{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/chipper/issues/239","labels_url":"https://api.github.com/repos/phetsims/chipper/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/chipper/issues/239/comments","events_url":"https://api.github.com/repos/phetsims/chipper/issues/239/events","html_url":"https://github.com/phetsims/chipper/issues/239","id":100133750,"number":239,"title":"improve error messages for unacceptable license entries","user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/chipper/labels/developer-meeting","name":"developer-meeting","color":"000000"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-10T18:13:09Z","updated_at":"2015-08-11T17:06:32Z","closed_at":null,"body":"Testing recent changes to media licensing, I noticed that the error message for \"unacceptable\" licensing are not very friendly.\r\n\r\nFor example... I changed `projectURL` for the first entry in beers-law-lab/images/license.json to something incompatible with PhET, like this:\r\n\r\n```js\r\n\"at-detector-probe.png\": {\r\n    \"text\": [\r\n      \"Copyright 2002-2015 University of Colorado Boulder\"\r\n    ],\r\n    \"projectURL\": \"BOGUS\",\r\n    \"license\": \"contact phethelp@colorado.edu\",\r\n    \"notes\": \"copied intensity_meter_probe.png from bending-light\"\r\n  },\r\n```\r\n\r\nHere's the messy/verbose error message that I get at build time:\r\n\r\n```\r\n% cd beers-law-lab\r\n% grunt --brand=phet`\r\n...\r\nRunning \"requirejs:build\" (requirejs) task\r\n>> Error: Error: Loader plugin did not call the load callback in the build:\r\n>> image:\r\n>>   image!BEERS_LAW_LAB/at-detector-probe.png: Error: problematic license entry\r\n>> Module loading did not complete for: beers-law-lab-main, BEERS_LAW_LAB/beerslaw/BeersLawScreen, BEERS_LAW_LAB/beerslaw/view/BeersLawView, BEERS_LAW_LAB/beerslaw/view/ATDetectorNode\r\n>>     at Function.build.checkForErrors (/Users/cmalley/PhET/GitHub/beers-law-lab/node_modules/requirejs/bin/r.js:28424:19)\r\nWarning: Task \"requirejs:build\" failed. Use --force to continue.\r\n\r\nAborted due to warnings.\r\n%\r\n```\r\n\r\nThe bit that's important is buried in there:\r\n\r\n```\r\nimage!BEERS_LAW_LAB/at-detector-probe.png: Error: problematic license entry\r\n```\r\n\r\nThe message should probably say \"unacceptable license entry\", since that's the terminology used in the source code, and since one has to resort to reading the source code to determine why it was unacceptable.\r\n"},"comment":{"url":"https://api.github.com/repos/phetsims/chipper/issues/comments/129970462","html_url":"https://github.com/phetsims/chipper/issues/239#issuecomment-129970462","issue_url":"https://api.github.com/repos/phetsims/chipper/issues/239","id":129970462,"user":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T17:06:32Z","updated_at":"2015-08-11T17:06:32Z","body":"Well, the docs do say you must pass in an Error instance."}}