{"action":"created","issue":{"url":"https://api.github.com/repos/gadgetron/gadgetron/issues/86","labels_url":"https://api.github.com/repos/gadgetron/gadgetron/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/gadgetron/gadgetron/issues/86/comments","events_url":"https://api.github.com/repos/gadgetron/gadgetron/issues/86/events","html_url":"https://github.com/gadgetron/gadgetron/pull/86","id":59294925,"number":86,"title":"For upstream","user":{"login":"mklassen","id":1391926,"avatar_url":"https://avatars.githubusercontent.com/u/1391926?v=3","gravatar_id":"","url":"https://api.github.com/users/mklassen","html_url":"https://github.com/mklassen","followers_url":"https://api.github.com/users/mklassen/followers","following_url":"https://api.github.com/users/mklassen/following{/other_user}","gists_url":"https://api.github.com/users/mklassen/gists{/gist_id}","starred_url":"https://api.github.com/users/mklassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklassen/subscriptions","organizations_url":"https://api.github.com/users/mklassen/orgs","repos_url":"https://api.github.com/users/mklassen/repos","events_url":"https://api.github.com/users/mklassen/events{/privacy}","received_events_url":"https://api.github.com/users/mklassen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-27T21:12:06Z","updated_at":"2015-02-27T21:29:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gadgetron/gadgetron/pulls/86","html_url":"https://github.com/gadgetron/gadgetron/pull/86","diff_url":"https://github.com/gadgetron/gadgetron/pull/86.diff","patch_url":"https://github.com/gadgetron/gadgetron/pull/86.patch"},"body":"Two sets of changes:\r\n 1. Changed toolboxes/gadgetrontools classes to by strings by ```const std::string &``` instead of ```std::string``` to save on making extra copies of potential large string variables.\r\n 1. Modifications to permit VB17 ICE to compile GadgetronConnector\r\n   1. MSVC++ 6 does not support variadic templates, so a macro was added to disable their usage in GadgetContainerMessage.\r\n   1. MSVC++ 6 does not support templated functions from which the template cannot be determined from the function arguments. Added a dummy argument to ```template <typename T> magic_number_for_type(T* = NULL)``` so that ```magic_number_for_type(reinterpret_cast<T *>(NULL))``` is used instead of using ```magic_number_for_type<T>()```.\r\n   1. Reduce the required dependencies of GadgetronConnector by splitting GadgetronMessageInterface.h into two files. The new GadgetronMessageReaderWriter.h contains only those parts required by GadgetronConnecter, thereby eliminating adding the Boost dependence of Gadget.h on which some of the other classes in GadgetronMessageInterface.h depend.\r\n"},"comment":{"url":"https://api.github.com/repos/gadgetron/gadgetron/issues/comments/76475065","html_url":"https://github.com/gadgetron/gadgetron/pull/86#issuecomment-76475065","issue_url":"https://api.github.com/repos/gadgetron/gadgetron/issues/86","id":76475065,"user":{"login":"hansenms","id":1149740,"avatar_url":"https://avatars.githubusercontent.com/u/1149740?v=3","gravatar_id":"","url":"https://api.github.com/users/hansenms","html_url":"https://github.com/hansenms","followers_url":"https://api.github.com/users/hansenms/followers","following_url":"https://api.github.com/users/hansenms/following{/other_user}","gists_url":"https://api.github.com/users/hansenms/gists{/gist_id}","starred_url":"https://api.github.com/users/hansenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansenms/subscriptions","organizations_url":"https://api.github.com/users/hansenms/orgs","repos_url":"https://api.github.com/users/hansenms/repos","events_url":"https://api.github.com/users/hansenms/events{/privacy}","received_events_url":"https://api.github.com/users/hansenms/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T21:29:08Z","updated_at":"2015-02-27T21:29:08Z","body":"I don't really like the idea of making modifications to the code to accomodate MSVC++ 6. It is not a compiler we support. The Gadgetron does not compile with this compiler. \r\n\r\nWe have an Ice program IceGadgetron that compiles with VB17, and is available from the IDEA board. I don't see the reason for making these modifications here. \r\n\r\nWhat are your thoughts here?\r\n"}}