{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/26576532","id":26576532,"diff_hunk":"@@ -64,7 +64,7 @@ let creedence_release_schema_major_vsn = 5\n let creedence_release_schema_minor_vsn = 72\n \n let cream_release_schema_major_vsn = 5\n-let cream_release_schema_minor_vsn = 72\n+let cream_release_schema_minor_vsn = 73\n \n let dundee_release_schema_major_vsn = 5\n let dundee_release_schema_minor_vsn = 83","path":"ocaml/idl/datamodel.ml","position":17,"original_position":17,"commit_id":"ba4819f4138a0722b82c53a4fdc7fa37f707b546","original_commit_id":"ba4819f4138a0722b82c53a4fdc7fa37f707b546","user":{"login":"thomassa","id":605052,"avatar_url":"https://avatars.githubusercontent.com/u/605052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomassa","html_url":"https://github.com/thomassa","followers_url":"https://api.github.com/users/thomassa/followers","following_url":"https://api.github.com/users/thomassa/following{/other_user}","gists_url":"https://api.github.com/users/thomassa/gists{/gist_id}","starred_url":"https://api.github.com/users/thomassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomassa/subscriptions","organizations_url":"https://api.github.com/users/thomassa/orgs","repos_url":"https://api.github.com/users/thomassa/repos","events_url":"https://api.github.com/users/thomassa/events{/privacy}","received_events_url":"https://api.github.com/users/thomassa/received_events","type":"User","site_admin":false},"body":"Should we set `dundee_release_schema_minor_vsn` equal to (or defined as) `schema_minor_vsn` or should that wait for now?","created_at":"2015-03-17T14:26:40Z","updated_at":"2015-03-17T14:26:40Z","html_url":"https://github.com/xapi-project/xen-api/pull/2180#discussion_r26576532","pull_request_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/26576532"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2180#discussion_r26576532"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180","id":30069690,"html_url":"https://github.com/xapi-project/xen-api/pull/2180","diff_url":"https://github.com/xapi-project/xen-api/pull/2180.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/2180.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2180","number":2180,"state":"open","locked":false,"title":"CP-11136 Virtual Hardware Platform Version (master)","user":{"login":"thomassa","id":605052,"avatar_url":"https://avatars.githubusercontent.com/u/605052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomassa","html_url":"https://github.com/thomassa","followers_url":"https://api.github.com/users/thomassa/followers","following_url":"https://api.github.com/users/thomassa/following{/other_user}","gists_url":"https://api.github.com/users/thomassa/gists{/gist_id}","starred_url":"https://api.github.com/users/thomassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomassa/subscriptions","organizations_url":"https://api.github.com/users/thomassa/orgs","repos_url":"https://api.github.com/users/thomassa/repos","events_url":"https://api.github.com/users/thomassa/events{/privacy}","received_events_url":"https://api.github.com/users/thomassa/received_events","type":"User","site_admin":false},"body":"This change requires changes in other repositories:\r\n\r\n* guest-templates needs to supply a value (initially `0L` by default) for the VM virtual hardware platform version when creating a VM. (This needs to be done immediately after the change to xen-api.) https://github.com/xenserver/guest-templates/\r\n\r\n* xen-api-sdk needs to cope with fields of type `Set(Int)`. That should be done before xen-api is changed, so I shall leave this pull-request closed until that has been done. (Done now.)\r\n\r\nThis change is essentially a forward-port of #2169.","created_at":"2015-02-26T11:27:06Z","updated_at":"2015-03-17T14:26:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"579475b2cd785b8160c44f6c8442df3b0c0fb89e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2180/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/ba4819f4138a0722b82c53a4fdc7fa37f707b546","head":{"label":"thomassa:tr-virt-plat-ver","ref":"tr-virt-plat-ver","sha":"ba4819f4138a0722b82c53a4fdc7fa37f707b546","user":{"login":"thomassa","id":605052,"avatar_url":"https://avatars.githubusercontent.com/u/605052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomassa","html_url":"https://github.com/thomassa","followers_url":"https://api.github.com/users/thomassa/followers","following_url":"https://api.github.com/users/thomassa/following{/other_user}","gists_url":"https://api.github.com/users/thomassa/gists{/gist_id}","starred_url":"https://api.github.com/users/thomassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomassa/subscriptions","organizations_url":"https://api.github.com/users/thomassa/orgs","repos_url":"https://api.github.com/users/thomassa/repos","events_url":"https://api.github.com/users/thomassa/events{/privacy}","received_events_url":"https://api.github.com/users/thomassa/received_events","type":"User","site_admin":false},"repo":{"id":6407153,"name":"xen-api","full_name":"thomassa/xen-api","owner":{"login":"thomassa","id":605052,"avatar_url":"https://avatars.githubusercontent.com/u/605052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomassa","html_url":"https://github.com/thomassa","followers_url":"https://api.github.com/users/thomassa/followers","following_url":"https://api.github.com/users/thomassa/following{/other_user}","gists_url":"https://api.github.com/users/thomassa/gists{/gist_id}","starred_url":"https://api.github.com/users/thomassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomassa/subscriptions","organizations_url":"https://api.github.com/users/thomassa/orgs","repos_url":"https://api.github.com/users/thomassa/repos","events_url":"https://api.github.com/users/thomassa/events{/privacy}","received_events_url":"https://api.github.com/users/thomassa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomassa/xen-api","description":"XCP xen-api","fork":true,"url":"https://api.github.com/repos/thomassa/xen-api","forks_url":"https://api.github.com/repos/thomassa/xen-api/forks","keys_url":"https://api.github.com/repos/thomassa/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomassa/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomassa/xen-api/teams","hooks_url":"https://api.github.com/repos/thomassa/xen-api/hooks","issue_events_url":"https://api.github.com/repos/thomassa/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/thomassa/xen-api/events","assignees_url":"https://api.github.com/repos/thomassa/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/thomassa/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/thomassa/xen-api/tags","blobs_url":"https://api.github.com/repos/thomassa/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomassa/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomassa/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomassa/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomassa/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/thomassa/xen-api/languages","stargazers_url":"https://api.github.com/repos/thomassa/xen-api/stargazers","contributors_url":"https://api.github.com/repos/thomassa/xen-api/contributors","subscribers_url":"https://api.github.com/repos/thomassa/xen-api/subscribers","subscription_url":"https://api.github.com/repos/thomassa/xen-api/subscription","commits_url":"https://api.github.com/repos/thomassa/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomassa/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomassa/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomassa/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomassa/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/thomassa/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomassa/xen-api/merges","archive_url":"https://api.github.com/repos/thomassa/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomassa/xen-api/downloads","issues_url":"https://api.github.com/repos/thomassa/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/thomassa/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/thomassa/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/thomassa/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomassa/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/thomassa/xen-api/releases{/id}","created_at":"2012-10-26T16:47:07Z","updated_at":"2015-02-10T11:26:32Z","pushed_at":"2015-03-17T14:00:44Z","git_url":"git://github.com/thomassa/xen-api.git","ssh_url":"git@github.com:thomassa/xen-api.git","clone_url":"https://github.com/thomassa/xen-api.git","svn_url":"https://github.com/thomassa/xen-api","homepage":"http://www.xen.org/products/cloudxen.html","size":23676,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"18180a15bb154bbc4f86285996674adb1cd0b63e","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","created_at":"2010-10-04T10:52:57Z","updated_at":"2015-03-17T11:20:48Z","pushed_at":"2015-03-17T11:20:48Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":37731,"stargazers_count":184,"watchers_count":184,"language":"Standard ML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":29,"forks":135,"open_issues":29,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2180"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2180"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2180/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2180/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/ba4819f4138a0722b82c53a4fdc7fa37f707b546"}}}}