{"action":"created","issue":{"url":"https://api.github.com/repos/JabRef/jabref/issues/249","labels_url":"https://api.github.com/repos/JabRef/jabref/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/249/comments","events_url":"https://api.github.com/repos/JabRef/jabref/issues/249/events","html_url":"https://github.com/JabRef/jabref/pull/249","id":112482380,"number":249,"title":"[WIP] Automatically generate eclipse settings","user":{"login":"koppor","id":1366654,"avatar_url":"https://avatars.githubusercontent.com/u/1366654?v=3","gravatar_id":"","url":"https://api.github.com/users/koppor","html_url":"https://github.com/koppor","followers_url":"https://api.github.com/users/koppor/followers","following_url":"https://api.github.com/users/koppor/following{/other_user}","gists_url":"https://api.github.com/users/koppor/gists{/gist_id}","starred_url":"https://api.github.com/users/koppor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppor/subscriptions","organizations_url":"https://api.github.com/users/koppor/orgs","repos_url":"https://api.github.com/users/koppor/repos","events_url":"https://api.github.com/users/koppor/events{/privacy}","received_events_url":"https://api.github.com/users/koppor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-20T23:40:19Z","updated_at":"2015-10-21T08:06:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/249","html_url":"https://github.com/JabRef/jabref/pull/249","diff_url":"https://github.com/JabRef/jabref/pull/249.diff","patch_url":"https://github.com/JabRef/jabref/pull/249.patch"},"body":"`gradlew eclipse` now generates formatter and save action settings.\r\n\r\nSince the default settings of Eclipse won't change in the near future (see [Eclipse bug 479928](https://bugs.eclipse.org/bugs/show_bug.cgi?id=479928)) and since it takes a few steps to configure Eclipse correctly, we try to create the required configurations\r\n\r\n* warnings,\r\n* formatter,\r\n* cleanup,\r\n* and save actions\r\n\r\nautomatically.\r\n\r\nFollowing minor issues remain:\r\n\r\n- [ ] When saving, Eclipse formats some lines. Not only the changed ones (as told) and not all (if configured to format all)\r\n- [ ] On Windows, the inserted lines are separated by `LF` and not `CRLF` as the part generated by gradle in `org.eclipse.jdt.core.prefs`. Works without issues in Eclipse, but causes difficulties in diffing with git.\r\n- [ ] When regenerating the config, the content is simply appended and not replaced. The user has to run `gradlew eclipseClean` manually\r\n- [ ] The `org.eclipse.jdt.core.pref` file is not sorted alphabetically: First come the gradle generated propreties and then our properties. This does not harm, but if a user changes a setting in eclipse. the file gets reordered. No drawbacks in the functionality, but hard to diff.\r\n\r\nI propose to reformat the whole source code using the new formatter settings (solves the last issue) in the near future and to ask all committers to regenerate their Eclipse config with the new gradle target.\r\n\r\nI tested the formatter with Eclipse Mars SR1 and JabRefPreferences. It looks good at first sight :smile_cat: "},"comment":{"url":"https://api.github.com/repos/JabRef/jabref/issues/comments/149810528","html_url":"https://github.com/JabRef/jabref/pull/249#issuecomment-149810528","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/249","id":149810528,"user":{"login":"simonharrer","id":375693,"avatar_url":"https://avatars.githubusercontent.com/u/375693?v=3","gravatar_id":"","url":"https://api.github.com/users/simonharrer","html_url":"https://github.com/simonharrer","followers_url":"https://api.github.com/users/simonharrer/followers","following_url":"https://api.github.com/users/simonharrer/following{/other_user}","gists_url":"https://api.github.com/users/simonharrer/gists{/gist_id}","starred_url":"https://api.github.com/users/simonharrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonharrer/subscriptions","organizations_url":"https://api.github.com/users/simonharrer/orgs","repos_url":"https://api.github.com/users/simonharrer/repos","events_url":"https://api.github.com/users/simonharrer/events{/privacy}","received_events_url":"https://api.github.com/users/simonharrer/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T08:06:11Z","updated_at":"2015-10-21T08:06:11Z","body":"I do not like that this is polluting the `build.gradle` file. Can you please put this in an `eclipse.gradle` file and just import it from the `build.gradle`?\r\n\r\nhttps://docs.gradle.org/current/userguide/userguide_single.html#sec%3aconfiguring_using_external_script"}}