{"action":"created","comment":{"url":"https://api.github.com/repos/minetest-technic/technic/pulls/comments/39517400","id":39517400,"diff_hunk":"@@ -200,129 +314,39 @@ local nodeboxes= {\n \tif zm==0 then\n \t\ttable.insert(nodeboxes, {-b,-b,-a, b,b,-b})\n \tend\n-\t\n-\tlocal nameext=tostring(xm)..tostring(xp)..tostring(ym)..tostring(yp)..tostring(zm)..tostring(zp)\n+\n+\tlocal nameext = tostring(xm)..tostring(xp)..tostring(ym)..tostring(yp)..tostring(zm)..tostring(zp)\n \tlocal groups = {snappy=2,choppy=2,oddly_breakable_by_hand=2}\n-\tif nameext~=\"111111\" then groups.not_in_creative_inventory=1 end\n-\t\n+\tif nameext ~= \"111111\" then\n+\t\tgroups.not_in_creative_inventory = 1\n+\tend\n+\n \n \tminetest.register_node(\"technic:frame_\"..nameext,{\n \t\tdescription = S(\"Frame\"),\n \t\ttiles = {\"technic_frame.png\"},\n-\t\tgroups=groups,\n+\t\tparamtype = \"light\",\n+\t\tsunlight_propagates = true,\n+\t\tframe = 1,\n+\t\tdrop = \"technic:frame_111111\",\n+\t\tselection_box = true,\n \t\tdrawtype = \"nodebox\",\n \t\tnode_box = {\n \t\t\ttype = \"fixed\",\n-\t\tfixed=nodeboxes,\n+\t\t\tfixed = nodeboxes,\n \t\t},\n-\t\tselection_box = {\n-\t\t\ttype=\"fixed\",\n-\t\t\tfixed={-0.5,-0.5,-0.5,0.5,0.5,0.5}\n-\t\t},\n-\t\tparamtype = \"light\",\n-\t\tframe=1,\n-\t\tdrop=\"technic:frame_111111\",\n-\t\tsunlight_propagates = true,\n-\t\tframe_connect_all=function(nodename)\n-\t\t\tl2={}\n-\t\t\tl1={{x=-1,y=0,z=0},{x=1,y=0,z=0},{x=0,y=-1,z=0},{x=0,y=1,z=0},{x=0,y=0,z=-1},{x=0,y=0,z=1}}\n-\t\t\tfor i,dir in ipairs(l1) do\n-\t\t\t\tif string.sub(nodename,-7+i,-7+i)==\"1\" then\n-\t\t\t\t\tl2[#(l2)+1]=dir\n-\t\t\t\tend\n-\t\t\tend\n-\t\t\treturn l2\n+\t\tgroups = groups,\n+\t\tframe_connect_all = function(nodename)\n+\t\t\treturn connect_frame(nodename)","path":"technic/machines/other/frames.lua","position":406,"original_position":406,"commit_id":"8eb266941da9b02ff4dce94bfb3f402f03c544ec","original_commit_id":"8eb266941da9b02ff4dce94bfb3f402f03c544ec","user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars.githubusercontent.com/u/3192173?v=3","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"body":"idk exactly how this works, if l just use that, the function becomes copied for every node and more memory is used, isn't it?","created_at":"2015-09-15T14:35:48Z","updated_at":"2015-09-15T14:35:48Z","html_url":"https://github.com/minetest-technic/technic/pull/249#discussion_r39517400","pull_request_url":"https://api.github.com/repos/minetest-technic/technic/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/minetest-technic/technic/pulls/comments/39517400"},"html":{"href":"https://github.com/minetest-technic/technic/pull/249#discussion_r39517400"},"pull_request":{"href":"https://api.github.com/repos/minetest-technic/technic/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/minetest-technic/technic/pulls/249","id":44852864,"html_url":"https://github.com/minetest-technic/technic/pull/249","diff_url":"https://github.com/minetest-technic/technic/pull/249.diff","patch_url":"https://github.com/minetest-technic/technic/pull/249.patch","issue_url":"https://api.github.com/repos/minetest-technic/technic/issues/249","number":249,"state":"open","locked":false,"title":"frames: use functions from vector.extras to improve speed, play sounds when digging their objects and fix #170","user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars.githubusercontent.com/u/3192173?v=3","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-12T12:52:15Z","updated_at":"2015-09-15T14:35:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa963f4adf180f0c9cdb288bada26381147bed8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest-technic/technic/pulls/249/commits","review_comments_url":"https://api.github.com/repos/minetest-technic/technic/pulls/249/comments","review_comment_url":"https://api.github.com/repos/minetest-technic/technic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest-technic/technic/issues/249/comments","statuses_url":"https://api.github.com/repos/minetest-technic/technic/statuses/8eb266941da9b02ff4dce94bfb3f402f03c544ec","head":{"label":"HybridDog:frames_fix","ref":"frames_fix","sha":"8eb266941da9b02ff4dce94bfb3f402f03c544ec","user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars.githubusercontent.com/u/3192173?v=3","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"repo":{"id":13910133,"name":"technic","full_name":"HybridDog/technic","owner":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars.githubusercontent.com/u/3192173?v=3","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HybridDog/technic","description":"Technic mod for Minetest","fork":true,"url":"https://api.github.com/repos/HybridDog/technic","forks_url":"https://api.github.com/repos/HybridDog/technic/forks","keys_url":"https://api.github.com/repos/HybridDog/technic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HybridDog/technic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HybridDog/technic/teams","hooks_url":"https://api.github.com/repos/HybridDog/technic/hooks","issue_events_url":"https://api.github.com/repos/HybridDog/technic/issues/events{/number}","events_url":"https://api.github.com/repos/HybridDog/technic/events","assignees_url":"https://api.github.com/repos/HybridDog/technic/assignees{/user}","branches_url":"https://api.github.com/repos/HybridDog/technic/branches{/branch}","tags_url":"https://api.github.com/repos/HybridDog/technic/tags","blobs_url":"https://api.github.com/repos/HybridDog/technic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HybridDog/technic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HybridDog/technic/git/refs{/sha}","trees_url":"https://api.github.com/repos/HybridDog/technic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HybridDog/technic/statuses/{sha}","languages_url":"https://api.github.com/repos/HybridDog/technic/languages","stargazers_url":"https://api.github.com/repos/HybridDog/technic/stargazers","contributors_url":"https://api.github.com/repos/HybridDog/technic/contributors","subscribers_url":"https://api.github.com/repos/HybridDog/technic/subscribers","subscription_url":"https://api.github.com/repos/HybridDog/technic/subscription","commits_url":"https://api.github.com/repos/HybridDog/technic/commits{/sha}","git_commits_url":"https://api.github.com/repos/HybridDog/technic/git/commits{/sha}","comments_url":"https://api.github.com/repos/HybridDog/technic/comments{/number}","issue_comment_url":"https://api.github.com/repos/HybridDog/technic/issues/comments{/number}","contents_url":"https://api.github.com/repos/HybridDog/technic/contents/{+path}","compare_url":"https://api.github.com/repos/HybridDog/technic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HybridDog/technic/merges","archive_url":"https://api.github.com/repos/HybridDog/technic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HybridDog/technic/downloads","issues_url":"https://api.github.com/repos/HybridDog/technic/issues{/number}","pulls_url":"https://api.github.com/repos/HybridDog/technic/pulls{/number}","milestones_url":"https://api.github.com/repos/HybridDog/technic/milestones{/number}","notifications_url":"https://api.github.com/repos/HybridDog/technic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HybridDog/technic/labels{/name}","releases_url":"https://api.github.com/repos/HybridDog/technic/releases{/id}","created_at":"2013-10-27T20:53:33Z","updated_at":"2014-09-05T15:58:24Z","pushed_at":"2015-09-12T12:51:40Z","git_url":"git://github.com/HybridDog/technic.git","ssh_url":"git@github.com:HybridDog/technic.git","clone_url":"https://github.com/HybridDog/technic.git","svn_url":"https://github.com/HybridDog/technic","homepage":null,"size":16503,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest-technic:master","ref":"master","sha":"54b6d9976cada36645ea573339d3683699a3dc90","user":{"login":"minetest-technic","id":5562347,"avatar_url":"https://avatars.githubusercontent.com/u/5562347?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest-technic","html_url":"https://github.com/minetest-technic","followers_url":"https://api.github.com/users/minetest-technic/followers","following_url":"https://api.github.com/users/minetest-technic/following{/other_user}","gists_url":"https://api.github.com/users/minetest-technic/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest-technic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest-technic/subscriptions","organizations_url":"https://api.github.com/users/minetest-technic/orgs","repos_url":"https://api.github.com/users/minetest-technic/repos","events_url":"https://api.github.com/users/minetest-technic/events{/privacy}","received_events_url":"https://api.github.com/users/minetest-technic/received_events","type":"Organization","site_admin":false},"repo":{"id":5490765,"name":"technic","full_name":"minetest-technic/technic","owner":{"login":"minetest-technic","id":5562347,"avatar_url":"https://avatars.githubusercontent.com/u/5562347?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest-technic","html_url":"https://github.com/minetest-technic","followers_url":"https://api.github.com/users/minetest-technic/followers","following_url":"https://api.github.com/users/minetest-technic/following{/other_user}","gists_url":"https://api.github.com/users/minetest-technic/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest-technic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest-technic/subscriptions","organizations_url":"https://api.github.com/users/minetest-technic/orgs","repos_url":"https://api.github.com/users/minetest-technic/repos","events_url":"https://api.github.com/users/minetest-technic/events{/privacy}","received_events_url":"https://api.github.com/users/minetest-technic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest-technic/technic","description":"Technic mod for Minetest","fork":false,"url":"https://api.github.com/repos/minetest-technic/technic","forks_url":"https://api.github.com/repos/minetest-technic/technic/forks","keys_url":"https://api.github.com/repos/minetest-technic/technic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest-technic/technic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest-technic/technic/teams","hooks_url":"https://api.github.com/repos/minetest-technic/technic/hooks","issue_events_url":"https://api.github.com/repos/minetest-technic/technic/issues/events{/number}","events_url":"https://api.github.com/repos/minetest-technic/technic/events","assignees_url":"https://api.github.com/repos/minetest-technic/technic/assignees{/user}","branches_url":"https://api.github.com/repos/minetest-technic/technic/branches{/branch}","tags_url":"https://api.github.com/repos/minetest-technic/technic/tags","blobs_url":"https://api.github.com/repos/minetest-technic/technic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest-technic/technic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest-technic/technic/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest-technic/technic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest-technic/technic/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest-technic/technic/languages","stargazers_url":"https://api.github.com/repos/minetest-technic/technic/stargazers","contributors_url":"https://api.github.com/repos/minetest-technic/technic/contributors","subscribers_url":"https://api.github.com/repos/minetest-technic/technic/subscribers","subscription_url":"https://api.github.com/repos/minetest-technic/technic/subscription","commits_url":"https://api.github.com/repos/minetest-technic/technic/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest-technic/technic/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest-technic/technic/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest-technic/technic/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest-technic/technic/contents/{+path}","compare_url":"https://api.github.com/repos/minetest-technic/technic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest-technic/technic/merges","archive_url":"https://api.github.com/repos/minetest-technic/technic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest-technic/technic/downloads","issues_url":"https://api.github.com/repos/minetest-technic/technic/issues{/number}","pulls_url":"https://api.github.com/repos/minetest-technic/technic/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest-technic/technic/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest-technic/technic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest-technic/technic/labels{/name}","releases_url":"https://api.github.com/repos/minetest-technic/technic/releases{/id}","created_at":"2012-08-21T05:17:09Z","updated_at":"2015-09-09T10:35:37Z","pushed_at":"2015-09-12T12:52:15Z","git_url":"git://github.com/minetest-technic/technic.git","ssh_url":"git@github.com:minetest-technic/technic.git","clone_url":"https://github.com/minetest-technic/technic.git","svn_url":"https://github.com/minetest-technic/technic","homepage":null,"size":19634,"stargazers_count":38,"watchers_count":38,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":26,"forks":53,"open_issues":26,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest-technic/technic/pulls/249"},"html":{"href":"https://github.com/minetest-technic/technic/pull/249"},"issue":{"href":"https://api.github.com/repos/minetest-technic/technic/issues/249"},"comments":{"href":"https://api.github.com/repos/minetest-technic/technic/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest-technic/technic/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest-technic/technic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest-technic/technic/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/minetest-technic/technic/statuses/8eb266941da9b02ff4dce94bfb3f402f03c544ec"}}}}