{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/45924564","id":45924564,"diff_hunk":"@@ -1,36 +1,10 @@\n <div class=\"cms-menu cms-panel cms-panel-layout west\" id=\"cms-menu\" data-layout-type=\"border\">\n \t<div class=\"cms-logo-header north\">","path":"admin/templates/Includes/LeftAndMain_Menu.ss","position":2,"original_position":2,"commit_id":"a24c7fe5b0c9ed448fb20302e9abac1643ed62b2","original_commit_id":"72fdc05e3bbaed7e338e1de73a62ed629a0e6f21","user":{"login":"stevie-mayhew","id":1953220,"avatar_url":"https://avatars.githubusercontent.com/u/1953220?v=3","gravatar_id":"","url":"https://api.github.com/users/stevie-mayhew","html_url":"https://github.com/stevie-mayhew","followers_url":"https://api.github.com/users/stevie-mayhew/followers","following_url":"https://api.github.com/users/stevie-mayhew/following{/other_user}","gists_url":"https://api.github.com/users/stevie-mayhew/gists{/gist_id}","starred_url":"https://api.github.com/users/stevie-mayhew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevie-mayhew/subscriptions","organizations_url":"https://api.github.com/users/stevie-mayhew/orgs","repos_url":"https://api.github.com/users/stevie-mayhew/repos","events_url":"https://api.github.com/users/stevie-mayhew/events{/privacy}","received_events_url":"https://api.github.com/users/stevie-mayhew/received_events","type":"User","site_admin":false},"body":"Yeah cool - ignore the above.\r\n\r\nAn example in the docs of the intended usage would be a good idea.","created_at":"2015-11-25T22:06:24Z","updated_at":"2015-11-25T22:06:24Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4795#discussion_r45924564","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/45924564"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4795#discussion_r45924564"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795","id":51848919,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4795","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4795.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4795.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4795","number":4795,"state":"open","locked":false,"title":"API refactor LeftAndMain_Menu.ss into individually overridable components","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"Since many modules override the main menu, it makes sense to cut down on code duplication (and maintenance) by splitting out re-usable components.\r\n\r\nFluent, translatable, and subsites, for instance, each add custom left hand menus.","created_at":"2015-11-25T21:38:47Z","updated_at":"2015-11-25T22:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a772d7c30f06bd8fef6ac8f0708c4b6e53061c7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4795/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/a24c7fe5b0c9ed448fb20302e9abac1643ed62b2","head":{"label":"tractorcow:pulls/4.0/menu-refactor","ref":"pulls/4.0/menu-refactor","sha":"a24c7fe5b0c9ed448fb20302e9abac1643ed62b2","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"repo":{"id":5337017,"name":"silverstripe-framework","full_name":"tractorcow/silverstripe-framework","owner":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tractorcow/silverstripe-framework","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/tractorcow/silverstripe-framework","forks_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/releases{/id}","created_at":"2012-08-08T04:07:21Z","updated_at":"2015-06-01T22:15:10Z","pushed_at":"2015-11-25T21:44:30Z","git_url":"git://github.com/tractorcow/silverstripe-framework.git","ssh_url":"git@github.com:tractorcow/silverstripe-framework.git","clone_url":"https://github.com/tractorcow/silverstripe-framework.git","svn_url":"https://github.com/tractorcow/silverstripe-framework","homepage":"http://silverstripe.org/","size":53598,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":0,"default_branch":"3.2"}},"base":{"label":"silverstripe:master","ref":"master","sha":"37957b7ee880e7eb957f7c1648a49b6ee93d04d5","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","created_at":"2011-02-02T02:04:13Z","updated_at":"2015-11-12T11:09:38Z","pushed_at":"2015-11-25T21:44:31Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":64471,"stargazers_count":471,"watchers_count":471,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":533,"mirror_url":null,"open_issues_count":646,"forks":533,"open_issues":646,"watchers":471,"default_branch":"3"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4795"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4795"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4795/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4795/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/a24c7fe5b0c9ed448fb20302e9abac1643ed62b2"}}}}