{"action":"created","comment":{"url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/comments/46461552","id":46461552,"diff_hunk":"@@ -63,139 +68,219 @@ Use `#pragma mark -` to categorize methods in functional groupings and protocol/\n ```\n \n ## Spacing\n+\n+### Indentation\n+* **Indent using 4 spaces. Never indent with tabs.** Be sure to set this preference in Xcode.\n+* Method braces and other braces (`if`/`else`/`switch`/`while` etc.) always open on the same line as the statement but close on a new line.\n+* One whitespace before the parenthesis, no space inside parenthesis\n+\n+**For example:**\n+\n+```objc\n+if (user.isHappy) {\n+    // Do something\n+}\n+else {\n+    // Do something else\n+}\n+```\n+### Line Break and Whitespace\n+* There should be exactly one blank line between methods to aid in visual clarity and organization.\n+* Whitespace within methods should be used to separate functionality (though often this can indicate an opportunity to split the method into several, smaller methods). In methods with long or verbose names, a single line of whitespace may be used to provide visual separation before the method’s body.\n+\n+**For example**\n+\n+```objc\n+- (void)initWithUser:(User *)newUser firstname:(NSString *)firstname lastname:(NSString *)lastname;\n+```\n+\n+* `@synthesize` and `@dynamic` should each be declared on new lines in the implementation.\n+\n+### Alignmnent\n+* Align \"=\" signs within the same code block\n+\n+\n ## Naming\n-## Properties\n-## Methods\n-## Variables\n-## Constants\n-## Enumeration Types\n-## Bitmasks\n-## Singletons\n-## Comments\n \n+Apple naming conventions should be adhered to wherever possible, especially those related to [memory management rules](https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/MemoryMgmt/Articles/MemoryMgmt.html) ([NARC](http://stackoverflow.com/a/2865194/340508)).\n \n-<!--## Dot Notation Syntax\n+Long, descriptive method and variable names are good.","path":"README.md","position":66,"original_position":66,"commit_id":"655803e0e448cf01f4ad6789bca3d53e4ac9c69b","original_commit_id":"655803e0e448cf01f4ad6789bca3d53e4ac9c69b","user":{"login":"halostatue","id":11361,"avatar_url":"https://avatars.githubusercontent.com/u/11361?v=3","gravatar_id":"","url":"https://api.github.com/users/halostatue","html_url":"https://github.com/halostatue","followers_url":"https://api.github.com/users/halostatue/followers","following_url":"https://api.github.com/users/halostatue/following{/other_user}","gists_url":"https://api.github.com/users/halostatue/gists{/gist_id}","starred_url":"https://api.github.com/users/halostatue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halostatue/subscriptions","organizations_url":"https://api.github.com/users/halostatue/orgs","repos_url":"https://api.github.com/users/halostatue/repos","events_url":"https://api.github.com/users/halostatue/events{/privacy}","received_events_url":"https://api.github.com/users/halostatue/received_events","type":"User","site_admin":false},"body":"I think that this is something where there are better guidelines for the length of names. The guideline that I’ve always used is that the length of a variable name should roughly correspond to how important it is and how long it lives.\r\n\r\nThus, `i` as an index counter in a loop is *perfect* because it has no life outside of a loop. A `Point` class would obviously have `x`, `y` (and `z`  if it’s in 3D space) because they are perfectly descriptive. A method name or variable name that is *excessively* long, however, benefits no one.","created_at":"2015-12-02T19:24:25Z","updated_at":"2015-12-02T19:24:25Z","html_url":"https://github.com/KineticCafe/objective-c-style-guide/pull/1#discussion_r46461552","pull_request_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/comments/46461552"},"html":{"href":"https://github.com/KineticCafe/objective-c-style-guide/pull/1#discussion_r46461552"},"pull_request":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1","id":52434198,"html_url":"https://github.com/KineticCafe/objective-c-style-guide/pull/1","diff_url":"https://github.com/KineticCafe/objective-c-style-guide/pull/1.diff","patch_url":"https://github.com/KineticCafe/objective-c-style-guide/pull/1.patch","issue_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/1","number":1,"state":"open","locked":false,"title":"Updates from the first style guide meeting","user":{"login":"blueils","id":881684,"avatar_url":"https://avatars.githubusercontent.com/u/881684?v=3","gravatar_id":"","url":"https://api.github.com/users/blueils","html_url":"https://github.com/blueils","followers_url":"https://api.github.com/users/blueils/followers","following_url":"https://api.github.com/users/blueils/following{/other_user}","gists_url":"https://api.github.com/users/blueils/gists{/gist_id}","starred_url":"https://api.github.com/users/blueils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueils/subscriptions","organizations_url":"https://api.github.com/users/blueils/orgs","repos_url":"https://api.github.com/users/blueils/repos","events_url":"https://api.github.com/users/blueils/events{/privacy}","received_events_url":"https://api.github.com/users/blueils/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-02T18:23:30Z","updated_at":"2015-12-02T19:24:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b034d8883929f6413ff0895418959cbb1ada9b8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1/commits","review_comments_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1/comments","review_comment_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/1/comments","statuses_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/statuses/655803e0e448cf01f4ad6789bca3d53e4ac9c69b","head":{"label":"KineticCafe:feature/first-meeting-notes","ref":"feature/first-meeting-notes","sha":"655803e0e448cf01f4ad6789bca3d53e4ac9c69b","user":{"login":"KineticCafe","id":11218112,"avatar_url":"https://avatars.githubusercontent.com/u/11218112?v=3","gravatar_id":"","url":"https://api.github.com/users/KineticCafe","html_url":"https://github.com/KineticCafe","followers_url":"https://api.github.com/users/KineticCafe/followers","following_url":"https://api.github.com/users/KineticCafe/following{/other_user}","gists_url":"https://api.github.com/users/KineticCafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticCafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticCafe/subscriptions","organizations_url":"https://api.github.com/users/KineticCafe/orgs","repos_url":"https://api.github.com/users/KineticCafe/repos","events_url":"https://api.github.com/users/KineticCafe/events{/privacy}","received_events_url":"https://api.github.com/users/KineticCafe/received_events","type":"Organization","site_admin":false},"repo":{"id":47263940,"name":"objective-c-style-guide","full_name":"KineticCafe/objective-c-style-guide","owner":{"login":"KineticCafe","id":11218112,"avatar_url":"https://avatars.githubusercontent.com/u/11218112?v=3","gravatar_id":"","url":"https://api.github.com/users/KineticCafe","html_url":"https://github.com/KineticCafe","followers_url":"https://api.github.com/users/KineticCafe/followers","following_url":"https://api.github.com/users/KineticCafe/following{/other_user}","gists_url":"https://api.github.com/users/KineticCafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticCafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticCafe/subscriptions","organizations_url":"https://api.github.com/users/KineticCafe/orgs","repos_url":"https://api.github.com/users/KineticCafe/repos","events_url":"https://api.github.com/users/KineticCafe/events{/privacy}","received_events_url":"https://api.github.com/users/KineticCafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KineticCafe/objective-c-style-guide","description":"The Objective-C Style Guide for Kinetic Cafe ","fork":true,"url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide","forks_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/forks","keys_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/teams","hooks_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/hooks","issue_events_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/events","assignees_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/tags","blobs_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/languages","stargazers_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/stargazers","contributors_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/contributors","subscribers_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/subscribers","subscription_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/subscription","commits_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/merges","archive_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/downloads","issues_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/releases{/id}","created_at":"2015-12-02T13:49:39Z","updated_at":"2015-12-02T13:50:49Z","pushed_at":"2015-12-02T18:23:30Z","git_url":"git://github.com/KineticCafe/objective-c-style-guide.git","ssh_url":"git@github.com:KineticCafe/objective-c-style-guide.git","clone_url":"https://github.com/KineticCafe/objective-c-style-guide.git","svn_url":"https://github.com/KineticCafe/objective-c-style-guide","homepage":"","size":238,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"KineticCafe:master","ref":"master","sha":"9f5a91089cd6122c33c4fb3a6bc3aeb16020e05c","user":{"login":"KineticCafe","id":11218112,"avatar_url":"https://avatars.githubusercontent.com/u/11218112?v=3","gravatar_id":"","url":"https://api.github.com/users/KineticCafe","html_url":"https://github.com/KineticCafe","followers_url":"https://api.github.com/users/KineticCafe/followers","following_url":"https://api.github.com/users/KineticCafe/following{/other_user}","gists_url":"https://api.github.com/users/KineticCafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticCafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticCafe/subscriptions","organizations_url":"https://api.github.com/users/KineticCafe/orgs","repos_url":"https://api.github.com/users/KineticCafe/repos","events_url":"https://api.github.com/users/KineticCafe/events{/privacy}","received_events_url":"https://api.github.com/users/KineticCafe/received_events","type":"Organization","site_admin":false},"repo":{"id":47263940,"name":"objective-c-style-guide","full_name":"KineticCafe/objective-c-style-guide","owner":{"login":"KineticCafe","id":11218112,"avatar_url":"https://avatars.githubusercontent.com/u/11218112?v=3","gravatar_id":"","url":"https://api.github.com/users/KineticCafe","html_url":"https://github.com/KineticCafe","followers_url":"https://api.github.com/users/KineticCafe/followers","following_url":"https://api.github.com/users/KineticCafe/following{/other_user}","gists_url":"https://api.github.com/users/KineticCafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticCafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticCafe/subscriptions","organizations_url":"https://api.github.com/users/KineticCafe/orgs","repos_url":"https://api.github.com/users/KineticCafe/repos","events_url":"https://api.github.com/users/KineticCafe/events{/privacy}","received_events_url":"https://api.github.com/users/KineticCafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KineticCafe/objective-c-style-guide","description":"The Objective-C Style Guide for Kinetic Cafe ","fork":true,"url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide","forks_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/forks","keys_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/teams","hooks_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/hooks","issue_events_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/events","assignees_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/tags","blobs_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/languages","stargazers_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/stargazers","contributors_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/contributors","subscribers_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/subscribers","subscription_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/subscription","commits_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/merges","archive_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/downloads","issues_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/releases{/id}","created_at":"2015-12-02T13:49:39Z","updated_at":"2015-12-02T13:50:49Z","pushed_at":"2015-12-02T18:23:30Z","git_url":"git://github.com/KineticCafe/objective-c-style-guide.git","ssh_url":"git@github.com:KineticCafe/objective-c-style-guide.git","clone_url":"https://github.com/KineticCafe/objective-c-style-guide.git","svn_url":"https://github.com/KineticCafe/objective-c-style-guide","homepage":"","size":238,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1"},"html":{"href":"https://github.com/KineticCafe/objective-c-style-guide/pull/1"},"issue":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/1"},"comments":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/KineticCafe/objective-c-style-guide/statuses/655803e0e448cf01f4ad6789bca3d53e4ac9c69b"}}}}