{"action":"created","comment":{"url":"https://api.github.com/repos/Flight/django-filer/pulls/comments/46258204","id":46258204,"diff_hunk":"@@ -1,150 +1,67 @@\n {% load i18n %}\n \n <section class=\"image-info\">\n-    <a class=\"image-info-close\"><span class=\"fa fa-times\"></span></a>\n-\n+    {% if original.original_filename %}\n     <div class=\"image-info-title\">\n-        holiday-foto.jpg\n-        <a href=\"#\" class=\"fa fa-pencil\"></a>\n+        {{ original.original_filename }}\n+        <a href=\"#\" class=\"icon fa fa-pencil\"></a>\n     </div>\n-\n-    <div class=\"image-preview-container\">\n-        <div class=\"image-preview js-focal-point\">\n-            <img src=\"http://lorempixel.com/210/266\" data-ratio=\"4.638095\" width=\"210\" height=\"266\" class=\"js-focal-point-image\">\n+    {% endif %}\n+    <div class=\"row\">\n+        <div class=\"col-sm-6\">\n+            <div class=\"image-preview-container\">\n+        <div class=\"image-preview js-focal-point\" data-location-selector=\"#id_subject_location\">\n+            <img src=\"{{ original.thumbnails.admin_sidebar_preview }}\" data-ratio=\"{{ adminform.form.sidebar_image_ratio }}\" class=\"js-focal-point-image\">\n             <div class=\"js-focal-point-circle image-preview-circle hidden\"></div>\n-            <input type=\"hidden\" class=\"js-focal-point-location\">\n         </div>\n \n-        <div class=\"text-right\">\n-            <a href=\"http://lorempixel.com/210/266\" target=\"_blank\" class=\"btn\">Full size preview</a>\n+        <div class=\"text-left\">\n+            <a href=\"{{ original.url }}\" target=\"_blank\" class=\"btn\">Full size preview</a>\n         </div>\n     </div>\n-\n-    <ul class=\"image-details\">\n-        <li class=\"row\">\n-            <div class=\"col-xs-4\">\n-                Type\n-            </div>\n-            <div class=\"col-xs-8\">\n-                Image\n-            </div>\n-        </li>\n-\n-        <li class=\"row\">\n-            <div class=\"col-xs-4\">\n-                Size\n-            </div>\n-            <div class=\"col-xs-8\">\n-                1765x1249 px\n-            </div>\n-        </li>\n-\n-        <li class=\"row\">\n-            <div class=\"col-xs-4\">\n-                File-size\n-            </div>\n-            <div class=\"col-xs-8\">\n-                2.3 MB\n-            </div>\n-        </li>\n-\n-        <li class=\"row\">\n-            <div class=\"col-xs-4\">\n-                Modified\n-            </div>\n-            <div class=\"col-xs-8\">\n-                25/10/2015 8:02 PM\n-            </div>\n-        </li>\n-\n-        <li class=\"row\">\n-            <div class=\"col-xs-4\">\n-                Created\n-            </div>\n-            <div class=\"col-xs-8\">\n-                25/10/2015 8:02 PM\n+        </div>\n+        <div class=\"col-sm-6\">\n+            {% if original.file_type or original.modified_at or original.uploaded_at %}\n+                <ul class=\"image-details\">\n+                    {% if original.file_type %}\n+                        <li class=\"row\">\n+                            <div class=\"col-xs-3\">Type</div>\n+                            <div class=\"col-xs-9\">{{ original.file_type }}</div>\n+                        </li>\n+                    {% endif %}\n+                        <li class=\"row\">\n+                            <div class=\"col-xs-3\">Size</div>\n+                            <div class=\"col-xs-9\">1765x1249 px</div>\n+                        </li>\n+                        <li class=\"row\">\n+                            <div class=\"col-xs-3\">File-size</div>\n+                            <div class=\"col-xs-9\">2.3 MB</div>\n+                        </li>\n+                    {% if original.modified_at %}\n+                        <li class=\"row\">\n+                            <div class=\"col-xs-3\">Modified</div>\n+                            <div class=\"col-xs-9\">{{ original.modified_at }}</div>\n+                        </li>\n+                    {% endif %}\n+                    {% if original.uploaded_at %}\n+                        <li class=\"row\">\n+                            <div class=\"col-xs-3\">Created</div>\n+                            <div class=\"col-xs-9\">{{ original.uploaded_at }}</div>\n+                        </li>\n+                    {% endif %}\n+                </ul>\n+            {% endif %}\n+            <div class=\"image-actions\">\n+                <ul class=\"actions-list\">\n+                    <li>\n+                        <a href=\"#\">","path":"filer/templates/admin/filer/tools/image_info.html","position":112,"original_position":112,"commit_id":"43404bb046c8f224681ee7d862b2ef1422364fbf","original_commit_id":"43404bb046c8f224681ee7d862b2ef1422364fbf","user":{"login":"vxsx","id":366813,"avatar_url":"https://avatars.githubusercontent.com/u/366813?v=3","gravatar_id":"","url":"https://api.github.com/users/vxsx","html_url":"https://github.com/vxsx","followers_url":"https://api.github.com/users/vxsx/followers","following_url":"https://api.github.com/users/vxsx/following{/other_user}","gists_url":"https://api.github.com/users/vxsx/gists{/gist_id}","starred_url":"https://api.github.com/users/vxsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vxsx/subscriptions","organizations_url":"https://api.github.com/users/vxsx/orgs","repos_url":"https://api.github.com/users/vxsx/repos","events_url":"https://api.github.com/users/vxsx/events{/privacy}","received_events_url":"https://api.github.com/users/vxsx/received_events","type":"User","site_admin":false},"body":"do you need a `js-` class here? or href?","created_at":"2015-12-01T09:50:33Z","updated_at":"2015-12-01T09:50:33Z","html_url":"https://github.com/Flight/django-filer/pull/13#discussion_r46258204","pull_request_url":"https://api.github.com/repos/Flight/django-filer/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/Flight/django-filer/pulls/comments/46258204"},"html":{"href":"https://github.com/Flight/django-filer/pull/13#discussion_r46258204"},"pull_request":{"href":"https://api.github.com/repos/Flight/django-filer/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/Flight/django-filer/pulls/13","id":52228774,"html_url":"https://github.com/Flight/django-filer/pull/13","diff_url":"https://github.com/Flight/django-filer/pull/13.diff","patch_url":"https://github.com/Flight/django-filer/pull/13.patch","issue_url":"https://api.github.com/repos/Flight/django-filer/issues/13","number":13,"state":"open","locked":false,"title":"implements and updates detail view","user":{"login":"lory87","id":2270884,"avatar_url":"https://avatars.githubusercontent.com/u/2270884?v=3","gravatar_id":"","url":"https://api.github.com/users/lory87","html_url":"https://github.com/lory87","followers_url":"https://api.github.com/users/lory87/followers","following_url":"https://api.github.com/users/lory87/following{/other_user}","gists_url":"https://api.github.com/users/lory87/gists{/gist_id}","starred_url":"https://api.github.com/users/lory87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lory87/subscriptions","organizations_url":"https://api.github.com/users/lory87/orgs","repos_url":"https://api.github.com/users/lory87/repos","events_url":"https://api.github.com/users/lory87/events{/privacy}","received_events_url":"https://api.github.com/users/lory87/received_events","type":"User","site_admin":false},"body":"**This pull request fixes the following issues**:\r\n\r\n- Image on the left (with focal point) and details on the right (box)\r\n- Followed by normal django fields\r\n- also consider file upload (not just image)\r\n\r\n- there are some template django variables missing. See screenshot. Will create a ticket for Kirill.\r\n![screen shot 2015-12-01 at 09 08 26](https://cloud.githubusercontent.com/assets/2270884/11497391/f6f17956-9818-11e5-98eb-cb539e6d8d40.png)\r\n\r\n\r\n|BEFORE|AFTER|\r\n|---|---|\r\n|![screen shot 2015-12-01 at 09 40 14](https://cloud.githubusercontent.com/assets/2270884/11496023/a335eef4-980f-11e5-89d7-27bc99f4b76c.png)|![screen shot 2015-12-01 at 09 39 54](https://cloud.githubusercontent.com/assets/2270884/11496166/6fa74320-9810-11e5-8d5f-8dc4dacf038b.png)|\r\n|![screen shot 2015-12-01 at 10 42 17](https://cloud.githubusercontent.com/assets/2270884/11497288/44a635de-9818-11e5-8ec0-9977d9cfb5c3.png)|![screen shot 2015-12-01 at 10 40 30](https://cloud.githubusercontent.com/assets/2270884/11497267/20f06ccc-9818-11e5-9e4e-3e6aae58e36d.png)|\r\n\r\n\r\n\r\n","created_at":"2015-12-01T08:30:12Z","updated_at":"2015-12-01T09:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aae5db885f9ff20eb3376a7a14e5ae7d636ed64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Flight/django-filer/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Flight/django-filer/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Flight/django-filer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Flight/django-filer/issues/13/comments","statuses_url":"https://api.github.com/repos/Flight/django-filer/statuses/43404bb046c8f224681ee7d862b2ef1422364fbf","head":{"label":"Flight:feature/detail-view","ref":"feature/detail-view","sha":"43404bb046c8f224681ee7d862b2ef1422364fbf","user":{"login":"Flight","id":306668,"avatar_url":"https://avatars.githubusercontent.com/u/306668?v=3","gravatar_id":"","url":"https://api.github.com/users/Flight","html_url":"https://github.com/Flight","followers_url":"https://api.github.com/users/Flight/followers","following_url":"https://api.github.com/users/Flight/following{/other_user}","gists_url":"https://api.github.com/users/Flight/gists{/gist_id}","starred_url":"https://api.github.com/users/Flight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flight/subscriptions","organizations_url":"https://api.github.com/users/Flight/orgs","repos_url":"https://api.github.com/users/Flight/repos","events_url":"https://api.github.com/users/Flight/events{/privacy}","received_events_url":"https://api.github.com/users/Flight/received_events","type":"User","site_admin":false},"repo":{"id":45904488,"name":"django-filer","full_name":"Flight/django-filer","owner":{"login":"Flight","id":306668,"avatar_url":"https://avatars.githubusercontent.com/u/306668?v=3","gravatar_id":"","url":"https://api.github.com/users/Flight","html_url":"https://github.com/Flight","followers_url":"https://api.github.com/users/Flight/followers","following_url":"https://api.github.com/users/Flight/following{/other_user}","gists_url":"https://api.github.com/users/Flight/gists{/gist_id}","starred_url":"https://api.github.com/users/Flight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flight/subscriptions","organizations_url":"https://api.github.com/users/Flight/orgs","repos_url":"https://api.github.com/users/Flight/repos","events_url":"https://api.github.com/users/Flight/events{/privacy}","received_events_url":"https://api.github.com/users/Flight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Flight/django-filer","description":"File and Image Management Application for django","fork":true,"url":"https://api.github.com/repos/Flight/django-filer","forks_url":"https://api.github.com/repos/Flight/django-filer/forks","keys_url":"https://api.github.com/repos/Flight/django-filer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flight/django-filer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flight/django-filer/teams","hooks_url":"https://api.github.com/repos/Flight/django-filer/hooks","issue_events_url":"https://api.github.com/repos/Flight/django-filer/issues/events{/number}","events_url":"https://api.github.com/repos/Flight/django-filer/events","assignees_url":"https://api.github.com/repos/Flight/django-filer/assignees{/user}","branches_url":"https://api.github.com/repos/Flight/django-filer/branches{/branch}","tags_url":"https://api.github.com/repos/Flight/django-filer/tags","blobs_url":"https://api.github.com/repos/Flight/django-filer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flight/django-filer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flight/django-filer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flight/django-filer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flight/django-filer/statuses/{sha}","languages_url":"https://api.github.com/repos/Flight/django-filer/languages","stargazers_url":"https://api.github.com/repos/Flight/django-filer/stargazers","contributors_url":"https://api.github.com/repos/Flight/django-filer/contributors","subscribers_url":"https://api.github.com/repos/Flight/django-filer/subscribers","subscription_url":"https://api.github.com/repos/Flight/django-filer/subscription","commits_url":"https://api.github.com/repos/Flight/django-filer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flight/django-filer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flight/django-filer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flight/django-filer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flight/django-filer/contents/{+path}","compare_url":"https://api.github.com/repos/Flight/django-filer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flight/django-filer/merges","archive_url":"https://api.github.com/repos/Flight/django-filer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flight/django-filer/downloads","issues_url":"https://api.github.com/repos/Flight/django-filer/issues{/number}","pulls_url":"https://api.github.com/repos/Flight/django-filer/pulls{/number}","milestones_url":"https://api.github.com/repos/Flight/django-filer/milestones{/number}","notifications_url":"https://api.github.com/repos/Flight/django-filer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flight/django-filer/labels{/name}","releases_url":"https://api.github.com/repos/Flight/django-filer/releases{/id}","created_at":"2015-11-10T10:23:24Z","updated_at":"2015-11-10T10:23:25Z","pushed_at":"2015-12-01T09:41:32Z","git_url":"git://github.com/Flight/django-filer.git","ssh_url":"git@github.com:Flight/django-filer.git","clone_url":"https://github.com/Flight/django-filer.git","svn_url":"https://github.com/Flight/django-filer","homepage":"https://github.com/stefanfoulis/django-filer/wiki","size":4920,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Flight:develop","ref":"develop","sha":"f1ee2cef22250bfc05fd1fc9b08dbcd5064487a3","user":{"login":"Flight","id":306668,"avatar_url":"https://avatars.githubusercontent.com/u/306668?v=3","gravatar_id":"","url":"https://api.github.com/users/Flight","html_url":"https://github.com/Flight","followers_url":"https://api.github.com/users/Flight/followers","following_url":"https://api.github.com/users/Flight/following{/other_user}","gists_url":"https://api.github.com/users/Flight/gists{/gist_id}","starred_url":"https://api.github.com/users/Flight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flight/subscriptions","organizations_url":"https://api.github.com/users/Flight/orgs","repos_url":"https://api.github.com/users/Flight/repos","events_url":"https://api.github.com/users/Flight/events{/privacy}","received_events_url":"https://api.github.com/users/Flight/received_events","type":"User","site_admin":false},"repo":{"id":45904488,"name":"django-filer","full_name":"Flight/django-filer","owner":{"login":"Flight","id":306668,"avatar_url":"https://avatars.githubusercontent.com/u/306668?v=3","gravatar_id":"","url":"https://api.github.com/users/Flight","html_url":"https://github.com/Flight","followers_url":"https://api.github.com/users/Flight/followers","following_url":"https://api.github.com/users/Flight/following{/other_user}","gists_url":"https://api.github.com/users/Flight/gists{/gist_id}","starred_url":"https://api.github.com/users/Flight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flight/subscriptions","organizations_url":"https://api.github.com/users/Flight/orgs","repos_url":"https://api.github.com/users/Flight/repos","events_url":"https://api.github.com/users/Flight/events{/privacy}","received_events_url":"https://api.github.com/users/Flight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Flight/django-filer","description":"File and Image Management Application for django","fork":true,"url":"https://api.github.com/repos/Flight/django-filer","forks_url":"https://api.github.com/repos/Flight/django-filer/forks","keys_url":"https://api.github.com/repos/Flight/django-filer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flight/django-filer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flight/django-filer/teams","hooks_url":"https://api.github.com/repos/Flight/django-filer/hooks","issue_events_url":"https://api.github.com/repos/Flight/django-filer/issues/events{/number}","events_url":"https://api.github.com/repos/Flight/django-filer/events","assignees_url":"https://api.github.com/repos/Flight/django-filer/assignees{/user}","branches_url":"https://api.github.com/repos/Flight/django-filer/branches{/branch}","tags_url":"https://api.github.com/repos/Flight/django-filer/tags","blobs_url":"https://api.github.com/repos/Flight/django-filer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flight/django-filer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flight/django-filer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flight/django-filer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flight/django-filer/statuses/{sha}","languages_url":"https://api.github.com/repos/Flight/django-filer/languages","stargazers_url":"https://api.github.com/repos/Flight/django-filer/stargazers","contributors_url":"https://api.github.com/repos/Flight/django-filer/contributors","subscribers_url":"https://api.github.com/repos/Flight/django-filer/subscribers","subscription_url":"https://api.github.com/repos/Flight/django-filer/subscription","commits_url":"https://api.github.com/repos/Flight/django-filer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flight/django-filer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flight/django-filer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flight/django-filer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flight/django-filer/contents/{+path}","compare_url":"https://api.github.com/repos/Flight/django-filer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flight/django-filer/merges","archive_url":"https://api.github.com/repos/Flight/django-filer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flight/django-filer/downloads","issues_url":"https://api.github.com/repos/Flight/django-filer/issues{/number}","pulls_url":"https://api.github.com/repos/Flight/django-filer/pulls{/number}","milestones_url":"https://api.github.com/repos/Flight/django-filer/milestones{/number}","notifications_url":"https://api.github.com/repos/Flight/django-filer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flight/django-filer/labels{/name}","releases_url":"https://api.github.com/repos/Flight/django-filer/releases{/id}","created_at":"2015-11-10T10:23:24Z","updated_at":"2015-11-10T10:23:25Z","pushed_at":"2015-12-01T09:41:32Z","git_url":"git://github.com/Flight/django-filer.git","ssh_url":"git@github.com:Flight/django-filer.git","clone_url":"https://github.com/Flight/django-filer.git","svn_url":"https://github.com/Flight/django-filer","homepage":"https://github.com/stefanfoulis/django-filer/wiki","size":4920,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Flight/django-filer/pulls/13"},"html":{"href":"https://github.com/Flight/django-filer/pull/13"},"issue":{"href":"https://api.github.com/repos/Flight/django-filer/issues/13"},"comments":{"href":"https://api.github.com/repos/Flight/django-filer/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Flight/django-filer/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Flight/django-filer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Flight/django-filer/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Flight/django-filer/statuses/43404bb046c8f224681ee7d862b2ef1422364fbf"}}}}