{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/46083787","id":46083787,"diff_hunk":"@@ -97,20 +106,18 @@ public void Tick(Actor self)\n \t\t\tadjacent = 0;\n \t\t\tforeach (var a in adjacentActors)\n \t\t\t{\n-\t\t\t\tvar rb = a.TraitOrDefault<WithWallSpriteBody>();\n-\t\t\t\tif (rb == null || rb.wallInfo.Type != wallInfo.Type)\n+\t\t\t\tCVec facing;\n+\t\t\t\tvar wc = a.TraitsImplementing<IWallConnector>().FirstOrDefault(b => b.IsTraitEnabled());","path":"OpenRA.Mods.Common/Traits/Render/WithWallSpriteBody.cs","position":37,"original_position":37,"commit_id":"e6552b8ed8edb375a9c531d9a541a9722868084f","original_commit_id":"e6552b8ed8edb375a9c531d9a541a9722868084f","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=3","gravatar_id":"","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"body":"This is an unnecessary lambda expression and the code usually uses `Where/FirstOrDefault/etc(Exts.IsTraitEnabled)`.\r\nWhen I add the `Trait` base class, I plan on adding `public static bool IsEnabled` so that `Exts.IsTraitEnabled` is replaced by `Trait.IsEnabled`.","created_at":"2015-11-28T20:05:14Z","updated_at":"2015-11-28T20:05:14Z","html_url":"https://github.com/OpenRA/OpenRA/pull/9981#discussion_r46083787","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/46083787"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9981#discussion_r46083787"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981","id":50635784,"html_url":"https://github.com/OpenRA/OpenRA/pull/9981","diff_url":"https://github.com/OpenRA/OpenRA/pull/9981.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/9981.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9981","number":9981,"state":"open","locked":false,"title":"Added gates to Tiberian Sun","user":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"body":"Reuses some code from #7888, reverted anything outside of Tiberian Sun.\r\n\r\nFixes #3196\r\n\r\nWorks by\r\n* Letting the pathfinder think there is no obstruction (for friendly gates)\r\n* Blocking movement for closed gates and opens via OnNotifyBlockingMove\r\n\r\nEDIT:\r\nImprovements for the future:\r\n* Locking\r\n* move `ITemporaryBlocker` and `ContainsTemporaryBlocker()` somewhere else\r\n* fix zoffset for gates\r\n* placing gates on existing walls\r\n\r\nMissing:\r\n* Implement IBlocker interface and block projectiles when not open","created_at":"2015-11-13T12:29:33Z","updated_at":"2015-11-28T20:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a84989802a2cbbcd1faa9fded14e671c6bdc1c3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9981/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/e6552b8ed8edb375a9c531d9a541a9722868084f","head":{"label":"teees:gates-trait","ref":"gates-trait","sha":"e6552b8ed8edb375a9c531d9a541a9722868084f","user":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"repo":{"id":44729148,"name":"OpenRA","full_name":"teees/OpenRA","owner":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teees/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/teees/OpenRA","forks_url":"https://api.github.com/repos/teees/OpenRA/forks","keys_url":"https://api.github.com/repos/teees/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teees/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teees/OpenRA/teams","hooks_url":"https://api.github.com/repos/teees/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/teees/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/teees/OpenRA/events","assignees_url":"https://api.github.com/repos/teees/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/teees/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/teees/OpenRA/tags","blobs_url":"https://api.github.com/repos/teees/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teees/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teees/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/teees/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teees/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/teees/OpenRA/languages","stargazers_url":"https://api.github.com/repos/teees/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/teees/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/teees/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/teees/OpenRA/subscription","commits_url":"https://api.github.com/repos/teees/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/teees/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/teees/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/teees/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/teees/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/teees/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teees/OpenRA/merges","archive_url":"https://api.github.com/repos/teees/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teees/OpenRA/downloads","issues_url":"https://api.github.com/repos/teees/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/teees/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/teees/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/teees/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teees/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/teees/OpenRA/releases{/id}","created_at":"2015-10-22T07:28:42Z","updated_at":"2015-10-22T07:28:54Z","pushed_at":"2015-11-27T16:48:42Z","git_url":"git://github.com/teees/OpenRA.git","ssh_url":"git@github.com:teees/OpenRA.git","clone_url":"https://github.com/teees/OpenRA.git","svn_url":"https://github.com/teees/OpenRA","homepage":"http://www.openra.net","size":97947,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"3e8df55bcb0ef88a11c8e150bcb0da36059a14cc","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-11-28T09:15:37Z","pushed_at":"2015-11-28T20:01:42Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":138978,"stargazers_count":2325,"watchers_count":2325,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":825,"mirror_url":null,"open_issues_count":928,"forks":825,"open_issues":928,"watchers":2325,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9981"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9981"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9981/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9981/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/e6552b8ed8edb375a9c531d9a541a9722868084f"}}}}