{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/account-fiscal-rule/issues/30","labels_url":"https://api.github.com/repos/OCA/account-fiscal-rule/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/OCA/account-fiscal-rule/issues/30/comments","events_url":"https://api.github.com/repos/OCA/account-fiscal-rule/issues/30/events","html_url":"https://github.com/OCA/account-fiscal-rule/pull/30","id":108493861,"number":30,"title":"Port account_fiscal_position_rule_stock to 8.0 continuation to #27","user":{"login":"danimaribeiro","id":854781,"avatar_url":"https://avatars.githubusercontent.com/u/854781?v=3","gravatar_id":"","url":"https://api.github.com/users/danimaribeiro","html_url":"https://github.com/danimaribeiro","followers_url":"https://api.github.com/users/danimaribeiro/followers","following_url":"https://api.github.com/users/danimaribeiro/following{/other_user}","gists_url":"https://api.github.com/users/danimaribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/danimaribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danimaribeiro/subscriptions","organizations_url":"https://api.github.com/users/danimaribeiro/orgs","repos_url":"https://api.github.com/users/danimaribeiro/repos","events_url":"https://api.github.com/users/danimaribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/danimaribeiro/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OCA/account-fiscal-rule/labels/needs%20review","name":"needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/OCA/account-fiscal-rule/milestones/1","html_url":"https://github.com/OCA/account-fiscal-rule/milestones/8.0","labels_url":"https://api.github.com/repos/OCA/account-fiscal-rule/milestones/1/labels","id":1228497,"number":1,"title":"8.0","description":null,"creator":{"login":"bwrsandman","id":1013356,"avatar_url":"https://avatars.githubusercontent.com/u/1013356?v=3","gravatar_id":"","url":"https://api.github.com/users/bwrsandman","html_url":"https://github.com/bwrsandman","followers_url":"https://api.github.com/users/bwrsandman/followers","following_url":"https://api.github.com/users/bwrsandman/following{/other_user}","gists_url":"https://api.github.com/users/bwrsandman/gists{/gist_id}","starred_url":"https://api.github.com/users/bwrsandman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwrsandman/subscriptions","organizations_url":"https://api.github.com/users/bwrsandman/orgs","repos_url":"https://api.github.com/users/bwrsandman/repos","events_url":"https://api.github.com/users/bwrsandman/events{/privacy}","received_events_url":"https://api.github.com/users/bwrsandman/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":7,"state":"open","created_at":"2015-07-28T00:20:20Z","updated_at":"2015-11-05T10:21:55Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2015-09-26T20:32:46Z","updated_at":"2015-11-05T18:14:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/account-fiscal-rule/pulls/30","html_url":"https://github.com/OCA/account-fiscal-rule/pull/30","diff_url":"https://github.com/OCA/account-fiscal-rule/pull/30.diff","patch_url":"https://github.com/OCA/account-fiscal-rule/pull/30.patch"},"body":"Continuation of this PR https://github.com/OCA/account-fiscal-rule/pull/27\r\nAdded some unit tests, added propagation of the fiscal position from the sale to picking.\r\n@bwrsandman \r\n\r\n@renatonlima and @mileo"},"comment":{"url":"https://api.github.com/repos/OCA/account-fiscal-rule/issues/comments/154142250","html_url":"https://github.com/OCA/account-fiscal-rule/pull/30#issuecomment-154142250","issue_url":"https://api.github.com/repos/OCA/account-fiscal-rule/issues/30","id":154142250,"user":{"login":"rvalyi","id":16926,"avatar_url":"https://avatars.githubusercontent.com/u/16926?v=3","gravatar_id":"","url":"https://api.github.com/users/rvalyi","html_url":"https://github.com/rvalyi","followers_url":"https://api.github.com/users/rvalyi/followers","following_url":"https://api.github.com/users/rvalyi/following{/other_user}","gists_url":"https://api.github.com/users/rvalyi/gists{/gist_id}","starred_url":"https://api.github.com/users/rvalyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvalyi/subscriptions","organizations_url":"https://api.github.com/users/rvalyi/orgs","repos_url":"https://api.github.com/users/rvalyi/repos","events_url":"https://api.github.com/users/rvalyi/events{/privacy}","received_events_url":"https://api.github.com/users/rvalyi/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T18:14:49Z","updated_at":"2015-11-05T18:14:49Z","body":"@danimaribeiro may be we can use this branch, I'm not sure. But you said \"I think the guys from Canada were also fed up waiting to some comments\". Which comments please? https://github.com/OCA/account-fiscal-rule/pull/17 and https://github.com/OCA/account-fiscal-rule/pull/21 had simply no review at all as far as I can see.\r\n\r\nAs for the errors we had in the Travis build in this repo, there appeared after a change in the OCA Travis management, they were not due to these branches (and BTW I fixed them because nobody fixed them during this period).\r\n\r\nSo for me Sandy should just have look in the existing PR's. They might not have been perfect at that time, but they were at least close. Anyway, I'll try to look at these two branches tomorrow."}}