{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/45599211","id":45599211,"diff_hunk":"@@ -53,105 +52,87 @@ class PaymentAcquirer(osv.Model):\n     _description = 'Payment Acquirer'\n     _order = 'sequence'\n \n-    def _get_providers(self, cr, uid, context=None):\n+    @api.model\n+    def _get_providers(self):\n         return []\n \n     # indirection to ease inheritance\n-    _provider_selection = lambda self, *args, **kwargs: self._get_providers(*args, **kwargs)\n-\n-    _columns = {\n-        'name': fields.char('Name', required=True, translate=True),\n-        'provider': fields.selection(_provider_selection, string='Provider', required=True),\n-        'company_id': fields.many2one('res.company', 'Company', required=True),\n-        'pre_msg': fields.html('Help Message', translate=True,\n-                               help='Message displayed to explain and help the payment process.'),\n-        'post_msg': fields.html('Thanks Message', help='Message displayed after having done the payment process.'),\n-        'view_template_id': fields.many2one('ir.ui.view', 'Form Button Template', required=True),\n-        'registration_view_template_id': fields.many2one('ir.ui.view', 'S2S Form Template',\n-                                                         domain=[('type', '=', 'qweb')],\n-                                                         help=\"Template for method registration\"),\n-        'environment': fields.selection(\n-            [('test', 'Test'), ('prod', 'Production')],\n-            string='Environment', oldname='env'),\n-        'website_published': fields.boolean(\n-            'Visible in Portal / Website', copy=False,\n-            help=\"Make this payment acquirer available (Customer invoices, etc.)\"),\n-        'auto_confirm': fields.selection(\n-            [('none', 'No automatic confirmation'),\n-             ('at_pay_confirm', 'At payment with acquirer confirmation'),\n-             ('at_pay_now', 'At payment no acquirer confirmation needed')],\n-            string='Order Confirmation', required=True),\n-        'pending_msg': fields.html('Pending Message', translate=True, help='Message displayed, if order is in pending state after having done the payment process.'),\n-        'done_msg': fields.html('Done Message', translate=True, help='Message displayed, if order is done successfully after having done the payment process.'),\n-        'cancel_msg': fields.html('Cancel Message', translate=True, help='Message displayed, if order is cancel during the payment process.'),\n-        'error_msg': fields.html('Error Message', translate=True, help='Message displayed, if error is occur during the payment process.'),\n-        # Fees\n-        'fees_active': fields.boolean('Add Extra Fees'),\n-        'fees_dom_fixed': fields.float('Fixed domestic fees'),\n-        'fees_dom_var': fields.float('Variable domestic fees (in percents)'),\n-        'fees_int_fixed': fields.float('Fixed international fees'),\n-        'fees_int_var': fields.float('Variable international fees (in percents)'),\n-        'sequence': fields.integer('Sequence', help=\"Determine the display order\"),\n-    }\n-\n-    image = openerp.fields.Binary(\"Image\", attachment=True,\n-        help=\"This field holds the image used for this provider, limited to 1024x1024px\")\n-    image_medium = openerp.fields.Binary(\"Medium-sized image\",\n-        compute='_compute_images', inverse='_inverse_image_medium', store=True, attachment=True,\n+    _provider_selection = lambda self: self._get_providers()\n+\n+    name = fields.Char(required=True, translate=True)\n+    provider = fields.Selection(_provider_selection, required=True)\n+    company_id = fields.Many2one('res.company', string='Company', default=lambda self: self.env.user.company_id, required=True)\n+    pre_msg = fields.Html(string='Help Message', translate=True, help='Message displayed to explain and help the payment process.')\n+    post_msg = fields.Html(string='Thanks Message', help='Message displayed after having done the payment process.')\n+    view_template_id = fields.Many2one('ir.ui.view', string='Form Button Template', required=True)\n+    registration_view_template_id = fields.Many2one('ir.ui.view', string='S2S Form Template', domain=[('type', '=', 'qweb')], help=\"Template for method registration\")\n+    environment = fields.Selection([('test', 'Test'), ('prod', 'Production')], oldname='env', default='prod')\n+    website_published = fields.Boolean(string='Visible in Portal / Website', copy=False, default=False, help=\"Make this payment acquirer available (Customer invoices, etc.)\")","path":"addons/payment/models/payment_acquirer.py","position":null,"original_position":93,"commit_id":"34a898013aa766350db4642dc5312aca02b817f7","original_commit_id":"1d0af0b478e3a5ee610a366768a7b811b1f7575a","user":{"login":"dbu-odoo","id":12182249,"avatar_url":"https://avatars.githubusercontent.com/u/12182249?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu-odoo","html_url":"https://github.com/dbu-odoo","followers_url":"https://api.github.com/users/dbu-odoo/followers","following_url":"https://api.github.com/users/dbu-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dbu-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu-odoo/subscriptions","organizations_url":"https://api.github.com/users/dbu-odoo/orgs","repos_url":"https://api.github.com/users/dbu-odoo/repos","events_url":"https://api.github.com/users/dbu-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dbu-odoo/received_events","type":"User","site_admin":false},"body":"Okay I have removed default=False here","created_at":"2015-11-23T12:46:45Z","updated_at":"2015-11-23T12:46:45Z","html_url":"https://github.com/odoo/odoo/pull/9591#discussion_r45599211","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/9591","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/45599211"},"html":{"href":"https://github.com/odoo/odoo/pull/9591#discussion_r45599211"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9591"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/9591","id":50905816,"html_url":"https://github.com/odoo/odoo/pull/9591","diff_url":"https://github.com/odoo/odoo/pull/9591.diff","patch_url":"https://github.com/odoo/odoo/pull/9591.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/9591","number":9591,"state":"open","locked":false,"title":"[payment] Migrate into new API","user":{"login":"dbu-odoo","id":12182249,"avatar_url":"https://avatars.githubusercontent.com/u/12182249?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu-odoo","html_url":"https://github.com/dbu-odoo","followers_url":"https://api.github.com/users/dbu-odoo/followers","following_url":"https://api.github.com/users/dbu-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dbu-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu-odoo/subscriptions","organizations_url":"https://api.github.com/users/dbu-odoo/orgs","repos_url":"https://api.github.com/users/dbu-odoo/repos","events_url":"https://api.github.com/users/dbu-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dbu-odoo/received_events","type":"User","site_admin":false},"body":"<strong>Task: </strong>https://www.odoo.com/web#id=13389&view_type=form&model=project.task&action=327\r\n<strong>Pad: </strong>https://pad.odoo.com/p/r.tJUQe47FRV5J27xH","created_at":"2015-11-17T05:24:28Z","updated_at":"2015-11-23T12:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f914a1301d58d38d08045087d5990c5a587b0cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/9591/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/9591/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/9591/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/34a898013aa766350db4642dc5312aca02b817f7","head":{"label":"odoo-dev:master-payment-newapi-dbu","ref":"master-payment-newapi-dbu","sha":"34a898013aa766350db4642dc5312aca02b817f7","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2015-11-23T04:22:05Z","pushed_at":"2015-11-23T12:46:13Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1128002,"stargazers_count":63,"watchers_count":63,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":0,"forks":27,"open_issues":0,"watchers":63,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"8de86e7c5cbede8f4ccbb0b8e77e05ac701876c9","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-11-23T09:37:35Z","pushed_at":"2015-11-23T12:42:12Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1203173,"stargazers_count":3429,"watchers_count":3429,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3108,"mirror_url":null,"open_issues_count":2870,"forks":3108,"open_issues":2870,"watchers":3429,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9591"},"html":{"href":"https://github.com/odoo/odoo/pull/9591"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/9591"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/9591/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9591/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9591/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/34a898013aa766350db4642dc5312aca02b817f7"}}}}