{"action":"opened","number":163,"pull_request":{"url":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/163","id":33183857,"html_url":"https://github.com/slackhq/SlackTextViewController/pull/163","diff_url":"https://github.com/slackhq/SlackTextViewController/pull/163.diff","patch_url":"https://github.com/slackhq/SlackTextViewController/pull/163.patch","issue_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/163","number":163,"state":"open","locked":false,"title":"Child view controller support","user":{"login":"dzenbot","id":590579,"avatar_url":"https://avatars.githubusercontent.com/u/590579?v=3","gravatar_id":"","url":"https://api.github.com/users/dzenbot","html_url":"https://github.com/dzenbot","followers_url":"https://api.github.com/users/dzenbot/followers","following_url":"https://api.github.com/users/dzenbot/following{/other_user}","gists_url":"https://api.github.com/users/dzenbot/gists{/gist_id}","starred_url":"https://api.github.com/users/dzenbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzenbot/subscriptions","organizations_url":"https://api.github.com/users/dzenbot/orgs","repos_url":"https://api.github.com/users/dzenbot/repos","events_url":"https://api.github.com/users/dzenbot/events{/privacy}","received_events_url":"https://api.github.com/users/dzenbot/received_events","type":"User","site_admin":false},"body":"*This was initially implemented by @pfleiner and PRed by @cameronehrlich. Thanks!*\r\n\r\nInstead of only allowing collection view controllers, the new implementation is more flexible, accepting table view controllers too. It could accept any view controller in the future, if they respond to selectors `tableView`, `collectionView` or `scrollView`, but this seems fine for now. \r\nA new target has also been added to the sample project, to be able to test it.\r\n\r\nOne thing to understand is that the child view controller's subviews aren't added to the view hierarchy, except for the scrollViewProxy. This is meant to decouple the implementation of the view controller's from `SlackTextViewController`.\r\n\r\n[Snapshot tests will be added soon, in this branch](https://github.com/slackhq/SlackTextViewController/tree/snapshot-tests).","created_at":"2015-04-13T17:19:01Z","updated_at":"2015-04-13T17:19:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/163/commits","review_comments_url":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/163/comments","review_comment_url":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/163/comments","statuses_url":"https://api.github.com/repos/slackhq/SlackTextViewController/statuses/43c4e08bc891c4720687d22fbdfc0fbefc517584","head":{"label":"slackhq:child-view-controller-support","ref":"child-view-controller-support","sha":"43c4e08bc891c4720687d22fbdfc0fbefc517584","user":{"login":"slackhq","id":6911160,"avatar_url":"https://avatars.githubusercontent.com/u/6911160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackhq","html_url":"https://github.com/slackhq","followers_url":"https://api.github.com/users/slackhq/followers","following_url":"https://api.github.com/users/slackhq/following{/other_user}","gists_url":"https://api.github.com/users/slackhq/gists{/gist_id}","starred_url":"https://api.github.com/users/slackhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackhq/subscriptions","organizations_url":"https://api.github.com/users/slackhq/orgs","repos_url":"https://api.github.com/users/slackhq/repos","events_url":"https://api.github.com/users/slackhq/events{/privacy}","received_events_url":"https://api.github.com/users/slackhq/received_events","type":"Organization","site_admin":false},"repo":{"id":23082332,"name":"SlackTextViewController","full_name":"slackhq/SlackTextViewController","owner":{"login":"slackhq","id":6911160,"avatar_url":"https://avatars.githubusercontent.com/u/6911160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackhq","html_url":"https://github.com/slackhq","followers_url":"https://api.github.com/users/slackhq/followers","following_url":"https://api.github.com/users/slackhq/following{/other_user}","gists_url":"https://api.github.com/users/slackhq/gists{/gist_id}","starred_url":"https://api.github.com/users/slackhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackhq/subscriptions","organizations_url":"https://api.github.com/users/slackhq/orgs","repos_url":"https://api.github.com/users/slackhq/repos","events_url":"https://api.github.com/users/slackhq/events{/privacy}","received_events_url":"https://api.github.com/users/slackhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slackhq/SlackTextViewController","description":"A drop-in UIViewController subclass with a growing text input view and other useful messaging features","fork":false,"url":"https://api.github.com/repos/slackhq/SlackTextViewController","forks_url":"https://api.github.com/repos/slackhq/SlackTextViewController/forks","keys_url":"https://api.github.com/repos/slackhq/SlackTextViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slackhq/SlackTextViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slackhq/SlackTextViewController/teams","hooks_url":"https://api.github.com/repos/slackhq/SlackTextViewController/hooks","issue_events_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/events{/number}","events_url":"https://api.github.com/repos/slackhq/SlackTextViewController/events","assignees_url":"https://api.github.com/repos/slackhq/SlackTextViewController/assignees{/user}","branches_url":"https://api.github.com/repos/slackhq/SlackTextViewController/branches{/branch}","tags_url":"https://api.github.com/repos/slackhq/SlackTextViewController/tags","blobs_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slackhq/SlackTextViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/slackhq/SlackTextViewController/languages","stargazers_url":"https://api.github.com/repos/slackhq/SlackTextViewController/stargazers","contributors_url":"https://api.github.com/repos/slackhq/SlackTextViewController/contributors","subscribers_url":"https://api.github.com/repos/slackhq/SlackTextViewController/subscribers","subscription_url":"https://api.github.com/repos/slackhq/SlackTextViewController/subscription","commits_url":"https://api.github.com/repos/slackhq/SlackTextViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/slackhq/SlackTextViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/comments{/number}","contents_url":"https://api.github.com/repos/slackhq/SlackTextViewController/contents/{+path}","compare_url":"https://api.github.com/repos/slackhq/SlackTextViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slackhq/SlackTextViewController/merges","archive_url":"https://api.github.com/repos/slackhq/SlackTextViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slackhq/SlackTextViewController/downloads","issues_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues{/number}","pulls_url":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/slackhq/SlackTextViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/slackhq/SlackTextViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slackhq/SlackTextViewController/labels{/name}","releases_url":"https://api.github.com/repos/slackhq/SlackTextViewController/releases{/id}","created_at":"2014-08-18T18:46:06Z","updated_at":"2015-04-13T16:49:34Z","pushed_at":"2015-04-13T17:10:41Z","git_url":"git://github.com/slackhq/SlackTextViewController.git","ssh_url":"git@github.com:slackhq/SlackTextViewController.git","clone_url":"https://github.com/slackhq/SlackTextViewController.git","svn_url":"https://github.com/slackhq/SlackTextViewController","homepage":"http://www.slack.com","size":10978,"stargazers_count":3226,"watchers_count":3226,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":15,"forks":235,"open_issues":15,"watchers":3226,"default_branch":"master"}},"base":{"label":"slackhq:master","ref":"master","sha":"dfe7fc157728d4b5e8f30dbb4bd44b47cd527c9e","user":{"login":"slackhq","id":6911160,"avatar_url":"https://avatars.githubusercontent.com/u/6911160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackhq","html_url":"https://github.com/slackhq","followers_url":"https://api.github.com/users/slackhq/followers","following_url":"https://api.github.com/users/slackhq/following{/other_user}","gists_url":"https://api.github.com/users/slackhq/gists{/gist_id}","starred_url":"https://api.github.com/users/slackhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackhq/subscriptions","organizations_url":"https://api.github.com/users/slackhq/orgs","repos_url":"https://api.github.com/users/slackhq/repos","events_url":"https://api.github.com/users/slackhq/events{/privacy}","received_events_url":"https://api.github.com/users/slackhq/received_events","type":"Organization","site_admin":false},"repo":{"id":23082332,"name":"SlackTextViewController","full_name":"slackhq/SlackTextViewController","owner":{"login":"slackhq","id":6911160,"avatar_url":"https://avatars.githubusercontent.com/u/6911160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackhq","html_url":"https://github.com/slackhq","followers_url":"https://api.github.com/users/slackhq/followers","following_url":"https://api.github.com/users/slackhq/following{/other_user}","gists_url":"https://api.github.com/users/slackhq/gists{/gist_id}","starred_url":"https://api.github.com/users/slackhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackhq/subscriptions","organizations_url":"https://api.github.com/users/slackhq/orgs","repos_url":"https://api.github.com/users/slackhq/repos","events_url":"https://api.github.com/users/slackhq/events{/privacy}","received_events_url":"https://api.github.com/users/slackhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slackhq/SlackTextViewController","description":"A drop-in UIViewController subclass with a growing text input view and other useful messaging features","fork":false,"url":"https://api.github.com/repos/slackhq/SlackTextViewController","forks_url":"https://api.github.com/repos/slackhq/SlackTextViewController/forks","keys_url":"https://api.github.com/repos/slackhq/SlackTextViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slackhq/SlackTextViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slackhq/SlackTextViewController/teams","hooks_url":"https://api.github.com/repos/slackhq/SlackTextViewController/hooks","issue_events_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/events{/number}","events_url":"https://api.github.com/repos/slackhq/SlackTextViewController/events","assignees_url":"https://api.github.com/repos/slackhq/SlackTextViewController/assignees{/user}","branches_url":"https://api.github.com/repos/slackhq/SlackTextViewController/branches{/branch}","tags_url":"https://api.github.com/repos/slackhq/SlackTextViewController/tags","blobs_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slackhq/SlackTextViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/slackhq/SlackTextViewController/languages","stargazers_url":"https://api.github.com/repos/slackhq/SlackTextViewController/stargazers","contributors_url":"https://api.github.com/repos/slackhq/SlackTextViewController/contributors","subscribers_url":"https://api.github.com/repos/slackhq/SlackTextViewController/subscribers","subscription_url":"https://api.github.com/repos/slackhq/SlackTextViewController/subscription","commits_url":"https://api.github.com/repos/slackhq/SlackTextViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/slackhq/SlackTextViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/slackhq/SlackTextViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/comments{/number}","contents_url":"https://api.github.com/repos/slackhq/SlackTextViewController/contents/{+path}","compare_url":"https://api.github.com/repos/slackhq/SlackTextViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slackhq/SlackTextViewController/merges","archive_url":"https://api.github.com/repos/slackhq/SlackTextViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slackhq/SlackTextViewController/downloads","issues_url":"https://api.github.com/repos/slackhq/SlackTextViewController/issues{/number}","pulls_url":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/slackhq/SlackTextViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/slackhq/SlackTextViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slackhq/SlackTextViewController/labels{/name}","releases_url":"https://api.github.com/repos/slackhq/SlackTextViewController/releases{/id}","created_at":"2014-08-18T18:46:06Z","updated_at":"2015-04-13T16:49:34Z","pushed_at":"2015-04-13T17:10:41Z","git_url":"git://github.com/slackhq/SlackTextViewController.git","ssh_url":"git@github.com:slackhq/SlackTextViewController.git","clone_url":"https://github.com/slackhq/SlackTextViewController.git","svn_url":"https://github.com/slackhq/SlackTextViewController","homepage":"http://www.slack.com","size":10978,"stargazers_count":3226,"watchers_count":3226,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":15,"forks":235,"open_issues":15,"watchers":3226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/163"},"html":{"href":"https://github.com/slackhq/SlackTextViewController/pull/163"},"issue":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/163"},"comments":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/slackhq/SlackTextViewController/statuses/43c4e08bc891c4720687d22fbdfc0fbefc517584"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":866,"deletions":473,"changed_files":65}}