{"action":"created","comment":{"url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments/31937142","id":31937142,"diff_hunk":"@@ -62,8 +62,44 @@ def setUp(self):\n             'COMPRESS_OFFLINE': True\n         }\n \n+        if django.VERSION >= (1, 8):\n+            override_settings['TEMPLATES'] = [\n+                {\n+                    \"BACKEND\": \"django.template.backends.django.DjangoTemplates\",\n+                    \"APP_DIRS\": True,\n+                    \"DIRS\": override_settings['TEMPLATE_DIRS'],\n+                },\n+            ]\n+\n         if \"jinja2\" in self.engines:\n-            override_settings[\"COMPRESS_JINJA2_GET_ENVIRONMENT\"] = lambda: self._get_jinja2_env()\n+            if django.VERSION < (1, 8):\n+                override_settings[\"COMPRESS_JINJA2_GET_ENVIRONMENT\"] = lambda: self._get_jinja2_env()\n+            else:\n+                override_settings['TEMPLATES'] += [","path":"compressor/tests/test_offline.py","position":18,"original_position":18,"commit_id":"041643654b276e87b360b449104c719e7de2c01c","original_commit_id":"041643654b276e87b360b449104c719e7de2c01c","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"deepcopy `settings['TEMPLATES']` before `self.settings()` is called, only changing `TEMPLATE_DIRS` inside your copy ?","created_at":"2015-06-08T17:15:35Z","updated_at":"2015-06-08T17:15:35Z","html_url":"https://github.com/django-compressor/django-compressor/pull/617#discussion_r31937142","pull_request_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments/31937142"},"html":{"href":"https://github.com/django-compressor/django-compressor/pull/617#discussion_r31937142"},"pull_request":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617","id":35572695,"html_url":"https://github.com/django-compressor/django-compressor/pull/617","diff_url":"https://github.com/django-compressor/django-compressor/pull/617.diff","patch_url":"https://github.com/django-compressor/django-compressor/pull/617.patch","issue_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/617","number":617,"state":"open","locked":false,"title":"Some template backends like jinja doesn't have `engine` attribute","user":{"login":"sodastsai","id":270913,"avatar_url":"https://avatars.githubusercontent.com/u/270913?v=3","gravatar_id":"","url":"https://api.github.com/users/sodastsai","html_url":"https://github.com/sodastsai","followers_url":"https://api.github.com/users/sodastsai/followers","following_url":"https://api.github.com/users/sodastsai/following{/other_user}","gists_url":"https://api.github.com/users/sodastsai/gists{/gist_id}","starred_url":"https://api.github.com/users/sodastsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sodastsai/subscriptions","organizations_url":"https://api.github.com/users/sodastsai/orgs","repos_url":"https://api.github.com/users/sodastsai/repos","events_url":"https://api.github.com/users/sodastsai/events{/privacy}","received_events_url":"https://api.github.com/users/sodastsai/received_events","type":"User","site_admin":false},"body":"So while doing offline compression, the command will crash.","created_at":"2015-05-16T15:28:30Z","updated_at":"2015-06-08T17:15:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"438c3aa0a8d5c1e910482c3218a634a90c75bb5f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617/commits","review_comments_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617/comments","review_comment_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/617/comments","statuses_url":"https://api.github.com/repos/django-compressor/django-compressor/statuses/041643654b276e87b360b449104c719e7de2c01c","head":{"label":"sodastsai:django-jinja-engine-fix","ref":"django-jinja-engine-fix","sha":"041643654b276e87b360b449104c719e7de2c01c","user":{"login":"sodastsai","id":270913,"avatar_url":"https://avatars.githubusercontent.com/u/270913?v=3","gravatar_id":"","url":"https://api.github.com/users/sodastsai","html_url":"https://github.com/sodastsai","followers_url":"https://api.github.com/users/sodastsai/followers","following_url":"https://api.github.com/users/sodastsai/following{/other_user}","gists_url":"https://api.github.com/users/sodastsai/gists{/gist_id}","starred_url":"https://api.github.com/users/sodastsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sodastsai/subscriptions","organizations_url":"https://api.github.com/users/sodastsai/orgs","repos_url":"https://api.github.com/users/sodastsai/repos","events_url":"https://api.github.com/users/sodastsai/events{/privacy}","received_events_url":"https://api.github.com/users/sodastsai/received_events","type":"User","site_admin":false},"repo":{"id":8867051,"name":"django-compressor","full_name":"sodastsai/django-compressor","owner":{"login":"sodastsai","id":270913,"avatar_url":"https://avatars.githubusercontent.com/u/270913?v=3","gravatar_id":"","url":"https://api.github.com/users/sodastsai","html_url":"https://github.com/sodastsai","followers_url":"https://api.github.com/users/sodastsai/followers","following_url":"https://api.github.com/users/sodastsai/following{/other_user}","gists_url":"https://api.github.com/users/sodastsai/gists{/gist_id}","starred_url":"https://api.github.com/users/sodastsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sodastsai/subscriptions","organizations_url":"https://api.github.com/users/sodastsai/orgs","repos_url":"https://api.github.com/users/sodastsai/repos","events_url":"https://api.github.com/users/sodastsai/events{/privacy}","received_events_url":"https://api.github.com/users/sodastsai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sodastsai/django-compressor","description":"Compresses linked and inline javascript or CSS into a single cached file.","fork":true,"url":"https://api.github.com/repos/sodastsai/django-compressor","forks_url":"https://api.github.com/repos/sodastsai/django-compressor/forks","keys_url":"https://api.github.com/repos/sodastsai/django-compressor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sodastsai/django-compressor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sodastsai/django-compressor/teams","hooks_url":"https://api.github.com/repos/sodastsai/django-compressor/hooks","issue_events_url":"https://api.github.com/repos/sodastsai/django-compressor/issues/events{/number}","events_url":"https://api.github.com/repos/sodastsai/django-compressor/events","assignees_url":"https://api.github.com/repos/sodastsai/django-compressor/assignees{/user}","branches_url":"https://api.github.com/repos/sodastsai/django-compressor/branches{/branch}","tags_url":"https://api.github.com/repos/sodastsai/django-compressor/tags","blobs_url":"https://api.github.com/repos/sodastsai/django-compressor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sodastsai/django-compressor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sodastsai/django-compressor/git/refs{/sha}","trees_url":"https://api.github.com/repos/sodastsai/django-compressor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sodastsai/django-compressor/statuses/{sha}","languages_url":"https://api.github.com/repos/sodastsai/django-compressor/languages","stargazers_url":"https://api.github.com/repos/sodastsai/django-compressor/stargazers","contributors_url":"https://api.github.com/repos/sodastsai/django-compressor/contributors","subscribers_url":"https://api.github.com/repos/sodastsai/django-compressor/subscribers","subscription_url":"https://api.github.com/repos/sodastsai/django-compressor/subscription","commits_url":"https://api.github.com/repos/sodastsai/django-compressor/commits{/sha}","git_commits_url":"https://api.github.com/repos/sodastsai/django-compressor/git/commits{/sha}","comments_url":"https://api.github.com/repos/sodastsai/django-compressor/comments{/number}","issue_comment_url":"https://api.github.com/repos/sodastsai/django-compressor/issues/comments{/number}","contents_url":"https://api.github.com/repos/sodastsai/django-compressor/contents/{+path}","compare_url":"https://api.github.com/repos/sodastsai/django-compressor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sodastsai/django-compressor/merges","archive_url":"https://api.github.com/repos/sodastsai/django-compressor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sodastsai/django-compressor/downloads","issues_url":"https://api.github.com/repos/sodastsai/django-compressor/issues{/number}","pulls_url":"https://api.github.com/repos/sodastsai/django-compressor/pulls{/number}","milestones_url":"https://api.github.com/repos/sodastsai/django-compressor/milestones{/number}","notifications_url":"https://api.github.com/repos/sodastsai/django-compressor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sodastsai/django-compressor/labels{/name}","releases_url":"https://api.github.com/repos/sodastsai/django-compressor/releases{/id}","created_at":"2013-03-19T00:00:14Z","updated_at":"2015-05-16T14:50:36Z","pushed_at":"2015-06-08T07:26:14Z","git_url":"git://github.com/sodastsai/django-compressor.git","ssh_url":"git@github.com:sodastsai/django-compressor.git","clone_url":"https://github.com/sodastsai/django-compressor.git","svn_url":"https://github.com/sodastsai/django-compressor","homepage":"http://django_compressor.rtfd.org/","size":1731,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"django-compressor:develop","ref":"develop","sha":"60ada6988047e2257b3f74af340f3944c4959367","user":{"login":"django-compressor","id":6460407,"avatar_url":"https://avatars.githubusercontent.com/u/6460407?v=3","gravatar_id":"","url":"https://api.github.com/users/django-compressor","html_url":"https://github.com/django-compressor","followers_url":"https://api.github.com/users/django-compressor/followers","following_url":"https://api.github.com/users/django-compressor/following{/other_user}","gists_url":"https://api.github.com/users/django-compressor/gists{/gist_id}","starred_url":"https://api.github.com/users/django-compressor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-compressor/subscriptions","organizations_url":"https://api.github.com/users/django-compressor/orgs","repos_url":"https://api.github.com/users/django-compressor/repos","events_url":"https://api.github.com/users/django-compressor/events{/privacy}","received_events_url":"https://api.github.com/users/django-compressor/received_events","type":"Organization","site_admin":false},"repo":{"id":504028,"name":"django-compressor","full_name":"django-compressor/django-compressor","owner":{"login":"django-compressor","id":6460407,"avatar_url":"https://avatars.githubusercontent.com/u/6460407?v=3","gravatar_id":"","url":"https://api.github.com/users/django-compressor","html_url":"https://github.com/django-compressor","followers_url":"https://api.github.com/users/django-compressor/followers","following_url":"https://api.github.com/users/django-compressor/following{/other_user}","gists_url":"https://api.github.com/users/django-compressor/gists{/gist_id}","starred_url":"https://api.github.com/users/django-compressor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-compressor/subscriptions","organizations_url":"https://api.github.com/users/django-compressor/orgs","repos_url":"https://api.github.com/users/django-compressor/repos","events_url":"https://api.github.com/users/django-compressor/events{/privacy}","received_events_url":"https://api.github.com/users/django-compressor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django-compressor/django-compressor","description":"Compresses linked and inline javascript or CSS into a single cached file.","fork":false,"url":"https://api.github.com/repos/django-compressor/django-compressor","forks_url":"https://api.github.com/repos/django-compressor/django-compressor/forks","keys_url":"https://api.github.com/repos/django-compressor/django-compressor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django-compressor/django-compressor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django-compressor/django-compressor/teams","hooks_url":"https://api.github.com/repos/django-compressor/django-compressor/hooks","issue_events_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/events{/number}","events_url":"https://api.github.com/repos/django-compressor/django-compressor/events","assignees_url":"https://api.github.com/repos/django-compressor/django-compressor/assignees{/user}","branches_url":"https://api.github.com/repos/django-compressor/django-compressor/branches{/branch}","tags_url":"https://api.github.com/repos/django-compressor/django-compressor/tags","blobs_url":"https://api.github.com/repos/django-compressor/django-compressor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django-compressor/django-compressor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django-compressor/django-compressor/git/refs{/sha}","trees_url":"https://api.github.com/repos/django-compressor/django-compressor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django-compressor/django-compressor/statuses/{sha}","languages_url":"https://api.github.com/repos/django-compressor/django-compressor/languages","stargazers_url":"https://api.github.com/repos/django-compressor/django-compressor/stargazers","contributors_url":"https://api.github.com/repos/django-compressor/django-compressor/contributors","subscribers_url":"https://api.github.com/repos/django-compressor/django-compressor/subscribers","subscription_url":"https://api.github.com/repos/django-compressor/django-compressor/subscription","commits_url":"https://api.github.com/repos/django-compressor/django-compressor/commits{/sha}","git_commits_url":"https://api.github.com/repos/django-compressor/django-compressor/git/commits{/sha}","comments_url":"https://api.github.com/repos/django-compressor/django-compressor/comments{/number}","issue_comment_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/comments{/number}","contents_url":"https://api.github.com/repos/django-compressor/django-compressor/contents/{+path}","compare_url":"https://api.github.com/repos/django-compressor/django-compressor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django-compressor/django-compressor/merges","archive_url":"https://api.github.com/repos/django-compressor/django-compressor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django-compressor/django-compressor/downloads","issues_url":"https://api.github.com/repos/django-compressor/django-compressor/issues{/number}","pulls_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls{/number}","milestones_url":"https://api.github.com/repos/django-compressor/django-compressor/milestones{/number}","notifications_url":"https://api.github.com/repos/django-compressor/django-compressor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django-compressor/django-compressor/labels{/name}","releases_url":"https://api.github.com/repos/django-compressor/django-compressor/releases{/id}","created_at":"2010-02-05T15:48:14Z","updated_at":"2015-06-06T15:04:50Z","pushed_at":"2015-06-08T07:08:04Z","git_url":"git://github.com/django-compressor/django-compressor.git","ssh_url":"git@github.com:django-compressor/django-compressor.git","clone_url":"https://github.com/django-compressor/django-compressor.git","svn_url":"https://github.com/django-compressor/django-compressor","homepage":"http://django-compressor.readthedocs.org/","size":11441,"stargazers_count":1491,"watchers_count":1491,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":413,"mirror_url":null,"open_issues_count":150,"forks":413,"open_issues":150,"watchers":1491,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617"},"html":{"href":"https://github.com/django-compressor/django-compressor/pull/617"},"issue":{"href":"https://api.github.com/repos/django-compressor/django-compressor/issues/617"},"comments":{"href":"https://api.github.com/repos/django-compressor/django-compressor/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/django-compressor/django-compressor/statuses/041643654b276e87b360b449104c719e7de2c01c"}}}}