{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/33988271","id":33988271,"diff_hunk":"@@ -93,6 +93,7 @@ ManagedIterator::~ManagedIterator() {\n     snapshot_created_ = false;\n     read_options_.snapshot = nullptr;\n   }\n+  UnLock();","path":"db/managed_iterator.cc","position":4,"original_position":4,"commit_id":"e25ee32e3d7e8ddcb28f1466e67f5ff930450b57","original_commit_id":"e25ee32e3d7e8ddcb28f1466e67f5ff930450b57","user":{"login":"siying","id":5334567,"avatar_url":"https://avatars.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"body":"Oh it is a bug then. Great.","created_at":"2015-07-06T22:09:05Z","updated_at":"2015-07-06T22:09:05Z","html_url":"https://github.com/facebook/rocksdb/pull/646#discussion_r33988271","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/646","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/33988271"},"html":{"href":"https://github.com/facebook/rocksdb/pull/646#discussion_r33988271"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/646"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/646","id":39035533,"html_url":"https://github.com/facebook/rocksdb/pull/646","diff_url":"https://github.com/facebook/rocksdb/pull/646.diff","patch_url":"https://github.com/facebook/rocksdb/pull/646.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/646","number":646,"state":"open","locked":false,"title":"Windows Port from Microsoft","user":{"login":"yuslepukhin","id":11303988,"avatar_url":"https://avatars.githubusercontent.com/u/11303988?v=3","gravatar_id":"","url":"https://api.github.com/users/yuslepukhin","html_url":"https://github.com/yuslepukhin","followers_url":"https://api.github.com/users/yuslepukhin/followers","following_url":"https://api.github.com/users/yuslepukhin/following{/other_user}","gists_url":"https://api.github.com/users/yuslepukhin/gists{/gist_id}","starred_url":"https://api.github.com/users/yuslepukhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuslepukhin/subscriptions","organizations_url":"https://api.github.com/users/yuslepukhin/orgs","repos_url":"https://api.github.com/users/yuslepukhin/repos","events_url":"https://api.github.com/users/yuslepukhin/events{/privacy}","received_events_url":"https://api.github.com/users/yuslepukhin/received_events","type":"User","site_admin":false},"body":" Summary: Make RocksDb build and run on Windows to be functionally\r\n complete and performant. All existing test cases run with no\r\n regressions. Performance numbers are in the pull-request.\r\n\r\n Test plan: make all of the existing unit tests pass, obtain perf numbers.\r\n\r\n Co-authored-by: Praveen Rao praveensinghrao@outlook.com\r\n Co-authored-by: Sherlock Huang baihan.huang@gmail.com\r\n Co-authored-by: Alex Zinoviev alexander.zinoviev@me.com\r\n Co-authored-by: Dmitri Smirnov dmitrism@microsoft.com","created_at":"2015-07-01T23:29:30Z","updated_at":"2015-07-06T22:09:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3887eaea9e97ee48e02dd67f9e321fa04fa5055","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/646/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/646/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/646/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/e25ee32e3d7e8ddcb28f1466e67f5ff930450b57","head":{"label":"yuslepukhin:ms_win_port","ref":"ms_win_port","sha":"e25ee32e3d7e8ddcb28f1466e67f5ff930450b57","user":{"login":"yuslepukhin","id":11303988,"avatar_url":"https://avatars.githubusercontent.com/u/11303988?v=3","gravatar_id":"","url":"https://api.github.com/users/yuslepukhin","html_url":"https://github.com/yuslepukhin","followers_url":"https://api.github.com/users/yuslepukhin/followers","following_url":"https://api.github.com/users/yuslepukhin/following{/other_user}","gists_url":"https://api.github.com/users/yuslepukhin/gists{/gist_id}","starred_url":"https://api.github.com/users/yuslepukhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuslepukhin/subscriptions","organizations_url":"https://api.github.com/users/yuslepukhin/orgs","repos_url":"https://api.github.com/users/yuslepukhin/repos","events_url":"https://api.github.com/users/yuslepukhin/events{/privacy}","received_events_url":"https://api.github.com/users/yuslepukhin/received_events","type":"User","site_admin":false},"repo":{"id":38400273,"name":"rocksdb","full_name":"yuslepukhin/rocksdb","owner":{"login":"yuslepukhin","id":11303988,"avatar_url":"https://avatars.githubusercontent.com/u/11303988?v=3","gravatar_id":"","url":"https://api.github.com/users/yuslepukhin","html_url":"https://github.com/yuslepukhin","followers_url":"https://api.github.com/users/yuslepukhin/followers","following_url":"https://api.github.com/users/yuslepukhin/following{/other_user}","gists_url":"https://api.github.com/users/yuslepukhin/gists{/gist_id}","starred_url":"https://api.github.com/users/yuslepukhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuslepukhin/subscriptions","organizations_url":"https://api.github.com/users/yuslepukhin/orgs","repos_url":"https://api.github.com/users/yuslepukhin/repos","events_url":"https://api.github.com/users/yuslepukhin/events{/privacy}","received_events_url":"https://api.github.com/users/yuslepukhin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuslepukhin/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/yuslepukhin/rocksdb","forks_url":"https://api.github.com/repos/yuslepukhin/rocksdb/forks","keys_url":"https://api.github.com/repos/yuslepukhin/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuslepukhin/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuslepukhin/rocksdb/teams","hooks_url":"https://api.github.com/repos/yuslepukhin/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/yuslepukhin/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/yuslepukhin/rocksdb/events","assignees_url":"https://api.github.com/repos/yuslepukhin/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/yuslepukhin/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/yuslepukhin/rocksdb/tags","blobs_url":"https://api.github.com/repos/yuslepukhin/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuslepukhin/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuslepukhin/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuslepukhin/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuslepukhin/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/yuslepukhin/rocksdb/languages","stargazers_url":"https://api.github.com/repos/yuslepukhin/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/yuslepukhin/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/yuslepukhin/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/yuslepukhin/rocksdb/subscription","commits_url":"https://api.github.com/repos/yuslepukhin/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuslepukhin/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuslepukhin/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuslepukhin/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuslepukhin/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/yuslepukhin/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuslepukhin/rocksdb/merges","archive_url":"https://api.github.com/repos/yuslepukhin/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuslepukhin/rocksdb/downloads","issues_url":"https://api.github.com/repos/yuslepukhin/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/yuslepukhin/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/yuslepukhin/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/yuslepukhin/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuslepukhin/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/yuslepukhin/rocksdb/releases{/id}","created_at":"2015-07-01T23:25:51Z","updated_at":"2015-07-05T11:11:14Z","pushed_at":"2015-07-03T00:41:22Z","git_url":"git://github.com/yuslepukhin/rocksdb.git","ssh_url":"git@github.com:yuslepukhin/rocksdb.git","clone_url":"https://github.com/yuslepukhin/rocksdb.git","svn_url":"https://github.com/yuslepukhin/rocksdb","homepage":"http://rocksdb.org","size":47937,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"e70115e71b74e6cce9484fcf2ded7ecb2d77ece3","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","created_at":"2012-11-30T06:16:18Z","updated_at":"2015-07-06T17:45:12Z","pushed_at":"2015-07-06T18:14:10Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":63666,"stargazers_count":3710,"watchers_count":3710,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":701,"mirror_url":null,"open_issues_count":84,"forks":701,"open_issues":84,"watchers":3710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/646"},"html":{"href":"https://github.com/facebook/rocksdb/pull/646"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/646"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/e25ee32e3d7e8ddcb28f1466e67f5ff930450b57"}}}}