{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/26105780","id":26105780,"diff_hunk":"@@ -0,0 +1,58 @@\n+///<reference path=\"../../reference.ts\" />\n+\n+module Plottable {\n+export module Plot {\n+  export class Rectangle<X, Y> extends AbstractXYPlot<X, Y> {\n+\n+    /**\n+     * Constructs a RectanglePlot.\n+     *\n+     * A RectanglePlot consists of a bunch of rectangles. The user is required to\n+     * project the left and right bounds of the rectangle (x1 and x2 respectively)\n+     * as well as the bottom and top bounds (y1 and y2 respectively)\n+     *\n+     * @constructor\n+     * @param {Scale.AbstractScale} xScale The x scale to use.\n+     * @param {Scale.AbstractScale} yScale The y scale to use.\n+     */\n+    constructor(xScale: Scale.AbstractScale<X, any>, yScale: Scale.AbstractScale<Y, any>) {\n+      super(xScale, yScale);\n+      this.classed(\"rectangle-plot\", true);\n+    }","path":"src/components/plots/rectanglePlot.ts","position":21,"original_position":21,"commit_id":"9a1fdfcd5b96e6da5c23db8e24ba7ba58e858e38","original_commit_id":"9a1fdfcd5b96e6da5c23db8e24ba7ba58e858e38","user":{"login":"rcchen","id":1175041,"avatar_url":"https://avatars.githubusercontent.com/u/1175041?v=3","gravatar_id":"","url":"https://api.github.com/users/rcchen","html_url":"https://github.com/rcchen","followers_url":"https://api.github.com/users/rcchen/followers","following_url":"https://api.github.com/users/rcchen/following{/other_user}","gists_url":"https://api.github.com/users/rcchen/gists{/gist_id}","starred_url":"https://api.github.com/users/rcchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcchen/subscriptions","organizations_url":"https://api.github.com/users/rcchen/orgs","repos_url":"https://api.github.com/users/rcchen/repos","events_url":"https://api.github.com/users/rcchen/events{/privacy}","received_events_url":"https://api.github.com/users/rcchen/received_events","type":"User","site_admin":false},"body":"Why? x1 is not necessarily going to be x.\r\n\r\nExample: CategoryScale, where x1 is mapped to x - rangeBand()/2","created_at":"2015-03-10T08:53:35Z","updated_at":"2015-03-10T08:53:35Z","html_url":"https://github.com/palantir/plottable/pull/1711#discussion_r26105780","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/1711","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/26105780"},"html":{"href":"https://github.com/palantir/plottable/pull/1711#discussion_r26105780"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1711"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/1711","id":30421818,"html_url":"https://github.com/palantir/plottable/pull/1711","diff_url":"https://github.com/palantir/plottable/pull/1711.diff","patch_url":"https://github.com/palantir/plottable/pull/1711.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/1711","number":1711,"state":"open","locked":false,"title":"[Plots] Implement RectanglePlot, reimplement GridPlot to support non-ordinal scales","user":{"login":"rcchen","id":1175041,"avatar_url":"https://avatars.githubusercontent.com/u/1175041?v=3","gravatar_id":"","url":"https://api.github.com/users/rcchen","html_url":"https://github.com/rcchen","followers_url":"https://api.github.com/users/rcchen/followers","following_url":"https://api.github.com/users/rcchen/following{/other_user}","gists_url":"https://api.github.com/users/rcchen/gists{/gist_id}","starred_url":"https://api.github.com/users/rcchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcchen/subscriptions","organizations_url":"https://api.github.com/users/rcchen/orgs","repos_url":"https://api.github.com/users/rcchen/repos","events_url":"https://api.github.com/users/rcchen/events{/privacy}","received_events_url":"https://api.github.com/users/rcchen/received_events","type":"User","site_admin":false},"body":"Still needs unit tests and whatnot, but I wanted to put this out there to kick off a conversation if there is any to be had about the implementation of RectanglePlot (for example, should this be called RectanglePlot?)\r\n\r\nProof of concept with TimeScale and LinearScale/OrdinalScale: http://jsfiddle.net/usv4ombr/2/\r\n\r\nFixes #1709 ","created_at":"2015-03-03T22:58:47Z","updated_at":"2015-03-10T08:53:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f87e334116b4ffa590c3c08d87f1986e9be5a562","assignee":{"login":"rcchen","id":1175041,"avatar_url":"https://avatars.githubusercontent.com/u/1175041?v=3","gravatar_id":"","url":"https://api.github.com/users/rcchen","html_url":"https://github.com/rcchen","followers_url":"https://api.github.com/users/rcchen/followers","following_url":"https://api.github.com/users/rcchen/following{/other_user}","gists_url":"https://api.github.com/users/rcchen/gists{/gist_id}","starred_url":"https://api.github.com/users/rcchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcchen/subscriptions","organizations_url":"https://api.github.com/users/rcchen/orgs","repos_url":"https://api.github.com/users/rcchen/repos","events_url":"https://api.github.com/users/rcchen/events{/privacy}","received_events_url":"https://api.github.com/users/rcchen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/1711/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/9a1fdfcd5b96e6da5c23db8e24ba7ba58e858e38","head":{"label":"palantir:1709-fix","ref":"1709-fix","sha":"9a1fdfcd5b96e6da5c23db8e24ba7ba58e858e38","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2015-03-10T00:50:20Z","pushed_at":"2015-03-10T02:45:46Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":60117,"stargazers_count":414,"watchers_count":414,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":138,"forks":33,"open_issues":138,"watchers":414,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"4c7960fd937971b351e060df54e173f0767a17e1","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2015-03-10T00:50:20Z","pushed_at":"2015-03-10T02:45:46Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":60117,"stargazers_count":414,"watchers_count":414,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":138,"forks":33,"open_issues":138,"watchers":414,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1711"},"html":{"href":"https://github.com/palantir/plottable/pull/1711"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/1711"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/9a1fdfcd5b96e6da5c23db8e24ba7ba58e858e38"}}}}