{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/47014429","id":47014429,"diff_hunk":"@@ -2385,82 +2386,95 @@\n       <h3>Interfaces for Connectivity Establishment</h3>\n \n       <section>\n-        <h4>RTCIceCandidate Dictionary</h4>\n+        <h4>RTCIceCandidate Interface</h4>\n \n-        <p>This describes an ICE candidate. Though not explicitly required,\n-        values for <var>candidate</var> and either <var>sdpMid</var>\n-        or <var>sdpMLineIndex</var> MUST be provided.</p>\n+        <p>This interface describes an ICE candidate.</p>\n \n-        <dl class=\"idl\" title=\"[Constructor(RTCIceCandidate copy)] dictionary RTCIceCandidate\">\n-          <dt>required DOMString candidate</dt>\n+        <dl class=\"idl\" data-merge=\"RTCIceCandidateInit\" title=\"interface RTCIceCandidate\">\n+          <dt>Constructor (RTCIceCandidateInit candidateInitDict)</dt>\n+\n+          <dd>The <dfn id=\"dom-icecandidate\"><code>RTCIceCandidate()</code></dfn> constructor\n+          takes a dictionary argument, <var>candidateInitDict</var>, whose content is used\n+          to initialize the new\n+          <a class=\"idlType\" href=\"#idl-def-RTCIceCandidate\"><code>RTCIceCandidate</code></a>\n+          object. If <var>sdpMid</var> or <var>sdpMLineIndex</var> is not present in\n+          <var>candidateInitDict</var>, the corresponding attribute will be initialized to\n+          <code>null</code>.</dd>\n+","path":"webrtc.html","position":57,"original_position":57,"commit_id":"3b6397e5d1ac8c87192d6cd2eb082623caea72c3","original_commit_id":"3b6397e5d1ac8c87192d6cd2eb082623caea72c3","user":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"body":"The above \"action\" should also go into the addIceCandidate() algorithm to make that complete.","created_at":"2015-12-08T21:14:27Z","updated_at":"2015-12-08T21:14:27Z","html_url":"https://github.com/w3c/webrtc-pc/pull/407#discussion_r47014429","pull_request_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407","_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/47014429"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/407#discussion_r47014429"},"pull_request":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407","id":52163421,"html_url":"https://github.com/w3c/webrtc-pc/pull/407","diff_url":"https://github.com/w3c/webrtc-pc/pull/407.diff","patch_url":"https://github.com/w3c/webrtc-pc/pull/407.patch","issue_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/407","number":407,"state":"open","locked":false,"title":"Bringing back the RTCIceCandidate interface, with 'init' dictionary.","user":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"body":"This is necessary since RTCIceCandidate is an attribute of an event\r\ninterface. This is also convenient since the new attributes on a\r\ncandidate (ip, port, foundation, etc.) can now become readonly\r\nattributes.","created_at":"2015-11-30T18:52:07Z","updated_at":"2015-12-08T21:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de939b683186ec4732c09de3a68a9cbacfafdd3e","assignee":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407/commits","review_comments_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407/comments","review_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/407/comments","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/3b6397e5d1ac8c87192d6cd2eb082623caea72c3","head":{"label":"taylor-b:ice_candidate_interface","ref":"ice_candidate_interface","sha":"3b6397e5d1ac8c87192d6cd2eb082623caea72c3","user":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"repo":{"id":43853249,"name":"webrtc-pc","full_name":"taylor-b/webrtc-pc","owner":{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taylor-b/webrtc-pc","description":"WebRTC 1.0 API","fork":true,"url":"https://api.github.com/repos/taylor-b/webrtc-pc","forks_url":"https://api.github.com/repos/taylor-b/webrtc-pc/forks","keys_url":"https://api.github.com/repos/taylor-b/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taylor-b/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taylor-b/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/taylor-b/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/taylor-b/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/taylor-b/webrtc-pc/events","assignees_url":"https://api.github.com/repos/taylor-b/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/taylor-b/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/taylor-b/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taylor-b/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/taylor-b/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/taylor-b/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/taylor-b/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/taylor-b/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/taylor-b/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/taylor-b/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/taylor-b/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/taylor-b/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/taylor-b/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/taylor-b/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/taylor-b/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taylor-b/webrtc-pc/merges","archive_url":"https://api.github.com/repos/taylor-b/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taylor-b/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/taylor-b/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/taylor-b/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/taylor-b/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/taylor-b/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taylor-b/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/taylor-b/webrtc-pc/releases{/id}","created_at":"2015-10-08T00:46:11Z","updated_at":"2015-10-08T00:46:14Z","pushed_at":"2015-11-30T18:50:48Z","git_url":"git://github.com/taylor-b/webrtc-pc.git","ssh_url":"git@github.com:taylor-b/webrtc-pc.git","clone_url":"https://github.com/taylor-b/webrtc-pc.git","svn_url":"https://github.com/taylor-b/webrtc-pc","homepage":null,"size":15328,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"8bbc42e71da1245a4e09f55e2b8e91f52d81c6f0","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23384500,"name":"webrtc-pc","full_name":"w3c/webrtc-pc","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webrtc-pc","description":"WebRTC 1.0 API","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-pc","forks_url":"https://api.github.com/repos/w3c/webrtc-pc/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-pc/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-pc/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-pc/releases{/id}","created_at":"2014-08-27T09:39:00Z","updated_at":"2015-12-03T14:33:58Z","pushed_at":"2015-12-07T21:57:44Z","git_url":"git://github.com/w3c/webrtc-pc.git","ssh_url":"git@github.com:w3c/webrtc-pc.git","clone_url":"https://github.com/w3c/webrtc-pc.git","svn_url":"https://github.com/w3c/webrtc-pc","homepage":null,"size":16222,"stargazers_count":53,"watchers_count":53,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":70,"forks":31,"open_issues":70,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/407"},"issue":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/407"},"comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webrtc-pc/statuses/3b6397e5d1ac8c87192d6cd2eb082623caea72c3"}}}}