{"action":"created","issue":{"url":"https://api.github.com/repos/diydrones/ardupilot/issues/3243","labels_url":"https://api.github.com/repos/diydrones/ardupilot/issues/3243/labels{/name}","comments_url":"https://api.github.com/repos/diydrones/ardupilot/issues/3243/comments","events_url":"https://api.github.com/repos/diydrones/ardupilot/issues/3243/events","html_url":"https://github.com/diydrones/ardupilot/pull/3243","id":119246592,"number":3243,"title":"min()/max() rework","user":{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars.githubusercontent.com/u/31864?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/diydrones/ardupilot/labels/AllVehicles","name":"AllVehicles","color":"bfd4f2"},{"url":"https://api.github.com/repos/diydrones/ardupilot/labels/Reviewed","name":"Reviewed","color":"f7c666"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2015-11-27T21:12:58Z","updated_at":"2015-11-30T20:37:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/diydrones/ardupilot/pulls/3243","html_url":"https://github.com/diydrones/ardupilot/pull/3243","diff_url":"https://github.com/diydrones/ardupilot/pull/3243.diff","patch_url":"https://github.com/diydrones/ardupilot/pull/3243.patch"},"body":"This changes the implementation of the min() and max() functions. The motivation for this was that defining them as macro conflicts with some C++ headers which we need for the threaded I2C work. I decided to send this earlier so to split the review.\r\n\r\nIt's basically composed of 2 parts: 1) use another name for these macros and 2) change the implementation to be a little bit better.  Specific commits contain more detail about the changes. Particularly the last commit shows some examples of callers that benefit from these new implementations."},"comment":{"url":"https://api.github.com/repos/diydrones/ardupilot/issues/comments/160754399","html_url":"https://github.com/diydrones/ardupilot/pull/3243#issuecomment-160754399","issue_url":"https://api.github.com/repos/diydrones/ardupilot/issues/3243","id":160754399,"user":{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T20:37:42Z","updated_at":"2015-11-30T20:37:42Z","body":"looks good. It adds 100 bytes of flash space on Pixhawk, but that isn't terrible.\r\nRandy, do you have time to flight test this with copter?\r\n"}}