{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/32678488","id":32678488,"diff_hunk":"@@ -228,6 +228,48 @@ int rl_dist(const tripoint &loc1, const tripoint &loc2)\n     return square_dist(loc1, loc2);\n }\n \n+// This more general version of this function gives correct values for larger values.\n+unsigned make_xyz(int const x, int const y, int const z)\n+{\n+    static const double sixteenth_arc = 0.392699082;\n+    int vertical_position = ((z > 0) ? 2u : (z < 0) ? 1u : 0u) * 9u;","path":"src/line.cpp","position":8,"original_position":8,"commit_id":"86863d44187c6779129743385c62dc2e682a287e","original_commit_id":"86863d44187c6779129743385c62dc2e682a287e","user":{"login":"DavidKeaton","id":1715605,"avatar_url":"https://avatars.githubusercontent.com/u/1715605?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidKeaton","html_url":"https://github.com/DavidKeaton","followers_url":"https://api.github.com/users/DavidKeaton/followers","following_url":"https://api.github.com/users/DavidKeaton/following{/other_user}","gists_url":"https://api.github.com/users/DavidKeaton/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidKeaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidKeaton/subscriptions","organizations_url":"https://api.github.com/users/DavidKeaton/orgs","repos_url":"https://api.github.com/users/DavidKeaton/repos","events_url":"https://api.github.com/users/DavidKeaton/events{/privacy}","received_events_url":"https://api.github.com/users/DavidKeaton/received_events","type":"User","site_admin":false},"body":"okay :-)","created_at":"2015-06-17T21:43:22Z","updated_at":"2015-06-17T21:43:22Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12695#discussion_r32678488","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/32678488"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12695#discussion_r32678488"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695","id":37868280,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12695","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12695.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12695.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12695","number":12695,"state":"open","locked":false,"title":"Base make_xyz() on trig functions to make it more general.","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"body":"This fixes the monster compass, which before this change would only report monsters as being in one of the cardinal directions if they were due N/E/S/W of you, now it splits it into 22.5 degree arcs like it should.\r\nAlso added a unit test for it, since I'm a little fuzzy on my trig and wanted to make sure I didn't break anything.","created_at":"2015-06-17T06:05:02Z","updated_at":"2015-06-17T21:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec5a6c02777fdd83e2046a74e30dd0219128a389","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12695/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/86863d44187c6779129743385c62dc2e682a287e","head":{"label":"kevingranade:fix-compass","ref":"fix-compass","sha":"86863d44187c6779129743385c62dc2e682a287e","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"repo":{"id":9759215,"name":"Cataclysm-DDA","full_name":"kevingranade/Cataclysm-DDA","owner":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevingranade/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA","forks_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/kevingranade/Cataclysm-DDA/releases{/id}","created_at":"2013-04-29T22:15:31Z","updated_at":"2015-03-21T16:31:24Z","pushed_at":"2015-06-17T06:02:00Z","git_url":"git://github.com/kevingranade/Cataclysm-DDA.git","ssh_url":"git@github.com:kevingranade/Cataclysm-DDA.git","clone_url":"https://github.com/kevingranade/Cataclysm-DDA.git","svn_url":"https://github.com/kevingranade/Cataclysm-DDA","homepage":"http://www.cataclysm.glyphgryph.com/","size":465993,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"cdfc26af00ad7ecec6f5cbd0a6030cf98a9bb365","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-06-16T18:58:13Z","pushed_at":"2015-06-17T06:05:02Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":547119,"stargazers_count":680,"watchers_count":680,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":724,"mirror_url":null,"open_issues_count":980,"forks":724,"open_issues":980,"watchers":680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12695"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12695"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12695/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12695/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/86863d44187c6779129743385c62dc2e682a287e"}}}}