{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/46363880","id":46363880,"diff_hunk":"@@ -361,15 +385,103 @@ def _Exists(self):\n     return len(placement_groups) > 0\n \n \n+class AwsRegionalNetwork(network.BaseNetwork):\n+  \"\"\"Object representing regional components of an AWS network.\n+\n+  This class maintains a singleton-per-region; acquire instances via\n+  AwsRegionalNetwork.GetForRegion.\n+\n+  Attributes:\n+    region: string. The AWS region.\n+    vpc: an AwsVpc instance.\n+    internet_gateway: an AwsInternetGateway instance.\n+    route_table: The default route table.","path":"perfkitbenchmarker/providers/aws/aws_network.py","position":61,"original_position":61,"commit_id":"83c356d0f3bf4ad3665bd7adc4688ce52e3fc3cd","original_commit_id":"83c356d0f3bf4ad3665bd7adc4688ce52e3fc3cd","user":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2015-12-02T00:52:20Z","updated_at":"2015-12-02T00:52:20Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/687#discussion_r46363880","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/46363880"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/687#discussion_r46363880"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687","id":52286211,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/687","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/687.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/687.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/687","number":687,"state":"open","locked":false,"title":"Create one AWS VPC/IGW/PlacementGroup per region.","user":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"body":"VPCs, Internet Gateways, and Placement groups are regional resources.\r\nThis change creates a single VPC/IGW/Placement Group per region (via\r\n`AwsRegionalNetwork`), then creates a per-AZ subnet.\r\n\r\nTested with:\r\n\r\n    python pkb.py --benchmarks netperf --cloud AWS \\\r\n      --zones us-west-1a,us-west-1c \\\r\n      --ip_addresses INTERNAL \\\r\n      --netperf_test_length 10\r\n\r\n    python pkb.py --benchmarks netperf --cloud AWS \\\r\n      --zones us-west-1 \\\r\n      --ip_addresses INTERNAL \\\r\n      --netperf_test_length 10","created_at":"2015-12-01T17:08:57Z","updated_at":"2015-12-02T00:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74fb14fa050c6a6e72c26f263b9ef9fe7cf9149b","assignee":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/687/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/83c356d0f3bf4ad3665bd7adc4688ce52e3fc3cd","head":{"label":"cmccoy:aws-vpc-per-region","ref":"aws-vpc-per-region","sha":"83c356d0f3bf4ad3665bd7adc4688ce52e3fc3cd","user":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"repo":{"id":34029803,"name":"PerfKitBenchmarker","full_name":"cmccoy/PerfKitBenchmarker","owner":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmccoy/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/releases{/id}","created_at":"2015-04-16T02:24:48Z","updated_at":"2015-04-18T13:31:32Z","pushed_at":"2015-12-01T17:04:44Z","git_url":"git://github.com/cmccoy/PerfKitBenchmarker.git","ssh_url":"git@github.com:cmccoy/PerfKitBenchmarker.git","clone_url":"https://github.com/cmccoy/PerfKitBenchmarker.git","svn_url":"https://github.com/cmccoy/PerfKitBenchmarker","homepage":"","size":3639,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6466090949488dbbb014edab5564ea8ca9c806f9","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2015-12-01T20:25:23Z","pushed_at":"2015-12-01T23:55:12Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":84416,"stargazers_count":508,"watchers_count":508,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":94,"mirror_url":null,"open_issues_count":92,"forks":94,"open_issues":92,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/687"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/687"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/83c356d0f3bf4ad3665bd7adc4688ce52e3fc3cd"}}}}