{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Logging/pulls/comments/48581530","id":48581530,"diff_hunk":"@@ -53,12 +51,65 @@ public void LoggerFactoryCreateOfT_TwoGenerics_CallsCreateWithCorrectName()\n                 x => x.Equals(\"Microsoft.Extensions.Logging.Test.GenericClass<Microsoft.Extensions.Logging.Test.TestType, Microsoft.Extensions.Logging.Test.SecondTestType>\"))))\n             .Returns(new Mock<ILogger>().Object);\n \n-            var logger = factory.Object.CreateLogger<GenericClass<TestType,SecondTestType>>();\n+            var logger = factory.Object.CreateLogger<GenericClass<TestType, SecondTestType>>();\n \n             // Assert\n             Assert.NotNull(logger);\n         }\n-#endif\n+\n+        [Fact]\n+        public void CreatesLoggerName_WithoutGenericTypeArgumentsInformation()\n+        {\n+            // Arrange\n+            var fullName = typeof(GenericClass<string>).GetGenericTypeDefinition().FullName;\n+            var fullNameWithoutTilda = fullName.Substring(0, fullName.IndexOf('`'));\n+            var testSink = new TestSink();\n+            var factory = new TestLoggerFactory(testSink, enabled: true);\n+\n+            // Act\n+            var logger = factory.CreateLogger<GenericClass<string>>();\n+            logger.LogInformation(\"test message\");\n+\n+            // Assert\n+            Assert.Single(testSink.Writes);\n+            Assert.Equal(fullNameWithoutTilda, testSink.Writes[0].LoggerName);\n+        }\n+\n+        [Fact]\n+        public void CreatesLoggerName_OnNestedGenericType_CreatesWithoutGenericTypeArgumentsInformation()\n+        {\n+            // Arrange\n+            var fullName = typeof(GenericClass<GenericClass<string>>).GetGenericTypeDefinition().FullName;\n+            var fullNameWithoutTilda = fullName.Substring(0, fullName.IndexOf('`'));","path":"test/Microsoft.Extensions.Logging.Test/LoggerFactoryExtensionsTest.cs","position":55,"original_position":55,"commit_id":"878bae028bf91228777dac7c6e54e06f47a0f649","original_commit_id":"878bae028bf91228777dac7c6e54e06f47a0f649","user":{"login":"Eilon","id":202643,"avatar_url":"https://avatars.githubusercontent.com/u/202643?v=3","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"body":"And here","created_at":"2015-12-30T00:50:50Z","updated_at":"2015-12-30T00:50:50Z","html_url":"https://github.com/aspnet/Logging/pull/329#discussion_r48581530","pull_request_url":"https://api.github.com/repos/aspnet/Logging/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/comments/48581530"},"html":{"href":"https://github.com/aspnet/Logging/pull/329#discussion_r48581530"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Logging/pulls/329","id":54751037,"html_url":"https://github.com/aspnet/Logging/pull/329","diff_url":"https://github.com/aspnet/Logging/pull/329.diff","patch_url":"https://github.com/aspnet/Logging/pull/329.patch","issue_url":"https://api.github.com/repos/aspnet/Logging/issues/329","number":329,"state":"open","locked":false,"title":"Fixes #326: Logger from Type name shouldn't include generic parameters","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"body":"@Eilon @muratg @loudej @lodejard ","created_at":"2015-12-29T19:23:24Z","updated_at":"2015-12-30T00:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b8ce1abe634a11cf3a37152fbc3db00297a72fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Logging/pulls/329/commits","review_comments_url":"https://api.github.com/repos/aspnet/Logging/pulls/329/comments","review_comment_url":"https://api.github.com/repos/aspnet/Logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Logging/issues/329/comments","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/878bae028bf91228777dac7c6e54e06f47a0f649","head":{"label":"aspnet:kiran/fix-logger-name","ref":"kiran/fix-logger-name","sha":"878bae028bf91228777dac7c6e54e06f47a0f649","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15836601,"name":"Logging","full_name":"aspnet/Logging","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Logging","description":"Common logging abstractions for DNX and ASP.NET 5.","fork":false,"url":"https://api.github.com/repos/aspnet/Logging","forks_url":"https://api.github.com/repos/aspnet/Logging/forks","keys_url":"https://api.github.com/repos/aspnet/Logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Logging/teams","hooks_url":"https://api.github.com/repos/aspnet/Logging/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Logging/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Logging/events","assignees_url":"https://api.github.com/repos/aspnet/Logging/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Logging/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Logging/tags","blobs_url":"https://api.github.com/repos/aspnet/Logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Logging/languages","stargazers_url":"https://api.github.com/repos/aspnet/Logging/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Logging/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Logging/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Logging/subscription","commits_url":"https://api.github.com/repos/aspnet/Logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Logging/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Logging/merges","archive_url":"https://api.github.com/repos/aspnet/Logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Logging/downloads","issues_url":"https://api.github.com/repos/aspnet/Logging/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Logging/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Logging/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Logging/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Logging/releases{/id}","created_at":"2014-01-12T04:46:28Z","updated_at":"2015-12-29T22:49:18Z","pushed_at":"2015-12-30T00:33:28Z","git_url":"git://github.com/aspnet/Logging.git","ssh_url":"git@github.com:aspnet/Logging.git","clone_url":"https://github.com/aspnet/Logging.git","svn_url":"https://github.com/aspnet/Logging","homepage":"","size":1383,"stargazers_count":181,"watchers_count":181,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":44,"forks":96,"open_issues":44,"watchers":181,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"f7c9fc32a801bc0c756931adfdca73ab4657727a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15836601,"name":"Logging","full_name":"aspnet/Logging","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Logging","description":"Common logging abstractions for DNX and ASP.NET 5.","fork":false,"url":"https://api.github.com/repos/aspnet/Logging","forks_url":"https://api.github.com/repos/aspnet/Logging/forks","keys_url":"https://api.github.com/repos/aspnet/Logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Logging/teams","hooks_url":"https://api.github.com/repos/aspnet/Logging/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Logging/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Logging/events","assignees_url":"https://api.github.com/repos/aspnet/Logging/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Logging/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Logging/tags","blobs_url":"https://api.github.com/repos/aspnet/Logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Logging/languages","stargazers_url":"https://api.github.com/repos/aspnet/Logging/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Logging/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Logging/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Logging/subscription","commits_url":"https://api.github.com/repos/aspnet/Logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Logging/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Logging/merges","archive_url":"https://api.github.com/repos/aspnet/Logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Logging/downloads","issues_url":"https://api.github.com/repos/aspnet/Logging/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Logging/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Logging/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Logging/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Logging/releases{/id}","created_at":"2014-01-12T04:46:28Z","updated_at":"2015-12-29T22:49:18Z","pushed_at":"2015-12-30T00:33:28Z","git_url":"git://github.com/aspnet/Logging.git","ssh_url":"git@github.com:aspnet/Logging.git","clone_url":"https://github.com/aspnet/Logging.git","svn_url":"https://github.com/aspnet/Logging","homepage":"","size":1383,"stargazers_count":181,"watchers_count":181,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":44,"forks":96,"open_issues":44,"watchers":181,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/329"},"html":{"href":"https://github.com/aspnet/Logging/pull/329"},"issue":{"href":"https://api.github.com/repos/aspnet/Logging/issues/329"},"comments":{"href":"https://api.github.com/repos/aspnet/Logging/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Logging/statuses/878bae028bf91228777dac7c6e54e06f47a0f649"}}}}