{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/6713","labels_url":"https://api.github.com/repos/ceph/ceph/issues/6713/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/6713/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/6713/events","html_url":"https://github.com/ceph/ceph/pull/6713","id":119010533,"number":6713,"title":"WBThrottle: fix incorrect throttle","user":{"login":"zhanghuan","id":19114,"avatar_url":"https://avatars.githubusercontent.com/u/19114?v=3","gravatar_id":"","url":"https://api.github.com/users/zhanghuan","html_url":"https://github.com/zhanghuan","followers_url":"https://api.github.com/users/zhanghuan/followers","following_url":"https://api.github.com/users/zhanghuan/following{/other_user}","gists_url":"https://api.github.com/users/zhanghuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhanghuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhanghuan/subscriptions","organizations_url":"https://api.github.com/users/zhanghuan/orgs","repos_url":"https://api.github.com/users/zhanghuan/repos","events_url":"https://api.github.com/users/zhanghuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhanghuan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-26T10:06:36Z","updated_at":"2015-12-01T08:57:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/6713","html_url":"https://github.com/ceph/ceph/pull/6713","diff_url":"https://github.com/ceph/ceph/pull/6713.diff","patch_url":"https://github.com/ceph/ceph/pull/6713.patch"},"body":"This bug is introduced in commit 573d2cc, that throttle()\r\nincorrectly use the \"start flusher\" throttle value to block new\r\nwrite requests.\r\n\r\nOn a test environment of 2 storage nodes with 7 HDD each, the\r\noverall write performance measured by iozone is doubled with this\r\npatch (boosted from 160MB/s to 300MB/s).\r\n\r\nSigned-off-by: Zhang Huan <zhanghuan@ict.ac.cn>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/160898382","html_url":"https://github.com/ceph/ceph/pull/6713#issuecomment-160898382","issue_url":"https://api.github.com/repos/ceph/ceph/issues/6713","id":160898382,"user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T08:57:21Z","updated_at":"2015-12-01T08:57:21Z","body":"@zhanghuan you are right. and i checked https://github.com/ceph/ceph/blob/master/CodingStyle . where vertical whitespace is not encouraged. https://google.github.io/styleguide/cppguide.html#Vertical_Whitespace "}}