{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/plottable/issues/1975","labels_url":"https://api.github.com/repos/palantir/plottable/issues/1975/labels{/name}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/1975/comments","events_url":"https://api.github.com/repos/palantir/plottable/issues/1975/events","html_url":"https://github.com/palantir/plottable/pull/1975","id":73728915,"number":1975,"title":"Created consistency on events by using onEvent and offEvent APIs","user":{"login":"aicioara","id":3248682,"avatar_url":"https://avatars.githubusercontent.com/u/3248682?v=3","gravatar_id":"","url":"https://api.github.com/users/aicioara","html_url":"https://github.com/aicioara","followers_url":"https://api.github.com/users/aicioara/followers","following_url":"https://api.github.com/users/aicioara/following{/other_user}","gists_url":"https://api.github.com/users/aicioara/gists{/gist_id}","starred_url":"https://api.github.com/users/aicioara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicioara/subscriptions","organizations_url":"https://api.github.com/users/aicioara/orgs","repos_url":"https://api.github.com/users/aicioara/repos","events_url":"https://api.github.com/users/aicioara/events{/privacy}","received_events_url":"https://api.github.com/users/aicioara/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/palantir/plottable/labels/API%20Refactor","name":"API Refactor","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-05-06T20:31:19Z","updated_at":"2015-05-06T21:10:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/1975","html_url":"https://github.com/palantir/plottable/pull/1975","diff_url":"https://github.com/palantir/plottable/pull/1975.diff","patch_url":"https://github.com/palantir/plottable/pull/1975.patch"},"body":"Point 6 of #1915 \r\n\r\nAs part of this PR\r\n- Renamed `interactionTests` to `keyInteractionTests` because that is what was tested in that file\r\n- We can now have multiple callbacks attached to one particular event of an interaction\r\n- The callbacks are now removed using the `off` keyword (ex `ofDrag()`), instead of passing null\r\n- The callbacks can no longer be retrieved because we don't want to expose our `CallbackSet`\r\n- touched the `dragBoxLayer` as well, since it was using on/off drag interactions\r\n- added tests to cover the fact that we can now have multiple callbacks attached to an event\r\n- modified tests to no longer be able to retrieve the callback\r\n- typed the callback signatures (ex `ClickCallback = (p: Point) => any;`\r\n\r\nDisclaimer: Since this was a pretty long PR, there might be some inconsistencies in the way I structured tests or commented on stuff. Please signal any if you see."},"comment":{"url":"https://api.github.com/repos/palantir/plottable/issues/comments/99610577","html_url":"https://github.com/palantir/plottable/pull/1975#issuecomment-99610577","issue_url":"https://api.github.com/repos/palantir/plottable/issues/1975","id":99610577,"user":{"login":"aicioara","id":3248682,"avatar_url":"https://avatars.githubusercontent.com/u/3248682?v=3","gravatar_id":"","url":"https://api.github.com/users/aicioara","html_url":"https://github.com/aicioara","followers_url":"https://api.github.com/users/aicioara/followers","following_url":"https://api.github.com/users/aicioara/following{/other_user}","gists_url":"https://api.github.com/users/aicioara/gists{/gist_id}","starred_url":"https://api.github.com/users/aicioara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicioara/subscriptions","organizations_url":"https://api.github.com/users/aicioara/orgs","repos_url":"https://api.github.com/users/aicioara/repos","events_url":"https://api.github.com/users/aicioara/events{/privacy}","received_events_url":"https://api.github.com/users/aicioara/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T21:10:18Z","updated_at":"2015-05-06T21:10:18Z","body":"Addressed one of @bluong tests and improved comment consistency\r\n"}}