{"action":"closed","number":216,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/216","id":47672217,"html_url":"https://github.com/jenkinsci/ghprb-plugin/pull/216","diff_url":"https://github.com/jenkinsci/ghprb-plugin/pull/216.diff","patch_url":"https://github.com/jenkinsci/ghprb-plugin/pull/216.patch","issue_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/216","number":216,"state":"closed","locked":false,"title":"Changes getProjectName to check for null from the trigger's getActual…","user":{"login":"mmitche","id":8725170,"avatar_url":"https://avatars.githubusercontent.com/u/8725170?v=3","gravatar_id":"","url":"https://api.github.com/users/mmitche","html_url":"https://github.com/mmitche","followers_url":"https://api.github.com/users/mmitche/followers","following_url":"https://api.github.com/users/mmitche/following{/other_user}","gists_url":"https://api.github.com/users/mmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/mmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmitche/subscriptions","organizations_url":"https://api.github.com/users/mmitche/orgs","repos_url":"https://api.github.com/users/mmitche/repos","events_url":"https://api.github.com/users/mmitche/events{/privacy}","received_events_url":"https://api.github.com/users/mmitche/received_events","type":"User","site_admin":false},"body":"…Project()\r\n\r\nThis isn't a bug per-se, but I have a Jenkins instance configured using the job-dsl plugin.  There was an attempt to configure the ghprb triggers using a configure block (which directly edits xml) which created a somewhat invalid trigger.  There was an error processing the webhooks in GhprbRootAction.doIndex().   The try catch block in the loop caught the exception and should have continued processing the rest of the hooks for other projects, however the catch block calls getProjectName, which has the potential to throw NullPointerException if the project for the trigger can't be found.  Avoid this by checking for whether trigger.getActualProject() return null.","created_at":"2015-10-14T15:10:54Z","updated_at":"2015-10-14T15:14:41Z","closed_at":"2015-10-14T15:14:41Z","merged_at":null,"merge_commit_sha":"d28af3939addc9f7c26e814d03478b5561cc2ce7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/216/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/216/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/216/comments","statuses_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/statuses/9585e0b7d71623e16f7d7ba9883b8ee47a682df7","head":{"label":"mmitche:avoid-npe","ref":"avoid-npe","sha":"9585e0b7d71623e16f7d7ba9883b8ee47a682df7","user":{"login":"mmitche","id":8725170,"avatar_url":"https://avatars.githubusercontent.com/u/8725170?v=3","gravatar_id":"","url":"https://api.github.com/users/mmitche","html_url":"https://github.com/mmitche","followers_url":"https://api.github.com/users/mmitche/followers","following_url":"https://api.github.com/users/mmitche/following{/other_user}","gists_url":"https://api.github.com/users/mmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/mmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmitche/subscriptions","organizations_url":"https://api.github.com/users/mmitche/orgs","repos_url":"https://api.github.com/users/mmitche/repos","events_url":"https://api.github.com/users/mmitche/events{/privacy}","received_events_url":"https://api.github.com/users/mmitche/received_events","type":"User","site_admin":false},"repo":{"id":26888782,"name":"ghprb","full_name":"mmitche/ghprb","owner":{"login":"mmitche","id":8725170,"avatar_url":"https://avatars.githubusercontent.com/u/8725170?v=3","gravatar_id":"","url":"https://api.github.com/users/mmitche","html_url":"https://github.com/mmitche","followers_url":"https://api.github.com/users/mmitche/followers","following_url":"https://api.github.com/users/mmitche/following{/other_user}","gists_url":"https://api.github.com/users/mmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/mmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmitche/subscriptions","organizations_url":"https://api.github.com/users/mmitche/orgs","repos_url":"https://api.github.com/users/mmitche/repos","events_url":"https://api.github.com/users/mmitche/events{/privacy}","received_events_url":"https://api.github.com/users/mmitche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmitche/ghprb","description":"github pull requests builder plugin for Jenkins","fork":true,"url":"https://api.github.com/repos/mmitche/ghprb","forks_url":"https://api.github.com/repos/mmitche/ghprb/forks","keys_url":"https://api.github.com/repos/mmitche/ghprb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmitche/ghprb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmitche/ghprb/teams","hooks_url":"https://api.github.com/repos/mmitche/ghprb/hooks","issue_events_url":"https://api.github.com/repos/mmitche/ghprb/issues/events{/number}","events_url":"https://api.github.com/repos/mmitche/ghprb/events","assignees_url":"https://api.github.com/repos/mmitche/ghprb/assignees{/user}","branches_url":"https://api.github.com/repos/mmitche/ghprb/branches{/branch}","tags_url":"https://api.github.com/repos/mmitche/ghprb/tags","blobs_url":"https://api.github.com/repos/mmitche/ghprb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmitche/ghprb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmitche/ghprb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmitche/ghprb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmitche/ghprb/statuses/{sha}","languages_url":"https://api.github.com/repos/mmitche/ghprb/languages","stargazers_url":"https://api.github.com/repos/mmitche/ghprb/stargazers","contributors_url":"https://api.github.com/repos/mmitche/ghprb/contributors","subscribers_url":"https://api.github.com/repos/mmitche/ghprb/subscribers","subscription_url":"https://api.github.com/repos/mmitche/ghprb/subscription","commits_url":"https://api.github.com/repos/mmitche/ghprb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmitche/ghprb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmitche/ghprb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmitche/ghprb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmitche/ghprb/contents/{+path}","compare_url":"https://api.github.com/repos/mmitche/ghprb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmitche/ghprb/merges","archive_url":"https://api.github.com/repos/mmitche/ghprb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmitche/ghprb/downloads","issues_url":"https://api.github.com/repos/mmitche/ghprb/issues{/number}","pulls_url":"https://api.github.com/repos/mmitche/ghprb/pulls{/number}","milestones_url":"https://api.github.com/repos/mmitche/ghprb/milestones{/number}","notifications_url":"https://api.github.com/repos/mmitche/ghprb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmitche/ghprb/labels{/name}","releases_url":"https://api.github.com/repos/mmitche/ghprb/releases{/id}","created_at":"2014-11-20T00:43:26Z","updated_at":"2014-11-20T00:43:26Z","pushed_at":"2015-10-14T15:09:28Z","git_url":"git://github.com/mmitche/ghprb.git","ssh_url":"git@github.com:mmitche/ghprb.git","clone_url":"https://github.com/mmitche/ghprb.git","svn_url":"https://github.com/mmitche/ghprb","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin","size":1459,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"89daac9f57f74d44effda82f29495cc0966233ed","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":5672873,"name":"ghprb-plugin","full_name":"jenkinsci/ghprb-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/ghprb-plugin","description":"github pull requests builder plugin for Jenkins","fork":true,"url":"https://api.github.com/repos/jenkinsci/ghprb-plugin","forks_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/releases{/id}","created_at":"2012-09-04T13:34:20Z","updated_at":"2015-10-02T15:22:22Z","pushed_at":"2015-10-14T15:14:01Z","git_url":"git://github.com/jenkinsci/ghprb-plugin.git","ssh_url":"git@github.com:jenkinsci/ghprb-plugin.git","clone_url":"https://github.com/jenkinsci/ghprb-plugin.git","svn_url":"https://github.com/jenkinsci/ghprb-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin","size":2989,"stargazers_count":114,"watchers_count":114,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":37,"forks":165,"open_issues":37,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/216"},"html":{"href":"https://github.com/jenkinsci/ghprb-plugin/pull/216"},"issue":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/216"},"comments":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/ghprb-plugin/statuses/9585e0b7d71623e16f7d7ba9883b8ee47a682df7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":12,"deletions":1,"changed_files":1}}