{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1204","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1204/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1204/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1204/events","html_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1204","id":108746631,"number":1204,"title":"Fix EZP-24890: Delayed indexing should fail gracefully on trashed / broken node","user":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-28T21:05:30Z","updated_at":"2015-09-29T18:30:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/pulls/1204","html_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1204","diff_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1204.diff","patch_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1204.patch"},"body":"The diff is misleading -- the fix is simply to mark the item to be removed instead of continuing on with the loop. I also renamed the offset and limit for the \"move\" section so it doesn't mess up the main offset and limit.\r\n\r\nAn alternative (that should perhaps be used together with this fix) is to make the trash action remove the \"index_moved_node\" entry from ezpending_actions, but then you still have a cleanup issue for any sites with this problem."},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/comments/144148093","html_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1204#issuecomment-144148093","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1204","id":144148093,"user":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T18:30:44Z","updated_at":"2015-09-29T18:30:44Z","body":"Nice suggestion from @bgamrat and @thiagocamposviana was to just duplicate the code, which I've done now: https://github.com/ezsystems/ezpublish-legacy/pull/1206.  I don't like it as much, especially for such a short file, but it's a cleaner diff."}}