{"action":"created","comment":{"url":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments/28280186","id":28280186,"diff_hunk":"@@ -318,6 +319,56 @@ def wrapper(ssl, out, outlen, in_, inlen, arg):\n         )\n \n \n+class _AlpnSelectHelper(_CallbackExceptionHelper):","path":"OpenSSL/SSL.py","position":12,"original_position":12,"commit_id":"e46fa849d3b61be6538447263d96a868b2f42a8a","original_commit_id":"e46fa849d3b61be6538447263d96a868b2f42a8a","user":{"login":"alex","id":772,"avatar_url":"https://avatars.githubusercontent.com/u/772?v=3","gravatar_id":"","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"body":"(Technically it's an initialism) :runs:\n\nOn Mon, Apr 13, 2015 at 5:14 PM, Jean-Paul Calderone <\nnotifications@github.com> wrote:\n\n> In OpenSSL/SSL.py\n> <https://github.com/pyca/pyopenssl/pull/120#discussion_r28279904>:\n>\n> > @@ -318,6 +319,56 @@ def wrapper(ssl, out, outlen, in_, inlen, arg):\n> >          )\n> >\n> >\n> > +class _AlpnSelectHelper(_CallbackExceptionHelper):\n>\n> (As opposed to Alpn)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/pyca/pyopenssl/pull/120/files#r28279904>.\n>\n\n\n\n-- \n\"I disapprove of what you say, but I will defend to the death your right to\nsay it.\" -- Evelyn Beatrice Hall (summarizing Voltaire)\n\"The people's good is the highest law.\" -- Cicero\nGPG Key fingerprint: 125F 5C67 DFE9 4084\n","created_at":"2015-04-13T21:17:31Z","updated_at":"2015-04-13T21:17:31Z","html_url":"https://github.com/pyca/pyopenssl/pull/120#discussion_r28280186","pull_request_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments/28280186"},"html":{"href":"https://github.com/pyca/pyopenssl/pull/120#discussion_r28280186"},"pull_request":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/pyca/pyopenssl/pulls/120","id":16854924,"html_url":"https://github.com/pyca/pyopenssl/pull/120","diff_url":"https://github.com/pyca/pyopenssl/pull/120.diff","patch_url":"https://github.com/pyca/pyopenssl/pull/120.patch","issue_url":"https://api.github.com/repos/pyca/pyopenssl/issues/120","number":120,"state":"open","locked":false,"title":"Add ALPN support.","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"This pull request adds support for Application Layer Protocol Negotiation, the spec-standardised version of NPN.\r\n\r\nThis was added to OpenSSL in v1.0.2. The keen eye might detect that OpenSSL v1.0.2 is only in beta at the moment, which means that unsurprisingly this doesn't work right now. I'm opening this Pull Request to track the work: I don't expect it to be merged any time soon.\r\n\r\nThe relevant `cryptography` support was merged in pyca/cryptography#1105.\r\n\r\nThis is the second half of #79.","created_at":"2014-06-07T15:00:09Z","updated_at":"2015-04-13T21:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6edc3a6697efd13acbc72ad37c0a24ad9cba205","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/120/commits","review_comments_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/120/comments","review_comment_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyca/pyopenssl/issues/120/comments","statuses_url":"https://api.github.com/repos/pyca/pyopenssl/statuses/e46fa849d3b61be6538447263d96a868b2f42a8a","head":{"label":"Lukasa:alpn","ref":"alpn","sha":"e46fa849d3b61be6538447263d96a868b2f42a8a","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"repo":{"id":18241108,"name":"pyopenssl","full_name":"Lukasa/pyopenssl","owner":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukasa/pyopenssl","description":"Python interface to the OpenSSL library","fork":true,"url":"https://api.github.com/repos/Lukasa/pyopenssl","forks_url":"https://api.github.com/repos/Lukasa/pyopenssl/forks","keys_url":"https://api.github.com/repos/Lukasa/pyopenssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukasa/pyopenssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukasa/pyopenssl/teams","hooks_url":"https://api.github.com/repos/Lukasa/pyopenssl/hooks","issue_events_url":"https://api.github.com/repos/Lukasa/pyopenssl/issues/events{/number}","events_url":"https://api.github.com/repos/Lukasa/pyopenssl/events","assignees_url":"https://api.github.com/repos/Lukasa/pyopenssl/assignees{/user}","branches_url":"https://api.github.com/repos/Lukasa/pyopenssl/branches{/branch}","tags_url":"https://api.github.com/repos/Lukasa/pyopenssl/tags","blobs_url":"https://api.github.com/repos/Lukasa/pyopenssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukasa/pyopenssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukasa/pyopenssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukasa/pyopenssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukasa/pyopenssl/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukasa/pyopenssl/languages","stargazers_url":"https://api.github.com/repos/Lukasa/pyopenssl/stargazers","contributors_url":"https://api.github.com/repos/Lukasa/pyopenssl/contributors","subscribers_url":"https://api.github.com/repos/Lukasa/pyopenssl/subscribers","subscription_url":"https://api.github.com/repos/Lukasa/pyopenssl/subscription","commits_url":"https://api.github.com/repos/Lukasa/pyopenssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukasa/pyopenssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukasa/pyopenssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukasa/pyopenssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukasa/pyopenssl/contents/{+path}","compare_url":"https://api.github.com/repos/Lukasa/pyopenssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukasa/pyopenssl/merges","archive_url":"https://api.github.com/repos/Lukasa/pyopenssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukasa/pyopenssl/downloads","issues_url":"https://api.github.com/repos/Lukasa/pyopenssl/issues{/number}","pulls_url":"https://api.github.com/repos/Lukasa/pyopenssl/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukasa/pyopenssl/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukasa/pyopenssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukasa/pyopenssl/labels{/name}","releases_url":"https://api.github.com/repos/Lukasa/pyopenssl/releases{/id}","created_at":"2014-03-29T12:44:11Z","updated_at":"2014-06-16T13:43:04Z","pushed_at":"2015-04-13T21:12:49Z","git_url":"git://github.com/Lukasa/pyopenssl.git","ssh_url":"git@github.com:Lukasa/pyopenssl.git","clone_url":"https://github.com/Lukasa/pyopenssl.git","svn_url":"https://github.com/Lukasa/pyopenssl","homepage":null,"size":9712,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"4ca37f747d9dcc21d6f85655895e1e997937a670","user":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":15778059,"name":"pyopenssl","full_name":"pyca/pyopenssl","owner":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/pyopenssl","description":"Python interface to the OpenSSL library","fork":false,"url":"https://api.github.com/repos/pyca/pyopenssl","forks_url":"https://api.github.com/repos/pyca/pyopenssl/forks","keys_url":"https://api.github.com/repos/pyca/pyopenssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/pyopenssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/pyopenssl/teams","hooks_url":"https://api.github.com/repos/pyca/pyopenssl/hooks","issue_events_url":"https://api.github.com/repos/pyca/pyopenssl/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/pyopenssl/events","assignees_url":"https://api.github.com/repos/pyca/pyopenssl/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/pyopenssl/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/pyopenssl/tags","blobs_url":"https://api.github.com/repos/pyca/pyopenssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/pyopenssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/pyopenssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/pyopenssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/pyopenssl/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/pyopenssl/languages","stargazers_url":"https://api.github.com/repos/pyca/pyopenssl/stargazers","contributors_url":"https://api.github.com/repos/pyca/pyopenssl/contributors","subscribers_url":"https://api.github.com/repos/pyca/pyopenssl/subscribers","subscription_url":"https://api.github.com/repos/pyca/pyopenssl/subscription","commits_url":"https://api.github.com/repos/pyca/pyopenssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/pyopenssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/pyopenssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/pyopenssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyca/pyopenssl/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/pyopenssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/pyopenssl/merges","archive_url":"https://api.github.com/repos/pyca/pyopenssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/pyopenssl/downloads","issues_url":"https://api.github.com/repos/pyca/pyopenssl/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/pyopenssl/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/pyopenssl/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/pyopenssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/pyopenssl/labels{/name}","releases_url":"https://api.github.com/repos/pyca/pyopenssl/releases{/id}","created_at":"2014-01-09T20:10:36Z","updated_at":"2015-04-13T20:09:29Z","pushed_at":"2015-04-13T21:12:49Z","git_url":"git://github.com/pyca/pyopenssl.git","ssh_url":"git@github.com:pyca/pyopenssl.git","clone_url":"https://github.com/pyca/pyopenssl.git","svn_url":"https://github.com/pyca/pyopenssl","homepage":null,"size":11003,"stargazers_count":146,"watchers_count":146,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":76,"forks":110,"open_issues":76,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/120"},"html":{"href":"https://github.com/pyca/pyopenssl/pull/120"},"issue":{"href":"https://api.github.com/repos/pyca/pyopenssl/issues/120"},"comments":{"href":"https://api.github.com/repos/pyca/pyopenssl/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/pyopenssl/statuses/e46fa849d3b61be6538447263d96a868b2f42a8a"}}}}