{"action":"created","issue":{"url":"https://api.github.com/repos/angrave/sysassets/issues/4","labels_url":"https://api.github.com/repos/angrave/sysassets/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/angrave/sysassets/issues/4/comments","events_url":"https://api.github.com/repos/angrave/sysassets/issues/4/events","html_url":"https://github.com/angrave/sysassets/pull/4","id":58115141,"number":4,"title":"Added xdomain functionality for sysbuild","user":{"login":"scowalt","id":1100550,"avatar_url":"https://avatars.githubusercontent.com/u/1100550?v=3","gravatar_id":"","url":"https://api.github.com/users/scowalt","html_url":"https://github.com/scowalt","followers_url":"https://api.github.com/users/scowalt/followers","following_url":"https://api.github.com/users/scowalt/following{/other_user}","gists_url":"https://api.github.com/users/scowalt/gists{/gist_id}","starred_url":"https://api.github.com/users/scowalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scowalt/subscriptions","organizations_url":"https://api.github.com/users/scowalt/orgs","repos_url":"https://api.github.com/users/scowalt/repos","events_url":"https://api.github.com/users/scowalt/events{/privacy}","received_events_url":"https://api.github.com/users/scowalt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-18T19:27:19Z","updated_at":"2015-02-18T21:46:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angrave/sysassets/pulls/4","html_url":"https://github.com/angrave/sysassets/pull/4","diff_url":"https://github.com/angrave/sysassets/pull/4.diff","patch_url":"https://github.com/angrave/sysassets/pull/4.patch"},"body":"Read [this issue in the sysbuild project](https://github.com/cs-education/sysbuild/issues/70) for more background on this pull request. Some things I'm unsure of:\r\n\r\n1. Should we pull the javascript library from the rawgit cdn or include the file locally in the repository?\r\n2. Should we include `localhost` as one of the masters? This allows us test on our local machines much easier, but may open us up to a security or other vulnerability I'm not aware of. If we're going to allow `localhost` anyways, is it equally secure to just allow all domains?"},"comment":{"url":"https://api.github.com/repos/angrave/sysassets/issues/comments/74954872","html_url":"https://github.com/angrave/sysassets/pull/4#issuecomment-74954872","issue_url":"https://api.github.com/repos/angrave/sysassets/issues/4","id":74954872,"user":{"login":"scowalt","id":1100550,"avatar_url":"https://avatars.githubusercontent.com/u/1100550?v=3","gravatar_id":"","url":"https://api.github.com/users/scowalt","html_url":"https://github.com/scowalt","followers_url":"https://api.github.com/users/scowalt/followers","following_url":"https://api.github.com/users/scowalt/following{/other_user}","gists_url":"https://api.github.com/users/scowalt/gists{/gist_id}","starred_url":"https://api.github.com/users/scowalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scowalt/subscriptions","organizations_url":"https://api.github.com/users/scowalt/orgs","repos_url":"https://api.github.com/users/scowalt/repos","events_url":"https://api.github.com/users/scowalt/events{/privacy}","received_events_url":"https://api.github.com/users/scowalt/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T21:46:17Z","updated_at":"2015-02-18T21:46:17Z","body":"Alright, I included the library as a git submodule and confirmed that `git clone <url> --recursive` will take care of getting the dependency. I think this pull request is good to go."}}