{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/42983672","id":42983672,"diff_hunk":"@@ -0,0 +1,70 @@\n+package com.hazelcast.internal.serialization.impl;\n+\n+import com.hazelcast.config.SerializationConfig;\n+import com.hazelcast.config.SerializerConfig;\n+import com.hazelcast.nio.serialization.HazelcastSerializationException;\n+import com.hazelcast.test.HazelcastParallelClassRunner;\n+import com.hazelcast.test.HazelcastTestSupport;\n+import com.hazelcast.test.annotation.ParallelTest;\n+import com.hazelcast.test.annotation.QuickTest;\n+import org.junit.Test;\n+import org.junit.experimental.categories.Category;\n+import org.junit.runner.RunWith;\n+\n+import java.util.Map;\n+\n+import static org.junit.Assert.assertNotNull;\n+\n+/**\n+ * SerializerHookLoader Tester.\n+ *\n+ */\n+@RunWith(HazelcastParallelClassRunner.class)\n+@Category({QuickTest.class, ParallelTest.class})\n+public class SerializerHookLoaderTest extends HazelcastTestSupport {\n+\n+    @Test\n+    public void testLoad() throws Exception {\n+        ClassLoader classLoader = getClass().getClassLoader();","path":"hazelcast/src/test/java/com/hazelcast/internal/serialization/impl/SerializerHookLoaderTest.java","position":28,"original_position":28,"commit_id":"870d6591b88d55fc3f9f969efef8a1745501d756","original_commit_id":"870d6591b88d55fc3f9f969efef8a1745501d756","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"I would put the classloader in a private field and. Now every tests gets longer because of this, even though they all share the same logic.","created_at":"2015-10-26T11:51:02Z","updated_at":"2015-10-26T11:51:02Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6562#discussion_r42983672","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/42983672"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6562#discussion_r42983672"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562","id":48726984,"html_url":"https://github.com/hazelcast/hazelcast/pull/6562","diff_url":"https://github.com/hazelcast/hazelcast/pull/6562.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6562.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6562","number":6562,"state":"open","locked":false,"title":"Serializer tests, UnsafeDatainput UnsafeDataoutput","user":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-26T11:19:19Z","updated_at":"2015-10-26T11:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"760c78c7f92eff1172191e8238aa5a4cdac6eda7","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":134,"closed_issues":676,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-10-26T11:47:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6562/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/870d6591b88d55fc3f9f969efef8a1745501d756","head":{"label":"asimarslan:feature/master/serialization-compatibility6","ref":"feature/master/serialization-compatibility6","sha":"870d6591b88d55fc3f9f969efef8a1745501d756","user":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"repo":{"id":10238745,"name":"hazelcast","full_name":"asimarslan/hazelcast","owner":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asimarslan/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/asimarslan/hazelcast","forks_url":"https://api.github.com/repos/asimarslan/hazelcast/forks","keys_url":"https://api.github.com/repos/asimarslan/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asimarslan/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asimarslan/hazelcast/teams","hooks_url":"https://api.github.com/repos/asimarslan/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/asimarslan/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/asimarslan/hazelcast/events","assignees_url":"https://api.github.com/repos/asimarslan/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/asimarslan/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/asimarslan/hazelcast/tags","blobs_url":"https://api.github.com/repos/asimarslan/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asimarslan/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asimarslan/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/asimarslan/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asimarslan/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/asimarslan/hazelcast/languages","stargazers_url":"https://api.github.com/repos/asimarslan/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/asimarslan/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/asimarslan/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/asimarslan/hazelcast/subscription","commits_url":"https://api.github.com/repos/asimarslan/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/asimarslan/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/asimarslan/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/asimarslan/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/asimarslan/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/asimarslan/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asimarslan/hazelcast/merges","archive_url":"https://api.github.com/repos/asimarslan/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asimarslan/hazelcast/downloads","issues_url":"https://api.github.com/repos/asimarslan/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/asimarslan/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/asimarslan/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/asimarslan/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asimarslan/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/asimarslan/hazelcast/releases{/id}","created_at":"2013-05-23T07:56:42Z","updated_at":"2015-04-01T14:20:18Z","pushed_at":"2015-10-26T11:17:22Z","git_url":"git://github.com/asimarslan/hazelcast.git","ssh_url":"git@github.com:asimarslan/hazelcast.git","clone_url":"https://github.com/asimarslan/hazelcast.git","svn_url":"https://github.com/asimarslan/hazelcast","homepage":"www.hazelcast.com","size":79548,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"008f92b65b9a6f5b89c3e0805921ee5d670971c4","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-10-25T20:02:43Z","pushed_at":"2015-10-26T11:48:56Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":160063,"stargazers_count":1281,"watchers_count":1281,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":621,"mirror_url":null,"open_issues_count":513,"forks":621,"open_issues":513,"watchers":1281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6562"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6562"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6562/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6562/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/870d6591b88d55fc3f9f969efef8a1745501d756"}}}}