{"action":"created","issue":{"url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/12","labels_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/12/comments","events_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/12/events","html_url":"https://github.com/eddelbuettel/rquantlib/issues/12","id":57416542,"number":12,"title":"Makevars.win","user":{"login":"jeroenooms","id":216319,"avatar_url":"https://avatars.githubusercontent.com/u/216319?v=3","gravatar_id":"","url":"https://api.github.com/users/jeroenooms","html_url":"https://github.com/jeroenooms","followers_url":"https://api.github.com/users/jeroenooms/followers","following_url":"https://api.github.com/users/jeroenooms/following{/other_user}","gists_url":"https://api.github.com/users/jeroenooms/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroenooms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroenooms/subscriptions","organizations_url":"https://api.github.com/users/jeroenooms/orgs","repos_url":"https://api.github.com/users/jeroenooms/repos","events_url":"https://api.github.com/users/jeroenooms/events{/privacy}","received_events_url":"https://api.github.com/users/jeroenooms/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-12T04:38:40Z","updated_at":"2015-02-12T11:42:02Z","closed_at":"2015-02-12T11:42:02Z","body":"The `Makevars.win` has `$(SHLIB_OPENMP_CFLAGS)` but I don't think those are used? Also the `-I` statements might be better in `CPPFLAGS`? I used:\r\n\r\n```Make\r\nPKG_CPPFLAGS=-I$(QUANTLIB_ROOT)/include -I../inst/include -I. -I$(BOOSTLIB)\r\nPKG_CXXFLAGS= -fpermissive \r\nPKG_LIBS=-L$(QUANTLIB_ROOT)/lib${R_ARCH} -lQuantLib\r\n```"},"comment":{"url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/comments/74057995","html_url":"https://github.com/eddelbuettel/rquantlib/issues/12#issuecomment-74057995","issue_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/12","id":74057995,"user":{"login":"eddelbuettel","id":673121,"avatar_url":"https://avatars.githubusercontent.com/u/673121?v=3","gravatar_id":"","url":"https://api.github.com/users/eddelbuettel","html_url":"https://github.com/eddelbuettel","followers_url":"https://api.github.com/users/eddelbuettel/followers","following_url":"https://api.github.com/users/eddelbuettel/following{/other_user}","gists_url":"https://api.github.com/users/eddelbuettel/gists{/gist_id}","starred_url":"https://api.github.com/users/eddelbuettel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddelbuettel/subscriptions","organizations_url":"https://api.github.com/users/eddelbuettel/orgs","repos_url":"https://api.github.com/users/eddelbuettel/repos","events_url":"https://api.github.com/users/eddelbuettel/events{/privacy}","received_events_url":"https://api.github.com/users/eddelbuettel/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T11:42:02Z","updated_at":"2015-02-12T11:42:02Z","body":"1) As I recall the WRE manual recommends `$(SHLIB_OPENMP_CFLAGS)` etc in Section 1.2.1.1.  QL uses it so we may as well carry it along.\r\n\r\n2) The `PKG_CPPFLAGS` vs `PKG_CXXFLAGS` hardly matters.  What we currently have _works_ and does not trigger emails from a certain part of the world.  \r\n\r\nGood enough for me on both counts.  Closing this."}}