{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37855872","id":37855872,"diff_hunk":"@@ -1190,6 +1190,8 @@ type ServiceSpec struct {\n \t// Type determines how the service will be exposed.  Valid options: ClusterIP, NodePort, LoadBalancer\n \tType ServiceType `json:\"type,omitempty\"`\n \n+\tLoadBalancerIP string `json:\"loadBalancerIP, omitEmpty`","path":"pkg/api/types.go","position":4,"original_position":4,"commit_id":"2cdd4bb9e7309da19e211f1d94c36709fcb51e84","original_commit_id":"f7cd6567aaf7e583a8457d7254ef483d446ada28","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"@thockin the answer to the AWS question in no; the ELB name is assigned by AWS.  If we use Route 53 (which maybe we should) we can create a DNS record pointing to that ELB.","created_at":"2015-08-25T11:46:44Z","updated_at":"2015-08-25T11:46:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13005#discussion_r37855872","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37855872"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13005#discussion_r37855872"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005","id":42995967,"html_url":"https://github.com/kubernetes/kubernetes/pull/13005","diff_url":"https://github.com/kubernetes/kubernetes/pull/13005.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13005.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13005","number":13005,"state":"open","locked":false,"title":"Create a LB for a K8S with the LB-IP provided by user.","user":{"login":"ArtfulCoder","id":1220660,"avatar_url":"https://avatars.githubusercontent.com/u/1220660?v=3","gravatar_id":"","url":"https://api.github.com/users/ArtfulCoder","html_url":"https://github.com/ArtfulCoder","followers_url":"https://api.github.com/users/ArtfulCoder/followers","following_url":"https://api.github.com/users/ArtfulCoder/following{/other_user}","gists_url":"https://api.github.com/users/ArtfulCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtfulCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtfulCoder/subscriptions","organizations_url":"https://api.github.com/users/ArtfulCoder/orgs","repos_url":"https://api.github.com/users/ArtfulCoder/repos","events_url":"https://api.github.com/users/ArtfulCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ArtfulCoder/received_events","type":"User","site_admin":false},"body":"The LB gets created but the LB-IP gets ignored..\r\nWIP.","created_at":"2015-08-21T01:25:10Z","updated_at":"2015-08-25T11:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13005/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2cdd4bb9e7309da19e211f1d94c36709fcb51e84","head":{"label":"ArtfulCoder:createLBWithIP","ref":"createLBWithIP","sha":"2cdd4bb9e7309da19e211f1d94c36709fcb51e84","user":{"login":"ArtfulCoder","id":1220660,"avatar_url":"https://avatars.githubusercontent.com/u/1220660?v=3","gravatar_id":"","url":"https://api.github.com/users/ArtfulCoder","html_url":"https://github.com/ArtfulCoder","followers_url":"https://api.github.com/users/ArtfulCoder/followers","following_url":"https://api.github.com/users/ArtfulCoder/following{/other_user}","gists_url":"https://api.github.com/users/ArtfulCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtfulCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtfulCoder/subscriptions","organizations_url":"https://api.github.com/users/ArtfulCoder/orgs","repos_url":"https://api.github.com/users/ArtfulCoder/repos","events_url":"https://api.github.com/users/ArtfulCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ArtfulCoder/received_events","type":"User","site_admin":false},"repo":{"id":29879916,"name":"kubernetes","full_name":"ArtfulCoder/kubernetes","owner":{"login":"ArtfulCoder","id":1220660,"avatar_url":"https://avatars.githubusercontent.com/u/1220660?v=3","gravatar_id":"","url":"https://api.github.com/users/ArtfulCoder","html_url":"https://github.com/ArtfulCoder","followers_url":"https://api.github.com/users/ArtfulCoder/followers","following_url":"https://api.github.com/users/ArtfulCoder/following{/other_user}","gists_url":"https://api.github.com/users/ArtfulCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtfulCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtfulCoder/subscriptions","organizations_url":"https://api.github.com/users/ArtfulCoder/orgs","repos_url":"https://api.github.com/users/ArtfulCoder/repos","events_url":"https://api.github.com/users/ArtfulCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ArtfulCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArtfulCoder/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ArtfulCoder/kubernetes","forks_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/forks","keys_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/teams","hooks_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/events","assignees_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/tags","blobs_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/subscription","commits_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/merges","archive_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/downloads","issues_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ArtfulCoder/kubernetes/releases{/id}","created_at":"2015-01-26T20:25:09Z","updated_at":"2015-05-07T20:25:01Z","pushed_at":"2015-08-25T00:15:40Z","git_url":"git://github.com/ArtfulCoder/kubernetes.git","ssh_url":"git@github.com:ArtfulCoder/kubernetes.git","clone_url":"https://github.com/ArtfulCoder/kubernetes.git","svn_url":"https://github.com/ArtfulCoder/kubernetes","homepage":"http://kubernetes.io","size":102059,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4c88aeeda213426b9c5549e4a54826bed585460a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-25T10:36:18Z","pushed_at":"2015-08-25T11:27:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":361282,"stargazers_count":9878,"watchers_count":9878,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2388,"mirror_url":null,"open_issues_count":1771,"forks":2388,"open_issues":1771,"watchers":9878,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13005"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13005"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13005/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13005/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2cdd4bb9e7309da19e211f1d94c36709fcb51e84"}}}}