{"action":"created","comment":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments/25343991","id":25343991,"diff_hunk":"@@ -70,14 +70,18 @@ static void test_plainIniWrite(char *fileName)\n \t\t\tkeyNew (\"user/tests/ini-write/nosectionkey\",\n \t\t\t\t\tKEY_VALUE, \"nosectionvalue\",\n \t\t\t\t\tKEY_END),\n-\t\t\tkeyNew (\"user/tests/ini-write/section1\", KEY_DIR, KEY_END),\n+\t\t\tkeyNew (\"user/tests/ini-write/section1\",\n+\t\t\t\t\tKEY_BINARY,","path":"src/plugins/ini/testmod_ini.c","position":15,"original_position":15,"commit_id":"f52386852789548f37e70c83bdbe26c6ef5f7cae","original_commit_id":"57ec340f4d805c7456f721a2fef61458d2e5c464","user":{"login":"markus2330","id":7949075,"avatar_url":"https://avatars.githubusercontent.com/u/7949075?v=3","gravatar_id":"","url":"https://api.github.com/users/markus2330","html_url":"https://github.com/markus2330","followers_url":"https://api.github.com/users/markus2330/followers","following_url":"https://api.github.com/users/markus2330/following{/other_user}","gists_url":"https://api.github.com/users/markus2330/gists{/gist_id}","starred_url":"https://api.github.com/users/markus2330/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markus2330/subscriptions","organizations_url":"https://api.github.com/users/markus2330/orgs","repos_url":"https://api.github.com/users/markus2330/repos","events_url":"https://api.github.com/users/markus2330/events{/privacy}","received_events_url":"https://api.github.com/users/markus2330/received_events","type":"User","site_admin":false},"body":"Felix Berlakovich wrote:\n> As far as I can tell the KEY_BINARY flag is already part of the keyNew\n> documentation and the feature is also tested in testabi_key.c\n\nFixed in 79868f66088a136340e469520a4554313e1ef4dc\n","created_at":"2015-02-25T14:43:30Z","updated_at":"2015-02-25T14:43:30Z","html_url":"https://github.com/ElektraInitiative/libelektra/pull/178#discussion_r25343991","pull_request_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments/25343991"},"html":{"href":"https://github.com/ElektraInitiative/libelektra/pull/178#discussion_r25343991"},"pull_request":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178","id":27876350,"html_url":"https://github.com/ElektraInitiative/libelektra/pull/178","diff_url":"https://github.com/ElektraInitiative/libelektra/pull/178.diff","patch_url":"https://github.com/ElektraInitiative/libelektra/pull/178.patch","issue_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/178","number":178,"state":"open","locked":false,"title":"Ini hierarchies","user":{"login":"fberlakovich","id":7955528,"avatar_url":"https://avatars.githubusercontent.com/u/7955528?v=3","gravatar_id":"","url":"https://api.github.com/users/fberlakovich","html_url":"https://github.com/fberlakovich","followers_url":"https://api.github.com/users/fberlakovich/followers","following_url":"https://api.github.com/users/fberlakovich/following{/other_user}","gists_url":"https://api.github.com/users/fberlakovich/gists{/gist_id}","starred_url":"https://api.github.com/users/fberlakovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fberlakovich/subscriptions","organizations_url":"https://api.github.com/users/fberlakovich/orgs","repos_url":"https://api.github.com/users/fberlakovich/repos","events_url":"https://api.github.com/users/fberlakovich/events{/privacy}","received_events_url":"https://api.github.com/users/fberlakovich/received_events","type":"User","site_admin":false},"body":"A first proposal of how the improved ini section handling discussed in #138 could look like. The plugin behaves as follows:\r\n* keys with a NULL value (i.e. binary keys with value 0) are treated as sections\r\n* all other keys are treated as plain ini keys\r\n* if the autosection option exists, the plugin will automatically create a section entry on write for keys with a level greater than 1 relative to the parent key (see the autosection testcase for a illustrative example)\r\n\r\nIf you like it this way, I will update the README accordingly. Additionally an option would be thinkable that prevents uses `keyChangeName` to directly use the names of ini keys / sections (see #138) for an example. If you have any further ideas on how to make the the use of the plugin more intuitive, please don't hesitate to ask.","created_at":"2015-01-22T20:46:41Z","updated_at":"2015-02-25T14:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dc85ff84657b4b0ac2e653376c9363d4499b699","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178/commits","review_comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178/comments","review_comment_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/178/comments","statuses_url":"https://api.github.com/repos/ElektraInitiative/libelektra/statuses/f52386852789548f37e70c83bdbe26c6ef5f7cae","head":{"label":"fberlakovich:ini-hierarchies","ref":"ini-hierarchies","sha":"f52386852789548f37e70c83bdbe26c6ef5f7cae","user":{"login":"fberlakovich","id":7955528,"avatar_url":"https://avatars.githubusercontent.com/u/7955528?v=3","gravatar_id":"","url":"https://api.github.com/users/fberlakovich","html_url":"https://github.com/fberlakovich","followers_url":"https://api.github.com/users/fberlakovich/followers","following_url":"https://api.github.com/users/fberlakovich/following{/other_user}","gists_url":"https://api.github.com/users/fberlakovich/gists{/gist_id}","starred_url":"https://api.github.com/users/fberlakovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fberlakovich/subscriptions","organizations_url":"https://api.github.com/users/fberlakovich/orgs","repos_url":"https://api.github.com/users/fberlakovich/repos","events_url":"https://api.github.com/users/fberlakovich/events{/privacy}","received_events_url":"https://api.github.com/users/fberlakovich/received_events","type":"User","site_admin":false},"repo":{"id":21090441,"name":"libelektra","full_name":"fberlakovich/libelektra","owner":{"login":"fberlakovich","id":7955528,"avatar_url":"https://avatars.githubusercontent.com/u/7955528?v=3","gravatar_id":"","url":"https://api.github.com/users/fberlakovich","html_url":"https://github.com/fberlakovich","followers_url":"https://api.github.com/users/fberlakovich/followers","following_url":"https://api.github.com/users/fberlakovich/following{/other_user}","gists_url":"https://api.github.com/users/fberlakovich/gists{/gist_id}","starred_url":"https://api.github.com/users/fberlakovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fberlakovich/subscriptions","organizations_url":"https://api.github.com/users/fberlakovich/orgs","repos_url":"https://api.github.com/users/fberlakovich/repos","events_url":"https://api.github.com/users/fberlakovich/events{/privacy}","received_events_url":"https://api.github.com/users/fberlakovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fberlakovich/libelektra","description":"Elektra provides a universal and secure framework to store configuration parameters in a global, hierarchical key database.","fork":true,"url":"https://api.github.com/repos/fberlakovich/libelektra","forks_url":"https://api.github.com/repos/fberlakovich/libelektra/forks","keys_url":"https://api.github.com/repos/fberlakovich/libelektra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fberlakovich/libelektra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fberlakovich/libelektra/teams","hooks_url":"https://api.github.com/repos/fberlakovich/libelektra/hooks","issue_events_url":"https://api.github.com/repos/fberlakovich/libelektra/issues/events{/number}","events_url":"https://api.github.com/repos/fberlakovich/libelektra/events","assignees_url":"https://api.github.com/repos/fberlakovich/libelektra/assignees{/user}","branches_url":"https://api.github.com/repos/fberlakovich/libelektra/branches{/branch}","tags_url":"https://api.github.com/repos/fberlakovich/libelektra/tags","blobs_url":"https://api.github.com/repos/fberlakovich/libelektra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fberlakovich/libelektra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fberlakovich/libelektra/git/refs{/sha}","trees_url":"https://api.github.com/repos/fberlakovich/libelektra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fberlakovich/libelektra/statuses/{sha}","languages_url":"https://api.github.com/repos/fberlakovich/libelektra/languages","stargazers_url":"https://api.github.com/repos/fberlakovich/libelektra/stargazers","contributors_url":"https://api.github.com/repos/fberlakovich/libelektra/contributors","subscribers_url":"https://api.github.com/repos/fberlakovich/libelektra/subscribers","subscription_url":"https://api.github.com/repos/fberlakovich/libelektra/subscription","commits_url":"https://api.github.com/repos/fberlakovich/libelektra/commits{/sha}","git_commits_url":"https://api.github.com/repos/fberlakovich/libelektra/git/commits{/sha}","comments_url":"https://api.github.com/repos/fberlakovich/libelektra/comments{/number}","issue_comment_url":"https://api.github.com/repos/fberlakovich/libelektra/issues/comments{/number}","contents_url":"https://api.github.com/repos/fberlakovich/libelektra/contents/{+path}","compare_url":"https://api.github.com/repos/fberlakovich/libelektra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fberlakovich/libelektra/merges","archive_url":"https://api.github.com/repos/fberlakovich/libelektra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fberlakovich/libelektra/downloads","issues_url":"https://api.github.com/repos/fberlakovich/libelektra/issues{/number}","pulls_url":"https://api.github.com/repos/fberlakovich/libelektra/pulls{/number}","milestones_url":"https://api.github.com/repos/fberlakovich/libelektra/milestones{/number}","notifications_url":"https://api.github.com/repos/fberlakovich/libelektra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fberlakovich/libelektra/labels{/name}","releases_url":"https://api.github.com/repos/fberlakovich/libelektra/releases{/id}","created_at":"2014-06-22T09:51:22Z","updated_at":"2015-01-24T18:13:10Z","pushed_at":"2015-02-24T20:55:07Z","git_url":"git://github.com/fberlakovich/libelektra.git","ssh_url":"git@github.com:fberlakovich/libelektra.git","clone_url":"https://github.com/fberlakovich/libelektra.git","svn_url":"https://github.com/fberlakovich/libelektra","homepage":"","size":27477,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ElektraInitiative:master","ref":"master","sha":"cf90f9a873432d05c9f5bf7f23f6ad1fceeab991","user":{"login":"ElektraInitiative","id":7949092,"avatar_url":"https://avatars.githubusercontent.com/u/7949092?v=3","gravatar_id":"","url":"https://api.github.com/users/ElektraInitiative","html_url":"https://github.com/ElektraInitiative","followers_url":"https://api.github.com/users/ElektraInitiative/followers","following_url":"https://api.github.com/users/ElektraInitiative/following{/other_user}","gists_url":"https://api.github.com/users/ElektraInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/ElektraInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElektraInitiative/subscriptions","organizations_url":"https://api.github.com/users/ElektraInitiative/orgs","repos_url":"https://api.github.com/users/ElektraInitiative/repos","events_url":"https://api.github.com/users/ElektraInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/ElektraInitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":21063580,"name":"libelektra","full_name":"ElektraInitiative/libelektra","owner":{"login":"ElektraInitiative","id":7949092,"avatar_url":"https://avatars.githubusercontent.com/u/7949092?v=3","gravatar_id":"","url":"https://api.github.com/users/ElektraInitiative","html_url":"https://github.com/ElektraInitiative","followers_url":"https://api.github.com/users/ElektraInitiative/followers","following_url":"https://api.github.com/users/ElektraInitiative/following{/other_user}","gists_url":"https://api.github.com/users/ElektraInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/ElektraInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElektraInitiative/subscriptions","organizations_url":"https://api.github.com/users/ElektraInitiative/orgs","repos_url":"https://api.github.com/users/ElektraInitiative/repos","events_url":"https://api.github.com/users/ElektraInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/ElektraInitiative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElektraInitiative/libelektra","description":"Elektra provides a universal and secure framework to store configuration parameters in a global, hierarchical key database.","fork":false,"url":"https://api.github.com/repos/ElektraInitiative/libelektra","forks_url":"https://api.github.com/repos/ElektraInitiative/libelektra/forks","keys_url":"https://api.github.com/repos/ElektraInitiative/libelektra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElektraInitiative/libelektra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElektraInitiative/libelektra/teams","hooks_url":"https://api.github.com/repos/ElektraInitiative/libelektra/hooks","issue_events_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/events{/number}","events_url":"https://api.github.com/repos/ElektraInitiative/libelektra/events","assignees_url":"https://api.github.com/repos/ElektraInitiative/libelektra/assignees{/user}","branches_url":"https://api.github.com/repos/ElektraInitiative/libelektra/branches{/branch}","tags_url":"https://api.github.com/repos/ElektraInitiative/libelektra/tags","blobs_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElektraInitiative/libelektra/statuses/{sha}","languages_url":"https://api.github.com/repos/ElektraInitiative/libelektra/languages","stargazers_url":"https://api.github.com/repos/ElektraInitiative/libelektra/stargazers","contributors_url":"https://api.github.com/repos/ElektraInitiative/libelektra/contributors","subscribers_url":"https://api.github.com/repos/ElektraInitiative/libelektra/subscribers","subscription_url":"https://api.github.com/repos/ElektraInitiative/libelektra/subscription","commits_url":"https://api.github.com/repos/ElektraInitiative/libelektra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElektraInitiative/libelektra/contents/{+path}","compare_url":"https://api.github.com/repos/ElektraInitiative/libelektra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElektraInitiative/libelektra/merges","archive_url":"https://api.github.com/repos/ElektraInitiative/libelektra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElektraInitiative/libelektra/downloads","issues_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues{/number}","pulls_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls{/number}","milestones_url":"https://api.github.com/repos/ElektraInitiative/libelektra/milestones{/number}","notifications_url":"https://api.github.com/repos/ElektraInitiative/libelektra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElektraInitiative/libelektra/labels{/name}","releases_url":"https://api.github.com/repos/ElektraInitiative/libelektra/releases{/id}","created_at":"2014-06-21T08:01:04Z","updated_at":"2015-02-25T14:43:00Z","pushed_at":"2015-02-25T14:43:00Z","git_url":"git://github.com/ElektraInitiative/libelektra.git","ssh_url":"git@github.com:ElektraInitiative/libelektra.git","clone_url":"https://github.com/ElektraInitiative/libelektra.git","svn_url":"https://github.com/ElektraInitiative/libelektra","homepage":"","size":29336,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":26,"forks":8,"open_issues":26,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178"},"html":{"href":"https://github.com/ElektraInitiative/libelektra/pull/178"},"issue":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/178"},"comments":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/statuses/f52386852789548f37e70c83bdbe26c6ef5f7cae"}}}}