{"action":"created","comment":{"url":"https://api.github.com/repos/cylc/cylc/pulls/comments/39939061","id":39939061,"diff_hunk":"@@ -67,7 +68,7 @@ def acceptIdentification(self, daemon, connection, token, challenge):\n             # Back compat for old suite client (passphrase only)\n             # (Allows old scan to see new suites.)\n             proc_passwd = token\n-            user = host = uuid = prog_name = \"(old-client)\"\n+            is_old_daemon = True","path":"lib/cylc/network/connection_validator.py","position":13,"original_position":13,"commit_id":"a42123b19d330268033ed3337166879111efec30","original_commit_id":"a42123b19d330268033ed3337166879111efec30","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"body":"Should be `is_old_client`!","created_at":"2015-09-21T02:34:36Z","updated_at":"2015-09-21T02:34:36Z","html_url":"https://github.com/cylc/cylc/pull/1612#discussion_r39939061","pull_request_url":"https://api.github.com/repos/cylc/cylc/pulls/1612","_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments/39939061"},"html":{"href":"https://github.com/cylc/cylc/pull/1612#discussion_r39939061"},"pull_request":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1612"}}},"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/1612","id":45386678,"html_url":"https://github.com/cylc/cylc/pull/1612","diff_url":"https://github.com/cylc/cylc/pull/1612.diff","patch_url":"https://github.com/cylc/cylc/pull/1612.patch","issue_url":"https://api.github.com/repos/cylc/cylc/issues/1612","number":1612,"state":"open","locked":false,"title":"cylc authentication: don't report old client fails","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"body":"This fixes #1578.\r\n\r\n@matthewrmshin, please review 1.\r\n@hjoliver, please review 2.","created_at":"2015-09-18T09:35:08Z","updated_at":"2015-09-21T02:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccf6d3c7c792d0b53f1c1dea2141cc08e3b5c76b","assignee":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/41","html_url":"https://github.com/cylc/cylc/milestones/next%20release","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/41/labels","id":1276926,"number":41,"title":"next release","description":"","creator":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":27,"state":"open","created_at":"2015-08-28T03:24:26Z","updated_at":"2015-09-18T20:16:49Z","due_on":"2015-09-24T12:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cylc/cylc/pulls/1612/commits","review_comments_url":"https://api.github.com/repos/cylc/cylc/pulls/1612/comments","review_comment_url":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/1612/comments","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/a42123b19d330268033ed3337166879111efec30","head":{"label":"benfitzpatrick:1578.old-clients-log","ref":"1578.old-clients-log","sha":"a42123b19d330268033ed3337166879111efec30","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"repo":{"id":2606625,"name":"cylc","full_name":"benfitzpatrick/cylc","owner":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfitzpatrick/cylc","description":"The cylc forecast suite metascheduler","fork":true,"url":"https://api.github.com/repos/benfitzpatrick/cylc","forks_url":"https://api.github.com/repos/benfitzpatrick/cylc/forks","keys_url":"https://api.github.com/repos/benfitzpatrick/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfitzpatrick/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfitzpatrick/cylc/teams","hooks_url":"https://api.github.com/repos/benfitzpatrick/cylc/hooks","issue_events_url":"https://api.github.com/repos/benfitzpatrick/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/benfitzpatrick/cylc/events","assignees_url":"https://api.github.com/repos/benfitzpatrick/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/benfitzpatrick/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/benfitzpatrick/cylc/tags","blobs_url":"https://api.github.com/repos/benfitzpatrick/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfitzpatrick/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfitzpatrick/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfitzpatrick/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfitzpatrick/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/benfitzpatrick/cylc/languages","stargazers_url":"https://api.github.com/repos/benfitzpatrick/cylc/stargazers","contributors_url":"https://api.github.com/repos/benfitzpatrick/cylc/contributors","subscribers_url":"https://api.github.com/repos/benfitzpatrick/cylc/subscribers","subscription_url":"https://api.github.com/repos/benfitzpatrick/cylc/subscription","commits_url":"https://api.github.com/repos/benfitzpatrick/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfitzpatrick/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfitzpatrick/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfitzpatrick/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfitzpatrick/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/benfitzpatrick/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfitzpatrick/cylc/merges","archive_url":"https://api.github.com/repos/benfitzpatrick/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfitzpatrick/cylc/downloads","issues_url":"https://api.github.com/repos/benfitzpatrick/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/benfitzpatrick/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/benfitzpatrick/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/benfitzpatrick/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfitzpatrick/cylc/labels{/name}","releases_url":"https://api.github.com/repos/benfitzpatrick/cylc/releases{/id}","created_at":"2011-10-19T14:47:18Z","updated_at":"2015-03-16T11:30:50Z","pushed_at":"2015-09-18T16:15:26Z","git_url":"git://github.com/benfitzpatrick/cylc.git","ssh_url":"git@github.com:benfitzpatrick/cylc.git","clone_url":"https://github.com/benfitzpatrick/cylc.git","svn_url":"https://github.com/benfitzpatrick/cylc","homepage":"https://github.com/cylc/cylc","size":98339,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"cylc:master","ref":"master","sha":"6a0dfc4422da8580bf3b5f7aa587dbeb37d964b9","user":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=3","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"repo":{"id":1836229,"name":"cylc","full_name":"cylc/cylc","owner":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=3","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cylc/cylc","description":"This is the official repository of the cylc suite engine. It will normally contain just the master branch, with completed features merged in from feature branches in developer forks.","fork":false,"url":"https://api.github.com/repos/cylc/cylc","forks_url":"https://api.github.com/repos/cylc/cylc/forks","keys_url":"https://api.github.com/repos/cylc/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cylc/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cylc/cylc/teams","hooks_url":"https://api.github.com/repos/cylc/cylc/hooks","issue_events_url":"https://api.github.com/repos/cylc/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/cylc/cylc/events","assignees_url":"https://api.github.com/repos/cylc/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/cylc/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/cylc/cylc/tags","blobs_url":"https://api.github.com/repos/cylc/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cylc/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cylc/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cylc/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/cylc/cylc/languages","stargazers_url":"https://api.github.com/repos/cylc/cylc/stargazers","contributors_url":"https://api.github.com/repos/cylc/cylc/contributors","subscribers_url":"https://api.github.com/repos/cylc/cylc/subscribers","subscription_url":"https://api.github.com/repos/cylc/cylc/subscription","commits_url":"https://api.github.com/repos/cylc/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cylc/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cylc/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cylc/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cylc/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/cylc/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cylc/cylc/merges","archive_url":"https://api.github.com/repos/cylc/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cylc/cylc/downloads","issues_url":"https://api.github.com/repos/cylc/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/cylc/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/cylc/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/cylc/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cylc/cylc/labels{/name}","releases_url":"https://api.github.com/repos/cylc/cylc/releases{/id}","created_at":"2011-06-02T08:31:49Z","updated_at":"2015-08-07T18:55:43Z","pushed_at":"2015-09-18T16:17:00Z","git_url":"git://github.com/cylc/cylc.git","ssh_url":"git@github.com:cylc/cylc.git","clone_url":"https://github.com/cylc/cylc.git","svn_url":"https://github.com/cylc/cylc","homepage":"http://cylc.github.com/cylc","size":97734,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":171,"forks":18,"open_issues":171,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1612"},"html":{"href":"https://github.com/cylc/cylc/pull/1612"},"issue":{"href":"https://api.github.com/repos/cylc/cylc/issues/1612"},"comments":{"href":"https://api.github.com/repos/cylc/cylc/issues/1612/comments"},"review_comments":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1612/comments"},"review_comment":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1612/commits"},"statuses":{"href":"https://api.github.com/repos/cylc/cylc/statuses/a42123b19d330268033ed3337166879111efec30"}}}}