{"action":"created","comment":{"url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments/32451590","id":32451590,"diff_hunk":"@@ -3838,23 +3834,25 @@ def as_json(self):\n     def get_type(self):\n         return AddLabelAction.TYPE\n \n-    def execute(self, run, actionset, sms):\n+    def execute(self, run, actionset, msg):\n         for label in self.labels:\n             if not isinstance(label, Label):\n                 contact = run.contact\n-                message_context = run.flow.build_message_context(contact, sms)\n+                message_context = run.flow.build_message_context(contact, msg)\n                 (value, missing) = Msg.substitute_variables(label, contact, message_context, org=run.flow.org)\n-                try:\n-                    label = Label.objects.get(org=contact.org, name=value)\n-                except:\n-                    label = Label.create_unique(contact.org, contact.org.get_user(), value)\n+\n+                if not missing:\n+                    label = Label.get_or_create(contact.org, contact.org.get_user(), value)\n                     if run.contact.is_test:\n-                        ActionLog.create(run, _(\"Label '%s' created\") % value)\n+                        ActionLog.create(run, _(\"Label '%s' created\") % label.name)\n+                else:\n+                    # TODO should be recorded in the action log as an error","path":"temba/flows/models.py","position":64,"original_position":64,"commit_id":"ae30a5a50ca09b397304621ef367e81005158d0e","original_commit_id":"ae30a5a50ca09b397304621ef367e81005158d0e","user":{"login":"rowanseymour","id":675558,"avatar_url":"https://avatars.githubusercontent.com/u/675558?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanseymour","html_url":"https://github.com/rowanseymour","followers_url":"https://api.github.com/users/rowanseymour/followers","following_url":"https://api.github.com/users/rowanseymour/following{/other_user}","gists_url":"https://api.github.com/users/rowanseymour/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanseymour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanseymour/subscriptions","organizations_url":"https://api.github.com/users/rowanseymour/orgs","repos_url":"https://api.github.com/users/rowanseymour/repos","events_url":"https://api.github.com/users/rowanseymour/events{/privacy}","received_events_url":"https://api.github.com/users/rowanseymour/received_events","type":"User","site_admin":false},"body":"@ericnewcomer what do you think about this? What should we do when a label name is variable substitution which doesn't match anything","created_at":"2015-06-15T18:34:18Z","updated_at":"2015-06-15T18:34:18Z","html_url":"https://github.com/nyaruka/rapidpro/pull/219#discussion_r32451590","pull_request_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219","_links":{"self":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments/32451590"},"html":{"href":"https://github.com/nyaruka/rapidpro/pull/219#discussion_r32451590"},"pull_request":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219","id":37700611,"html_url":"https://github.com/nyaruka/rapidpro/pull/219","diff_url":"https://github.com/nyaruka/rapidpro/pull/219.diff","patch_url":"https://github.com/nyaruka/rapidpro/pull/219.patch","issue_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/219","number":219,"state":"open","locked":false,"title":"Replace parent message labels with folders of labels","user":{"login":"rowanseymour","id":675558,"avatar_url":"https://avatars.githubusercontent.com/u/675558?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanseymour","html_url":"https://github.com/rowanseymour","followers_url":"https://api.github.com/users/rowanseymour/followers","following_url":"https://api.github.com/users/rowanseymour/following{/other_user}","gists_url":"https://api.github.com/users/rowanseymour/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanseymour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanseymour/subscriptions","organizations_url":"https://api.github.com/users/rowanseymour/orgs","repos_url":"https://api.github.com/users/rowanseymour/repos","events_url":"https://api.github.com/users/rowanseymour/events{/privacy}","received_events_url":"https://api.github.com/users/rowanseymour/received_events","type":"User","site_admin":false},"body":"Also cleaned up several unit tests that use user instances from the test super class.","created_at":"2015-06-15T14:59:24Z","updated_at":"2015-06-15T18:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3980d2686b04e47bdf573bdaf1970a27421caa44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219/commits","review_comments_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219/comments","review_comment_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/219/comments","statuses_url":"https://api.github.com/repos/nyaruka/rapidpro/statuses/ae30a5a50ca09b397304621ef367e81005158d0e","head":{"label":"nyaruka:label_folders","ref":"label_folders","sha":"ae30a5a50ca09b397304621ef367e81005158d0e","user":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"repo":{"id":27415685,"name":"rapidpro","full_name":"nyaruka/rapidpro","owner":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nyaruka/rapidpro","description":"RapidPro is a hosted service allowing organizations to visually build scalable interactive messaging applications.","fork":true,"url":"https://api.github.com/repos/nyaruka/rapidpro","forks_url":"https://api.github.com/repos/nyaruka/rapidpro/forks","keys_url":"https://api.github.com/repos/nyaruka/rapidpro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyaruka/rapidpro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyaruka/rapidpro/teams","hooks_url":"https://api.github.com/repos/nyaruka/rapidpro/hooks","issue_events_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/events{/number}","events_url":"https://api.github.com/repos/nyaruka/rapidpro/events","assignees_url":"https://api.github.com/repos/nyaruka/rapidpro/assignees{/user}","branches_url":"https://api.github.com/repos/nyaruka/rapidpro/branches{/branch}","tags_url":"https://api.github.com/repos/nyaruka/rapidpro/tags","blobs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyaruka/rapidpro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyaruka/rapidpro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyaruka/rapidpro/statuses/{sha}","languages_url":"https://api.github.com/repos/nyaruka/rapidpro/languages","stargazers_url":"https://api.github.com/repos/nyaruka/rapidpro/stargazers","contributors_url":"https://api.github.com/repos/nyaruka/rapidpro/contributors","subscribers_url":"https://api.github.com/repos/nyaruka/rapidpro/subscribers","subscription_url":"https://api.github.com/repos/nyaruka/rapidpro/subscription","commits_url":"https://api.github.com/repos/nyaruka/rapidpro/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyaruka/rapidpro/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyaruka/rapidpro/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyaruka/rapidpro/contents/{+path}","compare_url":"https://api.github.com/repos/nyaruka/rapidpro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyaruka/rapidpro/merges","archive_url":"https://api.github.com/repos/nyaruka/rapidpro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyaruka/rapidpro/downloads","issues_url":"https://api.github.com/repos/nyaruka/rapidpro/issues{/number}","pulls_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls{/number}","milestones_url":"https://api.github.com/repos/nyaruka/rapidpro/milestones{/number}","notifications_url":"https://api.github.com/repos/nyaruka/rapidpro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyaruka/rapidpro/labels{/name}","releases_url":"https://api.github.com/repos/nyaruka/rapidpro/releases{/id}","created_at":"2014-12-02T04:53:16Z","updated_at":"2015-05-08T12:28:17Z","pushed_at":"2015-06-15T18:28:51Z","git_url":"git://github.com/nyaruka/rapidpro.git","ssh_url":"git@github.com:nyaruka/rapidpro.git","clone_url":"https://github.com/nyaruka/rapidpro.git","svn_url":"https://github.com/nyaruka/rapidpro","homepage":null,"size":21841,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"nyaruka:master","ref":"master","sha":"3ee6ec234047e4283f9696f4a12a4149b359fa1b","user":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"repo":{"id":27415685,"name":"rapidpro","full_name":"nyaruka/rapidpro","owner":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nyaruka/rapidpro","description":"RapidPro is a hosted service allowing organizations to visually build scalable interactive messaging applications.","fork":true,"url":"https://api.github.com/repos/nyaruka/rapidpro","forks_url":"https://api.github.com/repos/nyaruka/rapidpro/forks","keys_url":"https://api.github.com/repos/nyaruka/rapidpro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyaruka/rapidpro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyaruka/rapidpro/teams","hooks_url":"https://api.github.com/repos/nyaruka/rapidpro/hooks","issue_events_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/events{/number}","events_url":"https://api.github.com/repos/nyaruka/rapidpro/events","assignees_url":"https://api.github.com/repos/nyaruka/rapidpro/assignees{/user}","branches_url":"https://api.github.com/repos/nyaruka/rapidpro/branches{/branch}","tags_url":"https://api.github.com/repos/nyaruka/rapidpro/tags","blobs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyaruka/rapidpro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyaruka/rapidpro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyaruka/rapidpro/statuses/{sha}","languages_url":"https://api.github.com/repos/nyaruka/rapidpro/languages","stargazers_url":"https://api.github.com/repos/nyaruka/rapidpro/stargazers","contributors_url":"https://api.github.com/repos/nyaruka/rapidpro/contributors","subscribers_url":"https://api.github.com/repos/nyaruka/rapidpro/subscribers","subscription_url":"https://api.github.com/repos/nyaruka/rapidpro/subscription","commits_url":"https://api.github.com/repos/nyaruka/rapidpro/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyaruka/rapidpro/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyaruka/rapidpro/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyaruka/rapidpro/contents/{+path}","compare_url":"https://api.github.com/repos/nyaruka/rapidpro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyaruka/rapidpro/merges","archive_url":"https://api.github.com/repos/nyaruka/rapidpro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyaruka/rapidpro/downloads","issues_url":"https://api.github.com/repos/nyaruka/rapidpro/issues{/number}","pulls_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls{/number}","milestones_url":"https://api.github.com/repos/nyaruka/rapidpro/milestones{/number}","notifications_url":"https://api.github.com/repos/nyaruka/rapidpro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyaruka/rapidpro/labels{/name}","releases_url":"https://api.github.com/repos/nyaruka/rapidpro/releases{/id}","created_at":"2014-12-02T04:53:16Z","updated_at":"2015-05-08T12:28:17Z","pushed_at":"2015-06-15T18:28:51Z","git_url":"git://github.com/nyaruka/rapidpro.git","ssh_url":"git@github.com:nyaruka/rapidpro.git","clone_url":"https://github.com/nyaruka/rapidpro.git","svn_url":"https://github.com/nyaruka/rapidpro","homepage":null,"size":21841,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219"},"html":{"href":"https://github.com/nyaruka/rapidpro/pull/219"},"issue":{"href":"https://api.github.com/repos/nyaruka/rapidpro/issues/219"},"comments":{"href":"https://api.github.com/repos/nyaruka/rapidpro/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/nyaruka/rapidpro/statuses/ae30a5a50ca09b397304621ef367e81005158d0e"}}}}