{"action":"created","comment":{"url":"https://api.github.com/repos/adsabs/bumblebee/pulls/comments/28423219","id":28423219,"diff_hunk":"@@ -31,7 +31,7 @@ define([\n       return true;\n     };\n     var allowedAttrs = {\n-      query: function(v) {return v instanceof ApiQuery},\n+      query: basicCheck,","path":"src/js/components/default_request.js","position":5,"original_position":5,"commit_id":"5235afa2706399afa372374bce9be31685caf8f3","original_commit_id":"5235afa2706399afa372374bce9be31685caf8f3","user":{"login":"romanchyla","id":411794,"avatar_url":"https://avatars.githubusercontent.com/u/411794?v=3","gravatar_id":"","url":"https://api.github.com/users/romanchyla","html_url":"https://github.com/romanchyla","followers_url":"https://api.github.com/users/romanchyla/followers","following_url":"https://api.github.com/users/romanchyla/following{/other_user}","gists_url":"https://api.github.com/users/romanchyla/gists{/gist_id}","starred_url":"https://api.github.com/users/romanchyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanchyla/subscriptions","organizations_url":"https://api.github.com/users/romanchyla/orgs","repos_url":"https://api.github.com/users/romanchyla/repos","events_url":"https://api.github.com/users/romanchyla/events{/privacy}","received_events_url":"https://api.github.com/users/romanchyla/received_events","type":"User","site_admin":false},"body":"v !== undefined\nOn Apr 14, 2015 4:10 PM, \"Alex\" <notifications@github.com> wrote:\n\n> In src/js/components/default_request.js\n> <https://github.com/adsabs/bumblebee/pull/336#discussion_r28365273>:\n>\n> > @@ -31,7 +31,7 @@ define([\n> >        return true;\n> >      };\n> >      var allowedAttrs = {\n> > -      query: function(v) {return v instanceof ApiQuery},\n> > +      query: basicCheck,\n>\n> should it be\n> query: function(v) { if (v) {return v instanceof ApiQuery}} ?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/adsabs/bumblebee/pull/336/files#r28365273>.\n>\n","created_at":"2015-04-15T14:20:30Z","updated_at":"2015-04-15T14:20:30Z","html_url":"https://github.com/adsabs/bumblebee/pull/336#discussion_r28423219","pull_request_url":"https://api.github.com/repos/adsabs/bumblebee/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/adsabs/bumblebee/pulls/comments/28423219"},"html":{"href":"https://github.com/adsabs/bumblebee/pull/336#discussion_r28423219"},"pull_request":{"href":"https://api.github.com/repos/adsabs/bumblebee/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/adsabs/bumblebee/pulls/336","id":33195855,"html_url":"https://github.com/adsabs/bumblebee/pull/336","diff_url":"https://github.com/adsabs/bumblebee/pull/336.diff","patch_url":"https://github.com/adsabs/bumblebee/pull/336.patch","issue_url":"https://api.github.com/repos/adsabs/bumblebee/issues/336","number":336,"state":"open","locked":false,"title":"finished recommender","user":{"login":"aholachek","id":3680488,"avatar_url":"https://avatars.githubusercontent.com/u/3680488?v=3","gravatar_id":"","url":"https://api.github.com/users/aholachek","html_url":"https://github.com/aholachek","followers_url":"https://api.github.com/users/aholachek/followers","following_url":"https://api.github.com/users/aholachek/following{/other_user}","gists_url":"https://api.github.com/users/aholachek/gists{/gist_id}","starred_url":"https://api.github.com/users/aholachek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aholachek/subscriptions","organizations_url":"https://api.github.com/users/aholachek/orgs","repos_url":"https://api.github.com/users/aholachek/repos","events_url":"https://api.github.com/users/aholachek/events{/privacy}","received_events_url":"https://api.github.com/users/aholachek/received_events","type":"User","site_admin":false},"body":"Hi Roman,\r\n\r\nThe recommender widget is simple but it brings up two issues that affect other widgets:\r\n\r\n1. There doesn't need to be an api query in an api request, for some endpoints (recommender, graphics) the \"target\" is enough because it has the bibcode in it\r\n2. The 404 throwing an error issue that I tried to address with the graphics widget pull request. But that pull request checks if the 404 comes from the graphics endpoint, so it wouldn't take into account the 404 issue from the recommender endpoint or citation helper endpoint.\r\n\r\nI removed the requirement for the query in the discovery_mediator, default_request, and api.js. I commented out the test in api_request.spec.js that checks the query validation, should I just remove it?","created_at":"2015-04-13T19:37:46Z","updated_at":"2015-04-15T14:20:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e357d7cd72ab38ec026d6bd79b2607849faf386","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adsabs/bumblebee/pulls/336/commits","review_comments_url":"https://api.github.com/repos/adsabs/bumblebee/pulls/336/comments","review_comment_url":"https://api.github.com/repos/adsabs/bumblebee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adsabs/bumblebee/issues/336/comments","statuses_url":"https://api.github.com/repos/adsabs/bumblebee/statuses/5235afa2706399afa372374bce9be31685caf8f3","head":{"label":"aholachek:recommender","ref":"recommender","sha":"5235afa2706399afa372374bce9be31685caf8f3","user":{"login":"aholachek","id":3680488,"avatar_url":"https://avatars.githubusercontent.com/u/3680488?v=3","gravatar_id":"","url":"https://api.github.com/users/aholachek","html_url":"https://github.com/aholachek","followers_url":"https://api.github.com/users/aholachek/followers","following_url":"https://api.github.com/users/aholachek/following{/other_user}","gists_url":"https://api.github.com/users/aholachek/gists{/gist_id}","starred_url":"https://api.github.com/users/aholachek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aholachek/subscriptions","organizations_url":"https://api.github.com/users/aholachek/orgs","repos_url":"https://api.github.com/users/aholachek/repos","events_url":"https://api.github.com/users/aholachek/events{/privacy}","received_events_url":"https://api.github.com/users/aholachek/received_events","type":"User","site_admin":false},"repo":{"id":17230633,"name":"bumblebee","full_name":"aholachek/bumblebee","owner":{"login":"aholachek","id":3680488,"avatar_url":"https://avatars.githubusercontent.com/u/3680488?v=3","gravatar_id":"","url":"https://api.github.com/users/aholachek","html_url":"https://github.com/aholachek","followers_url":"https://api.github.com/users/aholachek/followers","following_url":"https://api.github.com/users/aholachek/following{/other_user}","gists_url":"https://api.github.com/users/aholachek/gists{/gist_id}","starred_url":"https://api.github.com/users/aholachek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aholachek/subscriptions","organizations_url":"https://api.github.com/users/aholachek/orgs","repos_url":"https://api.github.com/users/aholachek/repos","events_url":"https://api.github.com/users/aholachek/events{/privacy}","received_events_url":"https://api.github.com/users/aholachek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aholachek/bumblebee","description":"Clever face for BEER","fork":true,"url":"https://api.github.com/repos/aholachek/bumblebee","forks_url":"https://api.github.com/repos/aholachek/bumblebee/forks","keys_url":"https://api.github.com/repos/aholachek/bumblebee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aholachek/bumblebee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aholachek/bumblebee/teams","hooks_url":"https://api.github.com/repos/aholachek/bumblebee/hooks","issue_events_url":"https://api.github.com/repos/aholachek/bumblebee/issues/events{/number}","events_url":"https://api.github.com/repos/aholachek/bumblebee/events","assignees_url":"https://api.github.com/repos/aholachek/bumblebee/assignees{/user}","branches_url":"https://api.github.com/repos/aholachek/bumblebee/branches{/branch}","tags_url":"https://api.github.com/repos/aholachek/bumblebee/tags","blobs_url":"https://api.github.com/repos/aholachek/bumblebee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aholachek/bumblebee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aholachek/bumblebee/git/refs{/sha}","trees_url":"https://api.github.com/repos/aholachek/bumblebee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aholachek/bumblebee/statuses/{sha}","languages_url":"https://api.github.com/repos/aholachek/bumblebee/languages","stargazers_url":"https://api.github.com/repos/aholachek/bumblebee/stargazers","contributors_url":"https://api.github.com/repos/aholachek/bumblebee/contributors","subscribers_url":"https://api.github.com/repos/aholachek/bumblebee/subscribers","subscription_url":"https://api.github.com/repos/aholachek/bumblebee/subscription","commits_url":"https://api.github.com/repos/aholachek/bumblebee/commits{/sha}","git_commits_url":"https://api.github.com/repos/aholachek/bumblebee/git/commits{/sha}","comments_url":"https://api.github.com/repos/aholachek/bumblebee/comments{/number}","issue_comment_url":"https://api.github.com/repos/aholachek/bumblebee/issues/comments{/number}","contents_url":"https://api.github.com/repos/aholachek/bumblebee/contents/{+path}","compare_url":"https://api.github.com/repos/aholachek/bumblebee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aholachek/bumblebee/merges","archive_url":"https://api.github.com/repos/aholachek/bumblebee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aholachek/bumblebee/downloads","issues_url":"https://api.github.com/repos/aholachek/bumblebee/issues{/number}","pulls_url":"https://api.github.com/repos/aholachek/bumblebee/pulls{/number}","milestones_url":"https://api.github.com/repos/aholachek/bumblebee/milestones{/number}","notifications_url":"https://api.github.com/repos/aholachek/bumblebee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aholachek/bumblebee/labels{/name}","releases_url":"https://api.github.com/repos/aholachek/bumblebee/releases{/id}","created_at":"2014-02-27T00:13:20Z","updated_at":"2015-03-05T13:36:43Z","pushed_at":"2015-04-14T20:28:26Z","git_url":"git://github.com/aholachek/bumblebee.git","ssh_url":"git@github.com:aholachek/bumblebee.git","clone_url":"https://github.com/aholachek/bumblebee.git","svn_url":"https://github.com/aholachek/bumblebee","homepage":null,"size":8620,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adsabs:master","ref":"master","sha":"2fa8bbe33b7ed53022d80182d9f20d1729998e95","user":{"login":"adsabs","id":1004839,"avatar_url":"https://avatars.githubusercontent.com/u/1004839?v=3","gravatar_id":"","url":"https://api.github.com/users/adsabs","html_url":"https://github.com/adsabs","followers_url":"https://api.github.com/users/adsabs/followers","following_url":"https://api.github.com/users/adsabs/following{/other_user}","gists_url":"https://api.github.com/users/adsabs/gists{/gist_id}","starred_url":"https://api.github.com/users/adsabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsabs/subscriptions","organizations_url":"https://api.github.com/users/adsabs/orgs","repos_url":"https://api.github.com/users/adsabs/repos","events_url":"https://api.github.com/users/adsabs/events{/privacy}","received_events_url":"https://api.github.com/users/adsabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17075030,"name":"bumblebee","full_name":"adsabs/bumblebee","owner":{"login":"adsabs","id":1004839,"avatar_url":"https://avatars.githubusercontent.com/u/1004839?v=3","gravatar_id":"","url":"https://api.github.com/users/adsabs","html_url":"https://github.com/adsabs","followers_url":"https://api.github.com/users/adsabs/followers","following_url":"https://api.github.com/users/adsabs/following{/other_user}","gists_url":"https://api.github.com/users/adsabs/gists{/gist_id}","starred_url":"https://api.github.com/users/adsabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsabs/subscriptions","organizations_url":"https://api.github.com/users/adsabs/orgs","repos_url":"https://api.github.com/users/adsabs/repos","events_url":"https://api.github.com/users/adsabs/events{/privacy}","received_events_url":"https://api.github.com/users/adsabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adsabs/bumblebee","description":"Clever face for ADS","fork":false,"url":"https://api.github.com/repos/adsabs/bumblebee","forks_url":"https://api.github.com/repos/adsabs/bumblebee/forks","keys_url":"https://api.github.com/repos/adsabs/bumblebee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adsabs/bumblebee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adsabs/bumblebee/teams","hooks_url":"https://api.github.com/repos/adsabs/bumblebee/hooks","issue_events_url":"https://api.github.com/repos/adsabs/bumblebee/issues/events{/number}","events_url":"https://api.github.com/repos/adsabs/bumblebee/events","assignees_url":"https://api.github.com/repos/adsabs/bumblebee/assignees{/user}","branches_url":"https://api.github.com/repos/adsabs/bumblebee/branches{/branch}","tags_url":"https://api.github.com/repos/adsabs/bumblebee/tags","blobs_url":"https://api.github.com/repos/adsabs/bumblebee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adsabs/bumblebee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adsabs/bumblebee/git/refs{/sha}","trees_url":"https://api.github.com/repos/adsabs/bumblebee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adsabs/bumblebee/statuses/{sha}","languages_url":"https://api.github.com/repos/adsabs/bumblebee/languages","stargazers_url":"https://api.github.com/repos/adsabs/bumblebee/stargazers","contributors_url":"https://api.github.com/repos/adsabs/bumblebee/contributors","subscribers_url":"https://api.github.com/repos/adsabs/bumblebee/subscribers","subscription_url":"https://api.github.com/repos/adsabs/bumblebee/subscription","commits_url":"https://api.github.com/repos/adsabs/bumblebee/commits{/sha}","git_commits_url":"https://api.github.com/repos/adsabs/bumblebee/git/commits{/sha}","comments_url":"https://api.github.com/repos/adsabs/bumblebee/comments{/number}","issue_comment_url":"https://api.github.com/repos/adsabs/bumblebee/issues/comments{/number}","contents_url":"https://api.github.com/repos/adsabs/bumblebee/contents/{+path}","compare_url":"https://api.github.com/repos/adsabs/bumblebee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adsabs/bumblebee/merges","archive_url":"https://api.github.com/repos/adsabs/bumblebee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adsabs/bumblebee/downloads","issues_url":"https://api.github.com/repos/adsabs/bumblebee/issues{/number}","pulls_url":"https://api.github.com/repos/adsabs/bumblebee/pulls{/number}","milestones_url":"https://api.github.com/repos/adsabs/bumblebee/milestones{/number}","notifications_url":"https://api.github.com/repos/adsabs/bumblebee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adsabs/bumblebee/labels{/name}","releases_url":"https://api.github.com/repos/adsabs/bumblebee/releases{/id}","created_at":"2014-02-22T00:59:37Z","updated_at":"2015-04-14T20:28:24Z","pushed_at":"2015-04-14T20:28:24Z","git_url":"git://github.com/adsabs/bumblebee.git","ssh_url":"git@github.com:adsabs/bumblebee.git","clone_url":"https://github.com/adsabs/bumblebee.git","svn_url":"https://github.com/adsabs/bumblebee","homepage":"","size":10792,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":34,"forks":8,"open_issues":34,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adsabs/bumblebee/pulls/336"},"html":{"href":"https://github.com/adsabs/bumblebee/pull/336"},"issue":{"href":"https://api.github.com/repos/adsabs/bumblebee/issues/336"},"comments":{"href":"https://api.github.com/repos/adsabs/bumblebee/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/adsabs/bumblebee/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/adsabs/bumblebee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adsabs/bumblebee/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/adsabs/bumblebee/statuses/5235afa2706399afa372374bce9be31685caf8f3"}}}}