{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/buildscripts/pulls/comments/28573881","id":28573881,"diff_hunk":"@@ -35,24 +35,18 @@ fi\n \n case \"$TEST_MACHINE\" in\n     chroot)\n-        # Fuser has special output. The PIDs arrive on stdout, and all the ornaments\n-        # arrive on stderr, so all we have to do is to grep for PID numbers.\n-        for pid in `sudo $FUSER $CHROOT_ROOT 2>/dev/null`; do\n-            # Leaving processes behind is an error. It should never happen.\n-            return_code=1\n-            (\n-                # This next part is very confusing when mixed with \"set -x\".\n-                # Turn it off inside the subshell while printing this.\n-                set +x\n-                echo \"Error: Found processes left behind in the chroot. I'm killing them, but the build will fail, so clean up your mess!\"\n-                echo \"Found PID $pid. Info from 'ps -ef'\"\n-                echo \"--------------\"\n-                ps -ef | grep $pid\n-                echo \"--------------\"\n-            )\n-        done\n+        echo \"Checking for stale processes in the chroot path: $CHROOT_ROOT\"\n+        sudo $FUSER -v $CHROOT_ROOT 2>&1","path":"build-scripts/test-on-testmachine","position":21,"original_position":21,"commit_id":"6d278e8f2a0f1ab05d98f479548d70d4a0c481dc","original_commit_id":"6d278e8f2a0f1ab05d98f479548d70d4a0c481dc","user":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"body":"``-v`` is not universally supported. Besides we'd really like to get PIDs, because the process is not necessarily a cf-* process, for example the build that triggered this tested if we could start ntpd, which then got left running. I will make a separate fix.","created_at":"2015-04-17T07:08:40Z","updated_at":"2015-04-17T07:08:40Z","html_url":"https://github.com/cfengine/buildscripts/pull/59#discussion_r28573881","pull_request_url":"https://api.github.com/repos/cfengine/buildscripts/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/cfengine/buildscripts/pulls/comments/28573881"},"html":{"href":"https://github.com/cfengine/buildscripts/pull/59#discussion_r28573881"},"pull_request":{"href":"https://api.github.com/repos/cfengine/buildscripts/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/buildscripts/pulls/59","id":33472967,"html_url":"https://github.com/cfengine/buildscripts/pull/59","diff_url":"https://github.com/cfengine/buildscripts/pull/59.diff","patch_url":"https://github.com/cfengine/buildscripts/pull/59.patch","issue_url":"https://api.github.com/repos/cfengine/buildscripts/issues/59","number":59,"state":"open","locked":false,"title":"Fix fuser output.","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"body":"fuser on RHEL4 is being printed differently. So avoid any parsing of its\r\noutput and just call fuser in verbose mode, which prints the process\r\nnames.","created_at":"2015-04-16T17:18:48Z","updated_at":"2015-04-17T07:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6093b9f9f901f6f9090319077c27953aeab7305e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/buildscripts/pulls/59/commits","review_comments_url":"https://api.github.com/repos/cfengine/buildscripts/pulls/59/comments","review_comment_url":"https://api.github.com/repos/cfengine/buildscripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/buildscripts/issues/59/comments","statuses_url":"https://api.github.com/repos/cfengine/buildscripts/statuses/6d278e8f2a0f1ab05d98f479548d70d4a0c481dc","head":{"label":"jimis:master","ref":"master","sha":"6d278e8f2a0f1ab05d98f479548d70d4a0c481dc","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"repo":{"id":24117540,"name":"buildscripts","full_name":"jimis/buildscripts","owner":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimis/buildscripts","description":"Build scripts for CFEngine Community packages","fork":true,"url":"https://api.github.com/repos/jimis/buildscripts","forks_url":"https://api.github.com/repos/jimis/buildscripts/forks","keys_url":"https://api.github.com/repos/jimis/buildscripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimis/buildscripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimis/buildscripts/teams","hooks_url":"https://api.github.com/repos/jimis/buildscripts/hooks","issue_events_url":"https://api.github.com/repos/jimis/buildscripts/issues/events{/number}","events_url":"https://api.github.com/repos/jimis/buildscripts/events","assignees_url":"https://api.github.com/repos/jimis/buildscripts/assignees{/user}","branches_url":"https://api.github.com/repos/jimis/buildscripts/branches{/branch}","tags_url":"https://api.github.com/repos/jimis/buildscripts/tags","blobs_url":"https://api.github.com/repos/jimis/buildscripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimis/buildscripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimis/buildscripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimis/buildscripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimis/buildscripts/statuses/{sha}","languages_url":"https://api.github.com/repos/jimis/buildscripts/languages","stargazers_url":"https://api.github.com/repos/jimis/buildscripts/stargazers","contributors_url":"https://api.github.com/repos/jimis/buildscripts/contributors","subscribers_url":"https://api.github.com/repos/jimis/buildscripts/subscribers","subscription_url":"https://api.github.com/repos/jimis/buildscripts/subscription","commits_url":"https://api.github.com/repos/jimis/buildscripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimis/buildscripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimis/buildscripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimis/buildscripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimis/buildscripts/contents/{+path}","compare_url":"https://api.github.com/repos/jimis/buildscripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimis/buildscripts/merges","archive_url":"https://api.github.com/repos/jimis/buildscripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimis/buildscripts/downloads","issues_url":"https://api.github.com/repos/jimis/buildscripts/issues{/number}","pulls_url":"https://api.github.com/repos/jimis/buildscripts/pulls{/number}","milestones_url":"https://api.github.com/repos/jimis/buildscripts/milestones{/number}","notifications_url":"https://api.github.com/repos/jimis/buildscripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimis/buildscripts/labels{/name}","releases_url":"https://api.github.com/repos/jimis/buildscripts/releases{/id}","created_at":"2014-09-16T20:59:09Z","updated_at":"2015-04-16T18:10:19Z","pushed_at":"2015-04-16T18:10:19Z","git_url":"git://github.com/jimis/buildscripts.git","ssh_url":"git@github.com:jimis/buildscripts.git","clone_url":"https://github.com/jimis/buildscripts.git","svn_url":"https://github.com/jimis/buildscripts","homepage":null,"size":3519,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"c98cd07b31fab199a2215e31165abda4156fa126","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":11123899,"name":"buildscripts","full_name":"cfengine/buildscripts","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/buildscripts","description":"Build scripts for CFEngine Community packages","fork":false,"url":"https://api.github.com/repos/cfengine/buildscripts","forks_url":"https://api.github.com/repos/cfengine/buildscripts/forks","keys_url":"https://api.github.com/repos/cfengine/buildscripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/buildscripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/buildscripts/teams","hooks_url":"https://api.github.com/repos/cfengine/buildscripts/hooks","issue_events_url":"https://api.github.com/repos/cfengine/buildscripts/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/buildscripts/events","assignees_url":"https://api.github.com/repos/cfengine/buildscripts/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/buildscripts/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/buildscripts/tags","blobs_url":"https://api.github.com/repos/cfengine/buildscripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/buildscripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/buildscripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/buildscripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/buildscripts/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/buildscripts/languages","stargazers_url":"https://api.github.com/repos/cfengine/buildscripts/stargazers","contributors_url":"https://api.github.com/repos/cfengine/buildscripts/contributors","subscribers_url":"https://api.github.com/repos/cfengine/buildscripts/subscribers","subscription_url":"https://api.github.com/repos/cfengine/buildscripts/subscription","commits_url":"https://api.github.com/repos/cfengine/buildscripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/buildscripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/buildscripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/buildscripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/buildscripts/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/buildscripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/buildscripts/merges","archive_url":"https://api.github.com/repos/cfengine/buildscripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/buildscripts/downloads","issues_url":"https://api.github.com/repos/cfengine/buildscripts/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/buildscripts/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/buildscripts/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/buildscripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/buildscripts/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/buildscripts/releases{/id}","created_at":"2013-07-02T11:55:07Z","updated_at":"2015-04-15T11:19:53Z","pushed_at":"2015-04-16T18:10:20Z","git_url":"git://github.com/cfengine/buildscripts.git","ssh_url":"git@github.com:cfengine/buildscripts.git","clone_url":"https://github.com/cfengine/buildscripts.git","svn_url":"https://github.com/cfengine/buildscripts","homepage":null,"size":5113,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":3,"forks":21,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/buildscripts/pulls/59"},"html":{"href":"https://github.com/cfengine/buildscripts/pull/59"},"issue":{"href":"https://api.github.com/repos/cfengine/buildscripts/issues/59"},"comments":{"href":"https://api.github.com/repos/cfengine/buildscripts/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/buildscripts/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/buildscripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/buildscripts/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/buildscripts/statuses/6d278e8f2a0f1ab05d98f479548d70d4a0c481dc"}}}}