{"action":"created","comment":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/37748865","id":37748865,"diff_hunk":"@@ -1346,7 +1346,7 @@ define(['exports', 'require', 'jquery', 'underscore', 'oae.api.config', 'markdow\n          * Redirect the currently user to the me page.\n          */\n         var me = function() {","path":"shared/oae/api/oae.api.util.js","position":23,"original_position":23,"commit_id":"29d5a5534673a4dbbd77a531cc55bb0b87b91957","original_commit_id":"29d5a5534673a4dbbd77a531cc55bb0b87b91957","user":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?v=3","gravatar_id":"","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"body":"I've changed it, but I can't actually find anywhere in the code base that was using `redirect.me()` so maybe the entire method isn't necessary.","created_at":"2015-08-24T13:12:32Z","updated_at":"2015-08-24T13:12:32Z","html_url":"https://github.com/oaeproject/3akai-ux/pull/4040#discussion_r37748865","pull_request_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/37748865"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/4040#discussion_r37748865"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040"}}},"pull_request":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040","id":41369690,"html_url":"https://github.com/oaeproject/3akai-ux/pull/4040","diff_url":"https://github.com/oaeproject/3akai-ux/pull/4040.diff","patch_url":"https://github.com/oaeproject/3akai-ux/pull/4040.patch","issue_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4040","number":4040,"state":"open","locked":false,"title":"Application navigation refinements","user":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?v=3","gravatar_id":"","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"body":"Note: this can be build on top of the work in https://github.com/oaeproject/3akai-ux/pull/3992\r\n\r\nThe existing `/me` page should be removed in favour of a `/` page that serves as both the tenant landing page and the me page. When the user is not signed in, this page should load the configured tenant landing page. When the user is signed in, this page should load the me page.\r\n\r\nIt's probably best to convert the logic in `index.html` and `index.js` to a widget that can be loaded through the left hand navigation. When the user is signed in, just load the standard me page widgets through the lhnav. When the user is not signed in, we can load the `tenantlandingpage` widget via the lhnav (and hiding the lhnav, just like the content profile page).\r\n\r\nThis also means that all links (both defined in UI and back-end) to `/me` should be changed to `/`. The link behind the logo in the top nav can be removed.","created_at":"2015-07-31T18:53:58Z","updated_at":"2015-08-24T13:12:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7289c2e4fe473533592efaf1ba4b9f723f75b826","assignee":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?v=3","gravatar_id":"","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040/commits","review_comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040/comments","review_comment_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4040/comments","statuses_url":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/29d5a5534673a4dbbd77a531cc55bb0b87b91957","head":{"label":"sathomas:issue4040","ref":"issue4040","sha":"29d5a5534673a4dbbd77a531cc55bb0b87b91957","user":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?v=3","gravatar_id":"","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"repo":{"id":13032557,"name":"3akai-ux","full_name":"sathomas/3akai-ux","owner":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?v=3","gravatar_id":"","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sathomas/3akai-ux","description":"Open Academic Environment (OAE) Front-End","fork":true,"url":"https://api.github.com/repos/sathomas/3akai-ux","forks_url":"https://api.github.com/repos/sathomas/3akai-ux/forks","keys_url":"https://api.github.com/repos/sathomas/3akai-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sathomas/3akai-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sathomas/3akai-ux/teams","hooks_url":"https://api.github.com/repos/sathomas/3akai-ux/hooks","issue_events_url":"https://api.github.com/repos/sathomas/3akai-ux/issues/events{/number}","events_url":"https://api.github.com/repos/sathomas/3akai-ux/events","assignees_url":"https://api.github.com/repos/sathomas/3akai-ux/assignees{/user}","branches_url":"https://api.github.com/repos/sathomas/3akai-ux/branches{/branch}","tags_url":"https://api.github.com/repos/sathomas/3akai-ux/tags","blobs_url":"https://api.github.com/repos/sathomas/3akai-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sathomas/3akai-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sathomas/3akai-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/sathomas/3akai-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sathomas/3akai-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/sathomas/3akai-ux/languages","stargazers_url":"https://api.github.com/repos/sathomas/3akai-ux/stargazers","contributors_url":"https://api.github.com/repos/sathomas/3akai-ux/contributors","subscribers_url":"https://api.github.com/repos/sathomas/3akai-ux/subscribers","subscription_url":"https://api.github.com/repos/sathomas/3akai-ux/subscription","commits_url":"https://api.github.com/repos/sathomas/3akai-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/sathomas/3akai-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/sathomas/3akai-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/sathomas/3akai-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/sathomas/3akai-ux/contents/{+path}","compare_url":"https://api.github.com/repos/sathomas/3akai-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sathomas/3akai-ux/merges","archive_url":"https://api.github.com/repos/sathomas/3akai-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sathomas/3akai-ux/downloads","issues_url":"https://api.github.com/repos/sathomas/3akai-ux/issues{/number}","pulls_url":"https://api.github.com/repos/sathomas/3akai-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/sathomas/3akai-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/sathomas/3akai-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sathomas/3akai-ux/labels{/name}","releases_url":"https://api.github.com/repos/sathomas/3akai-ux/releases{/id}","created_at":"2013-09-23T10:10:32Z","updated_at":"2014-06-24T17:52:41Z","pushed_at":"2015-08-05T16:37:13Z","git_url":"git://github.com/sathomas/3akai-ux.git","ssh_url":"git@github.com:sathomas/3akai-ux.git","clone_url":"https://github.com/sathomas/3akai-ux.git","svn_url":"https://github.com/sathomas/3akai-ux","homepage":"http://www.oaeproject.org","size":132361,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oaeproject:master","ref":"master","sha":"b6637bcda835e1cc3db0fd75cdb5f92697cc9945","user":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":761723,"name":"3akai-ux","full_name":"oaeproject/3akai-ux","owner":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oaeproject/3akai-ux","description":"Open Academic Environment (OAE) Front-End","fork":false,"url":"https://api.github.com/repos/oaeproject/3akai-ux","forks_url":"https://api.github.com/repos/oaeproject/3akai-ux/forks","keys_url":"https://api.github.com/repos/oaeproject/3akai-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaeproject/3akai-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaeproject/3akai-ux/teams","hooks_url":"https://api.github.com/repos/oaeproject/3akai-ux/hooks","issue_events_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/events{/number}","events_url":"https://api.github.com/repos/oaeproject/3akai-ux/events","assignees_url":"https://api.github.com/repos/oaeproject/3akai-ux/assignees{/user}","branches_url":"https://api.github.com/repos/oaeproject/3akai-ux/branches{/branch}","tags_url":"https://api.github.com/repos/oaeproject/3akai-ux/tags","blobs_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/oaeproject/3akai-ux/languages","stargazers_url":"https://api.github.com/repos/oaeproject/3akai-ux/stargazers","contributors_url":"https://api.github.com/repos/oaeproject/3akai-ux/contributors","subscribers_url":"https://api.github.com/repos/oaeproject/3akai-ux/subscribers","subscription_url":"https://api.github.com/repos/oaeproject/3akai-ux/subscription","commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/oaeproject/3akai-ux/contents/{+path}","compare_url":"https://api.github.com/repos/oaeproject/3akai-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaeproject/3akai-ux/merges","archive_url":"https://api.github.com/repos/oaeproject/3akai-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaeproject/3akai-ux/downloads","issues_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues{/number}","pulls_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/oaeproject/3akai-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/oaeproject/3akai-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaeproject/3akai-ux/labels{/name}","releases_url":"https://api.github.com/repos/oaeproject/3akai-ux/releases{/id}","created_at":"2010-07-07T12:48:50Z","updated_at":"2015-06-25T13:41:57Z","pushed_at":"2015-08-18T12:52:52Z","git_url":"git://github.com/oaeproject/3akai-ux.git","ssh_url":"git@github.com:oaeproject/3akai-ux.git","clone_url":"https://github.com/oaeproject/3akai-ux.git","svn_url":"https://github.com/oaeproject/3akai-ux","homepage":"http://www.oaeproject.org","size":173946,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":65,"forks":224,"open_issues":65,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/4040"},"issue":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4040"},"comments":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4040/comments"},"review_comments":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040/comments"},"review_comment":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4040/commits"},"statuses":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/29d5a5534673a4dbbd77a531cc55bb0b87b91957"}}}}