{"action":"closed","number":68,"pull_request":{"url":"https://api.github.com/repos/tonsky/datascript/pulls/68","id":32933619,"html_url":"https://github.com/tonsky/datascript/pull/68","diff_url":"https://github.com/tonsky/datascript/pull/68.diff","patch_url":"https://github.com/tonsky/datascript/pull/68.patch","issue_url":"https://api.github.com/repos/tonsky/datascript/issues/68","number":68,"state":"closed","locked":false,"title":"clojure port","user":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"body":"This represents a solid beginning toward a clojure port, see https://github.com/tonsky/datascript/issues/54.\r\n\r\nLots of tweaking done, and more is needed. Inlined/XXX comments explain reasoning or open questions. Best place to actually add comments is the second commit: https://github.com/benfleis/datascript/commit/d943eaba47da49cf8d647f1eb90068ed31f14644. (The first commit was only file movement, to make diff viewing easier.)\r\n\r\nWhat would it take to turn this into a basis for a real clojure/script version of datascript? I suspect that the big consideration points would be:\r\n\r\n* value vs. nuisance\r\n* portable code, performant code\r\n* cljx/cljc (1.7 reader conditionals)\r\n\r\nIt runs all CLJ tests, although the performance suite is not fully supported. The clojurescript code does not work at the moment, although that will be resuscitated soon. (I decided at a certain point on just getting the clojure side to work.) The fork originates from early february, so there would be a fair bit of catching up to do as well.\r\n\r\nFeedback, thoughts, suggestions?","created_at":"2015-04-09T08:11:27Z","updated_at":"2015-05-20T18:54:19Z","closed_at":"2015-05-20T18:54:19Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tonsky/datascript/pulls/68/commits","review_comments_url":"https://api.github.com/repos/tonsky/datascript/pulls/68/comments","review_comment_url":"https://api.github.com/repos/tonsky/datascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tonsky/datascript/issues/68/comments","statuses_url":"https://api.github.com/repos/tonsky/datascript/statuses/4146b5adafd311e225a98aa568544b72144e8812","head":{"label":"benfleis:feature/clojure-port-v2","ref":"feature/clojure-port-v2","sha":"4146b5adafd311e225a98aa568544b72144e8812","user":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"repo":{"id":32163605,"name":"datascript","full_name":"benfleis/datascript","owner":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfleis/datascript","description":"Immutable database and Datalog query engine in ClojureScript","fork":true,"url":"https://api.github.com/repos/benfleis/datascript","forks_url":"https://api.github.com/repos/benfleis/datascript/forks","keys_url":"https://api.github.com/repos/benfleis/datascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfleis/datascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfleis/datascript/teams","hooks_url":"https://api.github.com/repos/benfleis/datascript/hooks","issue_events_url":"https://api.github.com/repos/benfleis/datascript/issues/events{/number}","events_url":"https://api.github.com/repos/benfleis/datascript/events","assignees_url":"https://api.github.com/repos/benfleis/datascript/assignees{/user}","branches_url":"https://api.github.com/repos/benfleis/datascript/branches{/branch}","tags_url":"https://api.github.com/repos/benfleis/datascript/tags","blobs_url":"https://api.github.com/repos/benfleis/datascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfleis/datascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfleis/datascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfleis/datascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfleis/datascript/statuses/{sha}","languages_url":"https://api.github.com/repos/benfleis/datascript/languages","stargazers_url":"https://api.github.com/repos/benfleis/datascript/stargazers","contributors_url":"https://api.github.com/repos/benfleis/datascript/contributors","subscribers_url":"https://api.github.com/repos/benfleis/datascript/subscribers","subscription_url":"https://api.github.com/repos/benfleis/datascript/subscription","commits_url":"https://api.github.com/repos/benfleis/datascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfleis/datascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfleis/datascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfleis/datascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfleis/datascript/contents/{+path}","compare_url":"https://api.github.com/repos/benfleis/datascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfleis/datascript/merges","archive_url":"https://api.github.com/repos/benfleis/datascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfleis/datascript/downloads","issues_url":"https://api.github.com/repos/benfleis/datascript/issues{/number}","pulls_url":"https://api.github.com/repos/benfleis/datascript/pulls{/number}","milestones_url":"https://api.github.com/repos/benfleis/datascript/milestones{/number}","notifications_url":"https://api.github.com/repos/benfleis/datascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfleis/datascript/labels{/name}","releases_url":"https://api.github.com/repos/benfleis/datascript/releases{/id}","created_at":"2015-03-13T15:24:32Z","updated_at":"2015-03-13T15:24:32Z","pushed_at":"2015-04-15T12:58:05Z","git_url":"git://github.com/benfleis/datascript.git","ssh_url":"git@github.com:benfleis/datascript.git","clone_url":"https://github.com/benfleis/datascript.git","svn_url":"https://github.com/benfleis/datascript","homepage":"","size":672,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tonsky:master","ref":"master","sha":"d55b1948527e76a0667458bb667ae09134513ad2","user":{"login":"tonsky","id":285292,"avatar_url":"https://avatars.githubusercontent.com/u/285292?v=3","gravatar_id":"","url":"https://api.github.com/users/tonsky","html_url":"https://github.com/tonsky","followers_url":"https://api.github.com/users/tonsky/followers","following_url":"https://api.github.com/users/tonsky/following{/other_user}","gists_url":"https://api.github.com/users/tonsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tonsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonsky/subscriptions","organizations_url":"https://api.github.com/users/tonsky/orgs","repos_url":"https://api.github.com/users/tonsky/repos","events_url":"https://api.github.com/users/tonsky/events{/privacy}","received_events_url":"https://api.github.com/users/tonsky/received_events","type":"User","site_admin":false},"repo":{"id":18800032,"name":"datascript","full_name":"tonsky/datascript","owner":{"login":"tonsky","id":285292,"avatar_url":"https://avatars.githubusercontent.com/u/285292?v=3","gravatar_id":"","url":"https://api.github.com/users/tonsky","html_url":"https://github.com/tonsky","followers_url":"https://api.github.com/users/tonsky/followers","following_url":"https://api.github.com/users/tonsky/following{/other_user}","gists_url":"https://api.github.com/users/tonsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tonsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonsky/subscriptions","organizations_url":"https://api.github.com/users/tonsky/orgs","repos_url":"https://api.github.com/users/tonsky/repos","events_url":"https://api.github.com/users/tonsky/events{/privacy}","received_events_url":"https://api.github.com/users/tonsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonsky/datascript","description":"Immutable database and Datalog query engine in ClojureScript","fork":false,"url":"https://api.github.com/repos/tonsky/datascript","forks_url":"https://api.github.com/repos/tonsky/datascript/forks","keys_url":"https://api.github.com/repos/tonsky/datascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonsky/datascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonsky/datascript/teams","hooks_url":"https://api.github.com/repos/tonsky/datascript/hooks","issue_events_url":"https://api.github.com/repos/tonsky/datascript/issues/events{/number}","events_url":"https://api.github.com/repos/tonsky/datascript/events","assignees_url":"https://api.github.com/repos/tonsky/datascript/assignees{/user}","branches_url":"https://api.github.com/repos/tonsky/datascript/branches{/branch}","tags_url":"https://api.github.com/repos/tonsky/datascript/tags","blobs_url":"https://api.github.com/repos/tonsky/datascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonsky/datascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonsky/datascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonsky/datascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonsky/datascript/statuses/{sha}","languages_url":"https://api.github.com/repos/tonsky/datascript/languages","stargazers_url":"https://api.github.com/repos/tonsky/datascript/stargazers","contributors_url":"https://api.github.com/repos/tonsky/datascript/contributors","subscribers_url":"https://api.github.com/repos/tonsky/datascript/subscribers","subscription_url":"https://api.github.com/repos/tonsky/datascript/subscription","commits_url":"https://api.github.com/repos/tonsky/datascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonsky/datascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonsky/datascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonsky/datascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonsky/datascript/contents/{+path}","compare_url":"https://api.github.com/repos/tonsky/datascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonsky/datascript/merges","archive_url":"https://api.github.com/repos/tonsky/datascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonsky/datascript/downloads","issues_url":"https://api.github.com/repos/tonsky/datascript/issues{/number}","pulls_url":"https://api.github.com/repos/tonsky/datascript/pulls{/number}","milestones_url":"https://api.github.com/repos/tonsky/datascript/milestones{/number}","notifications_url":"https://api.github.com/repos/tonsky/datascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonsky/datascript/labels{/name}","releases_url":"https://api.github.com/repos/tonsky/datascript/releases{/id}","created_at":"2014-04-15T12:58:22Z","updated_at":"2015-05-20T15:43:27Z","pushed_at":"2015-05-20T16:29:27Z","git_url":"git://github.com/tonsky/datascript.git","ssh_url":"git@github.com:tonsky/datascript.git","clone_url":"https://github.com/tonsky/datascript.git","svn_url":"https://github.com/tonsky/datascript","homepage":"","size":2432,"stargazers_count":1072,"watchers_count":1072,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":15,"forks":65,"open_issues":15,"watchers":1072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tonsky/datascript/pulls/68"},"html":{"href":"https://github.com/tonsky/datascript/pull/68"},"issue":{"href":"https://api.github.com/repos/tonsky/datascript/issues/68"},"comments":{"href":"https://api.github.com/repos/tonsky/datascript/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/tonsky/datascript/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/tonsky/datascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tonsky/datascript/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/tonsky/datascript/statuses/4146b5adafd311e225a98aa568544b72144e8812"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":1481,"deletions":669,"changed_files":53}}