{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/15264","labels_url":"https://api.github.com/repos/symfony/symfony/issues/15264/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15264/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/15264/events","html_url":"https://github.com/symfony/symfony/pull/15264","id":94561610,"number":15264,"title":"[Security] Added more tests for Firewall","user":{"login":"taueres","id":3669079,"avatar_url":"https://avatars.githubusercontent.com/u/3669079?v=3","gravatar_id":"","url":"https://api.github.com/users/taueres","html_url":"https://github.com/taueres","followers_url":"https://api.github.com/users/taueres/followers","following_url":"https://api.github.com/users/taueres/following{/other_user}","gists_url":"https://api.github.com/users/taueres/gists{/gist_id}","starred_url":"https://api.github.com/users/taueres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taueres/subscriptions","organizations_url":"https://api.github.com/users/taueres/orgs","repos_url":"https://api.github.com/users/taueres/repos","events_url":"https://api.github.com/users/taueres/events{/privacy}","received_events_url":"https://api.github.com/users/taueres/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-12T12:25:29Z","updated_at":"2015-07-21T21:24:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15264","html_url":"https://github.com/symfony/symfony/pull/15264","diff_url":"https://github.com/symfony/symfony/pull/15264.diff","patch_url":"https://github.com/symfony/symfony/pull/15264.patch"},"body":"Symfony\\Component\\Security\\Http\\Firewall now has 100% of\r\nstatement and method coverage\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/123482221","html_url":"https://github.com/symfony/symfony/pull/15264#issuecomment-123482221","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15264","id":123482221,"user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T21:24:27Z","updated_at":"2015-07-21T21:24:27Z","body":"I fail to see the advantage of these 2 tests (and especially the last one testing the subscribed events). Imo, 100% test coverage should not be a target (and doesn't say much)."}}