{"action":"opened","number":1168,"pull_request":{"url":"https://api.github.com/repos/tastejs/todomvc/pulls/1168","id":29414197,"html_url":"https://github.com/tastejs/todomvc/pull/1168","diff_url":"https://github.com/tastejs/todomvc/pull/1168.diff","patch_url":"https://github.com/tastejs/todomvc/pull/1168.patch","issue_url":"https://api.github.com/repos/tastejs/todomvc/issues/1168","number":1168,"state":"open","locked":false,"title":"Fix spec compliance for Marionette.","user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"body":"#### What:\r\n\r\nIn issue #789 @ColinEberhardt pointed out that many of the examples do\r\nnot respect the rule that when a user hits the esc key on an input that\r\nthe input should be cleared and the input state should be left.\r\n\r\nUpon investigation I found the Marionette example to have never followed\r\nthis directive.\r\n\r\n#### How:\r\n\r\nDue the how the escape key works and the keypress event binding from\r\njQuery one must use the keyup event to register for the escape key\r\nkeycode.\r\n\r\nOnce I intercept the event I instruct the input area to simply rerender.\r\nThis has the desired effect in that it clears the transient input state\r\nand also due to it rendering new childnodes clears the focus from the\r\nuser.\r\n\r\n------\r\n\r\ncc @ColinEberhardt ","created_at":"2015-02-17T02:35:16Z","updated_at":"2015-02-17T02:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tastejs/todomvc/pulls/1168/commits","review_comments_url":"https://api.github.com/repos/tastejs/todomvc/pulls/1168/comments","review_comment_url":"https://api.github.com/repos/tastejs/todomvc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tastejs/todomvc/issues/1168/comments","statuses_url":"https://api.github.com/repos/tastejs/todomvc/statuses/ca2cbcfb5e8dec11466fb2fdfc9a912ee9e275de","head":{"label":"samccone:sjs/fix-escape-behavior","ref":"sjs/fix-escape-behavior","sha":"ca2cbcfb5e8dec11466fb2fdfc9a912ee9e275de","user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"repo":{"id":23483627,"name":"todomvc","full_name":"samccone/todomvc","owner":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samccone/todomvc","description":"Helping you select an MV* framework - Todo apps for Backbone.js, Ember.js, AngularJS, and many more","fork":true,"url":"https://api.github.com/repos/samccone/todomvc","forks_url":"https://api.github.com/repos/samccone/todomvc/forks","keys_url":"https://api.github.com/repos/samccone/todomvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samccone/todomvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samccone/todomvc/teams","hooks_url":"https://api.github.com/repos/samccone/todomvc/hooks","issue_events_url":"https://api.github.com/repos/samccone/todomvc/issues/events{/number}","events_url":"https://api.github.com/repos/samccone/todomvc/events","assignees_url":"https://api.github.com/repos/samccone/todomvc/assignees{/user}","branches_url":"https://api.github.com/repos/samccone/todomvc/branches{/branch}","tags_url":"https://api.github.com/repos/samccone/todomvc/tags","blobs_url":"https://api.github.com/repos/samccone/todomvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samccone/todomvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samccone/todomvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/samccone/todomvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samccone/todomvc/statuses/{sha}","languages_url":"https://api.github.com/repos/samccone/todomvc/languages","stargazers_url":"https://api.github.com/repos/samccone/todomvc/stargazers","contributors_url":"https://api.github.com/repos/samccone/todomvc/contributors","subscribers_url":"https://api.github.com/repos/samccone/todomvc/subscribers","subscription_url":"https://api.github.com/repos/samccone/todomvc/subscription","commits_url":"https://api.github.com/repos/samccone/todomvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/samccone/todomvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/samccone/todomvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/samccone/todomvc/issues/comments/{number}","contents_url":"https://api.github.com/repos/samccone/todomvc/contents/{+path}","compare_url":"https://api.github.com/repos/samccone/todomvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samccone/todomvc/merges","archive_url":"https://api.github.com/repos/samccone/todomvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samccone/todomvc/downloads","issues_url":"https://api.github.com/repos/samccone/todomvc/issues{/number}","pulls_url":"https://api.github.com/repos/samccone/todomvc/pulls{/number}","milestones_url":"https://api.github.com/repos/samccone/todomvc/milestones{/number}","notifications_url":"https://api.github.com/repos/samccone/todomvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samccone/todomvc/labels{/name}","releases_url":"https://api.github.com/repos/samccone/todomvc/releases{/id}","created_at":"2014-08-30T03:06:58Z","updated_at":"2015-02-17T01:56:42Z","pushed_at":"2015-02-17T02:34:50Z","git_url":"git://github.com/samccone/todomvc.git","ssh_url":"git@github.com:samccone/todomvc.git","clone_url":"https://github.com/samccone/todomvc.git","svn_url":"https://github.com/samccone/todomvc","homepage":"http://todomvc.com","size":43842,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tastejs:master","ref":"master","sha":"f7ece0f5e56d0ae6e407d863ade99a5d22b9c1c2","user":{"login":"tastejs","id":1733746,"avatar_url":"https://avatars.githubusercontent.com/u/1733746?v=3","gravatar_id":"","url":"https://api.github.com/users/tastejs","html_url":"https://github.com/tastejs","followers_url":"https://api.github.com/users/tastejs/followers","following_url":"https://api.github.com/users/tastejs/following{/other_user}","gists_url":"https://api.github.com/users/tastejs/gists{/gist_id}","starred_url":"https://api.github.com/users/tastejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tastejs/subscriptions","organizations_url":"https://api.github.com/users/tastejs/orgs","repos_url":"https://api.github.com/users/tastejs/repos","events_url":"https://api.github.com/users/tastejs/events{/privacy}","received_events_url":"https://api.github.com/users/tastejs/received_events","type":"Organization","site_admin":false},"repo":{"id":1844251,"name":"todomvc","full_name":"tastejs/todomvc","owner":{"login":"tastejs","id":1733746,"avatar_url":"https://avatars.githubusercontent.com/u/1733746?v=3","gravatar_id":"","url":"https://api.github.com/users/tastejs","html_url":"https://github.com/tastejs","followers_url":"https://api.github.com/users/tastejs/followers","following_url":"https://api.github.com/users/tastejs/following{/other_user}","gists_url":"https://api.github.com/users/tastejs/gists{/gist_id}","starred_url":"https://api.github.com/users/tastejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tastejs/subscriptions","organizations_url":"https://api.github.com/users/tastejs/orgs","repos_url":"https://api.github.com/users/tastejs/repos","events_url":"https://api.github.com/users/tastejs/events{/privacy}","received_events_url":"https://api.github.com/users/tastejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tastejs/todomvc","description":"Helping you select an MV* framework - Todo apps for Backbone.js, Ember.js, AngularJS, and many more","fork":false,"url":"https://api.github.com/repos/tastejs/todomvc","forks_url":"https://api.github.com/repos/tastejs/todomvc/forks","keys_url":"https://api.github.com/repos/tastejs/todomvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tastejs/todomvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tastejs/todomvc/teams","hooks_url":"https://api.github.com/repos/tastejs/todomvc/hooks","issue_events_url":"https://api.github.com/repos/tastejs/todomvc/issues/events{/number}","events_url":"https://api.github.com/repos/tastejs/todomvc/events","assignees_url":"https://api.github.com/repos/tastejs/todomvc/assignees{/user}","branches_url":"https://api.github.com/repos/tastejs/todomvc/branches{/branch}","tags_url":"https://api.github.com/repos/tastejs/todomvc/tags","blobs_url":"https://api.github.com/repos/tastejs/todomvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tastejs/todomvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tastejs/todomvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tastejs/todomvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tastejs/todomvc/statuses/{sha}","languages_url":"https://api.github.com/repos/tastejs/todomvc/languages","stargazers_url":"https://api.github.com/repos/tastejs/todomvc/stargazers","contributors_url":"https://api.github.com/repos/tastejs/todomvc/contributors","subscribers_url":"https://api.github.com/repos/tastejs/todomvc/subscribers","subscription_url":"https://api.github.com/repos/tastejs/todomvc/subscription","commits_url":"https://api.github.com/repos/tastejs/todomvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tastejs/todomvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tastejs/todomvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tastejs/todomvc/issues/comments/{number}","contents_url":"https://api.github.com/repos/tastejs/todomvc/contents/{+path}","compare_url":"https://api.github.com/repos/tastejs/todomvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tastejs/todomvc/merges","archive_url":"https://api.github.com/repos/tastejs/todomvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tastejs/todomvc/downloads","issues_url":"https://api.github.com/repos/tastejs/todomvc/issues{/number}","pulls_url":"https://api.github.com/repos/tastejs/todomvc/pulls{/number}","milestones_url":"https://api.github.com/repos/tastejs/todomvc/milestones{/number}","notifications_url":"https://api.github.com/repos/tastejs/todomvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tastejs/todomvc/labels{/name}","releases_url":"https://api.github.com/repos/tastejs/todomvc/releases{/id}","created_at":"2011-06-03T19:56:33Z","updated_at":"2015-02-17T02:19:52Z","pushed_at":"2015-02-17T02:21:26Z","git_url":"git://github.com/tastejs/todomvc.git","ssh_url":"git@github.com:tastejs/todomvc.git","clone_url":"https://github.com/tastejs/todomvc.git","svn_url":"https://github.com/tastejs/todomvc","homepage":"http://todomvc.com","size":86130,"stargazers_count":11549,"watchers_count":11549,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6006,"mirror_url":null,"open_issues_count":112,"forks":6006,"open_issues":112,"watchers":11549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1168"},"html":{"href":"https://github.com/tastejs/todomvc/pull/1168"},"issue":{"href":"https://api.github.com/repos/tastejs/todomvc/issues/1168"},"comments":{"href":"https://api.github.com/repos/tastejs/todomvc/issues/1168/comments"},"review_comments":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1168/comments"},"review_comment":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1168/commits"},"statuses":{"href":"https://api.github.com/repos/tastejs/todomvc/statuses/ca2cbcfb5e8dec11466fb2fdfc9a912ee9e275de"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":1,"changed_files":1}}