{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/35687427","id":35687427,"diff_hunk":"@@ -49,6 +51,11 @@ const extendsFn = function(superClass, subClassMethods={}) {\n   let methods = {};\n \n   if (typeof subClassMethods === 'object') {\n+    if (typeof subClassMethods.init === 'function') {\n+      log.warn('Constructor logic via init() is deprecated; please use constructor() instead.');\n+      subClassMethods.constructor = subClassMethods.init;\n+      delete subClassMethods.init;","path":"src/js/extends.js","position":13,"original_position":13,"commit_id":"1c3f396902d03b1a09eb48c07e775376c4641fcf","original_commit_id":"257ccb8c462b9e20defaf616a87b0356b1981567","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"I'm not sure on this one either, but we may want to consider leaving it in case older external code points to the init directly for some reason. Probably better they get the warning than a broken function.","created_at":"2015-07-28T19:08:03Z","updated_at":"2015-07-28T19:08:03Z","html_url":"https://github.com/videojs/video.js/pull/2406#discussion_r35687427","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2406","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/35687427"},"html":{"href":"https://github.com/videojs/video.js/pull/2406#discussion_r35687427"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2406"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2406","id":40813754,"html_url":"https://github.com/videojs/video.js/pull/2406","diff_url":"https://github.com/videojs/video.js/pull/2406.diff","patch_url":"https://github.com/videojs/video.js/pull/2406.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2406","number":2406,"state":"open","locked":false,"title":"Restorations and Removals","user":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"body":"Closes #2405 by restoring several properties/methods for 5.0. Follows on from the discussion in #2402.","created_at":"2015-07-24T20:42:16Z","updated_at":"2015-07-28T19:08:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fefd2f2dc20350b2772a66646e943c82a425d8c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2406/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2406/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2406/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/1c3f396902d03b1a09eb48c07e775376c4641fcf","head":{"label":"misteroneill:restorations","ref":"restorations","sha":"1c3f396902d03b1a09eb48c07e775376c4641fcf","user":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"repo":{"id":39393950,"name":"video.js","full_name":"misteroneill/video.js","owner":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misteroneill/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/misteroneill/video.js","forks_url":"https://api.github.com/repos/misteroneill/video.js/forks","keys_url":"https://api.github.com/repos/misteroneill/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misteroneill/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misteroneill/video.js/teams","hooks_url":"https://api.github.com/repos/misteroneill/video.js/hooks","issue_events_url":"https://api.github.com/repos/misteroneill/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/misteroneill/video.js/events","assignees_url":"https://api.github.com/repos/misteroneill/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/misteroneill/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/misteroneill/video.js/tags","blobs_url":"https://api.github.com/repos/misteroneill/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misteroneill/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misteroneill/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/misteroneill/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misteroneill/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/misteroneill/video.js/languages","stargazers_url":"https://api.github.com/repos/misteroneill/video.js/stargazers","contributors_url":"https://api.github.com/repos/misteroneill/video.js/contributors","subscribers_url":"https://api.github.com/repos/misteroneill/video.js/subscribers","subscription_url":"https://api.github.com/repos/misteroneill/video.js/subscription","commits_url":"https://api.github.com/repos/misteroneill/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/misteroneill/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/misteroneill/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/misteroneill/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/misteroneill/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/misteroneill/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misteroneill/video.js/merges","archive_url":"https://api.github.com/repos/misteroneill/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misteroneill/video.js/downloads","issues_url":"https://api.github.com/repos/misteroneill/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/misteroneill/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/misteroneill/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/misteroneill/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misteroneill/video.js/labels{/name}","releases_url":"https://api.github.com/repos/misteroneill/video.js/releases{/id}","created_at":"2015-07-20T16:03:45Z","updated_at":"2015-07-20T16:03:47Z","pushed_at":"2015-07-27T14:48:15Z","git_url":"git://github.com/misteroneill/video.js.git","ssh_url":"git@github.com:misteroneill/video.js.git","clone_url":"https://github.com/misteroneill/video.js.git","svn_url":"https://github.com/misteroneill/video.js","homepage":"www.videojs.com","size":38191,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"57152ae62fff461bfb5aedef4593e13317b26f1b","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-07-28T16:22:50Z","pushed_at":"2015-07-28T14:28:34Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":55022,"stargazers_count":9689,"watchers_count":9689,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2766,"mirror_url":null,"open_issues_count":192,"forks":2766,"open_issues":192,"watchers":9689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2406"},"html":{"href":"https://github.com/videojs/video.js/pull/2406"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2406"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2406/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2406/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2406/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/1c3f396902d03b1a09eb48c07e775376c4641fcf"}}}}