{"action":"created","comment":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments/29579122","id":29579122,"diff_hunk":"@@ -527,7 +533,10 @@ static int script_wait_event(lua_State *L)\n             pushnode(L, prop->data);\n             break;\n         case MPV_FORMAT_DOUBLE:\n-            lua_pushnumber(L, *(double *)prop->data);\n+            if (is_int(*(double *)prop->data))\n+                lua_pushinteger(L, *(lua_Integer *)prop->data);","path":"player/lua.c","position":28,"original_position":28,"commit_id":"d797d59b8380fca51ecdbd75ac5d0ed33e096f6d","original_commit_id":"d797d59b8380fca51ecdbd75ac5d0ed33e096f6d","user":{"login":"wm4","id":1387750,"avatar_url":"https://avatars.githubusercontent.com/u/1387750?v=3","gravatar_id":"","url":"https://api.github.com/users/wm4","html_url":"https://github.com/wm4","followers_url":"https://api.github.com/users/wm4/followers","following_url":"https://api.github.com/users/wm4/following{/other_user}","gists_url":"https://api.github.com/users/wm4/gists{/gist_id}","starred_url":"https://api.github.com/users/wm4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wm4/subscriptions","organizations_url":"https://api.github.com/users/wm4/orgs","repos_url":"https://api.github.com/users/wm4/repos","events_url":"https://api.github.com/users/wm4/events{/privacy}","received_events_url":"https://api.github.com/users/wm4/received_events","type":"User","site_admin":false},"body":"This makes no sense. You can't derefence a double* as luaInteger*.","created_at":"2015-05-04T11:56:37Z","updated_at":"2015-05-04T11:56:37Z","html_url":"https://github.com/mpv-player/mpv/pull/1914#discussion_r29579122","pull_request_url":"https://api.github.com/repos/mpv-player/mpv/pulls/1914","_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments/29579122"},"html":{"href":"https://github.com/mpv-player/mpv/pull/1914#discussion_r29579122"},"pull_request":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1914"}}},"pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/1914","id":34630654,"html_url":"https://github.com/mpv-player/mpv/pull/1914","diff_url":"https://github.com/mpv-player/mpv/pull/1914.diff","patch_url":"https://github.com/mpv-player/mpv/pull/1914.patch","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/1914","number":1914,"state":"open","locked":false,"title":"lua: make more compatible with lua 5.3","user":{"login":"radistmorse","id":3995455,"avatar_url":"https://avatars.githubusercontent.com/u/3995455?v=3","gravatar_id":"","url":"https://api.github.com/users/radistmorse","html_url":"https://github.com/radistmorse","followers_url":"https://api.github.com/users/radistmorse/followers","following_url":"https://api.github.com/users/radistmorse/following{/other_user}","gists_url":"https://api.github.com/users/radistmorse/gists{/gist_id}","starred_url":"https://api.github.com/users/radistmorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radistmorse/subscriptions","organizations_url":"https://api.github.com/users/radistmorse/orgs","repos_url":"https://api.github.com/users/radistmorse/repos","events_url":"https://api.github.com/users/radistmorse/events{/privacy}","received_events_url":"https://api.github.com/users/radistmorse/received_events","type":"User","site_admin":false},"body":"Lua 5.3 introduced stricter integer typisation which leaded to some\r\nerrors in osc modules. pushnumber was changed to pushinteger where\r\napplicable, math.floor was used to forcibly convert floats to ints,\r\nan explicit typecast to lua_Integer was introduced in places where\r\nthe error might occure with lua compiled with 32bit ints, and\r\nfinally, one special corner case in get_screen_size which leaded\r\nto division by zero was taken care of.\r\n\r\nThis solves the \"OSD not showing\" bug with lua 5.3","created_at":"2015-05-04T11:35:04Z","updated_at":"2015-05-04T11:56:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fc39bf943d2c7830c6f7df8c0bd460e62696aad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mpv-player/mpv/pulls/1914/commits","review_comments_url":"https://api.github.com/repos/mpv-player/mpv/pulls/1914/comments","review_comment_url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/1914/comments","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/d797d59b8380fca51ecdbd75ac5d0ed33e096f6d","head":{"label":"radistmorse:master","ref":"master","sha":"d797d59b8380fca51ecdbd75ac5d0ed33e096f6d","user":{"login":"radistmorse","id":3995455,"avatar_url":"https://avatars.githubusercontent.com/u/3995455?v=3","gravatar_id":"","url":"https://api.github.com/users/radistmorse","html_url":"https://github.com/radistmorse","followers_url":"https://api.github.com/users/radistmorse/followers","following_url":"https://api.github.com/users/radistmorse/following{/other_user}","gists_url":"https://api.github.com/users/radistmorse/gists{/gist_id}","starred_url":"https://api.github.com/users/radistmorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radistmorse/subscriptions","organizations_url":"https://api.github.com/users/radistmorse/orgs","repos_url":"https://api.github.com/users/radistmorse/repos","events_url":"https://api.github.com/users/radistmorse/events{/privacy}","received_events_url":"https://api.github.com/users/radistmorse/received_events","type":"User","site_admin":false},"repo":{"id":35030449,"name":"mpv","full_name":"radistmorse/mpv","owner":{"login":"radistmorse","id":3995455,"avatar_url":"https://avatars.githubusercontent.com/u/3995455?v=3","gravatar_id":"","url":"https://api.github.com/users/radistmorse","html_url":"https://github.com/radistmorse","followers_url":"https://api.github.com/users/radistmorse/followers","following_url":"https://api.github.com/users/radistmorse/following{/other_user}","gists_url":"https://api.github.com/users/radistmorse/gists{/gist_id}","starred_url":"https://api.github.com/users/radistmorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radistmorse/subscriptions","organizations_url":"https://api.github.com/users/radistmorse/orgs","repos_url":"https://api.github.com/users/radistmorse/repos","events_url":"https://api.github.com/users/radistmorse/events{/privacy}","received_events_url":"https://api.github.com/users/radistmorse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radistmorse/mpv","description":"Video player based on MPlayer/mplayer2","fork":true,"url":"https://api.github.com/repos/radistmorse/mpv","forks_url":"https://api.github.com/repos/radistmorse/mpv/forks","keys_url":"https://api.github.com/repos/radistmorse/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radistmorse/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radistmorse/mpv/teams","hooks_url":"https://api.github.com/repos/radistmorse/mpv/hooks","issue_events_url":"https://api.github.com/repos/radistmorse/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/radistmorse/mpv/events","assignees_url":"https://api.github.com/repos/radistmorse/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/radistmorse/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/radistmorse/mpv/tags","blobs_url":"https://api.github.com/repos/radistmorse/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radistmorse/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radistmorse/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/radistmorse/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radistmorse/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/radistmorse/mpv/languages","stargazers_url":"https://api.github.com/repos/radistmorse/mpv/stargazers","contributors_url":"https://api.github.com/repos/radistmorse/mpv/contributors","subscribers_url":"https://api.github.com/repos/radistmorse/mpv/subscribers","subscription_url":"https://api.github.com/repos/radistmorse/mpv/subscription","commits_url":"https://api.github.com/repos/radistmorse/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/radistmorse/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/radistmorse/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/radistmorse/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/radistmorse/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/radistmorse/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radistmorse/mpv/merges","archive_url":"https://api.github.com/repos/radistmorse/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radistmorse/mpv/downloads","issues_url":"https://api.github.com/repos/radistmorse/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/radistmorse/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/radistmorse/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/radistmorse/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radistmorse/mpv/labels{/name}","releases_url":"https://api.github.com/repos/radistmorse/mpv/releases{/id}","created_at":"2015-05-04T11:14:43Z","updated_at":"2015-05-04T11:30:39Z","pushed_at":"2015-05-04T11:30:38Z","git_url":"git://github.com/radistmorse/mpv.git","ssh_url":"git@github.com:radistmorse/mpv.git","clone_url":"https://github.com/radistmorse/mpv.git","svn_url":"https://github.com/radistmorse/mpv","homepage":"http://mpv.io","size":99417,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mpv-player:master","ref":"master","sha":"b6381a0ee383acb1ee7a9562b166c18066747b7f","user":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars.githubusercontent.com/u/2550273?v=3","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"repo":{"id":6201092,"name":"mpv","full_name":"mpv-player/mpv","owner":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars.githubusercontent.com/u/2550273?v=3","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mpv-player/mpv","description":"Video player based on MPlayer/mplayer2","fork":false,"url":"https://api.github.com/repos/mpv-player/mpv","forks_url":"https://api.github.com/repos/mpv-player/mpv/forks","keys_url":"https://api.github.com/repos/mpv-player/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpv-player/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpv-player/mpv/teams","hooks_url":"https://api.github.com/repos/mpv-player/mpv/hooks","issue_events_url":"https://api.github.com/repos/mpv-player/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/mpv-player/mpv/events","assignees_url":"https://api.github.com/repos/mpv-player/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/mpv-player/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/mpv-player/mpv/tags","blobs_url":"https://api.github.com/repos/mpv-player/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpv-player/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpv-player/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpv-player/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/mpv-player/mpv/languages","stargazers_url":"https://api.github.com/repos/mpv-player/mpv/stargazers","contributors_url":"https://api.github.com/repos/mpv-player/mpv/contributors","subscribers_url":"https://api.github.com/repos/mpv-player/mpv/subscribers","subscription_url":"https://api.github.com/repos/mpv-player/mpv/subscription","commits_url":"https://api.github.com/repos/mpv-player/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpv-player/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpv-player/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpv-player/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpv-player/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/mpv-player/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpv-player/mpv/merges","archive_url":"https://api.github.com/repos/mpv-player/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpv-player/mpv/downloads","issues_url":"https://api.github.com/repos/mpv-player/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/mpv-player/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/mpv-player/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/mpv-player/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpv-player/mpv/labels{/name}","releases_url":"https://api.github.com/repos/mpv-player/mpv/releases{/id}","created_at":"2012-10-13T08:08:44Z","updated_at":"2015-05-04T09:05:48Z","pushed_at":"2015-05-04T11:35:05Z","git_url":"git://github.com/mpv-player/mpv.git","ssh_url":"git@github.com:mpv-player/mpv.git","clone_url":"https://github.com/mpv-player/mpv.git","svn_url":"https://github.com/mpv-player/mpv","homepage":"http://mpv.io","size":99417,"stargazers_count":1797,"watchers_count":1797,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":212,"forks":246,"open_issues":212,"watchers":1797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1914"},"html":{"href":"https://github.com/mpv-player/mpv/pull/1914"},"issue":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/1914"},"comments":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/1914/comments"},"review_comments":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1914/comments"},"review_comment":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1914/commits"},"statuses":{"href":"https://api.github.com/repos/mpv-player/mpv/statuses/d797d59b8380fca51ecdbd75ac5d0ed33e096f6d"}}}}