{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-boot/pulls/comments/27640035","id":27640035,"diff_hunk":"@@ -538,3 +525,61 @@ function resolveRelativePaths(relativePaths, appRootDir) {\n     }\n   });\n }\n+\n+function isPreferredExtension (filename, disallowedExtensions) {\n+  disallowedExtensions = disallowedExtensions || [];\n+\n+  var includeExtensions = require.extensions;\n+  var excludeExtensions = {};\n+  excludeExtensions[FILE_EXTENSION_JSON] = FILE_EXTENSION_JSON;\n+\n+  disallowedExtensions.forEach(function(ext) {\n+    excludeExtensions[ext] = ext;\n+  });\n+\n+  var ext = path.extname(filename);\n+  return (ext in includeExtensions) && !(ext in excludeExtensions);\n+}\n+\n+function fixFileExtension (filepath, files, disallowedExtensions,\n+  contentDataType) {","path":"lib/compiler.js","position":159,"original_position":159,"commit_id":"ca4f2c5b5c5537954a47123c2b3129a662b08807","original_commit_id":"ca4f2c5b5c5537954a47123c2b3129a662b08807","user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"body":"> a single parameter like fixOptions\r\n\r\nSounds good, I think the name `options` is good enough.\r\n\r\nFew more thoughts: `.node` should be ignored everywhere we ignore `.json`, it's just another extensions that gets special treatment from Node.js.\r\n\r\nIf find `contentDataType: 'function'` difficult to understand in the context of the calling code. Perhaps `onlyScriptsExportingFunction: true` would be a better option name?","created_at":"2015-04-02T08:34:04Z","updated_at":"2015-04-02T08:34:04Z","html_url":"https://github.com/strongloop/loopback-boot/pull/114#discussion_r27640035","pull_request_url":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-boot/pulls/comments/27640035"},"html":{"href":"https://github.com/strongloop/loopback-boot/pull/114#discussion_r27640035"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114","id":31711991,"html_url":"https://github.com/strongloop/loopback-boot/pull/114","diff_url":"https://github.com/strongloop/loopback-boot/pull/114.diff","patch_url":"https://github.com/strongloop/loopback-boot/pull/114.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-boot/issues/114","number":114,"state":"open","locked":false,"title":"Resolve module paths as relative to appRootDir - for component","user":{"login":"PradnyaBaviskar","id":10217160,"avatar_url":"https://avatars.githubusercontent.com/u/10217160?v=3","gravatar_id":"","url":"https://api.github.com/users/PradnyaBaviskar","html_url":"https://github.com/PradnyaBaviskar","followers_url":"https://api.github.com/users/PradnyaBaviskar/followers","following_url":"https://api.github.com/users/PradnyaBaviskar/following{/other_user}","gists_url":"https://api.github.com/users/PradnyaBaviskar/gists{/gist_id}","starred_url":"https://api.github.com/users/PradnyaBaviskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradnyaBaviskar/subscriptions","organizations_url":"https://api.github.com/users/PradnyaBaviskar/orgs","repos_url":"https://api.github.com/users/PradnyaBaviskar/repos","events_url":"https://api.github.com/users/PradnyaBaviskar/events{/privacy}","received_events_url":"https://api.github.com/users/PradnyaBaviskar/received_events","type":"User","site_admin":false},"body":"In continuation with #73,\r\n\r\nMade modifications to component, so as to resolve the module paths relative to appRootDir.\r\nAdded test case to verify component changes.\r\n\r\n@bajtos - Can you please review?","created_at":"2015-03-23T08:21:04Z","updated_at":"2015-04-02T08:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"907f299bf1b064acd3cbf4f653856cfa04419fda","assignee":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-boot/issues/114/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-boot/statuses/ca4f2c5b5c5537954a47123c2b3129a662b08807","head":{"label":"PradnyaBaviskar:lb-boot-issue-73-5","ref":"lb-boot-issue-73-5","sha":"ca4f2c5b5c5537954a47123c2b3129a662b08807","user":{"login":"PradnyaBaviskar","id":10217160,"avatar_url":"https://avatars.githubusercontent.com/u/10217160?v=3","gravatar_id":"","url":"https://api.github.com/users/PradnyaBaviskar","html_url":"https://github.com/PradnyaBaviskar","followers_url":"https://api.github.com/users/PradnyaBaviskar/followers","following_url":"https://api.github.com/users/PradnyaBaviskar/following{/other_user}","gists_url":"https://api.github.com/users/PradnyaBaviskar/gists{/gist_id}","starred_url":"https://api.github.com/users/PradnyaBaviskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradnyaBaviskar/subscriptions","organizations_url":"https://api.github.com/users/PradnyaBaviskar/orgs","repos_url":"https://api.github.com/users/PradnyaBaviskar/repos","events_url":"https://api.github.com/users/PradnyaBaviskar/events{/privacy}","received_events_url":"https://api.github.com/users/PradnyaBaviskar/received_events","type":"User","site_admin":false},"repo":{"id":31638835,"name":"loopback-boot","full_name":"PradnyaBaviskar/loopback-boot","owner":{"login":"PradnyaBaviskar","id":10217160,"avatar_url":"https://avatars.githubusercontent.com/u/10217160?v=3","gravatar_id":"","url":"https://api.github.com/users/PradnyaBaviskar","html_url":"https://github.com/PradnyaBaviskar","followers_url":"https://api.github.com/users/PradnyaBaviskar/followers","following_url":"https://api.github.com/users/PradnyaBaviskar/following{/other_user}","gists_url":"https://api.github.com/users/PradnyaBaviskar/gists{/gist_id}","starred_url":"https://api.github.com/users/PradnyaBaviskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradnyaBaviskar/subscriptions","organizations_url":"https://api.github.com/users/PradnyaBaviskar/orgs","repos_url":"https://api.github.com/users/PradnyaBaviskar/repos","events_url":"https://api.github.com/users/PradnyaBaviskar/events{/privacy}","received_events_url":"https://api.github.com/users/PradnyaBaviskar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PradnyaBaviskar/loopback-boot","description":"Convention-based bootstrapper for LoopBack applications","fork":true,"url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot","forks_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/forks","keys_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/teams","hooks_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/hooks","issue_events_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/issues/events{/number}","events_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/events","assignees_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/assignees{/user}","branches_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/branches{/branch}","tags_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/tags","blobs_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/languages","stargazers_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/stargazers","contributors_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/contributors","subscribers_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/subscribers","subscription_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/subscription","commits_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/contents/{+path}","compare_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/merges","archive_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/downloads","issues_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/issues{/number}","pulls_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/labels{/name}","releases_url":"https://api.github.com/repos/PradnyaBaviskar/loopback-boot/releases{/id}","created_at":"2015-03-04T05:00:04Z","updated_at":"2015-03-23T06:20:50Z","pushed_at":"2015-04-01T10:27:40Z","git_url":"git://github.com/PradnyaBaviskar/loopback-boot.git","ssh_url":"git@github.com:PradnyaBaviskar/loopback-boot.git","clone_url":"https://github.com/PradnyaBaviskar/loopback-boot.git","svn_url":"https://github.com/PradnyaBaviskar/loopback-boot","homepage":null,"size":444,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"d7c67c803aadd46a514114f449fffabe3edf110e","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20100867,"name":"loopback-boot","full_name":"strongloop/loopback-boot","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-boot","description":"Convention-based bootstrapper for LoopBack applications","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-boot","forks_url":"https://api.github.com/repos/strongloop/loopback-boot/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-boot/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-boot/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-boot/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-boot/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-boot/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-boot/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-boot/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-boot/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-boot/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-boot/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-boot/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-boot/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-boot/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-boot/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-boot/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-boot/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-boot/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-boot/releases{/id}","created_at":"2014-05-23T13:41:51Z","updated_at":"2015-03-20T15:32:25Z","pushed_at":"2015-04-01T17:40:30Z","git_url":"git://github.com/strongloop/loopback-boot.git","ssh_url":"git@github.com:strongloop/loopback-boot.git","clone_url":"https://github.com/strongloop/loopback-boot.git","svn_url":"https://github.com/strongloop/loopback-boot","homepage":null,"size":2011,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":32,"forks":29,"open_issues":32,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114"},"html":{"href":"https://github.com/strongloop/loopback-boot/pull/114"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-boot/issues/114"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-boot/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-boot/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-boot/statuses/ca4f2c5b5c5537954a47123c2b3129a662b08807"}}}}