{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/45484192","id":45484192,"diff_hunk":"@@ -1293,7 +1293,7 @@ _get_field_view(PyArrayObject *arr, PyObject *ind, PyArrayObject **view)\n                                     PyArray_NDIM(arr),\n                                     PyArray_SHAPE(arr),\n                                     PyArray_STRIDES(arr),\n-                                    PyArray_DATA(arr) + offset,\n+                                    ((char *)PyArray_DATA(arr)) + offset,","path":"numpy/core/src/multiarray/mapping.c","position":5,"original_position":5,"commit_id":"4d2d360fd75301d4a3cb9914872f90fbef689667","original_commit_id":"4d2d360fd75301d4a3cb9914872f90fbef689667","user":{"login":"seberg","id":61977,"avatar_url":"https://avatars.githubusercontent.com/u/61977?v=3","gravatar_id":"","url":"https://api.github.com/users/seberg","html_url":"https://github.com/seberg","followers_url":"https://api.github.com/users/seberg/followers","following_url":"https://api.github.com/users/seberg/following{/other_user}","gists_url":"https://api.github.com/users/seberg/gists{/gist_id}","starred_url":"https://api.github.com/users/seberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seberg/subscriptions","organizations_url":"https://api.github.com/users/seberg/orgs","repos_url":"https://api.github.com/users/seberg/repos","events_url":"https://api.github.com/users/seberg/events{/privacy}","received_events_url":"https://api.github.com/users/seberg/received_events","type":"User","site_admin":false},"body":"`PyArray_Bytes` is a bti nicer here, since that is exactly what it is good for (instead of the cast).","created_at":"2015-11-20T16:00:07Z","updated_at":"2015-11-20T16:00:07Z","html_url":"https://github.com/numpy/numpy/pull/6662#discussion_r45484192","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/6662","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/45484192"},"html":{"href":"https://github.com/numpy/numpy/pull/6662#discussion_r45484192"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/6662"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/6662","id":50327077,"html_url":"https://github.com/numpy/numpy/pull/6662","diff_url":"https://github.com/numpy/numpy/pull/6662.diff","patch_url":"https://github.com/numpy/numpy/pull/6662.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/6662","number":6662,"state":"open","locked":false,"title":"Changed lines for successfull MSVC 14.0 compiling","user":{"login":"Iceman9","id":9912779,"avatar_url":"https://avatars.githubusercontent.com/u/9912779?v=3","gravatar_id":"","url":"https://api.github.com/users/Iceman9","html_url":"https://github.com/Iceman9","followers_url":"https://api.github.com/users/Iceman9/followers","following_url":"https://api.github.com/users/Iceman9/following{/other_user}","gists_url":"https://api.github.com/users/Iceman9/gists{/gist_id}","starred_url":"https://api.github.com/users/Iceman9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iceman9/subscriptions","organizations_url":"https://api.github.com/users/Iceman9/orgs","repos_url":"https://api.github.com/users/Iceman9/repos","events_url":"https://api.github.com/users/Iceman9/events{/privacy}","received_events_url":"https://api.github.com/users/Iceman9/received_events","type":"User","site_admin":false},"body":"Edited lines in ../numpy/core/src/multiarray/mapping.c and ../numpy/core/src/private/mem_overlap.c, namely functions that are not legally defined for MSVC 14.0. Need testing if the free (pointer) functions are properly placed in mem_overlap.c\r\n\r\nThis fixes the errors when trying to compile with MSVC 14.0 for python 3.5","created_at":"2015-11-10T23:24:03Z","updated_at":"2015-11-20T16:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1930b2140d904d059d7e53c9844ddd5a03e6014","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/6662/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/6662/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/6662/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/4d2d360fd75301d4a3cb9914872f90fbef689667","head":{"label":"Iceman9:simicg","ref":"simicg","sha":"4d2d360fd75301d4a3cb9914872f90fbef689667","user":{"login":"Iceman9","id":9912779,"avatar_url":"https://avatars.githubusercontent.com/u/9912779?v=3","gravatar_id":"","url":"https://api.github.com/users/Iceman9","html_url":"https://github.com/Iceman9","followers_url":"https://api.github.com/users/Iceman9/followers","following_url":"https://api.github.com/users/Iceman9/following{/other_user}","gists_url":"https://api.github.com/users/Iceman9/gists{/gist_id}","starred_url":"https://api.github.com/users/Iceman9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iceman9/subscriptions","organizations_url":"https://api.github.com/users/Iceman9/orgs","repos_url":"https://api.github.com/users/Iceman9/repos","events_url":"https://api.github.com/users/Iceman9/events{/privacy}","received_events_url":"https://api.github.com/users/Iceman9/received_events","type":"User","site_admin":false},"repo":{"id":45945652,"name":"numpy","full_name":"Iceman9/numpy","owner":{"login":"Iceman9","id":9912779,"avatar_url":"https://avatars.githubusercontent.com/u/9912779?v=3","gravatar_id":"","url":"https://api.github.com/users/Iceman9","html_url":"https://github.com/Iceman9","followers_url":"https://api.github.com/users/Iceman9/followers","following_url":"https://api.github.com/users/Iceman9/following{/other_user}","gists_url":"https://api.github.com/users/Iceman9/gists{/gist_id}","starred_url":"https://api.github.com/users/Iceman9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iceman9/subscriptions","organizations_url":"https://api.github.com/users/Iceman9/orgs","repos_url":"https://api.github.com/users/Iceman9/repos","events_url":"https://api.github.com/users/Iceman9/events{/privacy}","received_events_url":"https://api.github.com/users/Iceman9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Iceman9/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/Iceman9/numpy","forks_url":"https://api.github.com/repos/Iceman9/numpy/forks","keys_url":"https://api.github.com/repos/Iceman9/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Iceman9/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Iceman9/numpy/teams","hooks_url":"https://api.github.com/repos/Iceman9/numpy/hooks","issue_events_url":"https://api.github.com/repos/Iceman9/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/Iceman9/numpy/events","assignees_url":"https://api.github.com/repos/Iceman9/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/Iceman9/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/Iceman9/numpy/tags","blobs_url":"https://api.github.com/repos/Iceman9/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Iceman9/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Iceman9/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Iceman9/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Iceman9/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/Iceman9/numpy/languages","stargazers_url":"https://api.github.com/repos/Iceman9/numpy/stargazers","contributors_url":"https://api.github.com/repos/Iceman9/numpy/contributors","subscribers_url":"https://api.github.com/repos/Iceman9/numpy/subscribers","subscription_url":"https://api.github.com/repos/Iceman9/numpy/subscription","commits_url":"https://api.github.com/repos/Iceman9/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Iceman9/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Iceman9/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Iceman9/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Iceman9/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/Iceman9/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Iceman9/numpy/merges","archive_url":"https://api.github.com/repos/Iceman9/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Iceman9/numpy/downloads","issues_url":"https://api.github.com/repos/Iceman9/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/Iceman9/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/Iceman9/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/Iceman9/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Iceman9/numpy/labels{/name}","releases_url":"https://api.github.com/repos/Iceman9/numpy/releases{/id}","created_at":"2015-11-10T22:53:02Z","updated_at":"2015-11-10T22:53:13Z","pushed_at":"2015-11-18T22:30:43Z","git_url":"git://github.com/Iceman9/numpy.git","ssh_url":"git@github.com:Iceman9/numpy.git","clone_url":"https://github.com/Iceman9/numpy.git","svn_url":"https://github.com/Iceman9/numpy","homepage":"http://www.numpy.org/","size":41939,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"d05d26a5b3fb9b1add1b9a13836d3c8a20ca1d9d","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","created_at":"2010-09-13T23:02:39Z","updated_at":"2015-11-20T11:08:00Z","pushed_at":"2015-11-20T14:38:21Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":62701,"stargazers_count":2338,"watchers_count":2338,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1221,"mirror_url":null,"open_issues_count":1061,"forks":1221,"open_issues":1061,"watchers":2338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/6662"},"html":{"href":"https://github.com/numpy/numpy/pull/6662"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/6662"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/6662/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/6662/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/6662/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/4d2d360fd75301d4a3cb9914872f90fbef689667"}}}}