{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/8378","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8378/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8378/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8378/events","html_url":"https://github.com/joomla/joomla-cms/issues/8378","id":116310524,"number":8378,"title":"J3.5: Editor buttons can no longer define popup size","user":{"login":"nonumber","id":744259,"avatar_url":"https://avatars.githubusercontent.com/u/744259?v=3","gravatar_id":"","url":"https://api.github.com/users/nonumber","html_url":"https://github.com/nonumber","followers_url":"https://api.github.com/users/nonumber/followers","following_url":"https://api.github.com/users/nonumber/following{/other_user}","gists_url":"https://api.github.com/users/nonumber/gists{/gist_id}","starred_url":"https://api.github.com/users/nonumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonumber/subscriptions","organizations_url":"https://api.github.com/users/nonumber/orgs","repos_url":"https://api.github.com/users/nonumber/repos","events_url":"https://api.github.com/users/nonumber/events{/privacy}","received_events_url":"https://api.github.com/users/nonumber/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/No%20Code%20Attached%20Yet","name":"No Code Attached Yet","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-11-11T10:59:21Z","updated_at":"2015-11-11T15:18:02Z","closed_at":null,"body":"Since the implementation of https://github.com/joomla/joomla-cms/pull/7170 the editor buttons have no control anymore over the size of the modal popup.\r\nYou could do this before in the editors-xtd plugins render method:\r\n```$button->options = \"{handler: 'iframe', size: {x:window.getSize().x-100, y: window.getSize().y-100}}\";```\r\nThis would get placed in the html ```rel``` attribute used by the Squeezebox modal.\r\n\r\nNow the ```option``` is completely disregarded.\r\n\r\nThese plugins can also be having different scripts inside the modal to control the popup, like closing it on click.\r\nThese all now fail ungracefully\r\n\r\nEven the core ```Article``` button doesn't work anymore (aside from the fact that it looks bad because of the missing padding in the modal).\r\nIt will insert the article, but not close the modal, with js error:\r\n```\r\njModalClose is not defined\r\n```\r\n\r\nThis is a serious B/C issue and this PR needs to get reverted, IMO."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/155812301","html_url":"https://github.com/joomla/joomla-cms/issues/8378#issuecomment-155812301","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8378","id":155812301,"user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T15:18:01Z","updated_at":"2015-11-11T15:18:01Z","body":"> But you do expect that Joomla will deal with every odd thing any developer is doing out there?\r\n\r\nIt's not an odd thing when a core button itself becomes an issue with it."}}