{"action":"closed","number":7623,"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/7623","id":15874327,"html_url":"https://github.com/joyent/node/pull/7623","diff_url":"https://github.com/joyent/node/pull/7623.diff","patch_url":"https://github.com/joyent/node/pull/7623.patch","issue_url":"https://api.github.com/repos/joyent/node/issues/7623","number":7623,"state":"closed","locked":false,"title":"missing close event after EPIPE error","user":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"body":"The documentation for a `net.Socket` states [here](http://nodejs.org/api/net.html#net_event_error_1):\r\n\r\n> Event: 'error'#\r\n> Error object\r\n> Emitted when an error occurs. The 'close' event will be called directly following this event.\r\n\r\nThis does however not happen after an `EPIPE` error. I made the `net-write-after-close` test fail by waiting for that event.\r\n\r\nI'm not sure how to fix this, of course we could just `self.emit('close')` [here](https://github.com/joyent/node/blob/master/lib/net.js#L278) in `writeAfterFIN`, but it seems like this should rather happen somewhere around [here](https://github.com/joyent/node/blob/master/lib/net.js#L261) in `onSocketEnd()` or `destroySoon()`.","created_at":"2014-05-14T12:05:12Z","updated_at":"2015-08-15T17:10:20Z","closed_at":"2015-08-15T17:10:20Z","merged_at":null,"merge_commit_sha":"8d1af88ed1cf45e97140ddc8df99f4628709ad1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/node/pulls/7623/commits","review_comments_url":"https://api.github.com/repos/joyent/node/pulls/7623/comments","review_comment_url":"https://api.github.com/repos/joyent/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joyent/node/issues/7623/comments","statuses_url":"https://api.github.com/repos/joyent/node/statuses/38b16caf9aa27f4b33af4d7370c418e00aab2187","head":{"label":"juliangruber:close-after-epipe","ref":"close-after-epipe","sha":"38b16caf9aa27f4b33af4d7370c418e00aab2187","user":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"repo":{"id":8657441,"name":"node","full_name":"juliangruber/node","owner":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliangruber/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/juliangruber/node","forks_url":"https://api.github.com/repos/juliangruber/node/forks","keys_url":"https://api.github.com/repos/juliangruber/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliangruber/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliangruber/node/teams","hooks_url":"https://api.github.com/repos/juliangruber/node/hooks","issue_events_url":"https://api.github.com/repos/juliangruber/node/issues/events{/number}","events_url":"https://api.github.com/repos/juliangruber/node/events","assignees_url":"https://api.github.com/repos/juliangruber/node/assignees{/user}","branches_url":"https://api.github.com/repos/juliangruber/node/branches{/branch}","tags_url":"https://api.github.com/repos/juliangruber/node/tags","blobs_url":"https://api.github.com/repos/juliangruber/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliangruber/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliangruber/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliangruber/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliangruber/node/statuses/{sha}","languages_url":"https://api.github.com/repos/juliangruber/node/languages","stargazers_url":"https://api.github.com/repos/juliangruber/node/stargazers","contributors_url":"https://api.github.com/repos/juliangruber/node/contributors","subscribers_url":"https://api.github.com/repos/juliangruber/node/subscribers","subscription_url":"https://api.github.com/repos/juliangruber/node/subscription","commits_url":"https://api.github.com/repos/juliangruber/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliangruber/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliangruber/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliangruber/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliangruber/node/contents/{+path}","compare_url":"https://api.github.com/repos/juliangruber/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliangruber/node/merges","archive_url":"https://api.github.com/repos/juliangruber/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliangruber/node/downloads","issues_url":"https://api.github.com/repos/juliangruber/node/issues{/number}","pulls_url":"https://api.github.com/repos/juliangruber/node/pulls{/number}","milestones_url":"https://api.github.com/repos/juliangruber/node/milestones{/number}","notifications_url":"https://api.github.com/repos/juliangruber/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliangruber/node/labels{/name}","releases_url":"https://api.github.com/repos/juliangruber/node/releases{/id}","created_at":"2013-03-08T18:39:43Z","updated_at":"2014-10-11T00:45:22Z","pushed_at":"2014-05-23T15:26:08Z","git_url":"git://github.com/juliangruber/node.git","ssh_url":"git@github.com:juliangruber/node.git","clone_url":"https://github.com/juliangruber/node.git","svn_url":"https://github.com/juliangruber/node","homepage":"http://nodejs.org/","size":97805,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"31d4847d8b18cf487775dee3471dd4653b7d860b","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":211666,"name":"node","full_name":"joyent/node","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node","description":"evented I/O for v8 javascript","fork":false,"url":"https://api.github.com/repos/joyent/node","forks_url":"https://api.github.com/repos/joyent/node/forks","keys_url":"https://api.github.com/repos/joyent/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node/teams","hooks_url":"https://api.github.com/repos/joyent/node/hooks","issue_events_url":"https://api.github.com/repos/joyent/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node/events","assignees_url":"https://api.github.com/repos/joyent/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node/tags","blobs_url":"https://api.github.com/repos/joyent/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node/languages","stargazers_url":"https://api.github.com/repos/joyent/node/stargazers","contributors_url":"https://api.github.com/repos/joyent/node/contributors","subscribers_url":"https://api.github.com/repos/joyent/node/subscribers","subscription_url":"https://api.github.com/repos/joyent/node/subscription","commits_url":"https://api.github.com/repos/joyent/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node/merges","archive_url":"https://api.github.com/repos/joyent/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node/downloads","issues_url":"https://api.github.com/repos/joyent/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node/releases{/id}","created_at":"2009-05-27T16:29:46Z","updated_at":"2015-08-15T15:08:37Z","pushed_at":"2015-08-15T11:50:45Z","git_url":"git://github.com/joyent/node.git","ssh_url":"git@github.com:joyent/node.git","clone_url":"https://github.com/joyent/node.git","svn_url":"https://github.com/joyent/node","homepage":"http://nodejs.org/","size":360510,"stargazers_count":37762,"watchers_count":37762,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":8556,"mirror_url":null,"open_issues_count":921,"forks":8556,"open_issues":921,"watchers":37762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/7623"},"html":{"href":"https://github.com/joyent/node/pull/7623"},"issue":{"href":"https://api.github.com/repos/joyent/node/issues/7623"},"comments":{"href":"https://api.github.com/repos/joyent/node/issues/7623/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node/pulls/7623/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joyent/node/pulls/7623/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node/statuses/38b16caf9aa27f4b33af4d7370c418e00aab2187"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":9,"review_comments":0,"commits":2,"additions":17,"deletions":5,"changed_files":2}}