{"action":"created","comment":{"url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/comments/24740620","id":24740620,"diff_hunk":"@@ -36,7 +36,11 @@ public static function create_form( $namespace ) {\n \t *\n \t * @return null|string\n \t */\n-\tpublic static function end_form( $button_label = 'Save changes', $name = 'submit', $onclick = null ) {\n+\tpublic static function end_form( $button_label = null, $name = 'submit', $onclick = null ) {\n+\t\tif ( $button_label === null ) {","path":"admin/class-admin-form.php","position":6,"original_position":6,"commit_id":"98d2152443a6b30b0613958470e6ee5edfa85d12","original_commit_id":"98d2152443a6b30b0613958470e6ee5edfa85d12","user":{"login":"Petervw","id":7113270,"avatar_url":"https://avatars.githubusercontent.com/u/7113270?v=3","gravatar_id":"","url":"https://api.github.com/users/Petervw","html_url":"https://github.com/Petervw","followers_url":"https://api.github.com/users/Petervw/followers","following_url":"https://api.github.com/users/Petervw/following{/other_user}","gists_url":"https://api.github.com/users/Petervw/gists{/gist_id}","starred_url":"https://api.github.com/users/Petervw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Petervw/subscriptions","organizations_url":"https://api.github.com/users/Petervw/orgs","repos_url":"https://api.github.com/users/Petervw/repos","events_url":"https://api.github.com/users/Petervw/events{/privacy}","received_events_url":"https://api.github.com/users/Petervw/received_events","type":"User","site_admin":false},"body":"Isn't it possible to use this instead?\r\n```public static function end_form( $button_label = __( 'Save changes', 'google-analytics-for-wordpress' ), $name = 'submit', $onclick = null ) {```","created_at":"2015-02-16T09:52:43Z","updated_at":"2015-02-16T09:52:43Z","html_url":"https://github.com/Yoast/google-analytics-for-wordpress/pull/315#discussion_r24740620","pull_request_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315","_links":{"self":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/comments/24740620"},"html":{"href":"https://github.com/Yoast/google-analytics-for-wordpress/pull/315#discussion_r24740620"},"pull_request":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315","id":29267549,"html_url":"https://github.com/Yoast/google-analytics-for-wordpress/pull/315","diff_url":"https://github.com/Yoast/google-analytics-for-wordpress/pull/315.diff","patch_url":"https://github.com/Yoast/google-analytics-for-wordpress/pull/315.patch","issue_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/315","number":315,"state":"open","locked":false,"title":"Translate untranslatable string [Delivers #88223448]","user":{"login":"andizer","id":325040,"avatar_url":"https://avatars.githubusercontent.com/u/325040?v=3","gravatar_id":"","url":"https://api.github.com/users/andizer","html_url":"https://github.com/andizer","followers_url":"https://api.github.com/users/andizer/followers","following_url":"https://api.github.com/users/andizer/following{/other_user}","gists_url":"https://api.github.com/users/andizer/gists{/gist_id}","starred_url":"https://api.github.com/users/andizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andizer/subscriptions","organizations_url":"https://api.github.com/users/andizer/orgs","repos_url":"https://api.github.com/users/andizer/repos","events_url":"https://api.github.com/users/andizer/events{/privacy}","received_events_url":"https://api.github.com/users/andizer/received_events","type":"User","site_admin":false},"body":"Finish #304 ","created_at":"2015-02-13T14:20:50Z","updated_at":"2015-02-16T09:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0216ac715537957264b95c3f5c2c4d3856535ba6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315/commits","review_comments_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315/comments","review_comment_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/315/comments","statuses_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/statuses/98d2152443a6b30b0613958470e6ee5edfa85d12","head":{"label":"Yoast:stories/AM/untranslatable_string","ref":"stories/AM/untranslatable_string","sha":"98d2152443a6b30b0613958470e6ee5edfa85d12","user":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars.githubusercontent.com/u/4690436?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":11945060,"name":"google-analytics-for-wordpress","full_name":"Yoast/google-analytics-for-wordpress","owner":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars.githubusercontent.com/u/4690436?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/google-analytics-for-wordpress","description":"Add Google Analytics to WordPress and be able to use all the powerful functions Google Analytics offers","fork":false,"url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress","forks_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/forks","keys_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/teams","hooks_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/hooks","issue_events_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/events","assignees_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/tags","blobs_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/languages","stargazers_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/stargazers","contributors_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/contributors","subscribers_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/subscribers","subscription_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/subscription","commits_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/merges","archive_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/downloads","issues_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/releases{/id}","created_at":"2013-08-07T08:23:34Z","updated_at":"2015-02-12T09:58:40Z","pushed_at":"2015-02-13T14:17:49Z","git_url":"git://github.com/Yoast/google-analytics-for-wordpress.git","ssh_url":"git@github.com:Yoast/google-analytics-for-wordpress.git","clone_url":"https://github.com/Yoast/google-analytics-for-wordpress.git","svn_url":"https://github.com/Yoast/google-analytics-for-wordpress","homepage":null,"size":6144,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":27,"forks":51,"open_issues":27,"watchers":67,"default_branch":"trunk"}},"base":{"label":"Yoast:trunk","ref":"trunk","sha":"09f820e655d2c009f969accb545e9e5f7bbc3fe8","user":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars.githubusercontent.com/u/4690436?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":11945060,"name":"google-analytics-for-wordpress","full_name":"Yoast/google-analytics-for-wordpress","owner":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars.githubusercontent.com/u/4690436?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/google-analytics-for-wordpress","description":"Add Google Analytics to WordPress and be able to use all the powerful functions Google Analytics offers","fork":false,"url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress","forks_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/forks","keys_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/teams","hooks_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/hooks","issue_events_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/events","assignees_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/tags","blobs_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/languages","stargazers_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/stargazers","contributors_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/contributors","subscribers_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/subscribers","subscription_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/subscription","commits_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/merges","archive_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/downloads","issues_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/releases{/id}","created_at":"2013-08-07T08:23:34Z","updated_at":"2015-02-12T09:58:40Z","pushed_at":"2015-02-13T14:17:49Z","git_url":"git://github.com/Yoast/google-analytics-for-wordpress.git","ssh_url":"git@github.com:Yoast/google-analytics-for-wordpress.git","clone_url":"https://github.com/Yoast/google-analytics-for-wordpress.git","svn_url":"https://github.com/Yoast/google-analytics-for-wordpress","homepage":null,"size":6144,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":27,"forks":51,"open_issues":27,"watchers":67,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315"},"html":{"href":"https://github.com/Yoast/google-analytics-for-wordpress/pull/315"},"issue":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/315"},"comments":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/google-analytics-for-wordpress/statuses/98d2152443a6b30b0613958470e6ee5edfa85d12"}}}}