{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/46004623","id":46004623,"diff_hunk":"@@ -40,3 +43,17 @@ int putchar(int c)\n     uart_stdio_write(&_c, 1);\n     return 1;\n }\n+\n+/**\n+ * @brief   Write nbyte characters to the STDIO UART interface\n+ */\n+ssize_t write(int fildes, const void *buf, size_t nbyte)\n+{\n+    if (fildes == STDOUT_FILENO) {\n+        uart_stdio_write(buf, nbyte);","path":"cpu/msp430fxyz/msp430_stdio.c","position":21,"original_position":21,"commit_id":"2b67357e6046b3576e5c5eaba85ecfb4d52c98f1","original_commit_id":"2b67357e6046b3576e5c5eaba85ecfb4d52c98f1","user":{"login":"Kijewski","id":136776,"avatar_url":"https://avatars.githubusercontent.com/u/136776?v=3","gravatar_id":"","url":"https://api.github.com/users/Kijewski","html_url":"https://github.com/Kijewski","followers_url":"https://api.github.com/users/Kijewski/followers","following_url":"https://api.github.com/users/Kijewski/following{/other_user}","gists_url":"https://api.github.com/users/Kijewski/gists{/gist_id}","starred_url":"https://api.github.com/users/Kijewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kijewski/subscriptions","organizations_url":"https://api.github.com/users/Kijewski/orgs","repos_url":"https://api.github.com/users/Kijewski/repos","events_url":"https://api.github.com/users/Kijewski/events{/privacy}","received_events_url":"https://api.github.com/users/Kijewski/received_events","type":"User","site_admin":false},"body":"Why don't you `return uart_stdio_write(buf, nbyte);`?","created_at":"2015-11-26T20:00:14Z","updated_at":"2015-11-26T20:00:14Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/4312#discussion_r46004623","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/46004623"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/4312#discussion_r46004623"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312","id":51216679,"html_url":"https://github.com/RIOT-OS/RIOT/pull/4312","diff_url":"https://github.com/RIOT-OS/RIOT/pull/4312.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/4312.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4312","number":4312,"state":"open","locked":false,"title":"cpu: atmega_common, msp430: misc libc fixes for fmt","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"body":"AVR & msp430 don't have write().\r\n\r\nThis PR makes fmt use fwrite() on AVR, and implements write() using uart for the msp430s.\r\nAlso includes some related libc header fixes.\r\n\r\nWithout this, fmt will not compile on those platforms.","created_at":"2015-11-19T12:35:31Z","updated_at":"2015-11-26T20:00:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d3c3da1498bc5393f1b2c9496f6b1c6609083f7","assignee":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4312/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/2b67357e6046b3576e5c5eaba85ecfb4d52c98f1","head":{"label":"kaspar030:misc_fmt_compile_fixes","ref":"misc_fmt_compile_fixes","sha":"2b67357e6046b3576e5c5eaba85ecfb4d52c98f1","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"repo":{"id":14115364,"name":"RIOT","full_name":"kaspar030/RIOT","owner":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaspar030/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/kaspar030/RIOT","forks_url":"https://api.github.com/repos/kaspar030/RIOT/forks","keys_url":"https://api.github.com/repos/kaspar030/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaspar030/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaspar030/RIOT/teams","hooks_url":"https://api.github.com/repos/kaspar030/RIOT/hooks","issue_events_url":"https://api.github.com/repos/kaspar030/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/kaspar030/RIOT/events","assignees_url":"https://api.github.com/repos/kaspar030/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/kaspar030/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/kaspar030/RIOT/tags","blobs_url":"https://api.github.com/repos/kaspar030/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaspar030/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaspar030/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaspar030/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaspar030/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/kaspar030/RIOT/languages","stargazers_url":"https://api.github.com/repos/kaspar030/RIOT/stargazers","contributors_url":"https://api.github.com/repos/kaspar030/RIOT/contributors","subscribers_url":"https://api.github.com/repos/kaspar030/RIOT/subscribers","subscription_url":"https://api.github.com/repos/kaspar030/RIOT/subscription","commits_url":"https://api.github.com/repos/kaspar030/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaspar030/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaspar030/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaspar030/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaspar030/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/kaspar030/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaspar030/RIOT/merges","archive_url":"https://api.github.com/repos/kaspar030/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaspar030/RIOT/downloads","issues_url":"https://api.github.com/repos/kaspar030/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/kaspar030/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/kaspar030/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/kaspar030/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaspar030/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/kaspar030/RIOT/releases{/id}","created_at":"2013-11-04T16:04:12Z","updated_at":"2015-05-08T14:32:24Z","pushed_at":"2015-11-26T19:42:37Z","git_url":"git://github.com/kaspar030/RIOT.git","ssh_url":"git@github.com:kaspar030/RIOT.git","clone_url":"https://github.com/kaspar030/RIOT.git","svn_url":"https://github.com/kaspar030/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":22876,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"ab3345ac5a5d92d9be70ef21fd8a2928dc0a7afe","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-11-25T19:43:57Z","pushed_at":"2015-11-26T19:42:37Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":78068,"stargazers_count":566,"watchers_count":566,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":439,"mirror_url":null,"open_issues_count":429,"forks":439,"open_issues":429,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/4312"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4312"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4312/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4312/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/2b67357e6046b3576e5c5eaba85ecfb4d52c98f1"}}}}