{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/22587673","id":22587673,"diff_hunk":"@@ -0,0 +1,28 @@\n+class ConvertShowRefreshButtonAndLoadValuesOnInitToRealColumnsForDialogFields < ActiveRecord::Migration\n+  class DialogField < ActiveRecord::Base\n+    serialize :options\n+    self.inheritance_column = :_type_disabled\n+  end\n+\n+  def up\n+    add_column :dialog_fields, :show_refresh_button, :boolean\n+    add_column :dialog_fields, :load_values_on_init, :boolean\n+\n+    DialogField.all.each do |dialog_field|\n+      dialog_field.show_refresh_button = dialog_field.options[:show_refresh_button]\n+      dialog_field.load_values_on_init = dialog_field.options[:load_values_on_init]","path":"vmdb/db/migrate/20141126161823_convert_show_refresh_button_and_load_values_on_init_to_real_columns_for_dialog_fields.rb","position":13,"original_position":13,"commit_id":"0164d4b3a40758fb11b9fbeddc271283bb31e3bb","original_commit_id":"0164d4b3a40758fb11b9fbeddc271283bb31e3bb","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"body":"The options hash keys should be removed once the data is migrated to the dedicated columns.\r\n```ruby\r\ndialog_field.show_refresh_button = dialog_field.options.delete(:show_refresh_button)\r\ndialog_field.load_values_on_init = dialog_field.options.delete(:load_values_on_init)\r\n```","created_at":"2015-01-07T14:21:13Z","updated_at":"2015-01-07T14:21:13Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1131#discussion_r22587673","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/22587673"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1131#discussion_r22587673"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131","id":25102624,"html_url":"https://github.com/ManageIQ/manageiq/pull/1131","diff_url":"https://github.com/ManageIQ/manageiq/pull/1131.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1131.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1131","number":1131,"state":"open","locked":false,"title":"Dynamic dialog field data migration","user":{"login":"eclarizio","id":164557,"avatar_url":"https://avatars.githubusercontent.com/u/164557?v=3","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"body":"This should be merged in after #1130 \r\n\r\n/cc @gmcculloug ","created_at":"2014-11-26T17:54:58Z","updated_at":"2015-01-07T14:21:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ac5985416a5682a0d31ec89f9db8d83c17865ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1131/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/0164d4b3a40758fb11b9fbeddc271283bb31e3bb","head":{"label":"eclarizio:dynamic_dialog_field_data_migration","ref":"dynamic_dialog_field_data_migration","sha":"0164d4b3a40758fb11b9fbeddc271283bb31e3bb","user":{"login":"eclarizio","id":164557,"avatar_url":"https://avatars.githubusercontent.com/u/164557?v=3","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"repo":{"id":20897772,"name":"manageiq","full_name":"eclarizio/manageiq","owner":{"login":"eclarizio","id":164557,"avatar_url":"https://avatars.githubusercontent.com/u/164557?v=3","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eclarizio/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/eclarizio/manageiq","forks_url":"https://api.github.com/repos/eclarizio/manageiq/forks","keys_url":"https://api.github.com/repos/eclarizio/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclarizio/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclarizio/manageiq/teams","hooks_url":"https://api.github.com/repos/eclarizio/manageiq/hooks","issue_events_url":"https://api.github.com/repos/eclarizio/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/eclarizio/manageiq/events","assignees_url":"https://api.github.com/repos/eclarizio/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/eclarizio/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/eclarizio/manageiq/tags","blobs_url":"https://api.github.com/repos/eclarizio/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclarizio/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclarizio/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclarizio/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclarizio/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/eclarizio/manageiq/languages","stargazers_url":"https://api.github.com/repos/eclarizio/manageiq/stargazers","contributors_url":"https://api.github.com/repos/eclarizio/manageiq/contributors","subscribers_url":"https://api.github.com/repos/eclarizio/manageiq/subscribers","subscription_url":"https://api.github.com/repos/eclarizio/manageiq/subscription","commits_url":"https://api.github.com/repos/eclarizio/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclarizio/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclarizio/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclarizio/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/eclarizio/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/eclarizio/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclarizio/manageiq/merges","archive_url":"https://api.github.com/repos/eclarizio/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclarizio/manageiq/downloads","issues_url":"https://api.github.com/repos/eclarizio/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/eclarizio/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/eclarizio/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/eclarizio/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclarizio/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/eclarizio/manageiq/releases{/id}","created_at":"2014-06-16T19:30:10Z","updated_at":"2014-06-23T20:42:21Z","pushed_at":"2015-01-06T16:47:53Z","git_url":"git://github.com/eclarizio/manageiq.git","ssh_url":"git@github.com:eclarizio/manageiq.git","clone_url":"https://github.com/eclarizio/manageiq.git","svn_url":"https://github.com/eclarizio/manageiq","homepage":null,"size":60664,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"42e87835d933f15ef2e2179ca878bfb5e1f4ac3c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-01-06T23:12:34Z","pushed_at":"2015-01-06T23:12:34Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":82984,"stargazers_count":73,"watchers_count":73,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":214,"forks":80,"open_issues":214,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1131"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1131"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1131/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1131/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/0164d4b3a40758fb11b9fbeddc271283bb31e3bb"}}}}