{"action":"created","comment":{"url":"https://api.github.com/repos/carloscurotto/storm-example/pulls/comments/27584244","id":27584244,"diff_hunk":"@@ -24,23 +26,29 @@\n      * {@link ExceptionTradeStatusMessage} and a {@link TradeCommentsMessage}.\n      * \n      * @param theParameters\n-     *            a {@link java.util.Map<String, Object>}. It must have as a keys \"updateStatus\" as a boolean and\n-     *            \"updateInternalComment\" as a boolean.\n+     *            a {@link java.util.Map<String, Object>}. It cannot be null. \n+     *            It must have as a keys \"updateStatus\" as a boolean and updateInternalComment\" as a boolean.\n      * @param theUpdateRow\n      *            {@link UpdateRow} the row which state should be translated into string messages.\n+     *            It cannot be null.\n      * @return a {@link List<TradeMessage>} with the built messages. It can have from zero to two messages, according to\n      *         the input parameters (see this' method documentation).\n      */\n     public List<TradeMessage> build(final Map<String, Object> theParameters,\n             final UpdateRow theUpdateRow) {\n+        Validate.notNull(theParameters, \"The parameters map cannot be null.\");","path":"src/main/java/ar/com/carloscurotto/storm/complex/topology/propagator/gloss/MessageBuilder.java","position":25,"original_position":25,"commit_id":"b27eb9c55237bde0c9e3534ac84997412e86f1e9","original_commit_id":"b27eb9c55237bde0c9e3534ac84997412e86f1e9","user":{"login":"emacampolo","id":1101540,"avatar_url":"https://avatars.githubusercontent.com/u/1101540?v=3","gravatar_id":"","url":"https://api.github.com/users/emacampolo","html_url":"https://github.com/emacampolo","followers_url":"https://api.github.com/users/emacampolo/followers","following_url":"https://api.github.com/users/emacampolo/following{/other_user}","gists_url":"https://api.github.com/users/emacampolo/gists{/gist_id}","starred_url":"https://api.github.com/users/emacampolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacampolo/subscriptions","organizations_url":"https://api.github.com/users/emacampolo/orgs","repos_url":"https://api.github.com/users/emacampolo/repos","events_url":"https://api.github.com/users/emacampolo/events{/privacy}","received_events_url":"https://api.github.com/users/emacampolo/received_events","type":"User","site_admin":false},"body":"@carloscurotto me gustaria evitar los inline Validate de este metodo. Parece ser que el Map<String, Object> theParameters no tiene sentido cuando es nulo, es vacio y cuando no tiene al menos 3 parametros obligatorios.\r\nDonde te parece poner un metodo validateParameters(parameters) ?","created_at":"2015-04-01T16:11:10Z","updated_at":"2015-04-01T16:11:10Z","html_url":"https://github.com/carloscurotto/storm-example/pull/30#discussion_r27584244","pull_request_url":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/carloscurotto/storm-example/pulls/comments/27584244"},"html":{"href":"https://github.com/carloscurotto/storm-example/pull/30#discussion_r27584244"},"pull_request":{"href":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30","id":32324436,"html_url":"https://github.com/carloscurotto/storm-example/pull/30","diff_url":"https://github.com/carloscurotto/storm-example/pull/30.diff","patch_url":"https://github.com/carloscurotto/storm-example/pull/30.patch","issue_url":"https://api.github.com/repos/carloscurotto/storm-example/issues/30","number":30,"state":"open","locked":false,"title":"Gloss submodule","user":{"login":"mtkdante","id":11541282,"avatar_url":"https://avatars.githubusercontent.com/u/11541282?v=3","gravatar_id":"","url":"https://api.github.com/users/mtkdante","html_url":"https://github.com/mtkdante","followers_url":"https://api.github.com/users/mtkdante/followers","following_url":"https://api.github.com/users/mtkdante/following{/other_user}","gists_url":"https://api.github.com/users/mtkdante/gists{/gist_id}","starred_url":"https://api.github.com/users/mtkdante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtkdante/subscriptions","organizations_url":"https://api.github.com/users/mtkdante/orgs","repos_url":"https://api.github.com/users/mtkdante/repos","events_url":"https://api.github.com/users/mtkdante/events{/privacy}","received_events_url":"https://api.github.com/users/mtkdante/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-31T13:56:36Z","updated_at":"2015-04-01T16:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36af2ed6b4898eb95d08ac1d72717c6f15efee28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30/commits","review_comments_url":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30/comments","review_comment_url":"https://api.github.com/repos/carloscurotto/storm-example/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carloscurotto/storm-example/issues/30/comments","statuses_url":"https://api.github.com/repos/carloscurotto/storm-example/statuses/b27eb9c55237bde0c9e3534ac84997412e86f1e9","head":{"label":"carloscurotto:glossSubmodule","ref":"glossSubmodule","sha":"b27eb9c55237bde0c9e3534ac84997412e86f1e9","user":{"login":"carloscurotto","id":1410334,"avatar_url":"https://avatars.githubusercontent.com/u/1410334?v=3","gravatar_id":"","url":"https://api.github.com/users/carloscurotto","html_url":"https://github.com/carloscurotto","followers_url":"https://api.github.com/users/carloscurotto/followers","following_url":"https://api.github.com/users/carloscurotto/following{/other_user}","gists_url":"https://api.github.com/users/carloscurotto/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscurotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscurotto/subscriptions","organizations_url":"https://api.github.com/users/carloscurotto/orgs","repos_url":"https://api.github.com/users/carloscurotto/repos","events_url":"https://api.github.com/users/carloscurotto/events{/privacy}","received_events_url":"https://api.github.com/users/carloscurotto/received_events","type":"User","site_admin":false},"repo":{"id":10831185,"name":"storm-example","full_name":"carloscurotto/storm-example","owner":{"login":"carloscurotto","id":1410334,"avatar_url":"https://avatars.githubusercontent.com/u/1410334?v=3","gravatar_id":"","url":"https://api.github.com/users/carloscurotto","html_url":"https://github.com/carloscurotto","followers_url":"https://api.github.com/users/carloscurotto/followers","following_url":"https://api.github.com/users/carloscurotto/following{/other_user}","gists_url":"https://api.github.com/users/carloscurotto/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscurotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscurotto/subscriptions","organizations_url":"https://api.github.com/users/carloscurotto/orgs","repos_url":"https://api.github.com/users/carloscurotto/repos","events_url":"https://api.github.com/users/carloscurotto/events{/privacy}","received_events_url":"https://api.github.com/users/carloscurotto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carloscurotto/storm-example","description":"A simple example of use of the storm framework for online stream processing","fork":false,"url":"https://api.github.com/repos/carloscurotto/storm-example","forks_url":"https://api.github.com/repos/carloscurotto/storm-example/forks","keys_url":"https://api.github.com/repos/carloscurotto/storm-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carloscurotto/storm-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carloscurotto/storm-example/teams","hooks_url":"https://api.github.com/repos/carloscurotto/storm-example/hooks","issue_events_url":"https://api.github.com/repos/carloscurotto/storm-example/issues/events{/number}","events_url":"https://api.github.com/repos/carloscurotto/storm-example/events","assignees_url":"https://api.github.com/repos/carloscurotto/storm-example/assignees{/user}","branches_url":"https://api.github.com/repos/carloscurotto/storm-example/branches{/branch}","tags_url":"https://api.github.com/repos/carloscurotto/storm-example/tags","blobs_url":"https://api.github.com/repos/carloscurotto/storm-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carloscurotto/storm-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carloscurotto/storm-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/carloscurotto/storm-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carloscurotto/storm-example/statuses/{sha}","languages_url":"https://api.github.com/repos/carloscurotto/storm-example/languages","stargazers_url":"https://api.github.com/repos/carloscurotto/storm-example/stargazers","contributors_url":"https://api.github.com/repos/carloscurotto/storm-example/contributors","subscribers_url":"https://api.github.com/repos/carloscurotto/storm-example/subscribers","subscription_url":"https://api.github.com/repos/carloscurotto/storm-example/subscription","commits_url":"https://api.github.com/repos/carloscurotto/storm-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/carloscurotto/storm-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/carloscurotto/storm-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/carloscurotto/storm-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/carloscurotto/storm-example/contents/{+path}","compare_url":"https://api.github.com/repos/carloscurotto/storm-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carloscurotto/storm-example/merges","archive_url":"https://api.github.com/repos/carloscurotto/storm-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carloscurotto/storm-example/downloads","issues_url":"https://api.github.com/repos/carloscurotto/storm-example/issues{/number}","pulls_url":"https://api.github.com/repos/carloscurotto/storm-example/pulls{/number}","milestones_url":"https://api.github.com/repos/carloscurotto/storm-example/milestones{/number}","notifications_url":"https://api.github.com/repos/carloscurotto/storm-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carloscurotto/storm-example/labels{/name}","releases_url":"https://api.github.com/repos/carloscurotto/storm-example/releases{/id}","created_at":"2013-06-20T22:51:59Z","updated_at":"2015-03-31T20:09:24Z","pushed_at":"2015-04-01T14:54:32Z","git_url":"git://github.com/carloscurotto/storm-example.git","ssh_url":"git@github.com:carloscurotto/storm-example.git","clone_url":"https://github.com/carloscurotto/storm-example.git","svn_url":"https://github.com/carloscurotto/storm-example","homepage":null,"size":1065,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"carloscurotto:master","ref":"master","sha":"6c56a2add05c34909c96279ded6efb0425f3d4d5","user":{"login":"carloscurotto","id":1410334,"avatar_url":"https://avatars.githubusercontent.com/u/1410334?v=3","gravatar_id":"","url":"https://api.github.com/users/carloscurotto","html_url":"https://github.com/carloscurotto","followers_url":"https://api.github.com/users/carloscurotto/followers","following_url":"https://api.github.com/users/carloscurotto/following{/other_user}","gists_url":"https://api.github.com/users/carloscurotto/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscurotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscurotto/subscriptions","organizations_url":"https://api.github.com/users/carloscurotto/orgs","repos_url":"https://api.github.com/users/carloscurotto/repos","events_url":"https://api.github.com/users/carloscurotto/events{/privacy}","received_events_url":"https://api.github.com/users/carloscurotto/received_events","type":"User","site_admin":false},"repo":{"id":10831185,"name":"storm-example","full_name":"carloscurotto/storm-example","owner":{"login":"carloscurotto","id":1410334,"avatar_url":"https://avatars.githubusercontent.com/u/1410334?v=3","gravatar_id":"","url":"https://api.github.com/users/carloscurotto","html_url":"https://github.com/carloscurotto","followers_url":"https://api.github.com/users/carloscurotto/followers","following_url":"https://api.github.com/users/carloscurotto/following{/other_user}","gists_url":"https://api.github.com/users/carloscurotto/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscurotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscurotto/subscriptions","organizations_url":"https://api.github.com/users/carloscurotto/orgs","repos_url":"https://api.github.com/users/carloscurotto/repos","events_url":"https://api.github.com/users/carloscurotto/events{/privacy}","received_events_url":"https://api.github.com/users/carloscurotto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carloscurotto/storm-example","description":"A simple example of use of the storm framework for online stream processing","fork":false,"url":"https://api.github.com/repos/carloscurotto/storm-example","forks_url":"https://api.github.com/repos/carloscurotto/storm-example/forks","keys_url":"https://api.github.com/repos/carloscurotto/storm-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carloscurotto/storm-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carloscurotto/storm-example/teams","hooks_url":"https://api.github.com/repos/carloscurotto/storm-example/hooks","issue_events_url":"https://api.github.com/repos/carloscurotto/storm-example/issues/events{/number}","events_url":"https://api.github.com/repos/carloscurotto/storm-example/events","assignees_url":"https://api.github.com/repos/carloscurotto/storm-example/assignees{/user}","branches_url":"https://api.github.com/repos/carloscurotto/storm-example/branches{/branch}","tags_url":"https://api.github.com/repos/carloscurotto/storm-example/tags","blobs_url":"https://api.github.com/repos/carloscurotto/storm-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carloscurotto/storm-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carloscurotto/storm-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/carloscurotto/storm-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carloscurotto/storm-example/statuses/{sha}","languages_url":"https://api.github.com/repos/carloscurotto/storm-example/languages","stargazers_url":"https://api.github.com/repos/carloscurotto/storm-example/stargazers","contributors_url":"https://api.github.com/repos/carloscurotto/storm-example/contributors","subscribers_url":"https://api.github.com/repos/carloscurotto/storm-example/subscribers","subscription_url":"https://api.github.com/repos/carloscurotto/storm-example/subscription","commits_url":"https://api.github.com/repos/carloscurotto/storm-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/carloscurotto/storm-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/carloscurotto/storm-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/carloscurotto/storm-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/carloscurotto/storm-example/contents/{+path}","compare_url":"https://api.github.com/repos/carloscurotto/storm-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carloscurotto/storm-example/merges","archive_url":"https://api.github.com/repos/carloscurotto/storm-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carloscurotto/storm-example/downloads","issues_url":"https://api.github.com/repos/carloscurotto/storm-example/issues{/number}","pulls_url":"https://api.github.com/repos/carloscurotto/storm-example/pulls{/number}","milestones_url":"https://api.github.com/repos/carloscurotto/storm-example/milestones{/number}","notifications_url":"https://api.github.com/repos/carloscurotto/storm-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carloscurotto/storm-example/labels{/name}","releases_url":"https://api.github.com/repos/carloscurotto/storm-example/releases{/id}","created_at":"2013-06-20T22:51:59Z","updated_at":"2015-03-31T20:09:24Z","pushed_at":"2015-04-01T14:54:32Z","git_url":"git://github.com/carloscurotto/storm-example.git","ssh_url":"git@github.com:carloscurotto/storm-example.git","clone_url":"https://github.com/carloscurotto/storm-example.git","svn_url":"https://github.com/carloscurotto/storm-example","homepage":null,"size":1065,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30"},"html":{"href":"https://github.com/carloscurotto/storm-example/pull/30"},"issue":{"href":"https://api.github.com/repos/carloscurotto/storm-example/issues/30"},"comments":{"href":"https://api.github.com/repos/carloscurotto/storm-example/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/carloscurotto/storm-example/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carloscurotto/storm-example/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/carloscurotto/storm-example/statuses/b27eb9c55237bde0c9e3534ac84997412e86f1e9"}}}}