{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14618","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14618/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14618/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14618/events","html_url":"https://github.com/kubernetes/kubernetes/pull/14618","id":108503906,"number":14618,"title":"Refactor exec to make attach useful without a client.Config","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500"}],"state":"open","locked":false,"assignee":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-09-27T00:03:11Z","updated_at":"2015-09-27T00:37:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14618","html_url":"https://github.com/kubernetes/kubernetes/pull/14618","diff_url":"https://github.com/kubernetes/kubernetes/pull/14618.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14618.patch"},"body":"The current executor structure is too dependent on client.Request\r\nand client.Config. In order to do an attach from the server, it needs\r\nto be possible to create an Executor from crypto/tls#TLSConfig and to\r\nbypassing having a client.Request.\r\n\r\nChanges:\r\n\r\n* remotecommand.streamExecutor - handles upgrading a request and getting a connection, then streaming multiple input streams over it\r\n* remotecommand.NewAttach / New - moved to exec / portforward / attach since they handle requests\r\n* Remove request.Upgrade() - it's too coupled to SPDY, and can live with the streamExecutor\r\n* Add request.VersionedParams(runtime.Object, runtime.ObjectConvertor) to handle object -> query transform\r\n\r\n@ncdc this blocks being able to push binary builds to the server"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/143507166","html_url":"https://github.com/kubernetes/kubernetes/pull/14618#issuecomment-143507166","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14618","id":143507166,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-27T00:37:50Z","updated_at":"2015-09-27T00:37:50Z","body":"Unit, integration and GCE e2e build/test **failed** for commit dcc90670f3ac73da63a3847842e270cafa6c2600.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/dcc90670f3ac73da63a3847842e270cafa6c2600/kubernetes-pull-build-test-e2e-gce/10266/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/dcc90670f3ac73da63a3847842e270cafa6c2600/kubernetes-pull-build-test-e2e-gce/10266/_artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//10266)\n"}}