{"action":"created","comment":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments/32893613","id":32893613,"diff_hunk":"@@ -149,34 +149,21 @@ module.exports = function (grunt) {\n             }\n         },\n \n-\n-\n         // Compiles Sass to CSS and generates necessary files if requested\n-        compass: {\n+        sass: {\n             options: {\n-                sassDir: '<%= yeoman.app %>/styles',\n-                cssDir: '.tmp/styles',\n-                generatedImagesDir: '.tmp/images/generated',\n-                imagesDir: '<%= yeoman.app %>/images',\n-                javascriptsDir: '<%= yeoman.app %>/scripts',\n-                fontsDir: '<%= yeoman.app %>/styles/fonts',\n-                importPath: '<%= yeoman.app %>/bower_components',\n-                httpImagesPath: '/images',\n-                httpGeneratedImagesPath: '/images/generated',\n-                httpFontsPath: '/styles/fonts',\n-                sourcemap: true,","path":"Gruntfile.js","position":32,"original_position":32,"commit_id":"bc8074423802df054895037f66e2adaab041b287","original_commit_id":"bc8074423802df054895037f66e2adaab041b287","user":{"login":"xinan","id":2834397,"avatar_url":"https://avatars.githubusercontent.com/u/2834397?v=3","gravatar_id":"","url":"https://api.github.com/users/xinan","html_url":"https://github.com/xinan","followers_url":"https://api.github.com/users/xinan/followers","following_url":"https://api.github.com/users/xinan/following{/other_user}","gists_url":"https://api.github.com/users/xinan/gists{/gist_id}","starred_url":"https://api.github.com/users/xinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinan/subscriptions","organizations_url":"https://api.github.com/users/xinan/orgs","repos_url":"https://api.github.com/users/xinan/repos","events_url":"https://api.github.com/users/xinan/events{/privacy}","received_events_url":"https://api.github.com/users/xinan/received_events","type":"User","site_admin":false},"body":"The little off in the style is because of a problem in the `compass` setting. In order to work with Bootstrap correct, we should set the SASS number precision to 10 by adding `raw: 'Sass::Script::Number.precision = 10\\n'` into the options. \r\n`grunt-sass` by default sets it to 10 for us. So actually the new one is more accurate. ","created_at":"2015-06-21T13:46:39Z","updated_at":"2015-06-21T13:46:39Z","html_url":"https://github.com/nusmodifications/nusmods/pull/217#discussion_r32893613","pull_request_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments/32893613"},"html":{"href":"https://github.com/nusmodifications/nusmods/pull/217#discussion_r32893613"},"pull_request":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217","id":36705484,"html_url":"https://github.com/nusmodifications/nusmods/pull/217","diff_url":"https://github.com/nusmodifications/nusmods/pull/217.diff","patch_url":"https://github.com/nusmodifications/nusmods/pull/217.patch","issue_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/217","number":217,"state":"open","locked":false,"title":"Remove ruby dependencies for SASS","user":{"login":"yangshun","id":1315101,"avatar_url":"https://avatars.githubusercontent.com/u/1315101?v=3","gravatar_id":"","url":"https://api.github.com/users/yangshun","html_url":"https://github.com/yangshun","followers_url":"https://api.github.com/users/yangshun/followers","following_url":"https://api.github.com/users/yangshun/following{/other_user}","gists_url":"https://api.github.com/users/yangshun/gists{/gist_id}","starred_url":"https://api.github.com/users/yangshun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangshun/subscriptions","organizations_url":"https://api.github.com/users/yangshun/orgs","repos_url":"https://api.github.com/users/yangshun/repos","events_url":"https://api.github.com/users/yangshun/events{/privacy}","received_events_url":"https://api.github.com/users/yangshun/received_events","type":"User","site_admin":false},"body":"Referring to #208 , I have migrated the project from `grunt-contrib-compass` to `grunt-sass`. A few things to take note:\r\n- Version 3.1.3 of jasny-bootstrap does not work with the new sass task because of a bug. I have modified `bower.json` to point to a stable commit on master. Looks like we'll have to use this for a while.\r\n- The `sass:server` task has many CSS files included there. Not sure if there is a better way to do it.\r\n- Removed `Gemfile` and  `Gemfile.lock` because bundle is no longer needed.\r\n\r\nPlease review this @xinan @xbili @ahbeng . Try to clone the project from scratch and run `grunt serve` and `grunt build`. ","created_at":"2015-06-02T08:39:01Z","updated_at":"2015-06-21T13:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08d6ff98438a539e2afef75a554081f352154029","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217/commits","review_comments_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217/comments","review_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/217/comments","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/bc8074423802df054895037f66e2adaab041b287","head":{"label":"nusmodifications:remove-ruby-dep","ref":"remove-ruby-dep","sha":"bc8074423802df054895037f66e2adaab041b287","user":{"login":"nusmodifications","id":7428865,"avatar_url":"https://avatars.githubusercontent.com/u/7428865?v=3","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"repo":{"id":5481861,"name":"nusmods","full_name":"nusmodifications/nusmods","owner":{"login":"nusmodifications","id":7428865,"avatar_url":"https://avatars.githubusercontent.com/u/7428865?v=3","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nusmodifications/nusmods","description":"NUS CORS Module Finder & Timetable Builder (Unofficial)","fork":false,"url":"https://api.github.com/repos/nusmodifications/nusmods","forks_url":"https://api.github.com/repos/nusmodifications/nusmods/forks","keys_url":"https://api.github.com/repos/nusmodifications/nusmods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nusmodifications/nusmods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nusmodifications/nusmods/teams","hooks_url":"https://api.github.com/repos/nusmodifications/nusmods/hooks","issue_events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/events{/number}","events_url":"https://api.github.com/repos/nusmodifications/nusmods/events","assignees_url":"https://api.github.com/repos/nusmodifications/nusmods/assignees{/user}","branches_url":"https://api.github.com/repos/nusmodifications/nusmods/branches{/branch}","tags_url":"https://api.github.com/repos/nusmodifications/nusmods/tags","blobs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nusmodifications/nusmods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/refs{/sha}","trees_url":"https://api.github.com/repos/nusmodifications/nusmods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/{sha}","languages_url":"https://api.github.com/repos/nusmodifications/nusmods/languages","stargazers_url":"https://api.github.com/repos/nusmodifications/nusmods/stargazers","contributors_url":"https://api.github.com/repos/nusmodifications/nusmods/contributors","subscribers_url":"https://api.github.com/repos/nusmodifications/nusmods/subscribers","subscription_url":"https://api.github.com/repos/nusmodifications/nusmods/subscription","commits_url":"https://api.github.com/repos/nusmodifications/nusmods/commits{/sha}","git_commits_url":"https://api.github.com/repos/nusmodifications/nusmods/git/commits{/sha}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/comments{/number}","issue_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments{/number}","contents_url":"https://api.github.com/repos/nusmodifications/nusmods/contents/{+path}","compare_url":"https://api.github.com/repos/nusmodifications/nusmods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nusmodifications/nusmods/merges","archive_url":"https://api.github.com/repos/nusmodifications/nusmods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nusmodifications/nusmods/downloads","issues_url":"https://api.github.com/repos/nusmodifications/nusmods/issues{/number}","pulls_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls{/number}","milestones_url":"https://api.github.com/repos/nusmodifications/nusmods/milestones{/number}","notifications_url":"https://api.github.com/repos/nusmodifications/nusmods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/labels{/name}","releases_url":"https://api.github.com/repos/nusmodifications/nusmods/releases{/id}","created_at":"2012-08-20T13:58:35Z","updated_at":"2015-06-11T19:47:38Z","pushed_at":"2015-06-20T11:19:59Z","git_url":"git://github.com/nusmodifications/nusmods.git","ssh_url":"git@github.com:nusmodifications/nusmods.git","clone_url":"https://github.com/nusmodifications/nusmods.git","svn_url":"https://github.com/nusmodifications/nusmods","homepage":"http://nusmods.com","size":6936,"stargazers_count":86,"watchers_count":86,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":64,"forks":54,"open_issues":64,"watchers":86,"default_branch":"master"}},"base":{"label":"nusmodifications:master","ref":"master","sha":"ad13e9c2c64935cf11aaeeeb16414a660ca56134","user":{"login":"nusmodifications","id":7428865,"avatar_url":"https://avatars.githubusercontent.com/u/7428865?v=3","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"repo":{"id":5481861,"name":"nusmods","full_name":"nusmodifications/nusmods","owner":{"login":"nusmodifications","id":7428865,"avatar_url":"https://avatars.githubusercontent.com/u/7428865?v=3","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nusmodifications/nusmods","description":"NUS CORS Module Finder & Timetable Builder (Unofficial)","fork":false,"url":"https://api.github.com/repos/nusmodifications/nusmods","forks_url":"https://api.github.com/repos/nusmodifications/nusmods/forks","keys_url":"https://api.github.com/repos/nusmodifications/nusmods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nusmodifications/nusmods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nusmodifications/nusmods/teams","hooks_url":"https://api.github.com/repos/nusmodifications/nusmods/hooks","issue_events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/events{/number}","events_url":"https://api.github.com/repos/nusmodifications/nusmods/events","assignees_url":"https://api.github.com/repos/nusmodifications/nusmods/assignees{/user}","branches_url":"https://api.github.com/repos/nusmodifications/nusmods/branches{/branch}","tags_url":"https://api.github.com/repos/nusmodifications/nusmods/tags","blobs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nusmodifications/nusmods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/refs{/sha}","trees_url":"https://api.github.com/repos/nusmodifications/nusmods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/{sha}","languages_url":"https://api.github.com/repos/nusmodifications/nusmods/languages","stargazers_url":"https://api.github.com/repos/nusmodifications/nusmods/stargazers","contributors_url":"https://api.github.com/repos/nusmodifications/nusmods/contributors","subscribers_url":"https://api.github.com/repos/nusmodifications/nusmods/subscribers","subscription_url":"https://api.github.com/repos/nusmodifications/nusmods/subscription","commits_url":"https://api.github.com/repos/nusmodifications/nusmods/commits{/sha}","git_commits_url":"https://api.github.com/repos/nusmodifications/nusmods/git/commits{/sha}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/comments{/number}","issue_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments{/number}","contents_url":"https://api.github.com/repos/nusmodifications/nusmods/contents/{+path}","compare_url":"https://api.github.com/repos/nusmodifications/nusmods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nusmodifications/nusmods/merges","archive_url":"https://api.github.com/repos/nusmodifications/nusmods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nusmodifications/nusmods/downloads","issues_url":"https://api.github.com/repos/nusmodifications/nusmods/issues{/number}","pulls_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls{/number}","milestones_url":"https://api.github.com/repos/nusmodifications/nusmods/milestones{/number}","notifications_url":"https://api.github.com/repos/nusmodifications/nusmods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/labels{/name}","releases_url":"https://api.github.com/repos/nusmodifications/nusmods/releases{/id}","created_at":"2012-08-20T13:58:35Z","updated_at":"2015-06-11T19:47:38Z","pushed_at":"2015-06-20T11:19:59Z","git_url":"git://github.com/nusmodifications/nusmods.git","ssh_url":"git@github.com:nusmodifications/nusmods.git","clone_url":"https://github.com/nusmodifications/nusmods.git","svn_url":"https://github.com/nusmodifications/nusmods","homepage":"http://nusmods.com","size":6936,"stargazers_count":86,"watchers_count":86,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":64,"forks":54,"open_issues":64,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217"},"html":{"href":"https://github.com/nusmodifications/nusmods/pull/217"},"issue":{"href":"https://api.github.com/repos/nusmodifications/nusmods/issues/217"},"comments":{"href":"https://api.github.com/repos/nusmodifications/nusmods/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/nusmodifications/nusmods/statuses/bc8074423802df054895037f66e2adaab041b287"}}}}