{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/23643616","id":23643616,"diff_hunk":"@@ -58,173 +56,167 @@ def setUp(self):\n \n     def _make_activation_key(self, options=None):\n         \"\"\"Make a new activation key and assert its success\"\"\"\n-\n         if options is None:\n             options = {}\n \n         # Use default organization if None are provided\n-        if (\n-                not options.get('organization', None)\n-                and not options.get('organization-label', None)\n-                and not options.get('organization-id', None)):\n+        if (not options.get('organization', None)\n+            and not options.get('organization-label', None)\n+            and not options.get('organization-id', None)):\n             options['organization-id'] = self.org['id']\n \n         # Create activation key\n         ackey = make_activation_key(options)\n \n         # Fetch it\n-        result = ActivationKey.info(\n-            {\n-                'id': ackey['id']\n-            }\n-        )\n+        result = ActivationKey.info({'id': ackey['id']})\n \n         self.assertEqual(\n             result.return_code,\n             0,\n-            \"Activation key was not found: %s\" % str(result.stderr))\n+            'Activation key was not found: {}'.format(result.stderr))\n         self.assertEqual(\n             len(result.stderr),\n             0,\n-            \"No error was expected %s\" % str(result.stderr))\n+            'No error was expected {}'.format(result.stderr))\n \n         # Return the activation key dictionary\n         return ackey\n \n     @data(\n-        {'name': gen_string('alpha', 15)},\n-        {'name': gen_string('alphanumeric', 15)},\n-        {'name': gen_string('numeric', 15)},\n-        {'name': gen_string('latin1', 15)},\n-        {'name': gen_string('utf8', 15)},\n-        {'name': gen_string('html', 15)},\n+        gen_string('alpha'),\n+        gen_string('alphanumeric'),\n+        gen_string('numeric'),\n+        gen_string('latin1'),\n+        gen_string('utf8'),\n+        gen_string('html'),\n     )\n-    def test_positive_create_activation_key_1(self, test_data):\n+    def test_positive_create_activation_key_1(self, name):\n         \"\"\"@Test: Create Activation key for all variations of\n             Activation key name\n \n         @Feature: Activation key\n \n         @Steps:\n+\n         1. Create Activation key for all valid Activation Key name variation\n \n         @Assert: Activation key is created with chosen name\n \n         \"\"\"\n-\n-        new_ackey = self._make_activation_key({u'name': test_data['name']})\n+        new_ackey_name = self._make_activation_key({u'name': name})['name']\n         # Name should match passed data\n         self.assertEqual(\n-            new_ackey['name'],\n-            test_data['name'],\n-            (\"Names don't match: '%s' != '%s'\" %\n-             (new_ackey['name'], test_data['name']))\n+            new_ackey_name,\n+            name,\n+            'Names don\\'t match: \"{}\" != \"{}\"'.format(new_ackey_name, name)","path":"tests/foreman/cli/test_activationkey.py","position":99,"original_position":98,"commit_id":"0ab34446dd14a6c057c3ad6663c6b5ed2082527b","original_commit_id":"f36422a550ccd7745fad2bcad7b12f1df9394fc7","user":{"login":"JacobCallahan","id":6618303,"avatar_url":"https://avatars.githubusercontent.com/u/6618303?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobCallahan","html_url":"https://github.com/JacobCallahan","followers_url":"https://api.github.com/users/JacobCallahan/followers","following_url":"https://api.github.com/users/JacobCallahan/following{/other_user}","gists_url":"https://api.github.com/users/JacobCallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobCallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobCallahan/subscriptions","organizations_url":"https://api.github.com/users/JacobCallahan/orgs","repos_url":"https://api.github.com/users/JacobCallahan/repos","events_url":"https://api.github.com/users/JacobCallahan/events{/privacy}","received_events_url":"https://api.github.com/users/JacobCallahan/received_events","type":"User","site_admin":false},"body":"i was iffy on removing these completely. i am willing to make the changes, though.","created_at":"2015-01-27T21:17:23Z","updated_at":"2015-01-27T21:17:23Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/1871#discussion_r23643616","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/23643616"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/1871#discussion_r23643616"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871","id":28144270,"html_url":"https://github.com/SatelliteQE/robottelo/pull/1871","diff_url":"https://github.com/SatelliteQE/robottelo/pull/1871.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/1871.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1871","number":1871,"state":"open","locked":false,"title":"Fixed activation key CLI test formatting","user":{"login":"JacobCallahan","id":6618303,"avatar_url":"https://avatars.githubusercontent.com/u/6618303?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobCallahan","html_url":"https://github.com/JacobCallahan","followers_url":"https://api.github.com/users/JacobCallahan/followers","following_url":"https://api.github.com/users/JacobCallahan/following{/other_user}","gists_url":"https://api.github.com/users/JacobCallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobCallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobCallahan/subscriptions","organizations_url":"https://api.github.com/users/JacobCallahan/orgs","repos_url":"https://api.github.com/users/JacobCallahan/repos","events_url":"https://api.github.com/users/JacobCallahan/events{/privacy}","received_events_url":"https://api.github.com/users/JacobCallahan/received_events","type":"User","site_admin":false},"body":"A few other fixes and changes thrown in, but functionality\r\nremains the same. Ran test suite with same results.","created_at":"2015-01-27T21:05:12Z","updated_at":"2015-01-27T21:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45af7e33e9848a0a0175be693a1ef040567802c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1871/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/0ab34446dd14a6c057c3ad6663c6b5ed2082527b","head":{"label":"JacobCallahan:master","ref":"master","sha":"0ab34446dd14a6c057c3ad6663c6b5ed2082527b","user":{"login":"JacobCallahan","id":6618303,"avatar_url":"https://avatars.githubusercontent.com/u/6618303?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobCallahan","html_url":"https://github.com/JacobCallahan","followers_url":"https://api.github.com/users/JacobCallahan/followers","following_url":"https://api.github.com/users/JacobCallahan/following{/other_user}","gists_url":"https://api.github.com/users/JacobCallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobCallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobCallahan/subscriptions","organizations_url":"https://api.github.com/users/JacobCallahan/orgs","repos_url":"https://api.github.com/users/JacobCallahan/repos","events_url":"https://api.github.com/users/JacobCallahan/events{/privacy}","received_events_url":"https://api.github.com/users/JacobCallahan/received_events","type":"User","site_admin":false},"repo":{"id":24058307,"name":"robottelo","full_name":"JacobCallahan/robottelo","owner":{"login":"JacobCallahan","id":6618303,"avatar_url":"https://avatars.githubusercontent.com/u/6618303?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobCallahan","html_url":"https://github.com/JacobCallahan","followers_url":"https://api.github.com/users/JacobCallahan/followers","following_url":"https://api.github.com/users/JacobCallahan/following{/other_user}","gists_url":"https://api.github.com/users/JacobCallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobCallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobCallahan/subscriptions","organizations_url":"https://api.github.com/users/JacobCallahan/orgs","repos_url":"https://api.github.com/users/JacobCallahan/repos","events_url":"https://api.github.com/users/JacobCallahan/events{/privacy}","received_events_url":"https://api.github.com/users/JacobCallahan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacobCallahan/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/JacobCallahan/robottelo","forks_url":"https://api.github.com/repos/JacobCallahan/robottelo/forks","keys_url":"https://api.github.com/repos/JacobCallahan/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacobCallahan/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacobCallahan/robottelo/teams","hooks_url":"https://api.github.com/repos/JacobCallahan/robottelo/hooks","issue_events_url":"https://api.github.com/repos/JacobCallahan/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/JacobCallahan/robottelo/events","assignees_url":"https://api.github.com/repos/JacobCallahan/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/JacobCallahan/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/JacobCallahan/robottelo/tags","blobs_url":"https://api.github.com/repos/JacobCallahan/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacobCallahan/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacobCallahan/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacobCallahan/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacobCallahan/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/JacobCallahan/robottelo/languages","stargazers_url":"https://api.github.com/repos/JacobCallahan/robottelo/stargazers","contributors_url":"https://api.github.com/repos/JacobCallahan/robottelo/contributors","subscribers_url":"https://api.github.com/repos/JacobCallahan/robottelo/subscribers","subscription_url":"https://api.github.com/repos/JacobCallahan/robottelo/subscription","commits_url":"https://api.github.com/repos/JacobCallahan/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacobCallahan/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacobCallahan/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacobCallahan/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/JacobCallahan/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/JacobCallahan/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacobCallahan/robottelo/merges","archive_url":"https://api.github.com/repos/JacobCallahan/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacobCallahan/robottelo/downloads","issues_url":"https://api.github.com/repos/JacobCallahan/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/JacobCallahan/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/JacobCallahan/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/JacobCallahan/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacobCallahan/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/JacobCallahan/robottelo/releases{/id}","created_at":"2014-09-15T13:53:21Z","updated_at":"2015-01-27T21:13:23Z","pushed_at":"2015-01-27T21:13:23Z","git_url":"git://github.com/JacobCallahan/robottelo.git","ssh_url":"git@github.com:JacobCallahan/robottelo.git","clone_url":"https://github.com/JacobCallahan/robottelo.git","svn_url":"https://github.com/JacobCallahan/robottelo","homepage":null,"size":6778,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"cc72dccc137de9b025398597276ce0ade5ec5597","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2015-01-27T21:05:19Z","pushed_at":"2015-01-27T21:05:19Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":14434,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":126,"forks":21,"open_issues":126,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/1871"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1871"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/1871/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/1871/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/0ab34446dd14a6c057c3ad6663c6b5ed2082527b"}}}}