{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/kuma/issues/3138","labels_url":"https://api.github.com/repos/mozilla/kuma/issues/3138/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/kuma/issues/3138/comments","events_url":"https://api.github.com/repos/mozilla/kuma/issues/3138/events","html_url":"https://github.com/mozilla/kuma/pull/3138","id":64568767,"number":3138,"title":"Fix bug 1139490: Switch to django-pipeline","user":{"login":"openjck","id":933396,"avatar_url":"https://avatars.githubusercontent.com/u/933396?v=3","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/kuma/labels/not%20ready","name":"not ready","color":"f7c6c7"}],"state":"open","locked":false,"assignee":{"login":"openjck","id":933396,"avatar_url":"https://avatars.githubusercontent.com/u/933396?v=3","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"milestone":null,"comments":14,"created_at":"2015-03-26T16:09:15Z","updated_at":"2015-04-09T13:37:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/kuma/pulls/3138","html_url":"https://github.com/mozilla/kuma/pull/3138","diff_url":"https://github.com/mozilla/kuma/pull/3138.diff","patch_url":"https://github.com/mozilla/kuma/pull/3138.patch"},"body":"The more testing we can do, the better. This touches so many areas of the codebase.\r\n\r\n**To do**\r\n* [ ] Fix the Travis errors, apparently related to Travis not running `collectstatic`\r\n* [ ] Fix local 404s ([more info](https://github.com/mozilla/kuma/pull/3138#issuecomment-88998467))\r\n* [ ] Include only `media/styles` and `media/js` when running `collectstatic` ([more info](https://github.com/mozilla/kuma/pull/3138#issuecomment-89006752))\r\n* [ ] Look into and consider refactoring `for style in styles` ([more info](https://github.com/mozilla/kuma/pull/3138#issuecomment-89008651))\r\n* [ ] Fix issue with display of homepage demos"},"comment":{"url":"https://api.github.com/repos/mozilla/kuma/issues/comments/91233840","html_url":"https://github.com/mozilla/kuma/pull/3138#issuecomment-91233840","issue_url":"https://api.github.com/repos/mozilla/kuma/issues/3138","id":91233840,"user":{"login":"openjck","id":933396,"avatar_url":"https://avatars.githubusercontent.com/u/933396?v=3","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T13:37:52Z","updated_at":"2015-04-09T13:37:52Z","body":"> In other words, MEDIA_ROOT should not be listed in STATICFILES_DIRS as it would defeat the purpose of deployment time file copying. You don't want to copy around all attachments to the STATIC_ROOT right?\r\n\r\nDefinitely. Luke [made the same point](https://github.com/mozilla/kuma/pull/3138#issuecomment-89006752), and I agree. In my working directory, `media/styles` and `media/js` are individually added to `STATICFILES_DIRS`. I haven't pushed that change up yet because it caused (revealed?) [the other problem](https://github.com/mozilla/kuma/pull/3138#issuecomment-90108056).\r\n\r\n> I saw that you added path('media/templates') to TEMPLATES_DIRS, why?\r\n\r\nOn master, we [hard-code the filenames of CKEditor dependencies](https://github.com/openjck/kuma/blob/master/kuma/wiki/templates/wiki/ckeditor_config.js#L89-93) in a configuration file. On this branch, we [use compressed_css](https://github.com/openjck/kuma/blob/0291008212523d02cf47a56b640ee41adb6a0ccc/kuma/wiki/templates/wiki/ckeditor_config.js#L89) along with a [custom template](https://github.com/openjck/kuma/blob/0291008212523d02cf47a56b640ee41adb6a0ccc/media/templates/pipeline/javascript-array.jinja) and a [special configuration in settings.py](https://github.com/openjck/kuma/blob/0291008212523d02cf47a56b640ee41adb6a0ccc/settings.py#L789) that tells Pipeline to use the custom template when the CKEditor dependencies are included. If we would prefer to do this differently, let me know."}}