{"action":"reopened","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1680","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1680/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1680/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1680/events","html_url":"https://github.com/cockroachdb/cockroach/issues/1680","id":94982362,"number":1680,"title":"review feed buffering","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-14T16:20:02Z","updated_at":"2015-07-14T18:56:05Z","closed_at":null,"body":"the current `util.Feed` contains a buffered channel and will panic if the consumer can't keep up. The discussion in https://github.com/cockroachdb/cockroach/pull/1658 suggests un-buffering this channel or switching to another interface.\r\n\r\nI'm personally in favor of not keeping the current unbuffered channel (at least with the panicking) behavior. We should be careful about blocking though: different publishers may want different behavior (back-pressure vs. dropping messages)."}}