{"action":"created","comment":{"url":"https://api.github.com/repos/pereckerdal/overman/pulls/comments/32884480","id":32884480,"diff_hunk":"@@ -51,9 +51,13 @@ function invokeGeneratorOrPromiseFunction(fun) {\n   }\n \n   if (result && result.next) {  // This looks like a generator\n-    return co(result);\n+    return when.promise(function(resolve) {\n+      // fixme: the promise returned by co seems to be\n+      //        incompatible with the ones that when uses.\n+      co(result).then(resolve);","path":"lib/bin/run_test.js","position":8,"original_position":8,"commit_id":"d228fd40b00db1ba943e7a16a051f2ec4c9bc1ee","original_commit_id":"d228fd40b00db1ba943e7a16a051f2ec4c9bc1ee","user":{"login":"pereckerdal","id":87926,"avatar_url":"https://avatars.githubusercontent.com/u/87926?v=3","gravatar_id":"","url":"https://api.github.com/users/pereckerdal","html_url":"https://github.com/pereckerdal","followers_url":"https://api.github.com/users/pereckerdal/followers","following_url":"https://api.github.com/users/pereckerdal/following{/other_user}","gists_url":"https://api.github.com/users/pereckerdal/gists{/gist_id}","starred_url":"https://api.github.com/users/pereckerdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pereckerdal/subscriptions","organizations_url":"https://api.github.com/users/pereckerdal/orgs","repos_url":"https://api.github.com/users/pereckerdal/repos","events_url":"https://api.github.com/users/pereckerdal/events{/privacy}","received_events_url":"https://api.github.com/users/pereckerdal/received_events","type":"User","site_admin":false},"body":"Also, if you decide to not use `return when(co(result));`, the right thing to do is to use `.done(resolve, reject)` instead of `.then(resolve)`, otherwise debugging tools will treat this as a promise that no one used the result of.","created_at":"2015-06-20T13:18:18Z","updated_at":"2015-06-20T13:18:18Z","html_url":"https://github.com/pereckerdal/overman/pull/105#discussion_r32884480","pull_request_url":"https://api.github.com/repos/pereckerdal/overman/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/pereckerdal/overman/pulls/comments/32884480"},"html":{"href":"https://github.com/pereckerdal/overman/pull/105#discussion_r32884480"},"pull_request":{"href":"https://api.github.com/repos/pereckerdal/overman/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/pereckerdal/overman/pulls/105","id":38108075,"html_url":"https://github.com/pereckerdal/overman/pull/105","diff_url":"https://github.com/pereckerdal/overman/pull/105.diff","patch_url":"https://github.com/pereckerdal/overman/pull/105.patch","issue_url":"https://api.github.com/repos/pereckerdal/overman/issues/105","number":105,"state":"open","locked":false,"title":"A few small fixes","user":{"login":"jkp","id":1057,"avatar_url":"https://avatars.githubusercontent.com/u/1057?v=3","gravatar_id":"","url":"https://api.github.com/users/jkp","html_url":"https://github.com/jkp","followers_url":"https://api.github.com/users/jkp/followers","following_url":"https://api.github.com/users/jkp/following{/other_user}","gists_url":"https://api.github.com/users/jkp/gists{/gist_id}","starred_url":"https://api.github.com/users/jkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkp/subscriptions","organizations_url":"https://api.github.com/users/jkp/orgs","repos_url":"https://api.github.com/users/jkp/repos","events_url":"https://api.github.com/users/jkp/events{/privacy}","received_events_url":"https://api.github.com/users/jkp/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-19T13:39:08Z","updated_at":"2015-06-20T13:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f81fdda55684a36d5cd765b079e51589950b0d74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pereckerdal/overman/pulls/105/commits","review_comments_url":"https://api.github.com/repos/pereckerdal/overman/pulls/105/comments","review_comment_url":"https://api.github.com/repos/pereckerdal/overman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pereckerdal/overman/issues/105/comments","statuses_url":"https://api.github.com/repos/pereckerdal/overman/statuses/d228fd40b00db1ba943e7a16a051f2ec4c9bc1ee","head":{"label":"jkp:master","ref":"master","sha":"d228fd40b00db1ba943e7a16a051f2ec4c9bc1ee","user":{"login":"jkp","id":1057,"avatar_url":"https://avatars.githubusercontent.com/u/1057?v=3","gravatar_id":"","url":"https://api.github.com/users/jkp","html_url":"https://github.com/jkp","followers_url":"https://api.github.com/users/jkp/followers","following_url":"https://api.github.com/users/jkp/following{/other_user}","gists_url":"https://api.github.com/users/jkp/gists{/gist_id}","starred_url":"https://api.github.com/users/jkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkp/subscriptions","organizations_url":"https://api.github.com/users/jkp/orgs","repos_url":"https://api.github.com/users/jkp/repos","events_url":"https://api.github.com/users/jkp/events{/privacy}","received_events_url":"https://api.github.com/users/jkp/received_events","type":"User","site_admin":false},"repo":{"id":27162380,"name":"overman","full_name":"jkp/overman","owner":{"login":"jkp","id":1057,"avatar_url":"https://avatars.githubusercontent.com/u/1057?v=3","gravatar_id":"","url":"https://api.github.com/users/jkp","html_url":"https://github.com/jkp","followers_url":"https://api.github.com/users/jkp/followers","following_url":"https://api.github.com/users/jkp/following{/other_user}","gists_url":"https://api.github.com/users/jkp/gists{/gist_id}","starred_url":"https://api.github.com/users/jkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkp/subscriptions","organizations_url":"https://api.github.com/users/jkp/orgs","repos_url":"https://api.github.com/users/jkp/repos","events_url":"https://api.github.com/users/jkp/events{/privacy}","received_events_url":"https://api.github.com/users/jkp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkp/overman","description":"Mocha inspired test framework for integration and system tests","fork":true,"url":"https://api.github.com/repos/jkp/overman","forks_url":"https://api.github.com/repos/jkp/overman/forks","keys_url":"https://api.github.com/repos/jkp/overman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkp/overman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkp/overman/teams","hooks_url":"https://api.github.com/repos/jkp/overman/hooks","issue_events_url":"https://api.github.com/repos/jkp/overman/issues/events{/number}","events_url":"https://api.github.com/repos/jkp/overman/events","assignees_url":"https://api.github.com/repos/jkp/overman/assignees{/user}","branches_url":"https://api.github.com/repos/jkp/overman/branches{/branch}","tags_url":"https://api.github.com/repos/jkp/overman/tags","blobs_url":"https://api.github.com/repos/jkp/overman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkp/overman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkp/overman/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkp/overman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkp/overman/statuses/{sha}","languages_url":"https://api.github.com/repos/jkp/overman/languages","stargazers_url":"https://api.github.com/repos/jkp/overman/stargazers","contributors_url":"https://api.github.com/repos/jkp/overman/contributors","subscribers_url":"https://api.github.com/repos/jkp/overman/subscribers","subscription_url":"https://api.github.com/repos/jkp/overman/subscription","commits_url":"https://api.github.com/repos/jkp/overman/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkp/overman/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkp/overman/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkp/overman/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkp/overman/contents/{+path}","compare_url":"https://api.github.com/repos/jkp/overman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkp/overman/merges","archive_url":"https://api.github.com/repos/jkp/overman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkp/overman/downloads","issues_url":"https://api.github.com/repos/jkp/overman/issues{/number}","pulls_url":"https://api.github.com/repos/jkp/overman/pulls{/number}","milestones_url":"https://api.github.com/repos/jkp/overman/milestones{/number}","notifications_url":"https://api.github.com/repos/jkp/overman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkp/overman/labels{/name}","releases_url":"https://api.github.com/repos/jkp/overman/releases{/id}","created_at":"2014-11-26T06:12:55Z","updated_at":"2014-11-26T06:12:56Z","pushed_at":"2015-06-19T13:36:57Z","git_url":"git://github.com/jkp/overman.git","ssh_url":"git@github.com:jkp/overman.git","clone_url":"https://github.com/jkp/overman.git","svn_url":"https://github.com/jkp/overman","homepage":null,"size":470,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pereckerdal:master","ref":"master","sha":"de02fd4d599812ced012b70a8feda9ecb214dc17","user":{"login":"pereckerdal","id":87926,"avatar_url":"https://avatars.githubusercontent.com/u/87926?v=3","gravatar_id":"","url":"https://api.github.com/users/pereckerdal","html_url":"https://github.com/pereckerdal","followers_url":"https://api.github.com/users/pereckerdal/followers","following_url":"https://api.github.com/users/pereckerdal/following{/other_user}","gists_url":"https://api.github.com/users/pereckerdal/gists{/gist_id}","starred_url":"https://api.github.com/users/pereckerdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pereckerdal/subscriptions","organizations_url":"https://api.github.com/users/pereckerdal/orgs","repos_url":"https://api.github.com/users/pereckerdal/repos","events_url":"https://api.github.com/users/pereckerdal/events{/privacy}","received_events_url":"https://api.github.com/users/pereckerdal/received_events","type":"User","site_admin":false},"repo":{"id":27120307,"name":"overman","full_name":"pereckerdal/overman","owner":{"login":"pereckerdal","id":87926,"avatar_url":"https://avatars.githubusercontent.com/u/87926?v=3","gravatar_id":"","url":"https://api.github.com/users/pereckerdal","html_url":"https://github.com/pereckerdal","followers_url":"https://api.github.com/users/pereckerdal/followers","following_url":"https://api.github.com/users/pereckerdal/following{/other_user}","gists_url":"https://api.github.com/users/pereckerdal/gists{/gist_id}","starred_url":"https://api.github.com/users/pereckerdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pereckerdal/subscriptions","organizations_url":"https://api.github.com/users/pereckerdal/orgs","repos_url":"https://api.github.com/users/pereckerdal/repos","events_url":"https://api.github.com/users/pereckerdal/events{/privacy}","received_events_url":"https://api.github.com/users/pereckerdal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pereckerdal/overman","description":"Mocha inspired test framework for integration and system tests","fork":false,"url":"https://api.github.com/repos/pereckerdal/overman","forks_url":"https://api.github.com/repos/pereckerdal/overman/forks","keys_url":"https://api.github.com/repos/pereckerdal/overman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pereckerdal/overman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pereckerdal/overman/teams","hooks_url":"https://api.github.com/repos/pereckerdal/overman/hooks","issue_events_url":"https://api.github.com/repos/pereckerdal/overman/issues/events{/number}","events_url":"https://api.github.com/repos/pereckerdal/overman/events","assignees_url":"https://api.github.com/repos/pereckerdal/overman/assignees{/user}","branches_url":"https://api.github.com/repos/pereckerdal/overman/branches{/branch}","tags_url":"https://api.github.com/repos/pereckerdal/overman/tags","blobs_url":"https://api.github.com/repos/pereckerdal/overman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pereckerdal/overman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pereckerdal/overman/git/refs{/sha}","trees_url":"https://api.github.com/repos/pereckerdal/overman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pereckerdal/overman/statuses/{sha}","languages_url":"https://api.github.com/repos/pereckerdal/overman/languages","stargazers_url":"https://api.github.com/repos/pereckerdal/overman/stargazers","contributors_url":"https://api.github.com/repos/pereckerdal/overman/contributors","subscribers_url":"https://api.github.com/repos/pereckerdal/overman/subscribers","subscription_url":"https://api.github.com/repos/pereckerdal/overman/subscription","commits_url":"https://api.github.com/repos/pereckerdal/overman/commits{/sha}","git_commits_url":"https://api.github.com/repos/pereckerdal/overman/git/commits{/sha}","comments_url":"https://api.github.com/repos/pereckerdal/overman/comments{/number}","issue_comment_url":"https://api.github.com/repos/pereckerdal/overman/issues/comments{/number}","contents_url":"https://api.github.com/repos/pereckerdal/overman/contents/{+path}","compare_url":"https://api.github.com/repos/pereckerdal/overman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pereckerdal/overman/merges","archive_url":"https://api.github.com/repos/pereckerdal/overman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pereckerdal/overman/downloads","issues_url":"https://api.github.com/repos/pereckerdal/overman/issues{/number}","pulls_url":"https://api.github.com/repos/pereckerdal/overman/pulls{/number}","milestones_url":"https://api.github.com/repos/pereckerdal/overman/milestones{/number}","notifications_url":"https://api.github.com/repos/pereckerdal/overman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pereckerdal/overman/labels{/name}","releases_url":"https://api.github.com/repos/pereckerdal/overman/releases{/id}","created_at":"2014-11-25T10:20:00Z","updated_at":"2015-03-25T18:00:44Z","pushed_at":"2015-06-19T13:39:08Z","git_url":"git://github.com/pereckerdal/overman.git","ssh_url":"git@github.com:pereckerdal/overman.git","clone_url":"https://github.com/pereckerdal/overman.git","svn_url":"https://github.com/pereckerdal/overman","homepage":null,"size":998,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pereckerdal/overman/pulls/105"},"html":{"href":"https://github.com/pereckerdal/overman/pull/105"},"issue":{"href":"https://api.github.com/repos/pereckerdal/overman/issues/105"},"comments":{"href":"https://api.github.com/repos/pereckerdal/overman/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/pereckerdal/overman/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/pereckerdal/overman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pereckerdal/overman/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/pereckerdal/overman/statuses/d228fd40b00db1ba943e7a16a051f2ec4c9bc1ee"}}}}