{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/webmaker-app/issues/1425","labels_url":"https://api.github.com/repos/mozilla/webmaker-app/issues/1425/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/webmaker-app/issues/1425/comments","events_url":"https://api.github.com/repos/mozilla/webmaker-app/issues/1425/events","html_url":"https://github.com/mozilla/webmaker-app/issues/1425","id":59884940,"number":1425,"title":"lib/storage defines an object type App inline, instead of as a regular object type","user":{"login":"Pomax","id":177243,"avatar_url":"https://avatars.githubusercontent.com/u/177243?v=3","gravatar_id":"","url":"https://api.github.com/users/Pomax","html_url":"https://github.com/Pomax","followers_url":"https://api.github.com/users/Pomax/followers","following_url":"https://api.github.com/users/Pomax/following{/other_user}","gists_url":"https://api.github.com/users/Pomax/gists{/gist_id}","starred_url":"https://api.github.com/users/Pomax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pomax/subscriptions","organizations_url":"https://api.github.com/users/Pomax/orgs","repos_url":"https://api.github.com/users/Pomax/repos","events_url":"https://api.github.com/users/Pomax/events{/privacy}","received_events_url":"https://api.github.com/users/Pomax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/webmaker-app/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-05T00:18:56Z","updated_at":"2015-03-05T00:53:26Z","closed_at":null,"body":"https://github.com/mozilla/webmaker-app/blob/master/lib/storage.js#L60 has a full object type with prototype inline-defined, which means it gets redefined, locally scoped, on each call. We should *really* rewrite that to be a lib-scoped single object `App`, with proper construction.\r\n\r\nAs is, JSCS will trip over the nested this/that/self bindings, and the only real way to fix that is by lifting this code to the correct depth (most of that can be fixed because almost all the `self` references inside App aren't actually necessary)"},"comment":{"url":"https://api.github.com/repos/mozilla/webmaker-app/issues/comments/77284465","html_url":"https://github.com/mozilla/webmaker-app/issues/1425#issuecomment-77284465","issue_url":"https://api.github.com/repos/mozilla/webmaker-app/issues/1425","id":77284465,"user":{"login":"gvn","id":206379,"avatar_url":"https://avatars.githubusercontent.com/u/206379?v=3","gravatar_id":"","url":"https://api.github.com/users/gvn","html_url":"https://github.com/gvn","followers_url":"https://api.github.com/users/gvn/followers","following_url":"https://api.github.com/users/gvn/following{/other_user}","gists_url":"https://api.github.com/users/gvn/gists{/gist_id}","starred_url":"https://api.github.com/users/gvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvn/subscriptions","organizations_url":"https://api.github.com/users/gvn/orgs","repos_url":"https://api.github.com/users/gvn/repos","events_url":"https://api.github.com/users/gvn/events{/privacy}","received_events_url":"https://api.github.com/users/gvn/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T00:53:26Z","updated_at":"2015-03-05T00:53:26Z","body":"Maybe for now we should exclude this file from the linted group and do a follow on ticket to refactor it?"}}