{"action":"created","issue":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/480","labels_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/480/comments","events_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/480/events","html_url":"https://github.com/AutoFixture/AutoFixture/pull/480","id":120035973,"number":480,"title":"Deprecated NoSpecimen.Request,","user":{"login":"ploeh","id":242165,"avatar_url":"https://avatars.githubusercontent.com/u/242165?v=3","gravatar_id":"","url":"https://api.github.com/users/ploeh","html_url":"https://github.com/ploeh","followers_url":"https://api.github.com/users/ploeh/followers","following_url":"https://api.github.com/users/ploeh/following{/other_user}","gists_url":"https://api.github.com/users/ploeh/gists{/gist_id}","starred_url":"https://api.github.com/users/ploeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploeh/subscriptions","organizations_url":"https://api.github.com/users/ploeh/orgs","repos_url":"https://api.github.com/users/ploeh/repos","events_url":"https://api.github.com/users/ploeh/events{/privacy}","received_events_url":"https://api.github.com/users/ploeh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-02T21:07:49Z","updated_at":"2015-12-03T05:38:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/480","html_url":"https://github.com/AutoFixture/AutoFixture/pull/480","diff_url":"https://github.com/AutoFixture/AutoFixture/pull/480.diff","patch_url":"https://github.com/AutoFixture/AutoFixture/pull/480.patch"},"body":"and the corresponding constructor. The reason for this is that Request is\r\nnever used, but the design makes it look like it is. For consistency's\r\nsake, we ask contributors to adhere to the established standard of\r\nreturning `new NoSpecimen(request)` even when everything works fine\r\nwithout it. The design would be slightly simpler if Request was simply\r\nomitted.\r\n\r\nThis also paves the way towards making NoSpecimen a Singleton, although\r\nmeasurements carried out by Adam Chester indicate that it would only give\r\na marginal performance boost\r\n(https://github.com/AutoFixture/AutoFixture/issues/221#issuecomment-31623706).\r\n\r\nOnly two [Obsolete] attributes are added in this commit, both in\r\nSrc/AutoFixture/Kernel/NoSpecimen.cs. The rest of the files only contain\r\nmyriads of warning suppressions, because of the deprecation.\r\n\r\nThis commit changes no behaviour, because that might be a breaking change\r\n(although I doubt it). Instead, all warnings related to deprecation of\r\nNoSpecimen.Request are suppressed, in order to keep the behaviour as is."},"comment":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/comments/161522368","html_url":"https://github.com/AutoFixture/AutoFixture/pull/480#issuecomment-161522368","issue_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/480","id":161522368,"user":{"login":"moodmosaic","id":287532,"avatar_url":"https://avatars.githubusercontent.com/u/287532?v=3","gravatar_id":"","url":"https://api.github.com/users/moodmosaic","html_url":"https://github.com/moodmosaic","followers_url":"https://api.github.com/users/moodmosaic/followers","following_url":"https://api.github.com/users/moodmosaic/following{/other_user}","gists_url":"https://api.github.com/users/moodmosaic/gists{/gist_id}","starred_url":"https://api.github.com/users/moodmosaic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moodmosaic/subscriptions","organizations_url":"https://api.github.com/users/moodmosaic/orgs","repos_url":"https://api.github.com/users/moodmosaic/repos","events_url":"https://api.github.com/users/moodmosaic/events{/privacy}","received_events_url":"https://api.github.com/users/moodmosaic/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T05:38:46Z","updated_at":"2015-12-03T05:38:46Z","body":"Wow, what a massive piece of work :+1:\r\n\r\nBuild succeeds without warnings on my machine. "}}