{"action":"created","comment":{"url":"https://api.github.com/repos/mila-udem/fuel/pulls/comments/31030039","id":31030039,"diff_hunk":"@@ -328,35 +362,55 @@ def _file_handle(self):\n \n     def get_data(self, state=None, request=None):\n         if self.load_in_memory:\n-            return self._in_memory_get_data(state=state, request=request)\n+            rval, rval_shapes = self._in_memory_get_data(state, request)\n         else:\n-            return self._out_of_memory_get_data(state=state, request=request)\n+            rval, rval_shapes = self._out_of_memory_get_data(state, request)\n+        for i, shapes in enumerate(rval_shapes):","path":"fuel/datasets/hdf5.py","position":105,"original_position":105,"commit_id":"89b1ca2a598f4a9dc95a1f6f99261883d55b85a1","original_commit_id":"89b1ca2a598f4a9dc95a1f6f99261883d55b85a1","user":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"body":"Agreed. I'll try to come up with better names.","created_at":"2015-05-26T13:02:50Z","updated_at":"2015-05-26T13:02:50Z","html_url":"https://github.com/mila-udem/fuel/pull/141#discussion_r31030039","pull_request_url":"https://api.github.com/repos/mila-udem/fuel/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/mila-udem/fuel/pulls/comments/31030039"},"html":{"href":"https://github.com/mila-udem/fuel/pull/141#discussion_r31030039"},"pull_request":{"href":"https://api.github.com/repos/mila-udem/fuel/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/mila-udem/fuel/pulls/141","id":36152168,"html_url":"https://github.com/mila-udem/fuel/pull/141","diff_url":"https://github.com/mila-udem/fuel/pull/141.diff","patch_url":"https://github.com/mila-udem/fuel/pull/141.patch","issue_url":"https://api.github.com/repos/mila-udem/fuel/issues/141","number":141,"state":"open","locked":false,"title":"Add variable-length data support in H5PYDataset","user":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"body":"Fixes #136.\r\n\r\nLeft to implement before it's ready to merge: a tutorial explaining all this.","created_at":"2015-05-25T18:10:38Z","updated_at":"2015-05-26T13:02:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f6e0d76872b3f57652b90162a7eec7b6f7fe337","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mila-udem/fuel/pulls/141/commits","review_comments_url":"https://api.github.com/repos/mila-udem/fuel/pulls/141/comments","review_comment_url":"https://api.github.com/repos/mila-udem/fuel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mila-udem/fuel/issues/141/comments","statuses_url":"https://api.github.com/repos/mila-udem/fuel/statuses/89b1ca2a598f4a9dc95a1f6f99261883d55b85a1","head":{"label":"vdumoulin:vlen_h5pydataset","ref":"vlen_h5pydataset","sha":"89b1ca2a598f4a9dc95a1f6f99261883d55b85a1","user":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"repo":{"id":30834931,"name":"fuel","full_name":"vdumoulin/fuel","owner":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdumoulin/fuel","description":"A data pipeline framework for machine learning","fork":true,"url":"https://api.github.com/repos/vdumoulin/fuel","forks_url":"https://api.github.com/repos/vdumoulin/fuel/forks","keys_url":"https://api.github.com/repos/vdumoulin/fuel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdumoulin/fuel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdumoulin/fuel/teams","hooks_url":"https://api.github.com/repos/vdumoulin/fuel/hooks","issue_events_url":"https://api.github.com/repos/vdumoulin/fuel/issues/events{/number}","events_url":"https://api.github.com/repos/vdumoulin/fuel/events","assignees_url":"https://api.github.com/repos/vdumoulin/fuel/assignees{/user}","branches_url":"https://api.github.com/repos/vdumoulin/fuel/branches{/branch}","tags_url":"https://api.github.com/repos/vdumoulin/fuel/tags","blobs_url":"https://api.github.com/repos/vdumoulin/fuel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdumoulin/fuel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdumoulin/fuel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdumoulin/fuel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdumoulin/fuel/statuses/{sha}","languages_url":"https://api.github.com/repos/vdumoulin/fuel/languages","stargazers_url":"https://api.github.com/repos/vdumoulin/fuel/stargazers","contributors_url":"https://api.github.com/repos/vdumoulin/fuel/contributors","subscribers_url":"https://api.github.com/repos/vdumoulin/fuel/subscribers","subscription_url":"https://api.github.com/repos/vdumoulin/fuel/subscription","commits_url":"https://api.github.com/repos/vdumoulin/fuel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdumoulin/fuel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdumoulin/fuel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdumoulin/fuel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdumoulin/fuel/contents/{+path}","compare_url":"https://api.github.com/repos/vdumoulin/fuel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdumoulin/fuel/merges","archive_url":"https://api.github.com/repos/vdumoulin/fuel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdumoulin/fuel/downloads","issues_url":"https://api.github.com/repos/vdumoulin/fuel/issues{/number}","pulls_url":"https://api.github.com/repos/vdumoulin/fuel/pulls{/number}","milestones_url":"https://api.github.com/repos/vdumoulin/fuel/milestones{/number}","notifications_url":"https://api.github.com/repos/vdumoulin/fuel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdumoulin/fuel/labels{/name}","releases_url":"https://api.github.com/repos/vdumoulin/fuel/releases{/id}","created_at":"2015-02-15T17:25:11Z","updated_at":"2015-05-08T14:41:11Z","pushed_at":"2015-05-25T23:33:08Z","git_url":"git://github.com/vdumoulin/fuel.git","ssh_url":"git@github.com:vdumoulin/fuel.git","clone_url":"https://github.com/vdumoulin/fuel.git","svn_url":"https://github.com/vdumoulin/fuel","homepage":null,"size":1078,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mila-udem:master","ref":"master","sha":"c69e62e37931903d88bffe773f872b2288693b40","user":{"login":"mila-udem","id":11724251,"avatar_url":"https://avatars.githubusercontent.com/u/11724251?v=3","gravatar_id":"","url":"https://api.github.com/users/mila-udem","html_url":"https://github.com/mila-udem","followers_url":"https://api.github.com/users/mila-udem/followers","following_url":"https://api.github.com/users/mila-udem/following{/other_user}","gists_url":"https://api.github.com/users/mila-udem/gists{/gist_id}","starred_url":"https://api.github.com/users/mila-udem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mila-udem/subscriptions","organizations_url":"https://api.github.com/users/mila-udem/orgs","repos_url":"https://api.github.com/users/mila-udem/repos","events_url":"https://api.github.com/users/mila-udem/events{/privacy}","received_events_url":"https://api.github.com/users/mila-udem/received_events","type":"Organization","site_admin":false},"repo":{"id":30722866,"name":"fuel","full_name":"mila-udem/fuel","owner":{"login":"mila-udem","id":11724251,"avatar_url":"https://avatars.githubusercontent.com/u/11724251?v=3","gravatar_id":"","url":"https://api.github.com/users/mila-udem","html_url":"https://github.com/mila-udem","followers_url":"https://api.github.com/users/mila-udem/followers","following_url":"https://api.github.com/users/mila-udem/following{/other_user}","gists_url":"https://api.github.com/users/mila-udem/gists{/gist_id}","starred_url":"https://api.github.com/users/mila-udem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mila-udem/subscriptions","organizations_url":"https://api.github.com/users/mila-udem/orgs","repos_url":"https://api.github.com/users/mila-udem/repos","events_url":"https://api.github.com/users/mila-udem/events{/privacy}","received_events_url":"https://api.github.com/users/mila-udem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mila-udem/fuel","description":"A data pipeline framework for machine learning","fork":false,"url":"https://api.github.com/repos/mila-udem/fuel","forks_url":"https://api.github.com/repos/mila-udem/fuel/forks","keys_url":"https://api.github.com/repos/mila-udem/fuel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mila-udem/fuel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mila-udem/fuel/teams","hooks_url":"https://api.github.com/repos/mila-udem/fuel/hooks","issue_events_url":"https://api.github.com/repos/mila-udem/fuel/issues/events{/number}","events_url":"https://api.github.com/repos/mila-udem/fuel/events","assignees_url":"https://api.github.com/repos/mila-udem/fuel/assignees{/user}","branches_url":"https://api.github.com/repos/mila-udem/fuel/branches{/branch}","tags_url":"https://api.github.com/repos/mila-udem/fuel/tags","blobs_url":"https://api.github.com/repos/mila-udem/fuel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mila-udem/fuel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mila-udem/fuel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mila-udem/fuel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mila-udem/fuel/statuses/{sha}","languages_url":"https://api.github.com/repos/mila-udem/fuel/languages","stargazers_url":"https://api.github.com/repos/mila-udem/fuel/stargazers","contributors_url":"https://api.github.com/repos/mila-udem/fuel/contributors","subscribers_url":"https://api.github.com/repos/mila-udem/fuel/subscribers","subscription_url":"https://api.github.com/repos/mila-udem/fuel/subscription","commits_url":"https://api.github.com/repos/mila-udem/fuel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mila-udem/fuel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mila-udem/fuel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mila-udem/fuel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mila-udem/fuel/contents/{+path}","compare_url":"https://api.github.com/repos/mila-udem/fuel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mila-udem/fuel/merges","archive_url":"https://api.github.com/repos/mila-udem/fuel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mila-udem/fuel/downloads","issues_url":"https://api.github.com/repos/mila-udem/fuel/issues{/number}","pulls_url":"https://api.github.com/repos/mila-udem/fuel/pulls{/number}","milestones_url":"https://api.github.com/repos/mila-udem/fuel/milestones{/number}","notifications_url":"https://api.github.com/repos/mila-udem/fuel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mila-udem/fuel/labels{/name}","releases_url":"https://api.github.com/repos/mila-udem/fuel/releases{/id}","created_at":"2015-02-12T20:42:44Z","updated_at":"2015-05-21T23:39:43Z","pushed_at":"2015-05-26T11:44:59Z","git_url":"git://github.com/mila-udem/fuel.git","ssh_url":"git@github.com:mila-udem/fuel.git","clone_url":"https://github.com/mila-udem/fuel.git","svn_url":"https://github.com/mila-udem/fuel","homepage":null,"size":3359,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":38,"forks":43,"open_issues":38,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mila-udem/fuel/pulls/141"},"html":{"href":"https://github.com/mila-udem/fuel/pull/141"},"issue":{"href":"https://api.github.com/repos/mila-udem/fuel/issues/141"},"comments":{"href":"https://api.github.com/repos/mila-udem/fuel/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/mila-udem/fuel/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/mila-udem/fuel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mila-udem/fuel/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/mila-udem/fuel/statuses/89b1ca2a598f4a9dc95a1f6f99261883d55b85a1"}}}}