{"action":"created","comment":{"url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/comments/46851127","id":46851127,"diff_hunk":"@@ -72,6 +72,37 @@ describe('gulp-w3cjs', function () {\n \t\t\tstream.write(fakeFile);\n \t\t\tstream.end();\n \t\t});\n+\n+\t\tit('should fail even skipping errors', function (done) {\n+\t\t\tvar fakeFile = new gutil.File({\n+\t\t\t\tpath: './test/html/invalid.html',\n+\t\t\t\tcwd: './test/',\n+\t\t\t\tbase: './test/html/',\n+\t\t\t\tcontents: fs.readFileSync('./test/html/invalid.html')\n+\t\t\t});\n+\n+\t\t\tvar stream = w3cjs({\n+\t\t\t\tskipErrors: [\n+\t\t\t\t\t'End tag for  “body” seen, but there were unclosed elements.',\n+\t\t\t\t\t'Unclosed element “h1”.'\n+\t\t\t\t]\n+\t\t\t});\n+\n+\t\t\tstream.on('data', function (newFile) {\n+\t\t\t\tvar reporter = w3cjs.reporter();\n+\n+\t\t\t\t(function () {\n+\t\t\t\t\treporter.write(newFile);\n+\t\t\t\t}).should.throw(/HTML validation error\\(s\\) found/);","path":"test/main.js","position":43,"original_position":43,"commit_id":"c744136ad11695a2da2941d9cb9f109ea8e1a3c6","original_commit_id":"c744136ad11695a2da2941d9cb9f109ea8e1a3c6","user":{"login":"callumacrae","id":472830,"avatar_url":"https://avatars.githubusercontent.com/u/472830?v=3","gravatar_id":"","url":"https://api.github.com/users/callumacrae","html_url":"https://github.com/callumacrae","followers_url":"https://api.github.com/users/callumacrae/followers","following_url":"https://api.github.com/users/callumacrae/following{/other_user}","gists_url":"https://api.github.com/users/callumacrae/gists{/gist_id}","starred_url":"https://api.github.com/users/callumacrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callumacrae/subscriptions","organizations_url":"https://api.github.com/users/callumacrae/orgs","repos_url":"https://api.github.com/users/callumacrae/repos","events_url":"https://api.github.com/users/callumacrae/events{/privacy}","received_events_url":"https://api.github.com/users/callumacrae/received_events","type":"User","site_admin":false},"body":"If the errors are being skipped, why would you want it to fail?","created_at":"2015-12-07T17:41:02Z","updated_at":"2015-12-07T17:41:02Z","html_url":"https://github.com/callumacrae/gulp-w3cjs/pull/18#discussion_r46851127","pull_request_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/comments/46851127"},"html":{"href":"https://github.com/callumacrae/gulp-w3cjs/pull/18#discussion_r46851127"},"pull_request":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18","id":52778908,"html_url":"https://github.com/callumacrae/gulp-w3cjs/pull/18","diff_url":"https://github.com/callumacrae/gulp-w3cjs/pull/18.diff","patch_url":"https://github.com/callumacrae/gulp-w3cjs/pull/18.patch","issue_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues/18","number":18,"state":"open","locked":false,"title":"Add 'skipErrors' param to to skip certain w3c errors messages from va…","user":{"login":"pelllich","id":2727342,"avatar_url":"https://avatars.githubusercontent.com/u/2727342?v=3","gravatar_id":"","url":"https://api.github.com/users/pelllich","html_url":"https://github.com/pelllich","followers_url":"https://api.github.com/users/pelllich/followers","following_url":"https://api.github.com/users/pelllich/following{/other_user}","gists_url":"https://api.github.com/users/pelllich/gists{/gist_id}","starred_url":"https://api.github.com/users/pelllich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelllich/subscriptions","organizations_url":"https://api.github.com/users/pelllich/orgs","repos_url":"https://api.github.com/users/pelllich/repos","events_url":"https://api.github.com/users/pelllich/events{/privacy}","received_events_url":"https://api.github.com/users/pelllich/received_events","type":"User","site_admin":false},"body":"Useful when validating old DOCTYPE.\r\nThis param must be an array. Can contain exact error message or a part of error message, e.g.:\r\n```javascript\r\n[\r\n  'element is obsolete',\r\n  'The “cellpadding” attribute on the “table” element is obsolete. Use CSS instead.',\r\n]\r\n```","created_at":"2015-12-06T12:19:47Z","updated_at":"2015-12-07T17:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"238d7dd6868dbcb04a33bd8d2d8e9bdf3b497810","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18/commits","review_comments_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18/comments","review_comment_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues/18/comments","statuses_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/statuses/c744136ad11695a2da2941d9cb9f109ea8e1a3c6","head":{"label":"pelllich:master","ref":"master","sha":"c744136ad11695a2da2941d9cb9f109ea8e1a3c6","user":{"login":"pelllich","id":2727342,"avatar_url":"https://avatars.githubusercontent.com/u/2727342?v=3","gravatar_id":"","url":"https://api.github.com/users/pelllich","html_url":"https://github.com/pelllich","followers_url":"https://api.github.com/users/pelllich/followers","following_url":"https://api.github.com/users/pelllich/following{/other_user}","gists_url":"https://api.github.com/users/pelllich/gists{/gist_id}","starred_url":"https://api.github.com/users/pelllich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelllich/subscriptions","organizations_url":"https://api.github.com/users/pelllich/orgs","repos_url":"https://api.github.com/users/pelllich/repos","events_url":"https://api.github.com/users/pelllich/events{/privacy}","received_events_url":"https://api.github.com/users/pelllich/received_events","type":"User","site_admin":false},"repo":{"id":47494985,"name":"gulp-w3cjs","full_name":"pelllich/gulp-w3cjs","owner":{"login":"pelllich","id":2727342,"avatar_url":"https://avatars.githubusercontent.com/u/2727342?v=3","gravatar_id":"","url":"https://api.github.com/users/pelllich","html_url":"https://github.com/pelllich","followers_url":"https://api.github.com/users/pelllich/followers","following_url":"https://api.github.com/users/pelllich/following{/other_user}","gists_url":"https://api.github.com/users/pelllich/gists{/gist_id}","starred_url":"https://api.github.com/users/pelllich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelllich/subscriptions","organizations_url":"https://api.github.com/users/pelllich/orgs","repos_url":"https://api.github.com/users/pelllich/repos","events_url":"https://api.github.com/users/pelllich/events{/privacy}","received_events_url":"https://api.github.com/users/pelllich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pelllich/gulp-w3cjs","description":":vertical_traffic_light: w3cjs wrapper for gulp to validate your HTML","fork":true,"url":"https://api.github.com/repos/pelllich/gulp-w3cjs","forks_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/forks","keys_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/teams","hooks_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/hooks","issue_events_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/issues/events{/number}","events_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/events","assignees_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/assignees{/user}","branches_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/branches{/branch}","tags_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/tags","blobs_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/statuses/{sha}","languages_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/languages","stargazers_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/stargazers","contributors_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/contributors","subscribers_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/subscribers","subscription_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/subscription","commits_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/contents/{+path}","compare_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/merges","archive_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/downloads","issues_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/issues{/number}","pulls_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/pulls{/number}","milestones_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/milestones{/number}","notifications_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/labels{/name}","releases_url":"https://api.github.com/repos/pelllich/gulp-w3cjs/releases{/id}","created_at":"2015-12-06T12:00:53Z","updated_at":"2015-12-06T12:00:54Z","pushed_at":"2015-12-07T17:24:21Z","git_url":"git://github.com/pelllich/gulp-w3cjs.git","ssh_url":"git@github.com:pelllich/gulp-w3cjs.git","clone_url":"https://github.com/pelllich/gulp-w3cjs.git","svn_url":"https://github.com/pelllich/gulp-w3cjs","homepage":"","size":37,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callumacrae:master","ref":"master","sha":"ccac433dcd4722fd188b71325347133cd47f2211","user":{"login":"callumacrae","id":472830,"avatar_url":"https://avatars.githubusercontent.com/u/472830?v=3","gravatar_id":"","url":"https://api.github.com/users/callumacrae","html_url":"https://github.com/callumacrae","followers_url":"https://api.github.com/users/callumacrae/followers","following_url":"https://api.github.com/users/callumacrae/following{/other_user}","gists_url":"https://api.github.com/users/callumacrae/gists{/gist_id}","starred_url":"https://api.github.com/users/callumacrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callumacrae/subscriptions","organizations_url":"https://api.github.com/users/callumacrae/orgs","repos_url":"https://api.github.com/users/callumacrae/repos","events_url":"https://api.github.com/users/callumacrae/events{/privacy}","received_events_url":"https://api.github.com/users/callumacrae/received_events","type":"User","site_admin":false},"repo":{"id":15512955,"name":"gulp-w3cjs","full_name":"callumacrae/gulp-w3cjs","owner":{"login":"callumacrae","id":472830,"avatar_url":"https://avatars.githubusercontent.com/u/472830?v=3","gravatar_id":"","url":"https://api.github.com/users/callumacrae","html_url":"https://github.com/callumacrae","followers_url":"https://api.github.com/users/callumacrae/followers","following_url":"https://api.github.com/users/callumacrae/following{/other_user}","gists_url":"https://api.github.com/users/callumacrae/gists{/gist_id}","starred_url":"https://api.github.com/users/callumacrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callumacrae/subscriptions","organizations_url":"https://api.github.com/users/callumacrae/orgs","repos_url":"https://api.github.com/users/callumacrae/repos","events_url":"https://api.github.com/users/callumacrae/events{/privacy}","received_events_url":"https://api.github.com/users/callumacrae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/callumacrae/gulp-w3cjs","description":":vertical_traffic_light: w3cjs wrapper for gulp to validate your HTML","fork":false,"url":"https://api.github.com/repos/callumacrae/gulp-w3cjs","forks_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/forks","keys_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/teams","hooks_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/hooks","issue_events_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues/events{/number}","events_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/events","assignees_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/assignees{/user}","branches_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/branches{/branch}","tags_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/tags","blobs_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/statuses/{sha}","languages_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/languages","stargazers_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/stargazers","contributors_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/contributors","subscribers_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/subscribers","subscription_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/subscription","commits_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/contents/{+path}","compare_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/merges","archive_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/downloads","issues_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues{/number}","pulls_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls{/number}","milestones_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/milestones{/number}","notifications_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/labels{/name}","releases_url":"https://api.github.com/repos/callumacrae/gulp-w3cjs/releases{/id}","created_at":"2013-12-29T18:32:02Z","updated_at":"2015-10-27T11:21:58Z","pushed_at":"2015-12-07T17:24:21Z","git_url":"git://github.com/callumacrae/gulp-w3cjs.git","ssh_url":"git@github.com:callumacrae/gulp-w3cjs.git","clone_url":"https://github.com/callumacrae/gulp-w3cjs.git","svn_url":"https://github.com/callumacrae/gulp-w3cjs","homepage":"","size":336,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18"},"html":{"href":"https://github.com/callumacrae/gulp-w3cjs/pull/18"},"issue":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues/18"},"comments":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/callumacrae/gulp-w3cjs/statuses/c744136ad11695a2da2941d9cb9f109ea8e1a3c6"}}}}