{"action":"created","issue":{"url":"https://api.github.com/repos/WordPoints/wordpoints/issues/349","labels_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/349/comments","events_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/349/events","html_url":"https://github.com/WordPoints/wordpoints/issues/349","id":104787586,"number":349,"title":"Module flagged as incompatible on activation","user":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WordPoints/wordpoints/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/WordPoints/wordpoints/milestones/24","html_url":"https://github.com/WordPoints/wordpoints/milestones/2.0.2","labels_url":"https://api.github.com/repos/WordPoints/wordpoints/milestones/24/labels","id":1289192,"number":24,"title":"2.0.2","description":null,"creator":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2015-09-03T21:30:15Z","updated_at":"2015-09-03T21:43:45Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-09-03T21:43:45Z","updated_at":"2015-09-04T15:59:46Z","closed_at":null,"body":"In 2.0.0 we introduced a special module compatibility check performed when a breaking update occurs (WordPoints 1.x to 2.x, for example; see #330). For some reason, this check is sometimes being performed when a module is activated (and, at least part of the time, failing). This should not be occurring.\r\n\r\nAfter some investigation I believe that I have found the cause of the problem. In `WordPoints_Installables::maybe_do_updates()`, the `$data` variable is used in a `foreach` loop as a reference to either the local or network-wide version data. This simplifies the logic in the rest of the loop somewhat, because we don't have to keep checking which data-array to modify. However, I think the use of references within a loop is coming back to bite me, though I'm not sure exactly how yet."},"comment":{"url":"https://api.github.com/repos/WordPoints/wordpoints/issues/comments/137776876","html_url":"https://github.com/WordPoints/wordpoints/issues/349#issuecomment-137776876","issue_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/349","id":137776876,"user":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T15:59:46Z","updated_at":"2015-09-04T15:59:46Z","body":"I think I was actually wrong. It seems that in this case WordPoints's installation code was not being run when the plugin was activated. Because of this, the plugin version was not set in the database, resulting in the breaking update check always being performed on every page load. It only appeared that it was related to module activation, because, until a module was activated, there weren't any active modules for the breaking update compatibility checker to check.\r\n\r\nI still do not know why the activation code wasn't being run correctly, but it might be a bug in WordPress or another plugin that was causing it. I haven't been able to reproduce it myself."}}