{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/44010138","id":44010138,"diff_hunk":"@@ -1,8 +1,6 @@\n \"\"\"\n font data tables for truetype and afm computer modern fonts\n \"\"\"\n-# this dict maps symbol names to fontnames, glyphindex.  To get the\n-# glyph index from the character code, you have to use get_charmap","path":"lib/matplotlib/_mathtext_data.py","position":5,"original_position":5,"commit_id":"cce95bc6116b71eeb075add1db4ea919af156d4b","original_commit_id":"cce95bc6116b71eeb075add1db4ea919af156d4b","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"This comment is out of date and should have been removed in #5299.","created_at":"2015-11-05T13:22:53Z","updated_at":"2015-11-05T13:22:53Z","html_url":"https://github.com/matplotlib/matplotlib/pull/5410#discussion_r44010138","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/44010138"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/5410#discussion_r44010138"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410","id":49822852,"html_url":"https://github.com/matplotlib/matplotlib/pull/5410","diff_url":"https://github.com/matplotlib/matplotlib/pull/5410.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/5410.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5410","number":5410,"state":"open","locked":false,"title":"Remove uses of font.get_charmap","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"This is a follow-on to #5299 and removes all other uses of `FT2Font.get_charmap` in the code base (and these ones were a lot easier).  Again, this helps a lot with large Unicode fonts since we don't have to generate a large dictionary just to access the handful of characters any one plot contains.","created_at":"2015-11-05T13:22:29Z","updated_at":"2015-11-05T13:22:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"130658a9c6c38e740c7e7624b2c7de7f1c1716cc","assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14","html_url":"https://github.com/matplotlib/matplotlib/milestones/next%20major%20release%20(2.0)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14/labels","id":662004,"number":14,"title":"next major release (2.0)","description":"Style changes only","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":36,"state":"open","created_at":"2014-05-17T14:28:22Z","updated_at":"2015-11-05T13:22:33Z","due_on":"2015-11-30T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5410/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/cce95bc6116b71eeb075add1db4ea919af156d4b","head":{"label":"mdboom:get-charmap-removal","ref":"get-charmap-removal","sha":"cce95bc6116b71eeb075add1db4ea919af156d4b","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"repo":{"id":1389427,"name":"matplotlib","full_name":"mdboom/matplotlib","owner":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdboom/matplotlib","description":"","fork":true,"url":"https://api.github.com/repos/mdboom/matplotlib","forks_url":"https://api.github.com/repos/mdboom/matplotlib/forks","keys_url":"https://api.github.com/repos/mdboom/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdboom/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdboom/matplotlib/teams","hooks_url":"https://api.github.com/repos/mdboom/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/mdboom/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/mdboom/matplotlib/events","assignees_url":"https://api.github.com/repos/mdboom/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/mdboom/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/mdboom/matplotlib/tags","blobs_url":"https://api.github.com/repos/mdboom/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdboom/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdboom/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdboom/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdboom/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/mdboom/matplotlib/languages","stargazers_url":"https://api.github.com/repos/mdboom/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/mdboom/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/mdboom/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/mdboom/matplotlib/subscription","commits_url":"https://api.github.com/repos/mdboom/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdboom/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdboom/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdboom/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdboom/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/mdboom/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdboom/matplotlib/merges","archive_url":"https://api.github.com/repos/mdboom/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdboom/matplotlib/downloads","issues_url":"https://api.github.com/repos/mdboom/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/mdboom/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/mdboom/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/mdboom/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdboom/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/mdboom/matplotlib/releases{/id}","created_at":"2011-02-20T15:17:10Z","updated_at":"2015-03-03T18:29:21Z","pushed_at":"2015-11-05T13:20:56Z","git_url":"git://github.com/mdboom/matplotlib.git","ssh_url":"git@github.com:mdboom/matplotlib.git","clone_url":"https://github.com/mdboom/matplotlib.git","svn_url":"https://github.com/mdboom/matplotlib","homepage":"","size":255428,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"c53c58c65d182f436e3d635343258e779455c04c","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2015-11-05T12:56:57Z","pushed_at":"2015-11-05T13:22:30Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":318235,"stargazers_count":2970,"watchers_count":2970,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1510,"mirror_url":null,"open_issues_count":714,"forks":1510,"open_issues":714,"watchers":2970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/5410"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/5410"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/5410/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5410/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/cce95bc6116b71eeb075add1db4ea919af156d4b"}}}}