{"action":"created","issue":{"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/3220","labels_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/3220/labels{/name}","comments_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/3220/comments","events_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/3220/events","html_url":"https://github.com/natecavanaugh/liferay-portal/pull/3220","id":74259828,"number":3220,"title":"LPS-55175 Simplify ItemViewer module","user":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-08T07:04:45Z","updated_at":"2015-05-08T07:10:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/3220","html_url":"https://github.com/natecavanaugh/liferay-portal/pull/3220","diff_url":"https://github.com/natecavanaugh/liferay-portal/pull/3220.diff","patch_url":"https://github.com/natecavanaugh/liferay-portal/pull/3220.patch"},"body":"Rebased and resent ;)\r\n\r\nJust as a reminder from the previous PR:\r\n\r\n* Please, remove [`LPS-55175 [WARNING] not to merge`](https://github.com/jbalsas/liferay-portal/commit/e0e943a98435845f5abf09ba774d74c0081ee085) before sending to Brian. This adds a silly button inside the wiki view you can use to test the results.\r\n* For this PR, I've imported `list_group` from the guidelines. It simplifies styling things immensely, and keeps us from reinventing the markup+css wheel over and over. Not sure what's the status on the guidelines, but bringing this indeed helps. What do you think?\r\n \r\nThanks!\r\n\r\n/cc @sergiogonzalez @ipeychev @ambrinchaudhary "},"comment":{"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/comments/100129046","html_url":"https://github.com/natecavanaugh/liferay-portal/pull/3220#issuecomment-100129046","issue_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/3220","id":100129046,"user":{"login":"liferay-dev-ci","id":1374228,"avatar_url":"https://avatars.githubusercontent.com/u/1374228?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-dev-ci","html_url":"https://github.com/liferay-dev-ci","followers_url":"https://api.github.com/users/liferay-dev-ci/followers","following_url":"https://api.github.com/users/liferay-dev-ci/following{/other_user}","gists_url":"https://api.github.com/users/liferay-dev-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-dev-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-dev-ci/subscriptions","organizations_url":"https://api.github.com/users/liferay-dev-ci/orgs","repos_url":"https://api.github.com/users/liferay-dev-ci/repos","events_url":"https://api.github.com/users/liferay-dev-ci/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-dev-ci/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T07:10:34Z","updated_at":"2015-05-08T07:10:34Z","body":"Test FAILed.\nRefer to this link for build results (access rights to CI server needed): \n\nBuild Time: 5 mins 17 secs\nhttp://ci.liferay.org.es/jenkins//job/natecavanaugh/2296/<h2>Failed Tests: <span class='status-failure'>10</span></h2><h3><a name='natecavanaugh' /><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/'>natecavanaugh</a>: <span class='status-failure'>10</span></h3><ul><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_apps_wiki_wiki-web_docroot_html_portlet_wiki_view/jsp/undefined'><strong>modules/apps/wiki/wiki-web/docroot/html/portlet/wiki/view.jsp.undefined</strong></a>\n```\nLine 141: Variable declaration needs a new line after it: var dialog = Liferay.Util.getWindow('_PN_openFileEntryTypeView');\nLine 167: Sort attribute values: SELECT NUMBER!\nLine 303: Block level containers need either a class or id: <div>\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_apps_wiki_wiki-web_docroot_html_portlet_wiki_view/jsp/space_infix_ops'><strong>modules/apps/wiki/wiki-web/docroot/html/portlet/wiki/view.jsp.space-infix-ops</strong></a>\n```\nLine 144: Infix operators must be spaced.\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_apps_wiki_wiki-web_docroot_html_portlet_wiki_view/jsp/quotes'><strong>modules/apps/wiki/wiki-web/docroot/html/portlet/wiki/view.jsp.quotes</strong></a>\n```\nLine 144: Strings must use singlequote.\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_apps_wiki_wiki-web_docroot_html_portlet_wiki_view/jsp/semi'><strong>modules/apps/wiki/wiki-web/docroot/html/portlet/wiki/view.jsp.semi</strong></a>\n```\nLine 145: Missing semicolon.\nLine 165: Missing semicolon.\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_frontend_frontend-js-web_src_META-INF_resources_html_js_liferay_item_selector_browser/js/semi'><strong>modules/frontend/frontend-js-web/src/META-INF/resources/html/js/liferay/item_selector_browser.js.semi</strong></a>\n```\nLine 95: Missing semicolon.\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_frontend_frontend-js-web_src_META-INF_resources_html_js_liferay_item_selector_browser/js/csf_sort_props'><strong>modules/frontend/frontend-js-web/src/META-INF/resources/html/js/liferay/item_selector_browser.js.csf-sort-props</strong></a>\n```\nLine 130: Sort properties: title preview\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_frontend_frontend-js-web_src_META-INF_resources_html_js_liferay_modules/js/csf_sort_vars'><strong>modules/frontend/frontend-js-web/src/META-INF/resources/html/js/liferay/modules.js.csf-sort-vars</strong></a>\n```\nLine 2: Sort variables: LiferayAUI Browser\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/modules_frontend_frontend-js-web_src_META-INF_resources_html_js_liferay_modules/js/no_extra_parens'><strong>modules/frontend/frontend-js-web/src/META-INF/resources/html/js/liferay/modules.js.no-extra-parens</strong></a>\n```\nLine 13: Gratuitous parentheses around expression.\nLine 20: Gratuitous parentheses around expression.\nLine 202: Gratuitous parentheses around expression.\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/portal-web_docroot_html_taglib_ui_image_selector_page/jsp/csf_sort_props'><strong>portal-web/docroot/html/taglib/ui/image_selector/page.jsp.csf-sort-props</strong></a>\n```\nLine 117: Sort properties: itemSelectorURL errorNode\n```\n</li><li><a href='http://ci.liferay.org.es/jenkins/job/natecavanaugh/2296/testReport/junit/portal-web_docroot_html_taglib_ui_item_selector_browser_page/jsp/undefined'><strong>portal-web/docroot/html/taglib/ui/item_selector_browser/page.jsp.undefined</strong></a>\n```\nLine 125: Sort attribute values: text-default status\nLine 145: These arguments should each be on their own line: new Liferay.ItemSelectorBrowser({\n```\n</li></ul>\nTest FAILed."}}