{"action":"created","comment":{"url":"https://api.github.com/repos/dbfit/dbfit/pulls/comments/44215935","id":44215935,"diff_hunk":"@@ -0,0 +1,331 @@\n+package dbfit.environment;\n+\n+import dbfit.annotations.DatabaseEnvironment;\n+import dbfit.api.AbstractDbEnvironment;\n+import dbfit.fixture.StatementExecution;\n+import dbfit.util.DbParameterAccessor;\n+import dbfit.util.DdlStatementExecution;\n+import dbfit.util.Direction;\n+import dbfit.util.NameNormaliser;\n+import dbfit.util.Options;\n+import dbfit.util.TypeNormaliserFactory;\n+import fit.TypeAdapter;\n+\n+import java.math.BigDecimal;\n+import java.sql.*;\n+import java.util.*;\n+import java.util.regex.Pattern;\n+\n+import static dbfit.util.Direction.*;\n+\n+@DatabaseEnvironment(name=\"Informix\", driver=\"com.informix.jdbc.IfxDriver\")\n+public class InformixEnvironment extends AbstractDbEnvironment {\n+\n+    @Override\n+    public void afterConnectionEstablished() throws SQLException {\n+        if (currentConnection.getMetaData().supportsTransactions()) {","path":"dbfit-java/informix/src/main/java/dbfit/environment/InformixEnvironment.java","position":27,"original_position":26,"commit_id":"4be4fd107a02d8aa60222b1c932539d5b852c3d5","original_commit_id":"ff345b73e9d67ea4c680cdeb049c652f40b87008","user":{"login":"MMatten","id":1895701,"avatar_url":"https://avatars.githubusercontent.com/u/1895701?v=3","gravatar_id":"","url":"https://api.github.com/users/MMatten","html_url":"https://github.com/MMatten","followers_url":"https://api.github.com/users/MMatten/followers","following_url":"https://api.github.com/users/MMatten/following{/other_user}","gists_url":"https://api.github.com/users/MMatten/gists{/gist_id}","starred_url":"https://api.github.com/users/MMatten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMatten/subscriptions","organizations_url":"https://api.github.com/users/MMatten/orgs","repos_url":"https://api.github.com/users/MMatten/repos","events_url":"https://api.github.com/users/MMatten/events{/privacy}","received_events_url":"https://api.github.com/users/MMatten/received_events","type":"User","site_admin":false},"body":"After doing some testing with setting `autocommit` it seems that this doesn't affect that `getMetaData().supportsTransactions()` returns. It's always `false` in Informix mode and `true` in `ANSI` mode.\r\n\r\nIt seems like we don't need this method override at all in fact (at least with the acceptance tests that we have, including of course `CommitAndRollback`).\r\n\r\nI think we can just leave the autocommit state be the default.","created_at":"2015-11-07T19:26:42Z","updated_at":"2015-11-07T19:26:42Z","html_url":"https://github.com/dbfit/dbfit/pull/436#discussion_r44215935","pull_request_url":"https://api.github.com/repos/dbfit/dbfit/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/dbfit/dbfit/pulls/comments/44215935"},"html":{"href":"https://github.com/dbfit/dbfit/pull/436#discussion_r44215935"},"pull_request":{"href":"https://api.github.com/repos/dbfit/dbfit/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/dbfit/dbfit/pulls/436","id":48685855,"html_url":"https://github.com/dbfit/dbfit/pull/436","diff_url":"https://github.com/dbfit/dbfit/pull/436.diff","patch_url":"https://github.com/dbfit/dbfit/pull/436.patch","issue_url":"https://api.github.com/repos/dbfit/dbfit/issues/436","number":436,"state":"open","locked":false,"title":"Support Informix","user":{"login":"MMatten","id":1895701,"avatar_url":"https://avatars.githubusercontent.com/u/1895701?v=3","gravatar_id":"","url":"https://api.github.com/users/MMatten","html_url":"https://github.com/MMatten","followers_url":"https://api.github.com/users/MMatten/followers","following_url":"https://api.github.com/users/MMatten/following{/other_user}","gists_url":"https://api.github.com/users/MMatten/gists{/gist_id}","starred_url":"https://api.github.com/users/MMatten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMatten/subscriptions","organizations_url":"https://api.github.com/users/MMatten/orgs","repos_url":"https://api.github.com/users/MMatten/repos","events_url":"https://api.github.com/users/MMatten/events{/privacy}","received_events_url":"https://api.github.com/users/MMatten/received_events","type":"User","site_admin":false},"body":"Support for Informix (using alternate approach of allowing `StatementExecution` sub-classing instead of adding more parameters to existing class methods and more property getters on the `DBEnvironment` interface).","created_at":"2015-10-25T19:39:22Z","updated_at":"2015-11-07T19:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76fc7b200e82cca22ed610ee63b45d0bf101d248","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dbfit/dbfit/pulls/436/commits","review_comments_url":"https://api.github.com/repos/dbfit/dbfit/pulls/436/comments","review_comment_url":"https://api.github.com/repos/dbfit/dbfit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbfit/dbfit/issues/436/comments","statuses_url":"https://api.github.com/repos/dbfit/dbfit/statuses/4be4fd107a02d8aa60222b1c932539d5b852c3d5","head":{"label":"MMatten:support-informix-function-calls","ref":"support-informix-function-calls","sha":"4be4fd107a02d8aa60222b1c932539d5b852c3d5","user":{"login":"MMatten","id":1895701,"avatar_url":"https://avatars.githubusercontent.com/u/1895701?v=3","gravatar_id":"","url":"https://api.github.com/users/MMatten","html_url":"https://github.com/MMatten","followers_url":"https://api.github.com/users/MMatten/followers","following_url":"https://api.github.com/users/MMatten/following{/other_user}","gists_url":"https://api.github.com/users/MMatten/gists{/gist_id}","starred_url":"https://api.github.com/users/MMatten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMatten/subscriptions","organizations_url":"https://api.github.com/users/MMatten/orgs","repos_url":"https://api.github.com/users/MMatten/repos","events_url":"https://api.github.com/users/MMatten/events{/privacy}","received_events_url":"https://api.github.com/users/MMatten/received_events","type":"User","site_admin":false},"repo":{"id":42365201,"name":"dbfit","full_name":"MMatten/dbfit","owner":{"login":"MMatten","id":1895701,"avatar_url":"https://avatars.githubusercontent.com/u/1895701?v=3","gravatar_id":"","url":"https://api.github.com/users/MMatten","html_url":"https://github.com/MMatten","followers_url":"https://api.github.com/users/MMatten/followers","following_url":"https://api.github.com/users/MMatten/following{/other_user}","gists_url":"https://api.github.com/users/MMatten/gists{/gist_id}","starred_url":"https://api.github.com/users/MMatten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMatten/subscriptions","organizations_url":"https://api.github.com/users/MMatten/orgs","repos_url":"https://api.github.com/users/MMatten/repos","events_url":"https://api.github.com/users/MMatten/events{/privacy}","received_events_url":"https://api.github.com/users/MMatten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MMatten/dbfit","description":"DbFit is a database testing framework that supports easy test-driven development of your database code.","fork":true,"url":"https://api.github.com/repos/MMatten/dbfit","forks_url":"https://api.github.com/repos/MMatten/dbfit/forks","keys_url":"https://api.github.com/repos/MMatten/dbfit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MMatten/dbfit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MMatten/dbfit/teams","hooks_url":"https://api.github.com/repos/MMatten/dbfit/hooks","issue_events_url":"https://api.github.com/repos/MMatten/dbfit/issues/events{/number}","events_url":"https://api.github.com/repos/MMatten/dbfit/events","assignees_url":"https://api.github.com/repos/MMatten/dbfit/assignees{/user}","branches_url":"https://api.github.com/repos/MMatten/dbfit/branches{/branch}","tags_url":"https://api.github.com/repos/MMatten/dbfit/tags","blobs_url":"https://api.github.com/repos/MMatten/dbfit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MMatten/dbfit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MMatten/dbfit/git/refs{/sha}","trees_url":"https://api.github.com/repos/MMatten/dbfit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MMatten/dbfit/statuses/{sha}","languages_url":"https://api.github.com/repos/MMatten/dbfit/languages","stargazers_url":"https://api.github.com/repos/MMatten/dbfit/stargazers","contributors_url":"https://api.github.com/repos/MMatten/dbfit/contributors","subscribers_url":"https://api.github.com/repos/MMatten/dbfit/subscribers","subscription_url":"https://api.github.com/repos/MMatten/dbfit/subscription","commits_url":"https://api.github.com/repos/MMatten/dbfit/commits{/sha}","git_commits_url":"https://api.github.com/repos/MMatten/dbfit/git/commits{/sha}","comments_url":"https://api.github.com/repos/MMatten/dbfit/comments{/number}","issue_comment_url":"https://api.github.com/repos/MMatten/dbfit/issues/comments{/number}","contents_url":"https://api.github.com/repos/MMatten/dbfit/contents/{+path}","compare_url":"https://api.github.com/repos/MMatten/dbfit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MMatten/dbfit/merges","archive_url":"https://api.github.com/repos/MMatten/dbfit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MMatten/dbfit/downloads","issues_url":"https://api.github.com/repos/MMatten/dbfit/issues{/number}","pulls_url":"https://api.github.com/repos/MMatten/dbfit/pulls{/number}","milestones_url":"https://api.github.com/repos/MMatten/dbfit/milestones{/number}","notifications_url":"https://api.github.com/repos/MMatten/dbfit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MMatten/dbfit/labels{/name}","releases_url":"https://api.github.com/repos/MMatten/dbfit/releases{/id}","created_at":"2015-09-12T16:58:00Z","updated_at":"2015-09-12T16:58:01Z","pushed_at":"2015-11-07T14:33:54Z","git_url":"git://github.com/MMatten/dbfit.git","ssh_url":"git@github.com:MMatten/dbfit.git","clone_url":"https://github.com/MMatten/dbfit.git","svn_url":"https://github.com/MMatten/dbfit","homepage":"http://dbfit.github.io/dbfit","size":6860,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dbfit:master","ref":"master","sha":"9ea523df822fc598cfad5922962aec6150e40472","user":{"login":"dbfit","id":6273536,"avatar_url":"https://avatars.githubusercontent.com/u/6273536?v=3","gravatar_id":"","url":"https://api.github.com/users/dbfit","html_url":"https://github.com/dbfit","followers_url":"https://api.github.com/users/dbfit/followers","following_url":"https://api.github.com/users/dbfit/following{/other_user}","gists_url":"https://api.github.com/users/dbfit/gists{/gist_id}","starred_url":"https://api.github.com/users/dbfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbfit/subscriptions","organizations_url":"https://api.github.com/users/dbfit/orgs","repos_url":"https://api.github.com/users/dbfit/repos","events_url":"https://api.github.com/users/dbfit/events{/privacy}","received_events_url":"https://api.github.com/users/dbfit/received_events","type":"Organization","site_admin":false},"repo":{"id":7283919,"name":"dbfit","full_name":"dbfit/dbfit","owner":{"login":"dbfit","id":6273536,"avatar_url":"https://avatars.githubusercontent.com/u/6273536?v=3","gravatar_id":"","url":"https://api.github.com/users/dbfit","html_url":"https://github.com/dbfit","followers_url":"https://api.github.com/users/dbfit/followers","following_url":"https://api.github.com/users/dbfit/following{/other_user}","gists_url":"https://api.github.com/users/dbfit/gists{/gist_id}","starred_url":"https://api.github.com/users/dbfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbfit/subscriptions","organizations_url":"https://api.github.com/users/dbfit/orgs","repos_url":"https://api.github.com/users/dbfit/repos","events_url":"https://api.github.com/users/dbfit/events{/privacy}","received_events_url":"https://api.github.com/users/dbfit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbfit/dbfit","description":"DbFit is a database testing framework that supports easy test-driven development of your database code.","fork":false,"url":"https://api.github.com/repos/dbfit/dbfit","forks_url":"https://api.github.com/repos/dbfit/dbfit/forks","keys_url":"https://api.github.com/repos/dbfit/dbfit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbfit/dbfit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbfit/dbfit/teams","hooks_url":"https://api.github.com/repos/dbfit/dbfit/hooks","issue_events_url":"https://api.github.com/repos/dbfit/dbfit/issues/events{/number}","events_url":"https://api.github.com/repos/dbfit/dbfit/events","assignees_url":"https://api.github.com/repos/dbfit/dbfit/assignees{/user}","branches_url":"https://api.github.com/repos/dbfit/dbfit/branches{/branch}","tags_url":"https://api.github.com/repos/dbfit/dbfit/tags","blobs_url":"https://api.github.com/repos/dbfit/dbfit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbfit/dbfit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbfit/dbfit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbfit/dbfit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbfit/dbfit/statuses/{sha}","languages_url":"https://api.github.com/repos/dbfit/dbfit/languages","stargazers_url":"https://api.github.com/repos/dbfit/dbfit/stargazers","contributors_url":"https://api.github.com/repos/dbfit/dbfit/contributors","subscribers_url":"https://api.github.com/repos/dbfit/dbfit/subscribers","subscription_url":"https://api.github.com/repos/dbfit/dbfit/subscription","commits_url":"https://api.github.com/repos/dbfit/dbfit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbfit/dbfit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbfit/dbfit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbfit/dbfit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbfit/dbfit/contents/{+path}","compare_url":"https://api.github.com/repos/dbfit/dbfit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbfit/dbfit/merges","archive_url":"https://api.github.com/repos/dbfit/dbfit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbfit/dbfit/downloads","issues_url":"https://api.github.com/repos/dbfit/dbfit/issues{/number}","pulls_url":"https://api.github.com/repos/dbfit/dbfit/pulls{/number}","milestones_url":"https://api.github.com/repos/dbfit/dbfit/milestones{/number}","notifications_url":"https://api.github.com/repos/dbfit/dbfit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbfit/dbfit/labels{/name}","releases_url":"https://api.github.com/repos/dbfit/dbfit/releases{/id}","created_at":"2012-12-22T08:26:13Z","updated_at":"2015-10-17T00:16:56Z","pushed_at":"2015-11-07T14:33:55Z","git_url":"git://github.com/dbfit/dbfit.git","ssh_url":"git@github.com:dbfit/dbfit.git","clone_url":"https://github.com/dbfit/dbfit.git","svn_url":"https://github.com/dbfit/dbfit","homepage":"http://dbfit.github.io/dbfit","size":11258,"stargazers_count":79,"watchers_count":79,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":78,"forks":47,"open_issues":78,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbfit/dbfit/pulls/436"},"html":{"href":"https://github.com/dbfit/dbfit/pull/436"},"issue":{"href":"https://api.github.com/repos/dbfit/dbfit/issues/436"},"comments":{"href":"https://api.github.com/repos/dbfit/dbfit/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/dbfit/dbfit/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/dbfit/dbfit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbfit/dbfit/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/dbfit/dbfit/statuses/4be4fd107a02d8aa60222b1c932539d5b852c3d5"}}}}