{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/kue/issues/652","labels_url":"https://api.github.com/repos/Automattic/kue/issues/652/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/kue/issues/652/comments","events_url":"https://api.github.com/repos/Automattic/kue/issues/652/events","html_url":"https://github.com/Automattic/kue/pull/652","id":89432335,"number":652,"title":"add support for ioredis","user":{"login":"az7arul","id":1428169,"avatar_url":"https://avatars.githubusercontent.com/u/1428169?v=3","gravatar_id":"","url":"https://api.github.com/users/az7arul","html_url":"https://github.com/az7arul","followers_url":"https://api.github.com/users/az7arul/followers","following_url":"https://api.github.com/users/az7arul/following{/other_user}","gists_url":"https://api.github.com/users/az7arul/gists{/gist_id}","starred_url":"https://api.github.com/users/az7arul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/az7arul/subscriptions","organizations_url":"https://api.github.com/users/az7arul/orgs","repos_url":"https://api.github.com/users/az7arul/repos","events_url":"https://api.github.com/users/az7arul/events{/privacy}","received_events_url":"https://api.github.com/users/az7arul/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/kue/labels/Discussion","name":"Discussion","color":"bfd4f2"},{"url":"https://api.github.com/repos/Automattic/kue/labels/Feature","name":"Feature","color":"009800"},{"url":"https://api.github.com/repos/Automattic/kue/labels/need%20more%20info","name":"need more info","color":"fef2c0"},{"url":"https://api.github.com/repos/Automattic/kue/labels/needs%20pull%20request","name":"needs pull request","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-06-19T00:29:24Z","updated_at":"2015-10-01T10:40:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/kue/pulls/652","html_url":"https://github.com/Automattic/kue/pull/652","diff_url":"https://github.com/Automattic/kue/pull/652.diff","patch_url":"https://github.com/Automattic/kue/pull/652.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Automattic/kue/issues/comments/144690800","html_url":"https://github.com/Automattic/kue/pull/652#issuecomment-144690800","issue_url":"https://api.github.com/repos/Automattic/kue/issues/652","id":144690800,"user":{"login":"dandanknight","id":1822840,"avatar_url":"https://avatars.githubusercontent.com/u/1822840?v=3","gravatar_id":"","url":"https://api.github.com/users/dandanknight","html_url":"https://github.com/dandanknight","followers_url":"https://api.github.com/users/dandanknight/followers","following_url":"https://api.github.com/users/dandanknight/following{/other_user}","gists_url":"https://api.github.com/users/dandanknight/gists{/gist_id}","starred_url":"https://api.github.com/users/dandanknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dandanknight/subscriptions","organizations_url":"https://api.github.com/users/dandanknight/orgs","repos_url":"https://api.github.com/users/dandanknight/repos","events_url":"https://api.github.com/users/dandanknight/events{/privacy}","received_events_url":"https://api.github.com/users/dandanknight/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T10:40:40Z","updated_at":"2015-10-01T10:40:40Z","body":"I've been testing this PR with ioredis in sentinel mode for a couple of days now, and so far, had no issues at all. I obviously had to do a flushall on Redis beforehand. Will be moving the code out of dev and into our test environment in the next few days, where it should get a good workout.\r\n\r\nAlso, one small gotcha I found is that because ioredis only emits an error event if it has a listener on it, I couldn't work out why I was getting uncaught exceptions during redis failover, but it turns out that Kue attaches to the ioredis error event by default, so that Kue error event needs to be caught and handled in the case of a redis-server going down and ioredis attempting reconnection to a slave.\r\n\r\nI've attached directly to the ioredis events and can now get some good logging out of it, in the case of lost connections, failovers, new connections, ready etc.\r\n\r\nI'll keep testing and let you know if I find any issues. Cheers."}}