{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/29541879","id":29541879,"diff_hunk":"@@ -1203,14 +1495,25 @@ class Player extends Component {\n       // Don't trigger a change event unless it actually changed\n       if (this.controls_ !== bool) {\n         this.controls_ = bool;\n+\n+        if (!this.usingNativeControls()) {","path":"src/js/player.js","position":587,"original_position":543,"commit_id":"693eab4040b6532d0ef08a0a2277a42b36872def","original_commit_id":"6abec67a2c596408f635eb6e9140ae01d38e5619","user":{"login":"eXon","id":280982,"avatar_url":"https://avatars.githubusercontent.com/u/280982?v=3","gravatar_id":"","url":"https://api.github.com/users/eXon","html_url":"https://github.com/eXon","followers_url":"https://api.github.com/users/eXon/followers","following_url":"https://api.github.com/users/eXon/following{/other_user}","gists_url":"https://api.github.com/users/eXon/gists{/gist_id}","starred_url":"https://api.github.com/users/eXon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXon/subscriptions","organizations_url":"https://api.github.com/users/eXon/orgs","repos_url":"https://api.github.com/users/eXon/repos","events_url":"https://api.github.com/users/eXon/events{/privacy}","received_events_url":"https://api.github.com/users/eXon/received_events","type":"User","site_admin":false},"body":"I think you're right, fixing it","created_at":"2015-05-01T23:56:35Z","updated_at":"2015-05-01T23:56:35Z","html_url":"https://github.com/videojs/video.js/pull/2057#discussion_r29541879","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2057","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/29541879"},"html":{"href":"https://github.com/videojs/video.js/pull/2057#discussion_r29541879"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2057"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2057","id":33849162,"html_url":"https://github.com/videojs/video.js/pull/2057","diff_url":"https://github.com/videojs/video.js/pull/2057.diff","patch_url":"https://github.com/videojs/video.js/pull/2057.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2057","number":2057,"state":"open","locked":false,"title":"Tech 2.0","user":{"login":"eXon","id":280982,"avatar_url":"https://avatars.githubusercontent.com/u/280982?v=3","gravatar_id":"","url":"https://api.github.com/users/eXon","html_url":"https://github.com/eXon","followers_url":"https://api.github.com/users/eXon/followers","following_url":"https://api.github.com/users/eXon/following{/other_user}","gists_url":"https://api.github.com/users/eXon/gists{/gist_id}","starred_url":"https://api.github.com/users/eXon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXon/subscriptions","organizations_url":"https://api.github.com/users/eXon/orgs","repos_url":"https://api.github.com/users/eXon/repos","events_url":"https://api.github.com/users/eXon/events{/privacy}","received_events_url":"https://api.github.com/users/eXon/received_events","type":"User","site_admin":false},"body":"I'm starting a pull request to make sure I'm working in the right direction and that everyone agrees with that. (https://github.com/videojs/video.js/issues/2008)\r\n\r\nBy the way I couldn't test Flash because `videojs.options` doesn't exists anymore so I can't set the swf path.\r\n\r\nLet me know what you guys think.\r\n\r\n## Roadmap\r\n- [x] Trigger events on the tech instead of the player (https://github.com/videojs/video.js/issues/1485)\r\n- [x] Player should be responsible for adding the DOM element of the tech on himself (using tech.el_)\r\n- [x] Remove every dependencies of the player on\r\n    - [x] tech (fix https://github.com/videojs/video.js/issues/1863)\r\n    - [x] html5\r\n    - [x] flash\r\n- [x] Remove the player from the tech constructor signature\r\n- [x] Fix unit tests","created_at":"2015-04-22T11:29:45Z","updated_at":"2015-05-01T23:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c83e9a7438460faa56cdc8b9339f16a8944efa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2057/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2057/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2057/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/693eab4040b6532d0ef08a0a2277a42b36872def","head":{"label":"eXon:feature/tech-2.0","ref":"feature/tech-2.0","sha":"693eab4040b6532d0ef08a0a2277a42b36872def","user":{"login":"eXon","id":280982,"avatar_url":"https://avatars.githubusercontent.com/u/280982?v=3","gravatar_id":"","url":"https://api.github.com/users/eXon","html_url":"https://github.com/eXon","followers_url":"https://api.github.com/users/eXon/followers","following_url":"https://api.github.com/users/eXon/following{/other_user}","gists_url":"https://api.github.com/users/eXon/gists{/gist_id}","starred_url":"https://api.github.com/users/eXon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXon/subscriptions","organizations_url":"https://api.github.com/users/eXon/orgs","repos_url":"https://api.github.com/users/eXon/repos","events_url":"https://api.github.com/users/eXon/events{/privacy}","received_events_url":"https://api.github.com/users/eXon/received_events","type":"User","site_admin":false},"repo":{"id":34380352,"name":"video.js","full_name":"eXon/video.js","owner":{"login":"eXon","id":280982,"avatar_url":"https://avatars.githubusercontent.com/u/280982?v=3","gravatar_id":"","url":"https://api.github.com/users/eXon","html_url":"https://github.com/eXon","followers_url":"https://api.github.com/users/eXon/followers","following_url":"https://api.github.com/users/eXon/following{/other_user}","gists_url":"https://api.github.com/users/eXon/gists{/gist_id}","starred_url":"https://api.github.com/users/eXon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXon/subscriptions","organizations_url":"https://api.github.com/users/eXon/orgs","repos_url":"https://api.github.com/users/eXon/repos","events_url":"https://api.github.com/users/eXon/events{/privacy}","received_events_url":"https://api.github.com/users/eXon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eXon/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/eXon/video.js","forks_url":"https://api.github.com/repos/eXon/video.js/forks","keys_url":"https://api.github.com/repos/eXon/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eXon/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eXon/video.js/teams","hooks_url":"https://api.github.com/repos/eXon/video.js/hooks","issue_events_url":"https://api.github.com/repos/eXon/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/eXon/video.js/events","assignees_url":"https://api.github.com/repos/eXon/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/eXon/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/eXon/video.js/tags","blobs_url":"https://api.github.com/repos/eXon/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eXon/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eXon/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/eXon/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eXon/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/eXon/video.js/languages","stargazers_url":"https://api.github.com/repos/eXon/video.js/stargazers","contributors_url":"https://api.github.com/repos/eXon/video.js/contributors","subscribers_url":"https://api.github.com/repos/eXon/video.js/subscribers","subscription_url":"https://api.github.com/repos/eXon/video.js/subscription","commits_url":"https://api.github.com/repos/eXon/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/eXon/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/eXon/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/eXon/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/eXon/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/eXon/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eXon/video.js/merges","archive_url":"https://api.github.com/repos/eXon/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eXon/video.js/downloads","issues_url":"https://api.github.com/repos/eXon/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/eXon/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/eXon/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/eXon/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eXon/video.js/labels{/name}","releases_url":"https://api.github.com/repos/eXon/video.js/releases{/id}","created_at":"2015-04-22T09:05:20Z","updated_at":"2015-04-22T09:05:22Z","pushed_at":"2015-05-01T23:41:56Z","git_url":"git://github.com/eXon/video.js.git","ssh_url":"git@github.com:eXon/video.js.git","clone_url":"https://github.com/eXon/video.js.git","svn_url":"https://github.com/eXon/video.js","homepage":"www.videojs.com","size":13501,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"476b8a4cf84d7fb4a0fa969865221dcbfcc52dfb","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-05-01T21:18:09Z","pushed_at":"2015-05-01T23:41:57Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":33098,"stargazers_count":8754,"watchers_count":8754,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2413,"mirror_url":null,"open_issues_count":190,"forks":2413,"open_issues":190,"watchers":8754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2057"},"html":{"href":"https://github.com/videojs/video.js/pull/2057"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2057"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2057/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2057/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2057/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/693eab4040b6532d0ef08a0a2277a42b36872def"}}}}