{"action":"closed","number":509,"pull_request":{"url":"https://api.github.com/repos/lhorie/mithril.js/pulls/509","id":31696101,"html_url":"https://github.com/lhorie/mithril.js/pull/509","diff_url":"https://github.com/lhorie/mithril.js/pull/509.diff","patch_url":"https://github.com/lhorie/mithril.js/pull/509.patch","issue_url":"https://api.github.com/repos/lhorie/mithril.js/issues/509","number":509,"state":"closed","locked":false,"title":"Component docs fixes","user":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"body":"A few simple fixes to the Components docs:\r\n\r\n- In \"Aggregation of Responsibility\" example, correctly access `contacts` from the controller\r\n- Consistently use the name `args` for arguments passed to a module\r\n- Add `ctrl` argument to views that were missing it\r\n\r\nNote: I didn't bother adding semicolons because they seem to be consistently omitted; I assume this is intentional (?).","created_at":"2015-03-22T22:10:34Z","updated_at":"2015-03-27T00:14:06Z","closed_at":"2015-03-27T00:14:06Z","merged_at":"2015-03-27T00:14:06Z","merge_commit_sha":"a2768efee3ad65c848115b6115962e6b8e4a157d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/509/commits","review_comments_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/509/comments","review_comment_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/issues/509/comments","statuses_url":"https://api.github.com/repos/lhorie/mithril.js/statuses/946ebeeb4255d9cd46c91ee4d015d82cec04f106","head":{"label":"sloria:fix-component-docs","ref":"fix-component-docs","sha":"946ebeeb4255d9cd46c91ee4d015d82cec04f106","user":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"repo":{"id":32697736,"name":"mithril.js","full_name":"sloria/mithril.js","owner":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sloria/mithril.js","description":"A Javascript Framework for Building Brilliant Applications (development repo)","fork":true,"url":"https://api.github.com/repos/sloria/mithril.js","forks_url":"https://api.github.com/repos/sloria/mithril.js/forks","keys_url":"https://api.github.com/repos/sloria/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sloria/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sloria/mithril.js/teams","hooks_url":"https://api.github.com/repos/sloria/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/sloria/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/sloria/mithril.js/events","assignees_url":"https://api.github.com/repos/sloria/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/sloria/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/sloria/mithril.js/tags","blobs_url":"https://api.github.com/repos/sloria/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sloria/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sloria/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/sloria/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sloria/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/sloria/mithril.js/languages","stargazers_url":"https://api.github.com/repos/sloria/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/sloria/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/sloria/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/sloria/mithril.js/subscription","commits_url":"https://api.github.com/repos/sloria/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/sloria/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/sloria/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/sloria/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/sloria/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/sloria/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sloria/mithril.js/merges","archive_url":"https://api.github.com/repos/sloria/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sloria/mithril.js/downloads","issues_url":"https://api.github.com/repos/sloria/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/sloria/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/sloria/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/sloria/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sloria/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/sloria/mithril.js/releases{/id}","created_at":"2015-03-22T22:00:20Z","updated_at":"2015-03-22T22:00:25Z","pushed_at":"2015-03-23T06:57:00Z","git_url":"git://github.com/sloria/mithril.js.git","ssh_url":"git@github.com:sloria/mithril.js.git","clone_url":"https://github.com/sloria/mithril.js.git","svn_url":"https://github.com/sloria/mithril.js","homepage":"http://lhorie.github.io/mithril","size":5773,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"lhorie:components","ref":"components","sha":"4632a619592c2896c3f3e703a6e505258910ad76","user":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"repo":{"id":17814354,"name":"mithril.js","full_name":"lhorie/mithril.js","owner":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhorie/mithril.js","description":"A Javascript Framework for Building Brilliant Applications (development repo)","fork":false,"url":"https://api.github.com/repos/lhorie/mithril.js","forks_url":"https://api.github.com/repos/lhorie/mithril.js/forks","keys_url":"https://api.github.com/repos/lhorie/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhorie/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhorie/mithril.js/teams","hooks_url":"https://api.github.com/repos/lhorie/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/lhorie/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/lhorie/mithril.js/events","assignees_url":"https://api.github.com/repos/lhorie/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/lhorie/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/lhorie/mithril.js/tags","blobs_url":"https://api.github.com/repos/lhorie/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhorie/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhorie/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhorie/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhorie/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/lhorie/mithril.js/languages","stargazers_url":"https://api.github.com/repos/lhorie/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/lhorie/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/lhorie/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/lhorie/mithril.js/subscription","commits_url":"https://api.github.com/repos/lhorie/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhorie/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhorie/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhorie/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/lhorie/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhorie/mithril.js/merges","archive_url":"https://api.github.com/repos/lhorie/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhorie/mithril.js/downloads","issues_url":"https://api.github.com/repos/lhorie/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/lhorie/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/lhorie/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/lhorie/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhorie/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/lhorie/mithril.js/releases{/id}","created_at":"2014-03-17T01:59:39Z","updated_at":"2015-03-26T19:17:52Z","pushed_at":"2015-03-27T00:14:06Z","git_url":"git://github.com/lhorie/mithril.js.git","ssh_url":"git@github.com:lhorie/mithril.js.git","clone_url":"https://github.com/lhorie/mithril.js.git","svn_url":"https://github.com/lhorie/mithril.js","homepage":"http://lhorie.github.io/mithril","size":5773,"stargazers_count":3031,"watchers_count":3031,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":18,"forks":224,"open_issues":18,"watchers":3031,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/509"},"html":{"href":"https://github.com/lhorie/mithril.js/pull/509"},"issue":{"href":"https://api.github.com/repos/lhorie/mithril.js/issues/509"},"comments":{"href":"https://api.github.com/repos/lhorie/mithril.js/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/lhorie/mithril.js/statuses/946ebeeb4255d9cd46c91ee4d015d82cec04f106"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":31,"deletions":31,"changed_files":1}}