{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/44663980","id":44663980,"diff_hunk":"@@ -45,6 +45,12 @@ export default function closureAction(morph, env, scope, params, hash, template,\n         if (!action) {\n           throw new EmberError(`An action named '${actionName}' was not found in ${target}.`);\n         }\n+      } else if (actionType === 'function') {\n+        // on-change={{action setName}}","path":"packages/ember-routing-htmlbars/lib/keywords/closure-action.js","position":5,"original_position":5,"commit_id":"b95a814c063cf17e5a3a6233d6360de9d1758a8f","original_commit_id":"b95a814c063cf17e5a3a6233d6360de9d1758a8f","user":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"body":"`setName` here is a function as apposed to `\"setName\"` which is a string and an action name. I can change to `setNameFunc` if needed. In another comment, I will describe our use case. Maybe, it's not worth allowing targets for functions.","created_at":"2015-11-12T14:43:21Z","updated_at":"2015-11-12T14:43:21Z","html_url":"https://github.com/emberjs/ember.js/pull/12594#discussion_r44663980","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12594","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/44663980"},"html":{"href":"https://github.com/emberjs/ember.js/pull/12594#discussion_r44663980"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12594"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/12594","id":50500618,"html_url":"https://github.com/emberjs/ember.js/pull/12594","diff_url":"https://github.com/emberjs/ember.js/pull/12594.diff","patch_url":"https://github.com/emberjs/ember.js/pull/12594.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/12594","number":12594,"state":"open","locked":false,"title":"Allows the target for action functions","user":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"body":"Currently invocations `(action \"actionName\")`, `(action \"actionName\" target=serviceName)` and `(action funcName)` are possible. `(action serviceName.funcName)` is possible too but the function will run in the current scope.\r\n\r\nThis PR enables the target attribute for invocations when the action is a function.  With this PR, `(action serviceName.funcName target=serviceName)` runs in the serviceName context. `(action serviceName.funcName)` still runs in the current context.","created_at":"2015-11-12T11:37:54Z","updated_at":"2015-11-12T14:43:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58383079b1845d7895a210610ca5a5fb598450f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12594/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12594/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/12594/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/b95a814c063cf17e5a3a6233d6360de9d1758a8f","head":{"label":"OrKoN:actions-target","ref":"actions-target","sha":"b95a814c063cf17e5a3a6233d6360de9d1758a8f","user":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"repo":{"id":45622973,"name":"ember.js","full_name":"OrKoN/ember.js","owner":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OrKoN/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/OrKoN/ember.js","forks_url":"https://api.github.com/repos/OrKoN/ember.js/forks","keys_url":"https://api.github.com/repos/OrKoN/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrKoN/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrKoN/ember.js/teams","hooks_url":"https://api.github.com/repos/OrKoN/ember.js/hooks","issue_events_url":"https://api.github.com/repos/OrKoN/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/OrKoN/ember.js/events","assignees_url":"https://api.github.com/repos/OrKoN/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/OrKoN/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/OrKoN/ember.js/tags","blobs_url":"https://api.github.com/repos/OrKoN/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrKoN/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrKoN/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrKoN/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrKoN/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/OrKoN/ember.js/languages","stargazers_url":"https://api.github.com/repos/OrKoN/ember.js/stargazers","contributors_url":"https://api.github.com/repos/OrKoN/ember.js/contributors","subscribers_url":"https://api.github.com/repos/OrKoN/ember.js/subscribers","subscription_url":"https://api.github.com/repos/OrKoN/ember.js/subscription","commits_url":"https://api.github.com/repos/OrKoN/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrKoN/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrKoN/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrKoN/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrKoN/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/OrKoN/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrKoN/ember.js/merges","archive_url":"https://api.github.com/repos/OrKoN/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrKoN/ember.js/downloads","issues_url":"https://api.github.com/repos/OrKoN/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/OrKoN/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/OrKoN/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/OrKoN/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrKoN/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/OrKoN/ember.js/releases{/id}","created_at":"2015-11-05T16:12:10Z","updated_at":"2015-11-05T16:12:17Z","pushed_at":"2015-11-12T11:27:50Z","git_url":"git://github.com/OrKoN/ember.js.git","ssh_url":"git@github.com:OrKoN/ember.js.git","clone_url":"https://github.com/OrKoN/ember.js.git","svn_url":"https://github.com/OrKoN/ember.js","homepage":"http://www.emberjs.com","size":30886,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"44e5f282dd2084a39d510bca5e7e2f8a5f776bb6","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-11-12T13:33:46Z","pushed_at":"2015-11-12T11:37:54Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":92221,"stargazers_count":15072,"watchers_count":15072,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3240,"mirror_url":null,"open_issues_count":349,"forks":3240,"open_issues":349,"watchers":15072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12594"},"html":{"href":"https://github.com/emberjs/ember.js/pull/12594"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/12594"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/12594/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12594/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12594/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/b95a814c063cf17e5a3a6233d6360de9d1758a8f"}}}}