{"action":"created","issue":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/137","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/137/comments","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/137/events","html_url":"https://github.com/iZettle/izettle-toolbox/pull/137","id":116118148,"number":137,"title":"JsonSerializer: add InstantModule to serialize as Instants.","user":{"login":"aaanders","id":1295656,"avatar_url":"https://avatars.githubusercontent.com/u/1295656?v=3","gravatar_id":"","url":"https://api.github.com/users/aaanders","html_url":"https://github.com/aaanders","followers_url":"https://api.github.com/users/aaanders/followers","following_url":"https://api.github.com/users/aaanders/following{/other_user}","gists_url":"https://api.github.com/users/aaanders/gists{/gist_id}","starred_url":"https://api.github.com/users/aaanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaanders/subscriptions","organizations_url":"https://api.github.com/users/aaanders/orgs","repos_url":"https://api.github.com/users/aaanders/repos","events_url":"https://api.github.com/users/aaanders/events{/privacy}","received_events_url":"https://api.github.com/users/aaanders/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-10T14:32:36Z","updated_at":"2015-11-11T16:04:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/137","html_url":"https://github.com/iZettle/izettle-toolbox/pull/137","diff_url":"https://github.com/iZettle/izettle-toolbox/pull/137.diff","patch_url":"https://github.com/iZettle/izettle-toolbox/pull/137.patch"},"body":"Instants will now be serialized as ISO8601/RFC3339 formatted string like\r\n`yyyy-MM-dd'T'HH:mm:ss.SSSZ`.\r\n\r\n@nzroller can you check, please?"},"comment":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments/155827631","html_url":"https://github.com/iZettle/izettle-toolbox/pull/137#issuecomment-155827631","issue_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/137","id":155827631,"user":{"login":"aaanders","id":1295656,"avatar_url":"https://avatars.githubusercontent.com/u/1295656?v=3","gravatar_id":"","url":"https://api.github.com/users/aaanders","html_url":"https://github.com/aaanders","followers_url":"https://api.github.com/users/aaanders/followers","following_url":"https://api.github.com/users/aaanders/following{/other_user}","gists_url":"https://api.github.com/users/aaanders/gists{/gist_id}","starred_url":"https://api.github.com/users/aaanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaanders/subscriptions","organizations_url":"https://api.github.com/users/aaanders/orgs","repos_url":"https://api.github.com/users/aaanders/repos","events_url":"https://api.github.com/users/aaanders/events{/privacy}","received_events_url":"https://api.github.com/users/aaanders/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T16:04:39Z","updated_at":"2015-11-11T16:04:39Z","body":"So, that wasn't the entire truth. Stupid test case. When the millis part is `.000` it won't be included at all. I guess it can be considered an optimisation. And the Z simply means no TZ and no offset which is the case for Instant.\r\n\r\nSo, here are some examples:\r\n```\r\nInstant epoch          > \"1970-01-01T00:00:00Z\"\r\nInstant epochPlus555   > \"1970-01-01T00:00:00.555Z\"\r\nZonedDateTime epochZ   > \"1970-01-01T00:00Z[UTC]\"\r\nZonedDateTime epochCet > \"1970-01-01T01:00+01:00[CET]\"\r\n```\r\n\r\nWith this in mind I think it might be worth it to  use the JavaTimeModule(or JSR-310 module until we bump jackson again). Then we would have everything set for serializing the `java.time` package and also not having to maintain this throughout our services. Thoughts? "}}