{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/63","id":43751860,"html_url":"https://github.com/RetroShare/RetroShare/pull/63","diff_url":"https://github.com/RetroShare/RetroShare/pull/63.diff","patch_url":"https://github.com/RetroShare/RetroShare/pull/63.patch","issue_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/63","number":63,"state":"closed","locked":false,"title":"Remove lobby gui lag","user":{"login":"AsamK","id":2340865,"avatar_url":"https://avatars.githubusercontent.com/u/2340865?v=3","gravatar_id":"","url":"https://api.github.com/users/AsamK","html_url":"https://github.com/AsamK","followers_url":"https://api.github.com/users/AsamK/followers","following_url":"https://api.github.com/users/AsamK/following{/other_user}","gists_url":"https://api.github.com/users/AsamK/gists{/gist_id}","starred_url":"https://api.github.com/users/AsamK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsamK/subscriptions","organizations_url":"https://api.github.com/users/AsamK/orgs","repos_url":"https://api.github.com/users/AsamK/repos","events_url":"https://api.github.com/users/AsamK/events{/privacy}","received_events_url":"https://api.github.com/users/AsamK/received_events","type":"User","site_admin":false},"body":"Commit e40460bdcc608b89ee890c46b1dee467362a9354 introduced a rather complicated system to count unread messages, nick occurences and special text occurences in lobbies. To detect which messages have been read it adds an anchor (\\<a name=\"…\"/\\>) to every message and stores a separate list of unread anchor names. Every time the mouse is moved or a key is pressed it gets the currently visible text in the chat widget, searches for all anchors in that text and removes all anchors it found from the unseen list. This introduces lags in the gui because executing the regexp on every mouse movement is expensive.\r\n\r\nThe main part of removing the lag is to only search for anchors if the visible text has actually changed not unconditionally on every event. This PR also makes some other smaller (performance) improvements, see the commit messages for details.","created_at":"2015-08-31T10:40:47Z","updated_at":"2015-08-31T18:11:46Z","closed_at":"2015-08-31T18:11:46Z","merged_at":"2015-08-31T18:11:46Z","merge_commit_sha":"5dc972ee61a67ee296f5f59ff484e39d5d2091e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/63/commits","review_comments_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/63/comments","review_comment_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/63/comments","statuses_url":"https://api.github.com/repos/RetroShare/RetroShare/statuses/cfde9d303cc5baa5c96d48b608905dfb78ace843","head":{"label":"AsamK:lobby_gui_lag","ref":"lobby_gui_lag","sha":"cfde9d303cc5baa5c96d48b608905dfb78ace843","user":{"login":"AsamK","id":2340865,"avatar_url":"https://avatars.githubusercontent.com/u/2340865?v=3","gravatar_id":"","url":"https://api.github.com/users/AsamK","html_url":"https://github.com/AsamK","followers_url":"https://api.github.com/users/AsamK/followers","following_url":"https://api.github.com/users/AsamK/following{/other_user}","gists_url":"https://api.github.com/users/AsamK/gists{/gist_id}","starred_url":"https://api.github.com/users/AsamK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsamK/subscriptions","organizations_url":"https://api.github.com/users/AsamK/orgs","repos_url":"https://api.github.com/users/AsamK/repos","events_url":"https://api.github.com/users/AsamK/events{/privacy}","received_events_url":"https://api.github.com/users/AsamK/received_events","type":"User","site_admin":false},"repo":{"id":40265413,"name":"RetroShare","full_name":"AsamK/RetroShare","owner":{"login":"AsamK","id":2340865,"avatar_url":"https://avatars.githubusercontent.com/u/2340865?v=3","gravatar_id":"","url":"https://api.github.com/users/AsamK","html_url":"https://github.com/AsamK","followers_url":"https://api.github.com/users/AsamK/followers","following_url":"https://api.github.com/users/AsamK/following{/other_user}","gists_url":"https://api.github.com/users/AsamK/gists{/gist_id}","starred_url":"https://api.github.com/users/AsamK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsamK/subscriptions","organizations_url":"https://api.github.com/users/AsamK/orgs","repos_url":"https://api.github.com/users/AsamK/repos","events_url":"https://api.github.com/users/AsamK/events{/privacy}","received_events_url":"https://api.github.com/users/AsamK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AsamK/RetroShare","description":"upstream Repository","fork":true,"url":"https://api.github.com/repos/AsamK/RetroShare","forks_url":"https://api.github.com/repos/AsamK/RetroShare/forks","keys_url":"https://api.github.com/repos/AsamK/RetroShare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AsamK/RetroShare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AsamK/RetroShare/teams","hooks_url":"https://api.github.com/repos/AsamK/RetroShare/hooks","issue_events_url":"https://api.github.com/repos/AsamK/RetroShare/issues/events{/number}","events_url":"https://api.github.com/repos/AsamK/RetroShare/events","assignees_url":"https://api.github.com/repos/AsamK/RetroShare/assignees{/user}","branches_url":"https://api.github.com/repos/AsamK/RetroShare/branches{/branch}","tags_url":"https://api.github.com/repos/AsamK/RetroShare/tags","blobs_url":"https://api.github.com/repos/AsamK/RetroShare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AsamK/RetroShare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AsamK/RetroShare/git/refs{/sha}","trees_url":"https://api.github.com/repos/AsamK/RetroShare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AsamK/RetroShare/statuses/{sha}","languages_url":"https://api.github.com/repos/AsamK/RetroShare/languages","stargazers_url":"https://api.github.com/repos/AsamK/RetroShare/stargazers","contributors_url":"https://api.github.com/repos/AsamK/RetroShare/contributors","subscribers_url":"https://api.github.com/repos/AsamK/RetroShare/subscribers","subscription_url":"https://api.github.com/repos/AsamK/RetroShare/subscription","commits_url":"https://api.github.com/repos/AsamK/RetroShare/commits{/sha}","git_commits_url":"https://api.github.com/repos/AsamK/RetroShare/git/commits{/sha}","comments_url":"https://api.github.com/repos/AsamK/RetroShare/comments{/number}","issue_comment_url":"https://api.github.com/repos/AsamK/RetroShare/issues/comments{/number}","contents_url":"https://api.github.com/repos/AsamK/RetroShare/contents/{+path}","compare_url":"https://api.github.com/repos/AsamK/RetroShare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AsamK/RetroShare/merges","archive_url":"https://api.github.com/repos/AsamK/RetroShare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AsamK/RetroShare/downloads","issues_url":"https://api.github.com/repos/AsamK/RetroShare/issues{/number}","pulls_url":"https://api.github.com/repos/AsamK/RetroShare/pulls{/number}","milestones_url":"https://api.github.com/repos/AsamK/RetroShare/milestones{/number}","notifications_url":"https://api.github.com/repos/AsamK/RetroShare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AsamK/RetroShare/labels{/name}","releases_url":"https://api.github.com/repos/AsamK/RetroShare/releases{/id}","created_at":"2015-08-05T19:42:25Z","updated_at":"2015-08-05T19:42:33Z","pushed_at":"2015-08-31T14:39:18Z","git_url":"git://github.com/AsamK/RetroShare.git","ssh_url":"git@github.com:AsamK/RetroShare.git","clone_url":"https://github.com/AsamK/RetroShare.git","svn_url":"https://github.com/AsamK/RetroShare","homepage":null,"size":74431,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RetroShare:master","ref":"master","sha":"de92c06f0b9bd79cfe7a5ab8a65487b295d5f08c","user":{"login":"RetroShare","id":5185222,"avatar_url":"https://avatars.githubusercontent.com/u/5185222?v=3","gravatar_id":"","url":"https://api.github.com/users/RetroShare","html_url":"https://github.com/RetroShare","followers_url":"https://api.github.com/users/RetroShare/followers","following_url":"https://api.github.com/users/RetroShare/following{/other_user}","gists_url":"https://api.github.com/users/RetroShare/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroShare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroShare/subscriptions","organizations_url":"https://api.github.com/users/RetroShare/orgs","repos_url":"https://api.github.com/users/RetroShare/repos","events_url":"https://api.github.com/users/RetroShare/events{/privacy}","received_events_url":"https://api.github.com/users/RetroShare/received_events","type":"Organization","site_admin":false},"repo":{"id":40011265,"name":"RetroShare","full_name":"RetroShare/RetroShare","owner":{"login":"RetroShare","id":5185222,"avatar_url":"https://avatars.githubusercontent.com/u/5185222?v=3","gravatar_id":"","url":"https://api.github.com/users/RetroShare","html_url":"https://github.com/RetroShare","followers_url":"https://api.github.com/users/RetroShare/followers","following_url":"https://api.github.com/users/RetroShare/following{/other_user}","gists_url":"https://api.github.com/users/RetroShare/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroShare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroShare/subscriptions","organizations_url":"https://api.github.com/users/RetroShare/orgs","repos_url":"https://api.github.com/users/RetroShare/repos","events_url":"https://api.github.com/users/RetroShare/events{/privacy}","received_events_url":"https://api.github.com/users/RetroShare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RetroShare/RetroShare","description":"RetroShare is a Free and Open Source cross-platform, Friend-2-Friend and secure decentralised communication platform. (upstream Repository)","fork":false,"url":"https://api.github.com/repos/RetroShare/RetroShare","forks_url":"https://api.github.com/repos/RetroShare/RetroShare/forks","keys_url":"https://api.github.com/repos/RetroShare/RetroShare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RetroShare/RetroShare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RetroShare/RetroShare/teams","hooks_url":"https://api.github.com/repos/RetroShare/RetroShare/hooks","issue_events_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/events{/number}","events_url":"https://api.github.com/repos/RetroShare/RetroShare/events","assignees_url":"https://api.github.com/repos/RetroShare/RetroShare/assignees{/user}","branches_url":"https://api.github.com/repos/RetroShare/RetroShare/branches{/branch}","tags_url":"https://api.github.com/repos/RetroShare/RetroShare/tags","blobs_url":"https://api.github.com/repos/RetroShare/RetroShare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RetroShare/RetroShare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RetroShare/RetroShare/git/refs{/sha}","trees_url":"https://api.github.com/repos/RetroShare/RetroShare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RetroShare/RetroShare/statuses/{sha}","languages_url":"https://api.github.com/repos/RetroShare/RetroShare/languages","stargazers_url":"https://api.github.com/repos/RetroShare/RetroShare/stargazers","contributors_url":"https://api.github.com/repos/RetroShare/RetroShare/contributors","subscribers_url":"https://api.github.com/repos/RetroShare/RetroShare/subscribers","subscription_url":"https://api.github.com/repos/RetroShare/RetroShare/subscription","commits_url":"https://api.github.com/repos/RetroShare/RetroShare/commits{/sha}","git_commits_url":"https://api.github.com/repos/RetroShare/RetroShare/git/commits{/sha}","comments_url":"https://api.github.com/repos/RetroShare/RetroShare/comments{/number}","issue_comment_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/comments{/number}","contents_url":"https://api.github.com/repos/RetroShare/RetroShare/contents/{+path}","compare_url":"https://api.github.com/repos/RetroShare/RetroShare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RetroShare/RetroShare/merges","archive_url":"https://api.github.com/repos/RetroShare/RetroShare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RetroShare/RetroShare/downloads","issues_url":"https://api.github.com/repos/RetroShare/RetroShare/issues{/number}","pulls_url":"https://api.github.com/repos/RetroShare/RetroShare/pulls{/number}","milestones_url":"https://api.github.com/repos/RetroShare/RetroShare/milestones{/number}","notifications_url":"https://api.github.com/repos/RetroShare/RetroShare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RetroShare/RetroShare/labels{/name}","releases_url":"https://api.github.com/repos/RetroShare/RetroShare/releases{/id}","created_at":"2015-07-31T15:16:42Z","updated_at":"2015-08-31T11:34:47Z","pushed_at":"2015-08-31T18:11:46Z","git_url":"git://github.com/RetroShare/RetroShare.git","ssh_url":"git@github.com:RetroShare/RetroShare.git","clone_url":"https://github.com/RetroShare/RetroShare.git","svn_url":"https://github.com/RetroShare/RetroShare","homepage":"http://retroshare.org/","size":84776,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":18,"forks":13,"open_issues":18,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/63"},"html":{"href":"https://github.com/RetroShare/RetroShare/pull/63"},"issue":{"href":"https://api.github.com/repos/RetroShare/RetroShare/issues/63"},"comments":{"href":"https://api.github.com/repos/RetroShare/RetroShare/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RetroShare/RetroShare/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/RetroShare/RetroShare/statuses/cfde9d303cc5baa5c96d48b608905dfb78ace843"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"csoler","id":329008,"avatar_url":"https://avatars.githubusercontent.com/u/329008?v=3","gravatar_id":"","url":"https://api.github.com/users/csoler","html_url":"https://github.com/csoler","followers_url":"https://api.github.com/users/csoler/followers","following_url":"https://api.github.com/users/csoler/following{/other_user}","gists_url":"https://api.github.com/users/csoler/gists{/gist_id}","starred_url":"https://api.github.com/users/csoler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csoler/subscriptions","organizations_url":"https://api.github.com/users/csoler/orgs","repos_url":"https://api.github.com/users/csoler/repos","events_url":"https://api.github.com/users/csoler/events{/privacy}","received_events_url":"https://api.github.com/users/csoler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":19,"deletions":20,"changed_files":4}}