{"action":"closed","number":942,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/942","id":43563966,"html_url":"https://github.com/cfpb/cfgov-refresh/pull/942","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/942.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/942.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/942","number":942,"state":"closed","locked":false,"title":"New form macros","user":{"login":"KimberlyMunoz","id":1860176,"avatar_url":"https://avatars.githubusercontent.com/u/1860176?v=3","gravatar_id":"","url":"https://api.github.com/users/KimberlyMunoz","html_url":"https://github.com/KimberlyMunoz","followers_url":"https://api.github.com/users/KimberlyMunoz/followers","following_url":"https://api.github.com/users/KimberlyMunoz/following{/other_user}","gists_url":"https://api.github.com/users/KimberlyMunoz/gists{/gist_id}","starred_url":"https://api.github.com/users/KimberlyMunoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KimberlyMunoz/subscriptions","organizations_url":"https://api.github.com/users/KimberlyMunoz/orgs","repos_url":"https://api.github.com/users/KimberlyMunoz/repos","events_url":"https://api.github.com/users/KimberlyMunoz/events{/privacy}","received_events_url":"https://api.github.com/users/KimberlyMunoz/received_events","type":"User","site_admin":false},"body":"Created macros for reusable form patterns across forms. This will make it easier to keep our forms consistent and make changes in a consistent way.\r\n\r\n## Additions\r\n\r\n- All new macros for forms patterns and commonly used form fields\r\n\r\n## Changes\r\n\r\n- Replaced hard-coded forms with macros where possible\r\n- Added some code to make required fields more noticeable on screenreaders.\r\n\r\n## Testing\r\n\r\n- Visit all the pages with forms. \r\n  - http://localhost:7000/sub-pages/accessibility-feedback-form.html\r\n  - http://localhost:7000/sub-pages/amending-and-correcting-records-under-the-privacy-act-form.html\r\n  - http://localhost:7000/sub-pages/file-a-privacy-complaint-form.html\r\n  - http://localhost:7000/sub-pages/form-eeo-issue.html\r\n  - http://localhost:7000/sub-pages/plain-writing-feedback-form.html\r\n\r\n## Review\r\n\r\n- @sebworks \r\n- @anselmbradford \r\n- @jimmynotjim \r\n\r\n## Preview\r\n\r\n[Preview this PR without the whitespace changes](?w=0)\r\n\r\n## Notes\r\n\r\n- Radio buttons that show or hide fields based on what's selected are still hardcoded.\r\n- I couldn't figure out if I could pass through HTML as a macro parameter (seemed like a bad idea) for labels with links in them.","created_at":"2015-08-27T20:39:06Z","updated_at":"2015-09-09T16:35:52Z","closed_at":"2015-09-09T16:35:52Z","merged_at":"2015-09-09T16:35:52Z","merge_commit_sha":"615327462de74d1e9732ae3c635c0dc79e6ba842","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/942/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/942/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/942/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/32da92c380a0af55a73a4fecf81502465063d65c","head":{"label":"cfpb:new-form-macros","ref":"new-form-macros","sha":"32da92c380a0af55a73a4fecf81502465063d65c","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2015-07-16T17:30:22Z","pushed_at":"2015-09-09T16:35:53Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":100104,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":96,"forks":18,"open_issues":96,"watchers":9,"default_branch":"flapjack"}},"base":{"label":"cfpb:flapjack","ref":"flapjack","sha":"89fdaf8e20c66290e8ddb1ea3792f9d7e5ccd717","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2015-07-16T17:30:22Z","pushed_at":"2015-09-09T16:35:53Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":100104,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":96,"forks":18,"open_issues":96,"watchers":9,"default_branch":"flapjack"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/942"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/942"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/942"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/32da92c380a0af55a73a4fecf81502465063d65c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"KimberlyMunoz","id":1860176,"avatar_url":"https://avatars.githubusercontent.com/u/1860176?v=3","gravatar_id":"","url":"https://api.github.com/users/KimberlyMunoz","html_url":"https://github.com/KimberlyMunoz","followers_url":"https://api.github.com/users/KimberlyMunoz/followers","following_url":"https://api.github.com/users/KimberlyMunoz/following{/other_user}","gists_url":"https://api.github.com/users/KimberlyMunoz/gists{/gist_id}","starred_url":"https://api.github.com/users/KimberlyMunoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KimberlyMunoz/subscriptions","organizations_url":"https://api.github.com/users/KimberlyMunoz/orgs","repos_url":"https://api.github.com/users/KimberlyMunoz/repos","events_url":"https://api.github.com/users/KimberlyMunoz/events{/privacy}","received_events_url":"https://api.github.com/users/KimberlyMunoz/received_events","type":"User","site_admin":false},"comments":5,"review_comments":55,"commits":2,"additions":616,"deletions":830,"changed_files":9}}