{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/gcstaublin/pregame/pulls/18","id":48918695,"html_url":"https://github.com/gcstaublin/pregame/pull/18","diff_url":"https://github.com/gcstaublin/pregame/pull/18.diff","patch_url":"https://github.com/gcstaublin/pregame/pull/18.patch","issue_url":"https://api.github.com/repos/gcstaublin/pregame/issues/18","number":18,"state":"closed","locked":false,"title":"Svg","user":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"body":"## What this did\r\n\r\nProof of concept for a SVG workflow. When you type `gulp svg`, all svg located inside the `icons` folder will be combined into one file and inject into the html document, just above the opening `<body>` tag.\r\n\r\nThen inside your html you call svgs using the ID of that icon like so:\r\n\r\n```\r\n<span class=\"icon__container space-right--sm\">\r\n  <svg aria-hidden=\"true\" class=\"icon icon--sm\">\r\n    <use xlink:href=\"#icons_upload\"></use>\r\n  </svg>\r\n  <span class=\"assistive-text\">Text goes here</span>\r\n</span>\r\n```\r\n\r\n## How I did this\r\nI took 10 icons from the master SVG sheet and normalized their size to a consistent canvas. I actually copied each of these icons into Illustrator, then exported each and put them into the `icons` folder.\r\n\r\nThe gulp task uses `gulp-svgstore`, `gulp-inject`, 'gulp-cheerio` to combine the svgs and inject them into the html.\r\n\r\n## To test this out\r\nInstall the gulp dependencies\r\n`npm install`\r\n\r\nRun the gulp task\r\n`gulp svg`\r\n\r\nNOTE: The SVG sprite will already exist inside the html document. So you might experiment with adding another icon to the icons folder, as well as to your html to see the magic happen.\r\n\r\n## Questions\r\n  1. How would this work inside an actual build process?\r\n  1. Rather than having ALL icons injected into our documents, which would become unwieldy, how can we make separate sprite that would work for needs of different clusters. Unfortunately, linking to external files, an SVG file outside the document, doesn't work in any versions of IE.\r\n  1. This assumes SVGs that are normalized. How do we get there?\r\n  1. Other questions.","created_at":"2015-10-27T19:16:47Z","updated_at":"2015-10-28T17:31:21Z","closed_at":"2015-10-28T17:31:21Z","merged_at":"2015-10-28T17:31:21Z","merge_commit_sha":"078376923747df80883b5811c15dc56cf6bacef8","assignee":{"login":"mfouquet","id":7400740,"avatar_url":"https://avatars.githubusercontent.com/u/7400740?v=3","gravatar_id":"","url":"https://api.github.com/users/mfouquet","html_url":"https://github.com/mfouquet","followers_url":"https://api.github.com/users/mfouquet/followers","following_url":"https://api.github.com/users/mfouquet/following{/other_user}","gists_url":"https://api.github.com/users/mfouquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mfouquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfouquet/subscriptions","organizations_url":"https://api.github.com/users/mfouquet/orgs","repos_url":"https://api.github.com/users/mfouquet/repos","events_url":"https://api.github.com/users/mfouquet/events{/privacy}","received_events_url":"https://api.github.com/users/mfouquet/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/gcstaublin/pregame/pulls/18/commits","review_comments_url":"https://api.github.com/repos/gcstaublin/pregame/pulls/18/comments","review_comment_url":"https://api.github.com/repos/gcstaublin/pregame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcstaublin/pregame/issues/18/comments","statuses_url":"https://api.github.com/repos/gcstaublin/pregame/statuses/37160328d85cecff0b6794ec66374dee07891c9d","head":{"label":"gcstaublin:svg","ref":"svg","sha":"37160328d85cecff0b6794ec66374dee07891c9d","user":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"repo":{"id":43843243,"name":"pregame","full_name":"gcstaublin/pregame","owner":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcstaublin/pregame","description":"","fork":false,"url":"https://api.github.com/repos/gcstaublin/pregame","forks_url":"https://api.github.com/repos/gcstaublin/pregame/forks","keys_url":"https://api.github.com/repos/gcstaublin/pregame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcstaublin/pregame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcstaublin/pregame/teams","hooks_url":"https://api.github.com/repos/gcstaublin/pregame/hooks","issue_events_url":"https://api.github.com/repos/gcstaublin/pregame/issues/events{/number}","events_url":"https://api.github.com/repos/gcstaublin/pregame/events","assignees_url":"https://api.github.com/repos/gcstaublin/pregame/assignees{/user}","branches_url":"https://api.github.com/repos/gcstaublin/pregame/branches{/branch}","tags_url":"https://api.github.com/repos/gcstaublin/pregame/tags","blobs_url":"https://api.github.com/repos/gcstaublin/pregame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcstaublin/pregame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcstaublin/pregame/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcstaublin/pregame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcstaublin/pregame/statuses/{sha}","languages_url":"https://api.github.com/repos/gcstaublin/pregame/languages","stargazers_url":"https://api.github.com/repos/gcstaublin/pregame/stargazers","contributors_url":"https://api.github.com/repos/gcstaublin/pregame/contributors","subscribers_url":"https://api.github.com/repos/gcstaublin/pregame/subscribers","subscription_url":"https://api.github.com/repos/gcstaublin/pregame/subscription","commits_url":"https://api.github.com/repos/gcstaublin/pregame/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcstaublin/pregame/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcstaublin/pregame/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcstaublin/pregame/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcstaublin/pregame/contents/{+path}","compare_url":"https://api.github.com/repos/gcstaublin/pregame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcstaublin/pregame/merges","archive_url":"https://api.github.com/repos/gcstaublin/pregame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcstaublin/pregame/downloads","issues_url":"https://api.github.com/repos/gcstaublin/pregame/issues{/number}","pulls_url":"https://api.github.com/repos/gcstaublin/pregame/pulls{/number}","milestones_url":"https://api.github.com/repos/gcstaublin/pregame/milestones{/number}","notifications_url":"https://api.github.com/repos/gcstaublin/pregame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcstaublin/pregame/labels{/name}","releases_url":"https://api.github.com/repos/gcstaublin/pregame/releases{/id}","created_at":"2015-10-07T20:35:21Z","updated_at":"2015-10-07T20:36:05Z","pushed_at":"2015-10-28T17:31:21Z","git_url":"git://github.com/gcstaublin/pregame.git","ssh_url":"git@github.com:gcstaublin/pregame.git","clone_url":"https://github.com/gcstaublin/pregame.git","svn_url":"https://github.com/gcstaublin/pregame","homepage":null,"size":244,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"gcstaublin:master","ref":"master","sha":"167c120cd98b953688e43cbb0e18cf3b8f199a22","user":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"repo":{"id":43843243,"name":"pregame","full_name":"gcstaublin/pregame","owner":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcstaublin/pregame","description":"","fork":false,"url":"https://api.github.com/repos/gcstaublin/pregame","forks_url":"https://api.github.com/repos/gcstaublin/pregame/forks","keys_url":"https://api.github.com/repos/gcstaublin/pregame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcstaublin/pregame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcstaublin/pregame/teams","hooks_url":"https://api.github.com/repos/gcstaublin/pregame/hooks","issue_events_url":"https://api.github.com/repos/gcstaublin/pregame/issues/events{/number}","events_url":"https://api.github.com/repos/gcstaublin/pregame/events","assignees_url":"https://api.github.com/repos/gcstaublin/pregame/assignees{/user}","branches_url":"https://api.github.com/repos/gcstaublin/pregame/branches{/branch}","tags_url":"https://api.github.com/repos/gcstaublin/pregame/tags","blobs_url":"https://api.github.com/repos/gcstaublin/pregame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcstaublin/pregame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcstaublin/pregame/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcstaublin/pregame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcstaublin/pregame/statuses/{sha}","languages_url":"https://api.github.com/repos/gcstaublin/pregame/languages","stargazers_url":"https://api.github.com/repos/gcstaublin/pregame/stargazers","contributors_url":"https://api.github.com/repos/gcstaublin/pregame/contributors","subscribers_url":"https://api.github.com/repos/gcstaublin/pregame/subscribers","subscription_url":"https://api.github.com/repos/gcstaublin/pregame/subscription","commits_url":"https://api.github.com/repos/gcstaublin/pregame/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcstaublin/pregame/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcstaublin/pregame/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcstaublin/pregame/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcstaublin/pregame/contents/{+path}","compare_url":"https://api.github.com/repos/gcstaublin/pregame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcstaublin/pregame/merges","archive_url":"https://api.github.com/repos/gcstaublin/pregame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcstaublin/pregame/downloads","issues_url":"https://api.github.com/repos/gcstaublin/pregame/issues{/number}","pulls_url":"https://api.github.com/repos/gcstaublin/pregame/pulls{/number}","milestones_url":"https://api.github.com/repos/gcstaublin/pregame/milestones{/number}","notifications_url":"https://api.github.com/repos/gcstaublin/pregame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcstaublin/pregame/labels{/name}","releases_url":"https://api.github.com/repos/gcstaublin/pregame/releases{/id}","created_at":"2015-10-07T20:35:21Z","updated_at":"2015-10-07T20:36:05Z","pushed_at":"2015-10-28T17:31:21Z","git_url":"git://github.com/gcstaublin/pregame.git","ssh_url":"git@github.com:gcstaublin/pregame.git","clone_url":"https://github.com/gcstaublin/pregame.git","svn_url":"https://github.com/gcstaublin/pregame","homepage":null,"size":244,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gcstaublin/pregame/pulls/18"},"html":{"href":"https://github.com/gcstaublin/pregame/pull/18"},"issue":{"href":"https://api.github.com/repos/gcstaublin/pregame/issues/18"},"comments":{"href":"https://api.github.com/repos/gcstaublin/pregame/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/gcstaublin/pregame/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/gcstaublin/pregame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcstaublin/pregame/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/gcstaublin/pregame/statuses/37160328d85cecff0b6794ec66374dee07891c9d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":868,"deletions":21,"changed_files":19}}