{"action":"opened","number":23,"pull_request":{"url":"https://api.github.com/repos/nttcom/peerjs/pulls/23","id":35480318,"html_url":"https://github.com/nttcom/peerjs/pull/23","diff_url":"https://github.com/nttcom/peerjs/pull/23.diff","patch_url":"https://github.com/nttcom/peerjs/pull/23.patch","issue_url":"https://api.github.com/repos/nttcom/peerjs/issues/23","number":23,"state":"open","locked":false,"title":"fix socket.destroy to not start xhr. closes #21","user":{"login":"alanmshelly","id":2532867,"avatar_url":"https://avatars.githubusercontent.com/u/2532867?v=3","gravatar_id":"","url":"https://api.github.com/users/alanmshelly","html_url":"https://github.com/alanmshelly","followers_url":"https://api.github.com/users/alanmshelly/followers","following_url":"https://api.github.com/users/alanmshelly/following{/other_user}","gists_url":"https://api.github.com/users/alanmshelly/gists{/gist_id}","starred_url":"https://api.github.com/users/alanmshelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanmshelly/subscriptions","organizations_url":"https://api.github.com/users/alanmshelly/orgs","repos_url":"https://api.github.com/users/alanmshelly/repos","events_url":"https://api.github.com/users/alanmshelly/events{/privacy}","received_events_url":"https://api.github.com/users/alanmshelly/received_events","type":"User","site_admin":false},"body":"確認方法\r\n\r\ndestroyの確認\r\n```\r\npeer.listAllPeers(function(list){console.log(list)}) //自分のpeeridが入ってることを確認\r\npeer.destroy() //wsとhttpを切断 (dev toolのネットワーク画面でXHRを確認)\r\npeer.socket.disconnected === true //peerのステートを確認\r\npeer.listAllPeers(function(list){console.log(list)}) //自分のpeeridが入っていないことを確認\r\n```\r\n\r\nWSが切れたらxhrにフォールバックする確認\r\n```\r\npeer.listAllPeers(function(list){console.log(list)}) //自分のpeeridが入ってることを確認\r\npeer.socket._socket.close() //wsを切断 (dev toolのネットワーク画面でXHRを確認)\r\npeer.socket.disconnected === false //peerのステートを確認\r\npeer.listAllPeers(function(list){console.log(list)}) //自分のpeeridが入ってることを確認\r\n```","created_at":"2015-05-15T02:31:59Z","updated_at":"2015-05-15T02:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55814bcacea465b1bc49f96154197fce40fec698","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nttcom/peerjs/pulls/23/commits","review_comments_url":"https://api.github.com/repos/nttcom/peerjs/pulls/23/comments","review_comment_url":"https://api.github.com/repos/nttcom/peerjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nttcom/peerjs/issues/23/comments","statuses_url":"https://api.github.com/repos/nttcom/peerjs/statuses/e613bfecb559cc792c9159acda5ec889877ceedf","head":{"label":"nttcom:destroy_xhr_bug","ref":"destroy_xhr_bug","sha":"e613bfecb559cc792c9159acda5ec889877ceedf","user":{"login":"nttcom","id":1182318,"avatar_url":"https://avatars.githubusercontent.com/u/1182318?v=3","gravatar_id":"","url":"https://api.github.com/users/nttcom","html_url":"https://github.com/nttcom","followers_url":"https://api.github.com/users/nttcom/followers","following_url":"https://api.github.com/users/nttcom/following{/other_user}","gists_url":"https://api.github.com/users/nttcom/gists{/gist_id}","starred_url":"https://api.github.com/users/nttcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nttcom/subscriptions","organizations_url":"https://api.github.com/users/nttcom/orgs","repos_url":"https://api.github.com/users/nttcom/repos","events_url":"https://api.github.com/users/nttcom/events{/privacy}","received_events_url":"https://api.github.com/users/nttcom/received_events","type":"Organization","site_admin":false},"repo":{"id":14939516,"name":"peerjs","full_name":"nttcom/peerjs","owner":{"login":"nttcom","id":1182318,"avatar_url":"https://avatars.githubusercontent.com/u/1182318?v=3","gravatar_id":"","url":"https://api.github.com/users/nttcom","html_url":"https://github.com/nttcom","followers_url":"https://api.github.com/users/nttcom/followers","following_url":"https://api.github.com/users/nttcom/following{/other_user}","gists_url":"https://api.github.com/users/nttcom/gists{/gist_id}","starred_url":"https://api.github.com/users/nttcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nttcom/subscriptions","organizations_url":"https://api.github.com/users/nttcom/orgs","repos_url":"https://api.github.com/users/nttcom/repos","events_url":"https://api.github.com/users/nttcom/events{/privacy}","received_events_url":"https://api.github.com/users/nttcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nttcom/peerjs","description":"SkyWay対応版のPeerJS","fork":true,"url":"https://api.github.com/repos/nttcom/peerjs","forks_url":"https://api.github.com/repos/nttcom/peerjs/forks","keys_url":"https://api.github.com/repos/nttcom/peerjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nttcom/peerjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nttcom/peerjs/teams","hooks_url":"https://api.github.com/repos/nttcom/peerjs/hooks","issue_events_url":"https://api.github.com/repos/nttcom/peerjs/issues/events{/number}","events_url":"https://api.github.com/repos/nttcom/peerjs/events","assignees_url":"https://api.github.com/repos/nttcom/peerjs/assignees{/user}","branches_url":"https://api.github.com/repos/nttcom/peerjs/branches{/branch}","tags_url":"https://api.github.com/repos/nttcom/peerjs/tags","blobs_url":"https://api.github.com/repos/nttcom/peerjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nttcom/peerjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nttcom/peerjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nttcom/peerjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nttcom/peerjs/statuses/{sha}","languages_url":"https://api.github.com/repos/nttcom/peerjs/languages","stargazers_url":"https://api.github.com/repos/nttcom/peerjs/stargazers","contributors_url":"https://api.github.com/repos/nttcom/peerjs/contributors","subscribers_url":"https://api.github.com/repos/nttcom/peerjs/subscribers","subscription_url":"https://api.github.com/repos/nttcom/peerjs/subscription","commits_url":"https://api.github.com/repos/nttcom/peerjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nttcom/peerjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nttcom/peerjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nttcom/peerjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nttcom/peerjs/contents/{+path}","compare_url":"https://api.github.com/repos/nttcom/peerjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nttcom/peerjs/merges","archive_url":"https://api.github.com/repos/nttcom/peerjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nttcom/peerjs/downloads","issues_url":"https://api.github.com/repos/nttcom/peerjs/issues{/number}","pulls_url":"https://api.github.com/repos/nttcom/peerjs/pulls{/number}","milestones_url":"https://api.github.com/repos/nttcom/peerjs/milestones{/number}","notifications_url":"https://api.github.com/repos/nttcom/peerjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nttcom/peerjs/labels{/name}","releases_url":"https://api.github.com/repos/nttcom/peerjs/releases{/id}","created_at":"2013-12-05T00:04:44Z","updated_at":"2015-05-14T09:38:24Z","pushed_at":"2015-05-15T02:31:59Z","git_url":"git://github.com/nttcom/peerjs.git","ssh_url":"git@github.com:nttcom/peerjs.git","clone_url":"https://github.com/nttcom/peerjs.git","svn_url":"https://github.com/nttcom/peerjs","homepage":"http://nttcom.github.io/skyway/","size":2045,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":4,"forks":34,"open_issues":4,"watchers":127,"default_branch":"master"}},"base":{"label":"nttcom:master","ref":"master","sha":"f509ed4aed5e4326bac73c963ef56040be613c56","user":{"login":"nttcom","id":1182318,"avatar_url":"https://avatars.githubusercontent.com/u/1182318?v=3","gravatar_id":"","url":"https://api.github.com/users/nttcom","html_url":"https://github.com/nttcom","followers_url":"https://api.github.com/users/nttcom/followers","following_url":"https://api.github.com/users/nttcom/following{/other_user}","gists_url":"https://api.github.com/users/nttcom/gists{/gist_id}","starred_url":"https://api.github.com/users/nttcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nttcom/subscriptions","organizations_url":"https://api.github.com/users/nttcom/orgs","repos_url":"https://api.github.com/users/nttcom/repos","events_url":"https://api.github.com/users/nttcom/events{/privacy}","received_events_url":"https://api.github.com/users/nttcom/received_events","type":"Organization","site_admin":false},"repo":{"id":14939516,"name":"peerjs","full_name":"nttcom/peerjs","owner":{"login":"nttcom","id":1182318,"avatar_url":"https://avatars.githubusercontent.com/u/1182318?v=3","gravatar_id":"","url":"https://api.github.com/users/nttcom","html_url":"https://github.com/nttcom","followers_url":"https://api.github.com/users/nttcom/followers","following_url":"https://api.github.com/users/nttcom/following{/other_user}","gists_url":"https://api.github.com/users/nttcom/gists{/gist_id}","starred_url":"https://api.github.com/users/nttcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nttcom/subscriptions","organizations_url":"https://api.github.com/users/nttcom/orgs","repos_url":"https://api.github.com/users/nttcom/repos","events_url":"https://api.github.com/users/nttcom/events{/privacy}","received_events_url":"https://api.github.com/users/nttcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nttcom/peerjs","description":"SkyWay対応版のPeerJS","fork":true,"url":"https://api.github.com/repos/nttcom/peerjs","forks_url":"https://api.github.com/repos/nttcom/peerjs/forks","keys_url":"https://api.github.com/repos/nttcom/peerjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nttcom/peerjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nttcom/peerjs/teams","hooks_url":"https://api.github.com/repos/nttcom/peerjs/hooks","issue_events_url":"https://api.github.com/repos/nttcom/peerjs/issues/events{/number}","events_url":"https://api.github.com/repos/nttcom/peerjs/events","assignees_url":"https://api.github.com/repos/nttcom/peerjs/assignees{/user}","branches_url":"https://api.github.com/repos/nttcom/peerjs/branches{/branch}","tags_url":"https://api.github.com/repos/nttcom/peerjs/tags","blobs_url":"https://api.github.com/repos/nttcom/peerjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nttcom/peerjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nttcom/peerjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nttcom/peerjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nttcom/peerjs/statuses/{sha}","languages_url":"https://api.github.com/repos/nttcom/peerjs/languages","stargazers_url":"https://api.github.com/repos/nttcom/peerjs/stargazers","contributors_url":"https://api.github.com/repos/nttcom/peerjs/contributors","subscribers_url":"https://api.github.com/repos/nttcom/peerjs/subscribers","subscription_url":"https://api.github.com/repos/nttcom/peerjs/subscription","commits_url":"https://api.github.com/repos/nttcom/peerjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nttcom/peerjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nttcom/peerjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nttcom/peerjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nttcom/peerjs/contents/{+path}","compare_url":"https://api.github.com/repos/nttcom/peerjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nttcom/peerjs/merges","archive_url":"https://api.github.com/repos/nttcom/peerjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nttcom/peerjs/downloads","issues_url":"https://api.github.com/repos/nttcom/peerjs/issues{/number}","pulls_url":"https://api.github.com/repos/nttcom/peerjs/pulls{/number}","milestones_url":"https://api.github.com/repos/nttcom/peerjs/milestones{/number}","notifications_url":"https://api.github.com/repos/nttcom/peerjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nttcom/peerjs/labels{/name}","releases_url":"https://api.github.com/repos/nttcom/peerjs/releases{/id}","created_at":"2013-12-05T00:04:44Z","updated_at":"2015-05-14T09:38:24Z","pushed_at":"2015-05-15T02:31:59Z","git_url":"git://github.com/nttcom/peerjs.git","ssh_url":"git@github.com:nttcom/peerjs.git","clone_url":"https://github.com/nttcom/peerjs.git","svn_url":"https://github.com/nttcom/peerjs","homepage":"http://nttcom.github.io/skyway/","size":2045,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":4,"forks":34,"open_issues":4,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nttcom/peerjs/pulls/23"},"html":{"href":"https://github.com/nttcom/peerjs/pull/23"},"issue":{"href":"https://api.github.com/repos/nttcom/peerjs/issues/23"},"comments":{"href":"https://api.github.com/repos/nttcom/peerjs/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/nttcom/peerjs/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/nttcom/peerjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nttcom/peerjs/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/nttcom/peerjs/statuses/e613bfecb559cc792c9159acda5ec889877ceedf"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":20,"changed_files":3}}