{"action":"created","issue":{"url":"https://api.github.com/repos/pyca/pyopenssl/issues/244","labels_url":"https://api.github.com/repos/pyca/pyopenssl/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/pyca/pyopenssl/issues/244/comments","events_url":"https://api.github.com/repos/pyca/pyopenssl/issues/244/events","html_url":"https://github.com/pyca/pyopenssl/pull/244","id":71176009,"number":244,"title":"Add support for querying the negotiated TLS version.  The Quickening","user":{"login":"elitest","id":5925087,"avatar_url":"https://avatars.githubusercontent.com/u/5925087?v=3","gravatar_id":"","url":"https://api.github.com/users/elitest","html_url":"https://github.com/elitest","followers_url":"https://api.github.com/users/elitest/followers","following_url":"https://api.github.com/users/elitest/following{/other_user}","gists_url":"https://api.github.com/users/elitest/gists{/gist_id}","starred_url":"https://api.github.com/users/elitest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elitest/subscriptions","organizations_url":"https://api.github.com/users/elitest/orgs","repos_url":"https://api.github.com/users/elitest/repos","events_url":"https://api.github.com/users/elitest/events{/privacy}","received_events_url":"https://api.github.com/users/elitest/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-04-27T04:39:01Z","updated_at":"2015-05-05T16:31:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyca/pyopenssl/pulls/244","html_url":"https://github.com/pyca/pyopenssl/pull/244","diff_url":"https://github.com/pyca/pyopenssl/pull/244.diff","patch_url":"https://github.com/pyca/pyopenssl/pull/244.patch"},"body":"This PR hopefully finished up the work done by @richmoore in #184.  Thanks to @alex for helping me figure out how to get SSL_get_version implemented.  This PR requires the merge that happened in pyca/cryptography#1869, so do we wait until the next release of cryptography and then bump the required version number in setup.py?\r\n\r\nI'm happy to hear feedback on whether the change to strings requires better/different testing?\r\n\r\nAlso the [OpenSSL docs](https://www.openssl.org/docs/ssl/SSL_get_version.html) have been updated since the original PR in January, and this does actually support TLS1.1 and TLS1.2 :)"},"comment":{"url":"https://api.github.com/repos/pyca/pyopenssl/issues/comments/99133301","html_url":"https://github.com/pyca/pyopenssl/pull/244#issuecomment-99133301","issue_url":"https://api.github.com/repos/pyca/pyopenssl/issues/244","id":99133301,"user":{"login":"hynek","id":41240,"avatar_url":"https://avatars.githubusercontent.com/u/41240?v=3","gravatar_id":"","url":"https://api.github.com/users/hynek","html_url":"https://github.com/hynek","followers_url":"https://api.github.com/users/hynek/followers","following_url":"https://api.github.com/users/hynek/following{/other_user}","gists_url":"https://api.github.com/users/hynek/gists{/gist_id}","starred_url":"https://api.github.com/users/hynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hynek/subscriptions","organizations_url":"https://api.github.com/users/hynek/orgs","repos_url":"https://api.github.com/users/hynek/repos","events_url":"https://api.github.com/users/hynek/events{/privacy}","received_events_url":"https://api.github.com/users/hynek/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T16:31:59Z","updated_at":"2015-05-05T16:31:59Z","body":"Also, until cryptography 0.9 is out, we can bikeshed on the return type.\r\n\r\nMy impression is, that pyOpenSSL is bytes only.  If you’d like to argue for unicode I would like to ask you for precedents.\r\n\r\npyOpenSSL is supposed to by a low-level layer around OpenSSL so I’m very apprehensive to introduce unicode-based APIs.  We’ve just added a ton of warning if certain methods are called with unicode."}}