{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/38792824","id":38792824,"diff_hunk":"@@ -409,41 +389,39 @@ namespace edm\n   // Indicate if any bit in the trigger results matches the desired value\n   // at that position, based on the Bits array.  If s is Exception, this\n   // looks for a Exceptionmatch; otherwise, true-->Pass, false-->Fail.\n-  bool \n-  EventSelector::acceptOneBit(Bits const& b, \n-    \t\t       \t       HLTGlobalStatus const& tr, \n+  bool\n+  EventSelector::acceptOneBit(Bits const& b,\n+    \t\t       \t       HLTGlobalStatus const& tr,\n     \t\t               hlt::HLTState const& s) const\n   {\n     bool lookForException = (s == hlt::Exception);\n     Bits::const_iterator i(b.begin());\n     Bits::const_iterator e(b.end());","path":"FWCore/Framework/src/EventSelector.cc","position":504,"original_position":504,"commit_id":"f2a0a67bed7455a674cac8c099208b2f4b809158","original_commit_id":"f2a0a67bed7455a674cac8c099208b2f4b809158","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"body":"Chris,\r\n    Just an oversight. I will remove them when you let me know that you have no other suggested changes, or in a half hour or so if I don't hear from you.","created_at":"2015-09-04T20:51:23Z","updated_at":"2015-09-04T20:51:23Z","html_url":"https://github.com/cms-sw/cmssw/pull/11143#discussion_r38792824","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/38792824"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11143#discussion_r38792824"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143","id":44247408,"html_url":"https://github.com/cms-sw/cmssw/pull/11143","diff_url":"https://github.com/cms-sw/cmssw/pull/11143.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11143.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11143","number":11143,"state":"open","locked":false,"title":"Maintainability cleanup for EventSelector","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"body":"This PR is a cleanup of the EventSelector class for maintainability and clarity. The changes include:\r\n1) Removing one unused and one unnecessary data member.\r\n2) Renaming some data members, function members, and function parameters to be more mnemonic\r\n3) The three data members that are never changed are made const (more for clarity than for const correctness) and initialized in the initializer lists of the class. They are no longer modified in init() (renamed to initPathNames()), because they were just being reset to the same values.\r\n4) The three const data members are the first three data members.\r\n5) Iterator loops are changed to range for loops.","created_at":"2015-09-04T18:24:31Z","updated_at":"2015-09-04T20:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f892cd397439bad22141850f081415d4203fb90","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":93,"closed_issues":571,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-09-04T19:51:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11143/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/f2a0a67bed7455a674cac8c099208b2f4b809158","head":{"label":"wmtan:EventSelectorCleanup","ref":"EventSelectorCleanup","sha":"f2a0a67bed7455a674cac8c099208b2f4b809158","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"repo":{"id":10977262,"name":"cmssw","full_name":"wmtan/cmssw","owner":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmtan/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/wmtan/cmssw","forks_url":"https://api.github.com/repos/wmtan/cmssw/forks","keys_url":"https://api.github.com/repos/wmtan/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmtan/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmtan/cmssw/teams","hooks_url":"https://api.github.com/repos/wmtan/cmssw/hooks","issue_events_url":"https://api.github.com/repos/wmtan/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/wmtan/cmssw/events","assignees_url":"https://api.github.com/repos/wmtan/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/wmtan/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/wmtan/cmssw/tags","blobs_url":"https://api.github.com/repos/wmtan/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmtan/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmtan/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmtan/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmtan/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/wmtan/cmssw/languages","stargazers_url":"https://api.github.com/repos/wmtan/cmssw/stargazers","contributors_url":"https://api.github.com/repos/wmtan/cmssw/contributors","subscribers_url":"https://api.github.com/repos/wmtan/cmssw/subscribers","subscription_url":"https://api.github.com/repos/wmtan/cmssw/subscription","commits_url":"https://api.github.com/repos/wmtan/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmtan/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmtan/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmtan/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmtan/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/wmtan/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmtan/cmssw/merges","archive_url":"https://api.github.com/repos/wmtan/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmtan/cmssw/downloads","issues_url":"https://api.github.com/repos/wmtan/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/wmtan/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/wmtan/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/wmtan/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmtan/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/wmtan/cmssw/releases{/id}","created_at":"2013-06-26T19:44:14Z","updated_at":"2014-06-24T22:32:58Z","pushed_at":"2015-09-04T18:16:16Z","git_url":"git://github.com/wmtan/cmssw.git","ssh_url":"git@github.com:wmtan/cmssw.git","clone_url":"https://github.com/wmtan/cmssw.git","svn_url":"https://github.com/wmtan/cmssw","homepage":null,"size":699569,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_6_X","ref":"CMSSW_7_6_X","sha":"1e6f9b1a9deeabd990ec25f203391cb7135c238f","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-09-01T14:09:03Z","pushed_at":"2015-09-04T20:12:02Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1279721,"stargazers_count":258,"watchers_count":258,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1553,"mirror_url":null,"open_issues_count":227,"forks":1553,"open_issues":227,"watchers":258,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11143"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11143"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11143/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11143/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/f2a0a67bed7455a674cac8c099208b2f4b809158"}}}}