{"action":"closed","number":551,"pull_request":{"url":"https://api.github.com/repos/ddollar/foreman/pulls/551","id":33042637,"html_url":"https://github.com/ddollar/foreman/pull/551","diff_url":"https://github.com/ddollar/foreman/pull/551.diff","patch_url":"https://github.com/ddollar/foreman/pull/551.patch","issue_url":"https://api.github.com/repos/ddollar/foreman/issues/551","number":551,"state":"closed","locked":false,"title":"Fix Procfile#[] to return nil for non-existing entries","user":{"login":"sr","id":90,"avatar_url":"https://avatars.githubusercontent.com/u/90?v=3","gravatar_id":"","url":"https://api.github.com/users/sr","html_url":"https://github.com/sr","followers_url":"https://api.github.com/users/sr/followers","following_url":"https://api.github.com/users/sr/following{/other_user}","gists_url":"https://api.github.com/users/sr/gists{/gist_id}","starred_url":"https://api.github.com/users/sr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sr/subscriptions","organizations_url":"https://api.github.com/users/sr/orgs","repos_url":"https://api.github.com/users/sr/repos","events_url":"https://api.github.com/users/sr/events{/privacy}","received_events_url":"https://api.github.com/users/sr/received_events","type":"User","site_admin":false},"body":"This fixes the `Foreman::Procfile#[]` method to return `nil` when given the name of an entry that doesn't exist. I ran into this while using `Foreman::Procfile` to automate some stuff.\r\n\r\n```\r\n  1) Foreman::Procfile returns nil when attempting to retrieve an non-existing entry\r\n     Failure/Error: expect(procfile[\"unicorn\"]).to eq(nil)\r\n     NoMethodError:\r\n       undefined method `last' for nil:NilClass\r\n     # ./lib/foreman/procfile.rb:35:in `[]'\r\n     # ./spec/foreman/procfile_spec.rb:28:in `block (2 levels) in <top (required)>'\r\n``` \r\n\r\n/cc @ddollar","created_at":"2015-04-10T12:34:42Z","updated_at":"2015-07-21T20:05:15Z","closed_at":"2015-07-21T20:05:15Z","merged_at":"2015-07-21T20:05:15Z","merge_commit_sha":"0550eea473a7e4198c74fe4d69b197a4c4418d68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ddollar/foreman/pulls/551/commits","review_comments_url":"https://api.github.com/repos/ddollar/foreman/pulls/551/comments","review_comment_url":"https://api.github.com/repos/ddollar/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ddollar/foreman/issues/551/comments","statuses_url":"https://api.github.com/repos/ddollar/foreman/statuses/9bb0903fe864bf3f4d663e9c6fb8d6683ecabf34","head":{"label":"sr:fix-procfile","ref":"fix-procfile","sha":"9bb0903fe864bf3f4d663e9c6fb8d6683ecabf34","user":{"login":"sr","id":90,"avatar_url":"https://avatars.githubusercontent.com/u/90?v=3","gravatar_id":"","url":"https://api.github.com/users/sr","html_url":"https://github.com/sr","followers_url":"https://api.github.com/users/sr/followers","following_url":"https://api.github.com/users/sr/following{/other_user}","gists_url":"https://api.github.com/users/sr/gists{/gist_id}","starred_url":"https://api.github.com/users/sr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sr/subscriptions","organizations_url":"https://api.github.com/users/sr/orgs","repos_url":"https://api.github.com/users/sr/repos","events_url":"https://api.github.com/users/sr/events{/privacy}","received_events_url":"https://api.github.com/users/sr/received_events","type":"User","site_admin":false},"repo":{"id":33727159,"name":"foreman","full_name":"sr/foreman","owner":{"login":"sr","id":90,"avatar_url":"https://avatars.githubusercontent.com/u/90?v=3","gravatar_id":"","url":"https://api.github.com/users/sr","html_url":"https://github.com/sr","followers_url":"https://api.github.com/users/sr/followers","following_url":"https://api.github.com/users/sr/following{/other_user}","gists_url":"https://api.github.com/users/sr/gists{/gist_id}","starred_url":"https://api.github.com/users/sr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sr/subscriptions","organizations_url":"https://api.github.com/users/sr/orgs","repos_url":"https://api.github.com/users/sr/repos","events_url":"https://api.github.com/users/sr/events{/privacy}","received_events_url":"https://api.github.com/users/sr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sr/foreman","description":"Manage Procfile-based applications","fork":true,"url":"https://api.github.com/repos/sr/foreman","forks_url":"https://api.github.com/repos/sr/foreman/forks","keys_url":"https://api.github.com/repos/sr/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sr/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sr/foreman/teams","hooks_url":"https://api.github.com/repos/sr/foreman/hooks","issue_events_url":"https://api.github.com/repos/sr/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/sr/foreman/events","assignees_url":"https://api.github.com/repos/sr/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/sr/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/sr/foreman/tags","blobs_url":"https://api.github.com/repos/sr/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sr/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sr/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/sr/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sr/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/sr/foreman/languages","stargazers_url":"https://api.github.com/repos/sr/foreman/stargazers","contributors_url":"https://api.github.com/repos/sr/foreman/contributors","subscribers_url":"https://api.github.com/repos/sr/foreman/subscribers","subscription_url":"https://api.github.com/repos/sr/foreman/subscription","commits_url":"https://api.github.com/repos/sr/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/sr/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/sr/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/sr/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/sr/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/sr/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sr/foreman/merges","archive_url":"https://api.github.com/repos/sr/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sr/foreman/downloads","issues_url":"https://api.github.com/repos/sr/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/sr/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/sr/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/sr/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sr/foreman/labels{/name}","releases_url":"https://api.github.com/repos/sr/foreman/releases{/id}","created_at":"2015-04-10T12:24:52Z","updated_at":"2015-04-10T12:24:53Z","pushed_at":"2015-04-10T12:31:25Z","git_url":"git://github.com/sr/foreman.git","ssh_url":"git@github.com:sr/foreman.git","clone_url":"https://github.com/sr/foreman.git","svn_url":"https://github.com/sr/foreman","homepage":"http://ddollar.github.com/foreman","size":1036,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ddollar:master","ref":"master","sha":"4e6480cbe011a0972bd6a963cb154b4bbbc4c3e3","user":{"login":"ddollar","id":3308,"avatar_url":"https://avatars.githubusercontent.com/u/3308?v=3","gravatar_id":"","url":"https://api.github.com/users/ddollar","html_url":"https://github.com/ddollar","followers_url":"https://api.github.com/users/ddollar/followers","following_url":"https://api.github.com/users/ddollar/following{/other_user}","gists_url":"https://api.github.com/users/ddollar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddollar/subscriptions","organizations_url":"https://api.github.com/users/ddollar/orgs","repos_url":"https://api.github.com/users/ddollar/repos","events_url":"https://api.github.com/users/ddollar/events{/privacy}","received_events_url":"https://api.github.com/users/ddollar/received_events","type":"User","site_admin":false},"repo":{"id":672136,"name":"foreman","full_name":"ddollar/foreman","owner":{"login":"ddollar","id":3308,"avatar_url":"https://avatars.githubusercontent.com/u/3308?v=3","gravatar_id":"","url":"https://api.github.com/users/ddollar","html_url":"https://github.com/ddollar","followers_url":"https://api.github.com/users/ddollar/followers","following_url":"https://api.github.com/users/ddollar/following{/other_user}","gists_url":"https://api.github.com/users/ddollar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddollar/subscriptions","organizations_url":"https://api.github.com/users/ddollar/orgs","repos_url":"https://api.github.com/users/ddollar/repos","events_url":"https://api.github.com/users/ddollar/events{/privacy}","received_events_url":"https://api.github.com/users/ddollar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddollar/foreman","description":"Manage Procfile-based applications","fork":false,"url":"https://api.github.com/repos/ddollar/foreman","forks_url":"https://api.github.com/repos/ddollar/foreman/forks","keys_url":"https://api.github.com/repos/ddollar/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddollar/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddollar/foreman/teams","hooks_url":"https://api.github.com/repos/ddollar/foreman/hooks","issue_events_url":"https://api.github.com/repos/ddollar/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ddollar/foreman/events","assignees_url":"https://api.github.com/repos/ddollar/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ddollar/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ddollar/foreman/tags","blobs_url":"https://api.github.com/repos/ddollar/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddollar/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddollar/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddollar/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddollar/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ddollar/foreman/languages","stargazers_url":"https://api.github.com/repos/ddollar/foreman/stargazers","contributors_url":"https://api.github.com/repos/ddollar/foreman/contributors","subscribers_url":"https://api.github.com/repos/ddollar/foreman/subscribers","subscription_url":"https://api.github.com/repos/ddollar/foreman/subscription","commits_url":"https://api.github.com/repos/ddollar/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddollar/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddollar/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddollar/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddollar/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ddollar/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddollar/foreman/merges","archive_url":"https://api.github.com/repos/ddollar/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddollar/foreman/downloads","issues_url":"https://api.github.com/repos/ddollar/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ddollar/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ddollar/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ddollar/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddollar/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ddollar/foreman/releases{/id}","created_at":"2010-05-18T00:53:45Z","updated_at":"2015-07-21T16:36:00Z","pushed_at":"2015-07-21T20:05:15Z","git_url":"git://github.com/ddollar/foreman.git","ssh_url":"git@github.com:ddollar/foreman.git","clone_url":"https://github.com/ddollar/foreman.git","svn_url":"https://github.com/ddollar/foreman","homepage":"http://ddollar.github.com/foreman","size":2940,"stargazers_count":3283,"watchers_count":3283,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":419,"mirror_url":null,"open_issues_count":54,"forks":419,"open_issues":54,"watchers":3283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ddollar/foreman/pulls/551"},"html":{"href":"https://github.com/ddollar/foreman/pull/551"},"issue":{"href":"https://api.github.com/repos/ddollar/foreman/issues/551"},"comments":{"href":"https://api.github.com/repos/ddollar/foreman/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/ddollar/foreman/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/ddollar/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ddollar/foreman/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/ddollar/foreman/statuses/9bb0903fe864bf3f4d663e9c6fb8d6683ecabf34"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ddollar","id":3308,"avatar_url":"https://avatars.githubusercontent.com/u/3308?v=3","gravatar_id":"","url":"https://api.github.com/users/ddollar","html_url":"https://github.com/ddollar","followers_url":"https://api.github.com/users/ddollar/followers","following_url":"https://api.github.com/users/ddollar/following{/other_user}","gists_url":"https://api.github.com/users/ddollar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddollar/subscriptions","organizations_url":"https://api.github.com/users/ddollar/orgs","repos_url":"https://api.github.com/users/ddollar/repos","events_url":"https://api.github.com/users/ddollar/events{/privacy}","received_events_url":"https://api.github.com/users/ddollar/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":9,"deletions":1,"changed_files":2}}