{"action":"created","comment":{"url":"https://api.github.com/repos/busykai/cordova-js/pulls/comments/42440945","id":42440945,"diff_hunk":"@@ -110,6 +116,26 @@ function findCordovaPath() {\n     return path;\n }\n \n+exports.setModuleInstrumenter = function(moduleID, instrumenter) {\n+    if (typeof moduleID !== \"string\" || typeof instrumenter !== \"function\") {\n+        // ignore\n+        return;\n+    }\n+    moduleInstrumenters[moduleID] = instrumenter;\n+}\n+\n+// Recovers the information from the plugin list metadata and associates each\n+// module with its corresponding plugin","path":"src/common/pluginloader.js","position":35,"original_position":35,"commit_id":"d1dcea3bec5e5a63ecbce7760eacb8e27b8ba7df","original_commit_id":"d1dcea3bec5e5a63ecbce7760eacb8e27b8ba7df","user":{"login":"busykai","id":3368515,"avatar_url":"https://avatars.githubusercontent.com/u/3368515?v=3","gravatar_id":"","url":"https://api.github.com/users/busykai","html_url":"https://github.com/busykai","followers_url":"https://api.github.com/users/busykai/followers","following_url":"https://api.github.com/users/busykai/following{/other_user}","gists_url":"https://api.github.com/users/busykai/gists{/gist_id}","starred_url":"https://api.github.com/users/busykai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busykai/subscriptions","organizations_url":"https://api.github.com/users/busykai/orgs","repos_url":"https://api.github.com/users/busykai/repos","events_url":"https://api.github.com/users/busykai/events{/privacy}","received_events_url":"https://api.github.com/users/busykai/received_events","type":"User","site_admin":false},"body":"this will not be needed after apache/cordova-lib#322 gets into a released cordova-cli version.","created_at":"2015-10-19T23:52:28Z","updated_at":"2015-10-19T23:52:28Z","html_url":"https://github.com/busykai/cordova-js/pull/1#discussion_r42440945","pull_request_url":"https://api.github.com/repos/busykai/cordova-js/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/busykai/cordova-js/pulls/comments/42440945"},"html":{"href":"https://github.com/busykai/cordova-js/pull/1#discussion_r42440945"},"pull_request":{"href":"https://api.github.com/repos/busykai/cordova-js/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/busykai/cordova-js/pulls/1","id":47819985,"html_url":"https://github.com/busykai/cordova-js/pull/1","diff_url":"https://github.com/busykai/cordova-js/pull/1.diff","patch_url":"https://github.com/busykai/cordova-js/pull/1.patch","issue_url":"https://api.github.com/repos/busykai/cordova-js/issues/1","number":1,"state":"open","locked":false,"title":"Implement module \"instrumenters\".","user":{"login":"busykai","id":3368515,"avatar_url":"https://avatars.githubusercontent.com/u/3368515?v=3","gravatar_id":"","url":"https://api.github.com/users/busykai","html_url":"https://github.com/busykai","followers_url":"https://api.github.com/users/busykai/followers","following_url":"https://api.github.com/users/busykai/following{/other_user}","gists_url":"https://api.github.com/users/busykai/gists{/gist_id}","starred_url":"https://api.github.com/users/busykai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busykai/subscriptions","organizations_url":"https://api.github.com/users/busykai/orgs","repos_url":"https://api.github.com/users/busykai/repos","events_url":"https://api.github.com/users/busykai/events{/privacy}","received_events_url":"https://api.github.com/users/busykai/received_events","type":"User","site_admin":false},"body":"A module can be asynchronously instrumented, its \"ready\" state can be delayed\r\nuntil the instrumentation is done.\r\n\r\nThis is motivated by simulation support (microsoft/taco-simulate), but can also\r\nbe used for testing, collecting stats development time and so on.\r\n\r\n@purplecabbage this is a draft implementation of the idea I talked to you about yesterday (I'm Arzhan @ CordovaF2F). Please take a look when you have time.\r\n\r\nCC @TimBarham","created_at":"2015-10-15T17:57:41Z","updated_at":"2015-10-19T23:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e955e5143072ebb5cbe2be6121f4a11c54792c1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/busykai/cordova-js/pulls/1/commits","review_comments_url":"https://api.github.com/repos/busykai/cordova-js/pulls/1/comments","review_comment_url":"https://api.github.com/repos/busykai/cordova-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/busykai/cordova-js/issues/1/comments","statuses_url":"https://api.github.com/repos/busykai/cordova-js/statuses/d1dcea3bec5e5a63ecbce7760eacb8e27b8ba7df","head":{"label":"busykai:kai/module-instrumenters","ref":"kai/module-instrumenters","sha":"d1dcea3bec5e5a63ecbce7760eacb8e27b8ba7df","user":{"login":"busykai","id":3368515,"avatar_url":"https://avatars.githubusercontent.com/u/3368515?v=3","gravatar_id":"","url":"https://api.github.com/users/busykai","html_url":"https://github.com/busykai","followers_url":"https://api.github.com/users/busykai/followers","following_url":"https://api.github.com/users/busykai/following{/other_user}","gists_url":"https://api.github.com/users/busykai/gists{/gist_id}","starred_url":"https://api.github.com/users/busykai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busykai/subscriptions","organizations_url":"https://api.github.com/users/busykai/orgs","repos_url":"https://api.github.com/users/busykai/repos","events_url":"https://api.github.com/users/busykai/events{/privacy}","received_events_url":"https://api.github.com/users/busykai/received_events","type":"User","site_admin":false},"repo":{"id":44136048,"name":"cordova-js","full_name":"busykai/cordova-js","owner":{"login":"busykai","id":3368515,"avatar_url":"https://avatars.githubusercontent.com/u/3368515?v=3","gravatar_id":"","url":"https://api.github.com/users/busykai","html_url":"https://github.com/busykai","followers_url":"https://api.github.com/users/busykai/followers","following_url":"https://api.github.com/users/busykai/following{/other_user}","gists_url":"https://api.github.com/users/busykai/gists{/gist_id}","starred_url":"https://api.github.com/users/busykai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busykai/subscriptions","organizations_url":"https://api.github.com/users/busykai/orgs","repos_url":"https://api.github.com/users/busykai/repos","events_url":"https://api.github.com/users/busykai/events{/privacy}","received_events_url":"https://api.github.com/users/busykai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/busykai/cordova-js","description":"Mirror of Apache Cordova js","fork":true,"url":"https://api.github.com/repos/busykai/cordova-js","forks_url":"https://api.github.com/repos/busykai/cordova-js/forks","keys_url":"https://api.github.com/repos/busykai/cordova-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/busykai/cordova-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/busykai/cordova-js/teams","hooks_url":"https://api.github.com/repos/busykai/cordova-js/hooks","issue_events_url":"https://api.github.com/repos/busykai/cordova-js/issues/events{/number}","events_url":"https://api.github.com/repos/busykai/cordova-js/events","assignees_url":"https://api.github.com/repos/busykai/cordova-js/assignees{/user}","branches_url":"https://api.github.com/repos/busykai/cordova-js/branches{/branch}","tags_url":"https://api.github.com/repos/busykai/cordova-js/tags","blobs_url":"https://api.github.com/repos/busykai/cordova-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/busykai/cordova-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/busykai/cordova-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/busykai/cordova-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/busykai/cordova-js/statuses/{sha}","languages_url":"https://api.github.com/repos/busykai/cordova-js/languages","stargazers_url":"https://api.github.com/repos/busykai/cordova-js/stargazers","contributors_url":"https://api.github.com/repos/busykai/cordova-js/contributors","subscribers_url":"https://api.github.com/repos/busykai/cordova-js/subscribers","subscription_url":"https://api.github.com/repos/busykai/cordova-js/subscription","commits_url":"https://api.github.com/repos/busykai/cordova-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/busykai/cordova-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/busykai/cordova-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/busykai/cordova-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/busykai/cordova-js/contents/{+path}","compare_url":"https://api.github.com/repos/busykai/cordova-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/busykai/cordova-js/merges","archive_url":"https://api.github.com/repos/busykai/cordova-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/busykai/cordova-js/downloads","issues_url":"https://api.github.com/repos/busykai/cordova-js/issues{/number}","pulls_url":"https://api.github.com/repos/busykai/cordova-js/pulls{/number}","milestones_url":"https://api.github.com/repos/busykai/cordova-js/milestones{/number}","notifications_url":"https://api.github.com/repos/busykai/cordova-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/busykai/cordova-js/labels{/name}","releases_url":"https://api.github.com/repos/busykai/cordova-js/releases{/id}","created_at":"2015-10-12T21:47:24Z","updated_at":"2015-10-12T21:47:25Z","pushed_at":"2015-10-15T17:57:42Z","git_url":"git://github.com/busykai/cordova-js.git","ssh_url":"git@github.com:busykai/cordova-js.git","clone_url":"https://github.com/busykai/cordova-js.git","svn_url":"https://github.com/busykai/cordova-js","homepage":null,"size":3561,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"busykai:master","ref":"master","sha":"064b25a40aab8fc2f210fdbb394d63c31e7d3e6d","user":{"login":"busykai","id":3368515,"avatar_url":"https://avatars.githubusercontent.com/u/3368515?v=3","gravatar_id":"","url":"https://api.github.com/users/busykai","html_url":"https://github.com/busykai","followers_url":"https://api.github.com/users/busykai/followers","following_url":"https://api.github.com/users/busykai/following{/other_user}","gists_url":"https://api.github.com/users/busykai/gists{/gist_id}","starred_url":"https://api.github.com/users/busykai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busykai/subscriptions","organizations_url":"https://api.github.com/users/busykai/orgs","repos_url":"https://api.github.com/users/busykai/repos","events_url":"https://api.github.com/users/busykai/events{/privacy}","received_events_url":"https://api.github.com/users/busykai/received_events","type":"User","site_admin":false},"repo":{"id":44136048,"name":"cordova-js","full_name":"busykai/cordova-js","owner":{"login":"busykai","id":3368515,"avatar_url":"https://avatars.githubusercontent.com/u/3368515?v=3","gravatar_id":"","url":"https://api.github.com/users/busykai","html_url":"https://github.com/busykai","followers_url":"https://api.github.com/users/busykai/followers","following_url":"https://api.github.com/users/busykai/following{/other_user}","gists_url":"https://api.github.com/users/busykai/gists{/gist_id}","starred_url":"https://api.github.com/users/busykai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busykai/subscriptions","organizations_url":"https://api.github.com/users/busykai/orgs","repos_url":"https://api.github.com/users/busykai/repos","events_url":"https://api.github.com/users/busykai/events{/privacy}","received_events_url":"https://api.github.com/users/busykai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/busykai/cordova-js","description":"Mirror of Apache Cordova js","fork":true,"url":"https://api.github.com/repos/busykai/cordova-js","forks_url":"https://api.github.com/repos/busykai/cordova-js/forks","keys_url":"https://api.github.com/repos/busykai/cordova-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/busykai/cordova-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/busykai/cordova-js/teams","hooks_url":"https://api.github.com/repos/busykai/cordova-js/hooks","issue_events_url":"https://api.github.com/repos/busykai/cordova-js/issues/events{/number}","events_url":"https://api.github.com/repos/busykai/cordova-js/events","assignees_url":"https://api.github.com/repos/busykai/cordova-js/assignees{/user}","branches_url":"https://api.github.com/repos/busykai/cordova-js/branches{/branch}","tags_url":"https://api.github.com/repos/busykai/cordova-js/tags","blobs_url":"https://api.github.com/repos/busykai/cordova-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/busykai/cordova-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/busykai/cordova-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/busykai/cordova-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/busykai/cordova-js/statuses/{sha}","languages_url":"https://api.github.com/repos/busykai/cordova-js/languages","stargazers_url":"https://api.github.com/repos/busykai/cordova-js/stargazers","contributors_url":"https://api.github.com/repos/busykai/cordova-js/contributors","subscribers_url":"https://api.github.com/repos/busykai/cordova-js/subscribers","subscription_url":"https://api.github.com/repos/busykai/cordova-js/subscription","commits_url":"https://api.github.com/repos/busykai/cordova-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/busykai/cordova-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/busykai/cordova-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/busykai/cordova-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/busykai/cordova-js/contents/{+path}","compare_url":"https://api.github.com/repos/busykai/cordova-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/busykai/cordova-js/merges","archive_url":"https://api.github.com/repos/busykai/cordova-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/busykai/cordova-js/downloads","issues_url":"https://api.github.com/repos/busykai/cordova-js/issues{/number}","pulls_url":"https://api.github.com/repos/busykai/cordova-js/pulls{/number}","milestones_url":"https://api.github.com/repos/busykai/cordova-js/milestones{/number}","notifications_url":"https://api.github.com/repos/busykai/cordova-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/busykai/cordova-js/labels{/name}","releases_url":"https://api.github.com/repos/busykai/cordova-js/releases{/id}","created_at":"2015-10-12T21:47:24Z","updated_at":"2015-10-12T21:47:25Z","pushed_at":"2015-10-15T17:57:42Z","git_url":"git://github.com/busykai/cordova-js.git","ssh_url":"git@github.com:busykai/cordova-js.git","clone_url":"https://github.com/busykai/cordova-js.git","svn_url":"https://github.com/busykai/cordova-js","homepage":null,"size":3561,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/busykai/cordova-js/pulls/1"},"html":{"href":"https://github.com/busykai/cordova-js/pull/1"},"issue":{"href":"https://api.github.com/repos/busykai/cordova-js/issues/1"},"comments":{"href":"https://api.github.com/repos/busykai/cordova-js/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/busykai/cordova-js/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/busykai/cordova-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/busykai/cordova-js/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/busykai/cordova-js/statuses/d1dcea3bec5e5a63ecbce7760eacb8e27b8ba7df"}}}}