{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/1668","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/1668/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1668/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/1668/events","html_url":"https://github.com/buildbot/buildbot/pull/1668","id":77151087,"number":1668,"title":"Rewrite the flatten function to be even more flatenning","user":{"login":"vlovich","id":201287,"avatar_url":"https://avatars.githubusercontent.com/u/201287?v=3","gravatar_id":"","url":"https://api.github.com/users/vlovich","html_url":"https://github.com/vlovich","followers_url":"https://api.github.com/users/vlovich/followers","following_url":"https://api.github.com/users/vlovich/following{/other_user}","gists_url":"https://api.github.com/users/vlovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vlovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlovich/subscriptions","organizations_url":"https://api.github.com/users/vlovich/orgs","repos_url":"https://api.github.com/users/vlovich/repos","events_url":"https://api.github.com/users/vlovich/events{/privacy}","received_events_url":"https://api.github.com/users/vlovich/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20work","name":"needs work","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-16T22:44:48Z","updated_at":"2015-05-17T09:00:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1668","html_url":"https://github.com/buildbot/buildbot/pull/1668","diff_url":"https://github.com/buildbot/buildbot/pull/1668.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1668.patch"},"body":"This fixes the default flattening to apply to tuples too.  Additionally, it also now flattens any nested lists too.  When given something that's not a list, it converts it to a list.  That way the result of the flatten operation is always guaranteed to be a list regardless of input."},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/102769500","html_url":"https://github.com/buildbot/buildbot/pull/1668#issuecomment-102769500","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1668","id":102769500,"user":{"login":"vlovich","id":201287,"avatar_url":"https://avatars.githubusercontent.com/u/201287?v=3","gravatar_id":"","url":"https://api.github.com/users/vlovich","html_url":"https://github.com/vlovich","followers_url":"https://api.github.com/users/vlovich/followers","following_url":"https://api.github.com/users/vlovich/following{/other_user}","gists_url":"https://api.github.com/users/vlovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vlovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlovich/subscriptions","organizations_url":"https://api.github.com/users/vlovich/orgs","repos_url":"https://api.github.com/users/vlovich/repos","events_url":"https://api.github.com/users/vlovich/events{/privacy}","received_events_url":"https://api.github.com/users/vlovich/received_events","type":"User","site_admin":false},"created_at":"2015-05-17T09:00:40Z","updated_at":"2015-05-17T09:00:40Z","body":"K.  I'll look at the failing unit tests.  If you look, I added an example test-case that fails with the previous implementation, although it looks like master now passes due to changes you made in f148cdfabf009fa6565864bc52a52b06e2460543.\r\n\r\nNamely the types weren't being propagated to the recursive function.  Other than that, it's just a re-write to be use a generator version"}}