{"comment":{"url":"https://api.github.com/repos/vanilla/vanilla/comments/13550094","html_url":"https://github.com/vanilla/vanilla/commit/338fb1bbb703f2153ae6f698d28ed2562eef20d9#commitcomment-13550094","id":13550094,"user":{"login":"mtschirs","id":2223047,"avatar_url":"https://avatars.githubusercontent.com/u/2223047?v=3","gravatar_id":"","url":"https://api.github.com/users/mtschirs","html_url":"https://github.com/mtschirs","followers_url":"https://api.github.com/users/mtschirs/followers","following_url":"https://api.github.com/users/mtschirs/following{/other_user}","gists_url":"https://api.github.com/users/mtschirs/gists{/gist_id}","starred_url":"https://api.github.com/users/mtschirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtschirs/subscriptions","organizations_url":"https://api.github.com/users/mtschirs/orgs","repos_url":"https://api.github.com/users/mtschirs/repos","events_url":"https://api.github.com/users/mtschirs/events{/privacy}","received_events_url":"https://api.github.com/users/mtschirs/received_events","type":"User","site_admin":false},"position":12,"line":403,"path":"applications/dashboard/controllers/class.entrycontroller.php","commit_id":"338fb1bbb703f2153ae6f698d28ed2562eef20d9","created_at":"2015-10-01T20:20:06Z","updated_at":"2015-10-01T20:20:06Z","body":"just a question... won't that break existing addons that rely on 'Roles' being given as a form value?\r\n\r\nAlso in line 462:\r\n```\r\n$Roles = $this->Form->getFormValue('Roles', null);\r\n```\r\nHow about moving 'Roles' from formValues to Data?\r\n```\r\n// Here are the initial data array values. that can be set by a plugin.\r\n$Data = array('Roles' => '', ...);\r\n```"}}