{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/comidi/pulls/comments/38747624","id":38747624,"diff_hunk":"@@ -21,17 +21,24 @@\n (def Zipper\n   (schema/pred ks/zipper?))\n \n-(def http-methods\n-  #{:any :get :post :put :delete :head :options})\n-\n (def RequestMethod\n   (schema/enum :any :get :post :put :delete :head :options))\n \n+; Derived from bidi-schema PatternSegment\n (def RegexPatternSegment\n-  [(schema/one Pattern \"regex\") (schema/one schema/Keyword \"variable\")])\n+  (schema/pair schema/Regex \"qual\" schema/Keyword \"id\"))\n+\n+; Derived from bidi-schema by flattening a vector of Patterns\n+(def RouteInfoPathSegment\n+  (schema/either bidi-schema/Path\n+                 bidi-schema/PatternSegment\n+                 schema/Bool))","path":"src/puppetlabs/comidi.clj","position":19,"original_position":19,"commit_id":"cf5a99f5c1fbc54e076b5ca33766c2e1af766601","original_commit_id":"cf5a99f5c1fbc54e076b5ca33766c2e1af766601","user":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"body":"The difficulty is that we flatten the patterns from the nested routes, which isn't something that bidi ever needs to do. There's also no need to specifically identify regex segments.\r\n\r\nI'll update to use cond.","created_at":"2015-09-04T12:48:15Z","updated_at":"2015-09-04T12:48:15Z","html_url":"https://github.com/puppetlabs/comidi/pull/17#discussion_r38747624","pull_request_url":"https://api.github.com/repos/puppetlabs/comidi/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/comidi/pulls/comments/38747624"},"html":{"href":"https://github.com/puppetlabs/comidi/pull/17#discussion_r38747624"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/comidi/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/comidi/pulls/17","id":43965250,"html_url":"https://github.com/puppetlabs/comidi/pull/17","diff_url":"https://github.com/puppetlabs/comidi/pull/17.diff","patch_url":"https://github.com/puppetlabs/comidi/pull/17.patch","issue_url":"https://api.github.com/repos/puppetlabs/comidi/issues/17","number":17,"state":"open","locked":false,"title":"(maint) Better support for Bidi patterns","user":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"body":"Bidi permits true/false as Patterns on the left hand side of the route and this commit adds metadata support for those routes and clarifies the corresponding schema. It also adds some new tests.","created_at":"2015-09-02T08:22:56Z","updated_at":"2015-09-04T12:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69a808bd760a9315f8574b02dd661d987ca8b6e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/comidi/pulls/17/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/comidi/pulls/17/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/comidi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/comidi/issues/17/comments","statuses_url":"https://api.github.com/repos/puppetlabs/comidi/statuses/cf5a99f5c1fbc54e076b5ca33766c2e1af766601","head":{"label":"scottyw:better-pattern-support","ref":"better-pattern-support","sha":"cf5a99f5c1fbc54e076b5ca33766c2e1af766601","user":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"repo":{"id":41096229,"name":"comidi","full_name":"scottyw/comidi","owner":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottyw/comidi","description":"Puppet Labs utility functions for use with the bidi web routing library","fork":true,"url":"https://api.github.com/repos/scottyw/comidi","forks_url":"https://api.github.com/repos/scottyw/comidi/forks","keys_url":"https://api.github.com/repos/scottyw/comidi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottyw/comidi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottyw/comidi/teams","hooks_url":"https://api.github.com/repos/scottyw/comidi/hooks","issue_events_url":"https://api.github.com/repos/scottyw/comidi/issues/events{/number}","events_url":"https://api.github.com/repos/scottyw/comidi/events","assignees_url":"https://api.github.com/repos/scottyw/comidi/assignees{/user}","branches_url":"https://api.github.com/repos/scottyw/comidi/branches{/branch}","tags_url":"https://api.github.com/repos/scottyw/comidi/tags","blobs_url":"https://api.github.com/repos/scottyw/comidi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottyw/comidi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottyw/comidi/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottyw/comidi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottyw/comidi/statuses/{sha}","languages_url":"https://api.github.com/repos/scottyw/comidi/languages","stargazers_url":"https://api.github.com/repos/scottyw/comidi/stargazers","contributors_url":"https://api.github.com/repos/scottyw/comidi/contributors","subscribers_url":"https://api.github.com/repos/scottyw/comidi/subscribers","subscription_url":"https://api.github.com/repos/scottyw/comidi/subscription","commits_url":"https://api.github.com/repos/scottyw/comidi/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottyw/comidi/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottyw/comidi/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottyw/comidi/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottyw/comidi/contents/{+path}","compare_url":"https://api.github.com/repos/scottyw/comidi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottyw/comidi/merges","archive_url":"https://api.github.com/repos/scottyw/comidi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottyw/comidi/downloads","issues_url":"https://api.github.com/repos/scottyw/comidi/issues{/number}","pulls_url":"https://api.github.com/repos/scottyw/comidi/pulls{/number}","milestones_url":"https://api.github.com/repos/scottyw/comidi/milestones{/number}","notifications_url":"https://api.github.com/repos/scottyw/comidi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottyw/comidi/labels{/name}","releases_url":"https://api.github.com/repos/scottyw/comidi/releases{/id}","created_at":"2015-08-20T13:09:14Z","updated_at":"2015-08-20T13:09:14Z","pushed_at":"2015-09-04T09:08:51Z","git_url":"git://github.com/scottyw/comidi.git","ssh_url":"git@github.com:scottyw/comidi.git","clone_url":"https://github.com/scottyw/comidi.git","svn_url":"https://github.com/scottyw/comidi","homepage":null,"size":131,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"0751265f5b53f0bfe4ede322e65d45d2ffb2d57e","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":32033445,"name":"comidi","full_name":"puppetlabs/comidi","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/comidi","description":"Puppet Labs utility functions for use with the bidi web routing library","fork":false,"url":"https://api.github.com/repos/puppetlabs/comidi","forks_url":"https://api.github.com/repos/puppetlabs/comidi/forks","keys_url":"https://api.github.com/repos/puppetlabs/comidi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/comidi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/comidi/teams","hooks_url":"https://api.github.com/repos/puppetlabs/comidi/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/comidi/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/comidi/events","assignees_url":"https://api.github.com/repos/puppetlabs/comidi/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/comidi/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/comidi/tags","blobs_url":"https://api.github.com/repos/puppetlabs/comidi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/comidi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/comidi/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/comidi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/comidi/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/comidi/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/comidi/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/comidi/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/comidi/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/comidi/subscription","commits_url":"https://api.github.com/repos/puppetlabs/comidi/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/comidi/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/comidi/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/comidi/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/comidi/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/comidi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/comidi/merges","archive_url":"https://api.github.com/repos/puppetlabs/comidi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/comidi/downloads","issues_url":"https://api.github.com/repos/puppetlabs/comidi/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/comidi/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/comidi/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/comidi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/comidi/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/comidi/releases{/id}","created_at":"2015-03-11T18:14:08Z","updated_at":"2015-07-16T20:51:17Z","pushed_at":"2015-09-04T09:09:17Z","git_url":"git://github.com/puppetlabs/comidi.git","ssh_url":"git@github.com:puppetlabs/comidi.git","clone_url":"https://github.com/puppetlabs/comidi.git","svn_url":"https://github.com/puppetlabs/comidi","homepage":null,"size":303,"stargazers_count":5,"watchers_count":5,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/comidi/pulls/17"},"html":{"href":"https://github.com/puppetlabs/comidi/pull/17"},"issue":{"href":"https://api.github.com/repos/puppetlabs/comidi/issues/17"},"comments":{"href":"https://api.github.com/repos/puppetlabs/comidi/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/comidi/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/comidi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/comidi/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/comidi/statuses/cf5a99f5c1fbc54e076b5ca33766c2e1af766601"}}}}