{"action":"created","comment":{"url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments/26902213","id":26902213,"diff_hunk":"@@ -200,11 +248,21 @@ public int getSizeInventory() {\n \n \t@Override\n \tpublic ItemStack getStackInSlot(int i) {\n+\t\tif (!_drawer.isDrawerEnabled(i))\n+\t\t\treturn null;\n+\n \t\treturn _drawer.getDrawer(i) != null ? _drawer.getDrawer(i).getStoredItemCopy() : null;\n \t}\n \n \t@Override\n \tpublic ItemStack decrStackSize(int i, int j) {\n-\t\treturn _drawer.takeItemsFromSlot(i, j);\n+\t\tif (!_drawer.isDrawerEnabled(i))\n+\t\t\treturn null;\n+\n+\t\tIDrawer drawer = _drawer.getDrawer(i);\n+\t\tif (drawer == null)\n+\t\t\treturn null;\n+\n+\t\treturn getMultipleItems(ItemIdentifier.get(drawer.getStoredItemPrototype()), j);","path":"common/logisticspipes/proxy/specialinventoryhandler/StorageDrawersInventoryHandler.java","position":261,"original_position":261,"commit_id":"c3bfa36a66e3dfe4297655f911ebd781add18c33","original_commit_id":"c3bfa36a66e3dfe4297655f911ebd781add18c33","user":{"login":"davboecki","id":1119689,"avatar_url":"https://avatars.githubusercontent.com/u/1119689?v=3","gravatar_id":"","url":"https://api.github.com/users/davboecki","html_url":"https://github.com/davboecki","followers_url":"https://api.github.com/users/davboecki/followers","following_url":"https://api.github.com/users/davboecki/following{/other_user}","gists_url":"https://api.github.com/users/davboecki/gists{/gist_id}","starred_url":"https://api.github.com/users/davboecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davboecki/subscriptions","organizations_url":"https://api.github.com/users/davboecki/orgs","repos_url":"https://api.github.com/users/davboecki/repos","events_url":"https://api.github.com/users/davboecki/events{/privacy}","received_events_url":"https://api.github.com/users/davboecki/received_events","type":"User","site_admin":false},"body":"This can't be relaied to getMultipleItems();\r\nIt needs to access the slot i and not the complete inventory.","created_at":"2015-03-22T12:07:43Z","updated_at":"2015-03-22T12:07:43Z","html_url":"https://github.com/RS485/LogisticsPipes/pull/621#discussion_r26902213","pull_request_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621","_links":{"self":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments/26902213"},"html":{"href":"https://github.com/RS485/LogisticsPipes/pull/621#discussion_r26902213"},"pull_request":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621"}}},"pull_request":{"url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621","id":31683368,"html_url":"https://github.com/RS485/LogisticsPipes/pull/621","diff_url":"https://github.com/RS485/LogisticsPipes/pull/621.diff","patch_url":"https://github.com/RS485/LogisticsPipes/pull/621.patch","issue_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/621","number":621,"state":"open","locked":false,"title":"Fix Storage Drawers support.","user":{"login":"jaquadro","id":852988,"avatar_url":"https://avatars.githubusercontent.com/u/852988?v=3","gravatar_id":"","url":"https://api.github.com/users/jaquadro","html_url":"https://github.com/jaquadro","followers_url":"https://api.github.com/users/jaquadro/followers","following_url":"https://api.github.com/users/jaquadro/following{/other_user}","gists_url":"https://api.github.com/users/jaquadro/gists{/gist_id}","starred_url":"https://api.github.com/users/jaquadro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaquadro/subscriptions","organizations_url":"https://api.github.com/users/jaquadro/orgs","repos_url":"https://api.github.com/users/jaquadro/repos","events_url":"https://api.github.com/users/jaquadro/events{/privacy}","received_events_url":"https://api.github.com/users/jaquadro/received_events","type":"User","site_admin":false},"body":"First, thank you @davboecki for writing the initial integration for this.  I completely failed to get around to it.\r\n\r\nI ran off and did some testing after I got notified of the closed issue, but found it wasn't working.  I've updated the implementation with what I think is correct.\r\n\r\nMy main test setup has been a drawer, supplier, pipe, provider, and chest, testing the block as both a supplier and provider. As far as I can tell that's all working correctly now, but there's a lot to LP that I don't currently understand, so I can't say that my testing was thorough.\r\n\r\nI published 2 new builds of Storage Drawers since this support was initially merged, adding a necessary API entry and fixing a dupe bug that would have emerged with the LP support.","created_at":"2015-03-22T05:32:36Z","updated_at":"2015-03-22T12:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a90656bae0dc934b9abe5b2a353a99f5ec5671c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621/commits","review_comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621/comments","review_comment_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/621/comments","statuses_url":"https://api.github.com/repos/RS485/LogisticsPipes/statuses/c3bfa36a66e3dfe4297655f911ebd781add18c33","head":{"label":"jaquadro:mc17-0.9","ref":"mc17-0.9","sha":"c3bfa36a66e3dfe4297655f911ebd781add18c33","user":{"login":"jaquadro","id":852988,"avatar_url":"https://avatars.githubusercontent.com/u/852988?v=3","gravatar_id":"","url":"https://api.github.com/users/jaquadro","html_url":"https://github.com/jaquadro","followers_url":"https://api.github.com/users/jaquadro/followers","following_url":"https://api.github.com/users/jaquadro/following{/other_user}","gists_url":"https://api.github.com/users/jaquadro/gists{/gist_id}","starred_url":"https://api.github.com/users/jaquadro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaquadro/subscriptions","organizations_url":"https://api.github.com/users/jaquadro/orgs","repos_url":"https://api.github.com/users/jaquadro/repos","events_url":"https://api.github.com/users/jaquadro/events{/privacy}","received_events_url":"https://api.github.com/users/jaquadro/received_events","type":"User","site_admin":false},"repo":{"id":32658145,"name":"LogisticsPipes","full_name":"jaquadro/LogisticsPipes","owner":{"login":"jaquadro","id":852988,"avatar_url":"https://avatars.githubusercontent.com/u/852988?v=3","gravatar_id":"","url":"https://api.github.com/users/jaquadro","html_url":"https://github.com/jaquadro","followers_url":"https://api.github.com/users/jaquadro/followers","following_url":"https://api.github.com/users/jaquadro/following{/other_user}","gists_url":"https://api.github.com/users/jaquadro/gists{/gist_id}","starred_url":"https://api.github.com/users/jaquadro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaquadro/subscriptions","organizations_url":"https://api.github.com/users/jaquadro/orgs","repos_url":"https://api.github.com/users/jaquadro/repos","events_url":"https://api.github.com/users/jaquadro/events{/privacy}","received_events_url":"https://api.github.com/users/jaquadro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaquadro/LogisticsPipes","description":"This is the SMP version with additional features for the minecraft modification Logistics Pipes.","fork":true,"url":"https://api.github.com/repos/jaquadro/LogisticsPipes","forks_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/forks","keys_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/teams","hooks_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/hooks","issue_events_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/issues/events{/number}","events_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/events","assignees_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/assignees{/user}","branches_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/branches{/branch}","tags_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/tags","blobs_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/statuses/{sha}","languages_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/languages","stargazers_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/stargazers","contributors_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/contributors","subscribers_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/subscribers","subscription_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/subscription","commits_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/contents/{+path}","compare_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/merges","archive_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/downloads","issues_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/issues{/number}","pulls_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/pulls{/number}","milestones_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/milestones{/number}","notifications_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/labels{/name}","releases_url":"https://api.github.com/repos/jaquadro/LogisticsPipes/releases{/id}","created_at":"2015-03-22T02:05:01Z","updated_at":"2015-03-22T02:05:03Z","pushed_at":"2015-03-22T05:26:13Z","git_url":"git://github.com/jaquadro/LogisticsPipes.git","ssh_url":"git@github.com:jaquadro/LogisticsPipes.git","clone_url":"https://github.com/jaquadro/LogisticsPipes.git","svn_url":"https://github.com/jaquadro/LogisticsPipes","homepage":"http://rs485.network","size":23080,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mc17"}},"base":{"label":"RS485:mc17-0.9","ref":"mc17-0.9","sha":"bb01458507910571ffee30c55022b47bac5aef06","user":{"login":"RS485","id":1810136,"avatar_url":"https://avatars.githubusercontent.com/u/1810136?v=3","gravatar_id":"","url":"https://api.github.com/users/RS485","html_url":"https://github.com/RS485","followers_url":"https://api.github.com/users/RS485/followers","following_url":"https://api.github.com/users/RS485/following{/other_user}","gists_url":"https://api.github.com/users/RS485/gists{/gist_id}","starred_url":"https://api.github.com/users/RS485/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RS485/subscriptions","organizations_url":"https://api.github.com/users/RS485/orgs","repos_url":"https://api.github.com/users/RS485/repos","events_url":"https://api.github.com/users/RS485/events{/privacy}","received_events_url":"https://api.github.com/users/RS485/received_events","type":"Organization","site_admin":false},"repo":{"id":7784091,"name":"LogisticsPipes","full_name":"RS485/LogisticsPipes","owner":{"login":"RS485","id":1810136,"avatar_url":"https://avatars.githubusercontent.com/u/1810136?v=3","gravatar_id":"","url":"https://api.github.com/users/RS485","html_url":"https://github.com/RS485","followers_url":"https://api.github.com/users/RS485/followers","following_url":"https://api.github.com/users/RS485/following{/other_user}","gists_url":"https://api.github.com/users/RS485/gists{/gist_id}","starred_url":"https://api.github.com/users/RS485/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RS485/subscriptions","organizations_url":"https://api.github.com/users/RS485/orgs","repos_url":"https://api.github.com/users/RS485/repos","events_url":"https://api.github.com/users/RS485/events{/privacy}","received_events_url":"https://api.github.com/users/RS485/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RS485/LogisticsPipes","description":"This is the SMP version with additional features for the minecraft modification Logistics Pipes.","fork":false,"url":"https://api.github.com/repos/RS485/LogisticsPipes","forks_url":"https://api.github.com/repos/RS485/LogisticsPipes/forks","keys_url":"https://api.github.com/repos/RS485/LogisticsPipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RS485/LogisticsPipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RS485/LogisticsPipes/teams","hooks_url":"https://api.github.com/repos/RS485/LogisticsPipes/hooks","issue_events_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/events{/number}","events_url":"https://api.github.com/repos/RS485/LogisticsPipes/events","assignees_url":"https://api.github.com/repos/RS485/LogisticsPipes/assignees{/user}","branches_url":"https://api.github.com/repos/RS485/LogisticsPipes/branches{/branch}","tags_url":"https://api.github.com/repos/RS485/LogisticsPipes/tags","blobs_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RS485/LogisticsPipes/statuses/{sha}","languages_url":"https://api.github.com/repos/RS485/LogisticsPipes/languages","stargazers_url":"https://api.github.com/repos/RS485/LogisticsPipes/stargazers","contributors_url":"https://api.github.com/repos/RS485/LogisticsPipes/contributors","subscribers_url":"https://api.github.com/repos/RS485/LogisticsPipes/subscribers","subscription_url":"https://api.github.com/repos/RS485/LogisticsPipes/subscription","commits_url":"https://api.github.com/repos/RS485/LogisticsPipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/RS485/LogisticsPipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/RS485/LogisticsPipes/contents/{+path}","compare_url":"https://api.github.com/repos/RS485/LogisticsPipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RS485/LogisticsPipes/merges","archive_url":"https://api.github.com/repos/RS485/LogisticsPipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RS485/LogisticsPipes/downloads","issues_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues{/number}","pulls_url":"https://api.github.com/repos/RS485/LogisticsPipes/pulls{/number}","milestones_url":"https://api.github.com/repos/RS485/LogisticsPipes/milestones{/number}","notifications_url":"https://api.github.com/repos/RS485/LogisticsPipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RS485/LogisticsPipes/labels{/name}","releases_url":"https://api.github.com/repos/RS485/LogisticsPipes/releases{/id}","created_at":"2013-01-23T21:19:57Z","updated_at":"2015-03-21T22:02:06Z","pushed_at":"2015-03-22T05:32:37Z","git_url":"git://github.com/RS485/LogisticsPipes.git","ssh_url":"git@github.com:RS485/LogisticsPipes.git","clone_url":"https://github.com/RS485/LogisticsPipes.git","svn_url":"https://github.com/RS485/LogisticsPipes","homepage":"http://rs485.network","size":23080,"stargazers_count":85,"watchers_count":85,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":65,"forks":49,"open_issues":65,"watchers":85,"default_branch":"mc17"}},"_links":{"self":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621"},"html":{"href":"https://github.com/RS485/LogisticsPipes/pull/621"},"issue":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/issues/621"},"comments":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/issues/621/comments"},"review_comments":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621/comments"},"review_comment":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/pulls/621/commits"},"statuses":{"href":"https://api.github.com/repos/RS485/LogisticsPipes/statuses/c3bfa36a66e3dfe4297655f911ebd781add18c33"}}}}