{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/40302299","id":40302299,"diff_hunk":"@@ -8,8 +8,21 @@ FTST_IMAGE := $(FTST_TMPDIR)/rkt-inspect.aci\n FTST_IMAGE_MANIFEST_SRC := $(MK_SRCDIR)/image/manifest\n FTST_IMAGE_MANIFEST := $(FTST_IMAGE_DIR)/manifest\n FTST_IMAGE_TEST_DIRS := $(FTST_IMAGE_ROOTFSDIR)/dir1 $(FTST_IMAGE_ROOTFSDIR)/dir2\n+FTST_ACE_MAIN_IMAGE_DIR := $(FTST_TMPDIR)/ace-main\n+FTST_ACE_MAIN_IMAGE_ROOTFSDIR := $(FTST_ACE_MAIN_IMAGE_DIR)/rootfs\n+FTST_ACE_MAIN_IMAGE := $(FTST_TMPDIR)/rkt-ace-validator-main.aci\n+FTST_ACE_MAIN_IMAGE_MANIFEST_SRC := Godeps/_workspace/src/github.com/appc/spec/ace/image_manifest_main.json\n+FTST_ACE_MAIN_IMAGE_MANIFEST := $(FTST_ACE_MAIN_IMAGE_DIR)/manifest\n+FTST_ACE_SIDEKICK_IMAGE_DIR := $(FTST_TMPDIR)/ace-sidekick\n+FTST_ACE_SIDEKICK_IMAGE_ROOTFSDIR := $(FTST_ACE_SIDEKICK_IMAGE_DIR)/rootfs\n+FTST_ACE_SIDEKICK_IMAGE := $(FTST_TMPDIR)/rkt-ace-validator-sidekick.aci\n+FTST_ACE_SIDEKICK_IMAGE_MANIFEST_SRC := Godeps/_workspace/src/github.com/appc/spec/ace/image_manifest_sidekick.json\n+FTST_ACE_SIDEKICK_IMAGE_MANIFEST := $(FTST_ACE_SIDEKICK_IMAGE_DIR)/manifest\n FTST_INSPECT_BINARY := $(FTST_TMPDIR)/inspect\n FTST_ACI_INSPECT := $(FTST_IMAGE_ROOTFSDIR)/inspect\n+FTST_ACE_BINARY := $(FTST_TMPDIR)/ace-validator","path":"tests/functional.mk","position":16,"original_position":16,"commit_id":"a01fc772681d6610e7bf1ad42917d1525dc2ec71","original_commit_id":"a01fc772681d6610e7bf1ad42917d1525dc2ec71","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"`FTST_ACI_BINARY` needs to be added to `CLEAN_FILES`.","created_at":"2015-09-24T09:52:12Z","updated_at":"2015-09-24T09:52:12Z","html_url":"https://github.com/coreos/rkt/pull/1473#discussion_r40302299","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/1473","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/40302299"},"html":{"href":"https://github.com/coreos/rkt/pull/1473#discussion_r40302299"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1473"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1473","id":45875215,"html_url":"https://github.com/coreos/rkt/pull/1473","diff_url":"https://github.com/coreos/rkt/pull/1473.diff","patch_url":"https://github.com/coreos/rkt/pull/1473.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1473","number":1473,"state":"open","locked":false,"title":"functional tests: add ACE validator test","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"body":"Fixes #1218 ","created_at":"2015-09-24T09:21:02Z","updated_at":"2015-09-24T09:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a3b15f50c05395ca47ece33032cc6f7101da8f8","assignee":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/19","html_url":"https://github.com/coreos/rkt/milestones/v0.9.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/19/labels","id":1209255,"number":19,"title":"v0.9.0","description":"","creator":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":48,"state":"open","created_at":"2015-07-15T13:18:47Z","updated_at":"2015-09-24T09:40:32Z","due_on":"2015-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1473/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1473/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1473/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/a01fc772681d6610e7bf1ad42917d1525dc2ec71","head":{"label":"iaguis:ace-test","ref":"ace-test","sha":"a01fc772681d6610e7bf1ad42917d1525dc2ec71","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"repo":{"id":34848570,"name":"rkt","full_name":"iaguis/rkt","owner":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iaguis/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/iaguis/rkt","forks_url":"https://api.github.com/repos/iaguis/rkt/forks","keys_url":"https://api.github.com/repos/iaguis/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iaguis/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iaguis/rkt/teams","hooks_url":"https://api.github.com/repos/iaguis/rkt/hooks","issue_events_url":"https://api.github.com/repos/iaguis/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/iaguis/rkt/events","assignees_url":"https://api.github.com/repos/iaguis/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/iaguis/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/iaguis/rkt/tags","blobs_url":"https://api.github.com/repos/iaguis/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iaguis/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iaguis/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/iaguis/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iaguis/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/iaguis/rkt/languages","stargazers_url":"https://api.github.com/repos/iaguis/rkt/stargazers","contributors_url":"https://api.github.com/repos/iaguis/rkt/contributors","subscribers_url":"https://api.github.com/repos/iaguis/rkt/subscribers","subscription_url":"https://api.github.com/repos/iaguis/rkt/subscription","commits_url":"https://api.github.com/repos/iaguis/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/iaguis/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/iaguis/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/iaguis/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/iaguis/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/iaguis/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iaguis/rkt/merges","archive_url":"https://api.github.com/repos/iaguis/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iaguis/rkt/downloads","issues_url":"https://api.github.com/repos/iaguis/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/iaguis/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/iaguis/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/iaguis/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iaguis/rkt/labels{/name}","releases_url":"https://api.github.com/repos/iaguis/rkt/releases{/id}","created_at":"2015-04-30T10:23:40Z","updated_at":"2015-04-30T10:23:41Z","pushed_at":"2015-09-24T09:20:13Z","git_url":"git://github.com/iaguis/rkt.git","ssh_url":"git@github.com:iaguis/rkt.git","clone_url":"https://github.com/iaguis/rkt.git","svn_url":"https://github.com/iaguis/rkt","homepage":"","size":8099,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"d32b394841efd3091c5f05be3beecfe58c195f0f","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-09-24T08:11:04Z","pushed_at":"2015-09-24T09:21:03Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":18763,"stargazers_count":4681,"watchers_count":4681,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":385,"mirror_url":null,"open_issues_count":174,"forks":385,"open_issues":174,"watchers":4681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1473"},"html":{"href":"https://github.com/coreos/rkt/pull/1473"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1473"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1473/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1473/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1473/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/a01fc772681d6610e7bf1ad42917d1525dc2ec71"}}}}