{"action":"created","issue":{"url":"https://api.github.com/repos/andredumas/techan.js/issues/92","labels_url":"https://api.github.com/repos/andredumas/techan.js/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/andredumas/techan.js/issues/92/comments","events_url":"https://api.github.com/repos/andredumas/techan.js/issues/92/events","html_url":"https://github.com/andredumas/techan.js/issues/92","id":114410577,"number":92,"title":"Breaks on H1 chart when the time is all zero","user":{"login":"gr1212","id":15384750,"avatar_url":"https://avatars.githubusercontent.com/u/15384750?v=3","gravatar_id":"","url":"https://api.github.com/users/gr1212","html_url":"https://github.com/gr1212","followers_url":"https://api.github.com/users/gr1212/followers","following_url":"https://api.github.com/users/gr1212/following{/other_user}","gists_url":"https://api.github.com/users/gr1212/gists{/gist_id}","starred_url":"https://api.github.com/users/gr1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr1212/subscriptions","organizations_url":"https://api.github.com/users/gr1212/orgs","repos_url":"https://api.github.com/users/gr1212/repos","events_url":"https://api.github.com/users/gr1212/events{/privacy}","received_events_url":"https://api.github.com/users/gr1212/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/andredumas/techan.js/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/andredumas/techan.js/labels/duplicate","name":"duplicate","color":"cccccc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-31T13:12:16Z","updated_at":"2015-11-08T08:18:23Z","closed_at":"2015-11-08T06:51:10Z","body":"Hi, \r\nI started with the Candle Stick example (http://bl.ocks.org/andredumas/27c4a333b0e0813e093d) then made the dates work with HH:mm:ss. \r\nIt then fell over if I had a \"00:00:00\" datetime.\r\n\r\nIf use the following date parse function I get an error when the HH:mm:ss are all zero (i.e. \"2015-08-4T00:00:00)\"\r\n\r\nvar parseDate = d3.time.format(\"%Y-%m-%dT%H:%M:%S\").parse,\r\n      timeFormat = d3.time.format('%Y-%m-%dT%H:%M:%S'),\r\n      valueFormat = d3.format(',.5fs');   \r\n\r\nFound a work around: \r\n- Go into techan.js file\r\n- Look for: intraDayFormat = d3_time.format.multi([\r\n- Add the following:  [\"%d-%b-%y 00:00:00\", function (d) { return true; }]\r\nas a new item in the array. \r\n\r\nSo it should now look like this: \r\nintraDayFormat = d3_time.format.multi([\r\n        [\":%S\", function (d) { return d.getSeconds(); }],\r\n        [\"%I:%M\", function (d) { return d.getMinutes(); }],\r\n        [\"%H\", function (d) { return d.getHours(); }],\r\n        [\"%I %p\", function (d) { return d.getHours(); }],\r\n        [\"%d-%b-%y 00:00:00\", function (d) { return true; }]\r\n      ]),\r\n\r\nI'm now able to parse & chart the following dates: \r\n2015-08-24T16:00:00,0.93471,0.93471,0.92577,0.92997,37617413\r\n2015-08-24T17:00:00,0.93,0.93639,0.92904,0.93604,37617413\r\n2015-08-24T18:00:00,0.93606,0.93755,0.93169,0.93489,37617413\r\n2015-08-24T19:00:00,0.93488,0.93874,0.9341,0.93834,37617413\r\n2015-08-24T20:00:00,0.93832,0.93924,0.93519,0.93588,37617413\r\n"},"comment":{"url":"https://api.github.com/repos/andredumas/techan.js/issues/comments/154788723","html_url":"https://github.com/andredumas/techan.js/issues/92#issuecomment-154788723","issue_url":"https://api.github.com/repos/andredumas/techan.js/issues/92","id":154788723,"user":{"login":"gr1212","id":15384750,"avatar_url":"https://avatars.githubusercontent.com/u/15384750?v=3","gravatar_id":"","url":"https://api.github.com/users/gr1212","html_url":"https://github.com/gr1212","followers_url":"https://api.github.com/users/gr1212/followers","following_url":"https://api.github.com/users/gr1212/following{/other_user}","gists_url":"https://api.github.com/users/gr1212/gists{/gist_id}","starred_url":"https://api.github.com/users/gr1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr1212/subscriptions","organizations_url":"https://api.github.com/users/gr1212/orgs","repos_url":"https://api.github.com/users/gr1212/repos","events_url":"https://api.github.com/users/gr1212/events{/privacy}","received_events_url":"https://api.github.com/users/gr1212/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T08:18:23Z","updated_at":"2015-11-08T08:18:23Z","body":"Hi, \r\nThanks for the response. I'm using techan-0.5.0. \r\nWill wait for the next release and upgrade to that. \r\n\r\nThanks :)"}}