{"action":"created","issue":{"url":"https://api.github.com/repos/EdwardRaff/JSAT/issues/5","labels_url":"https://api.github.com/repos/EdwardRaff/JSAT/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/EdwardRaff/JSAT/issues/5/comments","events_url":"https://api.github.com/repos/EdwardRaff/JSAT/issues/5/events","html_url":"https://github.com/EdwardRaff/JSAT/pull/5","id":69585607,"number":5,"title":"(mainly) Java/Javadoc warnings removed","user":{"login":"TKlerx","id":1579185,"avatar_url":"https://avatars.githubusercontent.com/u/1579185?v=3","gravatar_id":"","url":"https://api.github.com/users/TKlerx","html_url":"https://github.com/TKlerx","followers_url":"https://api.github.com/users/TKlerx/followers","following_url":"https://api.github.com/users/TKlerx/following{/other_user}","gists_url":"https://api.github.com/users/TKlerx/gists{/gist_id}","starred_url":"https://api.github.com/users/TKlerx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TKlerx/subscriptions","organizations_url":"https://api.github.com/users/TKlerx/orgs","repos_url":"https://api.github.com/users/TKlerx/repos","events_url":"https://api.github.com/users/TKlerx/events{/privacy}","received_events_url":"https://api.github.com/users/TKlerx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-20T13:21:39Z","updated_at":"2015-04-24T07:02:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EdwardRaff/JSAT/pulls/5","html_url":"https://github.com/EdwardRaff/JSAT/pull/5","diff_url":"https://github.com/EdwardRaff/JSAT/pull/5.diff","patch_url":"https://github.com/EdwardRaff/JSAT/pull/5.patch"},"body":"* fixed javadoc errors/warnings, compile warnings\r\n *html in javadoc\r\n * unused java imports\r\n * missing serialVersionUID\r\n* added SingleValueDistribution to DistributionSearch\r\n* Changed every \"new ArrayList<Double/Integer>\" to new DoubleList/IntList\r\n\r\nSorry for this big pull request. Had to change something in almost every class."},"comment":{"url":"https://api.github.com/repos/EdwardRaff/JSAT/issues/comments/95826286","html_url":"https://github.com/EdwardRaff/JSAT/pull/5#issuecomment-95826286","issue_url":"https://api.github.com/repos/EdwardRaff/JSAT/issues/5","id":95826286,"user":{"login":"TKlerx","id":1579185,"avatar_url":"https://avatars.githubusercontent.com/u/1579185?v=3","gravatar_id":"","url":"https://api.github.com/users/TKlerx","html_url":"https://github.com/TKlerx","followers_url":"https://api.github.com/users/TKlerx/followers","following_url":"https://api.github.com/users/TKlerx/following{/other_user}","gists_url":"https://api.github.com/users/TKlerx/gists{/gist_id}","starred_url":"https://api.github.com/users/TKlerx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TKlerx/subscriptions","organizations_url":"https://api.github.com/users/TKlerx/orgs","repos_url":"https://api.github.com/users/TKlerx/repos","events_url":"https://api.github.com/users/TKlerx/events{/privacy}","received_events_url":"https://api.github.com/users/TKlerx/received_events","type":"User","site_admin":false},"created_at":"2015-04-24T07:02:13Z","updated_at":"2015-04-24T07:02:13Z","body":">Would prefer not to include the SignleValue class though. The functionality should be obtainable from the Uniform dist with a range +- epsilon. However, the SingleValue class can never be a valid probability density function, so two of its methods can never be implemented correctly. This is because the integral from -inf to inf of the pdf where only a single point has a non-zero value can't be = 1. \r\n\r\nDone.\r\n\r\n>There is some code you commented out in DCD.java that I would prefer you put back, as it dosn't hurt and makes the code match the algorithm description (easier to go back and compare in the event of a bug). \r\n\r\nDone.\r\n\r\n>Not major, but whatever you used to modify comments also modified non-javadoc comments, which should really be left alone (& -> & is not helpful in that case). More major is it expanded some occurrences of \"&\" in Strings for the GUI. It also modifed code in the auto-generated blocks, please remove those. \r\n\r\nUsed a RegExpr, but it replaced a bit too much. Sorry! Also done.\r\n\r\n>You've also made some changes to DBSCAN that I don't understand the purpose of. \r\n\r\nMaybe, I use DBSCAN in the wrong way, but I have the following usecase:\r\nI cluster some datapoints with DBSCAN and obtain an assignment.\r\nThen I get some new datapoints and want to know whether they belong to some cluster or whether they are noise points. That's why I need the last vector collection and also need the NOISE constant to be public.\r\n\r\n>What is the purpose of the change to LUPDecomposition linke 84? \r\n\r\nIt removes a findbugs warning: \r\n```Check for oddness that won't work for negative numbers in jsat.linear.LUPDecomposition.det()\r\nThe code uses x % 2 == 1 to check to see if a value is odd, but this won't work for negative numbers (e.g., (-5) % 2 == -1). If this code is intending to check for oddness, consider using x & 1 == 1, or x % 2 != 0.\"```\r\n\r\nI think I also replaced this in some other classes, but I can revert if you want.\r\n\r\n>Please remove the changes to SingularValueDecomposition, unless they are reflecting changes made the the JAMA SVD implementation since the time I modified it. \r\n\r\nDone.\r\n\r\n>In the future it would probably be easier to stick to one thing per pull request. \r\n\r\nYeah, definitely. Big sorry, I am not used to the git workflow, yet.\r\n\r\n"}}