{"action":"created","comment":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/comments/24060898","id":24060898,"diff_hunk":"@@ -54,6 +54,8 @@ protected int submit(String name, Config conf, TopologyBuilder builder) {\n         }\n \n         else {\n+            // register Metadata for serialization with FieldsSerializer\n+            Config.registerSerialization(conf, Metadata.class);","path":"core/src/main/java/com/digitalpebble/storm/crawler/ConfigurableTopology.java","position":5,"original_position":5,"commit_id":"83d6ad35080ad55e3586895be16fc736a46564ad","original_commit_id":"83d6ad35080ad55e3586895be16fc736a46564ad","user":{"login":"GuiForget","id":2585258,"avatar_url":"https://avatars.githubusercontent.com/u/2585258?v=3","gravatar_id":"","url":"https://api.github.com/users/GuiForget","html_url":"https://github.com/GuiForget","followers_url":"https://api.github.com/users/GuiForget/followers","following_url":"https://api.github.com/users/GuiForget/following{/other_user}","gists_url":"https://api.github.com/users/GuiForget/gists{/gist_id}","starred_url":"https://api.github.com/users/GuiForget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuiForget/subscriptions","organizations_url":"https://api.github.com/users/GuiForget/orgs","repos_url":"https://api.github.com/users/GuiForget/repos","events_url":"https://api.github.com/users/GuiForget/events{/privacy}","received_events_url":"https://api.github.com/users/GuiForget/received_events","type":"User","site_admin":false},"body":"There's also a non static registerSerialization on the Config object","created_at":"2015-02-04T03:38:59Z","updated_at":"2015-02-04T03:38:59Z","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/78#discussion_r24060898","pull_request_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/comments/24060898"},"html":{"href":"https://github.com/DigitalPebble/storm-crawler/pull/78#discussion_r24060898"},"pull_request":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78","id":28268031,"html_url":"https://github.com/DigitalPebble/storm-crawler/pull/78","diff_url":"https://github.com/DigitalPebble/storm-crawler/pull/78.diff","patch_url":"https://github.com/DigitalPebble/storm-crawler/pull/78.patch","issue_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/78","number":78,"state":"open","locked":false,"title":"Replace Map<String,String[]> with serializable Metadata in Fetcher and protocol","user":{"login":"jnioche","id":218319,"avatar_url":"https://avatars.githubusercontent.com/u/218319?v=3","gravatar_id":"","url":"https://api.github.com/users/jnioche","html_url":"https://github.com/jnioche","followers_url":"https://api.github.com/users/jnioche/followers","following_url":"https://api.github.com/users/jnioche/following{/other_user}","gists_url":"https://api.github.com/users/jnioche/gists{/gist_id}","starred_url":"https://api.github.com/users/jnioche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnioche/subscriptions","organizations_url":"https://api.github.com/users/jnioche/orgs","repos_url":"https://api.github.com/users/jnioche/repos","events_url":"https://api.github.com/users/jnioche/events{/privacy}","received_events_url":"https://api.github.com/users/jnioche/received_events","type":"User","site_admin":false},"body":"The bolts still emit Map<String,String[]> to the subsequent bolts for now.\r\n\r\nReplaces #36 \r\n\r\nStill need to port to other parts of the code but we can already discuss possible improvements to it now. \r\n\r\n","created_at":"2015-01-29T10:31:19Z","updated_at":"2015-02-04T03:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c14a29ff387b8cad991005685ab4f6f3863fb35b","assignee":null,"milestone":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/milestones/2","labels_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/milestones/2/labels","id":909889,"number":2,"title":"0.5","description":"0.5 release","creator":{"login":"jnioche","id":218319,"avatar_url":"https://avatars.githubusercontent.com/u/218319?v=3","gravatar_id":"","url":"https://api.github.com/users/jnioche","html_url":"https://github.com/jnioche","followers_url":"https://api.github.com/users/jnioche/followers","following_url":"https://api.github.com/users/jnioche/following{/other_user}","gists_url":"https://api.github.com/users/jnioche/gists{/gist_id}","starred_url":"https://api.github.com/users/jnioche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnioche/subscriptions","organizations_url":"https://api.github.com/users/jnioche/orgs","repos_url":"https://api.github.com/users/jnioche/repos","events_url":"https://api.github.com/users/jnioche/events{/privacy}","received_events_url":"https://api.github.com/users/jnioche/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2014-12-19T10:16:09Z","updated_at":"2015-01-31T15:56:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78/commits","review_comments_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78/comments","review_comment_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/78/comments","statuses_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/statuses/83d6ad35080ad55e3586895be16fc736a46564ad","head":{"label":"DigitalPebble:metadata2","ref":"metadata2","sha":"83d6ad35080ad55e3586895be16fc736a46564ad","user":{"login":"DigitalPebble","id":1726647,"avatar_url":"https://avatars.githubusercontent.com/u/1726647?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalPebble","html_url":"https://github.com/DigitalPebble","followers_url":"https://api.github.com/users/DigitalPebble/followers","following_url":"https://api.github.com/users/DigitalPebble/following{/other_user}","gists_url":"https://api.github.com/users/DigitalPebble/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalPebble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalPebble/subscriptions","organizations_url":"https://api.github.com/users/DigitalPebble/orgs","repos_url":"https://api.github.com/users/DigitalPebble/repos","events_url":"https://api.github.com/users/DigitalPebble/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalPebble/received_events","type":"Organization","site_admin":false},"repo":{"id":9395761,"name":"storm-crawler","full_name":"DigitalPebble/storm-crawler","owner":{"login":"DigitalPebble","id":1726647,"avatar_url":"https://avatars.githubusercontent.com/u/1726647?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalPebble","html_url":"https://github.com/DigitalPebble","followers_url":"https://api.github.com/users/DigitalPebble/followers","following_url":"https://api.github.com/users/DigitalPebble/following{/other_user}","gists_url":"https://api.github.com/users/DigitalPebble/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalPebble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalPebble/subscriptions","organizations_url":"https://api.github.com/users/DigitalPebble/orgs","repos_url":"https://api.github.com/users/DigitalPebble/repos","events_url":"https://api.github.com/users/DigitalPebble/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalPebble/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigitalPebble/storm-crawler","description":"Storm-based web crawler ","fork":false,"url":"https://api.github.com/repos/DigitalPebble/storm-crawler","forks_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/forks","keys_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/teams","hooks_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/hooks","issue_events_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/events","assignees_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/tags","blobs_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/languages","stargazers_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/stargazers","contributors_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/contributors","subscribers_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/subscribers","subscription_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/subscription","commits_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/comments/{number}","contents_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/merges","archive_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/downloads","issues_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/labels{/name}","releases_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/releases{/id}","created_at":"2013-04-12T14:13:30Z","updated_at":"2015-02-03T19:24:07Z","pushed_at":"2015-02-03T19:24:07Z","git_url":"git://github.com/DigitalPebble/storm-crawler.git","ssh_url":"git@github.com:DigitalPebble/storm-crawler.git","clone_url":"https://github.com/DigitalPebble/storm-crawler.git","svn_url":"https://github.com/DigitalPebble/storm-crawler","homepage":"","size":2242,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":46,"default_branch":"master"}},"base":{"label":"DigitalPebble:master","ref":"master","sha":"60b0ba35e8d0c2c47975d42a2bfede886d3fec7f","user":{"login":"DigitalPebble","id":1726647,"avatar_url":"https://avatars.githubusercontent.com/u/1726647?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalPebble","html_url":"https://github.com/DigitalPebble","followers_url":"https://api.github.com/users/DigitalPebble/followers","following_url":"https://api.github.com/users/DigitalPebble/following{/other_user}","gists_url":"https://api.github.com/users/DigitalPebble/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalPebble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalPebble/subscriptions","organizations_url":"https://api.github.com/users/DigitalPebble/orgs","repos_url":"https://api.github.com/users/DigitalPebble/repos","events_url":"https://api.github.com/users/DigitalPebble/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalPebble/received_events","type":"Organization","site_admin":false},"repo":{"id":9395761,"name":"storm-crawler","full_name":"DigitalPebble/storm-crawler","owner":{"login":"DigitalPebble","id":1726647,"avatar_url":"https://avatars.githubusercontent.com/u/1726647?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalPebble","html_url":"https://github.com/DigitalPebble","followers_url":"https://api.github.com/users/DigitalPebble/followers","following_url":"https://api.github.com/users/DigitalPebble/following{/other_user}","gists_url":"https://api.github.com/users/DigitalPebble/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalPebble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalPebble/subscriptions","organizations_url":"https://api.github.com/users/DigitalPebble/orgs","repos_url":"https://api.github.com/users/DigitalPebble/repos","events_url":"https://api.github.com/users/DigitalPebble/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalPebble/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigitalPebble/storm-crawler","description":"Storm-based web crawler ","fork":false,"url":"https://api.github.com/repos/DigitalPebble/storm-crawler","forks_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/forks","keys_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/teams","hooks_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/hooks","issue_events_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/events","assignees_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/tags","blobs_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/languages","stargazers_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/stargazers","contributors_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/contributors","subscribers_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/subscribers","subscription_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/subscription","commits_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/comments/{number}","contents_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/merges","archive_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/downloads","issues_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/labels{/name}","releases_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/releases{/id}","created_at":"2013-04-12T14:13:30Z","updated_at":"2015-02-03T19:24:07Z","pushed_at":"2015-02-03T19:24:07Z","git_url":"git://github.com/DigitalPebble/storm-crawler.git","ssh_url":"git@github.com:DigitalPebble/storm-crawler.git","clone_url":"https://github.com/DigitalPebble/storm-crawler.git","svn_url":"https://github.com/DigitalPebble/storm-crawler","homepage":"","size":2242,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78"},"html":{"href":"https://github.com/DigitalPebble/storm-crawler/pull/78"},"issue":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/78"},"comments":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/DigitalPebble/storm-crawler/statuses/83d6ad35080ad55e3586895be16fc736a46564ad"}}}}