{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/rocket/issues/546","labels_url":"https://api.github.com/repos/coreos/rocket/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/coreos/rocket/issues/546/comments","events_url":"https://api.github.com/repos/coreos/rocket/issues/546/events","html_url":"https://github.com/coreos/rocket/pull/546","id":58591458,"number":546,"title":"stage1: prepare-app: prepare /dev and /proc for apps","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-23T14:22:41Z","updated_at":"2015-02-26T09:56:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/rocket/pulls/546","html_url":"https://github.com/coreos/rocket/pull/546","diff_url":"https://github.com/coreos/rocket/pull/546.diff","patch_url":"https://github.com/coreos/rocket/pull/546.patch"},"body":"This PR supersedes #540\r\n\r\nprepare-app runs in stage1, so it knows how to handle dynamic\r\n/dev/console.\r\n\r\nIt does not change diagexec so it does not break rkt enter.\r\n\r\nBind mount individual /dev entries instead of bind mounting the /dev\r\ndirectory so rkt run --volume /dev/sda6 (performed in stage0) should\r\nstill work.\r\n\r\nDo not use a bunch of systemd mount units because they don't create\r\nnonexistent target files. See:\r\nhttp://lists.freedesktop.org/archives/systemd-devel/2015-February/028657.html\r\nWe might revisit this option if systemd mount units automatically create\r\nthe nonexistent target files.\r\n\r\nAvoid systemd option PrivateDevices to avoid shadowing additional bind\r\nmounts passed with --volume."},"comment":{"url":"https://api.github.com/repos/coreos/rocket/issues/comments/76150723","html_url":"https://github.com/coreos/rocket/pull/546#issuecomment-76150723","issue_url":"https://api.github.com/repos/coreos/rocket/issues/546","id":76150723,"user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"created_at":"2015-02-26T09:56:48Z","updated_at":"2015-02-26T09:56:48Z","body":"@vcaputo thanks for the review. I pushed a new version."}}