{"action":"created","comment":{"url":"https://api.github.com/repos/talis/tripod-php/pulls/comments/33962037","id":33962037,"diff_hunk":"@@ -659,6 +668,75 @@ protected function applyChangeSet(\\Tripod\\ChangeSet $cs, $originalCBDs, $context\n         }\n     }\n \n+    private function getAdditionsRemovalsGroupedByNsPredicate($cs,$additions,$removals)","path":"src/mongo/delegates/Updates.class.php","position":234,"original_position":234,"commit_id":"aae72fb6c752dd387626d467af8e7bd9495dd414","original_commit_id":"aae72fb6c752dd387626d467af8e7bd9495dd414","user":{"login":"rsinger","id":72548,"avatar_url":"https://avatars.githubusercontent.com/u/72548?v=3","gravatar_id":"","url":"https://api.github.com/users/rsinger","html_url":"https://github.com/rsinger","followers_url":"https://api.github.com/users/rsinger/followers","following_url":"https://api.github.com/users/rsinger/following{/other_user}","gists_url":"https://api.github.com/users/rsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/rsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsinger/subscriptions","organizations_url":"https://api.github.com/users/rsinger/orgs","repos_url":"https://api.github.com/users/rsinger/repos","events_url":"https://api.github.com/users/rsinger/events{/privacy}","received_events_url":"https://api.github.com/users/rsinger/received_events","type":"User","site_admin":false},"body":"More 70% feedback here, but some type hinting on these.  In the interest of this code review, I'm assuming it's ChangeSet, Array, Array","created_at":"2015-07-06T17:51:53Z","updated_at":"2015-07-06T17:51:53Z","html_url":"https://github.com/talis/tripod-php/pull/71#discussion_r33962037","pull_request_url":"https://api.github.com/repos/talis/tripod-php/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/talis/tripod-php/pulls/comments/33962037"},"html":{"href":"https://github.com/talis/tripod-php/pull/71#discussion_r33962037"},"pull_request":{"href":"https://api.github.com/repos/talis/tripod-php/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/talis/tripod-php/pulls/71","id":39282802,"html_url":"https://github.com/talis/tripod-php/pull/71","diff_url":"https://github.com/talis/tripod-php/pull/71.diff","patch_url":"https://github.com/talis/tripod-php/pull/71.patch","issue_url":"https://api.github.com/repos/talis/tripod-php/issues/71","number":71,"state":"open","locked":false,"title":"30% - In place updates","user":{"login":"robotrobot","id":933278,"avatar_url":"https://avatars.githubusercontent.com/u/933278?v=3","gravatar_id":"","url":"https://api.github.com/users/robotrobot","html_url":"https://github.com/robotrobot","followers_url":"https://api.github.com/users/robotrobot/followers","following_url":"https://api.github.com/users/robotrobot/following{/other_user}","gists_url":"https://api.github.com/users/robotrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/robotrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotrobot/subscriptions","organizations_url":"https://api.github.com/users/robotrobot/orgs","repos_url":"https://api.github.com/users/robotrobot/repos","events_url":"https://api.github.com/users/robotrobot/events{/privacy}","received_events_url":"https://api.github.com/users/robotrobot/received_events","type":"User","site_admin":false},"body":"On very large target graphs, the seriali(s|z)ation inside `Updates::applyChangeSet()` gave an unacceptable performance overhead, especially if just one or two triples were being updated.\r\n\r\nThis PR deals with the native mongodoc format in there, chucking the graphs, and also implementing in-place updates whilst we're there for good measure","created_at":"2015-07-06T15:58:09Z","updated_at":"2015-07-06T17:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06e91b159c5ca11632ad31afe536dd74612a27a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/talis/tripod-php/pulls/71/commits","review_comments_url":"https://api.github.com/repos/talis/tripod-php/pulls/71/comments","review_comment_url":"https://api.github.com/repos/talis/tripod-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/talis/tripod-php/issues/71/comments","statuses_url":"https://api.github.com/repos/talis/tripod-php/statuses/aae72fb6c752dd387626d467af8e7bd9495dd414","head":{"label":"talis:in-place-updates","ref":"in-place-updates","sha":"aae72fb6c752dd387626d467af8e7bd9495dd414","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":17243040,"name":"tripod-php","full_name":"talis/tripod-php","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/tripod-php","description":"Object Graph Mapper for managing RDF data in Mongo","fork":false,"url":"https://api.github.com/repos/talis/tripod-php","forks_url":"https://api.github.com/repos/talis/tripod-php/forks","keys_url":"https://api.github.com/repos/talis/tripod-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/tripod-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/tripod-php/teams","hooks_url":"https://api.github.com/repos/talis/tripod-php/hooks","issue_events_url":"https://api.github.com/repos/talis/tripod-php/issues/events{/number}","events_url":"https://api.github.com/repos/talis/tripod-php/events","assignees_url":"https://api.github.com/repos/talis/tripod-php/assignees{/user}","branches_url":"https://api.github.com/repos/talis/tripod-php/branches{/branch}","tags_url":"https://api.github.com/repos/talis/tripod-php/tags","blobs_url":"https://api.github.com/repos/talis/tripod-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/tripod-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/tripod-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/tripod-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/tripod-php/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/tripod-php/languages","stargazers_url":"https://api.github.com/repos/talis/tripod-php/stargazers","contributors_url":"https://api.github.com/repos/talis/tripod-php/contributors","subscribers_url":"https://api.github.com/repos/talis/tripod-php/subscribers","subscription_url":"https://api.github.com/repos/talis/tripod-php/subscription","commits_url":"https://api.github.com/repos/talis/tripod-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/tripod-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/tripod-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/tripod-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/tripod-php/contents/{+path}","compare_url":"https://api.github.com/repos/talis/tripod-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/tripod-php/merges","archive_url":"https://api.github.com/repos/talis/tripod-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/tripod-php/downloads","issues_url":"https://api.github.com/repos/talis/tripod-php/issues{/number}","pulls_url":"https://api.github.com/repos/talis/tripod-php/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/tripod-php/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/tripod-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/tripod-php/labels{/name}","releases_url":"https://api.github.com/repos/talis/tripod-php/releases{/id}","created_at":"2014-02-27T09:09:51Z","updated_at":"2015-04-24T13:28:31Z","pushed_at":"2015-07-06T15:58:09Z","git_url":"git://github.com/talis/tripod-php.git","ssh_url":"git@github.com:talis/tripod-php.git","clone_url":"https://github.com/talis/tripod-php.git","svn_url":"https://github.com/talis/tripod-php","homepage":"","size":2951,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":19,"default_branch":"master"}},"base":{"label":"talis:master","ref":"master","sha":"3c73c7e20f10608028de7fb4f4df4111e5190d3b","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":17243040,"name":"tripod-php","full_name":"talis/tripod-php","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/tripod-php","description":"Object Graph Mapper for managing RDF data in Mongo","fork":false,"url":"https://api.github.com/repos/talis/tripod-php","forks_url":"https://api.github.com/repos/talis/tripod-php/forks","keys_url":"https://api.github.com/repos/talis/tripod-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/tripod-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/tripod-php/teams","hooks_url":"https://api.github.com/repos/talis/tripod-php/hooks","issue_events_url":"https://api.github.com/repos/talis/tripod-php/issues/events{/number}","events_url":"https://api.github.com/repos/talis/tripod-php/events","assignees_url":"https://api.github.com/repos/talis/tripod-php/assignees{/user}","branches_url":"https://api.github.com/repos/talis/tripod-php/branches{/branch}","tags_url":"https://api.github.com/repos/talis/tripod-php/tags","blobs_url":"https://api.github.com/repos/talis/tripod-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/tripod-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/tripod-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/tripod-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/tripod-php/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/tripod-php/languages","stargazers_url":"https://api.github.com/repos/talis/tripod-php/stargazers","contributors_url":"https://api.github.com/repos/talis/tripod-php/contributors","subscribers_url":"https://api.github.com/repos/talis/tripod-php/subscribers","subscription_url":"https://api.github.com/repos/talis/tripod-php/subscription","commits_url":"https://api.github.com/repos/talis/tripod-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/tripod-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/tripod-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/tripod-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/tripod-php/contents/{+path}","compare_url":"https://api.github.com/repos/talis/tripod-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/tripod-php/merges","archive_url":"https://api.github.com/repos/talis/tripod-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/tripod-php/downloads","issues_url":"https://api.github.com/repos/talis/tripod-php/issues{/number}","pulls_url":"https://api.github.com/repos/talis/tripod-php/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/tripod-php/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/tripod-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/tripod-php/labels{/name}","releases_url":"https://api.github.com/repos/talis/tripod-php/releases{/id}","created_at":"2014-02-27T09:09:51Z","updated_at":"2015-04-24T13:28:31Z","pushed_at":"2015-07-06T15:58:09Z","git_url":"git://github.com/talis/tripod-php.git","ssh_url":"git@github.com:talis/tripod-php.git","clone_url":"https://github.com/talis/tripod-php.git","svn_url":"https://github.com/talis/tripod-php","homepage":"","size":2951,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/talis/tripod-php/pulls/71"},"html":{"href":"https://github.com/talis/tripod-php/pull/71"},"issue":{"href":"https://api.github.com/repos/talis/tripod-php/issues/71"},"comments":{"href":"https://api.github.com/repos/talis/tripod-php/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/talis/tripod-php/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/talis/tripod-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/talis/tripod-php/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/talis/tripod-php/statuses/aae72fb6c752dd387626d467af8e7bd9495dd414"}}}}