{"action":"created","comment":{"url":"https://api.github.com/repos/randoop/randoop/pulls/comments/46007721","id":46007721,"diff_hunk":"@@ -0,0 +1,50 @@\n+package randoop.types;\n+\n+import randoop.util.PrimitiveTypes;\n+\n+import plume.UtilMDE;\n+\n+public class TypeNames {\n+  \n+  /**\n+   * Generates a name for the given type in a format that can be compiled.\n+   * \n+   * @param cls is the type for which name is to be generated.\n+   * @return string that is a compilable version of type name.\n+   */\n+  public static String getCompilableName(Class<?> cls) {","path":"src/randoop/types/TypeNames.java","position":15,"original_position":15,"commit_id":"3046cf85a69928f1461a45f795b2cb9848539d6a","original_commit_id":"3046cf85a69928f1461a45f795b2cb9848539d6a","user":{"login":"mernst","id":121025,"avatar_url":"https://avatars.githubusercontent.com/u/121025?v=3","gravatar_id":"","url":"https://api.github.com/users/mernst","html_url":"https://github.com/mernst","followers_url":"https://api.github.com/users/mernst/followers","following_url":"https://api.github.com/users/mernst/following{/other_user}","gists_url":"https://api.github.com/users/mernst/gists{/gist_id}","starred_url":"https://api.github.com/users/mernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mernst/subscriptions","organizations_url":"https://api.github.com/users/mernst/orgs","repos_url":"https://api.github.com/users/mernst/repos","events_url":"https://api.github.com/users/mernst/events{/privacy}","received_events_url":"https://api.github.com/users/mernst/received_events","type":"User","site_admin":false},"body":"This does not return a result in compilable form.  It looks like it returns it in some variant of JVML form, but I'm not sure what format it actually returns.  Please use a precise term such as \"field descriptor\", \"binary name\", \"fully-qualified name\", etc. rather than JVML format or compilable form.  A brief description of the four (!) formats defined by Java appears at http://types.cs.washington.edu/checker-framework/current/checker-framework-manual.html#signature-annotations .\r\nAlso, is there a need to re-implement what exists in other packages?  For example, could you use plume-lib's `fieldDescriptorToBinaryName` (if that is what this is doing, but I now think it's not)?  Or should we add more methods that do the desired conversion, to some library?  (Maybe plume-lib should have a comprehensive ClassNames class that defines all possible conversions, or maybe some other library already does.)","created_at":"2015-11-26T21:37:39Z","updated_at":"2015-11-26T21:37:39Z","html_url":"https://github.com/randoop/randoop/pull/67#discussion_r46007721","pull_request_url":"https://api.github.com/repos/randoop/randoop/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/randoop/randoop/pulls/comments/46007721"},"html":{"href":"https://github.com/randoop/randoop/pull/67#discussion_r46007721"},"pull_request":{"href":"https://api.github.com/repos/randoop/randoop/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/randoop/randoop/pulls/67","id":51830522,"html_url":"https://github.com/randoop/randoop/pull/67","diff_url":"https://github.com/randoop/randoop/pull/67.diff","patch_url":"https://github.com/randoop/randoop/pull/67.patch","issue_url":"https://api.github.com/repos/randoop/randoop/issues/67","number":67,"state":"open","locked":false,"title":"For Review: st-refactor changes from 11/24","user":{"login":"bjkeller","id":5479869,"avatar_url":"https://avatars.githubusercontent.com/u/5479869?v=3","gravatar_id":"","url":"https://api.github.com/users/bjkeller","html_url":"https://github.com/bjkeller","followers_url":"https://api.github.com/users/bjkeller/followers","following_url":"https://api.github.com/users/bjkeller/following{/other_user}","gists_url":"https://api.github.com/users/bjkeller/gists{/gist_id}","starred_url":"https://api.github.com/users/bjkeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjkeller/subscriptions","organizations_url":"https://api.github.com/users/bjkeller/orgs","repos_url":"https://api.github.com/users/bjkeller/repos","events_url":"https://api.github.com/users/bjkeller/events{/privacy}","received_events_url":"https://api.github.com/users/bjkeller/received_events","type":"User","site_admin":false},"body":"This is current set of changes based one comments to PR65","created_at":"2015-11-25T18:30:15Z","updated_at":"2015-11-26T21:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa3885208f48cc3b21e4414085b02968a5f8eef1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/randoop/randoop/pulls/67/commits","review_comments_url":"https://api.github.com/repos/randoop/randoop/pulls/67/comments","review_comment_url":"https://api.github.com/repos/randoop/randoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/randoop/randoop/issues/67/comments","statuses_url":"https://api.github.com/repos/randoop/randoop/statuses/3046cf85a69928f1461a45f795b2cb9848539d6a","head":{"label":"randoop:st-refactor-review","ref":"st-refactor-review","sha":"3046cf85a69928f1461a45f795b2cb9848539d6a","user":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"repo":{"id":34923107,"name":"randoop","full_name":"randoop/randoop","owner":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/randoop/randoop","description":"Automatic test generation for Java","fork":false,"url":"https://api.github.com/repos/randoop/randoop","forks_url":"https://api.github.com/repos/randoop/randoop/forks","keys_url":"https://api.github.com/repos/randoop/randoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randoop/randoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randoop/randoop/teams","hooks_url":"https://api.github.com/repos/randoop/randoop/hooks","issue_events_url":"https://api.github.com/repos/randoop/randoop/issues/events{/number}","events_url":"https://api.github.com/repos/randoop/randoop/events","assignees_url":"https://api.github.com/repos/randoop/randoop/assignees{/user}","branches_url":"https://api.github.com/repos/randoop/randoop/branches{/branch}","tags_url":"https://api.github.com/repos/randoop/randoop/tags","blobs_url":"https://api.github.com/repos/randoop/randoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randoop/randoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randoop/randoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/randoop/randoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randoop/randoop/statuses/{sha}","languages_url":"https://api.github.com/repos/randoop/randoop/languages","stargazers_url":"https://api.github.com/repos/randoop/randoop/stargazers","contributors_url":"https://api.github.com/repos/randoop/randoop/contributors","subscribers_url":"https://api.github.com/repos/randoop/randoop/subscribers","subscription_url":"https://api.github.com/repos/randoop/randoop/subscription","commits_url":"https://api.github.com/repos/randoop/randoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/randoop/randoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/randoop/randoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/randoop/randoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/randoop/randoop/contents/{+path}","compare_url":"https://api.github.com/repos/randoop/randoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randoop/randoop/merges","archive_url":"https://api.github.com/repos/randoop/randoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randoop/randoop/downloads","issues_url":"https://api.github.com/repos/randoop/randoop/issues{/number}","pulls_url":"https://api.github.com/repos/randoop/randoop/pulls{/number}","milestones_url":"https://api.github.com/repos/randoop/randoop/milestones{/number}","notifications_url":"https://api.github.com/repos/randoop/randoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randoop/randoop/labels{/name}","releases_url":"https://api.github.com/repos/randoop/randoop/releases{/id}","created_at":"2015-05-01T20:42:29Z","updated_at":"2015-11-24T03:55:26Z","pushed_at":"2015-11-25T23:47:21Z","git_url":"git://github.com/randoop/randoop.git","ssh_url":"git@github.com:randoop/randoop.git","clone_url":"https://github.com/randoop/randoop.git","svn_url":"https://github.com/randoop/randoop","homepage":"http://randoop.github.io/randoop/","size":349389,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":14,"default_branch":"master"}},"base":{"label":"randoop:master","ref":"master","sha":"a02c100facb6449c9106132afabdd6a244fa9239","user":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"repo":{"id":34923107,"name":"randoop","full_name":"randoop/randoop","owner":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/randoop/randoop","description":"Automatic test generation for Java","fork":false,"url":"https://api.github.com/repos/randoop/randoop","forks_url":"https://api.github.com/repos/randoop/randoop/forks","keys_url":"https://api.github.com/repos/randoop/randoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randoop/randoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randoop/randoop/teams","hooks_url":"https://api.github.com/repos/randoop/randoop/hooks","issue_events_url":"https://api.github.com/repos/randoop/randoop/issues/events{/number}","events_url":"https://api.github.com/repos/randoop/randoop/events","assignees_url":"https://api.github.com/repos/randoop/randoop/assignees{/user}","branches_url":"https://api.github.com/repos/randoop/randoop/branches{/branch}","tags_url":"https://api.github.com/repos/randoop/randoop/tags","blobs_url":"https://api.github.com/repos/randoop/randoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randoop/randoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randoop/randoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/randoop/randoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randoop/randoop/statuses/{sha}","languages_url":"https://api.github.com/repos/randoop/randoop/languages","stargazers_url":"https://api.github.com/repos/randoop/randoop/stargazers","contributors_url":"https://api.github.com/repos/randoop/randoop/contributors","subscribers_url":"https://api.github.com/repos/randoop/randoop/subscribers","subscription_url":"https://api.github.com/repos/randoop/randoop/subscription","commits_url":"https://api.github.com/repos/randoop/randoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/randoop/randoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/randoop/randoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/randoop/randoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/randoop/randoop/contents/{+path}","compare_url":"https://api.github.com/repos/randoop/randoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randoop/randoop/merges","archive_url":"https://api.github.com/repos/randoop/randoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randoop/randoop/downloads","issues_url":"https://api.github.com/repos/randoop/randoop/issues{/number}","pulls_url":"https://api.github.com/repos/randoop/randoop/pulls{/number}","milestones_url":"https://api.github.com/repos/randoop/randoop/milestones{/number}","notifications_url":"https://api.github.com/repos/randoop/randoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randoop/randoop/labels{/name}","releases_url":"https://api.github.com/repos/randoop/randoop/releases{/id}","created_at":"2015-05-01T20:42:29Z","updated_at":"2015-11-24T03:55:26Z","pushed_at":"2015-11-25T23:47:21Z","git_url":"git://github.com/randoop/randoop.git","ssh_url":"git@github.com:randoop/randoop.git","clone_url":"https://github.com/randoop/randoop.git","svn_url":"https://github.com/randoop/randoop","homepage":"http://randoop.github.io/randoop/","size":349389,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/randoop/randoop/pulls/67"},"html":{"href":"https://github.com/randoop/randoop/pull/67"},"issue":{"href":"https://api.github.com/repos/randoop/randoop/issues/67"},"comments":{"href":"https://api.github.com/repos/randoop/randoop/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/randoop/randoop/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/randoop/randoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/randoop/randoop/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/randoop/randoop/statuses/3046cf85a69928f1461a45f795b2cb9848539d6a"}}}}