{"action":"created","issue":{"url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/4","labels_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/4/comments","events_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/4/events","html_url":"https://github.com/walkermatt/ol3-popup/issues/4","id":65242010,"number":4,"title":"This is more of a concern than an issue: why not make this a closure component?","user":{"login":"ca0v","id":1585764,"avatar_url":"https://avatars.githubusercontent.com/u/1585764?v=3","gravatar_id":"","url":"https://api.github.com/users/ca0v","html_url":"https://github.com/ca0v","followers_url":"https://api.github.com/users/ca0v/followers","following_url":"https://api.github.com/users/ca0v/following{/other_user}","gists_url":"https://api.github.com/users/ca0v/gists{/gist_id}","starred_url":"https://api.github.com/users/ca0v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca0v/subscriptions","organizations_url":"https://api.github.com/users/ca0v/orgs","repos_url":"https://api.github.com/users/ca0v/repos","events_url":"https://api.github.com/users/ca0v/events{/privacy}","received_events_url":"https://api.github.com/users/ca0v/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-30T15:47:40Z","updated_at":"2015-11-10T07:32:20Z","closed_at":"2015-11-10T07:32:20Z","body":"The ol library files all begin with goog.provide(nameOfModule).  I think it would make sense for extension developers to make their modules closure compatible  I personally dislike the fact that OL3 is build upon closure instead of AMD so a fix like this would be just fine with me:\r\n\r\n    define(function() {\r\n    ol.Overlay.Popup = function(opt_options) {\r\n        ...\r\n        return ol.Overlay.Popup;\r\n    });"},"comment":{"url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/comments/155345176","html_url":"https://github.com/walkermatt/ol3-popup/issues/4#issuecomment-155345176","issue_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/4","id":155345176,"user":{"login":"walkermatt","id":600349,"avatar_url":"https://avatars.githubusercontent.com/u/600349?v=3","gravatar_id":"","url":"https://api.github.com/users/walkermatt","html_url":"https://github.com/walkermatt","followers_url":"https://api.github.com/users/walkermatt/followers","following_url":"https://api.github.com/users/walkermatt/following{/other_user}","gists_url":"https://api.github.com/users/walkermatt/gists{/gist_id}","starred_url":"https://api.github.com/users/walkermatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkermatt/subscriptions","organizations_url":"https://api.github.com/users/walkermatt/orgs","repos_url":"https://api.github.com/users/walkermatt/repos","events_url":"https://api.github.com/users/walkermatt/events{/privacy}","received_events_url":"https://api.github.com/users/walkermatt/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T07:32:20Z","updated_at":"2015-11-10T07:32:20Z","body":"Closing this as OL3 is gradually looking to remove the dependency on Google Closure, see: https://github.com/openlayers/ol3/issues/4128"}}