{"action":"opened","number":1626,"pull_request":{"url":"https://api.github.com/repos/rancher/rancher/pulls/1626","id":40632384,"html_url":"https://github.com/rancher/rancher/pull/1626","diff_url":"https://github.com/rancher/rancher/pull/1626.diff","patch_url":"https://github.com/rancher/rancher/pull/1626.patch","issue_url":"https://api.github.com/repos/rancher/rancher/issues/1626","number":1626,"state":"open","locked":false,"title":"Hardening the verify funcition of run,sh","user":{"login":"cnzg","id":12028743,"avatar_url":"https://avatars.githubusercontent.com/u/12028743?v=3","gravatar_id":"","url":"https://api.github.com/users/cnzg","html_url":"https://github.com/cnzg","followers_url":"https://api.github.com/users/cnzg/followers","following_url":"https://api.github.com/users/cnzg/following{/other_user}","gists_url":"https://api.github.com/users/cnzg/gists{/gist_id}","starred_url":"https://api.github.com/users/cnzg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnzg/subscriptions","organizations_url":"https://api.github.com/users/cnzg/orgs","repos_url":"https://api.github.com/users/cnzg/repos","events_url":"https://api.github.com/users/cnzg/events{/privacy}","received_events_url":"https://api.github.com/users/cnzg/received_events","type":"User","site_admin":false},"body":"Because i have developed the Shell coding standard for my Product Line, \r\n\r\nso when i review this shell script, i found some function is not strong enough, such as verify_docker_client_server_version.\r\n\r\nsure, i have test it, pls review:)","created_at":"2015-07-23T02:46:01Z","updated_at":"2015-07-23T02:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rancher/rancher/pulls/1626/commits","review_comments_url":"https://api.github.com/repos/rancher/rancher/pulls/1626/comments","review_comment_url":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/rancher/issues/1626/comments","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/04c63fb10fc9f22625617df729aca88a503732b5","head":{"label":"cnzg:master","ref":"master","sha":"04c63fb10fc9f22625617df729aca88a503732b5","user":{"login":"cnzg","id":12028743,"avatar_url":"https://avatars.githubusercontent.com/u/12028743?v=3","gravatar_id":"","url":"https://api.github.com/users/cnzg","html_url":"https://github.com/cnzg","followers_url":"https://api.github.com/users/cnzg/followers","following_url":"https://api.github.com/users/cnzg/following{/other_user}","gists_url":"https://api.github.com/users/cnzg/gists{/gist_id}","starred_url":"https://api.github.com/users/cnzg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnzg/subscriptions","organizations_url":"https://api.github.com/users/cnzg/orgs","repos_url":"https://api.github.com/users/cnzg/repos","events_url":"https://api.github.com/users/cnzg/events{/privacy}","received_events_url":"https://api.github.com/users/cnzg/received_events","type":"User","site_admin":false},"repo":{"id":39540587,"name":"rancher","full_name":"cnzg/rancher","owner":{"login":"cnzg","id":12028743,"avatar_url":"https://avatars.githubusercontent.com/u/12028743?v=3","gravatar_id":"","url":"https://api.github.com/users/cnzg","html_url":"https://github.com/cnzg","followers_url":"https://api.github.com/users/cnzg/followers","following_url":"https://api.github.com/users/cnzg/following{/other_user}","gists_url":"https://api.github.com/users/cnzg/gists{/gist_id}","starred_url":"https://api.github.com/users/cnzg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnzg/subscriptions","organizations_url":"https://api.github.com/users/cnzg/orgs","repos_url":"https://api.github.com/users/cnzg/repos","events_url":"https://api.github.com/users/cnzg/events{/privacy}","received_events_url":"https://api.github.com/users/cnzg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnzg/rancher","description":"A Platform for Operating Docker in Production","fork":true,"url":"https://api.github.com/repos/cnzg/rancher","forks_url":"https://api.github.com/repos/cnzg/rancher/forks","keys_url":"https://api.github.com/repos/cnzg/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnzg/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnzg/rancher/teams","hooks_url":"https://api.github.com/repos/cnzg/rancher/hooks","issue_events_url":"https://api.github.com/repos/cnzg/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/cnzg/rancher/events","assignees_url":"https://api.github.com/repos/cnzg/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/cnzg/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/cnzg/rancher/tags","blobs_url":"https://api.github.com/repos/cnzg/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnzg/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnzg/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnzg/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnzg/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/cnzg/rancher/languages","stargazers_url":"https://api.github.com/repos/cnzg/rancher/stargazers","contributors_url":"https://api.github.com/repos/cnzg/rancher/contributors","subscribers_url":"https://api.github.com/repos/cnzg/rancher/subscribers","subscription_url":"https://api.github.com/repos/cnzg/rancher/subscription","commits_url":"https://api.github.com/repos/cnzg/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnzg/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnzg/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnzg/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnzg/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/cnzg/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnzg/rancher/merges","archive_url":"https://api.github.com/repos/cnzg/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnzg/rancher/downloads","issues_url":"https://api.github.com/repos/cnzg/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/cnzg/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/cnzg/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/cnzg/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnzg/rancher/labels{/name}","releases_url":"https://api.github.com/repos/cnzg/rancher/releases{/id}","created_at":"2015-07-23T02:12:19Z","updated_at":"2015-07-23T02:12:20Z","pushed_at":"2015-07-23T02:39:07Z","git_url":"git://github.com/cnzg/rancher.git","ssh_url":"git@github.com:cnzg/rancher.git","clone_url":"https://github.com/cnzg/rancher.git","svn_url":"https://github.com/cnzg/rancher","homepage":"http://rancher.com","size":4506,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"90e1cb74cdf0103913679a4befc60907823e10ef","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":26337322,"name":"rancher","full_name":"rancher/rancher","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/rancher","description":"A Platform for Operating Docker in Production","fork":false,"url":"https://api.github.com/repos/rancher/rancher","forks_url":"https://api.github.com/repos/rancher/rancher/forks","keys_url":"https://api.github.com/repos/rancher/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/rancher/teams","hooks_url":"https://api.github.com/repos/rancher/rancher/hooks","issue_events_url":"https://api.github.com/repos/rancher/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/rancher/events","assignees_url":"https://api.github.com/repos/rancher/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/rancher/tags","blobs_url":"https://api.github.com/repos/rancher/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/rancher/languages","stargazers_url":"https://api.github.com/repos/rancher/rancher/stargazers","contributors_url":"https://api.github.com/repos/rancher/rancher/contributors","subscribers_url":"https://api.github.com/repos/rancher/rancher/subscribers","subscription_url":"https://api.github.com/repos/rancher/rancher/subscription","commits_url":"https://api.github.com/repos/rancher/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/rancher/merges","archive_url":"https://api.github.com/repos/rancher/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/rancher/downloads","issues_url":"https://api.github.com/repos/rancher/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/rancher/labels{/name}","releases_url":"https://api.github.com/repos/rancher/rancher/releases{/id}","created_at":"2014-11-07T20:49:31Z","updated_at":"2015-07-23T00:53:31Z","pushed_at":"2015-07-22T19:14:56Z","git_url":"git://github.com/rancher/rancher.git","ssh_url":"git@github.com:rancher/rancher.git","clone_url":"https://github.com/rancher/rancher.git","svn_url":"https://github.com/rancher/rancher","homepage":"http://rancher.com","size":4506,"stargazers_count":1742,"watchers_count":1742,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":516,"forks":104,"open_issues":516,"watchers":1742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/1626"},"html":{"href":"https://github.com/rancher/rancher/pull/1626"},"issue":{"href":"https://api.github.com/repos/rancher/rancher/issues/1626"},"comments":{"href":"https://api.github.com/repos/rancher/rancher/issues/1626/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/rancher/pulls/1626/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/rancher/pulls/1626/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/rancher/statuses/04c63fb10fc9f22625617df729aca88a503732b5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":5,"changed_files":1}}