{"action":"created","comment":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/35808002","id":35808002,"diff_hunk":"@@ -18,10 +18,10 @@ def _iter_command_classes(module_name):\n     # TODO: add `name` attribute to commands and and merge this function with\n     # scrapy.utils.spider.iter_spider_classes\n     for module in walk_modules(module_name):\n-        for obj in vars(module).itervalues():\n+        for _, obj in vars(module).items():","path":"scrapy/cmdline.py","position":5,"original_position":5,"commit_id":"6a672e8188b6dae35aedc98557954ac0f07d25d1","original_commit_id":"6a672e8188b6dae35aedc98557954ac0f07d25d1","user":{"login":"kmike","id":107893,"avatar_url":"https://avatars.githubusercontent.com/u/107893?v=3","gravatar_id":"","url":"https://api.github.com/users/kmike","html_url":"https://github.com/kmike","followers_url":"https://api.github.com/users/kmike/followers","following_url":"https://api.github.com/users/kmike/following{/other_user}","gists_url":"https://api.github.com/users/kmike/gists{/gist_id}","starred_url":"https://api.github.com/users/kmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmike/subscriptions","organizations_url":"https://api.github.com/users/kmike/orgs","repos_url":"https://api.github.com/users/kmike/repos","events_url":"https://api.github.com/users/kmike/events{/privacy}","received_events_url":"https://api.github.com/users/kmike/received_events","type":"User","site_admin":false},"body":"can't we use .values() here?","created_at":"2015-07-29T20:31:21Z","updated_at":"2015-07-29T20:31:21Z","html_url":"https://github.com/scrapy/scrapy/pull/1393#discussion_r35808002","pull_request_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1393","_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/35808002"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1393#discussion_r35808002"},"pull_request":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1393"}}},"pull_request":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/1393","id":41144472,"html_url":"https://github.com/scrapy/scrapy/pull/1393","diff_url":"https://github.com/scrapy/scrapy/pull/1393.diff","patch_url":"https://github.com/scrapy/scrapy/pull/1393.patch","issue_url":"https://api.github.com/repos/scrapy/scrapy/issues/1393","number":1393,"state":"open","locked":false,"title":"PY3 split requirements into files","user":{"login":"nyov","id":438293,"avatar_url":"https://avatars.githubusercontent.com/u/438293?v=3","gravatar_id":"","url":"https://api.github.com/users/nyov","html_url":"https://github.com/nyov","followers_url":"https://api.github.com/users/nyov/followers","following_url":"https://api.github.com/users/nyov/following{/other_user}","gists_url":"https://api.github.com/users/nyov/gists{/gist_id}","starred_url":"https://api.github.com/users/nyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyov/subscriptions","organizations_url":"https://api.github.com/users/nyov/orgs","repos_url":"https://api.github.com/users/nyov/repos","events_url":"https://api.github.com/users/nyov/events{/privacy}","received_events_url":"https://api.github.com/users/nyov/received_events","type":"User","site_admin":false},"body":"I just got really confused why some dependency wouldn't be installed in the test environment, until I noticed these are defined seperately for py3 in tox.ini.\r\nHaving them in their own `requirements-py3.txt` wouldn't be a problem, or would it?","created_at":"2015-07-29T16:35:34Z","updated_at":"2015-07-29T20:31:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"147de720ce504097af2ba85e604eb0e0b426b879","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1393/commits","review_comments_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1393/comments","review_comment_url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapy/scrapy/issues/1393/comments","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/6a672e8188b6dae35aedc98557954ac0f07d25d1","head":{"label":"nyov:tmp-py3","ref":"tmp-py3","sha":"6a672e8188b6dae35aedc98557954ac0f07d25d1","user":{"login":"nyov","id":438293,"avatar_url":"https://avatars.githubusercontent.com/u/438293?v=3","gravatar_id":"","url":"https://api.github.com/users/nyov","html_url":"https://github.com/nyov","followers_url":"https://api.github.com/users/nyov/followers","following_url":"https://api.github.com/users/nyov/following{/other_user}","gists_url":"https://api.github.com/users/nyov/gists{/gist_id}","starred_url":"https://api.github.com/users/nyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyov/subscriptions","organizations_url":"https://api.github.com/users/nyov/orgs","repos_url":"https://api.github.com/users/nyov/repos","events_url":"https://api.github.com/users/nyov/events{/privacy}","received_events_url":"https://api.github.com/users/nyov/received_events","type":"User","site_admin":false},"repo":{"id":12548560,"name":"scrapy","full_name":"nyov/scrapy","owner":{"login":"nyov","id":438293,"avatar_url":"https://avatars.githubusercontent.com/u/438293?v=3","gravatar_id":"","url":"https://api.github.com/users/nyov","html_url":"https://github.com/nyov","followers_url":"https://api.github.com/users/nyov/followers","following_url":"https://api.github.com/users/nyov/following{/other_user}","gists_url":"https://api.github.com/users/nyov/gists{/gist_id}","starred_url":"https://api.github.com/users/nyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyov/subscriptions","organizations_url":"https://api.github.com/users/nyov/orgs","repos_url":"https://api.github.com/users/nyov/repos","events_url":"https://api.github.com/users/nyov/events{/privacy}","received_events_url":"https://api.github.com/users/nyov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyov/scrapy","description":"Scrapy, a fast high-level screen scraping and web crawling framework for Python.","fork":true,"url":"https://api.github.com/repos/nyov/scrapy","forks_url":"https://api.github.com/repos/nyov/scrapy/forks","keys_url":"https://api.github.com/repos/nyov/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyov/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyov/scrapy/teams","hooks_url":"https://api.github.com/repos/nyov/scrapy/hooks","issue_events_url":"https://api.github.com/repos/nyov/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/nyov/scrapy/events","assignees_url":"https://api.github.com/repos/nyov/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/nyov/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/nyov/scrapy/tags","blobs_url":"https://api.github.com/repos/nyov/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyov/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyov/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyov/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyov/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/nyov/scrapy/languages","stargazers_url":"https://api.github.com/repos/nyov/scrapy/stargazers","contributors_url":"https://api.github.com/repos/nyov/scrapy/contributors","subscribers_url":"https://api.github.com/repos/nyov/scrapy/subscribers","subscription_url":"https://api.github.com/repos/nyov/scrapy/subscription","commits_url":"https://api.github.com/repos/nyov/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyov/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyov/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyov/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyov/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/nyov/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyov/scrapy/merges","archive_url":"https://api.github.com/repos/nyov/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyov/scrapy/downloads","issues_url":"https://api.github.com/repos/nyov/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/nyov/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/nyov/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/nyov/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyov/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/nyov/scrapy/releases{/id}","created_at":"2013-09-02T20:33:18Z","updated_at":"2015-04-27T19:15:29Z","pushed_at":"2015-07-29T17:48:45Z","git_url":"git://github.com/nyov/scrapy.git","ssh_url":"git@github.com:nyov/scrapy.git","clone_url":"https://github.com/nyov/scrapy.git","svn_url":"https://github.com/nyov/scrapy","homepage":"http://scrapy.org","size":14879,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scrapy:tmp-py3","ref":"tmp-py3","sha":"dafcfd5be6040f0e2cc019dc01cb7d38a2bd24d2","user":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"repo":{"id":529502,"name":"scrapy","full_name":"scrapy/scrapy","owner":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapy/scrapy","description":"Scrapy, a fast high-level web crawling & scraping framework for Python.","fork":false,"url":"https://api.github.com/repos/scrapy/scrapy","forks_url":"https://api.github.com/repos/scrapy/scrapy/forks","keys_url":"https://api.github.com/repos/scrapy/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapy/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapy/scrapy/teams","hooks_url":"https://api.github.com/repos/scrapy/scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapy/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapy/scrapy/events","assignees_url":"https://api.github.com/repos/scrapy/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapy/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapy/scrapy/tags","blobs_url":"https://api.github.com/repos/scrapy/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapy/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapy/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapy/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapy/scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapy/scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapy/scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapy/scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapy/scrapy/subscription","commits_url":"https://api.github.com/repos/scrapy/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapy/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapy/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapy/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapy/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapy/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapy/scrapy/merges","archive_url":"https://api.github.com/repos/scrapy/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapy/scrapy/downloads","issues_url":"https://api.github.com/repos/scrapy/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapy/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapy/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapy/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapy/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapy/scrapy/releases{/id}","created_at":"2010-02-22T02:01:14Z","updated_at":"2015-07-29T15:13:54Z","pushed_at":"2015-07-29T17:48:46Z","git_url":"git://github.com/scrapy/scrapy.git","ssh_url":"git@github.com:scrapy/scrapy.git","clone_url":"https://github.com/scrapy/scrapy.git","svn_url":"https://github.com/scrapy/scrapy","homepage":"http://scrapy.org","size":27543,"stargazers_count":9630,"watchers_count":9630,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2736,"mirror_url":null,"open_issues_count":288,"forks":2736,"open_issues":288,"watchers":9630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1393"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1393"},"issue":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1393"},"comments":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1393/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1393/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1393/commits"},"statuses":{"href":"https://api.github.com/repos/scrapy/scrapy/statuses/6a672e8188b6dae35aedc98557954ac0f07d25d1"}}}}