{"action":"closed","number":52,"pull_request":{"url":"https://api.github.com/repos/ezsystems/eztags/pulls/52","id":1567441,"html_url":"https://github.com/ezsystems/eztags/pull/52","diff_url":"https://github.com/ezsystems/eztags/pull/52.diff","patch_url":"https://github.com/ezsystems/eztags/pull/52.patch","issue_url":"https://api.github.com/repos/ezsystems/eztags/issues/52","number":52,"state":"closed","locked":false,"title":"Hide tags (multilanguage version)","user":{"login":"bchoquet-heliopsis","id":465757,"avatar_url":"https://avatars.githubusercontent.com/u/465757?v=3","gravatar_id":"","url":"https://api.github.com/users/bchoquet-heliopsis","html_url":"https://github.com/bchoquet-heliopsis","followers_url":"https://api.github.com/users/bchoquet-heliopsis/followers","following_url":"https://api.github.com/users/bchoquet-heliopsis/following{/other_user}","gists_url":"https://api.github.com/users/bchoquet-heliopsis/gists{/gist_id}","starred_url":"https://api.github.com/users/bchoquet-heliopsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchoquet-heliopsis/subscriptions","organizations_url":"https://api.github.com/users/bchoquet-heliopsis/orgs","repos_url":"https://api.github.com/users/bchoquet-heliopsis/repos","events_url":"https://api.github.com/users/bchoquet-heliopsis/events{/privacy}","received_events_url":"https://api.github.com/users/bchoquet-heliopsis/received_events","type":"User","site_admin":false},"body":"Hi,\nhere I come again with my bloody feature ;)\n\nI took my code from pull request #39 and revamped it for version 2. I guess it'll be easier for you to review it this way and add it to the next release instead of creating an intermediary v1.\n\nHidden tags are now filtered only in the low level `eZtagsObject::fetchCustomCondsSQL` method. \n\nI began to work on passing an ignoreVisibility flag from method to method but it quickly became messy and created a few logic problems (for example, what to do when getting parent attribute of an invisible tag object ?). \n\nDo you think that flag is really necessary ?\n\nYou can check it out on https://github.com/Heliopsis-HQ/eztags/commit/3c92ac061e7ae520a10d969c3cfff20ca6da31ba\n\n\nThanks\n\nBen","created_at":"2012-06-14T17:03:17Z","updated_at":"2015-07-19T13:54:06Z","closed_at":"2015-07-19T13:54:06Z","merged_at":null,"merge_commit_sha":"5b06af37a06bccb63c9f3c4d85bb85cd9ac533be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/eztags/pulls/52/commits","review_comments_url":"https://api.github.com/repos/ezsystems/eztags/pulls/52/comments","review_comment_url":"https://api.github.com/repos/ezsystems/eztags/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/eztags/issues/52/comments","statuses_url":"https://api.github.com/repos/ezsystems/eztags/statuses/6fa016b1d7bd9e4ed3b439c29e3318fbafd19f91","head":{"label":"heliopsis:multilanguage_hide","ref":"multilanguage_hide","sha":"6fa016b1d7bd9e4ed3b439c29e3318fbafd19f91","user":{"login":"heliopsis","id":465506,"avatar_url":"https://avatars.githubusercontent.com/u/465506?v=3","gravatar_id":"","url":"https://api.github.com/users/heliopsis","html_url":"https://github.com/heliopsis","followers_url":"https://api.github.com/users/heliopsis/followers","following_url":"https://api.github.com/users/heliopsis/following{/other_user}","gists_url":"https://api.github.com/users/heliopsis/gists{/gist_id}","starred_url":"https://api.github.com/users/heliopsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heliopsis/subscriptions","organizations_url":"https://api.github.com/users/heliopsis/orgs","repos_url":"https://api.github.com/users/heliopsis/repos","events_url":"https://api.github.com/users/heliopsis/events{/privacy}","received_events_url":"https://api.github.com/users/heliopsis/received_events","type":"Organization","site_admin":false},"repo":{"id":1983238,"name":"eztags","full_name":"heliopsis/eztags","owner":{"login":"heliopsis","id":465506,"avatar_url":"https://avatars.githubusercontent.com/u/465506?v=3","gravatar_id":"","url":"https://api.github.com/users/heliopsis","html_url":"https://github.com/heliopsis","followers_url":"https://api.github.com/users/heliopsis/followers","following_url":"https://api.github.com/users/heliopsis/following{/other_user}","gists_url":"https://api.github.com/users/heliopsis/gists{/gist_id}","starred_url":"https://api.github.com/users/heliopsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heliopsis/subscriptions","organizations_url":"https://api.github.com/users/heliopsis/orgs","repos_url":"https://api.github.com/users/heliopsis/repos","events_url":"https://api.github.com/users/heliopsis/events{/privacy}","received_events_url":"https://api.github.com/users/heliopsis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heliopsis/eztags","description":"","fork":true,"url":"https://api.github.com/repos/heliopsis/eztags","forks_url":"https://api.github.com/repos/heliopsis/eztags/forks","keys_url":"https://api.github.com/repos/heliopsis/eztags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heliopsis/eztags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heliopsis/eztags/teams","hooks_url":"https://api.github.com/repos/heliopsis/eztags/hooks","issue_events_url":"https://api.github.com/repos/heliopsis/eztags/issues/events{/number}","events_url":"https://api.github.com/repos/heliopsis/eztags/events","assignees_url":"https://api.github.com/repos/heliopsis/eztags/assignees{/user}","branches_url":"https://api.github.com/repos/heliopsis/eztags/branches{/branch}","tags_url":"https://api.github.com/repos/heliopsis/eztags/tags","blobs_url":"https://api.github.com/repos/heliopsis/eztags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heliopsis/eztags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heliopsis/eztags/git/refs{/sha}","trees_url":"https://api.github.com/repos/heliopsis/eztags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heliopsis/eztags/statuses/{sha}","languages_url":"https://api.github.com/repos/heliopsis/eztags/languages","stargazers_url":"https://api.github.com/repos/heliopsis/eztags/stargazers","contributors_url":"https://api.github.com/repos/heliopsis/eztags/contributors","subscribers_url":"https://api.github.com/repos/heliopsis/eztags/subscribers","subscription_url":"https://api.github.com/repos/heliopsis/eztags/subscription","commits_url":"https://api.github.com/repos/heliopsis/eztags/commits{/sha}","git_commits_url":"https://api.github.com/repos/heliopsis/eztags/git/commits{/sha}","comments_url":"https://api.github.com/repos/heliopsis/eztags/comments{/number}","issue_comment_url":"https://api.github.com/repos/heliopsis/eztags/issues/comments{/number}","contents_url":"https://api.github.com/repos/heliopsis/eztags/contents/{+path}","compare_url":"https://api.github.com/repos/heliopsis/eztags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heliopsis/eztags/merges","archive_url":"https://api.github.com/repos/heliopsis/eztags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heliopsis/eztags/downloads","issues_url":"https://api.github.com/repos/heliopsis/eztags/issues{/number}","pulls_url":"https://api.github.com/repos/heliopsis/eztags/pulls{/number}","milestones_url":"https://api.github.com/repos/heliopsis/eztags/milestones{/number}","notifications_url":"https://api.github.com/repos/heliopsis/eztags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heliopsis/eztags/labels{/name}","releases_url":"https://api.github.com/repos/heliopsis/eztags/releases{/id}","created_at":"2011-07-01T12:43:13Z","updated_at":"2014-04-11T08:30:02Z","pushed_at":"2014-04-11T08:30:04Z","git_url":"git://github.com/heliopsis/eztags.git","ssh_url":"git@github.com:heliopsis/eztags.git","clone_url":"https://github.com/heliopsis/eztags.git","svn_url":"https://github.com/heliopsis/eztags","homepage":"","size":2920,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ezsystems:multilanguage","ref":"multilanguage","sha":"8f15b60dba8a5279c1fd79894eec2802b4d40754","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1022103,"name":"eztags","full_name":"ezsystems/eztags","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/eztags","description":"","fork":false,"url":"https://api.github.com/repos/ezsystems/eztags","forks_url":"https://api.github.com/repos/ezsystems/eztags/forks","keys_url":"https://api.github.com/repos/ezsystems/eztags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/eztags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/eztags/teams","hooks_url":"https://api.github.com/repos/ezsystems/eztags/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/eztags/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/eztags/events","assignees_url":"https://api.github.com/repos/ezsystems/eztags/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/eztags/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/eztags/tags","blobs_url":"https://api.github.com/repos/ezsystems/eztags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/eztags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/eztags/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/eztags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/eztags/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/eztags/languages","stargazers_url":"https://api.github.com/repos/ezsystems/eztags/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/eztags/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/eztags/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/eztags/subscription","commits_url":"https://api.github.com/repos/ezsystems/eztags/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/eztags/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/eztags/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/eztags/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/eztags/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/eztags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/eztags/merges","archive_url":"https://api.github.com/repos/ezsystems/eztags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/eztags/downloads","issues_url":"https://api.github.com/repos/ezsystems/eztags/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/eztags/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/eztags/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/eztags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/eztags/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/eztags/releases{/id}","created_at":"2010-10-25T11:47:51Z","updated_at":"2015-07-03T10:19:53Z","pushed_at":"2015-07-19T13:54:06Z","git_url":"git://github.com/ezsystems/eztags.git","ssh_url":"git@github.com:ezsystems/eztags.git","clone_url":"https://github.com/ezsystems/eztags.git","svn_url":"https://github.com/ezsystems/eztags","homepage":"","size":3508,"stargazers_count":46,"watchers_count":46,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":6,"forks":39,"open_issues":6,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/eztags/pulls/52"},"html":{"href":"https://github.com/ezsystems/eztags/pull/52"},"issue":{"href":"https://api.github.com/repos/ezsystems/eztags/issues/52"},"comments":{"href":"https://api.github.com/repos/ezsystems/eztags/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/eztags/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/eztags/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/eztags/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/eztags/statuses/6fa016b1d7bd9e4ed3b439c29e3318fbafd19f91"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":12,"additions":531,"deletions":18,"changed_files":34}}