{"action":"created","comment":{"url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/comments/30252654","id":30252654,"diff_hunk":"@@ -56,7 +56,7 @@ function RabbitMQBus (options) {\n     }\n \n     function done () {\n-      if (self.channels.length === 2) {\n+      if (self.channels.length === (options.createConfirmChannel ? 3 : 2)) {","path":"bus/rabbitmq/bus.js","position":29,"original_position":29,"commit_id":"b1972a6724f981a82166dd63ac6a73d0926c0397","original_commit_id":"b1972a6724f981a82166dd63ac6a73d0926c0397","user":{"login":"mateodelnorte","id":554847,"avatar_url":"https://avatars.githubusercontent.com/u/554847?v=3","gravatar_id":"","url":"https://api.github.com/users/mateodelnorte","html_url":"https://github.com/mateodelnorte","followers_url":"https://api.github.com/users/mateodelnorte/followers","following_url":"https://api.github.com/users/mateodelnorte/following{/other_user}","gists_url":"https://api.github.com/users/mateodelnorte/gists{/gist_id}","starred_url":"https://api.github.com/users/mateodelnorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateodelnorte/subscriptions","organizations_url":"https://api.github.com/users/mateodelnorte/orgs","repos_url":"https://api.github.com/users/mateodelnorte/repos","events_url":"https://api.github.com/users/mateodelnorte/events{/privacy}","received_events_url":"https://api.github.com/users/mateodelnorte/received_events","type":"User","site_admin":false},"body":"can you rename this options.enableConfirms or options.enablePublisherConfirms?","created_at":"2015-05-13T17:12:54Z","updated_at":"2015-05-13T17:12:54Z","html_url":"https://github.com/mateodelnorte/servicebus/pull/50#discussion_r30252654","pull_request_url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/comments/30252654"},"html":{"href":"https://github.com/mateodelnorte/servicebus/pull/50#discussion_r30252654"},"pull_request":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50","id":35341489,"html_url":"https://github.com/mateodelnorte/servicebus/pull/50","diff_url":"https://github.com/mateodelnorte/servicebus/pull/50.diff","patch_url":"https://github.com/mateodelnorte/servicebus/pull/50.patch","issue_url":"https://api.github.com/repos/mateodelnorte/servicebus/issues/50","number":50,"state":"open","locked":false,"title":"createConfirmChannel option and send/publish take callback","user":{"login":"jrmurad","id":172669,"avatar_url":"https://avatars.githubusercontent.com/u/172669?v=3","gravatar_id":"","url":"https://api.github.com/users/jrmurad","html_url":"https://github.com/jrmurad","followers_url":"https://api.github.com/users/jrmurad/followers","following_url":"https://api.github.com/users/jrmurad/following{/other_user}","gists_url":"https://api.github.com/users/jrmurad/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmurad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmurad/subscriptions","organizations_url":"https://api.github.com/users/jrmurad/orgs","repos_url":"https://api.github.com/users/jrmurad/repos","events_url":"https://api.github.com/users/jrmurad/events{/privacy}","received_events_url":"https://api.github.com/users/jrmurad/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-13T15:51:11Z","updated_at":"2015-05-13T17:12:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"610db893f326483f4a6f91ef668bc56caffd9b38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50/commits","review_comments_url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50/comments","review_comment_url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mateodelnorte/servicebus/issues/50/comments","statuses_url":"https://api.github.com/repos/mateodelnorte/servicebus/statuses/b1972a6724f981a82166dd63ac6a73d0926c0397","head":{"label":"jrmurad:confirm-mode","ref":"confirm-mode","sha":"b1972a6724f981a82166dd63ac6a73d0926c0397","user":{"login":"jrmurad","id":172669,"avatar_url":"https://avatars.githubusercontent.com/u/172669?v=3","gravatar_id":"","url":"https://api.github.com/users/jrmurad","html_url":"https://github.com/jrmurad","followers_url":"https://api.github.com/users/jrmurad/followers","following_url":"https://api.github.com/users/jrmurad/following{/other_user}","gists_url":"https://api.github.com/users/jrmurad/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmurad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmurad/subscriptions","organizations_url":"https://api.github.com/users/jrmurad/orgs","repos_url":"https://api.github.com/users/jrmurad/repos","events_url":"https://api.github.com/users/jrmurad/events{/privacy}","received_events_url":"https://api.github.com/users/jrmurad/received_events","type":"User","site_admin":false},"repo":{"id":31980529,"name":"servicebus","full_name":"jrmurad/servicebus","owner":{"login":"jrmurad","id":172669,"avatar_url":"https://avatars.githubusercontent.com/u/172669?v=3","gravatar_id":"","url":"https://api.github.com/users/jrmurad","html_url":"https://github.com/jrmurad","followers_url":"https://api.github.com/users/jrmurad/followers","following_url":"https://api.github.com/users/jrmurad/following{/other_user}","gists_url":"https://api.github.com/users/jrmurad/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmurad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmurad/subscriptions","organizations_url":"https://api.github.com/users/jrmurad/orgs","repos_url":"https://api.github.com/users/jrmurad/repos","events_url":"https://api.github.com/users/jrmurad/events{/privacy}","received_events_url":"https://api.github.com/users/jrmurad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrmurad/servicebus","description":"Simple service bus for sending events between processes using amqp. ","fork":true,"url":"https://api.github.com/repos/jrmurad/servicebus","forks_url":"https://api.github.com/repos/jrmurad/servicebus/forks","keys_url":"https://api.github.com/repos/jrmurad/servicebus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrmurad/servicebus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrmurad/servicebus/teams","hooks_url":"https://api.github.com/repos/jrmurad/servicebus/hooks","issue_events_url":"https://api.github.com/repos/jrmurad/servicebus/issues/events{/number}","events_url":"https://api.github.com/repos/jrmurad/servicebus/events","assignees_url":"https://api.github.com/repos/jrmurad/servicebus/assignees{/user}","branches_url":"https://api.github.com/repos/jrmurad/servicebus/branches{/branch}","tags_url":"https://api.github.com/repos/jrmurad/servicebus/tags","blobs_url":"https://api.github.com/repos/jrmurad/servicebus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrmurad/servicebus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrmurad/servicebus/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrmurad/servicebus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrmurad/servicebus/statuses/{sha}","languages_url":"https://api.github.com/repos/jrmurad/servicebus/languages","stargazers_url":"https://api.github.com/repos/jrmurad/servicebus/stargazers","contributors_url":"https://api.github.com/repos/jrmurad/servicebus/contributors","subscribers_url":"https://api.github.com/repos/jrmurad/servicebus/subscribers","subscription_url":"https://api.github.com/repos/jrmurad/servicebus/subscription","commits_url":"https://api.github.com/repos/jrmurad/servicebus/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrmurad/servicebus/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrmurad/servicebus/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrmurad/servicebus/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrmurad/servicebus/contents/{+path}","compare_url":"https://api.github.com/repos/jrmurad/servicebus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrmurad/servicebus/merges","archive_url":"https://api.github.com/repos/jrmurad/servicebus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrmurad/servicebus/downloads","issues_url":"https://api.github.com/repos/jrmurad/servicebus/issues{/number}","pulls_url":"https://api.github.com/repos/jrmurad/servicebus/pulls{/number}","milestones_url":"https://api.github.com/repos/jrmurad/servicebus/milestones{/number}","notifications_url":"https://api.github.com/repos/jrmurad/servicebus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrmurad/servicebus/labels{/name}","releases_url":"https://api.github.com/repos/jrmurad/servicebus/releases{/id}","created_at":"2015-03-10T20:37:22Z","updated_at":"2015-03-10T20:37:22Z","pushed_at":"2015-05-13T15:51:52Z","git_url":"git://github.com/jrmurad/servicebus.git","ssh_url":"git@github.com:jrmurad/servicebus.git","clone_url":"https://github.com/jrmurad/servicebus.git","svn_url":"https://github.com/jrmurad/servicebus","homepage":null,"size":826,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mateodelnorte:master","ref":"master","sha":"6b7615b98dcee441ef0982e578b98bcb1e605e1c","user":{"login":"mateodelnorte","id":554847,"avatar_url":"https://avatars.githubusercontent.com/u/554847?v=3","gravatar_id":"","url":"https://api.github.com/users/mateodelnorte","html_url":"https://github.com/mateodelnorte","followers_url":"https://api.github.com/users/mateodelnorte/followers","following_url":"https://api.github.com/users/mateodelnorte/following{/other_user}","gists_url":"https://api.github.com/users/mateodelnorte/gists{/gist_id}","starred_url":"https://api.github.com/users/mateodelnorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateodelnorte/subscriptions","organizations_url":"https://api.github.com/users/mateodelnorte/orgs","repos_url":"https://api.github.com/users/mateodelnorte/repos","events_url":"https://api.github.com/users/mateodelnorte/events{/privacy}","received_events_url":"https://api.github.com/users/mateodelnorte/received_events","type":"User","site_admin":false},"repo":{"id":4813266,"name":"servicebus","full_name":"mateodelnorte/servicebus","owner":{"login":"mateodelnorte","id":554847,"avatar_url":"https://avatars.githubusercontent.com/u/554847?v=3","gravatar_id":"","url":"https://api.github.com/users/mateodelnorte","html_url":"https://github.com/mateodelnorte","followers_url":"https://api.github.com/users/mateodelnorte/followers","following_url":"https://api.github.com/users/mateodelnorte/following{/other_user}","gists_url":"https://api.github.com/users/mateodelnorte/gists{/gist_id}","starred_url":"https://api.github.com/users/mateodelnorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateodelnorte/subscriptions","organizations_url":"https://api.github.com/users/mateodelnorte/orgs","repos_url":"https://api.github.com/users/mateodelnorte/repos","events_url":"https://api.github.com/users/mateodelnorte/events{/privacy}","received_events_url":"https://api.github.com/users/mateodelnorte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mateodelnorte/servicebus","description":"Simple service bus for sending events between processes using amqp. ","fork":false,"url":"https://api.github.com/repos/mateodelnorte/servicebus","forks_url":"https://api.github.com/repos/mateodelnorte/servicebus/forks","keys_url":"https://api.github.com/repos/mateodelnorte/servicebus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mateodelnorte/servicebus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mateodelnorte/servicebus/teams","hooks_url":"https://api.github.com/repos/mateodelnorte/servicebus/hooks","issue_events_url":"https://api.github.com/repos/mateodelnorte/servicebus/issues/events{/number}","events_url":"https://api.github.com/repos/mateodelnorte/servicebus/events","assignees_url":"https://api.github.com/repos/mateodelnorte/servicebus/assignees{/user}","branches_url":"https://api.github.com/repos/mateodelnorte/servicebus/branches{/branch}","tags_url":"https://api.github.com/repos/mateodelnorte/servicebus/tags","blobs_url":"https://api.github.com/repos/mateodelnorte/servicebus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mateodelnorte/servicebus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mateodelnorte/servicebus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mateodelnorte/servicebus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mateodelnorte/servicebus/statuses/{sha}","languages_url":"https://api.github.com/repos/mateodelnorte/servicebus/languages","stargazers_url":"https://api.github.com/repos/mateodelnorte/servicebus/stargazers","contributors_url":"https://api.github.com/repos/mateodelnorte/servicebus/contributors","subscribers_url":"https://api.github.com/repos/mateodelnorte/servicebus/subscribers","subscription_url":"https://api.github.com/repos/mateodelnorte/servicebus/subscription","commits_url":"https://api.github.com/repos/mateodelnorte/servicebus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mateodelnorte/servicebus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mateodelnorte/servicebus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mateodelnorte/servicebus/issues/comments{/number}","contents_url":"https://api.github.com/repos/mateodelnorte/servicebus/contents/{+path}","compare_url":"https://api.github.com/repos/mateodelnorte/servicebus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mateodelnorte/servicebus/merges","archive_url":"https://api.github.com/repos/mateodelnorte/servicebus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mateodelnorte/servicebus/downloads","issues_url":"https://api.github.com/repos/mateodelnorte/servicebus/issues{/number}","pulls_url":"https://api.github.com/repos/mateodelnorte/servicebus/pulls{/number}","milestones_url":"https://api.github.com/repos/mateodelnorte/servicebus/milestones{/number}","notifications_url":"https://api.github.com/repos/mateodelnorte/servicebus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mateodelnorte/servicebus/labels{/name}","releases_url":"https://api.github.com/repos/mateodelnorte/servicebus/releases{/id}","created_at":"2012-06-27T20:33:27Z","updated_at":"2015-05-12T21:51:28Z","pushed_at":"2015-05-13T15:52:10Z","git_url":"git://github.com/mateodelnorte/servicebus.git","ssh_url":"git@github.com:mateodelnorte/servicebus.git","clone_url":"https://github.com/mateodelnorte/servicebus.git","svn_url":"https://github.com/mateodelnorte/servicebus","homepage":null,"size":1395,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50"},"html":{"href":"https://github.com/mateodelnorte/servicebus/pull/50"},"issue":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/issues/50"},"comments":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/mateodelnorte/servicebus/statuses/b1972a6724f981a82166dd63ac6a73d0926c0397"}}}}