{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/44047676","id":44047676,"diff_hunk":"@@ -226,12 +249,29 @@ object Client {\n     conf.set(\"akka.loglevel\", driverArgs.logLevel.toString.replace(\"WARN\", \"WARNING\"))\n     Logger.getRootLogger.setLevel(driverArgs.logLevel)\n \n-    val rpcEnv =\n-      RpcEnv.create(\"driverClient\", Utils.localHostName(), 0, conf, new SecurityManager(conf))\n+    // if a secret key has been set in an env variable, use it\n+    sys.env.get(ENV_AUTH_SECRET).foreach(conf.set(SPARK_AUTH_SECRET_CONF, _))\n+\n+    // if a secret key for submission has been set in an env variable, use it\n+    sys.env.get(Namespace.Submission.inEnv(ENV_AUTH_SECRET))","path":"core/src/main/scala/org/apache/spark/deploy/Client.scala","position":67,"original_position":67,"commit_id":"3c1467ab94f5befa0c9a6c0f6b8aaaa4c1701002","original_commit_id":"3c1467ab94f5befa0c9a6c0f6b8aaaa4c1701002","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"As above, this code should not be added.","created_at":"2015-11-05T18:19:59Z","updated_at":"2015-11-05T18:19:59Z","html_url":"https://github.com/apache/spark/pull/9287#discussion_r44047676","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/9287","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/44047676"},"html":{"href":"https://github.com/apache/spark/pull/9287#discussion_r44047676"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/9287"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9287","id":48809971,"html_url":"https://github.com/apache/spark/pull/9287","diff_url":"https://github.com/apache/spark/pull/9287.diff","patch_url":"https://github.com/apache/spark/pull/9287.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/9287","number":9287,"state":"open","locked":false,"title":"SPARK-11326: Split networking in standalone mode","user":{"login":"jacek-lewandowski","id":6516951,"avatar_url":"https://avatars.githubusercontent.com/u/6516951?v=3","gravatar_id":"","url":"https://api.github.com/users/jacek-lewandowski","html_url":"https://github.com/jacek-lewandowski","followers_url":"https://api.github.com/users/jacek-lewandowski/followers","following_url":"https://api.github.com/users/jacek-lewandowski/following{/other_user}","gists_url":"https://api.github.com/users/jacek-lewandowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jacek-lewandowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacek-lewandowski/subscriptions","organizations_url":"https://api.github.com/users/jacek-lewandowski/orgs","repos_url":"https://api.github.com/users/jacek-lewandowski/repos","events_url":"https://api.github.com/users/jacek-lewandowski/events{/privacy}","received_events_url":"https://api.github.com/users/jacek-lewandowski/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-26T23:11:53Z","updated_at":"2015-11-05T18:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a532b073911629f52c47d315b0f3f9ca473a2db1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/9287/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/9287/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/9287/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/3c1467ab94f5befa0c9a6c0f6b8aaaa4c1701002","head":{"label":"jacek-lewandowski:SPARK-11326","ref":"SPARK-11326","sha":"3c1467ab94f5befa0c9a6c0f6b8aaaa4c1701002","user":{"login":"jacek-lewandowski","id":6516951,"avatar_url":"https://avatars.githubusercontent.com/u/6516951?v=3","gravatar_id":"","url":"https://api.github.com/users/jacek-lewandowski","html_url":"https://github.com/jacek-lewandowski","followers_url":"https://api.github.com/users/jacek-lewandowski/followers","following_url":"https://api.github.com/users/jacek-lewandowski/following{/other_user}","gists_url":"https://api.github.com/users/jacek-lewandowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jacek-lewandowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacek-lewandowski/subscriptions","organizations_url":"https://api.github.com/users/jacek-lewandowski/orgs","repos_url":"https://api.github.com/users/jacek-lewandowski/repos","events_url":"https://api.github.com/users/jacek-lewandowski/events{/privacy}","received_events_url":"https://api.github.com/users/jacek-lewandowski/received_events","type":"User","site_admin":false},"repo":{"id":17413502,"name":"spark","full_name":"jacek-lewandowski/spark","owner":{"login":"jacek-lewandowski","id":6516951,"avatar_url":"https://avatars.githubusercontent.com/u/6516951?v=3","gravatar_id":"","url":"https://api.github.com/users/jacek-lewandowski","html_url":"https://github.com/jacek-lewandowski","followers_url":"https://api.github.com/users/jacek-lewandowski/followers","following_url":"https://api.github.com/users/jacek-lewandowski/following{/other_user}","gists_url":"https://api.github.com/users/jacek-lewandowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jacek-lewandowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacek-lewandowski/subscriptions","organizations_url":"https://api.github.com/users/jacek-lewandowski/orgs","repos_url":"https://api.github.com/users/jacek-lewandowski/repos","events_url":"https://api.github.com/users/jacek-lewandowski/events{/privacy}","received_events_url":"https://api.github.com/users/jacek-lewandowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacek-lewandowski/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/jacek-lewandowski/spark","forks_url":"https://api.github.com/repos/jacek-lewandowski/spark/forks","keys_url":"https://api.github.com/repos/jacek-lewandowski/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacek-lewandowski/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacek-lewandowski/spark/teams","hooks_url":"https://api.github.com/repos/jacek-lewandowski/spark/hooks","issue_events_url":"https://api.github.com/repos/jacek-lewandowski/spark/issues/events{/number}","events_url":"https://api.github.com/repos/jacek-lewandowski/spark/events","assignees_url":"https://api.github.com/repos/jacek-lewandowski/spark/assignees{/user}","branches_url":"https://api.github.com/repos/jacek-lewandowski/spark/branches{/branch}","tags_url":"https://api.github.com/repos/jacek-lewandowski/spark/tags","blobs_url":"https://api.github.com/repos/jacek-lewandowski/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacek-lewandowski/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacek-lewandowski/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacek-lewandowski/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacek-lewandowski/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/jacek-lewandowski/spark/languages","stargazers_url":"https://api.github.com/repos/jacek-lewandowski/spark/stargazers","contributors_url":"https://api.github.com/repos/jacek-lewandowski/spark/contributors","subscribers_url":"https://api.github.com/repos/jacek-lewandowski/spark/subscribers","subscription_url":"https://api.github.com/repos/jacek-lewandowski/spark/subscription","commits_url":"https://api.github.com/repos/jacek-lewandowski/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacek-lewandowski/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacek-lewandowski/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacek-lewandowski/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacek-lewandowski/spark/contents/{+path}","compare_url":"https://api.github.com/repos/jacek-lewandowski/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacek-lewandowski/spark/merges","archive_url":"https://api.github.com/repos/jacek-lewandowski/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacek-lewandowski/spark/downloads","issues_url":"https://api.github.com/repos/jacek-lewandowski/spark/issues{/number}","pulls_url":"https://api.github.com/repos/jacek-lewandowski/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/jacek-lewandowski/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/jacek-lewandowski/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacek-lewandowski/spark/labels{/name}","releases_url":"https://api.github.com/repos/jacek-lewandowski/spark/releases{/id}","created_at":"2014-03-04T19:08:43Z","updated_at":"2015-04-29T20:48:39Z","pushed_at":"2015-11-05T15:54:39Z","git_url":"git://github.com/jacek-lewandowski/spark.git","ssh_url":"git@github.com:jacek-lewandowski/spark.git","clone_url":"https://github.com/jacek-lewandowski/spark.git","svn_url":"https://github.com/jacek-lewandowski/spark","homepage":null,"size":125928,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"77488fb8e586103ba4c0858b73e1715f1a66671f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-11-05T17:12:06Z","pushed_at":"2015-11-05T18:17:29Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1648205,"stargazers_count":6030,"watchers_count":6030,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5611,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":374,"forks":5611,"open_issues":374,"watchers":6030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/9287"},"html":{"href":"https://github.com/apache/spark/pull/9287"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/9287"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/9287/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/9287/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/9287/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/3c1467ab94f5befa0c9a6c0f6b8aaaa4c1701002"}}}}