{"action":"created","comment":{"url":"https://api.github.com/repos/Julian/jsonschema/pulls/comments/45548385","id":45548385,"diff_hunk":"@@ -22,7 +22,7 @@\n ]\n \n extras_require = {\n-    \"format\" : [\"rfc3987\", \"strict-rfc3339\", \"webcolors\"],","path":"setup.py","position":4,"original_position":4,"commit_id":"843b72e47000cc3b1f1cee14ae080fcd81affb63","original_commit_id":"843b72e47000cc3b1f1cee14ae080fcd81affb63","user":{"login":"Julian","id":329822,"avatar_url":"https://avatars.githubusercontent.com/u/329822?v=3","gravatar_id":"","url":"https://api.github.com/users/Julian","html_url":"https://github.com/Julian","followers_url":"https://api.github.com/users/Julian/followers","following_url":"https://api.github.com/users/Julian/following{/other_user}","gists_url":"https://api.github.com/users/Julian/gists{/gist_id}","starred_url":"https://api.github.com/users/Julian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Julian/subscriptions","organizations_url":"https://api.github.com/users/Julian/orgs","repos_url":"https://api.github.com/users/Julian/repos","events_url":"https://api.github.com/users/Julian/events{/privacy}","received_events_url":"https://api.github.com/users/Julian/received_events","type":"User","site_admin":false},"body":"I think probably we'd need to support backwards compat here too. I assume you've already verified that strict-rfc3339 and webcolors are non-GPL?\r\n\r\nIf so I think we'd need to add a format-nongpl extra, otherwise we'll potentially change the deps being installed for people.","created_at":"2015-11-21T17:20:40Z","updated_at":"2015-11-21T17:20:40Z","html_url":"https://github.com/Julian/jsonschema/pull/261#discussion_r45548385","pull_request_url":"https://api.github.com/repos/Julian/jsonschema/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/Julian/jsonschema/pulls/comments/45548385"},"html":{"href":"https://github.com/Julian/jsonschema/pull/261#discussion_r45548385"},"pull_request":{"href":"https://api.github.com/repos/Julian/jsonschema/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/Julian/jsonschema/pulls/261","id":51420689,"html_url":"https://github.com/Julian/jsonschema/pull/261","diff_url":"https://github.com/Julian/jsonschema/pull/261.diff","patch_url":"https://github.com/Julian/jsonschema/pull/261.patch","issue_url":"https://api.github.com/repos/Julian/jsonschema/issues/261","number":261,"state":"open","locked":false,"title":"Replace rfc3987 (GPL) with rfc3986 (Apache)","user":{"login":"shakeelmohamed","id":1480063,"avatar_url":"https://avatars.githubusercontent.com/u/1480063?v=3","gravatar_id":"","url":"https://api.github.com/users/shakeelmohamed","html_url":"https://github.com/shakeelmohamed","followers_url":"https://api.github.com/users/shakeelmohamed/followers","following_url":"https://api.github.com/users/shakeelmohamed/following{/other_user}","gists_url":"https://api.github.com/users/shakeelmohamed/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelmohamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelmohamed/subscriptions","organizations_url":"https://api.github.com/users/shakeelmohamed/orgs","repos_url":"https://api.github.com/users/shakeelmohamed/repos","events_url":"https://api.github.com/users/shakeelmohamed/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelmohamed/received_events","type":"User","site_admin":false},"body":"We'd like to consider using the jsonschema package which is licensed under an MIT-like license, but cannot take a dependency on rfc3987 because it is distributed under GPL.\r\n\r\nThis was the minimum amount of changes required to make the tests pass, we're open to any feedback on these changes!","created_at":"2015-11-20T23:10:07Z","updated_at":"2015-11-21T17:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53785dcc976eba50b6c6ae31c8ec84445f81a332","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Julian/jsonschema/pulls/261/commits","review_comments_url":"https://api.github.com/repos/Julian/jsonschema/pulls/261/comments","review_comment_url":"https://api.github.com/repos/Julian/jsonschema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Julian/jsonschema/issues/261/comments","statuses_url":"https://api.github.com/repos/Julian/jsonschema/statuses/843b72e47000cc3b1f1cee14ae080fcd81affb63","head":{"label":"shakeelmohamed:feature/rfc3986","ref":"feature/rfc3986","sha":"843b72e47000cc3b1f1cee14ae080fcd81affb63","user":{"login":"shakeelmohamed","id":1480063,"avatar_url":"https://avatars.githubusercontent.com/u/1480063?v=3","gravatar_id":"","url":"https://api.github.com/users/shakeelmohamed","html_url":"https://github.com/shakeelmohamed","followers_url":"https://api.github.com/users/shakeelmohamed/followers","following_url":"https://api.github.com/users/shakeelmohamed/following{/other_user}","gists_url":"https://api.github.com/users/shakeelmohamed/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelmohamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelmohamed/subscriptions","organizations_url":"https://api.github.com/users/shakeelmohamed/orgs","repos_url":"https://api.github.com/users/shakeelmohamed/repos","events_url":"https://api.github.com/users/shakeelmohamed/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelmohamed/received_events","type":"User","site_admin":false},"repo":{"id":46528252,"name":"jsonschema","full_name":"shakeelmohamed/jsonschema","owner":{"login":"shakeelmohamed","id":1480063,"avatar_url":"https://avatars.githubusercontent.com/u/1480063?v=3","gravatar_id":"","url":"https://api.github.com/users/shakeelmohamed","html_url":"https://github.com/shakeelmohamed","followers_url":"https://api.github.com/users/shakeelmohamed/followers","following_url":"https://api.github.com/users/shakeelmohamed/following{/other_user}","gists_url":"https://api.github.com/users/shakeelmohamed/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelmohamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelmohamed/subscriptions","organizations_url":"https://api.github.com/users/shakeelmohamed/orgs","repos_url":"https://api.github.com/users/shakeelmohamed/repos","events_url":"https://api.github.com/users/shakeelmohamed/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelmohamed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shakeelmohamed/jsonschema","description":"An(other) implementation of JSON Schema for Python","fork":true,"url":"https://api.github.com/repos/shakeelmohamed/jsonschema","forks_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/forks","keys_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/teams","hooks_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/hooks","issue_events_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/issues/events{/number}","events_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/events","assignees_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/assignees{/user}","branches_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/branches{/branch}","tags_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/tags","blobs_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/statuses/{sha}","languages_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/languages","stargazers_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/stargazers","contributors_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/contributors","subscribers_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/subscribers","subscription_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/subscription","commits_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/contents/{+path}","compare_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/merges","archive_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/downloads","issues_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/issues{/number}","pulls_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/pulls{/number}","milestones_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/milestones{/number}","notifications_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/labels{/name}","releases_url":"https://api.github.com/repos/shakeelmohamed/jsonschema/releases{/id}","created_at":"2015-11-20T00:12:06Z","updated_at":"2015-11-20T00:12:06Z","pushed_at":"2015-11-20T23:04:17Z","git_url":"git://github.com/shakeelmohamed/jsonschema.git","ssh_url":"git@github.com:shakeelmohamed/jsonschema.git","clone_url":"https://github.com/shakeelmohamed/jsonschema.git","svn_url":"https://github.com/shakeelmohamed/jsonschema","homepage":"https://python-jsonschema.readthedocs.org","size":957,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Julian:master","ref":"master","sha":"3eb5de857fc7313c9a54a62c967f21ecf88ad84c","user":{"login":"Julian","id":329822,"avatar_url":"https://avatars.githubusercontent.com/u/329822?v=3","gravatar_id":"","url":"https://api.github.com/users/Julian","html_url":"https://github.com/Julian","followers_url":"https://api.github.com/users/Julian/followers","following_url":"https://api.github.com/users/Julian/following{/other_user}","gists_url":"https://api.github.com/users/Julian/gists{/gist_id}","starred_url":"https://api.github.com/users/Julian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Julian/subscriptions","organizations_url":"https://api.github.com/users/Julian/orgs","repos_url":"https://api.github.com/users/Julian/repos","events_url":"https://api.github.com/users/Julian/events{/privacy}","received_events_url":"https://api.github.com/users/Julian/received_events","type":"User","site_admin":false},"repo":{"id":3072629,"name":"jsonschema","full_name":"Julian/jsonschema","owner":{"login":"Julian","id":329822,"avatar_url":"https://avatars.githubusercontent.com/u/329822?v=3","gravatar_id":"","url":"https://api.github.com/users/Julian","html_url":"https://github.com/Julian","followers_url":"https://api.github.com/users/Julian/followers","following_url":"https://api.github.com/users/Julian/following{/other_user}","gists_url":"https://api.github.com/users/Julian/gists{/gist_id}","starred_url":"https://api.github.com/users/Julian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Julian/subscriptions","organizations_url":"https://api.github.com/users/Julian/orgs","repos_url":"https://api.github.com/users/Julian/repos","events_url":"https://api.github.com/users/Julian/events{/privacy}","received_events_url":"https://api.github.com/users/Julian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Julian/jsonschema","description":"An(other) implementation of JSON Schema for Python","fork":false,"url":"https://api.github.com/repos/Julian/jsonschema","forks_url":"https://api.github.com/repos/Julian/jsonschema/forks","keys_url":"https://api.github.com/repos/Julian/jsonschema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Julian/jsonschema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Julian/jsonschema/teams","hooks_url":"https://api.github.com/repos/Julian/jsonschema/hooks","issue_events_url":"https://api.github.com/repos/Julian/jsonschema/issues/events{/number}","events_url":"https://api.github.com/repos/Julian/jsonschema/events","assignees_url":"https://api.github.com/repos/Julian/jsonschema/assignees{/user}","branches_url":"https://api.github.com/repos/Julian/jsonschema/branches{/branch}","tags_url":"https://api.github.com/repos/Julian/jsonschema/tags","blobs_url":"https://api.github.com/repos/Julian/jsonschema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Julian/jsonschema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Julian/jsonschema/git/refs{/sha}","trees_url":"https://api.github.com/repos/Julian/jsonschema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Julian/jsonschema/statuses/{sha}","languages_url":"https://api.github.com/repos/Julian/jsonschema/languages","stargazers_url":"https://api.github.com/repos/Julian/jsonschema/stargazers","contributors_url":"https://api.github.com/repos/Julian/jsonschema/contributors","subscribers_url":"https://api.github.com/repos/Julian/jsonschema/subscribers","subscription_url":"https://api.github.com/repos/Julian/jsonschema/subscription","commits_url":"https://api.github.com/repos/Julian/jsonschema/commits{/sha}","git_commits_url":"https://api.github.com/repos/Julian/jsonschema/git/commits{/sha}","comments_url":"https://api.github.com/repos/Julian/jsonschema/comments{/number}","issue_comment_url":"https://api.github.com/repos/Julian/jsonschema/issues/comments{/number}","contents_url":"https://api.github.com/repos/Julian/jsonschema/contents/{+path}","compare_url":"https://api.github.com/repos/Julian/jsonschema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Julian/jsonschema/merges","archive_url":"https://api.github.com/repos/Julian/jsonschema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Julian/jsonschema/downloads","issues_url":"https://api.github.com/repos/Julian/jsonschema/issues{/number}","pulls_url":"https://api.github.com/repos/Julian/jsonschema/pulls{/number}","milestones_url":"https://api.github.com/repos/Julian/jsonschema/milestones{/number}","notifications_url":"https://api.github.com/repos/Julian/jsonschema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Julian/jsonschema/labels{/name}","releases_url":"https://api.github.com/repos/Julian/jsonschema/releases{/id}","created_at":"2011-12-30T03:37:43Z","updated_at":"2015-11-20T21:36:27Z","pushed_at":"2015-11-20T23:10:07Z","git_url":"git://github.com/Julian/jsonschema.git","ssh_url":"git@github.com:Julian/jsonschema.git","clone_url":"https://github.com/Julian/jsonschema.git","svn_url":"https://github.com/Julian/jsonschema","homepage":"https://python-jsonschema.readthedocs.org","size":2801,"stargazers_count":658,"watchers_count":658,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":20,"forks":137,"open_issues":20,"watchers":658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Julian/jsonschema/pulls/261"},"html":{"href":"https://github.com/Julian/jsonschema/pull/261"},"issue":{"href":"https://api.github.com/repos/Julian/jsonschema/issues/261"},"comments":{"href":"https://api.github.com/repos/Julian/jsonschema/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/Julian/jsonschema/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/Julian/jsonschema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Julian/jsonschema/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/Julian/jsonschema/statuses/843b72e47000cc3b1f1cee14ae080fcd81affb63"}}}}