{"action":"created","issue":{"url":"https://api.github.com/repos/netshoes/styleguide/issues/48","labels_url":"https://api.github.com/repos/netshoes/styleguide/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/netshoes/styleguide/issues/48/comments","events_url":"https://api.github.com/repos/netshoes/styleguide/issues/48/events","html_url":"https://github.com/netshoes/styleguide/issues/48","id":102848472,"number":48,"title":"Change the commit message standard","user":{"login":"weslleyaraujo","id":2286385,"avatar_url":"https://avatars.githubusercontent.com/u/2286385?v=3","gravatar_id":"","url":"https://api.github.com/users/weslleyaraujo","html_url":"https://github.com/weslleyaraujo","followers_url":"https://api.github.com/users/weslleyaraujo/followers","following_url":"https://api.github.com/users/weslleyaraujo/following{/other_user}","gists_url":"https://api.github.com/users/weslleyaraujo/gists{/gist_id}","starred_url":"https://api.github.com/users/weslleyaraujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weslleyaraujo/subscriptions","organizations_url":"https://api.github.com/users/weslleyaraujo/orgs","repos_url":"https://api.github.com/users/weslleyaraujo/repos","events_url":"https://api.github.com/users/weslleyaraujo/events{/privacy}","received_events_url":"https://api.github.com/users/weslleyaraujo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netshoes/styleguide/labels/enhancement","name":"enhancement","color":"159818"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-24T17:27:32Z","updated_at":"2015-08-24T20:21:30Z","closed_at":null,"body":"Hey folks,\r\n\r\nI'm open this issue for us to discuss our current [commit message standard](https://github.com/netshoes/styleguide/tree/master/scm#4.5).\r\n\r\nAt first I would like to make clear that I don't see any problem with our current pattern, is that I just found out that there is a know pattern followed by some projects and I think that would be awesome for us to start using the same way.\r\n\r\nThe new standard would follow the same idea with the \"change type's\" thing, but it is written in a different way like:\r\n\r\n```\r\n<type>(<scope>): <subject>\r\n<BLANK LINE>\r\n<body>\r\n<BLANK LINE>\r\n<footer>\r\n```\r\n\r\nYou can follow [this](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md) explanation for each of those itens.\r\n\r\n### Why's\r\n\r\n* we would be following an already existing pattern created by many.\r\n* we could generate CHANGELOG files using many existent [plugins](https://skywinder.github.io/github-changelog-generator/) which is awesome 😁\r\n* sometimes it's nicer not to reinvent things\r\n\r\n### Who already uses this\r\n\r\n* [Semantic Release](https://github.com/semantic-release/semantic-release)\r\n* [Angular JS](https://github.com/angular/angular/commits/master)\r\n* [Spotify](https://www.youtube.com/watch?v=odZpA6yrOYY)\r\n\r\n\r\nWhat you guys think of this idea?\r\n(love you all 💜)\r\n\r\n@netshoes/front-end "},"comment":{"url":"https://api.github.com/repos/netshoes/styleguide/issues/comments/134365103","html_url":"https://github.com/netshoes/styleguide/issues/48#issuecomment-134365103","issue_url":"https://api.github.com/repos/netshoes/styleguide/issues/48","id":134365103,"user":{"login":"weslleyaraujo","id":2286385,"avatar_url":"https://avatars.githubusercontent.com/u/2286385?v=3","gravatar_id":"","url":"https://api.github.com/users/weslleyaraujo","html_url":"https://github.com/weslleyaraujo","followers_url":"https://api.github.com/users/weslleyaraujo/followers","following_url":"https://api.github.com/users/weslleyaraujo/following{/other_user}","gists_url":"https://api.github.com/users/weslleyaraujo/gists{/gist_id}","starred_url":"https://api.github.com/users/weslleyaraujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weslleyaraujo/subscriptions","organizations_url":"https://api.github.com/users/weslleyaraujo/orgs","repos_url":"https://api.github.com/users/weslleyaraujo/repos","events_url":"https://api.github.com/users/weslleyaraujo/events{/privacy}","received_events_url":"https://api.github.com/users/weslleyaraujo/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T20:21:30Z","updated_at":"2015-08-24T20:21:30Z","body":"@rafaelrinaldi thats true we could only start using the changelog thing (like for real)..\r\nabout the commit message I would propose:\r\n\r\n| Prefix | Description |\r\n|---|---|\r\n| `feat` | When adding a feature that provides real value to the product |\r\n| `fix` | When fixing a bug |\r\n| `wip` | When testing something (work in progress) |\r\n| `refactor` | When working on a refactor of some sort |\r\n| `test ` | For non-changelog related tasks |\r\n\r\n@raphaelfabeni we could use `Sentence case` and it be free to add long descriptions.. I just found out some examples from [this](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#) doc:\r\n\r\n```\r\nfix($compile): couple of unit tests for IE9\r\n\r\nOlder IEs serialize html uppercased, but IE9 does not...\r\nWould be better to expect case insensitive, unfortunately jasmine does\r\nnot allow to user regexps for throw expectations.\r\n\r\nCloses #392\r\nBreaks foo.bar api, foo.baz should be used instead\r\n```\r\n\r\nThe line with *Breaks*  will generate a block changing what this commit supposedly breaked.."}}