{"action":"opened","number":1283,"pull_request":{"url":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/1283","id":45821100,"html_url":"https://github.com/Mithion/ArsMagica2/pull/1283","diff_url":"https://github.com/Mithion/ArsMagica2/pull/1283.diff","patch_url":"https://github.com/Mithion/ArsMagica2/pull/1283.patch","issue_url":"https://api.github.com/repos/Mithion/ArsMagica2/issues/1283","number":1283,"state":"open","locked":false,"title":"Fix for crashes in issue #1212 (extended potion IDs)","user":{"login":"DoomFruit","id":9013415,"avatar_url":"https://avatars.githubusercontent.com/u/9013415?v=3","gravatar_id":"","url":"https://api.github.com/users/DoomFruit","html_url":"https://github.com/DoomFruit","followers_url":"https://api.github.com/users/DoomFruit/followers","following_url":"https://api.github.com/users/DoomFruit/following{/other_user}","gists_url":"https://api.github.com/users/DoomFruit/gists{/gist_id}","starred_url":"https://api.github.com/users/DoomFruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoomFruit/subscriptions","organizations_url":"https://api.github.com/users/DoomFruit/orgs","repos_url":"https://api.github.com/users/DoomFruit/repos","events_url":"https://api.github.com/users/DoomFruit/events{/privacy}","received_events_url":"https://api.github.com/users/DoomFruit/received_events","type":"User","site_admin":false},"body":"After a fair bit of bashing on Mojang's code, I think I've managed to get around the array out of bounds exception noted in issue #1212 with potion IDs above 128. I've had to alter PotionEffect.java to change the way it saves active potion effects into your player character (was byte, now int), changed S1DPacketHandler.java to send integers instead of bytes, and had to additionally change NetHandlerClient to expect an integer instead of a byte from one of its function calls.\r\n\r\nI've tested it in a pure AM2 dev environment, where a swift swim spell with potion ID 128 worked fine (previously, it failed by complaining about a clearly unphysical array index of -128). Testing it in my full modded setup revealed that whatever it is that DragonAPI does with respect to extending the potions array (which works fine with AM2 - I'm currently running a relatively early build of 009 on my server) clashes with my code, so I put in a check and don't do anything to potions if you have DragonAPI installed - there's no sense in duplicating effort, and Reika is almost certainly a better coder than I am.\r\n\r\nI think it's solved the out of bounds potion ID issue, but could use another pair of eyes here.","created_at":"2015-09-23T19:31:54Z","updated_at":"2015-09-23T19:31:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/1283/commits","review_comments_url":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/1283/comments","review_comment_url":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mithion/ArsMagica2/issues/1283/comments","statuses_url":"https://api.github.com/repos/Mithion/ArsMagica2/statuses/c13c0678723938cd9e9f0c2f010c23806e6d4e81","head":{"label":"DoomFruit:PotionIDExtensionFix","ref":"PotionIDExtensionFix","sha":"c13c0678723938cd9e9f0c2f010c23806e6d4e81","user":{"login":"DoomFruit","id":9013415,"avatar_url":"https://avatars.githubusercontent.com/u/9013415?v=3","gravatar_id":"","url":"https://api.github.com/users/DoomFruit","html_url":"https://github.com/DoomFruit","followers_url":"https://api.github.com/users/DoomFruit/followers","following_url":"https://api.github.com/users/DoomFruit/following{/other_user}","gists_url":"https://api.github.com/users/DoomFruit/gists{/gist_id}","starred_url":"https://api.github.com/users/DoomFruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoomFruit/subscriptions","organizations_url":"https://api.github.com/users/DoomFruit/orgs","repos_url":"https://api.github.com/users/DoomFruit/repos","events_url":"https://api.github.com/users/DoomFruit/events{/privacy}","received_events_url":"https://api.github.com/users/DoomFruit/received_events","type":"User","site_admin":false},"repo":{"id":42354217,"name":"ArsMagica2","full_name":"DoomFruit/ArsMagica2","owner":{"login":"DoomFruit","id":9013415,"avatar_url":"https://avatars.githubusercontent.com/u/9013415?v=3","gravatar_id":"","url":"https://api.github.com/users/DoomFruit","html_url":"https://github.com/DoomFruit","followers_url":"https://api.github.com/users/DoomFruit/followers","following_url":"https://api.github.com/users/DoomFruit/following{/other_user}","gists_url":"https://api.github.com/users/DoomFruit/gists{/gist_id}","starred_url":"https://api.github.com/users/DoomFruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoomFruit/subscriptions","organizations_url":"https://api.github.com/users/DoomFruit/orgs","repos_url":"https://api.github.com/users/DoomFruit/repos","events_url":"https://api.github.com/users/DoomFruit/events{/privacy}","received_events_url":"https://api.github.com/users/DoomFruit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DoomFruit/ArsMagica2","description":"Ars Magica 2 Bug Tracker","fork":true,"url":"https://api.github.com/repos/DoomFruit/ArsMagica2","forks_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/forks","keys_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/teams","hooks_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/hooks","issue_events_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/issues/events{/number}","events_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/events","assignees_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/assignees{/user}","branches_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/branches{/branch}","tags_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/tags","blobs_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/statuses/{sha}","languages_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/languages","stargazers_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/stargazers","contributors_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/contributors","subscribers_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/subscribers","subscription_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/subscription","commits_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/contents/{+path}","compare_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/merges","archive_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/downloads","issues_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/issues{/number}","pulls_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/pulls{/number}","milestones_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/milestones{/number}","notifications_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/labels{/name}","releases_url":"https://api.github.com/repos/DoomFruit/ArsMagica2/releases{/id}","created_at":"2015-09-12T11:09:52Z","updated_at":"2015-09-12T11:09:56Z","pushed_at":"2015-09-23T19:21:45Z","git_url":"git://github.com/DoomFruit/ArsMagica2.git","ssh_url":"git@github.com:DoomFruit/ArsMagica2.git","clone_url":"https://github.com/DoomFruit/ArsMagica2.git","svn_url":"https://github.com/DoomFruit/ArsMagica2","homepage":null,"size":20561,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mithion:master","ref":"master","sha":"b617a915692f49326dcd6edd0f45ccfcaea99dfe","user":{"login":"Mithion","id":2482373,"avatar_url":"https://avatars.githubusercontent.com/u/2482373?v=3","gravatar_id":"","url":"https://api.github.com/users/Mithion","html_url":"https://github.com/Mithion","followers_url":"https://api.github.com/users/Mithion/followers","following_url":"https://api.github.com/users/Mithion/following{/other_user}","gists_url":"https://api.github.com/users/Mithion/gists{/gist_id}","starred_url":"https://api.github.com/users/Mithion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mithion/subscriptions","organizations_url":"https://api.github.com/users/Mithion/orgs","repos_url":"https://api.github.com/users/Mithion/repos","events_url":"https://api.github.com/users/Mithion/events{/privacy}","received_events_url":"https://api.github.com/users/Mithion/received_events","type":"User","site_admin":false},"repo":{"id":13533527,"name":"ArsMagica2","full_name":"Mithion/ArsMagica2","owner":{"login":"Mithion","id":2482373,"avatar_url":"https://avatars.githubusercontent.com/u/2482373?v=3","gravatar_id":"","url":"https://api.github.com/users/Mithion","html_url":"https://github.com/Mithion","followers_url":"https://api.github.com/users/Mithion/followers","following_url":"https://api.github.com/users/Mithion/following{/other_user}","gists_url":"https://api.github.com/users/Mithion/gists{/gist_id}","starred_url":"https://api.github.com/users/Mithion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mithion/subscriptions","organizations_url":"https://api.github.com/users/Mithion/orgs","repos_url":"https://api.github.com/users/Mithion/repos","events_url":"https://api.github.com/users/Mithion/events{/privacy}","received_events_url":"https://api.github.com/users/Mithion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mithion/ArsMagica2","description":"Ars Magica 2 Bug Tracker","fork":false,"url":"https://api.github.com/repos/Mithion/ArsMagica2","forks_url":"https://api.github.com/repos/Mithion/ArsMagica2/forks","keys_url":"https://api.github.com/repos/Mithion/ArsMagica2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mithion/ArsMagica2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mithion/ArsMagica2/teams","hooks_url":"https://api.github.com/repos/Mithion/ArsMagica2/hooks","issue_events_url":"https://api.github.com/repos/Mithion/ArsMagica2/issues/events{/number}","events_url":"https://api.github.com/repos/Mithion/ArsMagica2/events","assignees_url":"https://api.github.com/repos/Mithion/ArsMagica2/assignees{/user}","branches_url":"https://api.github.com/repos/Mithion/ArsMagica2/branches{/branch}","tags_url":"https://api.github.com/repos/Mithion/ArsMagica2/tags","blobs_url":"https://api.github.com/repos/Mithion/ArsMagica2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mithion/ArsMagica2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mithion/ArsMagica2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mithion/ArsMagica2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mithion/ArsMagica2/statuses/{sha}","languages_url":"https://api.github.com/repos/Mithion/ArsMagica2/languages","stargazers_url":"https://api.github.com/repos/Mithion/ArsMagica2/stargazers","contributors_url":"https://api.github.com/repos/Mithion/ArsMagica2/contributors","subscribers_url":"https://api.github.com/repos/Mithion/ArsMagica2/subscribers","subscription_url":"https://api.github.com/repos/Mithion/ArsMagica2/subscription","commits_url":"https://api.github.com/repos/Mithion/ArsMagica2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mithion/ArsMagica2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mithion/ArsMagica2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mithion/ArsMagica2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mithion/ArsMagica2/contents/{+path}","compare_url":"https://api.github.com/repos/Mithion/ArsMagica2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mithion/ArsMagica2/merges","archive_url":"https://api.github.com/repos/Mithion/ArsMagica2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mithion/ArsMagica2/downloads","issues_url":"https://api.github.com/repos/Mithion/ArsMagica2/issues{/number}","pulls_url":"https://api.github.com/repos/Mithion/ArsMagica2/pulls{/number}","milestones_url":"https://api.github.com/repos/Mithion/ArsMagica2/milestones{/number}","notifications_url":"https://api.github.com/repos/Mithion/ArsMagica2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mithion/ArsMagica2/labels{/name}","releases_url":"https://api.github.com/repos/Mithion/ArsMagica2/releases{/id}","created_at":"2013-10-13T04:13:58Z","updated_at":"2015-09-20T12:09:05Z","pushed_at":"2015-09-22T21:58:50Z","git_url":"git://github.com/Mithion/ArsMagica2.git","ssh_url":"git@github.com:Mithion/ArsMagica2.git","clone_url":"https://github.com/Mithion/ArsMagica2.git","svn_url":"https://github.com/Mithion/ArsMagica2","homepage":null,"size":20788,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":50,"forks":73,"open_issues":50,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/1283"},"html":{"href":"https://github.com/Mithion/ArsMagica2/pull/1283"},"issue":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/issues/1283"},"comments":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/issues/1283/comments"},"review_comments":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/1283/comments"},"review_comment":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/pulls/1283/commits"},"statuses":{"href":"https://api.github.com/repos/Mithion/ArsMagica2/statuses/c13c0678723938cd9e9f0c2f010c23806e6d4e81"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":537,"deletions":0,"changed_files":2}}