{"action":"created","issue":{"url":"https://api.github.com/repos/GsDevKit/Seaside31/issues/31","labels_url":"https://api.github.com/repos/GsDevKit/Seaside31/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/GsDevKit/Seaside31/issues/31/comments","events_url":"https://api.github.com/repos/GsDevKit/Seaside31/issues/31/events","html_url":"https://github.com/GsDevKit/Seaside31/issues/31","id":37097372,"number":31,"title":"WAUrlEncoder not using primitive","user":{"login":"dalehenrich","id":623951,"avatar_url":"https://avatars.githubusercontent.com/u/623951?v=3","gravatar_id":"","url":"https://api.github.com/users/dalehenrich","html_url":"https://github.com/dalehenrich","followers_url":"https://api.github.com/users/dalehenrich/followers","following_url":"https://api.github.com/users/dalehenrich/following{/other_user}","gists_url":"https://api.github.com/users/dalehenrich/gists{/gist_id}","starred_url":"https://api.github.com/users/dalehenrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalehenrich/subscriptions","organizations_url":"https://api.github.com/users/dalehenrich/orgs","repos_url":"https://api.github.com/users/dalehenrich/repos","events_url":"https://api.github.com/users/dalehenrich/events{/privacy}","received_events_url":"https://api.github.com/users/dalehenrich/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GsDevKit/Seaside31/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-07-03T16:15:18Z","updated_at":"2015-06-08T23:32:34Z","closed_at":null,"body":"From Gerhard:\r\n\r\n```\r\nIt seems that the gemstone primitve encodeUsing: is not working \r\nwith the WAUrlEncoder table.\r\nThe primitive doesn't like nil as entries in the table.\r\n\r\nThe method table ^table at WATableBaseEncoder must be implemented to be able to run the test.\r\n'asd' encodeUsing: WAUrlEncoder table    .....    always returns nil\r\n\r\nI don't have a real patch for this. If the table is initialized with strings only, it seems to work.\r\nBut then also the nextPut: method at WATableBasedEncoder must be changed.\r\n\r\ne.g.\r\ninitializeTable\r\n\t\"Initializes the encoding table.\"\r\n\t| stream characterLimit |\r\n\tcharacterLimit := self maximumCharacterValue.\r\n\t\"character values at zero so we need to add 1\"\r\n\ttable := Array new: characterLimit + 1.\r\n\tstream := WriteStream on: (String new: 6).\r\n\t0 to: characterLimit do: [ :index | \r\n\t\t| character value |\r\n\t\tcharacter := Character codePoint: index.\r\n\t\tself encode: character on: stream reset.\r\n\t\t\"Smalltalk indices are one based but character values start at 0\"\r\n\t\tvalue := stream contents = (String with: character)\r\n\t\t\tifTrue: [ (String with: character) ]    .... instead of nil\r\n\t\t\tifFalse: [ stream contents ].\r\n\t\ttable at: index + 1 put: value ]\r\n```"},"comment":{"url":"https://api.github.com/repos/GsDevKit/Seaside31/issues/comments/110171504","html_url":"https://github.com/GsDevKit/Seaside31/issues/31#issuecomment-110171504","issue_url":"https://api.github.com/repos/GsDevKit/Seaside31/issues/31","id":110171504,"user":{"login":"dalehenrich","id":623951,"avatar_url":"https://avatars.githubusercontent.com/u/623951?v=3","gravatar_id":"","url":"https://api.github.com/users/dalehenrich","html_url":"https://github.com/dalehenrich","followers_url":"https://api.github.com/users/dalehenrich/followers","following_url":"https://api.github.com/users/dalehenrich/following{/other_user}","gists_url":"https://api.github.com/users/dalehenrich/gists{/gist_id}","starred_url":"https://api.github.com/users/dalehenrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalehenrich/subscriptions","organizations_url":"https://api.github.com/users/dalehenrich/orgs","repos_url":"https://api.github.com/users/dalehenrich/repos","events_url":"https://api.github.com/users/dalehenrich/events{/privacy}","received_events_url":"https://api.github.com/users/dalehenrich/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T23:32:34Z","updated_at":"2015-06-08T23:32:34Z","body":"Gemstone 3.2.0, 3.2.1, 3.2.6?  I'd like to narrow my search down a bit:) A little more detail for the seaside version as well ... a commit SHA would be best ... \r\n"}}