{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/247","labels_url":"https://api.github.com/repos/square/p2/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/247/comments","events_url":"https://api.github.com/repos/square/p2/issues/247/events","html_url":"https://github.com/square/p2/pull/247","id":106087274,"number":247,"title":"Add replication controller interface","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-11T20:23:04Z","updated_at":"2015-09-21T20:38:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/247","html_url":"https://github.com/square/p2/pull/247","diff_url":"https://github.com/square/p2/pull/247.diff","patch_url":"https://github.com/square/p2/pull/247.patch"},"body":"Taking comments on this while I work on the implementation. I originally did not have the increase/decrease functions in here as I thought the orchestrator might just directly write them to consul, but now I'm thinking it could be useful to have them since every replication controller needs to have it, whether it be backed by consul or otherwise."},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/142101849","html_url":"https://github.com/square/p2/pull/247#issuecomment-142101849","issue_url":"https://api.github.com/repos/square/p2/issues/247","id":142101849,"user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T20:38:24Z","updated_at":"2015-09-21T20:38:24Z","body":"Thoughts on labels: We'll want to add `pod_id` at least (for a future world where it is not obvious from the key structure)\r\n\r\nIn the case where there are mutliple RCs deploying the same manifest, we want a way to tell them apart. So the RC should be able to take a set of selectors that 1) will be applied to pods it deploys and 2) are used to select pods so that the RC knows what node it's running on."}}