{"action":"created","issue":{"url":"https://api.github.com/repos/nfischer/tuningfork/issues/2","labels_url":"https://api.github.com/repos/nfischer/tuningfork/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/nfischer/tuningfork/issues/2/comments","events_url":"https://api.github.com/repos/nfischer/tuningfork/issues/2/events","html_url":"https://github.com/nfischer/tuningfork/pull/2","id":110824623,"number":2,"title":"Convert genFile() to use a high-resolution, 1-period lookup table","user":{"login":"freitagbr","id":5988055,"avatar_url":"https://avatars.githubusercontent.com/u/5988055?v=3","gravatar_id":"","url":"https://api.github.com/users/freitagbr","html_url":"https://github.com/freitagbr","followers_url":"https://api.github.com/users/freitagbr/followers","following_url":"https://api.github.com/users/freitagbr/following{/other_user}","gists_url":"https://api.github.com/users/freitagbr/gists{/gist_id}","starred_url":"https://api.github.com/users/freitagbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freitagbr/subscriptions","organizations_url":"https://api.github.com/users/freitagbr/orgs","repos_url":"https://api.github.com/users/freitagbr/repos","events_url":"https://api.github.com/users/freitagbr/events{/privacy}","received_events_url":"https://api.github.com/users/freitagbr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-11T00:08:42Z","updated_at":"2015-11-03T05:38:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nfischer/tuningfork/pulls/2","html_url":"https://github.com/nfischer/tuningfork/pull/2","diff_url":"https://github.com/nfischer/tuningfork/pull/2.diff","patch_url":"https://github.com/nfischer/tuningfork/pull/2.patch"},"body":"### File Generation\r\nImplemented a high-resolution 1-period lookup table, which allows:\r\n* Reduced memory usage\r\n* Higher fidelity\r\n    * High resolution lookup table reduces distortion\r\n    * Default size of lookup table is 8192 samples\r\n    * For best sound, do not set the size any lower than 2048\r\n\r\n##### Note\r\nI tried a 1/4 period lookup table, but in practice the performance was worse.\r\n\r\n### Housekeeping\r\n* Removed unnecessary comments. Leave comments for whole blocks or tricky lines of code.\r\n* Renamed some variables.\r\n* Implemented some style guidelines, according to the cpplint linter; ignored the line length policy."},"comment":{"url":"https://api.github.com/repos/nfischer/tuningfork/issues/comments/153247512","html_url":"https://github.com/nfischer/tuningfork/pull/2#issuecomment-153247512","issue_url":"https://api.github.com/repos/nfischer/tuningfork/issues/2","id":153247512,"user":{"login":"nfischer","id":5801521,"avatar_url":"https://avatars.githubusercontent.com/u/5801521?v=3","gravatar_id":"","url":"https://api.github.com/users/nfischer","html_url":"https://github.com/nfischer","followers_url":"https://api.github.com/users/nfischer/followers","following_url":"https://api.github.com/users/nfischer/following{/other_user}","gists_url":"https://api.github.com/users/nfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfischer/subscriptions","organizations_url":"https://api.github.com/users/nfischer/orgs","repos_url":"https://api.github.com/users/nfischer/repos","events_url":"https://api.github.com/users/nfischer/events{/privacy}","received_events_url":"https://api.github.com/users/nfischer/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T05:38:34Z","updated_at":"2015-11-03T05:38:34Z","body":"@freitagbr Do you think this has significant improvements over the previous version?"}}