{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/8","id":45005522,"html_url":"https://github.com/brandonckelly/carma_pack/pull/8","diff_url":"https://github.com/brandonckelly/carma_pack/pull/8.diff","patch_url":"https://github.com/brandonckelly/carma_pack/pull/8.patch","issue_url":"https://api.github.com/repos/brandonckelly/carma_pack/issues/8","number":8,"state":"closed","locked":false,"title":"Changes to plot_power_spectrum","user":{"login":"Jamieryan","id":5634651,"avatar_url":"https://avatars.githubusercontent.com/u/5634651?v=3","gravatar_id":"","url":"https://api.github.com/users/Jamieryan","html_url":"https://github.com/Jamieryan","followers_url":"https://api.github.com/users/Jamieryan/followers","following_url":"https://api.github.com/users/Jamieryan/following{/other_user}","gists_url":"https://api.github.com/users/Jamieryan/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamieryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamieryan/subscriptions","organizations_url":"https://api.github.com/users/Jamieryan/orgs","repos_url":"https://api.github.com/users/Jamieryan/repos","events_url":"https://api.github.com/users/Jamieryan/events{/privacy}","received_events_url":"https://api.github.com/users/Jamieryan/received_events","type":"User","site_admin":false},"body":"There appears to be a bug in Car1Sample's plot_power_spectrum method. I ran the sampler for p=1,2, q=0 on a realization of a Car1 process. In the figure below, the CARMA(1,0) result in shown in blue, and the CARMA(2,0) result in shown in red, with the true PSD used to generate the light curve and periodogram also added. A) uses the original code, B) uses omega = exp(log_omega) instead of omega = 10 ** log_omega, and C) uses the code in the pull request.\r\n\r\nI also made the Car1Sample's method match the arguments and return products of CarmaSample's, and changed the frequency ranges (which didn't match) to both be 1/(light curve length) to the Nyquist frequency.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/5634651/9866798/e7e22a1c-5b1b-11e5-8ead-891b536cb14a.png)","created_at":"2015-09-15T03:31:31Z","updated_at":"2015-09-15T10:17:13Z","closed_at":"2015-09-15T10:17:13Z","merged_at":"2015-09-15T10:17:13Z","merge_commit_sha":"39eb6de6c355429cb5f85345ef929c83fa39c944","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/8/commits","review_comments_url":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/8/comments","review_comment_url":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brandonckelly/carma_pack/issues/8/comments","statuses_url":"https://api.github.com/repos/brandonckelly/carma_pack/statuses/6956f74e3bab56a609c9d062c5c26c7fc544d266","head":{"label":"Jamieryan:master","ref":"master","sha":"6956f74e3bab56a609c9d062c5c26c7fc544d266","user":{"login":"Jamieryan","id":5634651,"avatar_url":"https://avatars.githubusercontent.com/u/5634651?v=3","gravatar_id":"","url":"https://api.github.com/users/Jamieryan","html_url":"https://github.com/Jamieryan","followers_url":"https://api.github.com/users/Jamieryan/followers","following_url":"https://api.github.com/users/Jamieryan/following{/other_user}","gists_url":"https://api.github.com/users/Jamieryan/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamieryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamieryan/subscriptions","organizations_url":"https://api.github.com/users/Jamieryan/orgs","repos_url":"https://api.github.com/users/Jamieryan/repos","events_url":"https://api.github.com/users/Jamieryan/events{/privacy}","received_events_url":"https://api.github.com/users/Jamieryan/received_events","type":"User","site_admin":false},"repo":{"id":42485445,"name":"carma_pack","full_name":"Jamieryan/carma_pack","owner":{"login":"Jamieryan","id":5634651,"avatar_url":"https://avatars.githubusercontent.com/u/5634651?v=3","gravatar_id":"","url":"https://api.github.com/users/Jamieryan","html_url":"https://github.com/Jamieryan","followers_url":"https://api.github.com/users/Jamieryan/followers","following_url":"https://api.github.com/users/Jamieryan/following{/other_user}","gists_url":"https://api.github.com/users/Jamieryan/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamieryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamieryan/subscriptions","organizations_url":"https://api.github.com/users/Jamieryan/orgs","repos_url":"https://api.github.com/users/Jamieryan/repos","events_url":"https://api.github.com/users/Jamieryan/events{/privacy}","received_events_url":"https://api.github.com/users/Jamieryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jamieryan/carma_pack","description":"MCMC Sampler for Performing Bayesian Inference on Continuous Time Autoregressive Models.","fork":true,"url":"https://api.github.com/repos/Jamieryan/carma_pack","forks_url":"https://api.github.com/repos/Jamieryan/carma_pack/forks","keys_url":"https://api.github.com/repos/Jamieryan/carma_pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jamieryan/carma_pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jamieryan/carma_pack/teams","hooks_url":"https://api.github.com/repos/Jamieryan/carma_pack/hooks","issue_events_url":"https://api.github.com/repos/Jamieryan/carma_pack/issues/events{/number}","events_url":"https://api.github.com/repos/Jamieryan/carma_pack/events","assignees_url":"https://api.github.com/repos/Jamieryan/carma_pack/assignees{/user}","branches_url":"https://api.github.com/repos/Jamieryan/carma_pack/branches{/branch}","tags_url":"https://api.github.com/repos/Jamieryan/carma_pack/tags","blobs_url":"https://api.github.com/repos/Jamieryan/carma_pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jamieryan/carma_pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jamieryan/carma_pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jamieryan/carma_pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jamieryan/carma_pack/statuses/{sha}","languages_url":"https://api.github.com/repos/Jamieryan/carma_pack/languages","stargazers_url":"https://api.github.com/repos/Jamieryan/carma_pack/stargazers","contributors_url":"https://api.github.com/repos/Jamieryan/carma_pack/contributors","subscribers_url":"https://api.github.com/repos/Jamieryan/carma_pack/subscribers","subscription_url":"https://api.github.com/repos/Jamieryan/carma_pack/subscription","commits_url":"https://api.github.com/repos/Jamieryan/carma_pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jamieryan/carma_pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jamieryan/carma_pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jamieryan/carma_pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jamieryan/carma_pack/contents/{+path}","compare_url":"https://api.github.com/repos/Jamieryan/carma_pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jamieryan/carma_pack/merges","archive_url":"https://api.github.com/repos/Jamieryan/carma_pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jamieryan/carma_pack/downloads","issues_url":"https://api.github.com/repos/Jamieryan/carma_pack/issues{/number}","pulls_url":"https://api.github.com/repos/Jamieryan/carma_pack/pulls{/number}","milestones_url":"https://api.github.com/repos/Jamieryan/carma_pack/milestones{/number}","notifications_url":"https://api.github.com/repos/Jamieryan/carma_pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jamieryan/carma_pack/labels{/name}","releases_url":"https://api.github.com/repos/Jamieryan/carma_pack/releases{/id}","created_at":"2015-09-15T00:41:27Z","updated_at":"2015-09-15T00:41:28Z","pushed_at":"2015-09-15T02:25:43Z","git_url":"git://github.com/Jamieryan/carma_pack.git","ssh_url":"git@github.com:Jamieryan/carma_pack.git","clone_url":"https://github.com/Jamieryan/carma_pack.git","svn_url":"https://github.com/Jamieryan/carma_pack","homepage":null,"size":15510,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brandonckelly:master","ref":"master","sha":"abd7ae00406f126d12f273f9c02b1e2f64de315c","user":{"login":"brandonckelly","id":3742948,"avatar_url":"https://avatars.githubusercontent.com/u/3742948?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonckelly","html_url":"https://github.com/brandonckelly","followers_url":"https://api.github.com/users/brandonckelly/followers","following_url":"https://api.github.com/users/brandonckelly/following{/other_user}","gists_url":"https://api.github.com/users/brandonckelly/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonckelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonckelly/subscriptions","organizations_url":"https://api.github.com/users/brandonckelly/orgs","repos_url":"https://api.github.com/users/brandonckelly/repos","events_url":"https://api.github.com/users/brandonckelly/events{/privacy}","received_events_url":"https://api.github.com/users/brandonckelly/received_events","type":"User","site_admin":false},"repo":{"id":9848286,"name":"carma_pack","full_name":"brandonckelly/carma_pack","owner":{"login":"brandonckelly","id":3742948,"avatar_url":"https://avatars.githubusercontent.com/u/3742948?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonckelly","html_url":"https://github.com/brandonckelly","followers_url":"https://api.github.com/users/brandonckelly/followers","following_url":"https://api.github.com/users/brandonckelly/following{/other_user}","gists_url":"https://api.github.com/users/brandonckelly/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonckelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonckelly/subscriptions","organizations_url":"https://api.github.com/users/brandonckelly/orgs","repos_url":"https://api.github.com/users/brandonckelly/repos","events_url":"https://api.github.com/users/brandonckelly/events{/privacy}","received_events_url":"https://api.github.com/users/brandonckelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandonckelly/carma_pack","description":"MCMC Sampler for Performing Bayesian Inference on Continuous Time Autoregressive Models.","fork":false,"url":"https://api.github.com/repos/brandonckelly/carma_pack","forks_url":"https://api.github.com/repos/brandonckelly/carma_pack/forks","keys_url":"https://api.github.com/repos/brandonckelly/carma_pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandonckelly/carma_pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandonckelly/carma_pack/teams","hooks_url":"https://api.github.com/repos/brandonckelly/carma_pack/hooks","issue_events_url":"https://api.github.com/repos/brandonckelly/carma_pack/issues/events{/number}","events_url":"https://api.github.com/repos/brandonckelly/carma_pack/events","assignees_url":"https://api.github.com/repos/brandonckelly/carma_pack/assignees{/user}","branches_url":"https://api.github.com/repos/brandonckelly/carma_pack/branches{/branch}","tags_url":"https://api.github.com/repos/brandonckelly/carma_pack/tags","blobs_url":"https://api.github.com/repos/brandonckelly/carma_pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandonckelly/carma_pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandonckelly/carma_pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandonckelly/carma_pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandonckelly/carma_pack/statuses/{sha}","languages_url":"https://api.github.com/repos/brandonckelly/carma_pack/languages","stargazers_url":"https://api.github.com/repos/brandonckelly/carma_pack/stargazers","contributors_url":"https://api.github.com/repos/brandonckelly/carma_pack/contributors","subscribers_url":"https://api.github.com/repos/brandonckelly/carma_pack/subscribers","subscription_url":"https://api.github.com/repos/brandonckelly/carma_pack/subscription","commits_url":"https://api.github.com/repos/brandonckelly/carma_pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandonckelly/carma_pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandonckelly/carma_pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandonckelly/carma_pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandonckelly/carma_pack/contents/{+path}","compare_url":"https://api.github.com/repos/brandonckelly/carma_pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandonckelly/carma_pack/merges","archive_url":"https://api.github.com/repos/brandonckelly/carma_pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandonckelly/carma_pack/downloads","issues_url":"https://api.github.com/repos/brandonckelly/carma_pack/issues{/number}","pulls_url":"https://api.github.com/repos/brandonckelly/carma_pack/pulls{/number}","milestones_url":"https://api.github.com/repos/brandonckelly/carma_pack/milestones{/number}","notifications_url":"https://api.github.com/repos/brandonckelly/carma_pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandonckelly/carma_pack/labels{/name}","releases_url":"https://api.github.com/repos/brandonckelly/carma_pack/releases{/id}","created_at":"2013-05-04T02:30:48Z","updated_at":"2015-08-31T12:32:03Z","pushed_at":"2015-09-15T10:17:13Z","git_url":"git://github.com/brandonckelly/carma_pack.git","ssh_url":"git@github.com:brandonckelly/carma_pack.git","clone_url":"https://github.com/brandonckelly/carma_pack.git","svn_url":"https://github.com/brandonckelly/carma_pack","homepage":null,"size":16142,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/8"},"html":{"href":"https://github.com/brandonckelly/carma_pack/pull/8"},"issue":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/issues/8"},"comments":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/brandonckelly/carma_pack/statuses/6956f74e3bab56a609c9d062c5c26c7fc544d266"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brandonckelly","id":3742948,"avatar_url":"https://avatars.githubusercontent.com/u/3742948?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonckelly","html_url":"https://github.com/brandonckelly","followers_url":"https://api.github.com/users/brandonckelly/followers","following_url":"https://api.github.com/users/brandonckelly/following{/other_user}","gists_url":"https://api.github.com/users/brandonckelly/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonckelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonckelly/subscriptions","organizations_url":"https://api.github.com/users/brandonckelly/orgs","repos_url":"https://api.github.com/users/brandonckelly/repos","events_url":"https://api.github.com/users/brandonckelly/events{/privacy}","received_events_url":"https://api.github.com/users/brandonckelly/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":9,"changed_files":1}}