{"action":"created","comment":{"url":"https://api.github.com/repos/enthought/pyql/pulls/comments/24273867","id":24273867,"diff_hunk":"@@ -61,7 +61,7 @@ def test_comparison_with_datetime(self):\n         datetime_date_nov_98 = datetime.date(1998, 11, 19)\n \n         self.assertTrue(date_nov_98 == datetime_date_nov_98)\n-        self.assertEquals(cmp(date_nov_98, datetime_date_nov_98), 0)\n+        self.assertEquals(date_nov_98 > datetime_date_nov_98, 0)","path":"quantlib/test/test_date.py","position":14,"original_position":14,"commit_id":"6f004588b67cf174136e74a260655318c47d16cb","original_commit_id":"3b6000f02c4af9e012e015e0bc07bc41ab3f2f68","user":{"login":"dpinte","id":538104,"avatar_url":"https://avatars.githubusercontent.com/u/538104?v=3","gravatar_id":"","url":"https://api.github.com/users/dpinte","html_url":"https://github.com/dpinte","followers_url":"https://api.github.com/users/dpinte/followers","following_url":"https://api.github.com/users/dpinte/following{/other_user}","gists_url":"https://api.github.com/users/dpinte/gists{/gist_id}","starred_url":"https://api.github.com/users/dpinte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpinte/subscriptions","organizations_url":"https://api.github.com/users/dpinte/orgs","repos_url":"https://api.github.com/users/dpinte/repos","events_url":"https://api.github.com/users/dpinte/events{/privacy}","received_events_url":"https://api.github.com/users/dpinte/received_events","type":"User","site_admin":false},"body":"Not for this one but for the next test sure. This test is about testing the internal comparison methods. The result should not be an int but a boolean. I'm fixing that","created_at":"2015-02-06T21:35:06Z","updated_at":"2015-02-06T21:35:06Z","html_url":"https://github.com/enthought/pyql/pull/35#discussion_r24273867","pull_request_url":"https://api.github.com/repos/enthought/pyql/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/enthought/pyql/pulls/comments/24273867"},"html":{"href":"https://github.com/enthought/pyql/pull/35#discussion_r24273867"},"pull_request":{"href":"https://api.github.com/repos/enthought/pyql/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/pyql/pulls/35","id":11223441,"html_url":"https://github.com/enthought/pyql/pull/35","diff_url":"https://github.com/enthought/pyql/pull/35.diff","patch_url":"https://github.com/enthought/pyql/pull/35.patch","issue_url":"https://api.github.com/repos/enthought/pyql/issues/35","number":35,"state":"open","locked":false,"title":"Add Python 3 support","user":{"login":"dpinte","id":538104,"avatar_url":"https://avatars.githubusercontent.com/u/538104?v=3","gravatar_id":"","url":"https://api.github.com/users/dpinte","html_url":"https://github.com/dpinte","followers_url":"https://api.github.com/users/dpinte/followers","following_url":"https://api.github.com/users/dpinte/following{/other_user}","gists_url":"https://api.github.com/users/dpinte/gists{/gist_id}","starred_url":"https://api.github.com/users/dpinte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpinte/subscriptions","organizations_url":"https://api.github.com/users/dpinte/orgs","repos_url":"https://api.github.com/users/dpinte/repos","events_url":"https://api.github.com/users/dpinte/events{/privacy}","received_events_url":"https://api.github.com/users/dpinte/received_events","type":"User","site_admin":false},"body":"Credits to @edschofield for the work.","created_at":"2014-01-03T23:56:50Z","updated_at":"2015-02-06T21:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d49f79e7e3084a33a883b0be2f76cbac54690603","assignee":{"login":"jvkersch","id":537559,"avatar_url":"https://avatars.githubusercontent.com/u/537559?v=3","gravatar_id":"","url":"https://api.github.com/users/jvkersch","html_url":"https://github.com/jvkersch","followers_url":"https://api.github.com/users/jvkersch/followers","following_url":"https://api.github.com/users/jvkersch/following{/other_user}","gists_url":"https://api.github.com/users/jvkersch/gists{/gist_id}","starred_url":"https://api.github.com/users/jvkersch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvkersch/subscriptions","organizations_url":"https://api.github.com/users/jvkersch/orgs","repos_url":"https://api.github.com/users/jvkersch/repos","events_url":"https://api.github.com/users/jvkersch/events{/privacy}","received_events_url":"https://api.github.com/users/jvkersch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/enthought/pyql/pulls/35/commits","review_comments_url":"https://api.github.com/repos/enthought/pyql/pulls/35/comments","review_comment_url":"https://api.github.com/repos/enthought/pyql/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enthought/pyql/issues/35/comments","statuses_url":"https://api.github.com/repos/enthought/pyql/statuses/6f004588b67cf174136e74a260655318c47d16cb","head":{"label":"enthought:python3","ref":"python3","sha":"6f004588b67cf174136e74a260655318c47d16cb","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":3665229,"name":"pyql","full_name":"enthought/pyql","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/pyql","description":"Cython QuantLib wrappers","fork":false,"url":"https://api.github.com/repos/enthought/pyql","forks_url":"https://api.github.com/repos/enthought/pyql/forks","keys_url":"https://api.github.com/repos/enthought/pyql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/pyql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/pyql/teams","hooks_url":"https://api.github.com/repos/enthought/pyql/hooks","issue_events_url":"https://api.github.com/repos/enthought/pyql/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/pyql/events","assignees_url":"https://api.github.com/repos/enthought/pyql/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/pyql/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/pyql/tags","blobs_url":"https://api.github.com/repos/enthought/pyql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/pyql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/pyql/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/pyql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/pyql/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/pyql/languages","stargazers_url":"https://api.github.com/repos/enthought/pyql/stargazers","contributors_url":"https://api.github.com/repos/enthought/pyql/contributors","subscribers_url":"https://api.github.com/repos/enthought/pyql/subscribers","subscription_url":"https://api.github.com/repos/enthought/pyql/subscription","commits_url":"https://api.github.com/repos/enthought/pyql/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/pyql/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/pyql/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/pyql/issues/comments/{number}","contents_url":"https://api.github.com/repos/enthought/pyql/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/pyql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/pyql/merges","archive_url":"https://api.github.com/repos/enthought/pyql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/pyql/downloads","issues_url":"https://api.github.com/repos/enthought/pyql/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/pyql/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/pyql/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/pyql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/pyql/labels{/name}","releases_url":"https://api.github.com/repos/enthought/pyql/releases{/id}","created_at":"2012-03-08T22:44:35Z","updated_at":"2015-02-03T15:30:11Z","pushed_at":"2015-02-06T21:19:30Z","git_url":"git://github.com/enthought/pyql.git","ssh_url":"git@github.com:enthought/pyql.git","clone_url":"https://github.com/enthought/pyql.git","svn_url":"https://github.com/enthought/pyql","homepage":"","size":3830,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":8,"forks":46,"open_issues":8,"watchers":89,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"9a1124517ad6832b380a762fe62c703c6a800ee5","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":3665229,"name":"pyql","full_name":"enthought/pyql","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/pyql","description":"Cython QuantLib wrappers","fork":false,"url":"https://api.github.com/repos/enthought/pyql","forks_url":"https://api.github.com/repos/enthought/pyql/forks","keys_url":"https://api.github.com/repos/enthought/pyql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/pyql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/pyql/teams","hooks_url":"https://api.github.com/repos/enthought/pyql/hooks","issue_events_url":"https://api.github.com/repos/enthought/pyql/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/pyql/events","assignees_url":"https://api.github.com/repos/enthought/pyql/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/pyql/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/pyql/tags","blobs_url":"https://api.github.com/repos/enthought/pyql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/pyql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/pyql/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/pyql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/pyql/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/pyql/languages","stargazers_url":"https://api.github.com/repos/enthought/pyql/stargazers","contributors_url":"https://api.github.com/repos/enthought/pyql/contributors","subscribers_url":"https://api.github.com/repos/enthought/pyql/subscribers","subscription_url":"https://api.github.com/repos/enthought/pyql/subscription","commits_url":"https://api.github.com/repos/enthought/pyql/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/pyql/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/pyql/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/pyql/issues/comments/{number}","contents_url":"https://api.github.com/repos/enthought/pyql/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/pyql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/pyql/merges","archive_url":"https://api.github.com/repos/enthought/pyql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/pyql/downloads","issues_url":"https://api.github.com/repos/enthought/pyql/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/pyql/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/pyql/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/pyql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/pyql/labels{/name}","releases_url":"https://api.github.com/repos/enthought/pyql/releases{/id}","created_at":"2012-03-08T22:44:35Z","updated_at":"2015-02-03T15:30:11Z","pushed_at":"2015-02-06T21:19:30Z","git_url":"git://github.com/enthought/pyql.git","ssh_url":"git@github.com:enthought/pyql.git","clone_url":"https://github.com/enthought/pyql.git","svn_url":"https://github.com/enthought/pyql","homepage":"","size":3830,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":8,"forks":46,"open_issues":8,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/pyql/pulls/35"},"html":{"href":"https://github.com/enthought/pyql/pull/35"},"issue":{"href":"https://api.github.com/repos/enthought/pyql/issues/35"},"comments":{"href":"https://api.github.com/repos/enthought/pyql/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/pyql/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/pyql/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enthought/pyql/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/pyql/statuses/6f004588b67cf174136e74a260655318c47d16cb"}}}}