{"action":"created","issue":{"url":"https://api.github.com/repos/fsek/web/issues/68","labels_url":"https://api.github.com/repos/fsek/web/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/fsek/web/issues/68/comments","events_url":"https://api.github.com/repos/fsek/web/issues/68/events","html_url":"https://github.com/fsek/web/issues/68","id":62828863,"number":68,"title":"Test coverage","user":{"login":"Zofz","id":6763624,"avatar_url":"https://avatars.githubusercontent.com/u/6763624?v=3","gravatar_id":"","url":"https://api.github.com/users/Zofz","html_url":"https://github.com/Zofz","followers_url":"https://api.github.com/users/Zofz/followers","following_url":"https://api.github.com/users/Zofz/following{/other_user}","gists_url":"https://api.github.com/users/Zofz/gists{/gist_id}","starred_url":"https://api.github.com/users/Zofz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zofz/subscriptions","organizations_url":"https://api.github.com/users/Zofz/orgs","repos_url":"https://api.github.com/users/Zofz/repos","events_url":"https://api.github.com/users/Zofz/events{/privacy}","received_events_url":"https://api.github.com/users/Zofz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fsek/web/labels/issue/feature","name":"issue/feature","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/fsek/web/milestones/10","html_url":"https://github.com/fsek/web/milestones/Testing","labels_url":"https://api.github.com/repos/fsek/web/milestones/10/labels","id":990743,"number":10,"title":"Testing","description":null,"creator":{"login":"Zofz","id":6763624,"avatar_url":"https://avatars.githubusercontent.com/u/6763624?v=3","gravatar_id":"","url":"https://api.github.com/users/Zofz","html_url":"https://github.com/Zofz","followers_url":"https://api.github.com/users/Zofz/followers","following_url":"https://api.github.com/users/Zofz/following{/other_user}","gists_url":"https://api.github.com/users/Zofz/gists{/gist_id}","starred_url":"https://api.github.com/users/Zofz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zofz/subscriptions","organizations_url":"https://api.github.com/users/Zofz/orgs","repos_url":"https://api.github.com/users/Zofz/repos","events_url":"https://api.github.com/users/Zofz/events{/privacy}","received_events_url":"https://api.github.com/users/Zofz/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2015-02-23T06:47:18Z","updated_at":"2015-03-20T22:39:12Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-03-18T23:43:04Z","updated_at":"2015-03-20T23:17:04Z","closed_at":null,"body":"Since we have not used any tests before, we need to start while introducing new features + create some tests for old modules.\r\n\r\n@fsek/admins \r\nWhat do you think about:\r\nhttps://gist.github.com/kyletcarlson/6234923\r\nhttps://gist.github.com/eliotsykes/5b71277b0813fbc0df56\r\n\r\nThis can be used as a form to create better unit tests for models and controllers.\r\nNot every model needs all the parts, and some needs more custom."},"comment":{"url":"https://api.github.com/repos/fsek/web/issues/comments/84187880","html_url":"https://github.com/fsek/web/issues/68#issuecomment-84187880","issue_url":"https://api.github.com/repos/fsek/web/issues/68","id":84187880,"user":{"login":"Zofz","id":6763624,"avatar_url":"https://avatars.githubusercontent.com/u/6763624?v=3","gravatar_id":"","url":"https://api.github.com/users/Zofz","html_url":"https://github.com/Zofz","followers_url":"https://api.github.com/users/Zofz/followers","following_url":"https://api.github.com/users/Zofz/following{/other_user}","gists_url":"https://api.github.com/users/Zofz/gists{/gist_id}","starred_url":"https://api.github.com/users/Zofz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zofz/subscriptions","organizations_url":"https://api.github.com/users/Zofz/orgs","repos_url":"https://api.github.com/users/Zofz/repos","events_url":"https://api.github.com/users/Zofz/events{/privacy}","received_events_url":"https://api.github.com/users/Zofz/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T23:17:04Z","updated_at":"2015-03-20T23:17:04Z","body":"I do think that our unit tests can be a bit overdone - since much of the code need refactoring and might be a bit more coupled than we want.\r\n\r\nWhen we have improved the code, introduced some proper Integration-tests we can reduce it again.\r\nI like the way you did you tests, very clean and efficient 😄 \r\nBut we should (heh) move from ```should```to ```expect``` since the Rspec.should syntax is getting deprecated."}}