{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/42065594","id":42065594,"diff_hunk":"@@ -424,6 +424,16 @@ def editor_saved(self, user, old_metadata, old_content):\n         This should be fixed too.\n         \"\"\"\n         metadata_was_changed_by_user = old_metadata != own_metadata(self)\n+        # If metadata is not changed by user and html5_sub does not exist.\n+        if self.sub and old_metadata.get('html5_sources', []) and not metadata_was_changed_by_user:\n+            html5_ids = get_html5_ids(old_metadata['html5_sources'])\n+            for subs_id in html5_ids:\n+                try:\n+                    Transcript.asset(self.location, subs_id)\n+                except NotFoundError:\n+                    metadata_was_changed_by_user = True\n+                    break","path":"common/lib/xmodule/xmodule/video_module/video_module.py","position":21,"original_position":21,"commit_id":"fcd9797024733ced79561bf21478110b8d564f68","original_commit_id":"fcd9797024733ced79561bf21478110b8d564f68","user":{"login":"adampalay","id":2748698,"avatar_url":"https://avatars.githubusercontent.com/u/2748698?v=3","gravatar_id":"","url":"https://api.github.com/users/adampalay","html_url":"https://github.com/adampalay","followers_url":"https://api.github.com/users/adampalay/followers","following_url":"https://api.github.com/users/adampalay/following{/other_user}","gists_url":"https://api.github.com/users/adampalay/gists{/gist_id}","starred_url":"https://api.github.com/users/adampalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adampalay/subscriptions","organizations_url":"https://api.github.com/users/adampalay/orgs","repos_url":"https://api.github.com/users/adampalay/repos","events_url":"https://api.github.com/users/adampalay/events{/privacy}","received_events_url":"https://api.github.com/users/adampalay/received_events","type":"User","site_admin":false},"body":"why do we break?","created_at":"2015-10-14T23:06:12Z","updated_at":"2015-10-14T23:06:12Z","html_url":"https://github.com/edx/edx-platform/pull/9924#discussion_r42065594","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/9924","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/42065594"},"html":{"href":"https://github.com/edx/edx-platform/pull/9924#discussion_r42065594"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9924"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9924","id":46135788,"html_url":"https://github.com/edx/edx-platform/pull/9924","diff_url":"https://github.com/edx/edx-platform/pull/9924.diff","patch_url":"https://github.com/edx/edx-platform/pull/9924.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9924","number":9924,"state":"open","locked":false,"title":"html5 transcript exists","user":{"login":"Shrhawk","id":7054417,"avatar_url":"https://avatars.githubusercontent.com/u/7054417?v=3","gravatar_id":"","url":"https://api.github.com/users/Shrhawk","html_url":"https://github.com/Shrhawk","followers_url":"https://api.github.com/users/Shrhawk/followers","following_url":"https://api.github.com/users/Shrhawk/following{/other_user}","gists_url":"https://api.github.com/users/Shrhawk/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrhawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrhawk/subscriptions","organizations_url":"https://api.github.com/users/Shrhawk/orgs","repos_url":"https://api.github.com/users/Shrhawk/repos","events_url":"https://api.github.com/users/Shrhawk/events{/privacy}","received_events_url":"https://api.github.com/users/Shrhawk/received_events","type":"User","site_admin":false},"body":"[TNL-3168](https://openedx.atlassian.net/browse/TNL-3168)\r\n\r\n**Steps to Reproduce:**\r\n1.Create a video component with youtube and html(mp4) url\r\n2.Save the component\r\n3.Edit the component and click import from youtube(transcript)\r\n4.Go to assets page of an course (transcript with youtube_id only)\r\n**Problem:**\r\n[editor_saved](https://github.com/edx/edx-platform/blob/35503ebda2ef0a34a9c53379e45e5f2b1c24d186/common/lib/xmodule/xmodule/video_module/video_module.py#L409) is not syncing subs for an edge case above.\r\n**Solution:**\r\nAt [editor_saved](https://github.com/edx/edx-platform/blob/35503ebda2ef0a34a9c53379e45e5f2b1c24d186/common/lib/xmodule/xmodule/video_module/video_module.py#L409) check if ```youtube_sub``` already exists and there is no ```html5_subs``` present for html5_resources then create new ```html5_subs```.\r\n","created_at":"2015-09-28T09:28:27Z","updated_at":"2015-10-14T23:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6dcb78a918d732a72d52d980d36b1330f8c589c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/9924/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/9924/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9924/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/fcd9797024733ced79561bf21478110b8d564f68","head":{"label":"edx:shr/bug/TNL-3168-import_from_youtube_html5_subs","ref":"shr/bug/TNL-3168-import_from_youtube_html5_subs","sha":"fcd9797024733ced79561bf21478110b8d564f68","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-10-14T22:12:53Z","pushed_at":"2015-10-14T22:36:14Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2188837,"stargazers_count":2173,"watchers_count":2173,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1315,"mirror_url":null,"open_issues_count":143,"forks":1315,"open_issues":143,"watchers":2173,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ec023c22e6966faefa402d1e5801fef5adabc33b","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-10-14T22:12:53Z","pushed_at":"2015-10-14T22:36:14Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2188837,"stargazers_count":2173,"watchers_count":2173,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1315,"mirror_url":null,"open_issues_count":143,"forks":1315,"open_issues":143,"watchers":2173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9924"},"html":{"href":"https://github.com/edx/edx-platform/pull/9924"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9924"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9924/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9924/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9924/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/fcd9797024733ced79561bf21478110b8d564f68"}}}}