{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/mozdownload/pulls/comments/24339069","id":24339069,"diff_hunk":"@@ -66,7 +66,15 @@ def test_download(self):\n                           scraper2.download)\n \n     def test_notimplementedexceptions(self):\n-        scraper = mozdownload.Scraper(directory=self.temp_dir,\n+        filename = 'download_test.txt'\n+        # standard download\n+        test_url = urljoin(self.wdir, 'download_test.txt')\n+        scraper = mozdownload.DirectScraper(url=test_url,\n+                                            destination=self.temp_dir,\n+                                            version=None,\n+                                            log_level='ERROR')\n+        scraper.download()\n+        scraper = mozdownload.Scraper(destination=self.temp_dir,","path":"tests/base_scraper/test_base_scraper.py","position":49,"original_position":49,"commit_id":"cab7d0e7ba0394f27886f701190db12786535e0a","original_commit_id":"cab7d0e7ba0394f27886f701190db12786535e0a","user":{"login":"whimboo","id":129603,"avatar_url":"https://avatars.githubusercontent.com/u/129603?v=3","gravatar_id":"","url":"https://api.github.com/users/whimboo","html_url":"https://github.com/whimboo","followers_url":"https://api.github.com/users/whimboo/followers","following_url":"https://api.github.com/users/whimboo/following{/other_user}","gists_url":"https://api.github.com/users/whimboo/gists{/gist_id}","starred_url":"https://api.github.com/users/whimboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whimboo/subscriptions","organizations_url":"https://api.github.com/users/whimboo/orgs","repos_url":"https://api.github.com/users/whimboo/repos","events_url":"https://api.github.com/users/whimboo/events{/privacy}","received_events_url":"https://api.github.com/users/whimboo/received_events","type":"User","site_admin":false},"body":"I asked about those changes in my last review. Maybe you have missed to remove them? This is not related to the test method you placed the code into.","created_at":"2015-02-09T16:07:45Z","updated_at":"2015-02-09T16:07:45Z","html_url":"https://github.com/mozilla/mozdownload/pull/234#discussion_r24339069","pull_request_url":"https://api.github.com/repos/mozilla/mozdownload/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozdownload/pulls/comments/24339069"},"html":{"href":"https://github.com/mozilla/mozdownload/pull/234#discussion_r24339069"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozdownload/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/mozdownload/pulls/234","id":27465236,"html_url":"https://github.com/mozilla/mozdownload/pull/234","diff_url":"https://github.com/mozilla/mozdownload/pull/234.diff","patch_url":"https://github.com/mozilla/mozdownload/pull/234.patch","issue_url":"https://api.github.com/repos/mozilla/mozdownload/issues/234","number":234,"state":"open","locked":false,"title":"Replace directory with destination, allow specifying filename (#92)","user":{"login":"ujjwalwahi","id":1370255,"avatar_url":"https://avatars.githubusercontent.com/u/1370255?v=3","gravatar_id":"","url":"https://api.github.com/users/ujjwalwahi","html_url":"https://github.com/ujjwalwahi","followers_url":"https://api.github.com/users/ujjwalwahi/followers","following_url":"https://api.github.com/users/ujjwalwahi/following{/other_user}","gists_url":"https://api.github.com/users/ujjwalwahi/gists{/gist_id}","starred_url":"https://api.github.com/users/ujjwalwahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujjwalwahi/subscriptions","organizations_url":"https://api.github.com/users/ujjwalwahi/orgs","repos_url":"https://api.github.com/users/ujjwalwahi/repos","events_url":"https://api.github.com/users/ujjwalwahi/events{/privacy}","received_events_url":"https://api.github.com/users/ujjwalwahi/received_events","type":"User","site_admin":false},"body":"@whimboo \r\nReplaced directory(-d, --directory) with destination(-d, --dest), now user can specify filename of the download content. Also updated test cases to test added functionality.\r\n","created_at":"2015-01-15T21:48:31Z","updated_at":"2015-02-09T16:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5252baa43e13c3d3392ee528a9bf87fa1fe34aa","assignee":{"login":"ujjwalwahi","id":1370255,"avatar_url":"https://avatars.githubusercontent.com/u/1370255?v=3","gravatar_id":"","url":"https://api.github.com/users/ujjwalwahi","html_url":"https://github.com/ujjwalwahi","followers_url":"https://api.github.com/users/ujjwalwahi/followers","following_url":"https://api.github.com/users/ujjwalwahi/following{/other_user}","gists_url":"https://api.github.com/users/ujjwalwahi/gists{/gist_id}","starred_url":"https://api.github.com/users/ujjwalwahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujjwalwahi/subscriptions","organizations_url":"https://api.github.com/users/ujjwalwahi/orgs","repos_url":"https://api.github.com/users/ujjwalwahi/repos","events_url":"https://api.github.com/users/ujjwalwahi/events{/privacy}","received_events_url":"https://api.github.com/users/ujjwalwahi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/mozdownload/pulls/234/commits","review_comments_url":"https://api.github.com/repos/mozilla/mozdownload/pulls/234/comments","review_comment_url":"https://api.github.com/repos/mozilla/mozdownload/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/mozdownload/issues/234/comments","statuses_url":"https://api.github.com/repos/mozilla/mozdownload/statuses/cab7d0e7ba0394f27886f701190db12786535e0a","head":{"label":"ujjwalwahi:master","ref":"master","sha":"cab7d0e7ba0394f27886f701190db12786535e0a","user":{"login":"ujjwalwahi","id":1370255,"avatar_url":"https://avatars.githubusercontent.com/u/1370255?v=3","gravatar_id":"","url":"https://api.github.com/users/ujjwalwahi","html_url":"https://github.com/ujjwalwahi","followers_url":"https://api.github.com/users/ujjwalwahi/followers","following_url":"https://api.github.com/users/ujjwalwahi/following{/other_user}","gists_url":"https://api.github.com/users/ujjwalwahi/gists{/gist_id}","starred_url":"https://api.github.com/users/ujjwalwahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujjwalwahi/subscriptions","organizations_url":"https://api.github.com/users/ujjwalwahi/orgs","repos_url":"https://api.github.com/users/ujjwalwahi/repos","events_url":"https://api.github.com/users/ujjwalwahi/events{/privacy}","received_events_url":"https://api.github.com/users/ujjwalwahi/received_events","type":"User","site_admin":false},"repo":{"id":29241097,"name":"mozdownload","full_name":"ujjwalwahi/mozdownload","owner":{"login":"ujjwalwahi","id":1370255,"avatar_url":"https://avatars.githubusercontent.com/u/1370255?v=3","gravatar_id":"","url":"https://api.github.com/users/ujjwalwahi","html_url":"https://github.com/ujjwalwahi","followers_url":"https://api.github.com/users/ujjwalwahi/followers","following_url":"https://api.github.com/users/ujjwalwahi/following{/other_user}","gists_url":"https://api.github.com/users/ujjwalwahi/gists{/gist_id}","starred_url":"https://api.github.com/users/ujjwalwahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujjwalwahi/subscriptions","organizations_url":"https://api.github.com/users/ujjwalwahi/orgs","repos_url":"https://api.github.com/users/ujjwalwahi/repos","events_url":"https://api.github.com/users/ujjwalwahi/events{/privacy}","received_events_url":"https://api.github.com/users/ujjwalwahi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ujjwalwahi/mozdownload","description":"Easy to use download tool and API for different types of Firefox and Thunderbird builds","fork":true,"url":"https://api.github.com/repos/ujjwalwahi/mozdownload","forks_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/forks","keys_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/teams","hooks_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/hooks","issue_events_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/issues/events{/number}","events_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/events","assignees_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/assignees{/user}","branches_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/branches{/branch}","tags_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/tags","blobs_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/git/refs{/sha}","trees_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/statuses/{sha}","languages_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/languages","stargazers_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/stargazers","contributors_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/contributors","subscribers_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/subscribers","subscription_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/subscription","commits_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/commits{/sha}","git_commits_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/git/commits{/sha}","comments_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/comments{/number}","issue_comment_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/issues/comments/{number}","contents_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/contents/{+path}","compare_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/merges","archive_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/downloads","issues_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/issues{/number}","pulls_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/pulls{/number}","milestones_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/milestones{/number}","notifications_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/labels{/name}","releases_url":"https://api.github.com/repos/ujjwalwahi/mozdownload/releases{/id}","created_at":"2015-01-14T11:25:49Z","updated_at":"2015-02-02T20:26:29Z","pushed_at":"2015-02-02T20:26:28Z","git_url":"git://github.com/ujjwalwahi/mozdownload.git","ssh_url":"git@github.com:ujjwalwahi/mozdownload.git","clone_url":"https://github.com/ujjwalwahi/mozdownload.git","svn_url":"https://github.com/ujjwalwahi/mozdownload","homepage":"http://pypi.python.org/pypi/mozdownload","size":297,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"e102ac515b7de55ad165ae7833f25fca7d8722e9","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":4421513,"name":"mozdownload","full_name":"mozilla/mozdownload","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/mozdownload","description":"Easy to use download tool and API for different types of Firefox and Thunderbird builds","fork":false,"url":"https://api.github.com/repos/mozilla/mozdownload","forks_url":"https://api.github.com/repos/mozilla/mozdownload/forks","keys_url":"https://api.github.com/repos/mozilla/mozdownload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mozdownload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mozdownload/teams","hooks_url":"https://api.github.com/repos/mozilla/mozdownload/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mozdownload/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mozdownload/events","assignees_url":"https://api.github.com/repos/mozilla/mozdownload/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mozdownload/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mozdownload/tags","blobs_url":"https://api.github.com/repos/mozilla/mozdownload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mozdownload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mozdownload/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mozdownload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mozdownload/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mozdownload/languages","stargazers_url":"https://api.github.com/repos/mozilla/mozdownload/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mozdownload/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mozdownload/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mozdownload/subscription","commits_url":"https://api.github.com/repos/mozilla/mozdownload/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mozdownload/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mozdownload/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mozdownload/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/mozdownload/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mozdownload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mozdownload/merges","archive_url":"https://api.github.com/repos/mozilla/mozdownload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mozdownload/downloads","issues_url":"https://api.github.com/repos/mozilla/mozdownload/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mozdownload/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mozdownload/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mozdownload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mozdownload/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mozdownload/releases{/id}","created_at":"2012-05-23T15:06:09Z","updated_at":"2015-01-16T18:04:21Z","pushed_at":"2015-01-16T18:04:19Z","git_url":"git://github.com/mozilla/mozdownload.git","ssh_url":"git@github.com:mozilla/mozdownload.git","clone_url":"https://github.com/mozilla/mozdownload.git","svn_url":"https://github.com/mozilla/mozdownload","homepage":"http://pypi.python.org/pypi/mozdownload","size":23488,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":51,"forks":23,"open_issues":51,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozdownload/pulls/234"},"html":{"href":"https://github.com/mozilla/mozdownload/pull/234"},"issue":{"href":"https://api.github.com/repos/mozilla/mozdownload/issues/234"},"comments":{"href":"https://api.github.com/repos/mozilla/mozdownload/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/mozdownload/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/mozdownload/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/mozdownload/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/mozdownload/statuses/cab7d0e7ba0394f27886f701190db12786535e0a"}}}}