{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/comments/24632888","id":24632888,"diff_hunk":"@@ -40,6 +44,11 @@ class << fake_matcher\n \n   context 'greater_than_or_equal_to' do\n     it do\n+      expect(instance_with_validations(greater_than_or_equal_to: 2, strict: true))\n+        .to matcher.is_greater_than_or_equal_to(2).strict","path":"spec/unit/shoulda/matchers/active_model/numericality_matchers/comparison_matcher_spec.rb","position":16,"original_position":16,"commit_id":"5f20a8c393455f350eb9ec86838e0b92d578c221","original_commit_id":"5f20a8c393455f350eb9ec86838e0b92d578c221","user":{"login":"mcmire","id":7371,"avatar_url":"https://avatars.githubusercontent.com/u/7371?v=3","gravatar_id":"","url":"https://api.github.com/users/mcmire","html_url":"https://github.com/mcmire","followers_url":"https://api.github.com/users/mcmire/followers","following_url":"https://api.github.com/users/mcmire/following{/other_user}","gists_url":"https://api.github.com/users/mcmire/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmire/subscriptions","organizations_url":"https://api.github.com/users/mcmire/orgs","repos_url":"https://api.github.com/users/mcmire/repos","events_url":"https://api.github.com/users/mcmire/events{/privacy}","received_events_url":"https://api.github.com/users/mcmire/received_events","type":"User","site_admin":false},"body":"This is true and same for the other warnings just like this. Not sure how the bad style crept through for other tests.","created_at":"2015-02-12T23:48:21Z","updated_at":"2015-02-12T23:48:21Z","html_url":"https://github.com/thoughtbot/shoulda-matchers/pull/620#discussion_r24632888","pull_request_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/comments/24632888"},"html":{"href":"https://github.com/thoughtbot/shoulda-matchers/pull/620#discussion_r24632888"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620","id":25456096,"html_url":"https://github.com/thoughtbot/shoulda-matchers/pull/620","diff_url":"https://github.com/thoughtbot/shoulda-matchers/pull/620.diff","patch_url":"https://github.com/thoughtbot/shoulda-matchers/pull/620.patch","issue_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues/620","number":620,"state":"open","locked":false,"title":"Failing test strict option on numericality matcher","user":{"login":"Adam89","id":2530296,"avatar_url":"https://avatars.githubusercontent.com/u/2530296?v=3","gravatar_id":"","url":"https://api.github.com/users/Adam89","html_url":"https://github.com/Adam89","followers_url":"https://api.github.com/users/Adam89/followers","following_url":"https://api.github.com/users/Adam89/following{/other_user}","gists_url":"https://api.github.com/users/Adam89/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam89/subscriptions","organizations_url":"https://api.github.com/users/Adam89/orgs","repos_url":"https://api.github.com/users/Adam89/repos","events_url":"https://api.github.com/users/Adam89/events{/privacy}","received_events_url":"https://api.github.com/users/Adam89/received_events","type":"User","site_admin":false},"body":"This is related to issue #613 \r\n","created_at":"2014-12-03T22:08:41Z","updated_at":"2015-02-12T23:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6293a18434d7340984c7ddb45508f15764dd1255","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues/620/comments","statuses_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/statuses/5f20a8c393455f350eb9ec86838e0b92d578c221","head":{"label":"Adam89:ma-validate-numericality-strictly","ref":"ma-validate-numericality-strictly","sha":"5f20a8c393455f350eb9ec86838e0b92d578c221","user":{"login":"Adam89","id":2530296,"avatar_url":"https://avatars.githubusercontent.com/u/2530296?v=3","gravatar_id":"","url":"https://api.github.com/users/Adam89","html_url":"https://github.com/Adam89","followers_url":"https://api.github.com/users/Adam89/followers","following_url":"https://api.github.com/users/Adam89/following{/other_user}","gists_url":"https://api.github.com/users/Adam89/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam89/subscriptions","organizations_url":"https://api.github.com/users/Adam89/orgs","repos_url":"https://api.github.com/users/Adam89/repos","events_url":"https://api.github.com/users/Adam89/events{/privacy}","received_events_url":"https://api.github.com/users/Adam89/received_events","type":"User","site_admin":false},"repo":{"id":21220285,"name":"shoulda-matchers","full_name":"Adam89/shoulda-matchers","owner":{"login":"Adam89","id":2530296,"avatar_url":"https://avatars.githubusercontent.com/u/2530296?v=3","gravatar_id":"","url":"https://api.github.com/users/Adam89","html_url":"https://github.com/Adam89","followers_url":"https://api.github.com/users/Adam89/followers","following_url":"https://api.github.com/users/Adam89/following{/other_user}","gists_url":"https://api.github.com/users/Adam89/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam89/subscriptions","organizations_url":"https://api.github.com/users/Adam89/orgs","repos_url":"https://api.github.com/users/Adam89/repos","events_url":"https://api.github.com/users/Adam89/events{/privacy}","received_events_url":"https://api.github.com/users/Adam89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Adam89/shoulda-matchers","description":"Collection of testing matchers extracted from Shoulda","fork":true,"url":"https://api.github.com/repos/Adam89/shoulda-matchers","forks_url":"https://api.github.com/repos/Adam89/shoulda-matchers/forks","keys_url":"https://api.github.com/repos/Adam89/shoulda-matchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adam89/shoulda-matchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adam89/shoulda-matchers/teams","hooks_url":"https://api.github.com/repos/Adam89/shoulda-matchers/hooks","issue_events_url":"https://api.github.com/repos/Adam89/shoulda-matchers/issues/events{/number}","events_url":"https://api.github.com/repos/Adam89/shoulda-matchers/events","assignees_url":"https://api.github.com/repos/Adam89/shoulda-matchers/assignees{/user}","branches_url":"https://api.github.com/repos/Adam89/shoulda-matchers/branches{/branch}","tags_url":"https://api.github.com/repos/Adam89/shoulda-matchers/tags","blobs_url":"https://api.github.com/repos/Adam89/shoulda-matchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adam89/shoulda-matchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adam89/shoulda-matchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adam89/shoulda-matchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adam89/shoulda-matchers/statuses/{sha}","languages_url":"https://api.github.com/repos/Adam89/shoulda-matchers/languages","stargazers_url":"https://api.github.com/repos/Adam89/shoulda-matchers/stargazers","contributors_url":"https://api.github.com/repos/Adam89/shoulda-matchers/contributors","subscribers_url":"https://api.github.com/repos/Adam89/shoulda-matchers/subscribers","subscription_url":"https://api.github.com/repos/Adam89/shoulda-matchers/subscription","commits_url":"https://api.github.com/repos/Adam89/shoulda-matchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adam89/shoulda-matchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adam89/shoulda-matchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adam89/shoulda-matchers/issues/comments/{number}","contents_url":"https://api.github.com/repos/Adam89/shoulda-matchers/contents/{+path}","compare_url":"https://api.github.com/repos/Adam89/shoulda-matchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adam89/shoulda-matchers/merges","archive_url":"https://api.github.com/repos/Adam89/shoulda-matchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adam89/shoulda-matchers/downloads","issues_url":"https://api.github.com/repos/Adam89/shoulda-matchers/issues{/number}","pulls_url":"https://api.github.com/repos/Adam89/shoulda-matchers/pulls{/number}","milestones_url":"https://api.github.com/repos/Adam89/shoulda-matchers/milestones{/number}","notifications_url":"https://api.github.com/repos/Adam89/shoulda-matchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adam89/shoulda-matchers/labels{/name}","releases_url":"https://api.github.com/repos/Adam89/shoulda-matchers/releases{/id}","created_at":"2014-06-25T22:09:57Z","updated_at":"2015-01-30T23:56:29Z","pushed_at":"2015-01-30T23:56:27Z","git_url":"git://github.com/Adam89/shoulda-matchers.git","ssh_url":"git@github.com:Adam89/shoulda-matchers.git","clone_url":"https://github.com/Adam89/shoulda-matchers.git","svn_url":"https://github.com/Adam89/shoulda-matchers","homepage":"http://thoughtbot.com/community","size":3591,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"bbd0d5ed25a66e65ae0232e853ed937ed6ecf40e","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":1172597,"name":"shoulda-matchers","full_name":"thoughtbot/shoulda-matchers","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/shoulda-matchers","description":"Collection of testing matchers extracted from Shoulda","fork":false,"url":"https://api.github.com/repos/thoughtbot/shoulda-matchers","forks_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/forks","keys_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/teams","hooks_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/events","assignees_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/tags","blobs_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/subscription","commits_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/merges","archive_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/downloads","issues_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/shoulda-matchers/releases{/id}","created_at":"2010-12-15T22:41:52Z","updated_at":"2015-02-12T23:10:33Z","pushed_at":"2015-02-12T23:25:06Z","git_url":"git://github.com/thoughtbot/shoulda-matchers.git","ssh_url":"git@github.com:thoughtbot/shoulda-matchers.git","clone_url":"https://github.com/thoughtbot/shoulda-matchers.git","svn_url":"https://github.com/thoughtbot/shoulda-matchers","homepage":"http://matchers.shoulda.io","size":17108,"stargazers_count":1074,"watchers_count":1074,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":311,"mirror_url":null,"open_issues_count":44,"forks":311,"open_issues":44,"watchers":1074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620"},"html":{"href":"https://github.com/thoughtbot/shoulda-matchers/pull/620"},"issue":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues/620"},"comments":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/shoulda-matchers/statuses/5f20a8c393455f350eb9ec86838e0b92d578c221"}}}}