{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/28774504","id":28774504,"diff_hunk":"@@ -32,8 +32,9 @@ static const char *post_verb = \"POST\";\n \n #define OWNING_SUBTRANSPORT(s) ((http_subtransport *)(s)->parent.subtransport)\n \n-#define PARSE_ERROR_GENERIC\t-1\n-#define PARSE_ERROR_REPLAY\t-2\n+#define PARSE_ERROR_GENERIC\tGIT_ERROR\n+#define PARSE_ERROR_AUTHENTICATION\tGIT_EAUTH\n+#define PARSE_ERROR_REPLAY\t1","path":"src/transports/http.c","position":8,"original_position":8,"commit_id":"8af7356167edc6fa3bc0fd19a3c3f2ce500b5468","original_commit_id":"8af7356167edc6fa3bc0fd19a3c3f2ce500b5468","user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"body":"I think that makes sense, but then let's not redefine `GIT_` constants, let's just use them directly and keep `PARSE_ERROR` constants in the > 0 range.","created_at":"2015-04-21T12:57:26Z","updated_at":"2015-04-21T12:57:26Z","html_url":"https://github.com/libgit2/libgit2/pull/3062#discussion_r28774504","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3062","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/28774504"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3062#discussion_r28774504"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3062"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3062","id":33735816,"html_url":"https://github.com/libgit2/libgit2/pull/3062","diff_url":"https://github.com/libgit2/libgit2/pull/3062.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3062.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3062","number":3062,"state":"open","locked":false,"title":"Return GIT_EAUTH when authentication callbacks are missing for HTTP or S...","user":{"login":"swisspol","id":627915,"avatar_url":"https://avatars.githubusercontent.com/u/627915?v=3","gravatar_id":"","url":"https://api.github.com/users/swisspol","html_url":"https://github.com/swisspol","followers_url":"https://api.github.com/users/swisspol/followers","following_url":"https://api.github.com/users/swisspol/following{/other_user}","gists_url":"https://api.github.com/users/swisspol/gists{/gist_id}","starred_url":"https://api.github.com/users/swisspol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swisspol/subscriptions","organizations_url":"https://api.github.com/users/swisspol/orgs","repos_url":"https://api.github.com/users/swisspol/repos","events_url":"https://api.github.com/users/swisspol/events{/privacy}","received_events_url":"https://api.github.com/users/swisspol/received_events","type":"User","site_admin":false},"body":"...SH\r\n\r\nThis allows clients that either do not show an authentication UI, or show one\r\nbut let the user cancel and return GIT_PASSTHROUGH, to identify such cases from\r\nthe final error code returned by libgit2.","created_at":"2015-04-21T07:39:56Z","updated_at":"2015-04-21T12:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5121af2a4435aa94c793b0b0eaea39858a66a938","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3062/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3062/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3062/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/8af7356167edc6fa3bc0fd19a3c3f2ce500b5468","head":{"label":"git-up:eauth","ref":"eauth","sha":"8af7356167edc6fa3bc0fd19a3c3f2ce500b5468","user":{"login":"git-up","id":10783260,"avatar_url":"https://avatars.githubusercontent.com/u/10783260?v=3","gravatar_id":"","url":"https://api.github.com/users/git-up","html_url":"https://github.com/git-up","followers_url":"https://api.github.com/users/git-up/followers","following_url":"https://api.github.com/users/git-up/following{/other_user}","gists_url":"https://api.github.com/users/git-up/gists{/gist_id}","starred_url":"https://api.github.com/users/git-up/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-up/subscriptions","organizations_url":"https://api.github.com/users/git-up/orgs","repos_url":"https://api.github.com/users/git-up/repos","events_url":"https://api.github.com/users/git-up/events{/privacy}","received_events_url":"https://api.github.com/users/git-up/received_events","type":"Organization","site_admin":false},"repo":{"id":25694440,"name":"libgit2","full_name":"git-up/libgit2","owner":{"login":"git-up","id":10783260,"avatar_url":"https://avatars.githubusercontent.com/u/10783260?v=3","gravatar_id":"","url":"https://api.github.com/users/git-up","html_url":"https://github.com/git-up","followers_url":"https://api.github.com/users/git-up/followers","following_url":"https://api.github.com/users/git-up/following{/other_user}","gists_url":"https://api.github.com/users/git-up/gists{/gist_id}","starred_url":"https://api.github.com/users/git-up/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-up/subscriptions","organizations_url":"https://api.github.com/users/git-up/orgs","repos_url":"https://api.github.com/users/git-up/repos","events_url":"https://api.github.com/users/git-up/events{/privacy}","received_events_url":"https://api.github.com/users/git-up/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/git-up/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/git-up/libgit2","forks_url":"https://api.github.com/repos/git-up/libgit2/forks","keys_url":"https://api.github.com/repos/git-up/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/git-up/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/git-up/libgit2/teams","hooks_url":"https://api.github.com/repos/git-up/libgit2/hooks","issue_events_url":"https://api.github.com/repos/git-up/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/git-up/libgit2/events","assignees_url":"https://api.github.com/repos/git-up/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/git-up/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/git-up/libgit2/tags","blobs_url":"https://api.github.com/repos/git-up/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/git-up/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/git-up/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/git-up/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/git-up/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/git-up/libgit2/languages","stargazers_url":"https://api.github.com/repos/git-up/libgit2/stargazers","contributors_url":"https://api.github.com/repos/git-up/libgit2/contributors","subscribers_url":"https://api.github.com/repos/git-up/libgit2/subscribers","subscription_url":"https://api.github.com/repos/git-up/libgit2/subscription","commits_url":"https://api.github.com/repos/git-up/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/git-up/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/git-up/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/git-up/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/git-up/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/git-up/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/git-up/libgit2/merges","archive_url":"https://api.github.com/repos/git-up/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/git-up/libgit2/downloads","issues_url":"https://api.github.com/repos/git-up/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/git-up/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/git-up/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/git-up/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/git-up/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/git-up/libgit2/releases{/id}","created_at":"2014-10-24T15:19:55Z","updated_at":"2015-04-21T07:05:30Z","pushed_at":"2015-04-21T07:39:25Z","git_url":"git://github.com/git-up/libgit2.git","ssh_url":"git@github.com:git-up/libgit2.git","clone_url":"https://github.com/git-up/libgit2.git","svn_url":"https://github.com/git-up/libgit2","homepage":"http://libgit2.github.com","size":17474,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"08c45213b164fdb456c1b19b98039365c8f0cf98","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","created_at":"2010-09-10T16:17:48Z","updated_at":"2015-04-21T12:38:25Z","pushed_at":"2015-04-21T12:38:24Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":110380,"stargazers_count":4849,"watchers_count":4849,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1131,"mirror_url":null,"open_issues_count":120,"forks":1131,"open_issues":120,"watchers":4849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3062"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3062"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3062"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3062/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3062/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3062/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/8af7356167edc6fa3bc0fd19a3c3f2ce500b5468"}}}}