{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-lint/pulls/comments/48138762","id":48138762,"diff_hunk":"@@ -26,21 +26,21 @@ def write(self, text, hashline=u\"# {}\"):\n         be changed to accommodate different file syntaxes.\n \n         Arguments:\n-            text (unicode string): the contents of the file to write.\n+            text (byte string): the contents of the file to write.\n \n-            hashline (unicode string): the format of the last line to append to\n+            hashline (byte string): the format of the last line to append to\n                 the file, with \"{}\" replaced with the hash.","path":"edx_lint/tamper_evident.py","position":18,"original_position":18,"commit_id":"b24984b63df91c32ad514db0b6ba6598eeb26ade","original_commit_id":"b24984b63df91c32ad514db0b6ba6598eeb26ade","user":{"login":"cpennington","id":30236,"avatar_url":"https://avatars.githubusercontent.com/u/30236?v=3","gravatar_id":"","url":"https://api.github.com/users/cpennington","html_url":"https://github.com/cpennington","followers_url":"https://api.github.com/users/cpennington/followers","following_url":"https://api.github.com/users/cpennington/following{/other_user}","gists_url":"https://api.github.com/users/cpennington/gists{/gist_id}","starred_url":"https://api.github.com/users/cpennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpennington/subscriptions","organizations_url":"https://api.github.com/users/cpennington/orgs","repos_url":"https://api.github.com/users/cpennington/repos","events_url":"https://api.github.com/users/cpennington/events{/privacy}","received_events_url":"https://api.github.com/users/cpennington/received_events","type":"User","site_admin":false},"body":"In fact, both arguments must be, otherwise the file contents will be encoded with different encodings in different places, which would be unfortunate.","created_at":"2015-12-21T11:48:09Z","updated_at":"2015-12-21T11:48:09Z","html_url":"https://github.com/edx/edx-lint/pull/31#discussion_r48138762","pull_request_url":"https://api.github.com/repos/edx/edx-lint/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/comments/48138762"},"html":{"href":"https://github.com/edx/edx-lint/pull/31#discussion_r48138762"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-lint/pulls/31","id":54199282,"html_url":"https://github.com/edx/edx-lint/pull/31","diff_url":"https://github.com/edx/edx-lint/pull/31.diff","patch_url":"https://github.com/edx/edx-lint/pull/31.patch","issue_url":"https://api.github.com/repos/edx/edx-lint/issues/31","number":31,"state":"open","locked":false,"title":"Clean up, especially for Python 3","user":{"login":"nedbat","id":23789,"avatar_url":"https://avatars.githubusercontent.com/u/23789?v=3","gravatar_id":"","url":"https://api.github.com/users/nedbat","html_url":"https://github.com/nedbat","followers_url":"https://api.github.com/users/nedbat/followers","following_url":"https://api.github.com/users/nedbat/following{/other_user}","gists_url":"https://api.github.com/users/nedbat/gists{/gist_id}","starred_url":"https://api.github.com/users/nedbat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedbat/subscriptions","organizations_url":"https://api.github.com/users/nedbat/orgs","repos_url":"https://api.github.com/users/nedbat/repos","events_url":"https://api.github.com/users/nedbat/events{/privacy}","received_events_url":"https://api.github.com/users/nedbat/received_events","type":"User","site_admin":false},"body":"This changes the file operations back to pure byte strings.  Also, uses tox for testing, so we can easily test Python 2 and 3 locally.","created_at":"2015-12-20T13:20:20Z","updated_at":"2015-12-21T11:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dbb87aa1be3c12022311f9144a86dede1f1259d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-lint/pulls/31/commits","review_comments_url":"https://api.github.com/repos/edx/edx-lint/pulls/31/comments","review_comment_url":"https://api.github.com/repos/edx/edx-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-lint/issues/31/comments","statuses_url":"https://api.github.com/repos/edx/edx-lint/statuses/b24984b63df91c32ad514db0b6ba6598eeb26ade","head":{"label":"edx:ned/python3-cleanup","ref":"ned/python3-cleanup","sha":"b24984b63df91c32ad514db0b6ba6598eeb26ade","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30004785,"name":"edx-lint","full_name":"edx/edx-lint","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-lint","description":"repo to contain any/all pylint checkers","fork":false,"url":"https://api.github.com/repos/edx/edx-lint","forks_url":"https://api.github.com/repos/edx/edx-lint/forks","keys_url":"https://api.github.com/repos/edx/edx-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-lint/teams","hooks_url":"https://api.github.com/repos/edx/edx-lint/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-lint/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-lint/events","assignees_url":"https://api.github.com/repos/edx/edx-lint/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-lint/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-lint/tags","blobs_url":"https://api.github.com/repos/edx/edx-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-lint/languages","stargazers_url":"https://api.github.com/repos/edx/edx-lint/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-lint/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-lint/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-lint/subscription","commits_url":"https://api.github.com/repos/edx/edx-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-lint/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-lint/merges","archive_url":"https://api.github.com/repos/edx/edx-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-lint/downloads","issues_url":"https://api.github.com/repos/edx/edx-lint/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-lint/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-lint/releases{/id}","created_at":"2015-01-29T05:14:33Z","updated_at":"2015-12-09T13:35:01Z","pushed_at":"2015-12-21T01:08:18Z","git_url":"git://github.com/edx/edx-lint.git","ssh_url":"git@github.com:edx/edx-lint.git","clone_url":"https://github.com/edx/edx-lint.git","svn_url":"https://github.com/edx/edx-lint","homepage":null,"size":103,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"733b878098d87240d8828c1744742d6c2bec9334","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30004785,"name":"edx-lint","full_name":"edx/edx-lint","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-lint","description":"repo to contain any/all pylint checkers","fork":false,"url":"https://api.github.com/repos/edx/edx-lint","forks_url":"https://api.github.com/repos/edx/edx-lint/forks","keys_url":"https://api.github.com/repos/edx/edx-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-lint/teams","hooks_url":"https://api.github.com/repos/edx/edx-lint/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-lint/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-lint/events","assignees_url":"https://api.github.com/repos/edx/edx-lint/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-lint/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-lint/tags","blobs_url":"https://api.github.com/repos/edx/edx-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-lint/languages","stargazers_url":"https://api.github.com/repos/edx/edx-lint/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-lint/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-lint/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-lint/subscription","commits_url":"https://api.github.com/repos/edx/edx-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-lint/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-lint/merges","archive_url":"https://api.github.com/repos/edx/edx-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-lint/downloads","issues_url":"https://api.github.com/repos/edx/edx-lint/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-lint/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-lint/releases{/id}","created_at":"2015-01-29T05:14:33Z","updated_at":"2015-12-09T13:35:01Z","pushed_at":"2015-12-21T01:08:18Z","git_url":"git://github.com/edx/edx-lint.git","ssh_url":"git@github.com:edx/edx-lint.git","clone_url":"https://github.com/edx/edx-lint.git","svn_url":"https://github.com/edx/edx-lint","homepage":null,"size":103,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/31"},"html":{"href":"https://github.com/edx/edx-lint/pull/31"},"issue":{"href":"https://api.github.com/repos/edx/edx-lint/issues/31"},"comments":{"href":"https://api.github.com/repos/edx/edx-lint/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-lint/statuses/b24984b63df91c32ad514db0b6ba6598eeb26ade"}}}}