{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/6227","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227/events","html_url":"https://github.com/xbmc/xbmc/pull/6227","id":54809559,"number":6227,"title":"[binary addons] move PVR addons to our binary addons buildsystem","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR","name":"PVR","color":"e102d8"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/RFC","name":"RFC","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":93,"created_at":"2015-01-19T20:39:11Z","updated_at":"2015-02-02T13:22:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6227","html_url":"https://github.com/xbmc/xbmc/pull/6227","diff_url":"https://github.com/xbmc/xbmc/pull/6227.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6227.patch"},"body":"These commits (and all the PVR addons in my github account) are my initial take at moving PVR addons out of the xbmc-pvr-addons repository and into our binary addons buildsystem. A few notes\r\n* I've only really tested compiling as I don't have any PVR setup. I only tested the `pvr.demo` addon which lead to the first commit.\r\n* I've only tested this on WIN32\r\n* all PVR addons in my github account (see https://github.com/Montellese?tab=repositories) are based on the repositores created by and kept in sync by @notspiff so a big thank you to him.\r\n* all PVR addons depend on https://github.com/Montellese/kodi-platform which in turn depends on `tinyxml` which are added as common dependencies to all PVR addon repositories.\r\n\r\nTODOs\r\n- [ ] move `kodi-platform` into kodi's depends buildsystem\r\n- [ ] test building on all platforms\r\n- [ ] test every PVR addon\r\n- [ ] `pvr.filmon`\r\n- [ ] libjansson and cppmyth includes and libs are installed into the wrong directory\r\n- [x] `pvr.iptvsimple` depends on `zlib` which is downloaded from our mirrors and built using the supplied `CMakeLists.txt`. Unfortunately it builds shared and static libs and the builtin `FindZlib.cmake` provided with cmake picks up the shared lib instead of the static lib (at least on WIN32) and I haven't found a way around that yet.\r\n- [ ] sync all PVR addons to `xbmc-pvr-addons`\r\n- [ ] sync and rename `kodi-platform`\r\n- [ ] get the dependency handling right\r\n- [ ] move `kodi-platform` to xbmc's github account\r\n- [ ] move all PVR addons to xbmc's github account"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/72456860","html_url":"https://github.com/xbmc/xbmc/pull/6227#issuecomment-72456860","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227","id":72456860,"user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T13:22:50Z","updated_at":"2015-02-02T13:22:50Z","body":"Yeah the additional libraries in pvr.mythtv need to be refactored. They are in the \"lib\" directory and not in the \"depends\" directory. Therefore they don't get the dependency flags but the addon flags and they install their stuff into the same directory as the addons are installed (which is bad on darwin and win32)."}}