{"action":"created","issue":{"url":"https://api.github.com/repos/mobify/vellum/issues/74","labels_url":"https://api.github.com/repos/mobify/vellum/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/mobify/vellum/issues/74/comments","events_url":"https://api.github.com/repos/mobify/vellum/issues/74/events","html_url":"https://github.com/mobify/vellum/pull/74","id":63114457,"number":74,"title":"Forms checkbox radio update","user":{"login":"nastiatikk","id":4110509,"avatar_url":"https://avatars.githubusercontent.com/u/4110509?v=3","gravatar_id":"","url":"https://api.github.com/users/nastiatikk","html_url":"https://github.com/nastiatikk","followers_url":"https://api.github.com/users/nastiatikk/followers","following_url":"https://api.github.com/users/nastiatikk/following{/other_user}","gists_url":"https://api.github.com/users/nastiatikk/gists{/gist_id}","starred_url":"https://api.github.com/users/nastiatikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastiatikk/subscriptions","organizations_url":"https://api.github.com/users/nastiatikk/orgs","repos_url":"https://api.github.com/users/nastiatikk/repos","events_url":"https://api.github.com/users/nastiatikk/events{/privacy}","received_events_url":"https://api.github.com/users/nastiatikk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mobify/vellum/labels/Needs%20work","name":"Needs work","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-19T23:25:39Z","updated_at":"2015-03-25T23:28:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mobify/vellum/pulls/74","html_url":"https://github.com/mobify/vellum/pull/74","diff_url":"https://github.com/mobify/vellum/pull/74.diff","patch_url":"https://github.com/mobify/vellum/pull/74.patch"},"body":"Status: **Ready for Review**\r\nOwner: Anastasia\r\nReviewers: @ry5n @avelinet @mlworks @cole-sanderson @kpeatt @jeffkamo \r\n\r\n## Changes\r\n* `index.html` markup changed to match [_forms.dust](https://github.com/mobify/vellum/blob/forms--checkbox-radio-update/templates/_forms.dust) markup\r\n* Checkbox and radio styles in `forms.scss` changed to match `_forms.dust` markup\r\n* Long labels performance tweaked and they properly drop to the new line\r\n\r\n## Todos:\r\n- [ ] Designer +1\r\n- [ ] Designer +1\r\n"},"comment":{"url":"https://api.github.com/repos/mobify/vellum/issues/comments/86251480","html_url":"https://github.com/mobify/vellum/pull/74#issuecomment-86251480","issue_url":"https://api.github.com/repos/mobify/vellum/issues/74","id":86251480,"user":{"login":"nastiatikk","id":4110509,"avatar_url":"https://avatars.githubusercontent.com/u/4110509?v=3","gravatar_id":"","url":"https://api.github.com/users/nastiatikk","html_url":"https://github.com/nastiatikk","followers_url":"https://api.github.com/users/nastiatikk/followers","following_url":"https://api.github.com/users/nastiatikk/following{/other_user}","gists_url":"https://api.github.com/users/nastiatikk/gists{/gist_id}","starred_url":"https://api.github.com/users/nastiatikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastiatikk/subscriptions","organizations_url":"https://api.github.com/users/nastiatikk/orgs","repos_url":"https://api.github.com/users/nastiatikk/repos","events_url":"https://api.github.com/users/nastiatikk/events{/privacy}","received_events_url":"https://api.github.com/users/nastiatikk/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T23:28:59Z","updated_at":"2015-03-25T23:28:59Z","body":"So, we need to decide then what is our default markup.\r\n```\r\n№1\r\n<label>\r\n    <input type=\"radio\" class=\"radio\" name=\"radio_button\" value=\"radio_1\"> \r\n    Radio 1\r\n</label>\r\n```\r\nOR\r\n```\r\n№2\r\n<div>\r\n    <input id=\"radio-button\" type=\"radio\" />\r\n    <label for=\"radio-button\">A radio button and its label!</label>\r\n</div>\r\n```\r\n**№1** is not that we use in our projects. \r\n**№2** doesn't match our Vellum styles\r\n![screenshot 2015-03-25 16 26 11](https://cloud.githubusercontent.com/assets/4110509/6837594/515c78ce-d30b-11e4-8ab2-9d65842191cb.png)\r\n"}}