{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/37296164","id":37296164,"diff_hunk":"@@ -30,20 +30,25 @@ use data::Data;\n #[derive(PartialEq, Eq, PartialOrd, Ord, Clone, Debug, RustcEncodable, RustcDecodable)]\n /// represents response errors\n pub enum ResponseError {\n-    /// data not found\n-    NoData,\n+    /// Abort is for user to indicate that the state can be dropped;\n+    /// if received by routing, it will drop the state.\n+    Abort,\n     /// invalid request\n-    InvalidRequest,\n-    /// failure to store data\n-    FailedToStoreData(Data)\n+    InvalidRequest(Data),\n+    /// failure to complete request for data\n+    FailedRequestForData(Data),\n+    /// had to clear Sacrificial Data in order to complete request\n+    HadToClearSacrificial(usize),\n }\n \n impl error::Error for ResponseError {\n     fn description(&self) -> &str {\n         match *self {\n-            ResponseError::NoData => \"No Data\",\n-            ResponseError::InvalidRequest => \"Invalid request\",\n-            ResponseError::FailedToStoreData(_) => \"Failed to store data\",\n+            ResponseError::Abort => \"Abort\",\n+            ResponseError::InvalidRequest(_) => \"Invalid request\",\n+            ResponseError::FailedRequestForData(_) => \"Failed request for data\",\n+            ResponseError::HadToClearSacrificial(size) => \"Had to clear {:?} bytes of Sacrificial","path":"src/error.rs","position":29,"original_position":29,"commit_id":"df636a530329814acd53dd41427df1c3cd6bc700","original_commit_id":"df636a530329814acd53dd41427df1c3cd6bc700","user":{"login":"dirvine","id":123627,"avatar_url":"https://avatars.githubusercontent.com/u/123627?v=3","gravatar_id":"","url":"https://api.github.com/users/dirvine","html_url":"https://github.com/dirvine","followers_url":"https://api.github.com/users/dirvine/followers","following_url":"https://api.github.com/users/dirvine/following{/other_user}","gists_url":"https://api.github.com/users/dirvine/gists{/gist_id}","starred_url":"https://api.github.com/users/dirvine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirvine/subscriptions","organizations_url":"https://api.github.com/users/dirvine/orgs","repos_url":"https://api.github.com/users/dirvine/repos","events_url":"https://api.github.com/users/dirvine/events{/privacy}","received_events_url":"https://api.github.com/users/dirvine/received_events","type":"User","site_admin":false},"body":"I am not sure this should be even known to routing. ","created_at":"2015-08-18T13:19:06Z","updated_at":"2015-08-18T13:19:06Z","html_url":"https://github.com/maidsafe/routing/pull/613#discussion_r37296164","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/613","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/37296164"},"html":{"href":"https://github.com/maidsafe/routing/pull/613#discussion_r37296164"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/613"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/613","id":42696026,"html_url":"https://github.com/maidsafe/routing/pull/613","diff_url":"https://github.com/maidsafe/routing/pull/613.diff","patch_url":"https://github.com/maidsafe/routing/pull/613.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/613","number":613,"state":"open","locked":false,"title":"Finalise api 0.3","user":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/routing/613)\n<!-- Reviewable:end -->\n","created_at":"2015-08-18T13:08:08Z","updated_at":"2015-08-18T13:19:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4761a27da1aa7912ec91fedadb3e615dbebf187","assignee":{"login":"inetic","id":40127,"avatar_url":"https://avatars.githubusercontent.com/u/40127?v=3","gravatar_id":"","url":"https://api.github.com/users/inetic","html_url":"https://github.com/inetic","followers_url":"https://api.github.com/users/inetic/followers","following_url":"https://api.github.com/users/inetic/following{/other_user}","gists_url":"https://api.github.com/users/inetic/gists{/gist_id}","starred_url":"https://api.github.com/users/inetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inetic/subscriptions","organizations_url":"https://api.github.com/users/inetic/orgs","repos_url":"https://api.github.com/users/inetic/repos","events_url":"https://api.github.com/users/inetic/events{/privacy}","received_events_url":"https://api.github.com/users/inetic/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/613/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/613/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/613/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/df636a530329814acd53dd41427df1c3cd6bc700","head":{"label":"benjaminbollen:finalise_api_0.3","ref":"finalise_api_0.3","sha":"df636a530329814acd53dd41427df1c3cd6bc700","user":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"repo":{"id":31930999,"name":"routing","full_name":"benjaminbollen/routing","owner":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminbollen/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/benjaminbollen/routing","forks_url":"https://api.github.com/repos/benjaminbollen/routing/forks","keys_url":"https://api.github.com/repos/benjaminbollen/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminbollen/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminbollen/routing/teams","hooks_url":"https://api.github.com/repos/benjaminbollen/routing/hooks","issue_events_url":"https://api.github.com/repos/benjaminbollen/routing/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminbollen/routing/events","assignees_url":"https://api.github.com/repos/benjaminbollen/routing/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminbollen/routing/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminbollen/routing/tags","blobs_url":"https://api.github.com/repos/benjaminbollen/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminbollen/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminbollen/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminbollen/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminbollen/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminbollen/routing/languages","stargazers_url":"https://api.github.com/repos/benjaminbollen/routing/stargazers","contributors_url":"https://api.github.com/repos/benjaminbollen/routing/contributors","subscribers_url":"https://api.github.com/repos/benjaminbollen/routing/subscribers","subscription_url":"https://api.github.com/repos/benjaminbollen/routing/subscription","commits_url":"https://api.github.com/repos/benjaminbollen/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminbollen/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminbollen/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminbollen/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminbollen/routing/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminbollen/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminbollen/routing/merges","archive_url":"https://api.github.com/repos/benjaminbollen/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminbollen/routing/downloads","issues_url":"https://api.github.com/repos/benjaminbollen/routing/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminbollen/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminbollen/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminbollen/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminbollen/routing/labels{/name}","releases_url":"https://api.github.com/repos/benjaminbollen/routing/releases{/id}","created_at":"2015-03-10T01:00:26Z","updated_at":"2015-05-03T23:18:20Z","pushed_at":"2015-08-18T13:07:45Z","git_url":"git://github.com/benjaminbollen/routing.git","ssh_url":"git@github.com:benjaminbollen/routing.git","clone_url":"https://github.com/benjaminbollen/routing.git","svn_url":"https://github.com/benjaminbollen/routing","homepage":null,"size":4941,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"6a4ca193b9d88cdba22ad930b6d187d7bd7c4e3c","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","created_at":"2015-02-24T16:52:53Z","updated_at":"2015-08-08T13:39:34Z","pushed_at":"2015-08-18T13:08:12Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":20586,"stargazers_count":45,"watchers_count":45,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":18,"forks":26,"open_issues":18,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/613"},"html":{"href":"https://github.com/maidsafe/routing/pull/613"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/613"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/df636a530329814acd53dd41427df1c3cd6bc700"}}}}