{"action":"created","issue":{"url":"https://api.github.com/repos/atom/wrap-guide/issues/31","labels_url":"https://api.github.com/repos/atom/wrap-guide/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/atom/wrap-guide/issues/31/comments","events_url":"https://api.github.com/repos/atom/wrap-guide/issues/31/events","html_url":"https://github.com/atom/wrap-guide/pull/31","id":79775286,"number":31,"title":"Relativize wrap guide position","user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-23T08:12:54Z","updated_at":"2015-05-27T07:10:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/wrap-guide/pulls/31","html_url":"https://github.com/atom/wrap-guide/pull/31","diff_url":"https://github.com/atom/wrap-guide/pull/31.diff","patch_url":"https://github.com/atom/wrap-guide/pull/31.patch"},"body":"This change is needed in order to support the new tiled editor. You can find further information about this on https://github.com/atom/atom/pull/6733, but basically we don’t use absolute coordinates to position lines on screen anymore.\r\n\r\nIndeed, this is the situation if we use wrap-guide with the tiled editor, and we scroll left/right (please, notice how the guide sticks to a fixed position without being affected by scrolling):\r\n\r\n![before](https://cloud.githubusercontent.com/assets/482957/7783041/5427f56e-0133-11e5-85eb-b9f872141251.gif)\r\n\r\nAnd this is a screenshot after the proposed fix:\r\n\r\n![after](https://cloud.githubusercontent.com/assets/482957/7783040/5424b8ae-0133-11e5-976f-a049a7593fae.gif)\r\n\r\nThis should be released as soon as https://github.com/atom/atom/pull/6733 is released. As @benogle once said: \r\n\r\n> You know the wrap-guide has to work. Muy importante.\r\n\r\n:smile_cat: \r\n\r\n/cc: @nathansobo @atom/feedback"},"comment":{"url":"https://api.github.com/repos/atom/wrap-guide/issues/comments/105788573","html_url":"https://github.com/atom/wrap-guide/pull/31#issuecomment-105788573","issue_url":"https://api.github.com/repos/atom/wrap-guide/issues/31","id":105788573,"user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":false},"created_at":"2015-05-27T07:10:15Z","updated_at":"2015-05-27T07:10:15Z","body":"> Is there any way you could make this backward compatible with non tiled versions of Atom and ship it now? That could include detecting on a flag or something. It just makes these kinds of upgrades smoother when we're compatible with both versions.\r\n\r\nSounds like a great idea! :bulb: I couldn't find any other example of feature flags so I went with putting a boolean under the `atom` global, which is going to disappear as soon as we have correctly migrated this and other possibly affected packages (even though this should be the only one).\r\n\r\nPlease, have a look at e6066cf and the related commit on atom/atom (https://github.com/atom/atom/commit/7926ca5f231c9cd361a1c6f2781b39a273df09ce).\r\n\r\n:tada: "}}