{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/4333","labels_url":"https://api.github.com/repos/CartoDB/cartodb/issues/4333/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/4333/comments","events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/4333/events","html_url":"https://github.com/CartoDB/cartodb/pull/4333","id":93551382,"number":4333,"title":"revamp public map [DO NOT MERGE]","user":{"login":"matallo","id":36676,"avatar_url":"https://avatars.githubusercontent.com/u/36676?v=3","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-07T15:00:55Z","updated_at":"2015-07-15T14:45:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/4333","html_url":"https://github.com/CartoDB/cartodb/pull/4333","diff_url":"https://github.com/CartoDB/cartodb/pull/4333.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/4333.patch"},"body":"first commit, familiarizing myself with the code and so, just made the changes in the header for now\r\n\r\n- created a `dashboard_header`, do we want to change them only in the public pages or in the dashboard , too? Inevitably the styles will change\r\n\r\n<img width=\"970\" alt=\"screen shot 2015-07-07 at 16 48 29\" src=\"https://cloud.githubusercontent.com/assets/36676/8548975/697c47f4-24c8-11e5-9d26-21a86095b027.png\">\r\n\r\nthen, already in the `public_header` \r\n\r\n- left the links with a bit of opacity to keep the hover states, didn't found them in the mockups, **is it white with underline, do I leave them like this**?\r\n\r\n- do we lose \"Learn\" in favour of \"Industries\" + \"Pricing\" ?\r\n- I suppose the link \"Login\" was left with no update, applied the same style **please confirm you want it different**\r\n\r\n<img width=\"1197\" alt=\"screen shot 2015-07-07 at 16 46 47\" src=\"https://cloud.githubusercontent.com/assets/36676/8549003/95f0ea7e-24c8-11e5-97d8-422fcaca608c.png\">\r\n\r\n- had to modify `.UserAvatar-img` in order to the signup button to be aligned. Avatar is 42px with that transparent border (what is it for?), button is 44px :/\r\n\r\n- despite we already have a size variable for `40px` I created a new one for the items separation, modifying `$sMargin-element` wasn't feasible, so many side changes.\r\n\r\n- finally, I created `.Header-navigationItem` as we have `.Header-settingsItem`, actually, don't you think we should consolidate them both in a single class? the same with `.Header-navigationLink`\r\n\r\nwill go on with this, but as I first dove here I prefer to check these before going any further ^^^\r\n\r\n/cc @CartoDB/frontend "},"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments/121638451","html_url":"https://github.com/CartoDB/cartodb/pull/4333#issuecomment-121638451","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/4333","id":121638451,"user":{"login":"Cartofante","id":5066482,"avatar_url":"https://avatars.githubusercontent.com/u/5066482?v=3","gravatar_id":"","url":"https://api.github.com/users/Cartofante","html_url":"https://github.com/Cartofante","followers_url":"https://api.github.com/users/Cartofante/followers","following_url":"https://api.github.com/users/Cartofante/following{/other_user}","gists_url":"https://api.github.com/users/Cartofante/gists{/gist_id}","starred_url":"https://api.github.com/users/Cartofante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cartofante/subscriptions","organizations_url":"https://api.github.com/users/Cartofante/orgs","repos_url":"https://api.github.com/users/Cartofante/repos","events_url":"https://api.github.com/users/Cartofante/events{/privacy}","received_events_url":"https://api.github.com/users/Cartofante/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T14:45:21Z","updated_at":"2015-07-15T14:45:21Z","body":"Frontend tests were OK :+1: ([details](http://clinker.cartodb.net/jenkins/job/CartoDB-PR-testing/5001/))"}}