{"action":"created","issue":{"url":"https://api.github.com/repos/rwaldron/johnny-five/issues/419","labels_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/419/comments","events_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/419/events","html_url":"https://github.com/rwaldron/johnny-five/issues/419","id":39041734,"number":419,"title":"Intermittent test failures (still)","user":{"login":"dtex","id":854911,"avatar_url":"https://avatars.githubusercontent.com/u/854911?v=3","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rwaldron/johnny-five/labels/help%20wanted","name":"help wanted","color":"d4c5f9"},{"url":"https://api.github.com/repos/rwaldron/johnny-five/labels/Tests","name":"Tests","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"divanvisagie","id":2023086,"avatar_url":"https://avatars.githubusercontent.com/u/2023086?v=3","gravatar_id":"","url":"https://api.github.com/users/divanvisagie","html_url":"https://github.com/divanvisagie","followers_url":"https://api.github.com/users/divanvisagie/followers","following_url":"https://api.github.com/users/divanvisagie/following{/other_user}","gists_url":"https://api.github.com/users/divanvisagie/gists{/gist_id}","starred_url":"https://api.github.com/users/divanvisagie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divanvisagie/subscriptions","organizations_url":"https://api.github.com/users/divanvisagie/orgs","repos_url":"https://api.github.com/users/divanvisagie/repos","events_url":"https://api.github.com/users/divanvisagie/events{/privacy}","received_events_url":"https://api.github.com/users/divanvisagie/received_events","type":"User","site_admin":false},"milestone":null,"comments":19,"created_at":"2014-07-29T22:15:55Z","updated_at":"2015-03-30T15:48:13Z","closed_at":null,"body":"On tests with real timers we are seeing intermittent failures at Travis CI. It also fails locally on occasion. Tasks are simply not happening in the expected time. For example, we have ~24ms of wiggle room on piezo.playtune but it occasionally does not complete in time (the expected time to complete is 36ms and we currently wait 60ms).\r\n\r\nIdeas:\r\n\r\n 1. Increase the timeout. I tried this and it reduced the frequency of build failures, but it ultimately feels like a sledgehammer solution to just keep cranking up the timeout.\r\n 1. Fire an event when a tune is finished playing and check values after that instead of relying on a timeout.\r\n 1. I haven't looked at the piezo code, but maybe we need to test the technique used for timing in piezo against Travis and profile Travis CI's performance so we know what to expect.\r\n\r\nLastly, @lyzadanger made an effort to minimize the added delay on tests. Do we care if the tests take an extra 100 or even 1000ms? If so, the animation tests are going to be a big problem as they're at about 12 seconds right now."},"comment":{"url":"https://api.github.com/repos/rwaldron/johnny-five/issues/comments/87730175","html_url":"https://github.com/rwaldron/johnny-five/issues/419#issuecomment-87730175","issue_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/419","id":87730175,"user":{"login":"lyzadanger","id":439947,"avatar_url":"https://avatars.githubusercontent.com/u/439947?v=3","gravatar_id":"","url":"https://api.github.com/users/lyzadanger","html_url":"https://github.com/lyzadanger","followers_url":"https://api.github.com/users/lyzadanger/followers","following_url":"https://api.github.com/users/lyzadanger/following{/other_user}","gists_url":"https://api.github.com/users/lyzadanger/gists{/gist_id}","starred_url":"https://api.github.com/users/lyzadanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyzadanger/subscriptions","organizations_url":"https://api.github.com/users/lyzadanger/orgs","repos_url":"https://api.github.com/users/lyzadanger/repos","events_url":"https://api.github.com/users/lyzadanger/events{/privacy}","received_events_url":"https://api.github.com/users/lyzadanger/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T15:48:13Z","updated_at":"2015-03-30T15:48:13Z","body":"I'll do a write-up and submit a PR tonight or tomorrow night, availability-dependent!"}}