{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/50","id":48154680,"html_url":"https://github.com/jsperf/jsperf.com/pull/50","diff_url":"https://github.com/jsperf/jsperf.com/pull/50.diff","patch_url":"https://github.com/jsperf/jsperf.com/pull/50.patch","issue_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/50","number":50,"state":"closed","locked":false,"title":"convert to using promises","user":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"body":"the core db lib sparks a chain of callbacks throughout the code. with promises, there's a lot less arguments and error handling. it also makes the most complicated piece (getting a page by its slug) a lot more readable","created_at":"2015-10-20T04:02:35Z","updated_at":"2015-12-22T05:27:35Z","closed_at":"2015-12-22T05:27:35Z","merged_at":"2015-12-22T05:27:35Z","merge_commit_sha":"88834a053038af855b46a448fe7d307561aa6449","assignee":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/50/commits","review_comments_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/50/comments","review_comment_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/50/comments","statuses_url":"https://api.github.com/repos/jsperf/jsperf.com/statuses/721c62b219ffc91168c943d540d4e72b120e0431","head":{"label":"jsperf:promises","ref":"promises","sha":"721c62b219ffc91168c943d540d4e72b120e0431","user":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"repo":{"id":30963708,"name":"jsperf.com","full_name":"jsperf/jsperf.com","owner":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsperf/jsperf.com","description":"jsperf.com v2. https://github.com/h5bp/lazyweb-requests/issues/174","fork":false,"url":"https://api.github.com/repos/jsperf/jsperf.com","forks_url":"https://api.github.com/repos/jsperf/jsperf.com/forks","keys_url":"https://api.github.com/repos/jsperf/jsperf.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsperf/jsperf.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsperf/jsperf.com/teams","hooks_url":"https://api.github.com/repos/jsperf/jsperf.com/hooks","issue_events_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/events{/number}","events_url":"https://api.github.com/repos/jsperf/jsperf.com/events","assignees_url":"https://api.github.com/repos/jsperf/jsperf.com/assignees{/user}","branches_url":"https://api.github.com/repos/jsperf/jsperf.com/branches{/branch}","tags_url":"https://api.github.com/repos/jsperf/jsperf.com/tags","blobs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsperf/jsperf.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsperf/jsperf.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsperf/jsperf.com/statuses/{sha}","languages_url":"https://api.github.com/repos/jsperf/jsperf.com/languages","stargazers_url":"https://api.github.com/repos/jsperf/jsperf.com/stargazers","contributors_url":"https://api.github.com/repos/jsperf/jsperf.com/contributors","subscribers_url":"https://api.github.com/repos/jsperf/jsperf.com/subscribers","subscription_url":"https://api.github.com/repos/jsperf/jsperf.com/subscription","commits_url":"https://api.github.com/repos/jsperf/jsperf.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsperf/jsperf.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsperf/jsperf.com/contents/{+path}","compare_url":"https://api.github.com/repos/jsperf/jsperf.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsperf/jsperf.com/merges","archive_url":"https://api.github.com/repos/jsperf/jsperf.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsperf/jsperf.com/downloads","issues_url":"https://api.github.com/repos/jsperf/jsperf.com/issues{/number}","pulls_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls{/number}","milestones_url":"https://api.github.com/repos/jsperf/jsperf.com/milestones{/number}","notifications_url":"https://api.github.com/repos/jsperf/jsperf.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsperf/jsperf.com/labels{/name}","releases_url":"https://api.github.com/repos/jsperf/jsperf.com/releases{/id}","created_at":"2015-02-18T11:56:31Z","updated_at":"2015-12-20T12:22:19Z","pushed_at":"2015-12-22T05:27:35Z","git_url":"git://github.com/jsperf/jsperf.com.git","ssh_url":"git@github.com:jsperf/jsperf.com.git","clone_url":"https://github.com/jsperf/jsperf.com.git","svn_url":"https://github.com/jsperf/jsperf.com","homepage":"","size":799,"stargazers_count":228,"watchers_count":228,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":21,"forks":32,"open_issues":21,"watchers":228,"default_branch":"master"}},"base":{"label":"jsperf:master","ref":"master","sha":"96eb4fcb6d5d6adc7565f791e7e6729f4905f287","user":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"repo":{"id":30963708,"name":"jsperf.com","full_name":"jsperf/jsperf.com","owner":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsperf/jsperf.com","description":"jsperf.com v2. https://github.com/h5bp/lazyweb-requests/issues/174","fork":false,"url":"https://api.github.com/repos/jsperf/jsperf.com","forks_url":"https://api.github.com/repos/jsperf/jsperf.com/forks","keys_url":"https://api.github.com/repos/jsperf/jsperf.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsperf/jsperf.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsperf/jsperf.com/teams","hooks_url":"https://api.github.com/repos/jsperf/jsperf.com/hooks","issue_events_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/events{/number}","events_url":"https://api.github.com/repos/jsperf/jsperf.com/events","assignees_url":"https://api.github.com/repos/jsperf/jsperf.com/assignees{/user}","branches_url":"https://api.github.com/repos/jsperf/jsperf.com/branches{/branch}","tags_url":"https://api.github.com/repos/jsperf/jsperf.com/tags","blobs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsperf/jsperf.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsperf/jsperf.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsperf/jsperf.com/statuses/{sha}","languages_url":"https://api.github.com/repos/jsperf/jsperf.com/languages","stargazers_url":"https://api.github.com/repos/jsperf/jsperf.com/stargazers","contributors_url":"https://api.github.com/repos/jsperf/jsperf.com/contributors","subscribers_url":"https://api.github.com/repos/jsperf/jsperf.com/subscribers","subscription_url":"https://api.github.com/repos/jsperf/jsperf.com/subscription","commits_url":"https://api.github.com/repos/jsperf/jsperf.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsperf/jsperf.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsperf/jsperf.com/contents/{+path}","compare_url":"https://api.github.com/repos/jsperf/jsperf.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsperf/jsperf.com/merges","archive_url":"https://api.github.com/repos/jsperf/jsperf.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsperf/jsperf.com/downloads","issues_url":"https://api.github.com/repos/jsperf/jsperf.com/issues{/number}","pulls_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls{/number}","milestones_url":"https://api.github.com/repos/jsperf/jsperf.com/milestones{/number}","notifications_url":"https://api.github.com/repos/jsperf/jsperf.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsperf/jsperf.com/labels{/name}","releases_url":"https://api.github.com/repos/jsperf/jsperf.com/releases{/id}","created_at":"2015-02-18T11:56:31Z","updated_at":"2015-12-20T12:22:19Z","pushed_at":"2015-12-22T05:27:35Z","git_url":"git://github.com/jsperf/jsperf.com.git","ssh_url":"git@github.com:jsperf/jsperf.com.git","clone_url":"https://github.com/jsperf/jsperf.com.git","svn_url":"https://github.com/jsperf/jsperf.com","homepage":"","size":799,"stargazers_count":228,"watchers_count":228,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":21,"forks":32,"open_issues":21,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/50"},"html":{"href":"https://github.com/jsperf/jsperf.com/pull/50"},"issue":{"href":"https://api.github.com/repos/jsperf/jsperf.com/issues/50"},"comments":{"href":"https://api.github.com/repos/jsperf/jsperf.com/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/jsperf/jsperf.com/statuses/721c62b219ffc91168c943d540d4e72b120e0431"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":709,"deletions":733,"changed_files":26}}