{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/33916501","id":33916501,"diff_hunk":"@@ -1,1324 +1,58 @@\n <%@ page language=\"java\" contentType=\"text/html; charset=UTF-8\" pageEncoding=\"UTF-8\" %>\n \n-<%@page import=\"teammates.ui.controller.InstructorFeedbacksPageData\" %>\n-<%@ page import=\"java.util.Date\" %>\n-<%@ page import=\"java.util.List\" %>\n-<%@ page import=\"teammates.common.util.Const\" %>\n-<%@ page import=\"teammates.common.util.TimeHelper\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackParticipantType\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackQuestionType\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackQuestionAttributes\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackQuestionDetails\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackMcqQuestionDetails\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackMsqQuestionDetails\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackNumericalScaleQuestionDetails\" %>\n-<%@ page import=\"teammates.common.datatransfer.FeedbackConstantSumQuestionDetails\" %>\n-<%@ page import=\"teammates.common.datatransfer.StudentAttributes\" %>\n-<%@ page import=\"teammates.common.datatransfer.InstructorAttributes\" %>\n-<%@ page import=\"teammates.logic.core.Emails.EmailType\" %>\n-<%@ page import=\"teammates.ui.controller.InstructorFeedbackEditPageData\" %>\n-<%\n-    InstructorFeedbackEditPageData data = (InstructorFeedbackEditPageData)request.getAttribute(\"data\");\n- %>\n-<!DOCTYPE html>\n-<html>\n-<head>\n-    <title>TEAMMATES - Instructor</title>\n-\n-    <link rel=\"shortcut icon\" href=\"/favicon.png\" />\n-\n-    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\">\n-    <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n-\n-    <link type=\"text/css\" href=\"/bootstrap/css/bootstrap.min.css\" rel=\"stylesheet\"/>\n-    <link type=\"text/css\" href=\"/bootstrap/css/bootstrap-theme.min.css\" rel=\"stylesheet\"/>\n-    <link type=\"text/css\" href=\"/stylesheets/teammatesCommon.css\" rel=\"stylesheet\"/>\n-\n-    <!--[if lt IE 9]>\n-        <script src=\"https://oss.maxcdn.com/libs/html5shiv/3.7.0/html5shiv.js\"></script>\n-        <script src=\"https://oss.maxcdn.com/libs/respond.js/1.4.2/respond.min.js\"></script>\n-    <![endif]-->\n-\n-    <script type=\"text/javascript\" src=\"/js/googleAnalytics.js\"></script>\n-    <script type=\"text/javascript\" src=\"https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js\"></script>\n-    <script type=\"text/javascript\" src=\"//ajax.googleapis.com/ajax/libs/jqueryui/1.10.4/jquery-ui.min.js\"></script>\n-    <script type=\"text/javascript\" src=\"/js/common.js\"></script>\n-    <script type=\"text/javascript\" src=\"/bootstrap/js/bootstrap.min.js\"></script>\n+<%@ taglib uri=\"http://java.sun.com/jsp/jstl/core\" prefix=\"c\" %>\n \n-    <jsp:include page=\"../enableJS.jsp\"></jsp:include>\n-    \n-    <link rel=\"stylesheet\" href=\"/stylesheets/datepicker.css\" type=\"text/css\">\n-\n-    <script type=\"text/javascript\" src=\"/js/datepicker.js\"></script>\n-    <script type=\"text/javascript\" src=\"/js/instructor.js\"></script>\n-    <script type=\"text/javascript\" src=\"/js/instructorFeedbacks.js\"></script>\n-    <script type=\"text/javascript\" src=\"/js/instructorFeedbackEdit.js\"></script>\n-</head>\n+<%@ page import=\"teammates.common.util.Const\" %>\n \n-<body onload=\"readyFeedbackEditPage();\n+<%@ taglib tagdir=\"/WEB-INF/tags\" prefix=\"t\" %>\n+<%@ taglib tagdir=\"/WEB-INF/tags/instructor\" prefix=\"ti\" %>\n+<%@ taglib tagdir=\"/WEB-INF/tags/instructor/feedbackEdit\" prefix=\"feedbackEdit\" %>\n+<%@ taglib tagdir=\"/WEB-INF/tags/instructor/feedbacks\" prefix=\"feedbacks\" %>\n+\n+<c:set var=\"jsIncludes\">\n+        <link rel=\"stylesheet\" href=\"/stylesheets/datepicker.css\" type=\"text/css\" media=\"screen\">\n+        \n+        <script type=\"text/javascript\" src=\"/js/datepicker.js\"></script>\n+        <script type=\"text/javascript\" src=\"/js/instructor.js\"></script>\n+        <script type=\"text/javascript\" src=\"/js/instructorFeedbacks.js\"></script>\n+        <script type=\"text/javascript\" src=\"/js/instructorFeedbackEdit.js\"></script>","path":"src/main/webapp/jsp/instructorFeedbackEdit.jsp","position":72,"original_position":72,"commit_id":"bd0967cf7ad9474d5b931aab648f57eb37f51f88","original_commit_id":"bd0967cf7ad9474d5b931aab648f57eb37f51f88","user":{"login":"yj-soh","id":8586080,"avatar_url":"https://avatars.githubusercontent.com/u/8586080?v=3","gravatar_id":"","url":"https://api.github.com/users/yj-soh","html_url":"https://github.com/yj-soh","followers_url":"https://api.github.com/users/yj-soh/followers","following_url":"https://api.github.com/users/yj-soh/following{/other_user}","gists_url":"https://api.github.com/users/yj-soh/gists{/gist_id}","starred_url":"https://api.github.com/users/yj-soh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yj-soh/subscriptions","organizations_url":"https://api.github.com/users/yj-soh/orgs","repos_url":"https://api.github.com/users/yj-soh/repos","events_url":"https://api.github.com/users/yj-soh/events{/privacy}","received_events_url":"https://api.github.com/users/yj-soh/received_events","type":"User","site_admin":false},"body":"Indentation is off here and at the `<c:if>` in the body.\r\nAlso, it may be best arranging the `<c:set>` for the constant into a single line.","created_at":"2015-07-06T09:05:45Z","updated_at":"2015-07-06T09:05:45Z","html_url":"https://github.com/TEAMMATES/repo/pull/3736#discussion_r33916501","pull_request_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/33916501"},"html":{"href":"https://github.com/TEAMMATES/repo/pull/3736#discussion_r33916501"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736","id":37764060,"html_url":"https://github.com/TEAMMATES/repo/pull/3736","diff_url":"https://github.com/TEAMMATES/repo/pull/3736.diff","patch_url":"https://github.com/TEAMMATES/repo/pull/3736.patch","issue_url":"https://api.github.com/repos/TEAMMATES/repo/issues/3736","number":3736,"state":"open","locked":false,"title":"JSTL - InstructorFeedbackEdit","user":{"login":"kanghj","id":2216119,"avatar_url":"https://avatars.githubusercontent.com/u/2216119?v=3","gravatar_id":"","url":"https://api.github.com/users/kanghj","html_url":"https://github.com/kanghj","followers_url":"https://api.github.com/users/kanghj/followers","following_url":"https://api.github.com/users/kanghj/following{/other_user}","gists_url":"https://api.github.com/users/kanghj/gists{/gist_id}","starred_url":"https://api.github.com/users/kanghj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanghj/subscriptions","organizations_url":"https://api.github.com/users/kanghj/orgs","repos_url":"https://api.github.com/users/kanghj/repos","events_url":"https://api.github.com/users/kanghj/events{/privacy}","received_events_url":"https://api.github.com/users/kanghj/received_events","type":"User","site_admin":false},"body":"Will make the modifications to the test html in another pr, when the consistency issues have been fixed.\r\n\r\n@yj-soh","created_at":"2015-06-16T06:45:34Z","updated_at":"2015-07-06T09:05:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"513898fa28b6525e83b0d44a95d23844d707e27d","assignee":{"login":"yj-soh","id":8586080,"avatar_url":"https://avatars.githubusercontent.com/u/8586080?v=3","gravatar_id":"","url":"https://api.github.com/users/yj-soh","html_url":"https://github.com/yj-soh","followers_url":"https://api.github.com/users/yj-soh/followers","following_url":"https://api.github.com/users/yj-soh/following{/other_user}","gists_url":"https://api.github.com/users/yj-soh/gists{/gist_id}","starred_url":"https://api.github.com/users/yj-soh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yj-soh/subscriptions","organizations_url":"https://api.github.com/users/yj-soh/orgs","repos_url":"https://api.github.com/users/yj-soh/repos","events_url":"https://api.github.com/users/yj-soh/events{/privacy}","received_events_url":"https://api.github.com/users/yj-soh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/issues/3736/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/bd0967cf7ad9474d5b931aab648f57eb37f51f88","head":{"label":"TEAMMATES:JSTL-FeedbackEdit","ref":"JSTL-FeedbackEdit","sha":"bd0967cf7ad9474d5b931aab648f57eb37f51f88","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"repo","full_name":"TEAMMATES/repo","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/repo","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/repo","forks_url":"https://api.github.com/repos/TEAMMATES/repo/forks","keys_url":"https://api.github.com/repos/TEAMMATES/repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/repo/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/repo/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/repo/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/repo/events","assignees_url":"https://api.github.com/repos/TEAMMATES/repo/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/repo/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/repo/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/repo/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/repo/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/repo/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/repo/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/repo/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/repo/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/repo/merges","archive_url":"https://api.github.com/repos/TEAMMATES/repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/repo/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/repo/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/repo/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/repo/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/repo/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/repo/releases{/id}","created_at":"2014-05-02T07:43:00Z","updated_at":"2015-06-14T23:15:10Z","pushed_at":"2015-07-06T08:55:36Z","git_url":"git://github.com/TEAMMATES/repo.git","ssh_url":"git@github.com:TEAMMATES/repo.git","clone_url":"https://github.com/TEAMMATES/repo.git","svn_url":"https://github.com/TEAMMATES/repo","homepage":"http://teammatesv4.appspot.com/","size":152275,"stargazers_count":44,"watchers_count":44,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":439,"forks":124,"open_issues":439,"watchers":44,"default_branch":"master"}},"base":{"label":"TEAMMATES:JSTL-Dev","ref":"JSTL-Dev","sha":"0ef71025ee90f2b14c7e55526bc09c3c4b644df1","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"repo","full_name":"TEAMMATES/repo","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/repo","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/repo","forks_url":"https://api.github.com/repos/TEAMMATES/repo/forks","keys_url":"https://api.github.com/repos/TEAMMATES/repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/repo/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/repo/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/repo/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/repo/events","assignees_url":"https://api.github.com/repos/TEAMMATES/repo/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/repo/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/repo/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/repo/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/repo/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/repo/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/repo/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/repo/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/repo/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/repo/merges","archive_url":"https://api.github.com/repos/TEAMMATES/repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/repo/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/repo/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/repo/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/repo/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/repo/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/repo/releases{/id}","created_at":"2014-05-02T07:43:00Z","updated_at":"2015-06-14T23:15:10Z","pushed_at":"2015-07-06T08:55:36Z","git_url":"git://github.com/TEAMMATES/repo.git","ssh_url":"git@github.com:TEAMMATES/repo.git","clone_url":"https://github.com/TEAMMATES/repo.git","svn_url":"https://github.com/TEAMMATES/repo","homepage":"http://teammatesv4.appspot.com/","size":152275,"stargazers_count":44,"watchers_count":44,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":439,"forks":124,"open_issues":439,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736"},"html":{"href":"https://github.com/TEAMMATES/repo/pull/3736"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/repo/issues/3736"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/repo/issues/3736/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/3736/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/repo/statuses/bd0967cf7ad9474d5b931aab648f57eb37f51f88"}}}}