{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/43061795","id":43061795,"diff_hunk":"@@ -6070,7 +6070,7 @@ namespace WindowManager {\n \t\t\tTInRadFr = TInRad * root_4( ( 1.0 + 0.5 * ProjCorrFrIn ) / ( 1.0 + ProjCorrFrIn ) );\n \t\t\tFrameCon = SurfaceWindow( SurfNum ).FrameConductance;\n \t\t\tHInRad = 0.5 * SurfaceWindow( SurfNum ).FrameEmis * sigma * pow_3( TInRadFr + SurfaceWindow( SurfNum ).FrameTempSurfIn + TKelvin );\n-\t\t\tHInConvFr = 0.0;\n+\t\t\tHInConvFr = HInConv;","path":"src/EnergyPlus/WindowManager.cc","position":5,"original_position":5,"commit_id":"dd8dc05c1e7401e884567b7e9978be275459f504","original_commit_id":"dd8dc05c1e7401e884567b7e9978be275459f504","user":{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false},"body":"@EnergyArchmage Doesn't EnergyPlus remove the frame area from the base surface area even if there is no frame projection? It seems like a bad assumption that no projection implies no frame. Maybe I'm not understanding you correctly.","created_at":"2015-10-26T22:21:20Z","updated_at":"2015-10-26T22:21:20Z","html_url":"https://github.com/NREL/EnergyPlus/pull/5099#discussion_r43061795","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/43061795"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5099#discussion_r43061795"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099","id":42391595,"html_url":"https://github.com/NREL/EnergyPlus/pull/5099","diff_url":"https://github.com/NREL/EnergyPlus/pull/5099.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5099.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5099","number":5099,"state":"open","locked":false,"title":"Fix calculation of window frame heat gain","user":{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false},"body":"Fixes #5095.","created_at":"2015-08-13T19:53:28Z","updated_at":"2015-10-26T22:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c778b74895b18cf651bea01d08df3395177f9db","assignee":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/3","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.4.0+BugFix","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/3/labels","id":1318507,"number":3,"title":"EnergyPlus 8.4.0+BugFix","description":"This is a tentative milestone in case we want to release a follow-up bug-fix version of 8.4 sometime after the public release on September 30.  If we choose to not release a bug-fix version, then issues/PRs assigned to this milestone should be re-assigned to 8.5.0.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars.githubusercontent.com/u/849824?v=3","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":85,"closed_issues":5,"state":"open","created_at":"2015-09-22T14:43:30Z","updated_at":"2015-10-26T13:51:16Z","due_on":"2015-10-31T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5099/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/dd8dc05c1e7401e884567b7e9978be275459f504","head":{"label":"NREL:fix-window-frame-calcs-5095","ref":"fix-window-frame-calcs-5095","sha":"dd8dc05c1e7401e884567b7e9978be275459f504","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","created_at":"2013-11-22T14:47:34Z","updated_at":"2015-10-23T11:21:38Z","pushed_at":"2015-10-26T22:08:05Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":null,"size":439904,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":424,"forks":50,"open_issues":424,"watchers":70,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"919a328b0b5e76ee8825c1aaf494f0b5e25256df","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","created_at":"2013-11-22T14:47:34Z","updated_at":"2015-10-23T11:21:38Z","pushed_at":"2015-10-26T22:08:05Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":null,"size":439904,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":424,"forks":50,"open_issues":424,"watchers":70,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5099"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5099"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5099/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5099/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/dd8dc05c1e7401e884567b7e9978be275459f504"}}}}