{"action":"opened","number":6215,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6215","id":40046670,"html_url":"https://github.com/mozilla/pdf.js/pull/6215","diff_url":"https://github.com/mozilla/pdf.js/pull/6215.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6215.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6215","number":6215,"state":"open","locked":false,"title":"More cleanup regarding annotation border styles","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"body":"This PR provides (minor) clean-up for the annotation border styles. There are three changes:\r\n\r\n- `this.borderStyle.setStyle('S');` is wrong as `setStyle` takes an object (with a `name` entry) as parameter, not a string. Somehow we all missed this during review, but fortunately we do not even need that line because the solid border style is the default.\r\n\r\n- The `drawBorder` parameter for `initContainer` has become unused after the annotation border style refactoring, so we can remove it.\r\n\r\n- A unit test has been adjusted for the same reason as the first point: `setStyle` takes an object as parameter, not a Dict (even though this worked too, it is better to keep it the same as what we expect).","created_at":"2015-07-15T17:15:43Z","updated_at":"2015-07-15T17:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6215/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6215/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6215/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/327210fa73746da646a378fa73dbf62bc7138de9","head":{"label":"timvandermeij:annotation-border-fixes","ref":"annotation-border-fixes","sha":"327210fa73746da646a378fa73dbf62bc7138de9","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"repo":{"id":6161909,"name":"pdf.js","full_name":"timvandermeij/pdf.js","owner":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timvandermeij/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/timvandermeij/pdf.js","forks_url":"https://api.github.com/repos/timvandermeij/pdf.js/forks","keys_url":"https://api.github.com/repos/timvandermeij/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timvandermeij/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timvandermeij/pdf.js/teams","hooks_url":"https://api.github.com/repos/timvandermeij/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/timvandermeij/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/timvandermeij/pdf.js/events","assignees_url":"https://api.github.com/repos/timvandermeij/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/timvandermeij/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/timvandermeij/pdf.js/tags","blobs_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timvandermeij/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/timvandermeij/pdf.js/languages","stargazers_url":"https://api.github.com/repos/timvandermeij/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/timvandermeij/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/timvandermeij/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/timvandermeij/pdf.js/subscription","commits_url":"https://api.github.com/repos/timvandermeij/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/timvandermeij/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/timvandermeij/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/timvandermeij/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/timvandermeij/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/timvandermeij/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timvandermeij/pdf.js/merges","archive_url":"https://api.github.com/repos/timvandermeij/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timvandermeij/pdf.js/downloads","issues_url":"https://api.github.com/repos/timvandermeij/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/timvandermeij/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/timvandermeij/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/timvandermeij/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timvandermeij/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/timvandermeij/pdf.js/releases{/id}","created_at":"2012-10-10T18:16:22Z","updated_at":"2015-04-30T20:36:01Z","pushed_at":"2015-07-15T17:11:38Z","git_url":"git://github.com/timvandermeij/pdf.js.git","ssh_url":"git@github.com:timvandermeij/pdf.js.git","clone_url":"https://github.com/timvandermeij/pdf.js.git","svn_url":"https://github.com/timvandermeij/pdf.js","homepage":"","size":49082,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"2817f008c39c6eeb28bfb9e9154b12984b9c0605","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","created_at":"2011-04-26T06:32:03Z","updated_at":"2015-07-15T16:20:54Z","pushed_at":"2015-07-15T16:52:28Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":116228,"stargazers_count":12098,"watchers_count":12098,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2746,"mirror_url":null,"open_issues_count":544,"forks":2746,"open_issues":544,"watchers":12098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6215"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/6215"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/6215"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/6215/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6215/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6215/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/327210fa73746da646a378fa73dbf62bc7138de9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":7,"changed_files":3}}