{"action":"created","comment":{"url":"https://api.github.com/repos/tidepool-org/blip/pulls/comments/26008991","id":26008991,"diff_hunk":"@@ -374,12 +391,12 @@ var PatientInfo = React.createClass({\n     }\n \n     var birthday = formValues.birthday;\n-    if (!(birthday && datetimeUtils.isValidDate(birthday))) {\n+    if (!(birthday && sundial.isValidDate(birthday))) {","path":"app/pages/patient/patientinfo.js","position":75,"original_position":75,"commit_id":"d3143732c04234c2180005a5529ee9a059be32f5","original_commit_id":"abe2821e94b5c2ae9b60679f52b79519583412a0","user":{"login":"jebeck","id":1588547,"avatar_url":"https://avatars.githubusercontent.com/u/1588547?v=3","gravatar_id":"","url":"https://api.github.com/users/jebeck","html_url":"https://github.com/jebeck","followers_url":"https://api.github.com/users/jebeck/followers","following_url":"https://api.github.com/users/jebeck/following{/other_user}","gists_url":"https://api.github.com/users/jebeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jebeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebeck/subscriptions","organizations_url":"https://api.github.com/users/jebeck/orgs","repos_url":"https://api.github.com/users/jebeck/repos","events_url":"https://api.github.com/users/jebeck/events{/privacy}","received_events_url":"https://api.github.com/users/jebeck/received_events","type":"User","site_admin":false},"body":"This doesn't work quite as intended either.\r\n\r\nIt allows you to save a completely invalid date without exposing any error:\r\n![screenshot 2015-03-08 14 06 48](https://cloud.githubusercontent.com/assets/1588547/6547684/6aa4e3c4-c59c-11e4-815c-3af10d4a98d6.png)\r\n\r\nBut then silently translates it into a valid date:\r\n![screenshot 2015-03-08 14 06 55](https://cloud.githubusercontent.com/assets/1588547/6547685/70b9fc0e-c59c-11e4-9666-7fbfcc364a44.png)\r\n\r\nI don't know if there's anything we can do about this - I think it's how moment works :/\r\n","created_at":"2015-03-08T21:07:32Z","updated_at":"2015-03-08T21:07:32Z","html_url":"https://github.com/tidepool-org/blip/pull/213#discussion_r26008991","pull_request_url":"https://api.github.com/repos/tidepool-org/blip/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/blip/pulls/comments/26008991"},"html":{"href":"https://github.com/tidepool-org/blip/pull/213#discussion_r26008991"},"pull_request":{"href":"https://api.github.com/repos/tidepool-org/blip/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/tidepool-org/blip/pulls/213","id":30614627,"html_url":"https://github.com/tidepool-org/blip/pull/213","diff_url":"https://github.com/tidepool-org/blip/pull/213.diff","patch_url":"https://github.com/tidepool-org/blip/pull/213.patch","issue_url":"https://api.github.com/repos/tidepool-org/blip/issues/213","number":213,"state":"open","locked":false,"title":"Jhbate/fix date val","user":{"login":"jh-bate","id":5168993,"avatar_url":"https://avatars.githubusercontent.com/u/5168993?v=3","gravatar_id":"","url":"https://api.github.com/users/jh-bate","html_url":"https://github.com/jh-bate","followers_url":"https://api.github.com/users/jh-bate/followers","following_url":"https://api.github.com/users/jh-bate/following{/other_user}","gists_url":"https://api.github.com/users/jh-bate/gists{/gist_id}","starred_url":"https://api.github.com/users/jh-bate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh-bate/subscriptions","organizations_url":"https://api.github.com/users/jh-bate/orgs","repos_url":"https://api.github.com/users/jh-bate/repos","events_url":"https://api.github.com/users/jh-bate/events{/privacy}","received_events_url":"https://api.github.com/users/jh-bate/received_events","type":"User","site_admin":false},"body":"This PR removes all instances of moment from blip and ensure's we use sundial for date formatting and display.\r\n\r\n@jebeck if you could have a look that would be great, and yeah I tested I could have a birthdate on the 31 of March :)\r\n\r\n@jebeck FYI - i have updated the version of sundial but haven't yet gone through all usages of it to make sure they are updated.\r\n","created_at":"2015-03-06T01:50:41Z","updated_at":"2015-03-08T21:07:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ed74dbd97f9d50b4d4aa39d1a0364083a2ca178","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tidepool-org/blip/pulls/213/commits","review_comments_url":"https://api.github.com/repos/tidepool-org/blip/pulls/213/comments","review_comment_url":"https://api.github.com/repos/tidepool-org/blip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tidepool-org/blip/issues/213/comments","statuses_url":"https://api.github.com/repos/tidepool-org/blip/statuses/d3143732c04234c2180005a5529ee9a059be32f5","head":{"label":"tidepool-org:jhbate/fix-date-val","ref":"jhbate/fix-date-val","sha":"d3143732c04234c2180005a5529ee9a059be32f5","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":15945573,"name":"blip","full_name":"tidepool-org/blip","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/blip","description":"Blip is a web-based tool for managing all your Type 1 Diabetes data in one place.","fork":false,"url":"https://api.github.com/repos/tidepool-org/blip","forks_url":"https://api.github.com/repos/tidepool-org/blip/forks","keys_url":"https://api.github.com/repos/tidepool-org/blip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/blip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/blip/teams","hooks_url":"https://api.github.com/repos/tidepool-org/blip/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/blip/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/blip/events","assignees_url":"https://api.github.com/repos/tidepool-org/blip/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/blip/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/blip/tags","blobs_url":"https://api.github.com/repos/tidepool-org/blip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/blip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/blip/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/blip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/blip/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/blip/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/blip/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/blip/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/blip/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/blip/subscription","commits_url":"https://api.github.com/repos/tidepool-org/blip/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/blip/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/blip/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/blip/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidepool-org/blip/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/blip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/blip/merges","archive_url":"https://api.github.com/repos/tidepool-org/blip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/blip/downloads","issues_url":"https://api.github.com/repos/tidepool-org/blip/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/blip/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/blip/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/blip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/blip/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/blip/releases{/id}","created_at":"2014-01-15T19:25:43Z","updated_at":"2015-02-26T19:43:37Z","pushed_at":"2015-03-08T20:52:52Z","git_url":"git://github.com/tidepool-org/blip.git","ssh_url":"git@github.com:tidepool-org/blip.git","clone_url":"https://github.com/tidepool-org/blip.git","svn_url":"https://github.com/tidepool-org/blip","homepage":"","size":20356,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":33,"default_branch":"master"}},"base":{"label":"tidepool-org:master","ref":"master","sha":"8d431ce9e14cbf3bc7f3ab7a874a4f7ee28aaaea","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":15945573,"name":"blip","full_name":"tidepool-org/blip","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/blip","description":"Blip is a web-based tool for managing all your Type 1 Diabetes data in one place.","fork":false,"url":"https://api.github.com/repos/tidepool-org/blip","forks_url":"https://api.github.com/repos/tidepool-org/blip/forks","keys_url":"https://api.github.com/repos/tidepool-org/blip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/blip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/blip/teams","hooks_url":"https://api.github.com/repos/tidepool-org/blip/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/blip/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/blip/events","assignees_url":"https://api.github.com/repos/tidepool-org/blip/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/blip/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/blip/tags","blobs_url":"https://api.github.com/repos/tidepool-org/blip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/blip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/blip/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/blip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/blip/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/blip/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/blip/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/blip/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/blip/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/blip/subscription","commits_url":"https://api.github.com/repos/tidepool-org/blip/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/blip/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/blip/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/blip/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidepool-org/blip/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/blip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/blip/merges","archive_url":"https://api.github.com/repos/tidepool-org/blip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/blip/downloads","issues_url":"https://api.github.com/repos/tidepool-org/blip/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/blip/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/blip/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/blip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/blip/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/blip/releases{/id}","created_at":"2014-01-15T19:25:43Z","updated_at":"2015-02-26T19:43:37Z","pushed_at":"2015-03-08T20:52:52Z","git_url":"git://github.com/tidepool-org/blip.git","ssh_url":"git@github.com:tidepool-org/blip.git","clone_url":"https://github.com/tidepool-org/blip.git","svn_url":"https://github.com/tidepool-org/blip","homepage":"","size":20356,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/blip/pulls/213"},"html":{"href":"https://github.com/tidepool-org/blip/pull/213"},"issue":{"href":"https://api.github.com/repos/tidepool-org/blip/issues/213"},"comments":{"href":"https://api.github.com/repos/tidepool-org/blip/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/tidepool-org/blip/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/tidepool-org/blip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tidepool-org/blip/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/tidepool-org/blip/statuses/d3143732c04234c2180005a5529ee9a059be32f5"}}}}