{"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/xcore/sc_adat/pulls/9","id":42144288,"html_url":"https://github.com/xcore/sc_adat/pull/9","diff_url":"https://github.com/xcore/sc_adat/pull/9.diff","patch_url":"https://github.com/xcore/sc_adat/pull/9.patch","issue_url":"https://api.github.com/repos/xcore/sc_adat/issues/9","number":9,"state":"open","locked":false,"title":"Read in samples from channels in one go","user":{"login":"sflower","id":1526630,"avatar_url":"https://avatars.githubusercontent.com/u/1526630?v=3","gravatar_id":"","url":"https://api.github.com/users/sflower","html_url":"https://github.com/sflower","followers_url":"https://api.github.com/users/sflower/followers","following_url":"https://api.github.com/users/sflower/following{/other_user}","gists_url":"https://api.github.com/users/sflower/gists{/gist_id}","starred_url":"https://api.github.com/users/sflower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflower/subscriptions","organizations_url":"https://api.github.com/users/sflower/orgs","repos_url":"https://api.github.com/users/sflower/repos","events_url":"https://api.github.com/users/sflower/events{/privacy}","received_events_url":"https://api.github.com/users/sflower/received_events","type":"User","site_admin":false},"body":"I'm looking for some feedback on a modification I have had to make in order to integrate ADAT TX functionality into our products. I have just made the changes in the adat_transmit_port_until_ct_4x function as an example, but they would also be required for adat_transmit_port_until_ct_2x and adat_transmit_port_until_ct_1x.\r\n\r\nCurrently the non-ADAT_TX_USE_SHARED_BUFF implementation will take almost a whole sample period to consume 8 samples from the delivery thread, this is because it consumes and transmits two samples at a time.\r\n\r\nThese changes make it consume all 8 samples from the channel at the start of the loop, then transmit the 8 samples. This reduces the amount of time required to send all 8 samples from the delivery thread by an order of magnitude.\r\n\r\nThese changes would bring the performance much more inline with the ADAT_TX_USE_SHARED_BUFF implementation.","created_at":"2015-08-11T15:45:20Z","updated_at":"2015-08-11T15:45:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xcore/sc_adat/pulls/9/commits","review_comments_url":"https://api.github.com/repos/xcore/sc_adat/pulls/9/comments","review_comment_url":"https://api.github.com/repos/xcore/sc_adat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcore/sc_adat/issues/9/comments","statuses_url":"https://api.github.com/repos/xcore/sc_adat/statuses/5543676d5c9635057e7fdb703697b2104e32bdb2","head":{"label":"audient:sf-speed-up-channel-comms","ref":"sf-speed-up-channel-comms","sha":"5543676d5c9635057e7fdb703697b2104e32bdb2","user":{"login":"audient","id":7139356,"avatar_url":"https://avatars.githubusercontent.com/u/7139356?v=3","gravatar_id":"","url":"https://api.github.com/users/audient","html_url":"https://github.com/audient","followers_url":"https://api.github.com/users/audient/followers","following_url":"https://api.github.com/users/audient/following{/other_user}","gists_url":"https://api.github.com/users/audient/gists{/gist_id}","starred_url":"https://api.github.com/users/audient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audient/subscriptions","organizations_url":"https://api.github.com/users/audient/orgs","repos_url":"https://api.github.com/users/audient/repos","events_url":"https://api.github.com/users/audient/events{/privacy}","received_events_url":"https://api.github.com/users/audient/received_events","type":"Organization","site_admin":false},"repo":{"id":19350832,"name":"sc_adat","full_name":"audient/sc_adat","owner":{"login":"audient","id":7139356,"avatar_url":"https://avatars.githubusercontent.com/u/7139356?v=3","gravatar_id":"","url":"https://api.github.com/users/audient","html_url":"https://github.com/audient","followers_url":"https://api.github.com/users/audient/followers","following_url":"https://api.github.com/users/audient/following{/other_user}","gists_url":"https://api.github.com/users/audient/gists{/gist_id}","starred_url":"https://api.github.com/users/audient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audient/subscriptions","organizations_url":"https://api.github.com/users/audient/orgs","repos_url":"https://api.github.com/users/audient/repos","events_url":"https://api.github.com/users/audient/events{/privacy}","received_events_url":"https://api.github.com/users/audient/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/audient/sc_adat","description":"Modules to receive and transmit ADAT streams","fork":true,"url":"https://api.github.com/repos/audient/sc_adat","forks_url":"https://api.github.com/repos/audient/sc_adat/forks","keys_url":"https://api.github.com/repos/audient/sc_adat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/audient/sc_adat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/audient/sc_adat/teams","hooks_url":"https://api.github.com/repos/audient/sc_adat/hooks","issue_events_url":"https://api.github.com/repos/audient/sc_adat/issues/events{/number}","events_url":"https://api.github.com/repos/audient/sc_adat/events","assignees_url":"https://api.github.com/repos/audient/sc_adat/assignees{/user}","branches_url":"https://api.github.com/repos/audient/sc_adat/branches{/branch}","tags_url":"https://api.github.com/repos/audient/sc_adat/tags","blobs_url":"https://api.github.com/repos/audient/sc_adat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/audient/sc_adat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/audient/sc_adat/git/refs{/sha}","trees_url":"https://api.github.com/repos/audient/sc_adat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/audient/sc_adat/statuses/{sha}","languages_url":"https://api.github.com/repos/audient/sc_adat/languages","stargazers_url":"https://api.github.com/repos/audient/sc_adat/stargazers","contributors_url":"https://api.github.com/repos/audient/sc_adat/contributors","subscribers_url":"https://api.github.com/repos/audient/sc_adat/subscribers","subscription_url":"https://api.github.com/repos/audient/sc_adat/subscription","commits_url":"https://api.github.com/repos/audient/sc_adat/commits{/sha}","git_commits_url":"https://api.github.com/repos/audient/sc_adat/git/commits{/sha}","comments_url":"https://api.github.com/repos/audient/sc_adat/comments{/number}","issue_comment_url":"https://api.github.com/repos/audient/sc_adat/issues/comments{/number}","contents_url":"https://api.github.com/repos/audient/sc_adat/contents/{+path}","compare_url":"https://api.github.com/repos/audient/sc_adat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/audient/sc_adat/merges","archive_url":"https://api.github.com/repos/audient/sc_adat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/audient/sc_adat/downloads","issues_url":"https://api.github.com/repos/audient/sc_adat/issues{/number}","pulls_url":"https://api.github.com/repos/audient/sc_adat/pulls{/number}","milestones_url":"https://api.github.com/repos/audient/sc_adat/milestones{/number}","notifications_url":"https://api.github.com/repos/audient/sc_adat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/audient/sc_adat/labels{/name}","releases_url":"https://api.github.com/repos/audient/sc_adat/releases{/id}","created_at":"2014-05-01T16:44:14Z","updated_at":"2014-05-01T16:44:14Z","pushed_at":"2015-08-11T15:21:45Z","git_url":"git://github.com/audient/sc_adat.git","ssh_url":"git@github.com:audient/sc_adat.git","clone_url":"https://github.com/audient/sc_adat.git","svn_url":"https://github.com/audient/sc_adat","homepage":"http://github.xcore.com/sc_adat/","size":346,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcore:master","ref":"master","sha":"204d3d7b5528c2e97a0d87ea9ecbd57c04b217cd","user":{"login":"xcore","id":562788,"avatar_url":"https://avatars.githubusercontent.com/u/562788?v=3","gravatar_id":"","url":"https://api.github.com/users/xcore","html_url":"https://github.com/xcore","followers_url":"https://api.github.com/users/xcore/followers","following_url":"https://api.github.com/users/xcore/following{/other_user}","gists_url":"https://api.github.com/users/xcore/gists{/gist_id}","starred_url":"https://api.github.com/users/xcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcore/subscriptions","organizations_url":"https://api.github.com/users/xcore/orgs","repos_url":"https://api.github.com/users/xcore/repos","events_url":"https://api.github.com/users/xcore/events{/privacy}","received_events_url":"https://api.github.com/users/xcore/received_events","type":"Organization","site_admin":false},"repo":{"id":1836580,"name":"sc_adat","full_name":"xcore/sc_adat","owner":{"login":"xcore","id":562788,"avatar_url":"https://avatars.githubusercontent.com/u/562788?v=3","gravatar_id":"","url":"https://api.github.com/users/xcore","html_url":"https://github.com/xcore","followers_url":"https://api.github.com/users/xcore/followers","following_url":"https://api.github.com/users/xcore/following{/other_user}","gists_url":"https://api.github.com/users/xcore/gists{/gist_id}","starred_url":"https://api.github.com/users/xcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcore/subscriptions","organizations_url":"https://api.github.com/users/xcore/orgs","repos_url":"https://api.github.com/users/xcore/repos","events_url":"https://api.github.com/users/xcore/events{/privacy}","received_events_url":"https://api.github.com/users/xcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcore/sc_adat","description":"Modules to receive and transmit ADAT streams","fork":false,"url":"https://api.github.com/repos/xcore/sc_adat","forks_url":"https://api.github.com/repos/xcore/sc_adat/forks","keys_url":"https://api.github.com/repos/xcore/sc_adat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcore/sc_adat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcore/sc_adat/teams","hooks_url":"https://api.github.com/repos/xcore/sc_adat/hooks","issue_events_url":"https://api.github.com/repos/xcore/sc_adat/issues/events{/number}","events_url":"https://api.github.com/repos/xcore/sc_adat/events","assignees_url":"https://api.github.com/repos/xcore/sc_adat/assignees{/user}","branches_url":"https://api.github.com/repos/xcore/sc_adat/branches{/branch}","tags_url":"https://api.github.com/repos/xcore/sc_adat/tags","blobs_url":"https://api.github.com/repos/xcore/sc_adat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcore/sc_adat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcore/sc_adat/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcore/sc_adat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcore/sc_adat/statuses/{sha}","languages_url":"https://api.github.com/repos/xcore/sc_adat/languages","stargazers_url":"https://api.github.com/repos/xcore/sc_adat/stargazers","contributors_url":"https://api.github.com/repos/xcore/sc_adat/contributors","subscribers_url":"https://api.github.com/repos/xcore/sc_adat/subscribers","subscription_url":"https://api.github.com/repos/xcore/sc_adat/subscription","commits_url":"https://api.github.com/repos/xcore/sc_adat/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcore/sc_adat/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcore/sc_adat/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcore/sc_adat/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcore/sc_adat/contents/{+path}","compare_url":"https://api.github.com/repos/xcore/sc_adat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcore/sc_adat/merges","archive_url":"https://api.github.com/repos/xcore/sc_adat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcore/sc_adat/downloads","issues_url":"https://api.github.com/repos/xcore/sc_adat/issues{/number}","pulls_url":"https://api.github.com/repos/xcore/sc_adat/pulls{/number}","milestones_url":"https://api.github.com/repos/xcore/sc_adat/milestones{/number}","notifications_url":"https://api.github.com/repos/xcore/sc_adat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcore/sc_adat/labels{/name}","releases_url":"https://api.github.com/repos/xcore/sc_adat/releases{/id}","created_at":"2011-06-02T10:28:03Z","updated_at":"2015-03-30T14:16:23Z","pushed_at":"2015-03-30T14:16:23Z","git_url":"git://github.com/xcore/sc_adat.git","ssh_url":"git@github.com:xcore/sc_adat.git","clone_url":"https://github.com/xcore/sc_adat.git","svn_url":"https://github.com/xcore/sc_adat","homepage":"http://github.xcore.com/sc_adat/","size":436,"stargazers_count":4,"watchers_count":4,"language":"XC","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcore/sc_adat/pulls/9"},"html":{"href":"https://github.com/xcore/sc_adat/pull/9"},"issue":{"href":"https://api.github.com/repos/xcore/sc_adat/issues/9"},"comments":{"href":"https://api.github.com/repos/xcore/sc_adat/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/xcore/sc_adat/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/xcore/sc_adat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcore/sc_adat/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/xcore/sc_adat/statuses/5543676d5c9635057e7fdb703697b2104e32bdb2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":13,"changed_files":1}}