{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/76","id":27737191,"html_url":"https://github.com/sydcanem/bootstrap-contextmenu/pull/76","diff_url":"https://github.com/sydcanem/bootstrap-contextmenu/pull/76.diff","patch_url":"https://github.com/sydcanem/bootstrap-contextmenu/pull/76.patch","issue_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues/76","number":76,"state":"closed","locked":false,"title":"`before` function had to explicitly return true to show","user":{"login":"dsherret","id":1609021,"avatar_url":"https://avatars.githubusercontent.com/u/1609021?v=3","gravatar_id":"","url":"https://api.github.com/users/dsherret","html_url":"https://github.com/dsherret","followers_url":"https://api.github.com/users/dsherret/followers","following_url":"https://api.github.com/users/dsherret/following{/other_user}","gists_url":"https://api.github.com/users/dsherret/gists{/gist_id}","starred_url":"https://api.github.com/users/dsherret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsherret/subscriptions","organizations_url":"https://api.github.com/users/dsherret/orgs","repos_url":"https://api.github.com/users/dsherret/repos","events_url":"https://api.github.com/users/dsherret/events{/privacy}","received_events_url":"https://api.github.com/users/dsherret/received_events","type":"User","site_admin":false},"body":"In the current code, the following code from the README.MD will not show the contextmenu:\r\n\r\n```javascript\r\n$('.context').contextmenu({\r\n  target:'#context-menu', \r\n  before: function(e,context) {\r\n  },\r\n  onItem: function(context,e) {\r\n  }\r\n});\r\n```\r\n\r\nThis is because the `before` function must return true in order to show. The documentation only talks about returning false to not show the context menu. I've committed a fix that will only not show the context menu if the before function returns false.","created_at":"2015-01-21T05:58:24Z","updated_at":"2015-04-26T07:04:56Z","closed_at":"2015-04-26T07:04:56Z","merged_at":"2015-04-26T07:04:56Z","merge_commit_sha":"cb66b81ac7de5c75b62fa9c323ed978b7421e71e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/76/commits","review_comments_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/76/comments","review_comment_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues/76/comments","statuses_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/statuses/fdbc108fa1d916c9aa1eb2374580b9cca3adb322","head":{"label":"dsherret:master","ref":"master","sha":"fdbc108fa1d916c9aa1eb2374580b9cca3adb322","user":{"login":"dsherret","id":1609021,"avatar_url":"https://avatars.githubusercontent.com/u/1609021?v=3","gravatar_id":"","url":"https://api.github.com/users/dsherret","html_url":"https://github.com/dsherret","followers_url":"https://api.github.com/users/dsherret/followers","following_url":"https://api.github.com/users/dsherret/following{/other_user}","gists_url":"https://api.github.com/users/dsherret/gists{/gist_id}","starred_url":"https://api.github.com/users/dsherret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsherret/subscriptions","organizations_url":"https://api.github.com/users/dsherret/orgs","repos_url":"https://api.github.com/users/dsherret/repos","events_url":"https://api.github.com/users/dsherret/events{/privacy}","received_events_url":"https://api.github.com/users/dsherret/received_events","type":"User","site_admin":false},"repo":{"id":29573425,"name":"bootstrap-contextmenu","full_name":"dsherret/bootstrap-contextmenu","owner":{"login":"dsherret","id":1609021,"avatar_url":"https://avatars.githubusercontent.com/u/1609021?v=3","gravatar_id":"","url":"https://api.github.com/users/dsherret","html_url":"https://github.com/dsherret","followers_url":"https://api.github.com/users/dsherret/followers","following_url":"https://api.github.com/users/dsherret/following{/other_user}","gists_url":"https://api.github.com/users/dsherret/gists{/gist_id}","starred_url":"https://api.github.com/users/dsherret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsherret/subscriptions","organizations_url":"https://api.github.com/users/dsherret/orgs","repos_url":"https://api.github.com/users/dsherret/repos","events_url":"https://api.github.com/users/dsherret/events{/privacy}","received_events_url":"https://api.github.com/users/dsherret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsherret/bootstrap-contextmenu","description":"Context menu plugin for Twitter's Bootstrap framework","fork":true,"url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu","forks_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/forks","keys_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/teams","hooks_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/hooks","issue_events_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/issues/events{/number}","events_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/events","assignees_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/assignees{/user}","branches_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/branches{/branch}","tags_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/tags","blobs_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/statuses/{sha}","languages_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/languages","stargazers_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/stargazers","contributors_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/contributors","subscribers_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/subscribers","subscription_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/subscription","commits_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/contents/{+path}","compare_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/merges","archive_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/downloads","issues_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/issues{/number}","pulls_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/pulls{/number}","milestones_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/milestones{/number}","notifications_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/labels{/name}","releases_url":"https://api.github.com/repos/dsherret/bootstrap-contextmenu/releases{/id}","created_at":"2015-01-21T05:37:07Z","updated_at":"2015-01-21T05:54:33Z","pushed_at":"2015-01-21T05:54:33Z","git_url":"git://github.com/dsherret/bootstrap-contextmenu.git","ssh_url":"git@github.com:dsherret/bootstrap-contextmenu.git","clone_url":"https://github.com/dsherret/bootstrap-contextmenu.git","svn_url":"https://github.com/dsherret/bootstrap-contextmenu","homepage":"http://sydcanem.com/bootstrap-contextmenu/","size":306,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sydcanem:master","ref":"master","sha":"edc233ea0cf96448fea7a99d93db1920be952188","user":{"login":"sydcanem","id":646857,"avatar_url":"https://avatars.githubusercontent.com/u/646857?v=3","gravatar_id":"","url":"https://api.github.com/users/sydcanem","html_url":"https://github.com/sydcanem","followers_url":"https://api.github.com/users/sydcanem/followers","following_url":"https://api.github.com/users/sydcanem/following{/other_user}","gists_url":"https://api.github.com/users/sydcanem/gists{/gist_id}","starred_url":"https://api.github.com/users/sydcanem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydcanem/subscriptions","organizations_url":"https://api.github.com/users/sydcanem/orgs","repos_url":"https://api.github.com/users/sydcanem/repos","events_url":"https://api.github.com/users/sydcanem/events{/privacy}","received_events_url":"https://api.github.com/users/sydcanem/received_events","type":"User","site_admin":false},"repo":{"id":6380965,"name":"bootstrap-contextmenu","full_name":"sydcanem/bootstrap-contextmenu","owner":{"login":"sydcanem","id":646857,"avatar_url":"https://avatars.githubusercontent.com/u/646857?v=3","gravatar_id":"","url":"https://api.github.com/users/sydcanem","html_url":"https://github.com/sydcanem","followers_url":"https://api.github.com/users/sydcanem/followers","following_url":"https://api.github.com/users/sydcanem/following{/other_user}","gists_url":"https://api.github.com/users/sydcanem/gists{/gist_id}","starred_url":"https://api.github.com/users/sydcanem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydcanem/subscriptions","organizations_url":"https://api.github.com/users/sydcanem/orgs","repos_url":"https://api.github.com/users/sydcanem/repos","events_url":"https://api.github.com/users/sydcanem/events{/privacy}","received_events_url":"https://api.github.com/users/sydcanem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sydcanem/bootstrap-contextmenu","description":"Context menu plugin for Twitter's Bootstrap framework","fork":false,"url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu","forks_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/forks","keys_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/teams","hooks_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/hooks","issue_events_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues/events{/number}","events_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/events","assignees_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/assignees{/user}","branches_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/branches{/branch}","tags_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/tags","blobs_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/statuses/{sha}","languages_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/languages","stargazers_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/stargazers","contributors_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/contributors","subscribers_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/subscribers","subscription_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/subscription","commits_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/contents/{+path}","compare_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/merges","archive_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/downloads","issues_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues{/number}","pulls_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls{/number}","milestones_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/milestones{/number}","notifications_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/labels{/name}","releases_url":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/releases{/id}","created_at":"2012-10-25T02:42:00Z","updated_at":"2015-04-25T12:31:26Z","pushed_at":"2015-04-26T07:04:56Z","git_url":"git://github.com/sydcanem/bootstrap-contextmenu.git","ssh_url":"git@github.com:sydcanem/bootstrap-contextmenu.git","clone_url":"https://github.com/sydcanem/bootstrap-contextmenu.git","svn_url":"https://github.com/sydcanem/bootstrap-contextmenu","homepage":"http://sydcanem.com/bootstrap-contextmenu/","size":740,"stargazers_count":454,"watchers_count":454,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"open_issues_count":9,"forks":140,"open_issues":9,"watchers":454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/76"},"html":{"href":"https://github.com/sydcanem/bootstrap-contextmenu/pull/76"},"issue":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues/76"},"comments":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/sydcanem/bootstrap-contextmenu/statuses/fdbc108fa1d916c9aa1eb2374580b9cca3adb322"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sydcanem","id":646857,"avatar_url":"https://avatars.githubusercontent.com/u/646857?v=3","gravatar_id":"","url":"https://api.github.com/users/sydcanem","html_url":"https://github.com/sydcanem","followers_url":"https://api.github.com/users/sydcanem/followers","following_url":"https://api.github.com/users/sydcanem/following{/other_user}","gists_url":"https://api.github.com/users/sydcanem/gists{/gist_id}","starred_url":"https://api.github.com/users/sydcanem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydcanem/subscriptions","organizations_url":"https://api.github.com/users/sydcanem/orgs","repos_url":"https://api.github.com/users/sydcanem/repos","events_url":"https://api.github.com/users/sydcanem/events{/privacy}","received_events_url":"https://api.github.com/users/sydcanem/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":37,"deletions":1,"changed_files":2}}