{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-network/pulls/comments/44899176","id":44899176,"diff_hunk":"@@ -645,7 +645,7 @@ def WriteUdevItemsRules\n           # - remove it completely\n           # removing is less error prone when tracking name changes, so it was chosen.\n           item_udev_net = RemoveKeyFromUdevRule(item_udev_net, \"KERNEL\")\n-          SetLinkDown(dev_name)\n+          SetLinkDown(dev_name) if !Mode.autoinst","path":"src/modules/LanItems.rb","position":5,"original_position":5,"commit_id":"eef0c59576d18bea18f580f6a26c5f83a1e4ca0f","original_commit_id":"eef0c59576d18bea18f580f6a26c5f83a1e4ca0f","user":{"login":"schubi2","id":909986,"avatar_url":"https://avatars.githubusercontent.com/u/909986?v=3","gravatar_id":"","url":"https://api.github.com/users/schubi2","html_url":"https://github.com/schubi2","followers_url":"https://api.github.com/users/schubi2/followers","following_url":"https://api.github.com/users/schubi2/following{/other_user}","gists_url":"https://api.github.com/users/schubi2/gists{/gist_id}","starred_url":"https://api.github.com/users/schubi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schubi2/subscriptions","organizations_url":"https://api.github.com/users/schubi2/orgs","repos_url":"https://api.github.com/users/schubi2/repos","events_url":"https://api.github.com/users/schubi2/events{/privacy}","received_events_url":"https://api.github.com/users/schubi2/received_events","type":"User","site_admin":false},"body":"I would put here also an comment, that AutoYaST would have here a problem if it used via SSH installation.","created_at":"2015-11-16T08:47:53Z","updated_at":"2015-11-16T08:47:53Z","html_url":"https://github.com/yast/yast-network/pull/363#discussion_r44899176","pull_request_url":"https://api.github.com/repos/yast/yast-network/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments/44899176"},"html":{"href":"https://github.com/yast/yast-network/pull/363#discussion_r44899176"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-network/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-network/pulls/363","id":50778173,"html_url":"https://github.com/yast/yast-network/pull/363","diff_url":"https://github.com/yast/yast-network/pull/363.diff","patch_url":"https://github.com/yast/yast-network/pull/363.patch","issue_url":"https://api.github.com/repos/yast/yast-network/issues/363","number":363,"state":"open","locked":false,"title":"Device renaming during ssh|vnc AY installation","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"body":"bnc#944349\r\n\r\nthe most important part of the patch is moving device renaming from 2nd into 1st stage\r\n\r\nDo not merge yet, still under testing.","created_at":"2015-11-16T07:18:56Z","updated_at":"2015-11-16T08:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"905fcc1a30decd802cfbe510e664a4848ca973d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-network/pulls/363/commits","review_comments_url":"https://api.github.com/repos/yast/yast-network/pulls/363/comments","review_comment_url":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-network/issues/363/comments","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/eef0c59576d18bea18f580f6a26c5f83a1e4ca0f","head":{"label":"mchf:bnc944349-ssh-install","ref":"bnc944349-ssh-install","sha":"eef0c59576d18bea18f580f6a26c5f83a1e4ca0f","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"repo":{"id":4748313,"name":"yast-network","full_name":"mchf/yast-network","owner":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchf/yast-network","description":"YaST module network","fork":true,"url":"https://api.github.com/repos/mchf/yast-network","forks_url":"https://api.github.com/repos/mchf/yast-network/forks","keys_url":"https://api.github.com/repos/mchf/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchf/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchf/yast-network/teams","hooks_url":"https://api.github.com/repos/mchf/yast-network/hooks","issue_events_url":"https://api.github.com/repos/mchf/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/mchf/yast-network/events","assignees_url":"https://api.github.com/repos/mchf/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/mchf/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/mchf/yast-network/tags","blobs_url":"https://api.github.com/repos/mchf/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchf/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchf/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchf/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchf/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/mchf/yast-network/languages","stargazers_url":"https://api.github.com/repos/mchf/yast-network/stargazers","contributors_url":"https://api.github.com/repos/mchf/yast-network/contributors","subscribers_url":"https://api.github.com/repos/mchf/yast-network/subscribers","subscription_url":"https://api.github.com/repos/mchf/yast-network/subscription","commits_url":"https://api.github.com/repos/mchf/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchf/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchf/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchf/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchf/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/mchf/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchf/yast-network/merges","archive_url":"https://api.github.com/repos/mchf/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchf/yast-network/downloads","issues_url":"https://api.github.com/repos/mchf/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/mchf/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/mchf/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/mchf/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchf/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/mchf/yast-network/releases{/id}","created_at":"2012-06-22T06:44:13Z","updated_at":"2015-05-06T13:22:26Z","pushed_at":"2015-11-16T08:26:07Z","git_url":"git://github.com/mchf/yast-network.git","ssh_url":"git@github.com:mchf/yast-network.git","clone_url":"https://github.com/mchf/yast-network.git","svn_url":"https://github.com/mchf/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":26187,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yast:SLE-12-SP1","ref":"SLE-12-SP1","sha":"293a3c1eeb61adc1202019e636ceae904b4a3d91","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368160,"name":"yast-network","full_name":"yast/yast-network","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-network","description":"YaST module network","fork":false,"url":"https://api.github.com/repos/yast/yast-network","forks_url":"https://api.github.com/repos/yast/yast-network/forks","keys_url":"https://api.github.com/repos/yast/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-network/teams","hooks_url":"https://api.github.com/repos/yast/yast-network/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-network/events","assignees_url":"https://api.github.com/repos/yast/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-network/tags","blobs_url":"https://api.github.com/repos/yast/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-network/languages","stargazers_url":"https://api.github.com/repos/yast/yast-network/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-network/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-network/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-network/subscription","commits_url":"https://api.github.com/repos/yast/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-network/merges","archive_url":"https://api.github.com/repos/yast/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-network/downloads","issues_url":"https://api.github.com/repos/yast/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-network/releases{/id}","created_at":"2012-05-18T10:24:50Z","updated_at":"2015-09-20T18:17:24Z","pushed_at":"2015-11-16T08:26:08Z","git_url":"git://github.com/yast/yast-network.git","ssh_url":"git@github.com:yast/yast-network.git","clone_url":"https://github.com/yast/yast-network.git","svn_url":"https://github.com/yast/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":25844,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/363"},"html":{"href":"https://github.com/yast/yast-network/pull/363"},"issue":{"href":"https://api.github.com/repos/yast/yast-network/issues/363"},"comments":{"href":"https://api.github.com/repos/yast/yast-network/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-network/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-network/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-network/statuses/eef0c59576d18bea18f580f6a26c5f83a1e4ca0f"}}}}