{"action":"created","issue":{"url":"https://api.github.com/repos/lloeki/matterfront/issues/67","labels_url":"https://api.github.com/repos/lloeki/matterfront/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/lloeki/matterfront/issues/67/comments","events_url":"https://api.github.com/repos/lloeki/matterfront/issues/67/events","html_url":"https://github.com/lloeki/matterfront/pull/67","id":122814527,"number":67,"title":"Add tabs for teams","user":{"login":"geekytime","id":650247,"avatar_url":"https://avatars.githubusercontent.com/u/650247?v=3","gravatar_id":"","url":"https://api.github.com/users/geekytime","html_url":"https://github.com/geekytime","followers_url":"https://api.github.com/users/geekytime/followers","following_url":"https://api.github.com/users/geekytime/following{/other_user}","gists_url":"https://api.github.com/users/geekytime/gists{/gist_id}","starred_url":"https://api.github.com/users/geekytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekytime/subscriptions","organizations_url":"https://api.github.com/users/geekytime/orgs","repos_url":"https://api.github.com/users/geekytime/repos","events_url":"https://api.github.com/users/geekytime/events{/privacy}","received_events_url":"https://api.github.com/users/geekytime/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-17T20:14:44Z","updated_at":"2015-12-17T21:09:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lloeki/matterfront/pulls/67","html_url":"https://github.com/lloeki/matterfront/pull/67","diff_url":"https://github.com/lloeki/matterfront/pull/67.diff","patch_url":"https://github.com/lloeki/matterfront/pull/67.patch"},"body":"Sorry this is so big, but it took a fair amount of refactoring to get this to work cleanly. The good news is that this adds tabs for teams, with full support for notifications per tab, and basic support for themes (so if your teams are different colors, the tab background honors that).\r\n\r\nI also had some minor adventures with the webpack/livereload situation that were getting in the way, and sort of needed to be dealt with so I could work at speed.\r\n\r\nI think my commits tell the story pretty well, so that would be a good place to start reviewing.\r\n\r\nThe \"app state\" concept feels a little tricky to follow for folks who are new to React. If you're interested in the back-story behind this approach, read Matti Lankinen's article [Goodbye Flux, Welcome Bacon/RX?](https://medium.com/@milankinen/good-bye-flux-welcome-bacon-rx-23c71abfb1a7#.l489733k7).\r\n\r\nThe `app-state` module could definitely use some refactoring to simplify the pattern and reduce the amount of boilerplate needed per variable/action, but I wanted to watch the pattern emerge a bit more before abstracting it away, so I don't code myself into a corner."},"comment":{"url":"https://api.github.com/repos/lloeki/matterfront/issues/comments/165582927","html_url":"https://github.com/lloeki/matterfront/pull/67#issuecomment-165582927","issue_url":"https://api.github.com/repos/lloeki/matterfront/issues/67","id":165582927,"user":{"login":"ninja-","id":5637961,"avatar_url":"https://avatars.githubusercontent.com/u/5637961?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-","html_url":"https://github.com/ninja-","followers_url":"https://api.github.com/users/ninja-/followers","following_url":"https://api.github.com/users/ninja-/following{/other_user}","gists_url":"https://api.github.com/users/ninja-/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-/subscriptions","organizations_url":"https://api.github.com/users/ninja-/orgs","repos_url":"https://api.github.com/users/ninja-/repos","events_url":"https://api.github.com/users/ninja-/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T21:09:41Z","updated_at":"2015-12-17T21:09:41Z","body":"> until Mattermost implements its own tab view.\r\nfrom my point of view it should stay within matterfront just as slack does, because the accounts aren't related(or on different servers), have different preferences set etc. I like the way you implemented teams in this PR. Also, in future mattermost should add it's own minimal integration api so getting notification data wouldn't look hacky(hooking into webview still but straight to register listeners) "}}