{"action":"closed","number":23730,"pull_request":{"url":"https://api.github.com/repos/dart-lang/sdk/pulls/23730","id":38677898,"html_url":"https://github.com/dart-lang/sdk/pull/23730","diff_url":"https://github.com/dart-lang/sdk/pull/23730.diff","patch_url":"https://github.com/dart-lang/sdk/pull/23730.patch","issue_url":"https://api.github.com/repos/dart-lang/sdk/issues/23730","number":23730,"state":"closed","locked":false,"title":"Avoid multiline string literal in svgelement test.","user":{"login":"herhut-ggl","id":7458821,"avatar_url":"https://avatars.githubusercontent.com/u/7458821?v=3","gravatar_id":"","url":"https://api.github.com/users/herhut-ggl","html_url":"https://github.com/herhut-ggl","followers_url":"https://api.github.com/users/herhut-ggl/followers","following_url":"https://api.github.com/users/herhut-ggl/following{/other_user}","gists_url":"https://api.github.com/users/herhut-ggl/gists{/gist_id}","starred_url":"https://api.github.com/users/herhut-ggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herhut-ggl/subscriptions","organizations_url":"https://api.github.com/users/herhut-ggl/orgs","repos_url":"https://api.github.com/users/herhut-ggl/repos","events_url":"https://api.github.com/users/herhut-ggl/events{/privacy}","received_events_url":"https://api.github.com/users/herhut-ggl/received_events","type":"User","site_admin":false},"body":"Due to the recently introduced crlf normalization, the svnelement_test no longer passes on windows. The issue is that the multiline string literal might contain crlf on windows if the local git client is configured to do the translation (which is the default). To avoid this, I have changed the test to use single line literals with explicit \\n.","created_at":"2015-06-26T18:45:13Z","updated_at":"2015-06-29T10:31:11Z","closed_at":"2015-06-29T10:31:11Z","merged_at":null,"merge_commit_sha":"9d0ac63920311306b428c946b8bb7034c6d6c6db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/sdk/pulls/23730/commits","review_comments_url":"https://api.github.com/repos/dart-lang/sdk/pulls/23730/comments","review_comment_url":"https://api.github.com/repos/dart-lang/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/23730/comments","statuses_url":"https://api.github.com/repos/dart-lang/sdk/statuses/6f2994e3622b0766bcf180ace2f1421b0c12a17e","head":{"label":"dart-lang:herhut-ggl-patch-1","ref":"herhut-ggl-patch-1","sha":"6f2994e3622b0766bcf180ace2f1421b0c12a17e","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":35726310,"name":"sdk","full_name":"dart-lang/sdk","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/sdk","description":"The Dart SDK, including the VM, dart2js, core libraries, and more.","fork":false,"url":"https://api.github.com/repos/dart-lang/sdk","forks_url":"https://api.github.com/repos/dart-lang/sdk/forks","keys_url":"https://api.github.com/repos/dart-lang/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/sdk/teams","hooks_url":"https://api.github.com/repos/dart-lang/sdk/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/sdk/events","assignees_url":"https://api.github.com/repos/dart-lang/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/sdk/tags","blobs_url":"https://api.github.com/repos/dart-lang/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/sdk/languages","stargazers_url":"https://api.github.com/repos/dart-lang/sdk/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/sdk/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/sdk/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/sdk/subscription","commits_url":"https://api.github.com/repos/dart-lang/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/sdk/merges","archive_url":"https://api.github.com/repos/dart-lang/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/sdk/downloads","issues_url":"https://api.github.com/repos/dart-lang/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/sdk/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/sdk/releases{/id}","created_at":"2015-05-16T14:14:58Z","updated_at":"2015-06-28T17:21:52Z","pushed_at":"2015-06-29T07:16:58Z","git_url":"git://github.com/dart-lang/sdk.git","ssh_url":"git@github.com:dart-lang/sdk.git","clone_url":"https://github.com/dart-lang/sdk.git","svn_url":"https://github.com/dart-lang/sdk","homepage":"https://www.dartlang.org/","size":105501,"stargazers_count":243,"watchers_count":243,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":3304,"forks":23,"open_issues":3304,"watchers":243,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"86d0309c656b8324f4c5609bb5c1bdc38d361355","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":35726310,"name":"sdk","full_name":"dart-lang/sdk","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/sdk","description":"The Dart SDK, including the VM, dart2js, core libraries, and more.","fork":false,"url":"https://api.github.com/repos/dart-lang/sdk","forks_url":"https://api.github.com/repos/dart-lang/sdk/forks","keys_url":"https://api.github.com/repos/dart-lang/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/sdk/teams","hooks_url":"https://api.github.com/repos/dart-lang/sdk/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/sdk/events","assignees_url":"https://api.github.com/repos/dart-lang/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/sdk/tags","blobs_url":"https://api.github.com/repos/dart-lang/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/sdk/languages","stargazers_url":"https://api.github.com/repos/dart-lang/sdk/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/sdk/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/sdk/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/sdk/subscription","commits_url":"https://api.github.com/repos/dart-lang/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/sdk/merges","archive_url":"https://api.github.com/repos/dart-lang/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/sdk/downloads","issues_url":"https://api.github.com/repos/dart-lang/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/sdk/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/sdk/releases{/id}","created_at":"2015-05-16T14:14:58Z","updated_at":"2015-06-28T17:21:52Z","pushed_at":"2015-06-29T07:16:58Z","git_url":"git://github.com/dart-lang/sdk.git","ssh_url":"git@github.com:dart-lang/sdk.git","clone_url":"https://github.com/dart-lang/sdk.git","svn_url":"https://github.com/dart-lang/sdk","homepage":"https://www.dartlang.org/","size":105501,"stargazers_count":243,"watchers_count":243,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":3304,"forks":23,"open_issues":3304,"watchers":243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/sdk/pulls/23730"},"html":{"href":"https://github.com/dart-lang/sdk/pull/23730"},"issue":{"href":"https://api.github.com/repos/dart-lang/sdk/issues/23730"},"comments":{"href":"https://api.github.com/repos/dart-lang/sdk/issues/23730/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/sdk/pulls/23730/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/sdk/pulls/23730/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/sdk/statuses/6f2994e3622b0766bcf180ace2f1421b0c12a17e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":5,"changed_files":1}}