{"comment":{"url":"https://api.github.com/repos/annawoodard/CRABServer/comments/10225200","html_url":"https://github.com/annawoodard/CRABServer/commit/33af11064d44b2258886dc91ea1c8e2750d0d6da#commitcomment-10225200","id":10225200,"user":{"login":"annawoodard","id":5114833,"avatar_url":"https://avatars.githubusercontent.com/u/5114833?v=3","gravatar_id":"","url":"https://api.github.com/users/annawoodard","html_url":"https://github.com/annawoodard","followers_url":"https://api.github.com/users/annawoodard/followers","following_url":"https://api.github.com/users/annawoodard/following{/other_user}","gists_url":"https://api.github.com/users/annawoodard/gists{/gist_id}","starred_url":"https://api.github.com/users/annawoodard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annawoodard/subscriptions","organizations_url":"https://api.github.com/users/annawoodard/orgs","repos_url":"https://api.github.com/users/annawoodard/repos","events_url":"https://api.github.com/users/annawoodard/events{/privacy}","received_events_url":"https://api.github.com/users/annawoodard/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"33af11064d44b2258886dc91ea1c8e2750d0d6da","created_at":"2015-03-16T23:10:47Z","updated_at":"2015-03-16T23:10:47Z","body":"> I am sorry to be picky for these details, especially after you wrote so much code, but can you change all the variable names from snake_case (input_files) to camelCase (inputFiles). You can pylint your code using the followinf configuration file: https://github.com/dmwm/WMCore/blob/master/standards/.pylintrc\r\n\r\nNo problem; I'll pylint my commits from now on, thanks for pointing me to the config. Variable names are fixed in 36aa8c4c78500036de7fcad4092eb4a8cc5b8fea.\r\n\r\n> I have a more meaningful comment. Would it make sense for you to move the dryrun related feature in a DryRunUploader.py TaskWorker Action ? \r\n\r\nGood idea. Done in 36aa8c4c78500036de7fcad4092eb4a8cc5b8fea (note that I needed to move the assembly of this input files [list](https://github.com/annawoodard/CRABServer/commit/36aa8c4c78500036de7fcad4092eb4a8cc5b8fea#diff-87c8bab9e7cf28a8e8b0526de0cbed82R753) from the DagmanSubmitter to the DagmanCreator and pass them along, so that the DryRunUploader could pick them up.) I also needed to pass the splitting factory [through](https://github.com/annawoodard/CRABServer/commit/36aa8c4c78500036de7fcad4092eb4a8cc5b8fea#diff-87c8bab9e7cf28a8e8b0526de0cbed82R768), even though the Submitter doesn't need it-- not too nice, but I didn't know how to avoid it.\r\n\r\n> I have one final comment, but that's more on me than on you, I don't like that in this case we are adding a column to the DB for the sandbox hash. Maybe we can improve our crabcache so that it accepts filenames. I have implemented the feature for logfiles long time ago, maybe we can extend it to any named file. That way we can save one column. I can do that once the other changes I suggested are done and I will try the code :) In general I would like to avoid the \"proliferation\" of columns in the task DB.\r\n\r\nI agree that it's best to avoid new columns in the DB when possible. I've taken out the column and switched to using the logfiles method, to make it more straightforward to update once the any-named-file feature is in the crabcache. It seems to me that the [functionality](https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/Services/UserFileCache/UserFileCache.py#L43) is not special for log files; we can just change the name, no?"}}