{"action":"created","comment":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments/29040598","id":29040598,"diff_hunk":"@@ -226,6 +226,8 @@ app.ProfileController = function($scope) {\n             p.getCoordinates().concat(newVal[i]['dist']));\n       }\n       this.line_ = lineString;\n+    } else {\n+      delete this.line_;","path":"geoportailv3/static/js/profile/profiledirective.js","position":14,"original_position":14,"commit_id":"e69ef2fa241e5c88416010b835fd9a8bfd7ce7eb","original_commit_id":"e69ef2fa241e5c88416010b835fd9a8bfd7ce7eb","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"I'd rather initialize `this.line_` to `null` in the constructor, and reset it to `null` here.\r\n\r\n```js\r\n  /**\r\n   * @type {ol.geom.LineString}\r\n   * @private\r\n   */\r\n  this.line_ = null;\r\n```","created_at":"2015-04-24T11:06:49Z","updated_at":"2015-04-24T11:06:49Z","html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/427#discussion_r29040598","pull_request_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427","_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments/29040598"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/427#discussion_r29040598"},"pull_request":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427"}}},"pull_request":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427","id":34025091,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/427","diff_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/427.diff","patch_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/427.patch","issue_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/427","number":427,"state":"open","locked":false,"title":"Put the profile in the measures tools","user":{"login":"pgiraud","id":319774,"avatar_url":"https://avatars.githubusercontent.com/u/319774?v=3","gravatar_id":"","url":"https://api.github.com/users/pgiraud","html_url":"https://github.com/pgiraud","followers_url":"https://api.github.com/users/pgiraud/followers","following_url":"https://api.github.com/users/pgiraud/following{/other_user}","gists_url":"https://api.github.com/users/pgiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/pgiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgiraud/subscriptions","organizations_url":"https://api.github.com/users/pgiraud/orgs","repos_url":"https://api.github.com/users/pgiraud/repos","events_url":"https://api.github.com/users/pgiraud/events{/privacy}","received_events_url":"https://api.github.com/users/pgiraud/received_events","type":"User","site_admin":false},"body":"With this patch, the profile chart is located at the same place as the other measure tools.\r\n\r\nThis is how it looks:\r\n![screenshot from 2015-04-24 09 37 40](https://cloud.githubusercontent.com/assets/319774/7314529/a7ffedd4-ea65-11e4-918a-402c807c7728.png)\r\n","created_at":"2015-04-24T07:38:42Z","updated_at":"2015-04-24T11:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a043b10e9e74bfbaf291af823d9decb4de7380","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427/commits","review_comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427/comments","review_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/427/comments","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/e69ef2fa241e5c88416010b835fd9a8bfd7ce7eb","head":{"label":"Geoportail-Luxembourg:pgiraud_profile_interaction","ref":"pgiraud_profile_interaction","sha":"e69ef2fa241e5c88416010b835fd9a8bfd7ce7eb","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-04-22T11:43:57Z","pushed_at":"2015-04-24T08:37:48Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":81790,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":37,"forks":0,"open_issues":37,"watchers":4,"default_branch":"master"}},"base":{"label":"Geoportail-Luxembourg:master","ref":"master","sha":"72695d85a2d429fba4172ed65a1f6a4855f70a08","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-04-22T11:43:57Z","pushed_at":"2015-04-24T08:37:48Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":81790,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":37,"forks":0,"open_issues":37,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/427"},"issue":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/427"},"comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/e69ef2fa241e5c88416010b835fd9a8bfd7ce7eb"}}}}