{"action":"created","comment":{"url":"https://api.github.com/repos/Nikea/scikit-xray/pulls/comments/25515078","id":25515078,"diff_hunk":"@@ -353,9 +353,8 @@ def compton(x, compton_amplitude, coherent_sct_energy,\n \n     x = e_offset + x * e_linear + x**2 * e_quadratic\n \n-    compton_e = (coherent_sct_energy\n-                 / (1 + (coherent_sct_energy / 511)\n-                    * (1 - np.cos(compton_angle * np.pi / 180))))\n+    compton_e = coherent_sct_energy / (1 + (coherent_sct_energy / 511) *","path":"skxray/fitting/lineshapes.py","position":16,"original_position":16,"commit_id":"26dc6abf3619047e461d9bb8926c61b792068e90","original_commit_id":"26dc6abf3619047e461d9bb8926c61b792068e90","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"body":"Style nit: might be work breaking this up into two steps\r\n\r\n```python\r\ncomp_denom = (1 + (coherent_sct_energy / 511) * (1 - np.cos(compton_angle * np.pi / 180)))\r\ncompton_e = coherent_sct_energy / comp_denom\r\n```\r\n\r\nto make this more readable and robust to single character `()` errors.\r\n\r\nAlso, where does 511 come from?","created_at":"2015-02-27T15:50:57Z","updated_at":"2015-02-27T15:50:57Z","html_url":"https://github.com/Nikea/scikit-xray/pull/158#discussion_r25515078","pull_request_url":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/Nikea/scikit-xray/pulls/comments/25515078"},"html":{"href":"https://github.com/Nikea/scikit-xray/pull/158#discussion_r25515078"},"pull_request":{"href":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158","id":22027115,"html_url":"https://github.com/Nikea/scikit-xray/pull/158","diff_url":"https://github.com/Nikea/scikit-xray/pull/158.diff","patch_url":"https://github.com/Nikea/scikit-xray/pull/158.patch","issue_url":"https://api.github.com/repos/Nikea/scikit-xray/issues/158","number":158,"state":"open","locked":false,"title":"Lmfit model for xrf","user":{"login":"licode","id":4765544,"avatar_url":"https://avatars.githubusercontent.com/u/4765544?v=3","gravatar_id":"","url":"https://api.github.com/users/licode","html_url":"https://github.com/licode","followers_url":"https://api.github.com/users/licode/followers","following_url":"https://api.github.com/users/licode/following{/other_user}","gists_url":"https://api.github.com/users/licode/gists{/gist_id}","starred_url":"https://api.github.com/users/licode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/licode/subscriptions","organizations_url":"https://api.github.com/users/licode/orgs","repos_url":"https://api.github.com/users/licode/repos","events_url":"https://api.github.com/users/licode/events{/privacy}","received_events_url":"https://api.github.com/users/licode/received_events","type":"User","site_admin":false},"body":"The fitting model for xrf is included. It is still in process, and some file structure might need to be re-organized.","created_at":"2014-09-30T19:02:19Z","updated_at":"2015-02-27T15:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9681f925b74f0774df062696b2b47e794941568","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158/commits","review_comments_url":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158/comments","review_comment_url":"https://api.github.com/repos/Nikea/scikit-xray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nikea/scikit-xray/issues/158/comments","statuses_url":"https://api.github.com/repos/Nikea/scikit-xray/statuses/26dc6abf3619047e461d9bb8926c61b792068e90","head":{"label":"licode:lmfit_model","ref":"lmfit_model","sha":"26dc6abf3619047e461d9bb8926c61b792068e90","user":{"login":"licode","id":4765544,"avatar_url":"https://avatars.githubusercontent.com/u/4765544?v=3","gravatar_id":"","url":"https://api.github.com/users/licode","html_url":"https://github.com/licode","followers_url":"https://api.github.com/users/licode/followers","following_url":"https://api.github.com/users/licode/following{/other_user}","gists_url":"https://api.github.com/users/licode/gists{/gist_id}","starred_url":"https://api.github.com/users/licode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/licode/subscriptions","organizations_url":"https://api.github.com/users/licode/orgs","repos_url":"https://api.github.com/users/licode/repos","events_url":"https://api.github.com/users/licode/events{/privacy}","received_events_url":"https://api.github.com/users/licode/received_events","type":"User","site_admin":false},"repo":{"id":21828441,"name":"scikit-xray","full_name":"licode/scikit-xray","owner":{"login":"licode","id":4765544,"avatar_url":"https://avatars.githubusercontent.com/u/4765544?v=3","gravatar_id":"","url":"https://api.github.com/users/licode","html_url":"https://github.com/licode","followers_url":"https://api.github.com/users/licode/followers","following_url":"https://api.github.com/users/licode/following{/other_user}","gists_url":"https://api.github.com/users/licode/gists{/gist_id}","starred_url":"https://api.github.com/users/licode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/licode/subscriptions","organizations_url":"https://api.github.com/users/licode/orgs","repos_url":"https://api.github.com/users/licode/repos","events_url":"https://api.github.com/users/licode/events{/privacy}","received_events_url":"https://api.github.com/users/licode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/licode/scikit-xray","description":"Core repository for tools at NSLS-II","fork":true,"url":"https://api.github.com/repos/licode/scikit-xray","forks_url":"https://api.github.com/repos/licode/scikit-xray/forks","keys_url":"https://api.github.com/repos/licode/scikit-xray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/licode/scikit-xray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/licode/scikit-xray/teams","hooks_url":"https://api.github.com/repos/licode/scikit-xray/hooks","issue_events_url":"https://api.github.com/repos/licode/scikit-xray/issues/events{/number}","events_url":"https://api.github.com/repos/licode/scikit-xray/events","assignees_url":"https://api.github.com/repos/licode/scikit-xray/assignees{/user}","branches_url":"https://api.github.com/repos/licode/scikit-xray/branches{/branch}","tags_url":"https://api.github.com/repos/licode/scikit-xray/tags","blobs_url":"https://api.github.com/repos/licode/scikit-xray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/licode/scikit-xray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/licode/scikit-xray/git/refs{/sha}","trees_url":"https://api.github.com/repos/licode/scikit-xray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/licode/scikit-xray/statuses/{sha}","languages_url":"https://api.github.com/repos/licode/scikit-xray/languages","stargazers_url":"https://api.github.com/repos/licode/scikit-xray/stargazers","contributors_url":"https://api.github.com/repos/licode/scikit-xray/contributors","subscribers_url":"https://api.github.com/repos/licode/scikit-xray/subscribers","subscription_url":"https://api.github.com/repos/licode/scikit-xray/subscription","commits_url":"https://api.github.com/repos/licode/scikit-xray/commits{/sha}","git_commits_url":"https://api.github.com/repos/licode/scikit-xray/git/commits{/sha}","comments_url":"https://api.github.com/repos/licode/scikit-xray/comments{/number}","issue_comment_url":"https://api.github.com/repos/licode/scikit-xray/issues/comments{/number}","contents_url":"https://api.github.com/repos/licode/scikit-xray/contents/{+path}","compare_url":"https://api.github.com/repos/licode/scikit-xray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/licode/scikit-xray/merges","archive_url":"https://api.github.com/repos/licode/scikit-xray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/licode/scikit-xray/downloads","issues_url":"https://api.github.com/repos/licode/scikit-xray/issues{/number}","pulls_url":"https://api.github.com/repos/licode/scikit-xray/pulls{/number}","milestones_url":"https://api.github.com/repos/licode/scikit-xray/milestones{/number}","notifications_url":"https://api.github.com/repos/licode/scikit-xray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/licode/scikit-xray/labels{/name}","releases_url":"https://api.github.com/repos/licode/scikit-xray/releases{/id}","created_at":"2014-07-14T17:21:50Z","updated_at":"2014-12-11T21:33:42Z","pushed_at":"2015-02-03T05:02:50Z","git_url":"git://github.com/licode/scikit-xray.git","ssh_url":"git@github.com:licode/scikit-xray.git","clone_url":"https://github.com/licode/scikit-xray.git","svn_url":"https://github.com/licode/scikit-xray","homepage":"","size":1785,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Nikea:master","ref":"master","sha":"e6600b8aa4a175077f61e3e143273cd2b9c5032f","user":{"login":"Nikea","id":7108465,"avatar_url":"https://avatars.githubusercontent.com/u/7108465?v=3","gravatar_id":"","url":"https://api.github.com/users/Nikea","html_url":"https://github.com/Nikea","followers_url":"https://api.github.com/users/Nikea/followers","following_url":"https://api.github.com/users/Nikea/following{/other_user}","gists_url":"https://api.github.com/users/Nikea/gists{/gist_id}","starred_url":"https://api.github.com/users/Nikea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nikea/subscriptions","organizations_url":"https://api.github.com/users/Nikea/orgs","repos_url":"https://api.github.com/users/Nikea/repos","events_url":"https://api.github.com/users/Nikea/events{/privacy}","received_events_url":"https://api.github.com/users/Nikea/received_events","type":"Organization","site_admin":false},"repo":{"id":21679569,"name":"scikit-xray","full_name":"Nikea/scikit-xray","owner":{"login":"Nikea","id":7108465,"avatar_url":"https://avatars.githubusercontent.com/u/7108465?v=3","gravatar_id":"","url":"https://api.github.com/users/Nikea","html_url":"https://github.com/Nikea","followers_url":"https://api.github.com/users/Nikea/followers","following_url":"https://api.github.com/users/Nikea/following{/other_user}","gists_url":"https://api.github.com/users/Nikea/gists{/gist_id}","starred_url":"https://api.github.com/users/Nikea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nikea/subscriptions","organizations_url":"https://api.github.com/users/Nikea/orgs","repos_url":"https://api.github.com/users/Nikea/repos","events_url":"https://api.github.com/users/Nikea/events{/privacy}","received_events_url":"https://api.github.com/users/Nikea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nikea/scikit-xray","description":"Data analysis tools for X-ray science","fork":false,"url":"https://api.github.com/repos/Nikea/scikit-xray","forks_url":"https://api.github.com/repos/Nikea/scikit-xray/forks","keys_url":"https://api.github.com/repos/Nikea/scikit-xray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nikea/scikit-xray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nikea/scikit-xray/teams","hooks_url":"https://api.github.com/repos/Nikea/scikit-xray/hooks","issue_events_url":"https://api.github.com/repos/Nikea/scikit-xray/issues/events{/number}","events_url":"https://api.github.com/repos/Nikea/scikit-xray/events","assignees_url":"https://api.github.com/repos/Nikea/scikit-xray/assignees{/user}","branches_url":"https://api.github.com/repos/Nikea/scikit-xray/branches{/branch}","tags_url":"https://api.github.com/repos/Nikea/scikit-xray/tags","blobs_url":"https://api.github.com/repos/Nikea/scikit-xray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nikea/scikit-xray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nikea/scikit-xray/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nikea/scikit-xray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nikea/scikit-xray/statuses/{sha}","languages_url":"https://api.github.com/repos/Nikea/scikit-xray/languages","stargazers_url":"https://api.github.com/repos/Nikea/scikit-xray/stargazers","contributors_url":"https://api.github.com/repos/Nikea/scikit-xray/contributors","subscribers_url":"https://api.github.com/repos/Nikea/scikit-xray/subscribers","subscription_url":"https://api.github.com/repos/Nikea/scikit-xray/subscription","commits_url":"https://api.github.com/repos/Nikea/scikit-xray/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nikea/scikit-xray/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nikea/scikit-xray/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nikea/scikit-xray/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nikea/scikit-xray/contents/{+path}","compare_url":"https://api.github.com/repos/Nikea/scikit-xray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nikea/scikit-xray/merges","archive_url":"https://api.github.com/repos/Nikea/scikit-xray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nikea/scikit-xray/downloads","issues_url":"https://api.github.com/repos/Nikea/scikit-xray/issues{/number}","pulls_url":"https://api.github.com/repos/Nikea/scikit-xray/pulls{/number}","milestones_url":"https://api.github.com/repos/Nikea/scikit-xray/milestones{/number}","notifications_url":"https://api.github.com/repos/Nikea/scikit-xray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nikea/scikit-xray/labels{/name}","releases_url":"https://api.github.com/repos/Nikea/scikit-xray/releases{/id}","created_at":"2014-07-10T04:44:35Z","updated_at":"2015-02-20T17:33:08Z","pushed_at":"2015-02-20T17:33:07Z","git_url":"git://github.com/Nikea/scikit-xray.git","ssh_url":"git@github.com:Nikea/scikit-xray.git","clone_url":"https://github.com/Nikea/scikit-xray.git","svn_url":"https://github.com/Nikea/scikit-xray","homepage":"","size":20696,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":100,"forks":13,"open_issues":100,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158"},"html":{"href":"https://github.com/Nikea/scikit-xray/pull/158"},"issue":{"href":"https://api.github.com/repos/Nikea/scikit-xray/issues/158"},"comments":{"href":"https://api.github.com/repos/Nikea/scikit-xray/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/Nikea/scikit-xray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nikea/scikit-xray/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/Nikea/scikit-xray/statuses/26dc6abf3619047e461d9bb8926c61b792068e90"}}}}