{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/engwebUM/homework-week4/pulls/17","id":31209764,"html_url":"https://github.com/engwebUM/homework-week4/pull/17","diff_url":"https://github.com/engwebUM/homework-week4/pull/17.diff","patch_url":"https://github.com/engwebUM/homework-week4/pull/17.patch","issue_url":"https://api.github.com/repos/engwebUM/homework-week4/issues/17","number":17,"state":"closed","locked":false,"title":"homework-week4","user":{"login":"jmtalves","id":7840112,"avatar_url":"https://avatars.githubusercontent.com/u/7840112?v=3","gravatar_id":"","url":"https://api.github.com/users/jmtalves","html_url":"https://github.com/jmtalves","followers_url":"https://api.github.com/users/jmtalves/followers","following_url":"https://api.github.com/users/jmtalves/following{/other_user}","gists_url":"https://api.github.com/users/jmtalves/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtalves/subscriptions","organizations_url":"https://api.github.com/users/jmtalves/orgs","repos_url":"https://api.github.com/users/jmtalves/repos","events_url":"https://api.github.com/users/jmtalves/events{/privacy}","received_events_url":"https://api.github.com/users/jmtalves/received_events","type":"User","site_admin":false},"body":"In my previous solution I found some problems that need to be solved to have a clean code. My main errors were ifs chained  and methods with many lines.\r\nI decided to create methods to reduce ifs chained  and make smaller methods, trying not to exceed in exaggerated values the 5 lines.\r\nAfter solving these problems I came across one that was \"large class\" that is why separated in several classes. In separation I was careful to introduce only a responsibility by class.\r\n","created_at":"2015-03-15T23:33:37Z","updated_at":"2015-03-16T01:03:57Z","closed_at":"2015-03-16T01:03:57Z","merged_at":null,"merge_commit_sha":"06f4ff53b22290fa4004266709ec460c870caaf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/engwebUM/homework-week4/pulls/17/commits","review_comments_url":"https://api.github.com/repos/engwebUM/homework-week4/pulls/17/comments","review_comment_url":"https://api.github.com/repos/engwebUM/homework-week4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/engwebUM/homework-week4/issues/17/comments","statuses_url":"https://api.github.com/repos/engwebUM/homework-week4/statuses/55d5b19b2fa237b803fe0aa7cbe8c18540c87a5c","head":{"label":"jmtalves:master","ref":"master","sha":"55d5b19b2fa237b803fe0aa7cbe8c18540c87a5c","user":{"login":"jmtalves","id":7840112,"avatar_url":"https://avatars.githubusercontent.com/u/7840112?v=3","gravatar_id":"","url":"https://api.github.com/users/jmtalves","html_url":"https://github.com/jmtalves","followers_url":"https://api.github.com/users/jmtalves/followers","following_url":"https://api.github.com/users/jmtalves/following{/other_user}","gists_url":"https://api.github.com/users/jmtalves/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtalves/subscriptions","organizations_url":"https://api.github.com/users/jmtalves/orgs","repos_url":"https://api.github.com/users/jmtalves/repos","events_url":"https://api.github.com/users/jmtalves/events{/privacy}","received_events_url":"https://api.github.com/users/jmtalves/received_events","type":"User","site_admin":false},"repo":{"id":31925814,"name":"homework-week4","full_name":"jmtalves/homework-week4","owner":{"login":"jmtalves","id":7840112,"avatar_url":"https://avatars.githubusercontent.com/u/7840112?v=3","gravatar_id":"","url":"https://api.github.com/users/jmtalves","html_url":"https://github.com/jmtalves","followers_url":"https://api.github.com/users/jmtalves/followers","following_url":"https://api.github.com/users/jmtalves/following{/other_user}","gists_url":"https://api.github.com/users/jmtalves/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtalves/subscriptions","organizations_url":"https://api.github.com/users/jmtalves/orgs","repos_url":"https://api.github.com/users/jmtalves/repos","events_url":"https://api.github.com/users/jmtalves/events{/privacy}","received_events_url":"https://api.github.com/users/jmtalves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmtalves/homework-week4","description":"Homework for the fourth week of the Web Engineering course of MEI.","fork":true,"url":"https://api.github.com/repos/jmtalves/homework-week4","forks_url":"https://api.github.com/repos/jmtalves/homework-week4/forks","keys_url":"https://api.github.com/repos/jmtalves/homework-week4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmtalves/homework-week4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmtalves/homework-week4/teams","hooks_url":"https://api.github.com/repos/jmtalves/homework-week4/hooks","issue_events_url":"https://api.github.com/repos/jmtalves/homework-week4/issues/events{/number}","events_url":"https://api.github.com/repos/jmtalves/homework-week4/events","assignees_url":"https://api.github.com/repos/jmtalves/homework-week4/assignees{/user}","branches_url":"https://api.github.com/repos/jmtalves/homework-week4/branches{/branch}","tags_url":"https://api.github.com/repos/jmtalves/homework-week4/tags","blobs_url":"https://api.github.com/repos/jmtalves/homework-week4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmtalves/homework-week4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmtalves/homework-week4/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmtalves/homework-week4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmtalves/homework-week4/statuses/{sha}","languages_url":"https://api.github.com/repos/jmtalves/homework-week4/languages","stargazers_url":"https://api.github.com/repos/jmtalves/homework-week4/stargazers","contributors_url":"https://api.github.com/repos/jmtalves/homework-week4/contributors","subscribers_url":"https://api.github.com/repos/jmtalves/homework-week4/subscribers","subscription_url":"https://api.github.com/repos/jmtalves/homework-week4/subscription","commits_url":"https://api.github.com/repos/jmtalves/homework-week4/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmtalves/homework-week4/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmtalves/homework-week4/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmtalves/homework-week4/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmtalves/homework-week4/contents/{+path}","compare_url":"https://api.github.com/repos/jmtalves/homework-week4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmtalves/homework-week4/merges","archive_url":"https://api.github.com/repos/jmtalves/homework-week4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmtalves/homework-week4/downloads","issues_url":"https://api.github.com/repos/jmtalves/homework-week4/issues{/number}","pulls_url":"https://api.github.com/repos/jmtalves/homework-week4/pulls{/number}","milestones_url":"https://api.github.com/repos/jmtalves/homework-week4/milestones{/number}","notifications_url":"https://api.github.com/repos/jmtalves/homework-week4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmtalves/homework-week4/labels{/name}","releases_url":"https://api.github.com/repos/jmtalves/homework-week4/releases{/id}","created_at":"2015-03-09T22:19:55Z","updated_at":"2015-03-13T22:29:32Z","pushed_at":"2015-03-13T22:29:32Z","git_url":"git://github.com/jmtalves/homework-week4.git","ssh_url":"git@github.com:jmtalves/homework-week4.git","clone_url":"https://github.com/jmtalves/homework-week4.git","svn_url":"https://github.com/jmtalves/homework-week4","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"engwebUM:master","ref":"master","sha":"f432160ef9252ba4d54a84683cca25ba0c33368e","user":{"login":"engwebUM","id":11021540,"avatar_url":"https://avatars.githubusercontent.com/u/11021540?v=3","gravatar_id":"","url":"https://api.github.com/users/engwebUM","html_url":"https://github.com/engwebUM","followers_url":"https://api.github.com/users/engwebUM/followers","following_url":"https://api.github.com/users/engwebUM/following{/other_user}","gists_url":"https://api.github.com/users/engwebUM/gists{/gist_id}","starred_url":"https://api.github.com/users/engwebUM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engwebUM/subscriptions","organizations_url":"https://api.github.com/users/engwebUM/orgs","repos_url":"https://api.github.com/users/engwebUM/repos","events_url":"https://api.github.com/users/engwebUM/events{/privacy}","received_events_url":"https://api.github.com/users/engwebUM/received_events","type":"Organization","site_admin":false},"repo":{"id":31917419,"name":"homework-week4","full_name":"engwebUM/homework-week4","owner":{"login":"engwebUM","id":11021540,"avatar_url":"https://avatars.githubusercontent.com/u/11021540?v=3","gravatar_id":"","url":"https://api.github.com/users/engwebUM","html_url":"https://github.com/engwebUM","followers_url":"https://api.github.com/users/engwebUM/followers","following_url":"https://api.github.com/users/engwebUM/following{/other_user}","gists_url":"https://api.github.com/users/engwebUM/gists{/gist_id}","starred_url":"https://api.github.com/users/engwebUM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engwebUM/subscriptions","organizations_url":"https://api.github.com/users/engwebUM/orgs","repos_url":"https://api.github.com/users/engwebUM/repos","events_url":"https://api.github.com/users/engwebUM/events{/privacy}","received_events_url":"https://api.github.com/users/engwebUM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/engwebUM/homework-week4","description":"Homework for the fourth week of the Web Engineering course of MEI.","fork":false,"url":"https://api.github.com/repos/engwebUM/homework-week4","forks_url":"https://api.github.com/repos/engwebUM/homework-week4/forks","keys_url":"https://api.github.com/repos/engwebUM/homework-week4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/engwebUM/homework-week4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/engwebUM/homework-week4/teams","hooks_url":"https://api.github.com/repos/engwebUM/homework-week4/hooks","issue_events_url":"https://api.github.com/repos/engwebUM/homework-week4/issues/events{/number}","events_url":"https://api.github.com/repos/engwebUM/homework-week4/events","assignees_url":"https://api.github.com/repos/engwebUM/homework-week4/assignees{/user}","branches_url":"https://api.github.com/repos/engwebUM/homework-week4/branches{/branch}","tags_url":"https://api.github.com/repos/engwebUM/homework-week4/tags","blobs_url":"https://api.github.com/repos/engwebUM/homework-week4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/engwebUM/homework-week4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/engwebUM/homework-week4/git/refs{/sha}","trees_url":"https://api.github.com/repos/engwebUM/homework-week4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/engwebUM/homework-week4/statuses/{sha}","languages_url":"https://api.github.com/repos/engwebUM/homework-week4/languages","stargazers_url":"https://api.github.com/repos/engwebUM/homework-week4/stargazers","contributors_url":"https://api.github.com/repos/engwebUM/homework-week4/contributors","subscribers_url":"https://api.github.com/repos/engwebUM/homework-week4/subscribers","subscription_url":"https://api.github.com/repos/engwebUM/homework-week4/subscription","commits_url":"https://api.github.com/repos/engwebUM/homework-week4/commits{/sha}","git_commits_url":"https://api.github.com/repos/engwebUM/homework-week4/git/commits{/sha}","comments_url":"https://api.github.com/repos/engwebUM/homework-week4/comments{/number}","issue_comment_url":"https://api.github.com/repos/engwebUM/homework-week4/issues/comments{/number}","contents_url":"https://api.github.com/repos/engwebUM/homework-week4/contents/{+path}","compare_url":"https://api.github.com/repos/engwebUM/homework-week4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/engwebUM/homework-week4/merges","archive_url":"https://api.github.com/repos/engwebUM/homework-week4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/engwebUM/homework-week4/downloads","issues_url":"https://api.github.com/repos/engwebUM/homework-week4/issues{/number}","pulls_url":"https://api.github.com/repos/engwebUM/homework-week4/pulls{/number}","milestones_url":"https://api.github.com/repos/engwebUM/homework-week4/milestones{/number}","notifications_url":"https://api.github.com/repos/engwebUM/homework-week4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/engwebUM/homework-week4/labels{/name}","releases_url":"https://api.github.com/repos/engwebUM/homework-week4/releases{/id}","created_at":"2015-03-09T19:12:28Z","updated_at":"2015-03-09T19:12:28Z","pushed_at":"2015-03-09T19:17:45Z","git_url":"git://github.com/engwebUM/homework-week4.git","ssh_url":"git@github.com:engwebUM/homework-week4.git","clone_url":"https://github.com/engwebUM/homework-week4.git","svn_url":"https://github.com/engwebUM/homework-week4","homepage":null,"size":569,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":16,"forks":20,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/engwebUM/homework-week4/pulls/17"},"html":{"href":"https://github.com/engwebUM/homework-week4/pull/17"},"issue":{"href":"https://api.github.com/repos/engwebUM/homework-week4/issues/17"},"comments":{"href":"https://api.github.com/repos/engwebUM/homework-week4/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/engwebUM/homework-week4/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/engwebUM/homework-week4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/engwebUM/homework-week4/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/engwebUM/homework-week4/statuses/55d5b19b2fa237b803fe0aa7cbe8c18540c87a5c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":217,"deletions":0,"changed_files":6}}