{"action":"closed","number":1095,"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/1095","id":28336978,"html_url":"https://github.com/micropython/micropython/pull/1095","diff_url":"https://github.com/micropython/micropython/pull/1095.diff","patch_url":"https://github.com/micropython/micropython/pull/1095.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/1095","number":1095,"state":"closed","locked":false,"title":"Adding onewire support","user":{"login":"jdhildeb","id":10425781,"avatar_url":"https://avatars.githubusercontent.com/u/10425781?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhildeb","html_url":"https://github.com/jdhildeb","followers_url":"https://api.github.com/users/jdhildeb/followers","following_url":"https://api.github.com/users/jdhildeb/following{/other_user}","gists_url":"https://api.github.com/users/jdhildeb/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhildeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhildeb/subscriptions","organizations_url":"https://api.github.com/users/jdhildeb/orgs","repos_url":"https://api.github.com/users/jdhildeb/repos","events_url":"https://api.github.com/users/jdhildeb/events{/privacy}","received_events_url":"https://api.github.com/users/jdhildeb/received_events","type":"User","site_admin":false},"body":"I've begun working on onewire support for micropython.  I started in pure python but couldn't get the timing tight enough so ended up porting an existing onewire library to micropython.\r\n\r\nThere are still some to-dos of course, but it's working in simple tests (see the example python code).\r\n\r\nOne question at this point - does it make sense to refactor and move this code to the drivers directory?  (i.e. to decouple from stmhal).  I'm not sure what the approach should be to make this more useful for the other ports, but after looking around the codebase that is that I think makes sense - please confirm.\r\n\r\n\r\n","created_at":"2015-01-30T04:09:59Z","updated_at":"2015-03-03T01:31:52Z","closed_at":"2015-03-03T01:31:52Z","merged_at":null,"merge_commit_sha":"4d61b57d1f63cee6127e786c6322ec66bff07ead","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/1095/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/1095/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/1095/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/05a74b7c5028619ddccbcdda499167594caea63e","head":{"label":"jdhildeb:master","ref":"master","sha":"05a74b7c5028619ddccbcdda499167594caea63e","user":{"login":"jdhildeb","id":10425781,"avatar_url":"https://avatars.githubusercontent.com/u/10425781?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhildeb","html_url":"https://github.com/jdhildeb","followers_url":"https://api.github.com/users/jdhildeb/followers","following_url":"https://api.github.com/users/jdhildeb/following{/other_user}","gists_url":"https://api.github.com/users/jdhildeb/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhildeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhildeb/subscriptions","organizations_url":"https://api.github.com/users/jdhildeb/orgs","repos_url":"https://api.github.com/users/jdhildeb/repos","events_url":"https://api.github.com/users/jdhildeb/events{/privacy}","received_events_url":"https://api.github.com/users/jdhildeb/received_events","type":"User","site_admin":false},"repo":{"id":30001189,"name":"micropython","full_name":"jdhildeb/micropython","owner":{"login":"jdhildeb","id":10425781,"avatar_url":"https://avatars.githubusercontent.com/u/10425781?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhildeb","html_url":"https://github.com/jdhildeb","followers_url":"https://api.github.com/users/jdhildeb/followers","following_url":"https://api.github.com/users/jdhildeb/following{/other_user}","gists_url":"https://api.github.com/users/jdhildeb/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhildeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhildeb/subscriptions","organizations_url":"https://api.github.com/users/jdhildeb/orgs","repos_url":"https://api.github.com/users/jdhildeb/repos","events_url":"https://api.github.com/users/jdhildeb/events{/privacy}","received_events_url":"https://api.github.com/users/jdhildeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdhildeb/micropython","description":"The Micro Python project","fork":true,"url":"https://api.github.com/repos/jdhildeb/micropython","forks_url":"https://api.github.com/repos/jdhildeb/micropython/forks","keys_url":"https://api.github.com/repos/jdhildeb/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdhildeb/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdhildeb/micropython/teams","hooks_url":"https://api.github.com/repos/jdhildeb/micropython/hooks","issue_events_url":"https://api.github.com/repos/jdhildeb/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/jdhildeb/micropython/events","assignees_url":"https://api.github.com/repos/jdhildeb/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/jdhildeb/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/jdhildeb/micropython/tags","blobs_url":"https://api.github.com/repos/jdhildeb/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdhildeb/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdhildeb/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdhildeb/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdhildeb/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/jdhildeb/micropython/languages","stargazers_url":"https://api.github.com/repos/jdhildeb/micropython/stargazers","contributors_url":"https://api.github.com/repos/jdhildeb/micropython/contributors","subscribers_url":"https://api.github.com/repos/jdhildeb/micropython/subscribers","subscription_url":"https://api.github.com/repos/jdhildeb/micropython/subscription","commits_url":"https://api.github.com/repos/jdhildeb/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdhildeb/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdhildeb/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdhildeb/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdhildeb/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/jdhildeb/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdhildeb/micropython/merges","archive_url":"https://api.github.com/repos/jdhildeb/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdhildeb/micropython/downloads","issues_url":"https://api.github.com/repos/jdhildeb/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/jdhildeb/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/jdhildeb/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/jdhildeb/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdhildeb/micropython/labels{/name}","releases_url":"https://api.github.com/repos/jdhildeb/micropython/releases{/id}","created_at":"2015-01-29T03:11:10Z","updated_at":"2015-02-23T05:21:35Z","pushed_at":"2015-02-23T05:21:35Z","git_url":"git://github.com/jdhildeb/micropython.git","ssh_url":"git@github.com:jdhildeb/micropython.git","clone_url":"https://github.com/jdhildeb/micropython.git","svn_url":"https://github.com/jdhildeb/micropython","homepage":null,"size":15614,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"d01060241a2102878a2b6ff270323e7d278f0af8","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"The Micro Python project","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","created_at":"2013-12-20T11:47:07Z","updated_at":"2015-03-03T01:30:27Z","pushed_at":"2015-03-03T01:30:27Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":null,"size":41135,"stargazers_count":1617,"watchers_count":1617,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"open_issues_count":114,"forks":274,"open_issues":114,"watchers":1617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1095"},"html":{"href":"https://github.com/micropython/micropython/pull/1095"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/1095"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/1095/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1095/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1095/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/05a74b7c5028619ddccbcdda499167594caea63e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":21,"review_comments":2,"commits":9,"additions":522,"deletions":0,"changed_files":2}}