{"action":"created","comment":{"url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/comments/34404673","id":34404673,"diff_hunk":"@@ -11,6 +13,7 @@ export interface FileStatus {\n \n let fileStatuses: { [index: string]: FileStatus } = {};\n export function getFileStatus(filePath: string): FileStatus {\n+    filePath = path.normalize(filePath);","path":"lib/main/atom/fileStatusCache.ts","position":13,"original_position":13,"commit_id":"1bbcd9c24e6ed9481f596d89ba9195eb6ec27072","original_commit_id":"1bbcd9c24e6ed9481f596d89ba9195eb6ec27072","user":{"login":"basarat","id":874898,"avatar_url":"https://avatars.githubusercontent.com/u/874898?v=3","gravatar_id":"","url":"https://api.github.com/users/basarat","html_url":"https://github.com/basarat","followers_url":"https://api.github.com/users/basarat/followers","following_url":"https://api.github.com/users/basarat/following{/other_user}","gists_url":"https://api.github.com/users/basarat/gists{/gist_id}","starred_url":"https://api.github.com/users/basarat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basarat/subscriptions","organizations_url":"https://api.github.com/users/basarat/orgs","repos_url":"https://api.github.com/users/basarat/repos","events_url":"https://api.github.com/users/basarat/events{/privacy}","received_events_url":"https://api.github.com/users/basarat/received_events","type":"User","site_admin":false},"body":"Prefer `consistentPath` https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/utils/fsUtil.ts#L5-L8 i.e. `/` *everywhere*. This is what the TypeScript compiler does *internally*. We have a bit of a dance as atom works one way, and typescript the other.","created_at":"2015-07-10T23:27:24Z","updated_at":"2015-07-10T23:27:24Z","html_url":"https://github.com/TypeStrong/atom-typescript/pull/457#discussion_r34404673","pull_request_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/comments/34404673"},"html":{"href":"https://github.com/TypeStrong/atom-typescript/pull/457#discussion_r34404673"},"pull_request":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457","id":39720401,"html_url":"https://github.com/TypeStrong/atom-typescript/pull/457","diff_url":"https://github.com/TypeStrong/atom-typescript/pull/457.diff","patch_url":"https://github.com/TypeStrong/atom-typescript/pull/457.patch","issue_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/457","number":457,"state":"open","locked":false,"title":"Update file statuses on \"TypeScript: Build\" command","user":{"login":"helarqjsc","id":1840047,"avatar_url":"https://avatars.githubusercontent.com/u/1840047?v=3","gravatar_id":"","url":"https://api.github.com/users/helarqjsc","html_url":"https://github.com/helarqjsc","followers_url":"https://api.github.com/users/helarqjsc/followers","following_url":"https://api.github.com/users/helarqjsc/following{/other_user}","gists_url":"https://api.github.com/users/helarqjsc/gists{/gist_id}","starred_url":"https://api.github.com/users/helarqjsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helarqjsc/subscriptions","organizations_url":"https://api.github.com/users/helarqjsc/orgs","repos_url":"https://api.github.com/users/helarqjsc/repos","events_url":"https://api.github.com/users/helarqjsc/events{/privacy}","received_events_url":"https://api.github.com/users/helarqjsc/received_events","type":"User","site_admin":false},"body":"Currently a file status is only updated on save, after this PR build will also change it.\r\nI've added `path.normalize` to `getFileStatus`, because on Windows it would sometimes get a path as \"C:\\xampp\\htdocs\\atom-typescript\\lib\\main\\atomts.ts\", sometimes as \"C:/xampp/htdocs/atom-typescript/lib/main/atomts.ts\" and they would be considered different files with different statuses. Now this should be fixed.\r\nAlso, during my test runs of \"TypeScript: Build\" some js files got updated. I haven't changed the corresponding ts files, so I guess it's fine and they have the right content now? It's weird that the js files weren't up to date in the master branch. Please, tell me if I shouldn't have pushed those files here.","created_at":"2015-07-10T20:16:56Z","updated_at":"2015-07-10T23:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1ffa6dbc1d183a3eb7c4639194bdef1f4ef9538","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457/commits","review_comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457/comments","review_comment_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/457/comments","statuses_url":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/1bbcd9c24e6ed9481f596d89ba9195eb6ec27072","head":{"label":"helarqjsc:build-updates-file-status","ref":"build-updates-file-status","sha":"1bbcd9c24e6ed9481f596d89ba9195eb6ec27072","user":{"login":"helarqjsc","id":1840047,"avatar_url":"https://avatars.githubusercontent.com/u/1840047?v=3","gravatar_id":"","url":"https://api.github.com/users/helarqjsc","html_url":"https://github.com/helarqjsc","followers_url":"https://api.github.com/users/helarqjsc/followers","following_url":"https://api.github.com/users/helarqjsc/following{/other_user}","gists_url":"https://api.github.com/users/helarqjsc/gists{/gist_id}","starred_url":"https://api.github.com/users/helarqjsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helarqjsc/subscriptions","organizations_url":"https://api.github.com/users/helarqjsc/orgs","repos_url":"https://api.github.com/users/helarqjsc/repos","events_url":"https://api.github.com/users/helarqjsc/events{/privacy}","received_events_url":"https://api.github.com/users/helarqjsc/received_events","type":"User","site_admin":false},"repo":{"id":37973355,"name":"atom-typescript","full_name":"helarqjsc/atom-typescript","owner":{"login":"helarqjsc","id":1840047,"avatar_url":"https://avatars.githubusercontent.com/u/1840047?v=3","gravatar_id":"","url":"https://api.github.com/users/helarqjsc","html_url":"https://github.com/helarqjsc","followers_url":"https://api.github.com/users/helarqjsc/followers","following_url":"https://api.github.com/users/helarqjsc/following{/other_user}","gists_url":"https://api.github.com/users/helarqjsc/gists{/gist_id}","starred_url":"https://api.github.com/users/helarqjsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helarqjsc/subscriptions","organizations_url":"https://api.github.com/users/helarqjsc/orgs","repos_url":"https://api.github.com/users/helarqjsc/repos","events_url":"https://api.github.com/users/helarqjsc/events{/privacy}","received_events_url":"https://api.github.com/users/helarqjsc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helarqjsc/atom-typescript","description":"The only TypeScript package you will ever need","fork":true,"url":"https://api.github.com/repos/helarqjsc/atom-typescript","forks_url":"https://api.github.com/repos/helarqjsc/atom-typescript/forks","keys_url":"https://api.github.com/repos/helarqjsc/atom-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helarqjsc/atom-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helarqjsc/atom-typescript/teams","hooks_url":"https://api.github.com/repos/helarqjsc/atom-typescript/hooks","issue_events_url":"https://api.github.com/repos/helarqjsc/atom-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/helarqjsc/atom-typescript/events","assignees_url":"https://api.github.com/repos/helarqjsc/atom-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/helarqjsc/atom-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/helarqjsc/atom-typescript/tags","blobs_url":"https://api.github.com/repos/helarqjsc/atom-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helarqjsc/atom-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helarqjsc/atom-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/helarqjsc/atom-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helarqjsc/atom-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/helarqjsc/atom-typescript/languages","stargazers_url":"https://api.github.com/repos/helarqjsc/atom-typescript/stargazers","contributors_url":"https://api.github.com/repos/helarqjsc/atom-typescript/contributors","subscribers_url":"https://api.github.com/repos/helarqjsc/atom-typescript/subscribers","subscription_url":"https://api.github.com/repos/helarqjsc/atom-typescript/subscription","commits_url":"https://api.github.com/repos/helarqjsc/atom-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/helarqjsc/atom-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/helarqjsc/atom-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/helarqjsc/atom-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/helarqjsc/atom-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/helarqjsc/atom-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helarqjsc/atom-typescript/merges","archive_url":"https://api.github.com/repos/helarqjsc/atom-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helarqjsc/atom-typescript/downloads","issues_url":"https://api.github.com/repos/helarqjsc/atom-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/helarqjsc/atom-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/helarqjsc/atom-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/helarqjsc/atom-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helarqjsc/atom-typescript/labels{/name}","releases_url":"https://api.github.com/repos/helarqjsc/atom-typescript/releases{/id}","created_at":"2015-06-24T08:51:14Z","updated_at":"2015-06-24T08:51:15Z","pushed_at":"2015-07-10T20:15:11Z","git_url":"git://github.com/helarqjsc/atom-typescript.git","ssh_url":"git@github.com:helarqjsc/atom-typescript.git","clone_url":"https://github.com/helarqjsc/atom-typescript.git","svn_url":"https://github.com/helarqjsc/atom-typescript","homepage":"https://atom.io/packages/atom-typescript","size":21151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TypeStrong:master","ref":"master","sha":"a2dfa066c2d9962d91a84774012e092fbc7cba54","user":{"login":"TypeStrong","id":6759814,"avatar_url":"https://avatars.githubusercontent.com/u/6759814?v=3","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"repo":{"id":21060126,"name":"atom-typescript","full_name":"TypeStrong/atom-typescript","owner":{"login":"TypeStrong","id":6759814,"avatar_url":"https://avatars.githubusercontent.com/u/6759814?v=3","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TypeStrong/atom-typescript","description":"The only TypeScript package you will ever need","fork":false,"url":"https://api.github.com/repos/TypeStrong/atom-typescript","forks_url":"https://api.github.com/repos/TypeStrong/atom-typescript/forks","keys_url":"https://api.github.com/repos/TypeStrong/atom-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypeStrong/atom-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypeStrong/atom-typescript/teams","hooks_url":"https://api.github.com/repos/TypeStrong/atom-typescript/hooks","issue_events_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/TypeStrong/atom-typescript/events","assignees_url":"https://api.github.com/repos/TypeStrong/atom-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/TypeStrong/atom-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/TypeStrong/atom-typescript/tags","blobs_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/TypeStrong/atom-typescript/languages","stargazers_url":"https://api.github.com/repos/TypeStrong/atom-typescript/stargazers","contributors_url":"https://api.github.com/repos/TypeStrong/atom-typescript/contributors","subscribers_url":"https://api.github.com/repos/TypeStrong/atom-typescript/subscribers","subscription_url":"https://api.github.com/repos/TypeStrong/atom-typescript/subscription","commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypeStrong/atom-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypeStrong/atom-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypeStrong/atom-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/TypeStrong/atom-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypeStrong/atom-typescript/merges","archive_url":"https://api.github.com/repos/TypeStrong/atom-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypeStrong/atom-typescript/downloads","issues_url":"https://api.github.com/repos/TypeStrong/atom-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/TypeStrong/atom-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/TypeStrong/atom-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypeStrong/atom-typescript/labels{/name}","releases_url":"https://api.github.com/repos/TypeStrong/atom-typescript/releases{/id}","created_at":"2014-06-21T04:14:41Z","updated_at":"2015-07-10T02:32:54Z","pushed_at":"2015-07-10T23:23:52Z","git_url":"git://github.com/TypeStrong/atom-typescript.git","ssh_url":"git@github.com:TypeStrong/atom-typescript.git","clone_url":"https://github.com/TypeStrong/atom-typescript.git","svn_url":"https://github.com/TypeStrong/atom-typescript","homepage":"https://atom.io/packages/atom-typescript","size":24323,"stargazers_count":205,"watchers_count":205,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":84,"forks":35,"open_issues":84,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457"},"html":{"href":"https://github.com/TypeStrong/atom-typescript/pull/457"},"issue":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/457"},"comments":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/TypeStrong/atom-typescript/statuses/1bbcd9c24e6ed9481f596d89ba9195eb6ec27072"}}}}