{"action":"created","comment":{"url":"https://api.github.com/repos/translate/pootle/pulls/comments/28577711","id":28577711,"diff_hunk":"@@ -1309,19 +1309,14 @@ class StoreManager(models.Manager):\n     def get_queryset(self):\n         \"\"\"Mimics `select_related(depth=1)` behavior. Pending review.\"\"\"\n         return super(StoreManager, self).get_queryset() \\\n-                                        .filter(obsolete=False) \\\n                                         .select_related(\n                                             'parent',\n                                             'translation_project',\n                                         )\n \n-    def with_obsolete(self):\n-        \"\"\"Mimics `select_related(depth=1)` behavior. Pending review.\"\"\"\n-        return super(StoreManager, self).get_queryset() \\\n-                                        .select_related(\n-                                            'parent',\n-                                            'translation_project',\n-                                        )\n+    def live(self):\n+        \"\"\"\"\"\"","path":"pootle/apps/pootle_store/models.py","position":18,"original_position":18,"commit_id":"0c603963099c4c1f0f668bdd88248b0669e7a2dc","original_commit_id":"0c603963099c4c1f0f668bdd88248b0669e7a2dc","user":{"login":"julen","id":16768,"avatar_url":"https://avatars.githubusercontent.com/u/16768?v=3","gravatar_id":"","url":"https://api.github.com/users/julen","html_url":"https://github.com/julen","followers_url":"https://api.github.com/users/julen/followers","following_url":"https://api.github.com/users/julen/following{/other_user}","gists_url":"https://api.github.com/users/julen/gists{/gist_id}","starred_url":"https://api.github.com/users/julen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julen/subscriptions","organizations_url":"https://api.github.com/users/julen/orgs","repos_url":"https://api.github.com/users/julen/repos","events_url":"https://api.github.com/users/julen/events{/privacy}","received_events_url":"https://api.github.com/users/julen/received_events","type":"User","site_admin":false},"body":"Please add something more valuable here.","created_at":"2015-04-17T08:27:20Z","updated_at":"2015-04-17T08:27:20Z","html_url":"https://github.com/translate/pootle/pull/3678#discussion_r28577711","pull_request_url":"https://api.github.com/repos/translate/pootle/pulls/3678","_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments/28577711"},"html":{"href":"https://github.com/translate/pootle/pull/3678#discussion_r28577711"},"pull_request":{"href":"https://api.github.com/repos/translate/pootle/pulls/3678"}}},"pull_request":{"url":"https://api.github.com/repos/translate/pootle/pulls/3678","id":33459603,"html_url":"https://github.com/translate/pootle/pull/3678","diff_url":"https://github.com/translate/pootle/pull/3678.diff","patch_url":"https://github.com/translate/pootle/pull/3678.patch","issue_url":"https://api.github.com/repos/translate/pootle/issues/3678","number":3678,"state":"open","locked":false,"title":"Use live() to retrieve non-obsolete Store and Directory objects","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"body":"Default managers for Store and Directory objects retrieve all objects (including obsoletes).\r\nFix #3675\r\n\r\n@julen, @jleclanche, @dwaynebailey , @unho please check if I have added `live()` where necessary. ","created_at":"2015-04-16T15:00:26Z","updated_at":"2015-04-17T08:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1497244a6ca532901cd0883790524e46d0a1027","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/translate/pootle/pulls/3678/commits","review_comments_url":"https://api.github.com/repos/translate/pootle/pulls/3678/comments","review_comment_url":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/translate/pootle/issues/3678/comments","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/0c603963099c4c1f0f668bdd88248b0669e7a2dc","head":{"label":"ta2-1:issue/3675","ref":"issue/3675","sha":"0c603963099c4c1f0f668bdd88248b0669e7a2dc","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"repo":{"id":8358664,"name":"pootle","full_name":"ta2-1/pootle","owner":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ta2-1/pootle","description":"Online translation tool","fork":true,"url":"https://api.github.com/repos/ta2-1/pootle","forks_url":"https://api.github.com/repos/ta2-1/pootle/forks","keys_url":"https://api.github.com/repos/ta2-1/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ta2-1/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ta2-1/pootle/teams","hooks_url":"https://api.github.com/repos/ta2-1/pootle/hooks","issue_events_url":"https://api.github.com/repos/ta2-1/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/ta2-1/pootle/events","assignees_url":"https://api.github.com/repos/ta2-1/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/ta2-1/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/ta2-1/pootle/tags","blobs_url":"https://api.github.com/repos/ta2-1/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ta2-1/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ta2-1/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ta2-1/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ta2-1/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/ta2-1/pootle/languages","stargazers_url":"https://api.github.com/repos/ta2-1/pootle/stargazers","contributors_url":"https://api.github.com/repos/ta2-1/pootle/contributors","subscribers_url":"https://api.github.com/repos/ta2-1/pootle/subscribers","subscription_url":"https://api.github.com/repos/ta2-1/pootle/subscription","commits_url":"https://api.github.com/repos/ta2-1/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ta2-1/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ta2-1/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ta2-1/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ta2-1/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/ta2-1/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ta2-1/pootle/merges","archive_url":"https://api.github.com/repos/ta2-1/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ta2-1/pootle/downloads","issues_url":"https://api.github.com/repos/ta2-1/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/ta2-1/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/ta2-1/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/ta2-1/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ta2-1/pootle/labels{/name}","releases_url":"https://api.github.com/repos/ta2-1/pootle/releases{/id}","created_at":"2013-02-22T14:19:00Z","updated_at":"2015-02-04T13:34:18Z","pushed_at":"2015-04-16T16:01:57Z","git_url":"git://github.com/ta2-1/pootle.git","ssh_url":"git@github.com:ta2-1/pootle.git","clone_url":"https://github.com/ta2-1/pootle.git","svn_url":"https://github.com/ta2-1/pootle","homepage":"http://pootle.translatehouse.org","size":57127,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"translate:master","ref":"master","sha":"c51fc6e7ea18aa6e7bdc0f91c2f1230d40327fe8","user":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"repo":{"id":3769702,"name":"pootle","full_name":"translate/pootle","owner":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/translate/pootle","description":"Online translation tool","fork":false,"url":"https://api.github.com/repos/translate/pootle","forks_url":"https://api.github.com/repos/translate/pootle/forks","keys_url":"https://api.github.com/repos/translate/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/translate/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/translate/pootle/teams","hooks_url":"https://api.github.com/repos/translate/pootle/hooks","issue_events_url":"https://api.github.com/repos/translate/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/translate/pootle/events","assignees_url":"https://api.github.com/repos/translate/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/translate/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/translate/pootle/tags","blobs_url":"https://api.github.com/repos/translate/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/translate/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/translate/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/translate/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/translate/pootle/languages","stargazers_url":"https://api.github.com/repos/translate/pootle/stargazers","contributors_url":"https://api.github.com/repos/translate/pootle/contributors","subscribers_url":"https://api.github.com/repos/translate/pootle/subscribers","subscription_url":"https://api.github.com/repos/translate/pootle/subscription","commits_url":"https://api.github.com/repos/translate/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/translate/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/translate/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/translate/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/translate/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/translate/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/translate/pootle/merges","archive_url":"https://api.github.com/repos/translate/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/translate/pootle/downloads","issues_url":"https://api.github.com/repos/translate/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/translate/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/translate/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/translate/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/translate/pootle/labels{/name}","releases_url":"https://api.github.com/repos/translate/pootle/releases{/id}","created_at":"2012-03-19T23:06:03Z","updated_at":"2015-04-17T06:39:07Z","pushed_at":"2015-04-17T06:39:07Z","git_url":"git://github.com/translate/pootle.git","ssh_url":"git@github.com:translate/pootle.git","clone_url":"https://github.com/translate/pootle.git","svn_url":"https://github.com/translate/pootle","homepage":"http://pootle.translatehouse.org","size":75472,"stargazers_count":430,"watchers_count":430,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":130,"mirror_url":null,"open_issues_count":437,"forks":130,"open_issues":437,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/3678"},"html":{"href":"https://github.com/translate/pootle/pull/3678"},"issue":{"href":"https://api.github.com/repos/translate/pootle/issues/3678"},"comments":{"href":"https://api.github.com/repos/translate/pootle/issues/3678/comments"},"review_comments":{"href":"https://api.github.com/repos/translate/pootle/pulls/3678/comments"},"review_comment":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/translate/pootle/pulls/3678/commits"},"statuses":{"href":"https://api.github.com/repos/translate/pootle/statuses/0c603963099c4c1f0f668bdd88248b0669e7a2dc"}}}}