{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/23865100","id":23865100,"diff_hunk":"@@ -37,15 +37,13 @@ func getDaemonConfDir() string {\n }\n \n var (\n-\tflVersion     = flag.Bool([]string{\"v\", \"-version\"}, false, \"Print version information and quit\")\n-\tflDaemon      = flag.Bool([]string{\"d\", \"-daemon\"}, false, \"Enable daemon mode\")\n-\tflDebug       = flag.Bool([]string{\"D\", \"-debug\"}, false, \"Enable debug mode\")\n-\tflSocketGroup = flag.String([]string{\"G\", \"-group\"}, \"docker\", \"Group to assign the unix socket specified by -H when running in daemon mode\\nuse '' (the empty string) to disable setting of a group\")\n-\tflLogLevel    = flag.String([]string{\"l\", \"-log-level\"}, \"info\", \"Set the logging level (debug, info, warn, error, fatal)\")\n-\tflEnableCors  = flag.Bool([]string{\"#api-enable-cors\", \"-api-enable-cors\"}, false, \"Enable CORS headers in the remote API\")\n-\tflTls         = flag.Bool([]string{\"-tls\"}, false, \"Use TLS; implied by --tlsverify flag\")\n-\tflHelp        = flag.Bool([]string{\"h\", \"-help\"}, false, \"Print usage\")\n-\tflTlsVerify   = flag.Bool([]string{\"-tlsverify\"}, dockerTlsVerify, \"Use TLS and verify the remote (daemon: verify client, client: verify daemon)\")\n+\tflVersion   = flag.Bool([]string{\"v\", \"-version\"}, false, \"Print version information and quit\")\n+\tflDaemon    = flag.Bool([]string{\"d\", \"-daemon\"}, false, \"Enable daemon mode\")\n+\tflDebug     = flag.Bool([]string{\"D\", \"-debug\"}, false, \"Enable debug mode\")","path":"docker/flags.go","position":15,"original_position":15,"commit_id":"73a0adc3d411d3fdc1eb4578918064849ed533d5","original_commit_id":"73a0adc3d411d3fdc1eb4578918064849ed533d5","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"body":"Where? The daemon is responsible for creating the socket and serving the API. These arguments don't apply to any other docker subcommands...","created_at":"2015-01-30T19:21:02Z","updated_at":"2015-01-30T19:21:02Z","html_url":"https://github.com/docker/docker/pull/10453#discussion_r23865100","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/10453","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/23865100"},"html":{"href":"https://github.com/docker/docker/pull/10453#discussion_r23865100"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/10453"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/10453","id":28334708,"html_url":"https://github.com/docker/docker/pull/10453","diff_url":"https://github.com/docker/docker/pull/10453.diff","patch_url":"https://github.com/docker/docker/pull/10453.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/10453","number":10453,"state":"open","locked":false,"title":"Move daemon-only flags into the daemon config struct","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-30T02:56:40Z","updated_at":"2015-01-30T19:21:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f9059a6df474bab8f4b6abb03f209919227c9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/10453/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/10453/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/10453/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/73a0adc3d411d3fdc1eb4578918064849ed533d5","head":{"label":"aidanhs:aphs-move-daemon-flags","ref":"aphs-move-daemon-flags","sha":"73a0adc3d411d3fdc1eb4578918064849ed533d5","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"repo":{"id":15942913,"name":"docker","full_name":"aidanhs/docker","owner":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aidanhs/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/aidanhs/docker","forks_url":"https://api.github.com/repos/aidanhs/docker/forks","keys_url":"https://api.github.com/repos/aidanhs/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aidanhs/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aidanhs/docker/teams","hooks_url":"https://api.github.com/repos/aidanhs/docker/hooks","issue_events_url":"https://api.github.com/repos/aidanhs/docker/issues/events{/number}","events_url":"https://api.github.com/repos/aidanhs/docker/events","assignees_url":"https://api.github.com/repos/aidanhs/docker/assignees{/user}","branches_url":"https://api.github.com/repos/aidanhs/docker/branches{/branch}","tags_url":"https://api.github.com/repos/aidanhs/docker/tags","blobs_url":"https://api.github.com/repos/aidanhs/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aidanhs/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aidanhs/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/aidanhs/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aidanhs/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/aidanhs/docker/languages","stargazers_url":"https://api.github.com/repos/aidanhs/docker/stargazers","contributors_url":"https://api.github.com/repos/aidanhs/docker/contributors","subscribers_url":"https://api.github.com/repos/aidanhs/docker/subscribers","subscription_url":"https://api.github.com/repos/aidanhs/docker/subscription","commits_url":"https://api.github.com/repos/aidanhs/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/aidanhs/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/aidanhs/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/aidanhs/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/aidanhs/docker/contents/{+path}","compare_url":"https://api.github.com/repos/aidanhs/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aidanhs/docker/merges","archive_url":"https://api.github.com/repos/aidanhs/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aidanhs/docker/downloads","issues_url":"https://api.github.com/repos/aidanhs/docker/issues{/number}","pulls_url":"https://api.github.com/repos/aidanhs/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/aidanhs/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/aidanhs/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aidanhs/docker/labels{/name}","releases_url":"https://api.github.com/repos/aidanhs/docker/releases{/id}","created_at":"2014-01-15T17:48:20Z","updated_at":"2015-01-30T02:57:50Z","pushed_at":"2015-01-30T03:04:18Z","git_url":"git://github.com/aidanhs/docker.git","ssh_url":"git@github.com:aidanhs/docker.git","clone_url":"https://github.com/aidanhs/docker.git","svn_url":"https://github.com/aidanhs/docker","homepage":"http://www.docker.io","size":40632,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"144ae9b0c70ace8eb2e0336c7a4f6c479774fda1","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-01-30T18:58:10Z","pushed_at":"2015-01-30T17:59:32Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":132073,"stargazers_count":18816,"watchers_count":18816,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3881,"mirror_url":null,"open_issues_count":999,"forks":3881,"open_issues":999,"watchers":18816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/10453"},"html":{"href":"https://github.com/docker/docker/pull/10453"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/10453"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/10453/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/10453/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/10453/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/73a0adc3d411d3fdc1eb4578918064849ed533d5"}}}}