{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eigen/pulls/comments/30654534","id":30654534,"diff_hunk":"@@ -2,6 +2,11 @@\n #import \"ARItemThumbnailViewCell.h\"\n #import \"ARReusableLoadingView.h\"\n \n+\n+@interface ARArtworkMasonryModule (Private)\n+- (void)updateLayoutForSize:(CGSize)size;","path":"Artsy/Classes/View Controllers/AREmbeddedModelsViewController.m","position":6,"original_position":6,"commit_id":"2913e202dc231fba4106d24cc503b410a3997ca6","original_commit_id":"2913e202dc231fba4106d24cc503b410a3997ca6","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=3","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"only place where this needs to be used","created_at":"2015-05-19T22:24:12Z","updated_at":"2015-05-19T22:24:12Z","html_url":"https://github.com/artsy/eigen/pull/456#discussion_r30654534","pull_request_url":"https://api.github.com/repos/artsy/eigen/pulls/456","_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments/30654534"},"html":{"href":"https://github.com/artsy/eigen/pull/456#discussion_r30654534"},"pull_request":{"href":"https://api.github.com/repos/artsy/eigen/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eigen/pulls/456","id":35781221,"html_url":"https://github.com/artsy/eigen/pull/456","diff_url":"https://github.com/artsy/eigen/pull/456.diff","patch_url":"https://github.com/artsy/eigen/pull/456.patch","issue_url":"https://api.github.com/repos/artsy/eigen/issues/456","number":456,"state":"open","locked":false,"title":"@orta -> fix shows view not using proper masonry layout","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=3","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"I noticed that when switching tabs, rotating, then switching back, the view that is about to appear still had the old frame size. This is because we were removing navigation controllers from their host when at tab is deselected. If you DON'T remove them and maintain each tab's navigation controller in the VC hierarchy, each tab can respond to rotation/size change events even when they are not visible, and they will also already have the correct view size when they are reselected.\r\n\r\nLet me know if you think there would be other problems with doing this. It makes rotation a whole lot easier to keep all the Nav Controllers in the hierarchy even when deselected.","created_at":"2015-05-19T22:21:51Z","updated_at":"2015-05-19T22:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32d3709599d07703693714db11f3295d81725aa1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eigen/pulls/456/commits","review_comments_url":"https://api.github.com/repos/artsy/eigen/pulls/456/comments","review_comment_url":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/eigen/issues/456/comments","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/2913e202dc231fba4106d24cc503b410a3997ca6","head":{"label":"artsy:collection-view","ref":"collection-view","sha":"2913e202dc231fba4106d24cc503b410a3997ca6","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","created_at":"2015-01-22T21:52:39Z","updated_at":"2015-05-17T18:54:40Z","pushed_at":"2015-05-19T22:21:52Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":45895,"stargazers_count":691,"watchers_count":691,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":114,"forks":86,"open_issues":114,"watchers":691,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"b3ab9348b1578f1b11a5d44c696387c5e7dc0a67","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","created_at":"2015-01-22T21:52:39Z","updated_at":"2015-05-17T18:54:40Z","pushed_at":"2015-05-19T22:21:52Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":45895,"stargazers_count":691,"watchers_count":691,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":114,"forks":86,"open_issues":114,"watchers":691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/456"},"html":{"href":"https://github.com/artsy/eigen/pull/456"},"issue":{"href":"https://api.github.com/repos/artsy/eigen/issues/456"},"comments":{"href":"https://api.github.com/repos/artsy/eigen/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eigen/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/eigen/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eigen/statuses/2913e202dc231fba4106d24cc503b410a3997ca6"}}}}