{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/41209404","id":41209404,"diff_hunk":"@@ -504,7 +504,7 @@ describe('ReactCompositeComponent', function() {\n       componentWillUnmount: function() {\n         // It's important that ReactMount.purgeID is called after any component\n         // lifecycle methods, because a componentWillMount implementation is","path":"src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js","position":3,"original_position":3,"commit_id":"30e0d4b0a304d67052689ce7a598a3f97ba6b264","original_commit_id":"30e0d4b0a304d67052689ce7a598a3f97ba6b264","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"Mind fixing this to say componentWillUnmount while you're at it?","created_at":"2015-10-05T23:08:21Z","updated_at":"2015-10-05T23:08:21Z","html_url":"https://github.com/facebook/react/pull/5056#discussion_r41209404","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/5056","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/41209404"},"html":{"href":"https://github.com/facebook/react/pull/5056#discussion_r41209404"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/5056"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/5056","id":46841676,"html_url":"https://github.com/facebook/react/pull/5056","diff_url":"https://github.com/facebook/react/pull/5056.diff","patch_url":"https://github.com/facebook/react/pull/5056.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/5056","number":5056,"state":"open","locked":false,"title":"React->ReactDOM in src/\n","user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"body":"React->ReactDOM in src/\n","created_at":"2015-10-05T22:20:23Z","updated_at":"2015-10-05T23:08:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42bb9ffaf21636848a2a9abcfb3324835be7f6fe","assignee":null,"milestone":{"url":"https://api.github.com/repos/facebook/react/milestones/13","html_url":"https://github.com/facebook/react/milestones/0.14","labels_url":"https://api.github.com/repos/facebook/react/milestones/13/labels","id":1035426,"number":13,"title":"0.14","description":null,"creator":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":66,"state":"open","created_at":"2015-03-23T23:33:55Z","updated_at":"2015-10-05T22:39:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/facebook/react/pulls/5056/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/5056/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/5056/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/30e0d4b0a304d67052689ce7a598a3f97ba6b264","head":{"label":"jimfb:reactdom-in-src","ref":"reactdom-in-src","sha":"30e0d4b0a304d67052689ce7a598a3f97ba6b264","user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"repo":{"id":26285889,"name":"react","full_name":"jimfb/react","owner":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimfb/react","description":"React is a declarative, efficient, and extremely flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/jimfb/react","forks_url":"https://api.github.com/repos/jimfb/react/forks","keys_url":"https://api.github.com/repos/jimfb/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimfb/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimfb/react/teams","hooks_url":"https://api.github.com/repos/jimfb/react/hooks","issue_events_url":"https://api.github.com/repos/jimfb/react/issues/events{/number}","events_url":"https://api.github.com/repos/jimfb/react/events","assignees_url":"https://api.github.com/repos/jimfb/react/assignees{/user}","branches_url":"https://api.github.com/repos/jimfb/react/branches{/branch}","tags_url":"https://api.github.com/repos/jimfb/react/tags","blobs_url":"https://api.github.com/repos/jimfb/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimfb/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimfb/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimfb/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimfb/react/statuses/{sha}","languages_url":"https://api.github.com/repos/jimfb/react/languages","stargazers_url":"https://api.github.com/repos/jimfb/react/stargazers","contributors_url":"https://api.github.com/repos/jimfb/react/contributors","subscribers_url":"https://api.github.com/repos/jimfb/react/subscribers","subscription_url":"https://api.github.com/repos/jimfb/react/subscription","commits_url":"https://api.github.com/repos/jimfb/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimfb/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimfb/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimfb/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimfb/react/contents/{+path}","compare_url":"https://api.github.com/repos/jimfb/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimfb/react/merges","archive_url":"https://api.github.com/repos/jimfb/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimfb/react/downloads","issues_url":"https://api.github.com/repos/jimfb/react/issues{/number}","pulls_url":"https://api.github.com/repos/jimfb/react/pulls{/number}","milestones_url":"https://api.github.com/repos/jimfb/react/milestones{/number}","notifications_url":"https://api.github.com/repos/jimfb/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimfb/react/labels{/name}","releases_url":"https://api.github.com/repos/jimfb/react/releases{/id}","created_at":"2014-11-06T19:24:05Z","updated_at":"2015-08-03T01:13:28Z","pushed_at":"2015-10-05T22:34:49Z","git_url":"git://github.com/jimfb/react.git","ssh_url":"git@github.com:jimfb/react.git","clone_url":"https://github.com/jimfb/react.git","svn_url":"https://github.com/jimfb/react","homepage":"http://facebook.github.io/react/","size":64363,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"94ccda8543225098514cfedaa3d0627c0ab43c77","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","created_at":"2013-05-24T16:15:54Z","updated_at":"2015-10-05T23:06:36Z","pushed_at":"2015-10-05T22:34:50Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":116133,"stargazers_count":28989,"watchers_count":28989,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4386,"mirror_url":null,"open_issues_count":594,"forks":4386,"open_issues":594,"watchers":28989,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/5056"},"html":{"href":"https://github.com/facebook/react/pull/5056"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/5056"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/5056/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/5056/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/5056/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/30e0d4b0a304d67052689ce7a598a3f97ba6b264"}}}}