{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/35608299","id":35608299,"diff_hunk":"@@ -693,27 +686,28 @@ FP_PRECISION GPUSolver::getFSRSource(int fsr_id, int group) {\n              _num_groups * sizeof(FP_PRECISION),\n              cudaMemcpyDeviceToHost);\n \n-  /* Initialize variables */\n   FP_PRECISION fission_source = 0.0;\n   FP_PRECISION scatter_source = 0.0;\n   FP_PRECISION total_source;\n \n-  /* Compute total fission source for current region */\n-  for (int e=0; e < _num_groups; e++) {\n-    fission_source += fsr_scalar_fluxes[e] * nu_sigma_f[e];\n-  }\n-\n-  fission_source /= _k_eff;\n-\n-  /* Compute total scattering source for this FSR */\n+  /* Compute total scattering and fission sources for this FSR */\n   for (int g=0; g < _num_groups; g++) {\n     scatter_source += sigma_s[(group-1)*(_num_groups)+g] \n-                    * fsr_scalar_fluxes[g];\n+                      * fsr_scalar_fluxes[g];","path":"src/accel/cuda/GPUSolver.cu","position":87,"original_position":87,"commit_id":"b65a81208689cdd9ae8c3986647287cf096c7cc8","original_commit_id":"58d6d6c9d3b7aa8eda5d92000687b8e84a9d5174","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"body":"Ok, I'll go with that if the other developers concur.\nOn Jul 27, 2015 6:58 PM, \"Geoffrey Gunow\" <notifications@github.com> wrote:\n\n> In src/accel/cuda/GPUSolver.cu\n> <https://github.com/mit-crpg/OpenMOC/pull/186#discussion_r35608196>:\n>\n> >    for (int g=0; g < _num_groups; g++) {\n> >      scatter_source += sigma_s[(group-1)*(_num_groups)+g]\n> > -                    * fsr_scalar_fluxes[g];\n> > +                      * fsr_scalar_fluxes[g];\n>\n> Ok, I just looked into Vim - the default is just one more tab equivalent\n> (so 2 spaces in that case)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/mit-crpg/OpenMOC/pull/186/files#r35608196>.\n>\n","created_at":"2015-07-28T02:01:11Z","updated_at":"2015-07-28T02:01:11Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/186#discussion_r35608299","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/35608299"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/186#discussion_r35608299"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186","id":40856998,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/186","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/186.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/186.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/186","number":186,"state":"open","locked":false,"title":"Use of full fission matrix for source updates","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"body":"This PR introduces a new fission matrix ``_fiss_mat`` attribute for the ``Material`` class. The fission matrix is now used when computing the FSR sources from scattering and fission. The goal behind the fission matrix is to allow as much code as possible to be re-used for the upcoming adjoint solver (in this case, the scatter and fission matrices simply need to be transposed). This PR is a good follow-on to #183 and may be reviewed after that one. The fission matrix has been validated for the ``CPUSolver``, ``VectorizedSolver`` and ``GPUSolver``.","created_at":"2015-07-26T18:03:45Z","updated_at":"2015-07-28T02:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4434273194812d6fdd02070510d9e0a0ce85fc1","assignee":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/186/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/b65a81208689cdd9ae8c3986647287cf096c7cc8","head":{"label":"wbinventor:fiss-matrix","ref":"fiss-matrix","sha":"b65a81208689cdd9ae8c3986647287cf096c7cc8","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"repo":{"id":17987110,"name":"OpenMOC","full_name":"wbinventor/OpenMOC","owner":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wbinventor/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/wbinventor/OpenMOC","forks_url":"https://api.github.com/repos/wbinventor/OpenMOC/forks","keys_url":"https://api.github.com/repos/wbinventor/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wbinventor/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wbinventor/OpenMOC/teams","hooks_url":"https://api.github.com/repos/wbinventor/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/wbinventor/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/wbinventor/OpenMOC/events","assignees_url":"https://api.github.com/repos/wbinventor/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/wbinventor/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/wbinventor/OpenMOC/tags","blobs_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wbinventor/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/wbinventor/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/wbinventor/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/wbinventor/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/wbinventor/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/wbinventor/OpenMOC/subscription","commits_url":"https://api.github.com/repos/wbinventor/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/wbinventor/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/wbinventor/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/wbinventor/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/wbinventor/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wbinventor/OpenMOC/merges","archive_url":"https://api.github.com/repos/wbinventor/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wbinventor/OpenMOC/downloads","issues_url":"https://api.github.com/repos/wbinventor/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/wbinventor/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/wbinventor/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/wbinventor/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wbinventor/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/wbinventor/OpenMOC/releases{/id}","created_at":"2014-03-21T16:55:16Z","updated_at":"2015-07-22T15:37:55Z","pushed_at":"2015-07-28T01:52:00Z","git_url":"git://github.com/wbinventor/OpenMOC.git","ssh_url":"git@github.com:wbinventor/OpenMOC.git","clone_url":"https://github.com/wbinventor/OpenMOC.git","svn_url":"https://github.com/wbinventor/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":74608,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"9c5fffdfbdcbd86bf24fceedddd063a2d7fc6719","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","created_at":"2013-03-14T17:19:26Z","updated_at":"2015-07-19T18:33:59Z","pushed_at":"2015-07-28T01:52:00Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":114388,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":28,"forks":21,"open_issues":28,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/186"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/186"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/b65a81208689cdd9ae8c3986647287cf096c7cc8"}}}}