{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/45529434","id":45529434,"diff_hunk":"@@ -171,6 +175,45 @@ void RecordingScriptingInterface::saveRecording(const QString& filename) {\n     recording::Clip::toFile(filename, _lastClip);\n }\n \n+bool RecordingScriptingInterface::saveRecordingToAsset(QScriptValue getClipAtpUrl) {\n+\tif (!getClipAtpUrl.isFunction())\n+        return false;","path":"libraries/script-engine/src/RecordingScriptingInterface.cpp","position":21,"original_position":21,"commit_id":"54a9e945894a86cfce2bc3cb05b9d32f67bbafae","original_commit_id":"54a9e945894a86cfce2bc3cb05b9d32f67bbafae","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"The indentation looks wrong here.\r\nCoding standard also requires that you use curly braces even for one line if:\r\n```\r\nif (...) {\r\n    // do stuff\r\n}\r\n```\r\nI think you should probably print a warning so users can figure out why it doesn't work.","created_at":"2015-11-20T22:52:49Z","updated_at":"2015-11-20T22:52:49Z","html_url":"https://github.com/highfidelity/hifi/pull/6444#discussion_r45529434","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6444","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/45529434"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6444#discussion_r45529434"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6444"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6444","id":51314533,"html_url":"https://github.com/highfidelity/hifi/pull/6444","diff_url":"https://github.com/highfidelity/hifi/pull/6444.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6444.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6444","number":6444,"state":"open","locked":false,"title":"Save clip to asset","user":{"login":"EdgarPironti","id":13393674,"avatar_url":"https://avatars.githubusercontent.com/u/13393674?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgarPironti","html_url":"https://github.com/EdgarPironti","followers_url":"https://api.github.com/users/EdgarPironti/followers","following_url":"https://api.github.com/users/EdgarPironti/following{/other_user}","gists_url":"https://api.github.com/users/EdgarPironti/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarPironti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarPironti/subscriptions","organizations_url":"https://api.github.com/users/EdgarPironti/orgs","repos_url":"https://api.github.com/users/EdgarPironti/repos","events_url":"https://api.github.com/users/EdgarPironti/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarPironti/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-20T03:38:51Z","updated_at":"2015-11-20T22:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25d5135f605c30ab9d93e6d36a5a628c9226d3fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6444/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6444/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6444/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/54a9e945894a86cfce2bc3cb05b9d32f67bbafae","head":{"label":"EdgarPironti:asset_branch","ref":"asset_branch","sha":"54a9e945894a86cfce2bc3cb05b9d32f67bbafae","user":{"login":"EdgarPironti","id":13393674,"avatar_url":"https://avatars.githubusercontent.com/u/13393674?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgarPironti","html_url":"https://github.com/EdgarPironti","followers_url":"https://api.github.com/users/EdgarPironti/followers","following_url":"https://api.github.com/users/EdgarPironti/following{/other_user}","gists_url":"https://api.github.com/users/EdgarPironti/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarPironti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarPironti/subscriptions","organizations_url":"https://api.github.com/users/EdgarPironti/orgs","repos_url":"https://api.github.com/users/EdgarPironti/repos","events_url":"https://api.github.com/users/EdgarPironti/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarPironti/received_events","type":"User","site_admin":false},"repo":{"id":39301266,"name":"hifi","full_name":"EdgarPironti/hifi","owner":{"login":"EdgarPironti","id":13393674,"avatar_url":"https://avatars.githubusercontent.com/u/13393674?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgarPironti","html_url":"https://github.com/EdgarPironti","followers_url":"https://api.github.com/users/EdgarPironti/followers","following_url":"https://api.github.com/users/EdgarPironti/following{/other_user}","gists_url":"https://api.github.com/users/EdgarPironti/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarPironti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarPironti/subscriptions","organizations_url":"https://api.github.com/users/EdgarPironti/orgs","repos_url":"https://api.github.com/users/EdgarPironti/repos","events_url":"https://api.github.com/users/EdgarPironti/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarPironti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EdgarPironti/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/EdgarPironti/hifi","forks_url":"https://api.github.com/repos/EdgarPironti/hifi/forks","keys_url":"https://api.github.com/repos/EdgarPironti/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdgarPironti/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdgarPironti/hifi/teams","hooks_url":"https://api.github.com/repos/EdgarPironti/hifi/hooks","issue_events_url":"https://api.github.com/repos/EdgarPironti/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/EdgarPironti/hifi/events","assignees_url":"https://api.github.com/repos/EdgarPironti/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/EdgarPironti/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/EdgarPironti/hifi/tags","blobs_url":"https://api.github.com/repos/EdgarPironti/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdgarPironti/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdgarPironti/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdgarPironti/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdgarPironti/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/EdgarPironti/hifi/languages","stargazers_url":"https://api.github.com/repos/EdgarPironti/hifi/stargazers","contributors_url":"https://api.github.com/repos/EdgarPironti/hifi/contributors","subscribers_url":"https://api.github.com/repos/EdgarPironti/hifi/subscribers","subscription_url":"https://api.github.com/repos/EdgarPironti/hifi/subscription","commits_url":"https://api.github.com/repos/EdgarPironti/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdgarPironti/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdgarPironti/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdgarPironti/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdgarPironti/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/EdgarPironti/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdgarPironti/hifi/merges","archive_url":"https://api.github.com/repos/EdgarPironti/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdgarPironti/hifi/downloads","issues_url":"https://api.github.com/repos/EdgarPironti/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/EdgarPironti/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/EdgarPironti/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/EdgarPironti/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdgarPironti/hifi/labels{/name}","releases_url":"https://api.github.com/repos/EdgarPironti/hifi/releases{/id}","created_at":"2015-07-18T14:41:48Z","updated_at":"2015-07-18T14:41:53Z","pushed_at":"2015-11-20T21:37:24Z","git_url":"git://github.com/EdgarPironti/hifi.git","ssh_url":"git@github.com:EdgarPironti/hifi.git","clone_url":"https://github.com/EdgarPironti/hifi.git","svn_url":"https://github.com/EdgarPironti/hifi","homepage":"","size":183640,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"c7673aad4a30d97b517d258e9e4fd08623c06563","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-11-20T07:29:52Z","pushed_at":"2015-11-20T22:51:36Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":216814,"stargazers_count":326,"watchers_count":326,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":65,"forks":192,"open_issues":65,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6444"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6444"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6444"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6444/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6444/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6444/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/54a9e945894a86cfce2bc3cb05b9d32f67bbafae"}}}}