{"action":"created","issue":{"url":"https://api.github.com/repos/mperrin/poppy/issues/119","labels_url":"https://api.github.com/repos/mperrin/poppy/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/mperrin/poppy/issues/119/comments","events_url":"https://api.github.com/repos/mperrin/poppy/issues/119/events","html_url":"https://github.com/mperrin/poppy/issues/119","id":113692832,"number":119,"title":"ZernikeWFE doesn't set pupil_diam correctly","user":{"login":"josePhoenix","id":172886,"avatar_url":"https://avatars.githubusercontent.com/u/172886?v=3","gravatar_id":"","url":"https://api.github.com/users/josePhoenix","html_url":"https://github.com/josePhoenix","followers_url":"https://api.github.com/users/josePhoenix/followers","following_url":"https://api.github.com/users/josePhoenix/following{/other_user}","gists_url":"https://api.github.com/users/josePhoenix/gists{/gist_id}","starred_url":"https://api.github.com/users/josePhoenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josePhoenix/subscriptions","organizations_url":"https://api.github.com/users/josePhoenix/orgs","repos_url":"https://api.github.com/users/josePhoenix/repos","events_url":"https://api.github.com/users/josePhoenix/events{/privacy}","received_events_url":"https://api.github.com/users/josePhoenix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-27T21:25:01Z","updated_at":"2015-11-17T17:51:47Z","closed_at":"2015-11-17T17:09:57Z","body":"I think I haven't fully grokked where POPPY uses `pupil_diam`, but having it missing leads to being unable to sample the ZernikeWFE optic at some fixed npix across the circular aperture. The easy fix is to just set `self.pupil_diam = 2 * self.radius`, but I can see places where common code can be factored out of ZernikeWFE and ParameterizedWFE."},"comment":{"url":"https://api.github.com/repos/mperrin/poppy/issues/comments/157451512","html_url":"https://github.com/mperrin/poppy/issues/119#issuecomment-157451512","issue_url":"https://api.github.com/repos/mperrin/poppy/issues/119","id":157451512,"user":{"login":"mperrin","id":1151745,"avatar_url":"https://avatars.githubusercontent.com/u/1151745?v=3","gravatar_id":"","url":"https://api.github.com/users/mperrin","html_url":"https://github.com/mperrin","followers_url":"https://api.github.com/users/mperrin/followers","following_url":"https://api.github.com/users/mperrin/following{/other_user}","gists_url":"https://api.github.com/users/mperrin/gists{/gist_id}","starred_url":"https://api.github.com/users/mperrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperrin/subscriptions","organizations_url":"https://api.github.com/users/mperrin/orgs","repos_url":"https://api.github.com/users/mperrin/repos","events_url":"https://api.github.com/users/mperrin/events{/privacy}","received_events_url":"https://api.github.com/users/mperrin/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T17:51:47Z","updated_at":"2015-11-17T17:51:47Z","body":"aaaargh I entered the wrong issue number in the commit message *again*. second time today. blargh. The above commit actually addresses #111, *not* #119. "}}