{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/37861733","id":37861733,"diff_hunk":"@@ -698,11 +699,12 @@ public void loadAll(Set<K> keys, boolean replaceExistingValues) {\n         MapKeySetRequest request = new MapKeySetRequest(name);\n         MapKeySet mapKeySet = invoke(request);\n         Set<Data> keySetData = mapKeySet.getKeySet();\n-        Set<K> keySet = new HashSet<K>(keySetData.size());\n+        InflatableSet<K> keySet = new InflatableSet<K>(keySetData.size());\n         for (Data data : keySetData) {\n             final K key = toObject(data);","path":"hazelcast-client/src/main/java/com/hazelcast/client/proxy/ClientMapProxy.java","position":15,"original_position":15,"commit_id":"bbd81fe7787d02f4fdcc5879750be865822244f3","original_commit_id":"bbd81fe7787d02f4fdcc5879750be865822244f3","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"body":"as this is meant to be a Set with no external dependencies. I'll think about how to make it possible. ","created_at":"2015-08-25T13:04:07Z","updated_at":"2015-08-25T13:04:07Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6043#discussion_r37861733","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/37861733"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6043#discussion_r37861733"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043","id":43193695,"html_url":"https://github.com/hazelcast/hazelcast/pull/6043","diff_url":"https://github.com/hazelcast/hazelcast/pull/6043.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6043.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6043","number":6043,"state":"open","locked":false,"title":"Query Performance: InflatableSet Implementation","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"body":"This PR avoid potentially slow HashSet creation. \r\n\r\nOur tests have shown adding data into HashSet might be a bottleneck - specially when equals/hashdode methods are somewhat slow. This PR introduces `InflatableSet` - we are playing a bet most Sets obtained via querying a map are simple iterated over and they are rarely modified. I have a test (obtained from a real customer) which shows 3-5x improvement in throughput with this PR.\r\n\r\nSee commit messages for details. This is the test: https://github.com/hazelcast/hazelcast-simulator/pull/728\r\n\r\nThis modifies the old Java client only. I have yet to check how to ports these changes into the new client. ","created_at":"2015-08-24T16:26:27Z","updated_at":"2015-08-25T13:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e88c79261da8d2988369a28324c45b91ae705da","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":143,"closed_issues":307,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-08-25T11:50:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6043/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/bbd81fe7787d02f4fdcc5879750be865822244f3","head":{"label":"jerrinot:improvements/client-InflatableSet/master","ref":"improvements/client-InflatableSet/master","sha":"bbd81fe7787d02f4fdcc5879750be865822244f3","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"repo":{"id":14844579,"name":"hazelcast","full_name":"jerrinot/hazelcast","owner":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerrinot/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/jerrinot/hazelcast","forks_url":"https://api.github.com/repos/jerrinot/hazelcast/forks","keys_url":"https://api.github.com/repos/jerrinot/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerrinot/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerrinot/hazelcast/teams","hooks_url":"https://api.github.com/repos/jerrinot/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/jerrinot/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/jerrinot/hazelcast/events","assignees_url":"https://api.github.com/repos/jerrinot/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/jerrinot/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/jerrinot/hazelcast/tags","blobs_url":"https://api.github.com/repos/jerrinot/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerrinot/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerrinot/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerrinot/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerrinot/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/jerrinot/hazelcast/languages","stargazers_url":"https://api.github.com/repos/jerrinot/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/jerrinot/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/jerrinot/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/jerrinot/hazelcast/subscription","commits_url":"https://api.github.com/repos/jerrinot/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerrinot/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerrinot/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerrinot/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerrinot/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/jerrinot/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerrinot/hazelcast/merges","archive_url":"https://api.github.com/repos/jerrinot/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerrinot/hazelcast/downloads","issues_url":"https://api.github.com/repos/jerrinot/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/jerrinot/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/jerrinot/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/jerrinot/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerrinot/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/jerrinot/hazelcast/releases{/id}","created_at":"2013-12-01T19:18:56Z","updated_at":"2015-04-27T20:28:12Z","pushed_at":"2015-08-25T11:48:16Z","git_url":"git://github.com/jerrinot/hazelcast.git","ssh_url":"git@github.com:jerrinot/hazelcast.git","clone_url":"https://github.com/jerrinot/hazelcast.git","svn_url":"https://github.com/jerrinot/hazelcast","homepage":"www.hazelcast.com","size":76356,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"9f4437347515684af1046ca663bb40e1e50e02e7","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-08-24T10:54:49Z","pushed_at":"2015-08-25T11:50:09Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":150461,"stargazers_count":1213,"watchers_count":1213,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":485,"forks":588,"open_issues":485,"watchers":1213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6043"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6043"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6043/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6043/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/bbd81fe7787d02f4fdcc5879750be865822244f3"}}}}