{"action":"created","issue":{"url":"https://api.github.com/repos/Swimlane/angular-data-table/issues/105","labels_url":"https://api.github.com/repos/Swimlane/angular-data-table/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/Swimlane/angular-data-table/issues/105/comments","events_url":"https://api.github.com/repos/Swimlane/angular-data-table/issues/105/events","html_url":"https://github.com/Swimlane/angular-data-table/pull/105","id":120411684,"number":105,"title":"(fix): fixing BodyController isSelected method for multiselect.","user":{"login":"ngodfraind","id":1397430,"avatar_url":"https://avatars.githubusercontent.com/u/1397430?v=3","gravatar_id":"","url":"https://api.github.com/users/ngodfraind","html_url":"https://github.com/ngodfraind","followers_url":"https://api.github.com/users/ngodfraind/followers","following_url":"https://api.github.com/users/ngodfraind/following{/other_user}","gists_url":"https://api.github.com/users/ngodfraind/gists{/gist_id}","starred_url":"https://api.github.com/users/ngodfraind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngodfraind/subscriptions","organizations_url":"https://api.github.com/users/ngodfraind/orgs","repos_url":"https://api.github.com/users/ngodfraind/repos","events_url":"https://api.github.com/users/ngodfraind/events{/privacy}","received_events_url":"https://api.github.com/users/ngodfraind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-04T14:26:10Z","updated_at":"2015-12-04T14:48:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Swimlane/angular-data-table/pulls/105","html_url":"https://github.com/Swimlane/angular-data-table/pull/105","diff_url":"https://github.com/Swimlane/angular-data-table/pull/105.diff","patch_url":"https://github.com/Swimlane/angular-data-table/pull/105.patch"},"body":"It's me... again.\r\n\r\nI ran into some problems with the multiselect when I was changing pages for some reason.\r\nThe this.select.indexOf(xxx) never found any object (and they were existing) so my checkboxes were unchecked. I don't know what goes wrong.\r\n\r\nhttp://stackoverflow.com/questions/12604062/javascript-array-indexof-doesnt-search-objects\r\n\r\nThis is not a pretty fix but it worked well. It also somehow fixed the bug I had with the header select.\r\nI assume I'd have the same problem with the simple select but I didn't change the else bracket.\r\n\r\nedit: meh, I can't uncheck rows properly anymore with this. I'll looks at it."},"comment":{"url":"https://api.github.com/repos/Swimlane/angular-data-table/issues/comments/161984299","html_url":"https://github.com/Swimlane/angular-data-table/pull/105#issuecomment-161984299","issue_url":"https://api.github.com/repos/Swimlane/angular-data-table/issues/105","id":161984299,"user":{"login":"amcdnl","id":227909,"avatar_url":"https://avatars.githubusercontent.com/u/227909?v=3","gravatar_id":"","url":"https://api.github.com/users/amcdnl","html_url":"https://github.com/amcdnl","followers_url":"https://api.github.com/users/amcdnl/followers","following_url":"https://api.github.com/users/amcdnl/following{/other_user}","gists_url":"https://api.github.com/users/amcdnl/gists{/gist_id}","starred_url":"https://api.github.com/users/amcdnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcdnl/subscriptions","organizations_url":"https://api.github.com/users/amcdnl/orgs","repos_url":"https://api.github.com/users/amcdnl/repos","events_url":"https://api.github.com/users/amcdnl/events{/privacy}","received_events_url":"https://api.github.com/users/amcdnl/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T14:48:36Z","updated_at":"2015-12-04T14:48:36Z","body":"Can you make a demo of this happening? \r\n\r\nThat fix has some other unintended consequences and performance issues too so we will need to come up with something else."}}