{"action":"closed","number":14643,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/14643","id":52250145,"html_url":"https://github.com/mantidproject/mantid/pull/14643","diff_url":"https://github.com/mantidproject/mantid/pull/14643.diff","patch_url":"https://github.com/mantidproject/mantid/pull/14643.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/14643","number":14643,"state":"closed","locked":false,"title":"ISISEnergyTransfer remove revalidate and ensure user wants log rebinning","user":{"login":"ElliotAOram","id":13132128,"avatar_url":"https://avatars.githubusercontent.com/u/13132128?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliotAOram","html_url":"https://github.com/ElliotAOram","followers_url":"https://api.github.com/users/ElliotAOram/followers","following_url":"https://api.github.com/users/ElliotAOram/following{/other_user}","gists_url":"https://api.github.com/users/ElliotAOram/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliotAOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliotAOram/subscriptions","organizations_url":"https://api.github.com/users/ElliotAOram/orgs","repos_url":"https://api.github.com/users/ElliotAOram/repos","events_url":"https://api.github.com/users/ElliotAOram/events{/privacy}","received_events_url":"https://api.github.com/users/ElliotAOram/received_events","type":"User","site_admin":false},"body":"Fixes #14520\r\n\r\nISISEnergyTransfer no longer re-validates the interface every time the Rebinning spinners are changed *(this was causing issues when changing between instruments producing ~3 validation message boxes)*. Furthermore, it is now possible to have Logarithmic (negative) binning width in the interface as required by TOSCA and TFXA instruments.\r\n\r\n# To Test \r\n* Change your default instrument to IRIS *(This will not need to be done after #14067 is resolved)*\r\n* Open ISISEnergyTransfer (Interfaces > Indirect > Data Reduction > ISIS Energy Transfer)\r\n* Run number is `26176` This can be found in the data Archive or unit/system tests (you only need to enter the number `26176` while IRIS is your selected instrument)\r\n* Uncheck the `Do Not Rebin` option\r\n  * Low=0.1\r\n  * Width=-0.1\r\n  * High=0.2\r\n* Ensure that when you change the values it does not re validate the tab ever time you change a number\r\n* Click `Run` \r\n* Ensure that a message is produced about Logarithmic Binning\r\n* Click `No` \r\n  * Ensure that the algorithm does not run and a message is produced about the bin width being invalid\r\n* Click `Run` again and this time click `Yes` on the pop up message\r\n  * Ensure that the algorithm runs without errors\r\n* Please also check this is the case for positive binning","created_at":"2015-12-01T12:10:53Z","updated_at":"2015-12-02T12:24:45Z","closed_at":"2015-12-02T12:24:45Z","merged_at":"2015-12-02T12:24:45Z","merge_commit_sha":"721fdd7f070bd3e999bbb695168b470e61e502b4","assignee":{"login":"shahrozahmed1","id":13132173,"avatar_url":"https://avatars.githubusercontent.com/u/13132173?v=3","gravatar_id":"","url":"https://api.github.com/users/shahrozahmed1","html_url":"https://github.com/shahrozahmed1","followers_url":"https://api.github.com/users/shahrozahmed1/followers","following_url":"https://api.github.com/users/shahrozahmed1/following{/other_user}","gists_url":"https://api.github.com/users/shahrozahmed1/gists{/gist_id}","starred_url":"https://api.github.com/users/shahrozahmed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahrozahmed1/subscriptions","organizations_url":"https://api.github.com/users/shahrozahmed1/orgs","repos_url":"https://api.github.com/users/shahrozahmed1/repos","events_url":"https://api.github.com/users/shahrozahmed1/events{/privacy}","received_events_url":"https://api.github.com/users/shahrozahmed1/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/4","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.6","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/4/labels","id":1106937,"number":4,"title":"Release 3.6","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":593,"closed_issues":741,"state":"open","created_at":"2015-05-12T15:36:23Z","updated_at":"2015-12-02T12:24:45Z","due_on":"2016-01-30T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/14643/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/14643/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/14643/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/b0375d9b1005eb8c0ccd78259e4d295a79335d22","head":{"label":"mantidproject:14520_ISIS_Energy_transfer_TFXA_negative_bin_width","ref":"14520_ISIS_Energy_transfer_TFXA_negative_bin_width","sha":"b0375d9b1005eb8c0ccd78259e4d295a79335d22","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","created_at":"2011-10-17T19:07:38Z","updated_at":"2015-12-02T11:12:38Z","pushed_at":"2015-12-02T12:24:45Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":324118,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":1593,"forks":25,"open_issues":1593,"watchers":33,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"9f756ea69fc3f43167551c9aa54357ab383cf2a6","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","created_at":"2011-10-17T19:07:38Z","updated_at":"2015-12-02T11:12:38Z","pushed_at":"2015-12-02T12:24:45Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":324118,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":1593,"forks":25,"open_issues":1593,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/14643"},"html":{"href":"https://github.com/mantidproject/mantid/pull/14643"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/14643"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/14643/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/14643/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/14643/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/b0375d9b1005eb8c0ccd78259e4d295a79335d22"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shahrozahmed1","id":13132173,"avatar_url":"https://avatars.githubusercontent.com/u/13132173?v=3","gravatar_id":"","url":"https://api.github.com/users/shahrozahmed1","html_url":"https://github.com/shahrozahmed1","followers_url":"https://api.github.com/users/shahrozahmed1/followers","following_url":"https://api.github.com/users/shahrozahmed1/following{/other_user}","gists_url":"https://api.github.com/users/shahrozahmed1/gists{/gist_id}","starred_url":"https://api.github.com/users/shahrozahmed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahrozahmed1/subscriptions","organizations_url":"https://api.github.com/users/shahrozahmed1/orgs","repos_url":"https://api.github.com/users/shahrozahmed1/repos","events_url":"https://api.github.com/users/shahrozahmed1/events{/privacy}","received_events_url":"https://api.github.com/users/shahrozahmed1/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":15,"deletions":12,"changed_files":1}}