{"action":"created","comment":{"url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/comments/31649778","id":31649778,"diff_hunk":"@@ -593,18 +678,22 @@ static int mag_auth(request_rec *req)\n     ret = OK;\n \n done:\n-    if ((!is_basic) && (output.length != 0)) {\n+    if ((auth_type != AUTH_TYPE_BASIC) && (output.length != 0)) {\n+        int prefixlen = strlen(auth_types[auth_type]) + 1;","path":"src/mod_auth_gssapi.c","position":278,"original_position":278,"commit_id":"31c1179eb2d17ca2799c0b9445116973678ae8b5","original_commit_id":"31c1179eb2d17ca2799c0b9445116973678ae8b5","user":{"login":"frenche","id":7945916,"avatar_url":"https://avatars.githubusercontent.com/u/7945916?v=3","gravatar_id":"","url":"https://api.github.com/users/frenche","html_url":"https://github.com/frenche","followers_url":"https://api.github.com/users/frenche/followers","following_url":"https://api.github.com/users/frenche/following{/other_user}","gists_url":"https://api.github.com/users/frenche/gists{/gist_id}","starred_url":"https://api.github.com/users/frenche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenche/subscriptions","organizations_url":"https://api.github.com/users/frenche/orgs","repos_url":"https://api.github.com/users/frenche/repos","events_url":"https://api.github.com/users/frenche/events{/privacy}","received_events_url":"https://api.github.com/users/frenche/received_events","type":"User","site_admin":false},"body":"I *think* compile time sizeof could be kosher here instead of runtime strlen :)","created_at":"2015-06-03T17:49:47Z","updated_at":"2015-06-03T17:49:47Z","html_url":"https://github.com/modauthgssapi/mod_auth_gssapi/pull/33#discussion_r31649778","pull_request_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/comments/31649778"},"html":{"href":"https://github.com/modauthgssapi/mod_auth_gssapi/pull/33#discussion_r31649778"},"pull_request":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33","id":36658533,"html_url":"https://github.com/modauthgssapi/mod_auth_gssapi/pull/33","diff_url":"https://github.com/modauthgssapi/mod_auth_gssapi/pull/33.diff","patch_url":"https://github.com/modauthgssapi/mod_auth_gssapi/pull/33.patch","issue_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues/33","number":33,"state":"open","locked":false,"title":"Raw ntlm","user":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-01T18:51:57Z","updated_at":"2015-06-03T17:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d11fed6e49b4c7c1450fa1f80c9f544eb1b766fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33/commits","review_comments_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33/comments","review_comment_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues/33/comments","statuses_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/statuses/31c1179eb2d17ca2799c0b9445116973678ae8b5","head":{"label":"simo5:raw_ntlm","ref":"raw_ntlm","sha":"31c1179eb2d17ca2799c0b9445116973678ae8b5","user":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"repo":{"id":25178090,"name":"mod_auth_gssapi","full_name":"simo5/mod_auth_gssapi","owner":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simo5/mod_auth_gssapi","description":"GSSAPI Negotiate module for Apache","fork":true,"url":"https://api.github.com/repos/simo5/mod_auth_gssapi","forks_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/forks","keys_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/teams","hooks_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/hooks","issue_events_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/issues/events{/number}","events_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/events","assignees_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/assignees{/user}","branches_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/branches{/branch}","tags_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/tags","blobs_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/statuses/{sha}","languages_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/languages","stargazers_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/stargazers","contributors_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/contributors","subscribers_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/subscribers","subscription_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/subscription","commits_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/contents/{+path}","compare_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/merges","archive_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/downloads","issues_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/issues{/number}","pulls_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/pulls{/number}","milestones_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/milestones{/number}","notifications_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/labels{/name}","releases_url":"https://api.github.com/repos/simo5/mod_auth_gssapi/releases{/id}","created_at":"2014-10-13T21:13:01Z","updated_at":"2014-10-13T21:13:25Z","pushed_at":"2015-06-01T23:50:35Z","git_url":"git://github.com/simo5/mod_auth_gssapi.git","ssh_url":"git@github.com:simo5/mod_auth_gssapi.git","clone_url":"https://github.com/simo5/mod_auth_gssapi.git","svn_url":"https://github.com/simo5/mod_auth_gssapi","homepage":"","size":221,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modauthgssapi:master","ref":"master","sha":"4b68f81eb41a5934a952e2326c1226b5ef583269","user":{"login":"modauthgssapi","id":8332646,"avatar_url":"https://avatars.githubusercontent.com/u/8332646?v=3","gravatar_id":"","url":"https://api.github.com/users/modauthgssapi","html_url":"https://github.com/modauthgssapi","followers_url":"https://api.github.com/users/modauthgssapi/followers","following_url":"https://api.github.com/users/modauthgssapi/following{/other_user}","gists_url":"https://api.github.com/users/modauthgssapi/gists{/gist_id}","starred_url":"https://api.github.com/users/modauthgssapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modauthgssapi/subscriptions","organizations_url":"https://api.github.com/users/modauthgssapi/orgs","repos_url":"https://api.github.com/users/modauthgssapi/repos","events_url":"https://api.github.com/users/modauthgssapi/events{/privacy}","received_events_url":"https://api.github.com/users/modauthgssapi/received_events","type":"Organization","site_admin":false},"repo":{"id":22522821,"name":"mod_auth_gssapi","full_name":"modauthgssapi/mod_auth_gssapi","owner":{"login":"modauthgssapi","id":8332646,"avatar_url":"https://avatars.githubusercontent.com/u/8332646?v=3","gravatar_id":"","url":"https://api.github.com/users/modauthgssapi","html_url":"https://github.com/modauthgssapi","followers_url":"https://api.github.com/users/modauthgssapi/followers","following_url":"https://api.github.com/users/modauthgssapi/following{/other_user}","gists_url":"https://api.github.com/users/modauthgssapi/gists{/gist_id}","starred_url":"https://api.github.com/users/modauthgssapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modauthgssapi/subscriptions","organizations_url":"https://api.github.com/users/modauthgssapi/orgs","repos_url":"https://api.github.com/users/modauthgssapi/repos","events_url":"https://api.github.com/users/modauthgssapi/events{/privacy}","received_events_url":"https://api.github.com/users/modauthgssapi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modauthgssapi/mod_auth_gssapi","description":"GSSAPI Negotiate module for Apache","fork":false,"url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi","forks_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/forks","keys_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/teams","hooks_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/hooks","issue_events_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues/events{/number}","events_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/events","assignees_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/assignees{/user}","branches_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/branches{/branch}","tags_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/tags","blobs_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/statuses/{sha}","languages_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/languages","stargazers_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/stargazers","contributors_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/contributors","subscribers_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/subscribers","subscription_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/subscription","commits_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/contents/{+path}","compare_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/merges","archive_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/downloads","issues_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues{/number}","pulls_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls{/number}","milestones_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/milestones{/number}","notifications_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/labels{/name}","releases_url":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/releases{/id}","created_at":"2014-08-01T18:36:05Z","updated_at":"2015-06-03T07:12:58Z","pushed_at":"2015-06-01T23:50:35Z","git_url":"git://github.com/modauthgssapi/mod_auth_gssapi.git","ssh_url":"git@github.com:modauthgssapi/mod_auth_gssapi.git","clone_url":"https://github.com/modauthgssapi/mod_auth_gssapi.git","svn_url":"https://github.com/modauthgssapi/mod_auth_gssapi","homepage":"","size":540,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":8,"forks":6,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33"},"html":{"href":"https://github.com/modauthgssapi/mod_auth_gssapi/pull/33"},"issue":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues/33"},"comments":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/modauthgssapi/mod_auth_gssapi/statuses/31c1179eb2d17ca2799c0b9445116973678ae8b5"}}}}