{"action":"created","comment":{"url":"https://api.github.com/repos/ninjaframework/ninja/pulls/comments/42190041","id":42190041,"diff_hunk":"@@ -297,20 +358,31 @@ else if (file.getName().endsWith(\".jar\") && this.watchAllClassPathJars) {\n         \n         jvmArguments.add(systemPropertyDevMode);\n \n-        String portSelection\n-                = \"-D\" + NinjaJetty.COMMAND_LINE_PARAMETER_NINJA_PORT + \"=\" + port;\n-\n-        jvmArguments.add(portSelection);\n+        if (port != null) {\n+            String portSelection\n+                    = \"-D\" + NinjaJetty.KEY_NINJA_PORT + \"=\" + port;\n+            jvmArguments.add(portSelection);\n+        }\n         \n-        if (contextPath != null) {\n-            String systemPropertyContextPath = \"-Dninja.context=\" + contextPath;\n+        if (getContextPath() != null) {\n+            String systemPropertyContextPath = \"-Dninja.context=\" + getContextPath();\n             jvmArguments.add(systemPropertyContextPath);\n         }\n         \n+        if (jvmArgs != null) {\n+            // use excellent DrJava library to tokenize arguments (do not keep tokens)\n+            List<String> tokenizedArgs = ArgumentTokenizer.tokenize(jvmArgs, false);","path":"ninja-maven-plugin/src/main/java/ninja/maven/NinjaRunMojo.java","position":280,"original_position":280,"commit_id":"eba7f1f29a11f3666f601ec0603fd35ee5de4b48","original_commit_id":"eba7f1f29a11f3666f601ec0603fd35ee5de4b48","user":{"login":"raphaelbauer","id":524072,"avatar_url":"https://avatars.githubusercontent.com/u/524072?v=3","gravatar_id":"","url":"https://api.github.com/users/raphaelbauer","html_url":"https://github.com/raphaelbauer","followers_url":"https://api.github.com/users/raphaelbauer/followers","following_url":"https://api.github.com/users/raphaelbauer/following{/other_user}","gists_url":"https://api.github.com/users/raphaelbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelbauer/subscriptions","organizations_url":"https://api.github.com/users/raphaelbauer/orgs","repos_url":"https://api.github.com/users/raphaelbauer/repos","events_url":"https://api.github.com/users/raphaelbauer/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelbauer/received_events","type":"User","site_admin":false},"body":"Hmm.... Why don't we just use Guava's splitter to split the stuff easily? Copying the DrJava file with only use case... hmm...","created_at":"2015-10-15T22:37:39Z","updated_at":"2015-10-15T22:37:39Z","html_url":"https://github.com/ninjaframework/ninja/pull/409#discussion_r42190041","pull_request_url":"https://api.github.com/repos/ninjaframework/ninja/pulls/409","_links":{"self":{"href":"https://api.github.com/repos/ninjaframework/ninja/pulls/comments/42190041"},"html":{"href":"https://github.com/ninjaframework/ninja/pull/409#discussion_r42190041"},"pull_request":{"href":"https://api.github.com/repos/ninjaframework/ninja/pulls/409"}}},"pull_request":{"url":"https://api.github.com/repos/ninjaframework/ninja/pulls/409","id":47046758,"html_url":"https://github.com/ninjaframework/ninja/pull/409","diff_url":"https://github.com/ninjaframework/ninja/pull/409.diff","patch_url":"https://github.com/ninjaframework/ninja/pull/409.patch","issue_url":"https://api.github.com/repos/ninjaframework/ninja/issues/409","number":409,"state":"open","locked":false,"title":"Refactored servlet and standalone to prepare for eventual non-servlet-based Ninjas","user":{"login":"jjlauer","id":585730,"avatar_url":"https://avatars.githubusercontent.com/u/585730?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlauer","html_url":"https://github.com/jjlauer","followers_url":"https://api.github.com/users/jjlauer/followers","following_url":"https://api.github.com/users/jjlauer/following{/other_user}","gists_url":"https://api.github.com/users/jjlauer/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlauer/subscriptions","organizations_url":"https://api.github.com/users/jjlauer/orgs","repos_url":"https://api.github.com/users/jjlauer/repos","events_url":"https://api.github.com/users/jjlauer/events{/privacy}","received_events_url":"https://api.github.com/users/jjlauer/received_events","type":"User","site_admin":false},"body":"Fairly large commit to prepare for non-servlet-based contexts, bootstraps, and standalones.  Should finally remove the overall reliance on servlets to Bootstrap a Ninja application.  Here are the main changes...\r\n\r\n*ninja-servlet/src/main/java/ninja/servlet/NinjaBootstrap.java*\r\n\r\n- Non-servlet functionality extracted to `ninja-core/src/main/java/ninja/Bootstrap.java` and is now part of ninja-core.\r\n- Servlet functionality extracted to `ninja-servlet/src/main/java/ninja/servlet/NinjaServletBootstrap.java`\r\n\r\n*ninja-servlet/src/main/java/ninja/servlet/ContextImpl.java*\r\n\r\n- Non-servlet functionality extracted to `ninja-core/src/main/java/ninja/utils/AbstractContext.java` and is now part of ninja-core.\r\n- Servlet functionality extracted to ninja-servlet/src/main/java/ninja/servlet/NinjaServletContext.java\r\n\r\n*ninja-standalone/src/main/java/ninja/standalone/NinjaJetty.java*\r\n\r\n- Non-jetty functionality extracted to `ninja-core/src/main/java/ninja/standalone/AbstractStandalone.java` and is now part of ninja-core.\r\n- Jetty functionality retained in `ninja-standalone/src/main/java/ninja/standalone/NinjaJetty.java`\r\n- New `ninja-core/src/main/java/ninja/standalone/Standalone.java` interface that any standalone is required to implement.\r\n\r\n*Other notable enhancements*\r\n\r\n- Any Ninja standalone configuration (e.g. ninja.port) now available in `conf/application.conf`.  The priority of settings is systemProperty then configurationProperty then defaultValue.\r\n\r\n- New 'ninja.standalone' system property available to change the standalone implementation to be used for NinjaTestServer or maven plugin.  I have been working on an Undertow implementation for Ninja standalone and this let's me pick what Ninja uses in key spots.  It defaults to NinjaJetty.\r\n\r\n*Where are the docs & changelog?*\r\n\r\nLet me know what you think of the PR first and I can add the final doc and changelog info.","created_at":"2015-10-07T15:59:58Z","updated_at":"2015-10-15T22:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ed013c0be7eeb63d908604462a1bc38f014f049","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ninjaframework/ninja/pulls/409/commits","review_comments_url":"https://api.github.com/repos/ninjaframework/ninja/pulls/409/comments","review_comment_url":"https://api.github.com/repos/ninjaframework/ninja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninjaframework/ninja/issues/409/comments","statuses_url":"https://api.github.com/repos/ninjaframework/ninja/statuses/eba7f1f29a11f3666f601ec0603fd35ee5de4b48","head":{"label":"fizzed:feature_refactor_standalone","ref":"feature_refactor_standalone","sha":"eba7f1f29a11f3666f601ec0603fd35ee5de4b48","user":{"login":"fizzed","id":4987438,"avatar_url":"https://avatars.githubusercontent.com/u/4987438?v=3","gravatar_id":"","url":"https://api.github.com/users/fizzed","html_url":"https://github.com/fizzed","followers_url":"https://api.github.com/users/fizzed/followers","following_url":"https://api.github.com/users/fizzed/following{/other_user}","gists_url":"https://api.github.com/users/fizzed/gists{/gist_id}","starred_url":"https://api.github.com/users/fizzed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fizzed/subscriptions","organizations_url":"https://api.github.com/users/fizzed/orgs","repos_url":"https://api.github.com/users/fizzed/repos","events_url":"https://api.github.com/users/fizzed/events{/privacy}","received_events_url":"https://api.github.com/users/fizzed/received_events","type":"Organization","site_admin":false},"repo":{"id":42525150,"name":"ninja","full_name":"fizzed/ninja","owner":{"login":"fizzed","id":4987438,"avatar_url":"https://avatars.githubusercontent.com/u/4987438?v=3","gravatar_id":"","url":"https://api.github.com/users/fizzed","html_url":"https://github.com/fizzed","followers_url":"https://api.github.com/users/fizzed/followers","following_url":"https://api.github.com/users/fizzed/following{/other_user}","gists_url":"https://api.github.com/users/fizzed/gists{/gist_id}","starred_url":"https://api.github.com/users/fizzed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fizzed/subscriptions","organizations_url":"https://api.github.com/users/fizzed/orgs","repos_url":"https://api.github.com/users/fizzed/repos","events_url":"https://api.github.com/users/fizzed/events{/privacy}","received_events_url":"https://api.github.com/users/fizzed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fizzed/ninja","description":"Ninja is a full stack web framework for Java. Rock solid, fast and super productive.","fork":true,"url":"https://api.github.com/repos/fizzed/ninja","forks_url":"https://api.github.com/repos/fizzed/ninja/forks","keys_url":"https://api.github.com/repos/fizzed/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fizzed/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fizzed/ninja/teams","hooks_url":"https://api.github.com/repos/fizzed/ninja/hooks","issue_events_url":"https://api.github.com/repos/fizzed/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/fizzed/ninja/events","assignees_url":"https://api.github.com/repos/fizzed/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/fizzed/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/fizzed/ninja/tags","blobs_url":"https://api.github.com/repos/fizzed/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fizzed/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fizzed/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/fizzed/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fizzed/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/fizzed/ninja/languages","stargazers_url":"https://api.github.com/repos/fizzed/ninja/stargazers","contributors_url":"https://api.github.com/repos/fizzed/ninja/contributors","subscribers_url":"https://api.github.com/repos/fizzed/ninja/subscribers","subscription_url":"https://api.github.com/repos/fizzed/ninja/subscription","commits_url":"https://api.github.com/repos/fizzed/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/fizzed/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/fizzed/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/fizzed/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/fizzed/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/fizzed/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fizzed/ninja/merges","archive_url":"https://api.github.com/repos/fizzed/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fizzed/ninja/downloads","issues_url":"https://api.github.com/repos/fizzed/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/fizzed/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/fizzed/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/fizzed/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fizzed/ninja/labels{/name}","releases_url":"https://api.github.com/repos/fizzed/ninja/releases{/id}","created_at":"2015-09-15T14:38:06Z","updated_at":"2015-09-15T14:38:08Z","pushed_at":"2015-10-13T15:18:14Z","git_url":"git://github.com/fizzed/ninja.git","ssh_url":"git@github.com:fizzed/ninja.git","clone_url":"https://github.com/fizzed/ninja.git","svn_url":"https://github.com/fizzed/ninja","homepage":"http://www.ninjaframework.org","size":31798,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ninjaframework:develop","ref":"develop","sha":"54f79494bffbd4c66a328857f79f08e60093fd19","user":{"login":"ninjaframework","id":4134828,"avatar_url":"https://avatars.githubusercontent.com/u/4134828?v=3","gravatar_id":"","url":"https://api.github.com/users/ninjaframework","html_url":"https://github.com/ninjaframework","followers_url":"https://api.github.com/users/ninjaframework/followers","following_url":"https://api.github.com/users/ninjaframework/following{/other_user}","gists_url":"https://api.github.com/users/ninjaframework/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjaframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjaframework/subscriptions","organizations_url":"https://api.github.com/users/ninjaframework/orgs","repos_url":"https://api.github.com/users/ninjaframework/repos","events_url":"https://api.github.com/users/ninjaframework/events{/privacy}","received_events_url":"https://api.github.com/users/ninjaframework/received_events","type":"Organization","site_admin":false},"repo":{"id":4610430,"name":"ninja","full_name":"ninjaframework/ninja","owner":{"login":"ninjaframework","id":4134828,"avatar_url":"https://avatars.githubusercontent.com/u/4134828?v=3","gravatar_id":"","url":"https://api.github.com/users/ninjaframework","html_url":"https://github.com/ninjaframework","followers_url":"https://api.github.com/users/ninjaframework/followers","following_url":"https://api.github.com/users/ninjaframework/following{/other_user}","gists_url":"https://api.github.com/users/ninjaframework/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjaframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjaframework/subscriptions","organizations_url":"https://api.github.com/users/ninjaframework/orgs","repos_url":"https://api.github.com/users/ninjaframework/repos","events_url":"https://api.github.com/users/ninjaframework/events{/privacy}","received_events_url":"https://api.github.com/users/ninjaframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninjaframework/ninja","description":"Ninja is a full stack web framework for Java. Rock solid, fast and super productive.","fork":false,"url":"https://api.github.com/repos/ninjaframework/ninja","forks_url":"https://api.github.com/repos/ninjaframework/ninja/forks","keys_url":"https://api.github.com/repos/ninjaframework/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninjaframework/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninjaframework/ninja/teams","hooks_url":"https://api.github.com/repos/ninjaframework/ninja/hooks","issue_events_url":"https://api.github.com/repos/ninjaframework/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/ninjaframework/ninja/events","assignees_url":"https://api.github.com/repos/ninjaframework/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/ninjaframework/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/ninjaframework/ninja/tags","blobs_url":"https://api.github.com/repos/ninjaframework/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninjaframework/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninjaframework/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninjaframework/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninjaframework/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/ninjaframework/ninja/languages","stargazers_url":"https://api.github.com/repos/ninjaframework/ninja/stargazers","contributors_url":"https://api.github.com/repos/ninjaframework/ninja/contributors","subscribers_url":"https://api.github.com/repos/ninjaframework/ninja/subscribers","subscription_url":"https://api.github.com/repos/ninjaframework/ninja/subscription","commits_url":"https://api.github.com/repos/ninjaframework/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninjaframework/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninjaframework/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninjaframework/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninjaframework/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/ninjaframework/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninjaframework/ninja/merges","archive_url":"https://api.github.com/repos/ninjaframework/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninjaframework/ninja/downloads","issues_url":"https://api.github.com/repos/ninjaframework/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/ninjaframework/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/ninjaframework/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/ninjaframework/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninjaframework/ninja/labels{/name}","releases_url":"https://api.github.com/repos/ninjaframework/ninja/releases{/id}","created_at":"2012-06-09T21:06:05Z","updated_at":"2015-10-15T17:19:27Z","pushed_at":"2015-10-15T22:34:07Z","git_url":"git://github.com/ninjaframework/ninja.git","ssh_url":"git@github.com:ninjaframework/ninja.git","clone_url":"https://github.com/ninjaframework/ninja.git","svn_url":"https://github.com/ninjaframework/ninja","homepage":"http://www.ninjaframework.org","size":40817,"stargazers_count":1007,"watchers_count":1007,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":331,"mirror_url":null,"open_issues_count":82,"forks":331,"open_issues":82,"watchers":1007,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ninjaframework/ninja/pulls/409"},"html":{"href":"https://github.com/ninjaframework/ninja/pull/409"},"issue":{"href":"https://api.github.com/repos/ninjaframework/ninja/issues/409"},"comments":{"href":"https://api.github.com/repos/ninjaframework/ninja/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/ninjaframework/ninja/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/ninjaframework/ninja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninjaframework/ninja/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/ninjaframework/ninja/statuses/eba7f1f29a11f3666f601ec0603fd35ee5de4b48"}}}}