{"action":"closed","number":5680,"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/5680","id":42719822,"html_url":"https://github.com/TryGhost/Ghost/pull/5680","diff_url":"https://github.com/TryGhost/Ghost/pull/5680.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/5680.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/5680","number":5680,"state":"closed","locked":false,"title":"[WIP] Tags input (again) this time using bootstrap-tokenfield plugin","user":{"login":"kevinansfield","id":415,"avatar_url":"https://avatars.githubusercontent.com/u/415?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},"body":"@acburdine did some excellent work re-working the old tag input however there were still a number of edge cases and UI inconsistencies.\r\n\r\nThis is an attempt to leverage the existing bootstrap-tokenfield plugin with typeahead support and to further separate post/tags/input concerns.\r\n\r\nTODO:\r\n\r\n- [ ] Fix occasional issues arising from the async add/remove tag behaviour\r\n- [ ] Fix issue with only the first autocomplete item appearing as a typeahead hint\r\n- [ ] Fix previously added tag name re-appearing in the input field (introduced after delegating tag management to action)\r\n- [ ] Fix issue with autocomplete list showing items with no matches (introduced after delegating tag management to action)\r\n- [ ] Clean up the CSS\r\n- [ ] Split re-usable elements of the token field into a separate component (ie. `gh-tags-input` and `gh-tokenfield-input`)\r\n- [ ] Tests\r\n- [ ] Remove old tag input code","created_at":"2015-08-18T16:32:49Z","updated_at":"2015-08-19T11:24:08Z","closed_at":"2015-08-19T11:24:08Z","merged_at":null,"merge_commit_sha":"101a0d123e19bfb6b9ca3352277b036b9280ed07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/5680/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/5680/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/5680/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/8178215b8c3b9620b9d0d43fa6dd1e167accc2d0","head":{"label":"kevinansfield:tags-v3","ref":"tags-v3","sha":"8178215b8c3b9620b9d0d43fa6dd1e167accc2d0","user":{"login":"kevinansfield","id":415,"avatar_url":"https://avatars.githubusercontent.com/u/415?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},"repo":{"id":21034607,"name":"Ghost","full_name":"kevinansfield/Ghost","owner":{"login":"kevinansfield","id":415,"avatar_url":"https://avatars.githubusercontent.com/u/415?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinansfield/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/kevinansfield/Ghost","forks_url":"https://api.github.com/repos/kevinansfield/Ghost/forks","keys_url":"https://api.github.com/repos/kevinansfield/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinansfield/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinansfield/Ghost/teams","hooks_url":"https://api.github.com/repos/kevinansfield/Ghost/hooks","issue_events_url":"https://api.github.com/repos/kevinansfield/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/kevinansfield/Ghost/events","assignees_url":"https://api.github.com/repos/kevinansfield/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/kevinansfield/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/kevinansfield/Ghost/tags","blobs_url":"https://api.github.com/repos/kevinansfield/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinansfield/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinansfield/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinansfield/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinansfield/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinansfield/Ghost/languages","stargazers_url":"https://api.github.com/repos/kevinansfield/Ghost/stargazers","contributors_url":"https://api.github.com/repos/kevinansfield/Ghost/contributors","subscribers_url":"https://api.github.com/repos/kevinansfield/Ghost/subscribers","subscription_url":"https://api.github.com/repos/kevinansfield/Ghost/subscription","commits_url":"https://api.github.com/repos/kevinansfield/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinansfield/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinansfield/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinansfield/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinansfield/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/kevinansfield/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinansfield/Ghost/merges","archive_url":"https://api.github.com/repos/kevinansfield/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinansfield/Ghost/downloads","issues_url":"https://api.github.com/repos/kevinansfield/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/kevinansfield/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinansfield/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinansfield/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinansfield/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/kevinansfield/Ghost/releases{/id}","created_at":"2014-06-20T10:47:17Z","updated_at":"2014-06-29T17:41:21Z","pushed_at":"2015-08-19T11:22:39Z","git_url":"git://github.com/kevinansfield/Ghost.git","ssh_url":"git@github.com:kevinansfield/Ghost.git","clone_url":"https://github.com/kevinansfield/Ghost.git","svn_url":"https://github.com/kevinansfield/Ghost","homepage":"https://ghost.org","size":17587,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"24b8605c5208c2fbdefb68fceb7db3662225ed4f","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"Just a blogging platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","created_at":"2013-05-04T11:09:13Z","updated_at":"2015-08-19T09:10:54Z","pushed_at":"2015-08-19T11:23:07Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":66031,"stargazers_count":16277,"watchers_count":16277,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3902,"mirror_url":null,"open_issues_count":221,"forks":3902,"open_issues":221,"watchers":16277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/5680"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/5680"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/5680"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/5680/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/5680/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/5680/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/8178215b8c3b9620b9d0d43fa6dd1e167accc2d0"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":6,"additions":598,"deletions":5,"changed_files":8}}