{"action":"created","issue":{"url":"https://api.github.com/repos/servo/mozjs/issues/54","labels_url":"https://api.github.com/repos/servo/mozjs/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/servo/mozjs/issues/54/comments","events_url":"https://api.github.com/repos/servo/mozjs/issues/54/events","html_url":"https://github.com/servo/mozjs/pull/54","id":107739070,"number":54,"title":"Fix build under MSYS2/MINGW64","user":{"login":"vvuk","id":194965,"avatar_url":"https://avatars.githubusercontent.com/u/194965?v=3","gravatar_id":"","url":"https://api.github.com/users/vvuk","html_url":"https://github.com/vvuk","followers_url":"https://api.github.com/users/vvuk/followers","following_url":"https://api.github.com/users/vvuk/following{/other_user}","gists_url":"https://api.github.com/users/vvuk/gists{/gist_id}","starred_url":"https://api.github.com/users/vvuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvuk/subscriptions","organizations_url":"https://api.github.com/users/vvuk/orgs","repos_url":"https://api.github.com/users/vvuk/repos","events_url":"https://api.github.com/users/vvuk/events{/privacy}","received_events_url":"https://api.github.com/users/vvuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-09-22T15:27:33Z","updated_at":"2015-10-19T18:40:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/mozjs/pulls/54","html_url":"https://github.com/servo/mozjs/pull/54","diff_url":"https://github.com/servo/mozjs/pull/54.diff","patch_url":"https://github.com/servo/mozjs/pull/54.patch"},"body":"This is a set of changes needed to build mozjs under msys2/mingw64.\r\n\r\nCore changes:\r\n- Allow building with msys make\r\n- Don't strip \"lib\" prefix from library names\r\n- Use system nspr with correct lib names (nspr-config gives incorrect values)\r\n- Force using native win32 python instead of the mingw64/msys python\r\n\r\nI'm not really happy with these changes since these are all basically core m-c js files, and I don't think we could take some of these changes in m-c.  But, the majority of changes are correct or are resolving deeper issues in the m-c build system (e.g. the need to use the native win32 python instead of the msys one).\r\n\r\nThe ICU libprefix stuff can probably be resolved a different way, I just wasn't sure how to go about it.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/mozjs/54)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/mozjs/issues/comments/149308578","html_url":"https://github.com/servo/mozjs/pull/54#issuecomment-149308578","issue_url":"https://api.github.com/repos/servo/mozjs/issues/54","id":149308578,"user":{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T18:40:59Z","updated_at":"2015-10-19T18:40:59Z","body":"I appreciate the extra comments in the weird spots. There are still two comments that appear unanswered.\n\nIn makefile.cargo on line 49 there is a hardcoded path, which I asked if that was guaranteed to be there.\n\nIn the icu makefile there seems to be a typo between \"lib\" and \"libs\" in the two branches. Is that intentional or an error?\n<!-- Reviewable comment -K10O4UIC0NNifZBSELD:-1480099863 -->\n\n---\n\nReviewed 5 of 6 files at r2, 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[build.rs, line 23 \\[r3\\]](https://reviewable.io:443/reviews/servo/mozjs/54#-K10Mv56A_M6Ff694Zge)** ([raw file](https://github.com/servo/mozjs/blob/265c176471e5df0a9025add3ebf6e42394cad10b/build.rs#L23)):</sup>\nWhy do we only need to link nspr on windows?\n<!-- Reviewable comment -K10Mv571TyyTXWLxnjt:-1402763467 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/mozjs/54)\n<!-- Sent from Reviewable.io -->\n"}}