{"action":"created","comment":{"url":"https://api.github.com/repos/vcmi/vcmi/pulls/comments/26006389","id":26006389,"diff_hunk":"@@ -466,6 +474,17 @@ namespace ETileType\n \t};\r\n }\r\n \r\n+namespace ETeleportChannelType\r\n+{\r\n+\tenum ETeleportChannelType\r\n+\t{\r\n+\t\tIMPASSABLE,\r\n+\t\tBIDIRECTIONAL,\r\n+\t\tUNIDIRECTIONAL,\r\n+\t\tMIXED\r\n+\t};\r\n+}\r\n+\r","path":"lib/GameConstants.h","position":29,"original_position":29,"commit_id":"f490ea1fcd8ae93cd4ba82a6153c038b44e32ff0","original_commit_id":"6d77322d6a604276798604e9824bef74d188d544","user":{"login":"alexvins","id":1083924,"avatar_url":"https://avatars.githubusercontent.com/u/1083924?v=3","gravatar_id":"","url":"https://api.github.com/users/alexvins","html_url":"https://github.com/alexvins","followers_url":"https://api.github.com/users/alexvins/followers","following_url":"https://api.github.com/users/alexvins/following{/other_user}","gists_url":"https://api.github.com/users/alexvins/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvins/subscriptions","organizations_url":"https://api.github.com/users/alexvins/orgs","repos_url":"https://api.github.com/users/alexvins/repos","events_url":"https://api.github.com/users/alexvins/events{/privacy}","received_events_url":"https://api.github.com/users/alexvins/received_events","type":"User","site_admin":false},"body":"Use strongly-typed enum. ","created_at":"2015-03-08T16:07:48Z","updated_at":"2015-03-08T16:07:48Z","html_url":"https://github.com/vcmi/vcmi/pull/93#discussion_r26006389","pull_request_url":"https://api.github.com/repos/vcmi/vcmi/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/comments/26006389"},"html":{"href":"https://github.com/vcmi/vcmi/pull/93#discussion_r26006389"},"pull_request":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/vcmi/vcmi/pulls/93","id":30721076,"html_url":"https://github.com/vcmi/vcmi/pull/93","diff_url":"https://github.com/vcmi/vcmi/pull/93.diff","patch_url":"https://github.com/vcmi/vcmi/pull/93.patch","issue_url":"https://api.github.com/repos/vcmi/vcmi/issues/93","number":93,"state":"open","locked":false,"title":"Teleport channels and pathfinding via teleports","user":{"login":"ArseniyShestakov","id":9513350,"avatar_url":"https://avatars.githubusercontent.com/u/9513350?v=3","gravatar_id":"","url":"https://api.github.com/users/ArseniyShestakov","html_url":"https://github.com/ArseniyShestakov","followers_url":"https://api.github.com/users/ArseniyShestakov/followers","following_url":"https://api.github.com/users/ArseniyShestakov/following{/other_user}","gists_url":"https://api.github.com/users/ArseniyShestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ArseniyShestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArseniyShestakov/subscriptions","organizations_url":"https://api.github.com/users/ArseniyShestakov/orgs","repos_url":"https://api.github.com/users/ArseniyShestakov/repos","events_url":"https://api.github.com/users/ArseniyShestakov/events{/privacy}","received_events_url":"https://api.github.com/users/ArseniyShestakov/received_events","type":"User","site_admin":false},"body":"This one of course break saves compatibility. For now this code is stable except I break something while split changes into more logical commits. I'd tested it on some quite long AI game and they didn't manage to crash it.\r\n\r\nThere at least one possible problem exist: as in H3 mechanics heroes may start exchange within subterranean gates. Of course this can't happen accidentally because AI not going to explore \"busy\" gates and may only go there is he actually wanted to initiate this exchange, but I have feeling that it's works not the way as AI code expect it.\r\n\r\nMore detailed discussions may be found there:\r\nhttp://forum.vcmi.eu/viewtopic.php?t=1051\r\nhttps://github.com/ArseniyShestakov/vcmi/pull/2","created_at":"2015-03-08T15:19:04Z","updated_at":"2015-03-08T16:07:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"350d403d1dd3c40be7228f5e37c5393d4f9e37cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vcmi/vcmi/pulls/93/commits","review_comments_url":"https://api.github.com/repos/vcmi/vcmi/pulls/93/comments","review_comment_url":"https://api.github.com/repos/vcmi/vcmi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vcmi/vcmi/issues/93/comments","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/f490ea1fcd8ae93cd4ba82a6153c038b44e32ff0","head":{"label":"ArseniyShestakov:feature/pathfindingTeleports","ref":"feature/pathfindingTeleports","sha":"f490ea1fcd8ae93cd4ba82a6153c038b44e32ff0","user":{"login":"ArseniyShestakov","id":9513350,"avatar_url":"https://avatars.githubusercontent.com/u/9513350?v=3","gravatar_id":"","url":"https://api.github.com/users/ArseniyShestakov","html_url":"https://github.com/ArseniyShestakov","followers_url":"https://api.github.com/users/ArseniyShestakov/followers","following_url":"https://api.github.com/users/ArseniyShestakov/following{/other_user}","gists_url":"https://api.github.com/users/ArseniyShestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ArseniyShestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArseniyShestakov/subscriptions","organizations_url":"https://api.github.com/users/ArseniyShestakov/orgs","repos_url":"https://api.github.com/users/ArseniyShestakov/repos","events_url":"https://api.github.com/users/ArseniyShestakov/events{/privacy}","received_events_url":"https://api.github.com/users/ArseniyShestakov/received_events","type":"User","site_admin":false},"repo":{"id":27022927,"name":"vcmi","full_name":"ArseniyShestakov/vcmi","owner":{"login":"ArseniyShestakov","id":9513350,"avatar_url":"https://avatars.githubusercontent.com/u/9513350?v=3","gravatar_id":"","url":"https://api.github.com/users/ArseniyShestakov","html_url":"https://github.com/ArseniyShestakov","followers_url":"https://api.github.com/users/ArseniyShestakov/followers","following_url":"https://api.github.com/users/ArseniyShestakov/following{/other_user}","gists_url":"https://api.github.com/users/ArseniyShestakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ArseniyShestakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArseniyShestakov/subscriptions","organizations_url":"https://api.github.com/users/ArseniyShestakov/orgs","repos_url":"https://api.github.com/users/ArseniyShestakov/repos","events_url":"https://api.github.com/users/ArseniyShestakov/events{/privacy}","received_events_url":"https://api.github.com/users/ArseniyShestakov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArseniyShestakov/vcmi","description":"Open-source engine for Heroes of Might and Magic III","fork":true,"url":"https://api.github.com/repos/ArseniyShestakov/vcmi","forks_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/forks","keys_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/teams","hooks_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/hooks","issue_events_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/issues/events{/number}","events_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/events","assignees_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/assignees{/user}","branches_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/branches{/branch}","tags_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/tags","blobs_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/statuses/{sha}","languages_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/languages","stargazers_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/stargazers","contributors_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/contributors","subscribers_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/subscribers","subscription_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/subscription","commits_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/contents/{+path}","compare_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/merges","archive_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/downloads","issues_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/issues{/number}","pulls_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/pulls{/number}","milestones_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/milestones{/number}","notifications_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/labels{/name}","releases_url":"https://api.github.com/repos/ArseniyShestakov/vcmi/releases{/id}","created_at":"2014-11-23T05:23:00Z","updated_at":"2015-02-23T21:17:36Z","pushed_at":"2015-03-08T15:36:37Z","git_url":"git://github.com/ArseniyShestakov/vcmi.git","ssh_url":"git@github.com:ArseniyShestakov/vcmi.git","clone_url":"https://github.com/ArseniyShestakov/vcmi.git","svn_url":"https://github.com/ArseniyShestakov/vcmi","homepage":"http://vcmi.eu/","size":28103,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"vcmi:develop","ref":"develop","sha":"6ace53d8b9c8b4a6a000fdf8fb1aebdbb242600f","user":{"login":"vcmi","id":2861395,"avatar_url":"https://avatars.githubusercontent.com/u/2861395?v=3","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"repo":{"id":18490421,"name":"vcmi","full_name":"vcmi/vcmi","owner":{"login":"vcmi","id":2861395,"avatar_url":"https://avatars.githubusercontent.com/u/2861395?v=3","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vcmi/vcmi","description":"Open-source engine for Heroes of Might and Magic III","fork":false,"url":"https://api.github.com/repos/vcmi/vcmi","forks_url":"https://api.github.com/repos/vcmi/vcmi/forks","keys_url":"https://api.github.com/repos/vcmi/vcmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcmi/vcmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcmi/vcmi/teams","hooks_url":"https://api.github.com/repos/vcmi/vcmi/hooks","issue_events_url":"https://api.github.com/repos/vcmi/vcmi/issues/events{/number}","events_url":"https://api.github.com/repos/vcmi/vcmi/events","assignees_url":"https://api.github.com/repos/vcmi/vcmi/assignees{/user}","branches_url":"https://api.github.com/repos/vcmi/vcmi/branches{/branch}","tags_url":"https://api.github.com/repos/vcmi/vcmi/tags","blobs_url":"https://api.github.com/repos/vcmi/vcmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcmi/vcmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcmi/vcmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcmi/vcmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/{sha}","languages_url":"https://api.github.com/repos/vcmi/vcmi/languages","stargazers_url":"https://api.github.com/repos/vcmi/vcmi/stargazers","contributors_url":"https://api.github.com/repos/vcmi/vcmi/contributors","subscribers_url":"https://api.github.com/repos/vcmi/vcmi/subscribers","subscription_url":"https://api.github.com/repos/vcmi/vcmi/subscription","commits_url":"https://api.github.com/repos/vcmi/vcmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcmi/vcmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcmi/vcmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcmi/vcmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcmi/vcmi/contents/{+path}","compare_url":"https://api.github.com/repos/vcmi/vcmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcmi/vcmi/merges","archive_url":"https://api.github.com/repos/vcmi/vcmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcmi/vcmi/downloads","issues_url":"https://api.github.com/repos/vcmi/vcmi/issues{/number}","pulls_url":"https://api.github.com/repos/vcmi/vcmi/pulls{/number}","milestones_url":"https://api.github.com/repos/vcmi/vcmi/milestones{/number}","notifications_url":"https://api.github.com/repos/vcmi/vcmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcmi/vcmi/labels{/name}","releases_url":"https://api.github.com/repos/vcmi/vcmi/releases{/id}","created_at":"2014-04-06T13:42:23Z","updated_at":"2015-03-07T06:32:23Z","pushed_at":"2015-03-01T12:27:03Z","git_url":"git://github.com/vcmi/vcmi.git","ssh_url":"git@github.com:vcmi/vcmi.git","clone_url":"https://github.com/vcmi/vcmi.git","svn_url":"https://github.com/vcmi/vcmi","homepage":"http://vcmi.eu/","size":30207,"stargazers_count":168,"watchers_count":168,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":3,"forks":43,"open_issues":3,"watchers":168,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/93"},"html":{"href":"https://github.com/vcmi/vcmi/pull/93"},"issue":{"href":"https://api.github.com/repos/vcmi/vcmi/issues/93"},"comments":{"href":"https://api.github.com/repos/vcmi/vcmi/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/vcmi/vcmi/statuses/f490ea1fcd8ae93cd4ba82a6153c038b44e32ff0"}}}}