{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/36240943","id":36240943,"diff_hunk":"@@ -460,13 +457,13 @@ ComputedPropertyPrototype._set = function computedPropertySet(obj, keyName, valu\n /* called before property is overridden */\n ComputedPropertyPrototype.teardown = function(obj, keyName) {\n   var meta = metaFor(obj);\n-\n-  if (meta.cache) {\n-    if (keyName in meta.cache) {\n+  let cache = meta.readableCache();\n+  if (cache) {\n+    if (keyName in cache) {","path":"packages/ember-metal/lib/computed.js","position":97,"original_position":97,"commit_id":"714f0b8b7d4c95d18b561845493cc031d182eec7","original_commit_id":"714f0b8b7d4c95d18b561845493cc031d182eec7","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"if I recall, the cache will never have an undefined member representing the value of undefined, rather it will use the UNDEFINED sentinel value. This means, we can likely just do (the unfortunately faster) `if (cache[keyName] !== undefined)`","created_at":"2015-08-04T20:58:26Z","updated_at":"2015-08-04T20:58:26Z","html_url":"https://github.com/emberjs/ember.js/pull/11966#discussion_r36240943","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11966","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/36240943"},"html":{"href":"https://github.com/emberjs/ember.js/pull/11966#discussion_r36240943"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11966"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/11966","id":41453827,"html_url":"https://github.com/emberjs/ember.js/pull/11966","diff_url":"https://github.com/emberjs/ember.js/pull/11966.diff","patch_url":"https://github.com/emberjs/ember.js/pull/11966.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/11966","number":11966,"state":"open","locked":false,"title":"[BUGFIX canary] Meta refactor","user":{"login":"ef4","id":319282,"avatar_url":"https://avatars.githubusercontent.com/u/319282?v=3","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"body":"This refactors the meta object as a step toward optimizing it better.\r\n\r\n - consolidates and encapsulates meta's data structures so we can more easily replace them\r\n - switches to explicit inheritance between meta objects over prototypical inheritance, so we can pick and choose how each member is actually inherited, and choose to do optimizations.\r\n - refactors meta.listeners in an attempt to make listener creation and deletion cheaper, especially in terms of allocations. This is still an early sketch and more effort is needed to see if it's actually a good idea.\r\n\r\n\r\n","created_at":"2015-08-03T10:31:11Z","updated_at":"2015-08-04T20:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a262ae28a239bbf39975b4e6582ead54cfb882","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11966/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11966/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/11966/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/714f0b8b7d4c95d18b561845493cc031d182eec7","head":{"label":"ef4:meta-sanity","ref":"meta-sanity","sha":"714f0b8b7d4c95d18b561845493cc031d182eec7","user":{"login":"ef4","id":319282,"avatar_url":"https://avatars.githubusercontent.com/u/319282?v=3","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"repo":{"id":1992464,"name":"ember.js","full_name":"ef4/ember.js","owner":{"login":"ef4","id":319282,"avatar_url":"https://avatars.githubusercontent.com/u/319282?v=3","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ef4/ember.js","description":"","fork":true,"url":"https://api.github.com/repos/ef4/ember.js","forks_url":"https://api.github.com/repos/ef4/ember.js/forks","keys_url":"https://api.github.com/repos/ef4/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ef4/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ef4/ember.js/teams","hooks_url":"https://api.github.com/repos/ef4/ember.js/hooks","issue_events_url":"https://api.github.com/repos/ef4/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/ef4/ember.js/events","assignees_url":"https://api.github.com/repos/ef4/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/ef4/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/ef4/ember.js/tags","blobs_url":"https://api.github.com/repos/ef4/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ef4/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ef4/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ef4/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ef4/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ef4/ember.js/languages","stargazers_url":"https://api.github.com/repos/ef4/ember.js/stargazers","contributors_url":"https://api.github.com/repos/ef4/ember.js/contributors","subscribers_url":"https://api.github.com/repos/ef4/ember.js/subscribers","subscription_url":"https://api.github.com/repos/ef4/ember.js/subscription","commits_url":"https://api.github.com/repos/ef4/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ef4/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ef4/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ef4/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ef4/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/ef4/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ef4/ember.js/merges","archive_url":"https://api.github.com/repos/ef4/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ef4/ember.js/downloads","issues_url":"https://api.github.com/repos/ef4/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/ef4/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ef4/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ef4/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ef4/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/ef4/ember.js/releases{/id}","created_at":"2011-07-03T20:35:47Z","updated_at":"2015-05-08T02:53:10Z","pushed_at":"2015-08-04T01:53:28Z","git_url":"git://github.com/ef4/ember.js.git","ssh_url":"git@github.com:ef4/ember.js.git","clone_url":"https://github.com/ef4/ember.js.git","svn_url":"https://github.com/ef4/ember.js","homepage":"","size":28581,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"adabda53318555e59509312bd5df3b9da58f3998","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-08-04T19:48:41Z","pushed_at":"2015-08-04T18:32:27Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":87967,"stargazers_count":14407,"watchers_count":14407,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3091,"mirror_url":null,"open_issues_count":357,"forks":3091,"open_issues":357,"watchers":14407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11966"},"html":{"href":"https://github.com/emberjs/ember.js/pull/11966"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/11966"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/11966/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11966/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11966/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/714f0b8b7d4c95d18b561845493cc031d182eec7"}}}}