{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/comments/30797961","id":30797961,"diff_hunk":"@@ -572,6 +574,49 @@ public void check( List<CheckResultInterface> remarks, JobMeta jobMeta, Variable\n     andValidator().validate( this, \"className\", remarks, putValidators( notBlankValidator() ) );\n   }\n \n+  /**\n+   * Parse a string into arguments as if it were provided on the command line.\n+   *\n+   * @param commandLineString\n+   *          A command line string.\n+   * @return List of parsed arguments\n+   * @throws IOException\n+   *           when the command line could not be parsed\n+   */\n+  public List<String> parseCommandLine( String commandLineString ) throws IOException {\n+    List<String> args = new ArrayList<String>();\n+    StringReader reader = new StringReader( commandLineString );\n+    try {\n+      StreamTokenizer tokenizer = new StreamTokenizer( reader );\n+      // Treat a dash as an ordinary character so it gets included in the token\n+      tokenizer.ordinaryChar( '-' );\n+      tokenizer.ordinaryChar( '.' );\n+      tokenizer.ordinaryChars( '0', '9' );\n+      // Treat all characters as word characters so nothing is parsed out\n+      tokenizer.wordChars( '\\u0000', '\\uFFFF' );","path":"src/main/java/org/pentaho/di/job/entries/spark/JobEntrySparkSubmit.java","position":94,"original_position":94,"commit_id":"e7c65495fd6ce10cc7515435529af959e1bec30f","original_commit_id":"e7c65495fd6ce10cc7515435529af959e1bec30f","user":{"login":"pavel-sakun","id":1180923,"avatar_url":"https://avatars.githubusercontent.com/u/1180923?v=3","gravatar_id":"","url":"https://api.github.com/users/pavel-sakun","html_url":"https://github.com/pavel-sakun","followers_url":"https://api.github.com/users/pavel-sakun/followers","following_url":"https://api.github.com/users/pavel-sakun/following{/other_user}","gists_url":"https://api.github.com/users/pavel-sakun/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-sakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-sakun/subscriptions","organizations_url":"https://api.github.com/users/pavel-sakun/orgs","repos_url":"https://api.github.com/users/pavel-sakun/repos","events_url":"https://api.github.com/users/pavel-sakun/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-sakun/received_events","type":"User","site_admin":false},"body":"It takes care of 0000-FFFF which seems sufficient.","created_at":"2015-05-21T12:48:37Z","updated_at":"2015-05-21T12:48:37Z","html_url":"https://github.com/pentaho/pdi-spark-plugin/pull/8#discussion_r30797961","pull_request_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/comments/30797961"},"html":{"href":"https://github.com/pentaho/pdi-spark-plugin/pull/8#discussion_r30797961"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8","id":34813612,"html_url":"https://github.com/pentaho/pdi-spark-plugin/pull/8","diff_url":"https://github.com/pentaho/pdi-spark-plugin/pull/8.diff","patch_url":"https://github.com/pentaho/pdi-spark-plugin/pull/8.patch","issue_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues/8","number":8,"state":"open","locked":false,"title":"Recognize single and double quoted arguments.","user":{"login":"pavel-sakun","id":1180923,"avatar_url":"https://avatars.githubusercontent.com/u/1180923?v=3","gravatar_id":"","url":"https://api.github.com/users/pavel-sakun","html_url":"https://github.com/pavel-sakun","followers_url":"https://api.github.com/users/pavel-sakun/followers","following_url":"https://api.github.com/users/pavel-sakun/following{/other_user}","gists_url":"https://api.github.com/users/pavel-sakun/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-sakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-sakun/subscriptions","organizations_url":"https://api.github.com/users/pavel-sakun/orgs","repos_url":"https://api.github.com/users/pavel-sakun/repos","events_url":"https://api.github.com/users/pavel-sakun/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-sakun/received_events","type":"User","site_admin":false},"body":"@mattyb149","created_at":"2015-05-06T12:56:45Z","updated_at":"2015-05-21T12:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6d4e7451abc9c7ffe8fecf175aee7889ee82b8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8/commits","review_comments_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8/comments","review_comment_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues/8/comments","statuses_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/statuses/e7c65495fd6ce10cc7515435529af959e1bec30f","head":{"label":"pavel-sakun:master","ref":"master","sha":"e7c65495fd6ce10cc7515435529af959e1bec30f","user":{"login":"pavel-sakun","id":1180923,"avatar_url":"https://avatars.githubusercontent.com/u/1180923?v=3","gravatar_id":"","url":"https://api.github.com/users/pavel-sakun","html_url":"https://github.com/pavel-sakun","followers_url":"https://api.github.com/users/pavel-sakun/followers","following_url":"https://api.github.com/users/pavel-sakun/following{/other_user}","gists_url":"https://api.github.com/users/pavel-sakun/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-sakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-sakun/subscriptions","organizations_url":"https://api.github.com/users/pavel-sakun/orgs","repos_url":"https://api.github.com/users/pavel-sakun/repos","events_url":"https://api.github.com/users/pavel-sakun/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-sakun/received_events","type":"User","site_admin":false},"repo":{"id":33737780,"name":"pdi-spark-plugin","full_name":"pavel-sakun/pdi-spark-plugin","owner":{"login":"pavel-sakun","id":1180923,"avatar_url":"https://avatars.githubusercontent.com/u/1180923?v=3","gravatar_id":"","url":"https://api.github.com/users/pavel-sakun","html_url":"https://github.com/pavel-sakun","followers_url":"https://api.github.com/users/pavel-sakun/followers","following_url":"https://api.github.com/users/pavel-sakun/following{/other_user}","gists_url":"https://api.github.com/users/pavel-sakun/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-sakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-sakun/subscriptions","organizations_url":"https://api.github.com/users/pavel-sakun/orgs","repos_url":"https://api.github.com/users/pavel-sakun/repos","events_url":"https://api.github.com/users/pavel-sakun/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-sakun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavel-sakun/pdi-spark-plugin","description":"","fork":true,"url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin","forks_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/forks","keys_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/teams","hooks_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/hooks","issue_events_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/events","assignees_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/tags","blobs_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/languages","stargazers_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/stargazers","contributors_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/contributors","subscribers_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/subscribers","subscription_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/subscription","commits_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/merges","archive_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/downloads","issues_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/labels{/name}","releases_url":"https://api.github.com/repos/pavel-sakun/pdi-spark-plugin/releases{/id}","created_at":"2015-04-10T16:07:23Z","updated_at":"2015-05-06T12:55:31Z","pushed_at":"2015-05-13T16:46:00Z","git_url":"git://github.com/pavel-sakun/pdi-spark-plugin.git","ssh_url":"git@github.com:pavel-sakun/pdi-spark-plugin.git","clone_url":"https://github.com/pavel-sakun/pdi-spark-plugin.git","svn_url":"https://github.com/pavel-sakun/pdi-spark-plugin","homepage":null,"size":200,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"8ec9ea0bb61d516d6fd5c0ce44c4cbcaa0c75a7b","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":33730091,"name":"pdi-spark-plugin","full_name":"pentaho/pdi-spark-plugin","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pdi-spark-plugin","description":"","fork":false,"url":"https://api.github.com/repos/pentaho/pdi-spark-plugin","forks_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/forks","keys_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/teams","hooks_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/events","assignees_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/tags","blobs_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/languages","stargazers_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/subscription","commits_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/merges","archive_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/downloads","issues_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pdi-spark-plugin/releases{/id}","created_at":"2015-04-10T13:32:11Z","updated_at":"2015-05-08T03:24:56Z","pushed_at":"2015-05-19T13:33:51Z","git_url":"git://github.com/pentaho/pdi-spark-plugin.git","ssh_url":"git@github.com:pentaho/pdi-spark-plugin.git","clone_url":"https://github.com/pentaho/pdi-spark-plugin.git","svn_url":"https://github.com/pentaho/pdi-spark-plugin","homepage":null,"size":417,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8"},"html":{"href":"https://github.com/pentaho/pdi-spark-plugin/pull/8"},"issue":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues/8"},"comments":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pdi-spark-plugin/statuses/e7c65495fd6ce10cc7515435529af959e1bec30f"}}}}