{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/20165","labels_url":"https://api.github.com/repos/saltstack/salt/issues/20165/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/20165/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/20165/events","html_url":"https://github.com/saltstack/salt/issues/20165","id":55824173,"number":20165,"title":"Feature: support multiple unless statements","user":{"login":"notpeter","id":145113,"avatar_url":"https://avatars.githubusercontent.com/u/145113?v=3","gravatar_id":"","url":"https://api.github.com/users/notpeter","html_url":"https://github.com/notpeter","followers_url":"https://api.github.com/users/notpeter/followers","following_url":"https://api.github.com/users/notpeter/following{/other_user}","gists_url":"https://api.github.com/users/notpeter/gists{/gist_id}","starred_url":"https://api.github.com/users/notpeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notpeter/subscriptions","organizations_url":"https://api.github.com/users/notpeter/orgs","repos_url":"https://api.github.com/users/notpeter/repos","events_url":"https://api.github.com/users/notpeter/events{/privacy}","received_events_url":"https://api.github.com/users/notpeter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-28T22:15:59Z","updated_at":"2015-01-29T18:27:10Z","closed_at":null,"body":"Currently unless statements are only valid as a single line:\r\n\r\n    unless: test -f /whatever && grep Working /whatever/a.log\r\n\r\nIf you provide a dictionary, unless silently succeeds without running any command (bug?):\r\n\r\n    unless:\r\n        - test -f /whatever && grep Working /whatever/a.log\r\n\r\nI think it'd be relatively sane to support a dictionary of statements under unless which are && together at runtime. So the following format would be equivalent to either of the above. \r\n\r\n    unless:\r\n        - test -f /whatever\r\n        - grep Working /whatever/a.log"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/72077097","html_url":"https://github.com/saltstack/salt/issues/20165#issuecomment-72077097","issue_url":"https://api.github.com/repos/saltstack/salt/issues/20165","id":72077097,"user":{"login":"basepi","id":702318,"avatar_url":"https://avatars.githubusercontent.com/u/702318?v=3","gravatar_id":"","url":"https://api.github.com/users/basepi","html_url":"https://github.com/basepi","followers_url":"https://api.github.com/users/basepi/followers","following_url":"https://api.github.com/users/basepi/following{/other_user}","gists_url":"https://api.github.com/users/basepi/gists{/gist_id}","starred_url":"https://api.github.com/users/basepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basepi/subscriptions","organizations_url":"https://api.github.com/users/basepi/orgs","repos_url":"https://api.github.com/users/basepi/repos","events_url":"https://api.github.com/users/basepi/events{/privacy}","received_events_url":"https://api.github.com/users/basepi/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T18:27:10Z","updated_at":"2015-01-29T18:27:10Z","body":"Ya, I just wanted to clarify, your examples are lists, not dictionaries. `unless` is a key in the dictionary, containing a list of strings.\r\n\r\nBut the && vs || is a good question, in my brain, `onlyif` would be &&, and `unless` would be ||, because both of those decisions are conservative."}}