{"action":"created","comment":{"url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/comments/26983309","id":26983309,"diff_hunk":"@@ -46,22 +46,26 @@ clean:\n \t@echo \"---------------------------------------------\"\n \trm -rf dist/ build/ rpmbuild/ rpms/ *~ ../$(PACKAGE).spec\n \n-sdist:\n+../ztpserver.spec: ../VERSION\n \t@cp $(RPMSPEC) ../$(PACKAGE).spec\n \t@sed -i -e 's/^Version:.*/Version: $(SPECVERSION)/g' ../$(PACKAGE).spec\n \t@sed -i -e 's/^Release:.*/Release: $(RPMRELEASE)%{?dist}/g' ../$(PACKAGE).spec\n-\tmkdir -p dist/\n-\t@ln -s ../../../${PACKAGE} dist/${PACKAGE}-${SPECVERSION}\n-\ttar --directory=dist --dereference -czf dist/${PACKAGE}-${SPECVERSION}.tgz ${PACKAGE}-${SPECVERSION} --exclude=rpm --exclude=.git --exclude=.gitignore --exclude=ztpserver.egg-info\n-\t@rm dist/${PACKAGE}-${SPECVERSION}\n-\tcp ${HTTPDCONF} dist/${HTTPDCONF}\n+\t#mkdir -p dist/","path":"rpm/Makefile","position":34,"original_position":34,"commit_id":"fa92fc4e4bdd5772c04b8b46c708f77e52bbdb4d","original_commit_id":"fa92fc4e4bdd5772c04b8b46c708f77e52bbdb4d","user":{"login":"advornic","id":4182868,"avatar_url":"https://avatars.githubusercontent.com/u/4182868?v=3","gravatar_id":"","url":"https://api.github.com/users/advornic","html_url":"https://github.com/advornic","followers_url":"https://api.github.com/users/advornic/followers","following_url":"https://api.github.com/users/advornic/following{/other_user}","gists_url":"https://api.github.com/users/advornic/gists{/gist_id}","starred_url":"https://api.github.com/users/advornic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advornic/subscriptions","organizations_url":"https://api.github.com/users/advornic/orgs","repos_url":"https://api.github.com/users/advornic/repos","events_url":"https://api.github.com/users/advornic/events{/privacy}","received_events_url":"https://api.github.com/users/advornic/received_events","type":"User","site_admin":false},"body":"are these commented out - can we add a comment about why?","created_at":"2015-03-23T21:41:41Z","updated_at":"2015-03-23T21:41:41Z","html_url":"https://github.com/arista-eosplus/ztpserver/pull/300#discussion_r26983309","pull_request_url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300","_links":{"self":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/comments/26983309"},"html":{"href":"https://github.com/arista-eosplus/ztpserver/pull/300#discussion_r26983309"},"pull_request":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300"}}},"pull_request":{"url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300","id":31769870,"html_url":"https://github.com/arista-eosplus/ztpserver/pull/300","diff_url":"https://github.com/arista-eosplus/ztpserver/pull/300.diff","patch_url":"https://github.com/arista-eosplus/ztpserver/pull/300.patch","issue_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/300","number":300,"state":"open","locked":false,"title":"Hotfix 1.3.2","user":{"login":"jerearista","id":7839104,"avatar_url":"https://avatars.githubusercontent.com/u/7839104?v=3","gravatar_id":"","url":"https://api.github.com/users/jerearista","html_url":"https://github.com/jerearista","followers_url":"https://api.github.com/users/jerearista/followers","following_url":"https://api.github.com/users/jerearista/following{/other_user}","gists_url":"https://api.github.com/users/jerearista/gists{/gist_id}","starred_url":"https://api.github.com/users/jerearista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerearista/subscriptions","organizations_url":"https://api.github.com/users/jerearista/orgs","repos_url":"https://api.github.com/users/jerearista/repos","events_url":"https://api.github.com/users/jerearista/events{/privacy}","received_events_url":"https://api.github.com/users/jerearista/received_events","type":"User","site_admin":false},"body":"* An RPM upgrade could erase existing config files\r\n* RPM Versions can only take the numeric portions of a version (Ex 1.4 from 1.4-dev).  Updated Regex in rpm/Makefile\r\n* Quiet the output of chcon during RPM install\r\n* Resolve issues from consolidation of version info\r\n* 'make rpm' and 'make srpm' are now top-level citizens and should no-longer be run from the rpm/ dir.","created_at":"2015-03-23T20:18:27Z","updated_at":"2015-03-23T21:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300/commits","review_comments_url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300/comments","review_comment_url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/300/comments","statuses_url":"https://api.github.com/repos/arista-eosplus/ztpserver/statuses/fa92fc4e4bdd5772c04b8b46c708f77e52bbdb4d","head":{"label":"arista-eosplus:hotfix-1.3.2","ref":"hotfix-1.3.2","sha":"fa92fc4e4bdd5772c04b8b46c708f77e52bbdb4d","user":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"repo":{"id":16963305,"name":"ztpserver","full_name":"arista-eosplus/ztpserver","owner":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arista-eosplus/ztpserver","description":"Full service ZTP Server implementation for bootstrapping Arista EOS nodes","fork":false,"url":"https://api.github.com/repos/arista-eosplus/ztpserver","forks_url":"https://api.github.com/repos/arista-eosplus/ztpserver/forks","keys_url":"https://api.github.com/repos/arista-eosplus/ztpserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arista-eosplus/ztpserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arista-eosplus/ztpserver/teams","hooks_url":"https://api.github.com/repos/arista-eosplus/ztpserver/hooks","issue_events_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/events{/number}","events_url":"https://api.github.com/repos/arista-eosplus/ztpserver/events","assignees_url":"https://api.github.com/repos/arista-eosplus/ztpserver/assignees{/user}","branches_url":"https://api.github.com/repos/arista-eosplus/ztpserver/branches{/branch}","tags_url":"https://api.github.com/repos/arista-eosplus/ztpserver/tags","blobs_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arista-eosplus/ztpserver/statuses/{sha}","languages_url":"https://api.github.com/repos/arista-eosplus/ztpserver/languages","stargazers_url":"https://api.github.com/repos/arista-eosplus/ztpserver/stargazers","contributors_url":"https://api.github.com/repos/arista-eosplus/ztpserver/contributors","subscribers_url":"https://api.github.com/repos/arista-eosplus/ztpserver/subscribers","subscription_url":"https://api.github.com/repos/arista-eosplus/ztpserver/subscription","commits_url":"https://api.github.com/repos/arista-eosplus/ztpserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/arista-eosplus/ztpserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/arista-eosplus/ztpserver/contents/{+path}","compare_url":"https://api.github.com/repos/arista-eosplus/ztpserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arista-eosplus/ztpserver/merges","archive_url":"https://api.github.com/repos/arista-eosplus/ztpserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arista-eosplus/ztpserver/downloads","issues_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues{/number}","pulls_url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls{/number}","milestones_url":"https://api.github.com/repos/arista-eosplus/ztpserver/milestones{/number}","notifications_url":"https://api.github.com/repos/arista-eosplus/ztpserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arista-eosplus/ztpserver/labels{/name}","releases_url":"https://api.github.com/repos/arista-eosplus/ztpserver/releases{/id}","created_at":"2014-02-18T20:51:54Z","updated_at":"2015-03-16T09:00:46Z","pushed_at":"2015-03-23T20:18:30Z","git_url":"git://github.com/arista-eosplus/ztpserver.git","ssh_url":"git@github.com:arista-eosplus/ztpserver.git","clone_url":"https://github.com/arista-eosplus/ztpserver.git","svn_url":"https://github.com/arista-eosplus/ztpserver","homepage":null,"size":7707,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":36,"forks":12,"open_issues":36,"watchers":21,"default_branch":"develop"}},"base":{"label":"arista-eosplus:develop","ref":"develop","sha":"92720003cb3aa0046d60b2c0210eba918b734a4c","user":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"repo":{"id":16963305,"name":"ztpserver","full_name":"arista-eosplus/ztpserver","owner":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arista-eosplus/ztpserver","description":"Full service ZTP Server implementation for bootstrapping Arista EOS nodes","fork":false,"url":"https://api.github.com/repos/arista-eosplus/ztpserver","forks_url":"https://api.github.com/repos/arista-eosplus/ztpserver/forks","keys_url":"https://api.github.com/repos/arista-eosplus/ztpserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arista-eosplus/ztpserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arista-eosplus/ztpserver/teams","hooks_url":"https://api.github.com/repos/arista-eosplus/ztpserver/hooks","issue_events_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/events{/number}","events_url":"https://api.github.com/repos/arista-eosplus/ztpserver/events","assignees_url":"https://api.github.com/repos/arista-eosplus/ztpserver/assignees{/user}","branches_url":"https://api.github.com/repos/arista-eosplus/ztpserver/branches{/branch}","tags_url":"https://api.github.com/repos/arista-eosplus/ztpserver/tags","blobs_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arista-eosplus/ztpserver/statuses/{sha}","languages_url":"https://api.github.com/repos/arista-eosplus/ztpserver/languages","stargazers_url":"https://api.github.com/repos/arista-eosplus/ztpserver/stargazers","contributors_url":"https://api.github.com/repos/arista-eosplus/ztpserver/contributors","subscribers_url":"https://api.github.com/repos/arista-eosplus/ztpserver/subscribers","subscription_url":"https://api.github.com/repos/arista-eosplus/ztpserver/subscription","commits_url":"https://api.github.com/repos/arista-eosplus/ztpserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/arista-eosplus/ztpserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/arista-eosplus/ztpserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/arista-eosplus/ztpserver/contents/{+path}","compare_url":"https://api.github.com/repos/arista-eosplus/ztpserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arista-eosplus/ztpserver/merges","archive_url":"https://api.github.com/repos/arista-eosplus/ztpserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arista-eosplus/ztpserver/downloads","issues_url":"https://api.github.com/repos/arista-eosplus/ztpserver/issues{/number}","pulls_url":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls{/number}","milestones_url":"https://api.github.com/repos/arista-eosplus/ztpserver/milestones{/number}","notifications_url":"https://api.github.com/repos/arista-eosplus/ztpserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arista-eosplus/ztpserver/labels{/name}","releases_url":"https://api.github.com/repos/arista-eosplus/ztpserver/releases{/id}","created_at":"2014-02-18T20:51:54Z","updated_at":"2015-03-16T09:00:46Z","pushed_at":"2015-03-23T20:18:30Z","git_url":"git://github.com/arista-eosplus/ztpserver.git","ssh_url":"git@github.com:arista-eosplus/ztpserver.git","clone_url":"https://github.com/arista-eosplus/ztpserver.git","svn_url":"https://github.com/arista-eosplus/ztpserver","homepage":null,"size":7707,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":36,"forks":12,"open_issues":36,"watchers":21,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300"},"html":{"href":"https://github.com/arista-eosplus/ztpserver/pull/300"},"issue":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/300"},"comments":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/arista-eosplus/ztpserver/statuses/fa92fc4e4bdd5772c04b8b46c708f77e52bbdb4d"}}}}