{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/3811","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/3811/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/3811/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/3811/events","html_url":"https://github.com/jekyll/jekyll/pull/3811","id":90494684,"number":3811,"title":"Remove unnecessary `ensure` in LiquidRenderer","user":{"login":"fw42","id":2072686,"avatar_url":"https://avatars.githubusercontent.com/u/2072686?v=3","gravatar_id":"","url":"https://api.github.com/users/fw42","html_url":"https://github.com/fw42","followers_url":"https://api.github.com/users/fw42/followers","following_url":"https://api.github.com/users/fw42/following{/other_user}","gists_url":"https://api.github.com/users/fw42/gists{/gist_id}","starred_url":"https://api.github.com/users/fw42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fw42/subscriptions","organizations_url":"https://api.github.com/users/fw42/orgs","repos_url":"https://api.github.com/users/fw42/repos","events_url":"https://api.github.com/users/fw42/events{/privacy}","received_events_url":"https://api.github.com/users/fw42/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-06-23T21:28:02Z","updated_at":"2015-07-16T00:36:37Z","closed_at":"2015-06-23T22:36:13Z","pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/3811","html_url":"https://github.com/jekyll/jekyll/pull/3811","diff_url":"https://github.com/jekyll/jekyll/pull/3811.diff","patch_url":"https://github.com/jekyll/jekyll/pull/3811.patch"},"body":"Fixes https://github.com/jekyll/jekyll/issues/3808.\r\n\r\nProblem is that the block that is being `yield`ed can raise an exception (`Liquid::SyntaxError` for example), in which case `str` is `nil` and the `ensure` part will try to call `nil.bytesize`. This makes it harder to debug the Liquid Errors.\r\n\r\nThe `ensure` is actually unnecessary, this PR removes it. A Liquid::SyntaxError should now just bubble up like we want to.\r\n\r\n@parkr @envygeeks "},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/121789717","html_url":"https://github.com/jekyll/jekyll/pull/3811#issuecomment-121789717","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/3811","id":121789717,"user":{"login":"fw42","id":2072686,"avatar_url":"https://avatars.githubusercontent.com/u/2072686?v=3","gravatar_id":"","url":"https://api.github.com/users/fw42","html_url":"https://github.com/fw42","followers_url":"https://api.github.com/users/fw42/followers","following_url":"https://api.github.com/users/fw42/following{/other_user}","gists_url":"https://api.github.com/users/fw42/gists{/gist_id}","starred_url":"https://api.github.com/users/fw42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fw42/subscriptions","organizations_url":"https://api.github.com/users/fw42/orgs","repos_url":"https://api.github.com/users/fw42/repos","events_url":"https://api.github.com/users/fw42/events{/privacy}","received_events_url":"https://api.github.com/users/fw42/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T00:36:36Z","updated_at":"2015-07-16T00:36:36Z","body":"> We still aren't getting liquid errors passed to us for some reason, even on beta8\r\n\r\ncan you give me an example site please where I can see this behaviour? or some other way how to reproduce this problem?"}}