{"action":"created","issue":{"url":"https://api.github.com/repos/OpenClimate/climate_change_model/issues/7","labels_url":"https://api.github.com/repos/OpenClimate/climate_change_model/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/OpenClimate/climate_change_model/issues/7/comments","events_url":"https://api.github.com/repos/OpenClimate/climate_change_model/issues/7/events","html_url":"https://github.com/OpenClimate/climate_change_model/pull/7","id":103980148,"number":7,"title":"New feature: data loaders for CO2 and temperature","user":{"login":"jonathanrocher","id":593945,"avatar_url":"https://avatars.githubusercontent.com/u/593945?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanrocher","html_url":"https://github.com/jonathanrocher","followers_url":"https://api.github.com/users/jonathanrocher/followers","following_url":"https://api.github.com/users/jonathanrocher/following{/other_user}","gists_url":"https://api.github.com/users/jonathanrocher/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanrocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanrocher/subscriptions","organizations_url":"https://api.github.com/users/jonathanrocher/orgs","repos_url":"https://api.github.com/users/jonathanrocher/repos","events_url":"https://api.github.com/users/jonathanrocher/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanrocher/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-31T03:49:40Z","updated_at":"2015-09-02T21:17:20Z","closed_at":"2015-09-02T16:11:08Z","pull_request":{"url":"https://api.github.com/repos/OpenClimate/climate_change_model/pulls/7","html_url":"https://github.com/OpenClimate/climate_change_model/pull/7","diff_url":"https://github.com/OpenClimate/climate_change_model/pull/7.diff","patch_url":"https://github.com/OpenClimate/climate_change_model/pull/7.patch"},"body":"Initial implementation of functions to read reference global CO2 and temperature data. Missing unit tests for now.\r\n\r\n@bbeckage: Feedback requested. In particular, I need confirmation that climateDat simply stores data from the other datasets (Mauna Loa and GISS) and there is no need for a function to load it.\r\n\r\n@jonathanrocher : yes your comment above is correct.\r\n\r\nAddresses issue #3 ."},"comment":{"url":"https://api.github.com/repos/OpenClimate/climate_change_model/issues/comments/137247270","html_url":"https://github.com/OpenClimate/climate_change_model/pull/7#issuecomment-137247270","issue_url":"https://api.github.com/repos/OpenClimate/climate_change_model/issues/7","id":137247270,"user":{"login":"jonathanrocher","id":593945,"avatar_url":"https://avatars.githubusercontent.com/u/593945?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanrocher","html_url":"https://github.com/jonathanrocher","followers_url":"https://api.github.com/users/jonathanrocher/followers","following_url":"https://api.github.com/users/jonathanrocher/following{/other_user}","gists_url":"https://api.github.com/users/jonathanrocher/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanrocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanrocher/subscriptions","organizations_url":"https://api.github.com/users/jonathanrocher/orgs","repos_url":"https://api.github.com/users/jonathanrocher/repos","events_url":"https://api.github.com/users/jonathanrocher/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanrocher/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T21:17:20Z","updated_at":"2015-09-02T21:17:20Z","body":"Yes, you should test it before merging normally. The way to do that is to pull the branch locally on your machine before it is merged into master. To do that:\r\n1. checkout master on you machine\r\n2. git pull (that will pull all new branches and make them available on your machine)\r\n3. git checkout feature/data_loaders\r\n4. git pull (just in case)\r\nYou now have the version of the code in this branch. You can play with it, run the unit tests, .... That is critical to do that in the review process so that master never receives code that could be broken. The goal is for master to always be stable and working. \r\n\r\nHTH, \r\nJonathan"}}