{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/comments/39342930","id":39342930,"diff_hunk":"@@ -99,11 +132,17 @@ CachingWriter.prototype._conditionalBuild = function () {\n         return rimraf(writer.outputPath);\n       }).then(function() {\n         fs.mkdirSync(writer.outputPath);\n-      });\n+      }).finally(function() {\n+\n+        this.debug('purge output in %dms', new Date() - start);\n+        start = new Date();","path":"index.js","position":100,"original_position":100,"commit_id":"24eaa4a2776b9fb349ed77d7099f280ec800b94d","original_commit_id":"24eaa4a2776b9fb349ed77d7099f280ec800b94d","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"Ahh, I see.  We really are tracking two different timings here with `start`.  Thats the bit I missed, thanks for explaining.","created_at":"2015-09-13T00:14:32Z","updated_at":"2015-09-13T00:14:32Z","html_url":"https://github.com/ember-cli/broccoli-caching-writer/pull/57#discussion_r39342930","pull_request_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/comments/39342930"},"html":{"href":"https://github.com/ember-cli/broccoli-caching-writer/pull/57#discussion_r39342930"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57","id":44846837,"html_url":"https://github.com/ember-cli/broccoli-caching-writer/pull/57","diff_url":"https://github.com/ember-cli/broccoli-caching-writer/pull/57.diff","patch_url":"https://github.com/ember-cli/broccoli-caching-writer/pull/57.patch","issue_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/57","number":57,"state":"open","locked":false,"title":"only walk sync inputs that match inputFiles globs","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"- [x] fix failing tests\r\n- [ ] add back `listFiles`\r\n\r\nThis improves the scenario, where the `input` to BCW is much larger then the `inputFiles` globs match against. In the scenario where we can prune entire trees early like `['very/explicit/root/**/*.js']`, we can see  a nice speedup.\r\n\r\nIn a variation of the stress app, this reduces SimpleConcat key dervation time from 2500ms -> 100ms","created_at":"2015-09-12T04:36:28Z","updated_at":"2015-09-13T00:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e9b787bf5678a6565fbde605d5fde2b8be6afa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57/commits","review_comments_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57/comments","review_comment_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/57/comments","statuses_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/statuses/24eaa4a2776b9fb349ed77d7099f280ec800b94d","head":{"label":"ember-cli:glob-aware-key-building","ref":"glob-aware-key-building","sha":"24eaa4a2776b9fb349ed77d7099f280ec800b94d","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":19181151,"name":"broccoli-caching-writer","full_name":"ember-cli/broccoli-caching-writer","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/broccoli-caching-writer","description":null,"fork":false,"url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer","forks_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/forks","keys_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/teams","hooks_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/events","assignees_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/tags","blobs_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/languages","stargazers_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/subscription","commits_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/merges","archive_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/downloads","issues_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/releases{/id}","created_at":"2014-04-26T15:48:26Z","updated_at":"2015-04-05T17:43:39Z","pushed_at":"2015-09-12T16:59:24Z","git_url":"git://github.com/ember-cli/broccoli-caching-writer.git","ssh_url":"git@github.com:ember-cli/broccoli-caching-writer.git","clone_url":"https://github.com/ember-cli/broccoli-caching-writer.git","svn_url":"https://github.com/ember-cli/broccoli-caching-writer","homepage":null,"size":708,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":12,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"c70ad0cdfca72b71ab14f5cb45cc97660affb63f","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":19181151,"name":"broccoli-caching-writer","full_name":"ember-cli/broccoli-caching-writer","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/broccoli-caching-writer","description":null,"fork":false,"url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer","forks_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/forks","keys_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/teams","hooks_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/events","assignees_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/tags","blobs_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/languages","stargazers_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/subscription","commits_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/merges","archive_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/downloads","issues_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/releases{/id}","created_at":"2014-04-26T15:48:26Z","updated_at":"2015-04-05T17:43:39Z","pushed_at":"2015-09-12T16:59:24Z","git_url":"git://github.com/ember-cli/broccoli-caching-writer.git","ssh_url":"git@github.com:ember-cli/broccoli-caching-writer.git","clone_url":"https://github.com/ember-cli/broccoli-caching-writer.git","svn_url":"https://github.com/ember-cli/broccoli-caching-writer","homepage":null,"size":708,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57"},"html":{"href":"https://github.com/ember-cli/broccoli-caching-writer/pull/57"},"issue":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/57"},"comments":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/broccoli-caching-writer/statuses/24eaa4a2776b9fb349ed77d7099f280ec800b94d"}}}}