{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22417367","id":22417367,"diff_hunk":"@@ -112,6 +115,12 @@ void PixelShaderManager::SetConstants()\n \t\tdirty = true;\n \t\ts_bViewPortChanged = false;\n \t}\n+\n+\tif (s_bEFBScaleChanged) {\n+\t\tdirty = true;\n+\t\tconstants.efbscale[0] = 1.0f / float(Renderer::EFBToScaledXf(1));\n+\t\tconstants.efbscale[1] = 1.0f / float(Renderer::EFBToScaledYf(1));","path":"Source/Core/VideoCommon/PixelShaderManager.cpp","position":25,"original_position":25,"commit_id":"a535e9f2605e664458e2487a589f6a5111e5b183","original_commit_id":"a535e9f2605e664458e2487a589f6a5111e5b183","user":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"body":"Missing `s_bEFBScaleChanged = false;`?","created_at":"2015-01-02T18:16:56Z","updated_at":"2015-01-02T18:16:56Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1812#discussion_r22417367","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22417367"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1812#discussion_r22417367"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812","id":26754664,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1812","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1812.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1812.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812","number":1812,"state":"open","locked":false,"title":"Fix various issues with NanoByte's port of neobrain's zfreeze branch.","user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"body":"Results are still not correct, but things are getting closer.\r\n\r\n * Don't cull CULLALL primitives so early so they can be used as reference\r\n        planes.\r\n * Convert CalculateZSlope to screenspace coordinates.\r\n * Convert Pixelshader to screenspace coordinates (instead of worldspace\r\n        xy coordinates, which is totally wrong)\r\n * Divide depth by 2^24 instead of clamping to 0.0-1.0 as was done\r\n        before.\r\n\r\nProgress:\r\n * Rouge Squadron 2/3 appear correct in game (videos in rs2 save file\r\n         selection are missing)\r\n * Shadows draw 100% correctly in NHL 2003.\r\n * Mario golf menu renders correctly.\r\n * NFS: HP2, shadows sometimes render on top of car or below the road.\r\n * Mario Tennis, courts and shadows render correctly, but at wrong depth\r\n * Blood Omen 2, doesn't work.","created_at":"2015-01-02T11:13:24Z","updated_at":"2015-01-02T18:16:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22349fa4ff7a6ade86d9c9ca93a099e56dcf794d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/a535e9f2605e664458e2487a589f6a5111e5b183","head":{"label":"phire:real_zfreeze","ref":"real_zfreeze","sha":"a535e9f2605e664458e2487a589f6a5111e5b183","user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"repo":{"id":16432729,"name":"dolphin","full_name":"phire/dolphin","owner":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phire/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/phire/dolphin","forks_url":"https://api.github.com/repos/phire/dolphin/forks","keys_url":"https://api.github.com/repos/phire/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phire/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phire/dolphin/teams","hooks_url":"https://api.github.com/repos/phire/dolphin/hooks","issue_events_url":"https://api.github.com/repos/phire/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/phire/dolphin/events","assignees_url":"https://api.github.com/repos/phire/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/phire/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/phire/dolphin/tags","blobs_url":"https://api.github.com/repos/phire/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phire/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phire/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phire/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phire/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/phire/dolphin/languages","stargazers_url":"https://api.github.com/repos/phire/dolphin/stargazers","contributors_url":"https://api.github.com/repos/phire/dolphin/contributors","subscribers_url":"https://api.github.com/repos/phire/dolphin/subscribers","subscription_url":"https://api.github.com/repos/phire/dolphin/subscription","commits_url":"https://api.github.com/repos/phire/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phire/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phire/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phire/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/phire/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/phire/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phire/dolphin/merges","archive_url":"https://api.github.com/repos/phire/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phire/dolphin/downloads","issues_url":"https://api.github.com/repos/phire/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/phire/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/phire/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/phire/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phire/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/phire/dolphin/releases{/id}","created_at":"2014-02-01T11:17:19Z","updated_at":"2014-08-05T08:40:53Z","pushed_at":"2015-01-02T17:50:46Z","git_url":"git://github.com/phire/dolphin.git","ssh_url":"git@github.com:phire/dolphin.git","clone_url":"https://github.com/phire/dolphin.git","svn_url":"https://github.com/phire/dolphin","homepage":null,"size":197101,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"9c6795c7b74c8aa6c852a2855ab54315d34f8613","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-01-02T01:00:01Z","pushed_at":"2015-01-02T01:00:01Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":248071,"stargazers_count":893,"watchers_count":893,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":69,"forks":286,"open_issues":69,"watchers":893,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1812"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/a535e9f2605e664458e2487a589f6a5111e5b183"}}}}