{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/3905","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/3905/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/3905/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/3905/events","html_url":"https://github.com/kripken/emscripten/pull/3905","id":115907694,"number":3905,"title":"Implement glfwSetInputMode when mode is GLFW_CURSOR and value is GLFW_CURSOR_NORMAL or GLFW_CURSOR_DISABLED","user":{"login":"gouletr","id":6430434,"avatar_url":"https://avatars.githubusercontent.com/u/6430434?v=3","gravatar_id":"","url":"https://api.github.com/users/gouletr","html_url":"https://github.com/gouletr","followers_url":"https://api.github.com/users/gouletr/followers","following_url":"https://api.github.com/users/gouletr/following{/other_user}","gists_url":"https://api.github.com/users/gouletr/gists{/gist_id}","starred_url":"https://api.github.com/users/gouletr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouletr/subscriptions","organizations_url":"https://api.github.com/users/gouletr/orgs","repos_url":"https://api.github.com/users/gouletr/repos","events_url":"https://api.github.com/users/gouletr/events{/privacy}","received_events_url":"https://api.github.com/users/gouletr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-09T16:04:53Z","updated_at":"2015-11-09T18:10:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/3905","html_url":"https://github.com/kripken/emscripten/pull/3905","diff_url":"https://github.com/kripken/emscripten/pull/3905.diff","patch_url":"https://github.com/kripken/emscripten/pull/3905.patch"},"body":"This PR implements `glfwSetInputMode(window, mode, value)` when mode is `GLFW_CURSOR` and value is `GLFW_CURSOR_NORMAL` or `GLFW_CURSOR_DISABLED`.\r\n\r\nSince browsers require requestPointerLock to be in user event, I believe it is perfectly legitimate to add an event listener on the canvas click, to properly respect the value of the mode, meaning that in `GLFW_CURSOR_DISABLED` mode, even if the user press escape to exit the pointer lock, clicking again the canvas should request the pointer lock again, while being in `GLFW_CURSOR_NORMAL` mode will keep the cursor visible."},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/155143304","html_url":"https://github.com/kripken/emscripten/pull/3905#issuecomment-155143304","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/3905","id":155143304,"user":{"login":"gouletr","id":6430434,"avatar_url":"https://avatars.githubusercontent.com/u/6430434?v=3","gravatar_id":"","url":"https://api.github.com/users/gouletr","html_url":"https://github.com/gouletr","followers_url":"https://api.github.com/users/gouletr/followers","following_url":"https://api.github.com/users/gouletr/following{/other_user}","gists_url":"https://api.github.com/users/gouletr/gists{/gist_id}","starred_url":"https://api.github.com/users/gouletr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouletr/subscriptions","organizations_url":"https://api.github.com/users/gouletr/orgs","repos_url":"https://api.github.com/users/gouletr/repos","events_url":"https://api.github.com/users/gouletr/events{/privacy}","received_events_url":"https://api.github.com/users/gouletr/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T18:10:14Z","updated_at":"2015-11-09T18:10:14Z","body":"I added the test, but I couldn't find where to execute it."}}