{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/37541774","id":37541774,"diff_hunk":"@@ -119,6 +119,24 @@ export class Parser {\n   wrapLiteralPrimitive(input: string, location: any): ASTWithSource {\n     return new ASTWithSource(new LiteralPrimitive(input), input, location);\n   }\n+\n+  private _checkNoInterpolation(input: string, location: any): void {\n+    var parts = StringWrapper.split(input, INTERPOLATION_REGEXP);","path":"modules/angular2/src/change_detection/parser/parser.ts","position":43,"original_position":43,"commit_id":"9ff3cb4c0b21594b8d0b8c184feb8106fe00cab0","original_commit_id":"9ff3cb4c0b21594b8d0b8c184feb8106fe00cab0","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"What about adding the check in `parseInterpolation()` to avoid duplicating the logic here ?\r\n(you would have to check that you are parsing a template binding there)","created_at":"2015-08-20T15:17:12Z","updated_at":"2015-08-20T15:17:12Z","html_url":"https://github.com/angular/angular/pull/3750#discussion_r37541774","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/3750","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/37541774"},"html":{"href":"https://github.com/angular/angular/pull/3750#discussion_r37541774"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/3750"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/3750","id":42936258,"html_url":"https://github.com/angular/angular/pull/3750","diff_url":"https://github.com/angular/angular/pull/3750.diff","patch_url":"https://github.com/angular/angular/pull/3750.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/3750","number":3750,"state":"open","locked":false,"title":"fix(parser): detect and report interpolation in expressions","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"body":"Fixes #3645","created_at":"2015-08-20T14:35:16Z","updated_at":"2015-08-20T15:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c3be1913e4e4379869dd72f17d253e0948157a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/3750/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/3750/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/3750/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/9ff3cb4c0b21594b8d0b8c184feb8106fe00cab0","head":{"label":"pkozlowski-opensource:interp_in_exps","ref":"interp_in_exps","sha":"9ff3cb4c0b21594b8d0b8c184feb8106fe00cab0","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"repo":{"id":28565710,"name":"angular","full_name":"pkozlowski-opensource/angular","owner":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkozlowski-opensource/angular","description":"","fork":true,"url":"https://api.github.com/repos/pkozlowski-opensource/angular","forks_url":"https://api.github.com/repos/pkozlowski-opensource/angular/forks","keys_url":"https://api.github.com/repos/pkozlowski-opensource/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkozlowski-opensource/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkozlowski-opensource/angular/teams","hooks_url":"https://api.github.com/repos/pkozlowski-opensource/angular/hooks","issue_events_url":"https://api.github.com/repos/pkozlowski-opensource/angular/issues/events{/number}","events_url":"https://api.github.com/repos/pkozlowski-opensource/angular/events","assignees_url":"https://api.github.com/repos/pkozlowski-opensource/angular/assignees{/user}","branches_url":"https://api.github.com/repos/pkozlowski-opensource/angular/branches{/branch}","tags_url":"https://api.github.com/repos/pkozlowski-opensource/angular/tags","blobs_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkozlowski-opensource/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/pkozlowski-opensource/angular/languages","stargazers_url":"https://api.github.com/repos/pkozlowski-opensource/angular/stargazers","contributors_url":"https://api.github.com/repos/pkozlowski-opensource/angular/contributors","subscribers_url":"https://api.github.com/repos/pkozlowski-opensource/angular/subscribers","subscription_url":"https://api.github.com/repos/pkozlowski-opensource/angular/subscription","commits_url":"https://api.github.com/repos/pkozlowski-opensource/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkozlowski-opensource/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkozlowski-opensource/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkozlowski-opensource/angular/contents/{+path}","compare_url":"https://api.github.com/repos/pkozlowski-opensource/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkozlowski-opensource/angular/merges","archive_url":"https://api.github.com/repos/pkozlowski-opensource/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkozlowski-opensource/angular/downloads","issues_url":"https://api.github.com/repos/pkozlowski-opensource/angular/issues{/number}","pulls_url":"https://api.github.com/repos/pkozlowski-opensource/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/pkozlowski-opensource/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/pkozlowski-opensource/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkozlowski-opensource/angular/labels{/name}","releases_url":"https://api.github.com/repos/pkozlowski-opensource/angular/releases{/id}","created_at":"2014-12-28T16:05:25Z","updated_at":"2015-06-16T12:14:56Z","pushed_at":"2015-08-20T15:16:23Z","git_url":"git://github.com/pkozlowski-opensource/angular.git","ssh_url":"git@github.com:pkozlowski-opensource/angular.git","clone_url":"https://github.com/pkozlowski-opensource/angular.git","svn_url":"https://github.com/pkozlowski-opensource/angular","homepage":null,"size":12806,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"ddb62feae6313b8dc56b50e9cad9e5151493fbd3","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-08-20T14:57:19Z","pushed_at":"2015-08-20T15:16:24Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":41371,"stargazers_count":4856,"watchers_count":4856,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1276,"mirror_url":null,"open_issues_count":471,"forks":1276,"open_issues":471,"watchers":4856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/3750"},"html":{"href":"https://github.com/angular/angular/pull/3750"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/3750"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/3750/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/3750/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/3750/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/9ff3cb4c0b21594b8d0b8c184feb8106fe00cab0"}}}}