{"action":"created","issue":{"url":"https://api.github.com/repos/jaredly/hexo-admin/issues/33","labels_url":"https://api.github.com/repos/jaredly/hexo-admin/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/jaredly/hexo-admin/issues/33/comments","events_url":"https://api.github.com/repos/jaredly/hexo-admin/issues/33/events","html_url":"https://github.com/jaredly/hexo-admin/pull/33","id":113621328,"number":33,"title":"Add the deploy page","user":{"login":"bobchennan","id":939088,"avatar_url":"https://avatars.githubusercontent.com/u/939088?v=3","gravatar_id":"","url":"https://api.github.com/users/bobchennan","html_url":"https://github.com/bobchennan","followers_url":"https://api.github.com/users/bobchennan/followers","following_url":"https://api.github.com/users/bobchennan/following{/other_user}","gists_url":"https://api.github.com/users/bobchennan/gists{/gist_id}","starred_url":"https://api.github.com/users/bobchennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobchennan/subscriptions","organizations_url":"https://api.github.com/users/bobchennan/orgs","repos_url":"https://api.github.com/users/bobchennan/repos","events_url":"https://api.github.com/users/bobchennan/events{/privacy}","received_events_url":"https://api.github.com/users/bobchennan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-27T16:12:47Z","updated_at":"2015-10-27T17:41:01Z","closed_at":"2015-10-27T17:40:49Z","pull_request":{"url":"https://api.github.com/repos/jaredly/hexo-admin/pulls/33","html_url":"https://github.com/jaredly/hexo-admin/pull/33","diff_url":"https://github.com/jaredly/hexo-admin/pull/33.diff","patch_url":"https://github.com/jaredly/hexo-admin/pull/33.patch"},"body":"use the path specified in yml:\r\nadmin:\r\n  path: \"/home/ubuntu/workspace/deploy.sh\"\r\n\r\nthe script takes the first parameter as the commit log"},"comment":{"url":"https://api.github.com/repos/jaredly/hexo-admin/issues/comments/151582709","html_url":"https://github.com/jaredly/hexo-admin/pull/33#issuecomment-151582709","issue_url":"https://api.github.com/repos/jaredly/hexo-admin/issues/33","id":151582709,"user":{"login":"jaredly","id":112170,"avatar_url":"https://avatars.githubusercontent.com/u/112170?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredly","html_url":"https://github.com/jaredly","followers_url":"https://api.github.com/users/jaredly/followers","following_url":"https://api.github.com/users/jaredly/following{/other_user}","gists_url":"https://api.github.com/users/jaredly/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredly/subscriptions","organizations_url":"https://api.github.com/users/jaredly/orgs","repos_url":"https://api.github.com/users/jaredly/repos","events_url":"https://api.github.com/users/jaredly/events{/privacy}","received_events_url":"https://api.github.com/users/jaredly/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T17:41:01Z","updated_at":"2015-10-27T17:41:01Z","body":"Thanks for putting this together! I made some changes before merging it in to make it align with the style/organization of the project generally.\r\nFor reference (in case you are interested), the changes are:\r\n\r\n- put the `deploy` serverside logic in `api.js` along with the other endpoints, splitting out the non-app specific stuff into a separate function\r\n- changed the `path` config value to be `deployCommand` (a bit more specific)\r\n- put the front-end ajax stuff into the `./client/api/rest.js` file w/ the other api helpers, which cuts out a lot of the boilerplate and removes the need for jquery\r\n- changed the react code to use `<input onChanged...` instead of digging into refs (see the [todo example](http://facebook.github.io/react/) on the react homepage for another example of using `<input/>`)\r\n- added an `error` parameter to the `deploy` endpoint to report server errors, etc.\r\n- various ui changes\r\n- standardized code style/indents/etc.\r\n"}}