{"action":"closed","number":4336,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4336","id":27988762,"html_url":"https://github.com/D-Programming-Language/dmd/pull/4336","diff_url":"https://github.com/D-Programming-Language/dmd/pull/4336.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/4336.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4336","number":4336,"state":"closed","locked":false,"title":"Issue 9495 - Win64 vararg issue when first argument is > 8 byte","user":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"body":"Usually `va_start` is passed the last named argument, and on x86 the first variadic arg can be found by incrementing its address.  On win64, aggregates larger than 8 bytes (such as D's dynamic arrays) are allocated on the stack, and a pointer is passed instead.  When one of these is the last named argument, the address of the pointer is needed to find the address of the first variadic arg, but this is not possible within D's type system.\r\n\r\nTo solve this, I've added code to recognize `va_start` as an intrinsic function and replace it's call with a backend op: `OPva_start`. (toir.h toir.c e2ir.c idgen.c)\r\n\r\nThe backend then replaces the `va_start` op with `va = &lastNamedArg + 8` where `lastNamedArg` is the pointer to the arg when necessary.  This allows `va_start` to correctly initialize the arg pointer on win64.\r\n\r\nhttps://issues.dlang.org/show_bug.cgi?id=9495","created_at":"2015-01-25T07:23:21Z","updated_at":"2015-01-25T17:31:19Z","closed_at":"2015-01-25T17:31:19Z","merged_at":"2015-01-25T17:31:19Z","merge_commit_sha":"3ac77e08d99d96ccb1cd08119308bb30da1c757b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4336/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4336/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4336/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/185b0ab5fdef3592b0a9bdd2d0fef32dfb59c1e7","head":{"label":"yebblies:issue9495","ref":"issue9495","sha":"185b0ab5fdef3592b0a9bdd2d0fef32dfb59c1e7","user":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"repo":{"id":1850344,"name":"dmd","full_name":"yebblies/dmd","owner":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yebblies/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/yebblies/dmd","forks_url":"https://api.github.com/repos/yebblies/dmd/forks","keys_url":"https://api.github.com/repos/yebblies/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yebblies/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yebblies/dmd/teams","hooks_url":"https://api.github.com/repos/yebblies/dmd/hooks","issue_events_url":"https://api.github.com/repos/yebblies/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/yebblies/dmd/events","assignees_url":"https://api.github.com/repos/yebblies/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/yebblies/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/yebblies/dmd/tags","blobs_url":"https://api.github.com/repos/yebblies/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yebblies/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yebblies/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/yebblies/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yebblies/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/yebblies/dmd/languages","stargazers_url":"https://api.github.com/repos/yebblies/dmd/stargazers","contributors_url":"https://api.github.com/repos/yebblies/dmd/contributors","subscribers_url":"https://api.github.com/repos/yebblies/dmd/subscribers","subscription_url":"https://api.github.com/repos/yebblies/dmd/subscription","commits_url":"https://api.github.com/repos/yebblies/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/yebblies/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/yebblies/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/yebblies/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/yebblies/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/yebblies/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yebblies/dmd/merges","archive_url":"https://api.github.com/repos/yebblies/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yebblies/dmd/downloads","issues_url":"https://api.github.com/repos/yebblies/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/yebblies/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/yebblies/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/yebblies/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yebblies/dmd/labels{/name}","releases_url":"https://api.github.com/repos/yebblies/dmd/releases{/id}","created_at":"2011-06-05T13:45:33Z","updated_at":"2015-01-24T10:45:48Z","pushed_at":"2015-01-25T13:33:37Z","git_url":"git://github.com/yebblies/dmd.git","ssh_url":"git@github.com:yebblies/dmd.git","clone_url":"https://github.com/yebblies/dmd.git","svn_url":"https://github.com/yebblies/dmd","homepage":"d-programming-language.org","size":48406,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"862669514c4de7a4261a6508c7c8332816630f36","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2015-01-25T15:56:00Z","pushed_at":"2015-01-25T17:31:21Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":81889,"stargazers_count":908,"watchers_count":908,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":89,"forks":294,"open_issues":89,"watchers":908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4336"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/4336"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4336"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4336/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4336/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4336/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/185b0ab5fdef3592b0a9bdd2d0fef32dfb59c1e7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andralex","id":566679,"avatar_url":"https://avatars.githubusercontent.com/u/566679?v=3","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":1,"additions":128,"deletions":4,"changed_files":8}}