{"action":"created","comment":{"url":"https://api.github.com/repos/leancloud/python-sdk/pulls/comments/36386661","id":36386661,"diff_hunk":"@@ -401,7 +403,7 @@ def does_not_match_query(self, key, query):\n         self._add_condition(key, '$notInQuery', dumped)\n         return self\n \n-    def matched_key_in_query(self, key, query_key, query):\n+    def match_key_in_query(self, key, query_key, query):","path":"leancloud/query.py","position":34,"original_position":34,"commit_id":"3ed497563e9d4cae343679a7600a36c3e801c232","original_commit_id":"3ed497563e9d4cae343679a7600a36c3e801c232","user":{"login":"aisk","id":699636,"avatar_url":"https://avatars.githubusercontent.com/u/699636?v=3","gravatar_id":"","url":"https://api.github.com/users/aisk","html_url":"https://github.com/aisk","followers_url":"https://api.github.com/users/aisk/followers","following_url":"https://api.github.com/users/aisk/following{/other_user}","gists_url":"https://api.github.com/users/aisk/gists{/gist_id}","starred_url":"https://api.github.com/users/aisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aisk/subscriptions","organizations_url":"https://api.github.com/users/aisk/orgs","repos_url":"https://api.github.com/users/aisk/repos","events_url":"https://api.github.com/users/aisk/events{/privacy}","received_events_url":"https://api.github.com/users/aisk/received_events","type":"User","site_admin":false},"body":"看了下 JS 是 matchesKeyInQuery ，那还是改成 matches_key_in_query 吧。\r\n另外之前的方法也应该保留，在第一行调用 warnings.warn(' ... '); 提示用户使用新的 API，但是仍然执行此方法。","created_at":"2015-08-06T07:11:53Z","updated_at":"2015-08-06T07:11:53Z","html_url":"https://github.com/leancloud/python-sdk/pull/78#discussion_r36386661","pull_request_url":"https://api.github.com/repos/leancloud/python-sdk/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/leancloud/python-sdk/pulls/comments/36386661"},"html":{"href":"https://github.com/leancloud/python-sdk/pull/78#discussion_r36386661"},"pull_request":{"href":"https://api.github.com/repos/leancloud/python-sdk/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/leancloud/python-sdk/pulls/78","id":41756342,"html_url":"https://github.com/leancloud/python-sdk/pull/78","diff_url":"https://github.com/leancloud/python-sdk/pull/78.diff","patch_url":"https://github.com/leancloud/python-sdk/pull/78.patch","issue_url":"https://api.github.com/repos/leancloud/python-sdk/issues/78","number":78,"state":"open","locked":false,"title":"Add tests","user":{"login":"DionysusG","id":7628770,"avatar_url":"https://avatars.githubusercontent.com/u/7628770?v=3","gravatar_id":"","url":"https://api.github.com/users/DionysusG","html_url":"https://github.com/DionysusG","followers_url":"https://api.github.com/users/DionysusG/followers","following_url":"https://api.github.com/users/DionysusG/following{/other_user}","gists_url":"https://api.github.com/users/DionysusG/gists{/gist_id}","starred_url":"https://api.github.com/users/DionysusG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DionysusG/subscriptions","organizations_url":"https://api.github.com/users/DionysusG/orgs","repos_url":"https://api.github.com/users/DionysusG/repos","events_url":"https://api.github.com/users/DionysusG/events{/privacy}","received_events_url":"https://api.github.com/users/DionysusG/received_events","type":"User","site_admin":false},"body":"1. add ACL and query tests coverage to 100%\r\n2. fix bugs in ACL and query module\r\n3. improve the performance of query tests ","created_at":"2015-08-06T06:42:16Z","updated_at":"2015-08-06T07:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09f83ca657a542d34af10808f043770547dec3da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leancloud/python-sdk/pulls/78/commits","review_comments_url":"https://api.github.com/repos/leancloud/python-sdk/pulls/78/comments","review_comment_url":"https://api.github.com/repos/leancloud/python-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leancloud/python-sdk/issues/78/comments","statuses_url":"https://api.github.com/repos/leancloud/python-sdk/statuses/3ed497563e9d4cae343679a7600a36c3e801c232","head":{"label":"DionysusG:add_tests","ref":"add_tests","sha":"3ed497563e9d4cae343679a7600a36c3e801c232","user":{"login":"DionysusG","id":7628770,"avatar_url":"https://avatars.githubusercontent.com/u/7628770?v=3","gravatar_id":"","url":"https://api.github.com/users/DionysusG","html_url":"https://github.com/DionysusG","followers_url":"https://api.github.com/users/DionysusG/followers","following_url":"https://api.github.com/users/DionysusG/following{/other_user}","gists_url":"https://api.github.com/users/DionysusG/gists{/gist_id}","starred_url":"https://api.github.com/users/DionysusG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DionysusG/subscriptions","organizations_url":"https://api.github.com/users/DionysusG/orgs","repos_url":"https://api.github.com/users/DionysusG/repos","events_url":"https://api.github.com/users/DionysusG/events{/privacy}","received_events_url":"https://api.github.com/users/DionysusG/received_events","type":"User","site_admin":false},"repo":{"id":37584236,"name":"python-sdk","full_name":"DionysusG/python-sdk","owner":{"login":"DionysusG","id":7628770,"avatar_url":"https://avatars.githubusercontent.com/u/7628770?v=3","gravatar_id":"","url":"https://api.github.com/users/DionysusG","html_url":"https://github.com/DionysusG","followers_url":"https://api.github.com/users/DionysusG/followers","following_url":"https://api.github.com/users/DionysusG/following{/other_user}","gists_url":"https://api.github.com/users/DionysusG/gists{/gist_id}","starred_url":"https://api.github.com/users/DionysusG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DionysusG/subscriptions","organizations_url":"https://api.github.com/users/DionysusG/orgs","repos_url":"https://api.github.com/users/DionysusG/repos","events_url":"https://api.github.com/users/DionysusG/events{/privacy}","received_events_url":"https://api.github.com/users/DionysusG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DionysusG/python-sdk","description":"LeanCloud Python SDK","fork":true,"url":"https://api.github.com/repos/DionysusG/python-sdk","forks_url":"https://api.github.com/repos/DionysusG/python-sdk/forks","keys_url":"https://api.github.com/repos/DionysusG/python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DionysusG/python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DionysusG/python-sdk/teams","hooks_url":"https://api.github.com/repos/DionysusG/python-sdk/hooks","issue_events_url":"https://api.github.com/repos/DionysusG/python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/DionysusG/python-sdk/events","assignees_url":"https://api.github.com/repos/DionysusG/python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/DionysusG/python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/DionysusG/python-sdk/tags","blobs_url":"https://api.github.com/repos/DionysusG/python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DionysusG/python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DionysusG/python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/DionysusG/python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DionysusG/python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/DionysusG/python-sdk/languages","stargazers_url":"https://api.github.com/repos/DionysusG/python-sdk/stargazers","contributors_url":"https://api.github.com/repos/DionysusG/python-sdk/contributors","subscribers_url":"https://api.github.com/repos/DionysusG/python-sdk/subscribers","subscription_url":"https://api.github.com/repos/DionysusG/python-sdk/subscription","commits_url":"https://api.github.com/repos/DionysusG/python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/DionysusG/python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/DionysusG/python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/DionysusG/python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/DionysusG/python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/DionysusG/python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DionysusG/python-sdk/merges","archive_url":"https://api.github.com/repos/DionysusG/python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DionysusG/python-sdk/downloads","issues_url":"https://api.github.com/repos/DionysusG/python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/DionysusG/python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/DionysusG/python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/DionysusG/python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DionysusG/python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/DionysusG/python-sdk/releases{/id}","created_at":"2015-06-17T09:00:01Z","updated_at":"2015-06-17T09:00:01Z","pushed_at":"2015-08-06T06:54:36Z","git_url":"git://github.com/DionysusG/python-sdk.git","ssh_url":"git@github.com:DionysusG/python-sdk.git","clone_url":"https://github.com/DionysusG/python-sdk.git","svn_url":"https://github.com/DionysusG/python-sdk","homepage":"http://leancloud.cn/","size":391,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leancloud:master","ref":"master","sha":"36cac23ab908121103659e3d37fbf8495f557fd7","user":{"login":"leancloud","id":6660518,"avatar_url":"https://avatars.githubusercontent.com/u/6660518?v=3","gravatar_id":"","url":"https://api.github.com/users/leancloud","html_url":"https://github.com/leancloud","followers_url":"https://api.github.com/users/leancloud/followers","following_url":"https://api.github.com/users/leancloud/following{/other_user}","gists_url":"https://api.github.com/users/leancloud/gists{/gist_id}","starred_url":"https://api.github.com/users/leancloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leancloud/subscriptions","organizations_url":"https://api.github.com/users/leancloud/orgs","repos_url":"https://api.github.com/users/leancloud/repos","events_url":"https://api.github.com/users/leancloud/events{/privacy}","received_events_url":"https://api.github.com/users/leancloud/received_events","type":"Organization","site_admin":false},"repo":{"id":26794168,"name":"python-sdk","full_name":"leancloud/python-sdk","owner":{"login":"leancloud","id":6660518,"avatar_url":"https://avatars.githubusercontent.com/u/6660518?v=3","gravatar_id":"","url":"https://api.github.com/users/leancloud","html_url":"https://github.com/leancloud","followers_url":"https://api.github.com/users/leancloud/followers","following_url":"https://api.github.com/users/leancloud/following{/other_user}","gists_url":"https://api.github.com/users/leancloud/gists{/gist_id}","starred_url":"https://api.github.com/users/leancloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leancloud/subscriptions","organizations_url":"https://api.github.com/users/leancloud/orgs","repos_url":"https://api.github.com/users/leancloud/repos","events_url":"https://api.github.com/users/leancloud/events{/privacy}","received_events_url":"https://api.github.com/users/leancloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leancloud/python-sdk","description":"LeanCloud Python SDK","fork":false,"url":"https://api.github.com/repos/leancloud/python-sdk","forks_url":"https://api.github.com/repos/leancloud/python-sdk/forks","keys_url":"https://api.github.com/repos/leancloud/python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leancloud/python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leancloud/python-sdk/teams","hooks_url":"https://api.github.com/repos/leancloud/python-sdk/hooks","issue_events_url":"https://api.github.com/repos/leancloud/python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/leancloud/python-sdk/events","assignees_url":"https://api.github.com/repos/leancloud/python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/leancloud/python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/leancloud/python-sdk/tags","blobs_url":"https://api.github.com/repos/leancloud/python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leancloud/python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leancloud/python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/leancloud/python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leancloud/python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/leancloud/python-sdk/languages","stargazers_url":"https://api.github.com/repos/leancloud/python-sdk/stargazers","contributors_url":"https://api.github.com/repos/leancloud/python-sdk/contributors","subscribers_url":"https://api.github.com/repos/leancloud/python-sdk/subscribers","subscription_url":"https://api.github.com/repos/leancloud/python-sdk/subscription","commits_url":"https://api.github.com/repos/leancloud/python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/leancloud/python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/leancloud/python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/leancloud/python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/leancloud/python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/leancloud/python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leancloud/python-sdk/merges","archive_url":"https://api.github.com/repos/leancloud/python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leancloud/python-sdk/downloads","issues_url":"https://api.github.com/repos/leancloud/python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/leancloud/python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/leancloud/python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/leancloud/python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leancloud/python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/leancloud/python-sdk/releases{/id}","created_at":"2014-11-18T05:53:41Z","updated_at":"2015-08-03T07:03:12Z","pushed_at":"2015-08-06T06:54:36Z","git_url":"git://github.com/leancloud/python-sdk.git","ssh_url":"git@github.com:leancloud/python-sdk.git","clone_url":"https://github.com/leancloud/python-sdk.git","svn_url":"https://github.com/leancloud/python-sdk","homepage":"https://leancloud.cn/docs/python_guide.html","size":1020,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":7,"forks":15,"open_issues":7,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leancloud/python-sdk/pulls/78"},"html":{"href":"https://github.com/leancloud/python-sdk/pull/78"},"issue":{"href":"https://api.github.com/repos/leancloud/python-sdk/issues/78"},"comments":{"href":"https://api.github.com/repos/leancloud/python-sdk/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/leancloud/python-sdk/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/leancloud/python-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leancloud/python-sdk/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/leancloud/python-sdk/statuses/3ed497563e9d4cae343679a7600a36c3e801c232"}}}}