{"action":"opened","issue":{"url":"https://api.github.com/repos/bcjobs/analytics-dashboard/issues/25","labels_url":"https://api.github.com/repos/bcjobs/analytics-dashboard/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/bcjobs/analytics-dashboard/issues/25/comments","events_url":"https://api.github.com/repos/bcjobs/analytics-dashboard/issues/25/events","html_url":"https://github.com/bcjobs/analytics-dashboard/issues/25","id":123719548,"number":25,"title":"Code review: dedupe csv upload/download","user":{"login":"johnnyoshika","id":504505,"avatar_url":"https://avatars.githubusercontent.com/u/504505?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnyoshika","html_url":"https://github.com/johnnyoshika","followers_url":"https://api.github.com/users/johnnyoshika/followers","following_url":"https://api.github.com/users/johnnyoshika/following{/other_user}","gists_url":"https://api.github.com/users/johnnyoshika/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnyoshika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnyoshika/subscriptions","organizations_url":"https://api.github.com/users/johnnyoshika/orgs","repos_url":"https://api.github.com/users/johnnyoshika/repos","events_url":"https://api.github.com/users/johnnyoshika/events{/privacy}","received_events_url":"https://api.github.com/users/johnnyoshika/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bcjobs/analytics-dashboard/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"jsedlacek","id":10656,"avatar_url":"https://avatars.githubusercontent.com/u/10656?v=3","gravatar_id":"","url":"https://api.github.com/users/jsedlacek","html_url":"https://github.com/jsedlacek","followers_url":"https://api.github.com/users/jsedlacek/followers","following_url":"https://api.github.com/users/jsedlacek/following{/other_user}","gists_url":"https://api.github.com/users/jsedlacek/gists{/gist_id}","starred_url":"https://api.github.com/users/jsedlacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsedlacek/subscriptions","organizations_url":"https://api.github.com/users/jsedlacek/orgs","repos_url":"https://api.github.com/users/jsedlacek/repos","events_url":"https://api.github.com/users/jsedlacek/events{/privacy}","received_events_url":"https://api.github.com/users/jsedlacek/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-12-23T20:37:11Z","updated_at":"2015-12-23T20:37:11Z","closed_at":null,"body":"A quick code review on the dedupe CSV upload/download would be appreciated.  Both upload and download are implemented inside a single template and controller.  It seems like maybe this controller/template combo are doing too much.  Would you recommend splitting this into 2 parts?  And if so, how?\r\n\r\nRelevant commits:\r\n\r\nhttps://github.com/bcjobs/analytics-dashboard/commit/868a8325f4650655c45f41e78d6477307f2e92bd\r\nhttps://github.com/bcjobs/analytics-dashboard/commit/17eb14c8ffdb3ff81e7bbe9b68d7a0f06dfa527e\r\n\r\nThanks!"}}