{"action":"created","comment":{"url":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments/26230859","id":26230859,"diff_hunk":"@@ -89,6 +98,7 @@ def waitfor(taskset_id)\n           elsif rs.size != 0\n             rs[0].getc\n             taskset.cancel\n+            break","path":"rrrspec-client/lib/rrrspec/client/cli.rb","position":24,"original_position":24,"commit_id":"879bf0bf5b36c34ed72568205a5b4cd0b49e371d","original_commit_id":"879bf0bf5b36c34ed72568205a5b4cd0b49e371d","user":{"login":"eagletmt","id":69755,"avatar_url":"https://avatars.githubusercontent.com/u/69755?v=3","gravatar_id":"","url":"https://api.github.com/users/eagletmt","html_url":"https://github.com/eagletmt","followers_url":"https://api.github.com/users/eagletmt/followers","following_url":"https://api.github.com/users/eagletmt/following{/other_user}","gists_url":"https://api.github.com/users/eagletmt/gists{/gist_id}","starred_url":"https://api.github.com/users/eagletmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eagletmt/subscriptions","organizations_url":"https://api.github.com/users/eagletmt/orgs","repos_url":"https://api.github.com/users/eagletmt/repos","events_url":"https://api.github.com/users/eagletmt/events{/privacy}","received_events_url":"https://api.github.com/users/eagletmt/received_events","type":"User","site_admin":false},"body":"Yes, it's the main purpose of this PR.\r\n\r\nWhen `rrrspec waitfor` is interrupted, rrrspec is expected to cancel the taskset just like `rrrspec cancel` does.\r\n`rrrspec cancel` doesn't care about the cancelled taskset.","created_at":"2015-03-11T16:52:27Z","updated_at":"2015-03-11T16:52:27Z","html_url":"https://github.com/cookpad/rrrspec/pull/39#discussion_r26230859","pull_request_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments/26230859"},"html":{"href":"https://github.com/cookpad/rrrspec/pull/39#discussion_r26230859"},"pull_request":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/cookpad/rrrspec/pulls/39","id":30924908,"html_url":"https://github.com/cookpad/rrrspec/pull/39","diff_url":"https://github.com/cookpad/rrrspec/pull/39.diff","patch_url":"https://github.com/cookpad/rrrspec/pull/39.patch","issue_url":"https://api.github.com/repos/cookpad/rrrspec/issues/39","number":39,"state":"closed","locked":false,"title":"client waitfor: Quit right after cancel","user":{"login":"sorah","id":29440,"avatar_url":"https://avatars.githubusercontent.com/u/29440?v=3","gravatar_id":"","url":"https://api.github.com/users/sorah","html_url":"https://github.com/sorah","followers_url":"https://api.github.com/users/sorah/followers","following_url":"https://api.github.com/users/sorah/following{/other_user}","gists_url":"https://api.github.com/users/sorah/gists{/gist_id}","starred_url":"https://api.github.com/users/sorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorah/subscriptions","organizations_url":"https://api.github.com/users/sorah/orgs","repos_url":"https://api.github.com/users/sorah/repos","events_url":"https://api.github.com/users/sorah/events{/privacy}","received_events_url":"https://api.github.com/users/sorah/received_events","type":"User","site_admin":false},"body":"Previously `waitfor` accepts signal to cancel the taskset, but it continues to\nwait taskset's persistence.\n\nthis patch changes to quit on 2nd signal. Useful for users who don't want to\nwait the result.\n\n@cookpad/rrrspec :eyeglasses:","created_at":"2015-03-11T09:02:58Z","updated_at":"2015-03-11T16:52:27Z","closed_at":"2015-03-11T09:31:45Z","merged_at":"2015-03-11T09:31:45Z","merge_commit_sha":"ebc1f5ca3e3ae433e493f40ac39bd865af42382e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/39/commits","review_comments_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/39/comments","review_comment_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cookpad/rrrspec/issues/39/comments","statuses_url":"https://api.github.com/repos/cookpad/rrrspec/statuses/879bf0bf5b36c34ed72568205a5b4cd0b49e371d","head":{"label":"sorah:friendly-waitfor-cancel","ref":"friendly-waitfor-cancel","sha":"879bf0bf5b36c34ed72568205a5b4cd0b49e371d","user":{"login":"sorah","id":29440,"avatar_url":"https://avatars.githubusercontent.com/u/29440?v=3","gravatar_id":"","url":"https://api.github.com/users/sorah","html_url":"https://github.com/sorah","followers_url":"https://api.github.com/users/sorah/followers","following_url":"https://api.github.com/users/sorah/following{/other_user}","gists_url":"https://api.github.com/users/sorah/gists{/gist_id}","starred_url":"https://api.github.com/users/sorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorah/subscriptions","organizations_url":"https://api.github.com/users/sorah/orgs","repos_url":"https://api.github.com/users/sorah/repos","events_url":"https://api.github.com/users/sorah/events{/privacy}","received_events_url":"https://api.github.com/users/sorah/received_events","type":"User","site_admin":false},"repo":{"id":18356721,"name":"rrrspec","full_name":"sorah/rrrspec","owner":{"login":"sorah","id":29440,"avatar_url":"https://avatars.githubusercontent.com/u/29440?v=3","gravatar_id":"","url":"https://api.github.com/users/sorah","html_url":"https://github.com/sorah","followers_url":"https://api.github.com/users/sorah/followers","following_url":"https://api.github.com/users/sorah/following{/other_user}","gists_url":"https://api.github.com/users/sorah/gists{/gist_id}","starred_url":"https://api.github.com/users/sorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorah/subscriptions","organizations_url":"https://api.github.com/users/sorah/orgs","repos_url":"https://api.github.com/users/sorah/repos","events_url":"https://api.github.com/users/sorah/events{/privacy}","received_events_url":"https://api.github.com/users/sorah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sorah/rrrspec","description":"Distributed RSpec","fork":true,"url":"https://api.github.com/repos/sorah/rrrspec","forks_url":"https://api.github.com/repos/sorah/rrrspec/forks","keys_url":"https://api.github.com/repos/sorah/rrrspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sorah/rrrspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sorah/rrrspec/teams","hooks_url":"https://api.github.com/repos/sorah/rrrspec/hooks","issue_events_url":"https://api.github.com/repos/sorah/rrrspec/issues/events{/number}","events_url":"https://api.github.com/repos/sorah/rrrspec/events","assignees_url":"https://api.github.com/repos/sorah/rrrspec/assignees{/user}","branches_url":"https://api.github.com/repos/sorah/rrrspec/branches{/branch}","tags_url":"https://api.github.com/repos/sorah/rrrspec/tags","blobs_url":"https://api.github.com/repos/sorah/rrrspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sorah/rrrspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sorah/rrrspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/sorah/rrrspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sorah/rrrspec/statuses/{sha}","languages_url":"https://api.github.com/repos/sorah/rrrspec/languages","stargazers_url":"https://api.github.com/repos/sorah/rrrspec/stargazers","contributors_url":"https://api.github.com/repos/sorah/rrrspec/contributors","subscribers_url":"https://api.github.com/repos/sorah/rrrspec/subscribers","subscription_url":"https://api.github.com/repos/sorah/rrrspec/subscription","commits_url":"https://api.github.com/repos/sorah/rrrspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/sorah/rrrspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/sorah/rrrspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/sorah/rrrspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/sorah/rrrspec/contents/{+path}","compare_url":"https://api.github.com/repos/sorah/rrrspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sorah/rrrspec/merges","archive_url":"https://api.github.com/repos/sorah/rrrspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sorah/rrrspec/downloads","issues_url":"https://api.github.com/repos/sorah/rrrspec/issues{/number}","pulls_url":"https://api.github.com/repos/sorah/rrrspec/pulls{/number}","milestones_url":"https://api.github.com/repos/sorah/rrrspec/milestones{/number}","notifications_url":"https://api.github.com/repos/sorah/rrrspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sorah/rrrspec/labels{/name}","releases_url":"https://api.github.com/repos/sorah/rrrspec/releases{/id}","created_at":"2014-04-02T06:26:16Z","updated_at":"2014-04-24T02:14:26Z","pushed_at":"2015-03-11T09:31:46Z","git_url":"git://github.com/sorah/rrrspec.git","ssh_url":"git@github.com:sorah/rrrspec.git","clone_url":"https://github.com/sorah/rrrspec.git","svn_url":"https://github.com/sorah/rrrspec","homepage":"","size":1085,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cookpad:master","ref":"master","sha":"d34006f2cab6bf5d901975b2707a365821054975","user":{"login":"cookpad","id":119195,"avatar_url":"https://avatars.githubusercontent.com/u/119195?v=3","gravatar_id":"","url":"https://api.github.com/users/cookpad","html_url":"https://github.com/cookpad","followers_url":"https://api.github.com/users/cookpad/followers","following_url":"https://api.github.com/users/cookpad/following{/other_user}","gists_url":"https://api.github.com/users/cookpad/gists{/gist_id}","starred_url":"https://api.github.com/users/cookpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cookpad/subscriptions","organizations_url":"https://api.github.com/users/cookpad/orgs","repos_url":"https://api.github.com/users/cookpad/repos","events_url":"https://api.github.com/users/cookpad/events{/privacy}","received_events_url":"https://api.github.com/users/cookpad/received_events","type":"Organization","site_admin":false},"repo":{"id":16797453,"name":"rrrspec","full_name":"cookpad/rrrspec","owner":{"login":"cookpad","id":119195,"avatar_url":"https://avatars.githubusercontent.com/u/119195?v=3","gravatar_id":"","url":"https://api.github.com/users/cookpad","html_url":"https://github.com/cookpad","followers_url":"https://api.github.com/users/cookpad/followers","following_url":"https://api.github.com/users/cookpad/following{/other_user}","gists_url":"https://api.github.com/users/cookpad/gists{/gist_id}","starred_url":"https://api.github.com/users/cookpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cookpad/subscriptions","organizations_url":"https://api.github.com/users/cookpad/orgs","repos_url":"https://api.github.com/users/cookpad/repos","events_url":"https://api.github.com/users/cookpad/events{/privacy}","received_events_url":"https://api.github.com/users/cookpad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cookpad/rrrspec","description":"Distributed RSpec","fork":false,"url":"https://api.github.com/repos/cookpad/rrrspec","forks_url":"https://api.github.com/repos/cookpad/rrrspec/forks","keys_url":"https://api.github.com/repos/cookpad/rrrspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cookpad/rrrspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cookpad/rrrspec/teams","hooks_url":"https://api.github.com/repos/cookpad/rrrspec/hooks","issue_events_url":"https://api.github.com/repos/cookpad/rrrspec/issues/events{/number}","events_url":"https://api.github.com/repos/cookpad/rrrspec/events","assignees_url":"https://api.github.com/repos/cookpad/rrrspec/assignees{/user}","branches_url":"https://api.github.com/repos/cookpad/rrrspec/branches{/branch}","tags_url":"https://api.github.com/repos/cookpad/rrrspec/tags","blobs_url":"https://api.github.com/repos/cookpad/rrrspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cookpad/rrrspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cookpad/rrrspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/cookpad/rrrspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cookpad/rrrspec/statuses/{sha}","languages_url":"https://api.github.com/repos/cookpad/rrrspec/languages","stargazers_url":"https://api.github.com/repos/cookpad/rrrspec/stargazers","contributors_url":"https://api.github.com/repos/cookpad/rrrspec/contributors","subscribers_url":"https://api.github.com/repos/cookpad/rrrspec/subscribers","subscription_url":"https://api.github.com/repos/cookpad/rrrspec/subscription","commits_url":"https://api.github.com/repos/cookpad/rrrspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/cookpad/rrrspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/cookpad/rrrspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/cookpad/rrrspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/cookpad/rrrspec/contents/{+path}","compare_url":"https://api.github.com/repos/cookpad/rrrspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cookpad/rrrspec/merges","archive_url":"https://api.github.com/repos/cookpad/rrrspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cookpad/rrrspec/downloads","issues_url":"https://api.github.com/repos/cookpad/rrrspec/issues{/number}","pulls_url":"https://api.github.com/repos/cookpad/rrrspec/pulls{/number}","milestones_url":"https://api.github.com/repos/cookpad/rrrspec/milestones{/number}","notifications_url":"https://api.github.com/repos/cookpad/rrrspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cookpad/rrrspec/labels{/name}","releases_url":"https://api.github.com/repos/cookpad/rrrspec/releases{/id}","created_at":"2014-02-13T09:06:44Z","updated_at":"2015-03-11T09:31:45Z","pushed_at":"2015-03-11T09:31:45Z","git_url":"git://github.com/cookpad/rrrspec.git","ssh_url":"git@github.com:cookpad/rrrspec.git","clone_url":"https://github.com/cookpad/rrrspec.git","svn_url":"https://github.com/cookpad/rrrspec","homepage":"","size":1468,"stargazers_count":261,"watchers_count":261,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/39"},"html":{"href":"https://github.com/cookpad/rrrspec/pull/39"},"issue":{"href":"https://api.github.com/repos/cookpad/rrrspec/issues/39"},"comments":{"href":"https://api.github.com/repos/cookpad/rrrspec/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/cookpad/rrrspec/statuses/879bf0bf5b36c34ed72568205a5b4cd0b49e371d"}}}}