{"push_id":583806674,"size":44,"distinct_size":2,"ref":"refs/heads/RocksJava-Final-Patch","head":"2e1ccebf9b5d396556d608bdfcae704983ca42ce","before":"d9c8d5d7f5b4b5af8671eda3bfb660719eb3e5a6","commits":[{"sha":"43970127077700bbd08c0647ff1936ab5f96afa7","author":{"email":"a5cc31cb4e999d94012a4def28086ffbbec2d06a@gmail.com","name":"fyrz"},"message":"[RocksJava] Redundant access-modifier in interfaces\n\nRemoved redundant access modifier in interfaces.","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/43970127077700bbd08c0647ff1936ab5f96afa7"},{"sha":"6a0e737d9dd0531d0e4ebe2e6d4ded460eae018b","author":{"email":"a5cc31cb4e999d94012a4def28086ffbbec2d06a@gmail.com","name":"fyrz"},"message":"[RocksJava] Raw use of parametrized class\n\nResolved raw use of parametrized class issues.","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/6a0e737d9dd0531d0e4ebe2e6d4ded460eae018b"},{"sha":"b3fd162267c8253dc4de1294addc112ffb7f131b","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: remove unportable use of sed in favor of $(CXX)'s -MT\n\nSummary:\nThe code being removed would invoke sed differently to work\naround a portability difference in how sed -i works (different\non MacOS).  Yet performing a host-type-based ifdef fails when\nthe tools installed do not match.  That sed use was solely to\npost-process the .d file.  Instead, generate the desired output\ndirectly, by using the compiler's -MT<FILE> option.\n* Makefile (%.d: %.cc): With the prior use of Makefile-ifdef'd\nsed, when building on MacOS with gnu sed, every run of this rule\nwould fail with a sed usage error.  Also list each .d file as a\ndependent.\n\nTest Plan:\n  Ensure that a selected .d file is the same as before both with\n  g++ and with clang++.  However, note that the new .d files each\n  contain a new reference to the .d file itself.\n\nReviewers: sdong, ljin, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33369","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/b3fd162267c8253dc4de1294addc112ffb7f131b"},{"sha":"4e4b8578415d14393693467516e0ceb59e95b10f","author":{"email":"b686a470e0c11c198659bc102501f776e80830c6@dev2555.prn2.facebook.com","name":"Igor Sugak"},"message":"rocksdb: Fix scan-build 'Called C++ object pointer is null' and 'Dereference of null pointer' bugs\n\nSummary:\nIn the existing implementation of `ASSERT*`, test termination happens in `~Tester`, which is called when instance of `Tester` goes out of scope. This is the cause of many scan-build bugs.\n\nThis diff changes `ASSERT*` to terminate the test immediately. Also added one suppression in `util/signal_test.cc`\n\nscan-build bugs\nbefore: http://home.fburl.com/~sugak/latest/index.html\nafter: http://home.fburl.com/~sugak/latest2/index.html\n\nTest Plan:\nModify some test to fail an assertion and make sure that `ASSERT*` terminated the test.\n\nRun `make analyze` and make sure no 'Called C++ object pointer is null' and 'Dereference of null pointer' bugs reported.\n\nRun tests and make sure no failing tests:\n```lang=bash\n% make check\n% USE_CLANG=1 make check\n```\n\nReviewers: meyering, lgalanis, sdong, rven, igor\n\nReviewed By: igor\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D33381","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/4e4b8578415d14393693467516e0ceb59e95b10f"},{"sha":"b9a0213cda52a5ca801114144916995f778d25ee","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: fix unportable Makefile syntax\n\nSummary:\n* Makefile (dummy): Prefix this statement with \"dummy := \",\nso that it no longer triggers a syntax error from GNU make 3.80\nand earlier.  Reported by nielsl in\nhttps://github.com/facebook/rocksdb/issues/509\n\nTest Plan: run make\n\nReviewers: sdong, ljin, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33429","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/b9a0213cda52a5ca801114144916995f778d25ee"},{"sha":"e60bc99fe0a2ff57f217c0d3463741812c60d23b","author":{"email":"e363a170056789af5295e3062579e8b8a22461d8@fb.com","name":"Yueh-Hsuan Chiang"},"message":"Allow GetThreadList to reflect flush activity.\n\nSummary: Allow GetThreadList to reflect flush activity.\n\nTest Plan:\nDeveloped ThreadStatusFlush test and updated ThreadStatusMultiCompaction test.\n\n./db_test  ./thread_list_test\n\nReviewers: sdong, rven, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D32871","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/e60bc99fe0a2ff57f217c0d3463741812c60d23b"},{"sha":"daebb1f91657045c57b6ab222f7d2e3e679ae2f5","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: running \"make\" with no arguments must not \"uninstall\"\n\nSummary:\nBefore this change, running \"make\" with no arguments would\nsilently run the rules for the \"uninstall\" target(!).  Don't do that.\n* Makefile (default): New, first target; depend on \"all\".\n(uninstall, install): Do not hide the commands we run.\n\nTest Plan:\n  Run \"make\" and verify that the rules for \"uninstall\" are no longer run.\n  Instead, note that many files are compiled and linked.  Before, none were.\n\nReviewers: sdong, ljin, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33531","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/daebb1f91657045c57b6ab222f7d2e3e679ae2f5"},{"sha":"f0c36da6eea12a35ae97f07561eb3bf8e7f860a8","author":{"email":"e363a170056789af5295e3062579e8b8a22461d8@fb.com","name":"Yueh-Hsuan Chiang"},"message":"Add thread_status_util_debug.cc back\n\nSummary:\nAdd thread_status_util_debug.cc back as InstrumentedMutex related tests\nare using it to produce wait that can be reflected in the counter.\n\nTest Plan:\n./perf_context_test\nexport ROCKSDB_TESTS=MutexWaitStats\n./db_test\n\nReviewers: sdong, igor\n\nReviewed By: igor\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D33525","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/f0c36da6eea12a35ae97f07561eb3bf8e7f860a8"},{"sha":"12753130ec9b54189a1a0b0b9a821c47e6c17dc5","author":{"email":"e363a170056789af5295e3062579e8b8a22461d8@fb.com","name":"Yueh-Hsuan Chiang"},"message":"Remove ThreadStatusMultiCompaction test\n\nSummary:\nRemove ThreadStatusMultiCompaction test as it's currently written\nin a way that depends on some randomness, while the flush / compaction\nstatus of a single thread is also covered in ThreadStatusFlush\nand ThreadStatusSingleCompaction tests.\n\nTest Plan: ./db_test\n\nReviewers: igor, sdong\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D33537","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/12753130ec9b54189a1a0b0b9a821c47e6c17dc5"},{"sha":"3ad6b794cf7b547e489489bc4af0e2b523b424be","author":{"email":"b686a470e0c11c198659bc102501f776e80830c6@dev2555.prn2.facebook.com","name":"Igor Sugak"},"message":"rocksdb: Fix 'Division by zero' scan-build warning\n\nSummary:\nscan-build complains with division by zero warning in a test. Added an assertion to prevent this.\n\nscan-build report: http://home.fburl.com/~sugak/latest6/report-c61be9.html#EndPath\n\nTest Plan:\nMake sure scan-build does not report 'Division by zero' and all tests are passing.\n```lang=bash\n% make analyze\n% make check\n```\n\nReviewers: igor, meyering\n\nReviewed By: meyering\n\nSubscribers: sdong, dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D33495","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/3ad6b794cf7b547e489489bc4af0e2b523b424be"},{"sha":"55277c32871d275c314c9a28ad5df8fb92b3b6ad","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: remove unused rules: rocksdb_shell, DBClientProxy_test\n\nSummary:\nThere were Makefile rules to build those two targets,\nbut neither rule has worked for a long time, due to missing\ndependent source files.  Remove those rules.\n\nTest Plan: run \"make\"\n\nReviewers: sdong, ljin, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33567","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/55277c32871d275c314c9a28ad5df8fb92b3b6ad"},{"sha":"a37b46ae127b40184544f824239f75c3a1b5637a","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: fix Makefile inconsistencies (trivial)\n\nSummary:\nThis is in preparation for some factorization.\n* Makefile (deletefile_test): Add $(COVERAGEFLAGS) to link command.\n(options_test): Remove explicit (redundant) dependency on\noptions_helper.o: that is already a dependent, via $(LIBOBJECTS)\n\nTest Plan: run make\n\nReviewers: sdong, ljin, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33573","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/a37b46ae127b40184544f824239f75c3a1b5637a"},{"sha":"dc885c6e95a28c5005f47068682c05327b973613","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: make \"make\" output readable by default\n\nSummary:\nWith this change, make now prints a summary line for each\ncompiler and linker invocation, e.g.,:\n\n  CC       db/builder.o\n  CC       db/c.o\n  CC       db/column_family.o\n\nTo see full commands, insert \"V=1\" into your make command.\nE.g., run \"make V=1 all\" if you want it to print each command\nin its full glory.\n\n$^ is GNU make's abbreviation for the prerequisites of the current target.\nThese AM_V_... variables expand to some very short string like \"CC\" or\n\"LD\", by default, so that the output of \"make\" is readable.  If/when you\nwant more details, just build with \"make V=1 ...\", and make will print\neach full command as it is executed.  If you prefer to see the noise\nall the time, and only want to optionally see the abbreviated output,\nset AM_DEFAULT_VERBOSITY=1 in your environment, and then build with\nV=0 to see the abbreviated command indicators.\n\nTest Plan:\ninvoke make a few different ways and observe:\n  make clean; make       # abbreviated\n  make clean; make V=0   # also abbreviated\n  make clean; make V=1   # full detail\n\nReviewers: sdong, ljin, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33579","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/dc885c6e95a28c5005f47068682c05327b973613"},{"sha":"b4b8c25a5abec7caeb4afc42a7428fb7d330e698","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: factor out AM_LINK command (trivial)\n\nSummary:\n  Many link commands were identical.\n  Factor that out into a variable, AM_LINK, and use\n  it in place of all of those open-coded commands.\n\nTest Plan: run \"make check\"\n\nReviewers: ljin, igor, sdong\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33585","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/b4b8c25a5abec7caeb4afc42a7428fb7d330e698"},{"sha":"7d817268b989af6ccd0b273e47765be9c4619e98","author":{"email":"01b4858c232b891e1ad3edd1cd6314647466376f@fb.com","name":"Venkatesh Radhakrishnan"},"message":"Managed iterator\n\nSummary:\nThis is a diff for managed iterator. A managed iterator\nis a wrapper around an iterator which saves the options for that\niterator as well as the current key/value so that the underlying iterator\nand its associated memory can be released when it is aged out\nautomatically or on the request of the user. Will provide the automatic release as a follow-up diff.\n\nTest Plan: Managed* tests in db_test and XF tests for managed iterator\n\nReviewers: igor, yhchiang, anthony, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D31401","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/7d817268b989af6ccd0b273e47765be9c4619e98"},{"sha":"7ce1b2c19c00f303214305ac4cc9a67296ede84a","author":{"email":"e2d5d952016900c477a889ac4d8800bc5b695b9c@gmail.com","name":"stash93"},"message":"Fbson to Json\n\nSummary: Replaced rapidjson with fbson\n\nTest Plan:\nmake all check\nmake valgrind_check\n\nReviewers: golovachalexander, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D32733","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/7ce1b2c19c00f303214305ac4cc9a67296ede84a"},{"sha":"b8ac71ba1806aaeab52052f8a7984df1b796e499","author":{"email":"b74673f3c990e809b0211cc26cf8ff8cc1ef0907@fb.com","name":"Igor Canadi"},"message":"Revert \"Fbson to Json\"\n\nThis reverts commit 7ce1b2c19c00f303214305ac4cc9a67296ede84a.","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/b8ac71ba1806aaeab52052f8a7984df1b796e499"},{"sha":"11581b7415b203425704f14ebfbc228bedd7e5e6","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: abbreviate AR command, too\n\nSummary:\nThe \"ar\" command was excessively verbose.\nThis abbreviates it to be like CC and LD.\nAlso, factor \"rs\" options into ARFLAGS.\n\nTest Plan:\n  $ rm librocksdb.a\n  $ make librocksdb.a\n  AR       librocksdb.a\n  ar: creating librocksdb.a\n\nReviewers: ljin, sdong, igor.sugak, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33699","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/11581b7415b203425704f14ebfbc228bedd7e5e6"},{"sha":"d45a6a4002629e840439a56fd42272cce47ee6a2","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"Add rocksdb.num-live-versions: number of live versions\n\nSummary: Add a DB property about live versions. It can be helpful to figure out whether there are files not live but not yet deleted, in some use cases.\n\nTest Plan: make all check\n\nReviewers: rven, yhchiang, igor\n\nReviewed By: igor\n\nSubscribers: yoshinorim, dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D33327","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/d45a6a4002629e840439a56fd42272cce47ee6a2"},{"sha":"a42324e3707cba2d1709e03a516af4cfaebe29fb","author":{"email":"15b0b14300fba1cff8c70eb2a5c1720ef2a4c654@fb.com","name":"Jim Meyering"},"message":"build: do not relink every single binary just for a timestamp\n\nSummary:\nPrior to this change, \"make check\" would always waste a lot of\ntime relinking 60+ binaries. With this change, it does that\nonly when the generated file, util/build_version.cc, changes,\nand that happens only when the date changes or when the\ncurrent git SHA changes.\n\nThis change makes some other improvements: before, there was no\nrule to build a deleted util/build_version.cc. If it was somehow\nremoved, any attempt to link a program would fail.\nThere is no longer any need for the separate file,\nbuild_tools/build_detect_version.  Its functionality is\nnow in the Makefile.\n\n* Makefile (DEPFILES): Don't filter-out util/build_version.cc.\nNo need, and besides, removing that dependency was wrong.\n(date, git_sha, gen_build_version): New helper variables.\n(util/build_version.cc): New rule, to create this file\nand update it only if it would contain new information.\n* build_tools/build_detect_platform: Remove file.\n* db/db_impl.cc: Now, print only date (not the time).\n* util/build_version.h (rocksdb_build_compile_time): Remove\ndeclaration.  No longer used.\n\nTest Plan:\n- Run \"make check\" twice, and note that the second time no linking is performed.\n- Remove util/build_version.cc and ensure that any \"make\"\ncommand regenerates it before doing anything else.\n- Run this: strings librocksdb.a|grep _build_.\nThat prints output including the following:\n\n  rocksdb_build_git_date:2015-02-19\n  rocksdb_build_git_sha:2.8.fb-1792-g3cb6cc0\n\nReviewers: ljin, sdong, igor\n\nReviewed By: igor\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D33591","distinct":false,"url":"https://api.github.com/repos/fyrz/rocksdb/commits/a42324e3707cba2d1709e03a516af4cfaebe29fb"}]}