{"action":"created","comment":{"url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/comments/43226273","id":43226273,"diff_hunk":"@@ -106,4 +112,19 @@ public final void setPath(final String location) {\n         }\n     }\n \n+    @Override\n+    public void setVolume(final double volumeLevel) {\n+        try {\n+        audioClip.setVolume(volumeLevel);\n+        } catch (NullPointerException ne) { // NOPMD\n+            // This try-catch block is just here for testing.\n+            // The setVolume method can result in a NullPointer (according to\n+            // JUnit), because JUnit can't really play audio neither can Travis.","path":"src/main/java/nl/tudelft/ti2206/group9/audio/SoundEffectPlayer.java","position":38,"original_position":38,"commit_id":"47ab3235252a7a516c796652f62416998ba57542","original_commit_id":"2a546088d49aad183119a3faf6d06814b4e0baa2","user":{"login":"mdingjan","id":9783684,"avatar_url":"https://avatars.githubusercontent.com/u/9783684?v=3","gravatar_id":"","url":"https://api.github.com/users/mdingjan","html_url":"https://github.com/mdingjan","followers_url":"https://api.github.com/users/mdingjan/followers","following_url":"https://api.github.com/users/mdingjan/following{/other_user}","gists_url":"https://api.github.com/users/mdingjan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdingjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdingjan/subscriptions","organizations_url":"https://api.github.com/users/mdingjan/orgs","repos_url":"https://api.github.com/users/mdingjan/repos","events_url":"https://api.github.com/users/mdingjan/events{/privacy}","received_events_url":"https://api.github.com/users/mdingjan/received_events","type":"User","site_admin":false},"body":"Okay, I can live with that sort of catching :) I agree with your argument.\r\nWill change.\r\n\r\n<review,logic\r\n","created_at":"2015-10-28T08:10:16Z","updated_at":"2015-10-28T08:10:16Z","html_url":"https://github.com/thervh70/SEM_Team9/pull/198#discussion_r43226273","pull_request_url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/comments/43226273"},"html":{"href":"https://github.com/thervh70/SEM_Team9/pull/198#discussion_r43226273"},"pull_request":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198","id":48905932,"html_url":"https://github.com/thervh70/SEM_Team9/pull/198","diff_url":"https://github.com/thervh70/SEM_Team9/pull/198.diff","patch_url":"https://github.com/thervh70/SEM_Team9/pull/198.patch","issue_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues/198","number":198,"state":"open","locked":false,"title":"175 adapting the volume","user":{"login":"mdingjan","id":9783684,"avatar_url":"https://avatars.githubusercontent.com/u/9783684?v=3","gravatar_id":"","url":"https://api.github.com/users/mdingjan","html_url":"https://github.com/mdingjan","followers_url":"https://api.github.com/users/mdingjan/followers","following_url":"https://api.github.com/users/mdingjan/following{/other_user}","gists_url":"https://api.github.com/users/mdingjan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdingjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdingjan/subscriptions","organizations_url":"https://api.github.com/users/mdingjan/orgs","repos_url":"https://api.github.com/users/mdingjan/repos","events_url":"https://api.github.com/users/mdingjan/events{/privacy}","received_events_url":"https://api.github.com/users/mdingjan/received_events","type":"User","site_admin":false},"body":"Will close #175 \r\n\r\nThe feature is fully functional and tested well.\r\nI changed quite some things, so I will give you an overview of my changes again.\r\n\r\n- AudioPlayers have been extended so that the volume can be set and they have a default volume level from now on.\r\n- Changing the volume with the Soundtrack volume slider works nicely; besides updating the volume of the soundtracks in the application, soundtracks are updated directly on the fly. Thus changing the volume level will change the volume of the MainMenu soundtrack directly.\r\n- Changing the volume with the SoundEffect volume slider works nicely as well; quite the same as above, but this time the button sound effects are directly updated.\r\n- The information about a user's volume settings (thus volume of both soundtrack and sound effects) are saved in State.\r\n- Volume settings are saved and can be loaded with our Parser and Writer. In addition to this, when loading a saved account on which the sliders have been moved (for example to 3), then, when loaded, the sliders will initialise at this point (thus at 3 and not to MAX/2 <=> 5).\r\n- The E2E has been adapted. The robot moves the sliders now.\r\n\r\nPlease have a look at my changes and please start the application so that you can test my new feature.\r\nHave fun sliding!\r\n\r\n<feature,testing,organisation","created_at":"2015-10-27T17:40:30Z","updated_at":"2015-10-28T08:10:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d7803189c52ff97fc74efcd468f437f99042a6f","assignee":{"login":"mdingjan","id":9783684,"avatar_url":"https://avatars.githubusercontent.com/u/9783684?v=3","gravatar_id":"","url":"https://api.github.com/users/mdingjan","html_url":"https://github.com/mdingjan","followers_url":"https://api.github.com/users/mdingjan/followers","following_url":"https://api.github.com/users/mdingjan/following{/other_user}","gists_url":"https://api.github.com/users/mdingjan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdingjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdingjan/subscriptions","organizations_url":"https://api.github.com/users/mdingjan/orgs","repos_url":"https://api.github.com/users/mdingjan/repos","events_url":"https://api.github.com/users/mdingjan/events{/privacy}","received_events_url":"https://api.github.com/users/mdingjan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198/commits","review_comments_url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198/comments","review_comment_url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues/198/comments","statuses_url":"https://api.github.com/repos/thervh70/SEM_Team9/statuses/47ab3235252a7a516c796652f62416998ba57542","head":{"label":"thervh70:175-adapting-the-volume","ref":"175-adapting-the-volume","sha":"47ab3235252a7a516c796652f62416998ba57542","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"repo":{"id":41675883,"name":"SEM_Team9","full_name":"thervh70/SEM_Team9","owner":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thervh70/SEM_Team9","description":"","fork":false,"url":"https://api.github.com/repos/thervh70/SEM_Team9","forks_url":"https://api.github.com/repos/thervh70/SEM_Team9/forks","keys_url":"https://api.github.com/repos/thervh70/SEM_Team9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thervh70/SEM_Team9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thervh70/SEM_Team9/teams","hooks_url":"https://api.github.com/repos/thervh70/SEM_Team9/hooks","issue_events_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues/events{/number}","events_url":"https://api.github.com/repos/thervh70/SEM_Team9/events","assignees_url":"https://api.github.com/repos/thervh70/SEM_Team9/assignees{/user}","branches_url":"https://api.github.com/repos/thervh70/SEM_Team9/branches{/branch}","tags_url":"https://api.github.com/repos/thervh70/SEM_Team9/tags","blobs_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/refs{/sha}","trees_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thervh70/SEM_Team9/statuses/{sha}","languages_url":"https://api.github.com/repos/thervh70/SEM_Team9/languages","stargazers_url":"https://api.github.com/repos/thervh70/SEM_Team9/stargazers","contributors_url":"https://api.github.com/repos/thervh70/SEM_Team9/contributors","subscribers_url":"https://api.github.com/repos/thervh70/SEM_Team9/subscribers","subscription_url":"https://api.github.com/repos/thervh70/SEM_Team9/subscription","commits_url":"https://api.github.com/repos/thervh70/SEM_Team9/commits{/sha}","git_commits_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/commits{/sha}","comments_url":"https://api.github.com/repos/thervh70/SEM_Team9/comments{/number}","issue_comment_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues/comments{/number}","contents_url":"https://api.github.com/repos/thervh70/SEM_Team9/contents/{+path}","compare_url":"https://api.github.com/repos/thervh70/SEM_Team9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thervh70/SEM_Team9/merges","archive_url":"https://api.github.com/repos/thervh70/SEM_Team9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thervh70/SEM_Team9/downloads","issues_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues{/number}","pulls_url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls{/number}","milestones_url":"https://api.github.com/repos/thervh70/SEM_Team9/milestones{/number}","notifications_url":"https://api.github.com/repos/thervh70/SEM_Team9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thervh70/SEM_Team9/labels{/name}","releases_url":"https://api.github.com/repos/thervh70/SEM_Team9/releases{/id}","created_at":"2015-08-31T13:08:41Z","updated_at":"2015-09-11T10:38:33Z","pushed_at":"2015-10-28T07:14:29Z","git_url":"git://github.com/thervh70/SEM_Team9.git","ssh_url":"git@github.com:thervh70/SEM_Team9.git","clone_url":"https://github.com/thervh70/SEM_Team9.git","svn_url":"https://github.com/thervh70/SEM_Team9","homepage":null,"size":96271,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":2,"default_branch":"master"}},"base":{"label":"thervh70:master","ref":"master","sha":"72aeca90b0c8748e383de60de8e21024f31c5d50","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"repo":{"id":41675883,"name":"SEM_Team9","full_name":"thervh70/SEM_Team9","owner":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thervh70/SEM_Team9","description":"","fork":false,"url":"https://api.github.com/repos/thervh70/SEM_Team9","forks_url":"https://api.github.com/repos/thervh70/SEM_Team9/forks","keys_url":"https://api.github.com/repos/thervh70/SEM_Team9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thervh70/SEM_Team9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thervh70/SEM_Team9/teams","hooks_url":"https://api.github.com/repos/thervh70/SEM_Team9/hooks","issue_events_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues/events{/number}","events_url":"https://api.github.com/repos/thervh70/SEM_Team9/events","assignees_url":"https://api.github.com/repos/thervh70/SEM_Team9/assignees{/user}","branches_url":"https://api.github.com/repos/thervh70/SEM_Team9/branches{/branch}","tags_url":"https://api.github.com/repos/thervh70/SEM_Team9/tags","blobs_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/refs{/sha}","trees_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thervh70/SEM_Team9/statuses/{sha}","languages_url":"https://api.github.com/repos/thervh70/SEM_Team9/languages","stargazers_url":"https://api.github.com/repos/thervh70/SEM_Team9/stargazers","contributors_url":"https://api.github.com/repos/thervh70/SEM_Team9/contributors","subscribers_url":"https://api.github.com/repos/thervh70/SEM_Team9/subscribers","subscription_url":"https://api.github.com/repos/thervh70/SEM_Team9/subscription","commits_url":"https://api.github.com/repos/thervh70/SEM_Team9/commits{/sha}","git_commits_url":"https://api.github.com/repos/thervh70/SEM_Team9/git/commits{/sha}","comments_url":"https://api.github.com/repos/thervh70/SEM_Team9/comments{/number}","issue_comment_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues/comments{/number}","contents_url":"https://api.github.com/repos/thervh70/SEM_Team9/contents/{+path}","compare_url":"https://api.github.com/repos/thervh70/SEM_Team9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thervh70/SEM_Team9/merges","archive_url":"https://api.github.com/repos/thervh70/SEM_Team9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thervh70/SEM_Team9/downloads","issues_url":"https://api.github.com/repos/thervh70/SEM_Team9/issues{/number}","pulls_url":"https://api.github.com/repos/thervh70/SEM_Team9/pulls{/number}","milestones_url":"https://api.github.com/repos/thervh70/SEM_Team9/milestones{/number}","notifications_url":"https://api.github.com/repos/thervh70/SEM_Team9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thervh70/SEM_Team9/labels{/name}","releases_url":"https://api.github.com/repos/thervh70/SEM_Team9/releases{/id}","created_at":"2015-08-31T13:08:41Z","updated_at":"2015-09-11T10:38:33Z","pushed_at":"2015-10-28T07:14:29Z","git_url":"git://github.com/thervh70/SEM_Team9.git","ssh_url":"git@github.com:thervh70/SEM_Team9.git","clone_url":"https://github.com/thervh70/SEM_Team9.git","svn_url":"https://github.com/thervh70/SEM_Team9","homepage":null,"size":96271,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198"},"html":{"href":"https://github.com/thervh70/SEM_Team9/pull/198"},"issue":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/issues/198"},"comments":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/thervh70/SEM_Team9/statuses/47ab3235252a7a516c796652f62416998ba57542"}}}}