{"action":"created","comment":{"url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/25323916","id":25323916,"diff_hunk":"@@ -186,17 +235,23 @@ TEST(File, ScanDir) {\n   ASSERT_THROW(FileSystem::ScanDir(dir, scanner_before), DirDoesNotExistException);\n   ASSERT_THROW(FileSystem::ScanDirUntil(dir, scanner_before), DirDoesNotExistException);\n \n+#ifndef BRICKS_WINDOWS\n   {\n+    // TODO(dkorolev): Perhaps support this exception type on Windows as well.\n     const auto file_remover = FileSystem::ScopedRmFile(dir);\n     FileSystem::WriteStringToFile(\"This is a file, not a directory!\", dir.c_str());\n     ASSERT_THROW(FileSystem::ScanDir(dir, scanner_before), PathIsNotADirectoryException);\n     ASSERT_THROW(FileSystem::ScanDirUntil(dir, scanner_before), PathIsNotADirectoryException);\n   }\n+#endif\n \n   FileSystem::MkDir(dir);\n   FileSystem::WriteStringToFile(\"foo\", fn1.c_str());\n   FileSystem::WriteStringToFile(\"bar\", fn2.c_str());\n+#ifndef BRICKS_WINDOWS\n+  // Windows is not friendly with subdirectories.","path":"file/test.cc","position":129,"original_position":129,"commit_id":"dc65b1acb40859b672bb40c99b2552200cf87421","original_commit_id":"dc65b1acb40859b672bb40c99b2552200cf87421","user":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"body":"What does it mean? JoinPath should work, MkDir too.","created_at":"2015-02-25T08:18:16Z","updated_at":"2015-02-25T08:18:16Z","html_url":"https://github.com/KnowSheet/Bricks/pull/91#discussion_r25323916","pull_request_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/25323916"},"html":{"href":"https://github.com/KnowSheet/Bricks/pull/91#discussion_r25323916"},"pull_request":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91","id":29876154,"html_url":"https://github.com/KnowSheet/Bricks/pull/91","diff_url":"https://github.com/KnowSheet/Bricks/pull/91.diff","patch_url":"https://github.com/KnowSheet/Bricks/pull/91.patch","issue_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/91","number":91,"state":"open","locked":false,"title":"A single test, trying to run it on Windows.","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"body":"The remaining compilation problem is `opendir/readdir/closedir` and related. I'll solve it in the morning.\r\n\r\n@sompylasar : I'll handle the merge between this PR and your Mac OS changes. Btw, asked a friend for a few minutes of attention, and Bricks do build on Mac from your PR after a few changes; there are more issues though, which I'd have to look into.\r\n\r\n@deathbaba @sompylasar PTAL.\r\n\r\nThanks,\r\nDima","created_at":"2015-02-24T07:29:46Z","updated_at":"2015-02-25T08:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"870c5848ffb1a740b237a6baf5edc40bf9b70b52","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91/commits","review_comments_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91/comments","review_comment_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/91/comments","statuses_url":"https://api.github.com/repos/KnowSheet/Bricks/statuses/dc65b1acb40859b672bb40c99b2552200cf87421","head":{"label":"dkorolev:single_test_to_rule_them_all","ref":"single_test_to_rule_them_all","sha":"dc65b1acb40859b672bb40c99b2552200cf87421","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"repo":{"id":27625438,"name":"Bricks","full_name":"dkorolev/Bricks","owner":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkorolev/Bricks","description":"Our own core pieces to reuse.","fork":true,"url":"https://api.github.com/repos/dkorolev/Bricks","forks_url":"https://api.github.com/repos/dkorolev/Bricks/forks","keys_url":"https://api.github.com/repos/dkorolev/Bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkorolev/Bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkorolev/Bricks/teams","hooks_url":"https://api.github.com/repos/dkorolev/Bricks/hooks","issue_events_url":"https://api.github.com/repos/dkorolev/Bricks/issues/events{/number}","events_url":"https://api.github.com/repos/dkorolev/Bricks/events","assignees_url":"https://api.github.com/repos/dkorolev/Bricks/assignees{/user}","branches_url":"https://api.github.com/repos/dkorolev/Bricks/branches{/branch}","tags_url":"https://api.github.com/repos/dkorolev/Bricks/tags","blobs_url":"https://api.github.com/repos/dkorolev/Bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkorolev/Bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkorolev/Bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkorolev/Bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkorolev/Bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/dkorolev/Bricks/languages","stargazers_url":"https://api.github.com/repos/dkorolev/Bricks/stargazers","contributors_url":"https://api.github.com/repos/dkorolev/Bricks/contributors","subscribers_url":"https://api.github.com/repos/dkorolev/Bricks/subscribers","subscription_url":"https://api.github.com/repos/dkorolev/Bricks/subscription","commits_url":"https://api.github.com/repos/dkorolev/Bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkorolev/Bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkorolev/Bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkorolev/Bricks/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkorolev/Bricks/contents/{+path}","compare_url":"https://api.github.com/repos/dkorolev/Bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkorolev/Bricks/merges","archive_url":"https://api.github.com/repos/dkorolev/Bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkorolev/Bricks/downloads","issues_url":"https://api.github.com/repos/dkorolev/Bricks/issues{/number}","pulls_url":"https://api.github.com/repos/dkorolev/Bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/dkorolev/Bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/dkorolev/Bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkorolev/Bricks/labels{/name}","releases_url":"https://api.github.com/repos/dkorolev/Bricks/releases{/id}","created_at":"2014-12-06T06:52:51Z","updated_at":"2015-02-24T06:25:15Z","pushed_at":"2015-02-25T00:42:55Z","git_url":"git://github.com/dkorolev/Bricks.git","ssh_url":"git@github.com:dkorolev/Bricks.git","clone_url":"https://github.com/dkorolev/Bricks.git","svn_url":"https://github.com/dkorolev/Bricks","homepage":null,"size":4240,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KnowSheet:master","ref":"master","sha":"678d93c1f850234eb2a602efa6d6a69726ed1476","user":{"login":"KnowSheet","id":9897562,"avatar_url":"https://avatars.githubusercontent.com/u/9897562?v=3","gravatar_id":"","url":"https://api.github.com/users/KnowSheet","html_url":"https://github.com/KnowSheet","followers_url":"https://api.github.com/users/KnowSheet/followers","following_url":"https://api.github.com/users/KnowSheet/following{/other_user}","gists_url":"https://api.github.com/users/KnowSheet/gists{/gist_id}","starred_url":"https://api.github.com/users/KnowSheet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnowSheet/subscriptions","organizations_url":"https://api.github.com/users/KnowSheet/orgs","repos_url":"https://api.github.com/users/KnowSheet/repos","events_url":"https://api.github.com/users/KnowSheet/events{/privacy}","received_events_url":"https://api.github.com/users/KnowSheet/received_events","type":"Organization","site_admin":false},"repo":{"id":27625425,"name":"Bricks","full_name":"KnowSheet/Bricks","owner":{"login":"KnowSheet","id":9897562,"avatar_url":"https://avatars.githubusercontent.com/u/9897562?v=3","gravatar_id":"","url":"https://api.github.com/users/KnowSheet","html_url":"https://github.com/KnowSheet","followers_url":"https://api.github.com/users/KnowSheet/followers","following_url":"https://api.github.com/users/KnowSheet/following{/other_user}","gists_url":"https://api.github.com/users/KnowSheet/gists{/gist_id}","starred_url":"https://api.github.com/users/KnowSheet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnowSheet/subscriptions","organizations_url":"https://api.github.com/users/KnowSheet/orgs","repos_url":"https://api.github.com/users/KnowSheet/repos","events_url":"https://api.github.com/users/KnowSheet/events{/privacy}","received_events_url":"https://api.github.com/users/KnowSheet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnowSheet/Bricks","description":"Our own core pieces to reuse.","fork":false,"url":"https://api.github.com/repos/KnowSheet/Bricks","forks_url":"https://api.github.com/repos/KnowSheet/Bricks/forks","keys_url":"https://api.github.com/repos/KnowSheet/Bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnowSheet/Bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnowSheet/Bricks/teams","hooks_url":"https://api.github.com/repos/KnowSheet/Bricks/hooks","issue_events_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/events{/number}","events_url":"https://api.github.com/repos/KnowSheet/Bricks/events","assignees_url":"https://api.github.com/repos/KnowSheet/Bricks/assignees{/user}","branches_url":"https://api.github.com/repos/KnowSheet/Bricks/branches{/branch}","tags_url":"https://api.github.com/repos/KnowSheet/Bricks/tags","blobs_url":"https://api.github.com/repos/KnowSheet/Bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnowSheet/Bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnowSheet/Bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnowSheet/Bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnowSheet/Bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/KnowSheet/Bricks/languages","stargazers_url":"https://api.github.com/repos/KnowSheet/Bricks/stargazers","contributors_url":"https://api.github.com/repos/KnowSheet/Bricks/contributors","subscribers_url":"https://api.github.com/repos/KnowSheet/Bricks/subscribers","subscription_url":"https://api.github.com/repos/KnowSheet/Bricks/subscription","commits_url":"https://api.github.com/repos/KnowSheet/Bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnowSheet/Bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnowSheet/Bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnowSheet/Bricks/contents/{+path}","compare_url":"https://api.github.com/repos/KnowSheet/Bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnowSheet/Bricks/merges","archive_url":"https://api.github.com/repos/KnowSheet/Bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnowSheet/Bricks/downloads","issues_url":"https://api.github.com/repos/KnowSheet/Bricks/issues{/number}","pulls_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/KnowSheet/Bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/KnowSheet/Bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnowSheet/Bricks/labels{/name}","releases_url":"https://api.github.com/repos/KnowSheet/Bricks/releases{/id}","created_at":"2014-12-06T06:52:23Z","updated_at":"2015-02-24T06:23:24Z","pushed_at":"2015-02-24T06:23:22Z","git_url":"git://github.com/KnowSheet/Bricks.git","ssh_url":"git@github.com:KnowSheet/Bricks.git","clone_url":"https://github.com/KnowSheet/Bricks.git","svn_url":"https://github.com/KnowSheet/Bricks","homepage":null,"size":3681,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":15,"forks":4,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91"},"html":{"href":"https://github.com/KnowSheet/Bricks/pull/91"},"issue":{"href":"https://api.github.com/repos/KnowSheet/Bricks/issues/91"},"comments":{"href":"https://api.github.com/repos/KnowSheet/Bricks/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/KnowSheet/Bricks/statuses/dc65b1acb40859b672bb40c99b2552200cf87421"}}}}