{"action":"opened","number":88,"pull_request":{"url":"https://api.github.com/repos/iStefo/ember-select-2/pulls/88","id":34373863,"html_url":"https://github.com/iStefo/ember-select-2/pull/88","diff_url":"https://github.com/iStefo/ember-select-2/pull/88.diff","patch_url":"https://github.com/iStefo/ember-select-2/pull/88.patch","issue_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/88","number":88,"state":"open","locked":false,"title":"Allow different value separators","user":{"login":"drapergeek","id":89965,"avatar_url":"https://avatars.githubusercontent.com/u/89965?v=3","gravatar_id":"","url":"https://api.github.com/users/drapergeek","html_url":"https://github.com/drapergeek","followers_url":"https://api.github.com/users/drapergeek/followers","following_url":"https://api.github.com/users/drapergeek/following{/other_user}","gists_url":"https://api.github.com/users/drapergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/drapergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drapergeek/subscriptions","organizations_url":"https://api.github.com/users/drapergeek/orgs","repos_url":"https://api.github.com/users/drapergeek/repos","events_url":"https://api.github.com/users/drapergeek/events{/privacy}","received_events_url":"https://api.github.com/users/drapergeek/received_events","type":"User","site_admin":false},"body":"First of all, thank you for your work on this plugin. It saved me a huge amount of time vs wrapping select2 myself!\r\n\r\nI ran into an issue with my \"values\" having a comma in them. If a user selected any value with a comma in it, the select box would be disabled because it couldn't find the value in the content array. To take care of this issue I've made two changes:\r\n\r\n1. Allow the users to use a custom value separator. In case they ever want to split on something else.\r\n2. Allow the users to disable value separation all together. My opinion would probably be to not offer value splitting by default or to allow `valueSeparator=null` to override the default but I couldn't find anyway to support the single property option without a breaking change and I would love to get this feature in ASAP. The way it is written now, unless I missed something, you should be able to release this without a major version bump.\r\n\r\nI'm happy to make any test changes you'd prefer, this way seemed to be the most obvious way of testing it but I'm happy to accept any feedback.","created_at":"2015-04-29T15:20:44Z","updated_at":"2015-04-29T15:20:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iStefo/ember-select-2/pulls/88/commits","review_comments_url":"https://api.github.com/repos/iStefo/ember-select-2/pulls/88/comments","review_comment_url":"https://api.github.com/repos/iStefo/ember-select-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/88/comments","statuses_url":"https://api.github.com/repos/iStefo/ember-select-2/statuses/fd305a28df107e20b1fee5aa5e885bf9552ae1e6","head":{"label":"drapergeek:master","ref":"master","sha":"fd305a28df107e20b1fee5aa5e885bf9552ae1e6","user":{"login":"drapergeek","id":89965,"avatar_url":"https://avatars.githubusercontent.com/u/89965?v=3","gravatar_id":"","url":"https://api.github.com/users/drapergeek","html_url":"https://github.com/drapergeek","followers_url":"https://api.github.com/users/drapergeek/followers","following_url":"https://api.github.com/users/drapergeek/following{/other_user}","gists_url":"https://api.github.com/users/drapergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/drapergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drapergeek/subscriptions","organizations_url":"https://api.github.com/users/drapergeek/orgs","repos_url":"https://api.github.com/users/drapergeek/repos","events_url":"https://api.github.com/users/drapergeek/events{/privacy}","received_events_url":"https://api.github.com/users/drapergeek/received_events","type":"User","site_admin":false},"repo":{"id":34799090,"name":"ember-select-2","full_name":"drapergeek/ember-select-2","owner":{"login":"drapergeek","id":89965,"avatar_url":"https://avatars.githubusercontent.com/u/89965?v=3","gravatar_id":"","url":"https://api.github.com/users/drapergeek","html_url":"https://github.com/drapergeek","followers_url":"https://api.github.com/users/drapergeek/followers","following_url":"https://api.github.com/users/drapergeek/following{/other_user}","gists_url":"https://api.github.com/users/drapergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/drapergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drapergeek/subscriptions","organizations_url":"https://api.github.com/users/drapergeek/orgs","repos_url":"https://api.github.com/users/drapergeek/repos","events_url":"https://api.github.com/users/drapergeek/events{/privacy}","received_events_url":"https://api.github.com/users/drapergeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drapergeek/ember-select-2","description":"Select2 jQuery Plugin Wrapper for Ember.js","fork":true,"url":"https://api.github.com/repos/drapergeek/ember-select-2","forks_url":"https://api.github.com/repos/drapergeek/ember-select-2/forks","keys_url":"https://api.github.com/repos/drapergeek/ember-select-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drapergeek/ember-select-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drapergeek/ember-select-2/teams","hooks_url":"https://api.github.com/repos/drapergeek/ember-select-2/hooks","issue_events_url":"https://api.github.com/repos/drapergeek/ember-select-2/issues/events{/number}","events_url":"https://api.github.com/repos/drapergeek/ember-select-2/events","assignees_url":"https://api.github.com/repos/drapergeek/ember-select-2/assignees{/user}","branches_url":"https://api.github.com/repos/drapergeek/ember-select-2/branches{/branch}","tags_url":"https://api.github.com/repos/drapergeek/ember-select-2/tags","blobs_url":"https://api.github.com/repos/drapergeek/ember-select-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drapergeek/ember-select-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drapergeek/ember-select-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/drapergeek/ember-select-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drapergeek/ember-select-2/statuses/{sha}","languages_url":"https://api.github.com/repos/drapergeek/ember-select-2/languages","stargazers_url":"https://api.github.com/repos/drapergeek/ember-select-2/stargazers","contributors_url":"https://api.github.com/repos/drapergeek/ember-select-2/contributors","subscribers_url":"https://api.github.com/repos/drapergeek/ember-select-2/subscribers","subscription_url":"https://api.github.com/repos/drapergeek/ember-select-2/subscription","commits_url":"https://api.github.com/repos/drapergeek/ember-select-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/drapergeek/ember-select-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/drapergeek/ember-select-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/drapergeek/ember-select-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/drapergeek/ember-select-2/contents/{+path}","compare_url":"https://api.github.com/repos/drapergeek/ember-select-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drapergeek/ember-select-2/merges","archive_url":"https://api.github.com/repos/drapergeek/ember-select-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drapergeek/ember-select-2/downloads","issues_url":"https://api.github.com/repos/drapergeek/ember-select-2/issues{/number}","pulls_url":"https://api.github.com/repos/drapergeek/ember-select-2/pulls{/number}","milestones_url":"https://api.github.com/repos/drapergeek/ember-select-2/milestones{/number}","notifications_url":"https://api.github.com/repos/drapergeek/ember-select-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drapergeek/ember-select-2/labels{/name}","releases_url":"https://api.github.com/repos/drapergeek/ember-select-2/releases{/id}","created_at":"2015-04-29T14:38:25Z","updated_at":"2015-04-29T15:20:19Z","pushed_at":"2015-04-29T15:20:19Z","git_url":"git://github.com/drapergeek/ember-select-2.git","ssh_url":"git@github.com:drapergeek/ember-select-2.git","clone_url":"https://github.com/drapergeek/ember-select-2.git","svn_url":"https://github.com/drapergeek/ember-select-2","homepage":null,"size":3076,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iStefo:master","ref":"master","sha":"c33f9e23c255f418d523fc07c01cd6f64a2bdcd4","user":{"login":"iStefo","id":768764,"avatar_url":"https://avatars.githubusercontent.com/u/768764?v=3","gravatar_id":"","url":"https://api.github.com/users/iStefo","html_url":"https://github.com/iStefo","followers_url":"https://api.github.com/users/iStefo/followers","following_url":"https://api.github.com/users/iStefo/following{/other_user}","gists_url":"https://api.github.com/users/iStefo/gists{/gist_id}","starred_url":"https://api.github.com/users/iStefo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iStefo/subscriptions","organizations_url":"https://api.github.com/users/iStefo/orgs","repos_url":"https://api.github.com/users/iStefo/repos","events_url":"https://api.github.com/users/iStefo/events{/privacy}","received_events_url":"https://api.github.com/users/iStefo/received_events","type":"User","site_admin":false},"repo":{"id":19354917,"name":"ember-select-2","full_name":"iStefo/ember-select-2","owner":{"login":"iStefo","id":768764,"avatar_url":"https://avatars.githubusercontent.com/u/768764?v=3","gravatar_id":"","url":"https://api.github.com/users/iStefo","html_url":"https://github.com/iStefo","followers_url":"https://api.github.com/users/iStefo/followers","following_url":"https://api.github.com/users/iStefo/following{/other_user}","gists_url":"https://api.github.com/users/iStefo/gists{/gist_id}","starred_url":"https://api.github.com/users/iStefo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iStefo/subscriptions","organizations_url":"https://api.github.com/users/iStefo/orgs","repos_url":"https://api.github.com/users/iStefo/repos","events_url":"https://api.github.com/users/iStefo/events{/privacy}","received_events_url":"https://api.github.com/users/iStefo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iStefo/ember-select-2","description":"Select2 jQuery Plugin Wrapper for Ember.js","fork":false,"url":"https://api.github.com/repos/iStefo/ember-select-2","forks_url":"https://api.github.com/repos/iStefo/ember-select-2/forks","keys_url":"https://api.github.com/repos/iStefo/ember-select-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iStefo/ember-select-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iStefo/ember-select-2/teams","hooks_url":"https://api.github.com/repos/iStefo/ember-select-2/hooks","issue_events_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/events{/number}","events_url":"https://api.github.com/repos/iStefo/ember-select-2/events","assignees_url":"https://api.github.com/repos/iStefo/ember-select-2/assignees{/user}","branches_url":"https://api.github.com/repos/iStefo/ember-select-2/branches{/branch}","tags_url":"https://api.github.com/repos/iStefo/ember-select-2/tags","blobs_url":"https://api.github.com/repos/iStefo/ember-select-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iStefo/ember-select-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iStefo/ember-select-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iStefo/ember-select-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iStefo/ember-select-2/statuses/{sha}","languages_url":"https://api.github.com/repos/iStefo/ember-select-2/languages","stargazers_url":"https://api.github.com/repos/iStefo/ember-select-2/stargazers","contributors_url":"https://api.github.com/repos/iStefo/ember-select-2/contributors","subscribers_url":"https://api.github.com/repos/iStefo/ember-select-2/subscribers","subscription_url":"https://api.github.com/repos/iStefo/ember-select-2/subscription","commits_url":"https://api.github.com/repos/iStefo/ember-select-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iStefo/ember-select-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iStefo/ember-select-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iStefo/ember-select-2/contents/{+path}","compare_url":"https://api.github.com/repos/iStefo/ember-select-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iStefo/ember-select-2/merges","archive_url":"https://api.github.com/repos/iStefo/ember-select-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iStefo/ember-select-2/downloads","issues_url":"https://api.github.com/repos/iStefo/ember-select-2/issues{/number}","pulls_url":"https://api.github.com/repos/iStefo/ember-select-2/pulls{/number}","milestones_url":"https://api.github.com/repos/iStefo/ember-select-2/milestones{/number}","notifications_url":"https://api.github.com/repos/iStefo/ember-select-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iStefo/ember-select-2/labels{/name}","releases_url":"https://api.github.com/repos/iStefo/ember-select-2/releases{/id}","created_at":"2014-05-01T19:19:44Z","updated_at":"2015-04-25T19:20:05Z","pushed_at":"2015-04-15T08:52:17Z","git_url":"git://github.com/iStefo/ember-select-2.git","ssh_url":"git@github.com:iStefo/ember-select-2.git","clone_url":"https://github.com/iStefo/ember-select-2.git","svn_url":"https://github.com/iStefo/ember-select-2","homepage":null,"size":3076,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":34,"forks":69,"open_issues":34,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iStefo/ember-select-2/pulls/88"},"html":{"href":"https://github.com/iStefo/ember-select-2/pull/88"},"issue":{"href":"https://api.github.com/repos/iStefo/ember-select-2/issues/88"},"comments":{"href":"https://api.github.com/repos/iStefo/ember-select-2/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/iStefo/ember-select-2/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/iStefo/ember-select-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iStefo/ember-select-2/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/iStefo/ember-select-2/statuses/fd305a28df107e20b1fee5aa5e885bf9552ae1e6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":57,"deletions":2,"changed_files":2}}