{"action":"created","comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/33647424","id":33647424,"diff_hunk":"@@ -0,0 +1,32 @@\n+;;; config.el --- Colors Layer configuration File for Spacemacs\n+;;\n+;; Copyright (c) 2012-2014 Sylvain Benner\n+;; Copyright (c) 2014-2015 Sylvain Benner & Contributors\n+;;\n+;; Author: Sylvain Benner <sylvain.benner@gmail.com>\n+;; URL: https://github.com/syl20bnr/spacemacs\n+;;\n+;; This file is not part of GNU Emacs.\n+;;\n+;;; License: GPLv3\n+\n+;; Variables\n+\n+(defvar chinese-im-enable-pinyin nil\n+  \"Use Pinyin input method.\")\n+\n+(defvar chinese-im-enable-wubi nil\n+  \"Use Wubi input method.\")","path":"contrib/chinese/config.el","position":19,"original_position":19,"commit_id":"5fe9600bc09c4fe0302c79f386bb119254d0851e","original_commit_id":"5fe9600bc09c4fe0302c79f386bb119254d0851e","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"body":"Can both of these input method variable be enabled at the same time ?\r\nIf the expected behavior is to enable either one or the other then we can unify the variables under one variable `chinese-default-input-method` with the possible values `pinyin`and `wubi`.\r\n\r\nIn any case I would make the names more obvious with `input-method` instead of  `im` and `enable` should follow the layer name. It gives:\r\n- `chinese-enable-pinyin-input-method`\r\n- `chinese-enable-wubi-input-method`\r\n","created_at":"2015-07-01T04:30:07Z","updated_at":"2015-07-01T04:30:07Z","html_url":"https://github.com/syl20bnr/spacemacs/pull/2132#discussion_r33647424","pull_request_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132","_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/33647424"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/2132#discussion_r33647424"},"pull_request":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132"}}},"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132","id":38710857,"html_url":"https://github.com/syl20bnr/spacemacs/pull/2132","diff_url":"https://github.com/syl20bnr/spacemacs/pull/2132.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/2132.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2132","number":2132,"state":"open","locked":false,"title":"Add Chinese layer to spacemacs.","user":{"login":"andyque","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/andyque","html_url":"https://github.com/andyque","followers_url":"https://api.github.com/users/andyque/followers","following_url":"https://api.github.com/users/andyque/following{/other_user}","gists_url":"https://api.github.com/users/andyque/gists{/gist_id}","starred_url":"https://api.github.com/users/andyque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyque/subscriptions","organizations_url":"https://api.github.com/users/andyque/orgs","repos_url":"https://api.github.com/users/andyque/repos","events_url":"https://api.github.com/users/andyque/events{/privacy}","received_events_url":"https://api.github.com/users/andyque/received_events","type":"User","site_admin":false},"body":"This layer mainly add the following functionalities:\r\n\r\nAdd Chinese Pinyin Input method.\r\nAdd Chinese Wubi input method.\r\nAdd Youdao Dictionary.\r\nAdd Chinese Pinyin support for ace-jump-mode\r\nAdd Chinese Pinyin search ability in dired buffer\r\nImprove the font size when mix Chinese and English words.","created_at":"2015-06-27T15:14:12Z","updated_at":"2015-07-01T04:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6687cefa803b83bc40cdf72cdc4c839a2a62fd0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2132/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/5fe9600bc09c4fe0302c79f386bb119254d0851e","head":{"label":"andyque:add-chinese-layer-to-spacemacs","ref":"add-chinese-layer-to-spacemacs","sha":"5fe9600bc09c4fe0302c79f386bb119254d0851e","user":{"login":"andyque","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/andyque","html_url":"https://github.com/andyque","followers_url":"https://api.github.com/users/andyque/followers","following_url":"https://api.github.com/users/andyque/following{/other_user}","gists_url":"https://api.github.com/users/andyque/gists{/gist_id}","starred_url":"https://api.github.com/users/andyque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyque/subscriptions","organizations_url":"https://api.github.com/users/andyque/orgs","repos_url":"https://api.github.com/users/andyque/repos","events_url":"https://api.github.com/users/andyque/events{/privacy}","received_events_url":"https://api.github.com/users/andyque/received_events","type":"User","site_admin":false},"repo":{"id":34550095,"name":"spacemacs","full_name":"andyque/spacemacs","owner":{"login":"andyque","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/andyque","html_url":"https://github.com/andyque","followers_url":"https://api.github.com/users/andyque/followers","following_url":"https://api.github.com/users/andyque/following{/other_user}","gists_url":"https://api.github.com/users/andyque/gists{/gist_id}","starred_url":"https://api.github.com/users/andyque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyque/subscriptions","organizations_url":"https://api.github.com/users/andyque/orgs","repos_url":"https://api.github.com/users/andyque/repos","events_url":"https://api.github.com/users/andyque/events{/privacy}","received_events_url":"https://api.github.com/users/andyque/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyque/spacemacs","description":"Emacs advanced Kit focused on Evil: The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":true,"url":"https://api.github.com/repos/andyque/spacemacs","forks_url":"https://api.github.com/repos/andyque/spacemacs/forks","keys_url":"https://api.github.com/repos/andyque/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyque/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyque/spacemacs/teams","hooks_url":"https://api.github.com/repos/andyque/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/andyque/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/andyque/spacemacs/events","assignees_url":"https://api.github.com/repos/andyque/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/andyque/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/andyque/spacemacs/tags","blobs_url":"https://api.github.com/repos/andyque/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyque/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyque/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyque/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyque/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/andyque/spacemacs/languages","stargazers_url":"https://api.github.com/repos/andyque/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/andyque/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/andyque/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/andyque/spacemacs/subscription","commits_url":"https://api.github.com/repos/andyque/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyque/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyque/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyque/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyque/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/andyque/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyque/spacemacs/merges","archive_url":"https://api.github.com/repos/andyque/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyque/spacemacs/downloads","issues_url":"https://api.github.com/repos/andyque/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/andyque/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/andyque/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/andyque/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyque/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/andyque/spacemacs/releases{/id}","created_at":"2015-04-25T01:25:15Z","updated_at":"2015-04-30T07:58:15Z","pushed_at":"2015-06-27T15:14:36Z","git_url":"git://github.com/andyque/spacemacs.git","ssh_url":"git@github.com:andyque/spacemacs.git","clone_url":"https://github.com/andyque/spacemacs.git","svn_url":"https://github.com/andyque/spacemacs","homepage":"https://twitter.com/spacemacs","size":15973,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"c472191ea55c40612263d54bc1022b0129fa3929","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"Emacs advanced Kit focused on Evil: The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","created_at":"2012-12-17T21:34:03Z","updated_at":"2015-07-01T03:25:43Z","pushed_at":"2015-06-30T13:06:38Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"https://twitter.com/spacemacs","size":33503,"stargazers_count":2750,"watchers_count":2750,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":593,"mirror_url":null,"open_issues_count":518,"forks":593,"open_issues":518,"watchers":2750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/2132"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2132"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2132/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2132/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/5fe9600bc09c4fe0302c79f386bb119254d0851e"}}}}