{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/19","id":46031031,"html_url":"https://github.com/RIPE-NCC/ripe-atlas-tools/pull/19","diff_url":"https://github.com/RIPE-NCC/ripe-atlas-tools/pull/19.diff","patch_url":"https://github.com/RIPE-NCC/ripe-atlas-tools/pull/19.patch","issue_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues/19","number":19,"state":"closed","locked":false,"title":"dry-run for measure command + more aggregators","user":{"login":"pierky","id":6806218,"avatar_url":"https://avatars.githubusercontent.com/u/6806218?v=3","gravatar_id":"","url":"https://api.github.com/users/pierky","html_url":"https://github.com/pierky","followers_url":"https://api.github.com/users/pierky/followers","following_url":"https://api.github.com/users/pierky/following{/other_user}","gists_url":"https://api.github.com/users/pierky/gists{/gist_id}","starred_url":"https://api.github.com/users/pierky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierky/subscriptions","organizations_url":"https://api.github.com/users/pierky/orgs","repos_url":"https://api.github.com/users/pierky/repos","events_url":"https://api.github.com/users/pierky/events{/privacy}","received_events_url":"https://api.github.com/users/pierky/received_events","type":"User","site_admin":false},"body":"I thought to move the `aggregate` method to the base `Aggregator` class and abstract the aggregation key on children classes.\r\nI added some aggregators based on probes' properties (ASN) and on specific results parameters (ping avg RTT at this time).\r\nOptions can now be passed to aggregators using the `--aggregate-by-opt` argument (even multiple times); options parsing is in charge of the aggregator's `_prepare` method.\r\n\r\nExample:\r\n\r\n```\r\n$ ripe-atlas report 2449754 --aggregate-by avg_rtt\r\n\r\nRIPE Atlas Report for Measurement #2449754\r\n===================================================\r\n\r\nPing 217.151.0.8\r\n\r\n200-300 ms\r\n  48 bytes from probe #6059  196.192.112.244 to 217.151.0.8 (217.151.0.8): ttl=50 times:235.024, 233.995, 234.622,\r\n  48 bytes from probe #6090  82.148.114.58   to 217.151.0.8 (217.151.0.8): ttl=52 times:209.547, 205.908, 205.941,\r\n  48 bytes from probe #6099  200.160.6.19    to 217.151.0.8 (217.151.0.8): ttl=49 times:248.124, 248.11,  248.079,\r\n  48 bytes from probe #6139  202.73.56.70    to 217.151.0.8 (217.151.0.8): ttl=48 times:275.243, 275.24,  275.168,\r\n\r\n40-50 ms\r\n  48 bytes from probe #6002  87.238.48.243   to 217.151.0.8 (217.151.0.8): ttl=53 times:41.782,  41.755,  41.841,\r\n  48 bytes from probe #6063  185.47.192.253  to 217.151.0.8 (217.151.0.8): ttl=49 times:47.072,  45.291,  44.429,\r\n  48 bytes from probe #6102  188.95.32.34    to 217.151.0.8 (217.151.0.8): ttl=50 times:41.989,  41.793,  41.769,\r\n  48 bytes from probe #6106  62.205.155.50   to 217.151.0.8 (217.151.0.8): ttl=52 times:42.047,  42.041,  41.864,\r\n\r\n10-20 ms\r\n  48 bytes from probe #6001  193.0.19.107    to 217.151.0.8 (217.151.0.8): ttl=56 times:16.669,  16.61,   16.597,\r\n  48 bytes from probe #6006  217.31.202.20   to 217.151.0.8 (217.151.0.8): ttl=56 times:18.197,  18.249,  18.045,\r\n  48 bytes from probe #6019  193.0.0.176     to 217.151.0.8 (217.151.0.8): ttl=56 times:16.469,  16.421,  16.46,\r\n  48 bytes from probe #6031  145.220.0.55    to 217.151.0.8 (217.151.0.8): ttl=56 times:16.159,  16.011,  16.035,\r\n  48 bytes from probe #6035  129.143.4.230   to 217.151.0.8 (217.151.0.8): ttl=54 times:16.472,  16.452,  16.452,\r\n  48 bytes from probe #6040  193.176.144.165 to 217.151.0.8 (217.151.0.8): ttl=57 times:18.355,  18.421,  18.395,\r\n  48 bytes from probe #6071  143.129.80.132  to 217.151.0.8 (217.151.0.8): ttl=51 times:10.386,  10.265,  10.18,\r\n\r\n< 10 ms\r\n  48 bytes from probe #6025  213.225.160.239 to 217.151.0.8 (217.151.0.8): ttl=57 times:8.092,   8.073,   8.261,\r\n  48 bytes from probe #6058  130.104.229.249 to 217.151.0.8 (217.151.0.8): ttl=53 times:9.631,   9.326,   9.303,\r\n  48 bytes from probe #6070  185.54.168.245  to 217.151.0.8 (217.151.0.8): ttl=54 times:8.93,    8.788,   8.845,\r\n  48 bytes from probe #6075  5.101.111.218   to 217.151.0.8 (217.151.0.8): ttl=54 times:10.031,  9.842,   9.696,\r\n\r\n100-200 ms\r\n  48 bytes from probe #6024  80.94.66.18     to 217.151.0.8 (217.151.0.8): ttl=54 times:178.249, 80.688,  80.687,\r\n  48 bytes from probe #6045  149.20.4.10     to 217.151.0.8 (217.151.0.8): ttl=48 times:154.885, 154.869, 154.875,\r\n  48 bytes from probe #6061  129.250.50.30   to 217.151.0.8 (217.151.0.8): ttl=50 times:117.456, 117.462, 117.409,\r\n  48 bytes from probe #6062  129.250.50.34   to 217.151.0.8 (217.151.0.8): ttl=51 times:110.713, 110.598, 110.662,\r\n  48 bytes from probe #6065  129.250.50.37   to 217.151.0.8 (217.151.0.8): ttl=52 times:164.097, 163.918, 163.846,\r\n  48 bytes from probe #6067  199.7.183.254   to 217.151.0.8 (217.151.0.8): ttl=55 times:121.186, 123.732, 120.934,\r\n  48 bytes from probe #6074  198.199.99.218  to 217.151.0.8 (217.151.0.8): ttl=54 times:163.274, 163.297, 163.235,\r\n  48 bytes from probe #6080  76.26.120.98    to 217.151.0.8 (217.151.0.8): ttl=48 times:122.17,  122.107, 122.075,\r\n  48 bytes from probe #6093  208.80.152.244  to 217.151.0.8 (217.151.0.8): ttl=54 times:117.439, 114.433, 114.41,\r\n  48 bytes from probe #6095  198.35.26.244   to 217.151.0.8 (217.151.0.8): ttl=54 times:158.538, 158.503, 158.46,\r\n  48 bytes from probe #6142  199.19.51.230   to 217.151.0.8 (217.151.0.8): ttl=48 times:143.565, 143.482, 143.557,\r\n\r\n30-40 ms\r\n  48 bytes from probe #6034  150.254.210.169 to 217.151.0.8 (217.151.0.8): ttl=52 times:36.76,   36.58,   36.627,\r\n  48 bytes from probe #6112  185.55.228.6    to 217.151.0.8 (217.151.0.8): ttl=54 times:39.907,  39.85,   39.828,\r\n```","created_at":"2015-09-25T16:27:00Z","updated_at":"2015-09-28T16:17:40Z","closed_at":"2015-09-28T16:17:40Z","merged_at":null,"merge_commit_sha":"e63db32719ce165711c0a07a8e944a8b05a3ac4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/19/commits","review_comments_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/19/comments","review_comment_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues/19/comments","statuses_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/statuses/9b2681d474b2cb3ff46094c41316c42edef6cc4c","head":{"label":"pierky:master","ref":"master","sha":"9b2681d474b2cb3ff46094c41316c42edef6cc4c","user":{"login":"pierky","id":6806218,"avatar_url":"https://avatars.githubusercontent.com/u/6806218?v=3","gravatar_id":"","url":"https://api.github.com/users/pierky","html_url":"https://github.com/pierky","followers_url":"https://api.github.com/users/pierky/followers","following_url":"https://api.github.com/users/pierky/following{/other_user}","gists_url":"https://api.github.com/users/pierky/gists{/gist_id}","starred_url":"https://api.github.com/users/pierky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierky/subscriptions","organizations_url":"https://api.github.com/users/pierky/orgs","repos_url":"https://api.github.com/users/pierky/repos","events_url":"https://api.github.com/users/pierky/events{/privacy}","received_events_url":"https://api.github.com/users/pierky/received_events","type":"User","site_admin":false},"repo":{"id":42873597,"name":"ripe-atlas-tools","full_name":"pierky/ripe-atlas-tools","owner":{"login":"pierky","id":6806218,"avatar_url":"https://avatars.githubusercontent.com/u/6806218?v=3","gravatar_id":"","url":"https://api.github.com/users/pierky","html_url":"https://github.com/pierky","followers_url":"https://api.github.com/users/pierky/followers","following_url":"https://api.github.com/users/pierky/following{/other_user}","gists_url":"https://api.github.com/users/pierky/gists{/gist_id}","starred_url":"https://api.github.com/users/pierky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierky/subscriptions","organizations_url":"https://api.github.com/users/pierky/orgs","repos_url":"https://api.github.com/users/pierky/repos","events_url":"https://api.github.com/users/pierky/events{/privacy}","received_events_url":"https://api.github.com/users/pierky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierky/ripe-atlas-tools","description":"Official command-line client for RIPE Atlas","fork":true,"url":"https://api.github.com/repos/pierky/ripe-atlas-tools","forks_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/forks","keys_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/teams","hooks_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/hooks","issue_events_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/events","assignees_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/tags","blobs_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/languages","stargazers_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/stargazers","contributors_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/contributors","subscribers_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/subscribers","subscription_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/subscription","commits_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/merges","archive_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/downloads","issues_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/labels{/name}","releases_url":"https://api.github.com/repos/pierky/ripe-atlas-tools/releases{/id}","created_at":"2015-09-21T15:02:32Z","updated_at":"2015-09-21T15:02:32Z","pushed_at":"2015-09-25T16:23:33Z","git_url":"git://github.com/pierky/ripe-atlas-tools.git","ssh_url":"git@github.com:pierky/ripe-atlas-tools.git","clone_url":"https://github.com/pierky/ripe-atlas-tools.git","svn_url":"https://github.com/pierky/ripe-atlas-tools","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIPE-NCC:master","ref":"master","sha":"0005d2d969635e5ad6f7a04c149df4dace17ce49","user":{"login":"RIPE-NCC","id":1096476,"avatar_url":"https://avatars.githubusercontent.com/u/1096476?v=3","gravatar_id":"","url":"https://api.github.com/users/RIPE-NCC","html_url":"https://github.com/RIPE-NCC","followers_url":"https://api.github.com/users/RIPE-NCC/followers","following_url":"https://api.github.com/users/RIPE-NCC/following{/other_user}","gists_url":"https://api.github.com/users/RIPE-NCC/gists{/gist_id}","starred_url":"https://api.github.com/users/RIPE-NCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIPE-NCC/subscriptions","organizations_url":"https://api.github.com/users/RIPE-NCC/orgs","repos_url":"https://api.github.com/users/RIPE-NCC/repos","events_url":"https://api.github.com/users/RIPE-NCC/events{/privacy}","received_events_url":"https://api.github.com/users/RIPE-NCC/received_events","type":"Organization","site_admin":false},"repo":{"id":41851761,"name":"ripe-atlas-tools","full_name":"RIPE-NCC/ripe-atlas-tools","owner":{"login":"RIPE-NCC","id":1096476,"avatar_url":"https://avatars.githubusercontent.com/u/1096476?v=3","gravatar_id":"","url":"https://api.github.com/users/RIPE-NCC","html_url":"https://github.com/RIPE-NCC","followers_url":"https://api.github.com/users/RIPE-NCC/followers","following_url":"https://api.github.com/users/RIPE-NCC/following{/other_user}","gists_url":"https://api.github.com/users/RIPE-NCC/gists{/gist_id}","starred_url":"https://api.github.com/users/RIPE-NCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIPE-NCC/subscriptions","organizations_url":"https://api.github.com/users/RIPE-NCC/orgs","repos_url":"https://api.github.com/users/RIPE-NCC/repos","events_url":"https://api.github.com/users/RIPE-NCC/events{/privacy}","received_events_url":"https://api.github.com/users/RIPE-NCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIPE-NCC/ripe-atlas-tools","description":"Official command-line client for RIPE Atlas","fork":false,"url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools","forks_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/forks","keys_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/teams","hooks_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/hooks","issue_events_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues/events{/number}","events_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/events","assignees_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/assignees{/user}","branches_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/branches{/branch}","tags_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/tags","blobs_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/languages","stargazers_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/stargazers","contributors_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/contributors","subscribers_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/subscribers","subscription_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/subscription","commits_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/contents/{+path}","compare_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/merges","archive_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/downloads","issues_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues{/number}","pulls_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/labels{/name}","releases_url":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/releases{/id}","created_at":"2015-09-03T09:28:07Z","updated_at":"2015-09-25T10:52:59Z","pushed_at":"2015-09-28T16:11:28Z","git_url":"git://github.com/RIPE-NCC/ripe-atlas-tools.git","ssh_url":"git@github.com:RIPE-NCC/ripe-atlas-tools.git","clone_url":"https://github.com/RIPE-NCC/ripe-atlas-tools.git","svn_url":"https://github.com/RIPE-NCC/ripe-atlas-tools","homepage":null,"size":450,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/19"},"html":{"href":"https://github.com/RIPE-NCC/ripe-atlas-tools/pull/19"},"issue":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues/19"},"comments":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/RIPE-NCC/ripe-atlas-tools/statuses/9b2681d474b2cb3ff46094c41316c42edef6cc4c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":182,"deletions":47,"changed_files":8}}