{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/41610101","id":41610101,"diff_hunk":"@@ -88,22 +88,16 @@ extern (C++) Expression implicitCastTo(Expression e, Scope* sc, Type t)\n             {\n                 if (!t.deco)\n                 {\n-                    /* Can happen with:\n-                     *    enum E { One }\n-                     *    class A\n-                     *    { static void fork(EDG dg) { dg(E.One); }\n-                     *      alias void delegate(E) EDG;\n-                     *    }\n-                     * Should eventually make it work.\n-                     */","path":"src/dcast.d","position":11,"original_position":11,"commit_id":"ea7e7128eec33126ea1f815dd4c98a047e1b2378","original_commit_id":"ea7e7128eec33126ea1f815dd4c98a047e1b2378","user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"body":"This code already works. Remove just pointless comment.","created_at":"2015-10-09T08:59:40Z","updated_at":"2015-10-09T08:59:40Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/5176#discussion_r41610101","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/41610101"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/5176#discussion_r41610101"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176","id":47248144,"html_url":"https://github.com/D-Programming-Language/dmd/pull/5176","diff_url":"https://github.com/D-Programming-Language/dmd/pull/5176.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/5176.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5176","number":5176,"state":"open","locked":false,"title":"Refactor: remove unneeded uses of reliesOnTident","user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"body":"This is one of cleanup for forward reference mechanism.\r\n\r\nThe removed part was workaround code for the incomplete semantic analysis process in ancient. If `reliesOnTident(t)` returns true, it means that `t->semantic()` is yet not called.\r\n\r\nRather such the case is a bug in current forward reference resolution mechanism, and the loose check code is not necessary anymore.","created_at":"2015-10-09T08:57:36Z","updated_at":"2015-10-09T08:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c48a739db0670ea9b66deecd4d3ab5312b2de3d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5176/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/ea7e7128eec33126ea1f815dd4c98a047e1b2378","head":{"label":"9rnsr:refactor_use_of_reliesOnTident","ref":"refactor_use_of_reliesOnTident","sha":"ea7e7128eec33126ea1f815dd4c98a047e1b2378","user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"repo":{"id":1434550,"name":"dmd","full_name":"9rnsr/dmd","owner":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9rnsr/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/9rnsr/dmd","forks_url":"https://api.github.com/repos/9rnsr/dmd/forks","keys_url":"https://api.github.com/repos/9rnsr/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9rnsr/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9rnsr/dmd/teams","hooks_url":"https://api.github.com/repos/9rnsr/dmd/hooks","issue_events_url":"https://api.github.com/repos/9rnsr/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/9rnsr/dmd/events","assignees_url":"https://api.github.com/repos/9rnsr/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/9rnsr/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/9rnsr/dmd/tags","blobs_url":"https://api.github.com/repos/9rnsr/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9rnsr/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9rnsr/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/9rnsr/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9rnsr/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/9rnsr/dmd/languages","stargazers_url":"https://api.github.com/repos/9rnsr/dmd/stargazers","contributors_url":"https://api.github.com/repos/9rnsr/dmd/contributors","subscribers_url":"https://api.github.com/repos/9rnsr/dmd/subscribers","subscription_url":"https://api.github.com/repos/9rnsr/dmd/subscription","commits_url":"https://api.github.com/repos/9rnsr/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/9rnsr/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/9rnsr/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/9rnsr/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/9rnsr/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/9rnsr/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9rnsr/dmd/merges","archive_url":"https://api.github.com/repos/9rnsr/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9rnsr/dmd/downloads","issues_url":"https://api.github.com/repos/9rnsr/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/9rnsr/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/9rnsr/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/9rnsr/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9rnsr/dmd/labels{/name}","releases_url":"https://api.github.com/repos/9rnsr/dmd/releases{/id}","created_at":"2011-03-03T10:24:37Z","updated_at":"2015-08-23T13:19:40Z","pushed_at":"2015-10-09T08:55:15Z","git_url":"git://github.com/9rnsr/dmd.git","ssh_url":"git@github.com:9rnsr/dmd.git","clone_url":"https://github.com/9rnsr/dmd.git","svn_url":"https://github.com/9rnsr/dmd","homepage":"d-programming-language.org","size":75159,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"c9c0f206d35833c18dc6f8fe98d2c554286b65c9","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2015-10-07T17:21:32Z","pushed_at":"2015-10-09T08:57:36Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":106677,"stargazers_count":1087,"watchers_count":1087,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":141,"forks":339,"open_issues":141,"watchers":1087,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/5176"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5176"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5176/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5176/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/ea7e7128eec33126ea1f815dd4c98a047e1b2378"}}}}