{"action":"created","comment":{"url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments/25438000","id":25438000,"diff_hunk":"@@ -237,16 +237,11 @@ def remote_getDeviceNames(self, options=None):\n     def _getDevices(self, deviceNames=None, deviceFilter=None):\n \n         if not deviceNames:\n-            devices = filter(deviceFilter, self._prefs.devices())\n-        else:\n-            devices = []\n-            for name in deviceNames:\n-                device = self.dmd.Devices.findDeviceByIdExact(name)\n-                if not device:\n-                    continue\n-                else:\n-                    if deviceFilter(device):\n-                        devices.append(device)\n+            return filter(deviceFilter, self._prefs.devices())\n+        devices = []\n+        for device in self._prefs.devices():\n+            if device.id in deviceNames:\n+                devices.append(device)","path":"Products/ZenCollector/services/config.py","position":18,"original_position":18,"commit_id":"1dd618cd458f53dc500e014d47483b46af044784","original_commit_id":"1dd618cd458f53dc500e014d47483b46af044784","user":{"login":"jplouis","id":385623,"avatar_url":"https://avatars.githubusercontent.com/u/385623?v=3","gravatar_id":"","url":"https://api.github.com/users/jplouis","html_url":"https://github.com/jplouis","followers_url":"https://api.github.com/users/jplouis/followers","following_url":"https://api.github.com/users/jplouis/following{/other_user}","gists_url":"https://api.github.com/users/jplouis/gists{/gist_id}","starred_url":"https://api.github.com/users/jplouis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jplouis/subscriptions","organizations_url":"https://api.github.com/users/jplouis/orgs","repos_url":"https://api.github.com/users/jplouis/repos","events_url":"https://api.github.com/users/jplouis/events{/privacy}","received_events_url":"https://api.github.com/users/jplouis/received_events","type":"User","site_admin":false},"body":"The devices need to be filtered just like the  code did before, without filtering it might break collector  workers.","created_at":"2015-02-26T16:00:13Z","updated_at":"2015-02-26T16:00:13Z","html_url":"https://github.com/zenoss/zenoss-prodbin/pull/780#discussion_r25438000","pull_request_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780","_links":{"self":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments/25438000"},"html":{"href":"https://github.com/zenoss/zenoss-prodbin/pull/780#discussion_r25438000"},"pull_request":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780","id":30075999,"html_url":"https://github.com/zenoss/zenoss-prodbin/pull/780","diff_url":"https://github.com/zenoss/zenoss-prodbin/pull/780.diff","patch_url":"https://github.com/zenoss/zenoss-prodbin/pull/780.patch","issue_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/780","number":780,"state":"closed","locked":false,"title":"ZEN-15883: Catalog issues stop data collection","user":{"login":"byshovets","id":208513,"avatar_url":"https://avatars.githubusercontent.com/u/208513?v=3","gravatar_id":"","url":"https://api.github.com/users/byshovets","html_url":"https://github.com/byshovets","followers_url":"https://api.github.com/users/byshovets/followers","following_url":"https://api.github.com/users/byshovets/following{/other_user}","gists_url":"https://api.github.com/users/byshovets/gists{/gist_id}","starred_url":"https://api.github.com/users/byshovets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byshovets/subscriptions","organizations_url":"https://api.github.com/users/byshovets/orgs","repos_url":"https://api.github.com/users/byshovets/repos","events_url":"https://api.github.com/users/byshovets/events{/privacy}","received_events_url":"https://api.github.com/users/byshovets/received_events","type":"User","site_admin":false},"body":"Fixing https://jira.zenoss.com/browse/ZEN-15883","created_at":"2015-02-26T13:10:46Z","updated_at":"2015-02-26T16:00:13Z","closed_at":"2015-02-26T13:34:29Z","merged_at":"2015-02-26T13:34:29Z","merge_commit_sha":"96fc6b9bb6b319267698b37348aac3569b001241","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780/commits","review_comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780/comments","review_comment_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/780/comments","statuses_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/1dd618cd458f53dc500e014d47483b46af044784","head":{"label":"zenoss:ZEN-15883","ref":"ZEN-15883","sha":"1dd618cd458f53dc500e014d47483b46af044784","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":10389144,"name":"zenoss-prodbin","full_name":"zenoss/zenoss-prodbin","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/zenoss-prodbin","description":"Zenoss - zenoss-prodbin module","fork":false,"url":"https://api.github.com/repos/zenoss/zenoss-prodbin","forks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/forks","keys_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/teams","hooks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/hooks","issue_events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/events","assignees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/tags","blobs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/languages","stargazers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/stargazers","contributors_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contributors","subscribers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscribers","subscription_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscription","commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/merges","archive_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/downloads","issues_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/releases{/id}","created_at":"2013-05-30T18:36:05Z","updated_at":"2015-02-26T13:34:30Z","pushed_at":"2015-02-26T13:34:30Z","git_url":"git://github.com/zenoss/zenoss-prodbin.git","ssh_url":"git@github.com:zenoss/zenoss-prodbin.git","clone_url":"https://github.com/zenoss/zenoss-prodbin.git","svn_url":"https://github.com/zenoss/zenoss-prodbin","homepage":"http://www.zenoss.com","size":421000,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":5,"default_branch":"develop"}},"base":{"label":"zenoss:develop","ref":"develop","sha":"51b0341874af8e996d3ec3d7b61a3128025e970b","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":10389144,"name":"zenoss-prodbin","full_name":"zenoss/zenoss-prodbin","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/zenoss-prodbin","description":"Zenoss - zenoss-prodbin module","fork":false,"url":"https://api.github.com/repos/zenoss/zenoss-prodbin","forks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/forks","keys_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/teams","hooks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/hooks","issue_events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/events","assignees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/tags","blobs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/languages","stargazers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/stargazers","contributors_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contributors","subscribers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscribers","subscription_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscription","commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/merges","archive_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/downloads","issues_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/releases{/id}","created_at":"2013-05-30T18:36:05Z","updated_at":"2015-02-26T13:34:30Z","pushed_at":"2015-02-26T13:34:30Z","git_url":"git://github.com/zenoss/zenoss-prodbin.git","ssh_url":"git@github.com:zenoss/zenoss-prodbin.git","clone_url":"https://github.com/zenoss/zenoss-prodbin.git","svn_url":"https://github.com/zenoss/zenoss-prodbin","homepage":"http://www.zenoss.com","size":421000,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780"},"html":{"href":"https://github.com/zenoss/zenoss-prodbin/pull/780"},"issue":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/780"},"comments":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/1dd618cd458f53dc500e014d47483b46af044784"}}}}