{"action":"closed","number":13779,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13779","id":44750100,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/13779","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/13779.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/13779.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13779","number":13779,"state":"closed","locked":false,"title":"Fix Chipmunk setCollisionType issue by initializing variables","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"body":"setCollisionType will create a cpCollisionType(long) type variable to store a JS unsigned int value, as it's not initialized, jsval_to_uint will only modify its low bit values, then the final result will be wrong.\r\n\r\nThere are many other variables not initialized in JSB codes, I modified all that matters in chipmunk binding codes.","created_at":"2015-09-11T06:24:38Z","updated_at":"2015-09-11T09:58:48Z","closed_at":"2015-09-11T09:58:48Z","merged_at":"2015-09-11T09:58:48Z","merge_commit_sha":"963f60ae01e0daeb57991c1be5efe1b898260206","assignee":{"login":"WenhaiLin","id":5234286,"avatar_url":"https://avatars.githubusercontent.com/u/5234286?v=3","gravatar_id":"","url":"https://api.github.com/users/WenhaiLin","html_url":"https://github.com/WenhaiLin","followers_url":"https://api.github.com/users/WenhaiLin/followers","following_url":"https://api.github.com/users/WenhaiLin/following{/other_user}","gists_url":"https://api.github.com/users/WenhaiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/WenhaiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WenhaiLin/subscriptions","organizations_url":"https://api.github.com/users/WenhaiLin/orgs","repos_url":"https://api.github.com/users/WenhaiLin/repos","events_url":"https://api.github.com/users/WenhaiLin/events{/privacy}","received_events_url":"https://api.github.com/users/WenhaiLin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13779/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13779/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13779/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/5a918608c1e446b83b6148da7fcad209f4abe927","head":{"label":"pandamicro:v3","ref":"v3","sha":"5a918608c1e446b83b6148da7fcad209f4abe927","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"repo":{"id":15125810,"name":"cocos2d-x","full_name":"pandamicro/cocos2d-x","owner":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pandamicro/cocos2d-x","description":"cocos2d for iOS, Android, Win32 and OS X. Built using C++","fork":true,"url":"https://api.github.com/repos/pandamicro/cocos2d-x","forks_url":"https://api.github.com/repos/pandamicro/cocos2d-x/forks","keys_url":"https://api.github.com/repos/pandamicro/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandamicro/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandamicro/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/pandamicro/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/pandamicro/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/pandamicro/cocos2d-x/events","assignees_url":"https://api.github.com/repos/pandamicro/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/pandamicro/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/pandamicro/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/pandamicro/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandamicro/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandamicro/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandamicro/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandamicro/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/pandamicro/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/pandamicro/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/pandamicro/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/pandamicro/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/pandamicro/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/pandamicro/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandamicro/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandamicro/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandamicro/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandamicro/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/pandamicro/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandamicro/cocos2d-x/merges","archive_url":"https://api.github.com/repos/pandamicro/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandamicro/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/pandamicro/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/pandamicro/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/pandamicro/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/pandamicro/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandamicro/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/pandamicro/cocos2d-x/releases{/id}","created_at":"2013-12-12T03:12:23Z","updated_at":"2014-06-25T02:57:23Z","pushed_at":"2015-09-11T07:24:02Z","git_url":"git://github.com/pandamicro/cocos2d-x.git","ssh_url":"git@github.com:pandamicro/cocos2d-x.git","clone_url":"https://github.com/pandamicro/cocos2d-x.git","svn_url":"https://github.com/pandamicro/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1161158,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"62b5f173d50db866663c7b3f47cdb3d1a574f125","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2015-09-11T09:38:43Z","pushed_at":"2015-09-11T09:58:48Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1499654,"stargazers_count":6631,"watchers_count":6631,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4695,"mirror_url":null,"open_issues_count":757,"forks":4695,"open_issues":757,"watchers":6631,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13779"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/13779"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13779"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13779/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13779/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13779/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/5a918608c1e446b83b6148da7fcad209f4abe927"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":547,"deletions":544,"changed_files":3}}