{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/41151429","id":41151429,"diff_hunk":"@@ -0,0 +1,42 @@\n+/**\n+ * Copyright (C) Mellanox Technologies Ltd. 2001-2015.  ALL RIGHTS RESERVED.\n+ *\n+ * See file LICENSE for terms.\n+ */\n+\n+#include \"dt_generic.h\"\n+\n+#include <ucs/debug/memtrack.h>\n+\n+\n+ucs_status_t ucp_dt_create_generic(ucp_generic_dt_ops_t *ops, void *context,\n+                                   ucp_datatype_t *datatype_p)\n+{\n+    ucp_dt_generic_t *dt;\n+\n+    dt = ucs_memalign(UCS_BIT(UCP_DATATYPE_SHIFT), sizeof(*dt), \"generic_dt\");\n+    if (dt == NULL) {\n+        return UCS_ERR_NO_MEMORY;\n+    }\n+\n+    dt->ops      = ops;\n+    dt->context  = context;\n+    *datatype_p = ((uintptr_t)dt) | UCP_DATATYPE_GENERIC;","path":"src/ucp/dt/dt_generic.c","position":24,"original_position":24,"commit_id":"36f1758be43c52c27a66a5bc275ee4afccd6b756","original_commit_id":"36f1758be43c52c27a66a5bc275ee4afccd6b756","user":{"login":"shamisp","id":2236120,"avatar_url":"https://avatars.githubusercontent.com/u/2236120?v=3","gravatar_id":"","url":"https://api.github.com/users/shamisp","html_url":"https://github.com/shamisp","followers_url":"https://api.github.com/users/shamisp/followers","following_url":"https://api.github.com/users/shamisp/following{/other_user}","gists_url":"https://api.github.com/users/shamisp/gists{/gist_id}","starred_url":"https://api.github.com/users/shamisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamisp/subscriptions","organizations_url":"https://api.github.com/users/shamisp/orgs","repos_url":"https://api.github.com/users/shamisp/repos","events_url":"https://api.github.com/users/shamisp/events{/privacy}","received_events_url":"https://api.github.com/users/shamisp/received_events","type":"User","site_admin":false},"body":"I know that I proposed this (caching flag on bits not used by pointer), but we have to be careful with supporting of this across different architectures. x86_64 is safe. What about POWER and ARM. Probably the offset for unused bits that has to be #ifdefed by platform.  ","created_at":"2015-10-05T14:42:35Z","updated_at":"2015-10-05T14:42:35Z","html_url":"https://github.com/openucx/ucx/pull/421#discussion_r41151429","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/421","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/41151429"},"html":{"href":"https://github.com/openucx/ucx/pull/421#discussion_r41151429"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/421","id":46298237,"html_url":"https://github.com/openucx/ucx/pull/421","diff_url":"https://github.com/openucx/ucx/pull/421.diff","patch_url":"https://github.com/openucx/ucx/pull/421.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/421","number":421,"state":"open","locked":false,"title":"UCP/API/TEST: Full tag matching support.","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"MPI code is still WIP, see most recent version in:\r\nhttps://github.com/yosefe/ompi-release/tree/topic/ucx/ompi/mca/pml/ucx","created_at":"2015-09-29T16:09:54Z","updated_at":"2015-10-05T14:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b0fdbf055c244eebb4374c572b996dd62dd563a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/421/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/421/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/421/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/36f1758be43c52c27a66a5bc275ee4afccd6b756","head":{"label":"yosefe:topic/nb-tag-matching","ref":"topic/nb-tag-matching","sha":"36f1758be43c52c27a66a5bc275ee4afccd6b756","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"repo":{"id":25532870,"name":"ucx","full_name":"yosefe/ucx","owner":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yosefe/ucx","description":"The UCX","fork":true,"url":"https://api.github.com/repos/yosefe/ucx","forks_url":"https://api.github.com/repos/yosefe/ucx/forks","keys_url":"https://api.github.com/repos/yosefe/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yosefe/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yosefe/ucx/teams","hooks_url":"https://api.github.com/repos/yosefe/ucx/hooks","issue_events_url":"https://api.github.com/repos/yosefe/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/yosefe/ucx/events","assignees_url":"https://api.github.com/repos/yosefe/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/yosefe/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/yosefe/ucx/tags","blobs_url":"https://api.github.com/repos/yosefe/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yosefe/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yosefe/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/yosefe/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yosefe/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/yosefe/ucx/languages","stargazers_url":"https://api.github.com/repos/yosefe/ucx/stargazers","contributors_url":"https://api.github.com/repos/yosefe/ucx/contributors","subscribers_url":"https://api.github.com/repos/yosefe/ucx/subscribers","subscription_url":"https://api.github.com/repos/yosefe/ucx/subscription","commits_url":"https://api.github.com/repos/yosefe/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/yosefe/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/yosefe/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/yosefe/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/yosefe/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/yosefe/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yosefe/ucx/merges","archive_url":"https://api.github.com/repos/yosefe/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yosefe/ucx/downloads","issues_url":"https://api.github.com/repos/yosefe/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/yosefe/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/yosefe/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/yosefe/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yosefe/ucx/labels{/name}","releases_url":"https://api.github.com/repos/yosefe/ucx/releases{/id}","created_at":"2014-10-21T16:22:47Z","updated_at":"2015-07-13T17:18:28Z","pushed_at":"2015-10-04T14:40:33Z","git_url":"git://github.com/yosefe/ucx.git","ssh_url":"git@github.com:yosefe/ucx.git","clone_url":"https://github.com/yosefe/ucx.git","svn_url":"https://github.com/yosefe/ucx","homepage":"","size":3421,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"1c20cb48e255d225b7b3c7e46d6e7924406566ee","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (ucx-group@elist.ornl.gov): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","created_at":"2014-10-17T22:17:24Z","updated_at":"2015-09-08T19:41:11Z","pushed_at":"2015-10-04T14:40:33Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":" http://www.openucx.org","size":6141,"stargazers_count":18,"watchers_count":18,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":42,"forks":13,"open_issues":42,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/421"},"html":{"href":"https://github.com/openucx/ucx/pull/421"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/421"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/36f1758be43c52c27a66a5bc275ee4afccd6b756"}}}}