{"action":"created","comment":{"url":"https://api.github.com/repos/geb/geb/pulls/comments/46627321","id":46627321,"diff_hunk":"@@ -43,7 +45,9 @@ class GebReportingSpec extends GebSpec {\n     }\n \n     void report(String label = \"\") {\n-        browser.report(ReporterSupport.toTestReportLabel(gebReportingSpecTestCounter, gebReportingPerTestCounter++, gebReportingSpecTestName.methodName, label))\n+        if (!browser.config.reportOnTestFailureOnly || failTracker.failedTests.contains(gebReportingSpecTestName.methodName)) {","path":"module/geb-spock/src/main/groovy/geb/spock/GebReportingSpec.groovy","position":14,"original_position":14,"commit_id":"4dce6ef9870d3904161b456017e283d9a337e6eb","original_commit_id":"4dce6ef9870d3904161b456017e283d9a337e6eb","user":{"login":"erdi","id":205451,"avatar_url":"https://avatars.githubusercontent.com/u/205451?v=3","gravatar_id":"","url":"https://api.github.com/users/erdi","html_url":"https://github.com/erdi","followers_url":"https://api.github.com/users/erdi/followers","following_url":"https://api.github.com/users/erdi/following{/other_user}","gists_url":"https://api.github.com/users/erdi/gists{/gist_id}","starred_url":"https://api.github.com/users/erdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdi/subscriptions","organizations_url":"https://api.github.com/users/erdi/orgs","repos_url":"https://api.github.com/users/erdi/repos","events_url":"https://api.github.com/users/erdi/events{/privacy}","received_events_url":"https://api.github.com/users/erdi/received_events","type":"User","site_admin":false},"body":"This logic should be moved to the `cleanup()` method and put around the `report \"end\"` line. Probably also `failure` should be used as the label if there was a failure and `end` if there was no failure and `reportOnTestFailureOnly` is not enabled.\r\n\r\nThis method provides general reporting capability in the current test reporting group and can be used by the user directly and hence should not be changed. ","created_at":"2015-12-03T23:08:17Z","updated_at":"2015-12-03T23:08:17Z","html_url":"https://github.com/geb/geb/pull/113#discussion_r46627321","pull_request_url":"https://api.github.com/repos/geb/geb/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/geb/geb/pulls/comments/46627321"},"html":{"href":"https://github.com/geb/geb/pull/113#discussion_r46627321"},"pull_request":{"href":"https://api.github.com/repos/geb/geb/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/geb/geb/pulls/113","id":51820405,"html_url":"https://github.com/geb/geb/pull/113","diff_url":"https://github.com/geb/geb/pull/113.diff","patch_url":"https://github.com/geb/geb/pull/113.patch","issue_url":"https://api.github.com/repos/geb/geb/issues/113","number":113,"state":"open","locked":false,"title":"reportOnTestFailureOnly implementation for Spock (issue #92)","user":{"login":"leo-13","id":5223117,"avatar_url":"https://avatars.githubusercontent.com/u/5223117?v=3","gravatar_id":"","url":"https://api.github.com/users/leo-13","html_url":"https://github.com/leo-13","followers_url":"https://api.github.com/users/leo-13/followers","following_url":"https://api.github.com/users/leo-13/following{/other_user}","gists_url":"https://api.github.com/users/leo-13/gists{/gist_id}","starred_url":"https://api.github.com/users/leo-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo-13/subscriptions","organizations_url":"https://api.github.com/users/leo-13/orgs","repos_url":"https://api.github.com/users/leo-13/repos","events_url":"https://api.github.com/users/leo-13/events{/privacy}","received_events_url":"https://api.github.com/users/leo-13/received_events","type":"User","site_admin":false},"body":"reportOnTestFailureOnly option is now working for Spock integration, without changing the Spock code. Implemented via JUnit MethodRule interface. If approved can be later used for Geb-JUnit integration as well.","created_at":"2015-11-25T16:59:30Z","updated_at":"2015-12-03T23:08:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8467cff08df8ccd11e983fa6917f4e14d5504afc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geb/geb/pulls/113/commits","review_comments_url":"https://api.github.com/repos/geb/geb/pulls/113/comments","review_comment_url":"https://api.github.com/repos/geb/geb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geb/geb/issues/113/comments","statuses_url":"https://api.github.com/repos/geb/geb/statuses/4dce6ef9870d3904161b456017e283d9a337e6eb","head":{"label":"leo-13:master","ref":"master","sha":"4dce6ef9870d3904161b456017e283d9a337e6eb","user":{"login":"leo-13","id":5223117,"avatar_url":"https://avatars.githubusercontent.com/u/5223117?v=3","gravatar_id":"","url":"https://api.github.com/users/leo-13","html_url":"https://github.com/leo-13","followers_url":"https://api.github.com/users/leo-13/followers","following_url":"https://api.github.com/users/leo-13/following{/other_user}","gists_url":"https://api.github.com/users/leo-13/gists{/gist_id}","starred_url":"https://api.github.com/users/leo-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo-13/subscriptions","organizations_url":"https://api.github.com/users/leo-13/orgs","repos_url":"https://api.github.com/users/leo-13/repos","events_url":"https://api.github.com/users/leo-13/events{/privacy}","received_events_url":"https://api.github.com/users/leo-13/received_events","type":"User","site_admin":false},"repo":{"id":44563040,"name":"geb","full_name":"leo-13/geb","owner":{"login":"leo-13","id":5223117,"avatar_url":"https://avatars.githubusercontent.com/u/5223117?v=3","gravatar_id":"","url":"https://api.github.com/users/leo-13","html_url":"https://github.com/leo-13","followers_url":"https://api.github.com/users/leo-13/followers","following_url":"https://api.github.com/users/leo-13/following{/other_user}","gists_url":"https://api.github.com/users/leo-13/gists{/gist_id}","starred_url":"https://api.github.com/users/leo-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo-13/subscriptions","organizations_url":"https://api.github.com/users/leo-13/orgs","repos_url":"https://api.github.com/users/leo-13/repos","events_url":"https://api.github.com/users/leo-13/events{/privacy}","received_events_url":"https://api.github.com/users/leo-13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leo-13/geb","description":"Very Groovy Browser Automation","fork":true,"url":"https://api.github.com/repos/leo-13/geb","forks_url":"https://api.github.com/repos/leo-13/geb/forks","keys_url":"https://api.github.com/repos/leo-13/geb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leo-13/geb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leo-13/geb/teams","hooks_url":"https://api.github.com/repos/leo-13/geb/hooks","issue_events_url":"https://api.github.com/repos/leo-13/geb/issues/events{/number}","events_url":"https://api.github.com/repos/leo-13/geb/events","assignees_url":"https://api.github.com/repos/leo-13/geb/assignees{/user}","branches_url":"https://api.github.com/repos/leo-13/geb/branches{/branch}","tags_url":"https://api.github.com/repos/leo-13/geb/tags","blobs_url":"https://api.github.com/repos/leo-13/geb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leo-13/geb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leo-13/geb/git/refs{/sha}","trees_url":"https://api.github.com/repos/leo-13/geb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leo-13/geb/statuses/{sha}","languages_url":"https://api.github.com/repos/leo-13/geb/languages","stargazers_url":"https://api.github.com/repos/leo-13/geb/stargazers","contributors_url":"https://api.github.com/repos/leo-13/geb/contributors","subscribers_url":"https://api.github.com/repos/leo-13/geb/subscribers","subscription_url":"https://api.github.com/repos/leo-13/geb/subscription","commits_url":"https://api.github.com/repos/leo-13/geb/commits{/sha}","git_commits_url":"https://api.github.com/repos/leo-13/geb/git/commits{/sha}","comments_url":"https://api.github.com/repos/leo-13/geb/comments{/number}","issue_comment_url":"https://api.github.com/repos/leo-13/geb/issues/comments{/number}","contents_url":"https://api.github.com/repos/leo-13/geb/contents/{+path}","compare_url":"https://api.github.com/repos/leo-13/geb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leo-13/geb/merges","archive_url":"https://api.github.com/repos/leo-13/geb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leo-13/geb/downloads","issues_url":"https://api.github.com/repos/leo-13/geb/issues{/number}","pulls_url":"https://api.github.com/repos/leo-13/geb/pulls{/number}","milestones_url":"https://api.github.com/repos/leo-13/geb/milestones{/number}","notifications_url":"https://api.github.com/repos/leo-13/geb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leo-13/geb/labels{/name}","releases_url":"https://api.github.com/repos/leo-13/geb/releases{/id}","created_at":"2015-10-19T20:46:56Z","updated_at":"2015-10-19T20:46:57Z","pushed_at":"2015-11-27T21:55:59Z","git_url":"git://github.com/leo-13/geb.git","ssh_url":"git@github.com:leo-13/geb.git","clone_url":"https://github.com/leo-13/geb.git","svn_url":"https://github.com/leo-13/geb","homepage":"http://www.gebish.org","size":5544,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geb:master","ref":"master","sha":"d0d26e6d99583a048f91113b63085b9d1a94aadb","user":{"login":"geb","id":352388,"avatar_url":"https://avatars.githubusercontent.com/u/352388?v=3","gravatar_id":"","url":"https://api.github.com/users/geb","html_url":"https://github.com/geb","followers_url":"https://api.github.com/users/geb/followers","following_url":"https://api.github.com/users/geb/following{/other_user}","gists_url":"https://api.github.com/users/geb/gists{/gist_id}","starred_url":"https://api.github.com/users/geb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geb/subscriptions","organizations_url":"https://api.github.com/users/geb/orgs","repos_url":"https://api.github.com/users/geb/repos","events_url":"https://api.github.com/users/geb/events{/privacy}","received_events_url":"https://api.github.com/users/geb/received_events","type":"Organization","site_admin":false},"repo":{"id":813783,"name":"geb","full_name":"geb/geb","owner":{"login":"geb","id":352388,"avatar_url":"https://avatars.githubusercontent.com/u/352388?v=3","gravatar_id":"","url":"https://api.github.com/users/geb","html_url":"https://github.com/geb","followers_url":"https://api.github.com/users/geb/followers","following_url":"https://api.github.com/users/geb/following{/other_user}","gists_url":"https://api.github.com/users/geb/gists{/gist_id}","starred_url":"https://api.github.com/users/geb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geb/subscriptions","organizations_url":"https://api.github.com/users/geb/orgs","repos_url":"https://api.github.com/users/geb/repos","events_url":"https://api.github.com/users/geb/events{/privacy}","received_events_url":"https://api.github.com/users/geb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geb/geb","description":"Very Groovy Browser Automation","fork":false,"url":"https://api.github.com/repos/geb/geb","forks_url":"https://api.github.com/repos/geb/geb/forks","keys_url":"https://api.github.com/repos/geb/geb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geb/geb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geb/geb/teams","hooks_url":"https://api.github.com/repos/geb/geb/hooks","issue_events_url":"https://api.github.com/repos/geb/geb/issues/events{/number}","events_url":"https://api.github.com/repos/geb/geb/events","assignees_url":"https://api.github.com/repos/geb/geb/assignees{/user}","branches_url":"https://api.github.com/repos/geb/geb/branches{/branch}","tags_url":"https://api.github.com/repos/geb/geb/tags","blobs_url":"https://api.github.com/repos/geb/geb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geb/geb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geb/geb/git/refs{/sha}","trees_url":"https://api.github.com/repos/geb/geb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geb/geb/statuses/{sha}","languages_url":"https://api.github.com/repos/geb/geb/languages","stargazers_url":"https://api.github.com/repos/geb/geb/stargazers","contributors_url":"https://api.github.com/repos/geb/geb/contributors","subscribers_url":"https://api.github.com/repos/geb/geb/subscribers","subscription_url":"https://api.github.com/repos/geb/geb/subscription","commits_url":"https://api.github.com/repos/geb/geb/commits{/sha}","git_commits_url":"https://api.github.com/repos/geb/geb/git/commits{/sha}","comments_url":"https://api.github.com/repos/geb/geb/comments{/number}","issue_comment_url":"https://api.github.com/repos/geb/geb/issues/comments{/number}","contents_url":"https://api.github.com/repos/geb/geb/contents/{+path}","compare_url":"https://api.github.com/repos/geb/geb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geb/geb/merges","archive_url":"https://api.github.com/repos/geb/geb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geb/geb/downloads","issues_url":"https://api.github.com/repos/geb/geb/issues{/number}","pulls_url":"https://api.github.com/repos/geb/geb/pulls{/number}","milestones_url":"https://api.github.com/repos/geb/geb/milestones{/number}","notifications_url":"https://api.github.com/repos/geb/geb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geb/geb/labels{/name}","releases_url":"https://api.github.com/repos/geb/geb/releases{/id}","created_at":"2010-08-03T03:58:46Z","updated_at":"2015-12-02T21:24:09Z","pushed_at":"2015-12-03T22:47:09Z","git_url":"git://github.com/geb/geb.git","ssh_url":"git@github.com:geb/geb.git","clone_url":"https://github.com/geb/geb.git","svn_url":"https://github.com/geb/geb","homepage":"http://www.gebish.org","size":5800,"stargazers_count":528,"watchers_count":528,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":1,"forks":150,"open_issues":1,"watchers":528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geb/geb/pulls/113"},"html":{"href":"https://github.com/geb/geb/pull/113"},"issue":{"href":"https://api.github.com/repos/geb/geb/issues/113"},"comments":{"href":"https://api.github.com/repos/geb/geb/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/geb/geb/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/geb/geb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geb/geb/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/geb/geb/statuses/4dce6ef9870d3904161b456017e283d9a337e6eb"}}}}