{"action":"created","issue":{"url":"https://api.github.com/repos/OmniSharp/generator-aspnet/issues/108","labels_url":"https://api.github.com/repos/OmniSharp/generator-aspnet/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/OmniSharp/generator-aspnet/issues/108/comments","events_url":"https://api.github.com/repos/OmniSharp/generator-aspnet/issues/108/events","html_url":"https://github.com/OmniSharp/generator-aspnet/pull/108","id":67460887,"number":108,"title":"Update generator file system IO methods. Closes #107","user":{"login":"peterblazejewicz","id":14539,"avatar_url":"https://avatars.githubusercontent.com/u/14539?v=3","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-09T22:06:42Z","updated_at":"2015-04-10T21:01:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OmniSharp/generator-aspnet/pulls/108","html_url":"https://github.com/OmniSharp/generator-aspnet/pull/108","diff_url":"https://github.com/OmniSharp/generator-aspnet/pull/108.diff","patch_url":"https://github.com/OmniSharp/generator-aspnet/pull/108.patch"},"body":"Hello,\r\n\r\nAs reported on: https://github.com/OmniSharp/generator-aspnet/issues/107\r\n\r\nThis commit replace file system touching operations with\r\nYeoman's wrapper around mem-fs module as advised by Yeoman's documentation.\r\nThe commit removes use of already deprecated api, use this.fs module wrapper\r\nand fixes problem with relative paths used in base class.\r\nTested with both npm test and current e2e test\r\nThe npm test have been failing - unless I rewrote implementation in base generate to use `this.templatePath` and `this.destinationPath` as per current docs.\r\n\r\nTests run locally are OK (`84 passing (739ms)` etc), but I've run them only on OS X machine.\r\n\r\nhttp://yeoman.io/authoring/file-system.html\r\n\r\n@sayedihashimi @spboyer Can you guys review this PR and test on other OS? (I'll try to verify on Windows OS at my work, but can't promise :) )\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/OmniSharp/generator-aspnet/issues/comments/91689008","html_url":"https://github.com/OmniSharp/generator-aspnet/pull/108#issuecomment-91689008","issue_url":"https://api.github.com/repos/OmniSharp/generator-aspnet/issues/108","id":91689008,"user":{"login":"peterblazejewicz","id":14539,"avatar_url":"https://avatars.githubusercontent.com/u/14539?v=3","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T21:01:39Z","updated_at":"2015-04-10T21:01:39Z","body":"@sayedihashimi @spboyer \r\nupdated, rebased, squashed.\r\nThe problem was not only with deprecation - but with updated Yo dependencies. I've made a lot of updates in implementation - but without removing or refactoring everything. \r\nI've just followed Yo/Yo-Generator release notes and:\r\n- updated our `package.json` to match updated dependencies\r\n- went through api step by step and updated methods calls to new syntax\r\n- used new methods\r\n- removed old methods.\r\nEtc.\r\nPlease make sure to:\r\n- update your loal Yo via `npm update -g yo`\r\n- update your local, repository `node_modules`. Best to drop them and simply run again:\r\n```\r\nnpm install\r\n```\r\n\r\nThanks!"}}