{"action":"created","issue":{"url":"https://api.github.com/repos/PocketMine/RakLib/issues/10","labels_url":"https://api.github.com/repos/PocketMine/RakLib/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/PocketMine/RakLib/issues/10/comments","events_url":"https://api.github.com/repos/PocketMine/RakLib/issues/10/events","html_url":"https://github.com/PocketMine/RakLib/issues/10","id":56919239,"number":10,"title":"Missing encode on client handshake and decode on server handshake.","user":{"login":"Falkirks","id":5827558,"avatar_url":"https://avatars.githubusercontent.com/u/5827558?v=3","gravatar_id":"","url":"https://api.github.com/users/Falkirks","html_url":"https://github.com/Falkirks","followers_url":"https://api.github.com/users/Falkirks/followers","following_url":"https://api.github.com/users/Falkirks/following{/other_user}","gists_url":"https://api.github.com/users/Falkirks/gists{/gist_id}","starred_url":"https://api.github.com/users/Falkirks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falkirks/subscriptions","organizations_url":"https://api.github.com/users/Falkirks/orgs","repos_url":"https://api.github.com/users/Falkirks/repos","events_url":"https://api.github.com/users/Falkirks/events{/privacy}","received_events_url":"https://api.github.com/users/Falkirks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-07T17:49:59Z","updated_at":"2015-02-07T19:45:40Z","closed_at":null,"body":"I need these methods for a project and although they are not needed for PocketMine-MP, this library is a\r\n\r\n> UDP network library that follows the RakNet protocol for PHP\r\n\r\nSo I would personally expect to be able to decode and encode these packets. \r\n\r\n* https://github.com/PocketMine/RakLib/blob/master/protocol/CLIENT_HANDSHAKE_DataPacket.php is missing a proper encode method.\r\n* https://github.com/PocketMine/RakLib/blob/master/protocol/SERVER_HANDSHAKE_DataPacket.php is missing a proper decode method.\r\n\r\nI would implement this myself, but I am not sure where to stick the` getDataArray` and `putDataArray` methods. "},"comment":{"url":"https://api.github.com/repos/PocketMine/RakLib/issues/comments/73379642","html_url":"https://github.com/PocketMine/RakLib/issues/10#issuecomment-73379642","issue_url":"https://api.github.com/repos/PocketMine/RakLib/issues/10","id":73379642,"user":{"login":"Falkirks","id":5827558,"avatar_url":"https://avatars.githubusercontent.com/u/5827558?v=3","gravatar_id":"","url":"https://api.github.com/users/Falkirks","html_url":"https://github.com/Falkirks","followers_url":"https://api.github.com/users/Falkirks/followers","following_url":"https://api.github.com/users/Falkirks/following{/other_user}","gists_url":"https://api.github.com/users/Falkirks/gists{/gist_id}","starred_url":"https://api.github.com/users/Falkirks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falkirks/subscriptions","organizations_url":"https://api.github.com/users/Falkirks/orgs","repos_url":"https://api.github.com/users/Falkirks/repos","events_url":"https://api.github.com/users/Falkirks/events{/privacy}","received_events_url":"https://api.github.com/users/Falkirks/received_events","type":"User","site_admin":false},"created_at":"2015-02-07T19:45:40Z","updated_at":"2015-02-07T19:45:40Z","body":"Granted, but it would be nice to have enough to fool PocketMine or another server implementation. Even with what is known these methods could be implemented to a state which functions and represents the currently known protocol."}}