{"action":"created","issue":{"url":"https://api.github.com/repos/18F/C2/issues/656","labels_url":"https://api.github.com/repos/18F/C2/issues/656/labels{/name}","comments_url":"https://api.github.com/repos/18F/C2/issues/656/comments","events_url":"https://api.github.com/repos/18F/C2/issues/656/events","html_url":"https://github.com/18F/C2/pull/656","id":109661332,"number":656,"title":"[Delivers #96851664] simplify form specification","user":{"login":"afeld","id":86842,"avatar_url":"https://avatars.githubusercontent.com/u/86842?v=3","gravatar_id":"","url":"https://api.github.com/users/afeld","html_url":"https://github.com/afeld","followers_url":"https://api.github.com/users/afeld/followers","following_url":"https://api.github.com/users/afeld/following{/other_user}","gists_url":"https://api.github.com/users/afeld/gists{/gist_id}","starred_url":"https://api.github.com/users/afeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afeld/subscriptions","organizations_url":"https://api.github.com/users/afeld/orgs","repos_url":"https://api.github.com/users/afeld/repos","events_url":"https://api.github.com/users/afeld/events{/privacy}","received_events_url":"https://api.github.com/users/afeld/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/18F/C2/labels/QA-needed","name":"QA-needed","color":"eb6420"},{"url":"https://api.github.com/repos/18F/C2/labels/review-needed","name":"review-needed","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-04T03:47:58Z","updated_at":"2015-10-19T22:15:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/C2/pulls/656","html_url":"https://github.com/18F/C2/pull/656","diff_url":"https://github.com/18F/C2/pull/656.diff","patch_url":"https://github.com/18F/C2/pull/656.patch"},"body":"This pull request accomplishes a few things:\r\n\r\n* Uses [Simple Form](https://github.com/plataformatec/simple_form) to generate the appropriate form fields and labels with things like `required` attributes automatically, based on the schema and validations\r\n* Converts the use case forms to HAML\r\n* (Most) written text was moved from the form templates to internationalization config files, separating them from the form logic and making life easier if we ever wanted to provide alternate translations at some point\r\n\r\nWhile the overall number of lines went up (mostly from the generated Simple Form config files), 172 lines were removed from `app/views/`, and IMHO those files are now much easier to follow.\r\n\r\nWhile there were some minor changes to the form itself (fixing capitalization inconsistencies, etc.), both should otherwise be the same. I've looked at the old and new forms side-by-side to verify, but would love to be double-checked by whomever is doing QA. Thanks!"},"comment":{"url":"https://api.github.com/repos/18F/C2/issues/comments/149363331","html_url":"https://github.com/18F/C2/pull/656#issuecomment-149363331","issue_url":"https://api.github.com/repos/18F/C2/issues/656","id":149363331,"user":{"login":"jessieay","id":601515,"avatar_url":"https://avatars.githubusercontent.com/u/601515?v=3","gravatar_id":"","url":"https://api.github.com/users/jessieay","html_url":"https://github.com/jessieay","followers_url":"https://api.github.com/users/jessieay/followers","following_url":"https://api.github.com/users/jessieay/following{/other_user}","gists_url":"https://api.github.com/users/jessieay/gists{/gist_id}","starred_url":"https://api.github.com/users/jessieay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessieay/subscriptions","organizations_url":"https://api.github.com/users/jessieay/orgs","repos_url":"https://api.github.com/users/jessieay/repos","events_url":"https://api.github.com/users/jessieay/events{/privacy}","received_events_url":"https://api.github.com/users/jessieay/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T22:15:56Z","updated_at":"2015-10-19T22:15:56Z","body":"Only difference I found in forms is procurements form: new is on left, old is on right. Don't think this should be problematic \r\n\r\n![screen shot 2015-10-19 at 3 14 49 pm](https://cloud.githubusercontent.com/assets/601515/10592927/4a4c32d8-7674-11e5-99d1-bb2a0b938fa9.png)\r\n"}}