{"action":"created","comment":{"url":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments/31681455","id":31681455,"diff_hunk":"@@ -0,0 +1,109 @@\n+/* ========================================================================\n+ * Bootstrap: popover.js v3.3.4\n+ * http://getbootstrap.com/javascript/#popovers\n+ * ========================================================================\n+ * Copyright 2011-2015 Twitter, Inc.\n+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)\n+ * ======================================================================== */\n+\n+\n++function ($) {\n+  'use strict';\n+\n+  // POPOVER PUBLIC CLASS DEFINITION\n+  // ===============================\n+\n+  var Popover = function (element, options) {\n+    this.init('popover', element, options)\n+  }\n+\n+  if (!$.fn.tooltip) throw new Error('Popover requires tooltip.js')\n+\n+  Popover.VERSION  = '3.3.4'\n+\n+  Popover.DEFAULTS = $.extend({}, $.fn.tooltip.Constructor.DEFAULTS, {\n+    placement: 'right',\n+    trigger: 'click',\n+    content: '',\n+    template: '<div class=\"popover\" role=\"tooltip\"><div class=\"arrow\"></div><div class=\"popover_content\"></div></div>',\n+    container: 'body'\n+  })\n+\n+\n+  // NOTE: POPOVER EXTENDS tooltip.js\n+  // ================================\n+\n+  Popover.prototype = $.extend({}, $.fn.tooltip.Constructor.prototype)\n+\n+  Popover.prototype.constructor = Popover\n+\n+  Popover.prototype.getDefaults = function () {\n+    return Popover.DEFAULTS\n+  }\n+\n+  Popover.prototype.setContent = function () {\n+    var $tip    = this.tip()\n+    var title   = this.getTitle()\n+    var content = this.getContent()\n+\n+    $tip.find('.popover-title')[this.options.html ? 'html' : 'text'](title)\n+    $tip.find('.popover_content').children().detach().end()[ // we use append for html objects to maintain js events\n+      this.options.html ? (typeof content == 'string' ? 'html' : 'append') : 'text'\n+    ](content)\n+\n+    $tip.removeClass('fade top bottom left right in')\n+\n+    // IE8 doesn't accept hiding via the `:empty` pseudo selector, we have to do\n+    // this manually by checking the contents.\n+    if (!$tip.find('.popover-title').html()) $tip.find('.popover-title').hide()\n+  }\n+\n+  Popover.prototype.hasContent = function () {\n+    return this.getTitle() || this.getContent()\n+  }\n+\n+  Popover.prototype.getContent = function () {\n+    var $e = this.$element\n+    var o  = this.options\n+\n+    return $e.attr('data-content')\n+      || (typeof o.content == 'function' ?","path":"vendor/assets/javascripts/dvl/core/popovers.js","position":70,"original_position":70,"commit_id":"d7d6f831bb41e9efcfad44ae51d3b919a1703b6a","original_commit_id":"d7d6f831bb41e9efcfad44ae51d3b919a1703b6a","user":{"login":"dobthound","id":8866243,"avatar_url":"https://avatars.githubusercontent.com/u/8866243?v=3","gravatar_id":"","url":"https://api.github.com/users/dobthound","html_url":"https://github.com/dobthound","followers_url":"https://api.github.com/users/dobthound/followers","following_url":"https://api.github.com/users/dobthound/following{/other_user}","gists_url":"https://api.github.com/users/dobthound/gists{/gist_id}","starred_url":"https://api.github.com/users/dobthound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobthound/subscriptions","organizations_url":"https://api.github.com/users/dobthound/orgs","repos_url":"https://api.github.com/users/dobthound/repos","events_url":"https://api.github.com/users/dobthound/events{/privacy}","received_events_url":"https://api.github.com/users/dobthound/received_events","type":"User","site_admin":false},"body":"Bad line breaking before '||'.","created_at":"2015-06-03T23:30:27Z","updated_at":"2015-06-03T23:30:27Z","html_url":"https://github.com/dobtco/dvl-core/pull/101#discussion_r31681455","pull_request_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments/31681455"},"html":{"href":"https://github.com/dobtco/dvl-core/pull/101#discussion_r31681455"},"pull_request":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/dobtco/dvl-core/pulls/101","id":36888300,"html_url":"https://github.com/dobtco/dvl-core/pull/101","diff_url":"https://github.com/dobtco/dvl-core/pull/101.diff","patch_url":"https://github.com/dobtco/dvl-core/pull/101.patch","issue_url":"https://api.github.com/repos/dobtco/dvl-core/issues/101","number":101,"state":"open","locked":false,"title":"add delete confirmation","user":{"login":"ajb","id":1270317,"avatar_url":"https://avatars.githubusercontent.com/u/1270317?v=3","gravatar_id":"","url":"https://api.github.com/users/ajb","html_url":"https://github.com/ajb","followers_url":"https://api.github.com/users/ajb/followers","following_url":"https://api.github.com/users/ajb/following{/other_user}","gists_url":"https://api.github.com/users/ajb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajb/subscriptions","organizations_url":"https://api.github.com/users/ajb/orgs","repos_url":"https://api.github.com/users/ajb/repos","events_url":"https://api.github.com/users/ajb/events{/privacy}","received_events_url":"https://api.github.com/users/ajb/received_events","type":"User","site_admin":false},"body":"cf https://github.com/dobtco/screendoor-v2/issues/1841\r\n\r\n![img](http://take.ms/BwHRW)\r\n\r\nThere's a couple of use cases where I'm not sure how to implement this properly... this is definitely better for most use cases, but maybe we should keep the modal for some use cases? Here's where I'm stuck:\r\n\r\n![img](http://take.ms/u1m58)\r\n\r\n![img](http://take.ms/5nDTU)\r\n\r\nIt seems like we might need to preserve the ability to show a small bit of text along with the confirmation buttons.","created_at":"2015-06-03T23:15:43Z","updated_at":"2015-06-03T23:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad40bad6700c7b92e1928e9d9680bfc344303192","assignee":{"login":"jrubenoff","id":1328849,"avatar_url":"https://avatars.githubusercontent.com/u/1328849?v=3","gravatar_id":"","url":"https://api.github.com/users/jrubenoff","html_url":"https://github.com/jrubenoff","followers_url":"https://api.github.com/users/jrubenoff/followers","following_url":"https://api.github.com/users/jrubenoff/following{/other_user}","gists_url":"https://api.github.com/users/jrubenoff/gists{/gist_id}","starred_url":"https://api.github.com/users/jrubenoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrubenoff/subscriptions","organizations_url":"https://api.github.com/users/jrubenoff/orgs","repos_url":"https://api.github.com/users/jrubenoff/repos","events_url":"https://api.github.com/users/jrubenoff/events{/privacy}","received_events_url":"https://api.github.com/users/jrubenoff/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/101/commits","review_comments_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/101/comments","review_comment_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/issues/101/comments","statuses_url":"https://api.github.com/repos/dobtco/dvl-core/statuses/d7d6f831bb41e9efcfad44ae51d3b919a1703b6a","head":{"label":"dobtco:delete-confirmation","ref":"delete-confirmation","sha":"d7d6f831bb41e9efcfad44ae51d3b919a1703b6a","user":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"repo":{"id":26410803,"name":"dvl-core","full_name":"dobtco/dvl-core","owner":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dobtco/dvl-core","description":"Base styles for the DOBT View Layer.","fork":false,"url":"https://api.github.com/repos/dobtco/dvl-core","forks_url":"https://api.github.com/repos/dobtco/dvl-core/forks","keys_url":"https://api.github.com/repos/dobtco/dvl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dobtco/dvl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dobtco/dvl-core/teams","hooks_url":"https://api.github.com/repos/dobtco/dvl-core/hooks","issue_events_url":"https://api.github.com/repos/dobtco/dvl-core/issues/events{/number}","events_url":"https://api.github.com/repos/dobtco/dvl-core/events","assignees_url":"https://api.github.com/repos/dobtco/dvl-core/assignees{/user}","branches_url":"https://api.github.com/repos/dobtco/dvl-core/branches{/branch}","tags_url":"https://api.github.com/repos/dobtco/dvl-core/tags","blobs_url":"https://api.github.com/repos/dobtco/dvl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dobtco/dvl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dobtco/dvl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dobtco/dvl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dobtco/dvl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dobtco/dvl-core/languages","stargazers_url":"https://api.github.com/repos/dobtco/dvl-core/stargazers","contributors_url":"https://api.github.com/repos/dobtco/dvl-core/contributors","subscribers_url":"https://api.github.com/repos/dobtco/dvl-core/subscribers","subscription_url":"https://api.github.com/repos/dobtco/dvl-core/subscription","commits_url":"https://api.github.com/repos/dobtco/dvl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dobtco/dvl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dobtco/dvl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dobtco/dvl-core/contents/{+path}","compare_url":"https://api.github.com/repos/dobtco/dvl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dobtco/dvl-core/merges","archive_url":"https://api.github.com/repos/dobtco/dvl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dobtco/dvl-core/downloads","issues_url":"https://api.github.com/repos/dobtco/dvl-core/issues{/number}","pulls_url":"https://api.github.com/repos/dobtco/dvl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dobtco/dvl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dobtco/dvl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dobtco/dvl-core/labels{/name}","releases_url":"https://api.github.com/repos/dobtco/dvl-core/releases{/id}","created_at":"2014-11-09T22:00:57Z","updated_at":"2015-04-28T17:39:24Z","pushed_at":"2015-06-03T23:30:16Z","git_url":"git://github.com/dobtco/dvl-core.git","ssh_url":"git@github.com:dobtco/dvl-core.git","clone_url":"https://github.com/dobtco/dvl-core.git","svn_url":"https://github.com/dobtco/dvl-core","homepage":"https://dvlcore.herokuapp.com/","size":2378,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"dobtco:master","ref":"master","sha":"fd1a0272beae72985c53bae56dc5bc425ec51b0c","user":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"repo":{"id":26410803,"name":"dvl-core","full_name":"dobtco/dvl-core","owner":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dobtco/dvl-core","description":"Base styles for the DOBT View Layer.","fork":false,"url":"https://api.github.com/repos/dobtco/dvl-core","forks_url":"https://api.github.com/repos/dobtco/dvl-core/forks","keys_url":"https://api.github.com/repos/dobtco/dvl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dobtco/dvl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dobtco/dvl-core/teams","hooks_url":"https://api.github.com/repos/dobtco/dvl-core/hooks","issue_events_url":"https://api.github.com/repos/dobtco/dvl-core/issues/events{/number}","events_url":"https://api.github.com/repos/dobtco/dvl-core/events","assignees_url":"https://api.github.com/repos/dobtco/dvl-core/assignees{/user}","branches_url":"https://api.github.com/repos/dobtco/dvl-core/branches{/branch}","tags_url":"https://api.github.com/repos/dobtco/dvl-core/tags","blobs_url":"https://api.github.com/repos/dobtco/dvl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dobtco/dvl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dobtco/dvl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dobtco/dvl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dobtco/dvl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dobtco/dvl-core/languages","stargazers_url":"https://api.github.com/repos/dobtco/dvl-core/stargazers","contributors_url":"https://api.github.com/repos/dobtco/dvl-core/contributors","subscribers_url":"https://api.github.com/repos/dobtco/dvl-core/subscribers","subscription_url":"https://api.github.com/repos/dobtco/dvl-core/subscription","commits_url":"https://api.github.com/repos/dobtco/dvl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dobtco/dvl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dobtco/dvl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dobtco/dvl-core/contents/{+path}","compare_url":"https://api.github.com/repos/dobtco/dvl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dobtco/dvl-core/merges","archive_url":"https://api.github.com/repos/dobtco/dvl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dobtco/dvl-core/downloads","issues_url":"https://api.github.com/repos/dobtco/dvl-core/issues{/number}","pulls_url":"https://api.github.com/repos/dobtco/dvl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dobtco/dvl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dobtco/dvl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dobtco/dvl-core/labels{/name}","releases_url":"https://api.github.com/repos/dobtco/dvl-core/releases{/id}","created_at":"2014-11-09T22:00:57Z","updated_at":"2015-04-28T17:39:24Z","pushed_at":"2015-06-03T23:30:16Z","git_url":"git://github.com/dobtco/dvl-core.git","ssh_url":"git@github.com:dobtco/dvl-core.git","clone_url":"https://github.com/dobtco/dvl-core.git","svn_url":"https://github.com/dobtco/dvl-core","homepage":"https://dvlcore.herokuapp.com/","size":2378,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/101"},"html":{"href":"https://github.com/dobtco/dvl-core/pull/101"},"issue":{"href":"https://api.github.com/repos/dobtco/dvl-core/issues/101"},"comments":{"href":"https://api.github.com/repos/dobtco/dvl-core/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/dobtco/dvl-core/statuses/d7d6f831bb41e9efcfad44ae51d3b919a1703b6a"}}}}