{"action":"opened","number":3151,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3151","id":30416655,"html_url":"https://github.com/zfsonlinux/zfs/pull/3151","diff_url":"https://github.com/zfsonlinux/zfs/pull/3151.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3151.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3151","number":3151,"state":"open","locked":false,"title":"Restructure spa_features_check()","user":{"login":"nedbass","id":320381,"avatar_url":"https://avatars.githubusercontent.com/u/320381?v=3","gravatar_id":"","url":"https://api.github.com/users/nedbass","html_url":"https://github.com/nedbass","followers_url":"https://api.github.com/users/nedbass/followers","following_url":"https://api.github.com/users/nedbass/following{/other_user}","gists_url":"https://api.github.com/users/nedbass/gists{/gist_id}","starred_url":"https://api.github.com/users/nedbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedbass/subscriptions","organizations_url":"https://api.github.com/users/nedbass/orgs","repos_url":"https://api.github.com/users/nedbass/repos","events_url":"https://api.github.com/users/nedbass/events{/privacy}","received_events_url":"https://api.github.com/users/nedbass/received_events","type":"User","site_admin":false},"body":"A boolean checker function with side effects makes for poorly readable\r\ncode.  This patch restructures spa_features_check() to eliminate its\r\nside effects, and replaces it with a pair of functions\r\nspa_features_read_supported() spa_features_write_supported().  It also\r\nadds two new functions to supply the functionality previously provided\r\nby the side effects of spa_features_check(). Finally, spa_load_impl() is\r\nupdated to use the new interfaces. The goal is to make the intent of the\r\nmodified code in spa_load_impl() more obvious.\r\n\r\nSigned-off-by: Ned Bass <bass6@llnl.gov>","created_at":"2015-03-03T21:55:27Z","updated_at":"2015-03-03T21:55:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3151/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3151/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3151/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/c0cdcab092ebd7058c02f5c82c920d81d66122fc","head":{"label":"nedbass:b_spa_features_check_rework","ref":"b_spa_features_check_rework","sha":"c0cdcab092ebd7058c02f5c82c920d81d66122fc","user":{"login":"nedbass","id":320381,"avatar_url":"https://avatars.githubusercontent.com/u/320381?v=3","gravatar_id":"","url":"https://api.github.com/users/nedbass","html_url":"https://github.com/nedbass","followers_url":"https://api.github.com/users/nedbass/followers","following_url":"https://api.github.com/users/nedbass/following{/other_user}","gists_url":"https://api.github.com/users/nedbass/gists{/gist_id}","starred_url":"https://api.github.com/users/nedbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedbass/subscriptions","organizations_url":"https://api.github.com/users/nedbass/orgs","repos_url":"https://api.github.com/users/nedbass/repos","events_url":"https://api.github.com/users/nedbass/events{/privacy}","received_events_url":"https://api.github.com/users/nedbass/received_events","type":"User","site_admin":false},"repo":{"id":1556338,"name":"zfs","full_name":"nedbass/zfs","owner":{"login":"nedbass","id":320381,"avatar_url":"https://avatars.githubusercontent.com/u/320381?v=3","gravatar_id":"","url":"https://api.github.com/users/nedbass","html_url":"https://github.com/nedbass","followers_url":"https://api.github.com/users/nedbass/followers","following_url":"https://api.github.com/users/nedbass/following{/other_user}","gists_url":"https://api.github.com/users/nedbass/gists{/gist_id}","starred_url":"https://api.github.com/users/nedbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedbass/subscriptions","organizations_url":"https://api.github.com/users/nedbass/orgs","repos_url":"https://api.github.com/users/nedbass/repos","events_url":"https://api.github.com/users/nedbass/events{/privacy}","received_events_url":"https://api.github.com/users/nedbass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nedbass/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/nedbass/zfs","forks_url":"https://api.github.com/repos/nedbass/zfs/forks","keys_url":"https://api.github.com/repos/nedbass/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nedbass/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nedbass/zfs/teams","hooks_url":"https://api.github.com/repos/nedbass/zfs/hooks","issue_events_url":"https://api.github.com/repos/nedbass/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/nedbass/zfs/events","assignees_url":"https://api.github.com/repos/nedbass/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/nedbass/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/nedbass/zfs/tags","blobs_url":"https://api.github.com/repos/nedbass/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nedbass/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nedbass/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nedbass/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nedbass/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/nedbass/zfs/languages","stargazers_url":"https://api.github.com/repos/nedbass/zfs/stargazers","contributors_url":"https://api.github.com/repos/nedbass/zfs/contributors","subscribers_url":"https://api.github.com/repos/nedbass/zfs/subscribers","subscription_url":"https://api.github.com/repos/nedbass/zfs/subscription","commits_url":"https://api.github.com/repos/nedbass/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nedbass/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nedbass/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nedbass/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nedbass/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/nedbass/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nedbass/zfs/merges","archive_url":"https://api.github.com/repos/nedbass/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nedbass/zfs/downloads","issues_url":"https://api.github.com/repos/nedbass/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/nedbass/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/nedbass/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/nedbass/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nedbass/zfs/labels{/name}","releases_url":"https://api.github.com/repos/nedbass/zfs/releases{/id}","created_at":"2011-04-01T16:41:54Z","updated_at":"2014-12-24T01:09:57Z","pushed_at":"2015-03-03T21:52:31Z","git_url":"git://github.com/nedbass/zfs.git","ssh_url":"git@github.com:nedbass/zfs.git","clone_url":"https://github.com/nedbass/zfs.git","svn_url":"https://github.com/nedbass/zfs","homepage":"http://zfsonlinux.org/","size":25115,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"02bd676df1c260262d2e4c5618a42783fba52006","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"Native ZFS for Linux","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","created_at":"2009-12-14T20:20:34Z","updated_at":"2015-03-03T21:38:53Z","pushed_at":"2015-03-03T21:38:53Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":50171,"stargazers_count":1292,"watchers_count":1292,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":666,"forks":332,"open_issues":666,"watchers":1292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3151"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/3151"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3151"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3151/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3151/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3151/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/c0cdcab092ebd7058c02f5c82c920d81d66122fc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":126,"deletions":36,"changed_files":3}}