{"action":"created","issue":{"url":"https://api.github.com/repos/ronanguilloux/IsoCodes/issues/34","labels_url":"https://api.github.com/repos/ronanguilloux/IsoCodes/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/ronanguilloux/IsoCodes/issues/34/comments","events_url":"https://api.github.com/repos/ronanguilloux/IsoCodes/issues/34/events","html_url":"https://github.com/ronanguilloux/IsoCodes/pull/34","id":73385303,"number":34,"title":"Make Ssn as a singleton class","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-05-05T18:05:42Z","updated_at":"2015-06-03T07:52:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ronanguilloux/IsoCodes/pulls/34","html_url":"https://github.com/ronanguilloux/IsoCodes/pull/34","diff_url":"https://github.com/ronanguilloux/IsoCodes/pull/34.diff","patch_url":"https://github.com/ronanguilloux/IsoCodes/pull/34.patch"},"body":"This PR is related to #12 and also to #33 proposition.\r\n\r\n`Ssn` is now a singleton class in order to make `validate` function static like other validators does.\r\n\r\nI also add tests that simply call `generate` function to verify if is not crashing. I don't know how to assert results of `generate`, any advice @ronanguilloux?\r\n\r\nMethod based on this article: http://www.phptherightway.com/pages/Design-Patterns.html#singleton\r\n\r\nPlease not: This is BC break for libraries that implement IsoCodes. Must be on `1.2` version at least."},"comment":{"url":"https://api.github.com/repos/ronanguilloux/IsoCodes/issues/comments/108235270","html_url":"https://github.com/ronanguilloux/IsoCodes/pull/34#issuecomment-108235270","issue_url":"https://api.github.com/repos/ronanguilloux/IsoCodes/issues/34","id":108235270,"user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T07:52:54Z","updated_at":"2015-06-03T07:52:54Z","body":"Test case reviewed again. Should be OK now."}}