{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/specsim/issues/8","labels_url":"https://api.github.com/repos/desihub/specsim/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/desihub/specsim/issues/8/comments","events_url":"https://api.github.com/repos/desihub/specsim/issues/8/events","html_url":"https://github.com/desihub/specsim/issues/8","id":110356047,"number":8,"title":"Sky treatment does not account atmospheric extinction","user":{"login":"gdhungana","id":10554289,"avatar_url":"https://avatars.githubusercontent.com/u/10554289?v=3","gravatar_id":"","url":"https://api.github.com/users/gdhungana","html_url":"https://github.com/gdhungana","followers_url":"https://api.github.com/users/gdhungana/followers","following_url":"https://api.github.com/users/gdhungana/following{/other_user}","gists_url":"https://api.github.com/users/gdhungana/gists{/gist_id}","starred_url":"https://api.github.com/users/gdhungana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdhungana/subscriptions","organizations_url":"https://api.github.com/users/gdhungana/orgs","repos_url":"https://api.github.com/users/gdhungana/repos","events_url":"https://api.github.com/users/gdhungana/events{/privacy}","received_events_url":"https://api.github.com/users/gdhungana/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/desihub/specsim/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-08T01:51:34Z","updated_at":"2015-11-17T17:47:59Z","closed_at":null,"body":"Currently in quicksim, the sky is treated from top of the atmosphere, not accounting the extinction. I think (from one of the telecon) the zeroth order convention was to put atmospheric extinction to not only the source but sky also. "},"comment":{"url":"https://api.github.com/repos/desihub/specsim/issues/comments/157450555","html_url":"https://github.com/desihub/specsim/issues/8#issuecomment-157450555","issue_url":"https://api.github.com/repos/desihub/specsim/issues/8","id":157450555,"user":{"login":"dkirkby","id":185007,"avatar_url":"https://avatars.githubusercontent.com/u/185007?v=3","gravatar_id":"","url":"https://api.github.com/users/dkirkby","html_url":"https://github.com/dkirkby","followers_url":"https://api.github.com/users/dkirkby/followers","following_url":"https://api.github.com/users/dkirkby/following{/other_user}","gists_url":"https://api.github.com/users/dkirkby/gists{/gist_id}","starred_url":"https://api.github.com/users/dkirkby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkirkby/subscriptions","organizations_url":"https://api.github.com/users/dkirkby/orgs","repos_url":"https://api.github.com/users/dkirkby/repos","events_url":"https://api.github.com/users/dkirkby/events{/privacy}","received_events_url":"https://api.github.com/users/dkirkby/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T17:47:59Z","updated_at":"2015-11-17T17:47:59Z","body":"I was hoping this would be as simple as copying & pasting one line of code, but it will a bit more complicated because I am currently pre-computing the resolution-convolved sky in each camera as part of the initialization phase, but now that will need to be moved into the per-spectrum simulation code since the extinction depends on the per-observation airmass."}}