{"action":"opened","issue":{"url":"https://api.github.com/repos/pabloi/labTools/issues/11","labels_url":"https://api.github.com/repos/pabloi/labTools/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/pabloi/labTools/issues/11/comments","events_url":"https://api.github.com/repos/pabloi/labTools/issues/11/events","html_url":"https://github.com/pabloi/labTools/issues/11","id":110087975,"number":11,"title":"Deleting events vs. Labeling events in ReviewEventsGUI","user":{"login":"willpower2727","id":10742358,"avatar_url":"https://avatars.githubusercontent.com/u/10742358?v=3","gravatar_id":"","url":"https://api.github.com/users/willpower2727","html_url":"https://github.com/willpower2727","followers_url":"https://api.github.com/users/willpower2727/followers","following_url":"https://api.github.com/users/willpower2727/following{/other_user}","gists_url":"https://api.github.com/users/willpower2727/gists{/gist_id}","starred_url":"https://api.github.com/users/willpower2727/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willpower2727/subscriptions","organizations_url":"https://api.github.com/users/willpower2727/orgs","repos_url":"https://api.github.com/users/willpower2727/repos","events_url":"https://api.github.com/users/willpower2727/events{/privacy}","received_events_url":"https://api.github.com/users/willpower2727/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pabloi/labTools/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-06T19:59:02Z","updated_at":"2015-10-06T19:59:02Z","closed_at":null,"body":"Can anyone shed some insight on the differences between the delete events buttons and the label as good/bad buttons in the ReviewEventsGUI? In case you don't know, Pressing the \"delete\" buttons places a call to re-calculate the parameters:\r\n\r\nline 625\r\nexpData.data{handles.idx}.adaptParams=calcParameters(expData.data{handles.idx},expData.subData);\r\n\r\nWhen the label as \"bad\" button is pressed, line 719 the expData instance is simply updated, and then it re-plots in the GUI.\r\n\r\nexpData.data{handles.idx}.adaptParams.Data(loc,idxs)=[true, false]; \r\n\r\nIs the call to re-calculate parameters necessary? If labeling an event as \"bad\" has the same end affect as deleting the events, it would be much much much much faster to skip the call to re-calculate parameters. For example, when reviewing stroke or stroke control data, deleting an event on a long trial (6-10 minutes) takes several minutes. Typically there are a few events to delete and they don't always happen in the same time frame. So I end up deleting events multiple times per trial. Long story short, it takes all afternoon to review the events of a stroke/control subject.\r\n\r\nIf anyone can explain why we are calling calcparams I'd be grateful. If no one knows, and \"bad\" events are ignored in the end, I'd suggest we avoid using the delete buttons."}}