{"action":"created","issue":{"url":"https://api.github.com/repos/JabRef/jabref/issues/500","labels_url":"https://api.github.com/repos/JabRef/jabref/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/500/comments","events_url":"https://api.github.com/repos/JabRef/jabref/issues/500/events","html_url":"https://github.com/JabRef/jabref/pull/500","id":121511984,"number":500,"title":"Database type detection","user":{"login":"stefan-kolb","id":2141507,"avatar_url":"https://avatars.githubusercontent.com/u/2141507?v=3","gravatar_id":"","url":"https://api.github.com/users/stefan-kolb","html_url":"https://github.com/stefan-kolb","followers_url":"https://api.github.com/users/stefan-kolb/followers","following_url":"https://api.github.com/users/stefan-kolb/following{/other_user}","gists_url":"https://api.github.com/users/stefan-kolb/gists{/gist_id}","starred_url":"https://api.github.com/users/stefan-kolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefan-kolb/subscriptions","organizations_url":"https://api.github.com/users/stefan-kolb/orgs","repos_url":"https://api.github.com/users/stefan-kolb/repos","events_url":"https://api.github.com/users/stefan-kolb/events{/privacy}","received_events_url":"https://api.github.com/users/stefan-kolb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JabRef/jabref/labels/ready-for-review","name":"ready-for-review","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-10T15:32:25Z","updated_at":"2015-12-10T16:46:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/500","html_url":"https://github.com/JabRef/jabref/pull/500","diff_url":"https://github.com/JabRef/jabref/pull/500.diff","patch_url":"https://github.com/JabRef/jabref/pull/500.patch"},"body":"Please see `BibDatabaseTypeDetection.java`for review.\r\n\r\nSome refactoring and a class for auto-detection of database types.\r\n\r\n### Algorithm\r\n- should we introduce a hard-coded field like encodings inside the bib file?\r\n- fast-enough?\r\n- what about false detection?\r\n\r\n### Refactoring\r\n- Bibtexdatabase -> BibDatabase\r\n- BibtexEntry -> BibEntry\r\n\r\nalso see #495, #167"},"comment":{"url":"https://api.github.com/repos/JabRef/jabref/issues/comments/163683775","html_url":"https://github.com/JabRef/jabref/pull/500#issuecomment-163683775","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/500","id":163683775,"user":{"login":"lenhard","id":1515701,"avatar_url":"https://avatars.githubusercontent.com/u/1515701?v=3","gravatar_id":"","url":"https://api.github.com/users/lenhard","html_url":"https://github.com/lenhard","followers_url":"https://api.github.com/users/lenhard/followers","following_url":"https://api.github.com/users/lenhard/following{/other_user}","gists_url":"https://api.github.com/users/lenhard/gists{/gist_id}","starred_url":"https://api.github.com/users/lenhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenhard/subscriptions","organizations_url":"https://api.github.com/users/lenhard/orgs","repos_url":"https://api.github.com/users/lenhard/repos","events_url":"https://api.github.com/users/lenhard/events{/privacy}","received_events_url":"https://api.github.com/users/lenhard/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T16:46:32Z","updated_at":"2015-12-10T16:46:32Z","body":"The refactorings are fine, from my point of view.\r\n\r\nThe detection is based on in-memory operations on collections, so no need to worry about speed at the moment.\r\n\r\nIf I understand the algorithm correctly, any database that contains a non-Biblatex/non-Bibtex type will be categorized as Bibtex. So, a database with one BibLatex entry and a customn entry would be detected as Bibtex. Is that really the desired result? I would rather ignore all non-Bibtex / non-Biblatex types for the decision (CustomEntry, UnkownEntry, IEEETranEntry, ...) and do the decision solely on valid types with Bibtex as the default result."}}