{"action":"created","issue":{"url":"https://api.github.com/repos/schmie/hemeMove/issues/437","labels_url":"https://api.github.com/repos/schmie/hemeMove/issues/437/labels{/name}","comments_url":"https://api.github.com/repos/schmie/hemeMove/issues/437/comments","events_url":"https://api.github.com/repos/schmie/hemeMove/issues/437/events","html_url":"https://github.com/schmie/hemeMove/issues/437","id":96293576,"number":437,"title":"Test and merge CGAL setup tool","user":{"login":"schmie","id":6473158,"avatar_url":"https://avatars.githubusercontent.com/u/6473158?v=3","gravatar_id":"","url":"https://api.github.com/users/schmie","html_url":"https://github.com/schmie","followers_url":"https://api.github.com/users/schmie/followers","following_url":"https://api.github.com/users/schmie/following{/other_user}","gists_url":"https://api.github.com/users/schmie/gists{/gist_id}","starred_url":"https://api.github.com/users/schmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmie/subscriptions","organizations_url":"https://api.github.com/users/schmie/orgs","repos_url":"https://api.github.com/users/schmie/repos","events_url":"https://api.github.com/users/schmie/events{/privacy}","received_events_url":"https://api.github.com/users/schmie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jenshnielsen","id":548266,"avatar_url":"https://avatars.githubusercontent.com/u/548266?v=3","gravatar_id":"","url":"https://api.github.com/users/jenshnielsen","html_url":"https://github.com/jenshnielsen","followers_url":"https://api.github.com/users/jenshnielsen/followers","following_url":"https://api.github.com/users/jenshnielsen/following{/other_user}","gists_url":"https://api.github.com/users/jenshnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jenshnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenshnielsen/subscriptions","organizations_url":"https://api.github.com/users/jenshnielsen/orgs","repos_url":"https://api.github.com/users/jenshnielsen/repos","events_url":"https://api.github.com/users/jenshnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/jenshnielsen/received_events","type":"User","site_admin":false},"milestone":null,"comments":17,"created_at":"2015-07-21T11:29:26Z","updated_at":"2015-07-21T11:30:22Z","closed_at":null,"body":"**Reported by miguel on 17 Jul 2013 09:37 UTC**\nNone"},"comment":{"url":"https://api.github.com/repos/schmie/hemeMove/issues/comments/123273362","html_url":"https://github.com/schmie/hemeMove/issues/437#issuecomment-123273362","issue_url":"https://api.github.com/repos/schmie/hemeMove/issues/437","id":123273362,"user":{"login":"schmie","id":6473158,"avatar_url":"https://avatars.githubusercontent.com/u/6473158?v=3","gravatar_id":"","url":"https://api.github.com/users/schmie","html_url":"https://github.com/schmie","followers_url":"https://api.github.com/users/schmie/followers","following_url":"https://api.github.com/users/schmie/following{/other_user}","gists_url":"https://api.github.com/users/schmie/gists{/gist_id}","starred_url":"https://api.github.com/users/schmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmie/subscriptions","organizations_url":"https://api.github.com/users/schmie/orgs","repos_url":"https://api.github.com/users/schmie/repos","events_url":"https://api.github.com/users/schmie/events{/privacy}","received_events_url":"https://api.github.com/users/schmie/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T11:30:22Z","updated_at":"2015-07-21T11:30:22Z","body":"**Comment by miguel on 30 Aug 2013 09:45 UTC**\nThanks to the improvements of the past few days, I can now discretise at 0.433um.\r\n\r\nI noticed that one of the regression tests is failing. I investigated the issue a bit and found out that it is due to cut distances less than 1e-6 off, so I'm gonna ignore that and update the test fixture. This is the code I used for checking:\r\n\r\n```\r\ndiff -r e91918263cdd Tools/setuptool/test/TestHemeLBSetupTool/Model/test_OutputGeneration.py\r\n--- a/Tools/setuptool/test/TestHemeLBSetupTool/Model/test_OutputGeneration.py\tThu Aug 29 15:41:38 2013 +0100\r\n+++ b/Tools/setuptool/test/TestHemeLBSetupTool/Model/test_OutputGeneration.py\tFri Aug 30 10:42:24 2013 +0100\r\n@@ -33,6 +33,24 @@\r\n         generator = OutputGeneration.PolyDataGenerator(p)\r\n         generator.Execute()\r\n \r\n+        stored_file = ConfigLoader(os.path.join(dataDir, 'test.gmy'))\r\n+        stored_file.Load()\r\n+        new_file = ConfigLoader(outGmyFileName)\r\n+        new_file.Load()\r\n+\r\n+        assert sum(stored_file.Domain.BlockFluidSiteCounts) == sum(new_file.Domain.BlockFluidSiteCounts)\r\n+        from itertools import izip\r\n+        for s_block, n_block in izip(stored_file.Domain.Blocks, new_file.Domain.Blocks):\r\n+            if s_block.Sites is not None:\r\n+                for s_site, n_site in izip(s_block.Sites, n_block.Sites):\r\n+                    assert s_site.IsEdge == n_site.IsEdge\r\n+                    if n_site.IsEdge:\r\n+                        assert np.all(s_site.Position == n_site.Position)\r\n+                        assert np.all(s_site.IntersectionType == n_site.IntersectionType)\r\n+                        assert np.all(np.abs(s_site.IntersectionDistance - n_site.IntersectionDistance) < 1e-6)\r\n+            else:\r\n+                assert s_block.Sites == n_block.Sites\r\n+        \r\n         import filecmp\r\n         assert filecmp.cmp(outGmyFileName, os.path.join(dataDir, 'test.gmy'))\r\n         assert filecmp.cmp(outXmlFileName, os.path.join(dataDir, 'test.xml'))\r\n```\r\n\r\nI'm gonna update the regression test, merge the branch, and close the ticket today or Monday.\r\n\r\nI'm very pleased with this. Thanks for your efforts, Jens!\r\n"}}