{"action":"created","comment":{"url":"https://api.github.com/repos/clawpack/geoclaw/pulls/comments/26876096","id":26876096,"diff_hunk":"@@ -9,8 +9,13 @@ subroutine src1d(meqn,mbc,mx1d,q1d,maux,aux1d,t,dt)\n     use geoclaw_module, only: g => grav, coriolis_forcing, coriolis\n     use geoclaw_module, only: friction_forcing, friction_depth\n     use geoclaw_module, only: omega, coordinate_system, manning_coefficient\n-    use geoclaw_module, only: manning_break, num_manning\n-                              \n+    use geoclaw_module, only: manning_break, num_manning, dry_tolerance","path":"src/2d/shallow/src1d.f90","position":6,"original_position":6,"commit_id":"00a8814105893976b4e9e6c7bcf5a090aa454570","original_commit_id":"00a8814105893976b4e9e6c7bcf5a090aa454570","user":{"login":"rjleveque","id":720122,"avatar_url":"https://avatars.githubusercontent.com/u/720122?v=3","gravatar_id":"","url":"https://api.github.com/users/rjleveque","html_url":"https://github.com/rjleveque","followers_url":"https://api.github.com/users/rjleveque/followers","following_url":"https://api.github.com/users/rjleveque/following{/other_user}","gists_url":"https://api.github.com/users/rjleveque/gists{/gist_id}","starred_url":"https://api.github.com/users/rjleveque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjleveque/subscriptions","organizations_url":"https://api.github.com/users/rjleveque/orgs","repos_url":"https://api.github.com/users/rjleveque/repos","events_url":"https://api.github.com/users/rjleveque/events{/privacy}","received_events_url":"https://api.github.com/users/rjleveque/received_events","type":"User","site_admin":false},"body":"variable friction coefficient in `setaux` is supported in `src2.f90` but not in `src1d.f90`?","created_at":"2015-03-20T21:00:51Z","updated_at":"2015-03-20T21:00:51Z","html_url":"https://github.com/clawpack/geoclaw/pull/80#discussion_r26876096","pull_request_url":"https://api.github.com/repos/clawpack/geoclaw/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/clawpack/geoclaw/pulls/comments/26876096"},"html":{"href":"https://github.com/clawpack/geoclaw/pull/80#discussion_r26876096"},"pull_request":{"href":"https://api.github.com/repos/clawpack/geoclaw/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/clawpack/geoclaw/pulls/80","id":16607263,"html_url":"https://github.com/clawpack/geoclaw/pull/80","diff_url":"https://github.com/clawpack/geoclaw/pull/80.diff","patch_url":"https://github.com/clawpack/geoclaw/pull/80.patch","issue_url":"https://api.github.com/repos/clawpack/geoclaw/issues/80","number":80,"state":"open","locked":false,"title":"Merge Storm Surge Code Into Main Code","user":{"login":"mandli","id":322129,"avatar_url":"https://avatars.githubusercontent.com/u/322129?v=3","gravatar_id":"","url":"https://api.github.com/users/mandli","html_url":"https://github.com/mandli","followers_url":"https://api.github.com/users/mandli/followers","following_url":"https://api.github.com/users/mandli/following{/other_user}","gists_url":"https://api.github.com/users/mandli/gists{/gist_id}","starred_url":"https://api.github.com/users/mandli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandli/subscriptions","organizations_url":"https://api.github.com/users/mandli/orgs","repos_url":"https://api.github.com/users/mandli/repos","events_url":"https://api.github.com/users/mandli/events{/privacy}","received_events_url":"https://api.github.com/users/mandli/received_events","type":"User","site_admin":false},"body":"In an effort to cut down on the upkeep of the storm surge code I decided to try and merge the storm surge specific code back into the general \"shallow\" code.  With a few modifications of what was being done with the storm surge code, the modifications were actually pretty minimal.  The primary bother for existing applications will be adding the required storm surge modules to the Makefiles.  Crude speed tests are below  but at least for the examples in GeoClaw do not show and performance degradation.\r\n\r\n### Timings\r\n`FC=gfortran (v4.8.2)`\r\n`FFLAGS=-O3 -funroll-loops -finline-functions -fopenmp`\r\nResults were averaged over 3 runs\r\n\r\nExample   | Old Time | New Time\r\n-------------|--------------|----------------\r\nChile2010   | 16.16900000 s | 14.64300000 s\r\nbowl-slosh  | 3.18000000 s  | 3.00400000 s\r\nbowl-radial | 10.74600000 s | 10.00000000 s\r\nIke         | 61.82000000 s | 60.14500000 s","created_at":"2014-06-02T15:56:35Z","updated_at":"2015-03-20T21:00:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdc6605dc50730f8ebeeff55607e257c30ee143a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clawpack/geoclaw/pulls/80/commits","review_comments_url":"https://api.github.com/repos/clawpack/geoclaw/pulls/80/comments","review_comment_url":"https://api.github.com/repos/clawpack/geoclaw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clawpack/geoclaw/issues/80/comments","statuses_url":"https://api.github.com/repos/clawpack/geoclaw/statuses/00a8814105893976b4e9e6c7bcf5a090aa454570","head":{"label":"mandli:stormsurge-main-merge","ref":"stormsurge-main-merge","sha":"00a8814105893976b4e9e6c7bcf5a090aa454570","user":{"login":"mandli","id":322129,"avatar_url":"https://avatars.githubusercontent.com/u/322129?v=3","gravatar_id":"","url":"https://api.github.com/users/mandli","html_url":"https://github.com/mandli","followers_url":"https://api.github.com/users/mandli/followers","following_url":"https://api.github.com/users/mandli/following{/other_user}","gists_url":"https://api.github.com/users/mandli/gists{/gist_id}","starred_url":"https://api.github.com/users/mandli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandli/subscriptions","organizations_url":"https://api.github.com/users/mandli/orgs","repos_url":"https://api.github.com/users/mandli/repos","events_url":"https://api.github.com/users/mandli/events{/privacy}","received_events_url":"https://api.github.com/users/mandli/received_events","type":"User","site_admin":false},"repo":{"id":3498386,"name":"geoclaw","full_name":"mandli/geoclaw","owner":{"login":"mandli","id":322129,"avatar_url":"https://avatars.githubusercontent.com/u/322129?v=3","gravatar_id":"","url":"https://api.github.com/users/mandli","html_url":"https://github.com/mandli","followers_url":"https://api.github.com/users/mandli/followers","following_url":"https://api.github.com/users/mandli/following{/other_user}","gists_url":"https://api.github.com/users/mandli/gists{/gist_id}","starred_url":"https://api.github.com/users/mandli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandli/subscriptions","organizations_url":"https://api.github.com/users/mandli/orgs","repos_url":"https://api.github.com/users/mandli/repos","events_url":"https://api.github.com/users/mandli/events{/privacy}","received_events_url":"https://api.github.com/users/mandli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandli/geoclaw","description":"Version of Clawpack for geophysical waves and flows","fork":true,"url":"https://api.github.com/repos/mandli/geoclaw","forks_url":"https://api.github.com/repos/mandli/geoclaw/forks","keys_url":"https://api.github.com/repos/mandli/geoclaw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandli/geoclaw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandli/geoclaw/teams","hooks_url":"https://api.github.com/repos/mandli/geoclaw/hooks","issue_events_url":"https://api.github.com/repos/mandli/geoclaw/issues/events{/number}","events_url":"https://api.github.com/repos/mandli/geoclaw/events","assignees_url":"https://api.github.com/repos/mandli/geoclaw/assignees{/user}","branches_url":"https://api.github.com/repos/mandli/geoclaw/branches{/branch}","tags_url":"https://api.github.com/repos/mandli/geoclaw/tags","blobs_url":"https://api.github.com/repos/mandli/geoclaw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandli/geoclaw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandli/geoclaw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandli/geoclaw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandli/geoclaw/statuses/{sha}","languages_url":"https://api.github.com/repos/mandli/geoclaw/languages","stargazers_url":"https://api.github.com/repos/mandli/geoclaw/stargazers","contributors_url":"https://api.github.com/repos/mandli/geoclaw/contributors","subscribers_url":"https://api.github.com/repos/mandli/geoclaw/subscribers","subscription_url":"https://api.github.com/repos/mandli/geoclaw/subscription","commits_url":"https://api.github.com/repos/mandli/geoclaw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandli/geoclaw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandli/geoclaw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandli/geoclaw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandli/geoclaw/contents/{+path}","compare_url":"https://api.github.com/repos/mandli/geoclaw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandli/geoclaw/merges","archive_url":"https://api.github.com/repos/mandli/geoclaw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandli/geoclaw/downloads","issues_url":"https://api.github.com/repos/mandli/geoclaw/issues{/number}","pulls_url":"https://api.github.com/repos/mandli/geoclaw/pulls{/number}","milestones_url":"https://api.github.com/repos/mandli/geoclaw/milestones{/number}","notifications_url":"https://api.github.com/repos/mandli/geoclaw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandli/geoclaw/labels{/name}","releases_url":"https://api.github.com/repos/mandli/geoclaw/releases{/id}","created_at":"2012-02-20T22:13:15Z","updated_at":"2015-02-16T19:23:58Z","pushed_at":"2015-02-20T17:57:41Z","git_url":"git://github.com/mandli/geoclaw.git","ssh_url":"git@github.com:mandli/geoclaw.git","clone_url":"https://github.com/mandli/geoclaw.git","svn_url":"https://github.com/mandli/geoclaw","homepage":"http://www.clawpack.org/geoclaw","size":5949,"stargazers_count":1,"watchers_count":1,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"clawpack:master","ref":"master","sha":"1ea45d4f9d51b99a3d6a21f30e7452337358794f","user":{"login":"clawpack","id":725474,"avatar_url":"https://avatars.githubusercontent.com/u/725474?v=3","gravatar_id":"","url":"https://api.github.com/users/clawpack","html_url":"https://github.com/clawpack","followers_url":"https://api.github.com/users/clawpack/followers","following_url":"https://api.github.com/users/clawpack/following{/other_user}","gists_url":"https://api.github.com/users/clawpack/gists{/gist_id}","starred_url":"https://api.github.com/users/clawpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clawpack/subscriptions","organizations_url":"https://api.github.com/users/clawpack/orgs","repos_url":"https://api.github.com/users/clawpack/repos","events_url":"https://api.github.com/users/clawpack/events{/privacy}","received_events_url":"https://api.github.com/users/clawpack/received_events","type":"Organization","site_admin":false},"repo":{"id":1612786,"name":"geoclaw","full_name":"clawpack/geoclaw","owner":{"login":"clawpack","id":725474,"avatar_url":"https://avatars.githubusercontent.com/u/725474?v=3","gravatar_id":"","url":"https://api.github.com/users/clawpack","html_url":"https://github.com/clawpack","followers_url":"https://api.github.com/users/clawpack/followers","following_url":"https://api.github.com/users/clawpack/following{/other_user}","gists_url":"https://api.github.com/users/clawpack/gists{/gist_id}","starred_url":"https://api.github.com/users/clawpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clawpack/subscriptions","organizations_url":"https://api.github.com/users/clawpack/orgs","repos_url":"https://api.github.com/users/clawpack/repos","events_url":"https://api.github.com/users/clawpack/events{/privacy}","received_events_url":"https://api.github.com/users/clawpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clawpack/geoclaw","description":"Version of Clawpack for geophysical waves and flows","fork":false,"url":"https://api.github.com/repos/clawpack/geoclaw","forks_url":"https://api.github.com/repos/clawpack/geoclaw/forks","keys_url":"https://api.github.com/repos/clawpack/geoclaw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clawpack/geoclaw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clawpack/geoclaw/teams","hooks_url":"https://api.github.com/repos/clawpack/geoclaw/hooks","issue_events_url":"https://api.github.com/repos/clawpack/geoclaw/issues/events{/number}","events_url":"https://api.github.com/repos/clawpack/geoclaw/events","assignees_url":"https://api.github.com/repos/clawpack/geoclaw/assignees{/user}","branches_url":"https://api.github.com/repos/clawpack/geoclaw/branches{/branch}","tags_url":"https://api.github.com/repos/clawpack/geoclaw/tags","blobs_url":"https://api.github.com/repos/clawpack/geoclaw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clawpack/geoclaw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clawpack/geoclaw/git/refs{/sha}","trees_url":"https://api.github.com/repos/clawpack/geoclaw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clawpack/geoclaw/statuses/{sha}","languages_url":"https://api.github.com/repos/clawpack/geoclaw/languages","stargazers_url":"https://api.github.com/repos/clawpack/geoclaw/stargazers","contributors_url":"https://api.github.com/repos/clawpack/geoclaw/contributors","subscribers_url":"https://api.github.com/repos/clawpack/geoclaw/subscribers","subscription_url":"https://api.github.com/repos/clawpack/geoclaw/subscription","commits_url":"https://api.github.com/repos/clawpack/geoclaw/commits{/sha}","git_commits_url":"https://api.github.com/repos/clawpack/geoclaw/git/commits{/sha}","comments_url":"https://api.github.com/repos/clawpack/geoclaw/comments{/number}","issue_comment_url":"https://api.github.com/repos/clawpack/geoclaw/issues/comments{/number}","contents_url":"https://api.github.com/repos/clawpack/geoclaw/contents/{+path}","compare_url":"https://api.github.com/repos/clawpack/geoclaw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clawpack/geoclaw/merges","archive_url":"https://api.github.com/repos/clawpack/geoclaw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clawpack/geoclaw/downloads","issues_url":"https://api.github.com/repos/clawpack/geoclaw/issues{/number}","pulls_url":"https://api.github.com/repos/clawpack/geoclaw/pulls{/number}","milestones_url":"https://api.github.com/repos/clawpack/geoclaw/milestones{/number}","notifications_url":"https://api.github.com/repos/clawpack/geoclaw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clawpack/geoclaw/labels{/name}","releases_url":"https://api.github.com/repos/clawpack/geoclaw/releases{/id}","created_at":"2011-04-14T05:00:38Z","updated_at":"2015-03-19T22:42:56Z","pushed_at":"2015-03-19T22:42:54Z","git_url":"git://github.com/clawpack/geoclaw.git","ssh_url":"git@github.com:clawpack/geoclaw.git","clone_url":"https://github.com/clawpack/geoclaw.git","svn_url":"https://github.com/clawpack/geoclaw","homepage":"http://www.clawpack.org/geoclaw","size":5781,"stargazers_count":8,"watchers_count":8,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":18,"forks":20,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clawpack/geoclaw/pulls/80"},"html":{"href":"https://github.com/clawpack/geoclaw/pull/80"},"issue":{"href":"https://api.github.com/repos/clawpack/geoclaw/issues/80"},"comments":{"href":"https://api.github.com/repos/clawpack/geoclaw/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/clawpack/geoclaw/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/clawpack/geoclaw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clawpack/geoclaw/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/clawpack/geoclaw/statuses/00a8814105893976b4e9e6c7bcf5a090aa454570"}}}}