{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/48","id":54081431,"html_url":"https://github.com/scrapinghub/python-hubstorage/pull/48","diff_url":"https://github.com/scrapinghub/python-hubstorage/pull/48.diff","patch_url":"https://github.com/scrapinghub/python-hubstorage/pull/48.patch","issue_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/48","number":48,"state":"closed","locked":false,"title":"Retry on any ConnectionError exception","user":{"login":"lsenta","id":1136669,"avatar_url":"https://avatars.githubusercontent.com/u/1136669?v=3","gravatar_id":"","url":"https://api.github.com/users/lsenta","html_url":"https://github.com/lsenta","followers_url":"https://api.github.com/users/lsenta/followers","following_url":"https://api.github.com/users/lsenta/following{/other_user}","gists_url":"https://api.github.com/users/lsenta/gists{/gist_id}","starred_url":"https://api.github.com/users/lsenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsenta/subscriptions","organizations_url":"https://api.github.com/users/lsenta/orgs","repos_url":"https://api.github.com/users/lsenta/repos","events_url":"https://api.github.com/users/lsenta/events{/privacy}","received_events_url":"https://api.github.com/users/lsenta/received_events","type":"User","site_admin":false},"body":"So far we checked ConnectionError causes, which appears unnecessary.\r\n\r\nConnectionError may be caused by:\r\nReadTimeoutError, ClosedPoolError, ProtocolError, socket.error\r\n\r\nIt may also be caused by specific cases of MaxRetryError that we won't encounter.\r\n\r\nFixes #47 \r\n\r\nSigned-off-by: lsenta <laurent.senta@gmail.com>","created_at":"2015-12-18T09:33:10Z","updated_at":"2015-12-18T11:40:12Z","closed_at":"2015-12-18T11:40:12Z","merged_at":null,"merge_commit_sha":"30a6e03299060488f2b7b0f8594c955870880de8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/48/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/48/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/48/comments","statuses_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/statuses/c2b587e3f7fe65ab66aec4ed3dc885d730655384","head":{"label":"scrapinghub:fix-47-add-connection-errors","ref":"fix-47-add-connection-errors","sha":"c2b587e3f7fe65ab66aec4ed3dc885d730655384","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":5403123,"name":"python-hubstorage","full_name":"scrapinghub/python-hubstorage","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/python-hubstorage","description":"HubStorage client library","fork":false,"url":"https://api.github.com/repos/scrapinghub/python-hubstorage","forks_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/forks","keys_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/teams","hooks_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/events","assignees_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/tags","blobs_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/subscription","commits_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/merges","archive_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/downloads","issues_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/releases{/id}","created_at":"2012-08-13T18:47:25Z","updated_at":"2015-09-15T14:12:32Z","pushed_at":"2015-12-18T11:38:57Z","git_url":"git://github.com/scrapinghub/python-hubstorage.git","ssh_url":"git@github.com:scrapinghub/python-hubstorage.git","clone_url":"https://github.com/scrapinghub/python-hubstorage.git","svn_url":"https://github.com/scrapinghub/python-hubstorage","homepage":null,"size":260,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":14,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"8cdc483a68d20730f969e771c93ab2655985d0ac","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":5403123,"name":"python-hubstorage","full_name":"scrapinghub/python-hubstorage","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/python-hubstorage","description":"HubStorage client library","fork":false,"url":"https://api.github.com/repos/scrapinghub/python-hubstorage","forks_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/forks","keys_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/teams","hooks_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/events","assignees_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/tags","blobs_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/subscription","commits_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/merges","archive_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/downloads","issues_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/python-hubstorage/releases{/id}","created_at":"2012-08-13T18:47:25Z","updated_at":"2015-09-15T14:12:32Z","pushed_at":"2015-12-18T11:38:57Z","git_url":"git://github.com/scrapinghub/python-hubstorage.git","ssh_url":"git@github.com:scrapinghub/python-hubstorage.git","clone_url":"https://github.com/scrapinghub/python-hubstorage.git","svn_url":"https://github.com/scrapinghub/python-hubstorage","homepage":null,"size":260,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/48"},"html":{"href":"https://github.com/scrapinghub/python-hubstorage/pull/48"},"issue":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/48"},"comments":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/python-hubstorage/statuses/c2b587e3f7fe65ab66aec4ed3dc885d730655384"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":1}}