{"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/secor/pulls/comments/32391545","id":32391545,"diff_hunk":"@@ -54,6 +54,9 @@\n     private ConsumerConnector mConsumerConnector;\n     private ConsumerIterator mIterator;\n     private HashMap<TopicPartition, Long> mLastAccessTime;\n+    private final int mTopicPartitionForgetSeconds;\n+    private final int checkMessagesPerSecond;","path":"src/main/java/com/pinterest/secor/reader/MessageReader.java","position":5,"original_position":5,"commit_id":"b6c32a927c063c234b970b530cd6aae4faf52417","original_commit_id":"b6c32a927c063c234b970b530cd6aae4faf52417","user":{"login":"pgarbacki","id":5000576,"avatar_url":"https://avatars.githubusercontent.com/u/5000576?v=3","gravatar_id":"","url":"https://api.github.com/users/pgarbacki","html_url":"https://github.com/pgarbacki","followers_url":"https://api.github.com/users/pgarbacki/followers","following_url":"https://api.github.com/users/pgarbacki/following{/other_user}","gists_url":"https://api.github.com/users/pgarbacki/gists{/gist_id}","starred_url":"https://api.github.com/users/pgarbacki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgarbacki/subscriptions","organizations_url":"https://api.github.com/users/pgarbacki/orgs","repos_url":"https://api.github.com/users/pgarbacki/repos","events_url":"https://api.github.com/users/pgarbacki/events{/privacy}","received_events_url":"https://api.github.com/users/pgarbacki/received_events","type":"User","site_admin":false},"body":"This should be called mCheckMessagesPerSecond.","created_at":"2015-06-15T04:45:54Z","updated_at":"2015-06-15T04:45:54Z","html_url":"https://github.com/pinterest/secor/pull/99#discussion_r32391545","pull_request_url":"https://api.github.com/repos/pinterest/secor/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/pinterest/secor/pulls/comments/32391545"},"html":{"href":"https://github.com/pinterest/secor/pull/99#discussion_r32391545"},"pull_request":{"href":"https://api.github.com/repos/pinterest/secor/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/pinterest/secor/pulls/99","id":37208398,"html_url":"https://github.com/pinterest/secor/pull/99","diff_url":"https://github.com/pinterest/secor/pull/99.diff","patch_url":"https://github.com/pinterest/secor/pull/99.patch","issue_url":"https://api.github.com/repos/pinterest/secor/issues/99","number":99,"state":"open","locked":false,"title":"performance fix for small messages","user":{"login":"yyejun","id":5640582,"avatar_url":"https://avatars.githubusercontent.com/u/5640582?v=3","gravatar_id":"","url":"https://api.github.com/users/yyejun","html_url":"https://github.com/yyejun","followers_url":"https://api.github.com/users/yyejun/followers","following_url":"https://api.github.com/users/yyejun/following{/other_user}","gists_url":"https://api.github.com/users/yyejun/gists{/gist_id}","starred_url":"https://api.github.com/users/yyejun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyejun/subscriptions","organizations_url":"https://api.github.com/users/yyejun/orgs","repos_url":"https://api.github.com/users/yyejun/repos","events_url":"https://api.github.com/users/yyejun/events{/privacy}","received_events_url":"https://api.github.com/users/yyejun/received_events","type":"User","site_admin":false},"body":"This specific property is reloaded on every message read which cause server performance limited around 20k/s. Cache this as a static value.","created_at":"2015-06-09T00:02:46Z","updated_at":"2015-06-15T04:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8644ce89d9f3a928288af52dcc02828fbe327469","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/secor/pulls/99/commits","review_comments_url":"https://api.github.com/repos/pinterest/secor/pulls/99/comments","review_comment_url":"https://api.github.com/repos/pinterest/secor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pinterest/secor/issues/99/comments","statuses_url":"https://api.github.com/repos/pinterest/secor/statuses/b6c32a927c063c234b970b530cd6aae4faf52417","head":{"label":"yyejun:performance_fix","ref":"performance_fix","sha":"b6c32a927c063c234b970b530cd6aae4faf52417","user":{"login":"yyejun","id":5640582,"avatar_url":"https://avatars.githubusercontent.com/u/5640582?v=3","gravatar_id":"","url":"https://api.github.com/users/yyejun","html_url":"https://github.com/yyejun","followers_url":"https://api.github.com/users/yyejun/followers","following_url":"https://api.github.com/users/yyejun/following{/other_user}","gists_url":"https://api.github.com/users/yyejun/gists{/gist_id}","starred_url":"https://api.github.com/users/yyejun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyejun/subscriptions","organizations_url":"https://api.github.com/users/yyejun/orgs","repos_url":"https://api.github.com/users/yyejun/repos","events_url":"https://api.github.com/users/yyejun/events{/privacy}","received_events_url":"https://api.github.com/users/yyejun/received_events","type":"User","site_admin":false},"repo":{"id":35058012,"name":"secor","full_name":"yyejun/secor","owner":{"login":"yyejun","id":5640582,"avatar_url":"https://avatars.githubusercontent.com/u/5640582?v=3","gravatar_id":"","url":"https://api.github.com/users/yyejun","html_url":"https://github.com/yyejun","followers_url":"https://api.github.com/users/yyejun/followers","following_url":"https://api.github.com/users/yyejun/following{/other_user}","gists_url":"https://api.github.com/users/yyejun/gists{/gist_id}","starred_url":"https://api.github.com/users/yyejun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyejun/subscriptions","organizations_url":"https://api.github.com/users/yyejun/orgs","repos_url":"https://api.github.com/users/yyejun/repos","events_url":"https://api.github.com/users/yyejun/events{/privacy}","received_events_url":"https://api.github.com/users/yyejun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yyejun/secor","description":"Secor is a service implementing Kafka log persistence","fork":true,"url":"https://api.github.com/repos/yyejun/secor","forks_url":"https://api.github.com/repos/yyejun/secor/forks","keys_url":"https://api.github.com/repos/yyejun/secor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yyejun/secor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yyejun/secor/teams","hooks_url":"https://api.github.com/repos/yyejun/secor/hooks","issue_events_url":"https://api.github.com/repos/yyejun/secor/issues/events{/number}","events_url":"https://api.github.com/repos/yyejun/secor/events","assignees_url":"https://api.github.com/repos/yyejun/secor/assignees{/user}","branches_url":"https://api.github.com/repos/yyejun/secor/branches{/branch}","tags_url":"https://api.github.com/repos/yyejun/secor/tags","blobs_url":"https://api.github.com/repos/yyejun/secor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yyejun/secor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yyejun/secor/git/refs{/sha}","trees_url":"https://api.github.com/repos/yyejun/secor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yyejun/secor/statuses/{sha}","languages_url":"https://api.github.com/repos/yyejun/secor/languages","stargazers_url":"https://api.github.com/repos/yyejun/secor/stargazers","contributors_url":"https://api.github.com/repos/yyejun/secor/contributors","subscribers_url":"https://api.github.com/repos/yyejun/secor/subscribers","subscription_url":"https://api.github.com/repos/yyejun/secor/subscription","commits_url":"https://api.github.com/repos/yyejun/secor/commits{/sha}","git_commits_url":"https://api.github.com/repos/yyejun/secor/git/commits{/sha}","comments_url":"https://api.github.com/repos/yyejun/secor/comments{/number}","issue_comment_url":"https://api.github.com/repos/yyejun/secor/issues/comments{/number}","contents_url":"https://api.github.com/repos/yyejun/secor/contents/{+path}","compare_url":"https://api.github.com/repos/yyejun/secor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yyejun/secor/merges","archive_url":"https://api.github.com/repos/yyejun/secor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yyejun/secor/downloads","issues_url":"https://api.github.com/repos/yyejun/secor/issues{/number}","pulls_url":"https://api.github.com/repos/yyejun/secor/pulls{/number}","milestones_url":"https://api.github.com/repos/yyejun/secor/milestones{/number}","notifications_url":"https://api.github.com/repos/yyejun/secor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yyejun/secor/labels{/name}","releases_url":"https://api.github.com/repos/yyejun/secor/releases{/id}","created_at":"2015-05-04T20:33:58Z","updated_at":"2015-05-04T20:33:59Z","pushed_at":"2015-06-13T00:29:57Z","git_url":"git://github.com/yyejun/secor.git","ssh_url":"git@github.com:yyejun/secor.git","clone_url":"https://github.com/yyejun/secor.git","svn_url":"https://github.com/yyejun/secor","homepage":"","size":511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:master","ref":"master","sha":"61d5f05de6cf41123ac8c25ac5138df475b13e9c","user":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":18818296,"name":"secor","full_name":"pinterest/secor","owner":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/secor","description":"Secor is a service implementing Kafka log persistence","fork":false,"url":"https://api.github.com/repos/pinterest/secor","forks_url":"https://api.github.com/repos/pinterest/secor/forks","keys_url":"https://api.github.com/repos/pinterest/secor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/secor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/secor/teams","hooks_url":"https://api.github.com/repos/pinterest/secor/hooks","issue_events_url":"https://api.github.com/repos/pinterest/secor/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/secor/events","assignees_url":"https://api.github.com/repos/pinterest/secor/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/secor/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/secor/tags","blobs_url":"https://api.github.com/repos/pinterest/secor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/secor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/secor/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/secor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/secor/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/secor/languages","stargazers_url":"https://api.github.com/repos/pinterest/secor/stargazers","contributors_url":"https://api.github.com/repos/pinterest/secor/contributors","subscribers_url":"https://api.github.com/repos/pinterest/secor/subscribers","subscription_url":"https://api.github.com/repos/pinterest/secor/subscription","commits_url":"https://api.github.com/repos/pinterest/secor/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/secor/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/secor/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/secor/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinterest/secor/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/secor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/secor/merges","archive_url":"https://api.github.com/repos/pinterest/secor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/secor/downloads","issues_url":"https://api.github.com/repos/pinterest/secor/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/secor/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/secor/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/secor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/secor/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/secor/releases{/id}","created_at":"2014-04-15T22:26:44Z","updated_at":"2015-06-12T16:36:32Z","pushed_at":"2015-06-13T00:29:58Z","git_url":"git://github.com/pinterest/secor.git","ssh_url":"git@github.com:pinterest/secor.git","clone_url":"https://github.com/pinterest/secor.git","svn_url":"https://github.com/pinterest/secor","homepage":"","size":1265,"stargazers_count":351,"watchers_count":351,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":23,"forks":93,"open_issues":23,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/secor/pulls/99"},"html":{"href":"https://github.com/pinterest/secor/pull/99"},"issue":{"href":"https://api.github.com/repos/pinterest/secor/issues/99"},"comments":{"href":"https://api.github.com/repos/pinterest/secor/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/secor/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/secor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pinterest/secor/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/secor/statuses/b6c32a927c063c234b970b530cd6aae4faf52417"}}}}