{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/26586539","id":26586539,"diff_hunk":"@@ -233,6 +281,25 @@ let all (lookup: string -> string option) (list: string -> string list) ~__conte\n \t    Db.VM_guest_metrics.set_other ~__context ~self:gm ~value:other;\n \t    Helpers.call_api_functions ~__context (fun rpc session_id -> Client.Client.VM.update_allowed_operations rpc session_id self);\n \t  end;\n+\t  if(vif_state_cached <> vif_state) then begin","path":"ocaml/xapi/xapi_guest_agent.ml","position":139,"original_position":139,"commit_id":"3752aa5d91132eec9a166fafabc6c879d0293a4c","original_commit_id":"3752aa5d91132eec9a166fafabc6c879d0293a4c","user":{"login":"thomassa","id":605052,"avatar_url":"https://avatars.githubusercontent.com/u/605052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomassa","html_url":"https://github.com/thomassa","followers_url":"https://api.github.com/users/thomassa/followers","following_url":"https://api.github.com/users/thomassa/following{/other_user}","gists_url":"https://api.github.com/users/thomassa/gists{/gist_id}","starred_url":"https://api.github.com/users/thomassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomassa/subscriptions","organizations_url":"https://api.github.com/users/thomassa/orgs","repos_url":"https://api.github.com/users/thomassa/repos","events_url":"https://api.github.com/users/thomassa/events{/privacy}","received_events_url":"https://api.github.com/users/thomassa/received_events","type":"User","site_admin":false},"body":"Is there any reason not to just cache `network_paths_optimized` instead of building up `vif_state` and caching that?\r\n\r\nSame for VBDs.","created_at":"2015-03-17T16:02:26Z","updated_at":"2015-03-17T16:02:26Z","html_url":"https://github.com/xapi-project/xen-api/pull/2160#discussion_r26586539","pull_request_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/26586539"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2160#discussion_r26586539"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160","id":29348486,"html_url":"https://github.com/xapi-project/xen-api/pull/2160","diff_url":"https://github.com/xapi-project/xen-api/pull/2160.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/2160.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2160","number":2160,"state":"open","locked":false,"title":"CP-10531: Update vm_guest_metrics to implement PV drivers update","user":{"login":"huizh","id":6818445,"avatar_url":"https://avatars.githubusercontent.com/u/6818445?v=3","gravatar_id":"","url":"https://api.github.com/users/huizh","html_url":"https://github.com/huizh","followers_url":"https://api.github.com/users/huizh/followers","following_url":"https://api.github.com/users/huizh/following{/other_user}","gists_url":"https://api.github.com/users/huizh/gists{/gist_id}","starred_url":"https://api.github.com/users/huizh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huizh/subscriptions","organizations_url":"https://api.github.com/users/huizh/orgs","repos_url":"https://api.github.com/users/huizh/repos","events_url":"https://api.github.com/users/huizh/events{/privacy}","received_events_url":"https://api.github.com/users/huizh/received_events","type":"User","site_admin":false},"body":"1. Introduce networks_path_optimized and storages_path_optimized flags to vm_guest_metrics.\r\n2. Update the implementation of PV_drivers_up_to_date.\r\n\r\nSigned-off-by: Hui Zhang <hui.zhang@citrix.com>","created_at":"2015-02-16T03:46:43Z","updated_at":"2015-03-17T16:02:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fad0c24eb9ad19ce023fcde29f0d1a99dca63b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2160/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/3752aa5d91132eec9a166fafabc6c879d0293a4c","head":{"label":"huizh:CP-10531","ref":"CP-10531","sha":"3752aa5d91132eec9a166fafabc6c879d0293a4c","user":{"login":"huizh","id":6818445,"avatar_url":"https://avatars.githubusercontent.com/u/6818445?v=3","gravatar_id":"","url":"https://api.github.com/users/huizh","html_url":"https://github.com/huizh","followers_url":"https://api.github.com/users/huizh/followers","following_url":"https://api.github.com/users/huizh/following{/other_user}","gists_url":"https://api.github.com/users/huizh/gists{/gist_id}","starred_url":"https://api.github.com/users/huizh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huizh/subscriptions","organizations_url":"https://api.github.com/users/huizh/orgs","repos_url":"https://api.github.com/users/huizh/repos","events_url":"https://api.github.com/users/huizh/events{/privacy}","received_events_url":"https://api.github.com/users/huizh/received_events","type":"User","site_admin":false},"repo":{"id":17830179,"name":"xen-api","full_name":"huizh/xen-api","owner":{"login":"huizh","id":6818445,"avatar_url":"https://avatars.githubusercontent.com/u/6818445?v=3","gravatar_id":"","url":"https://api.github.com/users/huizh","html_url":"https://github.com/huizh","followers_url":"https://api.github.com/users/huizh/followers","following_url":"https://api.github.com/users/huizh/following{/other_user}","gists_url":"https://api.github.com/users/huizh/gists{/gist_id}","starred_url":"https://api.github.com/users/huizh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huizh/subscriptions","organizations_url":"https://api.github.com/users/huizh/orgs","repos_url":"https://api.github.com/users/huizh/repos","events_url":"https://api.github.com/users/huizh/events{/privacy}","received_events_url":"https://api.github.com/users/huizh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huizh/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/huizh/xen-api","forks_url":"https://api.github.com/repos/huizh/xen-api/forks","keys_url":"https://api.github.com/repos/huizh/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huizh/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huizh/xen-api/teams","hooks_url":"https://api.github.com/repos/huizh/xen-api/hooks","issue_events_url":"https://api.github.com/repos/huizh/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/huizh/xen-api/events","assignees_url":"https://api.github.com/repos/huizh/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/huizh/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/huizh/xen-api/tags","blobs_url":"https://api.github.com/repos/huizh/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huizh/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huizh/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/huizh/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huizh/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/huizh/xen-api/languages","stargazers_url":"https://api.github.com/repos/huizh/xen-api/stargazers","contributors_url":"https://api.github.com/repos/huizh/xen-api/contributors","subscribers_url":"https://api.github.com/repos/huizh/xen-api/subscribers","subscription_url":"https://api.github.com/repos/huizh/xen-api/subscription","commits_url":"https://api.github.com/repos/huizh/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/huizh/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/huizh/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/huizh/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/huizh/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/huizh/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huizh/xen-api/merges","archive_url":"https://api.github.com/repos/huizh/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huizh/xen-api/downloads","issues_url":"https://api.github.com/repos/huizh/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/huizh/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/huizh/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/huizh/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huizh/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/huizh/xen-api/releases{/id}","created_at":"2014-03-17T14:10:27Z","updated_at":"2015-01-05T09:30:19Z","pushed_at":"2015-03-17T05:56:36Z","git_url":"git://github.com/huizh/xen-api.git","ssh_url":"git@github.com:huizh/xen-api.git","clone_url":"https://github.com/huizh/xen-api.git","svn_url":"https://github.com/huizh/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":23221,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"dd109a85f21fd313472a287777da54a7c33921ba","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","created_at":"2010-10-04T10:52:57Z","updated_at":"2015-03-17T11:20:48Z","pushed_at":"2015-03-17T11:20:48Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":37731,"stargazers_count":184,"watchers_count":184,"language":"Standard ML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":29,"forks":135,"open_issues":29,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2160"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2160"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2160/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2160/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/3752aa5d91132eec9a166fafabc6c879d0293a4c"}}}}