{"action":"opened","number":6350,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6350","id":38726037,"html_url":"https://github.com/bitcoin/bitcoin/pull/6350","diff_url":"https://github.com/bitcoin/bitcoin/pull/6350.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6350.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6350","number":6350,"state":"open","locked":false,"title":"add unit tests for the decodescript rpc","user":{"login":"mruddy","id":6440430,"avatar_url":"https://avatars.githubusercontent.com/u/6440430?v=3","gravatar_id":"","url":"https://api.github.com/users/mruddy","html_url":"https://github.com/mruddy","followers_url":"https://api.github.com/users/mruddy/followers","following_url":"https://api.github.com/users/mruddy/following{/other_user}","gists_url":"https://api.github.com/users/mruddy/gists{/gist_id}","starred_url":"https://api.github.com/users/mruddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruddy/subscriptions","organizations_url":"https://api.github.com/users/mruddy/orgs","repos_url":"https://api.github.com/users/mruddy/repos","events_url":"https://api.github.com/users/mruddy/events{/privacy}","received_events_url":"https://api.github.com/users/mruddy/received_events","type":"User","site_admin":false},"body":"Adding unit tests for the \"decodescript\" RPC because:\r\n1) I didn't see any tests specifically for the \"decodescript\" RPC.\r\n2) In adding these, I added a case that will fail until fixed if/when the OP_NOP2 name decode changes to OP_CHECKLOCKTIMEVERIFY are made. Basically a minor follow-up to https://github.com/bitcoin/bitcoin/pull/6124#issuecomment-114599353.\r\n3) These will be good to have if/when I get back around to #5264 and #5392.\r\n","created_at":"2015-06-28T14:10:44Z","updated_at":"2015-06-28T14:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6350/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6350/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6350/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/3fb4ee66fcf4d7bdfa25b4ca4a51917abc57b897","head":{"label":"mruddy:raw-decode-unit-tests","ref":"raw-decode-unit-tests","sha":"3fb4ee66fcf4d7bdfa25b4ca4a51917abc57b897","user":{"login":"mruddy","id":6440430,"avatar_url":"https://avatars.githubusercontent.com/u/6440430?v=3","gravatar_id":"","url":"https://api.github.com/users/mruddy","html_url":"https://github.com/mruddy","followers_url":"https://api.github.com/users/mruddy/followers","following_url":"https://api.github.com/users/mruddy/following{/other_user}","gists_url":"https://api.github.com/users/mruddy/gists{/gist_id}","starred_url":"https://api.github.com/users/mruddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruddy/subscriptions","organizations_url":"https://api.github.com/users/mruddy/orgs","repos_url":"https://api.github.com/users/mruddy/repos","events_url":"https://api.github.com/users/mruddy/events{/privacy}","received_events_url":"https://api.github.com/users/mruddy/received_events","type":"User","site_admin":false},"repo":{"id":26165777,"name":"bitcoin","full_name":"mruddy/bitcoin","owner":{"login":"mruddy","id":6440430,"avatar_url":"https://avatars.githubusercontent.com/u/6440430?v=3","gravatar_id":"","url":"https://api.github.com/users/mruddy","html_url":"https://github.com/mruddy","followers_url":"https://api.github.com/users/mruddy/followers","following_url":"https://api.github.com/users/mruddy/following{/other_user}","gists_url":"https://api.github.com/users/mruddy/gists{/gist_id}","starred_url":"https://api.github.com/users/mruddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruddy/subscriptions","organizations_url":"https://api.github.com/users/mruddy/orgs","repos_url":"https://api.github.com/users/mruddy/repos","events_url":"https://api.github.com/users/mruddy/events{/privacy}","received_events_url":"https://api.github.com/users/mruddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mruddy/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/mruddy/bitcoin","forks_url":"https://api.github.com/repos/mruddy/bitcoin/forks","keys_url":"https://api.github.com/repos/mruddy/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruddy/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruddy/bitcoin/teams","hooks_url":"https://api.github.com/repos/mruddy/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/mruddy/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/mruddy/bitcoin/events","assignees_url":"https://api.github.com/repos/mruddy/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/mruddy/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/mruddy/bitcoin/tags","blobs_url":"https://api.github.com/repos/mruddy/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruddy/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruddy/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruddy/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruddy/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/mruddy/bitcoin/languages","stargazers_url":"https://api.github.com/repos/mruddy/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/mruddy/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/mruddy/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/mruddy/bitcoin/subscription","commits_url":"https://api.github.com/repos/mruddy/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruddy/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruddy/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruddy/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mruddy/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/mruddy/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruddy/bitcoin/merges","archive_url":"https://api.github.com/repos/mruddy/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruddy/bitcoin/downloads","issues_url":"https://api.github.com/repos/mruddy/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/mruddy/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/mruddy/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/mruddy/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruddy/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/mruddy/bitcoin/releases{/id}","created_at":"2014-11-04T11:20:28Z","updated_at":"2015-04-21T00:22:28Z","pushed_at":"2015-06-28T14:08:31Z","git_url":"git://github.com/mruddy/bitcoin.git","ssh_url":"git@github.com:mruddy/bitcoin.git","clone_url":"https://github.com/mruddy/bitcoin.git","svn_url":"https://github.com/mruddy/bitcoin","homepage":"https://bitcoin.org/en/download","size":50172,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"24f24896d602bef3323c5ff66bbccc92448e89d5","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-06-28T03:08:43Z","pushed_at":"2015-06-28T09:36:17Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":130347,"stargazers_count":7071,"watchers_count":7071,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4927,"mirror_url":null,"open_issues_count":432,"forks":4927,"open_issues":432,"watchers":7071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6350"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6350"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6350"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6350/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6350/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6350/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/3fb4ee66fcf4d7bdfa25b4ca4a51917abc57b897"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":94,"deletions":0,"changed_files":1}}