{"action":"created","issue":{"url":"https://api.github.com/repos/rails/actioncable/issues/49","labels_url":"https://api.github.com/repos/rails/actioncable/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/rails/actioncable/issues/49/comments","events_url":"https://api.github.com/repos/rails/actioncable/issues/49/events","html_url":"https://github.com/rails/actioncable/pull/49","id":98235424,"number":49,"title":"Fixes test failure in ActionCable::Channel::BroadcastingTest when run by itself","user":{"login":"jasondew","id":2415,"avatar_url":"https://avatars.githubusercontent.com/u/2415?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondew","html_url":"https://github.com/jasondew","followers_url":"https://api.github.com/users/jasondew/followers","following_url":"https://api.github.com/users/jasondew/following{/other_user}","gists_url":"https://api.github.com/users/jasondew/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondew/subscriptions","organizations_url":"https://api.github.com/users/jasondew/orgs","repos_url":"https://api.github.com/users/jasondew/repos","events_url":"https://api.github.com/users/jasondew/events{/privacy}","received_events_url":"https://api.github.com/users/jasondew/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-30T18:47:19Z","updated_at":"2015-07-30T19:24:16Z","closed_at":"2015-07-30T18:59:12Z","pull_request":{"url":"https://api.github.com/repos/rails/actioncable/pulls/49","html_url":"https://github.com/rails/actioncable/pull/49","diff_url":"https://github.com/rails/actioncable/pull/49.diff","patch_url":"https://github.com/rails/actioncable/pull/49.patch"},"body":"Here's the test output currently:\r\n\r\n```\r\n$ ruby -Ilib:test -rtest_helper test/channel/broadcasting_test.rb\r\nRun options: --seed 9529\r\n\r\n# Running:\r\n\r\nEEEE\r\n\r\nFinished in 0.002903s, 1378.0449 runs/s, 0.0000 assertions/s.\r\n\r\n  1) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasting_for_with_a_string:\r\nNoMethodError: undefined method `to_param' for \"hello\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:21:in `broadcasting_for'\r\n    test/channel/broadcasting_test.rb:27:in `block in <class:BroadcastingTest>'\r\n\r\n\r\n  2) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasting_for_with_an_array:\r\nNoMethodError: undefined method `to_param' for \"Room#1-Campfire\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/test/stubs/room.rb:14:in `to_gid_param'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:19:in `broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `block in broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `map'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `broadcasting_for'\r\n    test/channel/broadcasting_test.rb:23:in `block in <class:BroadcastingTest>'\r\n\r\n\r\n  3) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasting_for_with_an_object:\r\nNoMethodError: undefined method `to_param' for \"Room#1-Campfire\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/test/stubs/room.rb:14:in `to_gid_param'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:19:in `broadcasting_for'\r\n    test/channel/broadcasting_test.rb:19:in `block in <class:BroadcastingTest>'\r\n\r\n\r\n  4) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasts_to:\r\nNoMethodError: undefined method `to_param' for \"action_cable:channel:broadcasting_test:chat\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:21:in `broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `block in broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `map'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:11:in `broadcast_to'\r\n    test/channel/broadcasting_test.rb:15:in `block in <class:BroadcastingTest>'\r\n\r\n4 runs, 0 assertions, 0 failures, 4 errors, 0 skips\r\n```\r\n\r\nI haven't investigated further to find out where/how we're requiring this when the whole suite is run, but this fixes things up."},"comment":{"url":"https://api.github.com/repos/rails/actioncable/issues/comments/126445213","html_url":"https://github.com/rails/actioncable/pull/49#issuecomment-126445213","issue_url":"https://api.github.com/repos/rails/actioncable/issues/49","id":126445213,"user":{"login":"jasondew","id":2415,"avatar_url":"https://avatars.githubusercontent.com/u/2415?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondew","html_url":"https://github.com/jasondew","followers_url":"https://api.github.com/users/jasondew/followers","following_url":"https://api.github.com/users/jasondew/following{/other_user}","gists_url":"https://api.github.com/users/jasondew/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondew/subscriptions","organizations_url":"https://api.github.com/users/jasondew/orgs","repos_url":"https://api.github.com/users/jasondew/repos","events_url":"https://api.github.com/users/jasondew/events{/privacy}","received_events_url":"https://api.github.com/users/jasondew/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T19:24:16Z","updated_at":"2015-07-30T19:24:16Z","body":"Happy to help!"}}