{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/32138644","id":32138644,"diff_hunk":"@@ -65,18 +67,19 @@\n  * @author Mark Pollack\n  * @author Stephane Maldini\n  */\n-public class BroadcasterMessageHandler extends AbstractMessageProducingHandler  implements DisposableBean {\n+public class BroadcasterMessageHandler extends AbstractMessageProducingHandler implements DisposableBean {\n \n     protected final Log logger = LogFactory.getLog(getClass());\n \n-    private final RingBufferProcessor<Object> stream;\n-\n-    @SuppressWarnings(\"rawtypes\")\n-    private final Processor reactorProcessor;\n+    private final RingBufferProcessor<Object> ringBufferProcessor;\n \n     private final Class<?> inputType;\n \n-    private Subscription processorSubscription;\n+    private int stopTimeout = 5000;\n+\n+    private int ringBufferSize = 8192;","path":"spring-xd-reactor/src/main/java/org/springframework/xd/reactor/BroadcasterMessageHandler.java","position":50,"original_position":50,"commit_id":"82a3d43ed8795288decfb5910177c254a06eab06","original_commit_id":"82a3d43ed8795288decfb5910177c254a06eab06","user":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"body":"will create AbstractReactorMessageHandler to ensure consistent handling and no simple code dup for environment, stopTimeout, and ringBuffer fields.","created_at":"2015-06-10T16:47:48Z","updated_at":"2015-06-10T16:47:48Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1708#discussion_r32138644","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/32138644"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1708#discussion_r32138644"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708","id":37375691,"html_url":"https://github.com/spring-projects/spring-xd/pull/1708","diff_url":"https://github.com/spring-projects/spring-xd/pull/1708.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1708.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1708","number":1708,"state":"open","locked":false,"title":"[Sprint: 51][1.2 GA] XD-3114 Ensure proper lifecycle shutdown of Reactor processor","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"- proper lifecycle shutdown\r\n- add buffer size configuration","created_at":"2015-06-10T16:07:08Z","updated_at":"2015-06-10T16:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0e6744caa5f7ee858b4608a7e27d5060cbabb0f","assignee":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1708/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/82a3d43ed8795288decfb5910177c254a06eab06","head":{"label":"mbogoevici:XD-3114c","ref":"XD-3114c","sha":"82a3d43ed8795288decfb5910177c254a06eab06","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"repo":{"id":21505495,"name":"spring-xd","full_name":"mbogoevici/spring-xd","owner":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbogoevici/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/mbogoevici/spring-xd","forks_url":"https://api.github.com/repos/mbogoevici/spring-xd/forks","keys_url":"https://api.github.com/repos/mbogoevici/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbogoevici/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbogoevici/spring-xd/teams","hooks_url":"https://api.github.com/repos/mbogoevici/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/mbogoevici/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/mbogoevici/spring-xd/events","assignees_url":"https://api.github.com/repos/mbogoevici/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/mbogoevici/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/mbogoevici/spring-xd/tags","blobs_url":"https://api.github.com/repos/mbogoevici/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbogoevici/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbogoevici/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbogoevici/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbogoevici/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/mbogoevici/spring-xd/languages","stargazers_url":"https://api.github.com/repos/mbogoevici/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/mbogoevici/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/mbogoevici/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/mbogoevici/spring-xd/subscription","commits_url":"https://api.github.com/repos/mbogoevici/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbogoevici/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbogoevici/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbogoevici/spring-xd/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbogoevici/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/mbogoevici/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbogoevici/spring-xd/merges","archive_url":"https://api.github.com/repos/mbogoevici/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbogoevici/spring-xd/downloads","issues_url":"https://api.github.com/repos/mbogoevici/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/mbogoevici/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/mbogoevici/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/mbogoevici/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbogoevici/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/mbogoevici/spring-xd/releases{/id}","created_at":"2014-07-04T18:54:28Z","updated_at":"2015-05-01T14:11:42Z","pushed_at":"2015-06-10T16:09:57Z","git_url":"git://github.com/mbogoevici/spring-xd.git","ssh_url":"git@github.com:mbogoevici/spring-xd.git","clone_url":"https://github.com/mbogoevici/spring-xd.git","svn_url":"https://github.com/mbogoevici/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":25193,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"dec08262dfe945ada0b6ebb0cd5da9c91484e67b","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2015-06-10T15:58:05Z","pushed_at":"2015-06-10T16:10:05Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":60797,"stargazers_count":269,"watchers_count":269,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":213,"mirror_url":null,"open_issues_count":36,"forks":213,"open_issues":36,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1708"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1708"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1708/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1708/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/82a3d43ed8795288decfb5910177c254a06eab06"}}}}