{"action":"created","comment":{"url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments/42485142","id":42485142,"diff_hunk":"@@ -494,14 +484,14 @@ def cleanNotifier(notifier):\n #############################################################################\n # PDP\n #############################################################################\n-getPDPTemperature = _STATUSFUNC(\"getPDPTemperature\", C.c_double)","path":"hal-base/hal/functions.py","position":48,"original_position":48,"commit_id":"1bb7aeefd786a1b6b87830ca100f5893124a6080","original_commit_id":"1bb7aeefd786a1b6b87830ca100f5893124a6080","user":{"login":"computer-whisperer","id":3778956,"avatar_url":"https://avatars.githubusercontent.com/u/3778956?v=3","gravatar_id":"","url":"https://api.github.com/users/computer-whisperer","html_url":"https://github.com/computer-whisperer","followers_url":"https://api.github.com/users/computer-whisperer/followers","following_url":"https://api.github.com/users/computer-whisperer/following{/other_user}","gists_url":"https://api.github.com/users/computer-whisperer/gists{/gist_id}","starred_url":"https://api.github.com/users/computer-whisperer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computer-whisperer/subscriptions","organizations_url":"https://api.github.com/users/computer-whisperer/orgs","repos_url":"https://api.github.com/users/computer-whisperer/repos","events_url":"https://api.github.com/users/computer-whisperer/events{/privacy}","received_events_url":"https://api.github.com/users/computer-whisperer/received_events","type":"User","site_admin":false},"body":"Don't you need to fix the callers of these functions in both the java and c++ wpilib? Not just the HAL api?","created_at":"2015-10-20T11:51:25Z","updated_at":"2015-10-20T11:51:25Z","html_url":"https://github.com/robotpy/robotpy-wpilib/pull/154#discussion_r42485142","pull_request_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments/42485142"},"html":{"href":"https://github.com/robotpy/robotpy-wpilib/pull/154#discussion_r42485142"},"pull_request":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154","id":47997899,"html_url":"https://github.com/robotpy/robotpy-wpilib/pull/154","diff_url":"https://github.com/robotpy/robotpy-wpilib/pull/154.diff","patch_url":"https://github.com/robotpy/robotpy-wpilib/pull/154.patch","issue_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/154","number":154,"state":"open","locked":false,"title":"Adjusting for upstream HAL API updates, needs more work.","user":{"login":"computer-whisperer","id":3778956,"avatar_url":"https://avatars.githubusercontent.com/u/3778956?v=3","gravatar_id":"","url":"https://api.github.com/users/computer-whisperer","html_url":"https://github.com/computer-whisperer","followers_url":"https://api.github.com/users/computer-whisperer/followers","following_url":"https://api.github.com/users/computer-whisperer/following{/other_user}","gists_url":"https://api.github.com/users/computer-whisperer/gists{/gist_id}","starred_url":"https://api.github.com/users/computer-whisperer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computer-whisperer/subscriptions","organizations_url":"https://api.github.com/users/computer-whisperer/orgs","repos_url":"https://api.github.com/users/computer-whisperer/repos","events_url":"https://api.github.com/users/computer-whisperer/events{/privacy}","received_events_url":"https://api.github.com/users/computer-whisperer/received_events","type":"User","site_admin":false},"body":"This is not ready to merge yet, I just needed a place to discuss stuff with the group.\r\n\r\nAlso, feel free to double check any of my work.","created_at":"2015-10-17T23:37:16Z","updated_at":"2015-10-20T11:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49690bb2dc95198b8fa39370f4509e17f1bb3644","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154/commits","review_comments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154/comments","review_comment_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/154/comments","statuses_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/statuses/1bb7aeefd786a1b6b87830ca100f5893124a6080","head":{"label":"computer-whisperer:hal_update","ref":"hal_update","sha":"1bb7aeefd786a1b6b87830ca100f5893124a6080","user":{"login":"computer-whisperer","id":3778956,"avatar_url":"https://avatars.githubusercontent.com/u/3778956?v=3","gravatar_id":"","url":"https://api.github.com/users/computer-whisperer","html_url":"https://github.com/computer-whisperer","followers_url":"https://api.github.com/users/computer-whisperer/followers","following_url":"https://api.github.com/users/computer-whisperer/following{/other_user}","gists_url":"https://api.github.com/users/computer-whisperer/gists{/gist_id}","starred_url":"https://api.github.com/users/computer-whisperer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computer-whisperer/subscriptions","organizations_url":"https://api.github.com/users/computer-whisperer/orgs","repos_url":"https://api.github.com/users/computer-whisperer/repos","events_url":"https://api.github.com/users/computer-whisperer/events{/privacy}","received_events_url":"https://api.github.com/users/computer-whisperer/received_events","type":"User","site_admin":false},"repo":{"id":44108402,"name":"robotpy-wpilib","full_name":"computer-whisperer/robotpy-wpilib","owner":{"login":"computer-whisperer","id":3778956,"avatar_url":"https://avatars.githubusercontent.com/u/3778956?v=3","gravatar_id":"","url":"https://api.github.com/users/computer-whisperer","html_url":"https://github.com/computer-whisperer","followers_url":"https://api.github.com/users/computer-whisperer/followers","following_url":"https://api.github.com/users/computer-whisperer/following{/other_user}","gists_url":"https://api.github.com/users/computer-whisperer/gists{/gist_id}","starred_url":"https://api.github.com/users/computer-whisperer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/computer-whisperer/subscriptions","organizations_url":"https://api.github.com/users/computer-whisperer/orgs","repos_url":"https://api.github.com/users/computer-whisperer/repos","events_url":"https://api.github.com/users/computer-whisperer/events{/privacy}","received_events_url":"https://api.github.com/users/computer-whisperer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/computer-whisperer/robotpy-wpilib","description":"Pure python implementation of WPILib for FIRST Robotics Competition (FRC)","fork":true,"url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib","forks_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/forks","keys_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/teams","hooks_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/hooks","issue_events_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/issues/events{/number}","events_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/events","assignees_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/assignees{/user}","branches_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/branches{/branch}","tags_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/tags","blobs_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/git/refs{/sha}","trees_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/statuses/{sha}","languages_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/languages","stargazers_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/stargazers","contributors_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/contributors","subscribers_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/subscribers","subscription_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/subscription","commits_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/commits{/sha}","git_commits_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/git/commits{/sha}","comments_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/comments{/number}","issue_comment_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/issues/comments{/number}","contents_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/contents/{+path}","compare_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/merges","archive_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/downloads","issues_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/issues{/number}","pulls_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/pulls{/number}","milestones_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/milestones{/number}","notifications_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/labels{/name}","releases_url":"https://api.github.com/repos/computer-whisperer/robotpy-wpilib/releases{/id}","created_at":"2015-10-12T13:15:51Z","updated_at":"2015-10-12T13:15:52Z","pushed_at":"2015-10-17T23:34:50Z","git_url":"git://github.com/computer-whisperer/robotpy-wpilib.git","ssh_url":"git@github.com:computer-whisperer/robotpy-wpilib.git","clone_url":"https://github.com/computer-whisperer/robotpy-wpilib.git","svn_url":"https://github.com/computer-whisperer/robotpy-wpilib","homepage":"http://robotpy.github.io","size":898,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotpy:master","ref":"master","sha":"7fe40f839243a5aa01d526597e3e87ade7d1a643","user":{"login":"robotpy","id":640276,"avatar_url":"https://avatars.githubusercontent.com/u/640276?v=3","gravatar_id":"","url":"https://api.github.com/users/robotpy","html_url":"https://github.com/robotpy","followers_url":"https://api.github.com/users/robotpy/followers","following_url":"https://api.github.com/users/robotpy/following{/other_user}","gists_url":"https://api.github.com/users/robotpy/gists{/gist_id}","starred_url":"https://api.github.com/users/robotpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotpy/subscriptions","organizations_url":"https://api.github.com/users/robotpy/orgs","repos_url":"https://api.github.com/users/robotpy/repos","events_url":"https://api.github.com/users/robotpy/events{/privacy}","received_events_url":"https://api.github.com/users/robotpy/received_events","type":"Organization","site_admin":false},"repo":{"id":24757484,"name":"robotpy-wpilib","full_name":"robotpy/robotpy-wpilib","owner":{"login":"robotpy","id":640276,"avatar_url":"https://avatars.githubusercontent.com/u/640276?v=3","gravatar_id":"","url":"https://api.github.com/users/robotpy","html_url":"https://github.com/robotpy","followers_url":"https://api.github.com/users/robotpy/followers","following_url":"https://api.github.com/users/robotpy/following{/other_user}","gists_url":"https://api.github.com/users/robotpy/gists{/gist_id}","starred_url":"https://api.github.com/users/robotpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotpy/subscriptions","organizations_url":"https://api.github.com/users/robotpy/orgs","repos_url":"https://api.github.com/users/robotpy/repos","events_url":"https://api.github.com/users/robotpy/events{/privacy}","received_events_url":"https://api.github.com/users/robotpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotpy/robotpy-wpilib","description":"Pure python implementation of WPILib for FIRST Robotics Competition (FRC)","fork":false,"url":"https://api.github.com/repos/robotpy/robotpy-wpilib","forks_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/forks","keys_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/teams","hooks_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/hooks","issue_events_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/events{/number}","events_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/events","assignees_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/assignees{/user}","branches_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/branches{/branch}","tags_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/tags","blobs_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/statuses/{sha}","languages_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/languages","stargazers_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/stargazers","contributors_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/contributors","subscribers_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/subscribers","subscription_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/subscription","commits_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/contents/{+path}","compare_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/merges","archive_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/downloads","issues_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues{/number}","pulls_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls{/number}","milestones_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/milestones{/number}","notifications_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/labels{/name}","releases_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/releases{/id}","created_at":"2014-10-03T12:25:01Z","updated_at":"2015-06-08T21:47:53Z","pushed_at":"2015-10-17T23:37:16Z","git_url":"git://github.com/robotpy/robotpy-wpilib.git","ssh_url":"git@github.com:robotpy/robotpy-wpilib.git","clone_url":"https://github.com/robotpy/robotpy-wpilib.git","svn_url":"https://github.com/robotpy/robotpy-wpilib","homepage":"http://robotpy.github.io","size":2910,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":21,"forks":10,"open_issues":21,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154"},"html":{"href":"https://github.com/robotpy/robotpy-wpilib/pull/154"},"issue":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/154"},"comments":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/statuses/1bb7aeefd786a1b6b87830ca100f5893124a6080"}}}}