{"action":"created","comment":{"url":"https://api.github.com/repos/sdbg/sdbg/pulls/comments/29660908","id":29660908,"diff_hunk":"@@ -69,6 +69,10 @@ protected ILaunchConfigurationType getConfigurationType() {\n \n   @Override\n   protected void launch(IResource resource, String mode) {\n+    launch(resource, mode, null);\n+  }\n+\n+  public void launch(IResource resource, String mode, String url) {","path":"com.github.sdbg.debug.ui/src/com/github/sdbg/debug/ui/internal/chrome/ChromeLaunchShortcut.java","position":7,"original_position":7,"commit_id":"07bd9b04b2f6086ec79752fdabf855ca8108a66c","original_commit_id":"07bd9b04b2f6086ec79752fdabf855ca8108a66c","user":{"login":"ivmarkov","id":2607589,"avatar_url":"https://avatars.githubusercontent.com/u/2607589?v=3","gravatar_id":"","url":"https://api.github.com/users/ivmarkov","html_url":"https://github.com/ivmarkov","followers_url":"https://api.github.com/users/ivmarkov/followers","following_url":"https://api.github.com/users/ivmarkov/following{/other_user}","gists_url":"https://api.github.com/users/ivmarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmarkov/subscriptions","organizations_url":"https://api.github.com/users/ivmarkov/orgs","repos_url":"https://api.github.com/users/ivmarkov/repos","events_url":"https://api.github.com/users/ivmarkov/events{/privacy}","received_events_url":"https://api.github.com/users/ivmarkov/received_events","type":"User","site_admin":false},"body":"ChromeLaunchShortCut.java is a code inherited from Dart and not (currently) used in SDBG.\r\n\r\nBasically, it implements a standard Eclipse ILaunchShortcut extension point. From a user perspective, this allows you  to right-click an HTML file and launch a DART debugging session for it (\"Debug as -> DART application\"). For launching, the specially crafted Chrome which has the DartVM is used but that's a detail of course.\r\n\r\nNow, we want the same behavior for GWT, but the GWT plugin itself already has the GWT \"Web Application\" ILaunchShortcut implementation(s), that launch the GWT SDM server. I guess you want to call into SDBG *from there* (or from a new GWT Web App launcher implementation).\r\n\r\nWit the above said, I don't think we want to base ChromeLaunchShortcutExt on top of the dead ChromeLaunchShortcut, which - even worse - implements the ILaunchShortcut API which has no notion of \"URL\". \r\n\r\nHow about:\r\n- Renaming IChromeLaunchShortcutExt to just IChromeLaunch?\r\n- Renaming ChromeLaunchShortcutExt to ChromeLaunchImpl and no longer inheriting from ChromeLaunchShortcut?\r\n- Copying the useful bits and pieces from ChromeLaunchShortcut directly into ChromeLaunchImpl?\r\n","created_at":"2015-05-05T11:34:54Z","updated_at":"2015-05-05T11:34:54Z","html_url":"https://github.com/sdbg/sdbg/pull/123#discussion_r29660908","pull_request_url":"https://api.github.com/repos/sdbg/sdbg/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/comments/29660908"},"html":{"href":"https://github.com/sdbg/sdbg/pull/123#discussion_r29660908"},"pull_request":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/sdbg/sdbg/pulls/123","id":34608819,"html_url":"https://github.com/sdbg/sdbg/pull/123","diff_url":"https://github.com/sdbg/sdbg/pull/123.diff","patch_url":"https://github.com/sdbg/sdbg/pull/123.patch","issue_url":"https://api.github.com/repos/sdbg/sdbg/issues/123","number":123,"state":"open","locked":false,"title":"Adding launcher extension to launch from another plugin.","user":{"login":"branflake2267","id":1326504,"avatar_url":"https://avatars.githubusercontent.com/u/1326504?v=3","gravatar_id":"","url":"https://api.github.com/users/branflake2267","html_url":"https://github.com/branflake2267","followers_url":"https://api.github.com/users/branflake2267/followers","following_url":"https://api.github.com/users/branflake2267/following{/other_user}","gists_url":"https://api.github.com/users/branflake2267/gists{/gist_id}","starred_url":"https://api.github.com/users/branflake2267/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branflake2267/subscriptions","organizations_url":"https://api.github.com/users/branflake2267/orgs","repos_url":"https://api.github.com/users/branflake2267/repos","events_url":"https://api.github.com/users/branflake2267/events{/privacy}","received_events_url":"https://api.github.com/users/branflake2267/received_events","type":"User","site_admin":false},"body":"![screen shot 2015-05-03 at 12 23 25 pm](https://cloud.githubusercontent.com/assets/1326504/7447211/431a18ce-f1a7-11e4-90bb-1a27f39b2363.png)\r\n![screen shot 2015-05-03 at 3 05 21 pm](https://cloud.githubusercontent.com/assets/1326504/7447212/445cf7ec-f1a7-11e4-9fdc-eb49edad10a8.png)\r\n","created_at":"2015-05-03T22:15:49Z","updated_at":"2015-05-05T11:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b670641280421c15a11cc3d56164e9573f3c9006","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sdbg/sdbg/pulls/123/commits","review_comments_url":"https://api.github.com/repos/sdbg/sdbg/pulls/123/comments","review_comment_url":"https://api.github.com/repos/sdbg/sdbg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdbg/sdbg/issues/123/comments","statuses_url":"https://api.github.com/repos/sdbg/sdbg/statuses/07bd9b04b2f6086ec79752fdabf855ca8108a66c","head":{"label":"branflake2267:brandon-gwtplugin","ref":"brandon-gwtplugin","sha":"07bd9b04b2f6086ec79752fdabf855ca8108a66c","user":{"login":"branflake2267","id":1326504,"avatar_url":"https://avatars.githubusercontent.com/u/1326504?v=3","gravatar_id":"","url":"https://api.github.com/users/branflake2267","html_url":"https://github.com/branflake2267","followers_url":"https://api.github.com/users/branflake2267/followers","following_url":"https://api.github.com/users/branflake2267/following{/other_user}","gists_url":"https://api.github.com/users/branflake2267/gists{/gist_id}","starred_url":"https://api.github.com/users/branflake2267/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branflake2267/subscriptions","organizations_url":"https://api.github.com/users/branflake2267/orgs","repos_url":"https://api.github.com/users/branflake2267/repos","events_url":"https://api.github.com/users/branflake2267/events{/privacy}","received_events_url":"https://api.github.com/users/branflake2267/received_events","type":"User","site_admin":false},"repo":{"id":28004923,"name":"sdbg","full_name":"branflake2267/sdbg","owner":{"login":"branflake2267","id":1326504,"avatar_url":"https://avatars.githubusercontent.com/u/1326504?v=3","gravatar_id":"","url":"https://api.github.com/users/branflake2267","html_url":"https://github.com/branflake2267","followers_url":"https://api.github.com/users/branflake2267/followers","following_url":"https://api.github.com/users/branflake2267/following{/other_user}","gists_url":"https://api.github.com/users/branflake2267/gists{/gist_id}","starred_url":"https://api.github.com/users/branflake2267/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branflake2267/subscriptions","organizations_url":"https://api.github.com/users/branflake2267/orgs","repos_url":"https://api.github.com/users/branflake2267/repos","events_url":"https://api.github.com/users/branflake2267/events{/privacy}","received_events_url":"https://api.github.com/users/branflake2267/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/branflake2267/sdbg","description":"Eclipse debugger for GWT SuperDevMode","fork":true,"url":"https://api.github.com/repos/branflake2267/sdbg","forks_url":"https://api.github.com/repos/branflake2267/sdbg/forks","keys_url":"https://api.github.com/repos/branflake2267/sdbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/branflake2267/sdbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/branflake2267/sdbg/teams","hooks_url":"https://api.github.com/repos/branflake2267/sdbg/hooks","issue_events_url":"https://api.github.com/repos/branflake2267/sdbg/issues/events{/number}","events_url":"https://api.github.com/repos/branflake2267/sdbg/events","assignees_url":"https://api.github.com/repos/branflake2267/sdbg/assignees{/user}","branches_url":"https://api.github.com/repos/branflake2267/sdbg/branches{/branch}","tags_url":"https://api.github.com/repos/branflake2267/sdbg/tags","blobs_url":"https://api.github.com/repos/branflake2267/sdbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/branflake2267/sdbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/branflake2267/sdbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/branflake2267/sdbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/branflake2267/sdbg/statuses/{sha}","languages_url":"https://api.github.com/repos/branflake2267/sdbg/languages","stargazers_url":"https://api.github.com/repos/branflake2267/sdbg/stargazers","contributors_url":"https://api.github.com/repos/branflake2267/sdbg/contributors","subscribers_url":"https://api.github.com/repos/branflake2267/sdbg/subscribers","subscription_url":"https://api.github.com/repos/branflake2267/sdbg/subscription","commits_url":"https://api.github.com/repos/branflake2267/sdbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/branflake2267/sdbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/branflake2267/sdbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/branflake2267/sdbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/branflake2267/sdbg/contents/{+path}","compare_url":"https://api.github.com/repos/branflake2267/sdbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/branflake2267/sdbg/merges","archive_url":"https://api.github.com/repos/branflake2267/sdbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/branflake2267/sdbg/downloads","issues_url":"https://api.github.com/repos/branflake2267/sdbg/issues{/number}","pulls_url":"https://api.github.com/repos/branflake2267/sdbg/pulls{/number}","milestones_url":"https://api.github.com/repos/branflake2267/sdbg/milestones{/number}","notifications_url":"https://api.github.com/repos/branflake2267/sdbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/branflake2267/sdbg/labels{/name}","releases_url":"https://api.github.com/repos/branflake2267/sdbg/releases{/id}","created_at":"2014-12-14T19:19:23Z","updated_at":"2014-12-14T19:19:26Z","pushed_at":"2015-05-05T02:20:45Z","git_url":"git://github.com/branflake2267/sdbg.git","ssh_url":"git@github.com:branflake2267/sdbg.git","clone_url":"https://github.com/branflake2267/sdbg.git","svn_url":"https://github.com/branflake2267/sdbg","homepage":"http://sdbg.github.io","size":666948,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sdbg:master","ref":"master","sha":"ccd6e43621015a66b58b562d7112112c1d5b30fe","user":{"login":"sdbg","id":6445481,"avatar_url":"https://avatars.githubusercontent.com/u/6445481?v=3","gravatar_id":"","url":"https://api.github.com/users/sdbg","html_url":"https://github.com/sdbg","followers_url":"https://api.github.com/users/sdbg/followers","following_url":"https://api.github.com/users/sdbg/following{/other_user}","gists_url":"https://api.github.com/users/sdbg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdbg/subscriptions","organizations_url":"https://api.github.com/users/sdbg/orgs","repos_url":"https://api.github.com/users/sdbg/repos","events_url":"https://api.github.com/users/sdbg/events{/privacy}","received_events_url":"https://api.github.com/users/sdbg/received_events","type":"Organization","site_admin":false},"repo":{"id":16054725,"name":"sdbg","full_name":"sdbg/sdbg","owner":{"login":"sdbg","id":6445481,"avatar_url":"https://avatars.githubusercontent.com/u/6445481?v=3","gravatar_id":"","url":"https://api.github.com/users/sdbg","html_url":"https://github.com/sdbg","followers_url":"https://api.github.com/users/sdbg/followers","following_url":"https://api.github.com/users/sdbg/following{/other_user}","gists_url":"https://api.github.com/users/sdbg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdbg/subscriptions","organizations_url":"https://api.github.com/users/sdbg/orgs","repos_url":"https://api.github.com/users/sdbg/repos","events_url":"https://api.github.com/users/sdbg/events{/privacy}","received_events_url":"https://api.github.com/users/sdbg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdbg/sdbg","description":"Eclipse debugger for GWT SuperDevMode","fork":false,"url":"https://api.github.com/repos/sdbg/sdbg","forks_url":"https://api.github.com/repos/sdbg/sdbg/forks","keys_url":"https://api.github.com/repos/sdbg/sdbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdbg/sdbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdbg/sdbg/teams","hooks_url":"https://api.github.com/repos/sdbg/sdbg/hooks","issue_events_url":"https://api.github.com/repos/sdbg/sdbg/issues/events{/number}","events_url":"https://api.github.com/repos/sdbg/sdbg/events","assignees_url":"https://api.github.com/repos/sdbg/sdbg/assignees{/user}","branches_url":"https://api.github.com/repos/sdbg/sdbg/branches{/branch}","tags_url":"https://api.github.com/repos/sdbg/sdbg/tags","blobs_url":"https://api.github.com/repos/sdbg/sdbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdbg/sdbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdbg/sdbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdbg/sdbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdbg/sdbg/statuses/{sha}","languages_url":"https://api.github.com/repos/sdbg/sdbg/languages","stargazers_url":"https://api.github.com/repos/sdbg/sdbg/stargazers","contributors_url":"https://api.github.com/repos/sdbg/sdbg/contributors","subscribers_url":"https://api.github.com/repos/sdbg/sdbg/subscribers","subscription_url":"https://api.github.com/repos/sdbg/sdbg/subscription","commits_url":"https://api.github.com/repos/sdbg/sdbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdbg/sdbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdbg/sdbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdbg/sdbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdbg/sdbg/contents/{+path}","compare_url":"https://api.github.com/repos/sdbg/sdbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdbg/sdbg/merges","archive_url":"https://api.github.com/repos/sdbg/sdbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdbg/sdbg/downloads","issues_url":"https://api.github.com/repos/sdbg/sdbg/issues{/number}","pulls_url":"https://api.github.com/repos/sdbg/sdbg/pulls{/number}","milestones_url":"https://api.github.com/repos/sdbg/sdbg/milestones{/number}","notifications_url":"https://api.github.com/repos/sdbg/sdbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdbg/sdbg/labels{/name}","releases_url":"https://api.github.com/repos/sdbg/sdbg/releases{/id}","created_at":"2014-01-19T21:27:11Z","updated_at":"2015-05-02T20:13:50Z","pushed_at":"2015-05-05T02:20:46Z","git_url":"git://github.com/sdbg/sdbg.git","ssh_url":"git@github.com:sdbg/sdbg.git","clone_url":"https://github.com/sdbg/sdbg.git","svn_url":"https://github.com/sdbg/sdbg","homepage":"http://sdbg.github.io","size":666723,"stargazers_count":91,"watchers_count":91,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":21,"forks":11,"open_issues":21,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/123"},"html":{"href":"https://github.com/sdbg/sdbg/pull/123"},"issue":{"href":"https://api.github.com/repos/sdbg/sdbg/issues/123"},"comments":{"href":"https://api.github.com/repos/sdbg/sdbg/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/sdbg/sdbg/statuses/07bd9b04b2f6086ec79752fdabf855ca8108a66c"}}}}