{"action":"created","comment":{"url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/comments/38637401","id":38637401,"diff_hunk":"@@ -3,14 +3,20 @@\n \n import Fiber = require(\"fibers\");\n import Future = require(\"fibers/future\");\n-import errors = require(\"./errors\");\n+// import errors = require(\"./errors\");\n \n-export function run(action: Function) {\n-\tFiber(() => {\n-\t\terrors.installUncaughtExceptionListener();\n+export function run(action: any) {\n+\tif(Fiber.current) {\n+\t\t// Use the already existing fiber, we do not need new one.\n \t\taction();\n-\t\t$injector.dispose();\n-\t\tFuture.assertNoFutureLeftBehind();\n-\t}).run();\n+\t} else {\n+\t\tFiber(() => {\n+\t\t\t// TODO: Think about correct place for this.\n+\t\t\t// errors.installUncaughtExceptionListener();","path":"fiber-bootstrap.ts","position":20,"original_position":20,"commit_id":"42f116d821ddcecb718b1f7a6d71a8f4f83a8654","original_commit_id":"42f116d821ddcecb718b1f7a6d71a8f4f83a8654","user":{"login":"teobugslayer","id":5443453,"avatar_url":"https://avatars.githubusercontent.com/u/5443453?v=3","gravatar_id":"","url":"https://api.github.com/users/teobugslayer","html_url":"https://github.com/teobugslayer","followers_url":"https://api.github.com/users/teobugslayer/followers","following_url":"https://api.github.com/users/teobugslayer/following{/other_user}","gists_url":"https://api.github.com/users/teobugslayer/gists{/gist_id}","starred_url":"https://api.github.com/users/teobugslayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teobugslayer/subscriptions","organizations_url":"https://api.github.com/users/teobugslayer/orgs","repos_url":"https://api.github.com/users/teobugslayer/repos","events_url":"https://api.github.com/users/teobugslayer/events{/privacy}","received_events_url":"https://api.github.com/users/teobugslayer/received_events","type":"User","site_admin":false},"body":"I think we can change errors.installUncaughtExceptionListener to be idempotent, this make it safe to be called many times. Internally, we can use _.once with the code of the existing function. After that,w e can uncomment the currently commented out code.","created_at":"2015-09-03T11:57:01Z","updated_at":"2015-09-03T11:57:01Z","html_url":"https://github.com/telerik/mobile-cli-lib/pull/443#discussion_r38637401","pull_request_url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/comments/38637401"},"html":{"href":"https://github.com/telerik/mobile-cli-lib/pull/443#discussion_r38637401"},"pull_request":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443","id":43369229,"html_url":"https://github.com/telerik/mobile-cli-lib/pull/443","diff_url":"https://github.com/telerik/mobile-cli-lib/pull/443.diff","patch_url":"https://github.com/telerik/mobile-cli-lib/pull/443.patch","issue_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/443","number":443,"state":"open","locked":false,"title":"Initial device-discovery","user":{"login":"Mitko-Kerezov","id":6683316,"avatar_url":"https://avatars.githubusercontent.com/u/6683316?v=3","gravatar_id":"","url":"https://api.github.com/users/Mitko-Kerezov","html_url":"https://github.com/Mitko-Kerezov","followers_url":"https://api.github.com/users/Mitko-Kerezov/followers","following_url":"https://api.github.com/users/Mitko-Kerezov/following{/other_user}","gists_url":"https://api.github.com/users/Mitko-Kerezov/gists{/gist_id}","starred_url":"https://api.github.com/users/Mitko-Kerezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mitko-Kerezov/subscriptions","organizations_url":"https://api.github.com/users/Mitko-Kerezov/orgs","repos_url":"https://api.github.com/users/Mitko-Kerezov/repos","events_url":"https://api.github.com/users/Mitko-Kerezov/events{/privacy}","received_events_url":"https://api.github.com/users/Mitko-Kerezov/received_events","type":"User","site_admin":false},"body":"Positives\r\n+ A new method in Yok for exposing a whole class publicly\r\n+ Separation of device-discovery into android, ios and general device discovery\r\n+ Extraction of a common-bootstrapper, used only by modules which require the common-lib\r\n+ Android device discovery refactoring as an event-driven approach\r\n+ Initial spike for iOS device detection\r\n\r\nNegatives\r\n+ our usage of the ref and ffi native dependencies has trouble with iojs 3.x\r\n\r\nFollow-up\r\n+ This pull request manages the code base only, a subsequent pull request will update the native dependencies\r\n\r\nPing @Fatme and @teobugslayer ","created_at":"2015-08-26T06:47:37Z","updated_at":"2015-09-03T11:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df0cc20ecbf28cd745787fa95400a559ddb3ee98","assignee":{"login":"Mitko-Kerezov","id":6683316,"avatar_url":"https://avatars.githubusercontent.com/u/6683316?v=3","gravatar_id":"","url":"https://api.github.com/users/Mitko-Kerezov","html_url":"https://github.com/Mitko-Kerezov","followers_url":"https://api.github.com/users/Mitko-Kerezov/followers","following_url":"https://api.github.com/users/Mitko-Kerezov/following{/other_user}","gists_url":"https://api.github.com/users/Mitko-Kerezov/gists{/gist_id}","starred_url":"https://api.github.com/users/Mitko-Kerezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mitko-Kerezov/subscriptions","organizations_url":"https://api.github.com/users/Mitko-Kerezov/orgs","repos_url":"https://api.github.com/users/Mitko-Kerezov/repos","events_url":"https://api.github.com/users/Mitko-Kerezov/events{/privacy}","received_events_url":"https://api.github.com/users/Mitko-Kerezov/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/telerik/mobile-cli-lib/milestones/11","html_url":"https://github.com/telerik/mobile-cli-lib/milestones/AB%202.12","labels_url":"https://api.github.com/repos/telerik/mobile-cli-lib/milestones/11/labels","id":1247883,"number":11,"title":"AB 2.12","description":"","creator":{"login":"teobugslayer","id":5443453,"avatar_url":"https://avatars.githubusercontent.com/u/5443453?v=3","gravatar_id":"","url":"https://api.github.com/users/teobugslayer","html_url":"https://github.com/teobugslayer","followers_url":"https://api.github.com/users/teobugslayer/followers","following_url":"https://api.github.com/users/teobugslayer/following{/other_user}","gists_url":"https://api.github.com/users/teobugslayer/gists{/gist_id}","starred_url":"https://api.github.com/users/teobugslayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teobugslayer/subscriptions","organizations_url":"https://api.github.com/users/teobugslayer/orgs","repos_url":"https://api.github.com/users/teobugslayer/repos","events_url":"https://api.github.com/users/teobugslayer/events{/privacy}","received_events_url":"https://api.github.com/users/teobugslayer/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2015-08-10T09:44:31Z","updated_at":"2015-09-02T07:48:01Z","due_on":"2015-09-28T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443/commits","review_comments_url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443/comments","review_comment_url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/443/comments","statuses_url":"https://api.github.com/repos/telerik/mobile-cli-lib/statuses/42f116d821ddcecb718b1f7a6d71a8f4f83a8654","head":{"label":"telerik:vladimirov/expose-device-api","ref":"vladimirov/expose-device-api","sha":"42f116d821ddcecb718b1f7a6d71a8f4f83a8654","user":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"repo":{"id":21348075,"name":"mobile-cli-lib","full_name":"telerik/mobile-cli-lib","owner":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telerik/mobile-cli-lib","description":"Contains common infrastructure for CLIs - mainly AppBuilder, NativeScript and DDB.","fork":false,"url":"https://api.github.com/repos/telerik/mobile-cli-lib","forks_url":"https://api.github.com/repos/telerik/mobile-cli-lib/forks","keys_url":"https://api.github.com/repos/telerik/mobile-cli-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telerik/mobile-cli-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telerik/mobile-cli-lib/teams","hooks_url":"https://api.github.com/repos/telerik/mobile-cli-lib/hooks","issue_events_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/events{/number}","events_url":"https://api.github.com/repos/telerik/mobile-cli-lib/events","assignees_url":"https://api.github.com/repos/telerik/mobile-cli-lib/assignees{/user}","branches_url":"https://api.github.com/repos/telerik/mobile-cli-lib/branches{/branch}","tags_url":"https://api.github.com/repos/telerik/mobile-cli-lib/tags","blobs_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telerik/mobile-cli-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/telerik/mobile-cli-lib/languages","stargazers_url":"https://api.github.com/repos/telerik/mobile-cli-lib/stargazers","contributors_url":"https://api.github.com/repos/telerik/mobile-cli-lib/contributors","subscribers_url":"https://api.github.com/repos/telerik/mobile-cli-lib/subscribers","subscription_url":"https://api.github.com/repos/telerik/mobile-cli-lib/subscription","commits_url":"https://api.github.com/repos/telerik/mobile-cli-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/telerik/mobile-cli-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/telerik/mobile-cli-lib/contents/{+path}","compare_url":"https://api.github.com/repos/telerik/mobile-cli-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telerik/mobile-cli-lib/merges","archive_url":"https://api.github.com/repos/telerik/mobile-cli-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telerik/mobile-cli-lib/downloads","issues_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues{/number}","pulls_url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/telerik/mobile-cli-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/telerik/mobile-cli-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telerik/mobile-cli-lib/labels{/name}","releases_url":"https://api.github.com/repos/telerik/mobile-cli-lib/releases{/id}","created_at":"2014-06-30T10:54:52Z","updated_at":"2015-08-21T03:33:58Z","pushed_at":"2015-09-01T14:43:43Z","git_url":"git://github.com/telerik/mobile-cli-lib.git","ssh_url":"git@github.com:telerik/mobile-cli-lib.git","clone_url":"https://github.com/telerik/mobile-cli-lib.git","svn_url":"https://github.com/telerik/mobile-cli-lib","homepage":"","size":13106,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"telerik:master","ref":"master","sha":"529d74f524224add33c90812adb07dea8b564bfc","user":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"repo":{"id":21348075,"name":"mobile-cli-lib","full_name":"telerik/mobile-cli-lib","owner":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telerik/mobile-cli-lib","description":"Contains common infrastructure for CLIs - mainly AppBuilder, NativeScript and DDB.","fork":false,"url":"https://api.github.com/repos/telerik/mobile-cli-lib","forks_url":"https://api.github.com/repos/telerik/mobile-cli-lib/forks","keys_url":"https://api.github.com/repos/telerik/mobile-cli-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telerik/mobile-cli-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telerik/mobile-cli-lib/teams","hooks_url":"https://api.github.com/repos/telerik/mobile-cli-lib/hooks","issue_events_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/events{/number}","events_url":"https://api.github.com/repos/telerik/mobile-cli-lib/events","assignees_url":"https://api.github.com/repos/telerik/mobile-cli-lib/assignees{/user}","branches_url":"https://api.github.com/repos/telerik/mobile-cli-lib/branches{/branch}","tags_url":"https://api.github.com/repos/telerik/mobile-cli-lib/tags","blobs_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telerik/mobile-cli-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/telerik/mobile-cli-lib/languages","stargazers_url":"https://api.github.com/repos/telerik/mobile-cli-lib/stargazers","contributors_url":"https://api.github.com/repos/telerik/mobile-cli-lib/contributors","subscribers_url":"https://api.github.com/repos/telerik/mobile-cli-lib/subscribers","subscription_url":"https://api.github.com/repos/telerik/mobile-cli-lib/subscription","commits_url":"https://api.github.com/repos/telerik/mobile-cli-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/telerik/mobile-cli-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/telerik/mobile-cli-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/telerik/mobile-cli-lib/contents/{+path}","compare_url":"https://api.github.com/repos/telerik/mobile-cli-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telerik/mobile-cli-lib/merges","archive_url":"https://api.github.com/repos/telerik/mobile-cli-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telerik/mobile-cli-lib/downloads","issues_url":"https://api.github.com/repos/telerik/mobile-cli-lib/issues{/number}","pulls_url":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/telerik/mobile-cli-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/telerik/mobile-cli-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telerik/mobile-cli-lib/labels{/name}","releases_url":"https://api.github.com/repos/telerik/mobile-cli-lib/releases{/id}","created_at":"2014-06-30T10:54:52Z","updated_at":"2015-08-21T03:33:58Z","pushed_at":"2015-09-01T14:43:43Z","git_url":"git://github.com/telerik/mobile-cli-lib.git","ssh_url":"git@github.com:telerik/mobile-cli-lib.git","clone_url":"https://github.com/telerik/mobile-cli-lib.git","svn_url":"https://github.com/telerik/mobile-cli-lib","homepage":"","size":13106,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443"},"html":{"href":"https://github.com/telerik/mobile-cli-lib/pull/443"},"issue":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/443"},"comments":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/telerik/mobile-cli-lib/statuses/42f116d821ddcecb718b1f7a6d71a8f4f83a8654"}}}}