{"action":"created","comment":{"url":"https://api.github.com/repos/CruGlobal/sp/pulls/comments/23325932","id":23325932,"diff_hunk":"@@ -101,7 +101,7 @@ def staff_search\n       if @payment.staff_first.to_s.strip.empty? || @payment.staff_last.to_s.strip.empty?\n         render; return\n       end\n-      @results = Staff.order('\"lastName\", \"firstName\"').where(\"(\\\"firstName\\\" like ? OR \\\"preferredName\\\" like ?) AND \\\"lastName\\\" like ? and \\\"removedFromPeopleSoft\\\" <> 'Y'\", @payment.staff_first+'%', @payment.staff_first+'%', @payment.staff_last+'%')\n+      @results = ::Person.order('\"last_name\", \"first_name\"').where(\"(\\\"first_name\\\" like ? OR \\\"preferred_name\\\" like ?) AND \\\"last_name\\\" like ? and \\\"isStaff\\\" = 't'\", @payment.staff_first+'%', @payment.staff_first+'%', @payment.staff_last+'%')","path":"app/controllers/fe/payments_controller.rb","position":5,"original_position":5,"commit_id":"3721d6eee29b0da4935da5fff08e781025e42ee4","original_commit_id":"3721d6eee29b0da4935da5fff08e781025e42ee4","user":{"login":"jbirdjavi","id":59860,"avatar_url":"https://avatars.githubusercontent.com/u/59860?v=3","gravatar_id":"","url":"https://api.github.com/users/jbirdjavi","html_url":"https://github.com/jbirdjavi","followers_url":"https://api.github.com/users/jbirdjavi/followers","following_url":"https://api.github.com/users/jbirdjavi/following{/other_user}","gists_url":"https://api.github.com/users/jbirdjavi/gists{/gist_id}","starred_url":"https://api.github.com/users/jbirdjavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbirdjavi/subscriptions","organizations_url":"https://api.github.com/users/jbirdjavi/orgs","repos_url":"https://api.github.com/users/jbirdjavi/repos","events_url":"https://api.github.com/users/jbirdjavi/events{/privacy}","received_events_url":"https://api.github.com/users/jbirdjavi/received_events","type":"User","site_admin":false},"body":"Gotcha.  :)","created_at":"2015-01-21T19:21:40Z","updated_at":"2015-01-21T19:21:40Z","html_url":"https://github.com/CruGlobal/sp/pull/62#discussion_r23325932","pull_request_url":"https://api.github.com/repos/CruGlobal/sp/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/sp/pulls/comments/23325932"},"html":{"href":"https://github.com/CruGlobal/sp/pull/62#discussion_r23325932"},"pull_request":{"href":"https://api.github.com/repos/CruGlobal/sp/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/CruGlobal/sp/pulls/62","id":27780155,"html_url":"https://github.com/CruGlobal/sp/pull/62","diff_url":"https://github.com/CruGlobal/sp/pull/62.diff","patch_url":"https://github.com/CruGlobal/sp/pull/62.patch","issue_url":"https://api.github.com/repos/CruGlobal/sp/issues/62","number":62,"state":"closed","locked":false,"title":"Remove the ministry_staff table.","user":{"login":"twinge","id":23668,"avatar_url":"https://avatars.githubusercontent.com/u/23668?v=3","gravatar_id":"","url":"https://api.github.com/users/twinge","html_url":"https://github.com/twinge","followers_url":"https://api.github.com/users/twinge/followers","following_url":"https://api.github.com/users/twinge/following{/other_user}","gists_url":"https://api.github.com/users/twinge/gists{/gist_id}","starred_url":"https://api.github.com/users/twinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinge/subscriptions","organizations_url":"https://api.github.com/users/twinge/orgs","repos_url":"https://api.github.com/users/twinge/repos","events_url":"https://api.github.com/users/twinge/events{/privacy}","received_events_url":"https://api.github.com/users/twinge/received_events","type":"User","site_admin":false},"body":"@jbirdjavi \r\n\r\nAll specs pass, and I manually tested payment via staff transfer and searching for staff to set as PD","created_at":"2015-01-21T17:53:55Z","updated_at":"2015-01-21T19:21:40Z","closed_at":"2015-01-21T19:15:59Z","merged_at":"2015-01-21T19:15:59Z","merge_commit_sha":"38cd5ba35ef2aca9fc52a618681b61565ea5aef5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CruGlobal/sp/pulls/62/commits","review_comments_url":"https://api.github.com/repos/CruGlobal/sp/pulls/62/comments","review_comment_url":"https://api.github.com/repos/CruGlobal/sp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CruGlobal/sp/issues/62/comments","statuses_url":"https://api.github.com/repos/CruGlobal/sp/statuses/3721d6eee29b0da4935da5fff08e781025e42ee4","head":{"label":"CruGlobal:drop_staff_table","ref":"drop_staff_table","sha":"3721d6eee29b0da4935da5fff08e781025e42ee4","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":4471574,"name":"sp","full_name":"CruGlobal/sp","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/sp","description":"Summer Mission Tool","fork":false,"url":"https://api.github.com/repos/CruGlobal/sp","forks_url":"https://api.github.com/repos/CruGlobal/sp/forks","keys_url":"https://api.github.com/repos/CruGlobal/sp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/sp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/sp/teams","hooks_url":"https://api.github.com/repos/CruGlobal/sp/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/sp/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/sp/events","assignees_url":"https://api.github.com/repos/CruGlobal/sp/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/sp/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/sp/tags","blobs_url":"https://api.github.com/repos/CruGlobal/sp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/sp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/sp/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/sp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/sp/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/sp/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/sp/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/sp/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/sp/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/sp/subscription","commits_url":"https://api.github.com/repos/CruGlobal/sp/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/sp/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/sp/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/sp/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/sp/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/sp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/sp/merges","archive_url":"https://api.github.com/repos/CruGlobal/sp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/sp/downloads","issues_url":"https://api.github.com/repos/CruGlobal/sp/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/sp/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/sp/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/sp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/sp/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/sp/releases{/id}","created_at":"2012-05-28T14:59:06Z","updated_at":"2015-01-21T19:16:00Z","pushed_at":"2015-01-21T19:16:00Z","git_url":"git://github.com/CruGlobal/sp.git","ssh_url":"git@github.com:CruGlobal/sp.git","clone_url":"https://github.com/CruGlobal/sp.git","svn_url":"https://github.com/CruGlobal/sp","homepage":"","size":224968,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"CruGlobal:master","ref":"master","sha":"681d432c54a3c7bc694eec2ce9717bbfb6f2688e","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":4471574,"name":"sp","full_name":"CruGlobal/sp","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/sp","description":"Summer Mission Tool","fork":false,"url":"https://api.github.com/repos/CruGlobal/sp","forks_url":"https://api.github.com/repos/CruGlobal/sp/forks","keys_url":"https://api.github.com/repos/CruGlobal/sp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/sp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/sp/teams","hooks_url":"https://api.github.com/repos/CruGlobal/sp/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/sp/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/sp/events","assignees_url":"https://api.github.com/repos/CruGlobal/sp/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/sp/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/sp/tags","blobs_url":"https://api.github.com/repos/CruGlobal/sp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/sp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/sp/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/sp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/sp/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/sp/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/sp/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/sp/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/sp/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/sp/subscription","commits_url":"https://api.github.com/repos/CruGlobal/sp/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/sp/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/sp/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/sp/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/sp/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/sp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/sp/merges","archive_url":"https://api.github.com/repos/CruGlobal/sp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/sp/downloads","issues_url":"https://api.github.com/repos/CruGlobal/sp/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/sp/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/sp/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/sp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/sp/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/sp/releases{/id}","created_at":"2012-05-28T14:59:06Z","updated_at":"2015-01-21T19:16:00Z","pushed_at":"2015-01-21T19:16:00Z","git_url":"git://github.com/CruGlobal/sp.git","ssh_url":"git@github.com:CruGlobal/sp.git","clone_url":"https://github.com/CruGlobal/sp.git","svn_url":"https://github.com/CruGlobal/sp","homepage":"","size":224968,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/sp/pulls/62"},"html":{"href":"https://github.com/CruGlobal/sp/pull/62"},"issue":{"href":"https://api.github.com/repos/CruGlobal/sp/issues/62"},"comments":{"href":"https://api.github.com/repos/CruGlobal/sp/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/CruGlobal/sp/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/CruGlobal/sp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CruGlobal/sp/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/CruGlobal/sp/statuses/3721d6eee29b0da4935da5fff08e781025e42ee4"}}}}