{"action":"created","issue":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/628","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/628/labels{/name}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/628/comments","events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/628/events","html_url":"https://github.com/opensim-org/opensim-core/pull/628","id":107289197,"number":628,"title":"New data interface classes.","user":{"login":"klshrinidhi","id":1181669,"avatar_url":"https://avatars.githubusercontent.com/u/1181669?v=3","gravatar_id":"","url":"https://api.github.com/users/klshrinidhi","html_url":"https://github.com/klshrinidhi","followers_url":"https://api.github.com/users/klshrinidhi/followers","following_url":"https://api.github.com/users/klshrinidhi/following{/other_user}","gists_url":"https://api.github.com/users/klshrinidhi/gists{/gist_id}","starred_url":"https://api.github.com/users/klshrinidhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshrinidhi/subscriptions","organizations_url":"https://api.github.com/users/klshrinidhi/orgs","repos_url":"https://api.github.com/users/klshrinidhi/repos","events_url":"https://api.github.com/users/klshrinidhi/events{/privacy}","received_events_url":"https://api.github.com/users/klshrinidhi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":41,"created_at":"2015-09-18T22:32:30Z","updated_at":"2015-10-24T14:56:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/628","html_url":"https://github.com/opensim-org/opensim-core/pull/628","diff_url":"https://github.com/opensim-org/opensim-core/pull/628.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/628.patch"},"body":"Files to review:\r\n* Common/ValueArray.h\r\n* Common/ValueArrayDictionary.h\r\n* Common/DataTable.h\r\n* Common/TimeSeriesTable.h\r\n* Examples/DataTable/example.cpp\r\n* Common/Test/testDataTable.cpp"},"comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/150824259","html_url":"https://github.com/opensim-org/opensim-core/pull/628#issuecomment-150824259","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/628","id":150824259,"user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=3","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T14:56:42Z","updated_at":"2015-10-24T14:56:42Z","body":"To recap, all that remains to merge this PR:\r\n\r\n1. remove newly introduced static data member in Exception in favor of protected method that returns the delimiter (delimiter value could be private static member).\r\n\r\n2. open a new issue to discuss more-substantial engineering to the Exception/error handling facility. Begin by listing what needs to be done to bring it up to our own coding standards and how the old exception messages could use the same mechanism for formatting (i.e. old constructor delegates to the new constructor). A short list of target classes from which users would benefit most (e.g. Model, Solvers) would limit the scope and maximize benefit.\r\n"}}