{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/24215739","id":24215739,"diff_hunk":"@@ -45,6 +45,10 @@ src_libfabric_la_SOURCES = \\\n \tsrc/log.c \\\n \t$(common_srcs)\n \n+if MACOS\n+src_libfabric_la_SOURCES += src/osx/osd.c\n+endif\n+","path":"Makefile.am","position":7,"original_position":7,"commit_id":"20604ec14ad1fe6554e8a0edb2c8fe63c2a72a25","original_commit_id":"20604ec14ad1fe6554e8a0edb2c8fe63c2a72a25","user":{"login":"pmmccorm","id":8812360,"avatar_url":"https://avatars.githubusercontent.com/u/8812360?v=3","gravatar_id":"","url":"https://api.github.com/users/pmmccorm","html_url":"https://github.com/pmmccorm","followers_url":"https://api.github.com/users/pmmccorm/followers","following_url":"https://api.github.com/users/pmmccorm/following{/other_user}","gists_url":"https://api.github.com/users/pmmccorm/gists{/gist_id}","starred_url":"https://api.github.com/users/pmmccorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmmccorm/subscriptions","organizations_url":"https://api.github.com/users/pmmccorm/orgs","repos_url":"https://api.github.com/users/pmmccorm/repos","events_url":"https://api.github.com/users/pmmccorm/events{/privacy}","received_events_url":"https://api.github.com/users/pmmccorm/received_events","type":"User","site_admin":false},"body":"The new headers should be added to \"src_libfabric_la_SOURCES\" as well. Try \"make dist\" then build from resultant tarball to check.","created_at":"2015-02-06T01:05:58Z","updated_at":"2015-02-06T01:05:58Z","html_url":"https://github.com/ofiwg/libfabric/pull/585#discussion_r24215739","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/24215739"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/585#discussion_r24215739"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/585","id":28664352,"html_url":"https://github.com/ofiwg/libfabric/pull/585","diff_url":"https://github.com/ofiwg/libfabric/pull/585.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/585.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/585","number":585,"state":"open","locked":false,"title":"Build on OS X","user":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"body":"Various fixes that enable building on OS X. Tested on OS X 10.9.5. \r\n\r\nChanges that needed to be made: \r\n- Add a clock_gettime implementation since it is missing on OS X. This is in src/mach_clock_gettime.c. \r\n- Wrap htonll and ntohll definitions in ifndef gaurds.\r\n- Rename flsll to fi_flsll since OS X has an flsll implementation but it is not the same. \r\n- Define le32toh, htole32, bswap_64 with OS X compatible headers (if on OS X). \r\n- Change FI_ENOKEY to be project specific error rather than using ENOKEY from errno.h (not POSIX error code and not defined on OS X & BSD). \r\n- Change HOST_NAME_MAX to be defined as _POSIX_HOST_NAME_MAX if defined or to 255 if neither is defined. \r\n- Use pthread_yield_np on OS X instead of pthread_yield\r\n- Don't use attribute alias on OS X by defining default_symver_pre macro and checking for attribute support in configure.ac. \r\n\r\n@hppritcha @jsquyres  ","created_at":"2015-02-04T18:53:40Z","updated_at":"2015-02-06T01:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"528964c53f7ab8f4206ef1d3e812ba68b7cba2de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/585/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/585/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/585/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/20604ec14ad1fe6554e8a0edb2c8fe63c2a72a25","head":{"label":"bturrubiates:pr-os-x","ref":"pr-os-x","sha":"20604ec14ad1fe6554e8a0edb2c8fe63c2a72a25","user":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"repo":{"id":29930238,"name":"libfabric","full_name":"bturrubiates/libfabric","owner":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bturrubiates/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/bturrubiates/libfabric","forks_url":"https://api.github.com/repos/bturrubiates/libfabric/forks","keys_url":"https://api.github.com/repos/bturrubiates/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bturrubiates/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bturrubiates/libfabric/teams","hooks_url":"https://api.github.com/repos/bturrubiates/libfabric/hooks","issue_events_url":"https://api.github.com/repos/bturrubiates/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/bturrubiates/libfabric/events","assignees_url":"https://api.github.com/repos/bturrubiates/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/bturrubiates/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/bturrubiates/libfabric/tags","blobs_url":"https://api.github.com/repos/bturrubiates/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bturrubiates/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bturrubiates/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/bturrubiates/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bturrubiates/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/bturrubiates/libfabric/languages","stargazers_url":"https://api.github.com/repos/bturrubiates/libfabric/stargazers","contributors_url":"https://api.github.com/repos/bturrubiates/libfabric/contributors","subscribers_url":"https://api.github.com/repos/bturrubiates/libfabric/subscribers","subscription_url":"https://api.github.com/repos/bturrubiates/libfabric/subscription","commits_url":"https://api.github.com/repos/bturrubiates/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/bturrubiates/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/bturrubiates/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/bturrubiates/libfabric/issues/comments/{number}","contents_url":"https://api.github.com/repos/bturrubiates/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/bturrubiates/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bturrubiates/libfabric/merges","archive_url":"https://api.github.com/repos/bturrubiates/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bturrubiates/libfabric/downloads","issues_url":"https://api.github.com/repos/bturrubiates/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/bturrubiates/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/bturrubiates/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/bturrubiates/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bturrubiates/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/bturrubiates/libfabric/releases{/id}","created_at":"2015-01-27T19:13:34Z","updated_at":"2015-02-04T16:53:37Z","pushed_at":"2015-02-05T23:35:50Z","git_url":"git://github.com/bturrubiates/libfabric.git","ssh_url":"git@github.com:bturrubiates/libfabric.git","clone_url":"https://github.com/bturrubiates/libfabric.git","svn_url":"https://github.com/bturrubiates/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":4582,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"058ea060316cc669839128844def280e400534a5","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments/{number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-02-05T21:59:41Z","pushed_at":"2015-02-05T21:59:41Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":8345,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":36,"forks":27,"open_issues":36,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/585"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/585"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/585"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/20604ec14ad1fe6554e8a0edb2c8fe63c2a72a25"}}}}