{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/885","labels_url":"https://api.github.com/repos/ripple/rippled/issues/885/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/885/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/885/events","html_url":"https://github.com/ripple/rippled/pull/885","id":58525427,"number":885,"title":"Always use HTTP handshaking in overlay:","user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Ed","name":"Ed","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Nik","name":"Nik","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Tx%20Change","name":"Tx Change","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-22T22:54:35Z","updated_at":"2015-02-24T21:53:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/885","html_url":"https://github.com/ripple/rippled/pull/885","diff_url":"https://github.com/ripple/rippled/pull/885.diff","patch_url":"https://github.com/ripple/rippled/pull/885.patch"},"body":"Inbound and outbound peer connections always use HTTP handshakes to negotiate connections, instead of the deprecated TMHello protocol message.\r\n\r\nrippled versions 0.27.0 and later support both optional HTTP handshakes and legacy TMHello messages, so always using HTTP handshakes should not cause disruption. However, versions before 0.27.0 will no longer be able to participate in the overlay network - support for handshaking via the TMHello message is removed.\r\n"},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/75854581","html_url":"https://github.com/ripple/rippled/pull/885#issuecomment-75854581","issue_url":"https://api.github.com/repos/ripple/rippled/issues/885","id":75854581,"user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"created_at":"2015-02-24T21:53:05Z","updated_at":"2015-02-24T21:53:05Z","body":"PS. Tests pass in Windows for release and debug, and running `rippled` is able to connect to the network. I don't have the patience to wait for it to sync."}}