{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/48061144","id":48061144,"diff_hunk":"@@ -26,40 +26,40 @@\n // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n // Node polyfill\n-var fs = require('fs');\n-var os = {\n+const fs = require('fs');\n+const cp = require('child_process');\n+const os = {\n   system: function(name, args) {\n     if (process.platform === 'linux' && name === 'nm') {\n       // Filter out vdso and vsyscall entries.\n-      var arg = args[args.length - 1];\n+      const arg = args[args.length - 1];\n       if (arg === '[vdso]' ||\n           arg == '[vsyscall]' ||\n           /^[0-9a-f]+-[0-9a-f]+$/.test(arg)) {\n         return '';\n       }\n     }\n-    return require('child_process').execFileSync(\n-        name, args, {encoding: 'utf8'});\n+    const cmd = name + ' ' + args.join(' ');\n+    return cp.execSync(cmd, {encoding: 'utf8'});","path":"lib/internal/v8_prof_polyfill.js","position":null,"original_position":23,"commit_id":"3827bb7291dddea89ca971b149a40af5e82e76c5","original_commit_id":"fb493cccb83d916082b130dbecb8f0c7c66efcc4","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"I can handle the OS X case specially here if that is preferable. What is the motivation of changing `execSync` to `spawnSync`?","created_at":"2015-12-18T19:36:06Z","updated_at":"2015-12-18T19:36:06Z","html_url":"https://github.com/nodejs/node/pull/4224#discussion_r48061144","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4224","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/48061144"},"html":{"href":"https://github.com/nodejs/node/pull/4224#discussion_r48061144"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4224"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4224","id":53204283,"html_url":"https://github.com/nodejs/node/pull/4224","diff_url":"https://github.com/nodejs/node/pull/4224.diff","patch_url":"https://github.com/nodejs/node/pull/4224.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4224","number":4224,"state":"open","locked":false,"title":"tools: run tick processor without forking","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"Using the tick processor no longer creates temporary files or spawns a\r\nchild process.\r\n\r\n/cc @bnoordhuis ","created_at":"2015-12-10T01:30:06Z","updated_at":"2015-12-18T19:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5be1be898416e13c1126d35325fa08cb3f1cf532","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4224/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4224/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4224/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/3827bb7291dddea89ca971b149a40af5e82e76c5","head":{"label":"matthewloring:tp-no-cp","ref":"tp-no-cp","sha":"3827bb7291dddea89ca971b149a40af5e82e76c5","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"repo":{"id":38261750,"name":"io.js","full_name":"matthewloring/io.js","owner":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewloring/io.js","description":"Future Node.js releases will be based on io.js","fork":true,"url":"https://api.github.com/repos/matthewloring/io.js","forks_url":"https://api.github.com/repos/matthewloring/io.js/forks","keys_url":"https://api.github.com/repos/matthewloring/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewloring/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewloring/io.js/teams","hooks_url":"https://api.github.com/repos/matthewloring/io.js/hooks","issue_events_url":"https://api.github.com/repos/matthewloring/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/matthewloring/io.js/events","assignees_url":"https://api.github.com/repos/matthewloring/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/matthewloring/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/matthewloring/io.js/tags","blobs_url":"https://api.github.com/repos/matthewloring/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewloring/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewloring/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewloring/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewloring/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewloring/io.js/languages","stargazers_url":"https://api.github.com/repos/matthewloring/io.js/stargazers","contributors_url":"https://api.github.com/repos/matthewloring/io.js/contributors","subscribers_url":"https://api.github.com/repos/matthewloring/io.js/subscribers","subscription_url":"https://api.github.com/repos/matthewloring/io.js/subscription","commits_url":"https://api.github.com/repos/matthewloring/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewloring/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewloring/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewloring/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewloring/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/matthewloring/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewloring/io.js/merges","archive_url":"https://api.github.com/repos/matthewloring/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewloring/io.js/downloads","issues_url":"https://api.github.com/repos/matthewloring/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/matthewloring/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewloring/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewloring/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewloring/io.js/labels{/name}","releases_url":"https://api.github.com/repos/matthewloring/io.js/releases{/id}","created_at":"2015-06-29T17:49:00Z","updated_at":"2015-06-29T17:49:05Z","pushed_at":"2015-12-18T18:56:33Z","git_url":"git://github.com/matthewloring/io.js.git","ssh_url":"git@github.com:matthewloring/io.js.git","clone_url":"https://github.com/matthewloring/io.js.git","svn_url":"https://github.com/matthewloring/io.js","homepage":"https://iojs.org","size":159935,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"a2c1799a5b68dbf411785606345e166ad8acd607","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-12-18T19:31:58Z","pushed_at":"2015-12-18T18:56:34Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":178466,"stargazers_count":18414,"watchers_count":18414,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2088,"mirror_url":null,"open_issues_count":618,"forks":2088,"open_issues":618,"watchers":18414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4224"},"html":{"href":"https://github.com/nodejs/node/pull/4224"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4224"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4224/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4224/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4224/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/3827bb7291dddea89ca971b149a40af5e82e76c5"}}}}