{"action":"created","issue":{"url":"https://api.github.com/repos/NicolasDorier/NBitcoin/issues/88","labels_url":"https://api.github.com/repos/NicolasDorier/NBitcoin/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/NicolasDorier/NBitcoin/issues/88/comments","events_url":"https://api.github.com/repos/NicolasDorier/NBitcoin/issues/88/events","html_url":"https://github.com/NicolasDorier/NBitcoin/pull/88","id":87227542,"number":88,"title":"Validations","user":{"login":"lontivero","id":127973,"avatar_url":"https://avatars.githubusercontent.com/u/127973?v=3","gravatar_id":"","url":"https://api.github.com/users/lontivero","html_url":"https://github.com/lontivero","followers_url":"https://api.github.com/users/lontivero/followers","following_url":"https://api.github.com/users/lontivero/following{/other_user}","gists_url":"https://api.github.com/users/lontivero/gists{/gist_id}","starred_url":"https://api.github.com/users/lontivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lontivero/subscriptions","organizations_url":"https://api.github.com/users/lontivero/orgs","repos_url":"https://api.github.com/users/lontivero/repos","events_url":"https://api.github.com/users/lontivero/events{/privacy}","received_events_url":"https://api.github.com/users/lontivero/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-11T06:18:01Z","updated_at":"2015-06-11T23:44:39Z","closed_at":"2015-06-11T23:44:39Z","pull_request":{"url":"https://api.github.com/repos/NicolasDorier/NBitcoin/pulls/88","html_url":"https://github.com/NicolasDorier/NBitcoin/pull/88","diff_url":"https://github.com/NicolasDorier/NBitcoin/pull/88.diff","patch_url":"https://github.com/NicolasDorier/NBitcoin/pull/88.patch"},"body":"@NicolasDorier this PR has minor changes as:\r\n\r\n* null validations for public methods, \r\n* static modifier for those classes that only have static methods, \r\n* static modifier for methods that can be statics, \r\n* remove unused local variables\r\n\r\nBut also contains some **comments and warnings** that you should review. There are methods with **parameters that are not used in the method body** and that could be important (I don't know if their values should be used). Please take a look at the //FIXME comments.\r\n\r\nI've splitted the PR in a couple of commits because I think in that way it can be easier for reviewing. \r\n\r\n**NOTE:** the PR compiles and all tests pass GREEN. However, individual commits do not! \r\n"},"comment":{"url":"https://api.github.com/repos/NicolasDorier/NBitcoin/issues/comments/111307878","html_url":"https://github.com/NicolasDorier/NBitcoin/pull/88#issuecomment-111307878","issue_url":"https://api.github.com/repos/NicolasDorier/NBitcoin/issues/88","id":111307878,"user":{"login":"lontivero","id":127973,"avatar_url":"https://avatars.githubusercontent.com/u/127973?v=3","gravatar_id":"","url":"https://api.github.com/users/lontivero","html_url":"https://github.com/lontivero","followers_url":"https://api.github.com/users/lontivero/followers","following_url":"https://api.github.com/users/lontivero/following{/other_user}","gists_url":"https://api.github.com/users/lontivero/gists{/gist_id}","starred_url":"https://api.github.com/users/lontivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lontivero/subscriptions","organizations_url":"https://api.github.com/users/lontivero/orgs","repos_url":"https://api.github.com/users/lontivero/repos","events_url":"https://api.github.com/users/lontivero/events{/privacy}","received_events_url":"https://api.github.com/users/lontivero/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T23:44:39Z","updated_at":"2015-06-11T23:44:39Z","body":"There is a new PR #89 with these changes."}}