{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments/37131954","id":37131954,"diff_hunk":"@@ -43,11 +43,14 @@ gnome-shell-theme.gresource: gnome-shell-theme.gresource.xml $(resource_files)\n resourcedir = $(pkgdatadir)\n resource_DATA = gnome-shell-theme.gresource\n \n-keysdir = $(GNOME_KEYBINDINGS_KEYSDIR)\n keys_in_files =\t\t\t\t\t\\\n \t50-gnome-shell-system.xml.in\t\t\\\n \t$(NULL)\n+\n+if INSTALL_GNOME_KEYBINDINGS\n+keysdir = $(GNOME_KEYBINDINGS_KEYSDIR)\n keys_DATA = $(keys_in_files:.xml.in=.xml)","path":"data/Makefile.am","position":11,"original_position":11,"commit_id":"6bf44960d5f563b4119445bb519dc0164026d12d","original_commit_id":"6bf44960d5f563b4119445bb519dc0164026d12d","user":{"login":"smspillaz","id":775309,"avatar_url":"https://avatars.githubusercontent.com/u/775309?v=3","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"Yup - if `INSTALL_GNOME_KEYBINDINGS` wasn't set it might not have been cleaned either. Good catch.","created_at":"2015-08-15T02:14:01Z","updated_at":"2015-08-15T02:14:01Z","html_url":"https://github.com/endlessm/eos-desktop/pull/65#discussion_r37131954","pull_request_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments/37131954"},"html":{"href":"https://github.com/endlessm/eos-desktop/pull/65#discussion_r37131954"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65","id":40979289,"html_url":"https://github.com/endlessm/eos-desktop/pull/65","diff_url":"https://github.com/endlessm/eos-desktop/pull/65.diff","patch_url":"https://github.com/endlessm/eos-desktop/pull/65.patch","issue_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/65","number":65,"state":"open","locked":false,"title":"Makefile: Allow disabling of keybindings installation","user":{"login":"smspillaz","id":775309,"avatar_url":"https://avatars.githubusercontent.com/u/775309?v=3","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"By default these keybindings install systemwide and it doesn't\r\nmake sense to change their install location. Requiring root access\r\nto run make install is not desirable and so the user\r\nshould have been able to disable this.\r\n\r\n[endlessm/eos-shell#5439]","created_at":"2015-07-28T06:33:02Z","updated_at":"2015-08-15T02:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e90f10eacd9773c0cd5a09ae57dd0389cfc7ca38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/65/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-desktop/statuses/6bf44960d5f563b4119445bb519dc0164026d12d","head":{"label":"endlessm:shell/5439","ref":"shell/5439","sha":"6bf44960d5f563b4119445bb519dc0164026d12d","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":32344042,"name":"eos-desktop","full_name":"endlessm/eos-desktop","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-desktop","description":"Endless Desktop","fork":false,"url":"https://api.github.com/repos/endlessm/eos-desktop","forks_url":"https://api.github.com/repos/endlessm/eos-desktop/forks","keys_url":"https://api.github.com/repos/endlessm/eos-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-desktop/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-desktop/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-desktop/events","assignees_url":"https://api.github.com/repos/endlessm/eos-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-desktop/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-desktop/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-desktop/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-desktop/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-desktop/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-desktop/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-desktop/merges","archive_url":"https://api.github.com/repos/endlessm/eos-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-desktop/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-desktop/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-desktop/releases{/id}","created_at":"2015-03-16T18:15:46Z","updated_at":"2015-07-13T23:10:35Z","pushed_at":"2015-08-14T17:48:44Z","git_url":"git://github.com/endlessm/eos-desktop.git","ssh_url":"git@github.com:endlessm/eos-desktop.git","clone_url":"https://github.com/endlessm/eos-desktop.git","svn_url":"https://github.com/endlessm/eos-desktop","homepage":"http://endlessm.com","size":26094,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"76d7f93022427035128c405433444bfa472d2177","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":32344042,"name":"eos-desktop","full_name":"endlessm/eos-desktop","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-desktop","description":"Endless Desktop","fork":false,"url":"https://api.github.com/repos/endlessm/eos-desktop","forks_url":"https://api.github.com/repos/endlessm/eos-desktop/forks","keys_url":"https://api.github.com/repos/endlessm/eos-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-desktop/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-desktop/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-desktop/events","assignees_url":"https://api.github.com/repos/endlessm/eos-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-desktop/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-desktop/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-desktop/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-desktop/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-desktop/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-desktop/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-desktop/merges","archive_url":"https://api.github.com/repos/endlessm/eos-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-desktop/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-desktop/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-desktop/releases{/id}","created_at":"2015-03-16T18:15:46Z","updated_at":"2015-07-13T23:10:35Z","pushed_at":"2015-08-14T17:48:44Z","git_url":"git://github.com/endlessm/eos-desktop.git","ssh_url":"git@github.com:endlessm/eos-desktop.git","clone_url":"https://github.com/endlessm/eos-desktop.git","svn_url":"https://github.com/endlessm/eos-desktop","homepage":"http://endlessm.com","size":26094,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65"},"html":{"href":"https://github.com/endlessm/eos-desktop/pull/65"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-desktop/issues/65"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-desktop/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-desktop/statuses/6bf44960d5f563b4119445bb519dc0164026d12d"}}}}