{"action":"created","comment":{"url":"https://api.github.com/repos/socrata-platform/geo-import/pulls/comments/45090764","id":45090764,"diff_hunk":"@@ -0,0 +1,98 @@\n+import _ from 'underscore';\n+import chai from 'chai';\n+import should from 'should';\n+import * as es from 'event-stream';\n+import {\n+  fixture, bufferJs\n+}\n+from './fixture';\n+import request from 'request';\n+import CoreMock from './services/mock-core';\n+import MockZKClient from './services/mock-zk';\n+import {\n+  EventEmitter\n+}\n+from 'events';\n+import config from '../lib/config';\n+import service from '../lib/service';\n+import Shapefile from '../lib/decoders/shapefile';\n+import KMZ from '../lib/decoders/kmz';\n+import KML from '../lib/decoders/kml';\n+import Disk from '../lib/decoders/disk';\n+\n+var res;\n+var expect = chai.expect;\n+\n+function kmzDecoder() {\n+  res = new EventEmitter()\n+  return new KMZ(new Disk(res));\n+}\n+function shpDecoder() {\n+  res = new EventEmitter()\n+  return [new Shapefile(new Disk(res)), res]","path":"test/smoke-decoders.js","position":32,"original_position":32,"commit_id":"c9932397464fcbf2e763f1df082a117e219a512a","original_commit_id":"c9932397464fcbf2e763f1df082a117e219a512a","user":{"login":"rozap","id":736051,"avatar_url":"https://avatars.githubusercontent.com/u/736051?v=3","gravatar_id":"","url":"https://api.github.com/users/rozap","html_url":"https://github.com/rozap","followers_url":"https://api.github.com/users/rozap/followers","following_url":"https://api.github.com/users/rozap/following{/other_user}","gists_url":"https://api.github.com/users/rozap/gists{/gist_id}","starred_url":"https://api.github.com/users/rozap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozap/subscriptions","organizations_url":"https://api.github.com/users/rozap/orgs","repos_url":"https://api.github.com/users/rozap/repos","events_url":"https://api.github.com/users/rozap/events{/privacy}","received_events_url":"https://api.github.com/users/rozap/received_events","type":"User","site_admin":false},"body":"because js doesn't have tuples :(","created_at":"2015-11-17T17:30:43Z","updated_at":"2015-11-17T17:30:43Z","html_url":"https://github.com/socrata-platform/geo-import/pull/10#discussion_r45090764","pull_request_url":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/geo-import/pulls/comments/45090764"},"html":{"href":"https://github.com/socrata-platform/geo-import/pull/10#discussion_r45090764"},"pull_request":{"href":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10","id":50838899,"html_url":"https://github.com/socrata-platform/geo-import/pull/10","diff_url":"https://github.com/socrata-platform/geo-import/pull/10.diff","patch_url":"https://github.com/socrata-platform/geo-import/pull/10.patch","issue_url":"https://api.github.com/repos/socrata-platform/geo-import/issues/10","number":10,"state":"open","locked":false,"title":"Added smoke tests","user":{"login":"rozap","id":736051,"avatar_url":"https://avatars.githubusercontent.com/u/736051?v=3","gravatar_id":"","url":"https://api.github.com/users/rozap","html_url":"https://github.com/rozap","followers_url":"https://api.github.com/users/rozap/followers","following_url":"https://api.github.com/users/rozap/following{/other_user}","gists_url":"https://api.github.com/users/rozap/gists{/gist_id}","starred_url":"https://api.github.com/users/rozap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozap/subscriptions","organizations_url":"https://api.github.com/users/rozap/orgs","repos_url":"https://api.github.com/users/rozap/repos","events_url":"https://api.github.com/users/rozap/events{/privacy}","received_events_url":"https://api.github.com/users/rozap/received_events","type":"User","site_admin":false},"body":"* Added some smoke tests\r\n* Fixed a bunch of issues that the smoke tests uncovered\r\n    * Concurrency issue in services/spatial.js\r\n        * upsert requests weren't aborted when an error was\r\n          emitted\r\n        * layer wasn't emitting error and end events, which\r\n          would cause the upsertRequest callback to not\r\n          fire at the right time, which caused the upsert\r\n          response to finish early before the upsert had\r\n          completed\r\n* node's concurrency model is wtf i can't even\r\n* fixed up test script to run units by default - smoke tests\r\n  can be run in CI\r\n* fixed up the test classes - it looks like mocha doesn't\r\n  run things in serial? or close doesn't happen in a sync\r\n  way - even when mocha done is bound to a callback. workaround\r\n  is to use different service ports and mock ports across\r\n  different suites - test suite passes now","created_at":"2015-11-16T17:19:03Z","updated_at":"2015-11-17T17:30:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c0d190526da0e71fc4409bee8417bcdeffecd72","assignee":{"login":"vilterp","id":7341,"avatar_url":"https://avatars.githubusercontent.com/u/7341?v=3","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10/commits","review_comments_url":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10/comments","review_comment_url":"https://api.github.com/repos/socrata-platform/geo-import/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata-platform/geo-import/issues/10/comments","statuses_url":"https://api.github.com/repos/socrata-platform/geo-import/statuses/c9932397464fcbf2e763f1df082a117e219a512a","head":{"label":"socrata-platform:smoke-tests","ref":"smoke-tests","sha":"c9932397464fcbf2e763f1df082a117e219a512a","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":45220723,"name":"geo-import","full_name":"socrata-platform/geo-import","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/geo-import","description":"ingest multilayer geojson, shp, kml, kmz","fork":false,"url":"https://api.github.com/repos/socrata-platform/geo-import","forks_url":"https://api.github.com/repos/socrata-platform/geo-import/forks","keys_url":"https://api.github.com/repos/socrata-platform/geo-import/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/geo-import/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/geo-import/teams","hooks_url":"https://api.github.com/repos/socrata-platform/geo-import/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/geo-import/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/geo-import/events","assignees_url":"https://api.github.com/repos/socrata-platform/geo-import/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/geo-import/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/geo-import/tags","blobs_url":"https://api.github.com/repos/socrata-platform/geo-import/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/geo-import/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/geo-import/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/geo-import/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/geo-import/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/geo-import/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/geo-import/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/geo-import/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/geo-import/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/geo-import/subscription","commits_url":"https://api.github.com/repos/socrata-platform/geo-import/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/geo-import/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/geo-import/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/geo-import/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/geo-import/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/geo-import/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/geo-import/merges","archive_url":"https://api.github.com/repos/socrata-platform/geo-import/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/geo-import/downloads","issues_url":"https://api.github.com/repos/socrata-platform/geo-import/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/geo-import/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/geo-import/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/geo-import/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/geo-import/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/geo-import/releases{/id}","created_at":"2015-10-30T01:08:44Z","updated_at":"2015-10-30T01:10:07Z","pushed_at":"2015-11-16T20:21:15Z","git_url":"git://github.com/socrata-platform/geo-import.git","ssh_url":"git@github.com:socrata-platform/geo-import.git","clone_url":"https://github.com/socrata-platform/geo-import.git","svn_url":"https://github.com/socrata-platform/geo-import","homepage":null,"size":49096,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"socrata-platform:kml-schema","ref":"kml-schema","sha":"ba4562ba9bbce0daecba45647824ea3e7e3b7cd0","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":45220723,"name":"geo-import","full_name":"socrata-platform/geo-import","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/geo-import","description":"ingest multilayer geojson, shp, kml, kmz","fork":false,"url":"https://api.github.com/repos/socrata-platform/geo-import","forks_url":"https://api.github.com/repos/socrata-platform/geo-import/forks","keys_url":"https://api.github.com/repos/socrata-platform/geo-import/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/geo-import/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/geo-import/teams","hooks_url":"https://api.github.com/repos/socrata-platform/geo-import/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/geo-import/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/geo-import/events","assignees_url":"https://api.github.com/repos/socrata-platform/geo-import/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/geo-import/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/geo-import/tags","blobs_url":"https://api.github.com/repos/socrata-platform/geo-import/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/geo-import/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/geo-import/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/geo-import/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/geo-import/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/geo-import/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/geo-import/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/geo-import/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/geo-import/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/geo-import/subscription","commits_url":"https://api.github.com/repos/socrata-platform/geo-import/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/geo-import/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/geo-import/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/geo-import/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/geo-import/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/geo-import/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/geo-import/merges","archive_url":"https://api.github.com/repos/socrata-platform/geo-import/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/geo-import/downloads","issues_url":"https://api.github.com/repos/socrata-platform/geo-import/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/geo-import/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/geo-import/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/geo-import/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/geo-import/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/geo-import/releases{/id}","created_at":"2015-10-30T01:08:44Z","updated_at":"2015-10-30T01:10:07Z","pushed_at":"2015-11-16T20:21:15Z","git_url":"git://github.com/socrata-platform/geo-import.git","ssh_url":"git@github.com:socrata-platform/geo-import.git","clone_url":"https://github.com/socrata-platform/geo-import.git","svn_url":"https://github.com/socrata-platform/geo-import","homepage":null,"size":49096,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10"},"html":{"href":"https://github.com/socrata-platform/geo-import/pull/10"},"issue":{"href":"https://api.github.com/repos/socrata-platform/geo-import/issues/10"},"comments":{"href":"https://api.github.com/repos/socrata-platform/geo-import/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata-platform/geo-import/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata-platform/geo-import/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/socrata-platform/geo-import/statuses/c9932397464fcbf2e763f1df082a117e219a512a"}}}}