{"action":"created","comment":{"url":"https://api.github.com/repos/TestStack/ConventionTests/pulls/comments/22645380","id":22645380,"diff_hunk":"@@ -1,49 +1,221 @@\n ﻿namespace TestStack.ConventionTests.ConventionData\n {\n     using System;\n+    using System.Collections;\n     using System.Collections.Generic;\n+    using System.ComponentModel;\n     using System.Linq;\n-    using System.Runtime.CompilerServices;\n+    using System.Reflection;\n \n     /// <summary>\n     ///     This is where we set what our convention is all about.\n     /// </summary>\n-    public class Types : IConventionData\n+    public class Types : IConventionData, IEnumerable<Type>\n     {\n-        public Types(string descriptionOfTypes)\n+        private Types(IEnumerable<Type> typesToVerify, string descriptionOfTypes)\n         {\n+            TypesToVerify = typesToVerify;\n             Description = descriptionOfTypes;\n         }\n \n-        public Type[] TypesToVerify { get; set; }","path":"TestStack.ConventionTests/ConventionData/Types.cs","position":24,"original_position":24,"commit_id":"f6031a6a99f51a266145f283acb1e00cbca24f8d","original_commit_id":"f6031a6a99f51a266145f283acb1e00cbca24f8d","user":{"login":"JakeGinnivan","id":453152,"avatar_url":"https://avatars.githubusercontent.com/u/453152?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeGinnivan","html_url":"https://github.com/JakeGinnivan","followers_url":"https://api.github.com/users/JakeGinnivan/followers","following_url":"https://api.github.com/users/JakeGinnivan/following{/other_user}","gists_url":"https://api.github.com/users/JakeGinnivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeGinnivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeGinnivan/subscriptions","organizations_url":"https://api.github.com/users/JakeGinnivan/orgs","repos_url":"https://api.github.com/users/JakeGinnivan/repos","events_url":"https://api.github.com/users/JakeGinnivan/events{/privacy}","received_events_url":"https://api.github.com/users/JakeGinnivan/received_events","type":"User","site_admin":false},"body":"I think we should at least .ToArray() internally. The reason I use array is so make sure that it is not a lazy enumerable which can be executed multiple times. ","created_at":"2015-01-08T10:52:40Z","updated_at":"2015-01-08T10:52:40Z","html_url":"https://github.com/TestStack/ConventionTests/pull/62#discussion_r22645380","pull_request_url":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/TestStack/ConventionTests/pulls/comments/22645380"},"html":{"href":"https://github.com/TestStack/ConventionTests/pull/62#discussion_r22645380"},"pull_request":{"href":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62","id":26915807,"html_url":"https://github.com/TestStack/ConventionTests/pull/62","diff_url":"https://github.com/TestStack/ConventionTests/pull/62.diff","patch_url":"https://github.com/TestStack/ConventionTests/pull/62.patch","issue_url":"https://api.github.com/repos/TestStack/ConventionTests/issues/62","number":62,"state":"open","locked":false,"title":"Added new Types overloads","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"body":"Here's a couple of (in my opinion) missing overloads for `Types`.\r\n\r\nThis also fixes half of #56\r\n\r\nI went a bit overboard with breaking changes here. They are contained in the three last commits. If you want me to I can strip them out :smile:","created_at":"2015-01-06T20:33:11Z","updated_at":"2015-01-08T10:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e948c75c22e0ee5f6ba81206f4135b5b3b4004f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62/commits","review_comments_url":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62/comments","review_comment_url":"https://api.github.com/repos/TestStack/ConventionTests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TestStack/ConventionTests/issues/62/comments","statuses_url":"https://api.github.com/repos/TestStack/ConventionTests/statuses/f6031a6a99f51a266145f283acb1e00cbca24f8d","head":{"label":"khellang:types-overloads","ref":"types-overloads","sha":"f6031a6a99f51a266145f283acb1e00cbca24f8d","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"repo":{"id":28821821,"name":"ConventionTests","full_name":"khellang/ConventionTests","owner":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khellang/ConventionTests","description":"ConventionTests help you go beyond the compiler with conventions!","fork":true,"url":"https://api.github.com/repos/khellang/ConventionTests","forks_url":"https://api.github.com/repos/khellang/ConventionTests/forks","keys_url":"https://api.github.com/repos/khellang/ConventionTests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khellang/ConventionTests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khellang/ConventionTests/teams","hooks_url":"https://api.github.com/repos/khellang/ConventionTests/hooks","issue_events_url":"https://api.github.com/repos/khellang/ConventionTests/issues/events{/number}","events_url":"https://api.github.com/repos/khellang/ConventionTests/events","assignees_url":"https://api.github.com/repos/khellang/ConventionTests/assignees{/user}","branches_url":"https://api.github.com/repos/khellang/ConventionTests/branches{/branch}","tags_url":"https://api.github.com/repos/khellang/ConventionTests/tags","blobs_url":"https://api.github.com/repos/khellang/ConventionTests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khellang/ConventionTests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khellang/ConventionTests/git/refs{/sha}","trees_url":"https://api.github.com/repos/khellang/ConventionTests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khellang/ConventionTests/statuses/{sha}","languages_url":"https://api.github.com/repos/khellang/ConventionTests/languages","stargazers_url":"https://api.github.com/repos/khellang/ConventionTests/stargazers","contributors_url":"https://api.github.com/repos/khellang/ConventionTests/contributors","subscribers_url":"https://api.github.com/repos/khellang/ConventionTests/subscribers","subscription_url":"https://api.github.com/repos/khellang/ConventionTests/subscription","commits_url":"https://api.github.com/repos/khellang/ConventionTests/commits{/sha}","git_commits_url":"https://api.github.com/repos/khellang/ConventionTests/git/commits{/sha}","comments_url":"https://api.github.com/repos/khellang/ConventionTests/comments{/number}","issue_comment_url":"https://api.github.com/repos/khellang/ConventionTests/issues/comments/{number}","contents_url":"https://api.github.com/repos/khellang/ConventionTests/contents/{+path}","compare_url":"https://api.github.com/repos/khellang/ConventionTests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khellang/ConventionTests/merges","archive_url":"https://api.github.com/repos/khellang/ConventionTests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khellang/ConventionTests/downloads","issues_url":"https://api.github.com/repos/khellang/ConventionTests/issues{/number}","pulls_url":"https://api.github.com/repos/khellang/ConventionTests/pulls{/number}","milestones_url":"https://api.github.com/repos/khellang/ConventionTests/milestones{/number}","notifications_url":"https://api.github.com/repos/khellang/ConventionTests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khellang/ConventionTests/labels{/name}","releases_url":"https://api.github.com/repos/khellang/ConventionTests/releases{/id}","created_at":"2015-01-05T16:51:23Z","updated_at":"2015-01-06T18:16:01Z","pushed_at":"2015-01-06T20:35:20Z","git_url":"git://github.com/khellang/ConventionTests.git","ssh_url":"git@github.com:khellang/ConventionTests.git","clone_url":"https://github.com/khellang/ConventionTests.git","svn_url":"https://github.com/khellang/ConventionTests","homepage":"http://teststack.github.com/ConventionTests","size":16539,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TestStack:master","ref":"master","sha":"dd0c650a630c84e06fee9c21edca812f8e2febd7","user":{"login":"TestStack","id":1782385,"avatar_url":"https://avatars.githubusercontent.com/u/1782385?v=3","gravatar_id":"","url":"https://api.github.com/users/TestStack","html_url":"https://github.com/TestStack","followers_url":"https://api.github.com/users/TestStack/followers","following_url":"https://api.github.com/users/TestStack/following{/other_user}","gists_url":"https://api.github.com/users/TestStack/gists{/gist_id}","starred_url":"https://api.github.com/users/TestStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestStack/subscriptions","organizations_url":"https://api.github.com/users/TestStack/orgs","repos_url":"https://api.github.com/users/TestStack/repos","events_url":"https://api.github.com/users/TestStack/events{/privacy}","received_events_url":"https://api.github.com/users/TestStack/received_events","type":"Organization","site_admin":false},"repo":{"id":4459181,"name":"ConventionTests","full_name":"TestStack/ConventionTests","owner":{"login":"TestStack","id":1782385,"avatar_url":"https://avatars.githubusercontent.com/u/1782385?v=3","gravatar_id":"","url":"https://api.github.com/users/TestStack","html_url":"https://github.com/TestStack","followers_url":"https://api.github.com/users/TestStack/followers","following_url":"https://api.github.com/users/TestStack/following{/other_user}","gists_url":"https://api.github.com/users/TestStack/gists{/gist_id}","starred_url":"https://api.github.com/users/TestStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestStack/subscriptions","organizations_url":"https://api.github.com/users/TestStack/orgs","repos_url":"https://api.github.com/users/TestStack/repos","events_url":"https://api.github.com/users/TestStack/events{/privacy}","received_events_url":"https://api.github.com/users/TestStack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TestStack/ConventionTests","description":"ConventionTests help you go beyond the compiler with conventions!","fork":false,"url":"https://api.github.com/repos/TestStack/ConventionTests","forks_url":"https://api.github.com/repos/TestStack/ConventionTests/forks","keys_url":"https://api.github.com/repos/TestStack/ConventionTests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TestStack/ConventionTests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TestStack/ConventionTests/teams","hooks_url":"https://api.github.com/repos/TestStack/ConventionTests/hooks","issue_events_url":"https://api.github.com/repos/TestStack/ConventionTests/issues/events{/number}","events_url":"https://api.github.com/repos/TestStack/ConventionTests/events","assignees_url":"https://api.github.com/repos/TestStack/ConventionTests/assignees{/user}","branches_url":"https://api.github.com/repos/TestStack/ConventionTests/branches{/branch}","tags_url":"https://api.github.com/repos/TestStack/ConventionTests/tags","blobs_url":"https://api.github.com/repos/TestStack/ConventionTests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TestStack/ConventionTests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TestStack/ConventionTests/git/refs{/sha}","trees_url":"https://api.github.com/repos/TestStack/ConventionTests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TestStack/ConventionTests/statuses/{sha}","languages_url":"https://api.github.com/repos/TestStack/ConventionTests/languages","stargazers_url":"https://api.github.com/repos/TestStack/ConventionTests/stargazers","contributors_url":"https://api.github.com/repos/TestStack/ConventionTests/contributors","subscribers_url":"https://api.github.com/repos/TestStack/ConventionTests/subscribers","subscription_url":"https://api.github.com/repos/TestStack/ConventionTests/subscription","commits_url":"https://api.github.com/repos/TestStack/ConventionTests/commits{/sha}","git_commits_url":"https://api.github.com/repos/TestStack/ConventionTests/git/commits{/sha}","comments_url":"https://api.github.com/repos/TestStack/ConventionTests/comments{/number}","issue_comment_url":"https://api.github.com/repos/TestStack/ConventionTests/issues/comments/{number}","contents_url":"https://api.github.com/repos/TestStack/ConventionTests/contents/{+path}","compare_url":"https://api.github.com/repos/TestStack/ConventionTests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TestStack/ConventionTests/merges","archive_url":"https://api.github.com/repos/TestStack/ConventionTests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TestStack/ConventionTests/downloads","issues_url":"https://api.github.com/repos/TestStack/ConventionTests/issues{/number}","pulls_url":"https://api.github.com/repos/TestStack/ConventionTests/pulls{/number}","milestones_url":"https://api.github.com/repos/TestStack/ConventionTests/milestones{/number}","notifications_url":"https://api.github.com/repos/TestStack/ConventionTests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TestStack/ConventionTests/labels{/name}","releases_url":"https://api.github.com/repos/TestStack/ConventionTests/releases{/id}","created_at":"2012-05-27T01:42:45Z","updated_at":"2015-01-06T12:16:06Z","pushed_at":"2015-01-06T12:16:06Z","git_url":"git://github.com/TestStack/ConventionTests.git","ssh_url":"git@github.com:TestStack/ConventionTests.git","clone_url":"https://github.com/TestStack/ConventionTests.git","svn_url":"https://github.com/TestStack/ConventionTests","homepage":"http://teststack.github.com/ConventionTests","size":16875,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":9,"forks":7,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62"},"html":{"href":"https://github.com/TestStack/ConventionTests/pull/62"},"issue":{"href":"https://api.github.com/repos/TestStack/ConventionTests/issues/62"},"comments":{"href":"https://api.github.com/repos/TestStack/ConventionTests/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/TestStack/ConventionTests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TestStack/ConventionTests/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/TestStack/ConventionTests/statuses/f6031a6a99f51a266145f283acb1e00cbca24f8d"}}}}