{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/37988097","id":37988097,"diff_hunk":"@@ -491,9 +495,58 @@ public void cancel(JobID jobId) throws Exception {\n \t\t}\n \t}\n \n+\t/**\n+\t * Stops a program on Flink cluster whose job-manager is configured in this client's configuration.\n+\t * Stopping works only for streaming programs. Be aware, that the program might continue to run for\n+\t * a while after sending the stop command, because after sources stopped to emit data all operators\n+\t * need to finish processing.\n+\t * \n+\t * @param jobId\n+\t *            the job ID of the streaming program to stop\n+\t * @throws ProgramStopException\n+\t *             If the job ID in invalid (ie, is unknown or refers to a batch job) of if sending the stop signal\n+\t *             failed. That might be due to an I/O problem, ie, the job-manager is unreachable.\n+\t */\n+\tpublic void stop(JobID jobId) throws ProgramStopException {\n+\t\tLOG.info(\"JobManager actor system address is \" + jobManagerAddress);\n+\t\t\n+\t\tLOG.info(\"Starting client actor system\");\n+\t\tfinal ActorSystem actorSystem;\n+\t\ttry {\n+\t\t\tactorSystem = JobClient.startJobClientActorSystem(configuration);\n+\t\t}\n+\t\tcatch (Exception e) {","path":"flink-clients/src/main/java/org/apache/flink/client/program/Client.java","position":58,"original_position":58,"commit_id":"e95a18c8b4d6db575d533d2c4358d6c76e3c74a4","original_commit_id":"e95a18c8b4d6db575d533d2c4358d6c76e3c74a4","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"try - catch block formatting is not consistent. Here you insert a line break after the `}` and in another block you only insert a whitespace. I'm slightly in favour of the `} catch (...) {` format.","created_at":"2015-08-26T14:28:21Z","updated_at":"2015-08-26T14:28:21Z","html_url":"https://github.com/apache/flink/pull/750#discussion_r37988097","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/750","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/37988097"},"html":{"href":"https://github.com/apache/flink/pull/750#discussion_r37988097"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/750"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/750","id":36557373,"html_url":"https://github.com/apache/flink/pull/750","diff_url":"https://github.com/apache/flink/pull/750.diff","patch_url":"https://github.com/apache/flink/pull/750.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/750","number":750,"state":"open","locked":false,"title":"[FLINK-2111] Add \"stop\" signal to cleanly shutdown streaming jobs","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars.githubusercontent.com/u/8959638?v=3","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"added TERMINATE signal\r\n  - JobManager, TaskManager, ExecutionGraph\r\n  - CliFrontend, JobManagerFrontend\r\n  - StreamTask, StreamSource","created_at":"2015-05-30T01:25:42Z","updated_at":"2015-08-26T14:28:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5f2b75c49f21bc18a420a25a0342646c7676b06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/750/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/750/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/750/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/e95a18c8b4d6db575d533d2c4358d6c76e3c74a4","head":{"label":"mjsax:flink-2111-terminate","ref":"flink-2111-terminate","sha":"e95a18c8b4d6db575d533d2c4358d6c76e3c74a4","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars.githubusercontent.com/u/8959638?v=3","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"repo":{"id":28905963,"name":"flink","full_name":"mjsax/flink","owner":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars.githubusercontent.com/u/8959638?v=3","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjsax/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/mjsax/flink","forks_url":"https://api.github.com/repos/mjsax/flink/forks","keys_url":"https://api.github.com/repos/mjsax/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjsax/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjsax/flink/teams","hooks_url":"https://api.github.com/repos/mjsax/flink/hooks","issue_events_url":"https://api.github.com/repos/mjsax/flink/issues/events{/number}","events_url":"https://api.github.com/repos/mjsax/flink/events","assignees_url":"https://api.github.com/repos/mjsax/flink/assignees{/user}","branches_url":"https://api.github.com/repos/mjsax/flink/branches{/branch}","tags_url":"https://api.github.com/repos/mjsax/flink/tags","blobs_url":"https://api.github.com/repos/mjsax/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjsax/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjsax/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjsax/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjsax/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/mjsax/flink/languages","stargazers_url":"https://api.github.com/repos/mjsax/flink/stargazers","contributors_url":"https://api.github.com/repos/mjsax/flink/contributors","subscribers_url":"https://api.github.com/repos/mjsax/flink/subscribers","subscription_url":"https://api.github.com/repos/mjsax/flink/subscription","commits_url":"https://api.github.com/repos/mjsax/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjsax/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjsax/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjsax/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjsax/flink/contents/{+path}","compare_url":"https://api.github.com/repos/mjsax/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjsax/flink/merges","archive_url":"https://api.github.com/repos/mjsax/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjsax/flink/downloads","issues_url":"https://api.github.com/repos/mjsax/flink/issues{/number}","pulls_url":"https://api.github.com/repos/mjsax/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/mjsax/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/mjsax/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjsax/flink/labels{/name}","releases_url":"https://api.github.com/repos/mjsax/flink/releases{/id}","created_at":"2015-01-07T08:38:24Z","updated_at":"2015-05-05T14:52:09Z","pushed_at":"2015-08-26T12:22:53Z","git_url":"git://github.com/mjsax/flink.git","ssh_url":"git@github.com:mjsax/flink.git","clone_url":"https://github.com/mjsax/flink.git","svn_url":"https://github.com/mjsax/flink","homepage":null,"size":56231,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bc6278716ff759e7eac1ef52240fdc24eef33ced","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-08-25T17:37:35Z","pushed_at":"2015-08-26T14:10:54Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2661143,"stargazers_count":577,"watchers_count":577,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":384,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":79,"forks":384,"open_issues":79,"watchers":577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/750"},"html":{"href":"https://github.com/apache/flink/pull/750"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/750"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/750/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/750/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/750/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/e95a18c8b4d6db575d533d2c4358d6c76e3c74a4"}}}}