{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments/43447789","id":43447789,"diff_hunk":"@@ -33,13 +33,23 @@ export default class JavaScriptScanner {\n           message.ruleId = messages.JS_SYNTAX_ERROR.code;\n         }\n \n+        var code = message.ruleId.toUpperCase();\n+        var messageObj = messages[code];\n+\n+        // Fallback to looking up the message object by the\n+        // constant string passed in context.report()\n+        if (!messageObj && message.message) {","path":"src/scanners/javascript.js","position":9,"original_position":9,"commit_id":"7e3c52e6b5e41cb505535a5d7a5498a6f6269105","original_commit_id":"7e3c52e6b5e41cb505535a5d7a5498a6f6269105","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"Yeah it blows up if description isn't found.","created_at":"2015-10-29T21:37:26Z","updated_at":"2015-10-29T21:37:26Z","html_url":"https://github.com/mozilla/addons-validator/pull/176#discussion_r43447789","pull_request_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments/43447789"},"html":{"href":"https://github.com/mozilla/addons-validator/pull/176#discussion_r43447789"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-validator/pulls/176","id":49203038,"html_url":"https://github.com/mozilla/addons-validator/pull/176","diff_url":"https://github.com/mozilla/addons-validator/pull/176.diff","patch_url":"https://github.com/mozilla/addons-validator/pull/176.patch","issue_url":"https://api.github.com/repos/mozilla/addons-validator/issues/176","number":176,"state":"open","locked":false,"title":"Add rule for banned_identifiers","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"Fixes #175","created_at":"2015-10-29T21:31:17Z","updated_at":"2015-10-29T21:37:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a92ae545babd15614796a2b2b4070e2981dd1eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/176/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/176/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/issues/176/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/7e3c52e6b5e41cb505535a5d7a5498a6f6269105","head":{"label":"muffinresearch:banned-identifiers","ref":"banned-identifiers","sha":"7e3c52e6b5e41cb505535a5d7a5498a6f6269105","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"repo":{"id":42520293,"name":"addons-validator","full_name":"muffinresearch/addons-validator","owner":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffinresearch/addons-validator","description":"The amo-validator, JS edition.","fork":true,"url":"https://api.github.com/repos/muffinresearch/addons-validator","forks_url":"https://api.github.com/repos/muffinresearch/addons-validator/forks","keys_url":"https://api.github.com/repos/muffinresearch/addons-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffinresearch/addons-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffinresearch/addons-validator/teams","hooks_url":"https://api.github.com/repos/muffinresearch/addons-validator/hooks","issue_events_url":"https://api.github.com/repos/muffinresearch/addons-validator/issues/events{/number}","events_url":"https://api.github.com/repos/muffinresearch/addons-validator/events","assignees_url":"https://api.github.com/repos/muffinresearch/addons-validator/assignees{/user}","branches_url":"https://api.github.com/repos/muffinresearch/addons-validator/branches{/branch}","tags_url":"https://api.github.com/repos/muffinresearch/addons-validator/tags","blobs_url":"https://api.github.com/repos/muffinresearch/addons-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffinresearch/addons-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffinresearch/addons-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffinresearch/addons-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffinresearch/addons-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/muffinresearch/addons-validator/languages","stargazers_url":"https://api.github.com/repos/muffinresearch/addons-validator/stargazers","contributors_url":"https://api.github.com/repos/muffinresearch/addons-validator/contributors","subscribers_url":"https://api.github.com/repos/muffinresearch/addons-validator/subscribers","subscription_url":"https://api.github.com/repos/muffinresearch/addons-validator/subscription","commits_url":"https://api.github.com/repos/muffinresearch/addons-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffinresearch/addons-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffinresearch/addons-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffinresearch/addons-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/muffinresearch/addons-validator/contents/{+path}","compare_url":"https://api.github.com/repos/muffinresearch/addons-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffinresearch/addons-validator/merges","archive_url":"https://api.github.com/repos/muffinresearch/addons-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffinresearch/addons-validator/downloads","issues_url":"https://api.github.com/repos/muffinresearch/addons-validator/issues{/number}","pulls_url":"https://api.github.com/repos/muffinresearch/addons-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/muffinresearch/addons-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/muffinresearch/addons-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffinresearch/addons-validator/labels{/name}","releases_url":"https://api.github.com/repos/muffinresearch/addons-validator/releases{/id}","created_at":"2015-09-15T13:14:50Z","updated_at":"2015-09-14T22:18:36Z","pushed_at":"2015-10-29T21:30:44Z","git_url":"git://github.com/muffinresearch/addons-validator.git","ssh_url":"git@github.com:muffinresearch/addons-validator.git","clone_url":"https://github.com/muffinresearch/addons-validator.git","svn_url":"https://github.com/muffinresearch/addons-validator","homepage":null,"size":306,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c6e8c45ba03b7c7743172350196b328a7198f0e1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":42436885,"name":"addons-validator","full_name":"mozilla/addons-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-validator","description":"The new Firefox Add-ons validator, written in ES6/JavaScript.","fork":false,"url":"https://api.github.com/repos/mozilla/addons-validator","forks_url":"https://api.github.com/repos/mozilla/addons-validator/forks","keys_url":"https://api.github.com/repos/mozilla/addons-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-validator/events","assignees_url":"https://api.github.com/repos/mozilla/addons-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-validator/merges","archive_url":"https://api.github.com/repos/mozilla/addons-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-validator/releases{/id}","created_at":"2015-09-14T08:34:44Z","updated_at":"2015-10-24T03:57:22Z","pushed_at":"2015-10-29T21:31:17Z","git_url":"git://github.com/mozilla/addons-validator.git","ssh_url":"git@github.com:mozilla/addons-validator.git","clone_url":"https://github.com/mozilla/addons-validator.git","svn_url":"https://github.com/mozilla/addons-validator","homepage":"","size":1625,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":41,"forks":2,"open_issues":41,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/176"},"html":{"href":"https://github.com/mozilla/addons-validator/pull/176"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-validator/issues/176"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-validator/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-validator/statuses/7e3c52e6b5e41cb505535a5d7a5498a6f6269105"}}}}