{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40471845","id":40471845,"diff_hunk":"@@ -0,0 +1,15 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+namespace System.Net.Sockets.Tests\n+{\n+    static class SocketTestExtensions\n+    {\n+        // Binds to an IP address and OS-assigned port. Returns the chosen port.\n+        public static int Bind(this Socket socket, IPAddress address)","path":"src/Common/tests/System.Net/Sockets/SocketTestExtensions.cs","position":9,"original_position":9,"commit_id":"c9fe2ad047375fef597356a38704aeccfad1be4d","original_commit_id":"c9fe2ad047375fef597356a38704aeccfad1be4d","user":{"login":"CIPop","id":8635911,"avatar_url":"https://avatars.githubusercontent.com/u/8635911?v=3","gravatar_id":"","url":"https://api.github.com/users/CIPop","html_url":"https://github.com/CIPop","followers_url":"https://api.github.com/users/CIPop/followers","following_url":"https://api.github.com/users/CIPop/following{/other_user}","gists_url":"https://api.github.com/users/CIPop/gists{/gist_id}","starred_url":"https://api.github.com/users/CIPop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CIPop/subscriptions","organizations_url":"https://api.github.com/users/CIPop/orgs","repos_url":"https://api.github.com/users/CIPop/repos","events_url":"https://api.github.com/users/CIPop/events{/privacy}","received_events_url":"https://api.github.com/users/CIPop/received_events","type":"User","site_admin":false},"body":"Looks like an overload for Bind. In my opinion this is confusing. Maybe using a simple static helper function would be easier to understand.","created_at":"2015-09-25T20:25:40Z","updated_at":"2015-09-25T20:25:40Z","html_url":"https://github.com/dotnet/corefx/pull/3469#discussion_r40471845","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3469","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40471845"},"html":{"href":"https://github.com/dotnet/corefx/pull/3469#discussion_r40471845"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3469"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3469","id":46047068,"html_url":"https://github.com/dotnet/corefx/pull/3469","diff_url":"https://github.com/dotnet/corefx/pull/3469.diff","patch_url":"https://github.com/dotnet/corefx/pull/3469.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3469","number":3469,"state":"open","locked":false,"title":"Fix a behavior mismatch in Linux Sockets.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"Winsock tolerates a call to shutdown[1, 2] on a TCP socket whose underlying\r\nconnection has already transitioned to the CLOSED state[3]. Linux, however,\r\nreturns ENOTCONN, since the connection is already closed.\r\n\r\nThis change fixes the mismatch by exposing the socket instance's connection\r\nstate (i.e. Socket._isConnected) to the PAL and changing the *nix\r\nimplementation of SocketPal.Shutdown to ignore ENOTCONN if the socket is\r\nconnected.","created_at":"2015-09-25T19:11:12Z","updated_at":"2015-09-25T20:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ce33f1fc0448ed9c923fbe7e68e610663ee8664","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3469/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3469/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3469/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/c9fe2ad047375fef597356a38704aeccfad1be4d","head":{"label":"pgavlin:SocketsFix","ref":"SocketsFix","sha":"c9fe2ad047375fef597356a38704aeccfad1be4d","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":27393660,"name":"corefx","full_name":"pgavlin/corefx","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/pgavlin/corefx","forks_url":"https://api.github.com/repos/pgavlin/corefx/forks","keys_url":"https://api.github.com/repos/pgavlin/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/corefx/teams","hooks_url":"https://api.github.com/repos/pgavlin/corefx/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/corefx/events","assignees_url":"https://api.github.com/repos/pgavlin/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/corefx/tags","blobs_url":"https://api.github.com/repos/pgavlin/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/corefx/languages","stargazers_url":"https://api.github.com/repos/pgavlin/corefx/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/corefx/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/corefx/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/corefx/subscription","commits_url":"https://api.github.com/repos/pgavlin/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/corefx/merges","archive_url":"https://api.github.com/repos/pgavlin/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/corefx/downloads","issues_url":"https://api.github.com/repos/pgavlin/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/corefx/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/corefx/releases{/id}","created_at":"2014-12-01T18:38:07Z","updated_at":"2014-12-01T18:38:09Z","pushed_at":"2015-09-25T19:11:01Z","git_url":"git://github.com/pgavlin/corefx.git","ssh_url":"git@github.com:pgavlin/corefx.git","clone_url":"https://github.com/pgavlin/corefx.git","svn_url":"https://github.com/pgavlin/corefx","homepage":"","size":33549,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"da945695aa3306b06cfe656f6e3a5fce34398c68","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-09-25T18:41:11Z","pushed_at":"2015-09-25T19:29:32Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":72016,"stargazers_count":8387,"watchers_count":8387,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1813,"mirror_url":null,"open_issues_count":600,"forks":1813,"open_issues":600,"watchers":8387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3469"},"html":{"href":"https://github.com/dotnet/corefx/pull/3469"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3469"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3469/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3469/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3469/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/c9fe2ad047375fef597356a38704aeccfad1be4d"}}}}