{"action":"created","issue":{"url":"https://api.github.com/repos/the-lambda-church/merlin/issues/409","labels_url":"https://api.github.com/repos/the-lambda-church/merlin/issues/409/labels{/name}","comments_url":"https://api.github.com/repos/the-lambda-church/merlin/issues/409/comments","events_url":"https://api.github.com/repos/the-lambda-church/merlin/issues/409/events","html_url":"https://github.com/the-lambda-church/merlin/pull/409","id":90433079,"number":409,"title":"Revised commits for Windows/mingw32","user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-06-23T16:31:06Z","updated_at":"2015-10-30T16:02:15Z","closed_at":"2015-07-01T09:51:08Z","pull_request":{"url":"https://api.github.com/repos/the-lambda-church/merlin/pulls/409","html_url":"https://github.com/the-lambda-church/merlin/pull/409","diff_url":"https://github.com/the-lambda-church/merlin/pull/409.diff","patch_url":"https://github.com/the-lambda-church/merlin/pull/409.patch"},"body":"Finally found some time for upgrading Merlin from the patched 1.6 I'd been using. Patches very similar to those for #194 (some issues had already been fixed or become irrelevant) only as I'm a bit less unfamiliar with git now, I've broken the changes into multiple commits for easier cherry picking if necessary.\r\nAn adapted version of this branch also compiles against v2.2 (the whitespace clean-up of vim/merlin/autoload/merlin.py in 8c28e236 means the patch doesn't apply cleaning against v2.2)\r\nI've tested it with gVim 7.4.752 x64 on Windows 7 with Python 2.7.10/3.4.3 for OCaml 4.02.2 i686-w64-mingw32 and it seems to be working beautifully.\r\na3b240b is critical for building with native Windows ports as ln isn't available\r\nacc4ceb is critical for Vim support on Windows - since reporting that in #194, I've discovered that it is indeed a long-standing bug in Python (and the code is commented accordingly)\r\nRemaining commits, at least with a very current Cygwin, seem to be cosmetic."},"comment":{"url":"https://api.github.com/repos/the-lambda-church/merlin/issues/comments/152566254","html_url":"https://github.com/the-lambda-church/merlin/pull/409#issuecomment-152566254","issue_url":"https://api.github.com/repos/the-lambda-church/merlin/issues/409","id":152566254,"user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T16:02:15Z","updated_at":"2015-10-30T16:02:15Z","body":"Yes - Windows really doesn't run without it set (the Command Processor doesn't work and it affects the shell in other unexpected ways). What I've never been utterly certain is whether you can reasonably depend on COMSPEC not being used on any Unix variant.\r\nIncidentally, having done quite a lot of work on symbolic links on Windows recently, it would be good to see the test correctly checking whether ln works, rather than just simply disabling it completely on Windows - see https://github.com/dra27/dose/blob/windows/configure.ac#L265-L273"}}