{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments/24038306","id":24038306,"diff_hunk":"@@ -13,7 +13,27 @@\n     <script type=\"text/javascript\" charset=\"utf-8\" src=\"js/jquery.js\"></script>\n     <script type=\"text/javascript\" charset=\"utf-8\" src=\"js/app.js\"></script>\n     <script type=\"text/javascript\" charset=\"utf-8\" src=\"js/highlight.pack.js\"></script>\n-    <script>hljs.initHighlightingOnLoad();</script>\n+    <script type=\"text/javascript\" charset=\"utf-8\">\n+      hljs.initHighlightingOnLoad();\n+      // languages supported: 'bash', 'coffeescript', 'css', 'diff', 'elixir', 'erlang', 'erlang-repl', 'http', 'javascript', 'json', 'markdown', 'sql', 'xml'","path":"lib/ex_doc/formatter/html/templates/module_template.eex","position":7,"original_position":7,"commit_id":"a3d395e14621339225ab55a9c72fbec5cf208fd6","original_commit_id":"a3d395e14621339225ab55a9c72fbec5cf208fd6","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"We could add to the README. Actually, a section about syntax highlighting and mentioning that we use highlight.js would be really welcome!","created_at":"2015-02-03T20:49:16Z","updated_at":"2015-02-03T20:49:16Z","html_url":"https://github.com/elixir-lang/ex_doc/pull/185#discussion_r24038306","pull_request_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments/24038306"},"html":{"href":"https://github.com/elixir-lang/ex_doc/pull/185#discussion_r24038306"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185","id":28410354,"html_url":"https://github.com/elixir-lang/ex_doc/pull/185","diff_url":"https://github.com/elixir-lang/ex_doc/pull/185.diff","patch_url":"https://github.com/elixir-lang/ex_doc/pull/185.patch","issue_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/185","number":185,"state":"open","locked":false,"title":"update highlightjs to support more languages","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"body":"highlight.js has been updated\r\n* hightlight.js updated to latest version (v8.4)\r\n* Highlighting support for all these languages: Bash, CoffeeScript, CSS, Diff, Elixir, Erlang, Erlang-REPL, HTML/XML, HTTP, JavaScript, JSON, Markdown, SQL.\r\n* Header added to the hightligh.js library, showing the options were used to compile it, including license, copyright notice, and the date it was downloaded  (solving issue #173)\r\n*  highlighting autodetect has been disabled\r\n* any language in the code blocks can be defined, even though the ones not supported, but when no language is specified, the default is elixir (this solves the issue why this previous PR had to be reverted:  https://github.com/elixir-lang/ex_doc/pull/182#issuecomment-70820109 )\r\n* IEX code is detected and a class is added ( solving https://github.com/elixir-lang/ex_doc/issues/172#issuecomment-67610083 )\r\n* Dependencies have been updated\r\n\r\nPending Improvements:\r\n1. Elixir markup have some issues, It needs to be reported to the maintainers. I have used [this test file](https://bitbucket.org/birkenfeld/pygments-main/src/tip/tests/examplefiles/example_elixir.ex)\r\n2. We are lacking Iex support, if anybody wants to tackle down on it. [There is already support for it in pygments](https://bitbucket.org/birkenfeld/pygments-main/commits/45af979829ad0bad180224ceb6d30f13d0d2bc6e), I'm not sure if that helps when porting it to highlight.js\r\n3. Support for markdown is very poor and there is not much highlighting\r\n4. I have added to the header of the file html files the languages supported, and their alias, just because I didn't know where to put it in the ex_doc documentation, so if anybody knows a good place, we can add it, and provide examples of how to include code from other languages.\r\n```\r\n    // Languages supported and their aliases\r\n    bash, sh, zsh,\r\n    coffeescript, coffee, cson, iced,\r\n    css,\r\n    diff, patch,\r\n    elixir, iex,\r\n    erlang, erl,\r\n    erlang-repl,\r\n    http,\r\n    javascript, js,\r\n    json,\r\n    markdown, md, mkdown, mkd,\r\n    sql,\r\n    xml, html, xhtml, rss, atom, xsl, plist,\r\n```","created_at":"2015-01-31T05:46:38Z","updated_at":"2015-02-03T20:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b87649b5bfce630f6797ad13638d4fd821367041","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/185/comments","statuses_url":"https://api.github.com/repos/elixir-lang/ex_doc/statuses/a3d395e14621339225ab55a9c72fbec5cf208fd6","head":{"label":"eksperimental:highlightjs_headers2++","ref":"highlightjs_headers2++","sha":"a3d395e14621339225ab55a9c72fbec5cf208fd6","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"repo":{"id":25037635,"name":"ex_doc","full_name":"eksperimental/ex_doc","owner":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eksperimental/ex_doc","description":"ExDoc produces HTML and online documentation for Elixir projects","fork":true,"url":"https://api.github.com/repos/eksperimental/ex_doc","forks_url":"https://api.github.com/repos/eksperimental/ex_doc/forks","keys_url":"https://api.github.com/repos/eksperimental/ex_doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eksperimental/ex_doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eksperimental/ex_doc/teams","hooks_url":"https://api.github.com/repos/eksperimental/ex_doc/hooks","issue_events_url":"https://api.github.com/repos/eksperimental/ex_doc/issues/events{/number}","events_url":"https://api.github.com/repos/eksperimental/ex_doc/events","assignees_url":"https://api.github.com/repos/eksperimental/ex_doc/assignees{/user}","branches_url":"https://api.github.com/repos/eksperimental/ex_doc/branches{/branch}","tags_url":"https://api.github.com/repos/eksperimental/ex_doc/tags","blobs_url":"https://api.github.com/repos/eksperimental/ex_doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eksperimental/ex_doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eksperimental/ex_doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/eksperimental/ex_doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eksperimental/ex_doc/statuses/{sha}","languages_url":"https://api.github.com/repos/eksperimental/ex_doc/languages","stargazers_url":"https://api.github.com/repos/eksperimental/ex_doc/stargazers","contributors_url":"https://api.github.com/repos/eksperimental/ex_doc/contributors","subscribers_url":"https://api.github.com/repos/eksperimental/ex_doc/subscribers","subscription_url":"https://api.github.com/repos/eksperimental/ex_doc/subscription","commits_url":"https://api.github.com/repos/eksperimental/ex_doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/eksperimental/ex_doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/eksperimental/ex_doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/eksperimental/ex_doc/issues/comments/{number}","contents_url":"https://api.github.com/repos/eksperimental/ex_doc/contents/{+path}","compare_url":"https://api.github.com/repos/eksperimental/ex_doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eksperimental/ex_doc/merges","archive_url":"https://api.github.com/repos/eksperimental/ex_doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eksperimental/ex_doc/downloads","issues_url":"https://api.github.com/repos/eksperimental/ex_doc/issues{/number}","pulls_url":"https://api.github.com/repos/eksperimental/ex_doc/pulls{/number}","milestones_url":"https://api.github.com/repos/eksperimental/ex_doc/milestones{/number}","notifications_url":"https://api.github.com/repos/eksperimental/ex_doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eksperimental/ex_doc/labels{/name}","releases_url":"https://api.github.com/repos/eksperimental/ex_doc/releases{/id}","created_at":"2014-10-10T13:52:43Z","updated_at":"2015-02-02T17:17:53Z","pushed_at":"2015-02-03T19:37:09Z","git_url":"git://github.com/eksperimental/ex_doc.git","ssh_url":"git@github.com:eksperimental/ex_doc.git","clone_url":"https://github.com/eksperimental/ex_doc.git","svn_url":"https://github.com/eksperimental/ex_doc","homepage":"http://elixir-lang.org","size":990,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"5b520c4cad67c3a4b55042ca588ecfb5bea0b41f","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":3642931,"name":"ex_doc","full_name":"elixir-lang/ex_doc","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/ex_doc","description":"ExDoc produces HTML and online documentation for Elixir projects","fork":false,"url":"https://api.github.com/repos/elixir-lang/ex_doc","forks_url":"https://api.github.com/repos/elixir-lang/ex_doc/forks","keys_url":"https://api.github.com/repos/elixir-lang/ex_doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/ex_doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/ex_doc/teams","hooks_url":"https://api.github.com/repos/elixir-lang/ex_doc/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/ex_doc/events","assignees_url":"https://api.github.com/repos/elixir-lang/ex_doc/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/ex_doc/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/ex_doc/tags","blobs_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/ex_doc/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/ex_doc/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/ex_doc/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/ex_doc/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/ex_doc/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/ex_doc/subscription","commits_url":"https://api.github.com/repos/elixir-lang/ex_doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/ex_doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/ex_doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues/comments/{number}","contents_url":"https://api.github.com/repos/elixir-lang/ex_doc/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/ex_doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/ex_doc/merges","archive_url":"https://api.github.com/repos/elixir-lang/ex_doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/ex_doc/downloads","issues_url":"https://api.github.com/repos/elixir-lang/ex_doc/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/ex_doc/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/ex_doc/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/ex_doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/ex_doc/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/ex_doc/releases{/id}","created_at":"2012-03-06T21:35:38Z","updated_at":"2015-01-28T19:02:13Z","pushed_at":"2015-01-28T19:02:13Z","git_url":"git://github.com/elixir-lang/ex_doc.git","ssh_url":"git@github.com:elixir-lang/ex_doc.git","clone_url":"https://github.com/elixir-lang/ex_doc.git","svn_url":"https://github.com/elixir-lang/ex_doc","homepage":"http://elixir-lang.org","size":1934,"stargazers_count":59,"watchers_count":59,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185"},"html":{"href":"https://github.com/elixir-lang/ex_doc/pull/185"},"issue":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/issues/185"},"comments":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/ex_doc/statuses/a3d395e14621339225ab55a9c72fbec5cf208fd6"}}}}