{"action":"created","issue":{"url":"https://api.github.com/repos/DHrpcs3/rpcs3/issues/976","labels_url":"https://api.github.com/repos/DHrpcs3/rpcs3/issues/976/labels{/name}","comments_url":"https://api.github.com/repos/DHrpcs3/rpcs3/issues/976/comments","events_url":"https://api.github.com/repos/DHrpcs3/rpcs3/issues/976/events","html_url":"https://github.com/DHrpcs3/rpcs3/pull/976","id":55382661,"number":976,"title":"Various fixes and improvements","user":{"login":"tambry","id":1827708,"avatar_url":"https://avatars.githubusercontent.com/u/1827708?v=3","gravatar_id":"","url":"https://api.github.com/users/tambry","html_url":"https://github.com/tambry","followers_url":"https://api.github.com/users/tambry/followers","following_url":"https://api.github.com/users/tambry/following{/other_user}","gists_url":"https://api.github.com/users/tambry/gists{/gist_id}","starred_url":"https://api.github.com/users/tambry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambry/subscriptions","organizations_url":"https://api.github.com/users/tambry/orgs","repos_url":"https://api.github.com/users/tambry/repos","events_url":"https://api.github.com/users/tambry/events{/privacy}","received_events_url":"https://api.github.com/users/tambry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-24T19:51:50Z","updated_at":"2015-01-25T13:55:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DHrpcs3/rpcs3/pulls/976","html_url":"https://github.com/DHrpcs3/rpcs3/pull/976","diff_url":"https://github.com/DHrpcs3/rpcs3/pull/976.diff","patch_url":"https://github.com/DHrpcs3/rpcs3/pull/976.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/DHrpcs3/rpcs3/issues/comments/71374071","html_url":"https://github.com/DHrpcs3/rpcs3/pull/976#issuecomment-71374071","issue_url":"https://api.github.com/repos/DHrpcs3/rpcs3/issues/976","id":71374071,"user":{"login":"Nekotekina","id":6028184,"avatar_url":"https://avatars.githubusercontent.com/u/6028184?v=3","gravatar_id":"","url":"https://api.github.com/users/Nekotekina","html_url":"https://github.com/Nekotekina","followers_url":"https://api.github.com/users/Nekotekina/followers","following_url":"https://api.github.com/users/Nekotekina/following{/other_user}","gists_url":"https://api.github.com/users/Nekotekina/gists{/gist_id}","starred_url":"https://api.github.com/users/Nekotekina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nekotekina/subscriptions","organizations_url":"https://api.github.com/users/Nekotekina/orgs","repos_url":"https://api.github.com/users/Nekotekina/repos","events_url":"https://api.github.com/users/Nekotekina/events{/privacy}","received_events_url":"https://api.github.com/users/Nekotekina/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T13:55:16Z","updated_at":"2015-01-25T13:55:16Z","body":"Well, this PR seems inaccurate.\r\n\r\n1) return{} is removed only in 3 places but appears in 11.\r\n2) PPUThread.h and vfsDirBase.h - totally not sure about this.\r\n3) cellGcmSys: seems broken because m_frequency_mode value is not set for all cases.\r\n4) cellSync: I cannot confirm that it should always return CELL_SYNC_ERROR_AGAIN, it requires reversing.\r\n5) cellMsgDialog: it better be changed from TTY to HLE, because printing it to TTY makes no sense.\r\n6) cellMsgDialog: sprintf_s is not portable, I'm not sure why travis didn't fail on it. Better to leave sprintf.\r\n7) CompilerElf.cpp: not sure why this code is commented. Anyway it's better to use // style on every line."}}