{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/38608834","id":38608834,"diff_hunk":"@@ -136,7 +136,10 @@ struct StringPtr {\n \n   Local<String> ToString(Environment* env) const {\n     if (str_)\n-      return OneByteString(env->isolate(), str_, size_);\n+      return String::NewFromUtf8(env->isolate(),","path":"src/node_http_parser.cc","position":5,"original_position":5,"commit_id":"6e3df44a9da1f0289988f484a5f0b32859241c5d","original_commit_id":"6e3df44a9da1f0289988f484a5f0b32859241c5d","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"The benchmarks would be bias in out current benchmarks. We need to set some up that have various header lengths.","created_at":"2015-09-03T02:45:09Z","updated_at":"2015-09-03T02:45:09Z","html_url":"https://github.com/nodejs/node/pull/2629#discussion_r38608834","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/2629","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/38608834"},"html":{"href":"https://github.com/nodejs/node/pull/2629#discussion_r38608834"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/2629"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2629","id":43791952,"html_url":"https://github.com/nodejs/node/pull/2629","diff_url":"https://github.com/nodejs/node/pull/2629.diff","patch_url":"https://github.com/nodejs/node/pull/2629.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/2629","number":2629,"state":"open","locked":false,"title":"http: interpret strings as utf8","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"body":"See https://github.com/nodejs/node/issues/1693\r\n\r\nAt some point `http` began to interpret all strings as `binary`. This causes various incompatibilities in both incoming and outgoing messages. Incoming message seem more problematic, since both url and header values could be corrupted and there is no good way to tell whether they are.\r\n\r\nIt's probably right that clients should properly encode urls and headers, but some don't and this used to work, so a lot of code is broken by this change.\r\n\r\nR=@bnoordhuis ","created_at":"2015-08-31T18:09:28Z","updated_at":"2015-09-03T02:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f614973c25dee3420e47ee1755fd8d3dd40868c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/2629/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/2629/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2629/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/6e3df44a9da1f0289988f484a5f0b32859241c5d","head":{"label":"vkurchatkin:http-incoming-utf8","ref":"http-incoming-utf8","sha":"6e3df44a9da1f0289988f484a5f0b32859241c5d","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"repo":{"id":28152690,"name":"io.js","full_name":"vkurchatkin/io.js","owner":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkurchatkin/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/vkurchatkin/io.js","forks_url":"https://api.github.com/repos/vkurchatkin/io.js/forks","keys_url":"https://api.github.com/repos/vkurchatkin/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkurchatkin/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkurchatkin/io.js/teams","hooks_url":"https://api.github.com/repos/vkurchatkin/io.js/hooks","issue_events_url":"https://api.github.com/repos/vkurchatkin/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/vkurchatkin/io.js/events","assignees_url":"https://api.github.com/repos/vkurchatkin/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/vkurchatkin/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/vkurchatkin/io.js/tags","blobs_url":"https://api.github.com/repos/vkurchatkin/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkurchatkin/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkurchatkin/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkurchatkin/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkurchatkin/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/vkurchatkin/io.js/languages","stargazers_url":"https://api.github.com/repos/vkurchatkin/io.js/stargazers","contributors_url":"https://api.github.com/repos/vkurchatkin/io.js/contributors","subscribers_url":"https://api.github.com/repos/vkurchatkin/io.js/subscribers","subscription_url":"https://api.github.com/repos/vkurchatkin/io.js/subscription","commits_url":"https://api.github.com/repos/vkurchatkin/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkurchatkin/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkurchatkin/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkurchatkin/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/vkurchatkin/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/vkurchatkin/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkurchatkin/io.js/merges","archive_url":"https://api.github.com/repos/vkurchatkin/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkurchatkin/io.js/downloads","issues_url":"https://api.github.com/repos/vkurchatkin/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/vkurchatkin/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/vkurchatkin/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/vkurchatkin/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkurchatkin/io.js/labels{/name}","releases_url":"https://api.github.com/repos/vkurchatkin/io.js/releases{/id}","created_at":"2014-12-17T19:47:50Z","updated_at":"2014-12-23T18:30:27Z","pushed_at":"2015-08-31T18:01:12Z","git_url":"git://github.com/vkurchatkin/io.js.git","ssh_url":"git@github.com:vkurchatkin/io.js.git","clone_url":"https://github.com/vkurchatkin/io.js.git","svn_url":"https://github.com/vkurchatkin/io.js","homepage":null,"size":140320,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.12"}},"base":{"label":"nodejs:master","ref":"master","sha":"97dfbdb6505e41ba8b8d541073fb139f5824d9df","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Future Node.js releases will be from this repo. ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-09-03T02:32:24Z","pushed_at":"2015-09-03T02:26:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://iojs.org","size":203197,"stargazers_count":13737,"watchers_count":13737,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1148,"mirror_url":null,"open_issues_count":383,"forks":1148,"open_issues":383,"watchers":13737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/2629"},"html":{"href":"https://github.com/nodejs/node/pull/2629"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/2629"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/2629/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/2629/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/2629/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/6e3df44a9da1f0289988f484a5f0b32859241c5d"}}}}