{"action":"created","issue":{"url":"https://api.github.com/repos/bendrucker/emit-then/issues/2","labels_url":"https://api.github.com/repos/bendrucker/emit-then/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/bendrucker/emit-then/issues/2/comments","events_url":"https://api.github.com/repos/bendrucker/emit-then/issues/2/events","html_url":"https://github.com/bendrucker/emit-then/pull/2","id":119070658,"number":2,"title":"Update to use native Promise + other new Node features","user":{"login":"voxpelli","id":34457,"avatar_url":"https://avatars.githubusercontent.com/u/34457?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpelli","html_url":"https://github.com/voxpelli","followers_url":"https://api.github.com/users/voxpelli/followers","following_url":"https://api.github.com/users/voxpelli/following{/other_user}","gists_url":"https://api.github.com/users/voxpelli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpelli/subscriptions","organizations_url":"https://api.github.com/users/voxpelli/orgs","repos_url":"https://api.github.com/users/voxpelli/repos","events_url":"https://api.github.com/users/voxpelli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpelli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-26T16:02:33Z","updated_at":"2015-11-26T18:10:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bendrucker/emit-then/pulls/2","html_url":"https://github.com/bendrucker/emit-then/pull/2","diff_url":"https://github.com/bendrucker/emit-then/pull/2.diff","patch_url":"https://github.com/bendrucker/emit-then/pull/2.patch"},"body":"I really like the concept of this module and will start using it in a project of mine.\r\n\r\nLooking at the code though, I couldn't help but notice that the module currently uses `Bluebird` for the Promises, which feels a bit overkill for the use case. Since Node.js nowadays support native Promises I think it would be preferable for a small module like this one to use that and to have any user of the module convert the native Promise to a Bluebird Promise in the places they desire the additional capabilities that provide.\r\n\r\nSo this PR converts the module to native Promises and makes use of the arrow functions that are supported since Node 5 to make the Promise code a bit nicer thanks to theirs lexical `this`.\r\n\r\nI also threw in a change that no longer accesses the `EventEmitter` class as a property of the `events` module as that's no longer needed + moved the inclusion of the `events` module to only happen when someone wants to extend the global object.\r\n\r\nWhat are your thoughts on this? Are you positive to the idea of a new version geared towards Node 5?"},"comment":{"url":"https://api.github.com/repos/bendrucker/emit-then/issues/comments/159971144","html_url":"https://github.com/bendrucker/emit-then/pull/2#issuecomment-159971144","issue_url":"https://api.github.com/repos/bendrucker/emit-then/issues/2","id":159971144,"user":{"login":"bendrucker","id":808808,"avatar_url":"https://avatars.githubusercontent.com/u/808808?v=3","gravatar_id":"","url":"https://api.github.com/users/bendrucker","html_url":"https://github.com/bendrucker","followers_url":"https://api.github.com/users/bendrucker/followers","following_url":"https://api.github.com/users/bendrucker/following{/other_user}","gists_url":"https://api.github.com/users/bendrucker/gists{/gist_id}","starred_url":"https://api.github.com/users/bendrucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendrucker/subscriptions","organizations_url":"https://api.github.com/users/bendrucker/orgs","repos_url":"https://api.github.com/users/bendrucker/repos","events_url":"https://api.github.com/users/bendrucker/events{/privacy}","received_events_url":"https://api.github.com/users/bendrucker/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T18:10:21Z","updated_at":"2015-11-26T18:10:21Z","body":"GH doesn't seem to be updating the PR feed properly. I'll check out and merge manually. "}}