{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/26","id":28890294,"html_url":"https://github.com/wchen-r7/metasploit-framework/pull/26","diff_url":"https://github.com/wchen-r7/metasploit-framework/pull/26.diff","patch_url":"https://github.com/wchen-r7/metasploit-framework/pull/26.patch","issue_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/26","number":26,"state":"open","locked":false,"title":"Make safer Change AllowWin32SEH","user":{"login":"jvazquez-r7","id":1742838,"avatar_url":"https://avatars.githubusercontent.com/u/1742838?v=3","gravatar_id":"","url":"https://api.github.com/users/jvazquez-r7","html_url":"https://github.com/jvazquez-r7","followers_url":"https://api.github.com/users/jvazquez-r7/followers","following_url":"https://api.github.com/users/jvazquez-r7/following{/other_user}","gists_url":"https://api.github.com/users/jvazquez-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jvazquez-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvazquez-r7/subscriptions","organizations_url":"https://api.github.com/users/jvazquez-r7/orgs","repos_url":"https://api.github.com/users/jvazquez-r7/repos","events_url":"https://api.github.com/users/jvazquez-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jvazquez-r7/received_events","type":"User","site_admin":false},"body":"Hello @wchen-r7, this PR is related to https://github.com/rapid7/metasploit-framework/pull/4724\r\n\r\nSince it is changing default behavior of two encoders, and unfortunately there are a lot of modules forcing these encoders, but not providing ```BufferRegister``` I think would be good to set ```AllowWin32SEH``` as ```true``` as ```DefaultOptions``` so, hopefully, the old behavior remains. Ideally these modules should be rewritten to a) Don't force the encoder to use, b) Provide BufferRegister. But since I don't think we can accomplish that task in a reasonable time... trying to make it just safer by no changing the old behavior. What do you think.","created_at":"2015-02-09T00:33:29Z","updated_at":"2015-02-09T00:33:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/26/commits","review_comments_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/26/comments","review_comment_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/26/comments","statuses_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/statuses/831a1494ac135c5c00e6ec5fd9f34e19ac66cc74","head":{"label":"jvazquez-r7:review_4724","ref":"review_4724","sha":"831a1494ac135c5c00e6ec5fd9f34e19ac66cc74","user":{"login":"jvazquez-r7","id":1742838,"avatar_url":"https://avatars.githubusercontent.com/u/1742838?v=3","gravatar_id":"","url":"https://api.github.com/users/jvazquez-r7","html_url":"https://github.com/jvazquez-r7","followers_url":"https://api.github.com/users/jvazquez-r7/followers","following_url":"https://api.github.com/users/jvazquez-r7/following{/other_user}","gists_url":"https://api.github.com/users/jvazquez-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jvazquez-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvazquez-r7/subscriptions","organizations_url":"https://api.github.com/users/jvazquez-r7/orgs","repos_url":"https://api.github.com/users/jvazquez-r7/repos","events_url":"https://api.github.com/users/jvazquez-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jvazquez-r7/received_events","type":"User","site_admin":false},"repo":{"id":6786012,"name":"metasploit-framework","full_name":"jvazquez-r7/metasploit-framework","owner":{"login":"jvazquez-r7","id":1742838,"avatar_url":"https://avatars.githubusercontent.com/u/1742838?v=3","gravatar_id":"","url":"https://api.github.com/users/jvazquez-r7","html_url":"https://github.com/jvazquez-r7","followers_url":"https://api.github.com/users/jvazquez-r7/followers","following_url":"https://api.github.com/users/jvazquez-r7/following{/other_user}","gists_url":"https://api.github.com/users/jvazquez-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jvazquez-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvazquez-r7/subscriptions","organizations_url":"https://api.github.com/users/jvazquez-r7/orgs","repos_url":"https://api.github.com/users/jvazquez-r7/repos","events_url":"https://api.github.com/users/jvazquez-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jvazquez-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvazquez-r7/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework","forks_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/jvazquez-r7/metasploit-framework/releases{/id}","created_at":"2012-11-20T22:07:34Z","updated_at":"2015-02-09T00:11:27Z","pushed_at":"2015-02-09T00:29:35Z","git_url":"git://github.com/jvazquez-r7/metasploit-framework.git","ssh_url":"git@github.com:jvazquez-r7/metasploit-framework.git","clone_url":"https://github.com/jvazquez-r7/metasploit-framework.git","svn_url":"https://github.com/jvazquez-r7/metasploit-framework","homepage":"http://www.metasploit.com/","size":686636,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"wchen-r7:fix_4717","ref":"fix_4717","sha":"a543d957d4f9f8e70620871629681f08feb6ac1b","user":{"login":"wchen-r7","id":1170914,"avatar_url":"https://avatars.githubusercontent.com/u/1170914?v=3","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"repo":{"id":3789747,"name":"metasploit-framework","full_name":"wchen-r7/metasploit-framework","owner":{"login":"wchen-r7","id":1170914,"avatar_url":"https://avatars.githubusercontent.com/u/1170914?v=3","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wchen-r7/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/wchen-r7/metasploit-framework","forks_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/wchen-r7/metasploit-framework/releases{/id}","created_at":"2012-03-21T18:19:05Z","updated_at":"2014-08-01T16:20:50Z","pushed_at":"2015-02-07T06:09:29Z","git_url":"git://github.com/wchen-r7/metasploit-framework.git","ssh_url":"git@github.com:wchen-r7/metasploit-framework.git","clone_url":"https://github.com/wchen-r7/metasploit-framework.git","svn_url":"https://github.com/wchen-r7/metasploit-framework","homepage":"http://www.metasploit.com/","size":278259,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/26"},"html":{"href":"https://github.com/wchen-r7/metasploit-framework/pull/26"},"issue":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/26"},"comments":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/wchen-r7/metasploit-framework/statuses/831a1494ac135c5c00e6ec5fd9f34e19ac66cc74"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":47,"deletions":2,"changed_files":30}}