{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3428","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3428/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3428/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3428/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3428","id":118407066,"number":3428,"title":"My Profile","user":{"login":"oguzkocer","id":662023,"avatar_url":"https://avatars.githubusercontent.com/u/662023?v=3","gravatar_id":"","url":"https://api.github.com/users/oguzkocer","html_url":"https://github.com/oguzkocer","followers_url":"https://api.github.com/users/oguzkocer/followers","following_url":"https://api.github.com/users/oguzkocer/following{/other_user}","gists_url":"https://api.github.com/users/oguzkocer/gists{/gist_id}","starred_url":"https://api.github.com/users/oguzkocer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oguzkocer/subscriptions","organizations_url":"https://api.github.com/users/oguzkocer/orgs","repos_url":"https://api.github.com/users/oguzkocer/repos","events_url":"https://api.github.com/users/oguzkocer/events{/privacy}","received_events_url":"https://api.github.com/users/oguzkocer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels//me","name":"/me","color":"006b75"},{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Calypsofication","name":"Calypsofication","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"nbradbury","id":3903757,"avatar_url":"https://avatars.githubusercontent.com/u/3903757?v=3","gravatar_id":"","url":"https://api.github.com/users/nbradbury","html_url":"https://github.com/nbradbury","followers_url":"https://api.github.com/users/nbradbury/followers","following_url":"https://api.github.com/users/nbradbury/following{/other_user}","gists_url":"https://api.github.com/users/nbradbury/gists{/gist_id}","starred_url":"https://api.github.com/users/nbradbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbradbury/subscriptions","organizations_url":"https://api.github.com/users/nbradbury/orgs","repos_url":"https://api.github.com/users/nbradbury/repos","events_url":"https://api.github.com/users/nbradbury/events{/privacy}","received_events_url":"https://api.github.com/users/nbradbury/received_events","type":"User","site_admin":false},"milestone":null,"comments":19,"created_at":"2015-11-23T15:37:38Z","updated_at":"2015-12-15T18:53:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3428","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3428","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3428.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3428.patch"},"body":"I wanted to open this PR to get some early feedback. @tonyr59h and I were discussing that his \"Site Settings\" implementation might have some components we can use in \"My Profile\" as well. I am also not completely sure I have the best approach to a couple things.\r\n\r\nThe first question I had is about the layout. When we were working on the v1 of Calypsoification of the app with @nbradbury we opted not to use a list view for the Me fragment and I've taken a similar approach. I've used styles extensively here, so the code feels clear to me and there is not much need for a lot of switch statements. Having said that, it looks like \"Site Settings\" is implemented with list view, so I wanted to check in if I had the best approach for this.\r\n\r\nMy second question is about the usage of dialogs. I have looked into the `WPAlertDialogFragment` and it doesn't have a builder with an input in it. So for now, I have added the dialog inside the `MyProfileActivity`. Should I be looking to move that implementation to `WPAlertDialogFragment` instead? Also, note that the current dialog only works for \"first name\" and I thought I'd pass a tag to `showInputDialog` method and use a `switch` statement to make it work for all labels. I actually wanted to make it work with some kind of callback mechanism but couldn't really find a way to do that. Would that be possible? If not, I don't think the method would be generic enough to add inside of `WPAlertDialogFragment`.\r\n\r\nFor reference, here is the complete design for my profile page: https://cloudup.com/cGvJQYVBE0B\r\nAnd here are some screenshots from the actual implementation: https://cloudup.com/ciJn7zQjKfx\r\n\r\nAnyone can review the PR, I am just ping Maxime to add a name here. Thanks!\r\nNeeds review: @maxme "},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/164854902","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3428#issuecomment-164854902","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3428","id":164854902,"user":{"login":"nbradbury","id":3903757,"avatar_url":"https://avatars.githubusercontent.com/u/3903757?v=3","gravatar_id":"","url":"https://api.github.com/users/nbradbury","html_url":"https://github.com/nbradbury","followers_url":"https://api.github.com/users/nbradbury/followers","following_url":"https://api.github.com/users/nbradbury/following{/other_user}","gists_url":"https://api.github.com/users/nbradbury/gists{/gist_id}","starred_url":"https://api.github.com/users/nbradbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbradbury/subscriptions","organizations_url":"https://api.github.com/users/nbradbury/orgs","repos_url":"https://api.github.com/users/nbradbury/repos","events_url":"https://api.github.com/users/nbradbury/events{/privacy}","received_events_url":"https://api.github.com/users/nbradbury/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T18:53:20Z","updated_at":"2015-12-15T18:53:20Z","body":"@oguzkocer I updated my bug list above so that fixed problems are struck out (should make it easier to keep track of things). A few new ones to add:\r\n\r\n* If I change my public display name and save it, when I return to the Me tab the old name still displays.\r\n\r\n* If clear my public display name and save it, the old name returns the next time I go to My Profile. My guess is we don't want to allow people to clear it.\r\n\r\n* Having `MyProfileActivity` under a new `me` directory isn't ideal (for one thing, it's where I'd first look for the `Me` fragment). Maybe it belongs under `prefs` instead, so that's where other settings are located?"}}