{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/29596699","id":29596699,"diff_hunk":"@@ -0,0 +1,167 @@\n+﻿// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using System;\n+using System.IO;\n+using System.Collections;\n+using System.Globalization;\n+using System.Text;\n+using System.Threading;\n+using System.Runtime.CompilerServices;\n+using Xunit;\n+\n+namespace System.IO.FileSystem.Tests\n+{\n+    public abstract class SetTime_str_dt : FileSystemTest\n+    {\n+        private readonly string NonExistantFileName = \"nonexistant_file_name\";\n+        private readonly TimeSpan Accuracy = TimeSpan.FromSeconds(3);","path":"src/System.IO.FileSystem/tests/SetTime_str_dt.cs","position":18,"original_position":18,"commit_id":"b5f58c20f1d12faddfee3f3f9ffd771702b0548e","original_commit_id":"b5f58c20f1d12faddfee3f3f9ffd771702b0548e","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"These are fields rather than constants; should they begin with an underscore and lower case?","created_at":"2015-05-04T16:01:52Z","updated_at":"2015-05-04T16:01:52Z","html_url":"https://github.com/dotnet/corefx/pull/1607#discussion_r29596699","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/1607","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/29596699"},"html":{"href":"https://github.com/dotnet/corefx/pull/1607#discussion_r29596699"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1607"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1607","id":34569304,"html_url":"https://github.com/dotnet/corefx/pull/1607","diff_url":"https://github.com/dotnet/corefx/pull/1607.diff","patch_url":"https://github.com/dotnet/corefx/pull/1607.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1607","number":1607,"state":"open","locked":false,"title":"Replace System.IO.FileSystem Directory_SetLastWriteTime_str_dt tests","user":{"login":"FiveTimesTheFun","id":6598317,"avatar_url":"https://avatars.githubusercontent.com/u/6598317?v=3","gravatar_id":"","url":"https://api.github.com/users/FiveTimesTheFun","html_url":"https://github.com/FiveTimesTheFun","followers_url":"https://api.github.com/users/FiveTimesTheFun/followers","following_url":"https://api.github.com/users/FiveTimesTheFun/following{/other_user}","gists_url":"https://api.github.com/users/FiveTimesTheFun/gists{/gist_id}","starred_url":"https://api.github.com/users/FiveTimesTheFun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiveTimesTheFun/subscriptions","organizations_url":"https://api.github.com/users/FiveTimesTheFun/orgs","repos_url":"https://api.github.com/users/FiveTimesTheFun/repos","events_url":"https://api.github.com/users/FiveTimesTheFun/events{/privacy}","received_events_url":"https://api.github.com/users/FiveTimesTheFun/received_events","type":"User","site_admin":false},"body":"The existing ported System.IO.FileSystem tests have proven to be unreliable.  I'm opportunistically rewriting these tests.\r\n\r\nI'm trying to pay attention to the order that exceptions are thrown for fault conditions, and testing combinations of arguments... hopefully I've struck the right balance between brevity and complexity.\r\n\r\nWhen adding coverage, I'm also taking in to account that several of the \"Directory\" APIs operate on files, and vice versa. ","created_at":"2015-05-01T21:33:27Z","updated_at":"2015-05-04T16:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"380abbc82ef7410a777e0e58dfee953324e1b3ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1607/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1607/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1607/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/b5f58c20f1d12faddfee3f3f9ffd771702b0548e","head":{"label":"FiveTimesTheFun:System.IO.FileSystem","ref":"System.IO.FileSystem","sha":"b5f58c20f1d12faddfee3f3f9ffd771702b0548e","user":{"login":"FiveTimesTheFun","id":6598317,"avatar_url":"https://avatars.githubusercontent.com/u/6598317?v=3","gravatar_id":"","url":"https://api.github.com/users/FiveTimesTheFun","html_url":"https://github.com/FiveTimesTheFun","followers_url":"https://api.github.com/users/FiveTimesTheFun/followers","following_url":"https://api.github.com/users/FiveTimesTheFun/following{/other_user}","gists_url":"https://api.github.com/users/FiveTimesTheFun/gists{/gist_id}","starred_url":"https://api.github.com/users/FiveTimesTheFun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiveTimesTheFun/subscriptions","organizations_url":"https://api.github.com/users/FiveTimesTheFun/orgs","repos_url":"https://api.github.com/users/FiveTimesTheFun/repos","events_url":"https://api.github.com/users/FiveTimesTheFun/events{/privacy}","received_events_url":"https://api.github.com/users/FiveTimesTheFun/received_events","type":"User","site_admin":false},"repo":{"id":26556351,"name":"corefx","full_name":"FiveTimesTheFun/corefx","owner":{"login":"FiveTimesTheFun","id":6598317,"avatar_url":"https://avatars.githubusercontent.com/u/6598317?v=3","gravatar_id":"","url":"https://api.github.com/users/FiveTimesTheFun","html_url":"https://github.com/FiveTimesTheFun","followers_url":"https://api.github.com/users/FiveTimesTheFun/followers","following_url":"https://api.github.com/users/FiveTimesTheFun/following{/other_user}","gists_url":"https://api.github.com/users/FiveTimesTheFun/gists{/gist_id}","starred_url":"https://api.github.com/users/FiveTimesTheFun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiveTimesTheFun/subscriptions","organizations_url":"https://api.github.com/users/FiveTimesTheFun/orgs","repos_url":"https://api.github.com/users/FiveTimesTheFun/repos","events_url":"https://api.github.com/users/FiveTimesTheFun/events{/privacy}","received_events_url":"https://api.github.com/users/FiveTimesTheFun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FiveTimesTheFun/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/FiveTimesTheFun/corefx","forks_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/forks","keys_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/teams","hooks_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/hooks","issue_events_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/events","assignees_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/tags","blobs_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/languages","stargazers_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/stargazers","contributors_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/contributors","subscribers_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/subscribers","subscription_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/subscription","commits_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/merges","archive_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/downloads","issues_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/labels{/name}","releases_url":"https://api.github.com/repos/FiveTimesTheFun/corefx/releases{/id}","created_at":"2014-11-12T21:10:35Z","updated_at":"2015-02-13T21:33:58Z","pushed_at":"2015-05-01T23:33:46Z","git_url":"git://github.com/FiveTimesTheFun/corefx.git","ssh_url":"git@github.com:FiveTimesTheFun/corefx.git","clone_url":"https://github.com/FiveTimesTheFun/corefx.git","svn_url":"https://github.com/FiveTimesTheFun/corefx","homepage":"","size":18329,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"10c6dc5c76362b59dcc7593e5239ce114d85b218","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-05-04T15:27:35Z","pushed_at":"2015-05-04T15:33:55Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":40684,"stargazers_count":7689,"watchers_count":7689,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1523,"mirror_url":null,"open_issues_count":377,"forks":1523,"open_issues":377,"watchers":7689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1607"},"html":{"href":"https://github.com/dotnet/corefx/pull/1607"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1607"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1607/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1607/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1607/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/b5f58c20f1d12faddfee3f3f9ffd771702b0548e"}}}}