{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/16","id":38733765,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/16","diff_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/16.diff","patch_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/16.patch","issue_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/16","number":16,"state":"closed","locked":false,"title":"RFC: Refactoring of tables","user":{"login":"dpsanders","id":191822,"avatar_url":"https://avatars.githubusercontent.com/u/191822?v=3","gravatar_id":"","url":"https://api.github.com/users/dpsanders","html_url":"https://github.com/dpsanders","followers_url":"https://api.github.com/users/dpsanders/followers","following_url":"https://api.github.com/users/dpsanders/following{/other_user}","gists_url":"https://api.github.com/users/dpsanders/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsanders/subscriptions","organizations_url":"https://api.github.com/users/dpsanders/orgs","repos_url":"https://api.github.com/users/dpsanders/repos","events_url":"https://api.github.com/users/dpsanders/events{/privacy}","received_events_url":"https://api.github.com/users/dpsanders/received_events","type":"User","site_admin":false},"body":"- The generation code for tables has been refactored.\r\n- Tuples are now used instead of arrays in `index_table`\r\n- The `pos_table` now uses the tuple directly as the key;\r\nhashing is no longer required. (This is done in any case by the\r\ndictionary)\r\n- Names have been de-camel-cased\r\n  (numVars -> num_vars, indexTable -> index_table)\r\n- The tables are currently not `const`, since their type now changes\r\nwhen num_vars changes. We will have to think about how to solve this\r\n- `@simd` and `@inbounds` removed for now.  (Sorry, this has caused noise in the diff.)\r\n- EDIT: I also split up and renamed some files \r\n\r\nRefactoring of variable names\r\n\r\nSplit out definition of parameter type into new file TaylorN_parameters.jl\r\n\r\nSplit out printing into printing.jl\r\n\r\nMinor refactoring\r\n\r\nFactored out generation of homogeneous polynomial indices of given degree\r\n\r\nRename files without utils\r\n\r\nComplete rewrite of table generation code\r\n\r\nRemove parameter stuff from hashtables\r\n\r\nCorrect new file names in TaylorSeries.jl\r\n\r\nRefactoring of printing of homogeneous polynomials\r\n\r\nRename TaylorN_parameters.jl -> parameters.jl\r\n\r\nCorrected include in TaylorSeries\r\n\r\nAdded tuple addition\r\n\r\nRefactor tests into 3 files\r\n\r\nAllow redefining table sizes again\r\n\r\nAlmost all tests pass, except when changing the number of variables, which will require a major refactoring\r\n\r\nRemove const for tables for now. Remove @simd and @inbounds","created_at":"2015-06-28T23:18:24Z","updated_at":"2015-07-22T15:37:54Z","closed_at":"2015-07-22T15:37:54Z","merged_at":null,"merge_commit_sha":"89d512d2c6f516373b059d0f93edc2d6f237baac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/16/commits","review_comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/16/comments","review_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/16/comments","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/a6f470c7846675c393f4986d909f37124083d626","head":{"label":"JuliaDiff:refactor_hashtables","ref":"refactor_hashtables","sha":"a6f470c7846675c393f4986d909f37124083d626","user":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"repo":{"id":17322687,"name":"TaylorSeries.jl","full_name":"JuliaDiff/TaylorSeries.jl","owner":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl","description":"A julia package for Taylor expansions in one or more independent variables.","fork":false,"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl","forks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/releases{/id}","created_at":"2014-03-01T19:43:17Z","updated_at":"2015-06-28T10:20:27Z","pushed_at":"2015-07-15T23:24:18Z","git_url":"git://github.com/JuliaDiff/TaylorSeries.jl.git","ssh_url":"git@github.com:JuliaDiff/TaylorSeries.jl.git","clone_url":"https://github.com/JuliaDiff/TaylorSeries.jl.git","svn_url":"https://github.com/JuliaDiff/TaylorSeries.jl","homepage":"","size":1339,"stargazers_count":4,"watchers_count":4,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"JuliaDiff:master","ref":"master","sha":"3a7d69453be74f9cd50e631ebb0cc93777a1b917","user":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"repo":{"id":17322687,"name":"TaylorSeries.jl","full_name":"JuliaDiff/TaylorSeries.jl","owner":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl","description":"A julia package for Taylor expansions in one or more independent variables.","fork":false,"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl","forks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/releases{/id}","created_at":"2014-03-01T19:43:17Z","updated_at":"2015-06-28T10:20:27Z","pushed_at":"2015-07-15T23:24:18Z","git_url":"git://github.com/JuliaDiff/TaylorSeries.jl.git","ssh_url":"git@github.com:JuliaDiff/TaylorSeries.jl.git","clone_url":"https://github.com/JuliaDiff/TaylorSeries.jl.git","svn_url":"https://github.com/JuliaDiff/TaylorSeries.jl","homepage":"","size":1339,"stargazers_count":4,"watchers_count":4,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/16"},"html":{"href":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/16"},"issue":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/16"},"comments":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/a6f470c7846675c393f4986d909f37124083d626"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":2,"additions":677,"deletions":710,"changed_files":11}}