{"action":"created","issue":{"url":"https://api.github.com/repos/Qucs/qucs/issues/339","labels_url":"https://api.github.com/repos/Qucs/qucs/issues/339/labels{/name}","comments_url":"https://api.github.com/repos/Qucs/qucs/issues/339/comments","events_url":"https://api.github.com/repos/Qucs/qucs/issues/339/events","html_url":"https://github.com/Qucs/qucs/pull/339","id":98912682,"number":339,"title":"Matching tool","user":{"login":"andresmmera","id":13180689,"avatar_url":"https://avatars.githubusercontent.com/u/13180689?v=3","gravatar_id":"","url":"https://api.github.com/users/andresmmera","html_url":"https://github.com/andresmmera","followers_url":"https://api.github.com/users/andresmmera/followers","following_url":"https://api.github.com/users/andresmmera/following{/other_user}","gists_url":"https://api.github.com/users/andresmmera/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmmera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmmera/subscriptions","organizations_url":"https://api.github.com/users/andresmmera/orgs","repos_url":"https://api.github.com/users/andresmmera/repos","events_url":"https://api.github.com/users/andresmmera/events{/privacy}","received_events_url":"https://api.github.com/users/andresmmera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-04T08:10:00Z","updated_at":"2015-08-07T12:21:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Qucs/qucs/pulls/339","html_url":"https://github.com/Qucs/qucs/pull/339","diff_url":"https://github.com/Qucs/qucs/pull/339.diff","patch_url":"https://github.com/Qucs/qucs/pull/339.patch"},"body":"Hello all, \r\n\r\nI have added some methods to the matching tool. Should I 'squash' the old commits?"},"comment":{"url":"https://api.github.com/repos/Qucs/qucs/issues/comments/128686496","html_url":"https://github.com/Qucs/qucs/pull/339#issuecomment-128686496","issue_url":"https://api.github.com/repos/Qucs/qucs/issues/339","id":128686496,"user":{"login":"andresmmera","id":13180689,"avatar_url":"https://avatars.githubusercontent.com/u/13180689?v=3","gravatar_id":"","url":"https://api.github.com/users/andresmmera","html_url":"https://github.com/andresmmera","followers_url":"https://api.github.com/users/andresmmera/followers","following_url":"https://api.github.com/users/andresmmera/following{/other_user}","gists_url":"https://api.github.com/users/andresmmera/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmmera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmmera/subscriptions","organizations_url":"https://api.github.com/users/andresmmera/orgs","repos_url":"https://api.github.com/users/andresmmera/repos","events_url":"https://api.github.com/users/andresmmera/events{/privacy}","received_events_url":"https://api.github.com/users/andresmmera/received_events","type":"User","site_admin":false},"created_at":"2015-08-07T12:21:25Z","updated_at":"2015-08-07T12:21:25Z","body":"@in3otd I've corrected the code according to your suggestions and I've just pushed it to my fork. \r\n\r\n1) The duplication was minimized. Specific functions were written to calculate the individual matching sections and they are call from one-port matching and two-ports matching functions. In this sense, I've tried to reuse the existing functions for one-port and two-port matching.\r\n2) All warnings were wiped out, even those related to the Qt libraries (at least my compiler said it was clean) \r\n3) The binomial coefficients were calculated according to the multiplicative formula.\r\n4) I've included a checkbox to let the user to include a S-param block or not.\r\n5) The auto-indent tool of the QtCreator was used to change the old indentation. Thus, no more tab indents. (Yes, I'm prone to using tab indents... :) )\r\n6) I've checked matchdialog.cpp with the binary text editor and now it weren't added strange bytes at the beginning.\r\n\r\nI hope the code quality have been improved. If you see something else or if you have any other idea, please let me know"}}