{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/39336332","id":39336332,"diff_hunk":"@@ -4,7 +4,6 @@\n  * should trigger the error event after each attempt.\n  */\n \n-var common = require('../common');","path":"test/internet/test-http-dns-fail.js","position":4,"original_position":4,"commit_id":"baa04d43d84c624c5403c06e52751dcc3a153426","original_commit_id":"baa04d43d84c624c5403c06e52751dcc3a153426","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"body":"what's the big deal with requiring common? are you trying to shave off ms?","created_at":"2015-09-12T10:30:03Z","updated_at":"2015-09-12T10:30:03Z","html_url":"https://github.com/nodejs/node/pull/2828#discussion_r39336332","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/2828","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/39336332"},"html":{"href":"https://github.com/nodejs/node/pull/2828#discussion_r39336332"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/2828"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2828","id":44844306,"html_url":"https://github.com/nodejs/node/pull/2828","diff_url":"https://github.com/nodejs/node/pull/2828.diff","patch_url":"https://github.com/nodejs/node/pull/2828.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/2828","number":2828,"state":"open","locked":false,"title":"tools: enable no-unused-vars linter rule and fix issues","user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"body":"This enables the [`no-unused-vars`](http://eslint.org/docs/rules/no-unused-vars) rule. Issues that came up were mostly the variables on top of tests and there were a few cases where there was leftover dead code.\r\n\r\nI intentionally didn't enable the feature for unused function arguments yet. I think the best to go about these is to comment out the arguments in `lib` while removing them in `test`, does that sound good?\r\n\r\nNote that this is somewhat WIP, as there were a few cases where the intention seemed to be to use some of these variables, but I'm submitting this now as-is for some feedback.","created_at":"2015-09-12T01:49:53Z","updated_at":"2015-09-12T10:30:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79bd38469f4619b897d67cca863f249a3d448f68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/2828/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/2828/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2828/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/baa04d43d84c624c5403c06e52751dcc3a153426","head":{"label":"silverwind:no-unused-vars","ref":"no-unused-vars","sha":"baa04d43d84c624c5403c06e52751dcc3a153426","user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"repo":{"id":29392128,"name":"io.js","full_name":"silverwind/io.js","owner":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/silverwind/io.js","description":"A spork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/silverwind/io.js","forks_url":"https://api.github.com/repos/silverwind/io.js/forks","keys_url":"https://api.github.com/repos/silverwind/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverwind/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverwind/io.js/teams","hooks_url":"https://api.github.com/repos/silverwind/io.js/hooks","issue_events_url":"https://api.github.com/repos/silverwind/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/silverwind/io.js/events","assignees_url":"https://api.github.com/repos/silverwind/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/silverwind/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/silverwind/io.js/tags","blobs_url":"https://api.github.com/repos/silverwind/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverwind/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverwind/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverwind/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverwind/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/silverwind/io.js/languages","stargazers_url":"https://api.github.com/repos/silverwind/io.js/stargazers","contributors_url":"https://api.github.com/repos/silverwind/io.js/contributors","subscribers_url":"https://api.github.com/repos/silverwind/io.js/subscribers","subscription_url":"https://api.github.com/repos/silverwind/io.js/subscription","commits_url":"https://api.github.com/repos/silverwind/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverwind/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverwind/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverwind/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverwind/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/silverwind/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverwind/io.js/merges","archive_url":"https://api.github.com/repos/silverwind/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverwind/io.js/downloads","issues_url":"https://api.github.com/repos/silverwind/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/silverwind/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/silverwind/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/silverwind/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverwind/io.js/labels{/name}","releases_url":"https://api.github.com/repos/silverwind/io.js/releases{/id}","created_at":"2015-01-17T13:35:27Z","updated_at":"2015-04-17T13:52:48Z","pushed_at":"2015-09-12T01:39:01Z","git_url":"git://github.com/silverwind/io.js.git","ssh_url":"git@github.com:silverwind/io.js.git","clone_url":"https://github.com/silverwind/io.js.git","svn_url":"https://github.com/silverwind/io.js","homepage":"https://iojs.org","size":144052,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"68dc69a382692f424c53b75724e684a406b195a1","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Node.js  ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-09-12T09:49:41Z","pushed_at":"2015-09-12T06:54:12Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":205009,"stargazers_count":14713,"watchers_count":14713,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1262,"mirror_url":null,"open_issues_count":402,"forks":1262,"open_issues":402,"watchers":14713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/2828"},"html":{"href":"https://github.com/nodejs/node/pull/2828"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/2828"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/2828/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/2828/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/2828/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/baa04d43d84c624c5403c06e52751dcc3a153426"}}}}