{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments/39759955","id":39759955,"diff_hunk":"@@ -166,8 +166,7 @@ public function get($name)\n \n         $object = $this->doCreate($name);\n \n-        if (($this->sharedByDefault && !isset($this->shared[$name]))\n-            || (isset($this->shared[$name]) && $this->shared[$name])) {\n+        if ($this->sharedByDefault ^ isset($this->shared[$name])) {","path":"src/ServiceManager.php","position":6,"original_position":6,"commit_id":"9314370b6f5159337b0c8c175619d5ceac2276a6","original_commit_id":"9314370b6f5159337b0c8c175619d5ceac2276a6","user":{"login":"Maks3w","id":1301698,"avatar_url":"https://avatars.githubusercontent.com/u/1301698?v=3","gravatar_id":"","url":"https://api.github.com/users/Maks3w","html_url":"https://github.com/Maks3w","followers_url":"https://api.github.com/users/Maks3w/followers","following_url":"https://api.github.com/users/Maks3w/following{/other_user}","gists_url":"https://api.github.com/users/Maks3w/gists{/gist_id}","starred_url":"https://api.github.com/users/Maks3w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maks3w/subscriptions","organizations_url":"https://api.github.com/users/Maks3w/orgs","repos_url":"https://api.github.com/users/Maks3w/repos","events_url":"https://api.github.com/users/Maks3w/events{/privacy}","received_events_url":"https://api.github.com/users/Maks3w/received_events","type":"User","site_admin":false},"body":"Before `false` was a possible value of `isset($this->shared[$name]))` and was evaluated all as `false` now I think its evaluted as `true`","created_at":"2015-09-17T15:30:57Z","updated_at":"2015-09-17T15:30:57Z","html_url":"https://github.com/zendframework/zend-servicemanager/pull/20#discussion_r39759955","pull_request_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments/39759955"},"html":{"href":"https://github.com/zendframework/zend-servicemanager/pull/20#discussion_r39759955"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20","id":45304582,"html_url":"https://github.com/zendframework/zend-servicemanager/pull/20","diff_url":"https://github.com/zendframework/zend-servicemanager/pull/20.diff","patch_url":"https://github.com/zendframework/zend-servicemanager/pull/20.patch","issue_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/20","number":20,"state":"open","locked":false,"title":"Optimization","user":{"login":"bakura10","id":1198915,"avatar_url":"https://avatars.githubusercontent.com/u/1198915?v=3","gravatar_id":"","url":"https://api.github.com/users/bakura10","html_url":"https://github.com/bakura10","followers_url":"https://api.github.com/users/bakura10/followers","following_url":"https://api.github.com/users/bakura10/following{/other_user}","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","organizations_url":"https://api.github.com/users/bakura10/orgs","repos_url":"https://api.github.com/users/bakura10/repos","events_url":"https://api.github.com/users/bakura10/events{/privacy}","received_events_url":"https://api.github.com/users/bakura10/received_events","type":"User","site_admin":false},"body":"Squeezing every little bit of performance...","created_at":"2015-09-17T15:28:38Z","updated_at":"2015-09-17T15:30:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a7c43d3a7243642d0f7c026f9fdc054446e0283","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/20/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/9314370b6f5159337b0c8c175619d5ceac2276a6","head":{"label":"bakura10:micro-optimization","ref":"micro-optimization","sha":"9314370b6f5159337b0c8c175619d5ceac2276a6","user":{"login":"bakura10","id":1198915,"avatar_url":"https://avatars.githubusercontent.com/u/1198915?v=3","gravatar_id":"","url":"https://api.github.com/users/bakura10","html_url":"https://github.com/bakura10","followers_url":"https://api.github.com/users/bakura10/followers","following_url":"https://api.github.com/users/bakura10/following{/other_user}","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","organizations_url":"https://api.github.com/users/bakura10/orgs","repos_url":"https://api.github.com/users/bakura10/repos","events_url":"https://api.github.com/users/bakura10/events{/privacy}","received_events_url":"https://api.github.com/users/bakura10/received_events","type":"User","site_admin":false},"repo":{"id":35809550,"name":"zend-servicemanager","full_name":"bakura10/zend-servicemanager","owner":{"login":"bakura10","id":1198915,"avatar_url":"https://avatars.githubusercontent.com/u/1198915?v=3","gravatar_id":"","url":"https://api.github.com/users/bakura10","html_url":"https://github.com/bakura10","followers_url":"https://api.github.com/users/bakura10/followers","following_url":"https://api.github.com/users/bakura10/following{/other_user}","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","organizations_url":"https://api.github.com/users/bakura10/orgs","repos_url":"https://api.github.com/users/bakura10/repos","events_url":"https://api.github.com/users/bakura10/events{/privacy}","received_events_url":"https://api.github.com/users/bakura10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bakura10/zend-servicemanager","description":"ServiceManager component from Zend Framework","fork":true,"url":"https://api.github.com/repos/bakura10/zend-servicemanager","forks_url":"https://api.github.com/repos/bakura10/zend-servicemanager/forks","keys_url":"https://api.github.com/repos/bakura10/zend-servicemanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakura10/zend-servicemanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakura10/zend-servicemanager/teams","hooks_url":"https://api.github.com/repos/bakura10/zend-servicemanager/hooks","issue_events_url":"https://api.github.com/repos/bakura10/zend-servicemanager/issues/events{/number}","events_url":"https://api.github.com/repos/bakura10/zend-servicemanager/events","assignees_url":"https://api.github.com/repos/bakura10/zend-servicemanager/assignees{/user}","branches_url":"https://api.github.com/repos/bakura10/zend-servicemanager/branches{/branch}","tags_url":"https://api.github.com/repos/bakura10/zend-servicemanager/tags","blobs_url":"https://api.github.com/repos/bakura10/zend-servicemanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakura10/zend-servicemanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakura10/zend-servicemanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakura10/zend-servicemanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakura10/zend-servicemanager/statuses/{sha}","languages_url":"https://api.github.com/repos/bakura10/zend-servicemanager/languages","stargazers_url":"https://api.github.com/repos/bakura10/zend-servicemanager/stargazers","contributors_url":"https://api.github.com/repos/bakura10/zend-servicemanager/contributors","subscribers_url":"https://api.github.com/repos/bakura10/zend-servicemanager/subscribers","subscription_url":"https://api.github.com/repos/bakura10/zend-servicemanager/subscription","commits_url":"https://api.github.com/repos/bakura10/zend-servicemanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakura10/zend-servicemanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakura10/zend-servicemanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakura10/zend-servicemanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakura10/zend-servicemanager/contents/{+path}","compare_url":"https://api.github.com/repos/bakura10/zend-servicemanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakura10/zend-servicemanager/merges","archive_url":"https://api.github.com/repos/bakura10/zend-servicemanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakura10/zend-servicemanager/downloads","issues_url":"https://api.github.com/repos/bakura10/zend-servicemanager/issues{/number}","pulls_url":"https://api.github.com/repos/bakura10/zend-servicemanager/pulls{/number}","milestones_url":"https://api.github.com/repos/bakura10/zend-servicemanager/milestones{/number}","notifications_url":"https://api.github.com/repos/bakura10/zend-servicemanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakura10/zend-servicemanager/labels{/name}","releases_url":"https://api.github.com/repos/bakura10/zend-servicemanager/releases{/id}","created_at":"2015-05-18T09:41:37Z","updated_at":"2015-05-18T09:41:37Z","pushed_at":"2015-09-17T15:27:26Z","git_url":"git://github.com/bakura10/zend-servicemanager.git","ssh_url":"git@github.com:bakura10/zend-servicemanager.git","clone_url":"https://github.com/bakura10/zend-servicemanager.git","svn_url":"https://github.com/bakura10/zend-servicemanager","homepage":"https://github.com/zendframework/zf2","size":1987,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:develop","ref":"develop","sha":"e32517918cca18a293d7cec0990a03ea71c4fe8b","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280826,"name":"zend-servicemanager","full_name":"zendframework/zend-servicemanager","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-servicemanager","description":"ServiceManager component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-servicemanager","forks_url":"https://api.github.com/repos/zendframework/zend-servicemanager/forks","keys_url":"https://api.github.com/repos/zendframework/zend-servicemanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-servicemanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-servicemanager/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-servicemanager/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/events","assignees_url":"https://api.github.com/repos/zendframework/zend-servicemanager/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-servicemanager/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-servicemanager/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-servicemanager/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-servicemanager/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-servicemanager/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-servicemanager/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-servicemanager/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-servicemanager/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-servicemanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-servicemanager/merges","archive_url":"https://api.github.com/repos/zendframework/zend-servicemanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-servicemanager/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-servicemanager/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-servicemanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-servicemanager/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-servicemanager/releases{/id}","created_at":"2015-05-08T13:28:10Z","updated_at":"2015-09-16T10:00:57Z","pushed_at":"2015-09-17T15:28:38Z","git_url":"git://github.com/zendframework/zend-servicemanager.git","ssh_url":"git@github.com:zendframework/zend-servicemanager.git","clone_url":"https://github.com/zendframework/zend-servicemanager.git","svn_url":"https://github.com/zendframework/zend-servicemanager","homepage":"https://github.com/zendframework/zf2","size":2757,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20"},"html":{"href":"https://github.com/zendframework/zend-servicemanager/pull/20"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/20"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/9314370b6f5159337b0c8c175619d5ceac2276a6"}}}}