{"action":"created","issue":{"url":"https://api.github.com/repos/PyWavelets/pywt/issues/55","labels_url":"https://api.github.com/repos/PyWavelets/pywt/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/PyWavelets/pywt/issues/55/comments","events_url":"https://api.github.com/repos/PyWavelets/pywt/issues/55/events","html_url":"https://github.com/PyWavelets/pywt/pull/55","id":41586378,"number":55,"title":"[RFC] Api changes","user":{"login":"aaren","id":1364309,"avatar_url":"https://avatars.githubusercontent.com/u/1364309?v=3","gravatar_id":"","url":"https://api.github.com/users/aaren","html_url":"https://github.com/aaren","followers_url":"https://api.github.com/users/aaren/followers","following_url":"https://api.github.com/users/aaren/following{/other_user}","gists_url":"https://api.github.com/users/aaren/gists{/gist_id}","starred_url":"https://api.github.com/users/aaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaren/subscriptions","organizations_url":"https://api.github.com/users/aaren/orgs","repos_url":"https://api.github.com/users/aaren/repos","events_url":"https://api.github.com/users/aaren/events{/privacy}","received_events_url":"https://api.github.com/users/aaren/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PyWavelets/pywt/labels/API%20change","name":"API change","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/PyWavelets/pywt/milestones/2","html_url":"https://github.com/PyWavelets/pywt/milestones/v0.4.0","labels_url":"https://api.github.com/repos/PyWavelets/pywt/milestones/2/labels","id":1220990,"number":2,"title":"v0.4.0","description":"","creator":{"login":"rgommers","id":98330,"avatar_url":"https://avatars.githubusercontent.com/u/98330?v=3","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":11,"state":"open","created_at":"2015-07-22T20:08:40Z","updated_at":"2015-08-14T17:11:57Z","due_on":"2015-08-14T22:00:00Z","closed_at":null},"comments":50,"created_at":"2014-08-31T13:31:15Z","updated_at":"2015-08-14T20:34:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PyWavelets/pywt/pulls/55","html_url":"https://github.com/PyWavelets/pywt/pull/55","diff_url":"https://github.com/PyWavelets/pywt/pull/55.diff","patch_url":"https://github.com/PyWavelets/pywt/pull/55.patch"},"body":"As in #38. This is blocking [scipy wavelet progress](https://github.com/scipy/scipy/issues/3931). Collated todo:\r\n\r\n- [x] function names in functions.py need to be longer and clearer\r\n  (intwave, centrfrq, scal2frq, orthfilt).\r\n\r\n- [x] qmf already exists in scipy.signal - *ok we just deprecate in `signal` when pywt becomes `wavelets`*\r\n\r\n- [x] wavelet parameter to functions should be uniform everywhere (can\r\n  be Wavelet instance, string and in some cases intwave even a third\r\n  option). *decided on accepting both string and instance. removed tuple argument to intwave (just a convenience function anyway)*\r\n\r\n- [x] ~~functions in thresholding.py are (too?) simple and in two cases\r\n  equal numpy names.~~ *(fixed in #49)*\r\n\r\n- [x] MODES is all capitals. It's properties aren't very Pythonic. *this breaks compatibility with upstream, but that's fine*\r\n\r\n- [x] Wavelet has `__str__` but not `__repr__`. *return Wavelet(name, filter_bank)*\r\n\r\n- [x] scal2frq has scale and delta inputs that are identical (they're\r\n  just multiplied). *removed the delta argument*\r\n\r\n- [x] The submodules (functions, thresholding, etc.) should not be\r\n  public, so underscore them all.\r\n\r\n- [x] check for consistency of `walk` and `walk_depth`, #19. *fixed by setting `decompose=True` in both*\r\n\r\n- [x] ~~There's dwt, dwt2, dwtn and idwt, idwt2 but no idwtn. Needs adding.~~ *(now in 0.3.0)*\r\n\r\n-  [x] ~~Furthermore there's an open PR adding `wavedec_coeff_len`.~~ *(moved to #85)*\r\n\r\n- [ ] Deprecation warnings\r\n"},"comment":{"url":"https://api.github.com/repos/PyWavelets/pywt/issues/comments/131232757","html_url":"https://github.com/PyWavelets/pywt/pull/55#issuecomment-131232757","issue_url":"https://api.github.com/repos/PyWavelets/pywt/issues/55","id":131232757,"user":{"login":"grlee77","id":6528957,"avatar_url":"https://avatars.githubusercontent.com/u/6528957?v=3","gravatar_id":"","url":"https://api.github.com/users/grlee77","html_url":"https://github.com/grlee77","followers_url":"https://api.github.com/users/grlee77/followers","following_url":"https://api.github.com/users/grlee77/following{/other_user}","gists_url":"https://api.github.com/users/grlee77/gists{/gist_id}","starred_url":"https://api.github.com/users/grlee77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grlee77/subscriptions","organizations_url":"https://api.github.com/users/grlee77/orgs","repos_url":"https://api.github.com/users/grlee77/repos","events_url":"https://api.github.com/users/grlee77/events{/privacy}","received_events_url":"https://api.github.com/users/grlee77/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T20:34:25Z","updated_at":"2015-08-14T20:34:25Z","body":"I guess the API changes need to be documented somewhere for users as well."}}