{"action":"created","issue":{"url":"https://api.github.com/repos/mupen64plus-ae/mupen64plus-ae/issues/421","labels_url":"https://api.github.com/repos/mupen64plus-ae/mupen64plus-ae/issues/421/labels{/name}","comments_url":"https://api.github.com/repos/mupen64plus-ae/mupen64plus-ae/issues/421/comments","events_url":"https://api.github.com/repos/mupen64plus-ae/mupen64plus-ae/issues/421/events","html_url":"https://github.com/mupen64plus-ae/mupen64plus-ae/issues/421","id":60192425,"number":421,"title":"Does importing zip files actually work?","user":{"login":"BonzaiThePenguin","id":1899757,"avatar_url":"https://avatars.githubusercontent.com/u/1899757?v=3","gravatar_id":"","url":"https://api.github.com/users/BonzaiThePenguin","html_url":"https://github.com/BonzaiThePenguin","followers_url":"https://api.github.com/users/BonzaiThePenguin/followers","following_url":"https://api.github.com/users/BonzaiThePenguin/following{/other_user}","gists_url":"https://api.github.com/users/BonzaiThePenguin/gists{/gist_id}","starred_url":"https://api.github.com/users/BonzaiThePenguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BonzaiThePenguin/subscriptions","organizations_url":"https://api.github.com/users/BonzaiThePenguin/orgs","repos_url":"https://api.github.com/users/BonzaiThePenguin/repos","events_url":"https://api.github.com/users/BonzaiThePenguin/events{/privacy}","received_events_url":"https://api.github.com/users/BonzaiThePenguin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-07T05:48:31Z","updated_at":"2015-03-07T16:14:30Z","closed_at":null,"body":"So I was just playing around with zipped ROMs to make sure it \"still\" worked after the latest changes, but discovered that apparently it hasn't worked across any version I've tried? Is this affecting other people too? I don't want to start messing around with the code if it turns out I just have something set up wrong with my folder structure."},"comment":{"url":"https://api.github.com/repos/mupen64plus-ae/mupen64plus-ae/issues/comments/77695833","html_url":"https://github.com/mupen64plus-ae/mupen64plus-ae/issues/421#issuecomment-77695833","issue_url":"https://api.github.com/repos/mupen64plus-ae/mupen64plus-ae/issues/421","id":77695833,"user":{"login":"BonzaiThePenguin","id":1899757,"avatar_url":"https://avatars.githubusercontent.com/u/1899757?v=3","gravatar_id":"","url":"https://api.github.com/users/BonzaiThePenguin","html_url":"https://github.com/BonzaiThePenguin","followers_url":"https://api.github.com/users/BonzaiThePenguin/followers","following_url":"https://api.github.com/users/BonzaiThePenguin/following{/other_user}","gists_url":"https://api.github.com/users/BonzaiThePenguin/gists{/gist_id}","starred_url":"https://api.github.com/users/BonzaiThePenguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BonzaiThePenguin/subscriptions","organizations_url":"https://api.github.com/users/BonzaiThePenguin/orgs","repos_url":"https://api.github.com/users/BonzaiThePenguin/repos","events_url":"https://api.github.com/users/BonzaiThePenguin/events{/privacy}","received_events_url":"https://api.github.com/users/BonzaiThePenguin/received_events","type":"User","site_admin":false},"created_at":"2015-03-07T16:14:30Z","updated_at":"2015-03-07T16:14:30Z","body":"I get that, but would ROM hacks really need separate config options from the main ROM? Or even different official versions of a ROM? Especially when there are always new ROM hacks coming out (while the .ini is mostly designed for the N64's fixed library), and with a chance that the headers were altered slightly. In that situation it seems like *loose* matching would work better, with the super-strict matching coming into play when they go to complain about a crash and submit a report containing specific file offsets.\r\n\r\nAnyway I mostly meant that the MD5 ends up being calculated in situations where it's already known, but isn't actually passed in to the function that need it. So like even though the MD5 is saved to the config file and stored within each GalleryItem, the other functions are only given a File object so they have to retrieve the ROM information by computing another hash and matching it against the ROM database again.\r\n\r\nIt's not a huge deal, of course (on my quad-core with a class-10 SD card it only takes a second or so), but... it could be better! Plus on older devices it's dog-slow, but then again *so would the N64 emulation* so who cares. Maybe if I had a slower SD card I would be more motivated. ;)\r\n\r\n(Of course, full hashes are also useful for detecting duplicate files! Not sure if the app actually does this...)"}}