{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/32169175","id":32169175,"diff_hunk":"@@ -366,16 +365,11 @@ func (ep *endpoint) Delete() error {\n \tdriver := n.driver\n \tdelete(n.endpoints, epid)\n \tn.Unlock()\n-\tdefer func() {\n-\t\tif err != nil {\n-\t\t\tn.Lock()\n-\t\t\tn.endpoints[epid] = ep\n-\t\t\tn.Unlock()\n-\t\t}\n-\t}()\n \n-\terr = driver.DeleteEndpoint(nid, epid)\n-\treturn err\n+\tif err := driver.DeleteEndpoint(nid, epid); err != nil {","path":"endpoint.go","position":31,"original_position":31,"commit_id":"530d9feb380762f48b05eaf408bcfbf9c6fdfdbd","original_commit_id":"530d9feb380762f48b05eaf408bcfbf9c6fdfdbd","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"body":"As the commit log says, I feel we should check for FrobiddenError here as well.\r\nWe should not assume driver will never send a forbidden error for endpoint delete only because we know that actual driver implementation does not throw one.\r\n","created_at":"2015-06-10T21:32:36Z","updated_at":"2015-06-10T21:32:36Z","html_url":"https://github.com/docker/libnetwork/pull/273#discussion_r32169175","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/32169175"},"html":{"href":"https://github.com/docker/libnetwork/pull/273#discussion_r32169175"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/273","id":37402349,"html_url":"https://github.com/docker/libnetwork/pull/273","diff_url":"https://github.com/docker/libnetwork/pull/273.diff","patch_url":"https://github.com/docker/libnetwork/pull/273.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/273","number":273,"state":"open","locked":false,"title":"handling error condition for network and endpoint deletes","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"Unless it is a forbidden error, libnetwork should not fail a forced\r\ndelete of a network and endpoint if the driver throws an error.\r\n\r\nSigned-off-by: Madhu Venugopal <madhu@docker.com>","created_at":"2015-06-10T20:44:33Z","updated_at":"2015-06-10T21:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88abf1a3dfd947653c5b528ef98568f902a5c807","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/273/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/273/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/273/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/530d9feb380762f48b05eaf408bcfbf9c6fdfdbd","head":{"label":"mavenugo:delete_restore","ref":"delete_restore","sha":"530d9feb380762f48b05eaf408bcfbf9c6fdfdbd","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"repo":{"id":34572010,"name":"libnetwork","full_name":"mavenugo/libnetwork","owner":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavenugo/libnetwork","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/mavenugo/libnetwork","forks_url":"https://api.github.com/repos/mavenugo/libnetwork/forks","keys_url":"https://api.github.com/repos/mavenugo/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavenugo/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavenugo/libnetwork/teams","hooks_url":"https://api.github.com/repos/mavenugo/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/mavenugo/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/mavenugo/libnetwork/events","assignees_url":"https://api.github.com/repos/mavenugo/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/mavenugo/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/mavenugo/libnetwork/tags","blobs_url":"https://api.github.com/repos/mavenugo/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavenugo/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavenugo/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavenugo/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavenugo/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/mavenugo/libnetwork/languages","stargazers_url":"https://api.github.com/repos/mavenugo/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/mavenugo/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/mavenugo/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/mavenugo/libnetwork/subscription","commits_url":"https://api.github.com/repos/mavenugo/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavenugo/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavenugo/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavenugo/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavenugo/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/mavenugo/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavenugo/libnetwork/merges","archive_url":"https://api.github.com/repos/mavenugo/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavenugo/libnetwork/downloads","issues_url":"https://api.github.com/repos/mavenugo/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/mavenugo/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/mavenugo/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/mavenugo/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavenugo/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/mavenugo/libnetwork/releases{/id}","created_at":"2015-04-25T14:39:45Z","updated_at":"2015-05-07T18:56:18Z","pushed_at":"2015-06-10T20:44:12Z","git_url":"git://github.com/mavenugo/libnetwork.git","ssh_url":"git@github.com:mavenugo/libnetwork.git","clone_url":"https://github.com/mavenugo/libnetwork.git","svn_url":"https://github.com/mavenugo/libnetwork","homepage":"","size":1694,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"40f7ffc94f14d18c346f85e0f192b78ed96e84b0","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"networking for containers","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2015-06-08T12:50:35Z","pushed_at":"2015-06-10T21:29:35Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":6662,"stargazers_count":257,"watchers_count":257,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":42,"forks":76,"open_issues":42,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/273"},"html":{"href":"https://github.com/docker/libnetwork/pull/273"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/273"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/530d9feb380762f48b05eaf408bcfbf9c6fdfdbd"}}}}