{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/dmlc/dmlc-core/pulls/23","id":39749156,"html_url":"https://github.com/dmlc/dmlc-core/pull/23","diff_url":"https://github.com/dmlc/dmlc-core/pull/23.diff","patch_url":"https://github.com/dmlc/dmlc-core/pull/23.patch","issue_url":"https://api.github.com/repos/dmlc/dmlc-core/issues/23","number":23,"state":"closed","locked":false,"title":"Fixes for Row::SDot and RowBlockContainer::{Save,Load}","user":{"login":"TravisBarryDick","id":976796,"avatar_url":"https://avatars.githubusercontent.com/u/976796?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisBarryDick","html_url":"https://github.com/TravisBarryDick","followers_url":"https://api.github.com/users/TravisBarryDick/followers","following_url":"https://api.github.com/users/TravisBarryDick/following{/other_user}","gists_url":"https://api.github.com/users/TravisBarryDick/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisBarryDick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisBarryDick/subscriptions","organizations_url":"https://api.github.com/users/TravisBarryDick/orgs","repos_url":"https://api.github.com/users/TravisBarryDick/repos","events_url":"https://api.github.com/users/TravisBarryDick/events{/privacy}","received_events_url":"https://api.github.com/users/TravisBarryDick/received_events","type":"User","site_admin":false},"body":"This PR fixes two small bugs that Krishna and I found:\r\n- The first is that the function Row::SDot computes the dot product but does not return the value. \r\n- The second is that the functions RowBlockContainer::{Save,Load} did not save and load the RowBlockContainer members in the same order (so it looked like garbage was being loaded). \r\n- We also updated the RowBlockContainer::{Save,Load} functions to also save the row weights and the maximum index in the row block.","created_at":"2015-07-11T17:15:51Z","updated_at":"2015-07-11T17:25:42Z","closed_at":"2015-07-11T17:25:42Z","merged_at":"2015-07-11T17:25:42Z","merge_commit_sha":"8de8f9269e7e51b458f94a75f27981059e2d23eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/dmlc-core/pulls/23/commits","review_comments_url":"https://api.github.com/repos/dmlc/dmlc-core/pulls/23/comments","review_comment_url":"https://api.github.com/repos/dmlc/dmlc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/dmlc-core/issues/23/comments","statuses_url":"https://api.github.com/repos/dmlc/dmlc-core/statuses/bb465110b7b6d07f3eed412f6c1e0c9ee66b48b9","head":{"label":"TravisBarryDick:bugfix","ref":"bugfix","sha":"bb465110b7b6d07f3eed412f6c1e0c9ee66b48b9","user":{"login":"TravisBarryDick","id":976796,"avatar_url":"https://avatars.githubusercontent.com/u/976796?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisBarryDick","html_url":"https://github.com/TravisBarryDick","followers_url":"https://api.github.com/users/TravisBarryDick/followers","following_url":"https://api.github.com/users/TravisBarryDick/following{/other_user}","gists_url":"https://api.github.com/users/TravisBarryDick/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisBarryDick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisBarryDick/subscriptions","organizations_url":"https://api.github.com/users/TravisBarryDick/orgs","repos_url":"https://api.github.com/users/TravisBarryDick/repos","events_url":"https://api.github.com/users/TravisBarryDick/events{/privacy}","received_events_url":"https://api.github.com/users/TravisBarryDick/received_events","type":"User","site_admin":false},"repo":{"id":38933071,"name":"dmlc-core","full_name":"TravisBarryDick/dmlc-core","owner":{"login":"TravisBarryDick","id":976796,"avatar_url":"https://avatars.githubusercontent.com/u/976796?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisBarryDick","html_url":"https://github.com/TravisBarryDick","followers_url":"https://api.github.com/users/TravisBarryDick/followers","following_url":"https://api.github.com/users/TravisBarryDick/following{/other_user}","gists_url":"https://api.github.com/users/TravisBarryDick/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisBarryDick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisBarryDick/subscriptions","organizations_url":"https://api.github.com/users/TravisBarryDick/orgs","repos_url":"https://api.github.com/users/TravisBarryDick/repos","events_url":"https://api.github.com/users/TravisBarryDick/events{/privacy}","received_events_url":"https://api.github.com/users/TravisBarryDick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TravisBarryDick/dmlc-core","description":"A common code-base for Distributed Machine Learning in C++","fork":true,"url":"https://api.github.com/repos/TravisBarryDick/dmlc-core","forks_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/forks","keys_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/teams","hooks_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/hooks","issue_events_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/issues/events{/number}","events_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/events","assignees_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/assignees{/user}","branches_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/branches{/branch}","tags_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/tags","blobs_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/languages","stargazers_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/stargazers","contributors_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/contributors","subscribers_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/subscribers","subscription_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/subscription","commits_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/contents/{+path}","compare_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/merges","archive_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/downloads","issues_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/issues{/number}","pulls_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/labels{/name}","releases_url":"https://api.github.com/repos/TravisBarryDick/dmlc-core/releases{/id}","created_at":"2015-07-11T16:47:09Z","updated_at":"2015-07-11T16:47:10Z","pushed_at":"2015-07-11T17:10:56Z","git_url":"git://github.com/TravisBarryDick/dmlc-core.git","ssh_url":"git@github.com:TravisBarryDick/dmlc-core.git","clone_url":"https://github.com/TravisBarryDick/dmlc-core.git","svn_url":"https://github.com/TravisBarryDick/dmlc-core","homepage":"","size":1709,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"ca220ca62f7ee1b1da65ae642f9097348596b91e","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":32356864,"name":"dmlc-core","full_name":"dmlc/dmlc-core","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/dmlc-core","description":"A common code-base for Distributed Machine Learning in C++","fork":false,"url":"https://api.github.com/repos/dmlc/dmlc-core","forks_url":"https://api.github.com/repos/dmlc/dmlc-core/forks","keys_url":"https://api.github.com/repos/dmlc/dmlc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/dmlc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/dmlc-core/teams","hooks_url":"https://api.github.com/repos/dmlc/dmlc-core/hooks","issue_events_url":"https://api.github.com/repos/dmlc/dmlc-core/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/dmlc-core/events","assignees_url":"https://api.github.com/repos/dmlc/dmlc-core/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/dmlc-core/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/dmlc-core/tags","blobs_url":"https://api.github.com/repos/dmlc/dmlc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/dmlc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/dmlc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/dmlc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/dmlc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/dmlc-core/languages","stargazers_url":"https://api.github.com/repos/dmlc/dmlc-core/stargazers","contributors_url":"https://api.github.com/repos/dmlc/dmlc-core/contributors","subscribers_url":"https://api.github.com/repos/dmlc/dmlc-core/subscribers","subscription_url":"https://api.github.com/repos/dmlc/dmlc-core/subscription","commits_url":"https://api.github.com/repos/dmlc/dmlc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/dmlc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/dmlc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/dmlc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/dmlc-core/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/dmlc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/dmlc-core/merges","archive_url":"https://api.github.com/repos/dmlc/dmlc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/dmlc-core/downloads","issues_url":"https://api.github.com/repos/dmlc/dmlc-core/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/dmlc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/dmlc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/dmlc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/dmlc-core/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/dmlc-core/releases{/id}","created_at":"2015-03-16T22:30:15Z","updated_at":"2015-07-07T11:42:36Z","pushed_at":"2015-07-11T17:25:42Z","git_url":"git://github.com/dmlc/dmlc-core.git","ssh_url":"git@github.com:dmlc/dmlc-core.git","clone_url":"https://github.com/dmlc/dmlc-core.git","svn_url":"https://github.com/dmlc/dmlc-core","homepage":"","size":1709,"stargazers_count":157,"watchers_count":157,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":9,"forks":78,"open_issues":9,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/dmlc-core/pulls/23"},"html":{"href":"https://github.com/dmlc/dmlc-core/pull/23"},"issue":{"href":"https://api.github.com/repos/dmlc/dmlc-core/issues/23"},"comments":{"href":"https://api.github.com/repos/dmlc/dmlc-core/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/dmlc-core/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/dmlc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/dmlc-core/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/dmlc-core/statuses/bb465110b7b6d07f3eed412f6c1e0c9ee66b48b9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tqchen","id":2577440,"avatar_url":"https://avatars.githubusercontent.com/u/2577440?v=3","gravatar_id":"","url":"https://api.github.com/users/tqchen","html_url":"https://github.com/tqchen","followers_url":"https://api.github.com/users/tqchen/followers","following_url":"https://api.github.com/users/tqchen/following{/other_user}","gists_url":"https://api.github.com/users/tqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tqchen/subscriptions","organizations_url":"https://api.github.com/users/tqchen/orgs","repos_url":"https://api.github.com/users/tqchen/repos","events_url":"https://api.github.com/users/tqchen/events{/privacy}","received_events_url":"https://api.github.com/users/tqchen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":6,"deletions":1,"changed_files":2}}