{"action":"created","issue":{"url":"https://api.github.com/repos/garu/Data-Printer/issues/51","labels_url":"https://api.github.com/repos/garu/Data-Printer/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/garu/Data-Printer/issues/51/comments","events_url":"https://api.github.com/repos/garu/Data-Printer/issues/51/events","html_url":"https://github.com/garu/Data-Printer/pull/51","id":16725474,"number":51,"title":"Fixing whitespaces errors","user":{"login":"bessarabov","id":47263,"avatar_url":"https://avatars.githubusercontent.com/u/47263?v=3","gravatar_id":"","url":"https://api.github.com/users/bessarabov","html_url":"https://github.com/bessarabov","followers_url":"https://api.github.com/users/bessarabov/followers","following_url":"https://api.github.com/users/bessarabov/following{/other_user}","gists_url":"https://api.github.com/users/bessarabov/gists{/gist_id}","starred_url":"https://api.github.com/users/bessarabov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bessarabov/subscriptions","organizations_url":"https://api.github.com/users/bessarabov/orgs","repos_url":"https://api.github.com/users/bessarabov/repos","events_url":"https://api.github.com/users/bessarabov/events{/privacy}","received_events_url":"https://api.github.com/users/bessarabov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2013-07-14T08:56:15Z","updated_at":"2015-05-29T22:50:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/garu/Data-Printer/pulls/51","html_url":"https://github.com/garu/Data-Printer/pull/51","diff_url":"https://github.com/garu/Data-Printer/pull/51.diff","patch_url":"https://github.com/garu/Data-Printer/pull/51.patch"},"body":"I've used script `whiter examples lib xt t` from the module https://metacpan.org/module/Test::Whitespaces to fix all problems with whitespaces.\r\n\r\nHere is the list of rules that Test::Whitespaces uses:\r\n\r\n * Each line ends with \"\\n\" (including the last line)\r\n * For new lines \"\\n\" is used (not \"\\r\\n\")\r\n * There are no ending spaces on the lines\r\n * 4 spaces are used instead of tabs\r\n * No empty lines in the end of file"},"comment":{"url":"https://api.github.com/repos/garu/Data-Printer/issues/comments/106953780","html_url":"https://github.com/garu/Data-Printer/pull/51#issuecomment-106953780","issue_url":"https://api.github.com/repos/garu/Data-Printer/issues/51","id":106953780,"user":{"login":"garu","id":52187,"avatar_url":"https://avatars.githubusercontent.com/u/52187?v=3","gravatar_id":"","url":"https://api.github.com/users/garu","html_url":"https://github.com/garu","followers_url":"https://api.github.com/users/garu/followers","following_url":"https://api.github.com/users/garu/following{/other_user}","gists_url":"https://api.github.com/users/garu/gists{/gist_id}","starred_url":"https://api.github.com/users/garu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garu/subscriptions","organizations_url":"https://api.github.com/users/garu/orgs","repos_url":"https://api.github.com/users/garu/repos","events_url":"https://api.github.com/users/garu/events{/privacy}","received_events_url":"https://api.github.com/users/garu/received_events","type":"User","site_admin":false},"created_at":"2015-05-29T22:50:27Z","updated_at":"2015-05-29T22:50:27Z","body":"Nice! Actually, while I agree with you that variant 3 should be implemented, the issue I think is mostly because the regex being tested begins with a newline, and this is the only reason why the space becomes irrelevant. Considering that \"relevant trailing whitespace is evil\" I will fiddle with the expected string so the tests (and #52) remain valid, without needing the overhead of changing p() just because we want to remove trailing whitespace :)\r\n\r\nThanks again for the patch! (and for all the others)"}}