{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/26150751","id":26150751,"diff_hunk":"@@ -132,4 +179,88 @@ public void create() throws IOException {\n       LOG.info(\"Upgraded hbase table: {}\", tableName);\n     }\n   }\n+\n+\n+  // Moves dataset instance meta entries into new table (in system namespace)\n+  // Also updates the spec's name ('cdap.user.foo' -> 'foo')\n+  private void upgradeDatasetInstanceMDS() throws IOException, DatasetManagementException, InterruptedException,\n+    TransactionFailureException {\n+    LOG.info(\"Upgrading dataset instance mds.\");\n+    datasetInstanceMds.execute(new TransactionExecutor.Function<UpgradeMdsStores<DatasetInstanceMDS>, Void>() {\n+      @Override\n+      public Void apply(UpgradeMdsStores<DatasetInstanceMDS> ctx) throws Exception {\n+        MDSKey key = new MDSKey(Bytes.toBytes(DatasetInstanceMDS.INSTANCE_PREFIX));\n+        DatasetInstanceMDS newMds = ctx.getNewMds();\n+        Map<MDSKey, DatasetSpecification> dsSpecs = ctx.getOldMds().listKV(key, DatasetSpecification.class);\n+        for (Map.Entry<MDSKey, DatasetSpecification> dsSpecEntry : dsSpecs.entrySet()) {\n+          DatasetSpecification dsSpec = dsSpecEntry.getValue();\n+          LOG.info(\"Migrating dataset Spec: {}\", dsSpec);\n+          Id.Namespace namespace = namespaceFromDatasetName(dsSpec.getName());\n+          DatasetSpecification migratedDsSpec = migrateDatasetSpec(dsSpec);\n+          LOG.info(\"Writing new dataset Spec: {}\", migratedDsSpec);\n+          newMds.write(namespace, migratedDsSpec);\n+        }\n+        return null;\n+      }\n+    });\n+  }\n+\n+  /**\n+   * Construct a {@link TableId} from a dataset name\n+   * TODO: CDAP-1593 - This is bad and should be removed, since it makes assumptions about the dataset name format.\n+   *\n+   * @param name the dataset/table name to construct the {@link TableId} from\n+   * @return the {@link TableId} object for the specified dataset/table name\n+   */\n+  private static TableId from(String name) {\n+    Preconditions.checkArgument(name != null, \"Dataset name should not be null\");\n+    // Dataset/Table name is expected to be in the format <table-prefix>.<namespace>.<name>\n+    String invalidFormatError = String.format(\"Invalid format for dataset/table name '%s'. \" +\n+                                                \"Expected - <table-prefix>.<namespace>.<dataset/table-name>\", name);\n+    String [] parts = name.split(\"\\\\.\", 3);\n+    Preconditions.checkArgument(parts.length == 3, invalidFormatError);\n+    // Ignore the prefix in the input name.\n+    return TableId.from(Id.Namespace.from(parts[1]), parts[2]);\n+  }\n+\n+  private DatasetSpecification migrateDatasetSpec(DatasetSpecification oldSpec) {\n+    TableId from = from(oldSpec.getName());\n+    String newDatasetName = from.getTableName();\n+    return DatasetSpecification.changeName(oldSpec, newDatasetName);\n+  }\n+\n+  private Id.Namespace namespaceFromDatasetName(String dsName) {\n+    // input of the form: 'cdap.user.foo', or 'cdap.system.app.meta'\n+    TableId tableId = from(dsName);\n+    String namespace = tableId.getNamespace().getId();\n+    if (Constants.SYSTEM_NAMESPACE.equals(namespace)) {\n+      return Constants.SYSTEM_NAMESPACE_ID;\n+    } else if (\"user\".equals(namespace)) {\n+      return Constants.DEFAULT_NAMESPACE_ID;\n+    } else {\n+      throw new IllegalArgumentException(String.format(\"Expected dataset namespace to be either 'system' or 'user': %s\",\n+                                                       tableId));\n+    }\n+  }\n+\n+  private static final class UpgradeMdsStores<T> implements Iterable<T> {\n+    private final List<T> stores;\n+\n+    private UpgradeMdsStores(T oldMds, T newMds) {\n+      this.stores = ImmutableList.of(oldMds, newMds);\n+    }\n+\n+    private T getOldMds() {\n+      return stores.get(0);\n+    }\n+\n+    private T getNewMds() {\n+      return stores.get(1);","path":"cdap-master/src/main/java/co/cask/cdap/data/tools/DatasetUpgrader.java","position":205,"original_position":205,"commit_id":"1b5fa7144e4bc80a65f7c12b930a371eec27bdec","original_commit_id":"1b5fa7144e4bc80a65f7c12b930a371eec27bdec","user":{"login":"rohitsinha54","id":1472867,"avatar_url":"https://avatars.githubusercontent.com/u/1472867?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitsinha54","html_url":"https://github.com/rohitsinha54","followers_url":"https://api.github.com/users/rohitsinha54/followers","following_url":"https://api.github.com/users/rohitsinha54/following{/other_user}","gists_url":"https://api.github.com/users/rohitsinha54/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitsinha54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitsinha54/subscriptions","organizations_url":"https://api.github.com/users/rohitsinha54/orgs","repos_url":"https://api.github.com/users/rohitsinha54/repos","events_url":"https://api.github.com/users/rohitsinha54/events{/privacy}","received_events_url":"https://api.github.com/users/rohitsinha54/received_events","type":"User","site_admin":false},"body":"Nice,","created_at":"2015-03-10T18:26:30Z","updated_at":"2015-03-10T18:26:30Z","html_url":"https://github.com/caskdata/cdap/pull/1566#discussion_r26150751","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/1566","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/26150751"},"html":{"href":"https://github.com/caskdata/cdap/pull/1566#discussion_r26150751"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/1566"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/1566","id":30840674,"html_url":"https://github.com/caskdata/cdap/pull/1566","diff_url":"https://github.com/caskdata/cdap/pull/1566.diff","patch_url":"https://github.com/caskdata/cdap/pull/1566.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/1566","number":1566,"state":"open","locked":false,"title":"Upgrade/Migrate dataset instances mds.","user":{"login":"anwar6953","id":2440977,"avatar_url":"https://avatars.githubusercontent.com/u/2440977?v=3","gravatar_id":"","url":"https://api.github.com/users/anwar6953","html_url":"https://github.com/anwar6953","followers_url":"https://api.github.com/users/anwar6953/followers","following_url":"https://api.github.com/users/anwar6953/following{/other_user}","gists_url":"https://api.github.com/users/anwar6953/gists{/gist_id}","starred_url":"https://api.github.com/users/anwar6953/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anwar6953/subscriptions","organizations_url":"https://api.github.com/users/anwar6953/orgs","repos_url":"https://api.github.com/users/anwar6953/repos","events_url":"https://api.github.com/users/anwar6953/events{/privacy}","received_events_url":"https://api.github.com/users/anwar6953/received_events","type":"User","site_admin":false},"body":"https://issues.cask.co/browse/CDAP-1511\r\nhttp://builds.cask.co/browse/CDAP-DUT1048-6","created_at":"2015-03-10T11:09:27Z","updated_at":"2015-03-10T18:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982321a1035ef33cac25779816c5ec7cd6c9740d","assignee":null,"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/3","html_url":"https://github.com/caskdata/cdap/milestones/2.8.0","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/3/labels","id":944584,"number":3,"title":"2.8.0","description":null,"creator":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":167,"state":"open","created_at":"2015-01-21T01:15:14Z","updated_at":"2015-03-10T17:37:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/1566/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/1566/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/1566/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/1b5fa7144e4bc80a65f7c12b930a371eec27bdec","head":{"label":"caskdata:feature/CDAP-1511-dataset-instance-table-upgrader","ref":"feature/CDAP-1511-dataset-instance-table-upgrader","sha":"1b5fa7144e4bc80a65f7c12b930a371eec27bdec","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-03-10T17:37:03Z","pushed_at":"2015-03-10T18:24:39Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":797700,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":32,"forks":9,"open_issues":32,"watchers":32,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"44bfc678ea01d8c0ba6e27989a80057ae7998e10","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-03-10T17:37:03Z","pushed_at":"2015-03-10T18:24:39Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":797700,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":32,"forks":9,"open_issues":32,"watchers":32,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/1566"},"html":{"href":"https://github.com/caskdata/cdap/pull/1566"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/1566"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/1566/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/1566/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/1566/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/1b5fa7144e4bc80a65f7c12b930a371eec27bdec"}}}}