{"push_id":755209027,"size":3,"distinct_size":0,"ref":"refs/heads/dev.ssa","head":"463858e6ff8cacd3bf2dafebe56272f8a863d959","before":"e0e556620aaf9861c422191fc1efb8020c2f1507","commits":[{"sha":"40aba8c4e7ac5babf9901d1948ff56c117e3bcf9","author":{"email":"ae171625adc8645b8b79b7e405a6da5aba5341e0@google.com","name":"David Chase"},"message":"[dev.ssa] cmd/compile: add support for LROT, and tests\n\nHardcoded the limit on constants only allowed.\n\nChange-Id: Idb9b07b4871db7a752a79e492671e9b41207b956\nReviewed-on: https://go-review.googlesource.com/13257\nReviewed-by: Keith Randall <khr@golang.org>\nReviewed-by: Josh Bleecher Snyder <josharian@gmail.com>","distinct":false,"url":"https://api.github.com/repos/josharian/go.ssa/commits/40aba8c4e7ac5babf9901d1948ff56c117e3bcf9"},{"sha":"2af06480140dd48a4dc54257c2da46a73ca3ebb5","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"[dev.ssa] cmd/compile: fix function call memory accounting\n\nWe were not recording function calls as\nchanging the state of memory.\n\nAs a result, the scheduler was not aware that\nstoring values to the stack in order to make a\nfunction call must happen *after* retrieving\nresults from the stack from a just-completed\nfunction call.\n\nThis fixes the container/ring tests.\n\nThis was my first experience debugging an issue\nusing the HTML output. I'm feeling quite\npleased with it.\n\nChange-Id: I9e8276846be9fd7a60422911b11816c5175e3d0a\nReviewed-on: https://go-review.googlesource.com/13560\nReviewed-by: Keith Randall <khr@golang.org>","distinct":false,"url":"https://api.github.com/repos/josharian/go.ssa/commits/2af06480140dd48a4dc54257c2da46a73ca3ebb5"},{"sha":"463858e6ff8cacd3bf2dafebe56272f8a863d959","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"[dev.ssa] cmd/compile: make failed nil checks panic\n\nIntroduce pseudo-ops PanicMem and LoweredPanicMem.\nPanicMem could be rewritten directly into MOVL\nduring lowering, but then we couldn't log nil checks.\n\nWith this change, runnable nil check tests pass:\n\nGOSSAPKG=main go run run.go -- nil*.go\n\nCompiler output nil check tests fail:\n\nGOSSAPKG=p go run run.go -- nil*.go\n\nThis is due to several factors:\n\n* SSA has improved elimination of unnecessary nil checks.\n* SSA is missing elimination of implicit nil checks.\n* SSA is missing extra logging about why nil checks were removed.\n\nI'm not sure how best to resolve these failures,\nparticularly in a world in which the two backends\nwill live side by side for some time.\nFor now, punt on the problem.\n\nChange-Id: Ib2ca6824551671f92e0e1800b036f5ca0905e2a3\nReviewed-on: https://go-review.googlesource.com/13474\nReviewed-by: Keith Randall <khr@golang.org>","distinct":false,"url":"https://api.github.com/repos/josharian/go.ssa/commits/463858e6ff8cacd3bf2dafebe56272f8a863d959"}]}