{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/1480","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/1480/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/1480/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/1480/events","html_url":"https://github.com/weaveworks/weave/issues/1480","id":109049389,"number":1480,"title":"Data race in TestRecursiveCompress","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/weaveworks/weave/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/weaveworks/weave/labels/[component/dns]","name":"[component/dns]","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/weaveworks/weave/milestones/15","html_url":"https://github.com/weaveworks/weave/milestones/1.1.1","labels_url":"https://api.github.com/repos/weaveworks/weave/milestones/15/labels","id":1296220,"number":15,"title":"1.1.1","description":"","creator":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":16,"state":"open","created_at":"2015-09-08T19:17:22Z","updated_at":"2015-09-30T09:42:43Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-09-30T09:28:42Z","updated_at":"2015-09-30T09:43:14Z","closed_at":null,"body":"https://circleci.com/gh/weaveworks/weave/3023\r\n\r\n```\r\n==================\r\nWARNING: DATA RACE\r\nRead by goroutine 24:\r\n  github.com/weaveworks/weave/nameserver.(*handler).handleRecursive()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:260 +0x423\r\n  github.com/weaveworks/weave/nameserver.*handler.(github.com/weaveworks/weave/nameserver.handleRecursive)·fm()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:157 +0x52\r\n  github.com/miekg/dns.HandlerFunc.ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:82 +0x4e\r\n  github.com/miekg/dns.(*ServeMux).ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:186 +0xf0\r\n  github.com/miekg/dns.(*Server).serve()\r\n      /home/go/src/github.com/miekg/dns/server.go:565 +0xcc5\r\n\r\nPrevious write by goroutine 19:\r\n  github.com/weaveworks/weave/nameserver.TestRecursiveCompress()\r\n      /home/go/src/github.com/weaveworks/weave/nameserver/dns_test.go:150 +0xd84\r\n  testing.tRunner()\r\n      /usr/local/go/src/testing/testing.go:447 +0x133\r\n\r\nGoroutine 24 (running) created at:\r\n  github.com/miekg/dns.(*Server).serveUDP()\r\n      /home/go/src/github.com/miekg/dns/server.go:512 +0x49e\r\n  github.com/miekg/dns.(*Server).ActivateAndServe()\r\n      /home/go/src/github.com/miekg/dns/server.go:369 +0x43b\r\n  github.com/weaveworks/weave/nameserver.func·002()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:123 +0x51\r\n\r\nGoroutine 19 (running) created at:\r\n  testing.RunTests()\r\n      /usr/local/go/src/testing/testing.go:555 +0xd4e\r\n  testing.(*M).Run()\r\n      /usr/local/go/src/testing/testing.go:485 +0xe0\r\n  main.main()\r\n      github.com/weaveworks/weave/nameserver/_test/_testmain.go:204 +0x383\r\n==================\r\n==================\r\nWARNING: DATA RACE\r\nRead by goroutine 24:\r\n  github.com/weaveworks/weave/nameserver.(*handler).handleRecursive()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:260 +0x43b\r\n  github.com/weaveworks/weave/nameserver.*handler.(github.com/weaveworks/weave/nameserver.handleRecursive)·fm()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:157 +0x52\r\n  github.com/miekg/dns.HandlerFunc.ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:82 +0x4e\r\n  github.com/miekg/dns.(*ServeMux).ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:186 +0xf0\r\n  github.com/miekg/dns.(*Server).serve()\r\n      /home/go/src/github.com/miekg/dns/server.go:565 +0xcc5\r\n\r\nPrevious write by goroutine 19:\r\n  github.com/weaveworks/weave/nameserver.TestRecursiveCompress()\r\n      /home/go/src/github.com/weaveworks/weave/nameserver/dns_test.go:149 +0xbbc\r\n  testing.tRunner()\r\n      /usr/local/go/src/testing/testing.go:447 +0x133\r\n\r\nGoroutine 24 (running) created at:\r\n  github.com/miekg/dns.(*Server).serveUDP()\r\n      /home/go/src/github.com/miekg/dns/server.go:512 +0x49e\r\n  github.com/miekg/dns.(*Server).ActivateAndServe()\r\n      /home/go/src/github.com/miekg/dns/server.go:369 +0x43b\r\n  github.com/weaveworks/weave/nameserver.func·002()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:123 +0x51\r\n\r\nGoroutine 19 (running) created at:\r\n  testing.RunTests()\r\n      /usr/local/go/src/testing/testing.go:555 +0xd4e\r\n  testing.(*M).Run()\r\n      /usr/local/go/src/testing/testing.go:485 +0xe0\r\n  main.main()\r\n      github.com/weaveworks/weave/nameserver/_test/_testmain.go:204 +0x383\r\n==================\r\n==================\r\nWARNING: DATA RACE\r\nRead by goroutine 24:\r\n  github.com/weaveworks/weave/nameserver.(*handler).handleRecursive()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:260 +0x4a2\r\n  github.com/weaveworks/weave/nameserver.*handler.(github.com/weaveworks/weave/nameserver.handleRecursive)·fm()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:157 +0x52\r\n  github.com/miekg/dns.HandlerFunc.ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:82 +0x4e\r\n  github.com/miekg/dns.(*ServeMux).ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:186 +0xf0\r\n  github.com/miekg/dns.(*Server).serve()\r\n      /home/go/src/github.com/miekg/dns/server.go:565 +0xcc5\r\n\r\nPrevious write by goroutine 19:\r\n  github.com/weaveworks/weave/nameserver.TestRecursiveCompress()\r\n      /home/go/src/github.com/weaveworks/weave/nameserver/dns_test.go:145 +0xc14\r\n  testing.tRunner()\r\n      /usr/local/go/src/testing/testing.go:447 +0x133\r\n\r\nGoroutine 24 (running) created at:\r\n  github.com/miekg/dns.(*Server).serveUDP()\r\n      /home/go/src/github.com/miekg/dns/server.go:512 +0x49e\r\n  github.com/miekg/dns.(*Server).ActivateAndServe()\r\n      /home/go/src/github.com/miekg/dns/server.go:369 +0x43b\r\n  github.com/weaveworks/weave/nameserver.func·002()\r\n      github.com/weaveworks/weave/nameserver/_test/_obj_test/dns.go:123 +0x51\r\n\r\nGoroutine 19 (running) created at:\r\n  testing.RunTests()\r\n      /usr/local/go/src/testing/testing.go:555 +0xd4e\r\n  testing.(*M).Run()\r\n      /usr/local/go/src/testing/testing.go:485 +0xe0\r\n  main.main()\r\n      github.com/weaveworks/weave/nameserver/_test/_testmain.go:204 +0x383\r\n==================\r\n==================\r\nWARNING: DATA RACE\r\nRead by goroutine 19:\r\n  github.com/weaveworks/weave/nameserver.TestRecursiveCompress()\r\n      /home/go/src/github.com/weaveworks/weave/nameserver/dns_test.go:168 +0x12b0\r\n  testing.tRunner()\r\n      /usr/local/go/src/testing/testing.go:447 +0x133\r\n\r\nPrevious write by goroutine 25:\r\n  github.com/weaveworks/weave/nameserver.func·023()\r\n      /home/go/src/github.com/weaveworks/weave/nameserver/dns_test.go:127 +0x57\r\n  github.com/miekg/dns.HandlerFunc.ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:82 +0x4e\r\n  github.com/miekg/dns.(*ServeMux).ServeDNS()\r\n      /home/go/src/github.com/miekg/dns/server.go:186 +0xf0\r\n  github.com/miekg/dns.(*Server).serve()\r\n      /home/go/src/github.com/miekg/dns/server.go:565 +0xcc5\r\n\r\nGoroutine 19 (running) created at:\r\n  testing.RunTests()\r\n      /usr/local/go/src/testing/testing.go:555 +0xd4e\r\n  testing.(*M).Run()\r\n      /usr/local/go/src/testing/testing.go:485 +0xe0\r\n  main.main()\r\n      github.com/weaveworks/weave/nameserver/_test/_testmain.go:204 +0x383\r\n\r\nGoroutine 25 (finished) created at:\r\n  github.com/miekg/dns.(*Server).serveUDP()\r\n      /home/go/src/github.com/miekg/dns/server.go:512 +0x49e\r\n  github.com/miekg/dns.(*Server).ActivateAndServe()\r\n      /home/go/src/github.com/miekg/dns/server.go:369 +0x43b\r\n==================\r\n```"},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/144340523","html_url":"https://github.com/weaveworks/weave/issues/1480#issuecomment-144340523","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/1480","id":144340523,"user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T09:43:14Z","updated_at":"2015-09-30T09:43:14Z","body":"How come this doesn't trip up circle all the time?"}}