{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3436","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3436/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3436/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3436/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3436","id":94861699,"number":3436,"title":"remove warnings around MiqReportResult#all","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/rails%204","name":"rails 4","color":"f7c6c7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/reporting","name":"reporting","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-07-14T03:47:50Z","updated_at":"2015-07-14T18:25:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3436","html_url":"https://github.com/ManageIQ/manageiq/pull/3436","diff_url":"https://github.com/ManageIQ/manageiq/pull/3436.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3436.patch"},"body":"Rails is complaining about calling MiqReportResult#all\r\n\r\nIntroduce MiqReportResult#not_user_generated that will ensure the report_source\r\nis not \"Generated by User\"\r\n\r\n\r\nI wrote the code, but didn't test. Please advise if I need to add more tests.\r\n(since there were a number of travis warnings, I'm guessing most of this code is called in tests)\r\n\r\n```\r\nDEPRECATION WARNING: Relation#all is deprecated. If you want to eager-load a relation, you can call #load (e.g. `Post.where(published: true).load`). If you want to get an array of records from a relation, you can call #to_a (e.g. `Post.where(published: true).to_a`). (called from x_get_tree_custom_kids at /home/travis/build/ManageIQ/manageiq/app/presenters/tree_builder_chargeback_rates.rb:47)\r\nDEPRECATION WARNING: Relation#all is deprecated. If you want to eager-load a relation, you can call #load (e.g. `Post.where(published: true).load`). If you want to get an array of records from a relation, you can call #to_a (e.g. `Post.where(published: true).to_a`). (called from x_get_tree_roots at /home/travis/build/ManageIQ/manageiq/app/presenters/tree_builder_chargeback_reports.rb:21)\r\nDEPRECATION WARNING: Relation#all is deprecated. If you want to eager-load a relation, you can call #load (e.g. `Post.where(published: true).load`). If you want to get an array of records from a relation, you can call #to_a (e.g. `Post.where(published: true).to_a`). (called from cb_rpt_build_folder_nodes at /home/travis/build/ManageIQ/manageiq/app/controllers/chargeback_controller.rb:491)\r\nDEPRECATION WARNING: Relation#all is deprecated. If you want to eager-load a relation, you can call #load (e.g. `Post.where(published: true).load`). If you want to get an array of records from a relation, you can call #to_a (e.g. `Post.where(published: true).to_a`). (called from cb_rpt_build_folder_nodes at /home/travis/build/ManageIQ/manageiq/app/controllers/chargeback_controller.rb:491)\r\n```"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/121330444","html_url":"https://github.com/ManageIQ/manageiq/pull/3436#issuecomment-121330444","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3436","id":121330444,"user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T18:25:32Z","updated_at":"2015-07-14T18:25:32Z","body":"Thanks - made clause positive and pulled out sort/grouping."}}