{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/32703968","id":32703968,"diff_hunk":"@@ -3043,14 +3043,25 @@ void CDVDPlayer::GetGeneralInfo(std::string& strGeneralInfo)\n   }\n }\n \n-void CDVDPlayer::SeekPercentage(float iPercent)\n+void CDVDPlayer::SeekPercentage(float fPercent)\n {\n   int64_t iTotalTime = GetTotalTimeInMsec();\n \n   if (!iTotalTime)\n     return;\n \n-  SeekTime((int64_t)(iTotalTime * iPercent / 100));\n+  SeekTime((int64_t)(iTotalTime * fPercent / 100));\n+}\n+\n+bool CDVDPlayer::SeekPercentageRelative(float fPercent)","path":"xbmc/cores/dvdplayer/DVDPlayer.cpp","position":16,"original_position":16,"commit_id":"98a0f2d482321b0bd8af8fecbd8988e6f9db0af4","original_commit_id":"98a0f2d482321b0bd8af8fecbd8988e6f9db0af4","user":{"login":"da-anda","id":1159249,"avatar_url":"https://avatars.githubusercontent.com/u/1159249?v=3","gravatar_id":"","url":"https://api.github.com/users/da-anda","html_url":"https://github.com/da-anda","followers_url":"https://api.github.com/users/da-anda/followers","following_url":"https://api.github.com/users/da-anda/following{/other_user}","gists_url":"https://api.github.com/users/da-anda/gists{/gist_id}","starred_url":"https://api.github.com/users/da-anda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da-anda/subscriptions","organizations_url":"https://api.github.com/users/da-anda/orgs","repos_url":"https://api.github.com/users/da-anda/repos","events_url":"https://api.github.com/users/da-anda/events{/privacy}","received_events_url":"https://api.github.com/users/da-anda/received_events","type":"User","site_admin":false},"body":"couldn't relative just be a bool second param of CDVDPlayer::SeekPercentage()?","created_at":"2015-06-18T07:14:43Z","updated_at":"2015-06-18T07:14:43Z","html_url":"https://github.com/xbmc/xbmc/pull/7266#discussion_r32703968","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7266","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/32703968"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7266#discussion_r32703968"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7266"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7266","id":37560626,"html_url":"https://github.com/xbmc/xbmc/pull/7266","diff_url":"https://github.com/xbmc/xbmc/pull/7266.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7266.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7266","number":7266,"state":"open","locked":false,"title":"[RFC] Handle bigstep and chapter seek in SeekHandler","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"body":"Not sure if it really makes sense, but IMO we should handle all kinds of seeking in our SeekHandler. The Player shouldn't handle things like bigstep, smallstep + AS stuff or if we want to seek in percent. Instead it should only expose methods to seek by chapter, time, percentage, scene. The seek handler will do the necessary stuff to choose which method fits and call it.\r\n\r\nTherefore the method `Seek(bool bPlus, bool bLargeStep, bool bChapterOverride)` should die, but ATM i leave it in because of the EDL handling and I'm not sure where this part should be moved to.\r\n\r\n@FernetMenta mind taking a look","created_at":"2015-06-12T13:10:23Z","updated_at":"2015-06-18T07:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5062eba126f054f7efade1d0bdcd957e3567cf69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7266/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7266/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7266/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/98a0f2d482321b0bd8af8fecbd8988e6f9db0af4","head":{"label":"xhaggi:handle-bigstep-chapter-seek-in-seekhandler","ref":"handle-bigstep-chapter-seek-in-seekhandler","sha":"98a0f2d482321b0bd8af8fecbd8988e6f9db0af4","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"repo":{"id":5698705,"name":"xbmc","full_name":"xhaggi/xbmc","owner":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xhaggi/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/xhaggi/xbmc","forks_url":"https://api.github.com/repos/xhaggi/xbmc/forks","keys_url":"https://api.github.com/repos/xhaggi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xhaggi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xhaggi/xbmc/teams","hooks_url":"https://api.github.com/repos/xhaggi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xhaggi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xhaggi/xbmc/events","assignees_url":"https://api.github.com/repos/xhaggi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xhaggi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xhaggi/xbmc/tags","blobs_url":"https://api.github.com/repos/xhaggi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xhaggi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xhaggi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xhaggi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xhaggi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xhaggi/xbmc/languages","stargazers_url":"https://api.github.com/repos/xhaggi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xhaggi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xhaggi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xhaggi/xbmc/subscription","commits_url":"https://api.github.com/repos/xhaggi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xhaggi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xhaggi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xhaggi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xhaggi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xhaggi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xhaggi/xbmc/merges","archive_url":"https://api.github.com/repos/xhaggi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xhaggi/xbmc/downloads","issues_url":"https://api.github.com/repos/xhaggi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xhaggi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xhaggi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xhaggi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xhaggi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xhaggi/xbmc/releases{/id}","created_at":"2012-09-06T07:06:44Z","updated_at":"2015-04-20T10:44:49Z","pushed_at":"2015-06-12T13:32:47Z","git_url":"git://github.com/xhaggi/xbmc.git","ssh_url":"git@github.com:xhaggi/xbmc.git","clone_url":"https://github.com/xhaggi/xbmc.git","svn_url":"https://github.com/xhaggi/xbmc","homepage":"http://xbmc.org","size":513843,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"54ff3ddb91fa5c2b89fdb4c6b61591b6605e2915","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-06-18T02:25:05Z","pushed_at":"2015-06-18T00:38:04Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1869356,"stargazers_count":3954,"watchers_count":3954,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2875,"mirror_url":null,"open_issues_count":226,"forks":2875,"open_issues":226,"watchers":3954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7266"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7266"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7266"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7266/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7266/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7266/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/98a0f2d482321b0bd8af8fecbd8988e6f9db0af4"}}}}