{"action":"closed","number":380,"pull_request":{"url":"https://api.github.com/repos/scalanlp/breeze/pulls/380","id":31090755,"html_url":"https://github.com/scalanlp/breeze/pull/380","diff_url":"https://github.com/scalanlp/breeze/pull/380.diff","patch_url":"https://github.com/scalanlp/breeze/pull/380.patch","issue_url":"https://api.github.com/repos/scalanlp/breeze/issues/380","number":380,"state":"closed","locked":false,"title":"QuadraticMinimizer.updateGram cleaned exceptions","user":{"login":"debasish83","id":510896,"avatar_url":"https://avatars.githubusercontent.com/u/510896?v=3","gravatar_id":"","url":"https://api.github.com/users/debasish83","html_url":"https://github.com/debasish83","followers_url":"https://api.github.com/users/debasish83/followers","following_url":"https://api.github.com/users/debasish83/following{/other_user}","gists_url":"https://api.github.com/users/debasish83/gists{/gist_id}","starred_url":"https://api.github.com/users/debasish83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debasish83/subscriptions","organizations_url":"https://api.github.com/users/debasish83/orgs","repos_url":"https://api.github.com/users/debasish83/repos","events_url":"https://api.github.com/users/debasish83/events{/privacy}","received_events_url":"https://api.github.com/users/debasish83/received_events","type":"User","site_admin":false},"body":"At each iteration of updateGram I was checking if the indices are within bounds but when we call it from mllib ALS, we make sure upfront if the indices are fine. Having conditional checks will affect the performance for example. I cleaned it up and added a comment so that users are aware of this optimization.","created_at":"2015-03-13T00:21:11Z","updated_at":"2015-03-13T18:23:16Z","closed_at":"2015-03-13T18:23:16Z","merged_at":"2015-03-13T18:23:16Z","merge_commit_sha":"e832c925b63232c9725ac9847bc1c53bae6e39c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scalanlp/breeze/pulls/380/commits","review_comments_url":"https://api.github.com/repos/scalanlp/breeze/pulls/380/comments","review_comment_url":"https://api.github.com/repos/scalanlp/breeze/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalanlp/breeze/issues/380/comments","statuses_url":"https://api.github.com/repos/scalanlp/breeze/statuses/111530350a77e6391fe00f92c9ea03fb0d60390a","head":{"label":"debasish83:gram","ref":"gram","sha":"111530350a77e6391fe00f92c9ea03fb0d60390a","user":{"login":"debasish83","id":510896,"avatar_url":"https://avatars.githubusercontent.com/u/510896?v=3","gravatar_id":"","url":"https://api.github.com/users/debasish83","html_url":"https://github.com/debasish83","followers_url":"https://api.github.com/users/debasish83/followers","following_url":"https://api.github.com/users/debasish83/following{/other_user}","gists_url":"https://api.github.com/users/debasish83/gists{/gist_id}","starred_url":"https://api.github.com/users/debasish83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debasish83/subscriptions","organizations_url":"https://api.github.com/users/debasish83/orgs","repos_url":"https://api.github.com/users/debasish83/repos","events_url":"https://api.github.com/users/debasish83/events{/privacy}","received_events_url":"https://api.github.com/users/debasish83/received_events","type":"User","site_admin":false},"repo":{"id":18274015,"name":"breeze","full_name":"debasish83/breeze","owner":{"login":"debasish83","id":510896,"avatar_url":"https://avatars.githubusercontent.com/u/510896?v=3","gravatar_id":"","url":"https://api.github.com/users/debasish83","html_url":"https://github.com/debasish83","followers_url":"https://api.github.com/users/debasish83/followers","following_url":"https://api.github.com/users/debasish83/following{/other_user}","gists_url":"https://api.github.com/users/debasish83/gists{/gist_id}","starred_url":"https://api.github.com/users/debasish83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debasish83/subscriptions","organizations_url":"https://api.github.com/users/debasish83/orgs","repos_url":"https://api.github.com/users/debasish83/repos","events_url":"https://api.github.com/users/debasish83/events{/privacy}","received_events_url":"https://api.github.com/users/debasish83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/debasish83/breeze","description":"Breeze is a numerical processing library for Scala.","fork":true,"url":"https://api.github.com/repos/debasish83/breeze","forks_url":"https://api.github.com/repos/debasish83/breeze/forks","keys_url":"https://api.github.com/repos/debasish83/breeze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debasish83/breeze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debasish83/breeze/teams","hooks_url":"https://api.github.com/repos/debasish83/breeze/hooks","issue_events_url":"https://api.github.com/repos/debasish83/breeze/issues/events{/number}","events_url":"https://api.github.com/repos/debasish83/breeze/events","assignees_url":"https://api.github.com/repos/debasish83/breeze/assignees{/user}","branches_url":"https://api.github.com/repos/debasish83/breeze/branches{/branch}","tags_url":"https://api.github.com/repos/debasish83/breeze/tags","blobs_url":"https://api.github.com/repos/debasish83/breeze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debasish83/breeze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debasish83/breeze/git/refs{/sha}","trees_url":"https://api.github.com/repos/debasish83/breeze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debasish83/breeze/statuses/{sha}","languages_url":"https://api.github.com/repos/debasish83/breeze/languages","stargazers_url":"https://api.github.com/repos/debasish83/breeze/stargazers","contributors_url":"https://api.github.com/repos/debasish83/breeze/contributors","subscribers_url":"https://api.github.com/repos/debasish83/breeze/subscribers","subscription_url":"https://api.github.com/repos/debasish83/breeze/subscription","commits_url":"https://api.github.com/repos/debasish83/breeze/commits{/sha}","git_commits_url":"https://api.github.com/repos/debasish83/breeze/git/commits{/sha}","comments_url":"https://api.github.com/repos/debasish83/breeze/comments{/number}","issue_comment_url":"https://api.github.com/repos/debasish83/breeze/issues/comments{/number}","contents_url":"https://api.github.com/repos/debasish83/breeze/contents/{+path}","compare_url":"https://api.github.com/repos/debasish83/breeze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debasish83/breeze/merges","archive_url":"https://api.github.com/repos/debasish83/breeze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debasish83/breeze/downloads","issues_url":"https://api.github.com/repos/debasish83/breeze/issues{/number}","pulls_url":"https://api.github.com/repos/debasish83/breeze/pulls{/number}","milestones_url":"https://api.github.com/repos/debasish83/breeze/milestones{/number}","notifications_url":"https://api.github.com/repos/debasish83/breeze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debasish83/breeze/labels{/name}","releases_url":"https://api.github.com/repos/debasish83/breeze/releases{/id}","created_at":"2014-03-30T21:16:03Z","updated_at":"2015-03-12T22:13:41Z","pushed_at":"2015-03-13T06:14:03Z","git_url":"git://github.com/debasish83/breeze.git","ssh_url":"git@github.com:debasish83/breeze.git","clone_url":"https://github.com/debasish83/breeze.git","svn_url":"https://github.com/debasish83/breeze","homepage":"www.scalanlp.org","size":25500,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalanlp:master","ref":"master","sha":"b3d39e94c91a18b70112bbe640873ffde45db10e","user":{"login":"scalanlp","id":103090,"avatar_url":"https://avatars.githubusercontent.com/u/103090?v=3","gravatar_id":"","url":"https://api.github.com/users/scalanlp","html_url":"https://github.com/scalanlp","followers_url":"https://api.github.com/users/scalanlp/followers","following_url":"https://api.github.com/users/scalanlp/following{/other_user}","gists_url":"https://api.github.com/users/scalanlp/gists{/gist_id}","starred_url":"https://api.github.com/users/scalanlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalanlp/subscriptions","organizations_url":"https://api.github.com/users/scalanlp/orgs","repos_url":"https://api.github.com/users/scalanlp/repos","events_url":"https://api.github.com/users/scalanlp/events{/privacy}","received_events_url":"https://api.github.com/users/scalanlp/received_events","type":"Organization","site_admin":false},"repo":{"id":246644,"name":"breeze","full_name":"scalanlp/breeze","owner":{"login":"scalanlp","id":103090,"avatar_url":"https://avatars.githubusercontent.com/u/103090?v=3","gravatar_id":"","url":"https://api.github.com/users/scalanlp","html_url":"https://github.com/scalanlp","followers_url":"https://api.github.com/users/scalanlp/followers","following_url":"https://api.github.com/users/scalanlp/following{/other_user}","gists_url":"https://api.github.com/users/scalanlp/gists{/gist_id}","starred_url":"https://api.github.com/users/scalanlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalanlp/subscriptions","organizations_url":"https://api.github.com/users/scalanlp/orgs","repos_url":"https://api.github.com/users/scalanlp/repos","events_url":"https://api.github.com/users/scalanlp/events{/privacy}","received_events_url":"https://api.github.com/users/scalanlp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalanlp/breeze","description":"Breeze is a numerical processing library for Scala.","fork":false,"url":"https://api.github.com/repos/scalanlp/breeze","forks_url":"https://api.github.com/repos/scalanlp/breeze/forks","keys_url":"https://api.github.com/repos/scalanlp/breeze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalanlp/breeze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalanlp/breeze/teams","hooks_url":"https://api.github.com/repos/scalanlp/breeze/hooks","issue_events_url":"https://api.github.com/repos/scalanlp/breeze/issues/events{/number}","events_url":"https://api.github.com/repos/scalanlp/breeze/events","assignees_url":"https://api.github.com/repos/scalanlp/breeze/assignees{/user}","branches_url":"https://api.github.com/repos/scalanlp/breeze/branches{/branch}","tags_url":"https://api.github.com/repos/scalanlp/breeze/tags","blobs_url":"https://api.github.com/repos/scalanlp/breeze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalanlp/breeze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalanlp/breeze/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalanlp/breeze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalanlp/breeze/statuses/{sha}","languages_url":"https://api.github.com/repos/scalanlp/breeze/languages","stargazers_url":"https://api.github.com/repos/scalanlp/breeze/stargazers","contributors_url":"https://api.github.com/repos/scalanlp/breeze/contributors","subscribers_url":"https://api.github.com/repos/scalanlp/breeze/subscribers","subscription_url":"https://api.github.com/repos/scalanlp/breeze/subscription","commits_url":"https://api.github.com/repos/scalanlp/breeze/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalanlp/breeze/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalanlp/breeze/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalanlp/breeze/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalanlp/breeze/contents/{+path}","compare_url":"https://api.github.com/repos/scalanlp/breeze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalanlp/breeze/merges","archive_url":"https://api.github.com/repos/scalanlp/breeze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalanlp/breeze/downloads","issues_url":"https://api.github.com/repos/scalanlp/breeze/issues{/number}","pulls_url":"https://api.github.com/repos/scalanlp/breeze/pulls{/number}","milestones_url":"https://api.github.com/repos/scalanlp/breeze/milestones{/number}","notifications_url":"https://api.github.com/repos/scalanlp/breeze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalanlp/breeze/labels{/name}","releases_url":"https://api.github.com/repos/scalanlp/breeze/releases{/id}","created_at":"2009-07-08T23:22:52Z","updated_at":"2015-03-13T15:09:35Z","pushed_at":"2015-03-13T18:23:16Z","git_url":"git://github.com/scalanlp/breeze.git","ssh_url":"git@github.com:scalanlp/breeze.git","clone_url":"https://github.com/scalanlp/breeze.git","svn_url":"https://github.com/scalanlp/breeze","homepage":"www.scalanlp.org","size":29131,"stargazers_count":908,"watchers_count":908,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":52,"forks":244,"open_issues":52,"watchers":908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalanlp/breeze/pulls/380"},"html":{"href":"https://github.com/scalanlp/breeze/pull/380"},"issue":{"href":"https://api.github.com/repos/scalanlp/breeze/issues/380"},"comments":{"href":"https://api.github.com/repos/scalanlp/breeze/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/scalanlp/breeze/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/scalanlp/breeze/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalanlp/breeze/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/scalanlp/breeze/statuses/111530350a77e6391fe00f92c9ea03fb0d60390a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dlwh","id":9633,"avatar_url":"https://avatars.githubusercontent.com/u/9633?v=3","gravatar_id":"","url":"https://api.github.com/users/dlwh","html_url":"https://github.com/dlwh","followers_url":"https://api.github.com/users/dlwh/followers","following_url":"https://api.github.com/users/dlwh/following{/other_user}","gists_url":"https://api.github.com/users/dlwh/gists{/gist_id}","starred_url":"https://api.github.com/users/dlwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlwh/subscriptions","organizations_url":"https://api.github.com/users/dlwh/orgs","repos_url":"https://api.github.com/users/dlwh/repos","events_url":"https://api.github.com/users/dlwh/events{/privacy}","received_events_url":"https://api.github.com/users/dlwh/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":2,"additions":6,"deletions":4,"changed_files":1}}