{"action":"created","issue":{"url":"https://api.github.com/repos/ccny-ros-pkg/ccny_rgbd_tools/issues/39","labels_url":"https://api.github.com/repos/ccny-ros-pkg/ccny_rgbd_tools/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/ccny-ros-pkg/ccny_rgbd_tools/issues/39/comments","events_url":"https://api.github.com/repos/ccny-ros-pkg/ccny_rgbd_tools/issues/39/events","html_url":"https://github.com/ccny-ros-pkg/ccny_rgbd_tools/issues/39","id":55240533,"number":39,"title":"SurfDetectorConfig.h removed? ","user":{"login":"DhruvaKumar","id":2751425,"avatar_url":"https://avatars.githubusercontent.com/u/2751425?v=3","gravatar_id":"","url":"https://api.github.com/users/DhruvaKumar","html_url":"https://github.com/DhruvaKumar","followers_url":"https://api.github.com/users/DhruvaKumar/followers","following_url":"https://api.github.com/users/DhruvaKumar/following{/other_user}","gists_url":"https://api.github.com/users/DhruvaKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/DhruvaKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DhruvaKumar/subscriptions","organizations_url":"https://api.github.com/users/DhruvaKumar/orgs","repos_url":"https://api.github.com/users/DhruvaKumar/repos","events_url":"https://api.github.com/users/DhruvaKumar/events{/privacy}","received_events_url":"https://api.github.com/users/DhruvaKumar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-01-23T03:20:42Z","updated_at":"2015-06-23T09:39:12Z","closed_at":null,"body":"Hi,\r\nI think in the recent commit (https://github.com/ccny-ros-pkg/ccny_rgbd_tools/commit/4f5653264eff8e10c59a1fcaef22e9a6db687e63), the dependencies on SurfDetectorConfig.h have been removed.\r\n\r\nHowever, there are still some files which require them like types.h (https://github.com/ccny-ros-pkg/ccny_rgbd_tools/blob/master/ccny_rgbd/include/ccny_rgbd/types.h)\r\n\r\nHere's the build failure description while I tried installing ccny_rgbd_tools:\r\n`rosmake ccny_rgbd_tools`\r\n\r\n```\r\nBuilding CXX object CMakeFiles/feature_viewer_node.dir/src/node/feature_viewer_node.cpp.o\r\nBuilding CXX object CMakeFiles/feature_viewer_node.dir/src/apps/feature_viewer.cpp.o\r\nBuilding CXX object CMakeFiles/feature_viewer_node.dir/src/util.cpp.o\r\nmake[3]: Entering directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\n[ 82%] [ 85%] Building CXX object CMakeFiles/visual_odometry_node.dir/src/node/visual_odometry_node.cpp.o\r\nmake[3]: Entering directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nBuilding CXX object CMakeFiles/visual_odometry_node.dir/src/apps/visual_odometry.cpp.o\r\n[ 87%] Building CXX object CMakeFiles/keyframe_mapper_node.dir/src/node/keyframe_mapper_node.cpp.o\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/feature_viewer.h:36:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/node/feature_viewer_node.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/rgbd_image_proc.h:35:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/rgbd_image_proc.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/visual_odometry.h:36:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/visual_odometry.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/visual_odometry.h:36:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/node/visual_odometry_node.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/keyframe_mapper.h:43:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/node/keyframe_mapper_node.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/feature_viewer.h:36:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/feature_viewer.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nmake[3]: *** [CMakeFiles/rgbd_image_proc_app.dir/src/apps/rgbd_image_proc.cpp.o] Error 1\r\nmake[3]: *** Waiting for unfinished jobs....\r\nmake[3]: *** [CMakeFiles/feature_viewer_node.dir/src/util.cpp.o] Error 1\r\nmake[3]: *** Waiting for unfinished jobs....\r\n[ 92%] [ 92%] Building CXX object CMakeFiles/keyframe_mapper_node.dir/src/apps/keyframe_mapper.cpp.o\r\nBuilding CXX object CMakeFiles/visual_odometry_node.dir/src/util.cpp.o\r\nmake[3]: *** [CMakeFiles/feature_viewer_node.dir/src/node/feature_viewer_node.cpp.o] Error 1\r\n[ 95%] Building CXX object CMakeFiles/keyframe_mapper_node.dir/src/util.cpp.o\r\nmake[3]: *** [CMakeFiles/rgbd_image_proc_app.dir/src/util.cpp.o] Error 1\r\nmake[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nmake[2]: *** [CMakeFiles/rgbd_image_proc_app.dir/all] Error 2\r\nmake[2]: *** Waiting for unfinished jobs....\r\nmake[3]: *** [CMakeFiles/keyframe_mapper_node.dir/src/node/keyframe_mapper_node.cpp.o] Error 1\r\nmake[3]: *** Waiting for unfinished jobs....\r\nmake[3]: *** [CMakeFiles/visual_odometry_node.dir/src/apps/visual_odometry.cpp.o] Error 1\r\nmake[3]: *** Waiting for unfinished jobs....\r\nmake[3]: *** [CMakeFiles/visual_odometry_node.dir/src/node/visual_odometry_node.cpp.o] Error 1\r\nmake[3]: *** [CMakeFiles/feature_viewer_node.dir/src/apps/feature_viewer.cpp.o] Error 1\r\nmake[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nmake[2]: *** [CMakeFiles/feature_viewer_node.dir/all] Error 2\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/util.h:37:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/util.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nIn file included from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/apps/keyframe_mapper.h:43:0,\r\n                 from /home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/src/apps/keyframe_mapper.cpp:24:\r\n/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/include/ccny_rgbd/types.h:45:42: fatal error: ccny_rgbd/SurfDetectorConfig.h: No such file or directory\r\ncompilation terminated.\r\nmake[3]: *** [CMakeFiles/keyframe_mapper_node.dir/src/util.cpp.o] Error 1\r\nmake[3]: *** [CMakeFiles/visual_odometry_node.dir/src/util.cpp.o] Error 1\r\nmake[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nmake[2]: *** [CMakeFiles/visual_odometry_node.dir/all] Error 2\r\nmake[3]: *** [CMakeFiles/keyframe_mapper_node.dir/src/apps/keyframe_mapper.cpp.o] Error 1\r\nmake[3]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nmake[2]: *** [CMakeFiles/keyframe_mapper_node.dir/all] Error 2\r\nmake[2]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nmake[1]: *** [all] Error 2\r\nmake[1]: Leaving directory `/home/dhruva/Documents/Walgreens/ros_workspace/ccny_rgbd_tools/ccny_rgbd/build'\r\nmake: *** [all] Error 2\r\n```\r\n\r\nWhat was the point of removing the SURF detector? Is it unnecessary?  \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ccny-ros-pkg/ccny_rgbd_tools/issues/comments/114421641","html_url":"https://github.com/ccny-ros-pkg/ccny_rgbd_tools/issues/39#issuecomment-114421641","issue_url":"https://api.github.com/repos/ccny-ros-pkg/ccny_rgbd_tools/issues/39","id":114421641,"user":{"login":"dlime","id":3065709,"avatar_url":"https://avatars.githubusercontent.com/u/3065709?v=3","gravatar_id":"","url":"https://api.github.com/users/dlime","html_url":"https://github.com/dlime","followers_url":"https://api.github.com/users/dlime/followers","following_url":"https://api.github.com/users/dlime/following{/other_user}","gists_url":"https://api.github.com/users/dlime/gists{/gist_id}","starred_url":"https://api.github.com/users/dlime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlime/subscriptions","organizations_url":"https://api.github.com/users/dlime/orgs","repos_url":"https://api.github.com/users/dlime/repos","events_url":"https://api.github.com/users/dlime/events{/privacy}","received_events_url":"https://api.github.com/users/dlime/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T09:39:12Z","updated_at":"2015-06-23T09:39:12Z","body":"Same problem for me"}}