{"action":"created","issue":{"url":"https://api.github.com/repos/numpy/numpy/issues/6540","labels_url":"https://api.github.com/repos/numpy/numpy/issues/6540/labels{/name}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/6540/comments","events_url":"https://api.github.com/repos/numpy/numpy/issues/6540/events","html_url":"https://github.com/numpy/numpy/pull/6540","id":112590926,"number":6540,"title":"EHN: Using in-mem temporary files rather than in-disk for building zip archive in _savez ","user":{"login":"rherault-insa","id":15195333,"avatar_url":"https://avatars.githubusercontent.com/u/15195333?v=3","gravatar_id":"","url":"https://api.github.com/users/rherault-insa","html_url":"https://github.com/rherault-insa","followers_url":"https://api.github.com/users/rherault-insa/followers","following_url":"https://api.github.com/users/rherault-insa/following{/other_user}","gists_url":"https://api.github.com/users/rherault-insa/gists{/gist_id}","starred_url":"https://api.github.com/users/rherault-insa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rherault-insa/subscriptions","organizations_url":"https://api.github.com/users/rherault-insa/orgs","repos_url":"https://api.github.com/users/rherault-insa/repos","events_url":"https://api.github.com/users/rherault-insa/events{/privacy}","received_events_url":"https://api.github.com/users/rherault-insa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.lib","name":"component: numpy.lib","color":"ff0000"},{"url":"https://api.github.com/repos/numpy/numpy/labels/Enhancement","name":"Enhancement","color":"e102d8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-21T13:42:44Z","updated_at":"2015-10-21T21:21:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/6540","html_url":"https://github.com/numpy/numpy/pull/6540","diff_url":"https://github.com/numpy/numpy/pull/6540.diff","patch_url":"https://github.com/numpy/numpy/pull/6540.patch"},"body":"Temporary files are used in the _savez function to stage data during\r\narchiving. The choice is done through new keyword arg: disk_temp_files\r\nIf set to True, use in-disk temporary files (default_option).\r\nIf set to False, use in-mem temporary files.\r\n\r\nPlease note that the in-mem files are based on BytesIO.\r\nIn python2 BytesIO lacks getbuffer method which returns the content of\r\nthe file without copying it. Thus in python2, getvalue is used which is\r\nless memory efficient. In python3 getbuffer is privileged.\r\n\r\nThis pull request is based on an other pull request #6545."},"comment":{"url":"https://api.github.com/repos/numpy/numpy/issues/comments/150027705","html_url":"https://github.com/numpy/numpy/pull/6540#issuecomment-150027705","issue_url":"https://api.github.com/repos/numpy/numpy/issues/6540","id":150027705,"user":{"login":"rherault-insa","id":15195333,"avatar_url":"https://avatars.githubusercontent.com/u/15195333?v=3","gravatar_id":"","url":"https://api.github.com/users/rherault-insa","html_url":"https://github.com/rherault-insa","followers_url":"https://api.github.com/users/rherault-insa/followers","following_url":"https://api.github.com/users/rherault-insa/following{/other_user}","gists_url":"https://api.github.com/users/rherault-insa/gists{/gist_id}","starred_url":"https://api.github.com/users/rherault-insa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rherault-insa/subscriptions","organizations_url":"https://api.github.com/users/rherault-insa/orgs","repos_url":"https://api.github.com/users/rherault-insa/repos","events_url":"https://api.github.com/users/rherault-insa/events{/privacy}","received_events_url":"https://api.github.com/users/rherault-insa/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T21:21:17Z","updated_at":"2015-10-21T21:21:17Z","body":"I've done the split between #6545 and current pull request.\r\nIt is defaulting to in-disk temp file.\r\nTODO need to make unit tests on the in-mem temp files (as a result of defaulting to in-disk)"}}