{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/9506","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/9506/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9506/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/9506/events","html_url":"https://github.com/edx/edx-platform/pull/9506","id":103581007,"number":9506,"title":"Manage focus on delete component modal","user":{"login":"clytwynec","id":3818105,"avatar_url":"https://avatars.githubusercontent.com/u/3818105?v=3","gravatar_id":"","url":"https://api.github.com/users/clytwynec","html_url":"https://github.com/clytwynec","followers_url":"https://api.github.com/users/clytwynec/followers","following_url":"https://api.github.com/users/clytwynec/following{/other_user}","gists_url":"https://api.github.com/users/clytwynec/gists{/gist_id}","starred_url":"https://api.github.com/users/clytwynec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clytwynec/subscriptions","organizations_url":"https://api.github.com/users/clytwynec/orgs","repos_url":"https://api.github.com/users/clytwynec/repos","events_url":"https://api.github.com/users/clytwynec/events{/privacy}","received_events_url":"https://api.github.com/users/clytwynec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-08-27T19:49:07Z","updated_at":"2015-09-24T21:32:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9506","html_url":"https://github.com/edx/edx-platform/pull/9506","diff_url":"https://github.com/edx/edx-platform/pull/9506.diff","patch_url":"https://github.com/edx/edx-platform/pull/9506.patch"},"body":"## Overview\r\n \r\nThis is for [AC-157](https://openedx.atlassian.net/browse/AC-157)\r\n\r\n### Major changes\r\n\r\nUpdates the modal confirmation dialog to follow [WAI-ARIA best practices for modal dialogs](http://www.w3.org/TR/wai-aria-practices/#modal_dialog).  Previously, the focus wasn't being sent to the dialog in when it opened, so navigating to it with a keyboard required tabbing through the whole page.\r\n\r\n## Browsers\r\n\r\nThis work was checked in the following browsers:\r\n\r\n| Platform | Browser | Version | Passed |\r\n|----------|---------|---------|--------|\r\n| Mac      | Chrome  | 45      |  Yes     |\r\n|          | Safari  | 7       |  Yes   |\r\n|          | Firefox | 24      |   Yes   |\r\n| Windows  | Chrome  |45     |  Yes    |\r\n|          | Firefox | 40      |  Yes    |\r\n|          | IE      | 10      |   Yes    |\r\n\r\nNote that on windows, there is some strange behavior with the modal in Chrome if NVDA is in use, but works when it is not.  From what I can tell, NVDA only claims to be compatible with Firefox and IE.\r\n\r\n## Sandbox\r\nstudio: studio-clytwynec.sandbox.edx.org\r\nlms: clytwynec.sandbox.edx.org\r\n\r\n## Reviewers\r\n\r\nThe following reviewers need to provide thumbs before this work can be merged.\r\n\r\n- [ ] @clrux \r\n- [ ] @andy-armstrong \r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/143056624","html_url":"https://github.com/edx/edx-platform/pull/9506#issuecomment-143056624","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9506","id":143056624,"user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T21:32:54Z","updated_at":"2015-09-24T21:32:54Z","body":":+1: Excellent, thanks!"}}