{"action":"created","issue":{"url":"https://api.github.com/repos/bel2125/civetweb/issues/131","labels_url":"https://api.github.com/repos/bel2125/civetweb/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/bel2125/civetweb/issues/131/comments","events_url":"https://api.github.com/repos/bel2125/civetweb/issues/131/events","html_url":"https://github.com/bel2125/civetweb/issues/131","id":79142204,"number":131,"title":"Various Warnings","user":{"login":"bel2125","id":5619191,"avatar_url":"https://avatars.githubusercontent.com/u/5619191?v=3","gravatar_id":"","url":"https://api.github.com/users/bel2125","html_url":"https://github.com/bel2125","followers_url":"https://api.github.com/users/bel2125/followers","following_url":"https://api.github.com/users/bel2125/following{/other_user}","gists_url":"https://api.github.com/users/bel2125/gists{/gist_id}","starred_url":"https://api.github.com/users/bel2125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bel2125/subscriptions","organizations_url":"https://api.github.com/users/bel2125/orgs","repos_url":"https://api.github.com/users/bel2125/repos","events_url":"https://api.github.com/users/bel2125/events{/privacy}","received_events_url":"https://api.github.com/users/bel2125/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-05-21T20:07:16Z","updated_at":"2015-05-22T10:01:59Z","closed_at":null,"body":"This issue has been created for the remaining warnings after #129\r\n"},"comment":{"url":"https://api.github.com/repos/bel2125/civetweb/issues/comments/104605881","html_url":"https://github.com/bel2125/civetweb/issues/131#issuecomment-104605881","issue_url":"https://api.github.com/repos/bel2125/civetweb/issues/131","id":104605881,"user":{"login":"mattyclarkson","id":1081113,"avatar_url":"https://avatars.githubusercontent.com/u/1081113?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyclarkson","html_url":"https://github.com/mattyclarkson","followers_url":"https://api.github.com/users/mattyclarkson/followers","following_url":"https://api.github.com/users/mattyclarkson/following{/other_user}","gists_url":"https://api.github.com/users/mattyclarkson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyclarkson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyclarkson/subscriptions","organizations_url":"https://api.github.com/users/mattyclarkson/orgs","repos_url":"https://api.github.com/users/mattyclarkson/repos","events_url":"https://api.github.com/users/mattyclarkson/events{/privacy}","received_events_url":"https://api.github.com/users/mattyclarkson/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T10:01:59Z","updated_at":"2015-05-22T10:01:59Z","body":"@bel2125, the third party stuff is built independently on my cmake branch so we won't have to fix up the warnings there. Sorry didn't think about that, was only testing without Lua. Take out any warnings that spew! Good that you have got rid of `Wsign-conversion` for now.\r\n\r\nThanks for merging all the fixes, have clean builds on [gcc](https://travis-ci.org/vcatechnology/civetweb/jobs/63623561) and [clang](https://travis-ci.org/vcatechnology/civetweb/jobs/63623562) now on my [cmake branch](https://travis-ci.org/vcatechnology/civetweb/builds/63623560)!!! Just default build, no extras, but gives me a base to start attacking all the other features one by one.\r\n\r\nI'll try to work through the [MinGW](https://ci.appveyor.com/project/mattyclarkson/civetweb/build/55/job/b358bcxy3cxohvlc) warnings today.\r\n\r\nThen onto [MSVC](https://ci.appveyor.com/project/mattyclarkson/civetweb/build/55/job/jy28aj359ln6up78)! Hoping that should compile pretty cleanly if gcc is compiling cleanly.\r\n\r\nThis has raised the issue that it might be a thing to sanitize the types used in the library. There is lots truncation and sign conversion of values. Doing `int i = (int)count` when `count` is `size_t` is just dangerous. It is likely that there have been no bugs because the value of `count` never gets high enough to even matter. We should either just use `int`s everywhere as we probably don't need the extra range of unsigned values but semantically using the correct types is a good thing for the library so maybe figuring out what values _should_ be unsigned might be a good practice. I'm happy to help with that if you fancy doing it in the future."}}