{"action":"created","issue":{"url":"https://api.github.com/repos/glittergallery/GlitterGallery/issues/245","labels_url":"https://api.github.com/repos/glittergallery/GlitterGallery/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/glittergallery/GlitterGallery/issues/245/comments","events_url":"https://api.github.com/repos/glittergallery/GlitterGallery/issues/245/events","html_url":"https://github.com/glittergallery/GlitterGallery/pull/245","id":60601625,"number":245,"title":"Added mailcatcher, Improvements in ajax calls related to follow. completes #198?","user":{"login":"sonalkr132","id":7680662,"avatar_url":"https://avatars.githubusercontent.com/u/7680662?v=3","gravatar_id":"","url":"https://api.github.com/users/sonalkr132","html_url":"https://github.com/sonalkr132","followers_url":"https://api.github.com/users/sonalkr132/followers","following_url":"https://api.github.com/users/sonalkr132/following{/other_user}","gists_url":"https://api.github.com/users/sonalkr132/gists{/gist_id}","starred_url":"https://api.github.com/users/sonalkr132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonalkr132/subscriptions","organizations_url":"https://api.github.com/users/sonalkr132/orgs","repos_url":"https://api.github.com/users/sonalkr132/repos","events_url":"https://api.github.com/users/sonalkr132/events{/privacy}","received_events_url":"https://api.github.com/users/sonalkr132/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-11T02:39:44Z","updated_at":"2015-03-11T11:45:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/glittergallery/GlitterGallery/pulls/245","html_url":"https://github.com/glittergallery/GlitterGallery/pull/245","diff_url":"https://github.com/glittergallery/GlitterGallery/pull/245.diff","patch_url":"https://github.com/glittergallery/GlitterGallery/pull/245.patch"},"body":"I merged the master and changes I proposed in #231. A lot of improvements were made since then, I thought it would better to work with them. It kinda makes PR really log, but you need to review only last 3 commits. \r\n\r\n* I have added [mailcatcher](http://mailcatcher.me/). I guess we would need to update [user instructions wiki](https://github.com/glittergallery/GlitterGallery/wiki/Usage-Instructions) \r\n\r\n* Follow button on project page was a anchor tag, so it was sending a GET request. I updated routes.rb. I know I am violation RESTful urls but we haven't been very respectful of the concept in rest of project either :stuck_out_tongue_winking_eye: We need to refactor our routes file. \r\n\r\n* Fixed 401 error on clicking of follow by guest user. Now page redirects to root. \r\n\r\n* Fixed issues raised in #198  by @rohitpaulk about UX. In my implantation, user sees new followers list if he clicks on follow or unfollow. Also fixed handling of active class of social tabs.\r\n\r\nDoes this closes #198 or do you have any other improvements in mind?"},"comment":{"url":"https://api.github.com/repos/glittergallery/GlitterGallery/issues/comments/78248327","html_url":"https://github.com/glittergallery/GlitterGallery/pull/245#issuecomment-78248327","issue_url":"https://api.github.com/repos/glittergallery/GlitterGallery/issues/245","id":78248327,"user":{"login":"rohitpaulk","id":3893573,"avatar_url":"https://avatars.githubusercontent.com/u/3893573?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitpaulk","html_url":"https://github.com/rohitpaulk","followers_url":"https://api.github.com/users/rohitpaulk/followers","following_url":"https://api.github.com/users/rohitpaulk/following{/other_user}","gists_url":"https://api.github.com/users/rohitpaulk/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitpaulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitpaulk/subscriptions","organizations_url":"https://api.github.com/users/rohitpaulk/orgs","repos_url":"https://api.github.com/users/rohitpaulk/repos","events_url":"https://api.github.com/users/rohitpaulk/events{/privacy}","received_events_url":"https://api.github.com/users/rohitpaulk/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T11:45:12Z","updated_at":"2015-03-11T11:45:12Z","body":"> I didn't send merge request on master branch because I wanted to work on issue on show-followers and I was unsure if after my changes we will be done with it. Like what if you guys suggested something more enhancements to \"followers feature\".\r\n\r\nI feel that incremental changes are the best to work with. If we need enhancements, let's open them in a separate PR. :)"}}