{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1296","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1296/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1296/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1296/events","html_url":"https://github.com/puppetlabs/puppetdb/pull/1296","id":60707060,"number":1296,"title":"(PDB-1031) Lift fact paths into facts (also PDB-1224, PDB-1225, PDB-1226, PDB-1227)","user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-03-11T18:29:24Z","updated_at":"2015-03-30T19:37:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1296","html_url":"https://github.com/puppetlabs/puppetdb/pull/1296","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1296.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1296.patch"},"body":"This series migrates the database to use the new facts structure:\r\n\r\n(factset_id fact_path_id fact_value_id)\r\n\r\nand changes the code to accommodate that. When reviewing, it may be easier to look at the changes to storage.clj and facts.clj directly, as compared to the diff. Or, if we like, I can probably take some time to break up the PDB-1225 patch into more easily digested pieces.\r\n\r\nRob Browning (3):\r\n  (PDB-1031) Move paths from values to facts\r\n  (PDB-1031) Accommodate move of fact paths to facts\r\n  (PDB-1031) Verify gc behavior in update race test\r\n\r\nRyan Senior (3):\r\n  (PDB-1031) Fix query engine, v3 endpoints for fact_path move\r\n  (PDB-1031) Speed migration with unique facts table\r\n  (PDB-1031) Reproduce the fact paths constraint issue\r\n\r\n documentation/repl.markdown                        |   3 +-\r\n src/com/puppetlabs/puppetdb/cli/services.clj       |   3 +-\r\n src/com/puppetlabs/puppetdb/facts.clj              |  84 ++--\r\n src/com/puppetlabs/puppetdb/query.clj              |   8 +-\r\n src/com/puppetlabs/puppetdb/query/facts.clj        |   2 +-\r\n src/com/puppetlabs/puppetdb/query_eng.clj          |  22 +-\r\n src/com/puppetlabs/puppetdb/scf/migrate.clj        |  99 +++-\r\n .../puppetlabs/puppetdb/scf/migration_legacy.clj   | 278 +++++++++++\r\n src/com/puppetlabs/puppetdb/scf/storage.clj        | 556 ++++++++++-----------\r\n test/com/puppetlabs/puppetdb/test/command.clj      | 155 +++++-\r\n test/com/puppetlabs/puppetdb/test/facts.clj        |  72 ---\r\n test/com/puppetlabs/puppetdb/test/scf/migrate.clj  |  95 +++-\r\n .../puppetdb/test/scf/migration_legacy.clj         |  76 +++\r\n test/com/puppetlabs/puppetdb/test/scf/storage.clj  | 159 +++++-\r\n 14 files changed, 1162 insertions(+), 450 deletions(-)\r\n create mode 100644 src/com/puppetlabs/puppetdb/scf/migration_legacy.clj\r\n create mode 100644 test/com/puppetlabs/puppetdb/test/scf/migration_legacy.clj\r\n"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/87802047","html_url":"https://github.com/puppetlabs/puppetdb/pull/1296#issuecomment-87802047","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1296","id":87802047,"user":{"login":"pljenkinsro","id":6546951,"avatar_url":"https://avatars.githubusercontent.com/u/6546951?v=3","gravatar_id":"","url":"https://api.github.com/users/pljenkinsro","html_url":"https://github.com/pljenkinsro","followers_url":"https://api.github.com/users/pljenkinsro/followers","following_url":"https://api.github.com/users/pljenkinsro/following{/other_user}","gists_url":"https://api.github.com/users/pljenkinsro/gists{/gist_id}","starred_url":"https://api.github.com/users/pljenkinsro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pljenkinsro/subscriptions","organizations_url":"https://api.github.com/users/pljenkinsro/orgs","repos_url":"https://api.github.com/users/pljenkinsro/repos","events_url":"https://api.github.com/users/pljenkinsro/events{/privacy}","received_events_url":"https://api.github.com/users/pljenkinsro/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T19:37:09Z","updated_at":"2015-03-30T19:37:09Z","body":"Test FAILed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/954/"}}