{"push_id":784851323,"size":57,"distinct_size":57,"ref":"refs/heads/brocade","head":"941b96b1964483ba1b2b107669e41cd0480c8cae","before":"4d2fadf33f279969b74805453c79dcc307dce458","commits":[{"sha":"b7e0f6171b1e26bfbbb305f70bca52ed539cbbcf","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Fix some compiler warnings\n\nThis fixes some of the warnings reported when compiling with:\n\nCFLAGS=\"-std=gnu11 -Wextra -pedantic\" CXXFLAGS=\"-std=gnu++11 -Wextra\n-pedantic\" cmake ../vermont\n\nThe goal is fix them all so that it can be compiled with:\n\nCFLAGS=\"-std=gnu11 -Werror -Wall -Wextra -pedantic\"\nCXXFLAGS=\"-std=gnu++11 -Werror -Wall -Wextra -pedantic\"\ncmake ../vermont","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/b7e0f6171b1e26bfbbb305f70bca52ed539cbbcf"},{"sha":"615e81c50f5c5ec8584f82158c002181bdf93859","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Fix up compiler warnings in ipfixlolib\n\nA couple of mismatched types, and unused parameter.\n\nNoticed that ipfix_add_collector() is overloaded and address and port\nare used for file name and size in the datafile case. Yuck, Yuck, Yuck!","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/615e81c50f5c5ec8584f82158c002181bdf93859"},{"sha":"367aa174b46f3d6bbff690c551fd6ccd69dad8a4","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Fix compiler warnings for test_everything.cc\n\nComplained about set but unused variable and wrong scan format.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/367aa174b46f3d6bbff690c551fd6ccd69dad8a4"},{"sha":"73ac3065294196a948e4e0af5ce869bc49b0e4e1","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Code now compiles with SUPPORT_DTLS","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/73ac3065294196a948e4e0af5ce869bc49b0e4e1"},{"sha":"8bf7ff4fd65f60ff5ff28f38a7aa95d97238a2f7","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"differentiate error messages","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/8bf7ff4fd65f60ff5ff28f38a7aa95d97238a2f7"},{"sha":"277d6ef9174bdc7f84539ad043bdaae082082286","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Add strict default compiler flags\n\nA built types now have strict default compiler flags.\nThe default built type is set to 'Release' that build with -O3\nTo build an others type use something like 'cmake\n-DCMAKE_BUILD_TYPE=Debug'. As such the debug option that abuses\nadd_definition() is no longer needed.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/277d6ef9174bdc7f84539ad043bdaae082082286"},{"sha":"3d95bfefb013d7f148a24681e54a2a99435332ff","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Fix assorted type based compiler warnings","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/3d95bfefb013d7f148a24681e54a2a99435332ff"},{"sha":"5d48c482e176efb10f3a3e62bbb793bd185d02fc","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Add useful 'make cppcheck' target.\n\nPulled in the needed cmake modules from rpavlik/cmake-modules and added\ntargets for all libraries.\nShould be useful for developers looking for potential problems.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/5d48c482e176efb10f3a3e62bbb793bd185d02fc"},{"sha":"11a200c8852ab7f611d29e09cbb69ff783277d57","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Rename and simplify ipfix_prepend_header function\n\nIs now called ipfix_update_header to reflect its function.\nDoes not need to be passed the data_length as in all cases\nit just uses the committed length.\n\nIt could be further improved to calculate the length directly from the\nvectors as the first vector should contain the header, so need for the\nspecial case.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/11a200c8852ab7f611d29e09cbb69ff783277d57"},{"sha":"c3a74627411d472faac34f54bb49984ab516eaba","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"config/control plane control for NFV9\n\nThis adds a new protocolVersion configuration element to the\nipfixExporter module to choose NFV9 or IPFIX(default) export.\nThis is passed down to the ipfixlolib library, but is currently ignored.\nWorked need to have ipfixlolib support both V9 and IPFIX (similarly to\nhow libipfix supports both).","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/c3a74627411d472faac34f54bb49984ab516eaba"},{"sha":"358a3184550d7c22a3821306873b1ac2f53737dc","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"NFV9 support in ipfixlolib\n\nNFV9 and IPFIX are very similar, the later really just evolution and\nstandardised version of the former. Only major difference is the header\nfields and Template IDs. (Options also differ but library does not\nsupport them for either protocol yet).\n\nAdded the relative timestamp to the header. (Future task to add option\nto the Vermont exporter module to replace/add relative timestamps that\nmost V9 expect to receive instead of/as well as the absolute times)\n\nCount field was easy as it's just the records (of types) in a message,\nand library sends data an template records in separate messages.\n\nSequence count was harder, as it's the number of messages per collector\nconnection session, and as template manage is complex compared to data\nmessages, as sessions come and and are managed this state spread through\nthe code.\n\nipfix_send_template() is crying out to be refactored and simply the\ntracking of internal state across it. As I become more comfortable with\ncode I'll most likely attempt such a refactor.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/358a3184550d7c22a3821306873b1ac2f53737dc"},{"sha":"39f54ca68079f763e7e34719a750fc0d7752438a","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Simplify ipfix_send_templates() function.\n\nRemove a level of nesting by exiting loop early.\nSimplify ifdef code by making DTLS and UDP standalone cases.\n\nIt should now be easier to read/maintain. Further refactors should\nbecome apparent.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/39f54ca68079f763e7e34719a750fc0d7752438a"},{"sha":"67b0b464a765dddd19126f56cf2ff2d5a4564494","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"call dtls_send_templates()","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/67b0b464a765dddd19126f56cf2ff2d5a4564494"},{"sha":"ed9fe2f65c8e8632caa607a0e3f0b0ed1ae87582","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Functions to write sendbuffer to file and rawdir\n\nipfix_send_templates() and ipfix_send_data() had very similar code for\nwriting to datafile and rawdir. Turned these into functions used from\nboth places.\nipfix_send_templates() is down to more readable and manageable 169 lines\nin length with what are now obvious cases within the switch statement.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/ed9fe2f65c8e8632caa607a0e3f0b0ed1ae87582"},{"sha":"43a09f599f1748d3244cd7bd97d02957a2e54549","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Continue collector loop in ipfix_send_data() early\n\nJust like in ipfix_send_templates continue the loop over the collectors\nearly to reduce the amount of nesting in the function. Means reindenting\nthe code. Should help to spot common pattern in the code that can be\nturned into function, etc.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/43a09f599f1748d3244cd7bd97d02957a2e54549"},{"sha":"96aef36fae209d9e766c3d18266c9c40a6732a4d","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"sendbuffer debug in separate function\n\nTo make ipfix_send_data() easier to read/maintain.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/96aef36fae209d9e766c3d18266c9c40a6732a4d"},{"sha":"1f77b5ea79d243f3b494309a7987fa2ef5add725","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Simplify SCTP connection management with templates\n\nConnection function now just manages the connection, and does not send\ntemplates. Templates are now only sent from the main collector loop in\nthe ipfix_send_template functions, where case statement was reordered\nusing fall throughs so that the same behaviour is maintained.\nThis isolates state between functions better making reasoning/maintain\nthe code easier.","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/1f77b5ea79d243f3b494309a7987fa2ef5add725"},{"sha":"cab63d26f888f4a5686d07ecd68be7942d0cd767","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Reduce scope of variables","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/cab63d26f888f4a5686d07ecd68be7942d0cd767"},{"sha":"1a179072a0d8ea883347190198726dc29c02d877","author":{"email":"895eb7ae11e3b120c2ba26dae929e9e9a235a0d1@brocade.com","name":"Nicholas Brown"},"message":"Correctly NULL exporter pointer during deinit\n\nPreviously setting the direct pointer would have no effect outside the\nfunction. Replaced it with widely used double pointer pattern.\nCloses #38","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/1a179072a0d8ea883347190198726dc29c02d877"},{"sha":"d0a8bec57df3234f5f7111665eb6096e09951f90","author":{"email":"21ec360788927f1f88c5c5916def9968e9762552@brocade.com","name":"Luca Boccassi"},"message":"Add ZMQ IpfixReceiver subclass","distinct":true,"url":"https://api.github.com/repos/nickbroon/vermont/commits/d0a8bec57df3234f5f7111665eb6096e09951f90"}]}