{"action":"created","comment":{"url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/comments/41440042","id":41440042,"diff_hunk":"@@ -8,6 +8,78 @@ test('assign own enumerable propreties from source to target object', t => {\n \tt.end();\n });\n \n+test('do not assign null values', t => {\n+\tt.same(fn({}, {foo: null}), {});","path":"test.js","position":5,"original_position":5,"commit_id":"4cf674dc00750a00b263edfd470dd7f046a9b04a","original_commit_id":"4cf674dc00750a00b263edfd470dd7f046a9b04a","user":{"login":"schnittstabil","id":6059032,"avatar_url":"https://avatars.githubusercontent.com/u/6059032?v=3","gravatar_id":"","url":"https://api.github.com/users/schnittstabil","html_url":"https://github.com/schnittstabil","followers_url":"https://api.github.com/users/schnittstabil/followers","following_url":"https://api.github.com/users/schnittstabil/following{/other_user}","gists_url":"https://api.github.com/users/schnittstabil/gists{/gist_id}","starred_url":"https://api.github.com/users/schnittstabil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnittstabil/subscriptions","organizations_url":"https://api.github.com/users/schnittstabil/orgs","repos_url":"https://api.github.com/users/schnittstabil/repos","events_url":"https://api.github.com/users/schnittstabil/events{/privacy}","received_events_url":"https://api.github.com/users/schnittstabil/received_events","type":"User","site_admin":false},"body":"That is true, but only because `Object.assign` is not recursive :bowtie: ","created_at":"2015-10-07T20:11:08Z","updated_at":"2015-10-07T20:11:08Z","html_url":"https://github.com/purposeindustries/deep-assign/pull/1#discussion_r41440042","pull_request_url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/comments/41440042"},"html":{"href":"https://github.com/purposeindustries/deep-assign/pull/1#discussion_r41440042"},"pull_request":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1","id":46997235,"html_url":"https://github.com/purposeindustries/deep-assign/pull/1","diff_url":"https://github.com/purposeindustries/deep-assign/pull/1.diff","patch_url":"https://github.com/purposeindustries/deep-assign/pull/1.patch","issue_url":"https://api.github.com/repos/purposeindustries/deep-assign/issues/1","number":1,"state":"open","locked":false,"title":"Avoid Symbol, Array, …  transform","user":{"login":"schnittstabil","id":6059032,"avatar_url":"https://avatars.githubusercontent.com/u/6059032?v=3","gravatar_id":"","url":"https://api.github.com/users/schnittstabil","html_url":"https://github.com/schnittstabil","followers_url":"https://api.github.com/users/schnittstabil/followers","following_url":"https://api.github.com/users/schnittstabil/following{/other_user}","gists_url":"https://api.github.com/users/schnittstabil/gists{/gist_id}","starred_url":"https://api.github.com/users/schnittstabil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnittstabil/subscriptions","organizations_url":"https://api.github.com/users/schnittstabil/orgs","repos_url":"https://api.github.com/users/schnittstabil/repos","events_url":"https://api.github.com/users/schnittstabil/events{/privacy}","received_events_url":"https://api.github.com/users/schnittstabil/received_events","type":"User","site_admin":false},"body":"Further improvements, but to be clear:\r\n\r\n```js\r\nfunction foo() { return 'foo'; }\r\nfunction bar() { return 'bar'; }\r\n\r\nObject.assign(foo, bar)()             // => 'foo' \r\ndeepAssign(foo, bar)()                // => 'foo'\r\ndeepAssign({fn: foo}, {fn: bar}).fn() // => 'foo'\r\n```","created_at":"2015-10-07T08:06:22Z","updated_at":"2015-10-07T20:11:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"004a420db61904db079297286127d2be775af89a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1/commits","review_comments_url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1/comments","review_comment_url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purposeindustries/deep-assign/issues/1/comments","statuses_url":"https://api.github.com/repos/purposeindustries/deep-assign/statuses/4cf674dc00750a00b263edfd470dd7f046a9b04a","head":{"label":"schnittstabil:avoid-function-transform","ref":"avoid-function-transform","sha":"4cf674dc00750a00b263edfd470dd7f046a9b04a","user":{"login":"schnittstabil","id":6059032,"avatar_url":"https://avatars.githubusercontent.com/u/6059032?v=3","gravatar_id":"","url":"https://api.github.com/users/schnittstabil","html_url":"https://github.com/schnittstabil","followers_url":"https://api.github.com/users/schnittstabil/followers","following_url":"https://api.github.com/users/schnittstabil/following{/other_user}","gists_url":"https://api.github.com/users/schnittstabil/gists{/gist_id}","starred_url":"https://api.github.com/users/schnittstabil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnittstabil/subscriptions","organizations_url":"https://api.github.com/users/schnittstabil/orgs","repos_url":"https://api.github.com/users/schnittstabil/repos","events_url":"https://api.github.com/users/schnittstabil/events{/privacy}","received_events_url":"https://api.github.com/users/schnittstabil/received_events","type":"User","site_admin":false},"repo":{"id":43800575,"name":"deep-assign","full_name":"schnittstabil/deep-assign","owner":{"login":"schnittstabil","id":6059032,"avatar_url":"https://avatars.githubusercontent.com/u/6059032?v=3","gravatar_id":"","url":"https://api.github.com/users/schnittstabil","html_url":"https://github.com/schnittstabil","followers_url":"https://api.github.com/users/schnittstabil/followers","following_url":"https://api.github.com/users/schnittstabil/following{/other_user}","gists_url":"https://api.github.com/users/schnittstabil/gists{/gist_id}","starred_url":"https://api.github.com/users/schnittstabil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnittstabil/subscriptions","organizations_url":"https://api.github.com/users/schnittstabil/orgs","repos_url":"https://api.github.com/users/schnittstabil/repos","events_url":"https://api.github.com/users/schnittstabil/events{/privacy}","received_events_url":"https://api.github.com/users/schnittstabil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schnittstabil/deep-assign","description":"Recursive Object.assign()","fork":true,"url":"https://api.github.com/repos/schnittstabil/deep-assign","forks_url":"https://api.github.com/repos/schnittstabil/deep-assign/forks","keys_url":"https://api.github.com/repos/schnittstabil/deep-assign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schnittstabil/deep-assign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schnittstabil/deep-assign/teams","hooks_url":"https://api.github.com/repos/schnittstabil/deep-assign/hooks","issue_events_url":"https://api.github.com/repos/schnittstabil/deep-assign/issues/events{/number}","events_url":"https://api.github.com/repos/schnittstabil/deep-assign/events","assignees_url":"https://api.github.com/repos/schnittstabil/deep-assign/assignees{/user}","branches_url":"https://api.github.com/repos/schnittstabil/deep-assign/branches{/branch}","tags_url":"https://api.github.com/repos/schnittstabil/deep-assign/tags","blobs_url":"https://api.github.com/repos/schnittstabil/deep-assign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schnittstabil/deep-assign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schnittstabil/deep-assign/git/refs{/sha}","trees_url":"https://api.github.com/repos/schnittstabil/deep-assign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schnittstabil/deep-assign/statuses/{sha}","languages_url":"https://api.github.com/repos/schnittstabil/deep-assign/languages","stargazers_url":"https://api.github.com/repos/schnittstabil/deep-assign/stargazers","contributors_url":"https://api.github.com/repos/schnittstabil/deep-assign/contributors","subscribers_url":"https://api.github.com/repos/schnittstabil/deep-assign/subscribers","subscription_url":"https://api.github.com/repos/schnittstabil/deep-assign/subscription","commits_url":"https://api.github.com/repos/schnittstabil/deep-assign/commits{/sha}","git_commits_url":"https://api.github.com/repos/schnittstabil/deep-assign/git/commits{/sha}","comments_url":"https://api.github.com/repos/schnittstabil/deep-assign/comments{/number}","issue_comment_url":"https://api.github.com/repos/schnittstabil/deep-assign/issues/comments{/number}","contents_url":"https://api.github.com/repos/schnittstabil/deep-assign/contents/{+path}","compare_url":"https://api.github.com/repos/schnittstabil/deep-assign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schnittstabil/deep-assign/merges","archive_url":"https://api.github.com/repos/schnittstabil/deep-assign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schnittstabil/deep-assign/downloads","issues_url":"https://api.github.com/repos/schnittstabil/deep-assign/issues{/number}","pulls_url":"https://api.github.com/repos/schnittstabil/deep-assign/pulls{/number}","milestones_url":"https://api.github.com/repos/schnittstabil/deep-assign/milestones{/number}","notifications_url":"https://api.github.com/repos/schnittstabil/deep-assign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schnittstabil/deep-assign/labels{/name}","releases_url":"https://api.github.com/repos/schnittstabil/deep-assign/releases{/id}","created_at":"2015-10-07T07:19:16Z","updated_at":"2015-10-07T07:19:17Z","pushed_at":"2015-10-07T08:52:46Z","git_url":"git://github.com/schnittstabil/deep-assign.git","ssh_url":"git@github.com:schnittstabil/deep-assign.git","clone_url":"https://github.com/schnittstabil/deep-assign.git","svn_url":"https://github.com/schnittstabil/deep-assign","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purposeindustries:avoid-function-transform","ref":"avoid-function-transform","sha":"f96ea5eda3bada2a9137ab2dbf11c2c6f9b20e16","user":{"login":"purposeindustries","id":4601838,"avatar_url":"https://avatars.githubusercontent.com/u/4601838?v=3","gravatar_id":"","url":"https://api.github.com/users/purposeindustries","html_url":"https://github.com/purposeindustries","followers_url":"https://api.github.com/users/purposeindustries/followers","following_url":"https://api.github.com/users/purposeindustries/following{/other_user}","gists_url":"https://api.github.com/users/purposeindustries/gists{/gist_id}","starred_url":"https://api.github.com/users/purposeindustries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purposeindustries/subscriptions","organizations_url":"https://api.github.com/users/purposeindustries/orgs","repos_url":"https://api.github.com/users/purposeindustries/repos","events_url":"https://api.github.com/users/purposeindustries/events{/privacy}","received_events_url":"https://api.github.com/users/purposeindustries/received_events","type":"Organization","site_admin":false},"repo":{"id":43506493,"name":"deep-assign","full_name":"purposeindustries/deep-assign","owner":{"login":"purposeindustries","id":4601838,"avatar_url":"https://avatars.githubusercontent.com/u/4601838?v=3","gravatar_id":"","url":"https://api.github.com/users/purposeindustries","html_url":"https://github.com/purposeindustries","followers_url":"https://api.github.com/users/purposeindustries/followers","following_url":"https://api.github.com/users/purposeindustries/following{/other_user}","gists_url":"https://api.github.com/users/purposeindustries/gists{/gist_id}","starred_url":"https://api.github.com/users/purposeindustries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purposeindustries/subscriptions","organizations_url":"https://api.github.com/users/purposeindustries/orgs","repos_url":"https://api.github.com/users/purposeindustries/repos","events_url":"https://api.github.com/users/purposeindustries/events{/privacy}","received_events_url":"https://api.github.com/users/purposeindustries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purposeindustries/deep-assign","description":"Recursive Object.assign()","fork":true,"url":"https://api.github.com/repos/purposeindustries/deep-assign","forks_url":"https://api.github.com/repos/purposeindustries/deep-assign/forks","keys_url":"https://api.github.com/repos/purposeindustries/deep-assign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purposeindustries/deep-assign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purposeindustries/deep-assign/teams","hooks_url":"https://api.github.com/repos/purposeindustries/deep-assign/hooks","issue_events_url":"https://api.github.com/repos/purposeindustries/deep-assign/issues/events{/number}","events_url":"https://api.github.com/repos/purposeindustries/deep-assign/events","assignees_url":"https://api.github.com/repos/purposeindustries/deep-assign/assignees{/user}","branches_url":"https://api.github.com/repos/purposeindustries/deep-assign/branches{/branch}","tags_url":"https://api.github.com/repos/purposeindustries/deep-assign/tags","blobs_url":"https://api.github.com/repos/purposeindustries/deep-assign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purposeindustries/deep-assign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purposeindustries/deep-assign/git/refs{/sha}","trees_url":"https://api.github.com/repos/purposeindustries/deep-assign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purposeindustries/deep-assign/statuses/{sha}","languages_url":"https://api.github.com/repos/purposeindustries/deep-assign/languages","stargazers_url":"https://api.github.com/repos/purposeindustries/deep-assign/stargazers","contributors_url":"https://api.github.com/repos/purposeindustries/deep-assign/contributors","subscribers_url":"https://api.github.com/repos/purposeindustries/deep-assign/subscribers","subscription_url":"https://api.github.com/repos/purposeindustries/deep-assign/subscription","commits_url":"https://api.github.com/repos/purposeindustries/deep-assign/commits{/sha}","git_commits_url":"https://api.github.com/repos/purposeindustries/deep-assign/git/commits{/sha}","comments_url":"https://api.github.com/repos/purposeindustries/deep-assign/comments{/number}","issue_comment_url":"https://api.github.com/repos/purposeindustries/deep-assign/issues/comments{/number}","contents_url":"https://api.github.com/repos/purposeindustries/deep-assign/contents/{+path}","compare_url":"https://api.github.com/repos/purposeindustries/deep-assign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purposeindustries/deep-assign/merges","archive_url":"https://api.github.com/repos/purposeindustries/deep-assign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purposeindustries/deep-assign/downloads","issues_url":"https://api.github.com/repos/purposeindustries/deep-assign/issues{/number}","pulls_url":"https://api.github.com/repos/purposeindustries/deep-assign/pulls{/number}","milestones_url":"https://api.github.com/repos/purposeindustries/deep-assign/milestones{/number}","notifications_url":"https://api.github.com/repos/purposeindustries/deep-assign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purposeindustries/deep-assign/labels{/name}","releases_url":"https://api.github.com/repos/purposeindustries/deep-assign/releases{/id}","created_at":"2015-10-01T16:07:55Z","updated_at":"2015-10-01T16:07:56Z","pushed_at":"2015-10-07T08:52:46Z","git_url":"git://github.com/purposeindustries/deep-assign.git","ssh_url":"git@github.com:purposeindustries/deep-assign.git","clone_url":"https://github.com/purposeindustries/deep-assign.git","svn_url":"https://github.com/purposeindustries/deep-assign","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1"},"html":{"href":"https://github.com/purposeindustries/deep-assign/pull/1"},"issue":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/issues/1"},"comments":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/purposeindustries/deep-assign/statuses/4cf674dc00750a00b263edfd470dd7f046a9b04a"}}}}