{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/ralf/pulls/comments/25443111","id":25443111,"diff_hunk":"@@ -600,13 +639,18 @@ int main(int argc, char**argv)\n   }\n \n   realm_manager->stop();\n+\n   delete realm_manager; realm_manager = NULL;\n   delete diameter_resolver; diameter_resolver = NULL;\n   delete http_resolver; http_resolver = NULL;\n   delete dns_resolver; dns_resolver = NULL;\n-\n   delete load_monitor; load_monitor = NULL;\n \n+  hc->terminate();\n+  pthread_join(health_check_thread, NULL);\n+  delete hc; hc = NULL;\n+  delete exception_handler; exception_handler = NULL;","path":"src/main.cpp","position":175,"original_position":175,"commit_id":"8e736569b2e689f6d96e1edfcde389cd2340e02b","original_commit_id":"8e736569b2e689f6d96e1edfcde389cd2340e02b","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"body":"Should probably reverse these and delete the health-checker after the exception handler. (Sorry, that might be my fault.)","created_at":"2015-02-26T16:53:55Z","updated_at":"2015-02-26T16:53:55Z","html_url":"https://github.com/Metaswitch/ralf/pull/130#discussion_r25443111","pull_request_url":"https://api.github.com/repos/Metaswitch/ralf/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/ralf/pulls/comments/25443111"},"html":{"href":"https://github.com/Metaswitch/ralf/pull/130#discussion_r25443111"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/ralf/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/ralf/pulls/130","id":30094538,"html_url":"https://github.com/Metaswitch/ralf/pull/130","diff_url":"https://github.com/Metaswitch/ralf/pull/130.diff","patch_url":"https://github.com/Metaswitch/ralf/pull/130.patch","issue_url":"https://api.github.com/repos/Metaswitch/ralf/issues/130","number":130,"state":"open","locked":false,"title":"[Reviewer: Rob] Sto1117","user":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars.githubusercontent.com/u/5425325?v=3","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"body":"Rob, can you please review these changes to plumb exception handling into Ralf","created_at":"2015-02-26T16:50:16Z","updated_at":"2015-02-26T16:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fac5299206607c92fff13e6986ba256f9374dfd","assignee":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/ralf/pulls/130/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/ralf/pulls/130/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/ralf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/ralf/issues/130/comments","statuses_url":"https://api.github.com/repos/Metaswitch/ralf/statuses/8e736569b2e689f6d96e1edfcde389cd2340e02b","head":{"label":"Metaswitch:sto1117","ref":"sto1117","sha":"8e736569b2e689f6d96e1edfcde389cd2340e02b","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":16410428,"name":"ralf","full_name":"Metaswitch/ralf","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/ralf","description":"The Clearwater CTF","fork":false,"url":"https://api.github.com/repos/Metaswitch/ralf","forks_url":"https://api.github.com/repos/Metaswitch/ralf/forks","keys_url":"https://api.github.com/repos/Metaswitch/ralf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/ralf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/ralf/teams","hooks_url":"https://api.github.com/repos/Metaswitch/ralf/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/ralf/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/ralf/events","assignees_url":"https://api.github.com/repos/Metaswitch/ralf/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/ralf/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/ralf/tags","blobs_url":"https://api.github.com/repos/Metaswitch/ralf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/ralf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/ralf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/ralf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/ralf/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/ralf/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/ralf/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/ralf/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/ralf/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/ralf/subscription","commits_url":"https://api.github.com/repos/Metaswitch/ralf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/ralf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/ralf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/ralf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/ralf/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/ralf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/ralf/merges","archive_url":"https://api.github.com/repos/Metaswitch/ralf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/ralf/downloads","issues_url":"https://api.github.com/repos/Metaswitch/ralf/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/ralf/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/ralf/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/ralf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/ralf/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/ralf/releases{/id}","created_at":"2014-01-31T14:39:59Z","updated_at":"2015-02-20T11:09:13Z","pushed_at":"2015-02-26T16:50:10Z","git_url":"git://github.com/Metaswitch/ralf.git","ssh_url":"git@github.com:Metaswitch/ralf.git","clone_url":"https://github.com/Metaswitch/ralf.git","svn_url":"https://github.com/Metaswitch/ralf","homepage":null,"size":2202,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":0,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"f38688007a4fcc727822921f69c298f10087f3eb","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":16410428,"name":"ralf","full_name":"Metaswitch/ralf","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/ralf","description":"The Clearwater CTF","fork":false,"url":"https://api.github.com/repos/Metaswitch/ralf","forks_url":"https://api.github.com/repos/Metaswitch/ralf/forks","keys_url":"https://api.github.com/repos/Metaswitch/ralf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/ralf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/ralf/teams","hooks_url":"https://api.github.com/repos/Metaswitch/ralf/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/ralf/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/ralf/events","assignees_url":"https://api.github.com/repos/Metaswitch/ralf/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/ralf/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/ralf/tags","blobs_url":"https://api.github.com/repos/Metaswitch/ralf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/ralf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/ralf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/ralf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/ralf/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/ralf/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/ralf/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/ralf/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/ralf/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/ralf/subscription","commits_url":"https://api.github.com/repos/Metaswitch/ralf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/ralf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/ralf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/ralf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/ralf/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/ralf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/ralf/merges","archive_url":"https://api.github.com/repos/Metaswitch/ralf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/ralf/downloads","issues_url":"https://api.github.com/repos/Metaswitch/ralf/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/ralf/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/ralf/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/ralf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/ralf/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/ralf/releases{/id}","created_at":"2014-01-31T14:39:59Z","updated_at":"2015-02-20T11:09:13Z","pushed_at":"2015-02-26T16:50:10Z","git_url":"git://github.com/Metaswitch/ralf.git","ssh_url":"git@github.com:Metaswitch/ralf.git","clone_url":"https://github.com/Metaswitch/ralf.git","svn_url":"https://github.com/Metaswitch/ralf","homepage":null,"size":2202,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/ralf/pulls/130"},"html":{"href":"https://github.com/Metaswitch/ralf/pull/130"},"issue":{"href":"https://api.github.com/repos/Metaswitch/ralf/issues/130"},"comments":{"href":"https://api.github.com/repos/Metaswitch/ralf/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/ralf/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/ralf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/ralf/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/ralf/statuses/8e736569b2e689f6d96e1edfcde389cd2340e02b"}}}}