{"action":"created","comment":{"url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/comments/46973682","id":46973682,"diff_hunk":"@@ -163,7 +185,13 @@ private void joinGame(Pane gameBox, Specializations spec)\n         System.out.println(\"trying to join game\");\n         try\n         {\n-            Broker broker = new Broker();\n+            if(broker != null)\n+            {\n+                broker.unregisterAll(this);","path":"src/application/communication/GameClient.java","position":111,"original_position":111,"commit_id":"a07b2147a0794a7a8c2556611ab6460b37fbd8f8","original_commit_id":"a07b2147a0794a7a8c2556611ab6460b37fbd8f8","user":{"login":"LuqJensen","id":2790839,"avatar_url":"https://avatars.githubusercontent.com/u/2790839?v=3","gravatar_id":"","url":"https://api.github.com/users/LuqJensen","html_url":"https://github.com/LuqJensen","followers_url":"https://api.github.com/users/LuqJensen/followers","following_url":"https://api.github.com/users/LuqJensen/following{/other_user}","gists_url":"https://api.github.com/users/LuqJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/LuqJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuqJensen/subscriptions","organizations_url":"https://api.github.com/users/LuqJensen/orgs","repos_url":"https://api.github.com/users/LuqJensen/repos","events_url":"https://api.github.com/users/LuqJensen/events{/privacy}","received_events_url":"https://api.github.com/users/LuqJensen/received_events","type":"User","site_admin":false},"body":"i see your point. however i think gameclient should stop observing broker when it deactivates. so maybe that functionality must be called from broker","created_at":"2015-12-08T16:13:18Z","updated_at":"2015-12-08T16:13:18Z","html_url":"https://github.com/LuqJensen/Ball-of-Duty/pull/55#discussion_r46973682","pull_request_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/comments/46973682"},"html":{"href":"https://github.com/LuqJensen/Ball-of-Duty/pull/55#discussion_r46973682"},"pull_request":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55","id":52940521,"html_url":"https://github.com/LuqJensen/Ball-of-Duty/pull/55","diff_url":"https://github.com/LuqJensen/Ball-of-Duty/pull/55.diff","patch_url":"https://github.com/LuqJensen/Ball-of-Duty/pull/55.patch","issue_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues/55","number":55,"state":"open","locked":false,"title":"Renamed some stuff. Added server message. Closes tcp connection.","user":{"login":"Ploug","id":8784205,"avatar_url":"https://avatars.githubusercontent.com/u/8784205?v=3","gravatar_id":"","url":"https://api.github.com/users/Ploug","html_url":"https://github.com/Ploug","followers_url":"https://api.github.com/users/Ploug/followers","following_url":"https://api.github.com/users/Ploug/following{/other_user}","gists_url":"https://api.github.com/users/Ploug/gists{/gist_id}","starred_url":"https://api.github.com/users/Ploug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ploug/subscriptions","organizations_url":"https://api.github.com/users/Ploug/orgs","repos_url":"https://api.github.com/users/Ploug/repos","events_url":"https://api.github.com/users/Ploug/events{/privacy}","received_events_url":"https://api.github.com/users/Ploug/received_events","type":"User","site_admin":false},"body":"Added alert when server is down.","created_at":"2015-12-08T05:38:32Z","updated_at":"2015-12-08T16:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c55f0dde6197be66de214671e9fb1971bd5689b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55/commits","review_comments_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55/comments","review_comment_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues/55/comments","statuses_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/statuses/a07b2147a0794a7a8c2556611ab6460b37fbd8f8","head":{"label":"Ploug:master","ref":"master","sha":"a07b2147a0794a7a8c2556611ab6460b37fbd8f8","user":{"login":"Ploug","id":8784205,"avatar_url":"https://avatars.githubusercontent.com/u/8784205?v=3","gravatar_id":"","url":"https://api.github.com/users/Ploug","html_url":"https://github.com/Ploug","followers_url":"https://api.github.com/users/Ploug/followers","following_url":"https://api.github.com/users/Ploug/following{/other_user}","gists_url":"https://api.github.com/users/Ploug/gists{/gist_id}","starred_url":"https://api.github.com/users/Ploug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ploug/subscriptions","organizations_url":"https://api.github.com/users/Ploug/orgs","repos_url":"https://api.github.com/users/Ploug/repos","events_url":"https://api.github.com/users/Ploug/events{/privacy}","received_events_url":"https://api.github.com/users/Ploug/received_events","type":"User","site_admin":false},"repo":{"id":43125621,"name":"Ball-of-Duty","full_name":"Ploug/Ball-of-Duty","owner":{"login":"Ploug","id":8784205,"avatar_url":"https://avatars.githubusercontent.com/u/8784205?v=3","gravatar_id":"","url":"https://api.github.com/users/Ploug","html_url":"https://github.com/Ploug","followers_url":"https://api.github.com/users/Ploug/followers","following_url":"https://api.github.com/users/Ploug/following{/other_user}","gists_url":"https://api.github.com/users/Ploug/gists{/gist_id}","starred_url":"https://api.github.com/users/Ploug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ploug/subscriptions","organizations_url":"https://api.github.com/users/Ploug/orgs","repos_url":"https://api.github.com/users/Ploug/repos","events_url":"https://api.github.com/users/Ploug/events{/privacy}","received_events_url":"https://api.github.com/users/Ploug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ploug/Ball-of-Duty","description":"","fork":true,"url":"https://api.github.com/repos/Ploug/Ball-of-Duty","forks_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/forks","keys_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/teams","hooks_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/hooks","issue_events_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/issues/events{/number}","events_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/events","assignees_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/assignees{/user}","branches_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/branches{/branch}","tags_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/tags","blobs_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/statuses/{sha}","languages_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/languages","stargazers_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/stargazers","contributors_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/contributors","subscribers_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/subscribers","subscription_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/subscription","commits_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/contents/{+path}","compare_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/merges","archive_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/downloads","issues_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/issues{/number}","pulls_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/pulls{/number}","milestones_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/milestones{/number}","notifications_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/labels{/name}","releases_url":"https://api.github.com/repos/Ploug/Ball-of-Duty/releases{/id}","created_at":"2015-09-25T09:08:36Z","updated_at":"2015-10-15T11:26:31Z","pushed_at":"2015-12-08T05:37:34Z","git_url":"git://github.com/Ploug/Ball-of-Duty.git","ssh_url":"git@github.com:Ploug/Ball-of-Duty.git","clone_url":"https://github.com/Ploug/Ball-of-Duty.git","svn_url":"https://github.com/Ploug/Ball-of-Duty","homepage":null,"size":5836,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LuqJensen:master","ref":"master","sha":"e1d2f25486182354f3f942e9b14a6e50d29bbbe9","user":{"login":"LuqJensen","id":2790839,"avatar_url":"https://avatars.githubusercontent.com/u/2790839?v=3","gravatar_id":"","url":"https://api.github.com/users/LuqJensen","html_url":"https://github.com/LuqJensen","followers_url":"https://api.github.com/users/LuqJensen/followers","following_url":"https://api.github.com/users/LuqJensen/following{/other_user}","gists_url":"https://api.github.com/users/LuqJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/LuqJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuqJensen/subscriptions","organizations_url":"https://api.github.com/users/LuqJensen/orgs","repos_url":"https://api.github.com/users/LuqJensen/repos","events_url":"https://api.github.com/users/LuqJensen/events{/privacy}","received_events_url":"https://api.github.com/users/LuqJensen/received_events","type":"User","site_admin":false},"repo":{"id":43121123,"name":"Ball-of-Duty","full_name":"LuqJensen/Ball-of-Duty","owner":{"login":"LuqJensen","id":2790839,"avatar_url":"https://avatars.githubusercontent.com/u/2790839?v=3","gravatar_id":"","url":"https://api.github.com/users/LuqJensen","html_url":"https://github.com/LuqJensen","followers_url":"https://api.github.com/users/LuqJensen/followers","following_url":"https://api.github.com/users/LuqJensen/following{/other_user}","gists_url":"https://api.github.com/users/LuqJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/LuqJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuqJensen/subscriptions","organizations_url":"https://api.github.com/users/LuqJensen/orgs","repos_url":"https://api.github.com/users/LuqJensen/repos","events_url":"https://api.github.com/users/LuqJensen/events{/privacy}","received_events_url":"https://api.github.com/users/LuqJensen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LuqJensen/Ball-of-Duty","description":"","fork":false,"url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty","forks_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/forks","keys_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/teams","hooks_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/hooks","issue_events_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues/events{/number}","events_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/events","assignees_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/assignees{/user}","branches_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/branches{/branch}","tags_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/tags","blobs_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/statuses/{sha}","languages_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/languages","stargazers_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/stargazers","contributors_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/contributors","subscribers_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/subscribers","subscription_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/subscription","commits_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/contents/{+path}","compare_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/merges","archive_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/downloads","issues_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues{/number}","pulls_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls{/number}","milestones_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/milestones{/number}","notifications_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/labels{/name}","releases_url":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/releases{/id}","created_at":"2015-09-25T08:27:29Z","updated_at":"2015-10-14T21:32:33Z","pushed_at":"2015-12-08T05:38:33Z","git_url":"git://github.com/LuqJensen/Ball-of-Duty.git","ssh_url":"git@github.com:LuqJensen/Ball-of-Duty.git","clone_url":"https://github.com/LuqJensen/Ball-of-Duty.git","svn_url":"https://github.com/LuqJensen/Ball-of-Duty","homepage":null,"size":5849,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55"},"html":{"href":"https://github.com/LuqJensen/Ball-of-Duty/pull/55"},"issue":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues/55"},"comments":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/LuqJensen/Ball-of-Duty/statuses/a07b2147a0794a7a8c2556611ab6460b37fbd8f8"}}}}