{"action":"created","comment":{"url":"https://api.github.com/repos/PyTables/PyTables/pulls/comments/29546791","id":29546791,"diff_hunk":"@@ -410,6 +470,22 @@ def get_hdf5_version(headername):\n         # Don't delete this argument. It maybe useful for distutils\n         # when adding more flags later on\n         # sys.argv.remove(arg)\n+    elif arg.find('--use-pkgconfig') == 0:\n+        if arg == '--use-pkgconfig':\n+            USE_PKGCONFIG = True\n+        else:\n+            USE_PKGCONFIG = arg.split('=')[1]\n+\n+\n+if USE_PKGCONFIG is None:\n+    USE_PKGCONFIG = os.environ.get('USE_PKGCONFIG', 'TRUE')\n+if isinstance(USE_PKGCONFIG, str):","path":"setup.py","position":192,"original_position":192,"commit_id":"d11821922b7b89dd2126d7ed526a4c6b30a193dc","original_commit_id":"d11821922b7b89dd2126d7ed526a4c6b30a193dc","user":{"login":"avalentino","id":614554,"avatar_url":"https://avatars.githubusercontent.com/u/614554?v=3","gravatar_id":"","url":"https://api.github.com/users/avalentino","html_url":"https://github.com/avalentino","followers_url":"https://api.github.com/users/avalentino/followers","following_url":"https://api.github.com/users/avalentino/following{/other_user}","gists_url":"https://api.github.com/users/avalentino/gists{/gist_id}","starred_url":"https://api.github.com/users/avalentino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avalentino/subscriptions","organizations_url":"https://api.github.com/users/avalentino/orgs","repos_url":"https://api.github.com/users/avalentino/repos","events_url":"https://api.github.com/users/avalentino/events{/privacy}","received_events_url":"https://api.github.com/users/avalentino/received_events","type":"User","site_admin":false},"body":"My fear is that pkg-config can interfere with other options specified by the user (--hdf5, etc.).\r\nAt a first look it should not but the code is quite complex and I'm not sure I see all paths.\r\nThis is mainly a conservative choice.\r\nI can make some additional test and enable pkg-config by default always.\r\n","created_at":"2015-05-02T10:57:36Z","updated_at":"2015-05-02T10:57:36Z","html_url":"https://github.com/PyTables/PyTables/pull/444#discussion_r29546791","pull_request_url":"https://api.github.com/repos/PyTables/PyTables/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/PyTables/PyTables/pulls/comments/29546791"},"html":{"href":"https://github.com/PyTables/PyTables/pull/444#discussion_r29546791"},"pull_request":{"href":"https://api.github.com/repos/PyTables/PyTables/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/PyTables/PyTables/pulls/444","id":34583567,"html_url":"https://github.com/PyTables/PyTables/pull/444","diff_url":"https://github.com/PyTables/PyTables/pull/444.diff","patch_url":"https://github.com/PyTables/PyTables/pull/444.patch","issue_url":"https://api.github.com/repos/PyTables/PyTables/issues/444","number":444,"state":"open","locked":false,"title":"pkg-config support","user":{"login":"avalentino","id":614554,"avatar_url":"https://avatars.githubusercontent.com/u/614554?v=3","gravatar_id":"","url":"https://api.github.com/users/avalentino","html_url":"https://github.com/avalentino","followers_url":"https://api.github.com/users/avalentino/followers","following_url":"https://api.github.com/users/avalentino/following{/other_user}","gists_url":"https://api.github.com/users/avalentino/gists{/gist_id}","starred_url":"https://api.github.com/users/avalentino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avalentino/subscriptions","organizations_url":"https://api.github.com/users/avalentino/orgs","repos_url":"https://api.github.com/users/avalentino/repos","events_url":"https://api.github.com/users/avalentino/events{/privacy}","received_events_url":"https://api.github.com/users/avalentino/received_events","type":"User","site_admin":false},"body":"This PR adds to the `setup.py` script the ability to use the pkg-config package to find dependencies.\r\nBy default pkg-config is always used (if available), unless explicitly disabled.\r\n\r\nThis PR should also fix #442.\r\n","created_at":"2015-05-02T09:37:56Z","updated_at":"2015-05-02T10:57:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96f3046644473ae16d5ab1de737f7d6ef2be46a7","assignee":null,"milestone":{"url":"https://api.github.com/repos/PyTables/PyTables/milestones/7","html_url":"https://github.com/PyTables/PyTables/milestones/3.2","labels_url":"https://api.github.com/repos/PyTables/PyTables/milestones/7/labels","id":529664,"number":7,"title":"3.2","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":78,"state":"open","created_at":"2014-01-08T01:17:54Z","updated_at":"2015-05-02T09:37:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/PyTables/PyTables/pulls/444/commits","review_comments_url":"https://api.github.com/repos/PyTables/PyTables/pulls/444/comments","review_comment_url":"https://api.github.com/repos/PyTables/PyTables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PyTables/PyTables/issues/444/comments","statuses_url":"https://api.github.com/repos/PyTables/PyTables/statuses/d11821922b7b89dd2126d7ed526a4c6b30a193dc","head":{"label":"avalentino:pkgconfig","ref":"pkgconfig","sha":"d11821922b7b89dd2126d7ed526a4c6b30a193dc","user":{"login":"avalentino","id":614554,"avatar_url":"https://avatars.githubusercontent.com/u/614554?v=3","gravatar_id":"","url":"https://api.github.com/users/avalentino","html_url":"https://github.com/avalentino","followers_url":"https://api.github.com/users/avalentino/followers","following_url":"https://api.github.com/users/avalentino/following{/other_user}","gists_url":"https://api.github.com/users/avalentino/gists{/gist_id}","starred_url":"https://api.github.com/users/avalentino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avalentino/subscriptions","organizations_url":"https://api.github.com/users/avalentino/orgs","repos_url":"https://api.github.com/users/avalentino/repos","events_url":"https://api.github.com/users/avalentino/events{/privacy}","received_events_url":"https://api.github.com/users/avalentino/received_events","type":"User","site_admin":false},"repo":{"id":1895932,"name":"PyTables","full_name":"avalentino/PyTables","owner":{"login":"avalentino","id":614554,"avatar_url":"https://avatars.githubusercontent.com/u/614554?v=3","gravatar_id":"","url":"https://api.github.com/users/avalentino","html_url":"https://github.com/avalentino","followers_url":"https://api.github.com/users/avalentino/followers","following_url":"https://api.github.com/users/avalentino/following{/other_user}","gists_url":"https://api.github.com/users/avalentino/gists{/gist_id}","starred_url":"https://api.github.com/users/avalentino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avalentino/subscriptions","organizations_url":"https://api.github.com/users/avalentino/orgs","repos_url":"https://api.github.com/users/avalentino/repos","events_url":"https://api.github.com/users/avalentino/events{/privacy}","received_events_url":"https://api.github.com/users/avalentino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avalentino/PyTables","description":"PyTables is a package for managing hierarchical datasets and designed to efficiently and easily cope with extremely large amounts of data.  This a git-svn clone of the Pro version recently released under a BSD-flavored license by Francesc Alted!","fork":true,"url":"https://api.github.com/repos/avalentino/PyTables","forks_url":"https://api.github.com/repos/avalentino/PyTables/forks","keys_url":"https://api.github.com/repos/avalentino/PyTables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avalentino/PyTables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avalentino/PyTables/teams","hooks_url":"https://api.github.com/repos/avalentino/PyTables/hooks","issue_events_url":"https://api.github.com/repos/avalentino/PyTables/issues/events{/number}","events_url":"https://api.github.com/repos/avalentino/PyTables/events","assignees_url":"https://api.github.com/repos/avalentino/PyTables/assignees{/user}","branches_url":"https://api.github.com/repos/avalentino/PyTables/branches{/branch}","tags_url":"https://api.github.com/repos/avalentino/PyTables/tags","blobs_url":"https://api.github.com/repos/avalentino/PyTables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avalentino/PyTables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avalentino/PyTables/git/refs{/sha}","trees_url":"https://api.github.com/repos/avalentino/PyTables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avalentino/PyTables/statuses/{sha}","languages_url":"https://api.github.com/repos/avalentino/PyTables/languages","stargazers_url":"https://api.github.com/repos/avalentino/PyTables/stargazers","contributors_url":"https://api.github.com/repos/avalentino/PyTables/contributors","subscribers_url":"https://api.github.com/repos/avalentino/PyTables/subscribers","subscription_url":"https://api.github.com/repos/avalentino/PyTables/subscription","commits_url":"https://api.github.com/repos/avalentino/PyTables/commits{/sha}","git_commits_url":"https://api.github.com/repos/avalentino/PyTables/git/commits{/sha}","comments_url":"https://api.github.com/repos/avalentino/PyTables/comments{/number}","issue_comment_url":"https://api.github.com/repos/avalentino/PyTables/issues/comments{/number}","contents_url":"https://api.github.com/repos/avalentino/PyTables/contents/{+path}","compare_url":"https://api.github.com/repos/avalentino/PyTables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avalentino/PyTables/merges","archive_url":"https://api.github.com/repos/avalentino/PyTables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avalentino/PyTables/downloads","issues_url":"https://api.github.com/repos/avalentino/PyTables/issues{/number}","pulls_url":"https://api.github.com/repos/avalentino/PyTables/pulls{/number}","milestones_url":"https://api.github.com/repos/avalentino/PyTables/milestones{/number}","notifications_url":"https://api.github.com/repos/avalentino/PyTables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avalentino/PyTables/labels{/name}","releases_url":"https://api.github.com/repos/avalentino/PyTables/releases{/id}","created_at":"2011-06-14T18:23:29Z","updated_at":"2015-04-25T08:29:47Z","pushed_at":"2015-05-02T09:39:26Z","git_url":"git://github.com/avalentino/PyTables.git","ssh_url":"git@github.com:avalentino/PyTables.git","clone_url":"https://github.com/avalentino/PyTables.git","svn_url":"https://github.com/avalentino/PyTables","homepage":"http://www.pytables.org/","size":32207,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"PyTables:release-3.2.0","ref":"release-3.2.0","sha":"af4b4c17735484b1b0d685736f9ba81cc9901d95","user":{"login":"PyTables","id":828302,"avatar_url":"https://avatars.githubusercontent.com/u/828302?v=3","gravatar_id":"","url":"https://api.github.com/users/PyTables","html_url":"https://github.com/PyTables","followers_url":"https://api.github.com/users/PyTables/followers","following_url":"https://api.github.com/users/PyTables/following{/other_user}","gists_url":"https://api.github.com/users/PyTables/gists{/gist_id}","starred_url":"https://api.github.com/users/PyTables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyTables/subscriptions","organizations_url":"https://api.github.com/users/PyTables/orgs","repos_url":"https://api.github.com/users/PyTables/repos","events_url":"https://api.github.com/users/PyTables/events{/privacy}","received_events_url":"https://api.github.com/users/PyTables/received_events","type":"Organization","site_admin":false},"repo":{"id":1844194,"name":"PyTables","full_name":"PyTables/PyTables","owner":{"login":"PyTables","id":828302,"avatar_url":"https://avatars.githubusercontent.com/u/828302?v=3","gravatar_id":"","url":"https://api.github.com/users/PyTables","html_url":"https://github.com/PyTables","followers_url":"https://api.github.com/users/PyTables/followers","following_url":"https://api.github.com/users/PyTables/following{/other_user}","gists_url":"https://api.github.com/users/PyTables/gists{/gist_id}","starred_url":"https://api.github.com/users/PyTables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyTables/subscriptions","organizations_url":"https://api.github.com/users/PyTables/orgs","repos_url":"https://api.github.com/users/PyTables/repos","events_url":"https://api.github.com/users/PyTables/events{/privacy}","received_events_url":"https://api.github.com/users/PyTables/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PyTables/PyTables","description":"PyTables is a package for managing hierarchical datasets and designed to efficiently and easily cope with extremely large amounts of data. ","fork":false,"url":"https://api.github.com/repos/PyTables/PyTables","forks_url":"https://api.github.com/repos/PyTables/PyTables/forks","keys_url":"https://api.github.com/repos/PyTables/PyTables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PyTables/PyTables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PyTables/PyTables/teams","hooks_url":"https://api.github.com/repos/PyTables/PyTables/hooks","issue_events_url":"https://api.github.com/repos/PyTables/PyTables/issues/events{/number}","events_url":"https://api.github.com/repos/PyTables/PyTables/events","assignees_url":"https://api.github.com/repos/PyTables/PyTables/assignees{/user}","branches_url":"https://api.github.com/repos/PyTables/PyTables/branches{/branch}","tags_url":"https://api.github.com/repos/PyTables/PyTables/tags","blobs_url":"https://api.github.com/repos/PyTables/PyTables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PyTables/PyTables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PyTables/PyTables/git/refs{/sha}","trees_url":"https://api.github.com/repos/PyTables/PyTables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PyTables/PyTables/statuses/{sha}","languages_url":"https://api.github.com/repos/PyTables/PyTables/languages","stargazers_url":"https://api.github.com/repos/PyTables/PyTables/stargazers","contributors_url":"https://api.github.com/repos/PyTables/PyTables/contributors","subscribers_url":"https://api.github.com/repos/PyTables/PyTables/subscribers","subscription_url":"https://api.github.com/repos/PyTables/PyTables/subscription","commits_url":"https://api.github.com/repos/PyTables/PyTables/commits{/sha}","git_commits_url":"https://api.github.com/repos/PyTables/PyTables/git/commits{/sha}","comments_url":"https://api.github.com/repos/PyTables/PyTables/comments{/number}","issue_comment_url":"https://api.github.com/repos/PyTables/PyTables/issues/comments{/number}","contents_url":"https://api.github.com/repos/PyTables/PyTables/contents/{+path}","compare_url":"https://api.github.com/repos/PyTables/PyTables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PyTables/PyTables/merges","archive_url":"https://api.github.com/repos/PyTables/PyTables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PyTables/PyTables/downloads","issues_url":"https://api.github.com/repos/PyTables/PyTables/issues{/number}","pulls_url":"https://api.github.com/repos/PyTables/PyTables/pulls{/number}","milestones_url":"https://api.github.com/repos/PyTables/PyTables/milestones{/number}","notifications_url":"https://api.github.com/repos/PyTables/PyTables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PyTables/PyTables/labels{/name}","releases_url":"https://api.github.com/repos/PyTables/PyTables/releases{/id}","created_at":"2011-06-03T19:44:46Z","updated_at":"2015-05-01T07:20:21Z","pushed_at":"2015-05-02T09:39:26Z","git_url":"git://github.com/PyTables/PyTables.git","ssh_url":"git@github.com:PyTables/PyTables.git","clone_url":"https://github.com/PyTables/PyTables.git","svn_url":"https://github.com/PyTables/PyTables","homepage":"http://pytables.github.io/","size":34502,"stargazers_count":363,"watchers_count":363,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":94,"forks":87,"open_issues":94,"watchers":363,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PyTables/PyTables/pulls/444"},"html":{"href":"https://github.com/PyTables/PyTables/pull/444"},"issue":{"href":"https://api.github.com/repos/PyTables/PyTables/issues/444"},"comments":{"href":"https://api.github.com/repos/PyTables/PyTables/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/PyTables/PyTables/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/PyTables/PyTables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PyTables/PyTables/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/PyTables/PyTables/statuses/d11821922b7b89dd2126d7ed526a4c6b30a193dc"}}}}