{"action":"created","comment":{"url":"https://api.github.com/repos/drewhk/akka/pulls/comments/48092917","id":48092917,"diff_hunk":"@@ -495,32 +491,62 @@ private[stream] final class GraphInterpreterShell(\n /**\n  * INTERNAL API\n  */\n-private[stream] class ActorGraphInterpreter(_initial: GraphInterpreterShell) extends Actor {\n+private[stream] class ActorGraphInterpreter(_initial: GraphInterpreterShell) extends Actor with ActorLogging {\n   import ActorGraphInterpreter._\n \n-  var activeInterpreters = Set(_initial)\n+  var activeInterpreters = Set.empty[GraphInterpreterShell]\n+  var newShells: List[GraphInterpreterShell] = Nil\n+  val subFusingMaterializerImpl = new SubFusingActorMaterializerImpl(_initial.mat, registerShell)\n+\n+  def tryInit(shell: GraphInterpreterShell): Boolean =\n+    try {\n+      shell.init(self, subFusingMaterializerImpl)\n+      if (GraphInterpreter.Debug) println(s\"registering new shell in ${_initial}\\n  ${shell.toString.replace(\"\\n\", \"\\n  \")}\")\n+      activeInterpreters += shell\n+      true\n+    } catch {\n+      case NonFatal(e) ⇒\n+        log.error(e, \"initialization of GraphInterpreterShell failed for {}\", shell)\n+        false\n+    }\n \n   def registerShell(shell: GraphInterpreterShell): ActorRef = {\n-    shell.init(self, registerShell)\n-    if (GraphInterpreter.Debug) println(s\"registering new shell in ${_initial}\\n  ${shell.toString.replace(\"\\n\", \"\\n  \")}\")\n-    activeInterpreters += shell\n+    newShells ::= shell\n+    self ! Resume\n     self\n   }\n \n+  /*\n+   * Avoid performing the initialization (which start the first runBatch())\n+   * within registerShell in order to avoid unbounded recursion.\n+   */\n+  @tailrec private def finishShellRegistration(): Unit =\n+    newShells match {\n+      case Nil ⇒ if (activeInterpreters.isEmpty) context.stop(self)\n+      case shell :: tail ⇒\n+        newShells = tail\n+        if (shell.isInitialized) {\n+          // yes, this steals another shell’s Resume, but that’s okay","path":"akka-stream/src/main/scala/akka/stream/impl/fusing/ActorGraphInterpreter.scala","position":97,"original_position":97,"commit_id":"77a01c522394d30d2438046eff84310b0ee34ead","original_commit_id":"77a01c522394d30d2438046eff84310b0ee34ead","user":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=3","gravatar_id":"","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"body":"but why is it ok :)","created_at":"2015-12-19T14:38:02Z","updated_at":"2015-12-19T14:38:02Z","html_url":"https://github.com/drewhk/akka/pull/32#discussion_r48092917","pull_request_url":"https://api.github.com/repos/drewhk/akka/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/drewhk/akka/pulls/comments/48092917"},"html":{"href":"https://github.com/drewhk/akka/pull/32#discussion_r48092917"},"pull_request":{"href":"https://api.github.com/repos/drewhk/akka/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/drewhk/akka/pulls/32","id":54177499,"html_url":"https://github.com/drewhk/akka/pull/32","diff_url":"https://github.com/drewhk/akka/pull/32.diff","patch_url":"https://github.com/drewhk/akka/pull/32.patch","issue_url":"https://api.github.com/repos/drewhk/akka/issues/32","number":32,"state":"open","locked":false,"title":"Wip optimize fusing rk","user":{"login":"rkuhn","id":470469,"avatar_url":"https://avatars.githubusercontent.com/u/470469?v=3","gravatar_id":"","url":"https://api.github.com/users/rkuhn","html_url":"https://github.com/rkuhn","followers_url":"https://api.github.com/users/rkuhn/followers","following_url":"https://api.github.com/users/rkuhn/following{/other_user}","gists_url":"https://api.github.com/users/rkuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/rkuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkuhn/subscriptions","organizations_url":"https://api.github.com/users/rkuhn/orgs","repos_url":"https://api.github.com/users/rkuhn/repos","events_url":"https://api.github.com/users/rkuhn/events{/privacy}","received_events_url":"https://api.github.com/users/rkuhn/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-19T12:08:16Z","updated_at":"2015-12-19T14:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44ed8e2b74fba9445d43a25052dd9b2dbd32cbdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drewhk/akka/pulls/32/commits","review_comments_url":"https://api.github.com/repos/drewhk/akka/pulls/32/comments","review_comment_url":"https://api.github.com/repos/drewhk/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drewhk/akka/issues/32/comments","statuses_url":"https://api.github.com/repos/drewhk/akka/statuses/77a01c522394d30d2438046eff84310b0ee34ead","head":{"label":"akka:wip-optimize-fusing-RK","ref":"wip-optimize-fusing-RK","sha":"77a01c522394d30d2438046eff84310b0ee34ead","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-12-19T14:12:03Z","pushed_at":"2015-12-19T14:20:39Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":179374,"stargazers_count":4853,"watchers_count":4853,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1467,"mirror_url":null,"open_issues_count":801,"forks":1467,"open_issues":801,"watchers":4853,"default_branch":"master"}},"base":{"label":"drewhk:wip-fusable-splitwhen-drewhk","ref":"wip-fusable-splitwhen-drewhk","sha":"5a7358bcad7e1fff6d4b4060ea0d805f2ae3f4c8","user":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=3","gravatar_id":"","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"repo":{"id":4322312,"name":"akka","full_name":"drewhk/akka","owner":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=3","gravatar_id":"","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drewhk/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/drewhk/akka","forks_url":"https://api.github.com/repos/drewhk/akka/forks","keys_url":"https://api.github.com/repos/drewhk/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drewhk/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drewhk/akka/teams","hooks_url":"https://api.github.com/repos/drewhk/akka/hooks","issue_events_url":"https://api.github.com/repos/drewhk/akka/issues/events{/number}","events_url":"https://api.github.com/repos/drewhk/akka/events","assignees_url":"https://api.github.com/repos/drewhk/akka/assignees{/user}","branches_url":"https://api.github.com/repos/drewhk/akka/branches{/branch}","tags_url":"https://api.github.com/repos/drewhk/akka/tags","blobs_url":"https://api.github.com/repos/drewhk/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drewhk/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drewhk/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/drewhk/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drewhk/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/drewhk/akka/languages","stargazers_url":"https://api.github.com/repos/drewhk/akka/stargazers","contributors_url":"https://api.github.com/repos/drewhk/akka/contributors","subscribers_url":"https://api.github.com/repos/drewhk/akka/subscribers","subscription_url":"https://api.github.com/repos/drewhk/akka/subscription","commits_url":"https://api.github.com/repos/drewhk/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/drewhk/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/drewhk/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/drewhk/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/drewhk/akka/contents/{+path}","compare_url":"https://api.github.com/repos/drewhk/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drewhk/akka/merges","archive_url":"https://api.github.com/repos/drewhk/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drewhk/akka/downloads","issues_url":"https://api.github.com/repos/drewhk/akka/issues{/number}","pulls_url":"https://api.github.com/repos/drewhk/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/drewhk/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/drewhk/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drewhk/akka/labels{/name}","releases_url":"https://api.github.com/repos/drewhk/akka/releases{/id}","created_at":"2012-05-14T09:57:34Z","updated_at":"2015-02-17T12:40:08Z","pushed_at":"2015-12-19T12:08:16Z","git_url":"git://github.com/drewhk/akka.git","ssh_url":"git@github.com:drewhk/akka.git","clone_url":"https://github.com/drewhk/akka.git","svn_url":"https://github.com/drewhk/akka","homepage":"http://akka.io","size":169119,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drewhk/akka/pulls/32"},"html":{"href":"https://github.com/drewhk/akka/pull/32"},"issue":{"href":"https://api.github.com/repos/drewhk/akka/issues/32"},"comments":{"href":"https://api.github.com/repos/drewhk/akka/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/drewhk/akka/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/drewhk/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drewhk/akka/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/drewhk/akka/statuses/77a01c522394d30d2438046eff84310b0ee34ead"}}}}