{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/newtab-dev/pulls/comments/40586405","id":40586405,"diff_hunk":"@@ -446,10 +456,10 @@ let RemoteAboutNewTab = {\n           RemoteNewTabUtils.blockedLinks.resetCache();\n           break;\n       }\n-    } else if (aTopic == \"browser:purge-session-history\") {\n-        RemoteNewTabUtils.links.resetCache();\n-        RemoteNewTabUtils.links.populateCache(() => {\n-          this.pageListener.sendAsyncMessage(\"NewTab:UpdateLinks\", {\n+    } else if (aTopic === \"browser:purge-session-history\") {","path":"browser/components/newtab/RemoteAboutNewTab.jsm","position":189,"original_position":189,"commit_id":"f639ecda18c77f3d93ca6b1ad3dbcb4af200124c","original_commit_id":"f639ecda18c77f3d93ca6b1ad3dbcb4af200124c","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://avatars.githubusercontent.com/u/870154?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"body":"Nit: this `else if` is a bit ugly (particularly as it's not followed by a `} else {` ). Can it just be an normal if on its own on a new line? ","created_at":"2015-09-28T18:20:54Z","updated_at":"2015-09-28T18:20:54Z","html_url":"https://github.com/mozilla/newtab-dev/pull/14#discussion_r40586405","pull_request_url":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/mozilla/newtab-dev/pulls/comments/40586405"},"html":{"href":"https://github.com/mozilla/newtab-dev/pull/14#discussion_r40586405"},"pull_request":{"href":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14","id":45608866,"html_url":"https://github.com/mozilla/newtab-dev/pull/14","diff_url":"https://github.com/mozilla/newtab-dev/pull/14.diff","patch_url":"https://github.com/mozilla/newtab-dev/pull/14.patch","issue_url":"https://api.github.com/repos/mozilla/newtab-dev/issues/14","number":14,"state":"open","locked":false,"title":"Send RemoteNewTabLocation values via message","user":{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false},"body":"r? @marcoscaceres or @emtwo ","created_at":"2015-09-21T22:34:00Z","updated_at":"2015-09-28T18:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb5c1693525bd682db87c611ad1a464727fdf8fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mozilla/newtab-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/newtab-dev/issues/14/comments","statuses_url":"https://api.github.com/repos/mozilla/newtab-dev/statuses/f639ecda18c77f3d93ca6b1ad3dbcb4af200124c","head":{"label":"mozilla:bug_1206799_communicate_with_remotenewtablocation_via_messages","ref":"bug_1206799_communicate_with_remotenewtablocation_via_messages","sha":"f639ecda18c77f3d93ca6b1ad3dbcb4af200124c","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":41306135,"name":"newtab-dev","full_name":"mozilla/newtab-dev","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/newtab-dev","description":"Repo following gecko-dev for newtab development","fork":false,"url":"https://api.github.com/repos/mozilla/newtab-dev","forks_url":"https://api.github.com/repos/mozilla/newtab-dev/forks","keys_url":"https://api.github.com/repos/mozilla/newtab-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/newtab-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/newtab-dev/teams","hooks_url":"https://api.github.com/repos/mozilla/newtab-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla/newtab-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/newtab-dev/events","assignees_url":"https://api.github.com/repos/mozilla/newtab-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/newtab-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/newtab-dev/tags","blobs_url":"https://api.github.com/repos/mozilla/newtab-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/newtab-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/newtab-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/newtab-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/newtab-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/newtab-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla/newtab-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla/newtab-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla/newtab-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla/newtab-dev/subscription","commits_url":"https://api.github.com/repos/mozilla/newtab-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/newtab-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/newtab-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/newtab-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/newtab-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/newtab-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/newtab-dev/merges","archive_url":"https://api.github.com/repos/mozilla/newtab-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/newtab-dev/downloads","issues_url":"https://api.github.com/repos/mozilla/newtab-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/newtab-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/newtab-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/newtab-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/newtab-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/newtab-dev/releases{/id}","created_at":"2015-08-24T13:57:42Z","updated_at":"2015-09-10T16:33:40Z","pushed_at":"2015-09-28T15:41:41Z","git_url":"git://github.com/mozilla/newtab-dev.git","ssh_url":"git@github.com:mozilla/newtab-dev.git","clone_url":"https://github.com/mozilla/newtab-dev.git","svn_url":"https://github.com/mozilla/newtab-dev","homepage":"","size":2261296,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4d07b059d99722263df421931c6d79fab2dc4001","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":41306135,"name":"newtab-dev","full_name":"mozilla/newtab-dev","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/newtab-dev","description":"Repo following gecko-dev for newtab development","fork":false,"url":"https://api.github.com/repos/mozilla/newtab-dev","forks_url":"https://api.github.com/repos/mozilla/newtab-dev/forks","keys_url":"https://api.github.com/repos/mozilla/newtab-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/newtab-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/newtab-dev/teams","hooks_url":"https://api.github.com/repos/mozilla/newtab-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla/newtab-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/newtab-dev/events","assignees_url":"https://api.github.com/repos/mozilla/newtab-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/newtab-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/newtab-dev/tags","blobs_url":"https://api.github.com/repos/mozilla/newtab-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/newtab-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/newtab-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/newtab-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/newtab-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/newtab-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla/newtab-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla/newtab-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla/newtab-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla/newtab-dev/subscription","commits_url":"https://api.github.com/repos/mozilla/newtab-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/newtab-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/newtab-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/newtab-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/newtab-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/newtab-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/newtab-dev/merges","archive_url":"https://api.github.com/repos/mozilla/newtab-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/newtab-dev/downloads","issues_url":"https://api.github.com/repos/mozilla/newtab-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/newtab-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/newtab-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/newtab-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/newtab-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/newtab-dev/releases{/id}","created_at":"2015-08-24T13:57:42Z","updated_at":"2015-09-10T16:33:40Z","pushed_at":"2015-09-28T15:41:41Z","git_url":"git://github.com/mozilla/newtab-dev.git","ssh_url":"git@github.com:mozilla/newtab-dev.git","clone_url":"https://github.com/mozilla/newtab-dev.git","svn_url":"https://github.com/mozilla/newtab-dev","homepage":"","size":2261296,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14"},"html":{"href":"https://github.com/mozilla/newtab-dev/pull/14"},"issue":{"href":"https://api.github.com/repos/mozilla/newtab-dev/issues/14"},"comments":{"href":"https://api.github.com/repos/mozilla/newtab-dev/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/newtab-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/newtab-dev/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/newtab-dev/statuses/f639ecda18c77f3d93ca6b1ad3dbcb4af200124c"}}}}