{"action":"created","issue":{"url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101","labels_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101/comments","events_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101/events","html_url":"https://github.com/coop182/jquery.dfp.js/pull/101","id":84044472,"number":101,"title":"use the right $ as UMD Module","user":{"login":"BowlingX","id":215671,"avatar_url":"https://avatars.githubusercontent.com/u/215671?v=3","gravatar_id":"","url":"https://api.github.com/users/BowlingX","html_url":"https://github.com/BowlingX","followers_url":"https://api.github.com/users/BowlingX/followers","following_url":"https://api.github.com/users/BowlingX/following{/other_user}","gists_url":"https://api.github.com/users/BowlingX/gists{/gist_id}","starred_url":"https://api.github.com/users/BowlingX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BowlingX/subscriptions","organizations_url":"https://api.github.com/users/BowlingX/orgs","repos_url":"https://api.github.com/users/BowlingX/repos","events_url":"https://api.github.com/users/BowlingX/events{/privacy}","received_events_url":"https://api.github.com/users/BowlingX/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-02T14:18:10Z","updated_at":"2015-06-03T09:39:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101","html_url":"https://github.com/coop182/jquery.dfp.js/pull/101","diff_url":"https://github.com/coop182/jquery.dfp.js/pull/101.diff","patch_url":"https://github.com/coop182/jquery.dfp.js/pull/101.patch"},"body":"Hey :)\r\nthank you first for this plugin, it makes things a lot easier while dealing with DFP :).\r\nI changed the way the module loads, because the current UMD implementation is not correct.\r\n\r\n```\r\n(function($, window, undefined)(window.jQuery....)\r\n````\r\n\r\nThe $ shadows the underlying implementation and so a global $ is always used by the plugin (which is not available when loaded with a module loader). I changed it in a way that if a module loader is in scope all dependencies will be resolved first and then delegated to your implementation.\r\n\r\nBest\r\nDavid"},"comment":{"url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/comments/108269764","html_url":"https://github.com/coop182/jquery.dfp.js/pull/101#issuecomment-108269764","issue_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101","id":108269764,"user":{"login":"BowlingX","id":215671,"avatar_url":"https://avatars.githubusercontent.com/u/215671?v=3","gravatar_id":"","url":"https://api.github.com/users/BowlingX","html_url":"https://github.com/BowlingX","followers_url":"https://api.github.com/users/BowlingX/followers","following_url":"https://api.github.com/users/BowlingX/following{/other_user}","gists_url":"https://api.github.com/users/BowlingX/gists{/gist_id}","starred_url":"https://api.github.com/users/BowlingX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BowlingX/subscriptions","organizations_url":"https://api.github.com/users/BowlingX/orgs","repos_url":"https://api.github.com/users/BowlingX/repos","events_url":"https://api.github.com/users/BowlingX/events{/privacy}","received_events_url":"https://api.github.com/users/BowlingX/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T09:39:21Z","updated_at":"2015-06-03T09:39:21Z","body":"Sorry for the diff :/, I had to move everything and restore the intention. Thanks for looking."}}