{"action":"created","issue":{"url":"https://api.github.com/repos/m8pple/arch2-2015-cw1/issues/13","labels_url":"https://api.github.com/repos/m8pple/arch2-2015-cw1/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/m8pple/arch2-2015-cw1/issues/13/comments","events_url":"https://api.github.com/repos/m8pple/arch2-2015-cw1/issues/13/events","html_url":"https://github.com/m8pple/arch2-2015-cw1/issues/13","id":112899576,"number":13,"title":"Naming subfolders","user":{"login":"nikonikolov","id":11044035,"avatar_url":"https://avatars.githubusercontent.com/u/11044035?v=3","gravatar_id":"","url":"https://api.github.com/users/nikonikolov","html_url":"https://github.com/nikonikolov","followers_url":"https://api.github.com/users/nikonikolov/followers","following_url":"https://api.github.com/users/nikonikolov/following{/other_user}","gists_url":"https://api.github.com/users/nikonikolov/gists{/gist_id}","starred_url":"https://api.github.com/users/nikonikolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikonikolov/subscriptions","organizations_url":"https://api.github.com/users/nikonikolov/orgs","repos_url":"https://api.github.com/users/nikonikolov/repos","events_url":"https://api.github.com/users/nikonikolov/events{/privacy}","received_events_url":"https://api.github.com/users/nikonikolov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-22T21:54:12Z","updated_at":"2015-10-23T19:20:24Z","closed_at":null,"body":"Do we need to follow the name requirements for names of subfolders as well? In the current version of the makefile all subfolders will get compiled. However, that can cause some issues if tests are swapped around between different submissions. E.g. right now my test suite needs SOME of the subfolders to run, but not ALL of them. There is no clear way to distinguish the subfolders you need only from their names, though, without reading the code and tracking all headers back. Possible solution might be to name all test related files/subfolders test_mips_* and all cpu-related ones mips_cpu_*."},"comment":{"url":"https://api.github.com/repos/m8pple/arch2-2015-cw1/issues/comments/150668224","html_url":"https://github.com/m8pple/arch2-2015-cw1/issues/13#issuecomment-150668224","issue_url":"https://api.github.com/repos/m8pple/arch2-2015-cw1/issues/13","id":150668224,"user":{"login":"m8pple","id":3024705,"avatar_url":"https://avatars.githubusercontent.com/u/3024705?v=3","gravatar_id":"","url":"https://api.github.com/users/m8pple","html_url":"https://github.com/m8pple","followers_url":"https://api.github.com/users/m8pple/followers","following_url":"https://api.github.com/users/m8pple/following{/other_user}","gists_url":"https://api.github.com/users/m8pple/gists{/gist_id}","starred_url":"https://api.github.com/users/m8pple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8pple/subscriptions","organizations_url":"https://api.github.com/users/m8pple/orgs","repos_url":"https://api.github.com/users/m8pple/repos","events_url":"https://api.github.com/users/m8pple/events{/privacy}","received_events_url":"https://api.github.com/users/m8pple/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T19:20:24Z","updated_at":"2015-10-23T19:20:24Z","body":"That's an excellent point - I just looked at my assessment build rules, and I have a different\r\npattern that does bring things in according to the spec, but yes, that is broken.\r\n\r\nI'm reluctant to commit to master right now (as I can't test where I am). If you look\r\non the staging branch, does this https://github.com/m8pple/arch2-2015-cw1/commit/ab3e5732ab8d20ccb57cad5738cb5899e2e2d6c8 look ok?"}}