{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/23351811","id":23351811,"diff_hunk":"@@ -123,4 +123,22 @@ class Book < ActiveFedora::Base\n       it { should eq '123456w' }\n     end\n   end\n+\n+  describe \"when serializing an object\" do \n+    let(:book) { Book.create(title:\"foo\") }\n+    it \"should handle an empty base path\" do\n+      allow(ActiveFedora.fedora).to receive(:base_path).and_return(\"/\")\n+      expect(ActiveFedora::Base.find(book.id).class.name).to eq(\"Book\")","path":"spec/unit/core_spec.rb","position":9,"original_position":9,"commit_id":"ce952bfa59b9b7085207e9db5c88eb4e86982503","original_commit_id":"ce952bfa59b9b7085207e9db5c88eb4e86982503","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"How about testing `id_to_uri` directly rather than doing create/lookup to test that change? ","created_at":"2015-01-22T02:25:52Z","updated_at":"2015-01-22T02:25:52Z","html_url":"https://github.com/projecthydra/active_fedora/pull/696#discussion_r23351811","pull_request_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/23351811"},"html":{"href":"https://github.com/projecthydra/active_fedora/pull/696#discussion_r23351811"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696","id":27811594,"html_url":"https://github.com/projecthydra/active_fedora/pull/696","diff_url":"https://github.com/projecthydra/active_fedora/pull/696.diff","patch_url":"https://github.com/projecthydra/active_fedora/pull/696.patch","issue_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/696","number":696,"state":"open","locked":false,"title":"Fixes bug that prevented ActiveFedora from deserializing classes ","user":{"login":"hectorcorrea","id":568286,"avatar_url":"https://avatars.githubusercontent.com/u/568286?v=3","gravatar_id":"","url":"https://api.github.com/users/hectorcorrea","html_url":"https://github.com/hectorcorrea","followers_url":"https://api.github.com/users/hectorcorrea/followers","following_url":"https://api.github.com/users/hectorcorrea/following{/other_user}","gists_url":"https://api.github.com/users/hectorcorrea/gists{/gist_id}","starred_url":"https://api.github.com/users/hectorcorrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hectorcorrea/subscriptions","organizations_url":"https://api.github.com/users/hectorcorrea/orgs","repos_url":"https://api.github.com/users/hectorcorrea/repos","events_url":"https://api.github.com/users/hectorcorrea/events{/privacy}","received_events_url":"https://api.github.com/users/hectorcorrea/received_events","type":"User","site_admin":false},"body":"correctly when the base_path setting in fedora.yaml was not set.\r\n\r\nTakes care of https://github.com/projecthydra/active_fedora/issues/657\r\n\r\nNote: When I removed the base_path from config/fedora.yml and ran all tests I got 20+ failing tests. I spot checked several of them and the issues where because the tests were hard-coded to expect a /test/ on the URL or because the cleaner didn't know how to clean from fedora/rest rather than fedora/rest/test. I didn't think this should be an issue with the code given the new tests that evaluate the new changes. ","created_at":"2015-01-22T01:36:07Z","updated_at":"2015-01-22T02:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e178b7af6fcf24796bbd63d374589b8f3e2fcafd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696/commits","review_comments_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696/comments","review_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/{number}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/696/comments","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/ce952bfa59b9b7085207e9db5c88eb4e86982503","head":{"label":"projecthydra:empty_base_path","ref":"empty_base_path","sha":"ce952bfa59b9b7085207e9db5c88eb4e86982503","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":3867127,"name":"active_fedora","full_name":"projecthydra/active_fedora","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/active_fedora","description":"A Rails interface to the Fedora repository, akin to Active Model","fork":false,"url":"https://api.github.com/repos/projecthydra/active_fedora","forks_url":"https://api.github.com/repos/projecthydra/active_fedora/forks","keys_url":"https://api.github.com/repos/projecthydra/active_fedora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/active_fedora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/active_fedora/teams","hooks_url":"https://api.github.com/repos/projecthydra/active_fedora/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/active_fedora/events","assignees_url":"https://api.github.com/repos/projecthydra/active_fedora/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/active_fedora/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/active_fedora/tags","blobs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/active_fedora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/active_fedora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/active_fedora/languages","stargazers_url":"https://api.github.com/repos/projecthydra/active_fedora/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/active_fedora/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/active_fedora/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/active_fedora/subscription","commits_url":"https://api.github.com/repos/projecthydra/active_fedora/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/active_fedora/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/active_fedora/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/active_fedora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/active_fedora/merges","archive_url":"https://api.github.com/repos/projecthydra/active_fedora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/active_fedora/downloads","issues_url":"https://api.github.com/repos/projecthydra/active_fedora/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/active_fedora/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/active_fedora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/active_fedora/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/active_fedora/releases{/id}","created_at":"2012-03-29T15:01:13Z","updated_at":"2015-01-21T16:19:11Z","pushed_at":"2015-01-22T02:20:19Z","git_url":"git://github.com/projecthydra/active_fedora.git","ssh_url":"git@github.com:projecthydra/active_fedora.git","clone_url":"https://github.com/projecthydra/active_fedora.git","svn_url":"https://github.com/projecthydra/active_fedora","homepage":"","size":13489,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":41,"forks":43,"open_issues":41,"watchers":27,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"b19ee2de0798988086877625b214bf4a177f10f7","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":3867127,"name":"active_fedora","full_name":"projecthydra/active_fedora","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/active_fedora","description":"A Rails interface to the Fedora repository, akin to Active Model","fork":false,"url":"https://api.github.com/repos/projecthydra/active_fedora","forks_url":"https://api.github.com/repos/projecthydra/active_fedora/forks","keys_url":"https://api.github.com/repos/projecthydra/active_fedora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/active_fedora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/active_fedora/teams","hooks_url":"https://api.github.com/repos/projecthydra/active_fedora/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/active_fedora/events","assignees_url":"https://api.github.com/repos/projecthydra/active_fedora/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/active_fedora/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/active_fedora/tags","blobs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/active_fedora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/active_fedora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/active_fedora/languages","stargazers_url":"https://api.github.com/repos/projecthydra/active_fedora/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/active_fedora/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/active_fedora/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/active_fedora/subscription","commits_url":"https://api.github.com/repos/projecthydra/active_fedora/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/active_fedora/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/active_fedora/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/active_fedora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/active_fedora/merges","archive_url":"https://api.github.com/repos/projecthydra/active_fedora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/active_fedora/downloads","issues_url":"https://api.github.com/repos/projecthydra/active_fedora/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/active_fedora/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/active_fedora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/active_fedora/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/active_fedora/releases{/id}","created_at":"2012-03-29T15:01:13Z","updated_at":"2015-01-21T16:19:11Z","pushed_at":"2015-01-22T02:20:19Z","git_url":"git://github.com/projecthydra/active_fedora.git","ssh_url":"git@github.com:projecthydra/active_fedora.git","clone_url":"https://github.com/projecthydra/active_fedora.git","svn_url":"https://github.com/projecthydra/active_fedora","homepage":"","size":13489,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":41,"forks":43,"open_issues":41,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696"},"html":{"href":"https://github.com/projecthydra/active_fedora/pull/696"},"issue":{"href":"https://api.github.com/repos/projecthydra/active_fedora/issues/696"},"comments":{"href":"https://api.github.com/repos/projecthydra/active_fedora/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/active_fedora/statuses/ce952bfa59b9b7085207e9db5c88eb4e86982503"}}}}