{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/25265063","id":25265063,"diff_hunk":"@@ -601,10 +601,15 @@ double str_to_double(tokenizer_t *self, char *str)\n     {\n         val = strtod(str, &tmp);\n \n-        if (tmp == str || *tmp != 0)\n+        if (tmp == str || *tmp != 0) {\n+\t\t    if (0 == strncmp(str, \"nan\", 3)) {\n+\t\t\t\treturn NAN;\n+\t\t    }","path":"astropy/io/ascii/src/tokenizer.c","position":8,"original_position":8,"commit_id":"b50cbba8ca0a30df5821e671c4475ec8fa985f98","original_commit_id":"b50cbba8ca0a30df5821e671c4475ec8fa985f98","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"body":"@mdboom https://github.com/astropy/astropy/pull/3525/files#r25041109","created_at":"2015-02-24T16:16:40Z","updated_at":"2015-02-24T16:16:40Z","html_url":"https://github.com/astropy/astropy/pull/3525#discussion_r25265063","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/3525","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/25265063"},"html":{"href":"https://github.com/astropy/astropy/pull/3525#discussion_r25265063"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3525"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/3525","id":29654973,"html_url":"https://github.com/astropy/astropy/pull/3525","diff_url":"https://github.com/astropy/astropy/pull/3525.diff","patch_url":"https://github.com/astropy/astropy/pull/3525.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/3525","number":3525,"state":"open","locked":false,"title":"Fix io.ascii test failures on Windows","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"body":"Fixes many tests for `io.ascii` that were failing for me on Windows.  Some of these were being skipped on appveyor due to not passing.  But I think there were some others that don't explicitly say they are skipped on appveyor, and yet it is a mystery to me how they could have been passing at all...\r\n\r\nOnce this passes the first round of testing I'll take off some of the \"skip if appveyor\" decorators and see how things go.","created_at":"2015-02-19T22:22:38Z","updated_at":"2015-02-24T16:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c7d2ada388b7b051105e109b3462b64ae135860","assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/22","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/22/labels","id":966328,"number":22,"title":"v1.0.1","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2015-02-04T23:15:29Z","updated_at":"2015-02-24T15:21:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/3525/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/3525/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/3525/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/b50cbba8ca0a30df5821e671c4475ec8fa985f98","head":{"label":"embray:ascii/windows-fixes","ref":"ascii/windows-fixes","sha":"b50cbba8ca0a30df5821e671c4475ec8fa985f98","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"repo":{"id":2223452,"name":"astropy","full_name":"embray/astropy","owner":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/embray/astropy","description":"My fork of the main Astropy repository (astropy/astropy)","fork":true,"url":"https://api.github.com/repos/embray/astropy","forks_url":"https://api.github.com/repos/embray/astropy/forks","keys_url":"https://api.github.com/repos/embray/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embray/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embray/astropy/teams","hooks_url":"https://api.github.com/repos/embray/astropy/hooks","issue_events_url":"https://api.github.com/repos/embray/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/embray/astropy/events","assignees_url":"https://api.github.com/repos/embray/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/embray/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/embray/astropy/tags","blobs_url":"https://api.github.com/repos/embray/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embray/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embray/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/embray/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embray/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/embray/astropy/languages","stargazers_url":"https://api.github.com/repos/embray/astropy/stargazers","contributors_url":"https://api.github.com/repos/embray/astropy/contributors","subscribers_url":"https://api.github.com/repos/embray/astropy/subscribers","subscription_url":"https://api.github.com/repos/embray/astropy/subscription","commits_url":"https://api.github.com/repos/embray/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/embray/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/embray/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/embray/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/embray/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/embray/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embray/astropy/merges","archive_url":"https://api.github.com/repos/embray/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embray/astropy/downloads","issues_url":"https://api.github.com/repos/embray/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/embray/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/embray/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/embray/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embray/astropy/labels{/name}","releases_url":"https://api.github.com/repos/embray/astropy/releases{/id}","created_at":"2011-08-17T18:24:15Z","updated_at":"2015-02-19T23:48:34Z","pushed_at":"2015-02-19T23:48:31Z","git_url":"git://github.com/embray/astropy.git","ssh_url":"git@github.com:embray/astropy.git","clone_url":"https://github.com/embray/astropy.git","svn_url":"https://github.com/embray/astropy","homepage":"astropy.org","size":47495,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"484b2d2706efa136f75ac7f410b31e2c1d6fa431","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2015-02-24T15:21:17Z","pushed_at":"2015-02-24T15:21:16Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":59564,"stargazers_count":516,"watchers_count":516,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":438,"forks":347,"open_issues":438,"watchers":516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3525"},"html":{"href":"https://github.com/astropy/astropy/pull/3525"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/3525"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/3525/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3525/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3525/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/b50cbba8ca0a30df5821e671c4475ec8fa985f98"}}}}