{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/mburns/application_nodejs/pulls/9","id":15153971,"html_url":"https://github.com/mburns/application_nodejs/pull/9","diff_url":"https://github.com/mburns/application_nodejs/pull/9.diff","patch_url":"https://github.com/mburns/application_nodejs/pull/9.patch","issue_url":"https://api.github.com/repos/mburns/application_nodejs/issues/9","number":9,"state":"closed","locked":false,"title":"Updates and minor improvements","user":{"login":"rizzatti","id":793577,"avatar_url":"https://avatars.githubusercontent.com/u/793577?v=3","gravatar_id":"","url":"https://api.github.com/users/rizzatti","html_url":"https://github.com/rizzatti","followers_url":"https://api.github.com/users/rizzatti/followers","following_url":"https://api.github.com/users/rizzatti/following{/other_user}","gists_url":"https://api.github.com/users/rizzatti/gists{/gist_id}","starred_url":"https://api.github.com/users/rizzatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizzatti/subscriptions","organizations_url":"https://api.github.com/users/rizzatti/orgs","repos_url":"https://api.github.com/users/rizzatti/repos","events_url":"https://api.github.com/users/rizzatti/events{/privacy}","received_events_url":"https://api.github.com/users/rizzatti/received_events","type":"User","site_admin":false},"body":"First of all, thanks for making this available.\r\nI was having some trouble using this cookbook with the release of Ubuntu 14.04, so I made some changes.\r\n\r\nThis works fine with both edge/master versions of application and nodejs cookbooks.\r\n\r\nI'm not quite sure how support for node is on other distros, but the latest Ubuntu releases have kept pretty up2date, and now the nodejs cookbook has changed their policy to use the packages from the ppa.\r\n\r\nThe only reason the forced attribute now has more to do with the npm install than with the presence of node itself. I'd argue that maybe a better solution to including the nodejs::npm recipe would be to check for the executable on the system, because that recipe is a bit nuts :) One can only avoid this by making sure both ```node['nodejs']['dir']``` and ```node['nodejs']['npm']``` version are set right.\r\n\r\nAnyway, with the changes, we can now have recipes that look like, for people like me, who have multiple daemons in the same repo:\r\n\r\n```ruby\r\napplication 'ologger' do\r\n  path node['infosan']['ologger']['dir']\r\n  owner node['infosan']['user']\r\n  group node['infosan']['user']\r\n  repository node['infosan']['ologger']['repo']\r\n  deploy_key File.join(node['infosan']['home'], '.ssh', 'bitbucket')\r\n  action :deploy\r\n\r\n  nodejs do\r\n    entry_point 'bin/collectord'\r\n    service_name 'collector'\r\n  end\r\n\r\n  nodejs do\r\n    entry_point 'bin/commandsd'\r\n    service_name 'commands'\r\n  end\r\nend\r\n```\r\n","created_at":"2014-04-25T04:14:08Z","updated_at":"2015-07-08T04:36:41Z","closed_at":"2015-07-08T04:36:41Z","merged_at":null,"merge_commit_sha":"307872eaccde74276c3c979b4a57d8b32a359b56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mburns/application_nodejs/pulls/9/commits","review_comments_url":"https://api.github.com/repos/mburns/application_nodejs/pulls/9/comments","review_comment_url":"https://api.github.com/repos/mburns/application_nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mburns/application_nodejs/issues/9/comments","statuses_url":"https://api.github.com/repos/mburns/application_nodejs/statuses/e89f75dd618b84aad629b70574412e186beeeb45","head":{"label":"rizzatti:develop","ref":"develop","sha":"e89f75dd618b84aad629b70574412e186beeeb45","user":{"login":"rizzatti","id":793577,"avatar_url":"https://avatars.githubusercontent.com/u/793577?v=3","gravatar_id":"","url":"https://api.github.com/users/rizzatti","html_url":"https://github.com/rizzatti","followers_url":"https://api.github.com/users/rizzatti/followers","following_url":"https://api.github.com/users/rizzatti/following{/other_user}","gists_url":"https://api.github.com/users/rizzatti/gists{/gist_id}","starred_url":"https://api.github.com/users/rizzatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizzatti/subscriptions","organizations_url":"https://api.github.com/users/rizzatti/orgs","repos_url":"https://api.github.com/users/rizzatti/repos","events_url":"https://api.github.com/users/rizzatti/events{/privacy}","received_events_url":"https://api.github.com/users/rizzatti/received_events","type":"User","site_admin":false},"repo":{"id":19118542,"name":"application_nodejs","full_name":"rizzatti/application_nodejs","owner":{"login":"rizzatti","id":793577,"avatar_url":"https://avatars.githubusercontent.com/u/793577?v=3","gravatar_id":"","url":"https://api.github.com/users/rizzatti","html_url":"https://github.com/rizzatti","followers_url":"https://api.github.com/users/rizzatti/followers","following_url":"https://api.github.com/users/rizzatti/following{/other_user}","gists_url":"https://api.github.com/users/rizzatti/gists{/gist_id}","starred_url":"https://api.github.com/users/rizzatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizzatti/subscriptions","organizations_url":"https://api.github.com/users/rizzatti/orgs","repos_url":"https://api.github.com/users/rizzatti/repos","events_url":"https://api.github.com/users/rizzatti/events{/privacy}","received_events_url":"https://api.github.com/users/rizzatti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rizzatti/application_nodejs","description":"Chef cookbook for deploying and configuring Node.js applications","fork":true,"url":"https://api.github.com/repos/rizzatti/application_nodejs","forks_url":"https://api.github.com/repos/rizzatti/application_nodejs/forks","keys_url":"https://api.github.com/repos/rizzatti/application_nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rizzatti/application_nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rizzatti/application_nodejs/teams","hooks_url":"https://api.github.com/repos/rizzatti/application_nodejs/hooks","issue_events_url":"https://api.github.com/repos/rizzatti/application_nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/rizzatti/application_nodejs/events","assignees_url":"https://api.github.com/repos/rizzatti/application_nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/rizzatti/application_nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/rizzatti/application_nodejs/tags","blobs_url":"https://api.github.com/repos/rizzatti/application_nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rizzatti/application_nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rizzatti/application_nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rizzatti/application_nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rizzatti/application_nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/rizzatti/application_nodejs/languages","stargazers_url":"https://api.github.com/repos/rizzatti/application_nodejs/stargazers","contributors_url":"https://api.github.com/repos/rizzatti/application_nodejs/contributors","subscribers_url":"https://api.github.com/repos/rizzatti/application_nodejs/subscribers","subscription_url":"https://api.github.com/repos/rizzatti/application_nodejs/subscription","commits_url":"https://api.github.com/repos/rizzatti/application_nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rizzatti/application_nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rizzatti/application_nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rizzatti/application_nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rizzatti/application_nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/rizzatti/application_nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rizzatti/application_nodejs/merges","archive_url":"https://api.github.com/repos/rizzatti/application_nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rizzatti/application_nodejs/downloads","issues_url":"https://api.github.com/repos/rizzatti/application_nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/rizzatti/application_nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/rizzatti/application_nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/rizzatti/application_nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rizzatti/application_nodejs/labels{/name}","releases_url":"https://api.github.com/repos/rizzatti/application_nodejs/releases{/id}","created_at":"2014-04-24T18:01:33Z","updated_at":"2015-06-28T18:54:09Z","pushed_at":"2014-04-25T03:50:08Z","git_url":"git://github.com/rizzatti/application_nodejs.git","ssh_url":"git@github.com:rizzatti/application_nodejs.git","clone_url":"https://github.com/rizzatti/application_nodejs.git","svn_url":"https://github.com/rizzatti/application_nodejs","homepage":null,"size":168,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mburns:master","ref":"master","sha":"76391c132e4ca5f65e4b13507145213fe49142b0","user":{"login":"mburns","id":5170,"avatar_url":"https://avatars.githubusercontent.com/u/5170?v=3","gravatar_id":"","url":"https://api.github.com/users/mburns","html_url":"https://github.com/mburns","followers_url":"https://api.github.com/users/mburns/followers","following_url":"https://api.github.com/users/mburns/following{/other_user}","gists_url":"https://api.github.com/users/mburns/gists{/gist_id}","starred_url":"https://api.github.com/users/mburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mburns/subscriptions","organizations_url":"https://api.github.com/users/mburns/orgs","repos_url":"https://api.github.com/users/mburns/repos","events_url":"https://api.github.com/users/mburns/events{/privacy}","received_events_url":"https://api.github.com/users/mburns/received_events","type":"User","site_admin":false},"repo":{"id":7714192,"name":"application_nodejs","full_name":"mburns/application_nodejs","owner":{"login":"mburns","id":5170,"avatar_url":"https://avatars.githubusercontent.com/u/5170?v=3","gravatar_id":"","url":"https://api.github.com/users/mburns","html_url":"https://github.com/mburns","followers_url":"https://api.github.com/users/mburns/followers","following_url":"https://api.github.com/users/mburns/following{/other_user}","gists_url":"https://api.github.com/users/mburns/gists{/gist_id}","starred_url":"https://api.github.com/users/mburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mburns/subscriptions","organizations_url":"https://api.github.com/users/mburns/orgs","repos_url":"https://api.github.com/users/mburns/repos","events_url":"https://api.github.com/users/mburns/events{/privacy}","received_events_url":"https://api.github.com/users/mburns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mburns/application_nodejs","description":"Chef cookbook for deploying and configuring Node.js applications","fork":false,"url":"https://api.github.com/repos/mburns/application_nodejs","forks_url":"https://api.github.com/repos/mburns/application_nodejs/forks","keys_url":"https://api.github.com/repos/mburns/application_nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mburns/application_nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mburns/application_nodejs/teams","hooks_url":"https://api.github.com/repos/mburns/application_nodejs/hooks","issue_events_url":"https://api.github.com/repos/mburns/application_nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/mburns/application_nodejs/events","assignees_url":"https://api.github.com/repos/mburns/application_nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/mburns/application_nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/mburns/application_nodejs/tags","blobs_url":"https://api.github.com/repos/mburns/application_nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mburns/application_nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mburns/application_nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mburns/application_nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mburns/application_nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/mburns/application_nodejs/languages","stargazers_url":"https://api.github.com/repos/mburns/application_nodejs/stargazers","contributors_url":"https://api.github.com/repos/mburns/application_nodejs/contributors","subscribers_url":"https://api.github.com/repos/mburns/application_nodejs/subscribers","subscription_url":"https://api.github.com/repos/mburns/application_nodejs/subscription","commits_url":"https://api.github.com/repos/mburns/application_nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mburns/application_nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mburns/application_nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mburns/application_nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mburns/application_nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/mburns/application_nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mburns/application_nodejs/merges","archive_url":"https://api.github.com/repos/mburns/application_nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mburns/application_nodejs/downloads","issues_url":"https://api.github.com/repos/mburns/application_nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/mburns/application_nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/mburns/application_nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/mburns/application_nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mburns/application_nodejs/labels{/name}","releases_url":"https://api.github.com/repos/mburns/application_nodejs/releases{/id}","created_at":"2013-01-20T08:19:32Z","updated_at":"2015-07-08T02:34:31Z","pushed_at":"2015-07-08T04:36:28Z","git_url":"git://github.com/mburns/application_nodejs.git","ssh_url":"git@github.com:mburns/application_nodejs.git","clone_url":"https://github.com/mburns/application_nodejs.git","svn_url":"https://github.com/mburns/application_nodejs","homepage":null,"size":257,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":8,"forks":34,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mburns/application_nodejs/pulls/9"},"html":{"href":"https://github.com/mburns/application_nodejs/pull/9"},"issue":{"href":"https://api.github.com/repos/mburns/application_nodejs/issues/9"},"comments":{"href":"https://api.github.com/repos/mburns/application_nodejs/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/mburns/application_nodejs/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/mburns/application_nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mburns/application_nodejs/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/mburns/application_nodejs/statuses/e89f75dd618b84aad629b70574412e186beeeb45"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":24,"deletions":7,"changed_files":5}}