{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/36136510","id":36136510,"diff_hunk":"@@ -123,4 +124,87 @@ public static void FileSystemWatcher_Created_FileCreatedInNestedDirectory()\n             }\n         });\n     }\n+\n+    // This can potentially fail on Windows, depending on where the test is run from, due to \n+    // the MAX_PATH limitation in Windows. When issue 645 is closed, this shouldn't be a problem\n+    [Fact, ActiveIssue(\"645\", PlatformID.Windows)]\n+    public static void FileSystemWatcher_Created_DeepDirectoryStructure()\n+    {\n+        using (var dir = Utility.CreateTestDirectory())\n+        using (var watcher = new FileSystemWatcher())\n+        {\n+            AutoResetEvent eventOccured = Utility.WatchForEvents(watcher, WatcherChangeTypes.Created);\n+\n+            // put everything in our own directory to avoid collisions\n+            watcher.Path = Path.GetFullPath(dir.Path);\n+            watcher.Filter = \"*.*\";\n+            watcher.IncludeSubdirectories = true;\n+            watcher.EnableRaisingEvents = true;\n+\n+            // List of created directories\n+            List<TemporaryTestDirectory> lst = new List<TemporaryTestDirectory>();\n+\n+            // Priming directory\n+            TemporaryTestDirectory priming = new TemporaryTestDirectory(Path.Combine(dir.Path, \"dir\"));\n+            lst.Add(priming);\n+            Utility.ExpectEvent(eventOccured, \"priming create\");\n+\n+            // Create a deep directory structure and expect things to work\n+            for (int i = 1; i < 20; i++)\n+            {\n+                lst.Add(new TemporaryTestDirectory(Path.Combine(lst[i - 1].Path, String.Format(\"dir{0}\", i))));\n+                Utility.ExpectEvent(eventOccured, lst[i].Path + \" create\");\n+            }\n+\n+            // Put a file at the very bottom and expect it to raise an event\n+            using (var file = new TemporaryTestFile(Path.Combine(lst[lst.Count - 1].Path, \"temp file\")))\n+            {\n+                Utility.ExpectEvent(eventOccured, \"temp file create\");\n+            }\n+\n+            // Cleanup\n+            foreach (TemporaryTestDirectory d in lst)\n+                d.Dispose();\n+        }\n+    }\n+\n+    [Fact, ActiveIssue(\"1477\", PlatformID.Windows)]\n+    public static void FileSystemWatcher_Created_WatcherDoesntFollowSymLinkToFile()\n+    {\n+        using (var dir = Utility.CreateTestDirectory())\n+        using (var temp = Utility.CreateTestFile(Path.GetTempFileName()))\n+        using (var watcher = new FileSystemWatcher())\n+        {\n+            AutoResetEvent eventOccured = Utility.WatchForEvents(watcher, WatcherChangeTypes.Created);\n+\n+            // put everything in our own directory to avoid collisions\n+            watcher.Path = Path.GetFullPath(dir.Path);\n+            watcher.Filter = \"*\";\n+            watcher.EnableRaisingEvents = true;\n+\n+            // Make the symlink in our path (to the temp file) and make sure no event is raised\n+            Utility.CreateSymLink(Path.GetFullPath(temp.Path), Path.Combine(dir.Path, Path.GetFileName(temp.Path)), false);\n+            Utility.ExpectNoEvent(eventOccured, \"symlink created\");\n+        }\n+    }\n+\n+    [Fact, ActiveIssue(\"1477\", PlatformID.Windows)]\n+    public static void FileSystemWatcher_Created_WatcherDoesntFollowSymLinkToFolder()\n+    {\n+        using (var dir = Utility.CreateTestDirectory())\n+        using (var temp = Utility.CreateTestDirectory(Path.Combine(Path.GetTempPath(), \"FooBar\")))\n+        using (var watcher = new FileSystemWatcher())\n+        {\n+            AutoResetEvent eventOccured = Utility.WatchForEvents(watcher, WatcherChangeTypes.Created);\n+\n+            // put everything in our own directory to avoid collisions\n+            watcher.Path = Path.GetFullPath(dir.Path);\n+            watcher.Filter = \"*\";\n+            watcher.EnableRaisingEvents = true;\n+\n+            // Make the symlink in our path (to the temp folder) and make sure no event is raised\n+            Utility.CreateSymLink(Path.GetFullPath(temp.Path), Path.Combine(dir.Path, Path.GetFileName(temp.Path)), true);","path":"src/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Created.cs","position":91,"original_position":91,"commit_id":"3d82310ce51ed40bc605d3daa643fc095d807c20","original_commit_id":"3d82310ce51ed40bc605d3daa643fc095d807c20","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2015-08-03T21:56:58Z","updated_at":"2015-08-03T21:56:58Z","html_url":"https://github.com/dotnet/corefx/pull/2587#discussion_r36136510","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2587","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/36136510"},"html":{"href":"https://github.com/dotnet/corefx/pull/2587#discussion_r36136510"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2587"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2587","id":41381569,"html_url":"https://github.com/dotnet/corefx/pull/2587","diff_url":"https://github.com/dotnet/corefx/pull/2587.diff","patch_url":"https://github.com/dotnet/corefx/pull/2587.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2587","number":2587,"state":"open","locked":false,"title":"Adding new Unit Tests to validate the more complex FileSystemWatcher scenarios","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"Adding new Unit Tests to validate the more complex FileSystemWatcher scenarios: symlinks, deep directory structures, and preseeded directories.","created_at":"2015-07-31T21:13:35Z","updated_at":"2015-08-03T21:56:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05a595196369585a79d65a995f7f26926e8420fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2587/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2587/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2587/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3d82310ce51ed40bc605d3daa643fc095d807c20","head":{"label":"sokket:fsw","ref":"fsw","sha":"3d82310ce51ed40bc605d3daa643fc095d807c20","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"repo":{"id":31975260,"name":"corefx","full_name":"sokket/corefx","owner":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sokket/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sokket/corefx","forks_url":"https://api.github.com/repos/sokket/corefx/forks","keys_url":"https://api.github.com/repos/sokket/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sokket/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sokket/corefx/teams","hooks_url":"https://api.github.com/repos/sokket/corefx/hooks","issue_events_url":"https://api.github.com/repos/sokket/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sokket/corefx/events","assignees_url":"https://api.github.com/repos/sokket/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sokket/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sokket/corefx/tags","blobs_url":"https://api.github.com/repos/sokket/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sokket/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sokket/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sokket/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sokket/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sokket/corefx/languages","stargazers_url":"https://api.github.com/repos/sokket/corefx/stargazers","contributors_url":"https://api.github.com/repos/sokket/corefx/contributors","subscribers_url":"https://api.github.com/repos/sokket/corefx/subscribers","subscription_url":"https://api.github.com/repos/sokket/corefx/subscription","commits_url":"https://api.github.com/repos/sokket/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sokket/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sokket/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sokket/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sokket/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sokket/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sokket/corefx/merges","archive_url":"https://api.github.com/repos/sokket/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sokket/corefx/downloads","issues_url":"https://api.github.com/repos/sokket/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sokket/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sokket/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sokket/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sokket/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sokket/corefx/releases{/id}","created_at":"2015-03-10T18:45:28Z","updated_at":"2015-05-06T18:55:19Z","pushed_at":"2015-07-31T21:13:02Z","git_url":"git://github.com/sokket/corefx.git","ssh_url":"git@github.com:sokket/corefx.git","clone_url":"https://github.com/sokket/corefx.git","svn_url":"https://github.com/sokket/corefx","homepage":"","size":25365,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"63ff03fce5ab7c7ac6920d99af148a447d04c822","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-08-03T17:52:31Z","pushed_at":"2015-08-03T21:44:57Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":58030,"stargazers_count":8159,"watchers_count":8159,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1709,"mirror_url":null,"open_issues_count":529,"forks":1709,"open_issues":529,"watchers":8159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2587"},"html":{"href":"https://github.com/dotnet/corefx/pull/2587"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2587"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2587/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2587/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2587/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3d82310ce51ed40bc605d3daa643fc095d807c20"}}}}