{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/16935","labels_url":"https://api.github.com/repos/owncloud/core/issues/16935/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/16935/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/16935/events","html_url":"https://github.com/owncloud/core/pull/16935","id":88429890,"number":16935,"title":"Allow app check code for deprecated classes","user":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/technical%20debt","name":"technical debt","color":"FFFF00"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":621,"closed_issues":127,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-07-16T09:35:25Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"comments":22,"created_at":"2015-06-15T13:39:16Z","updated_at":"2015-07-16T09:45:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/16935","html_url":"https://github.com/owncloud/core/pull/16935","diff_url":"https://github.com/owncloud/core/pull/16935.diff","patch_url":"https://github.com/owncloud/core/pull/16935.patch"},"body":"Old behaviour (without parameter):\r\n```\r\nnickv@nickv-think ~/ownCloud/master/core $ ./occ app:check-code activity\r\nApp is compliant - awesome job!\r\n```\r\n\r\nWith deprecated parameter:\r\n```\r\nnickv@nickv-think ~/ownCloud/master/core $ ./occ app:check-code activity --deprecated\r\nAnalysing /home/nickv/ownCloud/master/repos/activity/templates/stream.app.navigation.php\r\n 1 errors\r\n    line   14: == - is discouraged\r\nAnalysing /home/nickv/ownCloud/master/repos/activity/controller/settings.php\r\n 2 errors\r\n    line   31: OCP\\IConfig - deprecated class must not be imported with a use statement\r\n    line  112: == - is discouraged\r\nAnalysing /home/nickv/ownCloud/master/repos/activity/lib/data.php\r\n 1 errors\r\n    line   27: OCP\\DB - deprecated class must not be imported with a use statement\r\n\r\nAnalysing /home/nickv/ownCloud/master/repos/activity/appinfo/update.php\r\n 3 errors\r\n    line   14: OCP\\DB - Static method of deprecated class must not be called\r\n    line   24: OCP\\DB - Static method of deprecated class must not be called\r\n    line   26: OCP\\DB - Static method of deprecated class must not be called\r\nApp uses deprecated functionality\r\n```\r\n\r\nRequested at https://mailman.owncloud.org/pipermail/devel/2015-June/001301.html\r\n\r\nI think it's quite useful.\r\nAlso fixing a bug (use statements could circumvent blacklisted classes)\r\n\r\n@DeepDiver1975 @MorrisJobke @LukasReschke \r\n\r\n### Todo\r\n- [x] Add support for deprecated classes\r\n- [x] Add support for deprecated constants\r\n- [x] Add support for deprecated functions\r\n- [ ] Add support for deprecated methods"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/121906229","html_url":"https://github.com/owncloud/core/pull/16935#issuecomment-121906229","issue_url":"https://api.github.com/repos/owncloud/core/issues/16935","id":121906229,"user":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T09:45:10Z","updated_at":"2015-07-16T09:45:10Z","body":"https://github.com/owncloud/core/pull/17046 was merged, so I will add that when jenkins reported back"}}