{"action":"created","comment":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/comments/43654019","id":43654019,"diff_hunk":"@@ -126,13 +126,15 @@ def test_get_dataset_dir():\n     # Non writeable dir is returned because dataset may be in there.\n     assert_equal(data_dir, no_write)\n     assert os.path.exists(data_dir)\n+    os.chmod(no_write, 0o600) # Enable write permissions back","path":"nilearn/datasets/tests/test_atlas.py","position":4,"original_position":4,"commit_id":"6be5f9c36bb371a3d9973e311885f116743a4c77","original_commit_id":"6be5f9c36bb371a3d9973e311885f116743a4c77","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"body":"PEP8 (two spaces before inline comment). Also mention why you reenabling write permissions (to be able to delete it I guess)","created_at":"2015-11-02T17:19:58Z","updated_at":"2015-11-02T17:19:58Z","html_url":"https://github.com/nilearn/nilearn/pull/814#discussion_r43654019","pull_request_url":"https://api.github.com/repos/nilearn/nilearn/pulls/814","_links":{"self":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/comments/43654019"},"html":{"href":"https://github.com/nilearn/nilearn/pull/814#discussion_r43654019"},"pull_request":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/814"}}},"pull_request":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/814","id":49453692,"html_url":"https://github.com/nilearn/nilearn/pull/814","diff_url":"https://github.com/nilearn/nilearn/pull/814.diff","patch_url":"https://github.com/nilearn/nilearn/pull/814.patch","issue_url":"https://api.github.com/repos/nilearn/nilearn/issues/814","number":814,"state":"open","locked":false,"title":"[MRG] Fixing path and environment variables issues + tests on windows","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"This PR partly fix the issue #809 \r\n\r\nBut it maybe worth to merge. Summary of changes:\r\n* fixed Environment variable split character for windows as it uses ';'\r\n* replaced '/' with os.sep when required\r\n* fixed permission issues when removing files in test_atlas.py/test_utils.py\r\n* fixed file:// prefix using urllib crossplatform dedicated function \"pathname2url\"","created_at":"2015-11-02T16:35:32Z","updated_at":"2015-11-02T17:19:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41de199c2d627dc1f78220e3966bcc1a233541c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nilearn/nilearn/pulls/814/commits","review_comments_url":"https://api.github.com/repos/nilearn/nilearn/pulls/814/comments","review_comment_url":"https://api.github.com/repos/nilearn/nilearn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nilearn/nilearn/issues/814/comments","statuses_url":"https://api.github.com/repos/nilearn/nilearn/statuses/6be5f9c36bb371a3d9973e311885f116743a4c77","head":{"label":"aabadie:fix_windows_paths","ref":"fix_windows_paths","sha":"6be5f9c36bb371a3d9973e311885f116743a4c77","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"repo":{"id":41858666,"name":"nilearn","full_name":"aabadie/nilearn","owner":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aabadie/nilearn","description":"Machine learning for NeuroImaging in Python","fork":true,"url":"https://api.github.com/repos/aabadie/nilearn","forks_url":"https://api.github.com/repos/aabadie/nilearn/forks","keys_url":"https://api.github.com/repos/aabadie/nilearn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aabadie/nilearn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aabadie/nilearn/teams","hooks_url":"https://api.github.com/repos/aabadie/nilearn/hooks","issue_events_url":"https://api.github.com/repos/aabadie/nilearn/issues/events{/number}","events_url":"https://api.github.com/repos/aabadie/nilearn/events","assignees_url":"https://api.github.com/repos/aabadie/nilearn/assignees{/user}","branches_url":"https://api.github.com/repos/aabadie/nilearn/branches{/branch}","tags_url":"https://api.github.com/repos/aabadie/nilearn/tags","blobs_url":"https://api.github.com/repos/aabadie/nilearn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aabadie/nilearn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aabadie/nilearn/git/refs{/sha}","trees_url":"https://api.github.com/repos/aabadie/nilearn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aabadie/nilearn/statuses/{sha}","languages_url":"https://api.github.com/repos/aabadie/nilearn/languages","stargazers_url":"https://api.github.com/repos/aabadie/nilearn/stargazers","contributors_url":"https://api.github.com/repos/aabadie/nilearn/contributors","subscribers_url":"https://api.github.com/repos/aabadie/nilearn/subscribers","subscription_url":"https://api.github.com/repos/aabadie/nilearn/subscription","commits_url":"https://api.github.com/repos/aabadie/nilearn/commits{/sha}","git_commits_url":"https://api.github.com/repos/aabadie/nilearn/git/commits{/sha}","comments_url":"https://api.github.com/repos/aabadie/nilearn/comments{/number}","issue_comment_url":"https://api.github.com/repos/aabadie/nilearn/issues/comments{/number}","contents_url":"https://api.github.com/repos/aabadie/nilearn/contents/{+path}","compare_url":"https://api.github.com/repos/aabadie/nilearn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aabadie/nilearn/merges","archive_url":"https://api.github.com/repos/aabadie/nilearn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aabadie/nilearn/downloads","issues_url":"https://api.github.com/repos/aabadie/nilearn/issues{/number}","pulls_url":"https://api.github.com/repos/aabadie/nilearn/pulls{/number}","milestones_url":"https://api.github.com/repos/aabadie/nilearn/milestones{/number}","notifications_url":"https://api.github.com/repos/aabadie/nilearn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aabadie/nilearn/labels{/name}","releases_url":"https://api.github.com/repos/aabadie/nilearn/releases{/id}","created_at":"2015-09-03T12:32:01Z","updated_at":"2015-09-03T12:32:02Z","pushed_at":"2015-11-02T16:31:03Z","git_url":"git://github.com/aabadie/nilearn.git","ssh_url":"git@github.com:aabadie/nilearn.git","clone_url":"https://github.com/aabadie/nilearn.git","svn_url":"https://github.com/aabadie/nilearn","homepage":"http://nilearn.github.io","size":8018,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nilearn:master","ref":"master","sha":"1f14723938e892801a9736481b588982d298ba48","user":{"login":"nilearn","id":4646912,"avatar_url":"https://avatars.githubusercontent.com/u/4646912?v=3","gravatar_id":"","url":"https://api.github.com/users/nilearn","html_url":"https://github.com/nilearn","followers_url":"https://api.github.com/users/nilearn/followers","following_url":"https://api.github.com/users/nilearn/following{/other_user}","gists_url":"https://api.github.com/users/nilearn/gists{/gist_id}","starred_url":"https://api.github.com/users/nilearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilearn/subscriptions","organizations_url":"https://api.github.com/users/nilearn/orgs","repos_url":"https://api.github.com/users/nilearn/repos","events_url":"https://api.github.com/users/nilearn/events{/privacy}","received_events_url":"https://api.github.com/users/nilearn/received_events","type":"Organization","site_admin":false},"repo":{"id":1235740,"name":"nilearn","full_name":"nilearn/nilearn","owner":{"login":"nilearn","id":4646912,"avatar_url":"https://avatars.githubusercontent.com/u/4646912?v=3","gravatar_id":"","url":"https://api.github.com/users/nilearn","html_url":"https://github.com/nilearn","followers_url":"https://api.github.com/users/nilearn/followers","following_url":"https://api.github.com/users/nilearn/following{/other_user}","gists_url":"https://api.github.com/users/nilearn/gists{/gist_id}","starred_url":"https://api.github.com/users/nilearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilearn/subscriptions","organizations_url":"https://api.github.com/users/nilearn/orgs","repos_url":"https://api.github.com/users/nilearn/repos","events_url":"https://api.github.com/users/nilearn/events{/privacy}","received_events_url":"https://api.github.com/users/nilearn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nilearn/nilearn","description":"Machine learning for NeuroImaging in Python","fork":false,"url":"https://api.github.com/repos/nilearn/nilearn","forks_url":"https://api.github.com/repos/nilearn/nilearn/forks","keys_url":"https://api.github.com/repos/nilearn/nilearn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nilearn/nilearn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nilearn/nilearn/teams","hooks_url":"https://api.github.com/repos/nilearn/nilearn/hooks","issue_events_url":"https://api.github.com/repos/nilearn/nilearn/issues/events{/number}","events_url":"https://api.github.com/repos/nilearn/nilearn/events","assignees_url":"https://api.github.com/repos/nilearn/nilearn/assignees{/user}","branches_url":"https://api.github.com/repos/nilearn/nilearn/branches{/branch}","tags_url":"https://api.github.com/repos/nilearn/nilearn/tags","blobs_url":"https://api.github.com/repos/nilearn/nilearn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nilearn/nilearn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nilearn/nilearn/git/refs{/sha}","trees_url":"https://api.github.com/repos/nilearn/nilearn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nilearn/nilearn/statuses/{sha}","languages_url":"https://api.github.com/repos/nilearn/nilearn/languages","stargazers_url":"https://api.github.com/repos/nilearn/nilearn/stargazers","contributors_url":"https://api.github.com/repos/nilearn/nilearn/contributors","subscribers_url":"https://api.github.com/repos/nilearn/nilearn/subscribers","subscription_url":"https://api.github.com/repos/nilearn/nilearn/subscription","commits_url":"https://api.github.com/repos/nilearn/nilearn/commits{/sha}","git_commits_url":"https://api.github.com/repos/nilearn/nilearn/git/commits{/sha}","comments_url":"https://api.github.com/repos/nilearn/nilearn/comments{/number}","issue_comment_url":"https://api.github.com/repos/nilearn/nilearn/issues/comments{/number}","contents_url":"https://api.github.com/repos/nilearn/nilearn/contents/{+path}","compare_url":"https://api.github.com/repos/nilearn/nilearn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nilearn/nilearn/merges","archive_url":"https://api.github.com/repos/nilearn/nilearn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nilearn/nilearn/downloads","issues_url":"https://api.github.com/repos/nilearn/nilearn/issues{/number}","pulls_url":"https://api.github.com/repos/nilearn/nilearn/pulls{/number}","milestones_url":"https://api.github.com/repos/nilearn/nilearn/milestones{/number}","notifications_url":"https://api.github.com/repos/nilearn/nilearn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nilearn/nilearn/labels{/name}","releases_url":"https://api.github.com/repos/nilearn/nilearn/releases{/id}","created_at":"2011-01-09T19:02:23Z","updated_at":"2015-11-01T23:42:20Z","pushed_at":"2015-11-02T16:35:33Z","git_url":"git://github.com/nilearn/nilearn.git","ssh_url":"git@github.com:nilearn/nilearn.git","clone_url":"https://github.com/nilearn/nilearn.git","svn_url":"https://github.com/nilearn/nilearn","homepage":"http://nilearn.github.io","size":15021,"stargazers_count":120,"watchers_count":120,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":95,"forks":85,"open_issues":95,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/814"},"html":{"href":"https://github.com/nilearn/nilearn/pull/814"},"issue":{"href":"https://api.github.com/repos/nilearn/nilearn/issues/814"},"comments":{"href":"https://api.github.com/repos/nilearn/nilearn/issues/814/comments"},"review_comments":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/814/comments"},"review_comment":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/814/commits"},"statuses":{"href":"https://api.github.com/repos/nilearn/nilearn/statuses/6be5f9c36bb371a3d9973e311885f116743a4c77"}}}}