{"action":"created","comment":{"url":"https://api.github.com/repos/YOURLS/YOURLS/pulls/comments/33345924","id":33345924,"diff_hunk":"@@ -757,7 +760,7 @@ function yourls_html_menu() {\n \t$admin_sublinks = yourls_apply_filter( 'admin_sublinks', $admin_sublinks );\n \t\n \t// Now output menu\n-\techo '<ul id=\"admin_menu\">'.\"\\n\";\n+\techo '<nav role=\"navigation\"><ul id=\"admin_menu\">'.\"\\n\";","path":"includes/functions-html.php","position":53,"original_position":53,"commit_id":"0acb6ac0bdd63491597252d74c832efddcc70722","original_commit_id":"0acb6ac0bdd63491597252d74c832efddcc70722","user":{"login":"LeoColomb","id":846943,"avatar_url":"https://avatars.githubusercontent.com/u/846943?v=3","gravatar_id":"","url":"https://api.github.com/users/LeoColomb","html_url":"https://github.com/LeoColomb","followers_url":"https://api.github.com/users/LeoColomb/followers","following_url":"https://api.github.com/users/LeoColomb/following{/other_user}","gists_url":"https://api.github.com/users/LeoColomb/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoColomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoColomb/subscriptions","organizations_url":"https://api.github.com/users/LeoColomb/orgs","repos_url":"https://api.github.com/users/LeoColomb/repos","events_url":"https://api.github.com/users/LeoColomb/events{/privacy}","received_events_url":"https://api.github.com/users/LeoColomb/received_events","type":"User","site_admin":false},"body":"Again with `nav` and `ul#admin_menu`.","created_at":"2015-06-26T10:54:04Z","updated_at":"2015-06-26T10:54:04Z","html_url":"https://github.com/YOURLS/YOURLS/pull/1921#discussion_r33345924","pull_request_url":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921","_links":{"self":{"href":"https://api.github.com/repos/YOURLS/YOURLS/pulls/comments/33345924"},"html":{"href":"https://github.com/YOURLS/YOURLS/pull/1921#discussion_r33345924"},"pull_request":{"href":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921"}}},"pull_request":{"url":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921","id":38636501,"html_url":"https://github.com/YOURLS/YOURLS/pull/1921","diff_url":"https://github.com/YOURLS/YOURLS/pull/1921.diff","patch_url":"https://github.com/YOURLS/YOURLS/pull/1921.patch","issue_url":"https://api.github.com/repos/YOURLS/YOURLS/issues/1921","number":1921,"state":"open","locked":false,"title":"add HTML5 tag and ARIA landmark","user":{"login":"audreymaniez","id":409392,"avatar_url":"https://avatars.githubusercontent.com/u/409392?v=3","gravatar_id":"","url":"https://api.github.com/users/audreymaniez","html_url":"https://github.com/audreymaniez","followers_url":"https://api.github.com/users/audreymaniez/followers","following_url":"https://api.github.com/users/audreymaniez/following{/other_user}","gists_url":"https://api.github.com/users/audreymaniez/gists{/gist_id}","starred_url":"https://api.github.com/users/audreymaniez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audreymaniez/subscriptions","organizations_url":"https://api.github.com/users/audreymaniez/orgs","repos_url":"https://api.github.com/users/audreymaniez/repos","events_url":"https://api.github.com/users/audreymaniez/events{/privacy}","received_events_url":"https://api.github.com/users/audreymaniez/received_events","type":"User","site_admin":false},"body":"I added HTML5 tag (`header nav footer main`) and ARIA landmark (`navigation main banner contentinfo`) on templates.\r\n[See WAI-ARIA recommendation ](http://www.w3.org/TR/wai-aria/roles#landmark_roles_header) \r\n\r\nNo design impact (no need to modify CSS files)\r\n\r\nAnd that's really good for screen reader users :-)\r\n\r\nIf interested, i can go further and I can work on making it all accessible, as I done for our society installation.","created_at":"2015-06-26T10:30:59Z","updated_at":"2015-06-26T10:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1a9e63c4d1199ca65bfe0a111b4bbdb3a1e68eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921/commits","review_comments_url":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921/comments","review_comment_url":"https://api.github.com/repos/YOURLS/YOURLS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YOURLS/YOURLS/issues/1921/comments","statuses_url":"https://api.github.com/repos/YOURLS/YOURLS/statuses/0acb6ac0bdd63491597252d74c832efddcc70722","head":{"label":"access42:a11y","ref":"a11y","sha":"0acb6ac0bdd63491597252d74c832efddcc70722","user":{"login":"access42","id":8665093,"avatar_url":"https://avatars.githubusercontent.com/u/8665093?v=3","gravatar_id":"","url":"https://api.github.com/users/access42","html_url":"https://github.com/access42","followers_url":"https://api.github.com/users/access42/followers","following_url":"https://api.github.com/users/access42/following{/other_user}","gists_url":"https://api.github.com/users/access42/gists{/gist_id}","starred_url":"https://api.github.com/users/access42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/access42/subscriptions","organizations_url":"https://api.github.com/users/access42/orgs","repos_url":"https://api.github.com/users/access42/repos","events_url":"https://api.github.com/users/access42/events{/privacy}","received_events_url":"https://api.github.com/users/access42/received_events","type":"User","site_admin":false},"repo":{"id":38102428,"name":"YOURLS","full_name":"access42/YOURLS","owner":{"login":"access42","id":8665093,"avatar_url":"https://avatars.githubusercontent.com/u/8665093?v=3","gravatar_id":"","url":"https://api.github.com/users/access42","html_url":"https://github.com/access42","followers_url":"https://api.github.com/users/access42/followers","following_url":"https://api.github.com/users/access42/following{/other_user}","gists_url":"https://api.github.com/users/access42/gists{/gist_id}","starred_url":"https://api.github.com/users/access42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/access42/subscriptions","organizations_url":"https://api.github.com/users/access42/orgs","repos_url":"https://api.github.com/users/access42/repos","events_url":"https://api.github.com/users/access42/events{/privacy}","received_events_url":"https://api.github.com/users/access42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/access42/YOURLS","description":"Your Own URL Shortener.","fork":true,"url":"https://api.github.com/repos/access42/YOURLS","forks_url":"https://api.github.com/repos/access42/YOURLS/forks","keys_url":"https://api.github.com/repos/access42/YOURLS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/access42/YOURLS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/access42/YOURLS/teams","hooks_url":"https://api.github.com/repos/access42/YOURLS/hooks","issue_events_url":"https://api.github.com/repos/access42/YOURLS/issues/events{/number}","events_url":"https://api.github.com/repos/access42/YOURLS/events","assignees_url":"https://api.github.com/repos/access42/YOURLS/assignees{/user}","branches_url":"https://api.github.com/repos/access42/YOURLS/branches{/branch}","tags_url":"https://api.github.com/repos/access42/YOURLS/tags","blobs_url":"https://api.github.com/repos/access42/YOURLS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/access42/YOURLS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/access42/YOURLS/git/refs{/sha}","trees_url":"https://api.github.com/repos/access42/YOURLS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/access42/YOURLS/statuses/{sha}","languages_url":"https://api.github.com/repos/access42/YOURLS/languages","stargazers_url":"https://api.github.com/repos/access42/YOURLS/stargazers","contributors_url":"https://api.github.com/repos/access42/YOURLS/contributors","subscribers_url":"https://api.github.com/repos/access42/YOURLS/subscribers","subscription_url":"https://api.github.com/repos/access42/YOURLS/subscription","commits_url":"https://api.github.com/repos/access42/YOURLS/commits{/sha}","git_commits_url":"https://api.github.com/repos/access42/YOURLS/git/commits{/sha}","comments_url":"https://api.github.com/repos/access42/YOURLS/comments{/number}","issue_comment_url":"https://api.github.com/repos/access42/YOURLS/issues/comments{/number}","contents_url":"https://api.github.com/repos/access42/YOURLS/contents/{+path}","compare_url":"https://api.github.com/repos/access42/YOURLS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/access42/YOURLS/merges","archive_url":"https://api.github.com/repos/access42/YOURLS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/access42/YOURLS/downloads","issues_url":"https://api.github.com/repos/access42/YOURLS/issues{/number}","pulls_url":"https://api.github.com/repos/access42/YOURLS/pulls{/number}","milestones_url":"https://api.github.com/repos/access42/YOURLS/milestones{/number}","notifications_url":"https://api.github.com/repos/access42/YOURLS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/access42/YOURLS/labels{/name}","releases_url":"https://api.github.com/repos/access42/YOURLS/releases{/id}","created_at":"2015-06-26T09:21:18Z","updated_at":"2015-06-26T09:21:18Z","pushed_at":"2015-06-26T10:20:37Z","git_url":"git://github.com/access42/YOURLS.git","ssh_url":"git@github.com:access42/YOURLS.git","clone_url":"https://github.com/access42/YOURLS.git","svn_url":"https://github.com/access42/YOURLS","homepage":"http://yourls.org/","size":15261,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YOURLS:master","ref":"master","sha":"12024cc56b7ee669321edfb6ca32385bd232a312","user":{"login":"YOURLS","id":2106111,"avatar_url":"https://avatars.githubusercontent.com/u/2106111?v=3","gravatar_id":"","url":"https://api.github.com/users/YOURLS","html_url":"https://github.com/YOURLS","followers_url":"https://api.github.com/users/YOURLS/followers","following_url":"https://api.github.com/users/YOURLS/following{/other_user}","gists_url":"https://api.github.com/users/YOURLS/gists{/gist_id}","starred_url":"https://api.github.com/users/YOURLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOURLS/subscriptions","organizations_url":"https://api.github.com/users/YOURLS/orgs","repos_url":"https://api.github.com/users/YOURLS/repos","events_url":"https://api.github.com/users/YOURLS/events{/privacy}","received_events_url":"https://api.github.com/users/YOURLS/received_events","type":"Organization","site_admin":false},"repo":{"id":5508585,"name":"YOURLS","full_name":"YOURLS/YOURLS","owner":{"login":"YOURLS","id":2106111,"avatar_url":"https://avatars.githubusercontent.com/u/2106111?v=3","gravatar_id":"","url":"https://api.github.com/users/YOURLS","html_url":"https://github.com/YOURLS","followers_url":"https://api.github.com/users/YOURLS/followers","following_url":"https://api.github.com/users/YOURLS/following{/other_user}","gists_url":"https://api.github.com/users/YOURLS/gists{/gist_id}","starred_url":"https://api.github.com/users/YOURLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOURLS/subscriptions","organizations_url":"https://api.github.com/users/YOURLS/orgs","repos_url":"https://api.github.com/users/YOURLS/repos","events_url":"https://api.github.com/users/YOURLS/events{/privacy}","received_events_url":"https://api.github.com/users/YOURLS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YOURLS/YOURLS","description":"Your Own URL Shortener.","fork":false,"url":"https://api.github.com/repos/YOURLS/YOURLS","forks_url":"https://api.github.com/repos/YOURLS/YOURLS/forks","keys_url":"https://api.github.com/repos/YOURLS/YOURLS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YOURLS/YOURLS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YOURLS/YOURLS/teams","hooks_url":"https://api.github.com/repos/YOURLS/YOURLS/hooks","issue_events_url":"https://api.github.com/repos/YOURLS/YOURLS/issues/events{/number}","events_url":"https://api.github.com/repos/YOURLS/YOURLS/events","assignees_url":"https://api.github.com/repos/YOURLS/YOURLS/assignees{/user}","branches_url":"https://api.github.com/repos/YOURLS/YOURLS/branches{/branch}","tags_url":"https://api.github.com/repos/YOURLS/YOURLS/tags","blobs_url":"https://api.github.com/repos/YOURLS/YOURLS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YOURLS/YOURLS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YOURLS/YOURLS/git/refs{/sha}","trees_url":"https://api.github.com/repos/YOURLS/YOURLS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YOURLS/YOURLS/statuses/{sha}","languages_url":"https://api.github.com/repos/YOURLS/YOURLS/languages","stargazers_url":"https://api.github.com/repos/YOURLS/YOURLS/stargazers","contributors_url":"https://api.github.com/repos/YOURLS/YOURLS/contributors","subscribers_url":"https://api.github.com/repos/YOURLS/YOURLS/subscribers","subscription_url":"https://api.github.com/repos/YOURLS/YOURLS/subscription","commits_url":"https://api.github.com/repos/YOURLS/YOURLS/commits{/sha}","git_commits_url":"https://api.github.com/repos/YOURLS/YOURLS/git/commits{/sha}","comments_url":"https://api.github.com/repos/YOURLS/YOURLS/comments{/number}","issue_comment_url":"https://api.github.com/repos/YOURLS/YOURLS/issues/comments{/number}","contents_url":"https://api.github.com/repos/YOURLS/YOURLS/contents/{+path}","compare_url":"https://api.github.com/repos/YOURLS/YOURLS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YOURLS/YOURLS/merges","archive_url":"https://api.github.com/repos/YOURLS/YOURLS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YOURLS/YOURLS/downloads","issues_url":"https://api.github.com/repos/YOURLS/YOURLS/issues{/number}","pulls_url":"https://api.github.com/repos/YOURLS/YOURLS/pulls{/number}","milestones_url":"https://api.github.com/repos/YOURLS/YOURLS/milestones{/number}","notifications_url":"https://api.github.com/repos/YOURLS/YOURLS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YOURLS/YOURLS/labels{/name}","releases_url":"https://api.github.com/repos/YOURLS/YOURLS/releases{/id}","created_at":"2012-08-22T11:36:52Z","updated_at":"2015-06-26T09:05:00Z","pushed_at":"2015-06-26T10:30:59Z","git_url":"git://github.com/YOURLS/YOURLS.git","ssh_url":"git@github.com:YOURLS/YOURLS.git","clone_url":"https://github.com/YOURLS/YOURLS.git","svn_url":"https://github.com/YOURLS/YOURLS","homepage":"http://yourls.org/","size":15261,"stargazers_count":1733,"watchers_count":1733,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":72,"forks":452,"open_issues":72,"watchers":1733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921"},"html":{"href":"https://github.com/YOURLS/YOURLS/pull/1921"},"issue":{"href":"https://api.github.com/repos/YOURLS/YOURLS/issues/1921"},"comments":{"href":"https://api.github.com/repos/YOURLS/YOURLS/issues/1921/comments"},"review_comments":{"href":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921/comments"},"review_comment":{"href":"https://api.github.com/repos/YOURLS/YOURLS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YOURLS/YOURLS/pulls/1921/commits"},"statuses":{"href":"https://api.github.com/repos/YOURLS/YOURLS/statuses/0acb6ac0bdd63491597252d74c832efddcc70722"}}}}