{"action":"opened","number":150,"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/150","id":49817187,"html_url":"https://github.com/nest/nest-simulator/pull/150","diff_url":"https://github.com/nest/nest-simulator/pull/150.diff","patch_url":"https://github.com/nest/nest-simulator/pull/150.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/150","number":150,"state":"open","locked":false,"title":"Add stdp_triplet_synapse from Pfister & Gerstner (2006)","user":{"login":"zifeo","id":9053709,"avatar_url":"https://avatars.githubusercontent.com/u/9053709?v=3","gravatar_id":"","url":"https://api.github.com/users/zifeo","html_url":"https://github.com/zifeo","followers_url":"https://api.github.com/users/zifeo/followers","following_url":"https://api.github.com/users/zifeo/following{/other_user}","gists_url":"https://api.github.com/users/zifeo/gists{/gist_id}","starred_url":"https://api.github.com/users/zifeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zifeo/subscriptions","organizations_url":"https://api.github.com/users/zifeo/orgs","repos_url":"https://api.github.com/users/zifeo/repos","events_url":"https://api.github.com/users/zifeo/events{/privacy}","received_events_url":"https://api.github.com/users/zifeo/received_events","type":"User","site_admin":false},"body":"This PR add the connection described in Pfister & Gerstner (2006) with some tests.\r\nThe work is based on the file @abigailm gave us and was supervised by @flinz.\r\n\r\n**Points to be discussed**\r\n\r\n*Nearest-spike pairing*\r\nThis would require a capping of the postsynaptic trace to a maximum of 1. This is not possible without changing the way that archiving_node updates `Kminus` and `triplet_Kminus`.\r\n\r\n*Tests involving the postsynaptic decay*\r\nThis would require access to the postsynaptic traces (states `Kminus` and `triplet_Kminus` of the archiving_node). This could be added. However, the correct decay of these states should be tested in the archiving_node itself.\r\n\r\n*Naming conventions*\r\nWe chose to stick to similar names across all variables, i.e. Kplus, Kminus, etc..\r\nIn addition `Kminus` might be named `K_minus` according the [naming conventions](https://nest.github.io/nest-simulator/variables_parameters_naming) but the name in archiving node is `Kminus` without the underscore. To keep coherence we used the same rule in the connection. However `triplet_var` is used as a prefix in archiving node whereas it might make more sense to use it as a suffix, i.e. `var_triplet`.\r\n\r\n*Inlining facilitate and depress*\r\nShould the `facilitate_` and `depress_` be inlined or not? Pros/cons?\r\n\r\n*Max weight parameters*\r\nOne could add additionally options to update the weights with either a hard maximal weight bound or multiplicative updating of weights. \r\n\r\n*Negative weight*\r\nCurrently the weights are set to a minimum of 0, so no negative weights are technically possible.\r\n\r\n*Parameters names*\r\nShould they be defined in `nest_names.h` or only the ones that are regularly re-used?","created_at":"2015-11-05T12:22:48Z","updated_at":"2015-11-05T12:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/150/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/150/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/150/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/23473799de6e433bc5f12c16a31bedbc115c6872","head":{"label":"zifeo:triplet_stdp","ref":"triplet_stdp","sha":"23473799de6e433bc5f12c16a31bedbc115c6872","user":{"login":"zifeo","id":9053709,"avatar_url":"https://avatars.githubusercontent.com/u/9053709?v=3","gravatar_id":"","url":"https://api.github.com/users/zifeo","html_url":"https://github.com/zifeo","followers_url":"https://api.github.com/users/zifeo/followers","following_url":"https://api.github.com/users/zifeo/following{/other_user}","gists_url":"https://api.github.com/users/zifeo/gists{/gist_id}","starred_url":"https://api.github.com/users/zifeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zifeo/subscriptions","organizations_url":"https://api.github.com/users/zifeo/orgs","repos_url":"https://api.github.com/users/zifeo/repos","events_url":"https://api.github.com/users/zifeo/events{/privacy}","received_events_url":"https://api.github.com/users/zifeo/received_events","type":"User","site_admin":false},"repo":{"id":42252307,"name":"nest-simulator","full_name":"zifeo/nest-simulator","owner":{"login":"zifeo","id":9053709,"avatar_url":"https://avatars.githubusercontent.com/u/9053709?v=3","gravatar_id":"","url":"https://api.github.com/users/zifeo","html_url":"https://github.com/zifeo","followers_url":"https://api.github.com/users/zifeo/followers","following_url":"https://api.github.com/users/zifeo/following{/other_user}","gists_url":"https://api.github.com/users/zifeo/gists{/gist_id}","starred_url":"https://api.github.com/users/zifeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zifeo/subscriptions","organizations_url":"https://api.github.com/users/zifeo/orgs","repos_url":"https://api.github.com/users/zifeo/repos","events_url":"https://api.github.com/users/zifeo/events{/privacy}","received_events_url":"https://api.github.com/users/zifeo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zifeo/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/zifeo/nest-simulator","forks_url":"https://api.github.com/repos/zifeo/nest-simulator/forks","keys_url":"https://api.github.com/repos/zifeo/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zifeo/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zifeo/nest-simulator/teams","hooks_url":"https://api.github.com/repos/zifeo/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/zifeo/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/zifeo/nest-simulator/events","assignees_url":"https://api.github.com/repos/zifeo/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/zifeo/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/zifeo/nest-simulator/tags","blobs_url":"https://api.github.com/repos/zifeo/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zifeo/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zifeo/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/zifeo/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zifeo/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/zifeo/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/zifeo/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/zifeo/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/zifeo/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/zifeo/nest-simulator/subscription","commits_url":"https://api.github.com/repos/zifeo/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/zifeo/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/zifeo/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/zifeo/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/zifeo/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/zifeo/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zifeo/nest-simulator/merges","archive_url":"https://api.github.com/repos/zifeo/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zifeo/nest-simulator/downloads","issues_url":"https://api.github.com/repos/zifeo/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/zifeo/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/zifeo/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/zifeo/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zifeo/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/zifeo/nest-simulator/releases{/id}","created_at":"2015-09-10T15:14:16Z","updated_at":"2015-09-10T15:14:19Z","pushed_at":"2015-11-05T10:45:08Z","git_url":"git://github.com/zifeo/nest-simulator.git","ssh_url":"git@github.com:zifeo/nest-simulator.git","clone_url":"https://github.com/zifeo/nest-simulator.git","svn_url":"https://github.com/zifeo/nest-simulator","homepage":null,"size":11110,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"349c72865ae715b67660b6cca05906be8d94f0d6","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","created_at":"2015-04-14T13:39:12Z","updated_at":"2015-11-04T12:02:52Z","pushed_at":"2015-11-04T16:20:15Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":19157,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"open_issues_count":40,"forks":52,"open_issues":40,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/150"},"html":{"href":"https://github.com/nest/nest-simulator/pull/150"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/150"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/23473799de6e433bc5f12c16a31bedbc115c6872"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":643,"deletions":0,"changed_files":5}}