{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/33","id":42383046,"html_url":"https://github.com/opscode-cookbooks/sql_server/pull/33","diff_url":"https://github.com/opscode-cookbooks/sql_server/pull/33.diff","patch_url":"https://github.com/opscode-cookbooks/sql_server/pull/33.patch","issue_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues/33","number":33,"state":"closed","locked":false,"title":"Support SQL Server 2012 and fix 2008R2 checksums","user":{"login":"tpetchel","id":7142397,"avatar_url":"https://avatars.githubusercontent.com/u/7142397?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetchel","html_url":"https://github.com/tpetchel","followers_url":"https://api.github.com/users/tpetchel/followers","following_url":"https://api.github.com/users/tpetchel/following{/other_user}","gists_url":"https://api.github.com/users/tpetchel/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetchel/subscriptions","organizations_url":"https://api.github.com/users/tpetchel/orgs","repos_url":"https://api.github.com/users/tpetchel/repos","events_url":"https://api.github.com/users/tpetchel/events{/privacy}","received_events_url":"https://api.github.com/users/tpetchel/received_events","type":"User","site_admin":false},"body":"* Delay evaluation of server package URL, checksum, and name so that it can be overwritten by specifying `node['sql_server']['version']` in a wrapper cookbook.\r\n* Use the version in the comment at the top of ConfigurationFile.ini. Otherwise, it always reads \"2008\", which is not always correct.\r\n* For SQL Server 2012, enable UpdateEnabled to be set in ConfigurationFile.ini. Use SQL's default value of True.\r\n* Update README to include references to SQL Server 2012 and how to specify the package to install.\r\n* Recursively set the `static_tcp_reg_key` Registry key. Otherwise, I get this error:\r\n```\r\n * Intermediate keys missing but recursive is set to false\r\n ================================================================================\r\n Error executing action `create` on resource 'registry_key[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Microsoft SQL Server\\MSSQL10_50.SQLEXPRESS\\MSSQLServer\\SuperSocketNetLib\\Tcp\\IPAll]'\r\n ================================================================================\r\n\r\n Chef::Exceptions::Win32RegNoRecursive\r\n -------------------------------------\r\n Intermediate keys missing but recursive is set to false\r\n\r\n Resource Declaration:\r\n ---------------------\r\n # In C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/sql_server/recipes/server.rb\r\n\r\n  56: registry_key static_tcp_reg_key do\r\n  57:   values [{ :name => 'TcpPort', :type => :string, :data => node['sql_server']['port'].to_s },\r\n  58:     { :name => 'TcpDynamicPorts', :type => :string, :data => '' }]\r\n  59:   notifies :restart, \"service[#{service_name}]\", :immediately\r\n  60: end\r\n  61:\r\n\r\n Compiled Resource:\r\n ------------------\r\n # Declared in C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/sql_server/recipes/server.rb:56:in `from_file'\r\n\r\n registry_key(\"HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Microsoft SQL Server\\MSSQL10_50.SQLEXPRESS\\MSSQLServer\\SuperSocketNetLib\\Tcp\\IPAll\") do\r\n   action [:create]\r\n   retries 0\r\n   retry_delay 2\r\n   default_guard_interpreter :default\r\n   architecture :machine\r\n   key \"HKEY_LOCAL_MACHINE\\\\SOFTWARE\\\\Microsoft\\\\Microsoft SQL Server\\\\MSSQL10_50.SQLEXPRESS\\\\MSSQLServer\\\\SuperSocketNetLib\\\\Tcp\\\\IPAll\"\r\n   values [{:name=>\"TcpPort\", :type=>:string, :data=>\"1433\"}, {:name=>\"TcpDynamicPorts\", :type=>:string, :data=>\"\"}]\r\n   unscrubbed_values [{:name=>\"TcpPort\", :type=>:string, :data=>\"1433\"}, {:name=>\"TcpDynamicPorts\", :type=>:string, :data=>\"\"}]\r\n   declared_type :registry_key\r\n   cookbook_name \"sql_server\"\r\n   recipe_name \"server\"\r\n end\r\n```\r\n* Fixed the checksum values for both x86 and x64 editions of SQL Server 2008R2 Express. Both were wrong.\r\n* Note: This cookbook continues to install SQL Server 2008 R2 Express by default.\r\n* Tested SQL Server 2008 R2 Express and SQL Server 2012 Express installs on a Windows Server 2012 R2 box.","created_at":"2015-08-13T18:31:17Z","updated_at":"2015-08-13T21:44:55Z","closed_at":"2015-08-13T21:44:55Z","merged_at":"2015-08-13T21:44:55Z","merge_commit_sha":"309d44163ce32346d58daa084595edb95681f7d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/33/commits","review_comments_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/33/comments","review_comment_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues/33/comments","statuses_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/statuses/fb6f88cec7287da8967409afaa10614180c8949a","head":{"label":"tpetchel:tp/support-2012","ref":"tp/support-2012","sha":"fb6f88cec7287da8967409afaa10614180c8949a","user":{"login":"tpetchel","id":7142397,"avatar_url":"https://avatars.githubusercontent.com/u/7142397?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetchel","html_url":"https://github.com/tpetchel","followers_url":"https://api.github.com/users/tpetchel/followers","following_url":"https://api.github.com/users/tpetchel/following{/other_user}","gists_url":"https://api.github.com/users/tpetchel/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetchel/subscriptions","organizations_url":"https://api.github.com/users/tpetchel/orgs","repos_url":"https://api.github.com/users/tpetchel/repos","events_url":"https://api.github.com/users/tpetchel/events{/privacy}","received_events_url":"https://api.github.com/users/tpetchel/received_events","type":"User","site_admin":false},"repo":{"id":40674459,"name":"sql_server","full_name":"tpetchel/sql_server","owner":{"login":"tpetchel","id":7142397,"avatar_url":"https://avatars.githubusercontent.com/u/7142397?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetchel","html_url":"https://github.com/tpetchel","followers_url":"https://api.github.com/users/tpetchel/followers","following_url":"https://api.github.com/users/tpetchel/following{/other_user}","gists_url":"https://api.github.com/users/tpetchel/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetchel/subscriptions","organizations_url":"https://api.github.com/users/tpetchel/orgs","repos_url":"https://api.github.com/users/tpetchel/repos","events_url":"https://api.github.com/users/tpetchel/events{/privacy}","received_events_url":"https://api.github.com/users/tpetchel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpetchel/sql_server","description":"Development repository for Chef Cookbook sql_server","fork":true,"url":"https://api.github.com/repos/tpetchel/sql_server","forks_url":"https://api.github.com/repos/tpetchel/sql_server/forks","keys_url":"https://api.github.com/repos/tpetchel/sql_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpetchel/sql_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpetchel/sql_server/teams","hooks_url":"https://api.github.com/repos/tpetchel/sql_server/hooks","issue_events_url":"https://api.github.com/repos/tpetchel/sql_server/issues/events{/number}","events_url":"https://api.github.com/repos/tpetchel/sql_server/events","assignees_url":"https://api.github.com/repos/tpetchel/sql_server/assignees{/user}","branches_url":"https://api.github.com/repos/tpetchel/sql_server/branches{/branch}","tags_url":"https://api.github.com/repos/tpetchel/sql_server/tags","blobs_url":"https://api.github.com/repos/tpetchel/sql_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpetchel/sql_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpetchel/sql_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpetchel/sql_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpetchel/sql_server/statuses/{sha}","languages_url":"https://api.github.com/repos/tpetchel/sql_server/languages","stargazers_url":"https://api.github.com/repos/tpetchel/sql_server/stargazers","contributors_url":"https://api.github.com/repos/tpetchel/sql_server/contributors","subscribers_url":"https://api.github.com/repos/tpetchel/sql_server/subscribers","subscription_url":"https://api.github.com/repos/tpetchel/sql_server/subscription","commits_url":"https://api.github.com/repos/tpetchel/sql_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpetchel/sql_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpetchel/sql_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpetchel/sql_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpetchel/sql_server/contents/{+path}","compare_url":"https://api.github.com/repos/tpetchel/sql_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpetchel/sql_server/merges","archive_url":"https://api.github.com/repos/tpetchel/sql_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpetchel/sql_server/downloads","issues_url":"https://api.github.com/repos/tpetchel/sql_server/issues{/number}","pulls_url":"https://api.github.com/repos/tpetchel/sql_server/pulls{/number}","milestones_url":"https://api.github.com/repos/tpetchel/sql_server/milestones{/number}","notifications_url":"https://api.github.com/repos/tpetchel/sql_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpetchel/sql_server/labels{/name}","releases_url":"https://api.github.com/repos/tpetchel/sql_server/releases{/id}","created_at":"2015-08-13T18:14:35Z","updated_at":"2015-08-13T18:14:35Z","pushed_at":"2015-08-13T18:43:46Z","git_url":"git://github.com/tpetchel/sql_server.git","ssh_url":"git@github.com:tpetchel/sql_server.git","clone_url":"https://github.com/tpetchel/sql_server.git","svn_url":"https://github.com/tpetchel/sql_server","homepage":"http://supermarket.chef.io/cookbooks/sql_server","size":531,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opscode-cookbooks:master","ref":"master","sha":"0be31708c812d698445694714d4e8b1f571d32ca","user":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?v=3","gravatar_id":"","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":3720920,"name":"sql_server","full_name":"opscode-cookbooks/sql_server","owner":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?v=3","gravatar_id":"","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode-cookbooks/sql_server","description":"Development repository for Chef Cookbook sql_server","fork":false,"url":"https://api.github.com/repos/opscode-cookbooks/sql_server","forks_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/forks","keys_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/teams","hooks_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/hooks","issue_events_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues/events{/number}","events_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/events","assignees_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/assignees{/user}","branches_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/branches{/branch}","tags_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/tags","blobs_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/languages","stargazers_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/stargazers","contributors_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/contributors","subscribers_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/subscribers","subscription_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/subscription","commits_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/contents/{+path}","compare_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/merges","archive_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/downloads","issues_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues{/number}","pulls_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/labels{/name}","releases_url":"https://api.github.com/repos/opscode-cookbooks/sql_server/releases{/id}","created_at":"2012-03-14T18:39:23Z","updated_at":"2015-08-13T07:25:27Z","pushed_at":"2015-08-13T21:44:55Z","git_url":"git://github.com/opscode-cookbooks/sql_server.git","ssh_url":"git@github.com:opscode-cookbooks/sql_server.git","clone_url":"https://github.com/opscode-cookbooks/sql_server.git","svn_url":"https://github.com/opscode-cookbooks/sql_server","homepage":"http://supermarket.chef.io/cookbooks/sql_server","size":531,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":14,"forks":55,"open_issues":14,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/33"},"html":{"href":"https://github.com/opscode-cookbooks/sql_server/pull/33"},"issue":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues/33"},"comments":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/opscode-cookbooks/sql_server/statuses/fb6f88cec7287da8967409afaa10614180c8949a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"someara","id":69068,"avatar_url":"https://avatars.githubusercontent.com/u/69068?v=3","gravatar_id":"","url":"https://api.github.com/users/someara","html_url":"https://github.com/someara","followers_url":"https://api.github.com/users/someara/followers","following_url":"https://api.github.com/users/someara/following{/other_user}","gists_url":"https://api.github.com/users/someara/gists{/gist_id}","starred_url":"https://api.github.com/users/someara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/someara/subscriptions","organizations_url":"https://api.github.com/users/someara/orgs","repos_url":"https://api.github.com/users/someara/repos","events_url":"https://api.github.com/users/someara/events{/privacy}","received_events_url":"https://api.github.com/users/someara/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":108,"deletions":34,"changed_files":5}}