{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/37090291","id":37090291,"diff_hunk":"@@ -867,9 +872,16 @@ private function count($filter, $base, $attr = null, $limit = null, $offset = nu\n \t\t\t$count = $this->countEntriesInSearchResults($sr, $limitPerPage, $continue);\n \t\t\t$counter += $count;\n \n-\t\t\t$this->processPagedSearchStatus($sr, $filter, $base, $count, $limitPerPage,\n+\t\t\t$hasMorePages = $this->processPagedSearchStatus($sr, $filter, $base, $count, $limitPerPage,\n \t\t\t\t\t\t\t\t\t\t$offset, $pagedSearchOK, $skipHandling);\n \t\t\t$offset += $limitPerPage;\n+\t\t\t/* ++ Fixing RHDS searches with pages with zero results ++\n+\t\t\t * Ignoring continue value got from countEntriesInSearchResults()\n+\t\t\t * previous implementation always got $continue equals false if\n+\t\t\t * page have 0 results.\n+\t\t\t * Continue now depends on $hasMorePages value\n+\t\t\t */\n+\t\t\t$continue = $pagedSearchOK && $hasMorePages;","path":"apps/user_ldap/lib/access.php","position":38,"original_position":38,"commit_id":"14e34ab8f07ed16660da7a9ece61c544f2d0e0c0","original_commit_id":"14e34ab8f07ed16660da7a9ece61c544f2d0e0c0","user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"body":"thus we can remove the third parameter from countEntriesInSearchResults, which would have brought bake the $continue value before (reference param). It should be the only usage of the method.","created_at":"2015-08-14T15:54:26Z","updated_at":"2015-08-14T15:54:26Z","html_url":"https://github.com/owncloud/core/pull/18294#discussion_r37090291","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/18294","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/37090291"},"html":{"href":"https://github.com/owncloud/core/pull/18294#discussion_r37090291"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/18294"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/18294","id":42378878,"html_url":"https://github.com/owncloud/core/pull/18294","diff_url":"https://github.com/owncloud/core/pull/18294.diff","patch_url":"https://github.com/owncloud/core/pull/18294.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/18294","number":18294,"state":"open","locked":false,"title":"Fix RHDS ldap paged search, Issue #17173","user":{"login":"esakol","id":1247100,"avatar_url":"https://avatars.githubusercontent.com/u/1247100?v=3","gravatar_id":"","url":"https://api.github.com/users/esakol","html_url":"https://github.com/esakol","followers_url":"https://api.github.com/users/esakol/followers","following_url":"https://api.github.com/users/esakol/following{/other_user}","gists_url":"https://api.github.com/users/esakol/gists{/gist_id}","starred_url":"https://api.github.com/users/esakol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esakol/subscriptions","organizations_url":"https://api.github.com/users/esakol/orgs","repos_url":"https://api.github.com/users/esakol/repos","events_url":"https://api.github.com/users/esakol/events{/privacy}","received_events_url":"https://api.github.com/users/esakol/received_events","type":"User","site_admin":false},"body":"Please,\r\n\r\nTake a look at the changes.\r\n\r\nFixes #17173","created_at":"2015-08-13T17:52:41Z","updated_at":"2015-08-14T15:54:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7d56a4a879541853a063c159c5c81e0880f5c8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/18294/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/18294/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/18294/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/14e34ab8f07ed16660da7a9ece61c544f2d0e0c0","head":{"label":"esakol:issue17173","ref":"issue17173","sha":"14e34ab8f07ed16660da7a9ece61c544f2d0e0c0","user":{"login":"esakol","id":1247100,"avatar_url":"https://avatars.githubusercontent.com/u/1247100?v=3","gravatar_id":"","url":"https://api.github.com/users/esakol","html_url":"https://github.com/esakol","followers_url":"https://api.github.com/users/esakol/followers","following_url":"https://api.github.com/users/esakol/following{/other_user}","gists_url":"https://api.github.com/users/esakol/gists{/gist_id}","starred_url":"https://api.github.com/users/esakol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esakol/subscriptions","organizations_url":"https://api.github.com/users/esakol/orgs","repos_url":"https://api.github.com/users/esakol/repos","events_url":"https://api.github.com/users/esakol/events{/privacy}","received_events_url":"https://api.github.com/users/esakol/received_events","type":"User","site_admin":false},"repo":{"id":40657127,"name":"core","full_name":"esakol/core","owner":{"login":"esakol","id":1247100,"avatar_url":"https://avatars.githubusercontent.com/u/1247100?v=3","gravatar_id":"","url":"https://api.github.com/users/esakol","html_url":"https://github.com/esakol","followers_url":"https://api.github.com/users/esakol/followers","following_url":"https://api.github.com/users/esakol/following{/other_user}","gists_url":"https://api.github.com/users/esakol/gists{/gist_id}","starred_url":"https://api.github.com/users/esakol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esakol/subscriptions","organizations_url":"https://api.github.com/users/esakol/orgs","repos_url":"https://api.github.com/users/esakol/repos","events_url":"https://api.github.com/users/esakol/events{/privacy}","received_events_url":"https://api.github.com/users/esakol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esakol/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/esakol/core","forks_url":"https://api.github.com/repos/esakol/core/forks","keys_url":"https://api.github.com/repos/esakol/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esakol/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esakol/core/teams","hooks_url":"https://api.github.com/repos/esakol/core/hooks","issue_events_url":"https://api.github.com/repos/esakol/core/issues/events{/number}","events_url":"https://api.github.com/repos/esakol/core/events","assignees_url":"https://api.github.com/repos/esakol/core/assignees{/user}","branches_url":"https://api.github.com/repos/esakol/core/branches{/branch}","tags_url":"https://api.github.com/repos/esakol/core/tags","blobs_url":"https://api.github.com/repos/esakol/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esakol/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esakol/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/esakol/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esakol/core/statuses/{sha}","languages_url":"https://api.github.com/repos/esakol/core/languages","stargazers_url":"https://api.github.com/repos/esakol/core/stargazers","contributors_url":"https://api.github.com/repos/esakol/core/contributors","subscribers_url":"https://api.github.com/repos/esakol/core/subscribers","subscription_url":"https://api.github.com/repos/esakol/core/subscription","commits_url":"https://api.github.com/repos/esakol/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/esakol/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/esakol/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/esakol/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/esakol/core/contents/{+path}","compare_url":"https://api.github.com/repos/esakol/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esakol/core/merges","archive_url":"https://api.github.com/repos/esakol/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esakol/core/downloads","issues_url":"https://api.github.com/repos/esakol/core/issues{/number}","pulls_url":"https://api.github.com/repos/esakol/core/pulls{/number}","milestones_url":"https://api.github.com/repos/esakol/core/milestones{/number}","notifications_url":"https://api.github.com/repos/esakol/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esakol/core/labels{/name}","releases_url":"https://api.github.com/repos/esakol/core/releases{/id}","created_at":"2015-08-13T12:17:18Z","updated_at":"2015-08-13T12:17:31Z","pushed_at":"2015-08-13T13:25:21Z","git_url":"git://github.com/esakol/core.git","ssh_url":"git@github.com:esakol/core.git","clone_url":"https://github.com/esakol/core.git","svn_url":"https://github.com/esakol/core","homepage":"https://owncloud.org/","size":179269,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"1f96fb3352ad43155586d6deae95bf889768ba05","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-08-14T14:01:39Z","pushed_at":"2015-08-14T14:54:26Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":1079059,"stargazers_count":3568,"watchers_count":3568,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1141,"mirror_url":null,"open_issues_count":1972,"forks":1141,"open_issues":1972,"watchers":3568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/18294"},"html":{"href":"https://github.com/owncloud/core/pull/18294"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/18294"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/18294/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/18294/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/18294/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/14e34ab8f07ed16660da7a9ece61c544f2d0e0c0"}}}}