{"action":"created","comment":{"url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/comments/42412124","id":42412124,"diff_hunk":"@@ -0,0 +1,14 @@\n+class PublicFilteredList\n+\n+  attr_reader :generic_files, :filters\n+\n+  def initialize(generic_files)\n+    @generic_files = generic_files\n+    @filters = []\n+  end\n+\n+  def filter\n+    @public_members ||= generic_files.reject{|gf| !gf.public?}","path":"app/models/public_filtered_list.rb","position":11,"original_position":11,"commit_id":"245ecae03a4ed651197f61f1c6639c2e34380be1","original_commit_id":"245ecae03a4ed651197f61f1c6639c2e34380be1","user":{"login":"awead","id":312085,"avatar_url":"https://avatars.githubusercontent.com/u/312085?v=3","gravatar_id":"","url":"https://api.github.com/users/awead","html_url":"https://github.com/awead","followers_url":"https://api.github.com/users/awead/followers","following_url":"https://api.github.com/users/awead/following{/other_user}","gists_url":"https://api.github.com/users/awead/gists{/gist_id}","starred_url":"https://api.github.com/users/awead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awead/subscriptions","organizations_url":"https://api.github.com/users/awead/orgs","repos_url":"https://api.github.com/users/awead/repos","events_url":"https://api.github.com/users/awead/events{/privacy}","received_events_url":"https://api.github.com/users/awead/received_events","type":"User","site_admin":false},"body":"doesn't public_members need an attr_reader?","created_at":"2015-10-19T19:02:00Z","updated_at":"2015-10-19T19:02:00Z","html_url":"https://github.com/psu-stewardship/scholarsphere/pull/207#discussion_r42412124","pull_request_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/comments/42412124"},"html":{"href":"https://github.com/psu-stewardship/scholarsphere/pull/207#discussion_r42412124"},"pull_request":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207","id":48099572,"html_url":"https://github.com/psu-stewardship/scholarsphere/pull/207","diff_url":"https://github.com/psu-stewardship/scholarsphere/pull/207.diff","patch_url":"https://github.com/psu-stewardship/scholarsphere/pull/207.patch","issue_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/207","number":207,"state":"open","locked":false,"title":"Adding filtered lists to allow an array of GenericFiles to be filtere…","user":{"login":"cam156","id":1599081,"avatar_url":"https://avatars.githubusercontent.com/u/1599081?v=3","gravatar_id":"","url":"https://api.github.com/users/cam156","html_url":"https://github.com/cam156","followers_url":"https://api.github.com/users/cam156/followers","following_url":"https://api.github.com/users/cam156/following{/other_user}","gists_url":"https://api.github.com/users/cam156/gists{/gist_id}","starred_url":"https://api.github.com/users/cam156/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cam156/subscriptions","organizations_url":"https://api.github.com/users/cam156/orgs","repos_url":"https://api.github.com/users/cam156/repos","events_url":"https://api.github.com/users/cam156/events{/privacy}","received_events_url":"https://api.github.com/users/cam156/received_events","type":"User","site_admin":false},"body":"…d based on visibility and resource type refs #205 \r\n\r\nThese FilteredLists can be used to add filtering need before a file is sen to share.  Implementing them as separate lists so they would be easy to test.\r\n\r\nIntending for the final answer to be something like:\r\nsend_list =   ResourceFilteredList.new(PublicFilteredList.new(files).filter).filter\r\n\r\nThere still needs to be an additional filter for not sending ones already sent to Share, but we have yet to define where that data is going to be stored.","created_at":"2015-10-19T17:12:01Z","updated_at":"2015-10-19T19:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b0274c83382d089b681fb3960fe8e395cd48422","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207/commits","review_comments_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207/comments","review_comment_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/207/comments","statuses_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/statuses/245ecae03a4ed651197f61f1c6639c2e34380be1","head":{"label":"psu-stewardship:scm_205","ref":"scm_205","sha":"245ecae03a4ed651197f61f1c6639c2e34380be1","user":{"login":"psu-stewardship","id":653493,"avatar_url":"https://avatars.githubusercontent.com/u/653493?v=3","gravatar_id":"","url":"https://api.github.com/users/psu-stewardship","html_url":"https://github.com/psu-stewardship","followers_url":"https://api.github.com/users/psu-stewardship/followers","following_url":"https://api.github.com/users/psu-stewardship/following{/other_user}","gists_url":"https://api.github.com/users/psu-stewardship/gists{/gist_id}","starred_url":"https://api.github.com/users/psu-stewardship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psu-stewardship/subscriptions","organizations_url":"https://api.github.com/users/psu-stewardship/orgs","repos_url":"https://api.github.com/users/psu-stewardship/repos","events_url":"https://api.github.com/users/psu-stewardship/events{/privacy}","received_events_url":"https://api.github.com/users/psu-stewardship/received_events","type":"Organization","site_admin":false},"repo":{"id":2481963,"name":"scholarsphere","full_name":"psu-stewardship/scholarsphere","owner":{"login":"psu-stewardship","id":653493,"avatar_url":"https://avatars.githubusercontent.com/u/653493?v=3","gravatar_id":"","url":"https://api.github.com/users/psu-stewardship","html_url":"https://github.com/psu-stewardship","followers_url":"https://api.github.com/users/psu-stewardship/followers","following_url":"https://api.github.com/users/psu-stewardship/following{/other_user}","gists_url":"https://api.github.com/users/psu-stewardship/gists{/gist_id}","starred_url":"https://api.github.com/users/psu-stewardship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psu-stewardship/subscriptions","organizations_url":"https://api.github.com/users/psu-stewardship/orgs","repos_url":"https://api.github.com/users/psu-stewardship/repos","events_url":"https://api.github.com/users/psu-stewardship/events{/privacy}","received_events_url":"https://api.github.com/users/psu-stewardship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/psu-stewardship/scholarsphere","description":"A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":false,"url":"https://api.github.com/repos/psu-stewardship/scholarsphere","forks_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/forks","keys_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/teams","hooks_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/hooks","issue_events_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/events{/number}","events_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/events","assignees_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/assignees{/user}","branches_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/branches{/branch}","tags_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/tags","blobs_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/languages","stargazers_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/stargazers","contributors_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/contributors","subscribers_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/subscribers","subscription_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/subscription","commits_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/contents/{+path}","compare_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/merges","archive_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/downloads","issues_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues{/number}","pulls_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/labels{/name}","releases_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/releases{/id}","created_at":"2011-09-29T13:12:23Z","updated_at":"2015-10-15T19:55:39Z","pushed_at":"2015-10-19T17:12:01Z","git_url":"git://github.com/psu-stewardship/scholarsphere.git","ssh_url":"git@github.com:psu-stewardship/scholarsphere.git","clone_url":"https://github.com/psu-stewardship/scholarsphere.git","svn_url":"https://github.com/psu-stewardship/scholarsphere","homepage":"","size":103190,"stargazers_count":52,"watchers_count":52,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":52,"default_branch":"develop"}},"base":{"label":"psu-stewardship:develop","ref":"develop","sha":"e8cff3780c3eef665ab26c9aeabd4978ca07169e","user":{"login":"psu-stewardship","id":653493,"avatar_url":"https://avatars.githubusercontent.com/u/653493?v=3","gravatar_id":"","url":"https://api.github.com/users/psu-stewardship","html_url":"https://github.com/psu-stewardship","followers_url":"https://api.github.com/users/psu-stewardship/followers","following_url":"https://api.github.com/users/psu-stewardship/following{/other_user}","gists_url":"https://api.github.com/users/psu-stewardship/gists{/gist_id}","starred_url":"https://api.github.com/users/psu-stewardship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psu-stewardship/subscriptions","organizations_url":"https://api.github.com/users/psu-stewardship/orgs","repos_url":"https://api.github.com/users/psu-stewardship/repos","events_url":"https://api.github.com/users/psu-stewardship/events{/privacy}","received_events_url":"https://api.github.com/users/psu-stewardship/received_events","type":"Organization","site_admin":false},"repo":{"id":2481963,"name":"scholarsphere","full_name":"psu-stewardship/scholarsphere","owner":{"login":"psu-stewardship","id":653493,"avatar_url":"https://avatars.githubusercontent.com/u/653493?v=3","gravatar_id":"","url":"https://api.github.com/users/psu-stewardship","html_url":"https://github.com/psu-stewardship","followers_url":"https://api.github.com/users/psu-stewardship/followers","following_url":"https://api.github.com/users/psu-stewardship/following{/other_user}","gists_url":"https://api.github.com/users/psu-stewardship/gists{/gist_id}","starred_url":"https://api.github.com/users/psu-stewardship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psu-stewardship/subscriptions","organizations_url":"https://api.github.com/users/psu-stewardship/orgs","repos_url":"https://api.github.com/users/psu-stewardship/repos","events_url":"https://api.github.com/users/psu-stewardship/events{/privacy}","received_events_url":"https://api.github.com/users/psu-stewardship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/psu-stewardship/scholarsphere","description":"A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":false,"url":"https://api.github.com/repos/psu-stewardship/scholarsphere","forks_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/forks","keys_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/teams","hooks_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/hooks","issue_events_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/events{/number}","events_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/events","assignees_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/assignees{/user}","branches_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/branches{/branch}","tags_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/tags","blobs_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/languages","stargazers_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/stargazers","contributors_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/contributors","subscribers_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/subscribers","subscription_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/subscription","commits_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/contents/{+path}","compare_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/merges","archive_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/downloads","issues_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues{/number}","pulls_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/labels{/name}","releases_url":"https://api.github.com/repos/psu-stewardship/scholarsphere/releases{/id}","created_at":"2011-09-29T13:12:23Z","updated_at":"2015-10-15T19:55:39Z","pushed_at":"2015-10-19T17:12:01Z","git_url":"git://github.com/psu-stewardship/scholarsphere.git","ssh_url":"git@github.com:psu-stewardship/scholarsphere.git","clone_url":"https://github.com/psu-stewardship/scholarsphere.git","svn_url":"https://github.com/psu-stewardship/scholarsphere","homepage":"","size":103190,"stargazers_count":52,"watchers_count":52,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":52,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207"},"html":{"href":"https://github.com/psu-stewardship/scholarsphere/pull/207"},"issue":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/207"},"comments":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/psu-stewardship/scholarsphere/statuses/245ecae03a4ed651197f61f1c6639c2e34380be1"}}}}