{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/comments/41003939","id":41003939,"diff_hunk":"@@ -0,0 +1,33 @@\n+<p>\n+    Using upper case literal suffixes removes the potential ambiguity between \"1\" (digit 1) and \"l\" (letter el) for declaring literals.","path":"src/SonarLint/Rules.Description/S818.html","position":2,"original_position":2,"commit_id":"d3767cc752106ecae3708c9adb9ec252f4f6ef18","original_commit_id":"d3767cc752106ecae3708c9adb9ec252f4f6ef18","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"body":"This doesn't explain why \"u\", \"d\", and \"f\" should be upper-case\r\ne.g. \"For consistency, upper-case all literal suffixes.\"","created_at":"2015-10-02T09:19:56Z","updated_at":"2015-10-02T09:19:56Z","html_url":"https://github.com/SonarSource/sonarlint-vs/pull/418#discussion_r41003939","pull_request_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/comments/41003939"},"html":{"href":"https://github.com/SonarSource/sonarlint-vs/pull/418#discussion_r41003939"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418","id":45408926,"html_url":"https://github.com/SonarSource/sonarlint-vs/pull/418","diff_url":"https://github.com/SonarSource/sonarlint-vs/pull/418.diff","patch_url":"https://github.com/SonarSource/sonarlint-vs/pull/418.patch","issue_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues/418","number":418,"state":"open","locked":false,"title":"Issue #366 - Literal suffixes should be upper case","user":{"login":"tvsonar","id":11485373,"avatar_url":"https://avatars.githubusercontent.com/u/11485373?v=3","gravatar_id":"","url":"https://api.github.com/users/tvsonar","html_url":"https://github.com/tvsonar","followers_url":"https://api.github.com/users/tvsonar/followers","following_url":"https://api.github.com/users/tvsonar/following{/other_user}","gists_url":"https://api.github.com/users/tvsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/tvsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvsonar/subscriptions","organizations_url":"https://api.github.com/users/tvsonar/orgs","repos_url":"https://api.github.com/users/tvsonar/repos","events_url":"https://api.github.com/users/tvsonar/events{/privacy}","received_events_url":"https://api.github.com/users/tvsonar/received_events","type":"User","site_admin":false},"body":"Fixes #366 ","created_at":"2015-09-18T13:57:06Z","updated_at":"2015-10-02T09:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5490b9e947a0b468c6c0430b7b447cec07a0d541","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues/418/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/statuses/d3767cc752106ecae3708c9adb9ec252f4f6ef18","head":{"label":"tvsonar:upper-literal-suffix","ref":"upper-literal-suffix","sha":"d3767cc752106ecae3708c9adb9ec252f4f6ef18","user":{"login":"tvsonar","id":11485373,"avatar_url":"https://avatars.githubusercontent.com/u/11485373?v=3","gravatar_id":"","url":"https://api.github.com/users/tvsonar","html_url":"https://github.com/tvsonar","followers_url":"https://api.github.com/users/tvsonar/followers","following_url":"https://api.github.com/users/tvsonar/following{/other_user}","gists_url":"https://api.github.com/users/tvsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/tvsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvsonar/subscriptions","organizations_url":"https://api.github.com/users/tvsonar/orgs","repos_url":"https://api.github.com/users/tvsonar/repos","events_url":"https://api.github.com/users/tvsonar/events{/privacy}","received_events_url":"https://api.github.com/users/tvsonar/received_events","type":"User","site_admin":false},"repo":{"id":35810200,"name":"sonarlint-vs","full_name":"tvsonar/sonarlint-vs","owner":{"login":"tvsonar","id":11485373,"avatar_url":"https://avatars.githubusercontent.com/u/11485373?v=3","gravatar_id":"","url":"https://api.github.com/users/tvsonar","html_url":"https://github.com/tvsonar","followers_url":"https://api.github.com/users/tvsonar/followers","following_url":"https://api.github.com/users/tvsonar/following{/other_user}","gists_url":"https://api.github.com/users/tvsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/tvsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvsonar/subscriptions","organizations_url":"https://api.github.com/users/tvsonar/orgs","repos_url":"https://api.github.com/users/tvsonar/repos","events_url":"https://api.github.com/users/tvsonar/events{/privacy}","received_events_url":"https://api.github.com/users/tvsonar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tvsonar/sonarlint-vs","description":"","fork":true,"url":"https://api.github.com/repos/tvsonar/sonarlint-vs","forks_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/forks","keys_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/teams","hooks_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/hooks","issue_events_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/issues/events{/number}","events_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/events","assignees_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/assignees{/user}","branches_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/branches{/branch}","tags_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/tags","blobs_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/statuses/{sha}","languages_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/languages","stargazers_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/stargazers","contributors_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/contributors","subscribers_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/subscribers","subscription_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/subscription","commits_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/contents/{+path}","compare_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/merges","archive_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/downloads","issues_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/issues{/number}","pulls_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/pulls{/number}","milestones_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/milestones{/number}","notifications_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/labels{/name}","releases_url":"https://api.github.com/repos/tvsonar/sonarlint-vs/releases{/id}","created_at":"2015-05-18T09:55:28Z","updated_at":"2015-07-15T06:19:31Z","pushed_at":"2015-10-02T08:04:57Z","git_url":"git://github.com/tvsonar/sonarlint-vs.git","ssh_url":"git@github.com:tvsonar/sonarlint-vs.git","clone_url":"https://github.com/tvsonar/sonarlint-vs.git","svn_url":"https://github.com/tvsonar/sonarlint-vs","homepage":null,"size":63318,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"ac994dc5ea7506b7843366a7fd87544dab4c74fa","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":33920958,"name":"sonarlint-vs","full_name":"SonarSource/sonarlint-vs","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonarlint-vs","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonarlint-vs","forks_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/forks","keys_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/events","assignees_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/merges","archive_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonarlint-vs/releases{/id}","created_at":"2015-04-14T08:51:34Z","updated_at":"2015-09-30T16:51:48Z","pushed_at":"2015-10-02T08:04:57Z","git_url":"git://github.com/SonarSource/sonarlint-vs.git","ssh_url":"git@github.com:SonarSource/sonarlint-vs.git","clone_url":"https://github.com/SonarSource/sonarlint-vs.git","svn_url":"https://github.com/SonarSource/sonarlint-vs","homepage":"http://vs.sonarlint.org/","size":64571,"stargazers_count":31,"watchers_count":31,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":106,"forks":16,"open_issues":106,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418"},"html":{"href":"https://github.com/SonarSource/sonarlint-vs/pull/418"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues/418"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonarlint-vs/statuses/d3767cc752106ecae3708c9adb9ec252f4f6ef18"}}}}