{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/5074","labels_url":"https://api.github.com/repos/ceph/ceph/issues/5074/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/5074/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/5074/events","html_url":"https://github.com/ceph/ceph/pull/5074","id":90902936,"number":5074,"title":"mds: fix mds crash when mds_max_log_events smaller.","user":{"login":"majianpeng","id":1230551,"avatar_url":"https://avatars.githubusercontent.com/u/1230551?v=3","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/cephfs","name":"cephfs","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-25T09:09:28Z","updated_at":"2015-06-29T11:24:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/5074","html_url":"https://github.com/ceph/ceph/pull/5074","diff_url":"https://github.com/ceph/ceph/pull/5074.diff","patch_url":"https://github.com/ceph/ceph/pull/5074.patch"},"body":"If 'mds max log events' small, it met this bug:\r\n\r\nmds/journal.cc: 155: FAILED assert(ls != this)\r\n ceph version 9.0.1-1117-gb0dc971\r\n(b0dc97198a45791c8b9661d4be8e531e63202005)\r\n 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char\r\nconst*)+0x80) [0x16ef7bf]\r\n 2: (LogSegment::try_to_expire(MDS*,\r\nC_GatherBuilderBase<MDSInternalContextBase, MDSGather>&, int)+0x1925)\r\n[0x15475e5]\r\n 3: (MDLog::try_expire(LogSegment*, int)+0x66) [0x14c50a0]\r\n 4: (MDLog::trim(int)+0xd67) [0x14c4511]\r\n 5: (MDS::tick()+0x265) [0x1146e0b]\r\n 6: (MDS::C_MDS_Tick::finish(int)+0x32) [0x11693b2]\r\n 7: (Context::complete(int)+0x27) [0x11611a7]\r\n 8: (MDSInternalContextBase::complete(int)+0x1a4) [0x14977fa]\r\n 9: (SafeTimer::timer_thread()+0x37a) [0x16e28fa]\r\n 10: (SafeTimerThread::entry()+0x1c) [0x16e3c56]\r\n 11: (Thread::entry_wrapper()+0xa8) [0x16df0ee]\r\n 12: (Thread::_entry_func(void*)+0x18) [0x16df03c]\r\n 13: /lib64/libpthread.so.0() [0x30c9c07555]\r\n 14: (clone()+0x6d) [0x30c9901f3d]\r\n\r\nLike mds asok command: flush journal, if there is only one segment, we\r\nstart a new segment to avoid this. But expect mds is stopping.\r\n\r\nSigned-off-by: Jianpeng Ma <jianpeng.ma@intel.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/116620848","html_url":"https://github.com/ceph/ceph/pull/5074#issuecomment-116620848","issue_url":"https://api.github.com/repos/ceph/ceph/issues/5074","id":116620848,"user":{"login":"gregsfortytwo","id":908479,"avatar_url":"https://avatars.githubusercontent.com/u/908479?v=3","gravatar_id":"","url":"https://api.github.com/users/gregsfortytwo","html_url":"https://github.com/gregsfortytwo","followers_url":"https://api.github.com/users/gregsfortytwo/followers","following_url":"https://api.github.com/users/gregsfortytwo/following{/other_user}","gists_url":"https://api.github.com/users/gregsfortytwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsfortytwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsfortytwo/subscriptions","organizations_url":"https://api.github.com/users/gregsfortytwo/orgs","repos_url":"https://api.github.com/users/gregsfortytwo/repos","events_url":"https://api.github.com/users/gregsfortytwo/events{/privacy}","received_events_url":"https://api.github.com/users/gregsfortytwo/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T11:24:08Z","updated_at":"2015-06-29T11:24:08Z","body":"Yeah, this looks fine to me. Can you change the commit messages so none of them are over 80 characters in a line, please? (They're getting cut off in the github interface and won't play nice with standard terminals.)"}}