{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/comments/46403286","id":46403286,"diff_hunk":"@@ -1,21 +1,115 @@\n /* globals describe, it, expect */\n var Rx = require('../../dist/cjs/Rx');\n var Observable = Rx.Observable;\n-var Promise = require('promise');\n \n describe('Observable.fromPromise', function () {\n-  it('should emit one value from that promise', function (done) {\n+  it('should emit one value from a resolved promise', function (done) {\n     var promise = Promise.resolve(42);\n     Observable.fromPromise(promise)\n       .subscribe(function (x) {\n         expect(x).toBe(42);\n-      }, null,\n+      }, done.fail,\n       function (x) {\n         expect(x).toBe(undefined);","path":"spec/observables/from-promise-spec.js","position":16,"original_position":16,"commit_id":"c1a724b043136a5a46ee730d87d8f66c03be4ead","original_commit_id":"c1a724b043136a5a46ee730d87d8f66c03be4ead","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"body":"Did that exist? Ew ugly","created_at":"2015-12-02T11:23:28Z","updated_at":"2015-12-02T11:23:28Z","html_url":"https://github.com/ReactiveX/RxJS/pull/768#discussion_r46403286","pull_request_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/comments/46403286"},"html":{"href":"https://github.com/ReactiveX/RxJS/pull/768#discussion_r46403286"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768","id":51583738,"html_url":"https://github.com/ReactiveX/RxJS/pull/768","diff_url":"https://github.com/ReactiveX/RxJS/pull/768.diff","patch_url":"https://github.com/ReactiveX/RxJS/pull/768.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/768","number":768,"state":"open","locked":false,"title":"test(PromiseObservable): add more tests for fromPromise operator","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"body":"Add more tests to increase test coverage of fromPromise operator (PromiseObservable.create).","created_at":"2015-11-23T21:35:55Z","updated_at":"2015-12-02T11:23:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59282c33f7806bdd8f9d4661ad509897d874ac67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/768/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJS/statuses/c1a724b043136a5a46ee730d87d8f66c03be4ead","head":{"label":"staltz:tests-from-promise","ref":"tests-from-promise","sha":"c1a724b043136a5a46ee730d87d8f66c03be4ead","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"repo":{"id":39303190,"name":"RxJSNext","full_name":"staltz/RxJSNext","owner":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/staltz/RxJSNext","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/staltz/RxJSNext","forks_url":"https://api.github.com/repos/staltz/RxJSNext/forks","keys_url":"https://api.github.com/repos/staltz/RxJSNext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staltz/RxJSNext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staltz/RxJSNext/teams","hooks_url":"https://api.github.com/repos/staltz/RxJSNext/hooks","issue_events_url":"https://api.github.com/repos/staltz/RxJSNext/issues/events{/number}","events_url":"https://api.github.com/repos/staltz/RxJSNext/events","assignees_url":"https://api.github.com/repos/staltz/RxJSNext/assignees{/user}","branches_url":"https://api.github.com/repos/staltz/RxJSNext/branches{/branch}","tags_url":"https://api.github.com/repos/staltz/RxJSNext/tags","blobs_url":"https://api.github.com/repos/staltz/RxJSNext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staltz/RxJSNext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staltz/RxJSNext/git/refs{/sha}","trees_url":"https://api.github.com/repos/staltz/RxJSNext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staltz/RxJSNext/statuses/{sha}","languages_url":"https://api.github.com/repos/staltz/RxJSNext/languages","stargazers_url":"https://api.github.com/repos/staltz/RxJSNext/stargazers","contributors_url":"https://api.github.com/repos/staltz/RxJSNext/contributors","subscribers_url":"https://api.github.com/repos/staltz/RxJSNext/subscribers","subscription_url":"https://api.github.com/repos/staltz/RxJSNext/subscription","commits_url":"https://api.github.com/repos/staltz/RxJSNext/commits{/sha}","git_commits_url":"https://api.github.com/repos/staltz/RxJSNext/git/commits{/sha}","comments_url":"https://api.github.com/repos/staltz/RxJSNext/comments{/number}","issue_comment_url":"https://api.github.com/repos/staltz/RxJSNext/issues/comments{/number}","contents_url":"https://api.github.com/repos/staltz/RxJSNext/contents/{+path}","compare_url":"https://api.github.com/repos/staltz/RxJSNext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staltz/RxJSNext/merges","archive_url":"https://api.github.com/repos/staltz/RxJSNext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staltz/RxJSNext/downloads","issues_url":"https://api.github.com/repos/staltz/RxJSNext/issues{/number}","pulls_url":"https://api.github.com/repos/staltz/RxJSNext/pulls{/number}","milestones_url":"https://api.github.com/repos/staltz/RxJSNext/milestones{/number}","notifications_url":"https://api.github.com/repos/staltz/RxJSNext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staltz/RxJSNext/labels{/name}","releases_url":"https://api.github.com/repos/staltz/RxJSNext/releases{/id}","created_at":"2015-07-18T15:40:11Z","updated_at":"2015-11-13T08:30:36Z","pushed_at":"2015-12-02T11:13:16Z","git_url":"git://github.com/staltz/RxJSNext.git","ssh_url":"git@github.com:staltz/RxJSNext.git","clone_url":"https://github.com/staltz/RxJSNext.git","svn_url":"https://github.com/staltz/RxJSNext","homepage":null,"size":3372,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"ecdd41bde9fd7d28980f104ec1e8d0bf49399ff2","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"RxJS","full_name":"ReactiveX/RxJS","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJS","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJS","forks_url":"https://api.github.com/repos/ReactiveX/RxJS/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJS/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJS/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJS/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJS/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJS/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJS/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJS/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJS/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJS/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJS/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJS/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJS/releases{/id}","created_at":"2015-03-15T06:17:10Z","updated_at":"2015-12-02T02:36:52Z","pushed_at":"2015-12-02T08:24:54Z","git_url":"git://github.com/ReactiveX/RxJS.git","ssh_url":"git@github.com:ReactiveX/RxJS.git","clone_url":"https://github.com/ReactiveX/RxJS.git","svn_url":"https://github.com/ReactiveX/RxJS","homepage":null,"size":6032,"stargazers_count":711,"watchers_count":711,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":48,"forks":72,"open_issues":48,"watchers":711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768"},"html":{"href":"https://github.com/ReactiveX/RxJS/pull/768"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJS/issues/768"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJS/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJS/statuses/c1a724b043136a5a46ee730d87d8f66c03be4ead"}}}}