{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/39433078","id":39433078,"diff_hunk":"@@ -841,6 +844,10 @@ pub fn rustc_optgroups() -> Vec<RustcOptGroup> {\n                       `hir,typed` (HIR with types for each node).\",\n                      \"TYPE\"),\n         opt::opt_u(\"\", \"show-span\", \"Show spans for compiler debugging\", \"expr|pat|ty\"),\n+        opt::include_u(\"\", \"include-arguments-from\",\n+                       \"Read additional arguments from the given FILE or the \\\n+                        standard input if FILE is `-`. Arguments must be \\\n+                        separated by \\\\0.\", \"FILE\", b'\\0'),","path":"src/librustc/session/config.rs","position":17,"original_position":17,"commit_id":"35cde39bbe86bb9c1285cc48285442b9f14c88cc","original_commit_id":"35cde39bbe86bb9c1285cc48285442b9f14c88cc","user":{"login":"TimNN","id":1178249,"avatar_url":"https://avatars.githubusercontent.com/u/1178249?v=3","gravatar_id":"","url":"https://api.github.com/users/TimNN","html_url":"https://github.com/TimNN","followers_url":"https://api.github.com/users/TimNN/followers","following_url":"https://api.github.com/users/TimNN/following{/other_user}","gists_url":"https://api.github.com/users/TimNN/gists{/gist_id}","starred_url":"https://api.github.com/users/TimNN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimNN/subscriptions","organizations_url":"https://api.github.com/users/TimNN/orgs","repos_url":"https://api.github.com/users/TimNN/repos","events_url":"https://api.github.com/users/TimNN/events{/privacy}","received_events_url":"https://api.github.com/users/TimNN/received_events","type":"User","site_admin":false},"body":"`\\0` was mentioned by @huonw in rust-lang/cargo#1241, which is why I choose to use it, but I can change that easily if required.","created_at":"2015-09-14T19:02:57Z","updated_at":"2015-09-14T19:02:57Z","html_url":"https://github.com/rust-lang/rust/pull/28391#discussion_r39433078","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/28391","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/39433078"},"html":{"href":"https://github.com/rust-lang/rust/pull/28391#discussion_r39433078"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28391"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/28391","id":44875546,"html_url":"https://github.com/rust-lang/rust/pull/28391","diff_url":"https://github.com/rust-lang/rust/pull/28391.diff","patch_url":"https://github.com/rust-lang/rust/pull/28391.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/28391","number":28391,"state":"open","locked":false,"title":"support reading rustc arguments from a file","user":{"login":"TimNN","id":1178249,"avatar_url":"https://avatars.githubusercontent.com/u/1178249?v=3","gravatar_id":"","url":"https://api.github.com/users/TimNN","html_url":"https://github.com/TimNN","followers_url":"https://api.github.com/users/TimNN/followers","following_url":"https://api.github.com/users/TimNN/following{/other_user}","gists_url":"https://api.github.com/users/TimNN/gists{/gist_id}","starred_url":"https://api.github.com/users/TimNN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimNN/subscriptions","organizations_url":"https://api.github.com/users/TimNN/orgs","repos_url":"https://api.github.com/users/TimNN/repos","events_url":"https://api.github.com/users/TimNN/events{/privacy}","received_events_url":"https://api.github.com/users/TimNN/received_events","type":"User","site_admin":false},"body":"Add an unstable (for now) flag to rustc (--include-arguments-from FILE) which causes rustc to read additional arguments (\\0 separated) from the specified FILE or stdin if FILE is '-'.\r\n\r\nI consider this pull request still a work-in-progress, because it's currently lacking any kind of test, but I wanted to publish it now to get some feedback, mainly on whether the current approach is the correct one and if this kind of change would require an RFC.\r\n\r\nThe pull request was inspired by rust-lang/cargo#1241.","created_at":"2015-09-13T16:17:22Z","updated_at":"2015-09-14T19:02:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"289daf039b52dab917d27386caba9f51a54b2056","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/28391/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/28391/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/28391/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/35cde39bbe86bb9c1285cc48285442b9f14c88cc","head":{"label":"TimNN:include-arguments-from","ref":"include-arguments-from","sha":"35cde39bbe86bb9c1285cc48285442b9f14c88cc","user":{"login":"TimNN","id":1178249,"avatar_url":"https://avatars.githubusercontent.com/u/1178249?v=3","gravatar_id":"","url":"https://api.github.com/users/TimNN","html_url":"https://github.com/TimNN","followers_url":"https://api.github.com/users/TimNN/followers","following_url":"https://api.github.com/users/TimNN/following{/other_user}","gists_url":"https://api.github.com/users/TimNN/gists{/gist_id}","starred_url":"https://api.github.com/users/TimNN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimNN/subscriptions","organizations_url":"https://api.github.com/users/TimNN/orgs","repos_url":"https://api.github.com/users/TimNN/repos","events_url":"https://api.github.com/users/TimNN/events{/privacy}","received_events_url":"https://api.github.com/users/TimNN/received_events","type":"User","site_admin":false},"repo":{"id":34207567,"name":"rust","full_name":"TimNN/rust","owner":{"login":"TimNN","id":1178249,"avatar_url":"https://avatars.githubusercontent.com/u/1178249?v=3","gravatar_id":"","url":"https://api.github.com/users/TimNN","html_url":"https://github.com/TimNN","followers_url":"https://api.github.com/users/TimNN/followers","following_url":"https://api.github.com/users/TimNN/following{/other_user}","gists_url":"https://api.github.com/users/TimNN/gists{/gist_id}","starred_url":"https://api.github.com/users/TimNN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimNN/subscriptions","organizations_url":"https://api.github.com/users/TimNN/orgs","repos_url":"https://api.github.com/users/TimNN/repos","events_url":"https://api.github.com/users/TimNN/events{/privacy}","received_events_url":"https://api.github.com/users/TimNN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimNN/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/TimNN/rust","forks_url":"https://api.github.com/repos/TimNN/rust/forks","keys_url":"https://api.github.com/repos/TimNN/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimNN/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimNN/rust/teams","hooks_url":"https://api.github.com/repos/TimNN/rust/hooks","issue_events_url":"https://api.github.com/repos/TimNN/rust/issues/events{/number}","events_url":"https://api.github.com/repos/TimNN/rust/events","assignees_url":"https://api.github.com/repos/TimNN/rust/assignees{/user}","branches_url":"https://api.github.com/repos/TimNN/rust/branches{/branch}","tags_url":"https://api.github.com/repos/TimNN/rust/tags","blobs_url":"https://api.github.com/repos/TimNN/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimNN/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimNN/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimNN/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimNN/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/TimNN/rust/languages","stargazers_url":"https://api.github.com/repos/TimNN/rust/stargazers","contributors_url":"https://api.github.com/repos/TimNN/rust/contributors","subscribers_url":"https://api.github.com/repos/TimNN/rust/subscribers","subscription_url":"https://api.github.com/repos/TimNN/rust/subscription","commits_url":"https://api.github.com/repos/TimNN/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimNN/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimNN/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimNN/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimNN/rust/contents/{+path}","compare_url":"https://api.github.com/repos/TimNN/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimNN/rust/merges","archive_url":"https://api.github.com/repos/TimNN/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimNN/rust/downloads","issues_url":"https://api.github.com/repos/TimNN/rust/issues{/number}","pulls_url":"https://api.github.com/repos/TimNN/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/TimNN/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/TimNN/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimNN/rust/labels{/name}","releases_url":"https://api.github.com/repos/TimNN/rust/releases{/id}","created_at":"2015-04-19T13:24:42Z","updated_at":"2015-04-19T13:25:07Z","pushed_at":"2015-09-13T18:16:58Z","git_url":"git://github.com/TimNN/rust.git","ssh_url":"git@github.com:TimNN/rust.git","clone_url":"https://github.com/TimNN/rust.git","svn_url":"https://github.com/TimNN/rust","homepage":"http://www.rust-lang.org","size":316441,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"9040b06ed28d37022d7c5135a6809aba951a243e","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-09-14T18:01:33Z","pushed_at":"2015-09-14T18:54:03Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":675923,"stargazers_count":13337,"watchers_count":13337,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2586,"mirror_url":null,"open_issues_count":2246,"forks":2586,"open_issues":2246,"watchers":13337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28391"},"html":{"href":"https://github.com/rust-lang/rust/pull/28391"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28391"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28391/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28391/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28391/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/35cde39bbe86bb9c1285cc48285442b9f14c88cc"}}}}