{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/45545469","id":45545469,"diff_hunk":"@@ -331,7 +340,9 @@ void SpawnPassenger(Actor passenger)\n \t\t\t\tw.Add(passenger);\n \t\t\t\tpassenger.Trait<IPositionable>().SetPosition(passenger, self.Location);\n \n-\t\t\t\t// TODO: this won't work well for >1 actor as they should move towards the next enterable (sub) cell instead\n+\t\t\t\tvar mobile = passenger.TraitOrDefault<Mobile>();","path":"OpenRA.Mods.Common/Traits/Cargo.cs","position":28,"original_position":28,"commit_id":"15b2885464919bd817c2dc9b5fe599afc457908c","original_commit_id":"15b2885464919bd817c2dc9b5fe599afc457908c","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars.githubusercontent.com/u/167819?v=3","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Can you use `OnNotifyBlockingMove` instead?  Hardcoding mobile references through unrelated code kind of sucks.","created_at":"2015-11-21T12:26:20Z","updated_at":"2015-11-21T12:26:20Z","html_url":"https://github.com/OpenRA/OpenRA/pull/10041#discussion_r45545469","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/45545469"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/10041#discussion_r45545469"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041","id":51340327,"html_url":"https://github.com/OpenRA/OpenRA/pull/10041","diff_url":"https://github.com/OpenRA/OpenRA/pull/10041.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/10041.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10041","number":10041,"state":"open","locked":false,"title":"Unload passengers / cargo on death","user":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"body":"Bit hacky approach, works by nudging passengers on exit so they don't bunch up.\r\n\r\nThe changes in EnterTransport will cancel any of the passengers activity, since mobile will discard nudges if not idle.\r\n\r\nKills any cargo it can't unload (when in water etc)\r\n\r\nEdit:\r\nNo changes in EnterTransport, added a check in Enter to move on to the next activity and don't wait for the next tick. Also use Mobile.Nudge instead of INotifyBlockingMove.OnNotifyBlockingMove\r\n\r\nhttp://gfycat.com/ImpishImaginativeFlea\r\n\r\nhttps://gfycat.com/BoilingLimpAfricanjacana","created_at":"2015-11-20T10:31:14Z","updated_at":"2015-11-21T12:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb19dc33aabf56ba0128722d23aab3b8083b229c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10041/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/15b2885464919bd817c2dc9b5fe599afc457908c","head":{"label":"teees:exit-on-death","ref":"exit-on-death","sha":"15b2885464919bd817c2dc9b5fe599afc457908c","user":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"repo":{"id":44729148,"name":"OpenRA","full_name":"teees/OpenRA","owner":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teees/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/teees/OpenRA","forks_url":"https://api.github.com/repos/teees/OpenRA/forks","keys_url":"https://api.github.com/repos/teees/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teees/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teees/OpenRA/teams","hooks_url":"https://api.github.com/repos/teees/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/teees/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/teees/OpenRA/events","assignees_url":"https://api.github.com/repos/teees/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/teees/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/teees/OpenRA/tags","blobs_url":"https://api.github.com/repos/teees/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teees/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teees/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/teees/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teees/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/teees/OpenRA/languages","stargazers_url":"https://api.github.com/repos/teees/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/teees/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/teees/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/teees/OpenRA/subscription","commits_url":"https://api.github.com/repos/teees/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/teees/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/teees/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/teees/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/teees/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/teees/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teees/OpenRA/merges","archive_url":"https://api.github.com/repos/teees/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teees/OpenRA/downloads","issues_url":"https://api.github.com/repos/teees/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/teees/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/teees/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/teees/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teees/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/teees/OpenRA/releases{/id}","created_at":"2015-10-22T07:28:42Z","updated_at":"2015-10-22T07:28:54Z","pushed_at":"2015-11-20T16:09:30Z","git_url":"git://github.com/teees/OpenRA.git","ssh_url":"git@github.com:teees/OpenRA.git","clone_url":"https://github.com/teees/OpenRA.git","svn_url":"https://github.com/teees/OpenRA","homepage":"http://www.openra.net","size":97746,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"a4d864903d974119d8480ce4de4fe9e130a0603a","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-11-20T13:32:12Z","pushed_at":"2015-11-21T11:15:17Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":138585,"stargazers_count":2319,"watchers_count":2319,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":822,"mirror_url":null,"open_issues_count":1006,"forks":822,"open_issues":1006,"watchers":2319,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/10041"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/10041"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/10041/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/10041/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/15b2885464919bd817c2dc9b5fe599afc457908c"}}}}