{"action":"opened","number":344,"pull_request":{"url":"https://api.github.com/repos/skulpt/skulpt/pulls/344","id":29916357,"html_url":"https://github.com/skulpt/skulpt/pull/344","diff_url":"https://github.com/skulpt/skulpt/pull/344.diff","patch_url":"https://github.com/skulpt/skulpt/pull/344.patch","issue_url":"https://api.github.com/repos/skulpt/skulpt/issues/344","number":344,"state":"open","locked":false,"title":"Fix __getattr__ and __setattr__, and make them suspendable","user":{"login":"meredydd","id":126110,"avatar_url":"https://avatars.githubusercontent.com/u/126110?v=3","gravatar_id":"","url":"https://api.github.com/users/meredydd","html_url":"https://github.com/meredydd","followers_url":"https://api.github.com/users/meredydd/followers","following_url":"https://api.github.com/users/meredydd/following{/other_user}","gists_url":"https://api.github.com/users/meredydd/gists{/gist_id}","starred_url":"https://api.github.com/users/meredydd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meredydd/subscriptions","organizations_url":"https://api.github.com/users/meredydd/orgs","repos_url":"https://api.github.com/users/meredydd/repos","events_url":"https://api.github.com/users/meredydd/events{/privacy}","received_events_url":"https://api.github.com/users/meredydd/received_events","type":"User","site_admin":false},"body":"```__getattr__``` and ```__setattr__``` support was broken (wrong lookup order), and pretty difficult to use because ```object.__setattr__``` was not available, so if you implemented a ```__setattr__``` there was no way to set *any* attributes in your object dictionary!\r\n\r\nI've fixed this, and added a test. In addition, these calls are now suspendable, so they can block.","created_at":"2015-02-24T17:12:00Z","updated_at":"2015-02-24T17:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skulpt/skulpt/pulls/344/commits","review_comments_url":"https://api.github.com/repos/skulpt/skulpt/pulls/344/comments","review_comment_url":"https://api.github.com/repos/skulpt/skulpt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skulpt/skulpt/issues/344/comments","statuses_url":"https://api.github.com/repos/skulpt/skulpt/statuses/266202f5d52b61a21370d19532a848fea7915eb1","head":{"label":"meredydd:getattr-pr","ref":"getattr-pr","sha":"266202f5d52b61a21370d19532a848fea7915eb1","user":{"login":"meredydd","id":126110,"avatar_url":"https://avatars.githubusercontent.com/u/126110?v=3","gravatar_id":"","url":"https://api.github.com/users/meredydd","html_url":"https://github.com/meredydd","followers_url":"https://api.github.com/users/meredydd/followers","following_url":"https://api.github.com/users/meredydd/following{/other_user}","gists_url":"https://api.github.com/users/meredydd/gists{/gist_id}","starred_url":"https://api.github.com/users/meredydd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meredydd/subscriptions","organizations_url":"https://api.github.com/users/meredydd/orgs","repos_url":"https://api.github.com/users/meredydd/repos","events_url":"https://api.github.com/users/meredydd/events{/privacy}","received_events_url":"https://api.github.com/users/meredydd/received_events","type":"User","site_admin":false},"repo":{"id":24228877,"name":"skulpt","full_name":"meredydd/skulpt","owner":{"login":"meredydd","id":126110,"avatar_url":"https://avatars.githubusercontent.com/u/126110?v=3","gravatar_id":"","url":"https://api.github.com/users/meredydd","html_url":"https://github.com/meredydd","followers_url":"https://api.github.com/users/meredydd/followers","following_url":"https://api.github.com/users/meredydd/following{/other_user}","gists_url":"https://api.github.com/users/meredydd/gists{/gist_id}","starred_url":"https://api.github.com/users/meredydd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meredydd/subscriptions","organizations_url":"https://api.github.com/users/meredydd/orgs","repos_url":"https://api.github.com/users/meredydd/repos","events_url":"https://api.github.com/users/meredydd/events{/privacy}","received_events_url":"https://api.github.com/users/meredydd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meredydd/skulpt","description":"Skulpt is a Javascript implementation of the Python programming language","fork":true,"url":"https://api.github.com/repos/meredydd/skulpt","forks_url":"https://api.github.com/repos/meredydd/skulpt/forks","keys_url":"https://api.github.com/repos/meredydd/skulpt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meredydd/skulpt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meredydd/skulpt/teams","hooks_url":"https://api.github.com/repos/meredydd/skulpt/hooks","issue_events_url":"https://api.github.com/repos/meredydd/skulpt/issues/events{/number}","events_url":"https://api.github.com/repos/meredydd/skulpt/events","assignees_url":"https://api.github.com/repos/meredydd/skulpt/assignees{/user}","branches_url":"https://api.github.com/repos/meredydd/skulpt/branches{/branch}","tags_url":"https://api.github.com/repos/meredydd/skulpt/tags","blobs_url":"https://api.github.com/repos/meredydd/skulpt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meredydd/skulpt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meredydd/skulpt/git/refs{/sha}","trees_url":"https://api.github.com/repos/meredydd/skulpt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meredydd/skulpt/statuses/{sha}","languages_url":"https://api.github.com/repos/meredydd/skulpt/languages","stargazers_url":"https://api.github.com/repos/meredydd/skulpt/stargazers","contributors_url":"https://api.github.com/repos/meredydd/skulpt/contributors","subscribers_url":"https://api.github.com/repos/meredydd/skulpt/subscribers","subscription_url":"https://api.github.com/repos/meredydd/skulpt/subscription","commits_url":"https://api.github.com/repos/meredydd/skulpt/commits{/sha}","git_commits_url":"https://api.github.com/repos/meredydd/skulpt/git/commits{/sha}","comments_url":"https://api.github.com/repos/meredydd/skulpt/comments{/number}","issue_comment_url":"https://api.github.com/repos/meredydd/skulpt/issues/comments{/number}","contents_url":"https://api.github.com/repos/meredydd/skulpt/contents/{+path}","compare_url":"https://api.github.com/repos/meredydd/skulpt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meredydd/skulpt/merges","archive_url":"https://api.github.com/repos/meredydd/skulpt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meredydd/skulpt/downloads","issues_url":"https://api.github.com/repos/meredydd/skulpt/issues{/number}","pulls_url":"https://api.github.com/repos/meredydd/skulpt/pulls{/number}","milestones_url":"https://api.github.com/repos/meredydd/skulpt/milestones{/number}","notifications_url":"https://api.github.com/repos/meredydd/skulpt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meredydd/skulpt/labels{/name}","releases_url":"https://api.github.com/repos/meredydd/skulpt/releases{/id}","created_at":"2014-09-19T12:23:48Z","updated_at":"2015-02-23T18:09:47Z","pushed_at":"2015-02-24T17:07:57Z","git_url":"git://github.com/meredydd/skulpt.git","ssh_url":"git@github.com:meredydd/skulpt.git","clone_url":"https://github.com/meredydd/skulpt.git","svn_url":"https://github.com/meredydd/skulpt","homepage":null,"size":76512,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"skulpt:master","ref":"master","sha":"6035d9dbfb29ce828c2e735d5fa42324f8b00871","user":{"login":"skulpt","id":5229490,"avatar_url":"https://avatars.githubusercontent.com/u/5229490?v=3","gravatar_id":"","url":"https://api.github.com/users/skulpt","html_url":"https://github.com/skulpt","followers_url":"https://api.github.com/users/skulpt/followers","following_url":"https://api.github.com/users/skulpt/following{/other_user}","gists_url":"https://api.github.com/users/skulpt/gists{/gist_id}","starred_url":"https://api.github.com/users/skulpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skulpt/subscriptions","organizations_url":"https://api.github.com/users/skulpt/orgs","repos_url":"https://api.github.com/users/skulpt/repos","events_url":"https://api.github.com/users/skulpt/events{/privacy}","received_events_url":"https://api.github.com/users/skulpt/received_events","type":"Organization","site_admin":false},"repo":{"id":4512368,"name":"skulpt","full_name":"skulpt/skulpt","owner":{"login":"skulpt","id":5229490,"avatar_url":"https://avatars.githubusercontent.com/u/5229490?v=3","gravatar_id":"","url":"https://api.github.com/users/skulpt","html_url":"https://github.com/skulpt","followers_url":"https://api.github.com/users/skulpt/followers","following_url":"https://api.github.com/users/skulpt/following{/other_user}","gists_url":"https://api.github.com/users/skulpt/gists{/gist_id}","starred_url":"https://api.github.com/users/skulpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skulpt/subscriptions","organizations_url":"https://api.github.com/users/skulpt/orgs","repos_url":"https://api.github.com/users/skulpt/repos","events_url":"https://api.github.com/users/skulpt/events{/privacy}","received_events_url":"https://api.github.com/users/skulpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skulpt/skulpt","description":"Skulpt is a Javascript implementation of the Python programming language","fork":false,"url":"https://api.github.com/repos/skulpt/skulpt","forks_url":"https://api.github.com/repos/skulpt/skulpt/forks","keys_url":"https://api.github.com/repos/skulpt/skulpt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skulpt/skulpt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skulpt/skulpt/teams","hooks_url":"https://api.github.com/repos/skulpt/skulpt/hooks","issue_events_url":"https://api.github.com/repos/skulpt/skulpt/issues/events{/number}","events_url":"https://api.github.com/repos/skulpt/skulpt/events","assignees_url":"https://api.github.com/repos/skulpt/skulpt/assignees{/user}","branches_url":"https://api.github.com/repos/skulpt/skulpt/branches{/branch}","tags_url":"https://api.github.com/repos/skulpt/skulpt/tags","blobs_url":"https://api.github.com/repos/skulpt/skulpt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skulpt/skulpt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skulpt/skulpt/git/refs{/sha}","trees_url":"https://api.github.com/repos/skulpt/skulpt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skulpt/skulpt/statuses/{sha}","languages_url":"https://api.github.com/repos/skulpt/skulpt/languages","stargazers_url":"https://api.github.com/repos/skulpt/skulpt/stargazers","contributors_url":"https://api.github.com/repos/skulpt/skulpt/contributors","subscribers_url":"https://api.github.com/repos/skulpt/skulpt/subscribers","subscription_url":"https://api.github.com/repos/skulpt/skulpt/subscription","commits_url":"https://api.github.com/repos/skulpt/skulpt/commits{/sha}","git_commits_url":"https://api.github.com/repos/skulpt/skulpt/git/commits{/sha}","comments_url":"https://api.github.com/repos/skulpt/skulpt/comments{/number}","issue_comment_url":"https://api.github.com/repos/skulpt/skulpt/issues/comments{/number}","contents_url":"https://api.github.com/repos/skulpt/skulpt/contents/{+path}","compare_url":"https://api.github.com/repos/skulpt/skulpt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skulpt/skulpt/merges","archive_url":"https://api.github.com/repos/skulpt/skulpt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skulpt/skulpt/downloads","issues_url":"https://api.github.com/repos/skulpt/skulpt/issues{/number}","pulls_url":"https://api.github.com/repos/skulpt/skulpt/pulls{/number}","milestones_url":"https://api.github.com/repos/skulpt/skulpt/milestones{/number}","notifications_url":"https://api.github.com/repos/skulpt/skulpt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skulpt/skulpt/labels{/name}","releases_url":"https://api.github.com/repos/skulpt/skulpt/releases{/id}","created_at":"2012-05-31T20:13:13Z","updated_at":"2015-02-24T16:25:32Z","pushed_at":"2015-02-24T07:30:11Z","git_url":"git://github.com/skulpt/skulpt.git","ssh_url":"git@github.com:skulpt/skulpt.git","clone_url":"https://github.com/skulpt/skulpt.git","svn_url":"https://github.com/skulpt/skulpt","homepage":null,"size":129032,"stargazers_count":811,"watchers_count":811,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":76,"forks":280,"open_issues":76,"watchers":811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skulpt/skulpt/pulls/344"},"html":{"href":"https://github.com/skulpt/skulpt/pull/344"},"issue":{"href":"https://api.github.com/repos/skulpt/skulpt/issues/344"},"comments":{"href":"https://api.github.com/repos/skulpt/skulpt/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/skulpt/skulpt/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/skulpt/skulpt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skulpt/skulpt/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/skulpt/skulpt/statuses/266202f5d52b61a21370d19532a848fea7915eb1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":841,"deletions":13,"changed_files":8}}