{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-php/issues/782","labels_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/782/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/782/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/782/events","html_url":"https://github.com/aws/aws-sdk-php/pull/782","id":108765524,"number":782,"title":"improved acl mapping","user":{"login":"femans","id":625851,"avatar_url":"https://avatars.githubusercontent.com/u/625851?v=3","gravatar_id":"","url":"https://api.github.com/users/femans","html_url":"https://github.com/femans","followers_url":"https://api.github.com/users/femans/followers","following_url":"https://api.github.com/users/femans/following{/other_user}","gists_url":"https://api.github.com/users/femans/gists{/gist_id}","starred_url":"https://api.github.com/users/femans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femans/subscriptions","organizations_url":"https://api.github.com/users/femans/orgs","repos_url":"https://api.github.com/users/femans/repos","events_url":"https://api.github.com/users/femans/events{/privacy}","received_events_url":"https://api.github.com/users/femans/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aws/aws-sdk-php/labels/enhancement","name":"enhancement","color":"207de5"},{"url":"https://api.github.com/repos/aws/aws-sdk-php/labels/streamwrapper","name":"streamwrapper","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-28T23:22:06Z","updated_at":"2015-09-29T22:57:11Z","closed_at":"2015-09-29T22:57:11Z","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/782","html_url":"https://github.com/aws/aws-sdk-php/pull/782","diff_url":"https://github.com/aws/aws-sdk-php/pull/782.diff","patch_url":"https://github.com/aws/aws-sdk-php/pull/782.patch"},"body":"as suggested and promised in https://github.com/aws/aws-sdk-php/pull/776#issuecomment-143505174 \r\n\r\nI don´t expect this to get pulled without some discussion about what would be the best mapping; however imo the current mapping is erroneous and needs improving; 700 should of course be as private as possible.\r\n\r\nI chose this simple form:\r\npublic-read: the third digit is 4 or 5\r\npublic-read-write: the third digit is 6 or 7\r\nprivate: the rest\r\n\r\nrationale:\r\nthe x-bit has no meaning in acl, so these options make the most sense. 0 or 1 is no permissions, 2 or 3 are write-but-not-read, which is rarely seen in the wild and of course has no corresponding acl, which leaves read and read+write.\r\nThe group (2nd) digit cannot really be described by canned acl policies; it is not authenticated-read, because this does not refer to the private group of the file.\r\nThe owner (1st) digit doesn´t get a lot of flexibility in canned acl´s, there is only full access for the owner, no matter which option is chosen. So maybe you might want an error or something if anything else than 6 or 7 is given, in stead of simply give full access to the owner no matter what is requested, which is my solution.\r\n\r\nThere may be better ways to improve the mapping than using canned acl, I am open to suggestions. Also on expanding the unit tests."},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-php/issues/comments/144214822","html_url":"https://github.com/aws/aws-sdk-php/pull/782#issuecomment-144214822","issue_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/782","id":144214822,"user":{"login":"jeskew","id":705500,"avatar_url":"https://avatars.githubusercontent.com/u/705500?v=3","gravatar_id":"","url":"https://api.github.com/users/jeskew","html_url":"https://github.com/jeskew","followers_url":"https://api.github.com/users/jeskew/followers","following_url":"https://api.github.com/users/jeskew/following{/other_user}","gists_url":"https://api.github.com/users/jeskew/gists{/gist_id}","starred_url":"https://api.github.com/users/jeskew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeskew/subscriptions","organizations_url":"https://api.github.com/users/jeskew/orgs","repos_url":"https://api.github.com/users/jeskew/repos","events_url":"https://api.github.com/users/jeskew/events{/privacy}","received_events_url":"https://api.github.com/users/jeskew/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T22:57:11Z","updated_at":"2015-09-29T22:57:11Z","body":"Closing in favor of #776."}}