{"action":"created","comment":{"url":"https://api.github.com/repos/zatar-iot/californium/pulls/comments/33476780","id":33476780,"diff_hunk":"@@ -0,0 +1,352 @@\n+package org.eclipse.californium.core.network.tcp;\n+\n+import java.util.Iterator;\n+import java.util.concurrent.ConcurrentHashMap;\n+import java.util.concurrent.ScheduledExecutorService;\n+import java.util.concurrent.TimeUnit;\n+import java.util.logging.Level;\n+import java.util.logging.Logger;\n+\n+import org.eclipse.californium.core.coap.CoAP.Type;\n+import org.eclipse.californium.core.coap.EmptyMessage;\n+import org.eclipse.californium.core.coap.Message;\n+import org.eclipse.californium.core.coap.Request;\n+import org.eclipse.californium.core.coap.Response;\n+import org.eclipse.californium.core.network.Exchange;\n+import org.eclipse.californium.core.network.Exchange.KeyMID;\n+import org.eclipse.californium.core.network.Exchange.KeyToken;\n+import org.eclipse.californium.core.network.Exchange.KeyUri;\n+import org.eclipse.californium.core.network.Exchange.Origin;\n+import org.eclipse.californium.core.network.ExchangeObserver;\n+import org.eclipse.californium.core.network.config.NetworkConfig;\n+import org.eclipse.californium.core.observe.ObserveRelation;\n+\n+public class TcpMatcher {","path":"californium-core/src/main/java/org/eclipse/californium/core/network/tcp/TcpMatcher.java","position":24,"original_position":24,"commit_id":"a0a5717598879067bc849b1675f3449d34309c8b","original_commit_id":"a0a5717598879067bc849b1675f3449d34309c8b","user":{"login":"louis89","id":2187164,"avatar_url":"https://avatars.githubusercontent.com/u/2187164?v=3","gravatar_id":"","url":"https://api.github.com/users/louis89","html_url":"https://github.com/louis89","followers_url":"https://api.github.com/users/louis89/followers","following_url":"https://api.github.com/users/louis89/following{/other_user}","gists_url":"https://api.github.com/users/louis89/gists{/gist_id}","starred_url":"https://api.github.com/users/louis89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louis89/subscriptions","organizations_url":"https://api.github.com/users/louis89/orgs","repos_url":"https://api.github.com/users/louis89/repos","events_url":"https://api.github.com/users/louis89/events{/privacy}","received_events_url":"https://api.github.com/users/louis89/received_events","type":"User","site_admin":false},"body":"And it appears as though the only difference here is removal of deduplication. Why couldn't you edit the Matcher class to optionally use deduplicator? Doesn't seem like it would have taken much effort and certainly would have been much cleaner...","created_at":"2015-06-29T15:36:30Z","updated_at":"2015-06-29T15:36:30Z","html_url":"https://github.com/zatar-iot/californium/pull/2#discussion_r33476780","pull_request_url":"https://api.github.com/repos/zatar-iot/californium/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/zatar-iot/californium/pulls/comments/33476780"},"html":{"href":"https://github.com/zatar-iot/californium/pull/2#discussion_r33476780"},"pull_request":{"href":"https://api.github.com/repos/zatar-iot/californium/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/zatar-iot/californium/pulls/2","id":38778183,"html_url":"https://github.com/zatar-iot/californium/pull/2","diff_url":"https://github.com/zatar-iot/californium/pull/2.diff","patch_url":"https://github.com/zatar-iot/californium/pull/2.patch","issue_url":"https://api.github.com/repos/zatar-iot/californium/issues/2","number":2,"state":"open","locked":false,"title":"Tcp endpoint","user":{"login":"Areontar","id":2413363,"avatar_url":"https://avatars.githubusercontent.com/u/2413363?v=3","gravatar_id":"","url":"https://api.github.com/users/Areontar","html_url":"https://github.com/Areontar","followers_url":"https://api.github.com/users/Areontar/followers","following_url":"https://api.github.com/users/Areontar/following{/other_user}","gists_url":"https://api.github.com/users/Areontar/gists{/gist_id}","starred_url":"https://api.github.com/users/Areontar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Areontar/subscriptions","organizations_url":"https://api.github.com/users/Areontar/orgs","repos_url":"https://api.github.com/users/Areontar/repos","events_url":"https://api.github.com/users/Areontar/events{/privacy}","received_events_url":"https://api.github.com/users/Areontar/received_events","type":"User","site_admin":false},"body":"impl of TLS and TCP round 1","created_at":"2015-06-29T14:19:19Z","updated_at":"2015-06-29T15:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be37c8b3af0c3fe83b7dc334f4f50abad227e125","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zatar-iot/californium/pulls/2/commits","review_comments_url":"https://api.github.com/repos/zatar-iot/californium/pulls/2/comments","review_comment_url":"https://api.github.com/repos/zatar-iot/californium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zatar-iot/californium/issues/2/comments","statuses_url":"https://api.github.com/repos/zatar-iot/californium/statuses/a0a5717598879067bc849b1675f3449d34309c8b","head":{"label":"zatar-iot:tcp_endpoint","ref":"tcp_endpoint","sha":"a0a5717598879067bc849b1675f3449d34309c8b","user":{"login":"zatar-iot","id":7365347,"avatar_url":"https://avatars.githubusercontent.com/u/7365347?v=3","gravatar_id":"","url":"https://api.github.com/users/zatar-iot","html_url":"https://github.com/zatar-iot","followers_url":"https://api.github.com/users/zatar-iot/followers","following_url":"https://api.github.com/users/zatar-iot/following{/other_user}","gists_url":"https://api.github.com/users/zatar-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/zatar-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zatar-iot/subscriptions","organizations_url":"https://api.github.com/users/zatar-iot/orgs","repos_url":"https://api.github.com/users/zatar-iot/repos","events_url":"https://api.github.com/users/zatar-iot/events{/privacy}","received_events_url":"https://api.github.com/users/zatar-iot/received_events","type":"Organization","site_admin":false},"repo":{"id":33694886,"name":"californium","full_name":"zatar-iot/californium","owner":{"login":"zatar-iot","id":7365347,"avatar_url":"https://avatars.githubusercontent.com/u/7365347?v=3","gravatar_id":"","url":"https://api.github.com/users/zatar-iot","html_url":"https://github.com/zatar-iot","followers_url":"https://api.github.com/users/zatar-iot/followers","following_url":"https://api.github.com/users/zatar-iot/following{/other_user}","gists_url":"https://api.github.com/users/zatar-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/zatar-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zatar-iot/subscriptions","organizations_url":"https://api.github.com/users/zatar-iot/orgs","repos_url":"https://api.github.com/users/zatar-iot/repos","events_url":"https://api.github.com/users/zatar-iot/events{/privacy}","received_events_url":"https://api.github.com/users/zatar-iot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zatar-iot/californium","description":"Californium project","fork":true,"url":"https://api.github.com/repos/zatar-iot/californium","forks_url":"https://api.github.com/repos/zatar-iot/californium/forks","keys_url":"https://api.github.com/repos/zatar-iot/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zatar-iot/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zatar-iot/californium/teams","hooks_url":"https://api.github.com/repos/zatar-iot/californium/hooks","issue_events_url":"https://api.github.com/repos/zatar-iot/californium/issues/events{/number}","events_url":"https://api.github.com/repos/zatar-iot/californium/events","assignees_url":"https://api.github.com/repos/zatar-iot/californium/assignees{/user}","branches_url":"https://api.github.com/repos/zatar-iot/californium/branches{/branch}","tags_url":"https://api.github.com/repos/zatar-iot/californium/tags","blobs_url":"https://api.github.com/repos/zatar-iot/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zatar-iot/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zatar-iot/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/zatar-iot/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zatar-iot/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/zatar-iot/californium/languages","stargazers_url":"https://api.github.com/repos/zatar-iot/californium/stargazers","contributors_url":"https://api.github.com/repos/zatar-iot/californium/contributors","subscribers_url":"https://api.github.com/repos/zatar-iot/californium/subscribers","subscription_url":"https://api.github.com/repos/zatar-iot/californium/subscription","commits_url":"https://api.github.com/repos/zatar-iot/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/zatar-iot/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/zatar-iot/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/zatar-iot/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/zatar-iot/californium/contents/{+path}","compare_url":"https://api.github.com/repos/zatar-iot/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zatar-iot/californium/merges","archive_url":"https://api.github.com/repos/zatar-iot/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zatar-iot/californium/downloads","issues_url":"https://api.github.com/repos/zatar-iot/californium/issues{/number}","pulls_url":"https://api.github.com/repos/zatar-iot/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/zatar-iot/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/zatar-iot/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zatar-iot/californium/labels{/name}","releases_url":"https://api.github.com/repos/zatar-iot/californium/releases{/id}","created_at":"2015-04-09T21:58:49Z","updated_at":"2015-04-09T21:58:50Z","pushed_at":"2015-06-29T14:52:34Z","git_url":"git://github.com/zatar-iot/californium.git","ssh_url":"git@github.com:zatar-iot/californium.git","clone_url":"https://github.com/zatar-iot/californium.git","svn_url":"https://github.com/zatar-iot/californium","homepage":null,"size":822,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zatar-iot:tcp_tls_impl","ref":"tcp_tls_impl","sha":"1e8a35b41401103dba7b3b85db14280366642366","user":{"login":"zatar-iot","id":7365347,"avatar_url":"https://avatars.githubusercontent.com/u/7365347?v=3","gravatar_id":"","url":"https://api.github.com/users/zatar-iot","html_url":"https://github.com/zatar-iot","followers_url":"https://api.github.com/users/zatar-iot/followers","following_url":"https://api.github.com/users/zatar-iot/following{/other_user}","gists_url":"https://api.github.com/users/zatar-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/zatar-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zatar-iot/subscriptions","organizations_url":"https://api.github.com/users/zatar-iot/orgs","repos_url":"https://api.github.com/users/zatar-iot/repos","events_url":"https://api.github.com/users/zatar-iot/events{/privacy}","received_events_url":"https://api.github.com/users/zatar-iot/received_events","type":"Organization","site_admin":false},"repo":{"id":33694886,"name":"californium","full_name":"zatar-iot/californium","owner":{"login":"zatar-iot","id":7365347,"avatar_url":"https://avatars.githubusercontent.com/u/7365347?v=3","gravatar_id":"","url":"https://api.github.com/users/zatar-iot","html_url":"https://github.com/zatar-iot","followers_url":"https://api.github.com/users/zatar-iot/followers","following_url":"https://api.github.com/users/zatar-iot/following{/other_user}","gists_url":"https://api.github.com/users/zatar-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/zatar-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zatar-iot/subscriptions","organizations_url":"https://api.github.com/users/zatar-iot/orgs","repos_url":"https://api.github.com/users/zatar-iot/repos","events_url":"https://api.github.com/users/zatar-iot/events{/privacy}","received_events_url":"https://api.github.com/users/zatar-iot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zatar-iot/californium","description":"Californium project","fork":true,"url":"https://api.github.com/repos/zatar-iot/californium","forks_url":"https://api.github.com/repos/zatar-iot/californium/forks","keys_url":"https://api.github.com/repos/zatar-iot/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zatar-iot/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zatar-iot/californium/teams","hooks_url":"https://api.github.com/repos/zatar-iot/californium/hooks","issue_events_url":"https://api.github.com/repos/zatar-iot/californium/issues/events{/number}","events_url":"https://api.github.com/repos/zatar-iot/californium/events","assignees_url":"https://api.github.com/repos/zatar-iot/californium/assignees{/user}","branches_url":"https://api.github.com/repos/zatar-iot/californium/branches{/branch}","tags_url":"https://api.github.com/repos/zatar-iot/californium/tags","blobs_url":"https://api.github.com/repos/zatar-iot/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zatar-iot/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zatar-iot/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/zatar-iot/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zatar-iot/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/zatar-iot/californium/languages","stargazers_url":"https://api.github.com/repos/zatar-iot/californium/stargazers","contributors_url":"https://api.github.com/repos/zatar-iot/californium/contributors","subscribers_url":"https://api.github.com/repos/zatar-iot/californium/subscribers","subscription_url":"https://api.github.com/repos/zatar-iot/californium/subscription","commits_url":"https://api.github.com/repos/zatar-iot/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/zatar-iot/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/zatar-iot/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/zatar-iot/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/zatar-iot/californium/contents/{+path}","compare_url":"https://api.github.com/repos/zatar-iot/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zatar-iot/californium/merges","archive_url":"https://api.github.com/repos/zatar-iot/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zatar-iot/californium/downloads","issues_url":"https://api.github.com/repos/zatar-iot/californium/issues{/number}","pulls_url":"https://api.github.com/repos/zatar-iot/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/zatar-iot/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/zatar-iot/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zatar-iot/californium/labels{/name}","releases_url":"https://api.github.com/repos/zatar-iot/californium/releases{/id}","created_at":"2015-04-09T21:58:49Z","updated_at":"2015-04-09T21:58:50Z","pushed_at":"2015-06-29T14:52:34Z","git_url":"git://github.com/zatar-iot/californium.git","ssh_url":"git@github.com:zatar-iot/californium.git","clone_url":"https://github.com/zatar-iot/californium.git","svn_url":"https://github.com/zatar-iot/californium","homepage":null,"size":822,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zatar-iot/californium/pulls/2"},"html":{"href":"https://github.com/zatar-iot/californium/pull/2"},"issue":{"href":"https://api.github.com/repos/zatar-iot/californium/issues/2"},"comments":{"href":"https://api.github.com/repos/zatar-iot/californium/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/zatar-iot/californium/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/zatar-iot/californium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zatar-iot/californium/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/zatar-iot/californium/statuses/a0a5717598879067bc849b1675f3449d34309c8b"}}}}