{"action":"created","issue":{"url":"https://api.github.com/repos/spedygiorgio/markovchain/issues/14","labels_url":"https://api.github.com/repos/spedygiorgio/markovchain/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/spedygiorgio/markovchain/issues/14/comments","events_url":"https://api.github.com/repos/spedygiorgio/markovchain/issues/14/events","html_url":"https://github.com/spedygiorgio/markovchain/issues/14","id":86759470,"number":14,"title":"naming hyperparameters matrices","user":{"login":"spedygiorgio","id":825030,"avatar_url":"https://avatars.githubusercontent.com/u/825030?v=3","gravatar_id":"","url":"https://api.github.com/users/spedygiorgio","html_url":"https://github.com/spedygiorgio","followers_url":"https://api.github.com/users/spedygiorgio/followers","following_url":"https://api.github.com/users/spedygiorgio/following{/other_user}","gists_url":"https://api.github.com/users/spedygiorgio/gists{/gist_id}","starred_url":"https://api.github.com/users/spedygiorgio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spedygiorgio/subscriptions","organizations_url":"https://api.github.com/users/spedygiorgio/orgs","repos_url":"https://api.github.com/users/spedygiorgio/repos","events_url":"https://api.github.com/users/spedygiorgio/events{/privacy}","received_events_url":"https://api.github.com/users/spedygiorgio/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spedygiorgio/markovchain/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/spedygiorgio/markovchain/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/spedygiorgio/markovchain/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"ysaibhargav","id":2175542,"avatar_url":"https://avatars.githubusercontent.com/u/2175542?v=3","gravatar_id":"","url":"https://api.github.com/users/ysaibhargav","html_url":"https://github.com/ysaibhargav","followers_url":"https://api.github.com/users/ysaibhargav/followers","following_url":"https://api.github.com/users/ysaibhargav/following{/other_user}","gists_url":"https://api.github.com/users/ysaibhargav/gists{/gist_id}","starred_url":"https://api.github.com/users/ysaibhargav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysaibhargav/subscriptions","organizations_url":"https://api.github.com/users/ysaibhargav/orgs","repos_url":"https://api.github.com/users/ysaibhargav/repos","events_url":"https://api.github.com/users/ysaibhargav/events{/privacy}","received_events_url":"https://api.github.com/users/ysaibhargav/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-06-09T22:44:57Z","updated_at":"2015-06-10T22:09:01Z","closed_at":null,"body":"predictiveDistribution and markovchainFit functions' hyperparam should be named. I suppose when you say matrix(1,1) the fist item is for \"a\" and the second is for \"b\" but it is not necessairly true. \r\n\r\nsequence<-c(\"a\", \"b\", \"a\", \"a\", \"a\", \"a\", \"b\", \"a\", \"b\", \"a\", \"b\", \"a\", \"a\", \"b\", \"b\", \"b\", \"a\")\r\npredProb <- predictiveDistribution(sequence[1:10], sequence[11:17], hyperparam = matrix(1, 1))\r\n\r\n\r\nAlso consider that matrix(1,1) in R is \r\n\r\nmatrix(1, 1)\r\n     [,1]\r\n[1,]    1\r\n\r\ni am not sure you intended this...\r\n"},"comment":{"url":"https://api.github.com/repos/spedygiorgio/markovchain/issues/comments/110931705","html_url":"https://github.com/spedygiorgio/markovchain/issues/14#issuecomment-110931705","issue_url":"https://api.github.com/repos/spedygiorgio/markovchain/issues/14","id":110931705,"user":{"login":"spedygiorgio","id":825030,"avatar_url":"https://avatars.githubusercontent.com/u/825030?v=3","gravatar_id":"","url":"https://api.github.com/users/spedygiorgio","html_url":"https://github.com/spedygiorgio","followers_url":"https://api.github.com/users/spedygiorgio/followers","following_url":"https://api.github.com/users/spedygiorgio/following{/other_user}","gists_url":"https://api.github.com/users/spedygiorgio/gists{/gist_id}","starred_url":"https://api.github.com/users/spedygiorgio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spedygiorgio/subscriptions","organizations_url":"https://api.github.com/users/spedygiorgio/orgs","repos_url":"https://api.github.com/users/spedygiorgio/repos","events_url":"https://api.github.com/users/spedygiorgio/events{/privacy}","received_events_url":"https://api.github.com/users/spedygiorgio/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T22:09:00Z","updated_at":"2015-06-10T22:09:00Z","body":"In order to fix an error in the vignette, I modified them naming the hyperparameters and duplicating the examples, swithcing two rows. This is what I intended. I see that estimates sligthly changes. Please could you check? Also, take into account that the distinct states observed should be included in the cases included in the hyperparameter matrix but not necessarily exacly the same. The hyperparameter matrix can be bigger (not smaller, taking into account there could be other states that are not observed in the sample)."}}