{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2364","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2364/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2364/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2364/events","html_url":"https://github.com/checkstyle/checkstyle/pull/2364","id":111859018,"number":2364,"title":"Issue #2266: Fixed blank line indentification for EmptyLineSeparator check","user":{"login":"pbaranchikov","id":3531552,"avatar_url":"https://avatars.githubusercontent.com/u/3531552?v=3","gravatar_id":"","url":"https://api.github.com/users/pbaranchikov","html_url":"https://github.com/pbaranchikov","followers_url":"https://api.github.com/users/pbaranchikov/followers","following_url":"https://api.github.com/users/pbaranchikov/following{/other_user}","gists_url":"https://api.github.com/users/pbaranchikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbaranchikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbaranchikov/subscriptions","organizations_url":"https://api.github.com/users/pbaranchikov/orgs","repos_url":"https://api.github.com/users/pbaranchikov/repos","events_url":"https://api.github.com/users/pbaranchikov/events{/privacy}","received_events_url":"https://api.github.com/users/pbaranchikov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-10-16T15:52:18Z","updated_at":"2015-10-17T12:44:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2364","html_url":"https://github.com/checkstyle/checkstyle/pull/2364","diff_url":"https://github.com/checkstyle/checkstyle/pull/2364.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/2364.patch"},"body":"Current implementation count everything outside AntLR tree as blank lines. Javadoc and comments among them.\r\n\r\nThis patch checks, that lines between tokens are actually empty (trim().isEmpty()).\r\n\r\nCheckstyle reports are uploaded to [my site] (http://pbaranchikov.github.io/checkstyle/empty-line-separator/checkstyle.html)\r\nFor guava project, found 1591 violations against 1576 for Checkstyle 6.11.2.\r\n\r\nValidations are also fixed in Checkstyle code itself"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/148914156","html_url":"https://github.com/checkstyle/checkstyle/pull/2364#issuecomment-148914156","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2364","id":148914156,"user":{"login":"romani","id":812984,"avatar_url":"https://avatars.githubusercontent.com/u/812984?v=3","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"created_at":"2015-10-17T12:44:20Z","updated_at":"2015-10-17T12:44:20Z","body":"diff: https://www.diffchecker.com/l0tpaz3r\r\nonly new violations, all violations are valid, good job!\r\n\r\nOne minor item to change, before merge:\r\n\r\n> private boolean hasEmptyLineAfter(DetailAST token) {\r\n> // If there are lines between current and next token, check if there are empty ones\r\n\r\ncomments over a block a first sign that you need to make a function from it - please do.\r\nAs you make it as function, you will make methods as with single exit point - that is also need to be done.\r\n\r\nRight now we enforce limit of RETURN as \"2\" , but that is transitional limit, eventually we will have limit \"1\"."}}