{"action":"created","issue":{"url":"https://api.github.com/repos/tdhock/animint/issues/114","labels_url":"https://api.github.com/repos/tdhock/animint/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/tdhock/animint/issues/114/comments","events_url":"https://api.github.com/repos/tdhock/animint/issues/114/events","html_url":"https://github.com/tdhock/animint/pull/114","id":107939098,"number":114,"title":"fix common chunk bug","user":{"login":"tdhock","id":932850,"avatar_url":"https://avatars.githubusercontent.com/u/932850?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhock","html_url":"https://github.com/tdhock","followers_url":"https://api.github.com/users/tdhock/followers","following_url":"https://api.github.com/users/tdhock/following{/other_user}","gists_url":"https://api.github.com/users/tdhock/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhock/subscriptions","organizations_url":"https://api.github.com/users/tdhock/orgs","repos_url":"https://api.github.com/users/tdhock/repos","events_url":"https://api.github.com/users/tdhock/events{/privacy}","received_events_url":"https://api.github.com/users/tdhock/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-23T14:57:58Z","updated_at":"2015-09-24T16:24:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tdhock/animint/pulls/114","html_url":"https://github.com/tdhock/animint/pull/114","diff_url":"https://github.com/tdhock/animint/pull/114.diff","patch_url":"https://github.com/tdhock/animint/pull/114.patch"},"body":"there is a new PeakConsistency data set, and a new test in test-PeakConsistency.R which fails. \r\n\r\n```\r\n> library(\"testthat\")\r\n\r\nAttaching package: ‘testthat’\r\n\r\nThe following object is masked _by_ ‘.GlobalEnv’:\r\n\r\n    watch\r\n\r\n> library(\"animint\")\r\nLoading required package: proto\r\n> library(\"RSelenium\") # RSelenium works with firefox <= 37.0.2\r\nLoading required package: RCurl\r\nLoading required package: bitops\r\nLoading required package: RJSONIO\r\nLoading required package: XML\r\n\r\nAttaching package: ‘XML’\r\n\r\nThe following object is masked _by_ ‘.GlobalEnv’:\r\n\r\n    free\r\n\r\n> tests_init(\"firefox\")\r\nStarting selenium binary. To shut it down, run: \r\nremDr$closeWindow() \r\nremDr$closeServer()\r\nserving the directory /home/thocking/R/animint/tests/testthat at http://127.0.0.1:4848\r\n> tests_run(filter=\"PeakConsistency\")\r\n1. Failure (at test-PeakConsistency.R#39): viz of just segments renders --------\r\nlength(line.list) not equal to 30\r\n30 - 0 == 30\r\n\r\ntestthat results ================================================================\r\nOK: 0 SKIPPED: 0 FAILED: 1\r\n1. Failure (at test-PeakConsistency.R#39): viz of just segments renders \r\n\r\nError: testthat unit tests failed\r\n> \r\n```\r\n\r\nThe `geom_segment` rendering stops with an error in the JavaScript:\r\n\r\n![screenshot-varied-chunk-error](https://cloud.githubusercontent.com/assets/932850/10048630/df044e1c-61e1-11e5-933f-5d771380e9db.png)\r\n\r\n@caijun since this seems to be a bug in your varied/common chunk code, could you please take a look at fixing it when you get a chance?"},"comment":{"url":"https://api.github.com/repos/tdhock/animint/issues/comments/142978568","html_url":"https://github.com/tdhock/animint/pull/114#issuecomment-142978568","issue_url":"https://api.github.com/repos/tdhock/animint/issues/114","id":142978568,"user":{"login":"caijun","id":2522593,"avatar_url":"https://avatars.githubusercontent.com/u/2522593?v=3","gravatar_id":"","url":"https://api.github.com/users/caijun","html_url":"https://github.com/caijun","followers_url":"https://api.github.com/users/caijun/followers","following_url":"https://api.github.com/users/caijun/following{/other_user}","gists_url":"https://api.github.com/users/caijun/gists{/gist_id}","starred_url":"https://api.github.com/users/caijun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caijun/subscriptions","organizations_url":"https://api.github.com/users/caijun/orgs","repos_url":"https://api.github.com/users/caijun/repos","events_url":"https://api.github.com/users/caijun/events{/privacy}","received_events_url":"https://api.github.com/users/caijun/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T16:24:22Z","updated_at":"2015-09-24T16:24:22Z","body":"I have drawn the figure, but the Panel 6~10 doesn't have geoms.\r\n\r\n<img width=\"1426\" alt=\"screen shot 2015-09-25 at 12 16 20\" src=\"https://cloud.githubusercontent.com/assets/2522593/10079143/fca6d48c-631a-11e5-845c-633402b706a2.png\">\r\n\r\nBy checking data of Geoms from DOM, the data are existed. I don't know why they aren't drawn. @tdhock  could you have a look?\r\n\r\n<img width=\"1424\" alt=\"screen shot 2015-09-25 at 12 20 42\" src=\"https://cloud.githubusercontent.com/assets/2522593/10079192/4e5bf8b6-631b-11e5-91a7-6fe571de6e38.png\">\r\n\r\nFollowing is the gist example.\r\n\r\nhttp://bl.ocks.org/caijun/raw/7a4bda7b54a600a8b60f/\r\n\r\n"}}