{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/40727819","id":40727819,"diff_hunk":"@@ -143,7 +162,12 @@ VoronoiBackgroundProducer::produce(edm::Event& iEvent, const edm::EventSetup& iS\n \t ue = new UECalibration(ueTable->values);\n \t}\n \n-     voronoi_ = new VoronoiAlgorithm(ue,equalizeR_,std::pair<double, double>(equalizeThreshold0_,equalizeThreshold1_),doEqualize_);\n+\tif (sameEvent_) {\n+\t\tvoronoi_ = new SameEventVoronoiAlgorithm(sameEventAntiktDistance_, sameEventExclusionPtMin_, sameEventExclusionRadius_, sameEventFakeRejectEtMax_, sameEventFakeRejectEtMaxOverMean_, std::pair<double, double>(equalizeThreshold0_,equalizeThreshold1_), doEqualize_);\n+\t}\n+\telse {\n+\tvoronoi_ = new VoronoiAlgorithm(ue,equalizeR_,excludeV1_,maxVn_,diagonalVn_,std::pair<double, double>(equalizeThreshold0_,equalizeThreshold1_),doEqualize_);\n+\t}","path":"RecoHI/HiJetAlgos/plugins/VoronoiBackgroundProducer.cc","position":56,"original_position":56,"commit_id":"5c427da5340574133c85b7a46ef7031af6ec7e03","original_commit_id":"5c427da5340574133c85b7a46ef7031af6ec7e03","user":{"login":"cvuosalo","id":5736159,"avatar_url":"https://avatars.githubusercontent.com/u/5736159?v=3","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"body":"Is voronoi_ ever deleted? It might be a good idea to convert it into a unique_ptr to protect against memory leaks.","created_at":"2015-09-29T20:52:38Z","updated_at":"2015-09-29T20:52:38Z","html_url":"https://github.com/cms-sw/cmssw/pull/11452#discussion_r40727819","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/40727819"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11452#discussion_r40727819"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452","id":45890353,"html_url":"https://github.com/cms-sw/cmssw/pull/11452","diff_url":"https://github.com/cms-sw/cmssw/pull/11452.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11452.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11452","number":11452,"state":"open","locked":false,"title":"Vs same event vn flags 3","user":{"login":"yslai","id":1032767,"avatar_url":"https://avatars.githubusercontent.com/u/1032767?v=3","gravatar_id":"","url":"https://api.github.com/users/yslai","html_url":"https://github.com/yslai","followers_url":"https://api.github.com/users/yslai/followers","following_url":"https://api.github.com/users/yslai/following{/other_user}","gists_url":"https://api.github.com/users/yslai/gists{/gist_id}","starred_url":"https://api.github.com/users/yslai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yslai/subscriptions","organizations_url":"https://api.github.com/users/yslai/orgs","repos_url":"https://api.github.com/users/yslai/repos","events_url":"https://api.github.com/users/yslai/events{/privacy}","received_events_url":"https://api.github.com/users/yslai/received_events","type":"User","site_admin":false},"body":"A change to implement two features:\r\n\r\n(a) A \"fall-back\" mode, when no calibration information is available, that estimates the UE from the same event using a close approximation of the ATLAS algorithm [Physics Letters B 719, 220–241 (2013)]. This mode is not turned on by default.\r\n\r\n(b) Flags to expose the to be subtracted order and cross terms. This was inadvertently hard-coded before.\r\n\r\nThe changes are merged due to otherwise conflicting diffs.","created_at":"2015-09-24T12:22:15Z","updated_at":"2015-09-29T20:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac3a09c13b5a71ebdce108c403a97962f54efce0","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":774,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-09-29T20:15:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11452/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/5c427da5340574133c85b7a46ef7031af6ec7e03","head":{"label":"yslai:vs_same_event_vn_flags_3","ref":"vs_same_event_vn_flags_3","sha":"5c427da5340574133c85b7a46ef7031af6ec7e03","user":{"login":"yslai","id":1032767,"avatar_url":"https://avatars.githubusercontent.com/u/1032767?v=3","gravatar_id":"","url":"https://api.github.com/users/yslai","html_url":"https://github.com/yslai","followers_url":"https://api.github.com/users/yslai/followers","following_url":"https://api.github.com/users/yslai/following{/other_user}","gists_url":"https://api.github.com/users/yslai/gists{/gist_id}","starred_url":"https://api.github.com/users/yslai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yslai/subscriptions","organizations_url":"https://api.github.com/users/yslai/orgs","repos_url":"https://api.github.com/users/yslai/repos","events_url":"https://api.github.com/users/yslai/events{/privacy}","received_events_url":"https://api.github.com/users/yslai/received_events","type":"User","site_admin":false},"repo":{"id":29597165,"name":"cmssw","full_name":"yslai/cmssw","owner":{"login":"yslai","id":1032767,"avatar_url":"https://avatars.githubusercontent.com/u/1032767?v=3","gravatar_id":"","url":"https://api.github.com/users/yslai","html_url":"https://github.com/yslai","followers_url":"https://api.github.com/users/yslai/followers","following_url":"https://api.github.com/users/yslai/following{/other_user}","gists_url":"https://api.github.com/users/yslai/gists{/gist_id}","starred_url":"https://api.github.com/users/yslai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yslai/subscriptions","organizations_url":"https://api.github.com/users/yslai/orgs","repos_url":"https://api.github.com/users/yslai/repos","events_url":"https://api.github.com/users/yslai/events{/privacy}","received_events_url":"https://api.github.com/users/yslai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yslai/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/yslai/cmssw","forks_url":"https://api.github.com/repos/yslai/cmssw/forks","keys_url":"https://api.github.com/repos/yslai/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yslai/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yslai/cmssw/teams","hooks_url":"https://api.github.com/repos/yslai/cmssw/hooks","issue_events_url":"https://api.github.com/repos/yslai/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/yslai/cmssw/events","assignees_url":"https://api.github.com/repos/yslai/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/yslai/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/yslai/cmssw/tags","blobs_url":"https://api.github.com/repos/yslai/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yslai/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yslai/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/yslai/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yslai/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/yslai/cmssw/languages","stargazers_url":"https://api.github.com/repos/yslai/cmssw/stargazers","contributors_url":"https://api.github.com/repos/yslai/cmssw/contributors","subscribers_url":"https://api.github.com/repos/yslai/cmssw/subscribers","subscription_url":"https://api.github.com/repos/yslai/cmssw/subscription","commits_url":"https://api.github.com/repos/yslai/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/yslai/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/yslai/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/yslai/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/yslai/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/yslai/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yslai/cmssw/merges","archive_url":"https://api.github.com/repos/yslai/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yslai/cmssw/downloads","issues_url":"https://api.github.com/repos/yslai/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/yslai/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/yslai/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/yslai/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yslai/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/yslai/cmssw/releases{/id}","created_at":"2015-01-21T15:52:38Z","updated_at":"2015-03-03T19:37:47Z","pushed_at":"2015-09-24T12:12:57Z","git_url":"git://github.com/yslai/cmssw.git","ssh_url":"git@github.com:yslai/cmssw.git","clone_url":"https://github.com/yslai/cmssw.git","svn_url":"https://github.com/yslai/cmssw","homepage":"http://cms-sw.github.io/","size":818299,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_4_X"}},"base":{"label":"cms-sw:CMSSW_7_6_X","ref":"CMSSW_7_6_X","sha":"104d1093307e95b805676ea0e887982579d755ad","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-09-29T08:31:25Z","pushed_at":"2015-09-29T20:03:43Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1296915,"stargazers_count":260,"watchers_count":260,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1575,"mirror_url":null,"open_issues_count":256,"forks":1575,"open_issues":256,"watchers":260,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11452"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11452"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11452/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11452/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/5c427da5340574133c85b7a46ef7031af6ec7e03"}}}}