{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/35514751","id":35514751,"diff_hunk":"@@ -496,9 +428,10 @@ static function getSecureMimeType($mimeType) {\n \t *\n \t * @param string $data\n \t * @return string\n+\t * @deprecated Use \\OC::$server->getMimeTypeDetector()->detectString($data)","path":"lib/private/helper.php","position":145,"original_position":145,"commit_id":"c633f3d0a197bcc2054e70671feac1f07684fdbf","original_commit_id":"c633f3d0a197bcc2054e70671feac1f07684fdbf","user":{"login":"Xenopathic","id":2016878,"avatar_url":"https://avatars.githubusercontent.com/u/2016878?v=3","gravatar_id":"","url":"https://api.github.com/users/Xenopathic","html_url":"https://github.com/Xenopathic","followers_url":"https://api.github.com/users/Xenopathic/followers","following_url":"https://api.github.com/users/Xenopathic/following{/other_user}","gists_url":"https://api.github.com/users/Xenopathic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xenopathic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xenopathic/subscriptions","organizations_url":"https://api.github.com/users/Xenopathic/orgs","repos_url":"https://api.github.com/users/Xenopathic/repos","events_url":"https://api.github.com/users/Xenopathic/events{/privacy}","received_events_url":"https://api.github.com/users/Xenopathic/received_events","type":"User","site_admin":false},"body":"Missing deprecation version","created_at":"2015-07-27T08:34:04Z","updated_at":"2015-07-27T08:34:04Z","html_url":"https://github.com/owncloud/core/pull/15543#discussion_r35514751","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/15543","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/35514751"},"html":{"href":"https://github.com/owncloud/core/pull/15543#discussion_r35514751"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/15543"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/15543","id":33067539,"html_url":"https://github.com/owncloud/core/pull/15543","diff_url":"https://github.com/owncloud/core/pull/15543.diff","patch_url":"https://github.com/owncloud/core/pull/15543.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/15543","number":15543,"state":"open","locked":false,"title":"Mimetypedetector","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"body":"As described in https://github.com/owncloud/core/issues/4774#issuecomment-88452605\r\nMoving aways from the mimetype stuff in OC_Helper.\r\n\r\navailable unit tests are copied and modified.\r\n\r\nIt should not provide to much trouble as most functions were already wrappers around this.","created_at":"2015-04-10T17:41:55Z","updated_at":"2015-07-27T08:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0aeddb99d3458373c3421a141b472807df0823d","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":637,"closed_issues":194,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-07-27T08:29:48Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/15543/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/15543/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/15543/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/c633f3d0a197bcc2054e70671feac1f07684fdbf","head":{"label":"rullzer:mimetypedetector","ref":"mimetypedetector","sha":"c633f3d0a197bcc2054e70671feac1f07684fdbf","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"repo":{"id":29611886,"name":"core","full_name":"rullzer/core","owner":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rullzer/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/rullzer/core","forks_url":"https://api.github.com/repos/rullzer/core/forks","keys_url":"https://api.github.com/repos/rullzer/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rullzer/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rullzer/core/teams","hooks_url":"https://api.github.com/repos/rullzer/core/hooks","issue_events_url":"https://api.github.com/repos/rullzer/core/issues/events{/number}","events_url":"https://api.github.com/repos/rullzer/core/events","assignees_url":"https://api.github.com/repos/rullzer/core/assignees{/user}","branches_url":"https://api.github.com/repos/rullzer/core/branches{/branch}","tags_url":"https://api.github.com/repos/rullzer/core/tags","blobs_url":"https://api.github.com/repos/rullzer/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rullzer/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rullzer/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rullzer/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rullzer/core/statuses/{sha}","languages_url":"https://api.github.com/repos/rullzer/core/languages","stargazers_url":"https://api.github.com/repos/rullzer/core/stargazers","contributors_url":"https://api.github.com/repos/rullzer/core/contributors","subscribers_url":"https://api.github.com/repos/rullzer/core/subscribers","subscription_url":"https://api.github.com/repos/rullzer/core/subscription","commits_url":"https://api.github.com/repos/rullzer/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rullzer/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rullzer/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rullzer/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rullzer/core/contents/{+path}","compare_url":"https://api.github.com/repos/rullzer/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rullzer/core/merges","archive_url":"https://api.github.com/repos/rullzer/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rullzer/core/downloads","issues_url":"https://api.github.com/repos/rullzer/core/issues{/number}","pulls_url":"https://api.github.com/repos/rullzer/core/pulls{/number}","milestones_url":"https://api.github.com/repos/rullzer/core/milestones{/number}","notifications_url":"https://api.github.com/repos/rullzer/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rullzer/core/labels{/name}","releases_url":"https://api.github.com/repos/rullzer/core/releases{/id}","created_at":"2015-01-21T20:40:40Z","updated_at":"2015-05-06T17:12:09Z","pushed_at":"2015-07-27T06:36:53Z","git_url":"git://github.com/rullzer/core.git","ssh_url":"git@github.com:rullzer/core.git","clone_url":"https://github.com/rullzer/core.git","svn_url":"https://github.com/rullzer/core","homepage":null,"size":172226,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"bacada263cac90302578925ecca0d85196f3fabb","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-07-26T21:30:14Z","pushed_at":"2015-07-27T08:30:20Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":1023823,"stargazers_count":3495,"watchers_count":3495,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1117,"mirror_url":null,"open_issues_count":1994,"forks":1117,"open_issues":1994,"watchers":3495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/15543"},"html":{"href":"https://github.com/owncloud/core/pull/15543"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/15543"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/15543/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/15543/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/15543/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/c633f3d0a197bcc2054e70671feac1f07684fdbf"}}}}