{"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/92","id":41452487,"html_url":"https://github.com/DavidThomasSL/intern-project/pull/92","diff_url":"https://github.com/DavidThomasSL/intern-project/pull/92.diff","patch_url":"https://github.com/DavidThomasSL/intern-project/pull/92.patch","issue_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/92","number":92,"state":"closed","locked":false,"title":"Player readying system","user":{"login":"BRHoward","id":10777232,"avatar_url":"https://avatars.githubusercontent.com/u/10777232?v=3","gravatar_id":"","url":"https://api.github.com/users/BRHoward","html_url":"https://github.com/BRHoward","followers_url":"https://api.github.com/users/BRHoward/followers","following_url":"https://api.github.com/users/BRHoward/following{/other_user}","gists_url":"https://api.github.com/users/BRHoward/gists{/gist_id}","starred_url":"https://api.github.com/users/BRHoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BRHoward/subscriptions","organizations_url":"https://api.github.com/users/BRHoward/orgs","repos_url":"https://api.github.com/users/BRHoward/repos","events_url":"https://api.github.com/users/BRHoward/events{/privacy}","received_events_url":"https://api.github.com/users/BRHoward/received_events","type":"User","site_admin":false},"body":"Made sure that each player needs to be ready before moving on.\r\nMoved some flow logic to the server so client can't just call finishGame(),nextRound() etc whenever they want, only can say that they are ready to move on.\r\nMade the sidebar update the scores after each vote instead of after each round but visual rank still doesn't work completely.\r\nRemoved ng-enter and ng-leave animations for now until flicker is fixed.","created_at":"2015-08-03T10:12:42Z","updated_at":"2015-08-03T10:38:51Z","closed_at":"2015-08-03T10:38:51Z","merged_at":"2015-08-03T10:38:51Z","merge_commit_sha":"8667fcf3d1771a40a295a48c289d42a74b3f25cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/92/commits","review_comments_url":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/92/comments","review_comment_url":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/92/comments","statuses_url":"https://api.github.com/repos/DavidThomasSL/intern-project/statuses/d0d3dc318a1977e5eea467091c072825f5b553ec","head":{"label":"DavidThomasSL:player-readying","ref":"player-readying","sha":"d0d3dc318a1977e5eea467091c072825f5b553ec","user":{"login":"DavidThomasSL","id":7385248,"avatar_url":"https://avatars.githubusercontent.com/u/7385248?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidThomasSL","html_url":"https://github.com/DavidThomasSL","followers_url":"https://api.github.com/users/DavidThomasSL/followers","following_url":"https://api.github.com/users/DavidThomasSL/following{/other_user}","gists_url":"https://api.github.com/users/DavidThomasSL/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidThomasSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidThomasSL/subscriptions","organizations_url":"https://api.github.com/users/DavidThomasSL/orgs","repos_url":"https://api.github.com/users/DavidThomasSL/repos","events_url":"https://api.github.com/users/DavidThomasSL/events{/privacy}","received_events_url":"https://api.github.com/users/DavidThomasSL/received_events","type":"User","site_admin":false},"repo":{"id":36076690,"name":"intern-project","full_name":"DavidThomasSL/intern-project","owner":{"login":"DavidThomasSL","id":7385248,"avatar_url":"https://avatars.githubusercontent.com/u/7385248?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidThomasSL","html_url":"https://github.com/DavidThomasSL","followers_url":"https://api.github.com/users/DavidThomasSL/followers","following_url":"https://api.github.com/users/DavidThomasSL/following{/other_user}","gists_url":"https://api.github.com/users/DavidThomasSL/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidThomasSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidThomasSL/subscriptions","organizations_url":"https://api.github.com/users/DavidThomasSL/orgs","repos_url":"https://api.github.com/users/DavidThomasSL/repos","events_url":"https://api.github.com/users/DavidThomasSL/events{/privacy}","received_events_url":"https://api.github.com/users/DavidThomasSL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidThomasSL/intern-project","description":"","fork":false,"url":"https://api.github.com/repos/DavidThomasSL/intern-project","forks_url":"https://api.github.com/repos/DavidThomasSL/intern-project/forks","keys_url":"https://api.github.com/repos/DavidThomasSL/intern-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidThomasSL/intern-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidThomasSL/intern-project/teams","hooks_url":"https://api.github.com/repos/DavidThomasSL/intern-project/hooks","issue_events_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/events{/number}","events_url":"https://api.github.com/repos/DavidThomasSL/intern-project/events","assignees_url":"https://api.github.com/repos/DavidThomasSL/intern-project/assignees{/user}","branches_url":"https://api.github.com/repos/DavidThomasSL/intern-project/branches{/branch}","tags_url":"https://api.github.com/repos/DavidThomasSL/intern-project/tags","blobs_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidThomasSL/intern-project/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidThomasSL/intern-project/languages","stargazers_url":"https://api.github.com/repos/DavidThomasSL/intern-project/stargazers","contributors_url":"https://api.github.com/repos/DavidThomasSL/intern-project/contributors","subscribers_url":"https://api.github.com/repos/DavidThomasSL/intern-project/subscribers","subscription_url":"https://api.github.com/repos/DavidThomasSL/intern-project/subscription","commits_url":"https://api.github.com/repos/DavidThomasSL/intern-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidThomasSL/intern-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidThomasSL/intern-project/contents/{+path}","compare_url":"https://api.github.com/repos/DavidThomasSL/intern-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidThomasSL/intern-project/merges","archive_url":"https://api.github.com/repos/DavidThomasSL/intern-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidThomasSL/intern-project/downloads","issues_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues{/number}","pulls_url":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidThomasSL/intern-project/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidThomasSL/intern-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidThomasSL/intern-project/labels{/name}","releases_url":"https://api.github.com/repos/DavidThomasSL/intern-project/releases{/id}","created_at":"2015-05-22T14:31:17Z","updated_at":"2015-07-17T15:47:19Z","pushed_at":"2015-08-03T10:38:51Z","git_url":"git://github.com/DavidThomasSL/intern-project.git","ssh_url":"git@github.com:DavidThomasSL/intern-project.git","clone_url":"https://github.com/DavidThomasSL/intern-project.git","svn_url":"https://github.com/DavidThomasSL/intern-project","homepage":null,"size":1584,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"dev"}},"base":{"label":"DavidThomasSL:dev","ref":"dev","sha":"2e7a4c523a8aa70e02bb5fd12747d969c13a7e45","user":{"login":"DavidThomasSL","id":7385248,"avatar_url":"https://avatars.githubusercontent.com/u/7385248?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidThomasSL","html_url":"https://github.com/DavidThomasSL","followers_url":"https://api.github.com/users/DavidThomasSL/followers","following_url":"https://api.github.com/users/DavidThomasSL/following{/other_user}","gists_url":"https://api.github.com/users/DavidThomasSL/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidThomasSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidThomasSL/subscriptions","organizations_url":"https://api.github.com/users/DavidThomasSL/orgs","repos_url":"https://api.github.com/users/DavidThomasSL/repos","events_url":"https://api.github.com/users/DavidThomasSL/events{/privacy}","received_events_url":"https://api.github.com/users/DavidThomasSL/received_events","type":"User","site_admin":false},"repo":{"id":36076690,"name":"intern-project","full_name":"DavidThomasSL/intern-project","owner":{"login":"DavidThomasSL","id":7385248,"avatar_url":"https://avatars.githubusercontent.com/u/7385248?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidThomasSL","html_url":"https://github.com/DavidThomasSL","followers_url":"https://api.github.com/users/DavidThomasSL/followers","following_url":"https://api.github.com/users/DavidThomasSL/following{/other_user}","gists_url":"https://api.github.com/users/DavidThomasSL/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidThomasSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidThomasSL/subscriptions","organizations_url":"https://api.github.com/users/DavidThomasSL/orgs","repos_url":"https://api.github.com/users/DavidThomasSL/repos","events_url":"https://api.github.com/users/DavidThomasSL/events{/privacy}","received_events_url":"https://api.github.com/users/DavidThomasSL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidThomasSL/intern-project","description":"","fork":false,"url":"https://api.github.com/repos/DavidThomasSL/intern-project","forks_url":"https://api.github.com/repos/DavidThomasSL/intern-project/forks","keys_url":"https://api.github.com/repos/DavidThomasSL/intern-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidThomasSL/intern-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidThomasSL/intern-project/teams","hooks_url":"https://api.github.com/repos/DavidThomasSL/intern-project/hooks","issue_events_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/events{/number}","events_url":"https://api.github.com/repos/DavidThomasSL/intern-project/events","assignees_url":"https://api.github.com/repos/DavidThomasSL/intern-project/assignees{/user}","branches_url":"https://api.github.com/repos/DavidThomasSL/intern-project/branches{/branch}","tags_url":"https://api.github.com/repos/DavidThomasSL/intern-project/tags","blobs_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidThomasSL/intern-project/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidThomasSL/intern-project/languages","stargazers_url":"https://api.github.com/repos/DavidThomasSL/intern-project/stargazers","contributors_url":"https://api.github.com/repos/DavidThomasSL/intern-project/contributors","subscribers_url":"https://api.github.com/repos/DavidThomasSL/intern-project/subscribers","subscription_url":"https://api.github.com/repos/DavidThomasSL/intern-project/subscription","commits_url":"https://api.github.com/repos/DavidThomasSL/intern-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidThomasSL/intern-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidThomasSL/intern-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidThomasSL/intern-project/contents/{+path}","compare_url":"https://api.github.com/repos/DavidThomasSL/intern-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidThomasSL/intern-project/merges","archive_url":"https://api.github.com/repos/DavidThomasSL/intern-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidThomasSL/intern-project/downloads","issues_url":"https://api.github.com/repos/DavidThomasSL/intern-project/issues{/number}","pulls_url":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidThomasSL/intern-project/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidThomasSL/intern-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidThomasSL/intern-project/labels{/name}","releases_url":"https://api.github.com/repos/DavidThomasSL/intern-project/releases{/id}","created_at":"2015-05-22T14:31:17Z","updated_at":"2015-07-17T15:47:19Z","pushed_at":"2015-08-03T10:38:51Z","git_url":"git://github.com/DavidThomasSL/intern-project.git","ssh_url":"git@github.com:DavidThomasSL/intern-project.git","clone_url":"https://github.com/DavidThomasSL/intern-project.git","svn_url":"https://github.com/DavidThomasSL/intern-project","homepage":null,"size":1584,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/92"},"html":{"href":"https://github.com/DavidThomasSL/intern-project/pull/92"},"issue":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/92"},"comments":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/DavidThomasSL/intern-project/statuses/d0d3dc318a1977e5eea467091c072825f5b553ec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"BRHoward","id":10777232,"avatar_url":"https://avatars.githubusercontent.com/u/10777232?v=3","gravatar_id":"","url":"https://api.github.com/users/BRHoward","html_url":"https://github.com/BRHoward","followers_url":"https://api.github.com/users/BRHoward/followers","following_url":"https://api.github.com/users/BRHoward/following{/other_user}","gists_url":"https://api.github.com/users/BRHoward/gists{/gist_id}","starred_url":"https://api.github.com/users/BRHoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BRHoward/subscriptions","organizations_url":"https://api.github.com/users/BRHoward/orgs","repos_url":"https://api.github.com/users/BRHoward/repos","events_url":"https://api.github.com/users/BRHoward/events{/privacy}","received_events_url":"https://api.github.com/users/BRHoward/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":6,"additions":295,"deletions":317,"changed_files":18}}