{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/48212972","id":48212972,"diff_hunk":"@@ -0,0 +1,54 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.catalyst\n+\n+import org.apache.spark.SparkFunSuite\n+import org.apache.spark.sql.catalyst.optimizer.Optimizer\n+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan\n+import org.apache.spark.sql.catalyst.rules.Rule\n+\n+/**\n+  * This is a test for SPARK-7727 if the Optimizer is kept being extendable\n+  */\n+class OptimizerExtendableSuite extends SparkFunSuite {\n+\n+  /**\n+    * Dummy rule for test batches\n+    */\n+  object DummyRule extends Rule[LogicalPlan] {\n+    def apply(p: LogicalPlan): LogicalPlan = p\n+  }\n+\n+  /**\n+    * This class represents a dummy extended optimizer that takes the batches of the\n+    * Optimizer and adds custom ones.\n+    */\n+  class ExtendedOptimizer extends Optimizer {\n+\n+    // rules set to DummyRule, would not be executed anyways\n+    val myBatches: Seq[Batch] = Batch(\"once\", Once, DummyRule) ::\n+                                Batch(\"fixedPoint\", FixedPoint(100), DummyRule) :: Nil","path":"sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerExtendableSuite.scala","position":45,"original_position":45,"commit_id":"a7c9f5cc10234d68c84a59eb969e0e4cf3d84cf0","original_commit_id":"a7c9f5cc10234d68c84a59eb969e0e4cf3d84cf0","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"You can follow `Optimizer` for how to indent these `Batch`es","created_at":"2015-12-22T01:24:26Z","updated_at":"2015-12-22T01:24:26Z","html_url":"https://github.com/apache/spark/pull/10174#discussion_r48212972","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/10174","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/48212972"},"html":{"href":"https://github.com/apache/spark/pull/10174#discussion_r48212972"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/10174"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/10174","id":52848525,"html_url":"https://github.com/apache/spark/pull/10174","diff_url":"https://github.com/apache/spark/pull/10174.diff","patch_url":"https://github.com/apache/spark/pull/10174.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/10174","number":10174,"state":"open","locked":false,"title":"[SPARK-7727] [SQL] Avoid inner classes in RuleExecutor","user":{"login":"stephankessler","id":12641153,"avatar_url":"https://avatars.githubusercontent.com/u/12641153?v=3","gravatar_id":"","url":"https://api.github.com/users/stephankessler","html_url":"https://github.com/stephankessler","followers_url":"https://api.github.com/users/stephankessler/followers","following_url":"https://api.github.com/users/stephankessler/following{/other_user}","gists_url":"https://api.github.com/users/stephankessler/gists{/gist_id}","starred_url":"https://api.github.com/users/stephankessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephankessler/subscriptions","organizations_url":"https://api.github.com/users/stephankessler/orgs","repos_url":"https://api.github.com/users/stephankessler/repos","events_url":"https://api.github.com/users/stephankessler/events{/privacy}","received_events_url":"https://api.github.com/users/stephankessler/received_events","type":"User","site_admin":false},"body":"Moved (case) classes Strategy, Once, FixedPoint and Batch to the companion object. This is necessary if we want to have the Optimizer easily extendable in the following sense: Usually a user wants to add additional rules, and just take the ones that are already there. However, inner classes made that impossible since the code did not compile\r\n\r\nThis allows easy extension of existing Optimizers see the DefaultOptimizerExtendableSuite for a corresponding test case.","created_at":"2015-12-07T14:09:40Z","updated_at":"2015-12-22T01:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b397c1d089d94dccffeebf5ff85ac252f1846a20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/10174/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/10174/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/10174/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/a7c9f5cc10234d68c84a59eb969e0e4cf3d84cf0","head":{"label":"stephankessler:SPARK-7727","ref":"SPARK-7727","sha":"a7c9f5cc10234d68c84a59eb969e0e4cf3d84cf0","user":{"login":"stephankessler","id":12641153,"avatar_url":"https://avatars.githubusercontent.com/u/12641153?v=3","gravatar_id":"","url":"https://api.github.com/users/stephankessler","html_url":"https://github.com/stephankessler","followers_url":"https://api.github.com/users/stephankessler/followers","following_url":"https://api.github.com/users/stephankessler/following{/other_user}","gists_url":"https://api.github.com/users/stephankessler/gists{/gist_id}","starred_url":"https://api.github.com/users/stephankessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephankessler/subscriptions","organizations_url":"https://api.github.com/users/stephankessler/orgs","repos_url":"https://api.github.com/users/stephankessler/repos","events_url":"https://api.github.com/users/stephankessler/events{/privacy}","received_events_url":"https://api.github.com/users/stephankessler/received_events","type":"User","site_admin":false},"repo":{"id":46266162,"name":"spark","full_name":"stephankessler/spark","owner":{"login":"stephankessler","id":12641153,"avatar_url":"https://avatars.githubusercontent.com/u/12641153?v=3","gravatar_id":"","url":"https://api.github.com/users/stephankessler","html_url":"https://github.com/stephankessler","followers_url":"https://api.github.com/users/stephankessler/followers","following_url":"https://api.github.com/users/stephankessler/following{/other_user}","gists_url":"https://api.github.com/users/stephankessler/gists{/gist_id}","starred_url":"https://api.github.com/users/stephankessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephankessler/subscriptions","organizations_url":"https://api.github.com/users/stephankessler/orgs","repos_url":"https://api.github.com/users/stephankessler/repos","events_url":"https://api.github.com/users/stephankessler/events{/privacy}","received_events_url":"https://api.github.com/users/stephankessler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephankessler/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/stephankessler/spark","forks_url":"https://api.github.com/repos/stephankessler/spark/forks","keys_url":"https://api.github.com/repos/stephankessler/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephankessler/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephankessler/spark/teams","hooks_url":"https://api.github.com/repos/stephankessler/spark/hooks","issue_events_url":"https://api.github.com/repos/stephankessler/spark/issues/events{/number}","events_url":"https://api.github.com/repos/stephankessler/spark/events","assignees_url":"https://api.github.com/repos/stephankessler/spark/assignees{/user}","branches_url":"https://api.github.com/repos/stephankessler/spark/branches{/branch}","tags_url":"https://api.github.com/repos/stephankessler/spark/tags","blobs_url":"https://api.github.com/repos/stephankessler/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephankessler/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephankessler/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephankessler/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephankessler/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/stephankessler/spark/languages","stargazers_url":"https://api.github.com/repos/stephankessler/spark/stargazers","contributors_url":"https://api.github.com/repos/stephankessler/spark/contributors","subscribers_url":"https://api.github.com/repos/stephankessler/spark/subscribers","subscription_url":"https://api.github.com/repos/stephankessler/spark/subscription","commits_url":"https://api.github.com/repos/stephankessler/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephankessler/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephankessler/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephankessler/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephankessler/spark/contents/{+path}","compare_url":"https://api.github.com/repos/stephankessler/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephankessler/spark/merges","archive_url":"https://api.github.com/repos/stephankessler/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephankessler/spark/downloads","issues_url":"https://api.github.com/repos/stephankessler/spark/issues{/number}","pulls_url":"https://api.github.com/repos/stephankessler/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/stephankessler/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/stephankessler/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephankessler/spark/labels{/name}","releases_url":"https://api.github.com/repos/stephankessler/spark/releases{/id}","created_at":"2015-11-16T09:54:32Z","updated_at":"2015-11-16T09:55:06Z","pushed_at":"2015-12-21T08:53:35Z","git_url":"git://github.com/stephankessler/spark.git","ssh_url":"git@github.com:stephankessler/spark.git","clone_url":"https://github.com/stephankessler/spark.git","svn_url":"https://github.com/stephankessler/spark","homepage":null,"size":136614,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ce1798b3af8de326bf955b51ed955a924b019b4e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-12-22T00:21:57Z","pushed_at":"2015-12-22T01:23:29Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":393370,"stargazers_count":6655,"watchers_count":6655,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6161,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":388,"forks":6161,"open_issues":388,"watchers":6655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/10174"},"html":{"href":"https://github.com/apache/spark/pull/10174"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/10174"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/10174/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/10174/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/10174/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/a7c9f5cc10234d68c84a59eb969e0e4cf3d84cf0"}}}}