{"push_id":876287493,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"db730725a86c540c8d9ba7d77c9651eb35389469","before":"7c6424ea9978fd6d1cc6d5b4d6eccae66bf49d9e","commits":[{"sha":"db730725a86c540c8d9ba7d77c9651eb35389469","author":{"email":"c0f02d98506190746d1cdcb01be0f37b51e27077@chromium.org","name":"Nico Weber"},"message":"Make SerialIoHandlerWin::UiThreadHelper final.\n\nFixes the clang/win build after https://codereview.chromium.org/1439443002/\nclang rightfully complains that UiThreadHelper has virtual methods, is\ndeleted polymorphically, and doesn't have a virtual destructor:\n\n..\\..\\base/sequenced_task_runner_helpers.h(40,5) :  error: delete called on 'const device::SerialIoHandlerWin::UiThreadHelper' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]\n    delete reinterpret_cast<const T*>(object);\n    ^\n..\\..\\base/sequenced_task_runner_helpers.h(86,38) :  note: in instantiation of member function 'base::DeleteHelper<device::SerialIoHandlerWin::UiThreadHelper>::DoDelete' requested here\n        from_here, &DeleteHelper<T>::DoDelete, object);\n                                     ^\n..\\..\\base/sequenced_task_runner.h(126,48) :  note: in instantiation of function template specialization 'base::subtle::DeleteHelperInternal<device::SerialIoHandlerWin::UiThreadHelper, bool>::DeleteViaSequencedTaskRunner<base::SequencedTaskRunner>' requested here\n        subtle::DeleteHelperInternal<T, bool>::DeleteViaSequencedTaskRunner(\n                                               ^\n..\\..\\device\\serial\\serial_io_handler_win.cc(374,28) :  note: in instantiation of function template specialization 'base::SequencedTaskRunner::DeleteSoon<device::SerialIoHandlerWin::UiThreadHelper>' requested here\n  ui_thread_task_runner()->DeleteSoon(FROM_HERE, helper_);\n                           ^\n\nMaking the class final fixes this as it makes sure that nobody adds\na subclass of UiThreadHelper.\n\nAlso don't mix initializer styles for the different fields of this\nclass.\n\nNo intended behavior change.\n\nBUG=82385\nTBR=juncai\n\nReview URL: https://codereview.chromium.org/1470983002 .\n\nCr-Commit-Position: refs/heads/master@{#361117}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/db730725a86c540c8d9ba7d77c9651eb35389469"}]}