{"action":"created","issue":{"url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/issues/1574","labels_url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/issues/1574/labels{/name}","comments_url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/issues/1574/comments","events_url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/issues/1574/events","html_url":"https://github.com/spritebuilder/SpriteBuilder/pull/1574","id":69515708,"number":1574,"title":"Publishing fixes.","user":{"login":"slembcke","id":153633,"avatar_url":"https://avatars.githubusercontent.com/u/153633?v=3","gravatar_id":"","url":"https://api.github.com/users/slembcke","html_url":"https://github.com/slembcke","followers_url":"https://api.github.com/users/slembcke/followers","following_url":"https://api.github.com/users/slembcke/following{/other_user}","gists_url":"https://api.github.com/users/slembcke/gists{/gist_id}","starred_url":"https://api.github.com/users/slembcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slembcke/subscriptions","organizations_url":"https://api.github.com/users/slembcke/orgs","repos_url":"https://api.github.com/users/slembcke/repos","events_url":"https://api.github.com/users/slembcke/events{/privacy}","received_events_url":"https://api.github.com/users/slembcke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-20T06:16:47Z","updated_at":"2015-04-20T19:33:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/pulls/1574","html_url":"https://github.com/spritebuilder/SpriteBuilder/pull/1574","diff_url":"https://github.com/spritebuilder/SpriteBuilder/pull/1574.diff","patch_url":"https://github.com/spritebuilder/SpriteBuilder/pull/1574.patch"},"body":"Two fixes so far:\r\n\r\n1. Added an argument to FCFormatConverter to request mipmap generation when exporting PVR files.\r\n2. Spritesheets were being generated incorrectly. (Ex: `Foo.plist` would contain references to `Bar-1x.png`, `Bar-2x.png` and `Bar-4x.png`) I'm not very certain that my fix for this is correct. It seems like there are a lot of dead paths through the code here that never actually happen.\r\n\r\nWill see how far I can get with the metadata generation tomorrow. It's preventing PVR and JPEG files from loading since there is no filename aliasing data exported yet.\r\n\r\n@rkachowski and/or @vlidholt  If you can review ASAP, that would be helpful. I'm don't know the publishing code very well."},"comment":{"url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/issues/comments/94548492","html_url":"https://github.com/spritebuilder/SpriteBuilder/pull/1574#issuecomment-94548492","issue_url":"https://api.github.com/repos/spritebuilder/SpriteBuilder/issues/1574","id":94548492,"user":{"login":"slembcke","id":153633,"avatar_url":"https://avatars.githubusercontent.com/u/153633?v=3","gravatar_id":"","url":"https://api.github.com/users/slembcke","html_url":"https://github.com/slembcke","followers_url":"https://api.github.com/users/slembcke/followers","following_url":"https://api.github.com/users/slembcke/following{/other_user}","gists_url":"https://api.github.com/users/slembcke/gists{/gist_id}","starred_url":"https://api.github.com/users/slembcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slembcke/subscriptions","organizations_url":"https://api.github.com/users/slembcke/orgs","repos_url":"https://api.github.com/users/slembcke/repos","events_url":"https://api.github.com/users/slembcke/events{/privacy}","received_events_url":"https://api.github.com/users/slembcke/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T19:33:28Z","updated_at":"2015-04-20T19:33:28Z","body":"A little more information about what I changed for the spritesheet fix. Say you were making a spritesheet out of this directory:\r\n\r\n```\r\nSprites/\r\n  foo.png\r\n  bar.png\r\n```\r\n\r\nIt would first rescale the images and output them into the old directory structure in a temporary location:\r\n\r\n```\r\nSomeTempFolder/\r\n  Sprites/ (Not sure what this dir was for...)\r\n  Sprites-phone/\r\n    foor.png\r\n    bar.png\r\n  Sprites-... (same for the -tablet, -tablethd directories)\r\n```\r\n\r\nThen it would make spritesheets out of the -phone, -tablet, etc directories and output them to their final location. Because of the change from directories to suffixes, this was happening:\r\n\r\n```\r\nSomeTempFolder/\r\n  Sprites/\r\n    foor-1x.png\r\n    bar-1x.png\r\n    foor-2x.png\r\n    bar-2x.png\r\n    foor-4x.png\r\n    bar-4x.png\r\n  Sprites-1x/ (these were all empty)\r\n  Sprites-2x/\r\n  Sprites-4x/\r\n```\r\n\r\nThe weird thing is that before, spritesheets would be made from both the files in `Sprites` and `Sprites-phone` (or -tablet, etc). AFAIK, the untagged directory would be empty. What I changed was to make it grab all of the (for example) -4x images, strip their resolution tags and build a spritesheet out of them. That's why I'm not terribly happy with the change, it's a little roundabout. Most of the filesystem work the conversion and spritesheet methods are doing seems unnecessary now. This could all be vastly simplified for v2, but it would probably be a lot of work."}}