{"action":"created","comment":{"url":"https://api.github.com/repos/ros/nodelet_core/pulls/comments/30448557","id":30448557,"diff_hunk":"@@ -127,6 +183,10 @@ class Nodelet\n   // Protected data fields for use by the subclass.\n protected:\n   inline const std::string& getName() const { return nodelet_name_; }\n+  inline std::string getSuffixedName(const std::string& suffix) const\n+  {\n+    return nodelet_name_ + std::string(\".\") + suffix;","path":"nodelet/include/nodelet/nodelet.h","position":69,"original_position":69,"commit_id":"59a5c538534ee92c776b31113d3d62e07c45857a","original_commit_id":"59a5c538534ee92c776b31113d3d62e07c45857a","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"As mentioned in my previous comment wrapping the string in `std::string` is not necessary.","created_at":"2015-05-15T21:42:45Z","updated_at":"2015-05-15T21:42:45Z","html_url":"https://github.com/ros/nodelet_core/pull/30#discussion_r30448557","pull_request_url":"https://api.github.com/repos/ros/nodelet_core/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/ros/nodelet_core/pulls/comments/30448557"},"html":{"href":"https://github.com/ros/nodelet_core/pull/30#discussion_r30448557"},"pull_request":{"href":"https://api.github.com/repos/ros/nodelet_core/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/ros/nodelet_core/pulls/30","id":35284736,"html_url":"https://github.com/ros/nodelet_core/pull/30","diff_url":"https://github.com/ros/nodelet_core/pull/30.diff","patch_url":"https://github.com/ros/nodelet_core/pull/30.patch","issue_url":"https://api.github.com/repos/ros/nodelet_core/issues/30","number":30,"state":"open","locked":false,"title":"Add support for named loggers in nodelet logging macros","user":{"login":"tfoote","id":447804,"avatar_url":"https://avatars.githubusercontent.com/u/447804?v=3","gravatar_id":"","url":"https://api.github.com/users/tfoote","html_url":"https://github.com/tfoote","followers_url":"https://api.github.com/users/tfoote/followers","following_url":"https://api.github.com/users/tfoote/following{/other_user}","gists_url":"https://api.github.com/users/tfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoote/subscriptions","organizations_url":"https://api.github.com/users/tfoote/orgs","repos_url":"https://api.github.com/users/tfoote/repos","events_url":"https://api.github.com/users/tfoote/events{/privacy}","received_events_url":"https://api.github.com/users/tfoote/received_events","type":"User","site_admin":false},"body":"@dirk-thomas @esteve @wjwwood for review\r\n\r\nThis will allow finer grained console logging inside of nodelets. ","created_at":"2015-05-13T00:35:08Z","updated_at":"2015-05-15T21:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbd52bece5676cf768d7419dc1da2dcea2174c6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros/nodelet_core/pulls/30/commits","review_comments_url":"https://api.github.com/repos/ros/nodelet_core/pulls/30/comments","review_comment_url":"https://api.github.com/repos/ros/nodelet_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/nodelet_core/issues/30/comments","statuses_url":"https://api.github.com/repos/ros/nodelet_core/statuses/59a5c538534ee92c776b31113d3d62e07c45857a","head":{"label":"ros:named_loggers","ref":"named_loggers","sha":"59a5c538534ee92c776b31113d3d62e07c45857a","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":5908550,"name":"nodelet_core","full_name":"ros/nodelet_core","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/nodelet_core","description":"Allows one to create \"nodelets\" -- ROS node-like entities that run within the same process so as to avoid IPC and serialization overhead","fork":false,"url":"https://api.github.com/repos/ros/nodelet_core","forks_url":"https://api.github.com/repos/ros/nodelet_core/forks","keys_url":"https://api.github.com/repos/ros/nodelet_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/nodelet_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/nodelet_core/teams","hooks_url":"https://api.github.com/repos/ros/nodelet_core/hooks","issue_events_url":"https://api.github.com/repos/ros/nodelet_core/issues/events{/number}","events_url":"https://api.github.com/repos/ros/nodelet_core/events","assignees_url":"https://api.github.com/repos/ros/nodelet_core/assignees{/user}","branches_url":"https://api.github.com/repos/ros/nodelet_core/branches{/branch}","tags_url":"https://api.github.com/repos/ros/nodelet_core/tags","blobs_url":"https://api.github.com/repos/ros/nodelet_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/nodelet_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/nodelet_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/nodelet_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/nodelet_core/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/nodelet_core/languages","stargazers_url":"https://api.github.com/repos/ros/nodelet_core/stargazers","contributors_url":"https://api.github.com/repos/ros/nodelet_core/contributors","subscribers_url":"https://api.github.com/repos/ros/nodelet_core/subscribers","subscription_url":"https://api.github.com/repos/ros/nodelet_core/subscription","commits_url":"https://api.github.com/repos/ros/nodelet_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/nodelet_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/nodelet_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/nodelet_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/nodelet_core/contents/{+path}","compare_url":"https://api.github.com/repos/ros/nodelet_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/nodelet_core/merges","archive_url":"https://api.github.com/repos/ros/nodelet_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/nodelet_core/downloads","issues_url":"https://api.github.com/repos/ros/nodelet_core/issues{/number}","pulls_url":"https://api.github.com/repos/ros/nodelet_core/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/nodelet_core/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/nodelet_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/nodelet_core/labels{/name}","releases_url":"https://api.github.com/repos/ros/nodelet_core/releases{/id}","created_at":"2012-09-21T23:21:34Z","updated_at":"2015-04-30T15:29:01Z","pushed_at":"2015-05-15T21:27:40Z","git_url":"git://github.com/ros/nodelet_core.git","ssh_url":"git@github.com:ros/nodelet_core.git","clone_url":"https://github.com/ros/nodelet_core.git","svn_url":"https://github.com/ros/nodelet_core","homepage":"http://www.ros.org/wiki/nodelet","size":2623,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":5,"default_branch":"indigo-devel"}},"base":{"label":"ros:indigo-devel","ref":"indigo-devel","sha":"647c050521557ca9083701e0505e2eee0b9d8227","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":5908550,"name":"nodelet_core","full_name":"ros/nodelet_core","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/nodelet_core","description":"Allows one to create \"nodelets\" -- ROS node-like entities that run within the same process so as to avoid IPC and serialization overhead","fork":false,"url":"https://api.github.com/repos/ros/nodelet_core","forks_url":"https://api.github.com/repos/ros/nodelet_core/forks","keys_url":"https://api.github.com/repos/ros/nodelet_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/nodelet_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/nodelet_core/teams","hooks_url":"https://api.github.com/repos/ros/nodelet_core/hooks","issue_events_url":"https://api.github.com/repos/ros/nodelet_core/issues/events{/number}","events_url":"https://api.github.com/repos/ros/nodelet_core/events","assignees_url":"https://api.github.com/repos/ros/nodelet_core/assignees{/user}","branches_url":"https://api.github.com/repos/ros/nodelet_core/branches{/branch}","tags_url":"https://api.github.com/repos/ros/nodelet_core/tags","blobs_url":"https://api.github.com/repos/ros/nodelet_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/nodelet_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/nodelet_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/nodelet_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/nodelet_core/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/nodelet_core/languages","stargazers_url":"https://api.github.com/repos/ros/nodelet_core/stargazers","contributors_url":"https://api.github.com/repos/ros/nodelet_core/contributors","subscribers_url":"https://api.github.com/repos/ros/nodelet_core/subscribers","subscription_url":"https://api.github.com/repos/ros/nodelet_core/subscription","commits_url":"https://api.github.com/repos/ros/nodelet_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/nodelet_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/nodelet_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/nodelet_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/nodelet_core/contents/{+path}","compare_url":"https://api.github.com/repos/ros/nodelet_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/nodelet_core/merges","archive_url":"https://api.github.com/repos/ros/nodelet_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/nodelet_core/downloads","issues_url":"https://api.github.com/repos/ros/nodelet_core/issues{/number}","pulls_url":"https://api.github.com/repos/ros/nodelet_core/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/nodelet_core/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/nodelet_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/nodelet_core/labels{/name}","releases_url":"https://api.github.com/repos/ros/nodelet_core/releases{/id}","created_at":"2012-09-21T23:21:34Z","updated_at":"2015-04-30T15:29:01Z","pushed_at":"2015-05-15T21:27:40Z","git_url":"git://github.com/ros/nodelet_core.git","ssh_url":"git@github.com:ros/nodelet_core.git","clone_url":"https://github.com/ros/nodelet_core.git","svn_url":"https://github.com/ros/nodelet_core","homepage":"http://www.ros.org/wiki/nodelet","size":2623,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":5,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/nodelet_core/pulls/30"},"html":{"href":"https://github.com/ros/nodelet_core/pull/30"},"issue":{"href":"https://api.github.com/repos/ros/nodelet_core/issues/30"},"comments":{"href":"https://api.github.com/repos/ros/nodelet_core/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/nodelet_core/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/nodelet_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/nodelet_core/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/ros/nodelet_core/statuses/59a5c538534ee92c776b31113d3d62e07c45857a"}}}}