{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/54","id":51081863,"html_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/54","diff_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/54.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/54.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/54","number":54,"state":"closed","locked":false,"title":"Refactor: GeoIP Struct processing, convert to hash once and store in cache","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"NOTES TO REVIEWERS:\r\n- Objective: to move the extensive and expensive hash manipulation (GeoIP Struct to hash) to the initial lookup and store the result in the cache.\r\n","created_at":"2015-11-18T13:09:27Z","updated_at":"2015-11-18T16:42:14Z","closed_at":"2015-11-18T16:42:14Z","merged_at":null,"merge_commit_sha":"f90051efe571fe04f0201aee7f299129d0bd18c4","assignee":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/54/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/54/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/54/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/statuses/a54fa947f7d3d2606835209e684d4abfd436a6b8","head":{"label":"guyboertje:fix/53","ref":"fix/53","sha":"a54fa947f7d3d2606835209e684d4abfd436a6b8","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"repo":{"id":46042024,"name":"logstash-filter-geoip","full_name":"guyboertje/logstash-filter-geoip","owner":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guyboertje/logstash-filter-geoip","description":null,"fork":true,"url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip","forks_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/forks","keys_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/teams","hooks_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/hooks","issue_events_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/issues/events{/number}","events_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/events","assignees_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/assignees{/user}","branches_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/branches{/branch}","tags_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/tags","blobs_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/git/refs{/sha}","trees_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/statuses/{sha}","languages_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/languages","stargazers_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/stargazers","contributors_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/contributors","subscribers_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/subscribers","subscription_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/subscription","commits_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/commits{/sha}","git_commits_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/git/commits{/sha}","comments_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/comments{/number}","issue_comment_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/issues/comments{/number}","contents_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/contents/{+path}","compare_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/merges","archive_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/downloads","issues_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/issues{/number}","pulls_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/pulls{/number}","milestones_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/milestones{/number}","notifications_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/labels{/name}","releases_url":"https://api.github.com/repos/guyboertje/logstash-filter-geoip/releases{/id}","created_at":"2015-11-12T09:15:58Z","updated_at":"2015-11-12T09:15:59Z","pushed_at":"2015-11-18T16:40:54Z","git_url":"git://github.com/guyboertje/logstash-filter-geoip.git","ssh_url":"git@github.com:guyboertje/logstash-filter-geoip.git","clone_url":"https://github.com/guyboertje/logstash-filter-geoip.git","svn_url":"https://github.com/guyboertje/logstash-filter-geoip","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"686eae8e2ea4105cfe5471864520ac0d93e32017","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":24894901,"name":"logstash-filter-geoip","full_name":"logstash-plugins/logstash-filter-geoip","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-geoip","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/releases{/id}","created_at":"2014-10-07T14:46:42Z","updated_at":"2015-10-13T22:36:28Z","pushed_at":"2015-11-18T16:42:14Z","git_url":"git://github.com/logstash-plugins/logstash-filter-geoip.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-geoip.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-geoip.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-geoip","homepage":null,"size":76,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":20,"forks":25,"open_issues":20,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/54"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/54"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/54"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/statuses/a54fa947f7d3d2606835209e684d4abfd436a6b8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":1,"commits":1,"additions":59,"deletions":40,"changed_files":4}}