{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/41138787","id":41138787,"diff_hunk":"@@ -1877,10 +1878,7 @@ def set_atom_string(self, block, block_items, existing_col, min_itemsize,\n         self.itemsize = itemsize\n         self.kind = 'string'\n         self.typ = self.get_atom_string(block, itemsize)\n-        self.set_data(self.convert_string_data(data, itemsize, encoding))\n-\n-    def convert_string_data(self, data, itemsize, encoding):\n-        return _convert_string_array(data, encoding, itemsize)\n+        self.set_data(data_converted.astype('|S%d' % itemsize))","path":"pandas/io/pytables.py","position":18,"original_position":18,"commit_id":"e9b2d2750f3a625adc9625c342d66ec05ddcf588","original_commit_id":"e9b2d2750f3a625adc9625c342d66ec05ddcf588","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"right that is ok (though maybe pass ``copy=False``) (e.g. if we didn't change it don't want to copy again)","created_at":"2015-10-05T12:43:24Z","updated_at":"2015-10-05T12:43:24Z","html_url":"https://github.com/pydata/pandas/pull/11240#discussion_r41138787","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/11240","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/41138787"},"html":{"href":"https://github.com/pydata/pandas/pull/11240#discussion_r41138787"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11240"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/11240","id":46736902,"html_url":"https://github.com/pydata/pandas/pull/11240","diff_url":"https://github.com/pydata/pandas/pull/11240.diff","patch_url":"https://github.com/pydata/pandas/pull/11240.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/11240","number":11240,"state":"open","locked":false,"title":"BUG: HDFStore.append with encoded string itemsize","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars.githubusercontent.com/u/1312546?v=3","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/pydata/pandas/issues/11234\r\n\r\nFailure came when the maximum length of the unencoded string\r\nwas smaller than the maximum encoded length.\r\n\r\nNeed to run a perf check still. We end up having to call `_convert_string_array` twice, once before we know the min_itemsize, and a second time just before appending once we do know the min itemsize.","created_at":"2015-10-05T00:15:36Z","updated_at":"2015-10-05T12:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43a9b0d65fac7820d267260c3ac82bae9ad1d8d4","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/37","html_url":"https://github.com/pydata/pandas/milestones/0.17.1","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/37/labels","id":1299459,"number":37,"title":"0.17.1","description":"after 0.17.0 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":0,"state":"open","created_at":"2015-09-10T14:30:44Z","updated_at":"2015-10-05T11:19:58Z","due_on":"2015-11-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/11240/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/11240/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/11240/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/e9b2d2750f3a625adc9625c342d66ec05ddcf588","head":{"label":"TomAugspurger:encoded-len","ref":"encoded-len","sha":"e9b2d2750f3a625adc9625c342d66ec05ddcf588","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars.githubusercontent.com/u/1312546?v=3","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"repo":{"id":9450481,"name":"pandas","full_name":"TomAugspurger/pandas","owner":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars.githubusercontent.com/u/1312546?v=3","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomAugspurger/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/TomAugspurger/pandas","forks_url":"https://api.github.com/repos/TomAugspurger/pandas/forks","keys_url":"https://api.github.com/repos/TomAugspurger/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomAugspurger/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomAugspurger/pandas/teams","hooks_url":"https://api.github.com/repos/TomAugspurger/pandas/hooks","issue_events_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/TomAugspurger/pandas/events","assignees_url":"https://api.github.com/repos/TomAugspurger/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/TomAugspurger/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/TomAugspurger/pandas/tags","blobs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomAugspurger/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomAugspurger/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomAugspurger/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/TomAugspurger/pandas/languages","stargazers_url":"https://api.github.com/repos/TomAugspurger/pandas/stargazers","contributors_url":"https://api.github.com/repos/TomAugspurger/pandas/contributors","subscribers_url":"https://api.github.com/repos/TomAugspurger/pandas/subscribers","subscription_url":"https://api.github.com/repos/TomAugspurger/pandas/subscription","commits_url":"https://api.github.com/repos/TomAugspurger/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomAugspurger/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomAugspurger/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomAugspurger/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/TomAugspurger/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomAugspurger/pandas/merges","archive_url":"https://api.github.com/repos/TomAugspurger/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomAugspurger/pandas/downloads","issues_url":"https://api.github.com/repos/TomAugspurger/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/TomAugspurger/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/TomAugspurger/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/TomAugspurger/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomAugspurger/pandas/labels{/name}","releases_url":"https://api.github.com/repos/TomAugspurger/pandas/releases{/id}","created_at":"2013-04-15T14:23:40Z","updated_at":"2015-06-09T07:27:54Z","pushed_at":"2015-10-05T12:37:41Z","git_url":"git://github.com/TomAugspurger/pandas.git","ssh_url":"git@github.com:TomAugspurger/pandas.git","clone_url":"https://github.com/TomAugspurger/pandas.git","svn_url":"https://github.com/TomAugspurger/pandas","homepage":"http://pandas.pydata.org","size":66201,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"0cd67345ceb715ab412e67d6f5f6504de4c96650","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-10-05T11:08:32Z","pushed_at":"2015-10-05T12:38:34Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":160758,"stargazers_count":5051,"watchers_count":5051,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1958,"mirror_url":null,"open_issues_count":1501,"forks":1958,"open_issues":1501,"watchers":5051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11240"},"html":{"href":"https://github.com/pydata/pandas/pull/11240"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/11240"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/11240/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11240/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11240/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/e9b2d2750f3a625adc9625c342d66ec05ddcf588"}}}}