{"action":"opened","issue":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/832","labels_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/832/labels{/name}","comments_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/832/comments","events_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/832/events","html_url":"https://github.com/Unvanquished/Unvanquished/issues/832","id":115988611,"number":832,"title":"Incorrect usages of std::move","user":{"login":"mbasaglia","id":2465791,"avatar_url":"https://avatars.githubusercontent.com/u/2465791?v=3","gravatar_id":"","url":"https://api.github.com/users/mbasaglia","html_url":"https://github.com/mbasaglia","followers_url":"https://api.github.com/users/mbasaglia/followers","following_url":"https://api.github.com/users/mbasaglia/following{/other_user}","gists_url":"https://api.github.com/users/mbasaglia/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasaglia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasaglia/subscriptions","organizations_url":"https://api.github.com/users/mbasaglia/orgs","repos_url":"https://api.github.com/users/mbasaglia/repos","events_url":"https://api.github.com/users/mbasaglia/events{/privacy}","received_events_url":"https://api.github.com/users/mbasaglia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-11-09T23:09:27Z","updated_at":"2015-11-09T23:09:27Z","closed_at":null,"body":"I've came across some incorrect usages of std::move, for now I'm fixing CvarSystem, but it might be the case that it's used incorrectly throughout the codebase.\r\n\r\nSome instances are probably innocuous but useless, others can have a slight negative impact on performance (Forcing a premature conversion from an prvalue to a lvalue).\r\nBut the biggest issue is that some places read from a moved-from variable, which results at best in an unspecified value, at worst undefined behaviour."}}