{"action":"created","issue":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/957","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/957/labels{/name}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/957/comments","events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/957/events","html_url":"https://github.com/rockstor/rockstor-core/pull/957","id":111457729,"number":957,"title":"smart data collection broken Fixes #657","user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-14T18:11:55Z","updated_at":"2015-10-17T16:13:33Z","closed_at":"2015-10-17T15:39:54Z","pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/957","html_url":"https://github.com/rockstor/rockstor-core/pull/957","diff_url":"https://github.com/rockstor/rockstor-core/pull/957.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/957.patch"},"body":"In some instances it seems that smartctl -l error returned a command line error of 64. This was correctly caught by Rockstor but interpreted as a failed command execution. In tests on several drives that displayed this wall of red text error that looked like a failure this pr produces valid smartctl error logs.\r\nAs this is an error condition I have added an email root function that is executed when this error code is encountered. N.B. if one refreshes smart data read via the web ui refresh button on a drive with S.M.A.R.T errors logged this email will be triggered. Note that I don't thing that all drives are capable of self logging.\r\n\r\nSubmitting as is for code review and further testing / analysis of my silencing an exception.\r\n\r\nemail part tested with and without email notifications enabled."},"comment":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments/148928799","html_url":"https://github.com/rockstor/rockstor-core/pull/957#issuecomment-148928799","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/957","id":148928799,"user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"created_at":"2015-10-17T16:13:33Z","updated_at":"2015-10-17T16:13:33Z","body":"Thanks @schakrava  and Cheers."}}