{"action":"created","comment":{"url":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments/29956592","id":29956592,"diff_hunk":"@@ -0,0 +1,349 @@\n+\n+\n+### Function declarations\n+\n+## 1\n+fun <- function(argument1,\n+                argument2) {\n+    body\n+}\n+\n+## 2\n+function(\n+    argument1,\n+    argument2\n+    )\n+    {\n+        body\n+    }\n+\n+## 3\n+function(argument_fun(sub_argument1,\n+                      sub_argument2),\n+         argument) {}\n+\n+## 4\n+function(argument1, parameter = fun_call(\n+                        sub_argument),\n+         argument2) {}\n+\n+\n+\n+### Function calls\n+\n+## 5\n+fun_call(argument1,\n+         argument2)\n+\n+## 6\n+fun_call(\n+    argument1,\n+    argument2\n+    )\n+\n+## 7\n+fun_call(parameter = (\n+    stuff\n+    ),\n+         argument)\n+\n+## 8\n+fun_call(parameter = fun_argument(\n+             stuff\n+    ),\n+         argument)\n+\n+\n+\n+### Blocks\n+\n+## 9\n+function()\n+    {\n+        body\n+    }\n+\n+## 10\n+fun_call(parameter1 = {\n+             stuff1\n+         },\n+         {\n+             stuff2\n+         }, parameter2 = {\n+             stuff3\n+         }, {\n+             stuff4\n+         },\n+         parameter3 =\n+             stuff5 ~\n+                 stuff6 +\n+                     stuff7)\n+\n+## 11\n+fun <- fun_call({\n+    stuff1\n+}, {\n+    stuff2\n+},\n+                {\n+                    stuff3\n+                }\n+                )\n+\n+## 12\n+fun_call(function(x) {\n+             body1\n+         },\n+         function(x) {\n+             body2\n+         })\n+\n+## 13\n+object <-\n+    fun_call({\n+        body\n+    })\n+\n+## 14\n+object <-\n+    fun_call(     {\n+                 body\n+             }\n+             )\n+\n+## 15\n+{\n+    {\n+        stuff\n+    }\n+}\n+\n+## 16\n+{{\n+     stuff\n+ }\n+}\n+\n+## 17\n+({\n+    stuff\n+})\n+\n+## 18\n+( {\n+     stuff\n+ }\n+ )\n+\n+## 19\n+object[\n+       argument1,\n+       argument2\n+       ]\n+\n+## 20\n+{\n+    object[\n+           fun_call(\n+               body\n+               ),\n+           argument[\n+                    (\n+                        sub_argument\n+                        )\n+                    ]\n+           ]\n+}\n+\n+\n+\n+### Control flow\n+\n+## 21\n+if (condition) {\n+    stuff1\n+} else {\n+    stuff2\n+}\n+\n+## 22\n+if (condition) {\n+    stuff1\n+}\n+else {\n+    stuff2\n+}\n+\n+## 23\n+if (condition)\n+    {\n+        stuff1\n+    } else\n+        {\n+            stuff2\n+        }\n+\n+## 24\n+if (condition)\n+    {\n+        stuff1\n+    }\n+else\n+    {\n+        stuff2\n+    }\n+\n+## 25\n+for (sequence)\n+    {\n+        stuff\n+    }\n+\n+## 26\n+for (sequence) {\n+    stuff\n+}\n+\n+## 27\n+if (condition)\n+    stuff\n+\n+## 28\n+for (sequence)\n+    stuff\n+\n+\n+\n+### Continuation lines\n+\n+## 29","path":"test/indentation-test-RRR.R","position":219,"original_position":219,"commit_id":"e78057e3e05f96e7fc6fc2d2c468b0bde67799c6","original_commit_id":"e78057e3e05f96e7fc6fc2d2c468b0bde67799c6","user":{"login":"vspinu","id":1363467,"avatar_url":"https://avatars.githubusercontent.com/u/1363467?v=3","gravatar_id":"","url":"https://api.github.com/users/vspinu","html_url":"https://github.com/vspinu","followers_url":"https://api.github.com/users/vspinu/followers","following_url":"https://api.github.com/users/vspinu/following{/other_user}","gists_url":"https://api.github.com/users/vspinu/gists{/gist_id}","starred_url":"https://api.github.com/users/vspinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vspinu/subscriptions","organizations_url":"https://api.github.com/users/vspinu/orgs","repos_url":"https://api.github.com/users/vspinu/repos","events_url":"https://api.github.com/users/vspinu/events{/privacy}","received_events_url":"https://api.github.com/users/vspinu/received_events","type":"User","site_admin":false},"body":"I think it would wiser to start new numbering in each section. We will surely be adding stuff in the future and it would be nice to keep clean numbering without the need to modify everything else.","created_at":"2015-05-08T17:01:40Z","updated_at":"2015-05-08T17:01:40Z","html_url":"https://github.com/emacs-ess/ESS/pull/175#discussion_r29956592","pull_request_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments/29956592"},"html":{"href":"https://github.com/emacs-ess/ESS/pull/175#discussion_r29956592"},"pull_request":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/emacs-ess/ESS/pulls/175","id":35003693,"html_url":"https://github.com/emacs-ess/ESS/pull/175","diff_url":"https://github.com/emacs-ess/ESS/pull/175.diff","patch_url":"https://github.com/emacs-ess/ESS/pull/175.patch","issue_url":"https://api.github.com/repos/emacs-ess/ESS/issues/175","number":175,"state":"open","locked":false,"title":"ERT testing framework and indentation test cases","user":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"body":"Here is the testing framework discussed in #174.\r\n\r\nThe tests can be run with `./run-tests` (needs to be launched from the test directory) and the indentation test files can be regenerated with `./run-tests --generate-indent-cases`.\r\n\r\nThe latter will:\r\n* (re)generate test files based on all configurations contained in the variable `ess-test-style-alist`.\r\n* take the `indentation-test-RRR.R` file as a model so any addition or modification of the test cases should be done in this file.\r\n\r\nCurrently the tests are broken because I have added this `test-misc1` configuration that makes ESS indentation fail with an error :-). It fails on the test cases 11, 13, 17 and 20.\r\n\r\nSo this PR can be merged and we can correct this bug later. We'll have `./run-tests` to check everything is fixed.","created_at":"2015-05-08T12:17:58Z","updated_at":"2015-05-08T17:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebba4721e3882441e28c976c5169a8c50bf76a28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/175/commits","review_comments_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/175/comments","review_comment_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/issues/175/comments","statuses_url":"https://api.github.com/repos/emacs-ess/ESS/statuses/e78057e3e05f96e7fc6fc2d2c468b0bde67799c6","head":{"label":"lionel-:indent-tests","ref":"indent-tests","sha":"e78057e3e05f96e7fc6fc2d2c468b0bde67799c6","user":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"repo":{"id":34910721,"name":"ESS","full_name":"lionel-/ESS","owner":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lionel-/ESS","description":"Git development branch","fork":true,"url":"https://api.github.com/repos/lionel-/ESS","forks_url":"https://api.github.com/repos/lionel-/ESS/forks","keys_url":"https://api.github.com/repos/lionel-/ESS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lionel-/ESS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lionel-/ESS/teams","hooks_url":"https://api.github.com/repos/lionel-/ESS/hooks","issue_events_url":"https://api.github.com/repos/lionel-/ESS/issues/events{/number}","events_url":"https://api.github.com/repos/lionel-/ESS/events","assignees_url":"https://api.github.com/repos/lionel-/ESS/assignees{/user}","branches_url":"https://api.github.com/repos/lionel-/ESS/branches{/branch}","tags_url":"https://api.github.com/repos/lionel-/ESS/tags","blobs_url":"https://api.github.com/repos/lionel-/ESS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lionel-/ESS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lionel-/ESS/git/refs{/sha}","trees_url":"https://api.github.com/repos/lionel-/ESS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lionel-/ESS/statuses/{sha}","languages_url":"https://api.github.com/repos/lionel-/ESS/languages","stargazers_url":"https://api.github.com/repos/lionel-/ESS/stargazers","contributors_url":"https://api.github.com/repos/lionel-/ESS/contributors","subscribers_url":"https://api.github.com/repos/lionel-/ESS/subscribers","subscription_url":"https://api.github.com/repos/lionel-/ESS/subscription","commits_url":"https://api.github.com/repos/lionel-/ESS/commits{/sha}","git_commits_url":"https://api.github.com/repos/lionel-/ESS/git/commits{/sha}","comments_url":"https://api.github.com/repos/lionel-/ESS/comments{/number}","issue_comment_url":"https://api.github.com/repos/lionel-/ESS/issues/comments{/number}","contents_url":"https://api.github.com/repos/lionel-/ESS/contents/{+path}","compare_url":"https://api.github.com/repos/lionel-/ESS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lionel-/ESS/merges","archive_url":"https://api.github.com/repos/lionel-/ESS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lionel-/ESS/downloads","issues_url":"https://api.github.com/repos/lionel-/ESS/issues{/number}","pulls_url":"https://api.github.com/repos/lionel-/ESS/pulls{/number}","milestones_url":"https://api.github.com/repos/lionel-/ESS/milestones{/number}","notifications_url":"https://api.github.com/repos/lionel-/ESS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lionel-/ESS/labels{/name}","releases_url":"https://api.github.com/repos/lionel-/ESS/releases{/id}","created_at":"2015-05-01T15:59:38Z","updated_at":"2015-05-01T15:59:40Z","pushed_at":"2015-05-08T16:09:18Z","git_url":"git://github.com/lionel-/ESS.git","ssh_url":"git@github.com:lionel-/ESS.git","clone_url":"https://github.com/lionel-/ESS.git","svn_url":"https://github.com/lionel-/ESS","homepage":"http://ess.r-project.org/","size":20053,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emacs-ess:master","ref":"master","sha":"982bfad997ccdb1e921aff620aeb1d821a6bcd06","user":{"login":"emacs-ess","id":1433218,"avatar_url":"https://avatars.githubusercontent.com/u/1433218?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-ess","html_url":"https://github.com/emacs-ess","followers_url":"https://api.github.com/users/emacs-ess/followers","following_url":"https://api.github.com/users/emacs-ess/following{/other_user}","gists_url":"https://api.github.com/users/emacs-ess/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-ess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-ess/subscriptions","organizations_url":"https://api.github.com/users/emacs-ess/orgs","repos_url":"https://api.github.com/users/emacs-ess/repos","events_url":"https://api.github.com/users/emacs-ess/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-ess/received_events","type":"Organization","site_admin":false},"repo":{"id":3585447,"name":"ESS","full_name":"emacs-ess/ESS","owner":{"login":"emacs-ess","id":1433218,"avatar_url":"https://avatars.githubusercontent.com/u/1433218?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-ess","html_url":"https://github.com/emacs-ess","followers_url":"https://api.github.com/users/emacs-ess/followers","following_url":"https://api.github.com/users/emacs-ess/following{/other_user}","gists_url":"https://api.github.com/users/emacs-ess/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-ess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-ess/subscriptions","organizations_url":"https://api.github.com/users/emacs-ess/orgs","repos_url":"https://api.github.com/users/emacs-ess/repos","events_url":"https://api.github.com/users/emacs-ess/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-ess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emacs-ess/ESS","description":"Git development branch","fork":false,"url":"https://api.github.com/repos/emacs-ess/ESS","forks_url":"https://api.github.com/repos/emacs-ess/ESS/forks","keys_url":"https://api.github.com/repos/emacs-ess/ESS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emacs-ess/ESS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emacs-ess/ESS/teams","hooks_url":"https://api.github.com/repos/emacs-ess/ESS/hooks","issue_events_url":"https://api.github.com/repos/emacs-ess/ESS/issues/events{/number}","events_url":"https://api.github.com/repos/emacs-ess/ESS/events","assignees_url":"https://api.github.com/repos/emacs-ess/ESS/assignees{/user}","branches_url":"https://api.github.com/repos/emacs-ess/ESS/branches{/branch}","tags_url":"https://api.github.com/repos/emacs-ess/ESS/tags","blobs_url":"https://api.github.com/repos/emacs-ess/ESS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emacs-ess/ESS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emacs-ess/ESS/git/refs{/sha}","trees_url":"https://api.github.com/repos/emacs-ess/ESS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emacs-ess/ESS/statuses/{sha}","languages_url":"https://api.github.com/repos/emacs-ess/ESS/languages","stargazers_url":"https://api.github.com/repos/emacs-ess/ESS/stargazers","contributors_url":"https://api.github.com/repos/emacs-ess/ESS/contributors","subscribers_url":"https://api.github.com/repos/emacs-ess/ESS/subscribers","subscription_url":"https://api.github.com/repos/emacs-ess/ESS/subscription","commits_url":"https://api.github.com/repos/emacs-ess/ESS/commits{/sha}","git_commits_url":"https://api.github.com/repos/emacs-ess/ESS/git/commits{/sha}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/comments{/number}","issue_comment_url":"https://api.github.com/repos/emacs-ess/ESS/issues/comments{/number}","contents_url":"https://api.github.com/repos/emacs-ess/ESS/contents/{+path}","compare_url":"https://api.github.com/repos/emacs-ess/ESS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emacs-ess/ESS/merges","archive_url":"https://api.github.com/repos/emacs-ess/ESS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emacs-ess/ESS/downloads","issues_url":"https://api.github.com/repos/emacs-ess/ESS/issues{/number}","pulls_url":"https://api.github.com/repos/emacs-ess/ESS/pulls{/number}","milestones_url":"https://api.github.com/repos/emacs-ess/ESS/milestones{/number}","notifications_url":"https://api.github.com/repos/emacs-ess/ESS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emacs-ess/ESS/labels{/name}","releases_url":"https://api.github.com/repos/emacs-ess/ESS/releases{/id}","created_at":"2012-02-29T20:13:38Z","updated_at":"2015-05-06T10:45:42Z","pushed_at":"2015-05-08T16:09:19Z","git_url":"git://github.com/emacs-ess/ESS.git","ssh_url":"git@github.com:emacs-ess/ESS.git","clone_url":"https://github.com/emacs-ess/ESS.git","svn_url":"https://github.com/emacs-ess/ESS","homepage":"http://ess.r-project.org/","size":21971,"stargazers_count":182,"watchers_count":182,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":50,"forks":55,"open_issues":50,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/175"},"html":{"href":"https://github.com/emacs-ess/ESS/pull/175"},"issue":{"href":"https://api.github.com/repos/emacs-ess/ESS/issues/175"},"comments":{"href":"https://api.github.com/repos/emacs-ess/ESS/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/emacs-ess/ESS/statuses/e78057e3e05f96e7fc6fc2d2c468b0bde67799c6"}}}}