{"action":"created","issue":{"url":"https://api.github.com/repos/dell-asm/puppet-transport/issues/7","labels_url":"https://api.github.com/repos/dell-asm/puppet-transport/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/dell-asm/puppet-transport/issues/7/comments","events_url":"https://api.github.com/repos/dell-asm/puppet-transport/issues/7/events","html_url":"https://github.com/dell-asm/puppet-transport/pull/7","id":105434437,"number":7,"title":"ASM-4753  Reconfigure HA","user":{"login":"logankimmel","id":3628618,"avatar_url":"https://avatars.githubusercontent.com/u/3628618?v=3","gravatar_id":"","url":"https://api.github.com/users/logankimmel","html_url":"https://github.com/logankimmel","followers_url":"https://api.github.com/users/logankimmel/followers","following_url":"https://api.github.com/users/logankimmel/following{/other_user}","gists_url":"https://api.github.com/users/logankimmel/gists{/gist_id}","starred_url":"https://api.github.com/users/logankimmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logankimmel/subscriptions","organizations_url":"https://api.github.com/users/logankimmel/orgs","repos_url":"https://api.github.com/users/logankimmel/repos","events_url":"https://api.github.com/users/logankimmel/events{/privacy}","received_events_url":"https://api.github.com/users/logankimmel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-08T17:44:11Z","updated_at":"2015-09-09T00:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dell-asm/puppet-transport/pulls/7","html_url":"https://github.com/dell-asm/puppet-transport/pull/7","diff_url":"https://github.com/dell-asm/puppet-transport/pull/7.diff","patch_url":"https://github.com/dell-asm/puppet-transport/pull/7.patch"},"body":"Added the endpoint param to override the name for the device_config\r\nparse.  We can't re-use two puppet resources with the same name so this\r\nis an extra param for when we have to define a vcenter transport more\r\nthan once. For example, in the firmware update manifest"},"comment":{"url":"https://api.github.com/repos/dell-asm/puppet-transport/issues/comments/138741100","html_url":"https://github.com/dell-asm/puppet-transport/pull/7#issuecomment-138741100","issue_url":"https://api.github.com/repos/dell-asm/puppet-transport/issues/7","id":138741100,"user":{"login":"gavin-scott","id":6208219,"avatar_url":"https://avatars.githubusercontent.com/u/6208219?v=3","gravatar_id":"","url":"https://api.github.com/users/gavin-scott","html_url":"https://github.com/gavin-scott","followers_url":"https://api.github.com/users/gavin-scott/followers","following_url":"https://api.github.com/users/gavin-scott/following{/other_user}","gists_url":"https://api.github.com/users/gavin-scott/gists{/gist_id}","starred_url":"https://api.github.com/users/gavin-scott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavin-scott/subscriptions","organizations_url":"https://api.github.com/users/gavin-scott/orgs","repos_url":"https://api.github.com/users/gavin-scott/repos","events_url":"https://api.github.com/users/gavin-scott/events{/privacy}","received_events_url":"https://api.github.com/users/gavin-scott/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T00:43:13Z","updated_at":"2015-09-09T00:43:13Z","body":"I'm still not wild about the extra complexity we are introducing with these changes. Here are my ideas for what might be a better idea (but maybe is too complex for a 8.1.1 patch):\r\n\r\n1. The vcenter_hadrs defined type should take the transport as a metaparameter the way all our other vcenter-related defined types do. E.g. the vcenter::cluter type: https://github.com/dell-asm/vmware-vcenter/blob/fddee78eef86c0a5b16bbd1fc1dc0f0dc8cb5470/manifests/cluster.pp#L8 The ensure_resource code can then be removed.\r\n2. The transport will now need to be created in asm-deployer when it creates the vcenter_hadrs resource and passed in as a parameter. E.g. here https://github.com/dell-asm/asm-deployer/blob/b47faebb9f5c324e789fc153cc8b93229a9f6db3/lib/asm/service_deployment.rb#L4283 and I think there is another location.\r\n3. To address the possible timeout of the transport while we are running a firmware update we could add retry in the vcenter transport. We may even have such logic already. I'm actually not convinced we ever saw this problem -- the error would have presented itself in a very similar manner to the bug we are fixing here, e.g. with a \"Operation timed out\" type error.\r\n\r\nIf 3 was never really problem we don't even have to do 1 & 2 here..."}}