{"action":"created","issue":{"url":"https://api.github.com/repos/codefordc/clean-slate/issues/32","labels_url":"https://api.github.com/repos/codefordc/clean-slate/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/codefordc/clean-slate/issues/32/comments","events_url":"https://api.github.com/repos/codefordc/clean-slate/issues/32/events","html_url":"https://github.com/codefordc/clean-slate/pull/32","id":74108151,"number":32,"title":"Created Results Page","user":{"login":"jrleszcz","id":7838603,"avatar_url":"https://avatars.githubusercontent.com/u/7838603?v=3","gravatar_id":"","url":"https://api.github.com/users/jrleszcz","html_url":"https://github.com/jrleszcz","followers_url":"https://api.github.com/users/jrleszcz/followers","following_url":"https://api.github.com/users/jrleszcz/following{/other_user}","gists_url":"https://api.github.com/users/jrleszcz/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleszcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleszcz/subscriptions","organizations_url":"https://api.github.com/users/jrleszcz/orgs","repos_url":"https://api.github.com/users/jrleszcz/repos","events_url":"https://api.github.com/users/jrleszcz/events{/privacy}","received_events_url":"https://api.github.com/users/jrleszcz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-05-07T19:59:42Z","updated_at":"2015-05-08T00:20:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codefordc/clean-slate/pulls/32","html_url":"https://github.com/codefordc/clean-slate/pull/32","diff_url":"https://github.com/codefordc/clean-slate/pull/32.diff","patch_url":"https://github.com/codefordc/clean-slate/pull/32.patch"},"body":"I made a separate results page and a new ResultsController, moved the question/answer history into a table, and added print, e-mail, and start over buttons.\r\n\r\nI ran out of time to work on this today but wanted to send this out in case someone has time to start styling the page.  Currently the table has no CSS applied but the markup is there. \r\n\r\nThe e-mail button doesn't work yet.\r\n\r\nThe print button works, but just prints the whole page, and we might want to write css for the printer to remove things like the buttons (or we could do this with javascript).\r\n\r\nFinally, I wanted to note that I am now storing the question/answer history in a global variable outside of EligibilityWizardController so that ResultsController can see it.  This works for now, but it would be better to create a custom Angular Service to pass the data between controllers. "},"comment":{"url":"https://api.github.com/repos/codefordc/clean-slate/issues/comments/100053600","html_url":"https://github.com/codefordc/clean-slate/pull/32#issuecomment-100053600","issue_url":"https://api.github.com/repos/codefordc/clean-slate/issues/32","id":100053600,"user":{"login":"cweems","id":1418949,"avatar_url":"https://avatars.githubusercontent.com/u/1418949?v=3","gravatar_id":"","url":"https://api.github.com/users/cweems","html_url":"https://github.com/cweems","followers_url":"https://api.github.com/users/cweems/followers","following_url":"https://api.github.com/users/cweems/following{/other_user}","gists_url":"https://api.github.com/users/cweems/gists{/gist_id}","starred_url":"https://api.github.com/users/cweems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweems/subscriptions","organizations_url":"https://api.github.com/users/cweems/orgs","repos_url":"https://api.github.com/users/cweems/repos","events_url":"https://api.github.com/users/cweems/events{/privacy}","received_events_url":"https://api.github.com/users/cweems/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T00:20:48Z","updated_at":"2015-05-08T00:20:48Z","body":"@jrleszcz another issue to consider for the results page is how to persist the data if the user refreshes. We could do this with a cookie, but I'm a bit worried about user privacy in the instance where someone uses this from a public computer. \r\n\r\nCreating an actual accounts framework would be the most comprehensive way to address this, but it also has the tradeoff that users would have to sign up. Besides being an automatic dropoff point, I think folks could be really nervous about providing any potentially personal information.\r\n\r\nThe good news is that even is a user refreshes mid-process, they will still end up at the correct eligibility state. They would just loose a portion of their history. This might be a bigger issue to talk about at the next meetup, but totally open to suggestions.\r\n\r\nIn the meantime, I'm planning on implementing gulp to automate our build process (i.e. comment remove and minification for distribution). I'll be sure to document the gulp commands I create in the readme!"}}