{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13799","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13799/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13799/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13799/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13799","id":112587073,"number":13799,"title":"String input options. Default character name.","user":{"login":"OzoneH3","id":3514404,"avatar_url":"https://avatars.githubusercontent.com/u/3514404?v=3","gravatar_id":"","url":"https://api.github.com/users/OzoneH3","html_url":"https://github.com/OzoneH3","followers_url":"https://api.github.com/users/OzoneH3/followers","following_url":"https://api.github.com/users/OzoneH3/following{/other_user}","gists_url":"https://api.github.com/users/OzoneH3/gists{/gist_id}","starred_url":"https://api.github.com/users/OzoneH3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OzoneH3/subscriptions","organizations_url":"https://api.github.com/users/OzoneH3/orgs","repos_url":"https://api.github.com/users/OzoneH3/repos","events_url":"https://api.github.com/users/OzoneH3/events{/privacy}","received_events_url":"https://api.github.com/users/OzoneH3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-21T13:25:18Z","updated_at":"2015-10-21T13:29:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13799","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13799","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13799.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13799.patch"},"body":"Allow options to store userdefined strings.\r\nProof of concept with default character naming: Closes #2110\r\n\r\nThis is somwhat dependant on #13787 in as you can't use spaces, otherwise it wont load the string back up. On input it removes all \" to not mess up future json saves.\r\n\r\n![](http://i.imgur.com/JMjLo62.png)"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/149894401","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13799#issuecomment-149894401","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13799","id":149894401,"user":{"login":"narc0tiq","id":591573,"avatar_url":"https://avatars.githubusercontent.com/u/591573?v=3","gravatar_id":"","url":"https://api.github.com/users/narc0tiq","html_url":"https://github.com/narc0tiq","followers_url":"https://api.github.com/users/narc0tiq/followers","following_url":"https://api.github.com/users/narc0tiq/following{/other_user}","gists_url":"https://api.github.com/users/narc0tiq/gists{/gist_id}","starred_url":"https://api.github.com/users/narc0tiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narc0tiq/subscriptions","organizations_url":"https://api.github.com/users/narc0tiq/orgs","repos_url":"https://api.github.com/users/narc0tiq/repos","events_url":"https://api.github.com/users/narc0tiq/events{/privacy}","received_events_url":"https://api.github.com/users/narc0tiq/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T13:29:48Z","updated_at":"2015-10-21T13:29:48Z","body":"Uh, I'm pretty sure JSON allows escaping quotes (as `\\\"`), so as long as\n#13787 is in place, you should be good to go there. Stripping user input is\nrarely the way to go; doing so silently is even worse!\n\nOn Wed, Oct 21, 2015 at 4:25 PM, OzoneH3 <notifications@github.com> wrote:\n\n> Allow options to store userdefined strings.\n> Proof of concept with default character naming: Closes #2110\n> <https://github.com/CleverRaven/Cataclysm-DDA/issues/2110>\n>\n> This is somwhat dependant on #13787\n> <https://github.com/CleverRaven/Cataclysm-DDA/pull/13787> in as you can't\n> use spaces, otherwise it wont load the string back up. On input it removes\n> all \" to not mess up future json saves.\n>\n>\n> <https://camo.githubusercontent.com/7d6263095d7beec8b363f6e7e7d42665f4e9416c/687474703a2f2f692e696d6775722e636f6d2f4a4d6a4c6f36322e706e67>\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/CleverRaven/Cataclysm-DDA/pull/13799\n> Commit Summary\n>\n>    - String input options. Default character name.\n>\n> File Changes\n>\n>    - *M* src/character.h\n>    <https://github.com/CleverRaven/Cataclysm-DDA/pull/13799/files#diff-0>\n>    (2)\n>    - *M* src/newcharacter.cpp\n>    <https://github.com/CleverRaven/Cataclysm-DDA/pull/13799/files#diff-1>\n>    (12)\n>    - *M* src/options.cpp\n>    <https://github.com/CleverRaven/Cataclysm-DDA/pull/13799/files#diff-2>\n>    (85)\n>    - *M* src/options.h\n>    <https://github.com/CleverRaven/Cataclysm-DDA/pull/13799/files#diff-3>\n>    (8)\n>\n> Patch Links:\n>\n>    - https://github.com/CleverRaven/Cataclysm-DDA/pull/13799.patch\n>    - https://github.com/CleverRaven/Cataclysm-DDA/pull/13799.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/CleverRaven/Cataclysm-DDA/pull/13799>.\n>\n"}}