{"action":"created","comment":{"url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/comments/44224993","id":44224993,"diff_hunk":"@@ -45,37 +50,101 @@\n     private Encoding encoding;\n     private Writer encodingWriter;\n \n-    /**\n-     * Constructor:  Connect to the PostgreSQL back end and return\n-     * a stream connection.\n-     *\n-     * @param hostSpec the host and port to connect to\n-     * @param timeout timeout in milliseconds, or 0 if no timeout set\n-     * @exception IOException if an IOException occurs below it.\n-     */\n-    public PGStream(HostSpec hostSpec, int timeout) throws IOException\n+    private final SocketFactory socketFactory;\n+\n+//    /**\n+//     * Constructor:  Connect to the PostgreSQL back end and return\n+//     * a stream connection.\n+//     *\n+//     * @param hostSpec the host and port to connect to\n+//     * @param timeout timeout in milliseconds, or 0 if no timeout set\n+//     * @exception IOException if an IOException occurs below it.\n+//     */\n+//    public PGStream(HostSpec hostSpec, int timeout) throws IOException\n+//    {","path":"org/postgresql/core/PGStream.java","position":36,"original_position":36,"commit_id":"87c7e42da17ce61c47699608006728b19831b41d","original_commit_id":"87c7e42da17ce61c47699608006728b19831b41d","user":{"login":"vlsi","id":213894,"avatar_url":"https://avatars.githubusercontent.com/u/213894?v=3","gravatar_id":"","url":"https://api.github.com/users/vlsi","html_url":"https://github.com/vlsi","followers_url":"https://api.github.com/users/vlsi/followers","following_url":"https://api.github.com/users/vlsi/following{/other_user}","gists_url":"https://api.github.com/users/vlsi/gists{/gist_id}","starred_url":"https://api.github.com/users/vlsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlsi/subscriptions","organizations_url":"https://api.github.com/users/vlsi/orgs","repos_url":"https://api.github.com/users/vlsi/repos","events_url":"https://api.github.com/users/vlsi/events{/privacy}","received_events_url":"https://api.github.com/users/vlsi/received_events","type":"User","site_admin":false},"body":"Why do you add commented-out code? Can you please drop it?","created_at":"2015-11-08T14:03:27Z","updated_at":"2015-11-08T14:03:27Z","html_url":"https://github.com/pgjdbc/pgjdbc/pull/415#discussion_r44224993","pull_request_url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415","_links":{"self":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/comments/44224993"},"html":{"href":"https://github.com/pgjdbc/pgjdbc/pull/415#discussion_r44224993"},"pull_request":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415"}}},"pull_request":{"url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415","id":49538103,"html_url":"https://github.com/pgjdbc/pgjdbc/pull/415","diff_url":"https://github.com/pgjdbc/pgjdbc/pull/415.diff","patch_url":"https://github.com/pgjdbc/pgjdbc/pull/415.patch","issue_url":"https://api.github.com/repos/pgjdbc/pgjdbc/issues/415","number":415,"state":"open","locked":false,"title":"Unixsocket branch","user":{"login":"matthiastran","id":4355693,"avatar_url":"https://avatars.githubusercontent.com/u/4355693?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiastran","html_url":"https://github.com/matthiastran","followers_url":"https://api.github.com/users/matthiastran/followers","following_url":"https://api.github.com/users/matthiastran/following{/other_user}","gists_url":"https://api.github.com/users/matthiastran/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiastran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiastran/subscriptions","organizations_url":"https://api.github.com/users/matthiastran/orgs","repos_url":"https://api.github.com/users/matthiastran/repos","events_url":"https://api.github.com/users/matthiastran/events{/privacy}","received_events_url":"https://api.github.com/users/matthiastran/received_events","type":"User","site_admin":false},"body":"The change consists in allowing unix socket connection with pgjdbc on version 9.4-1203.\r\nThe details of changes are explained here : http://www.postgresql.org/message-id/j1k9ss$p4m$1@dough.gmane.org","created_at":"2015-11-03T10:20:05Z","updated_at":"2015-11-08T14:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415/commits","review_comments_url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415/comments","review_comment_url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pgjdbc/pgjdbc/issues/415/comments","statuses_url":"https://api.github.com/repos/pgjdbc/pgjdbc/statuses/87c7e42da17ce61c47699608006728b19831b41d","head":{"label":"dhatim:unixsocket-branch","ref":"unixsocket-branch","sha":"87c7e42da17ce61c47699608006728b19831b41d","user":{"login":"dhatim","id":4233275,"avatar_url":"https://avatars.githubusercontent.com/u/4233275?v=3","gravatar_id":"","url":"https://api.github.com/users/dhatim","html_url":"https://github.com/dhatim","followers_url":"https://api.github.com/users/dhatim/followers","following_url":"https://api.github.com/users/dhatim/following{/other_user}","gists_url":"https://api.github.com/users/dhatim/gists{/gist_id}","starred_url":"https://api.github.com/users/dhatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhatim/subscriptions","organizations_url":"https://api.github.com/users/dhatim/orgs","repos_url":"https://api.github.com/users/dhatim/repos","events_url":"https://api.github.com/users/dhatim/events{/privacy}","received_events_url":"https://api.github.com/users/dhatim/received_events","type":"Organization","site_admin":false},"repo":{"id":44093001,"name":"pgjdbc","full_name":"dhatim/pgjdbc","owner":{"login":"dhatim","id":4233275,"avatar_url":"https://avatars.githubusercontent.com/u/4233275?v=3","gravatar_id":"","url":"https://api.github.com/users/dhatim","html_url":"https://github.com/dhatim","followers_url":"https://api.github.com/users/dhatim/followers","following_url":"https://api.github.com/users/dhatim/following{/other_user}","gists_url":"https://api.github.com/users/dhatim/gists{/gist_id}","starred_url":"https://api.github.com/users/dhatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhatim/subscriptions","organizations_url":"https://api.github.com/users/dhatim/orgs","repos_url":"https://api.github.com/users/dhatim/repos","events_url":"https://api.github.com/users/dhatim/events{/privacy}","received_events_url":"https://api.github.com/users/dhatim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhatim/pgjdbc","description":"Postgresql JDBC Driver","fork":true,"url":"https://api.github.com/repos/dhatim/pgjdbc","forks_url":"https://api.github.com/repos/dhatim/pgjdbc/forks","keys_url":"https://api.github.com/repos/dhatim/pgjdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhatim/pgjdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhatim/pgjdbc/teams","hooks_url":"https://api.github.com/repos/dhatim/pgjdbc/hooks","issue_events_url":"https://api.github.com/repos/dhatim/pgjdbc/issues/events{/number}","events_url":"https://api.github.com/repos/dhatim/pgjdbc/events","assignees_url":"https://api.github.com/repos/dhatim/pgjdbc/assignees{/user}","branches_url":"https://api.github.com/repos/dhatim/pgjdbc/branches{/branch}","tags_url":"https://api.github.com/repos/dhatim/pgjdbc/tags","blobs_url":"https://api.github.com/repos/dhatim/pgjdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhatim/pgjdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhatim/pgjdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhatim/pgjdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhatim/pgjdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/dhatim/pgjdbc/languages","stargazers_url":"https://api.github.com/repos/dhatim/pgjdbc/stargazers","contributors_url":"https://api.github.com/repos/dhatim/pgjdbc/contributors","subscribers_url":"https://api.github.com/repos/dhatim/pgjdbc/subscribers","subscription_url":"https://api.github.com/repos/dhatim/pgjdbc/subscription","commits_url":"https://api.github.com/repos/dhatim/pgjdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhatim/pgjdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhatim/pgjdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhatim/pgjdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhatim/pgjdbc/contents/{+path}","compare_url":"https://api.github.com/repos/dhatim/pgjdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhatim/pgjdbc/merges","archive_url":"https://api.github.com/repos/dhatim/pgjdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhatim/pgjdbc/downloads","issues_url":"https://api.github.com/repos/dhatim/pgjdbc/issues{/number}","pulls_url":"https://api.github.com/repos/dhatim/pgjdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/dhatim/pgjdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/dhatim/pgjdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhatim/pgjdbc/labels{/name}","releases_url":"https://api.github.com/repos/dhatim/pgjdbc/releases{/id}","created_at":"2015-10-12T08:04:08Z","updated_at":"2015-10-21T10:36:06Z","pushed_at":"2015-11-04T10:29:14Z","git_url":"git://github.com/dhatim/pgjdbc.git","ssh_url":"git@github.com:dhatim/pgjdbc.git","clone_url":"https://github.com/dhatim/pgjdbc.git","svn_url":"https://github.com/dhatim/pgjdbc","homepage":"http://jdbc.postgresql.org","size":12588,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pgjdbc:master","ref":"master","sha":"fa0d7d5d1caa3e7fbbfb7572beb9167cab38a6b4","user":{"login":"pgjdbc","id":1371956,"avatar_url":"https://avatars.githubusercontent.com/u/1371956?v=3","gravatar_id":"","url":"https://api.github.com/users/pgjdbc","html_url":"https://github.com/pgjdbc","followers_url":"https://api.github.com/users/pgjdbc/followers","following_url":"https://api.github.com/users/pgjdbc/following{/other_user}","gists_url":"https://api.github.com/users/pgjdbc/gists{/gist_id}","starred_url":"https://api.github.com/users/pgjdbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgjdbc/subscriptions","organizations_url":"https://api.github.com/users/pgjdbc/orgs","repos_url":"https://api.github.com/users/pgjdbc/repos","events_url":"https://api.github.com/users/pgjdbc/events{/privacy}","received_events_url":"https://api.github.com/users/pgjdbc/received_events","type":"Organization","site_admin":false},"repo":{"id":3370128,"name":"pgjdbc","full_name":"pgjdbc/pgjdbc","owner":{"login":"pgjdbc","id":1371956,"avatar_url":"https://avatars.githubusercontent.com/u/1371956?v=3","gravatar_id":"","url":"https://api.github.com/users/pgjdbc","html_url":"https://github.com/pgjdbc","followers_url":"https://api.github.com/users/pgjdbc/followers","following_url":"https://api.github.com/users/pgjdbc/following{/other_user}","gists_url":"https://api.github.com/users/pgjdbc/gists{/gist_id}","starred_url":"https://api.github.com/users/pgjdbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgjdbc/subscriptions","organizations_url":"https://api.github.com/users/pgjdbc/orgs","repos_url":"https://api.github.com/users/pgjdbc/repos","events_url":"https://api.github.com/users/pgjdbc/events{/privacy}","received_events_url":"https://api.github.com/users/pgjdbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pgjdbc/pgjdbc","description":"Postgresql JDBC Driver","fork":false,"url":"https://api.github.com/repos/pgjdbc/pgjdbc","forks_url":"https://api.github.com/repos/pgjdbc/pgjdbc/forks","keys_url":"https://api.github.com/repos/pgjdbc/pgjdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgjdbc/pgjdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgjdbc/pgjdbc/teams","hooks_url":"https://api.github.com/repos/pgjdbc/pgjdbc/hooks","issue_events_url":"https://api.github.com/repos/pgjdbc/pgjdbc/issues/events{/number}","events_url":"https://api.github.com/repos/pgjdbc/pgjdbc/events","assignees_url":"https://api.github.com/repos/pgjdbc/pgjdbc/assignees{/user}","branches_url":"https://api.github.com/repos/pgjdbc/pgjdbc/branches{/branch}","tags_url":"https://api.github.com/repos/pgjdbc/pgjdbc/tags","blobs_url":"https://api.github.com/repos/pgjdbc/pgjdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgjdbc/pgjdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgjdbc/pgjdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgjdbc/pgjdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgjdbc/pgjdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/pgjdbc/pgjdbc/languages","stargazers_url":"https://api.github.com/repos/pgjdbc/pgjdbc/stargazers","contributors_url":"https://api.github.com/repos/pgjdbc/pgjdbc/contributors","subscribers_url":"https://api.github.com/repos/pgjdbc/pgjdbc/subscribers","subscription_url":"https://api.github.com/repos/pgjdbc/pgjdbc/subscription","commits_url":"https://api.github.com/repos/pgjdbc/pgjdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgjdbc/pgjdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgjdbc/pgjdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgjdbc/pgjdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgjdbc/pgjdbc/contents/{+path}","compare_url":"https://api.github.com/repos/pgjdbc/pgjdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgjdbc/pgjdbc/merges","archive_url":"https://api.github.com/repos/pgjdbc/pgjdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgjdbc/pgjdbc/downloads","issues_url":"https://api.github.com/repos/pgjdbc/pgjdbc/issues{/number}","pulls_url":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/pgjdbc/pgjdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/pgjdbc/pgjdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgjdbc/pgjdbc/labels{/name}","releases_url":"https://api.github.com/repos/pgjdbc/pgjdbc/releases{/id}","created_at":"2012-02-06T19:30:35Z","updated_at":"2015-10-29T08:36:22Z","pushed_at":"2015-11-04T12:11:11Z","git_url":"git://github.com/pgjdbc/pgjdbc.git","ssh_url":"git@github.com:pgjdbc/pgjdbc.git","clone_url":"https://github.com/pgjdbc/pgjdbc.git","svn_url":"https://github.com/pgjdbc/pgjdbc","homepage":"http://jdbc.postgresql.org","size":16637,"stargazers_count":170,"watchers_count":170,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":93,"forks":154,"open_issues":93,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415"},"html":{"href":"https://github.com/pgjdbc/pgjdbc/pull/415"},"issue":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/issues/415"},"comments":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/pgjdbc/pgjdbc/statuses/87c7e42da17ce61c47699608006728b19831b41d"}}}}