{"action":"created","issue":{"url":"https://api.github.com/repos/open-mpi/ompi-release/issues/309","labels_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/309/comments","events_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/309/events","html_url":"https://github.com/open-mpi/ompi-release/pull/309","id":87021483,"number":309,"title":"fix pmi2 process map parsing in ess/pmi reusing the correct one in grpomm/pmi","user":{"login":"plesn","id":1788760,"avatar_url":"https://avatars.githubusercontent.com/u/1788760?v=3","gravatar_id":"","url":"https://api.github.com/users/plesn","html_url":"https://github.com/plesn","followers_url":"https://api.github.com/users/plesn/followers","following_url":"https://api.github.com/users/plesn/following{/other_user}","gists_url":"https://api.github.com/users/plesn/gists{/gist_id}","starred_url":"https://api.github.com/users/plesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plesn/subscriptions","organizations_url":"https://api.github.com/users/plesn/orgs","repos_url":"https://api.github.com/users/plesn/repos","events_url":"https://api.github.com/users/plesn/events{/privacy}","received_events_url":"https://api.github.com/users/plesn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/open-mpi/ompi-release/labels/bug","name":"bug","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/open-mpi/ompi-release/milestones/5","html_url":"https://github.com/open-mpi/ompi-release/milestones/v1.8.6","labels_url":"https://api.github.com/repos/open-mpi/ompi-release/milestones/5/labels","id":1073210,"number":5,"title":"v1.8.6","description":"","creator":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":19,"state":"open","created_at":"2015-04-18T12:03:50Z","updated_at":"2015-06-10T18:48:01Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-06-10T16:10:28Z","updated_at":"2015-06-11T13:24:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/309","html_url":"https://github.com/open-mpi/ompi-release/pull/309","diff_url":"https://github.com/open-mpi/ompi-release/pull/309.diff","patch_url":"https://github.com/open-mpi/ompi-release/pull/309.patch"},"body":"This fixes launching of openmpi-1.8 with mxm or sm in cases of\r\nunpopulated nodes like this :\r\n\r\n    $ srun  -N2 -n7  --cpu_bind=core -m block --mpi=pmi2 -K ./IMB-MPI1 Pingpong\r\n    [btp19:24155] Error: mtl_mxm.c:310 - ompi_mtl_mxm_module_init() Unable to obtain local node rank\r\n    [btp19:24157] Error: mtl_mxm.c:310 - ompi_mtl_mxm_module_init() Unable to obtain local node rank\r\n    --------------------------------------------------------------------------\r\n    WARNING: Missing locality information required for sm initialization.\r\n    Continuing without shared memory support.\r\n    --------------------------------------------------------------------------\r\n    [...]\r\n\r\nHere mxm and sm need the local/node rank, whose parsing in ess/pmi is\r\nbuggy when Slurm gives process mapping vectors with an offset like\r\n`(1,X,X)`. There is already a function that correctly reads Slurm's\r\nprocess mapping in grpcomm/pmi/pmi2_pmap_parser.c.\r\n\r\nI propose to fix the bug by reusing this pmap parsing function, and to\r\nbe a little bit prettier in the 2nd commit I move this common function\r\nto opal/mca/common/pmi.\r\n\r\nIf this seems okay to you, the pmi process mapping query code could be\r\nfactorised even further in a `mca_common_pmapping()` function.\r\n"},"comment":{"url":"https://api.github.com/repos/open-mpi/ompi-release/issues/comments/111134656","html_url":"https://github.com/open-mpi/ompi-release/pull/309#issuecomment-111134656","issue_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/309","id":111134656,"user":{"login":"rhc54","id":2440928,"avatar_url":"https://avatars.githubusercontent.com/u/2440928?v=3","gravatar_id":"","url":"https://api.github.com/users/rhc54","html_url":"https://github.com/rhc54","followers_url":"https://api.github.com/users/rhc54/followers","following_url":"https://api.github.com/users/rhc54/following{/other_user}","gists_url":"https://api.github.com/users/rhc54/gists{/gist_id}","starred_url":"https://api.github.com/users/rhc54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhc54/subscriptions","organizations_url":"https://api.github.com/users/rhc54/orgs","repos_url":"https://api.github.com/users/rhc54/repos","events_url":"https://api.github.com/users/rhc54/events{/privacy}","received_events_url":"https://api.github.com/users/rhc54/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T13:24:20Z","updated_at":"2015-06-11T13:24:20Z","body":"Thanks! Have you signed a contributor agreement, or belong to one of our member groups, perchance? "}}