{"action":"created","comment":{"url":"https://api.github.com/repos/philc/vimium/pulls/comments/31731763","id":31731763,"diff_hunk":"@@ -254,16 +255,27 @@ executePageCommand = (request) ->\n   # All other commands are handled in their frame (but only if Vimium is enabled).\n   return unless frameId == request.frameId and isEnabledForUrl\n \n-  if request.registryEntry.passCountToFunction\n+  if commandType == \"Marks\"\n+    Utils.invokeCommandString request.command, [request.registryEntry]","path":"content_scripts/vimium_frontend.coffee","position":33,"original_position":33,"commit_id":"2473475367411fdeb051a6752d0059e337ad09e3","original_commit_id":"2473475367411fdeb051a6752d0059e337ad09e3","user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"body":"This is no longer necessary after 2473475367411fdeb051a6752d0059e337ad09e3","created_at":"2015-06-04T15:29:12Z","updated_at":"2015-06-04T15:29:12Z","html_url":"https://github.com/philc/vimium/pull/1716#discussion_r31731763","pull_request_url":"https://api.github.com/repos/philc/vimium/pulls/1716","_links":{"self":{"href":"https://api.github.com/repos/philc/vimium/pulls/comments/31731763"},"html":{"href":"https://github.com/philc/vimium/pull/1716#discussion_r31731763"},"pull_request":{"href":"https://api.github.com/repos/philc/vimium/pulls/1716"}}},"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1716","id":36927189,"html_url":"https://github.com/philc/vimium/pull/1716","diff_url":"https://github.com/philc/vimium/pull/1716.diff","patch_url":"https://github.com/philc/vimium/pull/1716.patch","issue_url":"https://api.github.com/repos/philc/vimium/issues/1716","number":1716,"state":"open","locked":false,"title":"Improved global marks","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"body":"This makes global marks:\r\n- persistent across tab closures and browser sessions, and\r\n- synchronised between browser instances.\r\n\r\nEffectively, this makes global marks another kind of bookmark.\r\n\r\nThis PR includes and is an extension of #1714.  The differences are difficult to see in the diff.  They are:\r\n- [this](https://github.com/smblott-github/vimium/blob/global-marks/background_scripts/main.coffee#L38) line, so that we can set the scroll position after a tab has been opened, and\r\n- all of [this](https://github.com/smblott-github/vimium/blob/global-marks/background_scripts/marks.coffee) file.\r\n\r\nHere's the approach:\r\n- If the tab still exists, use it.\r\n- Otherwise, if another tab exists with a matching URL, then use that instead.\r\n- Otherwise, create a new tab and set the scroll position within that.\r\n\r\nWe use `vimiumSecret` to detect whether we can re-use a tab Id.  Global marks are stored not in memory, as previously, by in `chrome.storage.sync`.","created_at":"2015-06-04T11:58:18Z","updated_at":"2015-06-04T15:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9c2cd80630d5dee608aa0f456b4f853cc12af90","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/philc/vimium/pulls/1716/commits","review_comments_url":"https://api.github.com/repos/philc/vimium/pulls/1716/comments","review_comment_url":"https://api.github.com/repos/philc/vimium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1716/comments","statuses_url":"https://api.github.com/repos/philc/vimium/statuses/2473475367411fdeb051a6752d0059e337ad09e3","head":{"label":"smblott-github:global-marks","ref":"global-marks","sha":"2473475367411fdeb051a6752d0059e337ad09e3","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"repo":{"id":18924701,"name":"vimium","full_name":"smblott-github/vimium","owner":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smblott-github/vimium","description":"The hacker's browser.","fork":true,"url":"https://api.github.com/repos/smblott-github/vimium","forks_url":"https://api.github.com/repos/smblott-github/vimium/forks","keys_url":"https://api.github.com/repos/smblott-github/vimium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smblott-github/vimium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smblott-github/vimium/teams","hooks_url":"https://api.github.com/repos/smblott-github/vimium/hooks","issue_events_url":"https://api.github.com/repos/smblott-github/vimium/issues/events{/number}","events_url":"https://api.github.com/repos/smblott-github/vimium/events","assignees_url":"https://api.github.com/repos/smblott-github/vimium/assignees{/user}","branches_url":"https://api.github.com/repos/smblott-github/vimium/branches{/branch}","tags_url":"https://api.github.com/repos/smblott-github/vimium/tags","blobs_url":"https://api.github.com/repos/smblott-github/vimium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smblott-github/vimium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smblott-github/vimium/git/refs{/sha}","trees_url":"https://api.github.com/repos/smblott-github/vimium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smblott-github/vimium/statuses/{sha}","languages_url":"https://api.github.com/repos/smblott-github/vimium/languages","stargazers_url":"https://api.github.com/repos/smblott-github/vimium/stargazers","contributors_url":"https://api.github.com/repos/smblott-github/vimium/contributors","subscribers_url":"https://api.github.com/repos/smblott-github/vimium/subscribers","subscription_url":"https://api.github.com/repos/smblott-github/vimium/subscription","commits_url":"https://api.github.com/repos/smblott-github/vimium/commits{/sha}","git_commits_url":"https://api.github.com/repos/smblott-github/vimium/git/commits{/sha}","comments_url":"https://api.github.com/repos/smblott-github/vimium/comments{/number}","issue_comment_url":"https://api.github.com/repos/smblott-github/vimium/issues/comments{/number}","contents_url":"https://api.github.com/repos/smblott-github/vimium/contents/{+path}","compare_url":"https://api.github.com/repos/smblott-github/vimium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smblott-github/vimium/merges","archive_url":"https://api.github.com/repos/smblott-github/vimium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smblott-github/vimium/downloads","issues_url":"https://api.github.com/repos/smblott-github/vimium/issues{/number}","pulls_url":"https://api.github.com/repos/smblott-github/vimium/pulls{/number}","milestones_url":"https://api.github.com/repos/smblott-github/vimium/milestones{/number}","notifications_url":"https://api.github.com/repos/smblott-github/vimium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smblott-github/vimium/labels{/name}","releases_url":"https://api.github.com/repos/smblott-github/vimium/releases{/id}","created_at":"2014-04-18T20:29:25Z","updated_at":"2015-05-07T09:29:14Z","pushed_at":"2015-06-04T15:25:01Z","git_url":"git://github.com/smblott-github/vimium.git","ssh_url":"git@github.com:smblott-github/vimium.git","clone_url":"https://github.com/smblott-github/vimium.git","svn_url":"https://github.com/smblott-github/vimium","homepage":"","size":8020,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"philc:master","ref":"master","sha":"a402606774b8fe3bb04203f873804d61944553d6","user":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=3","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"repo":{"id":312262,"name":"vimium","full_name":"philc/vimium","owner":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=3","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philc/vimium","description":"The hacker's browser.","fork":false,"url":"https://api.github.com/repos/philc/vimium","forks_url":"https://api.github.com/repos/philc/vimium/forks","keys_url":"https://api.github.com/repos/philc/vimium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philc/vimium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philc/vimium/teams","hooks_url":"https://api.github.com/repos/philc/vimium/hooks","issue_events_url":"https://api.github.com/repos/philc/vimium/issues/events{/number}","events_url":"https://api.github.com/repos/philc/vimium/events","assignees_url":"https://api.github.com/repos/philc/vimium/assignees{/user}","branches_url":"https://api.github.com/repos/philc/vimium/branches{/branch}","tags_url":"https://api.github.com/repos/philc/vimium/tags","blobs_url":"https://api.github.com/repos/philc/vimium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philc/vimium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philc/vimium/git/refs{/sha}","trees_url":"https://api.github.com/repos/philc/vimium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philc/vimium/statuses/{sha}","languages_url":"https://api.github.com/repos/philc/vimium/languages","stargazers_url":"https://api.github.com/repos/philc/vimium/stargazers","contributors_url":"https://api.github.com/repos/philc/vimium/contributors","subscribers_url":"https://api.github.com/repos/philc/vimium/subscribers","subscription_url":"https://api.github.com/repos/philc/vimium/subscription","commits_url":"https://api.github.com/repos/philc/vimium/commits{/sha}","git_commits_url":"https://api.github.com/repos/philc/vimium/git/commits{/sha}","comments_url":"https://api.github.com/repos/philc/vimium/comments{/number}","issue_comment_url":"https://api.github.com/repos/philc/vimium/issues/comments{/number}","contents_url":"https://api.github.com/repos/philc/vimium/contents/{+path}","compare_url":"https://api.github.com/repos/philc/vimium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philc/vimium/merges","archive_url":"https://api.github.com/repos/philc/vimium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philc/vimium/downloads","issues_url":"https://api.github.com/repos/philc/vimium/issues{/number}","pulls_url":"https://api.github.com/repos/philc/vimium/pulls{/number}","milestones_url":"https://api.github.com/repos/philc/vimium/milestones{/number}","notifications_url":"https://api.github.com/repos/philc/vimium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philc/vimium/labels{/name}","releases_url":"https://api.github.com/repos/philc/vimium/releases{/id}","created_at":"2009-09-20T07:08:19Z","updated_at":"2015-06-04T12:44:44Z","pushed_at":"2015-06-04T15:24:44Z","git_url":"git://github.com/philc/vimium.git","ssh_url":"git@github.com:philc/vimium.git","clone_url":"https://github.com/philc/vimium.git","svn_url":"https://github.com/philc/vimium","homepage":"","size":11634,"stargazers_count":3228,"watchers_count":3228,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":473,"mirror_url":null,"open_issues_count":355,"forks":473,"open_issues":355,"watchers":3228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/philc/vimium/pulls/1716"},"html":{"href":"https://github.com/philc/vimium/pull/1716"},"issue":{"href":"https://api.github.com/repos/philc/vimium/issues/1716"},"comments":{"href":"https://api.github.com/repos/philc/vimium/issues/1716/comments"},"review_comments":{"href":"https://api.github.com/repos/philc/vimium/pulls/1716/comments"},"review_comment":{"href":"https://api.github.com/repos/philc/vimium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/philc/vimium/pulls/1716/commits"},"statuses":{"href":"https://api.github.com/repos/philc/vimium/statuses/2473475367411fdeb051a6752d0059e337ad09e3"}}}}