{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/36102598","id":36102598,"diff_hunk":"@@ -4,7 +4,11 @@\n install:\n \tnpm prune && npm install\n \tcd node_modules/.bin; ./jspm install && ./jspm dl-loader && ./jspm clean\n-\tgrunt copy\n+\tgrunt uglify:conf","path":"makefile","position":5,"original_position":5,"commit_id":"dacb9b98b1e1da217f51df2cd092802c798c226e","original_commit_id":"dacb9b98b1e1da217f51df2cd092802c798c226e","user":{"login":"desbo","id":1064734,"avatar_url":"https://avatars.githubusercontent.com/u/1064734?v=3","gravatar_id":"","url":"https://api.github.com/users/desbo","html_url":"https://github.com/desbo","followers_url":"https://api.github.com/users/desbo/followers","following_url":"https://api.github.com/users/desbo/following{/other_user}","gists_url":"https://api.github.com/users/desbo/gists{/gist_id}","starred_url":"https://api.github.com/users/desbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desbo/subscriptions","organizations_url":"https://api.github.com/users/desbo/orgs","repos_url":"https://api.github.com/users/desbo/repos","events_url":"https://api.github.com/users/desbo/events{/privacy}","received_events_url":"https://api.github.com/users/desbo/received_events","type":"User","site_admin":false},"body":"does `uglify:conf` do enough to replace `copy`?","created_at":"2015-08-03T16:26:50Z","updated_at":"2015-08-03T16:26:50Z","html_url":"https://github.com/guardian/frontend/pull/10012#discussion_r36102598","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/10012","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/36102598"},"html":{"href":"https://github.com/guardian/frontend/pull/10012#discussion_r36102598"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10012"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/10012","id":41482820,"html_url":"https://github.com/guardian/frontend/pull/10012","diff_url":"https://github.com/guardian/frontend/pull/10012.diff","patch_url":"https://github.com/guardian/frontend/pull/10012.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/10012","number":10012,"state":"open","locked":false,"title":"Create a make/node-sass based dev watcher","user":{"login":"sndrs","id":867233,"avatar_url":"https://avatars.githubusercontent.com/u/867233?v=3","gravatar_id":"","url":"https://api.github.com/users/sndrs","html_url":"https://github.com/sndrs","followers_url":"https://api.github.com/users/sndrs/followers","following_url":"https://api.github.com/users/sndrs/following{/other_user}","gists_url":"https://api.github.com/users/sndrs/gists{/gist_id}","starred_url":"https://api.github.com/users/sndrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sndrs/subscriptions","organizations_url":"https://api.github.com/users/sndrs/orgs","repos_url":"https://api.github.com/users/sndrs/repos","events_url":"https://api.github.com/users/sndrs/events{/privacy}","received_events_url":"https://api.github.com/users/sndrs/received_events","type":"User","site_admin":false},"body":"Improves asset watching/compilation etc with some newer tech/ideas. For now it will work alongside existing processes until kinks are ironed out.\r\n\r\nSpecifically:\r\n\r\n- introduces `make` as the generic command. this means any tooling we replace, add etc in the future won't affect how we actually run the job\r\n- speed up watching by using `node-sass` as the sass watcher and  [browsersync](http://www.browsersync.io) as the asset reloader (eventually replacing the `csdevmode`)\r\n- adds `gulp` for use behind the scenes in sass watching\r\n- tidies up some `grunt` commands\r\n\r\nThe idea is not to advocate for any particular system, but allow whatever works best in context for those who want to get their hands dirty in the pipeline, while eventually providing a simple, static interface for those who don't (`make watch`, `make install` etc).\r\n\r\nThis includes a `make watch` command, which can be used in palce of `grunt csdevmode` (which will eventually be retired). This will watch all Sass, and livereload prod-like css for modern browsers (IE9/old are excluded for speed), and auto-refresh if JS changes are detected.\r\n\r\n@OliverJAsh I know love this sort of thing, any thoughts?\r\n","created_at":"2015-08-03T16:07:14Z","updated_at":"2015-08-03T16:26:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cd6dc7a9a25e38c0bd472a598ceb04e25441937","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/10012/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/10012/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/10012/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/dacb9b98b1e1da217f51df2cd092802c798c226e","head":{"label":"guardian:dev-watch","ref":"dev-watch","sha":"dacb9b98b1e1da217f51df2cd092802c798c226e","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-07-30T16:22:03Z","pushed_at":"2015-08-03T16:09:03Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":542541,"stargazers_count":2851,"watchers_count":2851,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":63,"forks":271,"open_issues":63,"watchers":2851,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"2b2bee11b9e34f0eb05d70090cbf7d5e27dab866","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-07-30T16:22:03Z","pushed_at":"2015-08-03T16:09:03Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":542541,"stargazers_count":2851,"watchers_count":2851,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":63,"forks":271,"open_issues":63,"watchers":2851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10012"},"html":{"href":"https://github.com/guardian/frontend/pull/10012"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/10012"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/10012/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10012/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10012/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/dacb9b98b1e1da217f51df2cd092802c798c226e"}}}}