{"action":"created","comment":{"url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/comments/26185809","id":26185809,"diff_hunk":"@@ -55,275 +54,269 @@ class CallbackAlreadyRegistered(Exception):\n     pass\n \n \n-def ensure_client_daemon():\n+class EventsIOLoop(ioloop.ZMQIOLoop):","path":"src/leap/common/events/client.py","position":62,"original_position":62,"commit_id":"801ce9890c951f6ffda011b38cec3b2f67d398b9","original_commit_id":"801ce9890c951f6ffda011b38cec3b2f67d398b9","user":{"login":"kalikaneko","id":3072993,"avatar_url":"https://avatars.githubusercontent.com/u/3072993?v=3","gravatar_id":"","url":"https://api.github.com/users/kalikaneko","html_url":"https://github.com/kalikaneko","followers_url":"https://api.github.com/users/kalikaneko/followers","following_url":"https://api.github.com/users/kalikaneko/following{/other_user}","gists_url":"https://api.github.com/users/kalikaneko/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikaneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikaneko/subscriptions","organizations_url":"https://api.github.com/users/kalikaneko/orgs","repos_url":"https://api.github.com/users/kalikaneko/repos","events_url":"https://api.github.com/users/kalikaneko/events{/privacy}","received_events_url":"https://api.github.com/users/kalikaneko/received_events","type":"User","site_admin":false},"body":"does this mean that all clients will use the zmqioloop?\r\nisn't this only needed for the qt frontend?","created_at":"2015-03-11T03:00:03Z","updated_at":"2015-03-11T03:00:03Z","html_url":"https://github.com/leapcode/leap_pycommon/pull/95#discussion_r26185809","pull_request_url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/comments/26185809"},"html":{"href":"https://github.com/leapcode/leap_pycommon/pull/95#discussion_r26185809"},"pull_request":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95","id":30859681,"html_url":"https://github.com/leapcode/leap_pycommon/pull/95","diff_url":"https://github.com/leapcode/leap_pycommon/pull/95.diff","patch_url":"https://github.com/leapcode/leap_pycommon/pull/95.patch","issue_url":"https://api.github.com/repos/leapcode/leap_pycommon/issues/95","number":95,"state":"open","locked":false,"title":"[feature] Refactor leap.common.events to use ZMQ.","user":{"login":"andrejb","id":79672,"avatar_url":"https://avatars.githubusercontent.com/u/79672?v=3","gravatar_id":"","url":"https://api.github.com/users/andrejb","html_url":"https://github.com/andrejb","followers_url":"https://api.github.com/users/andrejb/followers","following_url":"https://api.github.com/users/andrejb/following{/other_user}","gists_url":"https://api.github.com/users/andrejb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrejb/subscriptions","organizations_url":"https://api.github.com/users/andrejb/orgs","repos_url":"https://api.github.com/users/andrejb/repos","events_url":"https://api.github.com/users/andrejb/events{/privacy}","received_events_url":"https://api.github.com/users/andrejb/received_events","type":"User","site_admin":false},"body":"Closes: #6359","created_at":"2015-03-10T15:17:18Z","updated_at":"2015-03-11T03:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a838db9d8beafe20f9afe31efcb5718d33f67b91","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95/commits","review_comments_url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95/comments","review_comment_url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leapcode/leap_pycommon/issues/95/comments","statuses_url":"https://api.github.com/repos/leapcode/leap_pycommon/statuses/801ce9890c951f6ffda011b38cec3b2f67d398b9","head":{"label":"andrejb:feature/6359_modify-events-to-use-zmq","ref":"feature/6359_modify-events-to-use-zmq","sha":"801ce9890c951f6ffda011b38cec3b2f67d398b9","user":{"login":"andrejb","id":79672,"avatar_url":"https://avatars.githubusercontent.com/u/79672?v=3","gravatar_id":"","url":"https://api.github.com/users/andrejb","html_url":"https://github.com/andrejb","followers_url":"https://api.github.com/users/andrejb/followers","following_url":"https://api.github.com/users/andrejb/following{/other_user}","gists_url":"https://api.github.com/users/andrejb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrejb/subscriptions","organizations_url":"https://api.github.com/users/andrejb/orgs","repos_url":"https://api.github.com/users/andrejb/repos","events_url":"https://api.github.com/users/andrejb/events{/privacy}","received_events_url":"https://api.github.com/users/andrejb/received_events","type":"User","site_admin":false},"repo":{"id":8959712,"name":"leap_pycommon","full_name":"andrejb/leap_pycommon","owner":{"login":"andrejb","id":79672,"avatar_url":"https://avatars.githubusercontent.com/u/79672?v=3","gravatar_id":"","url":"https://api.github.com/users/andrejb","html_url":"https://github.com/andrejb","followers_url":"https://api.github.com/users/andrejb/followers","following_url":"https://api.github.com/users/andrejb/following{/other_user}","gists_url":"https://api.github.com/users/andrejb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrejb/subscriptions","organizations_url":"https://api.github.com/users/andrejb/orgs","repos_url":"https://api.github.com/users/andrejb/repos","events_url":"https://api.github.com/users/andrejb/events{/privacy}","received_events_url":"https://api.github.com/users/andrejb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrejb/leap_pycommon","description":"","fork":true,"url":"https://api.github.com/repos/andrejb/leap_pycommon","forks_url":"https://api.github.com/repos/andrejb/leap_pycommon/forks","keys_url":"https://api.github.com/repos/andrejb/leap_pycommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrejb/leap_pycommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrejb/leap_pycommon/teams","hooks_url":"https://api.github.com/repos/andrejb/leap_pycommon/hooks","issue_events_url":"https://api.github.com/repos/andrejb/leap_pycommon/issues/events{/number}","events_url":"https://api.github.com/repos/andrejb/leap_pycommon/events","assignees_url":"https://api.github.com/repos/andrejb/leap_pycommon/assignees{/user}","branches_url":"https://api.github.com/repos/andrejb/leap_pycommon/branches{/branch}","tags_url":"https://api.github.com/repos/andrejb/leap_pycommon/tags","blobs_url":"https://api.github.com/repos/andrejb/leap_pycommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrejb/leap_pycommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrejb/leap_pycommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrejb/leap_pycommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrejb/leap_pycommon/statuses/{sha}","languages_url":"https://api.github.com/repos/andrejb/leap_pycommon/languages","stargazers_url":"https://api.github.com/repos/andrejb/leap_pycommon/stargazers","contributors_url":"https://api.github.com/repos/andrejb/leap_pycommon/contributors","subscribers_url":"https://api.github.com/repos/andrejb/leap_pycommon/subscribers","subscription_url":"https://api.github.com/repos/andrejb/leap_pycommon/subscription","commits_url":"https://api.github.com/repos/andrejb/leap_pycommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrejb/leap_pycommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrejb/leap_pycommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrejb/leap_pycommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrejb/leap_pycommon/contents/{+path}","compare_url":"https://api.github.com/repos/andrejb/leap_pycommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrejb/leap_pycommon/merges","archive_url":"https://api.github.com/repos/andrejb/leap_pycommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrejb/leap_pycommon/downloads","issues_url":"https://api.github.com/repos/andrejb/leap_pycommon/issues{/number}","pulls_url":"https://api.github.com/repos/andrejb/leap_pycommon/pulls{/number}","milestones_url":"https://api.github.com/repos/andrejb/leap_pycommon/milestones{/number}","notifications_url":"https://api.github.com/repos/andrejb/leap_pycommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrejb/leap_pycommon/labels{/name}","releases_url":"https://api.github.com/repos/andrejb/leap_pycommon/releases{/id}","created_at":"2013-03-22T19:54:17Z","updated_at":"2014-05-29T18:01:51Z","pushed_at":"2015-03-10T15:16:54Z","git_url":"git://github.com/andrejb/leap_pycommon.git","ssh_url":"git@github.com:andrejb/leap_pycommon.git","clone_url":"https://github.com/andrejb/leap_pycommon.git","svn_url":"https://github.com/andrejb/leap_pycommon","homepage":null,"size":788,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"leapcode:develop","ref":"develop","sha":"60bcc511b5d715b4921645cad6c82adfacf7ec24","user":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"repo":{"id":8909650,"name":"leap_pycommon","full_name":"leapcode/leap_pycommon","owner":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapcode/leap_pycommon","description":"Common utilities for leap python modules.","fork":false,"url":"https://api.github.com/repos/leapcode/leap_pycommon","forks_url":"https://api.github.com/repos/leapcode/leap_pycommon/forks","keys_url":"https://api.github.com/repos/leapcode/leap_pycommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapcode/leap_pycommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapcode/leap_pycommon/teams","hooks_url":"https://api.github.com/repos/leapcode/leap_pycommon/hooks","issue_events_url":"https://api.github.com/repos/leapcode/leap_pycommon/issues/events{/number}","events_url":"https://api.github.com/repos/leapcode/leap_pycommon/events","assignees_url":"https://api.github.com/repos/leapcode/leap_pycommon/assignees{/user}","branches_url":"https://api.github.com/repos/leapcode/leap_pycommon/branches{/branch}","tags_url":"https://api.github.com/repos/leapcode/leap_pycommon/tags","blobs_url":"https://api.github.com/repos/leapcode/leap_pycommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapcode/leap_pycommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapcode/leap_pycommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapcode/leap_pycommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapcode/leap_pycommon/statuses/{sha}","languages_url":"https://api.github.com/repos/leapcode/leap_pycommon/languages","stargazers_url":"https://api.github.com/repos/leapcode/leap_pycommon/stargazers","contributors_url":"https://api.github.com/repos/leapcode/leap_pycommon/contributors","subscribers_url":"https://api.github.com/repos/leapcode/leap_pycommon/subscribers","subscription_url":"https://api.github.com/repos/leapcode/leap_pycommon/subscription","commits_url":"https://api.github.com/repos/leapcode/leap_pycommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapcode/leap_pycommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapcode/leap_pycommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapcode/leap_pycommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapcode/leap_pycommon/contents/{+path}","compare_url":"https://api.github.com/repos/leapcode/leap_pycommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapcode/leap_pycommon/merges","archive_url":"https://api.github.com/repos/leapcode/leap_pycommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapcode/leap_pycommon/downloads","issues_url":"https://api.github.com/repos/leapcode/leap_pycommon/issues{/number}","pulls_url":"https://api.github.com/repos/leapcode/leap_pycommon/pulls{/number}","milestones_url":"https://api.github.com/repos/leapcode/leap_pycommon/milestones{/number}","notifications_url":"https://api.github.com/repos/leapcode/leap_pycommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapcode/leap_pycommon/labels{/name}","releases_url":"https://api.github.com/repos/leapcode/leap_pycommon/releases{/id}","created_at":"2013-03-20T17:01:43Z","updated_at":"2015-01-26T16:41:07Z","pushed_at":"2015-01-26T20:19:55Z","git_url":"git://github.com/leapcode/leap_pycommon.git","ssh_url":"git@github.com:leapcode/leap_pycommon.git","clone_url":"https://github.com/leapcode/leap_pycommon.git","svn_url":"https://github.com/leapcode/leap_pycommon","homepage":"","size":1435,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95"},"html":{"href":"https://github.com/leapcode/leap_pycommon/pull/95"},"issue":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/issues/95"},"comments":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/leapcode/leap_pycommon/statuses/801ce9890c951f6ffda011b38cec3b2f67d398b9"}}}}