{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/28","id":51691738,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/28","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/28.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/28.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/28","number":28,"state":"closed","locked":false,"title":"Several unit tests for spvBinaryParse","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"Add a non-zero spv_result_t value SPV_REQUESTED_TERMINATION\r\nwhich should be used to signal an ok result, but signals\r\nearly termination for a process, such as binary parsing.\r\n\r\nTests include:\r\n - correct contents sent to header and instruction callbacks\r\n - non-zero status from a callback should terminate parsing,\r\n   but the parser should not generate its own diagnostic.\r\n\r\nTODO: Check diagnostics generated by the parser itself.","created_at":"2015-11-24T17:36:04Z","updated_at":"2015-11-27T15:20:07Z","closed_at":"2015-11-27T15:20:07Z","merged_at":"2015-11-27T15:20:07Z","merge_commit_sha":"1b1387224c4350bd2c60d96c1cb1f973cbdbadcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/28/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/28/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/28/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/750f205b63818b6234ceb7e9e1b42fc6c327cbd5","head":{"label":"dneto0:unit-test-binary-parse","ref":"unit-test-binary-parse","sha":"750f205b63818b6234ceb7e9e1b42fc6c327cbd5","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"repo":{"id":46365138,"name":"SPIRV-Tools","full_name":"dneto0/SPIRV-Tools","owner":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dneto0/SPIRV-Tools","description":"","fork":true,"url":"https://api.github.com/repos/dneto0/SPIRV-Tools","forks_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/releases{/id}","created_at":"2015-11-17T17:57:28Z","updated_at":"2015-11-17T17:57:29Z","pushed_at":"2015-11-27T15:19:53Z","git_url":"git://github.com/dneto0/SPIRV-Tools.git","ssh_url":"git@github.com:dneto0/SPIRV-Tools.git","clone_url":"https://github.com/dneto0/SPIRV-Tools.git","svn_url":"https://github.com/dneto0/SPIRV-Tools","homepage":null,"size":878,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"c9e0845c7f4b55597349ed2d3de57646fa680aeb","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":"","fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","created_at":"2015-11-11T12:56:25Z","updated_at":"2015-11-25T22:42:12Z","pushed_at":"2015-11-27T15:20:07Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":835,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/28"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/28"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/28"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/750f205b63818b6234ceb7e9e1b42fc6c327cbd5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"comments":1,"review_comments":25,"commits":1,"additions":421,"deletions":4,"changed_files":3}}