{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/comments/32470379","id":32470379,"diff_hunk":"@@ -1986,13 +1986,18 @@ function markers(args) {\n                 .attr('y2', function() {\n                     return args.height - args.bottom - args.buffer;\n                 })\n+                .attr('class', function (d) {\n+                    return d.lineclass;\n+                })\n                 .attr('stroke-dasharray', '3,1');\n \n         gm.selectAll('.mg-markers')\n             .data(args.markers.filter(inRange))\n             .enter()\n             .append('text')\n-                .attr('class', 'mg-marker-text')\n+                .attr('class', function (d) {\n+                    return d.textclass ? 'mg-marker-text' : 'mg-marker-text ' + d.textclass;","path":"dist/metricsgraphics.js","position":15,"original_position":15,"commit_id":"5a72abdb92b330ad197e5f77838cb41afa092887","original_commit_id":"5a72abdb92b330ad197e5f77838cb41afa092887","user":{"login":"wjaspers","id":598148,"avatar_url":"https://avatars.githubusercontent.com/u/598148?v=3","gravatar_id":"","url":"https://api.github.com/users/wjaspers","html_url":"https://github.com/wjaspers","followers_url":"https://api.github.com/users/wjaspers/followers","following_url":"https://api.github.com/users/wjaspers/following{/other_user}","gists_url":"https://api.github.com/users/wjaspers/gists{/gist_id}","starred_url":"https://api.github.com/users/wjaspers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjaspers/subscriptions","organizations_url":"https://api.github.com/users/wjaspers/orgs","repos_url":"https://api.github.com/users/wjaspers/repos","events_url":"https://api.github.com/users/wjaspers/events{/privacy}","received_events_url":"https://api.github.com/users/wjaspers/received_events","type":"User","site_admin":false},"body":"Shouldn't this be `return d.textclass ? 'mg-marker-text ' + d.textclass : 'mg-marker-text'`?\r\nIf textclass is not set, the current statement tries to use it, which I assume would add `undefined` to the class.","created_at":"2015-06-15T21:42:36Z","updated_at":"2015-06-15T21:42:36Z","html_url":"https://github.com/mozilla/metrics-graphics/pull/447#discussion_r32470379","pull_request_url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447","_links":{"self":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/comments/32470379"},"html":{"href":"https://github.com/mozilla/metrics-graphics/pull/447#discussion_r32470379"},"pull_request":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447","id":37451515,"html_url":"https://github.com/mozilla/metrics-graphics/pull/447","diff_url":"https://github.com/mozilla/metrics-graphics/pull/447.diff","patch_url":"https://github.com/mozilla/metrics-graphics/pull/447.patch","issue_url":"https://api.github.com/repos/mozilla/metrics-graphics/issues/447","number":447,"state":"open","locked":false,"title":"Simple pr to add let users add a class to the markers","user":{"login":"iphands","id":129737,"avatar_url":"https://avatars.githubusercontent.com/u/129737?v=3","gravatar_id":"","url":"https://api.github.com/users/iphands","html_url":"https://github.com/iphands","followers_url":"https://api.github.com/users/iphands/followers","following_url":"https://api.github.com/users/iphands/following{/other_user}","gists_url":"https://api.github.com/users/iphands/gists{/gist_id}","starred_url":"https://api.github.com/users/iphands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphands/subscriptions","organizations_url":"https://api.github.com/users/iphands/orgs","repos_url":"https://api.github.com/users/iphands/repos","events_url":"https://api.github.com/users/iphands/events{/privacy}","received_events_url":"https://api.github.com/users/iphands/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-11T10:59:13Z","updated_at":"2015-06-15T21:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61ba7db91a4c5d24aa0723b8756e220b83bf376e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447/commits","review_comments_url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447/comments","review_comment_url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/metrics-graphics/issues/447/comments","statuses_url":"https://api.github.com/repos/mozilla/metrics-graphics/statuses/5a72abdb92b330ad197e5f77838cb41afa092887","head":{"label":"iphands:master","ref":"master","sha":"5a72abdb92b330ad197e5f77838cb41afa092887","user":{"login":"iphands","id":129737,"avatar_url":"https://avatars.githubusercontent.com/u/129737?v=3","gravatar_id":"","url":"https://api.github.com/users/iphands","html_url":"https://github.com/iphands","followers_url":"https://api.github.com/users/iphands/followers","following_url":"https://api.github.com/users/iphands/following{/other_user}","gists_url":"https://api.github.com/users/iphands/gists{/gist_id}","starred_url":"https://api.github.com/users/iphands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphands/subscriptions","organizations_url":"https://api.github.com/users/iphands/orgs","repos_url":"https://api.github.com/users/iphands/repos","events_url":"https://api.github.com/users/iphands/events{/privacy}","received_events_url":"https://api.github.com/users/iphands/received_events","type":"User","site_admin":false},"repo":{"id":37254558,"name":"metrics-graphics","full_name":"iphands/metrics-graphics","owner":{"login":"iphands","id":129737,"avatar_url":"https://avatars.githubusercontent.com/u/129737?v=3","gravatar_id":"","url":"https://api.github.com/users/iphands","html_url":"https://github.com/iphands","followers_url":"https://api.github.com/users/iphands/followers","following_url":"https://api.github.com/users/iphands/following{/other_user}","gists_url":"https://api.github.com/users/iphands/gists{/gist_id}","starred_url":"https://api.github.com/users/iphands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphands/subscriptions","organizations_url":"https://api.github.com/users/iphands/orgs","repos_url":"https://api.github.com/users/iphands/repos","events_url":"https://api.github.com/users/iphands/events{/privacy}","received_events_url":"https://api.github.com/users/iphands/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iphands/metrics-graphics","description":"A library optimized for concise, principled data graphics and layouts.","fork":true,"url":"https://api.github.com/repos/iphands/metrics-graphics","forks_url":"https://api.github.com/repos/iphands/metrics-graphics/forks","keys_url":"https://api.github.com/repos/iphands/metrics-graphics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iphands/metrics-graphics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iphands/metrics-graphics/teams","hooks_url":"https://api.github.com/repos/iphands/metrics-graphics/hooks","issue_events_url":"https://api.github.com/repos/iphands/metrics-graphics/issues/events{/number}","events_url":"https://api.github.com/repos/iphands/metrics-graphics/events","assignees_url":"https://api.github.com/repos/iphands/metrics-graphics/assignees{/user}","branches_url":"https://api.github.com/repos/iphands/metrics-graphics/branches{/branch}","tags_url":"https://api.github.com/repos/iphands/metrics-graphics/tags","blobs_url":"https://api.github.com/repos/iphands/metrics-graphics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iphands/metrics-graphics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iphands/metrics-graphics/git/refs{/sha}","trees_url":"https://api.github.com/repos/iphands/metrics-graphics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iphands/metrics-graphics/statuses/{sha}","languages_url":"https://api.github.com/repos/iphands/metrics-graphics/languages","stargazers_url":"https://api.github.com/repos/iphands/metrics-graphics/stargazers","contributors_url":"https://api.github.com/repos/iphands/metrics-graphics/contributors","subscribers_url":"https://api.github.com/repos/iphands/metrics-graphics/subscribers","subscription_url":"https://api.github.com/repos/iphands/metrics-graphics/subscription","commits_url":"https://api.github.com/repos/iphands/metrics-graphics/commits{/sha}","git_commits_url":"https://api.github.com/repos/iphands/metrics-graphics/git/commits{/sha}","comments_url":"https://api.github.com/repos/iphands/metrics-graphics/comments{/number}","issue_comment_url":"https://api.github.com/repos/iphands/metrics-graphics/issues/comments{/number}","contents_url":"https://api.github.com/repos/iphands/metrics-graphics/contents/{+path}","compare_url":"https://api.github.com/repos/iphands/metrics-graphics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iphands/metrics-graphics/merges","archive_url":"https://api.github.com/repos/iphands/metrics-graphics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iphands/metrics-graphics/downloads","issues_url":"https://api.github.com/repos/iphands/metrics-graphics/issues{/number}","pulls_url":"https://api.github.com/repos/iphands/metrics-graphics/pulls{/number}","milestones_url":"https://api.github.com/repos/iphands/metrics-graphics/milestones{/number}","notifications_url":"https://api.github.com/repos/iphands/metrics-graphics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iphands/metrics-graphics/labels{/name}","releases_url":"https://api.github.com/repos/iphands/metrics-graphics/releases{/id}","created_at":"2015-06-11T10:25:44Z","updated_at":"2015-06-11T10:25:45Z","pushed_at":"2015-06-11T10:58:18Z","git_url":"git://github.com/iphands/metrics-graphics.git","ssh_url":"git@github.com:iphands/metrics-graphics.git","clone_url":"https://github.com/iphands/metrics-graphics.git","svn_url":"https://github.com/iphands/metrics-graphics","homepage":"http://metricsgraphicsjs.org","size":3756,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"24a8d0880b4ef4fb12b1c6f72e0bc7716782bf51","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":19353482,"name":"metrics-graphics","full_name":"mozilla/metrics-graphics","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/metrics-graphics","description":"A library optimized for concise, principled data graphics and layouts.","fork":false,"url":"https://api.github.com/repos/mozilla/metrics-graphics","forks_url":"https://api.github.com/repos/mozilla/metrics-graphics/forks","keys_url":"https://api.github.com/repos/mozilla/metrics-graphics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/metrics-graphics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/metrics-graphics/teams","hooks_url":"https://api.github.com/repos/mozilla/metrics-graphics/hooks","issue_events_url":"https://api.github.com/repos/mozilla/metrics-graphics/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/metrics-graphics/events","assignees_url":"https://api.github.com/repos/mozilla/metrics-graphics/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/metrics-graphics/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/metrics-graphics/tags","blobs_url":"https://api.github.com/repos/mozilla/metrics-graphics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/metrics-graphics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/metrics-graphics/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/metrics-graphics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/metrics-graphics/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/metrics-graphics/languages","stargazers_url":"https://api.github.com/repos/mozilla/metrics-graphics/stargazers","contributors_url":"https://api.github.com/repos/mozilla/metrics-graphics/contributors","subscribers_url":"https://api.github.com/repos/mozilla/metrics-graphics/subscribers","subscription_url":"https://api.github.com/repos/mozilla/metrics-graphics/subscription","commits_url":"https://api.github.com/repos/mozilla/metrics-graphics/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/metrics-graphics/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/metrics-graphics/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/metrics-graphics/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/metrics-graphics/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/metrics-graphics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/metrics-graphics/merges","archive_url":"https://api.github.com/repos/mozilla/metrics-graphics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/metrics-graphics/downloads","issues_url":"https://api.github.com/repos/mozilla/metrics-graphics/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/metrics-graphics/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/metrics-graphics/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/metrics-graphics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/metrics-graphics/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/metrics-graphics/releases{/id}","created_at":"2014-05-01T18:25:52Z","updated_at":"2015-06-15T21:41:55Z","pushed_at":"2015-06-12T20:24:21Z","git_url":"git://github.com/mozilla/metrics-graphics.git","ssh_url":"git@github.com:mozilla/metrics-graphics.git","clone_url":"https://github.com/mozilla/metrics-graphics.git","svn_url":"https://github.com/mozilla/metrics-graphics","homepage":"http://metricsgraphicsjs.org","size":7563,"stargazers_count":4762,"watchers_count":4762,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"open_issues_count":38,"forks":228,"open_issues":38,"watchers":4762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447"},"html":{"href":"https://github.com/mozilla/metrics-graphics/pull/447"},"issue":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/issues/447"},"comments":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/metrics-graphics/statuses/5a72abdb92b330ad197e5f77838cb41afa092887"}}}}