{"action":"created","comment":{"url":"https://api.github.com/repos/kbond/php-backup/pulls/comments/45509023","id":45509023,"diff_hunk":"@@ -112,7 +113,7 @@ public function all()\n             throw new \\RuntimeException($process->getErrorOutput());\n         }\n \n-        return $this->parseS3CmdListOutput($process->getOutput());\n+        return new BackupCollection($this->parseS3CmdListOutput($process->getOutput()));","path":"src/Destination/S3CmdDestination.php","position":13,"original_position":13,"commit_id":"2a3f5204599a9bd9388f27a611b571a5680b4798","original_commit_id":"2a3f5204599a9bd9388f27a611b571a5680b4798","user":{"login":"kachkaev","id":608862,"avatar_url":"https://avatars.githubusercontent.com/u/608862?v=3","gravatar_id":"","url":"https://api.github.com/users/kachkaev","html_url":"https://github.com/kachkaev","followers_url":"https://api.github.com/users/kachkaev/followers","following_url":"https://api.github.com/users/kachkaev/following{/other_user}","gists_url":"https://api.github.com/users/kachkaev/gists{/gist_id}","starred_url":"https://api.github.com/users/kachkaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kachkaev/subscriptions","organizations_url":"https://api.github.com/users/kachkaev/orgs","repos_url":"https://api.github.com/users/kachkaev/repos","events_url":"https://api.github.com/users/kachkaev/events{/privacy}","received_events_url":"https://api.github.com/users/kachkaev/received_events","type":"User","site_admin":false},"body":"What is the rationale behind keeping S3CmdDestination after adding flysystem (except for BC, of course)? \r\nI'm not complaining, just asking :–)\r\n\r\nFlysystem seems to be a pretty universal way of pushing the backup to any destination type. Maybe it's worth switching to that engine in some future major release.","created_at":"2015-11-20T19:39:32Z","updated_at":"2015-11-20T19:39:32Z","html_url":"https://github.com/kbond/php-backup/pull/7#discussion_r45509023","pull_request_url":"https://api.github.com/repos/kbond/php-backup/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/kbond/php-backup/pulls/comments/45509023"},"html":{"href":"https://github.com/kbond/php-backup/pull/7#discussion_r45509023"},"pull_request":{"href":"https://api.github.com/repos/kbond/php-backup/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/kbond/php-backup/pulls/7","id":51397143,"html_url":"https://github.com/kbond/php-backup/pull/7","diff_url":"https://github.com/kbond/php-backup/pull/7.diff","patch_url":"https://github.com/kbond/php-backup/pull/7.patch","issue_url":"https://api.github.com/repos/kbond/php-backup/issues/7","number":7,"state":"open","locked":false,"title":"[RFC] Rotating backups","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"body":"This is a possible solution for #4. I tried to keep it as simple as possible.\r\n\r\nThere is a new `Destination` wrapper called `RotatedDestinaion`. This destination extends the `push()` method to first delete any existing backups found via a `RotateStrategy`. \r\n\r\nping @kachkaev","created_at":"2015-11-20T19:26:42Z","updated_at":"2015-11-20T19:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aee60227a9badcb436143f2e0d4efbcab3c3131b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kbond/php-backup/pulls/7/commits","review_comments_url":"https://api.github.com/repos/kbond/php-backup/pulls/7/comments","review_comment_url":"https://api.github.com/repos/kbond/php-backup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbond/php-backup/issues/7/comments","statuses_url":"https://api.github.com/repos/kbond/php-backup/statuses/2a3f5204599a9bd9388f27a611b571a5680b4798","head":{"label":"kbond:rotating-backups","ref":"rotating-backups","sha":"2a3f5204599a9bd9388f27a611b571a5680b4798","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"repo":{"id":45110395,"name":"php-backup","full_name":"kbond/php-backup","owner":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbond/php-backup","description":"PHP library to create and archive backups","fork":false,"url":"https://api.github.com/repos/kbond/php-backup","forks_url":"https://api.github.com/repos/kbond/php-backup/forks","keys_url":"https://api.github.com/repos/kbond/php-backup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbond/php-backup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbond/php-backup/teams","hooks_url":"https://api.github.com/repos/kbond/php-backup/hooks","issue_events_url":"https://api.github.com/repos/kbond/php-backup/issues/events{/number}","events_url":"https://api.github.com/repos/kbond/php-backup/events","assignees_url":"https://api.github.com/repos/kbond/php-backup/assignees{/user}","branches_url":"https://api.github.com/repos/kbond/php-backup/branches{/branch}","tags_url":"https://api.github.com/repos/kbond/php-backup/tags","blobs_url":"https://api.github.com/repos/kbond/php-backup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbond/php-backup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbond/php-backup/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbond/php-backup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbond/php-backup/statuses/{sha}","languages_url":"https://api.github.com/repos/kbond/php-backup/languages","stargazers_url":"https://api.github.com/repos/kbond/php-backup/stargazers","contributors_url":"https://api.github.com/repos/kbond/php-backup/contributors","subscribers_url":"https://api.github.com/repos/kbond/php-backup/subscribers","subscription_url":"https://api.github.com/repos/kbond/php-backup/subscription","commits_url":"https://api.github.com/repos/kbond/php-backup/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbond/php-backup/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbond/php-backup/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbond/php-backup/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbond/php-backup/contents/{+path}","compare_url":"https://api.github.com/repos/kbond/php-backup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbond/php-backup/merges","archive_url":"https://api.github.com/repos/kbond/php-backup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbond/php-backup/downloads","issues_url":"https://api.github.com/repos/kbond/php-backup/issues{/number}","pulls_url":"https://api.github.com/repos/kbond/php-backup/pulls{/number}","milestones_url":"https://api.github.com/repos/kbond/php-backup/milestones{/number}","notifications_url":"https://api.github.com/repos/kbond/php-backup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbond/php-backup/labels{/name}","releases_url":"https://api.github.com/repos/kbond/php-backup/releases{/id}","created_at":"2015-10-28T12:20:44Z","updated_at":"2015-11-20T14:09:33Z","pushed_at":"2015-11-20T19:26:43Z","git_url":"git://github.com/kbond/php-backup.git","ssh_url":"git@github.com:kbond/php-backup.git","clone_url":"https://github.com/kbond/php-backup.git","svn_url":"https://github.com/kbond/php-backup","homepage":null,"size":46,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"kbond:master","ref":"master","sha":"e396e090e34276bdfbbb35b30d80cf94d938d3af","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"repo":{"id":45110395,"name":"php-backup","full_name":"kbond/php-backup","owner":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbond/php-backup","description":"PHP library to create and archive backups","fork":false,"url":"https://api.github.com/repos/kbond/php-backup","forks_url":"https://api.github.com/repos/kbond/php-backup/forks","keys_url":"https://api.github.com/repos/kbond/php-backup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbond/php-backup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbond/php-backup/teams","hooks_url":"https://api.github.com/repos/kbond/php-backup/hooks","issue_events_url":"https://api.github.com/repos/kbond/php-backup/issues/events{/number}","events_url":"https://api.github.com/repos/kbond/php-backup/events","assignees_url":"https://api.github.com/repos/kbond/php-backup/assignees{/user}","branches_url":"https://api.github.com/repos/kbond/php-backup/branches{/branch}","tags_url":"https://api.github.com/repos/kbond/php-backup/tags","blobs_url":"https://api.github.com/repos/kbond/php-backup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbond/php-backup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbond/php-backup/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbond/php-backup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbond/php-backup/statuses/{sha}","languages_url":"https://api.github.com/repos/kbond/php-backup/languages","stargazers_url":"https://api.github.com/repos/kbond/php-backup/stargazers","contributors_url":"https://api.github.com/repos/kbond/php-backup/contributors","subscribers_url":"https://api.github.com/repos/kbond/php-backup/subscribers","subscription_url":"https://api.github.com/repos/kbond/php-backup/subscription","commits_url":"https://api.github.com/repos/kbond/php-backup/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbond/php-backup/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbond/php-backup/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbond/php-backup/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbond/php-backup/contents/{+path}","compare_url":"https://api.github.com/repos/kbond/php-backup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbond/php-backup/merges","archive_url":"https://api.github.com/repos/kbond/php-backup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbond/php-backup/downloads","issues_url":"https://api.github.com/repos/kbond/php-backup/issues{/number}","pulls_url":"https://api.github.com/repos/kbond/php-backup/pulls{/number}","milestones_url":"https://api.github.com/repos/kbond/php-backup/milestones{/number}","notifications_url":"https://api.github.com/repos/kbond/php-backup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbond/php-backup/labels{/name}","releases_url":"https://api.github.com/repos/kbond/php-backup/releases{/id}","created_at":"2015-10-28T12:20:44Z","updated_at":"2015-11-20T14:09:33Z","pushed_at":"2015-11-20T19:26:43Z","git_url":"git://github.com/kbond/php-backup.git","ssh_url":"git@github.com:kbond/php-backup.git","clone_url":"https://github.com/kbond/php-backup.git","svn_url":"https://github.com/kbond/php-backup","homepage":null,"size":46,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbond/php-backup/pulls/7"},"html":{"href":"https://github.com/kbond/php-backup/pull/7"},"issue":{"href":"https://api.github.com/repos/kbond/php-backup/issues/7"},"comments":{"href":"https://api.github.com/repos/kbond/php-backup/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/kbond/php-backup/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/kbond/php-backup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbond/php-backup/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/kbond/php-backup/statuses/2a3f5204599a9bd9388f27a611b571a5680b4798"}}}}