{"action":"created","issue":{"url":"https://api.github.com/repos/Artefact2/libxm/issues/4","labels_url":"https://api.github.com/repos/Artefact2/libxm/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Artefact2/libxm/issues/4/comments","events_url":"https://api.github.com/repos/Artefact2/libxm/issues/4/events","html_url":"https://github.com/Artefact2/libxm/pull/4","id":53737704,"number":4,"title":"Minor volume column porta fix","user":{"login":"DanielOaks","id":251281,"avatar_url":"https://avatars.githubusercontent.com/u/251281?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielOaks","html_url":"https://github.com/DanielOaks","followers_url":"https://api.github.com/users/DanielOaks/followers","following_url":"https://api.github.com/users/DanielOaks/following{/other_user}","gists_url":"https://api.github.com/users/DanielOaks/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielOaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielOaks/subscriptions","organizations_url":"https://api.github.com/users/DanielOaks/orgs","repos_url":"https://api.github.com/users/DanielOaks/repos","events_url":"https://api.github.com/users/DanielOaks/events{/privacy}","received_events_url":"https://api.github.com/users/DanielOaks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-08T10:51:48Z","updated_at":"2015-01-08T13:39:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Artefact2/libxm/pulls/4","html_url":"https://github.com/Artefact2/libxm/pull/4","diff_url":"https://github.com/Artefact2/libxm/pull/4.diff","patch_url":"https://github.com/Artefact2/libxm/pull/4.patch"},"body":"So I'm looking into the porta issues in #1, specifically the file [aurora_dawn.xm](http://modarchive.org/module.php?149875).\r\n\r\nI haven't yet cracked why it sounds so interesting (Milky sounds like it's not even applying porta to the note, I think it might be something to do with the tempo and ticks, seeing what I'm reading through a few docs. Maybe something with how we do ``SLIDE_TOWARDS`` or ``update_frequency``), but I'm gonna try and keep plodding along with it and see what I find.\r\n\r\nBut I did find this issue, which is why that big spike was happening. It was taking the effect number as well as the actual effect value  (instead of 7 there, it was grabbing a much larger number because of the ``M``).\r\n\r\nI haven't had a *good* look around at xm implementations, and I haven't done much audio work before, but I think porta's only meant to slide towards between the current and new note, right? I find it odd that even a larger than normal ``tone_portamento_param`` would make the note frequency spike – if anything, I'd expect it to just go between the two notes much faster than usual. But again, I'm not too familiar with XM, so I'll keep plodding along and see if I can work out the issue!\r\n\r\n**edit:** Having a play with MT, it looks like it is just doing the porta very fast, I suspect due to the tempo variable I saw some documentation about a bit earlier. I'll do some testing and see if I can get libxm sounding just like MT/etc sounds."},"comment":{"url":"https://api.github.com/repos/Artefact2/libxm/issues/comments/69179768","html_url":"https://github.com/Artefact2/libxm/pull/4#issuecomment-69179768","issue_url":"https://api.github.com/repos/Artefact2/libxm/issues/4","id":69179768,"user":{"login":"Artefact2","id":90720,"avatar_url":"https://avatars.githubusercontent.com/u/90720?v=3","gravatar_id":"","url":"https://api.github.com/users/Artefact2","html_url":"https://github.com/Artefact2","followers_url":"https://api.github.com/users/Artefact2/followers","following_url":"https://api.github.com/users/Artefact2/following{/other_user}","gists_url":"https://api.github.com/users/Artefact2/gists{/gist_id}","starred_url":"https://api.github.com/users/Artefact2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artefact2/subscriptions","organizations_url":"https://api.github.com/users/Artefact2/orgs","repos_url":"https://api.github.com/users/Artefact2/repos","events_url":"https://api.github.com/users/Artefact2/events{/privacy}","received_events_url":"https://api.github.com/users/Artefact2/received_events","type":"User","site_admin":false},"created_at":"2015-01-08T13:39:39Z","updated_at":"2015-01-08T13:39:39Z","body":"I've added a failing test in 73ac33b. Turns out `Mx` seems to behave like `3x0` instead of `30x`, but it doesn't sound that way in libxm."}}