{"action":"created","comment":{"url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/comments/38280080","id":38280080,"diff_hunk":"@@ -235,8 +235,16 @@ function! neobundle#installer#get_revision_number(bundle)\n \n     let rev = neobundle#util#system(cmd)\n \n-    \" If rev contains spaces, it is error message\n-    return (rev !~ '\\s') ? rev : ''\n+    if type.name ==# \"vba\" || type.name ==# \"raw\"\n+      \" If rev is ok, the output is the checksum followed by the filename\n+      \" separated by two spaces.\n+      let pat = '\\v^[0-9a-f]+  ' . a:bundle.path . '/' .\n+            \\ fnamemodify(a:bundle.uri, ':t') . '$'\n+      return (rev =~# pat) ? matchstr(rev, '\\v^[0-9a-f]+') : ''","path":"autoload/neobundle/installer.vim","position":11,"original_position":11,"commit_id":"bd1b8115bd2b89bff8b6ea7ba0b95f245c55917c","original_commit_id":"9bcf628344d75e6cf0c521284aa709acf0bcd78d","user":{"login":"paulhybryant","id":473349,"avatar_url":"https://avatars.githubusercontent.com/u/473349?v=3","gravatar_id":"","url":"https://api.github.com/users/paulhybryant","html_url":"https://github.com/paulhybryant","followers_url":"https://api.github.com/users/paulhybryant/followers","following_url":"https://api.github.com/users/paulhybryant/following{/other_user}","gists_url":"https://api.github.com/users/paulhybryant/gists{/gist_id}","starred_url":"https://api.github.com/users/paulhybryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulhybryant/subscriptions","organizations_url":"https://api.github.com/users/paulhybryant/orgs","repos_url":"https://api.github.com/users/paulhybryant/repos","events_url":"https://api.github.com/users/paulhybryant/events{/privacy}","received_events_url":"https://api.github.com/users/paulhybryant/received_events","type":"User","site_admin":false},"body":"Sure. Thanks.\n\nOn Sun, Aug 30, 2015 at 5:09 PM, Shougo <notifications@github.com> wrote:\n\n> In autoload/neobundle/installer.vim\n> <https://github.com/Shougo/neobundle.vim/pull/411#discussion_r38269917>:\n>\n> > @@ -235,8 +235,16 @@ function! neobundle#installer#get_revision_number(bundle)\n> >\n> >      let rev = neobundle#util#system(cmd)\n> >\n> > -    \" If rev contains spaces, it is error message\n> > -    return (rev !~ '\\s') ? rev : ''\n> > +    if type.name ==# \"vba\" || type.name ==# \"raw\"\n> > +      \" If rev is ok, the output is the checksum followed by the filename\n> > +      \" separated by two spaces.\n> > +      let pat = '\\v^[0-9a-f]+  ' . a:bundle.path . '/' .\n> > +            \\ fnamemodify(a:bundle.uri, ':t') . '$'\n> > +      return (rev =~# pat) ? matchstr(rev, '\\v^[0-9a-f]+') : ''\n>\n> It is ^[0-9a-f]\\+.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Shougo/neobundle.vim/pull/411/files#r38269917>.\n>\n\n\n\n-- \nWith Regards,\n\nYu Huang\n\nSoftware Engineer,\nGoogle Inc.\n","created_at":"2015-08-31T01:45:45Z","updated_at":"2015-08-31T01:45:45Z","html_url":"https://github.com/Shougo/neobundle.vim/pull/411#discussion_r38280080","pull_request_url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411","_links":{"self":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/comments/38280080"},"html":{"href":"https://github.com/Shougo/neobundle.vim/pull/411#discussion_r38280080"},"pull_request":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411","id":43597001,"html_url":"https://github.com/Shougo/neobundle.vim/pull/411","diff_url":"https://github.com/Shougo/neobundle.vim/pull/411.diff","patch_url":"https://github.com/Shougo/neobundle.vim/pull/411.patch","issue_url":"https://api.github.com/repos/Shougo/neobundle.vim/issues/411","number":411,"state":"open","locked":false,"title":"Add support for plugins in vba format.","user":{"login":"paulhybryant","id":473349,"avatar_url":"https://avatars.githubusercontent.com/u/473349?v=3","gravatar_id":"","url":"https://api.github.com/users/paulhybryant","html_url":"https://github.com/paulhybryant","followers_url":"https://api.github.com/users/paulhybryant/followers","following_url":"https://api.github.com/users/paulhybryant/following{/other_user}","gists_url":"https://api.github.com/users/paulhybryant/gists{/gist_id}","starred_url":"https://api.github.com/users/paulhybryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulhybryant/subscriptions","organizations_url":"https://api.github.com/users/paulhybryant/orgs","repos_url":"https://api.github.com/users/paulhybryant/repos","events_url":"https://api.github.com/users/paulhybryant/events{/privacy}","received_events_url":"https://api.github.com/users/paulhybryant/received_events","type":"User","site_admin":false},"body":"Hi Shougo,\r\n\r\nI am attempting to add this in my fork. Do you mind giving some feedback?\r\nSpecifically I am not quite sure why line 79 and 80 in vba.vim have no effect.\r\n\r\nAlso it would be great if you are open to merge this PR to support vba.\r\n\r\nThanks,","created_at":"2015-08-28T06:21:05Z","updated_at":"2015-08-31T01:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75b9806c9582c81cb368dccfb285ca21c14ae5c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411/commits","review_comments_url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411/comments","review_comment_url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shougo/neobundle.vim/issues/411/comments","statuses_url":"https://api.github.com/repos/Shougo/neobundle.vim/statuses/bd1b8115bd2b89bff8b6ea7ba0b95f245c55917c","head":{"label":"paulhybryant:master","ref":"master","sha":"bd1b8115bd2b89bff8b6ea7ba0b95f245c55917c","user":{"login":"paulhybryant","id":473349,"avatar_url":"https://avatars.githubusercontent.com/u/473349?v=3","gravatar_id":"","url":"https://api.github.com/users/paulhybryant","html_url":"https://github.com/paulhybryant","followers_url":"https://api.github.com/users/paulhybryant/followers","following_url":"https://api.github.com/users/paulhybryant/following{/other_user}","gists_url":"https://api.github.com/users/paulhybryant/gists{/gist_id}","starred_url":"https://api.github.com/users/paulhybryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulhybryant/subscriptions","organizations_url":"https://api.github.com/users/paulhybryant/orgs","repos_url":"https://api.github.com/users/paulhybryant/repos","events_url":"https://api.github.com/users/paulhybryant/events{/privacy}","received_events_url":"https://api.github.com/users/paulhybryant/received_events","type":"User","site_admin":false},"repo":{"id":41469853,"name":"neobundle.vim","full_name":"paulhybryant/neobundle.vim","owner":{"login":"paulhybryant","id":473349,"avatar_url":"https://avatars.githubusercontent.com/u/473349?v=3","gravatar_id":"","url":"https://api.github.com/users/paulhybryant","html_url":"https://github.com/paulhybryant","followers_url":"https://api.github.com/users/paulhybryant/followers","following_url":"https://api.github.com/users/paulhybryant/following{/other_user}","gists_url":"https://api.github.com/users/paulhybryant/gists{/gist_id}","starred_url":"https://api.github.com/users/paulhybryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulhybryant/subscriptions","organizations_url":"https://api.github.com/users/paulhybryant/orgs","repos_url":"https://api.github.com/users/paulhybryant/repos","events_url":"https://api.github.com/users/paulhybryant/events{/privacy}","received_events_url":"https://api.github.com/users/paulhybryant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulhybryant/neobundle.vim","description":"Next generation Vim package manager","fork":true,"url":"https://api.github.com/repos/paulhybryant/neobundle.vim","forks_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/forks","keys_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/teams","hooks_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/hooks","issue_events_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/issues/events{/number}","events_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/events","assignees_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/assignees{/user}","branches_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/branches{/branch}","tags_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/tags","blobs_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/statuses/{sha}","languages_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/languages","stargazers_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/stargazers","contributors_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/contributors","subscribers_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/subscribers","subscription_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/subscription","commits_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/contents/{+path}","compare_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/merges","archive_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/downloads","issues_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/issues{/number}","pulls_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/pulls{/number}","milestones_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/milestones{/number}","notifications_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/labels{/name}","releases_url":"https://api.github.com/repos/paulhybryant/neobundle.vim/releases{/id}","created_at":"2015-08-27T06:33:56Z","updated_at":"2015-08-27T06:33:57Z","pushed_at":"2015-08-30T07:59:00Z","git_url":"git://github.com/paulhybryant/neobundle.vim.git","ssh_url":"git@github.com:paulhybryant/neobundle.vim.git","clone_url":"https://github.com/paulhybryant/neobundle.vim.git","svn_url":"https://github.com/paulhybryant/neobundle.vim","homepage":"","size":2249,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Shougo:master","ref":"master","sha":"849487832fb2f3f76d2031bb439148d4bb85595d","user":{"login":"Shougo","id":41495,"avatar_url":"https://avatars.githubusercontent.com/u/41495?v=3","gravatar_id":"","url":"https://api.github.com/users/Shougo","html_url":"https://github.com/Shougo","followers_url":"https://api.github.com/users/Shougo/followers","following_url":"https://api.github.com/users/Shougo/following{/other_user}","gists_url":"https://api.github.com/users/Shougo/gists{/gist_id}","starred_url":"https://api.github.com/users/Shougo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shougo/subscriptions","organizations_url":"https://api.github.com/users/Shougo/orgs","repos_url":"https://api.github.com/users/Shougo/repos","events_url":"https://api.github.com/users/Shougo/events{/privacy}","received_events_url":"https://api.github.com/users/Shougo/received_events","type":"User","site_admin":false},"repo":{"id":2403263,"name":"neobundle.vim","full_name":"Shougo/neobundle.vim","owner":{"login":"Shougo","id":41495,"avatar_url":"https://avatars.githubusercontent.com/u/41495?v=3","gravatar_id":"","url":"https://api.github.com/users/Shougo","html_url":"https://github.com/Shougo","followers_url":"https://api.github.com/users/Shougo/followers","following_url":"https://api.github.com/users/Shougo/following{/other_user}","gists_url":"https://api.github.com/users/Shougo/gists{/gist_id}","starred_url":"https://api.github.com/users/Shougo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shougo/subscriptions","organizations_url":"https://api.github.com/users/Shougo/orgs","repos_url":"https://api.github.com/users/Shougo/repos","events_url":"https://api.github.com/users/Shougo/events{/privacy}","received_events_url":"https://api.github.com/users/Shougo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shougo/neobundle.vim","description":"Next generation Vim package manager","fork":false,"url":"https://api.github.com/repos/Shougo/neobundle.vim","forks_url":"https://api.github.com/repos/Shougo/neobundle.vim/forks","keys_url":"https://api.github.com/repos/Shougo/neobundle.vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shougo/neobundle.vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shougo/neobundle.vim/teams","hooks_url":"https://api.github.com/repos/Shougo/neobundle.vim/hooks","issue_events_url":"https://api.github.com/repos/Shougo/neobundle.vim/issues/events{/number}","events_url":"https://api.github.com/repos/Shougo/neobundle.vim/events","assignees_url":"https://api.github.com/repos/Shougo/neobundle.vim/assignees{/user}","branches_url":"https://api.github.com/repos/Shougo/neobundle.vim/branches{/branch}","tags_url":"https://api.github.com/repos/Shougo/neobundle.vim/tags","blobs_url":"https://api.github.com/repos/Shougo/neobundle.vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shougo/neobundle.vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shougo/neobundle.vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shougo/neobundle.vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shougo/neobundle.vim/statuses/{sha}","languages_url":"https://api.github.com/repos/Shougo/neobundle.vim/languages","stargazers_url":"https://api.github.com/repos/Shougo/neobundle.vim/stargazers","contributors_url":"https://api.github.com/repos/Shougo/neobundle.vim/contributors","subscribers_url":"https://api.github.com/repos/Shougo/neobundle.vim/subscribers","subscription_url":"https://api.github.com/repos/Shougo/neobundle.vim/subscription","commits_url":"https://api.github.com/repos/Shougo/neobundle.vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shougo/neobundle.vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shougo/neobundle.vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shougo/neobundle.vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shougo/neobundle.vim/contents/{+path}","compare_url":"https://api.github.com/repos/Shougo/neobundle.vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shougo/neobundle.vim/merges","archive_url":"https://api.github.com/repos/Shougo/neobundle.vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shougo/neobundle.vim/downloads","issues_url":"https://api.github.com/repos/Shougo/neobundle.vim/issues{/number}","pulls_url":"https://api.github.com/repos/Shougo/neobundle.vim/pulls{/number}","milestones_url":"https://api.github.com/repos/Shougo/neobundle.vim/milestones{/number}","notifications_url":"https://api.github.com/repos/Shougo/neobundle.vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shougo/neobundle.vim/labels{/name}","releases_url":"https://api.github.com/repos/Shougo/neobundle.vim/releases{/id}","created_at":"2011-09-17T02:56:51Z","updated_at":"2015-08-30T17:36:41Z","pushed_at":"2015-08-30T09:08:38Z","git_url":"git://github.com/Shougo/neobundle.vim.git","ssh_url":"git@github.com:Shougo/neobundle.vim.git","clone_url":"https://github.com/Shougo/neobundle.vim.git","svn_url":"https://github.com/Shougo/neobundle.vim","homepage":"","size":4825,"stargazers_count":1601,"watchers_count":1601,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":14,"forks":136,"open_issues":14,"watchers":1601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411"},"html":{"href":"https://github.com/Shougo/neobundle.vim/pull/411"},"issue":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/issues/411"},"comments":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/Shougo/neobundle.vim/statuses/bd1b8115bd2b89bff8b6ea7ba0b95f245c55917c"}}}}