{"action":"created","issue":{"url":"https://api.github.com/repos/aferrero2707/PhotoFlow/issues/52","labels_url":"https://api.github.com/repos/aferrero2707/PhotoFlow/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/aferrero2707/PhotoFlow/issues/52/comments","events_url":"https://api.github.com/repos/aferrero2707/PhotoFlow/issues/52/events","html_url":"https://github.com/aferrero2707/PhotoFlow/pull/52","id":119766624,"number":52,"title":"Fedora 23 compatibility","user":{"login":"oleastre","id":838332,"avatar_url":"https://avatars.githubusercontent.com/u/838332?v=3","gravatar_id":"","url":"https://api.github.com/users/oleastre","html_url":"https://github.com/oleastre","followers_url":"https://api.github.com/users/oleastre/followers","following_url":"https://api.github.com/users/oleastre/following{/other_user}","gists_url":"https://api.github.com/users/oleastre/gists{/gist_id}","starred_url":"https://api.github.com/users/oleastre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleastre/subscriptions","organizations_url":"https://api.github.com/users/oleastre/orgs","repos_url":"https://api.github.com/users/oleastre/repos","events_url":"https://api.github.com/users/oleastre/events{/privacy}","received_events_url":"https://api.github.com/users/oleastre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-01T17:23:39Z","updated_at":"2015-12-02T07:01:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aferrero2707/PhotoFlow/pulls/52","html_url":"https://github.com/aferrero2707/PhotoFlow/pull/52","diff_url":"https://github.com/aferrero2707/PhotoFlow/pull/52.diff","patch_url":"https://github.com/aferrero2707/PhotoFlow/pull/52.patch"},"body":"I tried to compile the current stable branch to fedora 23.\r\n\r\nI got some problems (and solutions in this PR):\r\n- static libraries should be compiled with the -fPIC flag\r\n- scrolledwin test is not gtkmm3 compatible (was the cmake test erroneous ?)\r\n- embedded lensfun installs it's library event if statically compiled.\r\n\r\nNote that Fedora packaging tries to avoid bundled libraries. So, is there a way to use the shared version of lensfun, or is the bundled one a modified version that's required ?"},"comment":{"url":"https://api.github.com/repos/aferrero2707/PhotoFlow/issues/comments/161202854","html_url":"https://github.com/aferrero2707/PhotoFlow/pull/52#issuecomment-161202854","issue_url":"https://api.github.com/repos/aferrero2707/PhotoFlow/issues/52","id":161202854,"user":{"login":"Joermungand","id":11301958,"avatar_url":"https://avatars.githubusercontent.com/u/11301958?v=3","gravatar_id":"","url":"https://api.github.com/users/Joermungand","html_url":"https://github.com/Joermungand","followers_url":"https://api.github.com/users/Joermungand/followers","following_url":"https://api.github.com/users/Joermungand/following{/other_user}","gists_url":"https://api.github.com/users/Joermungand/gists{/gist_id}","starred_url":"https://api.github.com/users/Joermungand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joermungand/subscriptions","organizations_url":"https://api.github.com/users/Joermungand/orgs","repos_url":"https://api.github.com/users/Joermungand/repos","events_url":"https://api.github.com/users/Joermungand/events{/privacy}","received_events_url":"https://api.github.com/users/Joermungand/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T07:01:44Z","updated_at":"2015-12-02T07:01:44Z","body":"What I failed to mention was that the lens correction layer never \nmanaged to load. While the application behaved normally, it wouldn’t get \nto the point where the camera/lens got detected. I updated to the latest \ncommit and everything works fine now. Thanks.\n\nOn 02/12/15 08:22, aferrero2707 wrote:\n> The .messages in the latest are normal, they are there to debug the issue\n> on Ubuntu. I've removed them in the latest code.\n>\n> I'll try to make the bundling optional this evening. Meanwhile, the latest\n> code should not install lens fun library anymore.\n>\n> Thanks!\n> Il 01/dic/2015 22:47, \"Joermungand\" <notifications@github.com> ha scritto:\n>\n> > Yeah, it’s precisely that.\n> >\n> > I’ve tested the lens correction tool (found under geom/Optical\n> > corrections, right?) with both 2.4 and the latest stable before the\n> > lensfun bundle. The former works just fine and correctly identifies my\n> > camera/lens models as stored in the raw file. The latter, however,\n> > starts a process that spits continuous (looping) x,y field/value pairs\n> > in the terminal, which does not stop even after exiting PhotoFlow. The\n> > glitch must be somewhere in between the two. I’ve kept all the\n> > intermediary compiled packages of the stable branch, so I can test each\n> > one in turn and tell you where things break, if it’s any help.\n> >\n> > Nothing to thank me for. Just glad to help.\n> >\n> > On 01/12/15 23:17, aferrero2707 wrote:\n> > >\n> > > @Alex <https://github.com/Alex>: could this be due to the fact that,\n> > > as Olivier pointed out, the bundled lensfun was installing the static\n> > > library in the system directories, clearly conflicting with the\n> > > system-wide lensfun installation? This should be solved by the latest\n> > > commit to the stable branch...\n> > >\n> > > Concerning the bundling, as I said it was a sort-of hack to get the\n> > > lens correction tool work properly under Ubuntu (or at least better\n> > > debug crashes if they will occur again). Could you maybe check if\n> > > under Arch the lens correction tool was working fine in version 0.2.4?\n> > > Then I have no problem making the bundling optional and\n> > > flag-controlled (it will maybe take a couple of days).\n> > > By the way, there is nothing in photoflow that requires the latest\n> > > lensfun version.\n> > >\n> > > Thanks!\n> > >\n> > > —\n> > > Reply to this email directly or view it on GitHub\n> > > <\n> > \n> https://github.com/aferrero2707/PhotoFlow/pull/52#issuecomment-161098364>.\n> > >\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > \n> <https://github.com/aferrero2707/PhotoFlow/pull/52#issuecomment-161105799>\n> > .\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/aferrero2707/PhotoFlow/pull/52#issuecomment-161191675>.\n>\n\n"}}