{"action":"created","issue":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/64","labels_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/64/comments","events_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/64/events","html_url":"https://github.com/sailfishos/sailfish-office/pull/64","id":122940901,"number":64,"title":"[sailfish-office] Fix pdf document image grabbing. Fixes JB#31599","user":{"login":"rainemak","id":3470958,"avatar_url":"https://avatars.githubusercontent.com/u/3470958?v=3","gravatar_id":"","url":"https://api.github.com/users/rainemak","html_url":"https://github.com/rainemak","followers_url":"https://api.github.com/users/rainemak/followers","following_url":"https://api.github.com/users/rainemak/following{/other_user}","gists_url":"https://api.github.com/users/rainemak/gists{/gist_id}","starred_url":"https://api.github.com/users/rainemak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainemak/subscriptions","organizations_url":"https://api.github.com/users/rainemak/orgs","repos_url":"https://api.github.com/users/rainemak/repos","events_url":"https://api.github.com/users/rainemak/events{/privacy}","received_events_url":"https://api.github.com/users/rainemak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-18T12:30:36Z","updated_at":"2015-12-21T09:56:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/64","html_url":"https://github.com/sailfishos/sailfish-office/pull/64","diff_url":"https://github.com/sailfishos/sailfish-office/pull/64.diff","patch_url":"https://github.com/sailfishos/sailfish-office/pull/64.patch"},"body":"This requires a small change on Sailfish Silica. Thus, left the ```updateCover``` but in practice that could be removed. If everybody agrees, I'd like to drop it already now.\r\n\r\nIdea here is that content is grab when peeking starts (cover becomes visible) and released when cover is invisible and application window is visible (in practice at foreground). The releasing part guarantees that the old captured document doesn't flicker on the cover.\r\n\r\nIn addition, grabbing is done only if application window is visible (main window). Currently you can see errors printed from QQuickItemGrabResultPrivate::create we're trying to grab when main window is already hidden."},"comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/comments/166254677","html_url":"https://github.com/sailfishos/sailfish-office/pull/64#issuecomment-166254677","issue_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/64","id":166254677,"user":{"login":"pvuorela","id":2478615,"avatar_url":"https://avatars.githubusercontent.com/u/2478615?v=3","gravatar_id":"","url":"https://api.github.com/users/pvuorela","html_url":"https://github.com/pvuorela","followers_url":"https://api.github.com/users/pvuorela/followers","following_url":"https://api.github.com/users/pvuorela/following{/other_user}","gists_url":"https://api.github.com/users/pvuorela/gists{/gist_id}","starred_url":"https://api.github.com/users/pvuorela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvuorela/subscriptions","organizations_url":"https://api.github.com/users/pvuorela/orgs","repos_url":"https://api.github.com/users/pvuorela/repos","events_url":"https://api.github.com/users/pvuorela/events{/privacy}","received_events_url":"https://api.github.com/users/pvuorela/received_events","type":"User","site_admin":false},"created_at":"2015-12-21T09:56:59Z","updated_at":"2015-12-21T09:56:59Z","body":"Silica changes seem source compatible, so no objections for removing temporary code."}}