{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/24375754","id":24375754,"diff_hunk":"@@ -322,23 +424,21 @@ def find_easyconfigs(path, ignore_dirs=None):\n                 continue\n \n             spec = os.path.join(dirpath, f)\n-            _log.debug(\"Found easyconfig %s\" % spec)\n+            _log.debug(\"Found easyconfig %s\", spec)\n             files.append(spec)\n \n         # ignore subdirs specified to be ignored by replacing items in dirnames list used by os.walk\n-        dirnames[:] = [d for d in dirnames if not d in ignore_dirs]\n+        dirnames[:] = [d for d in dirnames if d not in ignore_dirs]\n \n     return files\n \n \n-def search_file(paths, query, short=False, ignore_dirs=None, silent=False):\n+def search_file(paths, query, short=False, ignore_dirs=['.git', '.svn'], silent=False):","path":"easybuild/tools/filetools.py","position":203,"original_position":203,"commit_id":"837ee0f423d7fd890723164c0f6d62426faa7f60","original_commit_id":"837ee0f423d7fd890723164c0f6d62426faa7f60","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"don't use a list a default value, since it's mutable and can get very weird... (appending to `ignore_dirs` in the function body results in actually modifying the default value)\r\n\r\nalso, use `build_option('ignore_dirs')` is case `ignore_dirs` is `None`, don't hardcode a default like this, since we already have a default defined for `--ignore-dirs` in `easybuild/tools/options.py`\r\n\r\n","created_at":"2015-02-09T23:19:47Z","updated_at":"2015-02-09T23:19:47Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1082#discussion_r24375754","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/24375754"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1082#discussion_r24375754"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082","id":23623184,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/1082","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1082.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1082.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1082","number":1082,"state":"open","locked":false,"title":"\tadded support for checking out svn revisions to download_file","user":{"login":"JensTimmerman","id":281523,"avatar_url":"https://avatars.githubusercontent.com/u/281523?v=3","gravatar_id":"","url":"https://api.github.com/users/JensTimmerman","html_url":"https://github.com/JensTimmerman","followers_url":"https://api.github.com/users/JensTimmerman/followers","following_url":"https://api.github.com/users/JensTimmerman/following{/other_user}","gists_url":"https://api.github.com/users/JensTimmerman/gists{/gist_id}","starred_url":"https://api.github.com/users/JensTimmerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensTimmerman/subscriptions","organizations_url":"https://api.github.com/users/JensTimmerman/orgs","repos_url":"https://api.github.com/users/JensTimmerman/repos","events_url":"https://api.github.com/users/JensTimmerman/events{/privacy}","received_events_url":"https://api.github.com/users/JensTimmerman/received_events","type":"User","site_admin":false},"body":"This works for easyconfig files looking like this (if pysvn and tar are available on the system):\r\n\r\n\r\n```\r\nname = 'FDS'\r\nversion = '20564'\r\n\r\nhomepage = 'https://code.google.com/p/fds-smv/'\r\ndescription = \"\"\"\r\n Fire Dynamics Simulator (FDS) is a large-eddy simulation (LES) code for low-speed flows, with an emphasis on smoke and\r\n heat transport from fires.\r\n\"\"\"\r\ntoolchain = {'name': 'foss', 'version': '2014b'}\r\ntoolchainopts = {'pic': True, 'usempi': True}\r\n\r\nsource_urls = ['svn+http://fds-smv.googlecode.com/svn/trunk/FDS/trunk/']\r\n\r\nsources = ['%(version)s.tar.gz']\r\nmoduleclass = 'phys'\r\n```\r\n\r\nnote the 'svn+http' part in the source_urls, this is needed to tell the download function to use svn. version is used as the revision number to check out, \r\nsources are currently always '%(version)s.tar.gz'\r\nSine this code checks out the svn repo at the given revision, creates a tarball, and removes it again.\r\n","created_at":"2014-10-30T17:35:36Z","updated_at":"2015-02-09T23:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fc3276d70693a006f8f738adac1114561d560e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1082/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/837ee0f423d7fd890723164c0f6d62426faa7f60","head":{"label":"JensTimmerman:svn","ref":"svn","sha":"837ee0f423d7fd890723164c0f6d62426faa7f60","user":{"login":"JensTimmerman","id":281523,"avatar_url":"https://avatars.githubusercontent.com/u/281523?v=3","gravatar_id":"","url":"https://api.github.com/users/JensTimmerman","html_url":"https://github.com/JensTimmerman","followers_url":"https://api.github.com/users/JensTimmerman/followers","following_url":"https://api.github.com/users/JensTimmerman/following{/other_user}","gists_url":"https://api.github.com/users/JensTimmerman/gists{/gist_id}","starred_url":"https://api.github.com/users/JensTimmerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensTimmerman/subscriptions","organizations_url":"https://api.github.com/users/JensTimmerman/orgs","repos_url":"https://api.github.com/users/JensTimmerman/repos","events_url":"https://api.github.com/users/JensTimmerman/events{/privacy}","received_events_url":"https://api.github.com/users/JensTimmerman/received_events","type":"User","site_admin":false},"repo":{"id":4107251,"name":"easybuild-framework","full_name":"JensTimmerman/easybuild-framework","owner":{"login":"JensTimmerman","id":281523,"avatar_url":"https://avatars.githubusercontent.com/u/281523?v=3","gravatar_id":"","url":"https://api.github.com/users/JensTimmerman","html_url":"https://github.com/JensTimmerman","followers_url":"https://api.github.com/users/JensTimmerman/followers","following_url":"https://api.github.com/users/JensTimmerman/following{/other_user}","gists_url":"https://api.github.com/users/JensTimmerman/gists{/gist_id}","starred_url":"https://api.github.com/users/JensTimmerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensTimmerman/subscriptions","organizations_url":"https://api.github.com/users/JensTimmerman/orgs","repos_url":"https://api.github.com/users/JensTimmerman/repos","events_url":"https://api.github.com/users/JensTimmerman/events{/privacy}","received_events_url":"https://api.github.com/users/JensTimmerman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JensTimmerman/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/JensTimmerman/easybuild-framework","forks_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/forks","keys_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/events","assignees_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/merges","archive_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/JensTimmerman/easybuild-framework/releases{/id}","created_at":"2012-04-22T21:20:23Z","updated_at":"2014-06-19T15:34:59Z","pushed_at":"2015-02-09T15:37:54Z","git_url":"git://github.com/JensTimmerman/easybuild-framework.git","ssh_url":"git@github.com:JensTimmerman/easybuild-framework.git","clone_url":"https://github.com/JensTimmerman/easybuild-framework.git","svn_url":"https://github.com/JensTimmerman/easybuild-framework","homepage":"","size":7969,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"e280ab0a54da189dbd388fa5f2f126039af66ca5","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","created_at":"2012-03-08T17:07:43Z","updated_at":"2015-01-30T14:03:55Z","pushed_at":"2015-02-07T08:58:58Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":13704,"stargazers_count":39,"watchers_count":39,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":217,"forks":53,"open_issues":217,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1082"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1082"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/837ee0f423d7fd890723164c0f6d62426faa7f60"}}}}