{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/48045463","id":48045463,"diff_hunk":"@@ -72,6 +81,15 @@ var Settings = {\n     }\n   },\n \n+  // return resolve promise with sendReadReport status\n+  initSendReadReport: function initSendReadReport(value) {\n+    this._sendReadReportDefer.resolve(value);\n+    delete this._sendReadReportDefer;\n+\n+    navigator.mozSettings.addObserver(this.SEND_READ_REPORT_KEY,\n+      (e) => this.sendReadReport = Promise.resolve(e.settingValue));","path":"apps/sms/views/shared/js/settings.js","position":63,"original_position":63,"commit_id":"4a5d7ee7ac828237a92d860ae704003bf91945ac","original_commit_id":"4a5d7ee7ac828237a92d860ae704003bf91945ac","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"nit: please indent like we usually do in the SMS app :)\r\n```javascript\r\nnavigator.mozSettings.addObserver(\r\n  this.SEND_READ_REPORT_KEY,\r\n  (e) => ...\r\n);\r\n```","created_at":"2015-12-18T16:56:16Z","updated_at":"2015-12-18T16:56:16Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/32044#discussion_r48045463","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/48045463"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32044#discussion_r48045463"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044","id":45977414,"html_url":"https://github.com/mozilla-b2g/gaia/pull/32044","diff_url":"https://github.com/mozilla-b2g/gaia/pull/32044.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/32044.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32044","number":32044,"state":"open","locked":false,"title":"Bug 1180470 - [Messages] Propose a setting to disable sending the read report","user":{"login":"kumarrishav","id":4078325,"avatar_url":"https://avatars.githubusercontent.com/u/4078325?v=3","gravatar_id":"","url":"https://api.github.com/users/kumarrishav","html_url":"https://github.com/kumarrishav","followers_url":"https://api.github.com/users/kumarrishav/followers","following_url":"https://api.github.com/users/kumarrishav/following{/other_user}","gists_url":"https://api.github.com/users/kumarrishav/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarrishav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarrishav/subscriptions","organizations_url":"https://api.github.com/users/kumarrishav/orgs","repos_url":"https://api.github.com/users/kumarrishav/repos","events_url":"https://api.github.com/users/kumarrishav/events{/privacy}","received_events_url":"https://api.github.com/users/kumarrishav/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-25T05:00:32Z","updated_at":"2015-12-18T16:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4687c5138cc1eda42116e7706d672cb31f33dab3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32044/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4a5d7ee7ac828237a92d860ae704003bf91945ac","head":{"label":"kumarrishav:new-Bug-1180470","ref":"new-Bug-1180470","sha":"4a5d7ee7ac828237a92d860ae704003bf91945ac","user":{"login":"kumarrishav","id":4078325,"avatar_url":"https://avatars.githubusercontent.com/u/4078325?v=3","gravatar_id":"","url":"https://api.github.com/users/kumarrishav","html_url":"https://github.com/kumarrishav","followers_url":"https://api.github.com/users/kumarrishav/followers","following_url":"https://api.github.com/users/kumarrishav/following{/other_user}","gists_url":"https://api.github.com/users/kumarrishav/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarrishav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarrishav/subscriptions","organizations_url":"https://api.github.com/users/kumarrishav/orgs","repos_url":"https://api.github.com/users/kumarrishav/repos","events_url":"https://api.github.com/users/kumarrishav/events{/privacy}","received_events_url":"https://api.github.com/users/kumarrishav/received_events","type":"User","site_admin":false},"repo":{"id":14716677,"name":"gaia","full_name":"kumarrishav/gaia","owner":{"login":"kumarrishav","id":4078325,"avatar_url":"https://avatars.githubusercontent.com/u/4078325?v=3","gravatar_id":"","url":"https://api.github.com/users/kumarrishav","html_url":"https://github.com/kumarrishav","followers_url":"https://api.github.com/users/kumarrishav/followers","following_url":"https://api.github.com/users/kumarrishav/following{/other_user}","gists_url":"https://api.github.com/users/kumarrishav/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarrishav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarrishav/subscriptions","organizations_url":"https://api.github.com/users/kumarrishav/orgs","repos_url":"https://api.github.com/users/kumarrishav/repos","events_url":"https://api.github.com/users/kumarrishav/events{/privacy}","received_events_url":"https://api.github.com/users/kumarrishav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kumarrishav/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/kumarrishav/gaia","forks_url":"https://api.github.com/repos/kumarrishav/gaia/forks","keys_url":"https://api.github.com/repos/kumarrishav/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kumarrishav/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kumarrishav/gaia/teams","hooks_url":"https://api.github.com/repos/kumarrishav/gaia/hooks","issue_events_url":"https://api.github.com/repos/kumarrishav/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/kumarrishav/gaia/events","assignees_url":"https://api.github.com/repos/kumarrishav/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/kumarrishav/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/kumarrishav/gaia/tags","blobs_url":"https://api.github.com/repos/kumarrishav/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kumarrishav/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kumarrishav/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/kumarrishav/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kumarrishav/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/kumarrishav/gaia/languages","stargazers_url":"https://api.github.com/repos/kumarrishav/gaia/stargazers","contributors_url":"https://api.github.com/repos/kumarrishav/gaia/contributors","subscribers_url":"https://api.github.com/repos/kumarrishav/gaia/subscribers","subscription_url":"https://api.github.com/repos/kumarrishav/gaia/subscription","commits_url":"https://api.github.com/repos/kumarrishav/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/kumarrishav/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/kumarrishav/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/kumarrishav/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/kumarrishav/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/kumarrishav/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kumarrishav/gaia/merges","archive_url":"https://api.github.com/repos/kumarrishav/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kumarrishav/gaia/downloads","issues_url":"https://api.github.com/repos/kumarrishav/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/kumarrishav/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/kumarrishav/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/kumarrishav/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kumarrishav/gaia/labels{/name}","releases_url":"https://api.github.com/repos/kumarrishav/gaia/releases{/id}","created_at":"2013-11-26T12:45:49Z","updated_at":"2015-04-01T07:33:18Z","pushed_at":"2015-12-04T13:13:23Z","git_url":"git://github.com/kumarrishav/gaia.git","ssh_url":"git@github.com:kumarrishav/gaia.git","clone_url":"https://github.com/kumarrishav/gaia.git","svn_url":"https://github.com/kumarrishav/gaia","homepage":"https://wiki.mozilla.org/B2G","size":967348,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ef8d5801f34219d7162415f56e6811a0e7cae305","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-12-18T05:07:07Z","pushed_at":"2015-12-18T16:29:50Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1187354,"stargazers_count":2022,"watchers_count":2022,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2575,"mirror_url":null,"open_issues_count":1294,"forks":2575,"open_issues":1294,"watchers":2022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32044"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32044"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32044/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32044/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4a5d7ee7ac828237a92d860ae704003bf91945ac"}}}}