{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/23575377","id":23575377,"diff_hunk":"@@ -1,30 +0,0 @@\n-# https://devcenter.heroku.com/articles/rails-unicorn\n-\n-worker_processes (ENV[\"UNICORN_WORKERS\"] || 3).to_i\n-timeout (ENV[\"UNICORN_TIMEOUT\"] || 15).to_i\n-preload_app true\n-\n-before_fork do |_server, _worker|\n-  Signal.trap \"TERM\" do\n-    puts \"Unicorn master intercepting TERM, sending myself QUIT instead\"\n-    Process.kill \"QUIT\", Process.pid\n-  end\n-\n-  if defined? ActiveRecord::Base\n-    ActiveRecord::Base.connection.disconnect!\n-  end\n-end\n-\n-after_fork do |_server, _worker|\n-  Signal.trap \"TERM\" do\n-    puts \"Unicorn worker intercepting TERM, waiting for master to send QUIT\"\n-  end\n-\n-  if defined? ActiveRecord::Base\n-    config = ActiveRecord::Base.configurations[Rails.env] ||\n-      Rails.application.config.database_configuration[Rails.env]\n-    config[\"reaping_frequency\"] = (ENV[\"DB_REAPING_FREQUENCY\"] || 10).to_i\n-    config[\"pool\"] = (ENV[\"DB_POOL\"] || 2).to_i","path":"templates/unicorn.rb","position":27,"original_position":27,"commit_id":"3de47d88fbfd08d8abfef26b77b047236064cb11","original_commit_id":"3de47d88fbfd08d8abfef26b77b047236064cb11","user":{"login":"croaky","id":198,"avatar_url":"https://avatars.githubusercontent.com/u/198?v=3","gravatar_id":"","url":"https://api.github.com/users/croaky","html_url":"https://github.com/croaky","followers_url":"https://api.github.com/users/croaky/followers","following_url":"https://api.github.com/users/croaky/following{/other_user}","gists_url":"https://api.github.com/users/croaky/gists{/gist_id}","starred_url":"https://api.github.com/users/croaky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croaky/subscriptions","organizations_url":"https://api.github.com/users/croaky/orgs","repos_url":"https://api.github.com/users/croaky/repos","events_url":"https://api.github.com/users/croaky/events{/privacy}","received_events_url":"https://api.github.com/users/croaky/received_events","type":"User","site_admin":false},"body":"It looks like there's a regression here, losing our `DB_POOL` setting. It looks like with Heroku and Puma, they suggest setting it in the `database.yml` file:\r\n\r\nhttps://devcenter.heroku.com/articles/concurrency-and-database-connections#threaded-servers","created_at":"2015-01-26T23:44:35Z","updated_at":"2015-01-26T23:44:35Z","html_url":"https://github.com/thoughtbot/suspenders/pull/501#discussion_r23575377","pull_request_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/23575377"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/501#discussion_r23575377"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501","id":28055792,"html_url":"https://github.com/thoughtbot/suspenders/pull/501","diff_url":"https://github.com/thoughtbot/suspenders/pull/501.diff","patch_url":"https://github.com/thoughtbot/suspenders/pull/501.patch","issue_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/501","number":501,"state":"open","locked":false,"title":"Replace Unicorn with Puma","user":{"login":"calebthompson","id":711717,"avatar_url":"https://avatars.githubusercontent.com/u/711717?v=3","gravatar_id":"","url":"https://api.github.com/users/calebthompson","html_url":"https://github.com/calebthompson","followers_url":"https://api.github.com/users/calebthompson/followers","following_url":"https://api.github.com/users/calebthompson/following{/other_user}","gists_url":"https://api.github.com/users/calebthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/calebthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebthompson/subscriptions","organizations_url":"https://api.github.com/users/calebthompson/orgs","repos_url":"https://api.github.com/users/calebthompson/repos","events_url":"https://api.github.com/users/calebthompson/events{/privacy}","received_events_url":"https://api.github.com/users/calebthompson/received_events","type":"User","site_admin":false},"body":"> Heroku now recommends using the Puma webserver. The previously\n> recommended webserver, Unicorn, is susceptible to slow client attacks.\n\nhttps://devcenter.heroku.com/changelog-items/594","created_at":"2015-01-26T20:05:09Z","updated_at":"2015-01-26T23:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e76711f4cc1f39c3956a10dc036d6aa8ef0de250","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/501/comments","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/3de47d88fbfd08d8abfef26b77b047236064cb11","head":{"label":"thoughtbot:ct-unicorn","ref":"ct-unicorn","sha":"3de47d88fbfd08d8abfef26b77b047236064cb11","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":666566,"name":"suspenders","full_name":"thoughtbot/suspenders","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/suspenders","description":"A Rails template with our standard defaults, ready to deploy to Heroku.","fork":false,"url":"https://api.github.com/repos/thoughtbot/suspenders","forks_url":"https://api.github.com/repos/thoughtbot/suspenders/forks","keys_url":"https://api.github.com/repos/thoughtbot/suspenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/suspenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/suspenders/teams","hooks_url":"https://api.github.com/repos/thoughtbot/suspenders/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/suspenders/events","assignees_url":"https://api.github.com/repos/thoughtbot/suspenders/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/suspenders/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/suspenders/tags","blobs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/suspenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/suspenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/suspenders/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/suspenders/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/suspenders/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/suspenders/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/suspenders/subscription","commits_url":"https://api.github.com/repos/thoughtbot/suspenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/suspenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/suspenders/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/suspenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/suspenders/merges","archive_url":"https://api.github.com/repos/thoughtbot/suspenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/suspenders/downloads","issues_url":"https://api.github.com/repos/thoughtbot/suspenders/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/suspenders/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/suspenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/suspenders/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/suspenders/releases{/id}","created_at":"2010-05-14T14:34:46Z","updated_at":"2015-01-26T23:25:01Z","pushed_at":"2015-01-26T20:07:12Z","git_url":"git://github.com/thoughtbot/suspenders.git","ssh_url":"git@github.com:thoughtbot/suspenders.git","clone_url":"https://github.com/thoughtbot/suspenders.git","svn_url":"https://github.com/thoughtbot/suspenders","homepage":"","size":4517,"stargazers_count":1572,"watchers_count":1572,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":13,"forks":255,"open_issues":13,"watchers":1572,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"f82b5b05a7b78a8ddb3db0d3b001db5d7334e412","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":666566,"name":"suspenders","full_name":"thoughtbot/suspenders","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/suspenders","description":"A Rails template with our standard defaults, ready to deploy to Heroku.","fork":false,"url":"https://api.github.com/repos/thoughtbot/suspenders","forks_url":"https://api.github.com/repos/thoughtbot/suspenders/forks","keys_url":"https://api.github.com/repos/thoughtbot/suspenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/suspenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/suspenders/teams","hooks_url":"https://api.github.com/repos/thoughtbot/suspenders/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/suspenders/events","assignees_url":"https://api.github.com/repos/thoughtbot/suspenders/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/suspenders/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/suspenders/tags","blobs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/suspenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/suspenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/suspenders/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/suspenders/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/suspenders/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/suspenders/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/suspenders/subscription","commits_url":"https://api.github.com/repos/thoughtbot/suspenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/suspenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/suspenders/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/suspenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/suspenders/merges","archive_url":"https://api.github.com/repos/thoughtbot/suspenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/suspenders/downloads","issues_url":"https://api.github.com/repos/thoughtbot/suspenders/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/suspenders/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/suspenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/suspenders/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/suspenders/releases{/id}","created_at":"2010-05-14T14:34:46Z","updated_at":"2015-01-26T23:25:01Z","pushed_at":"2015-01-26T20:07:12Z","git_url":"git://github.com/thoughtbot/suspenders.git","ssh_url":"git@github.com:thoughtbot/suspenders.git","clone_url":"https://github.com/thoughtbot/suspenders.git","svn_url":"https://github.com/thoughtbot/suspenders","homepage":"","size":4517,"stargazers_count":1572,"watchers_count":1572,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":13,"forks":255,"open_issues":13,"watchers":1572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/501"},"issue":{"href":"https://api.github.com/repos/thoughtbot/suspenders/issues/501"},"comments":{"href":"https://api.github.com/repos/thoughtbot/suspenders/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/suspenders/statuses/3de47d88fbfd08d8abfef26b77b047236064cb11"}}}}