{"action":"created","comment":{"url":"https://api.github.com/repos/box/ClusterRunner/pulls/comments/38051330","id":38051330,"diff_hunk":"@@ -33,3 +43,19 @@ def test_update_timing_file(self, existing_timing_data, new_timing_data, expecte\n             updated_timing_data = json.load(timing_file)\n \n         self.assertDictEqual(updated_timing_data, expected_final_timing_data)\n+\n+    def test_get_failed_subjob_and_atom_ids_returns_correct_ids(self):\n+        \"\"\"\n+        Build artifact directory:\n+            artifact_1_0/clusterrunner_exit_code -> 0\n+            artifact_1_1/clusterrunner_exit_code -> 1\n+            artifact_2_0/clusterrunner_exit_code -> 0\n+            artifact_2_1/clusterrunner_exit_code -> 1\n+\n+        Expected to return: [(1,1), (2,1)]\n+        \"\"\"\n+        build_artifact = BuildArtifact(self._artifact_directory_path)\n+        failed_subjob_and_atoms = build_artifact.get_failed_subjob_and_atom_ids()\n+        self.assertIn((1, 1), failed_subjob_and_atoms)\n+        self.assertIn((2, 1), failed_subjob_and_atoms)\n+        self.assertEquals(2, len(failed_subjob_and_atoms))","path":"test/integration/master/test_build_artifact.py","position":63,"original_position":63,"commit_id":"037f1e23db51749fd3e83342ea01f01fb633b6ee","original_commit_id":"037f1e23db51749fd3e83342ea01f01fb633b6ee","user":{"login":"josephharrington","id":1109303,"avatar_url":"https://avatars.githubusercontent.com/u/1109303?v=3","gravatar_id":"","url":"https://api.github.com/users/josephharrington","html_url":"https://github.com/josephharrington","followers_url":"https://api.github.com/users/josephharrington/followers","following_url":"https://api.github.com/users/josephharrington/following{/other_user}","gists_url":"https://api.github.com/users/josephharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/josephharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephharrington/subscriptions","organizations_url":"https://api.github.com/users/josephharrington/orgs","repos_url":"https://api.github.com/users/josephharrington/repos","events_url":"https://api.github.com/users/josephharrington/events{/privacy}","received_events_url":"https://api.github.com/users/josephharrington/received_events","type":"User","site_admin":false},"body":"I think you might be able to combine all three asserts with \r\n```python\r\nself.assertCountEqual(failed_subjob_and_atoms, [(1, 1), (1, 2)])\r\n```","created_at":"2015-08-27T00:23:10Z","updated_at":"2015-08-27T00:23:10Z","html_url":"https://github.com/box/ClusterRunner/pull/257#discussion_r38051330","pull_request_url":"https://api.github.com/repos/box/ClusterRunner/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/comments/38051330"},"html":{"href":"https://github.com/box/ClusterRunner/pull/257#discussion_r38051330"},"pull_request":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/box/ClusterRunner/pulls/257","id":43463985,"html_url":"https://github.com/box/ClusterRunner/pull/257","diff_url":"https://github.com/box/ClusterRunner/pull/257.diff","patch_url":"https://github.com/box/ClusterRunner/pull/257.patch","issue_url":"https://api.github.com/repos/box/ClusterRunner/issues/257","number":257,"state":"open","locked":false,"title":"Change 'failed_atoms' endpoint API representation for a build","user":{"login":"tjlee0909","id":3615089,"avatar_url":"https://avatars.githubusercontent.com/u/3615089?v=3","gravatar_id":"","url":"https://api.github.com/users/tjlee0909","html_url":"https://github.com/tjlee0909","followers_url":"https://api.github.com/users/tjlee0909/followers","following_url":"https://api.github.com/users/tjlee0909/following{/other_user}","gists_url":"https://api.github.com/users/tjlee0909/gists{/gist_id}","starred_url":"https://api.github.com/users/tjlee0909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjlee0909/subscriptions","organizations_url":"https://api.github.com/users/tjlee0909/orgs","repos_url":"https://api.github.com/users/tjlee0909/repos","events_url":"https://api.github.com/users/tjlee0909/events{/privacy}","received_events_url":"https://api.github.com/users/tjlee0909/received_events","type":"User","site_admin":false},"body":"to return the api_representation of the atoms.","created_at":"2015-08-26T23:26:21Z","updated_at":"2015-08-27T00:23:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05f162b7f275b90148adda42ecacf743da4b937e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/box/ClusterRunner/pulls/257/commits","review_comments_url":"https://api.github.com/repos/box/ClusterRunner/pulls/257/comments","review_comment_url":"https://api.github.com/repos/box/ClusterRunner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/box/ClusterRunner/issues/257/comments","statuses_url":"https://api.github.com/repos/box/ClusterRunner/statuses/037f1e23db51749fd3e83342ea01f01fb633b6ee","head":{"label":"box:failed_atoms_api_representation_should_be_original_atomization","ref":"failed_atoms_api_representation_should_be_original_atomization","sha":"037f1e23db51749fd3e83342ea01f01fb633b6ee","user":{"login":"box","id":23900,"avatar_url":"https://avatars.githubusercontent.com/u/23900?v=3","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"repo":{"id":25371175,"name":"ClusterRunner","full_name":"box/ClusterRunner","owner":{"login":"box","id":23900,"avatar_url":"https://avatars.githubusercontent.com/u/23900?v=3","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/box/ClusterRunner","description":"ClusterRunner makes it easy to execute test-suites across your infrastructure in the fastest and most efficient way possible.","fork":false,"url":"https://api.github.com/repos/box/ClusterRunner","forks_url":"https://api.github.com/repos/box/ClusterRunner/forks","keys_url":"https://api.github.com/repos/box/ClusterRunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/box/ClusterRunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/box/ClusterRunner/teams","hooks_url":"https://api.github.com/repos/box/ClusterRunner/hooks","issue_events_url":"https://api.github.com/repos/box/ClusterRunner/issues/events{/number}","events_url":"https://api.github.com/repos/box/ClusterRunner/events","assignees_url":"https://api.github.com/repos/box/ClusterRunner/assignees{/user}","branches_url":"https://api.github.com/repos/box/ClusterRunner/branches{/branch}","tags_url":"https://api.github.com/repos/box/ClusterRunner/tags","blobs_url":"https://api.github.com/repos/box/ClusterRunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/box/ClusterRunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/box/ClusterRunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/box/ClusterRunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/box/ClusterRunner/statuses/{sha}","languages_url":"https://api.github.com/repos/box/ClusterRunner/languages","stargazers_url":"https://api.github.com/repos/box/ClusterRunner/stargazers","contributors_url":"https://api.github.com/repos/box/ClusterRunner/contributors","subscribers_url":"https://api.github.com/repos/box/ClusterRunner/subscribers","subscription_url":"https://api.github.com/repos/box/ClusterRunner/subscription","commits_url":"https://api.github.com/repos/box/ClusterRunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/box/ClusterRunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/box/ClusterRunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/box/ClusterRunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/box/ClusterRunner/contents/{+path}","compare_url":"https://api.github.com/repos/box/ClusterRunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/box/ClusterRunner/merges","archive_url":"https://api.github.com/repos/box/ClusterRunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/box/ClusterRunner/downloads","issues_url":"https://api.github.com/repos/box/ClusterRunner/issues{/number}","pulls_url":"https://api.github.com/repos/box/ClusterRunner/pulls{/number}","milestones_url":"https://api.github.com/repos/box/ClusterRunner/milestones{/number}","notifications_url":"https://api.github.com/repos/box/ClusterRunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/box/ClusterRunner/labels{/name}","releases_url":"https://api.github.com/repos/box/ClusterRunner/releases{/id}","created_at":"2014-10-17T18:20:39Z","updated_at":"2015-07-07T15:58:06Z","pushed_at":"2015-08-26T23:26:22Z","git_url":"git://github.com/box/ClusterRunner.git","ssh_url":"git@github.com:box/ClusterRunner.git","clone_url":"https://github.com/box/ClusterRunner.git","svn_url":"https://github.com/box/ClusterRunner","homepage":"http://clusterrunner.com","size":7098,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":40,"forks":13,"open_issues":40,"watchers":56,"default_branch":"master"}},"base":{"label":"box:master","ref":"master","sha":"c74c2e12efa9c8af90e110828b289e1e059afefc","user":{"login":"box","id":23900,"avatar_url":"https://avatars.githubusercontent.com/u/23900?v=3","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"repo":{"id":25371175,"name":"ClusterRunner","full_name":"box/ClusterRunner","owner":{"login":"box","id":23900,"avatar_url":"https://avatars.githubusercontent.com/u/23900?v=3","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/box/ClusterRunner","description":"ClusterRunner makes it easy to execute test-suites across your infrastructure in the fastest and most efficient way possible.","fork":false,"url":"https://api.github.com/repos/box/ClusterRunner","forks_url":"https://api.github.com/repos/box/ClusterRunner/forks","keys_url":"https://api.github.com/repos/box/ClusterRunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/box/ClusterRunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/box/ClusterRunner/teams","hooks_url":"https://api.github.com/repos/box/ClusterRunner/hooks","issue_events_url":"https://api.github.com/repos/box/ClusterRunner/issues/events{/number}","events_url":"https://api.github.com/repos/box/ClusterRunner/events","assignees_url":"https://api.github.com/repos/box/ClusterRunner/assignees{/user}","branches_url":"https://api.github.com/repos/box/ClusterRunner/branches{/branch}","tags_url":"https://api.github.com/repos/box/ClusterRunner/tags","blobs_url":"https://api.github.com/repos/box/ClusterRunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/box/ClusterRunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/box/ClusterRunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/box/ClusterRunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/box/ClusterRunner/statuses/{sha}","languages_url":"https://api.github.com/repos/box/ClusterRunner/languages","stargazers_url":"https://api.github.com/repos/box/ClusterRunner/stargazers","contributors_url":"https://api.github.com/repos/box/ClusterRunner/contributors","subscribers_url":"https://api.github.com/repos/box/ClusterRunner/subscribers","subscription_url":"https://api.github.com/repos/box/ClusterRunner/subscription","commits_url":"https://api.github.com/repos/box/ClusterRunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/box/ClusterRunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/box/ClusterRunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/box/ClusterRunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/box/ClusterRunner/contents/{+path}","compare_url":"https://api.github.com/repos/box/ClusterRunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/box/ClusterRunner/merges","archive_url":"https://api.github.com/repos/box/ClusterRunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/box/ClusterRunner/downloads","issues_url":"https://api.github.com/repos/box/ClusterRunner/issues{/number}","pulls_url":"https://api.github.com/repos/box/ClusterRunner/pulls{/number}","milestones_url":"https://api.github.com/repos/box/ClusterRunner/milestones{/number}","notifications_url":"https://api.github.com/repos/box/ClusterRunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/box/ClusterRunner/labels{/name}","releases_url":"https://api.github.com/repos/box/ClusterRunner/releases{/id}","created_at":"2014-10-17T18:20:39Z","updated_at":"2015-07-07T15:58:06Z","pushed_at":"2015-08-26T23:26:22Z","git_url":"git://github.com/box/ClusterRunner.git","ssh_url":"git@github.com:box/ClusterRunner.git","clone_url":"https://github.com/box/ClusterRunner.git","svn_url":"https://github.com/box/ClusterRunner","homepage":"http://clusterrunner.com","size":7098,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":40,"forks":13,"open_issues":40,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/257"},"html":{"href":"https://github.com/box/ClusterRunner/pull/257"},"issue":{"href":"https://api.github.com/repos/box/ClusterRunner/issues/257"},"comments":{"href":"https://api.github.com/repos/box/ClusterRunner/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/box/ClusterRunner/statuses/037f1e23db51749fd3e83342ea01f01fb633b6ee"}}}}