{"action":"closed","number":6591,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6591","id":49867579,"html_url":"https://github.com/dotnet/roslyn/pull/6591","diff_url":"https://github.com/dotnet/roslyn/pull/6591.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6591.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6591","number":6591,"state":"closed","locked":false,"title":"Disable pumping in one more place in the project system","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"body":"Windows erorr reporting shows reports of crashes due to LockRecursionException\r\ndue to the following pattern:\r\n* ASP.NET design view forces a lazy loaded tab to be populated during solution load\r\n* That causes us to need to start pushing to workspace hosts in\r\n  VisualStudioProjectTracker.StartPushingToWorkspaceAndNotifyOfOpenDocuments\r\n* Ends up waiting in Workspace.OnDocumentOpened.\r\n* Waiting pumps, and ASP.NET is finished parsing, so it tries to set the compilation options\r\n* Workspace.OnCompilationOptionsChanged throws because the lock is the same one being waited\r\n  on by Workspace.OnDocumentOpened.\r\n\r\nFixes one of the causes of internal bug 149765.","created_at":"2015-11-05T19:20:20Z","updated_at":"2015-11-09T15:42:30Z","closed_at":"2015-11-09T15:42:30Z","merged_at":"2015-11-09T15:42:30Z","merge_commit_sha":"eb9d109dbf1e60cfabd38120518a84c42ebab94f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6591/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6591/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6591/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/a0bfff2006f9c05edaa66f4bc8ee4243479cc5c3","head":{"label":"Pilchie:Fix149765-1-LockRecursion","ref":"Fix149765-1-LockRecursion","sha":"a0bfff2006f9c05edaa66f4bc8ee4243479cc5c3","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"repo":{"id":29272236,"name":"roslyn","full_name":"Pilchie/roslyn","owner":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pilchie/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/Pilchie/roslyn","forks_url":"https://api.github.com/repos/Pilchie/roslyn/forks","keys_url":"https://api.github.com/repos/Pilchie/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pilchie/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pilchie/roslyn/teams","hooks_url":"https://api.github.com/repos/Pilchie/roslyn/hooks","issue_events_url":"https://api.github.com/repos/Pilchie/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/Pilchie/roslyn/events","assignees_url":"https://api.github.com/repos/Pilchie/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/Pilchie/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/Pilchie/roslyn/tags","blobs_url":"https://api.github.com/repos/Pilchie/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pilchie/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pilchie/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pilchie/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pilchie/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/Pilchie/roslyn/languages","stargazers_url":"https://api.github.com/repos/Pilchie/roslyn/stargazers","contributors_url":"https://api.github.com/repos/Pilchie/roslyn/contributors","subscribers_url":"https://api.github.com/repos/Pilchie/roslyn/subscribers","subscription_url":"https://api.github.com/repos/Pilchie/roslyn/subscription","commits_url":"https://api.github.com/repos/Pilchie/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pilchie/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pilchie/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pilchie/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pilchie/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/Pilchie/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pilchie/roslyn/merges","archive_url":"https://api.github.com/repos/Pilchie/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pilchie/roslyn/downloads","issues_url":"https://api.github.com/repos/Pilchie/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/Pilchie/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/Pilchie/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/Pilchie/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pilchie/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/Pilchie/roslyn/releases{/id}","created_at":"2015-01-15T00:05:23Z","updated_at":"2015-01-15T00:06:02Z","pushed_at":"2015-11-05T19:17:55Z","git_url":"git://github.com/Pilchie/roslyn.git","ssh_url":"git@github.com:Pilchie/roslyn.git","clone_url":"https://github.com/Pilchie/roslyn.git","svn_url":"https://github.com/Pilchie/roslyn","homepage":"","size":107212,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b78d8e018d9db71eb1e2ce4c6ac8aad8f5ab3187","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-11-09T15:16:05Z","pushed_at":"2015-11-09T15:42:30Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":230237,"stargazers_count":3682,"watchers_count":3682,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":879,"mirror_url":null,"open_issues_count":1594,"forks":879,"open_issues":1594,"watchers":3682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6591"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6591"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6591"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6591/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6591/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6591/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/a0bfff2006f9c05edaa66f4bc8ee4243479cc5c3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}