{"push_id":660884219,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"fade1790a724ccafd46ce9ccd20235f02d6e3d71","before":"1b794d56b72853fe2eecbea2c719886c44578ed8","commits":[{"sha":"075bb8d1256de8f7f3469eed9fc9b89bef74f824","author":{"email":"2c708eb0a58047bf403399f50b3da33ffd2dd444@webrtc.org","name":"Karl Wiberg"},"message":"Fix race in AudioCodingModuleImpl::Add10MsData()\n\nAudioCodingModuleImpl::Add10MsData() calls two private methods that\ntogether do all the work: Add10MsDataInternal() and Encode(). They\neach took locks internally in order to protect access to, among other\nthings, codec_manager_.\n\nThis turned out to be inadequate. Add10MsDataInternal() calls\ncodec_manager_.CurrentEncoder()->SampleRateHz() in order to be able to\nresample the audio data to what the current encoder wants. When the\nresampled data is fed to the encoder deep inside the Encode() call,\nthat sample rate must still be correct, but occasionally it wasn't,\nwhich triggered a CHECK. (The specific test that failed was the\nvoe_auto_test subtest\nCodecTest.OpusMaxPlaybackRateCannotBeSetForNonOpus, which changes the\ncurrent encoder while encoding is in progress.)\n\nThis CL solves the problem by covering all of\nAudioCodingModuleImpl::Add10MsData() in a single critical section, so\nthat the sample rate obtained in Add10MsDataInternal() is guaranteed\nto still be valid during the Encode() call.\n\nBUG=4644\nR=henrik.lundin@webrtc.org\n\nReview URL: https://webrtc-codereview.appspot.com/52459004\n\nCr-Commit-Position: refs/heads/master@{#9174}","distinct":true,"url":"https://api.github.com/repos/vsimon/webrtcbuilds/commits/075bb8d1256de8f7f3469eed9fc9b89bef74f824"},{"sha":"fade1790a724ccafd46ce9ccd20235f02d6e3d71","author":{"email":"835dd55d2edbcf18427bfaff167a5f261a98c2e0@webrtc.org","name":"Peter Boström"},"message":"Remove leaking aecdump testfiles.\n\nAlso removes tracing to file in ApmTest because it leads to remaining\nfiles.\n\nBUG=4258\nR=bjornv@webrtc.org, kjellander@webrtc.org\n\nReview URL: https://webrtc-codereview.appspot.com/52469004\n\nCr-Commit-Position: refs/heads/master@{#9175}","distinct":true,"url":"https://api.github.com/repos/vsimon/webrtcbuilds/commits/fade1790a724ccafd46ce9ccd20235f02d6e3d71"}]}