{"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/robertvacha/SC/pulls/8","id":53392274,"html_url":"https://github.com/robertvacha/SC/pull/8","diff_url":"https://github.com/robertvacha/SC/pull/8.diff","patch_url":"https://github.com/robertvacha/SC/pull/8.patch","issue_url":"https://api.github.com/repos/robertvacha/SC/issues/8","number":8,"state":"open","locked":false,"title":"Fix CM bug + change in usePBC","user":{"login":"MirekJ","id":11032442,"avatar_url":"https://avatars.githubusercontent.com/u/11032442?v=3","gravatar_id":"","url":"https://api.github.com/users/MirekJ","html_url":"https://github.com/MirekJ","followers_url":"https://api.github.com/users/MirekJ/followers","following_url":"https://api.github.com/users/MirekJ/following{/other_user}","gists_url":"https://api.github.com/users/MirekJ/gists{/gist_id}","starred_url":"https://api.github.com/users/MirekJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirekJ/subscriptions","organizations_url":"https://api.github.com/users/MirekJ/orgs","repos_url":"https://api.github.com/users/MirekJ/repos","events_url":"https://api.github.com/users/MirekJ/events{/privacy}","received_events_url":"https://api.github.com/users/MirekJ/received_events","type":"User","site_admin":false},"body":"Problem in CM was in fact that it use function usePBC() which does not worked differently then you would expect ... it does not use PBC conditions on internal but on real positions of particles. Also it does not put particles in central box, but in neighbour box.\r\n\r\nSo I changed usePBC() in way it work on internal representation which lead to minor change in order scaling and then calling usePBC in initializer.\r\n\r\nChanges were tested.","created_at":"2015-12-11T13:28:12Z","updated_at":"2015-12-11T13:28:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robertvacha/SC/pulls/8/commits","review_comments_url":"https://api.github.com/repos/robertvacha/SC/pulls/8/comments","review_comment_url":"https://api.github.com/repos/robertvacha/SC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robertvacha/SC/issues/8/comments","statuses_url":"https://api.github.com/repos/robertvacha/SC/statuses/f0950a57ca1b6c57a3933343d3aefd270fa451a8","head":{"label":"MirekJ:FixUsePBC","ref":"FixUsePBC","sha":"f0950a57ca1b6c57a3933343d3aefd270fa451a8","user":{"login":"MirekJ","id":11032442,"avatar_url":"https://avatars.githubusercontent.com/u/11032442?v=3","gravatar_id":"","url":"https://api.github.com/users/MirekJ","html_url":"https://github.com/MirekJ","followers_url":"https://api.github.com/users/MirekJ/followers","following_url":"https://api.github.com/users/MirekJ/following{/other_user}","gists_url":"https://api.github.com/users/MirekJ/gists{/gist_id}","starred_url":"https://api.github.com/users/MirekJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirekJ/subscriptions","organizations_url":"https://api.github.com/users/MirekJ/orgs","repos_url":"https://api.github.com/users/MirekJ/repos","events_url":"https://api.github.com/users/MirekJ/events{/privacy}","received_events_url":"https://api.github.com/users/MirekJ/received_events","type":"User","site_admin":false},"repo":{"id":31012267,"name":"SC","full_name":"MirekJ/SC","owner":{"login":"MirekJ","id":11032442,"avatar_url":"https://avatars.githubusercontent.com/u/11032442?v=3","gravatar_id":"","url":"https://api.github.com/users/MirekJ","html_url":"https://github.com/MirekJ","followers_url":"https://api.github.com/users/MirekJ/followers","following_url":"https://api.github.com/users/MirekJ/following{/other_user}","gists_url":"https://api.github.com/users/MirekJ/gists{/gist_id}","starred_url":"https://api.github.com/users/MirekJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirekJ/subscriptions","organizations_url":"https://api.github.com/users/MirekJ/orgs","repos_url":"https://api.github.com/users/MirekJ/repos","events_url":"https://api.github.com/users/MirekJ/events{/privacy}","received_events_url":"https://api.github.com/users/MirekJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MirekJ/SC","description":"C++ code for Monte Carlo simulations of patchy spherocylinders","fork":true,"url":"https://api.github.com/repos/MirekJ/SC","forks_url":"https://api.github.com/repos/MirekJ/SC/forks","keys_url":"https://api.github.com/repos/MirekJ/SC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MirekJ/SC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MirekJ/SC/teams","hooks_url":"https://api.github.com/repos/MirekJ/SC/hooks","issue_events_url":"https://api.github.com/repos/MirekJ/SC/issues/events{/number}","events_url":"https://api.github.com/repos/MirekJ/SC/events","assignees_url":"https://api.github.com/repos/MirekJ/SC/assignees{/user}","branches_url":"https://api.github.com/repos/MirekJ/SC/branches{/branch}","tags_url":"https://api.github.com/repos/MirekJ/SC/tags","blobs_url":"https://api.github.com/repos/MirekJ/SC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MirekJ/SC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MirekJ/SC/git/refs{/sha}","trees_url":"https://api.github.com/repos/MirekJ/SC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MirekJ/SC/statuses/{sha}","languages_url":"https://api.github.com/repos/MirekJ/SC/languages","stargazers_url":"https://api.github.com/repos/MirekJ/SC/stargazers","contributors_url":"https://api.github.com/repos/MirekJ/SC/contributors","subscribers_url":"https://api.github.com/repos/MirekJ/SC/subscribers","subscription_url":"https://api.github.com/repos/MirekJ/SC/subscription","commits_url":"https://api.github.com/repos/MirekJ/SC/commits{/sha}","git_commits_url":"https://api.github.com/repos/MirekJ/SC/git/commits{/sha}","comments_url":"https://api.github.com/repos/MirekJ/SC/comments{/number}","issue_comment_url":"https://api.github.com/repos/MirekJ/SC/issues/comments{/number}","contents_url":"https://api.github.com/repos/MirekJ/SC/contents/{+path}","compare_url":"https://api.github.com/repos/MirekJ/SC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MirekJ/SC/merges","archive_url":"https://api.github.com/repos/MirekJ/SC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MirekJ/SC/downloads","issues_url":"https://api.github.com/repos/MirekJ/SC/issues{/number}","pulls_url":"https://api.github.com/repos/MirekJ/SC/pulls{/number}","milestones_url":"https://api.github.com/repos/MirekJ/SC/milestones{/number}","notifications_url":"https://api.github.com/repos/MirekJ/SC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MirekJ/SC/labels{/name}","releases_url":"https://api.github.com/repos/MirekJ/SC/releases{/id}","created_at":"2015-02-19T11:24:15Z","updated_at":"2015-09-14T12:41:36Z","pushed_at":"2015-12-11T13:21:48Z","git_url":"git://github.com/MirekJ/SC.git","ssh_url":"git@github.com:MirekJ/SC.git","clone_url":"https://github.com/MirekJ/SC.git","svn_url":"https://github.com/MirekJ/SC","homepage":null,"size":34452,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"robertvacha:master","ref":"master","sha":"6b0af0aa610aaed8c0bdacb24f24c52ddf076976","user":{"login":"robertvacha","id":3294118,"avatar_url":"https://avatars.githubusercontent.com/u/3294118?v=3","gravatar_id":"","url":"https://api.github.com/users/robertvacha","html_url":"https://github.com/robertvacha","followers_url":"https://api.github.com/users/robertvacha/followers","following_url":"https://api.github.com/users/robertvacha/following{/other_user}","gists_url":"https://api.github.com/users/robertvacha/gists{/gist_id}","starred_url":"https://api.github.com/users/robertvacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertvacha/subscriptions","organizations_url":"https://api.github.com/users/robertvacha/orgs","repos_url":"https://api.github.com/users/robertvacha/repos","events_url":"https://api.github.com/users/robertvacha/events{/privacy}","received_events_url":"https://api.github.com/users/robertvacha/received_events","type":"User","site_admin":false},"repo":{"id":14586355,"name":"SC","full_name":"robertvacha/SC","owner":{"login":"robertvacha","id":3294118,"avatar_url":"https://avatars.githubusercontent.com/u/3294118?v=3","gravatar_id":"","url":"https://api.github.com/users/robertvacha","html_url":"https://github.com/robertvacha","followers_url":"https://api.github.com/users/robertvacha/followers","following_url":"https://api.github.com/users/robertvacha/following{/other_user}","gists_url":"https://api.github.com/users/robertvacha/gists{/gist_id}","starred_url":"https://api.github.com/users/robertvacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertvacha/subscriptions","organizations_url":"https://api.github.com/users/robertvacha/orgs","repos_url":"https://api.github.com/users/robertvacha/repos","events_url":"https://api.github.com/users/robertvacha/events{/privacy}","received_events_url":"https://api.github.com/users/robertvacha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertvacha/SC","description":"C++ code for Monte Carlo simulations of patchy spherocylinders","fork":false,"url":"https://api.github.com/repos/robertvacha/SC","forks_url":"https://api.github.com/repos/robertvacha/SC/forks","keys_url":"https://api.github.com/repos/robertvacha/SC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertvacha/SC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertvacha/SC/teams","hooks_url":"https://api.github.com/repos/robertvacha/SC/hooks","issue_events_url":"https://api.github.com/repos/robertvacha/SC/issues/events{/number}","events_url":"https://api.github.com/repos/robertvacha/SC/events","assignees_url":"https://api.github.com/repos/robertvacha/SC/assignees{/user}","branches_url":"https://api.github.com/repos/robertvacha/SC/branches{/branch}","tags_url":"https://api.github.com/repos/robertvacha/SC/tags","blobs_url":"https://api.github.com/repos/robertvacha/SC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertvacha/SC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertvacha/SC/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertvacha/SC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertvacha/SC/statuses/{sha}","languages_url":"https://api.github.com/repos/robertvacha/SC/languages","stargazers_url":"https://api.github.com/repos/robertvacha/SC/stargazers","contributors_url":"https://api.github.com/repos/robertvacha/SC/contributors","subscribers_url":"https://api.github.com/repos/robertvacha/SC/subscribers","subscription_url":"https://api.github.com/repos/robertvacha/SC/subscription","commits_url":"https://api.github.com/repos/robertvacha/SC/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertvacha/SC/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertvacha/SC/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertvacha/SC/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertvacha/SC/contents/{+path}","compare_url":"https://api.github.com/repos/robertvacha/SC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertvacha/SC/merges","archive_url":"https://api.github.com/repos/robertvacha/SC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertvacha/SC/downloads","issues_url":"https://api.github.com/repos/robertvacha/SC/issues{/number}","pulls_url":"https://api.github.com/repos/robertvacha/SC/pulls{/number}","milestones_url":"https://api.github.com/repos/robertvacha/SC/milestones{/number}","notifications_url":"https://api.github.com/repos/robertvacha/SC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertvacha/SC/labels{/name}","releases_url":"https://api.github.com/repos/robertvacha/SC/releases{/id}","created_at":"2013-11-21T11:59:15Z","updated_at":"2015-09-02T11:52:45Z","pushed_at":"2015-12-11T13:28:12Z","git_url":"git://github.com/robertvacha/SC.git","ssh_url":"git@github.com:robertvacha/SC.git","clone_url":"https://github.com/robertvacha/SC.git","svn_url":"https://github.com/robertvacha/SC","homepage":null,"size":34428,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robertvacha/SC/pulls/8"},"html":{"href":"https://github.com/robertvacha/SC/pull/8"},"issue":{"href":"https://api.github.com/repos/robertvacha/SC/issues/8"},"comments":{"href":"https://api.github.com/repos/robertvacha/SC/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/robertvacha/SC/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/robertvacha/SC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robertvacha/SC/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/robertvacha/SC/statuses/f0950a57ca1b6c57a3933343d3aefd270fa451a8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":22,"deletions":24,"changed_files":3}}