{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/22971370","id":22971370,"diff_hunk":"@@ -180,20 +180,19 @@ Call.prototype.connectToRoom_ = function(mediaPromise, turnPromise) {\n   // already registered with GAE.\n   Promise.all([channelPromise, registerPromise]).then(function() {\n     this.channel_.register(this.params_.roomId, this.params_.clientId);\n+    // We only create a peer connection once we have media and TURN. Since right","path":"samples/web/content/apprtc/js/call.js","position":null,"original_position":4,"commit_id":"53da6372e0d901315582573e757b44f6ee2b09cb","original_commit_id":"fe2e373c0d8c599f9b7caef2ee4a4ba09cff52d7","user":{"login":"jiayliu","id":7770539,"avatar_url":"https://avatars.githubusercontent.com/u/7770539?v=3","gravatar_id":"","url":"https://api.github.com/users/jiayliu","html_url":"https://github.com/jiayliu","followers_url":"https://api.github.com/users/jiayliu/followers","following_url":"https://api.github.com/users/jiayliu/following{/other_user}","gists_url":"https://api.github.com/users/jiayliu/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayliu/subscriptions","organizations_url":"https://api.github.com/users/jiayliu/orgs","repos_url":"https://api.github.com/users/jiayliu/repos","events_url":"https://api.github.com/users/jiayliu/events{/privacy}","received_events_url":"https://api.github.com/users/jiayliu/received_events","type":"User","site_admin":false},"body":"Done.\r\n\r\nOn Wed, Jan 14, 2015 at 1:17 PM, Justin Uberti <notifications@github.com>\r\nwrote:\r\n\r\n> In samples/web/content/apprtc/js/call.js\r\n> <https://github.com/GoogleChrome/webrtc/pull/377#discussion-diff-22970670>\r\n> :\r\n>\r\n> > @@ -180,20 +180,19 @@ Call.prototype.connectToRoom_ = function(mediaPromise, turnPromise) {\r\n> >    // already registered with GAE.\r\n> >    Promise.all([channelPromise, registerPromise]).then(function() {\r\n> >      this.channel_.register(this.params_.roomId, this.params_.clientId);\r\n> > +    // We only create a peer connection once we have media and TURN. Since right\r\n>\r\n> Update this comment?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/GoogleChrome/webrtc/pull/377/files#r22970670>.\r\n>\r\n\r\n\r\n\r\n-- \r\nJiayang Liu","created_at":"2015-01-14T21:26:43Z","updated_at":"2015-01-14T21:26:43Z","html_url":"https://github.com/GoogleChrome/webrtc/pull/377#discussion_r22971370","pull_request_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/22971370"},"html":{"href":"https://github.com/GoogleChrome/webrtc/pull/377#discussion_r22971370"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377","id":27380282,"html_url":"https://github.com/GoogleChrome/webrtc/pull/377","diff_url":"https://github.com/GoogleChrome/webrtc/pull/377.diff","patch_url":"https://github.com/GoogleChrome/webrtc/pull/377.patch","issue_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/377","number":377,"state":"open","locked":false,"title":"Do not start signaling until signaling channel is registered","user":{"login":"jiayliu","id":7770539,"avatar_url":"https://avatars.githubusercontent.com/u/7770539?v=3","gravatar_id":"","url":"https://api.github.com/users/jiayliu","html_url":"https://github.com/jiayliu","followers_url":"https://api.github.com/users/jiayliu/followers","following_url":"https://api.github.com/users/jiayliu/following{/other_user}","gists_url":"https://api.github.com/users/jiayliu/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayliu/subscriptions","organizations_url":"https://api.github.com/users/jiayliu/orgs","repos_url":"https://api.github.com/users/jiayliu/repos","events_url":"https://api.github.com/users/jiayliu/events{/privacy}","received_events_url":"https://api.github.com/users/jiayliu/received_events","type":"User","site_admin":false},"body":"@marwahvikas \r\n\r\nFixing a connection setup issue on staging (or head of Master).","created_at":"2015-01-14T20:23:48Z","updated_at":"2015-01-14T21:26:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d741c8cc56398edfdc44b2668dd5d6d56e584f7b","assignee":{"login":"juberti","id":1821693,"avatar_url":"https://avatars.githubusercontent.com/u/1821693?v=3","gravatar_id":"","url":"https://api.github.com/users/juberti","html_url":"https://github.com/juberti","followers_url":"https://api.github.com/users/juberti/followers","following_url":"https://api.github.com/users/juberti/following{/other_user}","gists_url":"https://api.github.com/users/juberti/gists{/gist_id}","starred_url":"https://api.github.com/users/juberti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juberti/subscriptions","organizations_url":"https://api.github.com/users/juberti/orgs","repos_url":"https://api.github.com/users/juberti/repos","events_url":"https://api.github.com/users/juberti/events{/privacy}","received_events_url":"https://api.github.com/users/juberti/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/377/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/53da6372e0d901315582573e757b44f6ee2b09cb","head":{"label":"jiayliu:wsreg","ref":"wsreg","sha":"53da6372e0d901315582573e757b44f6ee2b09cb","user":{"login":"jiayliu","id":7770539,"avatar_url":"https://avatars.githubusercontent.com/u/7770539?v=3","gravatar_id":"","url":"https://api.github.com/users/jiayliu","html_url":"https://github.com/jiayliu","followers_url":"https://api.github.com/users/jiayliu/followers","following_url":"https://api.github.com/users/jiayliu/following{/other_user}","gists_url":"https://api.github.com/users/jiayliu/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayliu/subscriptions","organizations_url":"https://api.github.com/users/jiayliu/orgs","repos_url":"https://api.github.com/users/jiayliu/repos","events_url":"https://api.github.com/users/jiayliu/events{/privacy}","received_events_url":"https://api.github.com/users/jiayliu/received_events","type":"User","site_admin":false},"repo":{"id":23972508,"name":"jiayl-webrtc","full_name":"jiayliu/jiayl-webrtc","owner":{"login":"jiayliu","id":7770539,"avatar_url":"https://avatars.githubusercontent.com/u/7770539?v=3","gravatar_id":"","url":"https://api.github.com/users/jiayliu","html_url":"https://github.com/jiayliu","followers_url":"https://api.github.com/users/jiayliu/followers","following_url":"https://api.github.com/users/jiayliu/following{/other_user}","gists_url":"https://api.github.com/users/jiayliu/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayliu/subscriptions","organizations_url":"https://api.github.com/users/jiayliu/orgs","repos_url":"https://api.github.com/users/jiayliu/repos","events_url":"https://api.github.com/users/jiayliu/events{/privacy}","received_events_url":"https://api.github.com/users/jiayliu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiayliu/jiayl-webrtc","description":"WebRTC demos and samples","fork":true,"url":"https://api.github.com/repos/jiayliu/jiayl-webrtc","forks_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/forks","keys_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/teams","hooks_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/hooks","issue_events_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/events","assignees_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/tags","blobs_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/languages","stargazers_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/stargazers","contributors_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/contributors","subscribers_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/subscribers","subscription_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/subscription","commits_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/issues/comments/{number}","contents_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/merges","archive_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/downloads","issues_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/jiayliu/jiayl-webrtc/releases{/id}","created_at":"2014-09-12T18:45:08Z","updated_at":"2014-12-17T00:23:59Z","pushed_at":"2015-01-14T21:26:15Z","git_url":"git://github.com/jiayliu/jiayl-webrtc.git","ssh_url":"git@github.com:jiayliu/jiayl-webrtc.git","clone_url":"https://github.com/jiayliu/jiayl-webrtc.git","svn_url":"https://github.com/jiayliu/jiayl-webrtc","homepage":null,"size":2921,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"7c82d69485e441309468bca8f2334d146552628e","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":12970971,"name":"webrtc","full_name":"GoogleChrome/webrtc","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/webrtc","description":"WebRTC demos and samples","fork":false,"url":"https://api.github.com/repos/GoogleChrome/webrtc","forks_url":"https://api.github.com/repos/GoogleChrome/webrtc/forks","keys_url":"https://api.github.com/repos/GoogleChrome/webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/webrtc/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/webrtc/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/webrtc/events","assignees_url":"https://api.github.com/repos/GoogleChrome/webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/webrtc/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/webrtc/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/webrtc/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/webrtc/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/webrtc/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/webrtc/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleChrome/webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/webrtc/merges","archive_url":"https://api.github.com/repos/GoogleChrome/webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/webrtc/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/webrtc/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/webrtc/releases{/id}","created_at":"2013-09-20T10:40:23Z","updated_at":"2015-01-14T21:07:40Z","pushed_at":"2015-01-14T21:15:00Z","git_url":"git://github.com/GoogleChrome/webrtc.git","ssh_url":"git@github.com:GoogleChrome/webrtc.git","clone_url":"https://github.com/GoogleChrome/webrtc.git","svn_url":"https://github.com/GoogleChrome/webrtc","homepage":"http://googlechrome.github.io/webrtc/","size":9770,"stargazers_count":626,"watchers_count":626,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":364,"mirror_url":null,"open_issues_count":90,"forks":364,"open_issues":90,"watchers":626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377"},"html":{"href":"https://github.com/GoogleChrome/webrtc/pull/377"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/issues/377"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/webrtc/statuses/53da6372e0d901315582573e757b44f6ee2b09cb"}}}}