{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments/39850728","id":39850728,"diff_hunk":"@@ -126,16 +126,10 @@ def katcp_rct(self):\n         if self._katcp_rct is None:\n             try:\n                 self.katcp_array_port = int(\n-                self.rct.req.array_list()[1][0].arguments[1])\n+                    self.rct.req.array_list()[1][0].arguments[1])\n             except IndexError:\n-                print 'Index error at line 126\\n\\n\\n'\n-                import IPython;IPython.embed()\n-                #self.start_correlator()\n-                # multicast_ip = self.corr_conf['test_confs']['source_mcast_ips']\n-                #self.rct.req.array_assign('array0',\n-                #        *multicast_ip.split(','))\n-                #self.katcp_array_port = int(\n-                #self.rct.req.array_list()[1][0].arguments[1])\n+                LOGGER.error('Failed to assign katcp array port number.')","path":"mkat_fpga_tests/__init__.py","position":15,"original_position":15,"commit_id":"c97f6e1ace3b0d06ad1cea9c1b9754b913a68488","original_commit_id":"c97f6e1ace3b0d06ad1cea9c1b9754b913a68488","user":{"login":"brickZA","id":630432,"avatar_url":"https://avatars.githubusercontent.com/u/630432?v=3","gravatar_id":"","url":"https://api.github.com/users/brickZA","html_url":"https://github.com/brickZA","followers_url":"https://api.github.com/users/brickZA/followers","following_url":"https://api.github.com/users/brickZA/following{/other_user}","gists_url":"https://api.github.com/users/brickZA/gists{/gist_id}","starred_url":"https://api.github.com/users/brickZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickZA/subscriptions","organizations_url":"https://api.github.com/users/brickZA/orgs","repos_url":"https://api.github.com/users/brickZA/repos","events_url":"https://api.github.com/users/brickZA/events{/privacy}","received_events_url":"https://api.github.com/users/brickZA/received_events","type":"User","site_admin":false},"body":"Don't think you need to log it also if you are raising an exception?","created_at":"2015-09-18T12:49:22Z","updated_at":"2015-09-18T12:49:22Z","html_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/67#discussion_r39850728","pull_request_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments/39850728"},"html":{"href":"https://github.com/ska-sa/mkat_fpga_tests/pull/67#discussion_r39850728"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67","id":45260144,"html_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/67","diff_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/67.diff","patch_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/67.patch","issue_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/67","number":67,"state":"open","locked":false,"title":"Delay tracking","user":{"login":"mmphego","id":7910856,"avatar_url":"https://avatars.githubusercontent.com/u/7910856?v=3","gravatar_id":"","url":"https://api.github.com/users/mmphego","html_url":"https://github.com/mmphego","followers_url":"https://api.github.com/users/mmphego/followers","following_url":"https://api.github.com/users/mmphego/following{/other_user}","gists_url":"https://api.github.com/users/mmphego/gists{/gist_id}","starred_url":"https://api.github.com/users/mmphego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmphego/subscriptions","organizations_url":"https://api.github.com/users/mmphego/orgs","repos_url":"https://api.github.com/users/mmphego/repos","events_url":"https://api.github.com/users/mmphego/events{/privacy}","received_events_url":"https://api.github.com/users/mmphego/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-17T07:39:12Z","updated_at":"2015-09-18T12:49:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6582fc6d59cdaf7ade4be2ef74227ca64509d78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/67/comments","statuses_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/c97f6e1ace3b0d06ad1cea9c1b9754b913a68488","head":{"label":"ska-sa:delay-tracking","ref":"delay-tracking","sha":"c97f6e1ace3b0d06ad1cea9c1b9754b913a68488","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":38315839,"name":"mkat_fpga_tests","full_name":"ska-sa/mkat_fpga_tests","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/mkat_fpga_tests","description":"Tests for the mkat_fpga FPGA bitstreams","fork":false,"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests","forks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/forks","keys_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/teams","hooks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/events","assignees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/tags","blobs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/languages","stargazers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscription","commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/merges","archive_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/downloads","issues_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/releases{/id}","created_at":"2015-06-30T15:02:05Z","updated_at":"2015-07-03T15:52:16Z","pushed_at":"2015-09-18T09:05:09Z","git_url":"git://github.com/ska-sa/mkat_fpga_tests.git","ssh_url":"git@github.com:ska-sa/mkat_fpga_tests.git","clone_url":"https://github.com/ska-sa/mkat_fpga_tests.git","svn_url":"https://github.com/ska-sa/mkat_fpga_tests","homepage":null,"size":22272,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ska-sa:devel","ref":"devel","sha":"15f69ec7442a5dddb9bf9e843cad6339dd9f6ec0","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":38315839,"name":"mkat_fpga_tests","full_name":"ska-sa/mkat_fpga_tests","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/mkat_fpga_tests","description":"Tests for the mkat_fpga FPGA bitstreams","fork":false,"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests","forks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/forks","keys_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/teams","hooks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/events","assignees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/tags","blobs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/languages","stargazers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscription","commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/merges","archive_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/downloads","issues_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/releases{/id}","created_at":"2015-06-30T15:02:05Z","updated_at":"2015-07-03T15:52:16Z","pushed_at":"2015-09-18T09:05:09Z","git_url":"git://github.com/ska-sa/mkat_fpga_tests.git","ssh_url":"git@github.com:ska-sa/mkat_fpga_tests.git","clone_url":"https://github.com/ska-sa/mkat_fpga_tests.git","svn_url":"https://github.com/ska-sa/mkat_fpga_tests","homepage":null,"size":22272,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67"},"html":{"href":"https://github.com/ska-sa/mkat_fpga_tests/pull/67"},"issue":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/67"},"comments":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/c97f6e1ace3b0d06ad1cea9c1b9754b913a68488"}}}}