{"action":"created","comment":{"url":"https://api.github.com/repos/hapijs/catbox-memory/pulls/comments/28320406","id":28320406,"diff_hunk":"@@ -379,6 +381,54 @@ describe('Memory', function () {\n         done();\n     });\n \n+    describe('stopping after set', function () {","path":"test/index.js","position":13,"original_position":13,"commit_id":"0736cccd84f679ee6cb65923480eb7fffa63fc31","original_commit_id":"0736cccd84f679ee6cb65923480eb7fffa63fc31","user":{"login":"jagoda","id":655686,"avatar_url":"https://avatars.githubusercontent.com/u/655686?v=3","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"body":"Sure, `parallel : false` makes total sense. I want to make sure that I understand your 'single test' point. By that do you mean a single `it` clause rather than a `describe` block with `before` and `after`? My concern with this approach is that in the event of a test failure the rest of the test cases could end up running without the `setTimeout` and `clearTimeout` changes being cleaned up. Given the current mock implementations, I don't expect there to be any noticable problems in this case, but allowing changes to the global state to possibly hang around seemed like a bad idea to me. Happy to do whatever you think is best though.","created_at":"2015-04-14T12:03:21Z","updated_at":"2015-04-14T12:03:21Z","html_url":"https://github.com/hapijs/catbox-memory/pull/27#discussion_r28320406","pull_request_url":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/hapijs/catbox-memory/pulls/comments/28320406"},"html":{"href":"https://github.com/hapijs/catbox-memory/pull/27#discussion_r28320406"},"pull_request":{"href":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27","id":32376268,"html_url":"https://github.com/hapijs/catbox-memory/pull/27","diff_url":"https://github.com/hapijs/catbox-memory/pull/27.diff","patch_url":"https://github.com/hapijs/catbox-memory/pull/27.patch","issue_url":"https://api.github.com/repos/hapijs/catbox-memory/issues/27","number":27,"state":"open","locked":false,"title":"Clean up timers when the cache is stopped.","user":{"login":"jagoda","id":655686,"avatar_url":"https://avatars.githubusercontent.com/u/655686?v=3","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"body":"Pending timers cause the Node process to remain running even after the rest of the program has completed. This change causes all pending timers to be cleared when the cache service is stopped.","created_at":"2015-03-31T23:27:22Z","updated_at":"2015-04-14T12:03:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aff80ea5d82d76e881c9c424cec4b83e7ccf261e","assignee":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hapijs/catbox-memory/milestones/7","html_url":"https://github.com/hapijs/catbox-memory/milestones/1.1.2","labels_url":"https://api.github.com/repos/hapijs/catbox-memory/milestones/7/labels","id":842606,"number":7,"title":"1.1.2","description":"","creator":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2014-10-27T20:17:03Z","updated_at":"2015-04-13T21:50:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27/commits","review_comments_url":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27/comments","review_comment_url":"https://api.github.com/repos/hapijs/catbox-memory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hapijs/catbox-memory/issues/27/comments","statuses_url":"https://api.github.com/repos/hapijs/catbox-memory/statuses/0736cccd84f679ee6cb65923480eb7fffa63fc31","head":{"label":"jagoda:fix-clean-timers","ref":"fix-clean-timers","sha":"0736cccd84f679ee6cb65923480eb7fffa63fc31","user":{"login":"jagoda","id":655686,"avatar_url":"https://avatars.githubusercontent.com/u/655686?v=3","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"repo":{"id":33214327,"name":"catbox-memory","full_name":"jagoda/catbox-memory","owner":{"login":"jagoda","id":655686,"avatar_url":"https://avatars.githubusercontent.com/u/655686?v=3","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagoda/catbox-memory","description":"Memory adapter for catbox","fork":true,"url":"https://api.github.com/repos/jagoda/catbox-memory","forks_url":"https://api.github.com/repos/jagoda/catbox-memory/forks","keys_url":"https://api.github.com/repos/jagoda/catbox-memory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagoda/catbox-memory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagoda/catbox-memory/teams","hooks_url":"https://api.github.com/repos/jagoda/catbox-memory/hooks","issue_events_url":"https://api.github.com/repos/jagoda/catbox-memory/issues/events{/number}","events_url":"https://api.github.com/repos/jagoda/catbox-memory/events","assignees_url":"https://api.github.com/repos/jagoda/catbox-memory/assignees{/user}","branches_url":"https://api.github.com/repos/jagoda/catbox-memory/branches{/branch}","tags_url":"https://api.github.com/repos/jagoda/catbox-memory/tags","blobs_url":"https://api.github.com/repos/jagoda/catbox-memory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagoda/catbox-memory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagoda/catbox-memory/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagoda/catbox-memory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagoda/catbox-memory/statuses/{sha}","languages_url":"https://api.github.com/repos/jagoda/catbox-memory/languages","stargazers_url":"https://api.github.com/repos/jagoda/catbox-memory/stargazers","contributors_url":"https://api.github.com/repos/jagoda/catbox-memory/contributors","subscribers_url":"https://api.github.com/repos/jagoda/catbox-memory/subscribers","subscription_url":"https://api.github.com/repos/jagoda/catbox-memory/subscription","commits_url":"https://api.github.com/repos/jagoda/catbox-memory/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagoda/catbox-memory/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagoda/catbox-memory/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagoda/catbox-memory/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagoda/catbox-memory/contents/{+path}","compare_url":"https://api.github.com/repos/jagoda/catbox-memory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagoda/catbox-memory/merges","archive_url":"https://api.github.com/repos/jagoda/catbox-memory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagoda/catbox-memory/downloads","issues_url":"https://api.github.com/repos/jagoda/catbox-memory/issues{/number}","pulls_url":"https://api.github.com/repos/jagoda/catbox-memory/pulls{/number}","milestones_url":"https://api.github.com/repos/jagoda/catbox-memory/milestones{/number}","notifications_url":"https://api.github.com/repos/jagoda/catbox-memory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagoda/catbox-memory/labels{/name}","releases_url":"https://api.github.com/repos/jagoda/catbox-memory/releases{/id}","created_at":"2015-03-31T22:46:16Z","updated_at":"2015-03-31T22:46:17Z","pushed_at":"2015-04-09T01:19:24Z","git_url":"git://github.com/jagoda/catbox-memory.git","ssh_url":"git@github.com:jagoda/catbox-memory.git","clone_url":"https://github.com/jagoda/catbox-memory.git","svn_url":"https://github.com/jagoda/catbox-memory","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hapijs:master","ref":"master","sha":"669616103d102c90e9fe82c89779e9cba5818928","user":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"repo":{"id":17343848,"name":"catbox-memory","full_name":"hapijs/catbox-memory","owner":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapijs/catbox-memory","description":"Memory adapter for catbox","fork":false,"url":"https://api.github.com/repos/hapijs/catbox-memory","forks_url":"https://api.github.com/repos/hapijs/catbox-memory/forks","keys_url":"https://api.github.com/repos/hapijs/catbox-memory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapijs/catbox-memory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapijs/catbox-memory/teams","hooks_url":"https://api.github.com/repos/hapijs/catbox-memory/hooks","issue_events_url":"https://api.github.com/repos/hapijs/catbox-memory/issues/events{/number}","events_url":"https://api.github.com/repos/hapijs/catbox-memory/events","assignees_url":"https://api.github.com/repos/hapijs/catbox-memory/assignees{/user}","branches_url":"https://api.github.com/repos/hapijs/catbox-memory/branches{/branch}","tags_url":"https://api.github.com/repos/hapijs/catbox-memory/tags","blobs_url":"https://api.github.com/repos/hapijs/catbox-memory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapijs/catbox-memory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapijs/catbox-memory/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapijs/catbox-memory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapijs/catbox-memory/statuses/{sha}","languages_url":"https://api.github.com/repos/hapijs/catbox-memory/languages","stargazers_url":"https://api.github.com/repos/hapijs/catbox-memory/stargazers","contributors_url":"https://api.github.com/repos/hapijs/catbox-memory/contributors","subscribers_url":"https://api.github.com/repos/hapijs/catbox-memory/subscribers","subscription_url":"https://api.github.com/repos/hapijs/catbox-memory/subscription","commits_url":"https://api.github.com/repos/hapijs/catbox-memory/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapijs/catbox-memory/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapijs/catbox-memory/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapijs/catbox-memory/issues/comments{/number}","contents_url":"https://api.github.com/repos/hapijs/catbox-memory/contents/{+path}","compare_url":"https://api.github.com/repos/hapijs/catbox-memory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapijs/catbox-memory/merges","archive_url":"https://api.github.com/repos/hapijs/catbox-memory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapijs/catbox-memory/downloads","issues_url":"https://api.github.com/repos/hapijs/catbox-memory/issues{/number}","pulls_url":"https://api.github.com/repos/hapijs/catbox-memory/pulls{/number}","milestones_url":"https://api.github.com/repos/hapijs/catbox-memory/milestones{/number}","notifications_url":"https://api.github.com/repos/hapijs/catbox-memory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapijs/catbox-memory/labels{/name}","releases_url":"https://api.github.com/repos/hapijs/catbox-memory/releases{/id}","created_at":"2014-03-02T18:31:34Z","updated_at":"2015-03-02T16:14:26Z","pushed_at":"2015-04-09T01:19:25Z","git_url":"git://github.com/hapijs/catbox-memory.git","ssh_url":"git@github.com:hapijs/catbox-memory.git","clone_url":"https://github.com/hapijs/catbox-memory.git","svn_url":"https://github.com/hapijs/catbox-memory","homepage":null,"size":361,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27"},"html":{"href":"https://github.com/hapijs/catbox-memory/pull/27"},"issue":{"href":"https://api.github.com/repos/hapijs/catbox-memory/issues/27"},"comments":{"href":"https://api.github.com/repos/hapijs/catbox-memory/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/hapijs/catbox-memory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hapijs/catbox-memory/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/hapijs/catbox-memory/statuses/0736cccd84f679ee6cb65923480eb7fffa63fc31"}}}}