{"action":"created","issue":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/748","labels_url":"https://api.github.com/repos/ratpack/ratpack/issues/748/labels{/name}","comments_url":"https://api.github.com/repos/ratpack/ratpack/issues/748/comments","events_url":"https://api.github.com/repos/ratpack/ratpack/issues/748/events","html_url":"https://github.com/ratpack/ratpack/pull/748","id":99955839,"number":748,"title":"Support Redis as a SessionStorage Option","user":{"login":"beckje01","id":232059,"avatar_url":"https://avatars.githubusercontent.com/u/232059?v=3","gravatar_id":"","url":"https://api.github.com/users/beckje01","html_url":"https://github.com/beckje01","followers_url":"https://api.github.com/users/beckje01/followers","following_url":"https://api.github.com/users/beckje01/following{/other_user}","gists_url":"https://api.github.com/users/beckje01/gists{/gist_id}","starred_url":"https://api.github.com/users/beckje01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckje01/subscriptions","organizations_url":"https://api.github.com/users/beckje01/orgs","repos_url":"https://api.github.com/users/beckje01/repos","events_url":"https://api.github.com/users/beckje01/events{/privacy}","received_events_url":"https://api.github.com/users/beckje01/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ratpack/ratpack/labels/in%20progress","name":"in progress","color":"eac04b"}],"state":"open","locked":false,"assignee":{"login":"beckje01","id":232059,"avatar_url":"https://avatars.githubusercontent.com/u/232059?v=3","gravatar_id":"","url":"https://api.github.com/users/beckje01","html_url":"https://github.com/beckje01","followers_url":"https://api.github.com/users/beckje01/followers","following_url":"https://api.github.com/users/beckje01/following{/other_user}","gists_url":"https://api.github.com/users/beckje01/gists{/gist_id}","starred_url":"https://api.github.com/users/beckje01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckje01/subscriptions","organizations_url":"https://api.github.com/users/beckje01/orgs","repos_url":"https://api.github.com/users/beckje01/repos","events_url":"https://api.github.com/users/beckje01/events{/privacy}","received_events_url":"https://api.github.com/users/beckje01/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-08-10T02:23:58Z","updated_at":"2015-08-12T01:06:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ratpack/ratpack/pulls/748","html_url":"https://github.com/ratpack/ratpack/pull/748","diff_url":"https://github.com/ratpack/ratpack/pull/748.diff","patch_url":"https://github.com/ratpack/ratpack/pull/748.patch"},"body":"Starting this as a PR early to see if CI is ok.\r\n\r\nPending: \r\n- [x] Java Doc\r\n- [x] Changelog Update\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/ratpack/ratpack/748)\r\n<!-- Reviewable:end -->"},"comment":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/comments/130127665","html_url":"https://github.com/ratpack/ratpack/pull/748#issuecomment-130127665","issue_url":"https://api.github.com/repos/ratpack/ratpack/issues/748","id":130127665,"user":{"login":"beckje01","id":232059,"avatar_url":"https://avatars.githubusercontent.com/u/232059?v=3","gravatar_id":"","url":"https://api.github.com/users/beckje01","html_url":"https://github.com/beckje01","followers_url":"https://api.github.com/users/beckje01/followers","following_url":"https://api.github.com/users/beckje01/following{/other_user}","gists_url":"https://api.github.com/users/beckje01/gists{/gist_id}","starred_url":"https://api.github.com/users/beckje01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckje01/subscriptions","organizations_url":"https://api.github.com/users/beckje01/orgs","repos_url":"https://api.github.com/users/beckje01/repos","events_url":"https://api.github.com/users/beckje01/events{/privacy}","received_events_url":"https://api.github.com/users/beckje01/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T01:06:12Z","updated_at":"2015-08-12T01:06:12Z","body":"\n\n\n\nReviewed 2 of 6 files at r1, 6 of 7 files at r2.\nReview status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks pending.\n\n---\n\n<sup>**[ratpack-session-redis/src/main/java/ratpack/session/store/internal/RedisSessionStore.java, line 55 \\[r2\\]](https://reviewable.io:443/reviews/ratpack/ratpack/748#-JwUR5-E8-Z398mX1CfQ)** ([raw file](https://github.com/ratpack/ratpack/blob/1bd3ddb5f8b19f96e08acc60d9e180ff302d174d/ratpack-session-redis/src/main/java/ratpack/session/store/internal/RedisSessionStore.java#L55)):</sup>\nDoes this seem correct or is there a special executor I should be passing in to keep on the correct thread?\n\n---\n\n<sup>**[ratpack-session-redis/src/main/java/ratpack/session/store/RedisSessionModule.java, line 24 \\[r1\\]](https://reviewable.io:443/reviews/ratpack/ratpack/748#-JwKPzXKQKE4RUgdCwSS-r1-24)** ([raw file](https://github.com/ratpack/ratpack/blob/d3a4bc9910985931d0bf23f7c1526242914d05a4/ratpack-session-redis/src/main/java/ratpack/session/store/RedisSessionModule.java#L24)):</sup>\nDone.\n\n---\n\n<sup>**[ratpack-session-redis/src/main/java/ratpack/session/store/RedisSessionStore.java, line 17 \\[r1\\]](https://reviewable.io:443/reviews/ratpack/ratpack/748#-JwKRJdqd-i53nI4op1E)** ([raw file](https://github.com/ratpack/ratpack/blob/d3a4bc9910985931d0bf23f7c1526242914d05a4/ratpack-session-redis/src/main/java/ratpack/session/store/RedisSessionStore.java#L17)):</sup>\nDone.\n\n---\n\n<sup>**[ratpack-session-redis/src/main/java/ratpack/session/store/RedisSessionStore.java, line 54 \\[r1\\]](https://reviewable.io:443/reviews/ratpack/ratpack/748#-JwKRb_P1Bc4O18z8fhX)** ([raw file](https://github.com/ratpack/ratpack/blob/d3a4bc9910985931d0bf23f7c1526242914d05a4/ratpack-session-redis/src/main/java/ratpack/session/store/RedisSessionStore.java#L54)):</sup>\nMoved.\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/ratpack/ratpack/748)\n<!-- Sent from Reviewable.io -->\n"}}