{"action":"closed","number":45,"pull_request":{"url":"https://api.github.com/repos/TooTallNate/node-lame/pulls/45","id":29425135,"html_url":"https://github.com/TooTallNate/node-lame/pull/45","diff_url":"https://github.com/TooTallNate/node-lame/pull/45.diff","patch_url":"https://github.com/TooTallNate/node-lame/pull/45.patch","issue_url":"https://api.github.com/repos/TooTallNate/node-lame/issues/45","number":45,"state":"closed","locked":false,"title":"node 0.12 support","user":{"login":"LinusU","id":189580,"avatar_url":"https://avatars.githubusercontent.com/u/189580?v=3","gravatar_id":"","url":"https://api.github.com/users/LinusU","html_url":"https://github.com/LinusU","followers_url":"https://api.github.com/users/LinusU/followers","following_url":"https://api.github.com/users/LinusU/following{/other_user}","gists_url":"https://api.github.com/users/LinusU/gists{/gist_id}","starred_url":"https://api.github.com/users/LinusU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinusU/subscriptions","organizations_url":"https://api.github.com/users/LinusU/orgs","repos_url":"https://api.github.com/users/LinusU/repos","events_url":"https://api.github.com/users/LinusU/events{/privacy}","received_events_url":"https://api.github.com/users/LinusU/received_events","type":"User","site_admin":false},"body":"This fixes compilation with nan `> 1.5.0` and works with node `0.12.0`.\r\n\r\n@TooTallNate After arriving at the same conclusions as you did I found rvagg/nan#279. The only difference is that I used `uint32_t` instead of `int32_t`. I believe that it's correct to use `uint32_t` since `size_t` is unsigned (and `ssize_t` is signed).","created_at":"2015-02-17T08:32:43Z","updated_at":"2015-03-06T17:34:09Z","closed_at":"2015-03-06T17:34:09Z","merged_at":"2015-03-06T17:34:09Z","merge_commit_sha":"ca8a257828bef74c3a583df7e461d5dba25a98a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TooTallNate/node-lame/pulls/45/commits","review_comments_url":"https://api.github.com/repos/TooTallNate/node-lame/pulls/45/comments","review_comment_url":"https://api.github.com/repos/TooTallNate/node-lame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TooTallNate/node-lame/issues/45/comments","statuses_url":"https://api.github.com/repos/TooTallNate/node-lame/statuses/4bea07f44f60a4e5191dfbe7218a93dc52f989f0","head":{"label":"LinusU:patch-1","ref":"patch-1","sha":"4bea07f44f60a4e5191dfbe7218a93dc52f989f0","user":{"login":"LinusU","id":189580,"avatar_url":"https://avatars.githubusercontent.com/u/189580?v=3","gravatar_id":"","url":"https://api.github.com/users/LinusU","html_url":"https://github.com/LinusU","followers_url":"https://api.github.com/users/LinusU/followers","following_url":"https://api.github.com/users/LinusU/following{/other_user}","gists_url":"https://api.github.com/users/LinusU/gists{/gist_id}","starred_url":"https://api.github.com/users/LinusU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinusU/subscriptions","organizations_url":"https://api.github.com/users/LinusU/orgs","repos_url":"https://api.github.com/users/LinusU/repos","events_url":"https://api.github.com/users/LinusU/events{/privacy}","received_events_url":"https://api.github.com/users/LinusU/received_events","type":"User","site_admin":false},"repo":{"id":30908546,"name":"node-lame","full_name":"LinusU/node-lame","owner":{"login":"LinusU","id":189580,"avatar_url":"https://avatars.githubusercontent.com/u/189580?v=3","gravatar_id":"","url":"https://api.github.com/users/LinusU","html_url":"https://github.com/LinusU","followers_url":"https://api.github.com/users/LinusU/followers","following_url":"https://api.github.com/users/LinusU/following{/other_user}","gists_url":"https://api.github.com/users/LinusU/gists{/gist_id}","starred_url":"https://api.github.com/users/LinusU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinusU/subscriptions","organizations_url":"https://api.github.com/users/LinusU/orgs","repos_url":"https://api.github.com/users/LinusU/repos","events_url":"https://api.github.com/users/LinusU/events{/privacy}","received_events_url":"https://api.github.com/users/LinusU/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LinusU/node-lame","description":"NodeJS native bindings to libmp3lame & libmpg123","fork":true,"url":"https://api.github.com/repos/LinusU/node-lame","forks_url":"https://api.github.com/repos/LinusU/node-lame/forks","keys_url":"https://api.github.com/repos/LinusU/node-lame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinusU/node-lame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinusU/node-lame/teams","hooks_url":"https://api.github.com/repos/LinusU/node-lame/hooks","issue_events_url":"https://api.github.com/repos/LinusU/node-lame/issues/events{/number}","events_url":"https://api.github.com/repos/LinusU/node-lame/events","assignees_url":"https://api.github.com/repos/LinusU/node-lame/assignees{/user}","branches_url":"https://api.github.com/repos/LinusU/node-lame/branches{/branch}","tags_url":"https://api.github.com/repos/LinusU/node-lame/tags","blobs_url":"https://api.github.com/repos/LinusU/node-lame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinusU/node-lame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinusU/node-lame/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinusU/node-lame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinusU/node-lame/statuses/{sha}","languages_url":"https://api.github.com/repos/LinusU/node-lame/languages","stargazers_url":"https://api.github.com/repos/LinusU/node-lame/stargazers","contributors_url":"https://api.github.com/repos/LinusU/node-lame/contributors","subscribers_url":"https://api.github.com/repos/LinusU/node-lame/subscribers","subscription_url":"https://api.github.com/repos/LinusU/node-lame/subscription","commits_url":"https://api.github.com/repos/LinusU/node-lame/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinusU/node-lame/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinusU/node-lame/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinusU/node-lame/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinusU/node-lame/contents/{+path}","compare_url":"https://api.github.com/repos/LinusU/node-lame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinusU/node-lame/merges","archive_url":"https://api.github.com/repos/LinusU/node-lame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinusU/node-lame/downloads","issues_url":"https://api.github.com/repos/LinusU/node-lame/issues{/number}","pulls_url":"https://api.github.com/repos/LinusU/node-lame/pulls{/number}","milestones_url":"https://api.github.com/repos/LinusU/node-lame/milestones{/number}","notifications_url":"https://api.github.com/repos/LinusU/node-lame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinusU/node-lame/labels{/name}","releases_url":"https://api.github.com/repos/LinusU/node-lame/releases{/id}","created_at":"2015-02-17T08:29:05Z","updated_at":"2015-02-17T08:29:06Z","pushed_at":"2015-02-17T08:29:35Z","git_url":"git://github.com/LinusU/node-lame.git","ssh_url":"git@github.com:LinusU/node-lame.git","clone_url":"https://github.com/LinusU/node-lame.git","svn_url":"https://github.com/LinusU/node-lame","homepage":"","size":3291,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TooTallNate:master","ref":"master","sha":"6d0c0276502fc5aa9278470bea4588d7c81c74b0","user":{"login":"TooTallNate","id":71256,"avatar_url":"https://avatars.githubusercontent.com/u/71256?v=3","gravatar_id":"","url":"https://api.github.com/users/TooTallNate","html_url":"https://github.com/TooTallNate","followers_url":"https://api.github.com/users/TooTallNate/followers","following_url":"https://api.github.com/users/TooTallNate/following{/other_user}","gists_url":"https://api.github.com/users/TooTallNate/gists{/gist_id}","starred_url":"https://api.github.com/users/TooTallNate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TooTallNate/subscriptions","organizations_url":"https://api.github.com/users/TooTallNate/orgs","repos_url":"https://api.github.com/users/TooTallNate/repos","events_url":"https://api.github.com/users/TooTallNate/events{/privacy}","received_events_url":"https://api.github.com/users/TooTallNate/received_events","type":"User","site_admin":false},"repo":{"id":2738565,"name":"node-lame","full_name":"TooTallNate/node-lame","owner":{"login":"TooTallNate","id":71256,"avatar_url":"https://avatars.githubusercontent.com/u/71256?v=3","gravatar_id":"","url":"https://api.github.com/users/TooTallNate","html_url":"https://github.com/TooTallNate","followers_url":"https://api.github.com/users/TooTallNate/followers","following_url":"https://api.github.com/users/TooTallNate/following{/other_user}","gists_url":"https://api.github.com/users/TooTallNate/gists{/gist_id}","starred_url":"https://api.github.com/users/TooTallNate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TooTallNate/subscriptions","organizations_url":"https://api.github.com/users/TooTallNate/orgs","repos_url":"https://api.github.com/users/TooTallNate/repos","events_url":"https://api.github.com/users/TooTallNate/events{/privacy}","received_events_url":"https://api.github.com/users/TooTallNate/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TooTallNate/node-lame","description":"NodeJS native bindings to libmp3lame & libmpg123","fork":false,"url":"https://api.github.com/repos/TooTallNate/node-lame","forks_url":"https://api.github.com/repos/TooTallNate/node-lame/forks","keys_url":"https://api.github.com/repos/TooTallNate/node-lame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TooTallNate/node-lame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TooTallNate/node-lame/teams","hooks_url":"https://api.github.com/repos/TooTallNate/node-lame/hooks","issue_events_url":"https://api.github.com/repos/TooTallNate/node-lame/issues/events{/number}","events_url":"https://api.github.com/repos/TooTallNate/node-lame/events","assignees_url":"https://api.github.com/repos/TooTallNate/node-lame/assignees{/user}","branches_url":"https://api.github.com/repos/TooTallNate/node-lame/branches{/branch}","tags_url":"https://api.github.com/repos/TooTallNate/node-lame/tags","blobs_url":"https://api.github.com/repos/TooTallNate/node-lame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TooTallNate/node-lame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TooTallNate/node-lame/git/refs{/sha}","trees_url":"https://api.github.com/repos/TooTallNate/node-lame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TooTallNate/node-lame/statuses/{sha}","languages_url":"https://api.github.com/repos/TooTallNate/node-lame/languages","stargazers_url":"https://api.github.com/repos/TooTallNate/node-lame/stargazers","contributors_url":"https://api.github.com/repos/TooTallNate/node-lame/contributors","subscribers_url":"https://api.github.com/repos/TooTallNate/node-lame/subscribers","subscription_url":"https://api.github.com/repos/TooTallNate/node-lame/subscription","commits_url":"https://api.github.com/repos/TooTallNate/node-lame/commits{/sha}","git_commits_url":"https://api.github.com/repos/TooTallNate/node-lame/git/commits{/sha}","comments_url":"https://api.github.com/repos/TooTallNate/node-lame/comments{/number}","issue_comment_url":"https://api.github.com/repos/TooTallNate/node-lame/issues/comments{/number}","contents_url":"https://api.github.com/repos/TooTallNate/node-lame/contents/{+path}","compare_url":"https://api.github.com/repos/TooTallNate/node-lame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TooTallNate/node-lame/merges","archive_url":"https://api.github.com/repos/TooTallNate/node-lame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TooTallNate/node-lame/downloads","issues_url":"https://api.github.com/repos/TooTallNate/node-lame/issues{/number}","pulls_url":"https://api.github.com/repos/TooTallNate/node-lame/pulls{/number}","milestones_url":"https://api.github.com/repos/TooTallNate/node-lame/milestones{/number}","notifications_url":"https://api.github.com/repos/TooTallNate/node-lame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TooTallNate/node-lame/labels{/name}","releases_url":"https://api.github.com/repos/TooTallNate/node-lame/releases{/id}","created_at":"2011-11-09T01:08:44Z","updated_at":"2015-03-06T09:00:17Z","pushed_at":"2015-03-06T17:34:09Z","git_url":"git://github.com/TooTallNate/node-lame.git","ssh_url":"git@github.com:TooTallNate/node-lame.git","clone_url":"https://github.com/TooTallNate/node-lame.git","svn_url":"https://github.com/TooTallNate/node-lame","homepage":"","size":3562,"stargazers_count":273,"watchers_count":273,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":20,"forks":51,"open_issues":20,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TooTallNate/node-lame/pulls/45"},"html":{"href":"https://github.com/TooTallNate/node-lame/pull/45"},"issue":{"href":"https://api.github.com/repos/TooTallNate/node-lame/issues/45"},"comments":{"href":"https://api.github.com/repos/TooTallNate/node-lame/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/TooTallNate/node-lame/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/TooTallNate/node-lame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TooTallNate/node-lame/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/TooTallNate/node-lame/statuses/4bea07f44f60a4e5191dfbe7218a93dc52f989f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"TooTallNate","id":71256,"avatar_url":"https://avatars.githubusercontent.com/u/71256?v=3","gravatar_id":"","url":"https://api.github.com/users/TooTallNate","html_url":"https://github.com/TooTallNate","followers_url":"https://api.github.com/users/TooTallNate/followers","following_url":"https://api.github.com/users/TooTallNate/following{/other_user}","gists_url":"https://api.github.com/users/TooTallNate/gists{/gist_id}","starred_url":"https://api.github.com/users/TooTallNate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TooTallNate/subscriptions","organizations_url":"https://api.github.com/users/TooTallNate/orgs","repos_url":"https://api.github.com/users/TooTallNate/repos","events_url":"https://api.github.com/users/TooTallNate/events{/privacy}","received_events_url":"https://api.github.com/users/TooTallNate/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":2}}