{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3060","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3060/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3060/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3060/events","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/3060","id":117478742,"number":3060,"title":"more clearly indicate Foundation imports to avoid recursion","user":{"login":"incanus","id":17722,"avatar_url":"https://avatars.githubusercontent.com/u/17722?v=3","gravatar_id":"","url":"https://api.github.com/users/incanus","html_url":"https://github.com/incanus","followers_url":"https://api.github.com/users/incanus/followers","following_url":"https://api.github.com/users/incanus/following{/other_user}","gists_url":"https://api.github.com/users/incanus/gists{/gist_id}","starred_url":"https://api.github.com/users/incanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incanus/subscriptions","organizations_url":"https://api.github.com/users/incanus/orgs","repos_url":"https://api.github.com/users/incanus/repos","events_url":"https://api.github.com/users/incanus/events{/privacy}","received_events_url":"https://api.github.com/users/incanus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/iOS","name":"iOS","color":"207de5"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/refactor","name":"refactor","color":"4c4c4c"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/13","html_url":"https://github.com/mapbox/mapbox-gl-native/milestones/ios-v3.0.0","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/13/labels","id":1278059,"number":13,"title":"ios-v3.0.0","description":"See CHANGELOG.md.","creator":{"login":"1ec5","id":1231218,"avatar_url":"https://avatars.githubusercontent.com/u/1231218?v=3","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":50,"state":"open","created_at":"2015-08-28T18:13:23Z","updated_at":"2015-11-17T23:53:11Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-11-17T23:53:11Z","updated_at":"2015-11-18T00:30:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/3060","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/3060","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/3060.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/3060.patch"},"body":"Due to https://github.com/mapbox/mapbox-gl-native/commit/0a8d9a3b6d686c1fce9dc48014d1b13fdd58cdb3, we recursively import `Mapbox.h` and we shouldn't do this. Instead, we should bring in any Apple Foundation imports directly, our own superclasses / category-extended classes if necessary, and forward-declare the rest. \r\n\r\n/cc @1ec5 "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/157554546","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/3060#issuecomment-157554546","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3060","id":157554546,"user":{"login":"incanus","id":17722,"avatar_url":"https://avatars.githubusercontent.com/u/17722?v=3","gravatar_id":"","url":"https://api.github.com/users/incanus","html_url":"https://github.com/incanus","followers_url":"https://api.github.com/users/incanus/followers","following_url":"https://api.github.com/users/incanus/following{/other_user}","gists_url":"https://api.github.com/users/incanus/gists{/gist_id}","starred_url":"https://api.github.com/users/incanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incanus/subscriptions","organizations_url":"https://api.github.com/users/incanus/orgs","repos_url":"https://api.github.com/users/incanus/repos","events_url":"https://api.github.com/users/incanus/events{/privacy}","received_events_url":"https://api.github.com/users/incanus/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T00:30:28Z","updated_at":"2015-11-18T00:30:28Z","body":"> I’d still omit the Foundation import\r\n\r\nIt still feels \"most correct\" to bring in Foundation because of objects inheriting from `NSObject` or using `NSString` or what-have-you, but I could let it pass. "}}