{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/40092305","id":40092305,"diff_hunk":"@@ -1958,12 +2130,25 @@ func (s *DockerSuite) TestRunExposePort(c *check.C) {\n }\n \n func (s *DockerSuite) TestRunUnknownCommand(c *check.C) {\n-\ttestRequires(c, NativeExecDriver, DaemonIsLinux)\n+\tif daemonPlatform != \"windows\" {\n+\t\ttestRequires(c, NativeExecDriver)\n+\t}\n \tout, _, _ := dockerCmdWithStdoutStderr(c, \"create\", \"busybox\", \"/bin/nada\")\n \n \tcID := strings.TrimSpace(out)\n \t_, _, err := dockerCmdWithError(\"start\", cID)\n-\tc.Assert(err, check.NotNil)\n+\n+\t// Windows and Linux are different here by architectural design. Linux will\n+\t// fail to start the container, so an error is expected. Windows will\n+\t// successfully start the container, and once started attempt to execute\n+\t// the command which will fail.\n+\tif daemonPlatform == \"windows\" {\n+\t\t// Wait for it to exit.\n+\t\twaitExited(cID, 30)\n+\t\tc.Assert(err, check.IsNil)","path":"integration-cli/docker_cli_run_test.go","position":1097,"original_position":1107,"commit_id":"c9da4724090340d181deab02e59f88a4e63fc6d1","original_commit_id":"e6fec35c18eb2e4e61d8a1bc090dd87f28089efc","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"I'm not sure where the design discussions happened around this or if it is a limitation in Windows, but this really seems like a problem and a huge inconsistency in the API.","created_at":"2015-09-22T14:26:40Z","updated_at":"2015-09-22T14:26:40Z","html_url":"https://github.com/docker/docker/pull/16312#discussion_r40092305","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/16312","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/40092305"},"html":{"href":"https://github.com/docker/docker/pull/16312#discussion_r40092305"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/16312"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16312","id":45087402,"html_url":"https://github.com/docker/docker/pull/16312","diff_url":"https://github.com/docker/docker/pull/16312.diff","patch_url":"https://github.com/docker/docker/pull/16312.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/16312","number":16312,"state":"open","locked":false,"title":"Windows: First part of CI tests (docker run)","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\n@jfrazelle @cpuguy83.  This is the first of several updates to integration-cli to start enabling test-integration-cli to run against the Windows daemon. It addresses many of the tests in docker_cli_run_test.go (ie `TestRun*`). These can't yet be run under CI (still more infrastructure required), but can locally. I use an interim Windows `busybox` image which I build from http://github.com/jhowardmsft/busybox. This image will change though, as it's 32-bit and hence can't run on nano server. \r\n\r\n","created_at":"2015-09-15T18:51:05Z","updated_at":"2015-09-22T14:26:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8d0248455534ee9744a7b2994abbdce49b258ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/16312/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/16312/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/16312/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/c9da4724090340d181deab02e59f88a4e63fc6d1","head":{"label":"Microsoft:10662-startwindowscli","ref":"10662-startwindowscli","sha":"c9da4724090340d181deab02e59f88a4e63fc6d1","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":30096470,"name":"docker","full_name":"Microsoft/docker","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/Microsoft/docker","forks_url":"https://api.github.com/repos/Microsoft/docker/forks","keys_url":"https://api.github.com/repos/Microsoft/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/docker/teams","hooks_url":"https://api.github.com/repos/Microsoft/docker/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/docker/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/docker/events","assignees_url":"https://api.github.com/repos/Microsoft/docker/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/docker/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/docker/tags","blobs_url":"https://api.github.com/repos/Microsoft/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/docker/languages","stargazers_url":"https://api.github.com/repos/Microsoft/docker/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/docker/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/docker/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/docker/subscription","commits_url":"https://api.github.com/repos/Microsoft/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/docker/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/docker/merges","archive_url":"https://api.github.com/repos/Microsoft/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/docker/downloads","issues_url":"https://api.github.com/repos/Microsoft/docker/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/docker/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/docker/releases{/id}","created_at":"2015-01-31T00:05:16Z","updated_at":"2015-09-21T03:19:44Z","pushed_at":"2015-09-22T02:57:06Z","git_url":"git://github.com/Microsoft/docker.git","ssh_url":"git@github.com:Microsoft/docker.git","clone_url":"https://github.com/Microsoft/docker.git","svn_url":"https://github.com/Microsoft/docker","homepage":"http://www.docker.com","size":71037,"stargazers_count":183,"watchers_count":183,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":0,"forks":33,"open_issues":0,"watchers":183,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"587558f617e602c0a690c751d96ccddea3f648d3","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-09-22T14:13:38Z","pushed_at":"2015-09-22T14:25:02Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":257845,"stargazers_count":24958,"watchers_count":24958,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6484,"mirror_url":null,"open_issues_count":1071,"forks":6484,"open_issues":1071,"watchers":24958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/16312"},"html":{"href":"https://github.com/docker/docker/pull/16312"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/16312"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/16312/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/16312/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/16312/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/c9da4724090340d181deab02e59f88a4e63fc6d1"}}}}