{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/29241932","id":29241932,"diff_hunk":"@@ -63,15 +44,6 @@ def run(args)\n         end\n         return LogStash::Agent.run($0, agent_args)\n       end,\n-      \"rspec\" => lambda do","path":"lib/logstash/runner.rb","position":48,"original_position":48,"commit_id":"ad6b8e63adf726acfa7aed53db127f2565fc8d04","original_commit_id":"6aaed918a1b8fcd30286d3ffca8df808a936f35d","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"ah good point. let's see if that is the best strategy to run that through runner.","created_at":"2015-04-28T13:31:24Z","updated_at":"2015-04-28T13:31:24Z","html_url":"https://github.com/elastic/logstash/pull/3111#discussion_r29241932","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/3111","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/29241932"},"html":{"href":"https://github.com/elastic/logstash/pull/3111#discussion_r29241932"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3111"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/3111","id":34112819,"html_url":"https://github.com/elastic/logstash/pull/3111","diff_url":"https://github.com/elastic/logstash/pull/3111.diff","patch_url":"https://github.com/elastic/logstash/pull/3111.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/3111","number":3111,"state":"open","locked":false,"title":"[WIP] use either local core lib dir or logstash-core gem","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"will fix #3096\r\n\r\nadds the concept of `LOGSTASH_HOME` vs `LOGSTASH_CORE` where `LOGSTASH_HOME` points to the package root while `LOGSTASH_CORE` points to the directory containing the core code `lib/logstash/...`.\r\nBoth can be the same, when in development using a repo clone, or different when packaged where `LOGSTASH_CORE` points to the `logstash-core` gem under `vendor/bundle/...`.\r\n\r\nIt looks like it's working well but I haven't fully tested the package generation because I did not have internet on my flight :P hence the WIP. This is an early release so we can have more eyeballs on the idea. \r\n\r\nI also did a few cleanup of what I thought was dead/unused code.\r\n\r\n","created_at":"2015-04-25T20:47:14Z","updated_at":"2015-04-28T13:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e500adac5c7fe8a9728622f63e1fb33e6f71ea95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/3111/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/3111/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/3111/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/ad6b8e63adf726acfa7aed53db127f2565fc8d04","head":{"label":"colinsurprenant:fix/logstash_core","ref":"fix/logstash_core","sha":"ad6b8e63adf726acfa7aed53db127f2565fc8d04","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"repo":{"id":17155108,"name":"logstash","full_name":"colinsurprenant/logstash","owner":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colinsurprenant/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/colinsurprenant/logstash","forks_url":"https://api.github.com/repos/colinsurprenant/logstash/forks","keys_url":"https://api.github.com/repos/colinsurprenant/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colinsurprenant/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colinsurprenant/logstash/teams","hooks_url":"https://api.github.com/repos/colinsurprenant/logstash/hooks","issue_events_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/colinsurprenant/logstash/events","assignees_url":"https://api.github.com/repos/colinsurprenant/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/colinsurprenant/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/colinsurprenant/logstash/tags","blobs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colinsurprenant/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/colinsurprenant/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colinsurprenant/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/colinsurprenant/logstash/languages","stargazers_url":"https://api.github.com/repos/colinsurprenant/logstash/stargazers","contributors_url":"https://api.github.com/repos/colinsurprenant/logstash/contributors","subscribers_url":"https://api.github.com/repos/colinsurprenant/logstash/subscribers","subscription_url":"https://api.github.com/repos/colinsurprenant/logstash/subscription","commits_url":"https://api.github.com/repos/colinsurprenant/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/colinsurprenant/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/colinsurprenant/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/colinsurprenant/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/colinsurprenant/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colinsurprenant/logstash/merges","archive_url":"https://api.github.com/repos/colinsurprenant/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colinsurprenant/logstash/downloads","issues_url":"https://api.github.com/repos/colinsurprenant/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/colinsurprenant/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/colinsurprenant/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/colinsurprenant/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colinsurprenant/logstash/labels{/name}","releases_url":"https://api.github.com/repos/colinsurprenant/logstash/releases{/id}","created_at":"2014-02-24T23:52:15Z","updated_at":"2015-04-13T10:39:50Z","pushed_at":"2015-04-28T12:28:44Z","git_url":"git://github.com/colinsurprenant/logstash.git","ssh_url":"git@github.com:colinsurprenant/logstash.git","clone_url":"https://github.com/colinsurprenant/logstash.git","svn_url":"https://github.com/colinsurprenant/logstash","homepage":"http://logstash.net/","size":71981,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c70f252fe489a1a33d763736f186ad453614673b","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2015-04-28T11:15:49Z","pushed_at":"2015-04-28T12:28:47Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":90894,"stargazers_count":4064,"watchers_count":4064,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1412,"mirror_url":null,"open_issues_count":678,"forks":1412,"open_issues":678,"watchers":4064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3111"},"html":{"href":"https://github.com/elastic/logstash/pull/3111"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/3111"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/3111/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3111/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3111/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/ad6b8e63adf726acfa7aed53db127f2565fc8d04"}}}}