{"action":"created","comment":{"url":"https://api.github.com/repos/chop-dbhi/serrano/pulls/comments/29307482","id":29307482,"diff_hunk":"@@ -28,13 +27,41 @@ class PreviewResource(BaseResource, PaginatorResource):\n \n     parametizer = PreviewParametizer\n \n-    def get(self, request):\n+    def get(self, request, **kwargs):\n         params = self.get_params(request)\n \n-        page = params.get('page')\n         limit = params.get('limit')\n         tree = params.get('tree')\n \n+        page = kwargs.get('page')\n+        stop_page = kwargs.get('stop_page')\n+\n+        offset = None\n+\n+        # Restrict the preview results to a particular page or page range. If\n+        # no page range is supplied, use the default limit.","path":"serrano/resources/preview.py","position":47,"original_position":46,"commit_id":"24d4c35c5db0c656ada464954899ddb10035de3c","original_commit_id":"cd6c0f70becbe36b9489f02d1e3ac19a6f2b1885","user":{"login":"naegelyd","id":3911912,"avatar_url":"https://avatars.githubusercontent.com/u/3911912?v=3","gravatar_id":"","url":"https://api.github.com/users/naegelyd","html_url":"https://github.com/naegelyd","followers_url":"https://api.github.com/users/naegelyd/followers","following_url":"https://api.github.com/users/naegelyd/following{/other_user}","gists_url":"https://api.github.com/users/naegelyd/gists{/gist_id}","starred_url":"https://api.github.com/users/naegelyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naegelyd/subscriptions","organizations_url":"https://api.github.com/users/naegelyd/orgs","repos_url":"https://api.github.com/users/naegelyd/repos","events_url":"https://api.github.com/users/naegelyd/events{/privacy}","received_events_url":"https://api.github.com/users/naegelyd/received_events","type":"User","site_admin":false},"body":"I think I must have lost something in the rebase. Sorry for the confusion. What I meant meant to ask here is if we should explicitly set the limit to `None` when no page is supplied as is done [here](https://github.com/chop-dbhi/serrano/blob/master/serrano/resources/exporter.py#L103-L106). So:\r\n\r\n```python\r\nif page:\r\n    ...\r\nelse:\r\n    limit = None\r\n```\r\n\r\nUnder the setup that currently exists, limit will always be 20 when not supplied as you noted.","created_at":"2015-04-29T03:00:33Z","updated_at":"2015-04-29T03:00:33Z","html_url":"https://github.com/chop-dbhi/serrano/pull/276#discussion_r29307482","pull_request_url":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/chop-dbhi/serrano/pulls/comments/29307482"},"html":{"href":"https://github.com/chop-dbhi/serrano/pull/276#discussion_r29307482"},"pull_request":{"href":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276","id":33018172,"html_url":"https://github.com/chop-dbhi/serrano/pull/276","diff_url":"https://github.com/chop-dbhi/serrano/pull/276.diff","patch_url":"https://github.com/chop-dbhi/serrano/pull/276.patch","issue_url":"https://api.github.com/repos/chop-dbhi/serrano/issues/276","number":276,"state":"open","locked":false,"title":"Decouple count/paging from preview endpoint","user":{"login":"naegelyd","id":3911912,"avatar_url":"https://avatars.githubusercontent.com/u/3911912?v=3","gravatar_id":"","url":"https://api.github.com/users/naegelyd","html_url":"https://github.com/naegelyd","followers_url":"https://api.github.com/users/naegelyd/followers","following_url":"https://api.github.com/users/naegelyd/following{/other_user}","gists_url":"https://api.github.com/users/naegelyd/gists{/gist_id}","starred_url":"https://api.github.com/users/naegelyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naegelyd/subscriptions","organizations_url":"https://api.github.com/users/naegelyd/orgs","repos_url":"https://api.github.com/users/naegelyd/repos","events_url":"https://api.github.com/users/naegelyd/events{/privacy}","received_events_url":"https://api.github.com/users/naegelyd/received_events","type":"User","site_admin":false},"body":"Fix #254.\r\n\r\nTested locally and this does not appear to introduce any failures beyond those already occurring in master.","created_at":"2015-04-10T04:53:47Z","updated_at":"2015-04-29T03:00:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"456d4bb82dfe658f0fa066e5756ce62671751b97","assignee":{"login":"bruth","id":515142,"avatar_url":"https://avatars.githubusercontent.com/u/515142?v=3","gravatar_id":"","url":"https://api.github.com/users/bruth","html_url":"https://github.com/bruth","followers_url":"https://api.github.com/users/bruth/followers","following_url":"https://api.github.com/users/bruth/following{/other_user}","gists_url":"https://api.github.com/users/bruth/gists{/gist_id}","starred_url":"https://api.github.com/users/bruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruth/subscriptions","organizations_url":"https://api.github.com/users/bruth/orgs","repos_url":"https://api.github.com/users/bruth/repos","events_url":"https://api.github.com/users/bruth/events{/privacy}","received_events_url":"https://api.github.com/users/bruth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276/commits","review_comments_url":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276/comments","review_comment_url":"https://api.github.com/repos/chop-dbhi/serrano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chop-dbhi/serrano/issues/276/comments","statuses_url":"https://api.github.com/repos/chop-dbhi/serrano/statuses/24d4c35c5db0c656ada464954899ddb10035de3c","head":{"label":"chop-dbhi:issue-254","ref":"issue-254","sha":"24d4c35c5db0c656ada464954899ddb10035de3c","user":{"login":"chop-dbhi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/chop-dbhi","html_url":"https://github.com/chop-dbhi","followers_url":"https://api.github.com/users/chop-dbhi/followers","following_url":"https://api.github.com/users/chop-dbhi/following{/other_user}","gists_url":"https://api.github.com/users/chop-dbhi/gists{/gist_id}","starred_url":"https://api.github.com/users/chop-dbhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chop-dbhi/subscriptions","organizations_url":"https://api.github.com/users/chop-dbhi/orgs","repos_url":"https://api.github.com/users/chop-dbhi/repos","events_url":"https://api.github.com/users/chop-dbhi/events{/privacy}","received_events_url":"https://api.github.com/users/chop-dbhi/received_events","type":"Organization","site_admin":false},"repo":{"id":2338279,"name":"serrano","full_name":"chop-dbhi/serrano","owner":{"login":"chop-dbhi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/chop-dbhi","html_url":"https://github.com/chop-dbhi","followers_url":"https://api.github.com/users/chop-dbhi/followers","following_url":"https://api.github.com/users/chop-dbhi/following{/other_user}","gists_url":"https://api.github.com/users/chop-dbhi/gists{/gist_id}","starred_url":"https://api.github.com/users/chop-dbhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chop-dbhi/subscriptions","organizations_url":"https://api.github.com/users/chop-dbhi/orgs","repos_url":"https://api.github.com/users/chop-dbhi/repos","events_url":"https://api.github.com/users/chop-dbhi/events{/privacy}","received_events_url":"https://api.github.com/users/chop-dbhi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chop-dbhi/serrano","description":"Serrano implements a hypermedia API for Avocado. Avocado is a Django app which targets developers who are interested in letting their data do the work for them.","fork":false,"url":"https://api.github.com/repos/chop-dbhi/serrano","forks_url":"https://api.github.com/repos/chop-dbhi/serrano/forks","keys_url":"https://api.github.com/repos/chop-dbhi/serrano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chop-dbhi/serrano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chop-dbhi/serrano/teams","hooks_url":"https://api.github.com/repos/chop-dbhi/serrano/hooks","issue_events_url":"https://api.github.com/repos/chop-dbhi/serrano/issues/events{/number}","events_url":"https://api.github.com/repos/chop-dbhi/serrano/events","assignees_url":"https://api.github.com/repos/chop-dbhi/serrano/assignees{/user}","branches_url":"https://api.github.com/repos/chop-dbhi/serrano/branches{/branch}","tags_url":"https://api.github.com/repos/chop-dbhi/serrano/tags","blobs_url":"https://api.github.com/repos/chop-dbhi/serrano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chop-dbhi/serrano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chop-dbhi/serrano/git/refs{/sha}","trees_url":"https://api.github.com/repos/chop-dbhi/serrano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chop-dbhi/serrano/statuses/{sha}","languages_url":"https://api.github.com/repos/chop-dbhi/serrano/languages","stargazers_url":"https://api.github.com/repos/chop-dbhi/serrano/stargazers","contributors_url":"https://api.github.com/repos/chop-dbhi/serrano/contributors","subscribers_url":"https://api.github.com/repos/chop-dbhi/serrano/subscribers","subscription_url":"https://api.github.com/repos/chop-dbhi/serrano/subscription","commits_url":"https://api.github.com/repos/chop-dbhi/serrano/commits{/sha}","git_commits_url":"https://api.github.com/repos/chop-dbhi/serrano/git/commits{/sha}","comments_url":"https://api.github.com/repos/chop-dbhi/serrano/comments{/number}","issue_comment_url":"https://api.github.com/repos/chop-dbhi/serrano/issues/comments{/number}","contents_url":"https://api.github.com/repos/chop-dbhi/serrano/contents/{+path}","compare_url":"https://api.github.com/repos/chop-dbhi/serrano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chop-dbhi/serrano/merges","archive_url":"https://api.github.com/repos/chop-dbhi/serrano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chop-dbhi/serrano/downloads","issues_url":"https://api.github.com/repos/chop-dbhi/serrano/issues{/number}","pulls_url":"https://api.github.com/repos/chop-dbhi/serrano/pulls{/number}","milestones_url":"https://api.github.com/repos/chop-dbhi/serrano/milestones{/number}","notifications_url":"https://api.github.com/repos/chop-dbhi/serrano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chop-dbhi/serrano/labels{/name}","releases_url":"https://api.github.com/repos/chop-dbhi/serrano/releases{/id}","created_at":"2011-09-07T00:01:38Z","updated_at":"2015-04-27T00:51:20Z","pushed_at":"2015-04-28T03:36:30Z","git_url":"git://github.com/chop-dbhi/serrano.git","ssh_url":"git@github.com:chop-dbhi/serrano.git","clone_url":"https://github.com/chop-dbhi/serrano.git","svn_url":"https://github.com/chop-dbhi/serrano","homepage":"http://serrano.harvest.io","size":4837,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":21,"forks":7,"open_issues":21,"watchers":19,"default_branch":"master"}},"base":{"label":"chop-dbhi:master","ref":"master","sha":"ae5d0b049febe87eb31f0f40abd8cb87d3af306f","user":{"login":"chop-dbhi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/chop-dbhi","html_url":"https://github.com/chop-dbhi","followers_url":"https://api.github.com/users/chop-dbhi/followers","following_url":"https://api.github.com/users/chop-dbhi/following{/other_user}","gists_url":"https://api.github.com/users/chop-dbhi/gists{/gist_id}","starred_url":"https://api.github.com/users/chop-dbhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chop-dbhi/subscriptions","organizations_url":"https://api.github.com/users/chop-dbhi/orgs","repos_url":"https://api.github.com/users/chop-dbhi/repos","events_url":"https://api.github.com/users/chop-dbhi/events{/privacy}","received_events_url":"https://api.github.com/users/chop-dbhi/received_events","type":"Organization","site_admin":false},"repo":{"id":2338279,"name":"serrano","full_name":"chop-dbhi/serrano","owner":{"login":"chop-dbhi","id":709892,"avatar_url":"https://avatars.githubusercontent.com/u/709892?v=3","gravatar_id":"","url":"https://api.github.com/users/chop-dbhi","html_url":"https://github.com/chop-dbhi","followers_url":"https://api.github.com/users/chop-dbhi/followers","following_url":"https://api.github.com/users/chop-dbhi/following{/other_user}","gists_url":"https://api.github.com/users/chop-dbhi/gists{/gist_id}","starred_url":"https://api.github.com/users/chop-dbhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chop-dbhi/subscriptions","organizations_url":"https://api.github.com/users/chop-dbhi/orgs","repos_url":"https://api.github.com/users/chop-dbhi/repos","events_url":"https://api.github.com/users/chop-dbhi/events{/privacy}","received_events_url":"https://api.github.com/users/chop-dbhi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chop-dbhi/serrano","description":"Serrano implements a hypermedia API for Avocado. Avocado is a Django app which targets developers who are interested in letting their data do the work for them.","fork":false,"url":"https://api.github.com/repos/chop-dbhi/serrano","forks_url":"https://api.github.com/repos/chop-dbhi/serrano/forks","keys_url":"https://api.github.com/repos/chop-dbhi/serrano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chop-dbhi/serrano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chop-dbhi/serrano/teams","hooks_url":"https://api.github.com/repos/chop-dbhi/serrano/hooks","issue_events_url":"https://api.github.com/repos/chop-dbhi/serrano/issues/events{/number}","events_url":"https://api.github.com/repos/chop-dbhi/serrano/events","assignees_url":"https://api.github.com/repos/chop-dbhi/serrano/assignees{/user}","branches_url":"https://api.github.com/repos/chop-dbhi/serrano/branches{/branch}","tags_url":"https://api.github.com/repos/chop-dbhi/serrano/tags","blobs_url":"https://api.github.com/repos/chop-dbhi/serrano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chop-dbhi/serrano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chop-dbhi/serrano/git/refs{/sha}","trees_url":"https://api.github.com/repos/chop-dbhi/serrano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chop-dbhi/serrano/statuses/{sha}","languages_url":"https://api.github.com/repos/chop-dbhi/serrano/languages","stargazers_url":"https://api.github.com/repos/chop-dbhi/serrano/stargazers","contributors_url":"https://api.github.com/repos/chop-dbhi/serrano/contributors","subscribers_url":"https://api.github.com/repos/chop-dbhi/serrano/subscribers","subscription_url":"https://api.github.com/repos/chop-dbhi/serrano/subscription","commits_url":"https://api.github.com/repos/chop-dbhi/serrano/commits{/sha}","git_commits_url":"https://api.github.com/repos/chop-dbhi/serrano/git/commits{/sha}","comments_url":"https://api.github.com/repos/chop-dbhi/serrano/comments{/number}","issue_comment_url":"https://api.github.com/repos/chop-dbhi/serrano/issues/comments{/number}","contents_url":"https://api.github.com/repos/chop-dbhi/serrano/contents/{+path}","compare_url":"https://api.github.com/repos/chop-dbhi/serrano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chop-dbhi/serrano/merges","archive_url":"https://api.github.com/repos/chop-dbhi/serrano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chop-dbhi/serrano/downloads","issues_url":"https://api.github.com/repos/chop-dbhi/serrano/issues{/number}","pulls_url":"https://api.github.com/repos/chop-dbhi/serrano/pulls{/number}","milestones_url":"https://api.github.com/repos/chop-dbhi/serrano/milestones{/number}","notifications_url":"https://api.github.com/repos/chop-dbhi/serrano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chop-dbhi/serrano/labels{/name}","releases_url":"https://api.github.com/repos/chop-dbhi/serrano/releases{/id}","created_at":"2011-09-07T00:01:38Z","updated_at":"2015-04-27T00:51:20Z","pushed_at":"2015-04-28T03:36:30Z","git_url":"git://github.com/chop-dbhi/serrano.git","ssh_url":"git@github.com:chop-dbhi/serrano.git","clone_url":"https://github.com/chop-dbhi/serrano.git","svn_url":"https://github.com/chop-dbhi/serrano","homepage":"http://serrano.harvest.io","size":4837,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":21,"forks":7,"open_issues":21,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276"},"html":{"href":"https://github.com/chop-dbhi/serrano/pull/276"},"issue":{"href":"https://api.github.com/repos/chop-dbhi/serrano/issues/276"},"comments":{"href":"https://api.github.com/repos/chop-dbhi/serrano/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/chop-dbhi/serrano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chop-dbhi/serrano/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/chop-dbhi/serrano/statuses/24d4c35c5db0c656ada464954899ddb10035de3c"}}}}