{"action":"created","issue":{"url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/issues/1","labels_url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/issues/1/comments","events_url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/issues/1/events","html_url":"https://github.com/ZaneDubya/MP3Sharp/pull/1","id":95327345,"number":1,"title":"Lots of refactoring, code analysis and coding standards corrections, and a unit test project is added.","user":{"login":"jessehallam","id":10954805,"avatar_url":"https://avatars.githubusercontent.com/u/10954805?v=3","gravatar_id":"","url":"https://api.github.com/users/jessehallam","html_url":"https://github.com/jessehallam","followers_url":"https://api.github.com/users/jessehallam/followers","following_url":"https://api.github.com/users/jessehallam/following{/other_user}","gists_url":"https://api.github.com/users/jessehallam/gists{/gist_id}","starred_url":"https://api.github.com/users/jessehallam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessehallam/subscriptions","organizations_url":"https://api.github.com/users/jessehallam/orgs","repos_url":"https://api.github.com/users/jessehallam/repos","events_url":"https://api.github.com/users/jessehallam/events{/privacy}","received_events_url":"https://api.github.com/users/jessehallam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-16T01:40:09Z","updated_at":"2015-07-17T02:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/pulls/1","html_url":"https://github.com/ZaneDubya/MP3Sharp/pull/1","diff_url":"https://github.com/ZaneDubya/MP3Sharp/pull/1.diff","patch_url":"https://github.com/ZaneDubya/MP3Sharp/pull/1.patch"},"body":"Decided to tackle your project just for fun. I've written a whole muck of changes which conform to Microsoft coding standards. In particular:\r\n\r\n- Added XML docs on several properties and methods.\r\n- Rewrote some docs to use standardized verbiage.\r\n- Ran Visual Studio Code Analysis and cleared all CA-series warnings.\r\n- Added additional error checking on method parameters (is offset + count > length?)\r\n- Added a basic Unit Test package. Ran unit tests against the original solution (f7d579516144ddf824fbead6b61027c628289ec7) and against my fork with all changes merged (5865338b380151d22134c7a93ee101fb90405a66); tests passed.\r\n\r\nNotes on tests: Coverage is at ~40%. I might add additional tests if I find the time.\r\nThe main test reads the MP3Stream (ala the README) and MD5 hashes the PCM output. If the hash is good, the whole algorithm is thought to be in a good state."},"comment":{"url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/issues/comments/122149997","html_url":"https://github.com/ZaneDubya/MP3Sharp/pull/1#issuecomment-122149997","issue_url":"https://api.github.com/repos/ZaneDubya/MP3Sharp/issues/1","id":122149997,"user":{"login":"ZaneDubya","id":7041719,"avatar_url":"https://avatars.githubusercontent.com/u/7041719?v=3","gravatar_id":"","url":"https://api.github.com/users/ZaneDubya","html_url":"https://github.com/ZaneDubya","followers_url":"https://api.github.com/users/ZaneDubya/followers","following_url":"https://api.github.com/users/ZaneDubya/following{/other_user}","gists_url":"https://api.github.com/users/ZaneDubya/gists{/gist_id}","starred_url":"https://api.github.com/users/ZaneDubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZaneDubya/subscriptions","organizations_url":"https://api.github.com/users/ZaneDubya/orgs","repos_url":"https://api.github.com/users/ZaneDubya/repos","events_url":"https://api.github.com/users/ZaneDubya/events{/privacy}","received_events_url":"https://api.github.com/users/ZaneDubya/received_events","type":"User","site_admin":false},"created_at":"2015-07-17T02:10:59Z","updated_at":"2015-07-17T02:10:59Z","body":"@jessehallam More than satisfied, these are great. I've made one change. Please take a look at [Buffer16BitStereo.cs:71](https://github.com/ZaneDubya/MP3Sharp/blob/jessehallam-formatting-docs-unittests-warnings/MP3Sharp/Buffer16BitStereo.cs#L71) (link is to my edit). I've changed the error condition from >= to >. Is this correct?"}}