{"action":"created","issue":{"url":"https://api.github.com/repos/Metastruct/luadev/issues/3","labels_url":"https://api.github.com/repos/Metastruct/luadev/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/Metastruct/luadev/issues/3/comments","events_url":"https://api.github.com/repos/Metastruct/luadev/issues/3/events","html_url":"https://github.com/Metastruct/luadev/pull/3","id":85122387,"number":3,"title":"Update run_client to allow quotes","user":{"login":"xaviergmail","id":522034,"avatar_url":"https://avatars.githubusercontent.com/u/522034?v=3","gravatar_id":"","url":"https://api.github.com/users/xaviergmail","html_url":"https://github.com/xaviergmail","followers_url":"https://api.github.com/users/xaviergmail/followers","following_url":"https://api.github.com/users/xaviergmail/following{/other_user}","gists_url":"https://api.github.com/users/xaviergmail/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviergmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviergmail/subscriptions","organizations_url":"https://api.github.com/users/xaviergmail/orgs","repos_url":"https://api.github.com/users/xaviergmail/repos","events_url":"https://api.github.com/users/xaviergmail/events{/privacy}","received_events_url":"https://api.github.com/users/xaviergmail/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-04T14:27:25Z","updated_at":"2015-06-04T22:20:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Metastruct/luadev/pulls/3","html_url":"https://github.com/Metastruct/luadev/pull/3","diff_url":"https://github.com/Metastruct/luadev/pull/3.diff","patch_url":"https://github.com/Metastruct/luadev/pull/3.patch"},"body":"Using TableToString to rebuild the script string from the argument table minus the first argument (player search string) causes double-quotes to disappear. This commit uses patterns to first check for a quoted argument and unquoted afterwards, and effectively removes it from the 'script' string, leaving our beloved double-quotes intact. Unmatched double quotes will be caught by the first check in the function, with tbl[2] being nil.\r\n\r\nWith TableToString:\r\n>] l_run_client ^ print(\"a\")\r\n>[Luadev Server] print ( a )\r\n><0:0:40320801|CSi. Xavier><run_client> running on Player [1][CSi. Xavier]\r\n\r\nWith pattern matching:\r\n>] l_run_client ^ print(\"a\")\r\n>[Luadev Server] print(\"a\")\r\n><0:0:40320801|CSi. Xavier><run_client> running on Player [1][CSi. Xavier]\r\n\r\nI am not 100% sure if my patterns are correct, but I haven't found a way to break them yet. Improvements / suggestions are more than welcome."},"comment":{"url":"https://api.github.com/repos/Metastruct/luadev/issues/comments/109071501","html_url":"https://github.com/Metastruct/luadev/pull/3#issuecomment-109071501","issue_url":"https://api.github.com/repos/Metastruct/luadev/issues/3","id":109071501,"user":{"login":"xaviergmail","id":522034,"avatar_url":"https://avatars.githubusercontent.com/u/522034?v=3","gravatar_id":"","url":"https://api.github.com/users/xaviergmail","html_url":"https://github.com/xaviergmail","followers_url":"https://api.github.com/users/xaviergmail/followers","following_url":"https://api.github.com/users/xaviergmail/following{/other_user}","gists_url":"https://api.github.com/users/xaviergmail/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviergmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviergmail/subscriptions","organizations_url":"https://api.github.com/users/xaviergmail/orgs","repos_url":"https://api.github.com/users/xaviergmail/repos","events_url":"https://api.github.com/users/xaviergmail/events{/privacy}","received_events_url":"https://api.github.com/users/xaviergmail/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T22:20:03Z","updated_at":"2015-06-04T22:20:03Z","body":"Are you saying we should use `\",\":` as a separator? I'm not quite sure I understand what you mean."}}