{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/35048019","id":35048019,"diff_hunk":"@@ -383,12 +383,20 @@ var CallScreen = {\n       var f = new navigator.mozL10n.DateTimeFormat();\n       var timeFormat = window.navigator.mozHour12 ? _('shortTimeFormat12') :\n                                                     _('shortTimeFormat24');\n-      // FIXME/bug 1060333: Replace span with hidden mechanism.\n-      // Don't show am/pm (for 12 or 24 time) in the callscreen\n+      /* In 12h format we don't want to display the AM/PM component on the\n+       * lockscreen. However there's no way to obtain such a string using\n+       * DateTimeFormat(). What we do instead is to inject a fake <span> tag\n+       * around the AM/PM component which we later remove from the string using\n+       * a regular expression. */","path":"apps/callscreen/js/call_screen.js","position":10,"original_position":10,"commit_id":"4ab2589fcdd19641cb378c4d4df1568e870e4082","original_commit_id":"4ab2589fcdd19641cb378c4d4df1568e870e4082","user":{"login":"DouglasSherk","id":1310914,"avatar_url":"https://avatars.githubusercontent.com/u/1310914?v=3","gravatar_id":"","url":"https://api.github.com/users/DouglasSherk","html_url":"https://github.com/DouglasSherk","followers_url":"https://api.github.com/users/DouglasSherk/followers","following_url":"https://api.github.com/users/DouglasSherk/following{/other_user}","gists_url":"https://api.github.com/users/DouglasSherk/gists{/gist_id}","starred_url":"https://api.github.com/users/DouglasSherk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DouglasSherk/subscriptions","organizations_url":"https://api.github.com/users/DouglasSherk/orgs","repos_url":"https://api.github.com/users/DouglasSherk/repos","events_url":"https://api.github.com/users/DouglasSherk/events{/privacy}","received_events_url":"https://api.github.com/users/DouglasSherk/received_events","type":"User","site_admin":false},"body":"This is a really wonky method, but I can't think of a better one.","created_at":"2015-07-20T21:43:30Z","updated_at":"2015-07-20T21:43:30Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/30685#discussion_r35048019","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/35048019"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30685#discussion_r35048019"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685","id":38192303,"html_url":"https://github.com/mozilla-b2g/gaia/pull/30685","diff_url":"https://github.com/mozilla-b2g/gaia/pull/30685.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/30685.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30685","number":30685,"state":"open","locked":false,"title":"Bug 1060333 - Remove the use of innerHTML for displaying the time in the lockscreen r=drs,gweng","user":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-21T22:55:10Z","updated_at":"2015-07-20T21:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e8ce415ff03bb423a1f091886bd97181dc49bfb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30685/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4ab2589fcdd19641cb378c4d4df1568e870e4082","head":{"label":"gabrielesvelto:bug-1060333-call-screen-inner-html","ref":"bug-1060333-call-screen-inner-html","sha":"4ab2589fcdd19641cb378c4d4df1568e870e4082","user":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"repo":{"id":6279318,"name":"gaia","full_name":"gabrielesvelto/gaia","owner":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabrielesvelto/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/gabrielesvelto/gaia","forks_url":"https://api.github.com/repos/gabrielesvelto/gaia/forks","keys_url":"https://api.github.com/repos/gabrielesvelto/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrielesvelto/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrielesvelto/gaia/teams","hooks_url":"https://api.github.com/repos/gabrielesvelto/gaia/hooks","issue_events_url":"https://api.github.com/repos/gabrielesvelto/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/gabrielesvelto/gaia/events","assignees_url":"https://api.github.com/repos/gabrielesvelto/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/gabrielesvelto/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/gabrielesvelto/gaia/tags","blobs_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrielesvelto/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrielesvelto/gaia/languages","stargazers_url":"https://api.github.com/repos/gabrielesvelto/gaia/stargazers","contributors_url":"https://api.github.com/repos/gabrielesvelto/gaia/contributors","subscribers_url":"https://api.github.com/repos/gabrielesvelto/gaia/subscribers","subscription_url":"https://api.github.com/repos/gabrielesvelto/gaia/subscription","commits_url":"https://api.github.com/repos/gabrielesvelto/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrielesvelto/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrielesvelto/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrielesvelto/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/gabrielesvelto/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrielesvelto/gaia/merges","archive_url":"https://api.github.com/repos/gabrielesvelto/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrielesvelto/gaia/downloads","issues_url":"https://api.github.com/repos/gabrielesvelto/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/gabrielesvelto/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrielesvelto/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrielesvelto/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrielesvelto/gaia/labels{/name}","releases_url":"https://api.github.com/repos/gabrielesvelto/gaia/releases{/id}","created_at":"2012-10-18T13:53:19Z","updated_at":"2015-05-07T14:08:22Z","pushed_at":"2015-07-20T13:11:52Z","git_url":"git://github.com/gabrielesvelto/gaia.git","ssh_url":"git@github.com:gabrielesvelto/gaia.git","clone_url":"https://github.com/gabrielesvelto/gaia.git","svn_url":"https://github.com/gabrielesvelto/gaia","homepage":"https://wiki.mozilla.org/B2G","size":947670,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"5f3cfc662bac683438ddd260f4bbd1f55b3b5b9b","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-07-18T19:42:32Z","pushed_at":"2015-07-20T21:30:44Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1658187,"stargazers_count":1954,"watchers_count":1954,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2374,"mirror_url":null,"open_issues_count":1088,"forks":2374,"open_issues":1088,"watchers":1954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30685"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30685"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30685/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30685/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4ab2589fcdd19641cb378c4d4df1568e870e4082"}}}}