{"comment":{"url":"https://api.github.com/repos/xhaggi/xbmc/comments/12533295","html_url":"https://github.com/xhaggi/xbmc/commit/71c0f048ac3467e496f83a656a0d57e65cf80b38#commitcomment-12533295","id":12533295,"user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"position":4,"line":50,"path":"xbmc/settings/Settings.h","commit_id":"71c0f048ac3467e496f83a656a0d57e65cf80b38","created_at":"2015-08-05T06:52:22Z","updated_at":"2015-08-05T06:52:22Z","body":"Why did you go with `const char*`? `ISetting::GetId()` returns `const std::string&` and all `CSettings` and `CSettingsManager` methods expect a `const std::string&` and you even had to throw in some manual casts to `std::string`."}}