{"action":"created","issue":{"url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/51","labels_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/51/comments","events_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/51/events","html_url":"https://github.com/ericclemmons/react-resolver/pull/51","id":85939665,"number":51,"title":"Nested Containers Not Finishing?","user":{"login":"ericclemmons","id":15182,"avatar_url":"https://avatars.githubusercontent.com/u/15182?v=3","gravatar_id":"","url":"https://api.github.com/users/ericclemmons","html_url":"https://github.com/ericclemmons","followers_url":"https://api.github.com/users/ericclemmons/followers","following_url":"https://api.github.com/users/ericclemmons/following{/other_user}","gists_url":"https://api.github.com/users/ericclemmons/gists{/gist_id}","starred_url":"https://api.github.com/users/ericclemmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericclemmons/subscriptions","organizations_url":"https://api.github.com/users/ericclemmons/orgs","repos_url":"https://api.github.com/users/ericclemmons/repos","events_url":"https://api.github.com/users/ericclemmons/events{/privacy}","received_events_url":"https://api.github.com/users/ericclemmons/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ericclemmons/react-resolver/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"ericclemmons","id":15182,"avatar_url":"https://avatars.githubusercontent.com/u/15182?v=3","gravatar_id":"","url":"https://api.github.com/users/ericclemmons","html_url":"https://github.com/ericclemmons","followers_url":"https://api.github.com/users/ericclemmons/followers","following_url":"https://api.github.com/users/ericclemmons/following{/other_user}","gists_url":"https://api.github.com/users/ericclemmons/gists{/gist_id}","starred_url":"https://api.github.com/users/ericclemmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericclemmons/subscriptions","organizations_url":"https://api.github.com/users/ericclemmons/orgs","repos_url":"https://api.github.com/users/ericclemmons/repos","events_url":"https://api.github.com/users/ericclemmons/events{/privacy}","received_events_url":"https://api.github.com/users/ericclemmons/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-06-07T20:37:07Z","updated_at":"2015-06-07T20:58:44Z","closed_at":"2015-06-07T20:58:44Z","pull_request":{"url":"https://api.github.com/repos/ericclemmons/react-resolver/pulls/51","html_url":"https://github.com/ericclemmons/react-resolver/pull/51","diff_url":"https://github.com/ericclemmons/react-resolver/pull/51.diff","patch_url":"https://github.com/ericclemmons/react-resolver/pull/51.patch"},"body":"On an internal project, @willrstern found this peculiar bug:\r\n\r\n```js\r\nimport React from \"react\";\r\nimport { Resolver } from \"react-resolver\";\r\n\r\nclass Foo extends React.Component {\r\n  render() {\r\n    console.log(\"render Foo\");\r\n    return (\r\n      <h1>Foo</h1>\r\n    );\r\n  }\r\n}\r\n\r\nFoo.displayName = \"Foo\";\r\n\r\nconst FooContainer = Resolver.createContainer(Foo, {\r\n  resolve: {\r\n    foo: function() {\r\n      console.log(\"foo resolve\");\r\n      return \"foo\";\r\n    }\r\n  }\r\n});\r\n\r\nclass Bar extends React.Component {\r\n  render() {\r\n    console.log(\"render Bar\");\r\n    return (\r\n      <FooContainer />\r\n    );\r\n  }\r\n}\r\n\r\nBar.displayName = \"Bar\";\r\n\r\nconst BarContainer = Resolver.createContainer(Bar, {\r\n  resolve: {\r\n    bar: function() {\r\n      console.log(\"bar resolve\");\r\n      return \"bar\";\r\n    }\r\n  }\r\n});\r\n\r\nexport const register = function(server, options, next) {\r\n  server.route({\r\n    method: \"GET\",\r\n    path: \"/{p*}\",\r\n    handler: function(request, reply) {\r\n      Resolver.renderToString(<BarContainer />).then((markup) => {\r\n        console.log(\"render view\", markup);\r\n        reply(markup);\r\n      });\r\n    },\r\n  });\r\n\r\n  next();\r\n};\r\n\r\nregister.attributes = { name: \"View\" };\r\n```\r\n\r\nThe resolver never seems to `finish()`, so `markup` is never sent."},"comment":{"url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/comments/109799323","html_url":"https://github.com/ericclemmons/react-resolver/pull/51#issuecomment-109799323","issue_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/51","id":109799323,"user":{"login":"ericclemmons","id":15182,"avatar_url":"https://avatars.githubusercontent.com/u/15182?v=3","gravatar_id":"","url":"https://api.github.com/users/ericclemmons","html_url":"https://github.com/ericclemmons","followers_url":"https://api.github.com/users/ericclemmons/followers","following_url":"https://api.github.com/users/ericclemmons/following{/other_user}","gists_url":"https://api.github.com/users/ericclemmons/gists{/gist_id}","starred_url":"https://api.github.com/users/ericclemmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericclemmons/subscriptions","organizations_url":"https://api.github.com/users/ericclemmons/orgs","repos_url":"https://api.github.com/users/ericclemmons/repos","events_url":"https://api.github.com/users/ericclemmons/events{/privacy}","received_events_url":"https://api.github.com/users/ericclemmons/received_events","type":"User","site_admin":false},"created_at":"2015-06-07T20:58:43Z","updated_at":"2015-06-07T20:58:43Z","body":"@willrstern There's something else going on.  This _works_ on this project, but fails on our internal one. =/\r\n\r\n```\r\n  Resolver\r\n    .finish\r\nbar resolve\r\nrender Bar\r\nfoo resolve\r\nrender Foo\r\nrender Bar\r\nrender Foo\r\n<h1 data-reactid=\".n\" data-react-checksum=\"-1790047910\">Foo</h1>\r\n```"}}