{"action":"created","issue":{"url":"https://api.github.com/repos/jimhester/knitrBootstrap/issues/68","labels_url":"https://api.github.com/repos/jimhester/knitrBootstrap/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/jimhester/knitrBootstrap/issues/68/comments","events_url":"https://api.github.com/repos/jimhester/knitrBootstrap/issues/68/events","html_url":"https://github.com/jimhester/knitrBootstrap/pull/68","id":45142085,"number":68,"title":"Simple document format","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2014-10-07T18:24:24Z","updated_at":"2015-04-16T18:41:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jimhester/knitrBootstrap/pulls/68","html_url":"https://github.com/jimhester/knitrBootstrap/pull/68","diff_url":"https://github.com/jimhester/knitrBootstrap/pull/68.diff","patch_url":"https://github.com/jimhester/knitrBootstrap/pull/68.patch"},"body":"This is a major restructuring of the package embracing `rmarkdown` fully.  It has two main features,\r\n\r\n1. fully support rmarkdown, building knitrBootstrap off of `html_document()`\r\n2. simplify the code by removing features\r\n  - style and code theme choosers\r\n  - global toggles\r\n\r\nIt aims to do as little work in javascript as possible, namely no DOM restructuring (other than highlighting)."},"comment":{"url":"https://api.github.com/repos/jimhester/knitrBootstrap/issues/comments/93811297","html_url":"https://github.com/jimhester/knitrBootstrap/pull/68#issuecomment-93811297","issue_url":"https://api.github.com/repos/jimhester/knitrBootstrap/issues/68","id":93811297,"user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T18:41:12Z","updated_at":"2015-04-16T18:41:12Z","body":"It isn't really making any progress unfortunately :frowning:.  I haven't really done any analysis for almost two years at this point so my major impetus for writing knitrBootstrap (documenting analysis pipelines) is absent.\r\n\r\nI would really like this branch to be merged, as it is a simpler approach than previously and will inherit all of the testing and bug fixes from the close relationship with `rmarkdown`.\r\n\r\nHowever there are a couple of things holding it back,\r\n\r\n1. Standalone is broken due to a bug in pandoc and the Bootswatch themes, see https://github.com/jgm/pandoc/issues/1477, https://github.com/jimhester/knitrBootstrap/issues/172.  This is the reason it is hardcoded to `FALSE` currently.\r\n2. As a partial workaround to 1) this branch includes the dependencies locally, but previous `knitrBootstrap` behavior was to have all HTML dependencies as links.  Ideally both options would be supported. [htmltools::html_depenency()](https://github.com/rstudio/htmltools/blob/432d21858df07aeb176c41feb0d305316fe83955/R/html_dependency.R) does support supplying multiple dependency locations for a given dependency (i.e. local and remote), so that would be the way forward.  I don't really know what the proper way to allow the user to choose which dependency to use is however.\r\n3. All depenencies are loaded even if only one theme is used.  This is the default behavior of the html_depencey code in `rmarkdown`, but there is probably a way to specify a conditional dependency?\r\n4. Long TOCs are broken, (this is true of the regular branch as well).  I don't have a great fix for this unfortunately.\r\n5. simple vs bootstrap documents.  I feel like the bootstrap document buttons are too noisy, you don't really need to have every R code and output chunk labelled as such.  However as you said the simple document format (while less obtrusive) does not ever label them.  Perhaps it would be best to have a label appear on hover perhaps?\r\n6. I feel like the presence and continued development of `rmarkdown` has largely fixed most of the motivating purpose behind `knitrBootstrap`.  Namely there now exists an easy way to get decently styled reports from a knitr markdown document.  I am unsure how much marginal benefit `knitrBootstrap` gives over the standard `rmarkdown` themes.\r\n\r\nI unfortunately don't have much time or motivation to tackle the above issues (which is most of the reason progress has stagnated).  @lcolladotor if you want to try and tackle any of the above I would be more than happy to review the code.\r\n\r\nWhile this may seem like a depressing reply I think this branch is actually very close to completion and would be an improvement in the project, so if you have any interest I would encourage you or anyone else to give it a try!"}}