{"action":"created","issue":{"url":"https://api.github.com/repos/paypal/gatt/issues/33","labels_url":"https://api.github.com/repos/paypal/gatt/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/paypal/gatt/issues/33/comments","events_url":"https://api.github.com/repos/paypal/gatt/issues/33/events","html_url":"https://github.com/paypal/gatt/pull/33","id":70585123,"number":33,"title":"Increasing buffer size on responses channel","user":{"login":"demon-xxi","id":1762346,"avatar_url":"https://avatars.githubusercontent.com/u/1762346?v=3","gravatar_id":"","url":"https://api.github.com/users/demon-xxi","html_url":"https://github.com/demon-xxi","followers_url":"https://api.github.com/users/demon-xxi/followers","following_url":"https://api.github.com/users/demon-xxi/following{/other_user}","gists_url":"https://api.github.com/users/demon-xxi/gists{/gist_id}","starred_url":"https://api.github.com/users/demon-xxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demon-xxi/subscriptions","organizations_url":"https://api.github.com/users/demon-xxi/orgs","repos_url":"https://api.github.com/users/demon-xxi/repos","events_url":"https://api.github.com/users/demon-xxi/events{/privacy}","received_events_url":"https://api.github.com/users/demon-xxi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-24T04:39:44Z","updated_at":"2015-04-24T07:25:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paypal/gatt/pulls/33","html_url":"https://github.com/paypal/gatt/pull/33","diff_url":"https://github.com/paypal/gatt/pull/33.diff","patch_url":"https://github.com/paypal/gatt/pull/33.patch"},"body":"Because of \"Dequeue request loop\" returning message into the channel (req.rspc <- r) this may deadlock if another response has been already pushed by other routine to the channel.  \r\nIt does locks consistently with devices that send a lot of notifications. \r\nAdding extra buffer in channel reserves space for that extra command to be returned."},"comment":{"url":"https://api.github.com/repos/paypal/gatt/issues/comments/95833230","html_url":"https://github.com/paypal/gatt/pull/33#issuecomment-95833230","issue_url":"https://api.github.com/repos/paypal/gatt/issues/33","id":95833230,"user":{"login":"roylee17","id":97372,"avatar_url":"https://avatars.githubusercontent.com/u/97372?v=3","gravatar_id":"","url":"https://api.github.com/users/roylee17","html_url":"https://github.com/roylee17","followers_url":"https://api.github.com/users/roylee17/followers","following_url":"https://api.github.com/users/roylee17/following{/other_user}","gists_url":"https://api.github.com/users/roylee17/gists{/gist_id}","starred_url":"https://api.github.com/users/roylee17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roylee17/subscriptions","organizations_url":"https://api.github.com/users/roylee17/orgs","repos_url":"https://api.github.com/users/roylee17/repos","events_url":"https://api.github.com/users/roylee17/events{/privacy}","received_events_url":"https://api.github.com/users/roylee17/received_events","type":"User","site_admin":false},"created_at":"2015-04-24T07:25:48Z","updated_at":"2015-04-24T07:25:48Z","body":"The \"log\" seems only have the device initialization part, is it truncated? \r\n\r\nAre they \"notifications\" or \"indications\"? \r\nIn case of indications, the early return at https://github.com/paypal/gatt/blob/master/peripheral_linux.go#L373 will be the bug as it prevent the acknowledge from being sent (at the bottom of the loop).  \r\n\r\np.s. I might not be able to get my environment setup to debug until next week. So I need to trouble you to peak and poke around :-)"}}