{"action":"created","comment":{"url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/comments/26381629","id":26381629,"diff_hunk":"@@ -103,27 +104,67 @@\n   gulp.task(\"webdriver_update\", factory.webdriveUpdate());\n \n   // e2e testing\n-  gulp.task(\"html:e2e\", factory.htmlE2E({\n-    files: [\"./src/settings.html\", \"./src/widget.html\", \"./test/html/widget-storage-test.html\"],\n-    e2eUrl: [\"../node_modules/sinon/pkg/sinon.js\", \"../node_modules/sinon/pkg/sinon-server-1.12.2.js\", \"../test/data/url.js\"],\n-    e2eStorage: [\"../node_modules/sinon/pkg/sinon.js\", \"../node_modules/sinon/pkg/sinon-server-1.12.2.js\",\n-      \"../test/data/storage.js\"]\n+  // Settings\n+  gulp.task(\"html:e2e:settings\", factory.htmlE2E({\n+    e2eMockData: \"../test/data/url.js\"\n   }));\n \n-  gulp.task(\"e2e:server\", [\"config\", \"html:e2e\"], factory.testServer());\n+  gulp.task(\"e2e:server:settings\", [\"config\", \"html:e2e:settings\"], factory.testServer());\n \n-  gulp.task(\"test:e2e:settings\", [\"webdriver_update\"], factory.testE2EAngular({\n-      testFiles: \"test/e2e/settings.js\"}\n+  gulp.task(\"test:e2e:settings:run\", [\"webdriver_update\"], factory.testE2EAngular({\n+    testFiles: \"test/e2e/settings.js\"}\n   ));\n \n-  gulp.task(\"test:e2e:widget\", factory.testE2E({\n+  gulp.task(\"test:e2e:settings\", function(cb) {\n+    runSequence([\"e2e:server:settings\"], \"test:e2e:settings:run\", \"e2e:server-close\", cb);\n+  });\n+\n+  // Widget\n+  gulp.task(\"html:e2e:widget:url\", function () {\n+    return gulp.src(\"./src/widget.html\")\n+      .pipe(htmlreplace({\n+        e2egadgets: \"../node_modules/widget-tester/mocks/gadget-mocks.js\",\n+        e2eMockData: [\"../node_modules/sinon/pkg/sinon.js\", \"../node_modules/sinon/pkg/sinon-server-1.12.2.js\",\n+          \"../test/data/url.js\"]\n+      }))\n+      .pipe(rename(function (path) {\n+        path.basename += \"-url-e2e\";\n+      }))\n+      .pipe(gulp.dest(\"./src/\"));\n+  });\n+\n+  gulp.task(\"html:e2e:widget:storage\", function () {\n+    return gulp.src(\"./src/widget.html\")\n+      .pipe(htmlreplace({\n+        e2egadgets: \"../node_modules/widget-tester/mocks/gadget-mocks.js\",\n+        e2eMockData: [\"../node_modules/sinon/pkg/sinon.js\", \"../node_modules/sinon/pkg/sinon-server-1.12.2.js\",","path":"gulpfile.js","position":57,"original_position":57,"commit_id":"956ba4c1e394050c58099b4b2ed01d53b02ebb99","original_commit_id":"956ba4c1e394050c58099b4b2ed01d53b02ebb99","user":{"login":"donnapep","id":1190420,"avatar_url":"https://avatars.githubusercontent.com/u/1190420?v=3","gravatar_id":"","url":"https://api.github.com/users/donnapep","html_url":"https://github.com/donnapep","followers_url":"https://api.github.com/users/donnapep/followers","following_url":"https://api.github.com/users/donnapep/following{/other_user}","gists_url":"https://api.github.com/users/donnapep/gists{/gist_id}","starred_url":"https://api.github.com/users/donnapep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnapep/subscriptions","organizations_url":"https://api.github.com/users/donnapep/orgs","repos_url":"https://api.github.com/users/donnapep/repos","events_url":"https://api.github.com/users/donnapep/events{/privacy}","received_events_url":"https://api.github.com/users/donnapep/received_events","type":"User","site_admin":false},"body":"@stulees Yup, I discovered it awhile back when I did some playing with the gulp test tasks. Comes in handy.","created_at":"2015-03-13T12:30:57Z","updated_at":"2015-03-13T12:30:57Z","html_url":"https://github.com/Rise-Vision/widget-image/pull/10#discussion_r26381629","pull_request_url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/comments/26381629"},"html":{"href":"https://github.com/Rise-Vision/widget-image/pull/10#discussion_r26381629"},"pull_request":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10","id":31075225,"html_url":"https://github.com/Rise-Vision/widget-image/pull/10","diff_url":"https://github.com/Rise-Vision/widget-image/pull/10.diff","patch_url":"https://github.com/Rise-Vision/widget-image/pull/10.patch","issue_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues/10","number":10,"state":"open","locked":false,"title":"Chore/refresh from storage","user":{"login":"donnapep","id":1190420,"avatar_url":"https://avatars.githubusercontent.com/u/1190420?v=3","gravatar_id":"","url":"https://api.github.com/users/donnapep","html_url":"https://github.com/donnapep","followers_url":"https://api.github.com/users/donnapep/followers","following_url":"https://api.github.com/users/donnapep/following{/other_user}","gists_url":"https://api.github.com/users/donnapep/gists{/gist_id}","starred_url":"https://api.github.com/users/donnapep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnapep/subscriptions","organizations_url":"https://api.github.com/users/donnapep/orgs","repos_url":"https://api.github.com/users/donnapep/repos","events_url":"https://api.github.com/users/donnapep/events{/privacy}","received_events_url":"https://api.github.com/users/donnapep/received_events","type":"User","site_admin":false},"body":"* Add the ability for Storage images to refresh every 15 minutes.\r\n* Update the test structure so that it is similar to the Video Widget.\r\n* Sometimes the call to `storage.go()` fails, and that's because the web component hasn't initialized yet. Add a `polymer-ready` event handler to tell when the component has been registered.\r\n* Update the tests to manually fire the `polymer-ready` event since otherwise it will never trigger.\r\n* Use `rise-storage-mock` to ensure the Storage image has loaded.","created_at":"2015-03-12T20:37:57Z","updated_at":"2015-03-13T12:30:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29a0bbd4e79129856e551072bb9c2c803eb2472f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues/10/comments","statuses_url":"https://api.github.com/repos/Rise-Vision/widget-image/statuses/956ba4c1e394050c58099b4b2ed01d53b02ebb99","head":{"label":"Rise-Vision:chore/refresh-from-storage","ref":"chore/refresh-from-storage","sha":"956ba4c1e394050c58099b4b2ed01d53b02ebb99","user":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":27281315,"name":"widget-image","full_name":"Rise-Vision/widget-image","owner":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rise-Vision/widget-image","description":"Image Widget","fork":false,"url":"https://api.github.com/repos/Rise-Vision/widget-image","forks_url":"https://api.github.com/repos/Rise-Vision/widget-image/forks","keys_url":"https://api.github.com/repos/Rise-Vision/widget-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/widget-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/widget-image/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/widget-image/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/widget-image/events","assignees_url":"https://api.github.com/repos/Rise-Vision/widget-image/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/widget-image/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/widget-image/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/widget-image/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/widget-image/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/widget-image/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/widget-image/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/widget-image/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/widget-image/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/widget-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/widget-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/widget-image/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/widget-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/widget-image/merges","archive_url":"https://api.github.com/repos/Rise-Vision/widget-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/widget-image/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/widget-image/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/widget-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/widget-image/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/widget-image/releases{/id}","created_at":"2014-11-28T20:33:06Z","updated_at":"2015-03-06T14:18:49Z","pushed_at":"2015-03-12T20:38:36Z","git_url":"git://github.com/Rise-Vision/widget-image.git","ssh_url":"git@github.com:Rise-Vision/widget-image.git","clone_url":"https://github.com/Rise-Vision/widget-image.git","svn_url":"https://github.com/Rise-Vision/widget-image","homepage":null,"size":2828,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Rise-Vision:master","ref":"master","sha":"1ae8bde76569ea3262a4ca498d3b2a3ec9d586b6","user":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":27281315,"name":"widget-image","full_name":"Rise-Vision/widget-image","owner":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rise-Vision/widget-image","description":"Image Widget","fork":false,"url":"https://api.github.com/repos/Rise-Vision/widget-image","forks_url":"https://api.github.com/repos/Rise-Vision/widget-image/forks","keys_url":"https://api.github.com/repos/Rise-Vision/widget-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/widget-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/widget-image/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/widget-image/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/widget-image/events","assignees_url":"https://api.github.com/repos/Rise-Vision/widget-image/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/widget-image/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/widget-image/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/widget-image/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/widget-image/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/widget-image/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/widget-image/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/widget-image/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/widget-image/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/widget-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/widget-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/widget-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/widget-image/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/widget-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/widget-image/merges","archive_url":"https://api.github.com/repos/Rise-Vision/widget-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/widget-image/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/widget-image/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/widget-image/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/widget-image/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/widget-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/widget-image/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/widget-image/releases{/id}","created_at":"2014-11-28T20:33:06Z","updated_at":"2015-03-06T14:18:49Z","pushed_at":"2015-03-12T20:38:36Z","git_url":"git://github.com/Rise-Vision/widget-image.git","ssh_url":"git@github.com:Rise-Vision/widget-image.git","clone_url":"https://github.com/Rise-Vision/widget-image.git","svn_url":"https://github.com/Rise-Vision/widget-image","homepage":null,"size":2828,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10"},"html":{"href":"https://github.com/Rise-Vision/widget-image/pull/10"},"issue":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/issues/10"},"comments":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Rise-Vision/widget-image/statuses/956ba4c1e394050c58099b4b2ed01d53b02ebb99"}}}}