{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/redding/qs/pulls/41","id":26832937,"html_url":"https://github.com/redding/qs/pull/41","diff_url":"https://github.com/redding/qs/pull/41.diff","patch_url":"https://github.com/redding/qs/pull/41.patch","issue_url":"https://api.github.com/repos/redding/qs/issues/41","number":41,"state":"closed","locked":false,"title":"Properly create/close IO pipes on start/shutdown","user":{"login":"jcredding","id":85966,"avatar_url":"https://avatars.githubusercontent.com/u/85966?v=3","gravatar_id":"","url":"https://api.github.com/users/jcredding","html_url":"https://github.com/jcredding","followers_url":"https://api.github.com/users/jcredding/followers","following_url":"https://api.github.com/users/jcredding/following{/other_user}","gists_url":"https://api.github.com/users/jcredding/gists{/gist_id}","starred_url":"https://api.github.com/users/jcredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcredding/subscriptions","organizations_url":"https://api.github.com/users/jcredding/orgs","repos_url":"https://api.github.com/users/jcredding/repos","events_url":"https://api.github.com/users/jcredding/events{/privacy}","received_events_url":"https://api.github.com/users/jcredding/received_events","type":"User","site_admin":false},"body":"This updates the `Daemon` to properly handle its IO pipes for\r\nsignalling when a worker is available or a queue is empty. The test\r\nsuite was randomly failing because the process opened too many files\r\n(IO pipes) and didn't close them. This fixes the issue by wrapping\r\nthe IOs in an internal class, `IOPipe`. `IOPipe` has a `setup`\r\nand `teardown` method which will build the IOs and close them. This\r\nis then called when a daemon is started and stopped. This error only\r\nshowed up in the test suite because it built many daemon instances.\r\nIn a typical scenario, you would only run a single daemon instance\r\nfor a process so this error wouldn't occur.\r\n\r\n@kellyredding - Ready for review.","created_at":"2015-01-05T16:14:43Z","updated_at":"2015-01-05T19:30:18Z","closed_at":"2015-01-05T19:30:18Z","merged_at":"2015-01-05T19:30:18Z","merge_commit_sha":"1ec207836d329ac20fdc53aa7041e03ed3df1e4c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redding/qs/pulls/41/commits","review_comments_url":"https://api.github.com/repos/redding/qs/pulls/41/comments","review_comment_url":"https://api.github.com/repos/redding/qs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/redding/qs/issues/41/comments","statuses_url":"https://api.github.com/repos/redding/qs/statuses/cadbf594127c874918fb74a3b9c3f4bfdc88f745","head":{"label":"redding:jcr-reset-io-pipes","ref":"jcr-reset-io-pipes","sha":"cadbf594127c874918fb74a3b9c3f4bfdc88f745","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":8260201,"name":"qs","full_name":"redding/qs","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/qs","description":"Setup message queues. Run jobs and events. Profit.","fork":false,"url":"https://api.github.com/repos/redding/qs","forks_url":"https://api.github.com/repos/redding/qs/forks","keys_url":"https://api.github.com/repos/redding/qs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/qs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/qs/teams","hooks_url":"https://api.github.com/repos/redding/qs/hooks","issue_events_url":"https://api.github.com/repos/redding/qs/issues/events{/number}","events_url":"https://api.github.com/repos/redding/qs/events","assignees_url":"https://api.github.com/repos/redding/qs/assignees{/user}","branches_url":"https://api.github.com/repos/redding/qs/branches{/branch}","tags_url":"https://api.github.com/repos/redding/qs/tags","blobs_url":"https://api.github.com/repos/redding/qs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/qs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/qs/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/qs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/qs/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/qs/languages","stargazers_url":"https://api.github.com/repos/redding/qs/stargazers","contributors_url":"https://api.github.com/repos/redding/qs/contributors","subscribers_url":"https://api.github.com/repos/redding/qs/subscribers","subscription_url":"https://api.github.com/repos/redding/qs/subscription","commits_url":"https://api.github.com/repos/redding/qs/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/qs/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/qs/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/qs/issues/comments/{number}","contents_url":"https://api.github.com/repos/redding/qs/contents/{+path}","compare_url":"https://api.github.com/repos/redding/qs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/qs/merges","archive_url":"https://api.github.com/repos/redding/qs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/qs/downloads","issues_url":"https://api.github.com/repos/redding/qs/issues{/number}","pulls_url":"https://api.github.com/repos/redding/qs/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/qs/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/qs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/qs/labels{/name}","releases_url":"https://api.github.com/repos/redding/qs/releases{/id}","created_at":"2013-02-18T02:20:31Z","updated_at":"2015-01-05T16:04:09Z","pushed_at":"2015-01-05T19:30:18Z","git_url":"git://github.com/redding/qs.git","ssh_url":"git@github.com:redding/qs.git","clone_url":"https://github.com/redding/qs.git","svn_url":"https://github.com/redding/qs","homepage":null,"size":1720,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"redding:master","ref":"master","sha":"ba73714136858a17214319b08452219d9a7bdb07","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":8260201,"name":"qs","full_name":"redding/qs","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/qs","description":"Setup message queues. Run jobs and events. Profit.","fork":false,"url":"https://api.github.com/repos/redding/qs","forks_url":"https://api.github.com/repos/redding/qs/forks","keys_url":"https://api.github.com/repos/redding/qs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/qs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/qs/teams","hooks_url":"https://api.github.com/repos/redding/qs/hooks","issue_events_url":"https://api.github.com/repos/redding/qs/issues/events{/number}","events_url":"https://api.github.com/repos/redding/qs/events","assignees_url":"https://api.github.com/repos/redding/qs/assignees{/user}","branches_url":"https://api.github.com/repos/redding/qs/branches{/branch}","tags_url":"https://api.github.com/repos/redding/qs/tags","blobs_url":"https://api.github.com/repos/redding/qs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/qs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/qs/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/qs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/qs/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/qs/languages","stargazers_url":"https://api.github.com/repos/redding/qs/stargazers","contributors_url":"https://api.github.com/repos/redding/qs/contributors","subscribers_url":"https://api.github.com/repos/redding/qs/subscribers","subscription_url":"https://api.github.com/repos/redding/qs/subscription","commits_url":"https://api.github.com/repos/redding/qs/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/qs/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/qs/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/qs/issues/comments/{number}","contents_url":"https://api.github.com/repos/redding/qs/contents/{+path}","compare_url":"https://api.github.com/repos/redding/qs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/qs/merges","archive_url":"https://api.github.com/repos/redding/qs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/qs/downloads","issues_url":"https://api.github.com/repos/redding/qs/issues{/number}","pulls_url":"https://api.github.com/repos/redding/qs/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/qs/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/qs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/qs/labels{/name}","releases_url":"https://api.github.com/repos/redding/qs/releases{/id}","created_at":"2013-02-18T02:20:31Z","updated_at":"2015-01-05T16:04:09Z","pushed_at":"2015-01-05T19:30:18Z","git_url":"git://github.com/redding/qs.git","ssh_url":"git@github.com:redding/qs.git","clone_url":"https://github.com/redding/qs.git","svn_url":"https://github.com/redding/qs","homepage":null,"size":1720,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redding/qs/pulls/41"},"html":{"href":"https://github.com/redding/qs/pull/41"},"issue":{"href":"https://api.github.com/repos/redding/qs/issues/41"},"comments":{"href":"https://api.github.com/repos/redding/qs/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/redding/qs/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/redding/qs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/redding/qs/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/redding/qs/statuses/cadbf594127c874918fb74a3b9c3f4bfdc88f745"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jcredding","id":85966,"avatar_url":"https://avatars.githubusercontent.com/u/85966?v=3","gravatar_id":"","url":"https://api.github.com/users/jcredding","html_url":"https://github.com/jcredding","followers_url":"https://api.github.com/users/jcredding/followers","following_url":"https://api.github.com/users/jcredding/following{/other_user}","gists_url":"https://api.github.com/users/jcredding/gists{/gist_id}","starred_url":"https://api.github.com/users/jcredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcredding/subscriptions","organizations_url":"https://api.github.com/users/jcredding/orgs","repos_url":"https://api.github.com/users/jcredding/repos","events_url":"https://api.github.com/users/jcredding/events{/privacy}","received_events_url":"https://api.github.com/users/jcredding/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":97,"deletions":12,"changed_files":2}}