{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/46764046","id":46764046,"diff_hunk":"@@ -89,8 +89,6 @@ object Play {\n       // Ensure routes are eagerly loaded, so that the reverse routers are\n       // correctly initialised before plugins are started.\n       app.routes","path":"framework/src/play/src/main/scala/play/api/Play.scala","position":9,"original_position":3,"commit_id":"cc265b59b6eb115e5b90464274481e9ec9a7c26d","original_commit_id":"57bd81c855f4c925f5f6196e141aecbf31c0c9cd","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"body":"I'd rather remove routes in a seperate PR...","created_at":"2015-12-05T22:37:50Z","updated_at":"2015-12-05T22:37:50Z","html_url":"https://github.com/playframework/playframework/pull/5339#discussion_r46764046","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/5339","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/46764046"},"html":{"href":"https://github.com/playframework/playframework/pull/5339#discussion_r46764046"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5339"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5339","id":52631711,"html_url":"https://github.com/playframework/playframework/pull/5339","diff_url":"https://github.com/playframework/playframework/pull/5339.diff","patch_url":"https://github.com/playframework/playframework/pull/5339.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5339","number":5339,"state":"open","locked":false,"title":"Remove play.api.Plugin etc.","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"body":"Remove play.api.Plugin.  \r\n\r\nBecause GlobalSettings depends on a Plugin, there's also some work to directly address GlobalSettings as an application dependency.  GlobalSettings was not previously deprecated, so that is also done here, and a GlobalSettings.Deprecated type is added so that deprecation warnings can be avoided on an internal Play build.\r\n\r\nAlso removed a couple of `@Deprecated` global methods while I was at it. ","created_at":"2015-12-04T05:33:47Z","updated_at":"2015-12-05T22:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11038c5a2a33f913d23a360716218293cae0d21f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/5339/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/5339/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5339/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/cc265b59b6eb115e5b90464274481e9ec9a7c26d","head":{"label":"wsargent:remove-plugins","ref":"remove-plugins","sha":"cc265b59b6eb115e5b90464274481e9ec9a7c26d","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"repo":{"id":11010009,"name":"playframework","full_name":"wsargent/playframework","owner":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wsargent/playframework","description":"Play framework 2.x","fork":true,"url":"https://api.github.com/repos/wsargent/playframework","forks_url":"https://api.github.com/repos/wsargent/playframework/forks","keys_url":"https://api.github.com/repos/wsargent/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsargent/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsargent/playframework/teams","hooks_url":"https://api.github.com/repos/wsargent/playframework/hooks","issue_events_url":"https://api.github.com/repos/wsargent/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/wsargent/playframework/events","assignees_url":"https://api.github.com/repos/wsargent/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/wsargent/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/wsargent/playframework/tags","blobs_url":"https://api.github.com/repos/wsargent/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsargent/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsargent/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsargent/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsargent/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/wsargent/playframework/languages","stargazers_url":"https://api.github.com/repos/wsargent/playframework/stargazers","contributors_url":"https://api.github.com/repos/wsargent/playframework/contributors","subscribers_url":"https://api.github.com/repos/wsargent/playframework/subscribers","subscription_url":"https://api.github.com/repos/wsargent/playframework/subscription","commits_url":"https://api.github.com/repos/wsargent/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsargent/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsargent/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsargent/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wsargent/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/wsargent/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsargent/playframework/merges","archive_url":"https://api.github.com/repos/wsargent/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsargent/playframework/downloads","issues_url":"https://api.github.com/repos/wsargent/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/wsargent/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/wsargent/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/wsargent/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsargent/playframework/labels{/name}","releases_url":"https://api.github.com/repos/wsargent/playframework/releases{/id}","created_at":"2013-06-27T22:58:23Z","updated_at":"2015-04-15T18:06:45Z","pushed_at":"2015-12-05T22:35:02Z","git_url":"git://github.com/wsargent/playframework.git","ssh_url":"git@github.com:wsargent/playframework.git","clone_url":"https://github.com/wsargent/playframework.git","svn_url":"https://github.com/wsargent/playframework","homepage":"http://www.playframework.org/","size":77651,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"d4e984d528fdb10db9b36fc32b8583b6c2dd5a5f","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-12-05T21:37:45Z","pushed_at":"2015-12-05T22:35:06Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":83771,"stargazers_count":7139,"watchers_count":7139,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2525,"mirror_url":null,"open_issues_count":319,"forks":2525,"open_issues":319,"watchers":7139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5339"},"html":{"href":"https://github.com/playframework/playframework/pull/5339"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/5339"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/5339/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5339/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5339/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/cc265b59b6eb115e5b90464274481e9ec9a7c26d"}}}}