{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/5684","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5684/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5684/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5684/events","html_url":"https://github.com/mozilla/pdf.js/pull/5684","id":55815305,"number":5684,"title":"Make sure that an A entry in an annotation dictionary is also a dictionary itself","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-annotations","name":"4-annotations","color":"DDDDDD"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-28T21:05:34Z","updated_at":"2015-01-29T12:30:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5684","html_url":"https://github.com/mozilla/pdf.js/pull/5684","diff_url":"https://github.com/mozilla/pdf.js/pull/5684.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/5684.patch"},"body":"Fixes #5683.\r\n\r\nAccording to https://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_reference_1-7.pdf#page=647&zoom=auto,-246,56 an `A` entry in an annotation dictionary *must* also be a dictionary itself. The current code just assumes that, but some (corrupted) PDFs violate that standard. This patch makes sure to check that the `A` entry is actually a dictionary before trying to get properties from it (on https://github.com/mozilla/pdf.js/blob/master/src/core/annotation.js#L489 which assumes we are dealing with a valid dictionary)."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/72016563","html_url":"https://github.com/mozilla/pdf.js/pull/5684#issuecomment-72016563","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5684","id":72016563,"user":{"login":"pdfjsbot","id":1036361,"avatar_url":"https://avatars.githubusercontent.com/u/1036361?v=3","gravatar_id":"","url":"https://api.github.com/users/pdfjsbot","html_url":"https://github.com/pdfjsbot","followers_url":"https://api.github.com/users/pdfjsbot/followers","following_url":"https://api.github.com/users/pdfjsbot/following{/other_user}","gists_url":"https://api.github.com/users/pdfjsbot/gists{/gist_id}","starred_url":"https://api.github.com/users/pdfjsbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdfjsbot/subscriptions","organizations_url":"https://api.github.com/users/pdfjsbot/orgs","repos_url":"https://api.github.com/users/pdfjsbot/repos","events_url":"https://api.github.com/users/pdfjsbot/events{/privacy}","received_events_url":"https://api.github.com/users/pdfjsbot/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T12:30:03Z","updated_at":"2015-01-29T12:30:03Z","body":"#### From: Bot.io (Windows)\n\n----\n\n# Failed\n\nFull output at http://107.22.172.223:8877/c6fa37413ccf83d/output.txt\n\nTotal script time: 2.88 mins\n\n+ **Font tests:** FAILED\n+ **Unit tests:** Passed\n+ **Regression tests:** FAILED\n\nImage differences available at: http://107.22.172.223:8877/c6fa37413ccf83d/reftest-analyzer.html#web=eq.log"}}