{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/30402392","id":30402392,"diff_hunk":"@@ -121,6 +121,8 @@ EthashAux::LightType EthashAux::light(uint64_t _blockNumber)\n EthashAux::LightAllocation::LightAllocation(uint64_t _blockNumber)\n {\n \tlight = ethash_light_new(_blockNumber);\n+    if (!light)","path":"libethcore/EthashAux.cpp","position":4,"original_position":4,"commit_id":"e20a762ce7511b8f3d62290d41ccc2772997fbeb","original_commit_id":"e20a762ce7511b8f3d62290d41ccc2772997fbeb","user":{"login":"CJentzsch","id":8452011,"avatar_url":"https://avatars.githubusercontent.com/u/8452011?v=3","gravatar_id":"","url":"https://api.github.com/users/CJentzsch","html_url":"https://github.com/CJentzsch","followers_url":"https://api.github.com/users/CJentzsch/followers","following_url":"https://api.github.com/users/CJentzsch/following{/other_user}","gists_url":"https://api.github.com/users/CJentzsch/gists{/gist_id}","starred_url":"https://api.github.com/users/CJentzsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJentzsch/subscriptions","organizations_url":"https://api.github.com/users/CJentzsch/orgs","repos_url":"https://api.github.com/users/CJentzsch/repos","events_url":"https://api.github.com/users/CJentzsch/events{/privacy}","received_events_url":"https://api.github.com/users/CJentzsch/received_events","type":"User","site_admin":false},"body":"indentation is wrong","created_at":"2015-05-15T11:42:52Z","updated_at":"2015-05-15T11:42:52Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1920#discussion_r30402392","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/30402392"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1920#discussion_r30402392"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920","id":35491582,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1920","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1920.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1920.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1920","number":1920,"state":"open","locked":false,"title":"Throw if ethash_XXX_new() fails","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"It would still be really good if we could get more information for what error occured in the `ethash_full_new()` case. ","created_at":"2015-05-15T07:50:55Z","updated_at":"2015-05-15T11:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b02bdd1303207ed8c84fba562b560f3a670c6d27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1920/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/e20a762ce7511b8f3d62290d41ccc2772997fbeb","head":{"label":"LefterisJP:exception_at_ethash_failures","ref":"exception_at_ethash_failures","sha":"e20a762ce7511b8f3d62290d41ccc2772997fbeb","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"repo":{"id":25381518,"name":"cpp-ethereum","full_name":"LefterisJP/cpp-ethereum","owner":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LefterisJP/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/LefterisJP/cpp-ethereum","forks_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/releases{/id}","created_at":"2014-10-17T23:43:38Z","updated_at":"2015-05-08T15:33:49Z","pushed_at":"2015-05-15T11:29:13Z","git_url":"git://github.com/LefterisJP/cpp-ethereum.git","ssh_url":"git@github.com:LefterisJP/cpp-ethereum.git","clone_url":"https://github.com/LefterisJP/cpp-ethereum.git","svn_url":"https://github.com/LefterisJP/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":24328,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"db7b5484f2edc067d0ddb2f9be8413ddc612bf30","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-05-15T07:29:28Z","pushed_at":"2015-05-15T11:30:30Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":99360,"stargazers_count":467,"watchers_count":467,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":163,"forks":165,"open_issues":163,"watchers":467,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1920"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1920"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1920/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1920/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/e20a762ce7511b8f3d62290d41ccc2772997fbeb"}}}}