{"action":"created","issue":{"url":"https://api.github.com/repos/libpnet/libpnet/issues/56","labels_url":"https://api.github.com/repos/libpnet/libpnet/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/libpnet/libpnet/issues/56/comments","events_url":"https://api.github.com/repos/libpnet/libpnet/issues/56/events","html_url":"https://github.com/libpnet/libpnet/pull/56","id":64400959,"number":56,"title":"Fixing bug in `get_network_interfaces_impl` interface merging.","user":{"login":"lukeasrodgers","id":816444,"avatar_url":"https://avatars.githubusercontent.com/u/816444?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeasrodgers","html_url":"https://github.com/lukeasrodgers","followers_url":"https://api.github.com/users/lukeasrodgers/followers","following_url":"https://api.github.com/users/lukeasrodgers/following{/other_user}","gists_url":"https://api.github.com/users/lukeasrodgers/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeasrodgers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeasrodgers/subscriptions","organizations_url":"https://api.github.com/users/lukeasrodgers/orgs","repos_url":"https://api.github.com/users/lukeasrodgers/repos","events_url":"https://api.github.com/users/lukeasrodgers/events{/privacy}","received_events_url":"https://api.github.com/users/lukeasrodgers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-26T00:11:43Z","updated_at":"2015-05-20T19:34:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libpnet/libpnet/pulls/56","html_url":"https://github.com/libpnet/libpnet/pull/56","diff_url":"https://github.com/libpnet/libpnet/pull/56.diff","patch_url":"https://github.com/libpnet/libpnet/pull/56.patch"},"body":"If we found an interface, but it had no IPs, subsequent interfaces of the same name with IPs would not be merged into the interface struct.\r\n\r\nAdds a test for non-linux platforms, following the example of the `check_test_environment` test.\r\n\r\n@mrmonday let me know if you'd like an additional test for alternate scenarios (e.g. in which no IP addresses should be found for a given interface). Not sure exactly how I'd implement that yet, might require some refactoring of `get_network_interfaces_impl` but I could give it a shot. Also not sure how this change will fare on non-OSX platforms.\r\n\r\nFixes #55"},"comment":{"url":"https://api.github.com/repos/libpnet/libpnet/issues/comments/104008132","html_url":"https://github.com/libpnet/libpnet/pull/56#issuecomment-104008132","issue_url":"https://api.github.com/repos/libpnet/libpnet/issues/56","id":104008132,"user":{"login":"mrmonday","id":165689,"avatar_url":"https://avatars.githubusercontent.com/u/165689?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmonday","html_url":"https://github.com/mrmonday","followers_url":"https://api.github.com/users/mrmonday/followers","following_url":"https://api.github.com/users/mrmonday/following{/other_user}","gists_url":"https://api.github.com/users/mrmonday/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmonday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmonday/subscriptions","organizations_url":"https://api.github.com/users/mrmonday/orgs","repos_url":"https://api.github.com/users/mrmonday/repos","events_url":"https://api.github.com/users/mrmonday/events{/privacy}","received_events_url":"https://api.github.com/users/mrmonday/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T19:34:28Z","updated_at":"2015-05-20T19:34:28Z","body":"I'm sorry to hear that. I'll try and get this cleaned up merged when I can."}}