{"action":"closed","number":352,"pull_request":{"url":"https://api.github.com/repos/biojava/biojava/pulls/352","id":51531184,"html_url":"https://github.com/biojava/biojava/pull/352","diff_url":"https://github.com/biojava/biojava/pull/352.diff","patch_url":"https://github.com/biojava/biojava/pull/352.patch","issue_url":"https://api.github.com/repos/biojava/biojava/issues/352","number":352,"state":"closed","locked":false,"title":"Include jgrapht dependency to biojava-structure","user":{"login":"lafita","id":11161522,"avatar_url":"https://avatars.githubusercontent.com/u/11161522?v=3","gravatar_id":"","url":"https://api.github.com/users/lafita","html_url":"https://github.com/lafita","followers_url":"https://api.github.com/users/lafita/followers","following_url":"https://api.github.com/users/lafita/following{/other_user}","gists_url":"https://api.github.com/users/lafita/gists{/gist_id}","starred_url":"https://api.github.com/users/lafita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafita/subscriptions","organizations_url":"https://api.github.com/users/lafita/orgs","repos_url":"https://api.github.com/users/lafita/repos","events_url":"https://api.github.com/users/lafita/events{/privacy}","received_events_url":"https://api.github.com/users/lafita/received_events","type":"User","site_admin":false},"body":"As it was discussed in #299, the **BioJava** implementations and algorithms for **Graphs** have been replaced by an external library: [jgrapht](http://jgrapht.org). \r\n\r\nThe only code replaced is related to the **Quaternary Symmetry** detection. Tests pass and demos work as before, but @pwrose might want to take a look and check that the changes are conceptually correct. \r\n\r\nAs a summary, the **ComponentFinder** was checking if a **SubunitGraph** had more than one connected component. This is now done by using the **ConnectivityInspector** from jgrapht, that returns true if the graph is connected (one component) or not (more than one component). The constructor of the **SubunitGraph** is the same, and also the construction of a **SubGraph** given a set of vertices.\r\n\r\nMerging this closes issue #319.","created_at":"2015-11-23T14:43:40Z","updated_at":"2015-11-27T02:43:09Z","closed_at":"2015-11-27T02:43:09Z","merged_at":"2015-11-27T02:43:09Z","merge_commit_sha":"0fbb9884b76d4df115df980740a2de4dfd153646","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biojava/biojava/pulls/352/commits","review_comments_url":"https://api.github.com/repos/biojava/biojava/pulls/352/comments","review_comment_url":"https://api.github.com/repos/biojava/biojava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biojava/biojava/issues/352/comments","statuses_url":"https://api.github.com/repos/biojava/biojava/statuses/a9eecede2b572c6389f135eff032537d1bfd6c9d","head":{"label":"lafita:graph","ref":"graph","sha":"a9eecede2b572c6389f135eff032537d1bfd6c9d","user":{"login":"lafita","id":11161522,"avatar_url":"https://avatars.githubusercontent.com/u/11161522?v=3","gravatar_id":"","url":"https://api.github.com/users/lafita","html_url":"https://github.com/lafita","followers_url":"https://api.github.com/users/lafita/followers","following_url":"https://api.github.com/users/lafita/following{/other_user}","gists_url":"https://api.github.com/users/lafita/gists{/gist_id}","starred_url":"https://api.github.com/users/lafita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafita/subscriptions","organizations_url":"https://api.github.com/users/lafita/orgs","repos_url":"https://api.github.com/users/lafita/repos","events_url":"https://api.github.com/users/lafita/events{/privacy}","received_events_url":"https://api.github.com/users/lafita/received_events","type":"User","site_admin":false},"repo":{"id":31761416,"name":"biojava","full_name":"lafita/biojava","owner":{"login":"lafita","id":11161522,"avatar_url":"https://avatars.githubusercontent.com/u/11161522?v=3","gravatar_id":"","url":"https://api.github.com/users/lafita","html_url":"https://github.com/lafita","followers_url":"https://api.github.com/users/lafita/followers","following_url":"https://api.github.com/users/lafita/following{/other_user}","gists_url":"https://api.github.com/users/lafita/gists{/gist_id}","starred_url":"https://api.github.com/users/lafita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafita/subscriptions","organizations_url":"https://api.github.com/users/lafita/orgs","repos_url":"https://api.github.com/users/lafita/repos","events_url":"https://api.github.com/users/lafita/events{/privacy}","received_events_url":"https://api.github.com/users/lafita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lafita/biojava","description":"BioJava is an open-source project dedicated to providing a Java framework for processing biological data.","fork":true,"url":"https://api.github.com/repos/lafita/biojava","forks_url":"https://api.github.com/repos/lafita/biojava/forks","keys_url":"https://api.github.com/repos/lafita/biojava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lafita/biojava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lafita/biojava/teams","hooks_url":"https://api.github.com/repos/lafita/biojava/hooks","issue_events_url":"https://api.github.com/repos/lafita/biojava/issues/events{/number}","events_url":"https://api.github.com/repos/lafita/biojava/events","assignees_url":"https://api.github.com/repos/lafita/biojava/assignees{/user}","branches_url":"https://api.github.com/repos/lafita/biojava/branches{/branch}","tags_url":"https://api.github.com/repos/lafita/biojava/tags","blobs_url":"https://api.github.com/repos/lafita/biojava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lafita/biojava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lafita/biojava/git/refs{/sha}","trees_url":"https://api.github.com/repos/lafita/biojava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lafita/biojava/statuses/{sha}","languages_url":"https://api.github.com/repos/lafita/biojava/languages","stargazers_url":"https://api.github.com/repos/lafita/biojava/stargazers","contributors_url":"https://api.github.com/repos/lafita/biojava/contributors","subscribers_url":"https://api.github.com/repos/lafita/biojava/subscribers","subscription_url":"https://api.github.com/repos/lafita/biojava/subscription","commits_url":"https://api.github.com/repos/lafita/biojava/commits{/sha}","git_commits_url":"https://api.github.com/repos/lafita/biojava/git/commits{/sha}","comments_url":"https://api.github.com/repos/lafita/biojava/comments{/number}","issue_comment_url":"https://api.github.com/repos/lafita/biojava/issues/comments{/number}","contents_url":"https://api.github.com/repos/lafita/biojava/contents/{+path}","compare_url":"https://api.github.com/repos/lafita/biojava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lafita/biojava/merges","archive_url":"https://api.github.com/repos/lafita/biojava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lafita/biojava/downloads","issues_url":"https://api.github.com/repos/lafita/biojava/issues{/number}","pulls_url":"https://api.github.com/repos/lafita/biojava/pulls{/number}","milestones_url":"https://api.github.com/repos/lafita/biojava/milestones{/number}","notifications_url":"https://api.github.com/repos/lafita/biojava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lafita/biojava/labels{/name}","releases_url":"https://api.github.com/repos/lafita/biojava/releases{/id}","created_at":"2015-03-06T09:12:41Z","updated_at":"2015-03-06T09:12:49Z","pushed_at":"2015-11-26T19:08:51Z","git_url":"git://github.com/lafita/biojava.git","ssh_url":"git@github.com:lafita/biojava.git","clone_url":"https://github.com/lafita/biojava.git","svn_url":"https://github.com/lafita/biojava","homepage":"http://biojava.org","size":37942,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biojava:master","ref":"master","sha":"4045e7a1e1a82952a49efd95028d94029a74214c","user":{"login":"biojava","id":237402,"avatar_url":"https://avatars.githubusercontent.com/u/237402?v=3","gravatar_id":"","url":"https://api.github.com/users/biojava","html_url":"https://github.com/biojava","followers_url":"https://api.github.com/users/biojava/followers","following_url":"https://api.github.com/users/biojava/following{/other_user}","gists_url":"https://api.github.com/users/biojava/gists{/gist_id}","starred_url":"https://api.github.com/users/biojava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biojava/subscriptions","organizations_url":"https://api.github.com/users/biojava/orgs","repos_url":"https://api.github.com/users/biojava/repos","events_url":"https://api.github.com/users/biojava/events{/privacy}","received_events_url":"https://api.github.com/users/biojava/received_events","type":"Organization","site_admin":false},"repo":{"id":9199359,"name":"biojava","full_name":"biojava/biojava","owner":{"login":"biojava","id":237402,"avatar_url":"https://avatars.githubusercontent.com/u/237402?v=3","gravatar_id":"","url":"https://api.github.com/users/biojava","html_url":"https://github.com/biojava","followers_url":"https://api.github.com/users/biojava/followers","following_url":"https://api.github.com/users/biojava/following{/other_user}","gists_url":"https://api.github.com/users/biojava/gists{/gist_id}","starred_url":"https://api.github.com/users/biojava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biojava/subscriptions","organizations_url":"https://api.github.com/users/biojava/orgs","repos_url":"https://api.github.com/users/biojava/repos","events_url":"https://api.github.com/users/biojava/events{/privacy}","received_events_url":"https://api.github.com/users/biojava/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biojava/biojava","description":":book::microscope::coffee: BioJava is an open-source project dedicated to providing a Java framework for processing biological data.","fork":false,"url":"https://api.github.com/repos/biojava/biojava","forks_url":"https://api.github.com/repos/biojava/biojava/forks","keys_url":"https://api.github.com/repos/biojava/biojava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biojava/biojava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biojava/biojava/teams","hooks_url":"https://api.github.com/repos/biojava/biojava/hooks","issue_events_url":"https://api.github.com/repos/biojava/biojava/issues/events{/number}","events_url":"https://api.github.com/repos/biojava/biojava/events","assignees_url":"https://api.github.com/repos/biojava/biojava/assignees{/user}","branches_url":"https://api.github.com/repos/biojava/biojava/branches{/branch}","tags_url":"https://api.github.com/repos/biojava/biojava/tags","blobs_url":"https://api.github.com/repos/biojava/biojava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biojava/biojava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biojava/biojava/git/refs{/sha}","trees_url":"https://api.github.com/repos/biojava/biojava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biojava/biojava/statuses/{sha}","languages_url":"https://api.github.com/repos/biojava/biojava/languages","stargazers_url":"https://api.github.com/repos/biojava/biojava/stargazers","contributors_url":"https://api.github.com/repos/biojava/biojava/contributors","subscribers_url":"https://api.github.com/repos/biojava/biojava/subscribers","subscription_url":"https://api.github.com/repos/biojava/biojava/subscription","commits_url":"https://api.github.com/repos/biojava/biojava/commits{/sha}","git_commits_url":"https://api.github.com/repos/biojava/biojava/git/commits{/sha}","comments_url":"https://api.github.com/repos/biojava/biojava/comments{/number}","issue_comment_url":"https://api.github.com/repos/biojava/biojava/issues/comments{/number}","contents_url":"https://api.github.com/repos/biojava/biojava/contents/{+path}","compare_url":"https://api.github.com/repos/biojava/biojava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biojava/biojava/merges","archive_url":"https://api.github.com/repos/biojava/biojava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biojava/biojava/downloads","issues_url":"https://api.github.com/repos/biojava/biojava/issues{/number}","pulls_url":"https://api.github.com/repos/biojava/biojava/pulls{/number}","milestones_url":"https://api.github.com/repos/biojava/biojava/milestones{/number}","notifications_url":"https://api.github.com/repos/biojava/biojava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biojava/biojava/labels{/name}","releases_url":"https://api.github.com/repos/biojava/biojava/releases{/id}","created_at":"2013-04-03T16:27:17Z","updated_at":"2015-11-24T13:03:14Z","pushed_at":"2015-11-27T02:43:10Z","git_url":"git://github.com/biojava/biojava.git","ssh_url":"git@github.com:biojava/biojava.git","clone_url":"https://github.com/biojava/biojava.git","svn_url":"https://github.com/biojava/biojava","homepage":"http://biojava.org","size":38131,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":59,"forks":110,"open_issues":59,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biojava/biojava/pulls/352"},"html":{"href":"https://github.com/biojava/biojava/pull/352"},"issue":{"href":"https://api.github.com/repos/biojava/biojava/issues/352"},"comments":{"href":"https://api.github.com/repos/biojava/biojava/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/biojava/biojava/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/biojava/biojava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biojava/biojava/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/biojava/biojava/statuses/a9eecede2b572c6389f135eff032537d1bfd6c9d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"josemduarte","id":6000474,"avatar_url":"https://avatars.githubusercontent.com/u/6000474?v=3","gravatar_id":"","url":"https://api.github.com/users/josemduarte","html_url":"https://github.com/josemduarte","followers_url":"https://api.github.com/users/josemduarte/followers","following_url":"https://api.github.com/users/josemduarte/following{/other_user}","gists_url":"https://api.github.com/users/josemduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/josemduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemduarte/subscriptions","organizations_url":"https://api.github.com/users/josemduarte/orgs","repos_url":"https://api.github.com/users/josemduarte/repos","events_url":"https://api.github.com/users/josemduarte/events{/privacy}","received_events_url":"https://api.github.com/users/josemduarte/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":86,"deletions":566,"changed_files":12}}