{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/35231597","id":35231597,"diff_hunk":"@@ -331,6 +331,96 @@ code {\n   overflow-x: auto; // remove when we update to latest patternfly with twbs 3.3.4\n }\n \n+.table-events {\n+  background-color: #fff;\n+  > tbody {\n+    + tbody {\n+      border-top-width: 1px;\n+    }\n+  }\n+  tr {\n+    th,td {\n+      .column-combine {\n+        display: none;\n+      }\n+    }\n+    @media (min-width: @screen-lg-min) {\n+      td[data-title=\"Name\"] {\n+        white-space: nowrap;\n+      }\n+    }\n+  }\n+  // Combine event reason and message into one column between 768 and 1100, so that table doesn't cause horizontal scroll and message is readable\n+  @media (min-width: @screen-sm-min) and (max-width: @screen-md-max) {\n+    > thead {\n+      > tr {\n+        > th {\n+          &:nth-child(4) {\n+            display: none;\n+          }\n+          &:nth-child(5) {\n+            .column-combine {\n+              display: inline;\n+            }\n+          }\n+        }\n+      }\n+    }\n+    > tbody {\n+      > tr {\n+        > td {\n+          &:nth-child(4) {\n+            display: none;\n+          }\n+          &:nth-child(5) {\n+            .column-combine {\n+              display: block;\n+            }\n+          }\n+        }\n+      }\n+    }\n+  }\n+}\n+\n+@media (max-width: @screen-xs-max) {\n+  .table-events, thead, tbody, th, td, tr {\n+    display: block;\n+  }\n+  .table-events {\n+    thead tr {\n+      /* Hide table headers (but not display: none;, for accessibility) */\n+      position: absolute;\n+      top: -9999px;\n+      left: -9999px;","path":"assets/app/styles/_core.less","position":28,"original_position":65,"commit_id":"aed4376547b392e80e28426288d721df1b1a52ee","original_commit_id":"a597c36e18c14c4b6cf686e1a9474503b9049c93","user":{"login":"sg00dwin","id":1874151,"avatar_url":"https://avatars.githubusercontent.com/u/1874151?v=3","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"body":"yes that works, I'll update it.","created_at":"2015-07-22T16:17:28Z","updated_at":"2015-07-22T16:17:28Z","html_url":"https://github.com/openshift/origin/pull/3792#discussion_r35231597","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/3792","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/35231597"},"html":{"href":"https://github.com/openshift/origin/pull/3792#discussion_r35231597"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/3792"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/3792","id":40394622,"html_url":"https://github.com/openshift/origin/pull/3792","diff_url":"https://github.com/openshift/origin/pull/3792.diff","patch_url":"https://github.com/openshift/origin/pull/3792.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/3792","number":3792,"state":"open","locked":false,"title":"Customize the events table layout and styles for better readability on mobile devices.","user":{"login":"sg00dwin","id":1874151,"avatar_url":"https://avatars.githubusercontent.com/u/1874151?v=3","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"body":"At < 992px the \"Reason and Message\" columns are combined into one, so that the columns aren't squished.\r\nAt < 767px the data switches to a 2 column layout - table headings are on the left and their values are on the right. This enable the content to compress down to 320px and without triggering a horizontal scrollbar.\r\n\r\nDisplay at multiple viewport widths.\r\n\r\n1200px and wider\r\n![screen shot 2015-07-20 at 4 09 41 pm](https://cloud.githubusercontent.com/assets/1874151/8786766/2143ae74-2efe-11e5-9d7a-e429f82a3365.png)\r\n\r\n800px\r\n![screen shot 2015-07-20 at 4 10 19 pm](https://cloud.githubusercontent.com/assets/1874151/8786705/bf1a1896-2efd-11e5-9d2c-42cbc198766a.png)\r\n\r\n580px\r\n![screen shot 2015-07-20 at 4 10 46 pm](https://cloud.githubusercontent.com/assets/1874151/8786735/e2a38c20-2efd-11e5-9f83-4e91db11dad7.png)\r\n\r\n320px\r\n![screen shot 2015-07-20 at 3 47 01 pm](https://cloud.githubusercontent.com/assets/1874151/8786738/eb096e8e-2efd-11e5-959b-000125aa4f4e.png)\r\n\r\n","created_at":"2015-07-20T20:40:22Z","updated_at":"2015-07-22T16:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f52d7454231970b87f1f539cf2d345db077b744","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/3792/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/3792/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/3792/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/aed4376547b392e80e28426288d721df1b1a52ee","head":{"label":"sg00dwin:table-styles","ref":"table-styles","sha":"aed4376547b392e80e28426288d721df1b1a52ee","user":{"login":"sg00dwin","id":1874151,"avatar_url":"https://avatars.githubusercontent.com/u/1874151?v=3","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"repo":{"id":28092895,"name":"origin","full_name":"sg00dwin/origin","owner":{"login":"sg00dwin","id":1874151,"avatar_url":"https://avatars.githubusercontent.com/u/1874151?v=3","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sg00dwin/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/sg00dwin/origin","forks_url":"https://api.github.com/repos/sg00dwin/origin/forks","keys_url":"https://api.github.com/repos/sg00dwin/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sg00dwin/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sg00dwin/origin/teams","hooks_url":"https://api.github.com/repos/sg00dwin/origin/hooks","issue_events_url":"https://api.github.com/repos/sg00dwin/origin/issues/events{/number}","events_url":"https://api.github.com/repos/sg00dwin/origin/events","assignees_url":"https://api.github.com/repos/sg00dwin/origin/assignees{/user}","branches_url":"https://api.github.com/repos/sg00dwin/origin/branches{/branch}","tags_url":"https://api.github.com/repos/sg00dwin/origin/tags","blobs_url":"https://api.github.com/repos/sg00dwin/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sg00dwin/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sg00dwin/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sg00dwin/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sg00dwin/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/sg00dwin/origin/languages","stargazers_url":"https://api.github.com/repos/sg00dwin/origin/stargazers","contributors_url":"https://api.github.com/repos/sg00dwin/origin/contributors","subscribers_url":"https://api.github.com/repos/sg00dwin/origin/subscribers","subscription_url":"https://api.github.com/repos/sg00dwin/origin/subscription","commits_url":"https://api.github.com/repos/sg00dwin/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sg00dwin/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sg00dwin/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sg00dwin/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sg00dwin/origin/contents/{+path}","compare_url":"https://api.github.com/repos/sg00dwin/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sg00dwin/origin/merges","archive_url":"https://api.github.com/repos/sg00dwin/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sg00dwin/origin/downloads","issues_url":"https://api.github.com/repos/sg00dwin/origin/issues{/number}","pulls_url":"https://api.github.com/repos/sg00dwin/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/sg00dwin/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/sg00dwin/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sg00dwin/origin/labels{/name}","releases_url":"https://api.github.com/repos/sg00dwin/origin/releases{/id}","created_at":"2014-12-16T15:24:00Z","updated_at":"2015-03-12T13:05:36Z","pushed_at":"2015-07-21T21:54:06Z","git_url":"git://github.com/sg00dwin/origin.git","ssh_url":"git@github.com:sg00dwin/origin.git","clone_url":"https://github.com/sg00dwin/origin.git","svn_url":"https://github.com/sg00dwin/origin","homepage":"https://openshift.github.io","size":125616,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6ce414638e372cf38fb82e95b327afcb989cc9d4","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-07-21T20:44:23Z","pushed_at":"2015-07-22T16:14:05Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":195977,"stargazers_count":564,"watchers_count":564,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":448,"forks":311,"open_issues":448,"watchers":564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/3792"},"html":{"href":"https://github.com/openshift/origin/pull/3792"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/3792"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/3792/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/3792/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/3792/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/aed4376547b392e80e28426288d721df1b1a52ee"}}}}