{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-odk/pulls/comments/41825920","id":41825920,"diff_hunk":"@@ -0,0 +1,76 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<RelativeLayout xmlns:android=\"http://schemas.android.com/apk/res/android\"\n+    android:orientation=\"vertical\"\n+    android:layout_width=\"match_parent\"\n+    android:layout_height=\"match_parent\">\n+\n+    <include\n+        android:id=\"@+id/dialog_title\"\n+        layout=\"@layout/dialog_title\" />\n+\n+    <TextView\n+        android:id=\"@+id/dialog_message\"\n+        android:layout_width=\"wrap_content\"\n+        android:layout_height=\"wrap_content\"\n+        android:textSize=\"@dimen/font_size_large\"\n+        android:layout_below=\"@id/dialog_title\"\n+        android:layout_marginLeft=\"@dimen/standard_spacer_large\"\n+        android:layout_marginRight=\"@dimen/standard_spacer_large\"\n+        android:layout_marginBottom=\"@dimen/standard_spacer_large\" />\n+\n+    <Button xmlns:android=\"http://schemas.android.com/apk/res/android\"\n+        android:id=\"@+id/positive_button\"\n+        android:layout_width=\"wrap_content\"\n+        android:layout_height=\"@dimen/min_button_height\"\n+        android:padding=\"@dimen/standard_spacer\"\n+\n+        android:layout_below=\"@id/dialog_message\"\n+        android:layout_alignParentRight=\"true\"\n+\n+        android:layout_marginBottom=\"@dimen/standard_spacer\"\n+        android:layout_marginRight=\"@dimen/standard_spacer\"\n+\n+        android:background=\"@android:color/transparent\"\n+        android:textSize=\"@dimen/font_size_medium\"\n+        android:textColor=\"#2196F3\"\n+        android:visibility=\"gone\" >\n+    </Button>\n+\n+    <Button xmlns:android=\"http://schemas.android.com/apk/res/android\"\n+        android:id=\"@+id/neutral_button\"\n+        android:layout_width=\"wrap_content\"\n+        android:layout_height=\"@dimen/min_button_height\"\n+        android:padding=\"@dimen/standard_spacer\"\n+\n+        android:layout_below=\"@id/dialog_message\"\n+        android:layout_toLeftOf=\"@id/positive_button\"\n+\n+        android:layout_marginBottom=\"@dimen/standard_spacer\"\n+\n+        android:background=\"@android:color/transparent\"\n+        android:textSize=\"@dimen/font_size_medium\"\n+        android:textColor=\"#2196F3\"\n+        android:visibility=\"gone\" >\n+    </Button>\n+\n+    <Button xmlns:android=\"http://schemas.android.com/apk/res/android\"\n+        android:id=\"@+id/negative_button\"\n+        android:layout_width=\"wrap_content\"\n+        android:layout_height=\"@dimen/min_button_height\"\n+        android:padding=\"@dimen/standard_spacer\"\n+\n+        android:layout_below=\"@id/dialog_message\"\n+        android:layout_toLeftOf=\"@id/neutral_button\"\n+\n+        android:layout_marginBottom=\"@dimen/standard_spacer\"\n+        android:layout_marginRight=\"@dimen/standard_spacer\"\n+        android:layout_marginLeft=\"@dimen/standard_spacer\"\n+\n+        android:background=\"@android:color/transparent\"\n+        android:textSize=\"@dimen/font_size_medium\"\n+        android:textColor=\"#2196F3\"","path":"app/res/layout/custom_alert_dialog.xml","position":71,"original_position":71,"commit_id":"7c24c80683073b8aa7e1747c4ed29289b7d40aa3","original_commit_id":"7c24c80683073b8aa7e1747c4ed29289b7d40aa3","user":{"login":"ctsims","id":155066,"avatar_url":"https://avatars.githubusercontent.com/u/155066?v=3","gravatar_id":"","url":"https://api.github.com/users/ctsims","html_url":"https://github.com/ctsims","followers_url":"https://api.github.com/users/ctsims/followers","following_url":"https://api.github.com/users/ctsims/following{/other_user}","gists_url":"https://api.github.com/users/ctsims/gists{/gist_id}","starred_url":"https://api.github.com/users/ctsims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctsims/subscriptions","organizations_url":"https://api.github.com/users/ctsims/orgs","repos_url":"https://api.github.com/users/ctsims/repos","events_url":"https://api.github.com/users/ctsims/events{/privacy}","received_events_url":"https://api.github.com/users/ctsims/received_events","type":"User","site_admin":false},"body":"Can we make sure this is coming from the colors.xml file?","created_at":"2015-10-13T04:31:36Z","updated_at":"2015-10-13T04:31:36Z","html_url":"https://github.com/dimagi/commcare-odk/pull/676#discussion_r41825920","pull_request_url":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-odk/pulls/comments/41825920"},"html":{"href":"https://github.com/dimagi/commcare-odk/pull/676#discussion_r41825920"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676","id":46842162,"html_url":"https://github.com/dimagi/commcare-odk/pull/676","diff_url":"https://github.com/dimagi/commcare-odk/pull/676.diff","patch_url":"https://github.com/dimagi/commcare-odk/pull/676.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-odk/issues/676","number":676,"state":"open","locked":false,"title":"New UI re-design for progress dialogs and basic alert dialogs","user":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars.githubusercontent.com/u/3723143?v=3","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"body":"Redesign of progress dialogs and (basic) alert dialogs to comply with the new UI spec. Modeled after image in this ticket: http://manage.dimagi.com/default.asp?183307#1025658, and using the google design specs for dialogs: https://www.google.com/design/spec/components/dialogs.html#dialogs-specs. Screenshots included below! Have also tested on devices of a few different sizes to make sure it still looks right.\r\n\r\nThe new design has been applied to every progress dialog (by refactoring CustomProgressDialog), and nearly every alert dialog (by creating AlertDialogFactory). The alert dialogs that were excluded are those that involve more complicated construction in one way or another, and which Clayton therefore told me to leave out of the redesign, at least for now. \r\n\r\nThe alert dialogs that were NOT included in the redesign - just so that we have a comprehensive list somewhere and in case anyone feels strongly that any of them should be included - are the following:\r\n-buildAboutCommCareDialog() in DialogCreationHelpers\r\n-onCreateDialog() in CallOutActivity\r\n-showAboutCommCareDialog() and showDemoModeWarning() in CommCareHomeActivity\r\n-createSortMenu() in EntitySelectActivity\r\n-buildMenuList() in AndroidShortucts\r\n-createQuitDrawDialog() in DrawActivity\r\n-createLanguageDialog(), createQuitDialog(), and createRepeatDialog() in FormEntryActivity\r\n-setupSplashPathPreference() in PreferencesActivity\r\n-fireHelpText() in QuestionWidget\r\n-the constructor of SpinnerMultiWidget","created_at":"2015-10-05T22:25:23Z","updated_at":"2015-10-13T04:31:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1de23447664edf4564687d6ce324d823c7cd5527","assignee":null,"milestone":{"url":"https://api.github.com/repos/dimagi/commcare-odk/milestones/4","html_url":"https://github.com/dimagi/commcare-odk/milestones/commcare_2.24","labels_url":"https://api.github.com/repos/dimagi/commcare-odk/milestones/4/labels","id":1276470,"number":4,"title":"commcare_2.24","description":null,"creator":{"login":"phillipm","id":94817,"avatar_url":"https://avatars.githubusercontent.com/u/94817?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipm","html_url":"https://github.com/phillipm","followers_url":"https://api.github.com/users/phillipm/followers","following_url":"https://api.github.com/users/phillipm/following{/other_user}","gists_url":"https://api.github.com/users/phillipm/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipm/subscriptions","organizations_url":"https://api.github.com/users/phillipm/orgs","repos_url":"https://api.github.com/users/phillipm/repos","events_url":"https://api.github.com/users/phillipm/events{/privacy}","received_events_url":"https://api.github.com/users/phillipm/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":44,"state":"open","created_at":"2015-08-27T20:11:24Z","updated_at":"2015-10-13T04:27:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-odk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-odk/issues/676/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-odk/statuses/7c24c80683073b8aa7e1747c4ed29289b7d40aa3","head":{"label":"dimagi:new-dialogs","ref":"new-dialogs","sha":"7c24c80683073b8aa7e1747c4ed29289b7d40aa3","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20939877,"name":"commcare-odk","full_name":"dimagi/commcare-odk","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-odk","description":"","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-odk","forks_url":"https://api.github.com/repos/dimagi/commcare-odk/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-odk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-odk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-odk/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-odk/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-odk/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-odk/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-odk/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-odk/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-odk/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-odk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-odk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-odk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-odk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-odk/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-odk/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-odk/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-odk/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-odk/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-odk/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-odk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-odk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-odk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-odk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-odk/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-odk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-odk/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-odk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-odk/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-odk/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-odk/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-odk/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-odk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-odk/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-odk/releases{/id}","created_at":"2014-06-17T21:17:26Z","updated_at":"2015-05-06T16:04:54Z","pushed_at":"2015-10-13T04:30:28Z","git_url":"git://github.com/dimagi/commcare-odk.git","ssh_url":"git@github.com:dimagi/commcare-odk.git","clone_url":"https://github.com/dimagi/commcare-odk.git","svn_url":"https://github.com/dimagi/commcare-odk","homepage":null,"size":66866,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"c7af6fc5dc0f60d00c399fe4ee3dca700bfe9e15","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20939877,"name":"commcare-odk","full_name":"dimagi/commcare-odk","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-odk","description":"","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-odk","forks_url":"https://api.github.com/repos/dimagi/commcare-odk/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-odk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-odk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-odk/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-odk/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-odk/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-odk/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-odk/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-odk/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-odk/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-odk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-odk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-odk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-odk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-odk/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-odk/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-odk/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-odk/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-odk/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-odk/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-odk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-odk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-odk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-odk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-odk/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-odk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-odk/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-odk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-odk/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-odk/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-odk/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-odk/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-odk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-odk/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-odk/releases{/id}","created_at":"2014-06-17T21:17:26Z","updated_at":"2015-05-06T16:04:54Z","pushed_at":"2015-10-13T04:30:28Z","git_url":"git://github.com/dimagi/commcare-odk.git","ssh_url":"git@github.com:dimagi/commcare-odk.git","clone_url":"https://github.com/dimagi/commcare-odk.git","svn_url":"https://github.com/dimagi/commcare-odk","homepage":null,"size":66866,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676"},"html":{"href":"https://github.com/dimagi/commcare-odk/pull/676"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-odk/issues/676"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-odk/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-odk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-odk/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-odk/statuses/7c24c80683073b8aa7e1747c4ed29289b7d40aa3"}}}}