{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments/31253544","id":31253544,"diff_hunk":"@@ -0,0 +1,57 @@\n+package org.broadinstitute.dsde.vault.services.generic\n+\n+import com.wordnik.swagger.annotations._\n+import org.broadinstitute.dsde.vault.common.directives.VersioningDirectives._\n+import org.broadinstitute.dsde.vault.model.{GenericSysAttrs, GenericEntity, GenericIngest}\n+import org.broadinstitute.dsde.vault.model.GenericJsonProtocol._\n+import spray.json._\n+import spray.http.MediaTypes._\n+import spray.httpx.SprayJsonSupport._\n+import spray.routing.HttpService\n+\n+@Api(value=\"/entities\", description=\"generic entity service\", produces=\"application/json\")\n+trait GenericIngestService extends HttpService {\n+  private final val ApiPrefix = \"entities\"\n+  private final val ApiVersions = \"v1\"\n+  private final val DefaultVersion = 1\n+\n+  val giRoute = ingestRoute\n+\n+  @ApiOperation(\n+    value = \"store some entities and relationships\",\n+    nickname = \"genericIngest\",\n+    httpMethod = \"POST\",\n+    response = classOf[GenericEntity],\n+    responseContainer = \"List\",\n+    notes = \"response is a list of the new entities\")","path":"src/main/scala/org/broadinstitute/dsde/vault/services/generic/GenericIngestService.scala","position":26,"original_position":26,"commit_id":"38af46709727a57c5821aa3cc98a40cf230bdd21","original_commit_id":"38af46709727a57c5821aa3cc98a40cf230bdd21","user":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"body":"DM is just returning the UUIDs it created, not the whole entities. From the stub below, it looks like you'll handle returning the whole entities (and relations) by replacing the relevant parts of the request. If this works, great! If that's difficult, it might require GET-ing the entities again ... extra queries. No action necessary from this comment ... just tossing it out there.","created_at":"2015-05-28T16:48:19Z","updated_at":"2015-05-28T16:48:19Z","html_url":"https://github.com/broadinstitute/vault-api/pull/60#discussion_r31253544","pull_request_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments/31253544"},"html":{"href":"https://github.com/broadinstitute/vault-api/pull/60#discussion_r31253544"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60","id":36331806,"html_url":"https://github.com/broadinstitute/vault-api/pull/60","diff_url":"https://github.com/broadinstitute/vault-api/pull/60.diff","patch_url":"https://github.com/broadinstitute/vault-api/pull/60.patch","issue_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/60","number":60,"state":"open","locked":false,"title":"Stubs for Generic API","user":{"login":"jmthibault79","id":2701406,"avatar_url":"https://avatars.githubusercontent.com/u/2701406?v=3","gravatar_id":"","url":"https://api.github.com/users/jmthibault79","html_url":"https://github.com/jmthibault79","followers_url":"https://api.github.com/users/jmthibault79/followers","following_url":"https://api.github.com/users/jmthibault79/following{/other_user}","gists_url":"https://api.github.com/users/jmthibault79/gists{/gist_id}","starred_url":"https://api.github.com/users/jmthibault79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmthibault79/subscriptions","organizations_url":"https://api.github.com/users/jmthibault79/orgs","repos_url":"https://api.github.com/users/jmthibault79/repos","events_url":"https://api.github.com/users/jmthibault79/events{/privacy}","received_events_url":"https://api.github.com/users/jmthibault79/received_events","type":"User","site_admin":false},"body":"DSDEV-1993\r\n\r\nMostly copied from DM, except for BlobSpecification, getUrl, and putUrl.\r\n\r\nPlease also review the `//STUB` pseudocode and test this out with Swagger.\r\n\r\n","created_at":"2015-05-27T18:07:37Z","updated_at":"2015-05-28T16:48:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b9020d08916a82ed0aafd37535d8bab00892f5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/60/comments","statuses_url":"https://api.github.com/repos/broadinstitute/vault-api/statuses/38af46709727a57c5821aa3cc98a40cf230bdd21","head":{"label":"broadinstitute:jt_generic_stubs","ref":"jt_generic_stubs","sha":"38af46709727a57c5821aa3cc98a40cf230bdd21","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":30926361,"name":"vault-api","full_name":"broadinstitute/vault-api","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-api","description":"Vault Orchestration Service","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-api","forks_url":"https://api.github.com/repos/broadinstitute/vault-api/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-api/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-api/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-api/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-api/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-api/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-api/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-api/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-api/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-api/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-api/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-api/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-api/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-api/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-api/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-api/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-api/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-api/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-api/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-api/releases{/id}","created_at":"2015-02-17T16:41:31Z","updated_at":"2015-05-08T18:30:44Z","pushed_at":"2015-05-28T14:29:17Z","git_url":"git://github.com/broadinstitute/vault-api.git","ssh_url":"git@github.com:broadinstitute/vault-api.git","clone_url":"https://github.com/broadinstitute/vault-api.git","svn_url":"https://github.com/broadinstitute/vault-api","homepage":null,"size":2625,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"335d5b65c94d76bdb21ec8d89c2eb3ea9cdbc505","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":30926361,"name":"vault-api","full_name":"broadinstitute/vault-api","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-api","description":"Vault Orchestration Service","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-api","forks_url":"https://api.github.com/repos/broadinstitute/vault-api/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-api/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-api/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-api/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-api/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-api/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-api/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-api/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-api/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-api/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-api/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-api/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-api/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-api/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-api/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-api/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-api/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-api/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-api/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-api/releases{/id}","created_at":"2015-02-17T16:41:31Z","updated_at":"2015-05-08T18:30:44Z","pushed_at":"2015-05-28T14:29:17Z","git_url":"git://github.com/broadinstitute/vault-api.git","ssh_url":"git@github.com:broadinstitute/vault-api.git","clone_url":"https://github.com/broadinstitute/vault-api.git","svn_url":"https://github.com/broadinstitute/vault-api","homepage":null,"size":2625,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60"},"html":{"href":"https://github.com/broadinstitute/vault-api/pull/60"},"issue":{"href":"https://api.github.com/repos/broadinstitute/vault-api/issues/60"},"comments":{"href":"https://api.github.com/repos/broadinstitute/vault-api/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/vault-api/statuses/38af46709727a57c5821aa3cc98a40cf230bdd21"}}}}