{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/43640858","id":43640858,"diff_hunk":"@@ -64,6 +64,52 @@ angular.module('openshiftConsole')\n               logLinks.scrollTop();\n             };\n \n+            var bufferedLines = [];\n+            // Display all buffered lines.\n+            var update = function() {\n+              var fragment = document.createDocumentFragment();\n+              var logContent = document.getElementById('logContent');\n+              angular.forEach(bufferedLines, function(line) {\n+                // Manipulate the DOM directly for better performance displaying large log files.","path":"assets/app/scripts/directives/logViewer.js","position":37,"original_position":37,"commit_id":"0764d6f0c8c78f5f254fabe375257440ef340144","original_commit_id":"0764d6f0c8c78f5f254fabe375257440ef340144","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"@liggitt let me look and see if i can make the clone node change","created_at":"2015-11-02T15:39:16Z","updated_at":"2015-11-02T15:39:16Z","html_url":"https://github.com/openshift/origin/pull/5564#discussion_r43640858","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/5564","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/43640858"},"html":{"href":"https://github.com/openshift/origin/pull/5564#discussion_r43640858"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/5564"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5564","id":49375101,"html_url":"https://github.com/openshift/origin/pull/5564","diff_url":"https://github.com/openshift/origin/pull/5564.diff","patch_url":"https://github.com/openshift/origin/pull/5564.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/5564","number":5564,"state":"open","locked":false,"title":"Throttle log updates to avoid UI flicker","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Some browsers flicker when there are bursts of messages (dozens in a second). This seems worst in Safari. Buffer and throttle updates when auto-scrolling to avoid flicker.\r\n\r\nTested in Chrome, Firefox, IE, and Safari.","created_at":"2015-11-01T16:24:37Z","updated_at":"2015-11-02T15:39:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"395200d3a7ce2c9b20a166535e3bf9d28ab2b3d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/5564/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/5564/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5564/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/0764d6f0c8c78f5f254fabe375257440ef340144","head":{"label":"spadgett:throttle-scroll","ref":"throttle-scroll","sha":"0764d6f0c8c78f5f254fabe375257440ef340144","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"repo":{"id":34353535,"name":"origin","full_name":"spadgett/origin","owner":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spadgett/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/spadgett/origin","forks_url":"https://api.github.com/repos/spadgett/origin/forks","keys_url":"https://api.github.com/repos/spadgett/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spadgett/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spadgett/origin/teams","hooks_url":"https://api.github.com/repos/spadgett/origin/hooks","issue_events_url":"https://api.github.com/repos/spadgett/origin/issues/events{/number}","events_url":"https://api.github.com/repos/spadgett/origin/events","assignees_url":"https://api.github.com/repos/spadgett/origin/assignees{/user}","branches_url":"https://api.github.com/repos/spadgett/origin/branches{/branch}","tags_url":"https://api.github.com/repos/spadgett/origin/tags","blobs_url":"https://api.github.com/repos/spadgett/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spadgett/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spadgett/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spadgett/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spadgett/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/spadgett/origin/languages","stargazers_url":"https://api.github.com/repos/spadgett/origin/stargazers","contributors_url":"https://api.github.com/repos/spadgett/origin/contributors","subscribers_url":"https://api.github.com/repos/spadgett/origin/subscribers","subscription_url":"https://api.github.com/repos/spadgett/origin/subscription","commits_url":"https://api.github.com/repos/spadgett/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spadgett/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spadgett/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spadgett/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spadgett/origin/contents/{+path}","compare_url":"https://api.github.com/repos/spadgett/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spadgett/origin/merges","archive_url":"https://api.github.com/repos/spadgett/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spadgett/origin/downloads","issues_url":"https://api.github.com/repos/spadgett/origin/issues{/number}","pulls_url":"https://api.github.com/repos/spadgett/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/spadgett/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/spadgett/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spadgett/origin/labels{/name}","releases_url":"https://api.github.com/repos/spadgett/origin/releases{/id}","created_at":"2015-04-21T21:38:33Z","updated_at":"2015-05-08T19:33:23Z","pushed_at":"2015-11-02T12:39:23Z","git_url":"git://github.com/spadgett/origin.git","ssh_url":"git@github.com:spadgett/origin.git","clone_url":"https://github.com/spadgett/origin.git","svn_url":"https://github.com/spadgett/origin","homepage":"http://www.openshift.org","size":174411,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3cf7f3cccd5b7b95448568ba8e2b3c81cc6ab9af","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-11-01T13:41:20Z","pushed_at":"2015-11-02T15:38:49Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":301390,"stargazers_count":783,"watchers_count":783,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":484,"mirror_url":null,"open_issues_count":603,"forks":484,"open_issues":603,"watchers":783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/5564"},"html":{"href":"https://github.com/openshift/origin/pull/5564"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/5564"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/5564/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/5564/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/5564/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/0764d6f0c8c78f5f254fabe375257440ef340144"}}}}