{"action":"created","comment":{"url":"https://api.github.com/repos/dynup/kpatch/pulls/comments/42245584","id":42245584,"diff_hunk":"@@ -482,21 +482,26 @@ for i in $FILES; do\n \tcd $TEMPDIR\n \tdebugopt=\n \t[[ $DEBUG -eq 1 ]] && debugopt=-d\n-\t\"$TOOLSDIR\"/create-diff-object $debugopt \"orig/$i\" \"patched/$i\" \"$KOBJFILE\" \"output/$i\" 2>&1 |tee -a \"$LOGFILE\"\n-\trc=\"${PIPESTATUS[0]}\"\n-\tif [[ $rc = 139 ]]; then\n-\t\twarn \"create-diff-object SIGSEGV\"\n-\t\tif ls core* &> /dev/null; then\n-\t\t\tcp core* /tmp\n-\t\t\tdie \"core file at /tmp/$(ls core*)\"\n+\tif [[ -e \"orig/$i\" ]]; then\n+\t\t\"$TOOLSDIR\"/create-diff-object $debugopt \"orig/$i\" \"patched/$i\" \"$KOBJFILE\" \"output/$i\" 2>&1 |tee -a \"$LOGFILE\"\n+\t\trc=\"${PIPESTATUS[0]}\"\n+\t\tif [[ $rc = 139 ]]; then\n+\t\t\twarn \"create-diff-object SIGSEGV\"\n+\t\t\tif ls core* &> /dev/null; then\n+\t\t\t\tcp core* /tmp\n+\t\t\t\tdie \"core file at /tmp/$(ls core*)\"\n+\t\t\tfi\n+\t\t\tdie \"no core file found, run 'ulimit -c unlimited' and try to recreate\"\n \t\tfi\n-\t\tdie \"no core file found, run 'ulimit -c unlimited' and try to recreate\"\n-\tfi\n-\t# create-diff-object returns 3 if no functional change is found\n-\t[[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || ERROR=$(expr $ERROR \"+\" 1)\n-\tif [[ $rc -eq 0 ]]; then\n-\t\t[[ -n $ERROR_IF_DIFF ]] && die $ERROR_IF_DIFF\n-\t\tCHANGED=1\n+\t\t# create-diff-object returns 3 if no functional change is found\n+\t\t[[ $rc -eq 0 ]] || [[ $rc -eq 3 ]] || ERROR=$(expr $ERROR \"+\" 1)\n+\t\tif [[ $rc -eq 0 ]]; then\n+\t\t\t[[ -n $ERROR_IF_DIFF ]] && die $ERROR_IF_DIFF\n+\t\t\tCHANGED=1\n+\t\t\tobjnames[$KOBJFILE]=1\n+\t\tfi\n+\telse\n+\t\tcp -f \"patched/$i\" \"output/$i\"\n \t\tobjnames[$KOBJFILE]=1","path":"kpatch-build/kpatch-build","position":47,"original_position":47,"commit_id":"ef76bd9cc96170830e7b07cddc14f1003793cb31","original_commit_id":"ef76bd9cc96170830e7b07cddc14f1003793cb31","user":{"login":"jpoimboe","id":1750978,"avatar_url":"https://avatars.githubusercontent.com/u/1750978?v=3","gravatar_id":"","url":"https://api.github.com/users/jpoimboe","html_url":"https://github.com/jpoimboe","followers_url":"https://api.github.com/users/jpoimboe/followers","following_url":"https://api.github.com/users/jpoimboe/following{/other_user}","gists_url":"https://api.github.com/users/jpoimboe/gists{/gist_id}","starred_url":"https://api.github.com/users/jpoimboe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpoimboe/subscriptions","organizations_url":"https://api.github.com/users/jpoimboe/orgs","repos_url":"https://api.github.com/users/jpoimboe/repos","events_url":"https://api.github.com/users/jpoimboe/events{/privacy}","received_events_url":"https://api.github.com/users/jpoimboe/received_events","type":"User","site_admin":false},"body":"I think the \"no functional changes found\" error would still be appropriate.  If they're not changing any functions, why use kpatch?","created_at":"2015-10-16T14:05:12Z","updated_at":"2015-10-16T14:05:12Z","html_url":"https://github.com/dynup/kpatch/pull/510#discussion_r42245584","pull_request_url":"https://api.github.com/repos/dynup/kpatch/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/comments/42245584"},"html":{"href":"https://github.com/dynup/kpatch/pull/510#discussion_r42245584"},"pull_request":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/dynup/kpatch/pulls/510","id":47888353,"html_url":"https://github.com/dynup/kpatch/pull/510","diff_url":"https://github.com/dynup/kpatch/pull/510.diff","patch_url":"https://github.com/dynup/kpatch/pull/510.patch","issue_url":"https://api.github.com/repos/dynup/kpatch/issues/510","number":510,"state":"open","locked":false,"title":"kpatch-build: support adding new files in patch","user":{"login":"libin2015","id":15058319,"avatar_url":"https://avatars.githubusercontent.com/u/15058319?v=3","gravatar_id":"","url":"https://api.github.com/users/libin2015","html_url":"https://github.com/libin2015","followers_url":"https://api.github.com/users/libin2015/followers","following_url":"https://api.github.com/users/libin2015/following{/other_user}","gists_url":"https://api.github.com/users/libin2015/gists{/gist_id}","starred_url":"https://api.github.com/users/libin2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libin2015/subscriptions","organizations_url":"https://api.github.com/users/libin2015/orgs","repos_url":"https://api.github.com/users/libin2015/repos","events_url":"https://api.github.com/users/libin2015/events{/privacy}","received_events_url":"https://api.github.com/users/libin2015/received_events","type":"User","site_admin":false},"body":"Geting the changed objects from the patched dir, in order to support\r\nadding new files in patch.\r\n\r\nSigned-off-by: Li Bin <huawei.libin@huawei.com>","created_at":"2015-10-16T09:28:03Z","updated_at":"2015-10-16T14:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1351ff69be7a6349af6dd3a4af14afc42662f1ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dynup/kpatch/pulls/510/commits","review_comments_url":"https://api.github.com/repos/dynup/kpatch/pulls/510/comments","review_comment_url":"https://api.github.com/repos/dynup/kpatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dynup/kpatch/issues/510/comments","statuses_url":"https://api.github.com/repos/dynup/kpatch/statuses/ef76bd9cc96170830e7b07cddc14f1003793cb31","head":{"label":"libin2015:support-add-new-file-v2","ref":"support-add-new-file-v2","sha":"ef76bd9cc96170830e7b07cddc14f1003793cb31","user":{"login":"libin2015","id":15058319,"avatar_url":"https://avatars.githubusercontent.com/u/15058319?v=3","gravatar_id":"","url":"https://api.github.com/users/libin2015","html_url":"https://github.com/libin2015","followers_url":"https://api.github.com/users/libin2015/followers","following_url":"https://api.github.com/users/libin2015/following{/other_user}","gists_url":"https://api.github.com/users/libin2015/gists{/gist_id}","starred_url":"https://api.github.com/users/libin2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libin2015/subscriptions","organizations_url":"https://api.github.com/users/libin2015/orgs","repos_url":"https://api.github.com/users/libin2015/repos","events_url":"https://api.github.com/users/libin2015/events{/privacy}","received_events_url":"https://api.github.com/users/libin2015/received_events","type":"User","site_admin":false},"repo":{"id":44095767,"name":"kpatch","full_name":"libin2015/kpatch","owner":{"login":"libin2015","id":15058319,"avatar_url":"https://avatars.githubusercontent.com/u/15058319?v=3","gravatar_id":"","url":"https://api.github.com/users/libin2015","html_url":"https://github.com/libin2015","followers_url":"https://api.github.com/users/libin2015/followers","following_url":"https://api.github.com/users/libin2015/following{/other_user}","gists_url":"https://api.github.com/users/libin2015/gists{/gist_id}","starred_url":"https://api.github.com/users/libin2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libin2015/subscriptions","organizations_url":"https://api.github.com/users/libin2015/orgs","repos_url":"https://api.github.com/users/libin2015/repos","events_url":"https://api.github.com/users/libin2015/events{/privacy}","received_events_url":"https://api.github.com/users/libin2015/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/libin2015/kpatch","description":"kpatch - dynamic kernel patching","fork":true,"url":"https://api.github.com/repos/libin2015/kpatch","forks_url":"https://api.github.com/repos/libin2015/kpatch/forks","keys_url":"https://api.github.com/repos/libin2015/kpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libin2015/kpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libin2015/kpatch/teams","hooks_url":"https://api.github.com/repos/libin2015/kpatch/hooks","issue_events_url":"https://api.github.com/repos/libin2015/kpatch/issues/events{/number}","events_url":"https://api.github.com/repos/libin2015/kpatch/events","assignees_url":"https://api.github.com/repos/libin2015/kpatch/assignees{/user}","branches_url":"https://api.github.com/repos/libin2015/kpatch/branches{/branch}","tags_url":"https://api.github.com/repos/libin2015/kpatch/tags","blobs_url":"https://api.github.com/repos/libin2015/kpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libin2015/kpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libin2015/kpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/libin2015/kpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libin2015/kpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/libin2015/kpatch/languages","stargazers_url":"https://api.github.com/repos/libin2015/kpatch/stargazers","contributors_url":"https://api.github.com/repos/libin2015/kpatch/contributors","subscribers_url":"https://api.github.com/repos/libin2015/kpatch/subscribers","subscription_url":"https://api.github.com/repos/libin2015/kpatch/subscription","commits_url":"https://api.github.com/repos/libin2015/kpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/libin2015/kpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/libin2015/kpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/libin2015/kpatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/libin2015/kpatch/contents/{+path}","compare_url":"https://api.github.com/repos/libin2015/kpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libin2015/kpatch/merges","archive_url":"https://api.github.com/repos/libin2015/kpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libin2015/kpatch/downloads","issues_url":"https://api.github.com/repos/libin2015/kpatch/issues{/number}","pulls_url":"https://api.github.com/repos/libin2015/kpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/libin2015/kpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/libin2015/kpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libin2015/kpatch/labels{/name}","releases_url":"https://api.github.com/repos/libin2015/kpatch/releases{/id}","created_at":"2015-10-12T08:57:57Z","updated_at":"2015-10-12T08:57:58Z","pushed_at":"2015-10-16T09:27:03Z","git_url":"git://github.com/libin2015/kpatch.git","ssh_url":"git@github.com:libin2015/kpatch.git","clone_url":"https://github.com/libin2015/kpatch.git","svn_url":"https://github.com/libin2015/kpatch","homepage":null,"size":1219,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dynup:master","ref":"master","sha":"c8b0f18aa95dec397ad5b865768c5c256f84028e","user":{"login":"dynup","id":6643594,"avatar_url":"https://avatars.githubusercontent.com/u/6643594?v=3","gravatar_id":"","url":"https://api.github.com/users/dynup","html_url":"https://github.com/dynup","followers_url":"https://api.github.com/users/dynup/followers","following_url":"https://api.github.com/users/dynup/following{/other_user}","gists_url":"https://api.github.com/users/dynup/gists{/gist_id}","starred_url":"https://api.github.com/users/dynup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynup/subscriptions","organizations_url":"https://api.github.com/users/dynup/orgs","repos_url":"https://api.github.com/users/dynup/repos","events_url":"https://api.github.com/users/dynup/events{/privacy}","received_events_url":"https://api.github.com/users/dynup/received_events","type":"Organization","site_admin":false},"repo":{"id":16743039,"name":"kpatch","full_name":"dynup/kpatch","owner":{"login":"dynup","id":6643594,"avatar_url":"https://avatars.githubusercontent.com/u/6643594?v=3","gravatar_id":"","url":"https://api.github.com/users/dynup","html_url":"https://github.com/dynup","followers_url":"https://api.github.com/users/dynup/followers","following_url":"https://api.github.com/users/dynup/following{/other_user}","gists_url":"https://api.github.com/users/dynup/gists{/gist_id}","starred_url":"https://api.github.com/users/dynup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynup/subscriptions","organizations_url":"https://api.github.com/users/dynup/orgs","repos_url":"https://api.github.com/users/dynup/repos","events_url":"https://api.github.com/users/dynup/events{/privacy}","received_events_url":"https://api.github.com/users/dynup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dynup/kpatch","description":"kpatch - dynamic kernel patching","fork":false,"url":"https://api.github.com/repos/dynup/kpatch","forks_url":"https://api.github.com/repos/dynup/kpatch/forks","keys_url":"https://api.github.com/repos/dynup/kpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dynup/kpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dynup/kpatch/teams","hooks_url":"https://api.github.com/repos/dynup/kpatch/hooks","issue_events_url":"https://api.github.com/repos/dynup/kpatch/issues/events{/number}","events_url":"https://api.github.com/repos/dynup/kpatch/events","assignees_url":"https://api.github.com/repos/dynup/kpatch/assignees{/user}","branches_url":"https://api.github.com/repos/dynup/kpatch/branches{/branch}","tags_url":"https://api.github.com/repos/dynup/kpatch/tags","blobs_url":"https://api.github.com/repos/dynup/kpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dynup/kpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dynup/kpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dynup/kpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dynup/kpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dynup/kpatch/languages","stargazers_url":"https://api.github.com/repos/dynup/kpatch/stargazers","contributors_url":"https://api.github.com/repos/dynup/kpatch/contributors","subscribers_url":"https://api.github.com/repos/dynup/kpatch/subscribers","subscription_url":"https://api.github.com/repos/dynup/kpatch/subscription","commits_url":"https://api.github.com/repos/dynup/kpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dynup/kpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dynup/kpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dynup/kpatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dynup/kpatch/contents/{+path}","compare_url":"https://api.github.com/repos/dynup/kpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dynup/kpatch/merges","archive_url":"https://api.github.com/repos/dynup/kpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dynup/kpatch/downloads","issues_url":"https://api.github.com/repos/dynup/kpatch/issues{/number}","pulls_url":"https://api.github.com/repos/dynup/kpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dynup/kpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dynup/kpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dynup/kpatch/labels{/name}","releases_url":"https://api.github.com/repos/dynup/kpatch/releases{/id}","created_at":"2014-02-11T19:47:52Z","updated_at":"2015-09-30T12:25:43Z","pushed_at":"2015-10-16T13:59:14Z","git_url":"git://github.com/dynup/kpatch.git","ssh_url":"git@github.com:dynup/kpatch.git","clone_url":"https://github.com/dynup/kpatch.git","svn_url":"https://github.com/dynup/kpatch","homepage":null,"size":2830,"stargazers_count":324,"watchers_count":324,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":19,"forks":70,"open_issues":19,"watchers":324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/510"},"html":{"href":"https://github.com/dynup/kpatch/pull/510"},"issue":{"href":"https://api.github.com/repos/dynup/kpatch/issues/510"},"comments":{"href":"https://api.github.com/repos/dynup/kpatch/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/dynup/kpatch/statuses/ef76bd9cc96170830e7b07cddc14f1003793cb31"}}}}