{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/41230434","id":41230434,"diff_hunk":"@@ -455,22 +456,36 @@ TEE_Result tee_svc_storage_obj_open(uint32_t storage_id, void *object_id,\n \n \tres = tee_svc_storage_read_head(sess, o);\n \tif (res != TEE_SUCCESS) {\n+\t\tif (res == TEE_ERROR_CORRUPT_OBJECT) {","path":"core/tee/tee_svc_storage.c","position":305,"original_position":305,"commit_id":"3ae333691f8df824177e3869a42d53122658c165","original_commit_id":"3ae333691f8df824177e3869a42d53122658c165","user":{"login":"jamescfkung","id":10397509,"avatar_url":"https://avatars.githubusercontent.com/u/10397509?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescfkung","html_url":"https://github.com/jamescfkung","followers_url":"https://api.github.com/users/jamescfkung/followers","following_url":"https://api.github.com/users/jamescfkung/following{/other_user}","gists_url":"https://api.github.com/users/jamescfkung/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescfkung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescfkung/subscriptions","organizations_url":"https://api.github.com/users/jamescfkung/orgs","repos_url":"https://api.github.com/users/jamescfkung/repos","events_url":"https://api.github.com/users/jamescfkung/events{/privacy}","received_events_url":"https://api.github.com/users/jamescfkung/received_events","type":"User","site_admin":false},"body":"Can we simplify it by removing the entire \"if (res == TEE_ERROR_CORRUPT_OBJECT) {....}\" statement?\r\nIt looks like that we do not need extra error handling for TEE_ERROR_CORRUPT_OBJECT here.","created_at":"2015-10-06T06:47:34Z","updated_at":"2015-10-06T06:47:34Z","html_url":"https://github.com/OP-TEE/optee_os/pull/454#discussion_r41230434","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/41230434"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/454#discussion_r41230434"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454","id":43757610,"html_url":"https://github.com/OP-TEE/optee_os/pull/454","diff_url":"https://github.com/OP-TEE/optee_os/pull/454.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/454.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/454","number":454,"state":"open","locked":false,"title":"GP11: trusted storage verify","user":{"login":"cedric-chaumont-st-dev","id":7803511,"avatar_url":"https://avatars.githubusercontent.com/u/7803511?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-chaumont-st-dev","html_url":"https://github.com/cedric-chaumont-st-dev","followers_url":"https://api.github.com/users/cedric-chaumont-st-dev/followers","following_url":"https://api.github.com/users/cedric-chaumont-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/cedric-chaumont-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-chaumont-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-chaumont-st-dev/subscriptions","organizations_url":"https://api.github.com/users/cedric-chaumont-st-dev/orgs","repos_url":"https://api.github.com/users/cedric-chaumont-st-dev/repos","events_url":"https://api.github.com/users/cedric-chaumont-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-chaumont-st-dev/received_events","type":"User","site_admin":false},"body":"Note: For testing, use optee_test branch dev/gp11_trusted_storage_verify","created_at":"2015-08-31T12:06:48Z","updated_at":"2015-10-06T06:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79e2ec0ddf0d045fc110cb3d980b9f7e9772e310","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/454/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/3ae333691f8df824177e3869a42d53122658c165","head":{"label":"cedric-chaumont-st-dev:dev/gp11_trusted_storage_verify","ref":"dev/gp11_trusted_storage_verify","sha":"3ae333691f8df824177e3869a42d53122658c165","user":{"login":"cedric-chaumont-st-dev","id":7803511,"avatar_url":"https://avatars.githubusercontent.com/u/7803511?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-chaumont-st-dev","html_url":"https://github.com/cedric-chaumont-st-dev","followers_url":"https://api.github.com/users/cedric-chaumont-st-dev/followers","following_url":"https://api.github.com/users/cedric-chaumont-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/cedric-chaumont-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-chaumont-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-chaumont-st-dev/subscriptions","organizations_url":"https://api.github.com/users/cedric-chaumont-st-dev/orgs","repos_url":"https://api.github.com/users/cedric-chaumont-st-dev/repos","events_url":"https://api.github.com/users/cedric-chaumont-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-chaumont-st-dev/received_events","type":"User","site_admin":false},"repo":{"id":20771117,"name":"optee_os","full_name":"cedric-chaumont-st-dev/optee_os","owner":{"login":"cedric-chaumont-st-dev","id":7803511,"avatar_url":"https://avatars.githubusercontent.com/u/7803511?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-chaumont-st-dev","html_url":"https://github.com/cedric-chaumont-st-dev","followers_url":"https://api.github.com/users/cedric-chaumont-st-dev/followers","following_url":"https://api.github.com/users/cedric-chaumont-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/cedric-chaumont-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-chaumont-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-chaumont-st-dev/subscriptions","organizations_url":"https://api.github.com/users/cedric-chaumont-st-dev/orgs","repos_url":"https://api.github.com/users/cedric-chaumont-st-dev/repos","events_url":"https://api.github.com/users/cedric-chaumont-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-chaumont-st-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedric-chaumont-st-dev/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os","forks_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/forks","keys_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/teams","hooks_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/hooks","issue_events_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/events","assignees_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/tags","blobs_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/languages","stargazers_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/stargazers","contributors_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/contributors","subscribers_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/subscribers","subscription_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/subscription","commits_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/merges","archive_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/downloads","issues_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_os/releases{/id}","created_at":"2014-06-12T14:47:54Z","updated_at":"2015-05-07T07:53:43Z","pushed_at":"2015-10-05T15:06:25Z","git_url":"git://github.com/cedric-chaumont-st-dev/optee_os.git","ssh_url":"git@github.com:cedric-chaumont-st-dev/optee_os.git","clone_url":"https://github.com/cedric-chaumont-st-dev/optee_os.git","svn_url":"https://github.com/cedric-chaumont-st-dev/optee_os","homepage":null,"size":4438,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"855ae4e1abed278c1183a89052190fa9cd8f8806","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-10-05T08:13:47Z","pushed_at":"2015-10-05T15:06:26Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":10584,"stargazers_count":64,"watchers_count":64,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":17,"forks":64,"open_issues":17,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/454"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/454"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/3ae333691f8df824177e3869a42d53122658c165"}}}}