{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments/31547255","id":31547255,"diff_hunk":"@@ -80,10 +80,16 @@ const conf = convict({\n     }\n   },\n   expiration: {\n+    // in JavaScript, we live in milliseconds\n+    accessToken: {\n+      doc: 'Access Tokens maximum expiration (can live shorter)',\n+      format: 'duration',\n+      default: 1000 * 60 * 60 * 24 * 2 // 2weeks","path":"lib/config.js","position":8,"original_position":8,"commit_id":"c85f0661699738b80a49d0d78b8f44c14f044ad3","original_commit_id":"c85f0661699738b80a49d0d78b8f44c14f044ad3","user":{"login":"zaach","id":3903,"avatar_url":"https://avatars.githubusercontent.com/u/3903?v=3","gravatar_id":"","url":"https://api.github.com/users/zaach","html_url":"https://github.com/zaach","followers_url":"https://api.github.com/users/zaach/followers","following_url":"https://api.github.com/users/zaach/following{/other_user}","gists_url":"https://api.github.com/users/zaach/gists{/gist_id}","starred_url":"https://api.github.com/users/zaach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaach/subscriptions","organizations_url":"https://api.github.com/users/zaach/orgs","repos_url":"https://api.github.com/users/zaach/repos","events_url":"https://api.github.com/users/zaach/events{/privacy}","received_events_url":"https://api.github.com/users/zaach/received_events","type":"User","site_admin":false},"body":"convict will actually convert `'2 weeks'` into an integer.","created_at":"2015-06-02T17:22:07Z","updated_at":"2015-06-02T17:22:07Z","html_url":"https://github.com/mozilla/fxa-oauth-server/pull/260#discussion_r31547255","pull_request_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments/31547255"},"html":{"href":"https://github.com/mozilla/fxa-oauth-server/pull/260#discussion_r31547255"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260","id":36234591,"html_url":"https://github.com/mozilla/fxa-oauth-server/pull/260","diff_url":"https://github.com/mozilla/fxa-oauth-server/pull/260.diff","patch_url":"https://github.com/mozilla/fxa-oauth-server/pull/260.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/260","number":260,"state":"open","locked":false,"title":"feat(refresh_tokens): add refresh_tokens to /token endpoint","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"All good to go-ish.\r\n\r\nAny test cases I missed with scopes?\r\n\r\nCloses #209 ","created_at":"2015-05-26T19:04:02Z","updated_at":"2015-06-02T17:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d8bc47cfb76050212d692597313d26960a51417","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/260/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/c85f0661699738b80a49d0d78b8f44c14f044ad3","head":{"label":"mozilla:refresh-tokens","ref":"refresh-tokens","sha":"c85f0661699738b80a49d0d78b8f44c14f044ad3","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16819795,"name":"fxa-oauth-server","full_name":"mozilla/fxa-oauth-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-oauth-server","description":"OAuth server for Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-oauth-server","forks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/releases{/id}","created_at":"2014-02-13T22:41:50Z","updated_at":"2015-05-15T13:22:33Z","pushed_at":"2015-06-02T16:50:00Z","git_url":"git://github.com/mozilla/fxa-oauth-server.git","ssh_url":"git@github.com:mozilla/fxa-oauth-server.git","clone_url":"https://github.com/mozilla/fxa-oauth-server.git","svn_url":"https://github.com/mozilla/fxa-oauth-server","homepage":"","size":3551,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":34,"forks":12,"open_issues":34,"watchers":16,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"07efe68605c78b31c3babffeeb398530c9bb66cf","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16819795,"name":"fxa-oauth-server","full_name":"mozilla/fxa-oauth-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-oauth-server","description":"OAuth server for Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-oauth-server","forks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/releases{/id}","created_at":"2014-02-13T22:41:50Z","updated_at":"2015-05-15T13:22:33Z","pushed_at":"2015-06-02T16:50:00Z","git_url":"git://github.com/mozilla/fxa-oauth-server.git","ssh_url":"git@github.com:mozilla/fxa-oauth-server.git","clone_url":"https://github.com/mozilla/fxa-oauth-server.git","svn_url":"https://github.com/mozilla/fxa-oauth-server","homepage":"","size":3551,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":34,"forks":12,"open_issues":34,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260"},"html":{"href":"https://github.com/mozilla/fxa-oauth-server/pull/260"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/260"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/c85f0661699738b80a49d0d78b8f44c14f044ad3"}}}}