{"action":"created","comment":{"url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/comments/32085278","id":32085278,"diff_hunk":"@@ -49,6 +49,16 @@ def nmea_to_deg(nmea):\n         minutes = float(conversion.match(nmea[0]).group(2))/60\n         return (deg + minutes)*negation\n \n+    def speed(self):\n+        \"\"\"\n+        Find the speed in the NMEA text\n+        $GPRMC,194509.000,A,4042.6142,N,07400.4168,W,2.03,221.11,160412,,,A*77\n+        \"\"\"\n+        speed_knots = self.nmea.split(',')[7]\n+        speed_mph = float(speed_knots) * 1.15078\n+        formatted_speed = float(\"{0:.2f}\".format(speed_mph))","path":"gpsweb/models/Location.py","position":11,"original_position":11,"commit_id":"23a26c1cd9061221996638038228d8bcb405082b","original_commit_id":"23a26c1cd9061221996638038228d8bcb405082b","user":{"login":"Kartstig","id":2031422,"avatar_url":"https://avatars.githubusercontent.com/u/2031422?v=3","gravatar_id":"","url":"https://api.github.com/users/Kartstig","html_url":"https://github.com/Kartstig","followers_url":"https://api.github.com/users/Kartstig/followers","following_url":"https://api.github.com/users/Kartstig/following{/other_user}","gists_url":"https://api.github.com/users/Kartstig/gists{/gist_id}","starred_url":"https://api.github.com/users/Kartstig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kartstig/subscriptions","organizations_url":"https://api.github.com/users/Kartstig/orgs","repos_url":"https://api.github.com/users/Kartstig/repos","events_url":"https://api.github.com/users/Kartstig/events{/privacy}","received_events_url":"https://api.github.com/users/Kartstig/received_events","type":"User","site_admin":false},"body":"The casting to float twice seems pretty unnecessary. I'm also going to be strict here because you know a lot more theory than I do. Can you explain why your speed calculation is going to be off?","created_at":"2015-06-10T03:12:12Z","updated_at":"2015-06-10T03:12:12Z","html_url":"https://github.com/Kartstig/gps-tracker/pull/1#discussion_r32085278","pull_request_url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/comments/32085278"},"html":{"href":"https://github.com/Kartstig/gps-tracker/pull/1#discussion_r32085278"},"pull_request":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1","id":37302461,"html_url":"https://github.com/Kartstig/gps-tracker/pull/1","diff_url":"https://github.com/Kartstig/gps-tracker/pull/1.diff","patch_url":"https://github.com/Kartstig/gps-tracker/pull/1.patch","issue_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues/1","number":1,"state":"open","locked":false,"title":"Feras branch","user":{"login":"FerasDA","id":6404662,"avatar_url":"https://avatars.githubusercontent.com/u/6404662?v=3","gravatar_id":"","url":"https://api.github.com/users/FerasDA","html_url":"https://github.com/FerasDA","followers_url":"https://api.github.com/users/FerasDA/followers","following_url":"https://api.github.com/users/FerasDA/following{/other_user}","gists_url":"https://api.github.com/users/FerasDA/gists{/gist_id}","starred_url":"https://api.github.com/users/FerasDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FerasDA/subscriptions","organizations_url":"https://api.github.com/users/FerasDA/orgs","repos_url":"https://api.github.com/users/FerasDA/repos","events_url":"https://api.github.com/users/FerasDA/events{/privacy}","received_events_url":"https://api.github.com/users/FerasDA/received_events","type":"User","site_admin":false},"body":"Add velocity to GPS Tracker App","created_at":"2015-06-09T21:32:26Z","updated_at":"2015-06-10T03:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0858f5e064aede67f6e2ed3021d0cfb78b6b2afa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues/1/comments","statuses_url":"https://api.github.com/repos/Kartstig/gps-tracker/statuses/23a26c1cd9061221996638038228d8bcb405082b","head":{"label":"Kartstig:FerasBranch","ref":"FerasBranch","sha":"23a26c1cd9061221996638038228d8bcb405082b","user":{"login":"Kartstig","id":2031422,"avatar_url":"https://avatars.githubusercontent.com/u/2031422?v=3","gravatar_id":"","url":"https://api.github.com/users/Kartstig","html_url":"https://github.com/Kartstig","followers_url":"https://api.github.com/users/Kartstig/followers","following_url":"https://api.github.com/users/Kartstig/following{/other_user}","gists_url":"https://api.github.com/users/Kartstig/gists{/gist_id}","starred_url":"https://api.github.com/users/Kartstig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kartstig/subscriptions","organizations_url":"https://api.github.com/users/Kartstig/orgs","repos_url":"https://api.github.com/users/Kartstig/repos","events_url":"https://api.github.com/users/Kartstig/events{/privacy}","received_events_url":"https://api.github.com/users/Kartstig/received_events","type":"User","site_admin":false},"repo":{"id":35968886,"name":"gps-tracker","full_name":"Kartstig/gps-tracker","owner":{"login":"Kartstig","id":2031422,"avatar_url":"https://avatars.githubusercontent.com/u/2031422?v=3","gravatar_id":"","url":"https://api.github.com/users/Kartstig","html_url":"https://github.com/Kartstig","followers_url":"https://api.github.com/users/Kartstig/followers","following_url":"https://api.github.com/users/Kartstig/following{/other_user}","gists_url":"https://api.github.com/users/Kartstig/gists{/gist_id}","starred_url":"https://api.github.com/users/Kartstig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kartstig/subscriptions","organizations_url":"https://api.github.com/users/Kartstig/orgs","repos_url":"https://api.github.com/users/Kartstig/repos","events_url":"https://api.github.com/users/Kartstig/events{/privacy}","received_events_url":"https://api.github.com/users/Kartstig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kartstig/gps-tracker","description":"GPS Tracking System","fork":false,"url":"https://api.github.com/repos/Kartstig/gps-tracker","forks_url":"https://api.github.com/repos/Kartstig/gps-tracker/forks","keys_url":"https://api.github.com/repos/Kartstig/gps-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kartstig/gps-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kartstig/gps-tracker/teams","hooks_url":"https://api.github.com/repos/Kartstig/gps-tracker/hooks","issue_events_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/Kartstig/gps-tracker/events","assignees_url":"https://api.github.com/repos/Kartstig/gps-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/Kartstig/gps-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/Kartstig/gps-tracker/tags","blobs_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kartstig/gps-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/Kartstig/gps-tracker/languages","stargazers_url":"https://api.github.com/repos/Kartstig/gps-tracker/stargazers","contributors_url":"https://api.github.com/repos/Kartstig/gps-tracker/contributors","subscribers_url":"https://api.github.com/repos/Kartstig/gps-tracker/subscribers","subscription_url":"https://api.github.com/repos/Kartstig/gps-tracker/subscription","commits_url":"https://api.github.com/repos/Kartstig/gps-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kartstig/gps-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kartstig/gps-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/Kartstig/gps-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kartstig/gps-tracker/merges","archive_url":"https://api.github.com/repos/Kartstig/gps-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kartstig/gps-tracker/downloads","issues_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/Kartstig/gps-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/Kartstig/gps-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kartstig/gps-tracker/labels{/name}","releases_url":"https://api.github.com/repos/Kartstig/gps-tracker/releases{/id}","created_at":"2015-05-20T19:15:15Z","updated_at":"2015-05-20T22:38:02Z","pushed_at":"2015-06-09T21:32:26Z","git_url":"git://github.com/Kartstig/gps-tracker.git","ssh_url":"git@github.com:Kartstig/gps-tracker.git","clone_url":"https://github.com/Kartstig/gps-tracker.git","svn_url":"https://github.com/Kartstig/gps-tracker","homepage":null,"size":216,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Kartstig:master","ref":"master","sha":"a99c0c12b3c0f28acb8ff1544f908bef90a9cf7c","user":{"login":"Kartstig","id":2031422,"avatar_url":"https://avatars.githubusercontent.com/u/2031422?v=3","gravatar_id":"","url":"https://api.github.com/users/Kartstig","html_url":"https://github.com/Kartstig","followers_url":"https://api.github.com/users/Kartstig/followers","following_url":"https://api.github.com/users/Kartstig/following{/other_user}","gists_url":"https://api.github.com/users/Kartstig/gists{/gist_id}","starred_url":"https://api.github.com/users/Kartstig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kartstig/subscriptions","organizations_url":"https://api.github.com/users/Kartstig/orgs","repos_url":"https://api.github.com/users/Kartstig/repos","events_url":"https://api.github.com/users/Kartstig/events{/privacy}","received_events_url":"https://api.github.com/users/Kartstig/received_events","type":"User","site_admin":false},"repo":{"id":35968886,"name":"gps-tracker","full_name":"Kartstig/gps-tracker","owner":{"login":"Kartstig","id":2031422,"avatar_url":"https://avatars.githubusercontent.com/u/2031422?v=3","gravatar_id":"","url":"https://api.github.com/users/Kartstig","html_url":"https://github.com/Kartstig","followers_url":"https://api.github.com/users/Kartstig/followers","following_url":"https://api.github.com/users/Kartstig/following{/other_user}","gists_url":"https://api.github.com/users/Kartstig/gists{/gist_id}","starred_url":"https://api.github.com/users/Kartstig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kartstig/subscriptions","organizations_url":"https://api.github.com/users/Kartstig/orgs","repos_url":"https://api.github.com/users/Kartstig/repos","events_url":"https://api.github.com/users/Kartstig/events{/privacy}","received_events_url":"https://api.github.com/users/Kartstig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kartstig/gps-tracker","description":"GPS Tracking System","fork":false,"url":"https://api.github.com/repos/Kartstig/gps-tracker","forks_url":"https://api.github.com/repos/Kartstig/gps-tracker/forks","keys_url":"https://api.github.com/repos/Kartstig/gps-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kartstig/gps-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kartstig/gps-tracker/teams","hooks_url":"https://api.github.com/repos/Kartstig/gps-tracker/hooks","issue_events_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/Kartstig/gps-tracker/events","assignees_url":"https://api.github.com/repos/Kartstig/gps-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/Kartstig/gps-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/Kartstig/gps-tracker/tags","blobs_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kartstig/gps-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/Kartstig/gps-tracker/languages","stargazers_url":"https://api.github.com/repos/Kartstig/gps-tracker/stargazers","contributors_url":"https://api.github.com/repos/Kartstig/gps-tracker/contributors","subscribers_url":"https://api.github.com/repos/Kartstig/gps-tracker/subscribers","subscription_url":"https://api.github.com/repos/Kartstig/gps-tracker/subscription","commits_url":"https://api.github.com/repos/Kartstig/gps-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kartstig/gps-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kartstig/gps-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kartstig/gps-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/Kartstig/gps-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kartstig/gps-tracker/merges","archive_url":"https://api.github.com/repos/Kartstig/gps-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kartstig/gps-tracker/downloads","issues_url":"https://api.github.com/repos/Kartstig/gps-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/Kartstig/gps-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/Kartstig/gps-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/Kartstig/gps-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kartstig/gps-tracker/labels{/name}","releases_url":"https://api.github.com/repos/Kartstig/gps-tracker/releases{/id}","created_at":"2015-05-20T19:15:15Z","updated_at":"2015-05-20T22:38:02Z","pushed_at":"2015-06-09T21:32:26Z","git_url":"git://github.com/Kartstig/gps-tracker.git","ssh_url":"git@github.com:Kartstig/gps-tracker.git","clone_url":"https://github.com/Kartstig/gps-tracker.git","svn_url":"https://github.com/Kartstig/gps-tracker","homepage":null,"size":216,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1"},"html":{"href":"https://github.com/Kartstig/gps-tracker/pull/1"},"issue":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/issues/1"},"comments":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Kartstig/gps-tracker/statuses/23a26c1cd9061221996638038228d8bcb405082b"}}}}