{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments/37127390","id":37127390,"diff_hunk":"@@ -126,6 +147,57 @@ public String toString() {\n \n \n \t/**\n+\t * Build a list of ModuleDefinitions out of a parsed StreamNode.\n+\t *\n+\t * @param name the name of the definition unit\n+\t * @param stream the AST construct representing the definition\n+\t */\n+\tprivate static List<ModuleDefinition> buildModuleDefinitions(String name, StreamNode stream) {","path":"spring-cloud-data-core/src/main/java/org/springframework/cloud/data/core/StreamDefinition.java","position":65,"original_position":65,"commit_id":"0031fab5024b1659b6fe86b5104211c2472777a6","original_commit_id":"0031fab5024b1659b6fe86b5104211c2472777a6","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"Agreed. I will move into a ModuleDefintionBuilder in the dsl package. At first I was trying to keep it as similar to TaskDefinition as possible, but the TaskNode is a much simpler class, and nothing like this method was needed for task parsing. By the way this doesn't need to be static, but it is just used once and has no state other than its params, and is called from the constructor (so for those reasons I opted for static). That said, the builder in the dsl package would be cleaner.","created_at":"2015-08-14T23:06:32Z","updated_at":"2015-08-14T23:06:32Z","html_url":"https://github.com/spring-cloud/spring-cloud-data/pull/48#discussion_r37127390","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments/37127390"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-data/pull/48#discussion_r37127390"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48","id":42505581,"html_url":"https://github.com/spring-cloud/spring-cloud-data/pull/48","diff_url":"https://github.com/spring-cloud/spring-cloud-data/pull/48.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-data/pull/48.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/48","number":48,"state":"open","locked":false,"title":"removed StreamDefinitionParser","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-14T22:56:24Z","updated_at":"2015-08-14T23:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0af0508deec00642d15ec3348f383f2d9a0ba23d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/48/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/statuses/0031fab5024b1659b6fe86b5104211c2472777a6","head":{"label":"markfisher:remove-stream-definition-parser","ref":"remove-stream-definition-parser","sha":"0031fab5024b1659b6fe86b5104211c2472777a6","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"repo":{"id":39469527,"name":"spring-cloud-data","full_name":"markfisher/spring-cloud-data","owner":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markfisher/spring-cloud-data","description":"","fork":true,"url":"https://api.github.com/repos/markfisher/spring-cloud-data","forks_url":"https://api.github.com/repos/markfisher/spring-cloud-data/forks","keys_url":"https://api.github.com/repos/markfisher/spring-cloud-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markfisher/spring-cloud-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markfisher/spring-cloud-data/teams","hooks_url":"https://api.github.com/repos/markfisher/spring-cloud-data/hooks","issue_events_url":"https://api.github.com/repos/markfisher/spring-cloud-data/issues/events{/number}","events_url":"https://api.github.com/repos/markfisher/spring-cloud-data/events","assignees_url":"https://api.github.com/repos/markfisher/spring-cloud-data/assignees{/user}","branches_url":"https://api.github.com/repos/markfisher/spring-cloud-data/branches{/branch}","tags_url":"https://api.github.com/repos/markfisher/spring-cloud-data/tags","blobs_url":"https://api.github.com/repos/markfisher/spring-cloud-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markfisher/spring-cloud-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markfisher/spring-cloud-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/markfisher/spring-cloud-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markfisher/spring-cloud-data/statuses/{sha}","languages_url":"https://api.github.com/repos/markfisher/spring-cloud-data/languages","stargazers_url":"https://api.github.com/repos/markfisher/spring-cloud-data/stargazers","contributors_url":"https://api.github.com/repos/markfisher/spring-cloud-data/contributors","subscribers_url":"https://api.github.com/repos/markfisher/spring-cloud-data/subscribers","subscription_url":"https://api.github.com/repos/markfisher/spring-cloud-data/subscription","commits_url":"https://api.github.com/repos/markfisher/spring-cloud-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/markfisher/spring-cloud-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/markfisher/spring-cloud-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/markfisher/spring-cloud-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/markfisher/spring-cloud-data/contents/{+path}","compare_url":"https://api.github.com/repos/markfisher/spring-cloud-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markfisher/spring-cloud-data/merges","archive_url":"https://api.github.com/repos/markfisher/spring-cloud-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markfisher/spring-cloud-data/downloads","issues_url":"https://api.github.com/repos/markfisher/spring-cloud-data/issues{/number}","pulls_url":"https://api.github.com/repos/markfisher/spring-cloud-data/pulls{/number}","milestones_url":"https://api.github.com/repos/markfisher/spring-cloud-data/milestones{/number}","notifications_url":"https://api.github.com/repos/markfisher/spring-cloud-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markfisher/spring-cloud-data/labels{/name}","releases_url":"https://api.github.com/repos/markfisher/spring-cloud-data/releases{/id}","created_at":"2015-07-21T20:57:06Z","updated_at":"2015-07-22T19:38:20Z","pushed_at":"2015-08-14T22:55:31Z","git_url":"git://github.com/markfisher/spring-cloud-data.git","ssh_url":"git@github.com:markfisher/spring-cloud-data.git","clone_url":"https://github.com/markfisher/spring-cloud-data.git","svn_url":"https://github.com/markfisher/spring-cloud-data","homepage":null,"size":438,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"cc55eea8eca46e33b993eb9567ad3b6cbca311a6","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-data","full_name":"spring-cloud/spring-cloud-data","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-data","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-data","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/releases{/id}","created_at":"2015-07-21T20:56:11Z","updated_at":"2015-08-07T16:39:03Z","pushed_at":"2015-08-14T22:56:25Z","git_url":"git://github.com/spring-cloud/spring-cloud-data.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-data.git","clone_url":"https://github.com/spring-cloud/spring-cloud-data.git","svn_url":"https://github.com/spring-cloud/spring-cloud-data","homepage":null,"size":851,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-data/pull/48"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/48"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/statuses/0031fab5024b1659b6fe86b5104211c2472777a6"}}}}