{"action":"closed","number":558,"pull_request":{"url":"https://api.github.com/repos/btcsuite/btcd/pulls/558","id":51459248,"html_url":"https://github.com/btcsuite/btcd/pull/558","diff_url":"https://github.com/btcsuite/btcd/pull/558.diff","patch_url":"https://github.com/btcsuite/btcd/pull/558.patch","issue_url":"https://api.github.com/repos/btcsuite/btcd/issues/558","number":558,"state":"closed","locked":false,"title":"mining: Remove comment and change fee calc to int.","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"body":"Now that the memory pool minimum fee calculation code is also calculating a more precise value instead of rounding up to the nearest kilobyte boundary, the comment in `NewBlockTemplate` regarding this behavior is no longer accurate.  Thus, this removes the comment.\r\n\r\nAlso, while here, change the calculation to use an int64 instead of float since it matches the precision of the new calculation code used by the memory pool and can also avoid the need for the slower floating point math.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/btcsuite/btcd/558)\n<!-- Reviewable:end -->\n","created_at":"2015-11-22T06:58:57Z","updated_at":"2015-11-24T03:56:06Z","closed_at":"2015-11-24T03:56:06Z","merged_at":"2015-11-24T03:56:06Z","merge_commit_sha":"5f28f8ab7c510fe9464f81835c65b5264da1de39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/btcsuite/btcd/pulls/558/commits","review_comments_url":"https://api.github.com/repos/btcsuite/btcd/pulls/558/comments","review_comment_url":"https://api.github.com/repos/btcsuite/btcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/btcsuite/btcd/issues/558/comments","statuses_url":"https://api.github.com/repos/btcsuite/btcd/statuses/2799ddf538cddc5721f58761d7f60ddb7e766a6b","head":{"label":"davecgh:update_blocktemplate_feeperkb","ref":"update_blocktemplate_feeperkb","sha":"2799ddf538cddc5721f58761d7f60ddb7e766a6b","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"repo":{"id":16972952,"name":"btcd","full_name":"davecgh/btcd","owner":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davecgh/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":true,"url":"https://api.github.com/repos/davecgh/btcd","forks_url":"https://api.github.com/repos/davecgh/btcd/forks","keys_url":"https://api.github.com/repos/davecgh/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davecgh/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davecgh/btcd/teams","hooks_url":"https://api.github.com/repos/davecgh/btcd/hooks","issue_events_url":"https://api.github.com/repos/davecgh/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/davecgh/btcd/events","assignees_url":"https://api.github.com/repos/davecgh/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/davecgh/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/davecgh/btcd/tags","blobs_url":"https://api.github.com/repos/davecgh/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davecgh/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davecgh/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/davecgh/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davecgh/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/davecgh/btcd/languages","stargazers_url":"https://api.github.com/repos/davecgh/btcd/stargazers","contributors_url":"https://api.github.com/repos/davecgh/btcd/contributors","subscribers_url":"https://api.github.com/repos/davecgh/btcd/subscribers","subscription_url":"https://api.github.com/repos/davecgh/btcd/subscription","commits_url":"https://api.github.com/repos/davecgh/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/davecgh/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/davecgh/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/davecgh/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/davecgh/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/davecgh/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davecgh/btcd/merges","archive_url":"https://api.github.com/repos/davecgh/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davecgh/btcd/downloads","issues_url":"https://api.github.com/repos/davecgh/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/davecgh/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/davecgh/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/davecgh/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davecgh/btcd/labels{/name}","releases_url":"https://api.github.com/repos/davecgh/btcd/releases{/id}","created_at":"2014-02-19T03:45:51Z","updated_at":"2015-04-21T20:13:13Z","pushed_at":"2015-11-24T03:52:45Z","git_url":"git://github.com/davecgh/btcd.git","ssh_url":"git@github.com:davecgh/btcd.git","clone_url":"https://github.com/davecgh/btcd.git","svn_url":"https://github.com/davecgh/btcd","homepage":null,"size":9315,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"btcsuite:master","ref":"master","sha":"09874f1e9115b56573168cf2d310357356c9d80a","user":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":11931032,"name":"btcd","full_name":"btcsuite/btcd","owner":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/btcsuite/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":false,"url":"https://api.github.com/repos/btcsuite/btcd","forks_url":"https://api.github.com/repos/btcsuite/btcd/forks","keys_url":"https://api.github.com/repos/btcsuite/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btcsuite/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btcsuite/btcd/teams","hooks_url":"https://api.github.com/repos/btcsuite/btcd/hooks","issue_events_url":"https://api.github.com/repos/btcsuite/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/btcsuite/btcd/events","assignees_url":"https://api.github.com/repos/btcsuite/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/btcsuite/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/btcsuite/btcd/tags","blobs_url":"https://api.github.com/repos/btcsuite/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btcsuite/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btcsuite/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/btcsuite/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btcsuite/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/btcsuite/btcd/languages","stargazers_url":"https://api.github.com/repos/btcsuite/btcd/stargazers","contributors_url":"https://api.github.com/repos/btcsuite/btcd/contributors","subscribers_url":"https://api.github.com/repos/btcsuite/btcd/subscribers","subscription_url":"https://api.github.com/repos/btcsuite/btcd/subscription","commits_url":"https://api.github.com/repos/btcsuite/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/btcsuite/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/btcsuite/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/btcsuite/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/btcsuite/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/btcsuite/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btcsuite/btcd/merges","archive_url":"https://api.github.com/repos/btcsuite/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btcsuite/btcd/downloads","issues_url":"https://api.github.com/repos/btcsuite/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/btcsuite/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/btcsuite/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/btcsuite/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btcsuite/btcd/labels{/name}","releases_url":"https://api.github.com/repos/btcsuite/btcd/releases{/id}","created_at":"2013-08-06T18:10:52Z","updated_at":"2015-11-23T22:56:40Z","pushed_at":"2015-11-24T03:56:05Z","git_url":"git://github.com/btcsuite/btcd.git","ssh_url":"git@github.com:btcsuite/btcd.git","clone_url":"https://github.com/btcsuite/btcd.git","svn_url":"https://github.com/btcsuite/btcd","homepage":"https://github.com/btcsuite/btcd/blob/master/docs/README.md","size":14558,"stargazers_count":714,"watchers_count":714,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":46,"forks":158,"open_issues":46,"watchers":714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/558"},"html":{"href":"https://github.com/btcsuite/btcd/pull/558"},"issue":{"href":"https://api.github.com/repos/btcsuite/btcd/issues/558"},"comments":{"href":"https://api.github.com/repos/btcsuite/btcd/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/btcsuite/btcd/statuses/2799ddf538cddc5721f58761d7f60ddb7e766a6b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"conformal-deploy","id":4398447,"avatar_url":"https://avatars.githubusercontent.com/u/4398447?v=3","gravatar_id":"","url":"https://api.github.com/users/conformal-deploy","html_url":"https://github.com/conformal-deploy","followers_url":"https://api.github.com/users/conformal-deploy/followers","following_url":"https://api.github.com/users/conformal-deploy/following{/other_user}","gists_url":"https://api.github.com/users/conformal-deploy/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal-deploy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal-deploy/subscriptions","organizations_url":"https://api.github.com/users/conformal-deploy/orgs","repos_url":"https://api.github.com/users/conformal-deploy/repos","events_url":"https://api.github.com/users/conformal-deploy/events{/privacy}","received_events_url":"https://api.github.com/users/conformal-deploy/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":8,"changed_files":1}}