{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/2","id":46732944,"html_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/2","diff_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/2.diff","patch_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/2.patch","issue_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/2","number":2,"state":"open","locked":false,"title":"require jquery to fix it in firefox, some ui tweaks","user":{"login":"tduva","id":5621113,"avatar_url":"https://avatars.githubusercontent.com/u/5621113?v=3","gravatar_id":"","url":"https://api.github.com/users/tduva","html_url":"https://github.com/tduva","followers_url":"https://api.github.com/users/tduva/followers","following_url":"https://api.github.com/users/tduva/following{/other_user}","gists_url":"https://api.github.com/users/tduva/gists{/gist_id}","starred_url":"https://api.github.com/users/tduva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tduva/subscriptions","organizations_url":"https://api.github.com/users/tduva/orgs","repos_url":"https://api.github.com/users/tduva/repos","events_url":"https://api.github.com/users/tduva/events{/privacy}","received_events_url":"https://api.github.com/users/tduva/received_events","type":"User","site_admin":false},"body":"Most importantly adding the `@grant GM_addStyle` completely broke it in Firefox, because apparently changing it from the default (no `@grant` specified at all) prevents you from accessing the jQuery in the site itself. I required our own version of jQuery to fix this as suggested in [this SO question](http://stackoverflow.com/questions/25532475/adding-a-grant-value-breaks-my-greasemonkeyjquery-script).\r\n\r\nI think it would be a good idea to test all changes in Firefox and Chrome, at least roughly.\r\n\r\nI'm not quite sure why you added `GM_addStyle(\"select:-moz-focusring { outline: none; }\");`, that would suggest it's more Mozilla, but I had the problem with the focus border on Chrome, so I added `GM_addStyle(\".js-quality:focus { outline: none; }\");`. Maybe I'm understanding something wrong or there was a miscommunication. I only apply it to the `.js-quality` class to prevent any other possible select boxes on the page to be affected, if that may be a problem. I'm not sure if we can remove the other one or if it still does anything useful.\r\n\r\nThe vertical alignment of the quality selector is still inconsistent between browsers, I tried a new approach and it seems the same height in Chrome and possibly a bit better in Firefox. Hopefully we'll find a better solution for that.\r\n\r\nI moved the styling of the options out of the on hover, because it meant that the quality selection moved when you hovered over it the first time on Firefox. And I think it makes more sense to only change on hover what you actually need to change. I also set the font-weight to normal for the options, because they were bold in Firefox, but not in Chrome. Seems like these things work differently between browsers. I think it makes sense to only have the quality selector bold and not the options.\r\n\r\nI also updated the README with some installation instructions. Feel free to correct it if there's something wrong. Have you advertised this anywhere yet? It's pretty early in development of course, but I think it can already be helpful.","created_at":"2015-10-04T20:51:46Z","updated_at":"2015-10-04T20:51:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/2/commits","review_comments_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/2/comments","review_comment_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/2/comments","statuses_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/statuses/def68db4bcda97d27dd81bbc62b6d31b4c6e5a7b","head":{"label":"tduva:ui-tweaks","ref":"ui-tweaks","sha":"def68db4bcda97d27dd81bbc62b6d31b4c6e5a7b","user":{"login":"tduva","id":5621113,"avatar_url":"https://avatars.githubusercontent.com/u/5621113?v=3","gravatar_id":"","url":"https://api.github.com/users/tduva","html_url":"https://github.com/tduva","followers_url":"https://api.github.com/users/tduva/followers","following_url":"https://api.github.com/users/tduva/following{/other_user}","gists_url":"https://api.github.com/users/tduva/gists{/gist_id}","starred_url":"https://api.github.com/users/tduva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tduva/subscriptions","organizations_url":"https://api.github.com/users/tduva/orgs","repos_url":"https://api.github.com/users/tduva/repos","events_url":"https://api.github.com/users/tduva/events{/privacy}","received_events_url":"https://api.github.com/users/tduva/received_events","type":"User","site_admin":false},"repo":{"id":43606878,"name":"TwitchPlayerPlus","full_name":"tduva/TwitchPlayerPlus","owner":{"login":"tduva","id":5621113,"avatar_url":"https://avatars.githubusercontent.com/u/5621113?v=3","gravatar_id":"","url":"https://api.github.com/users/tduva","html_url":"https://github.com/tduva","followers_url":"https://api.github.com/users/tduva/followers","following_url":"https://api.github.com/users/tduva/following{/other_user}","gists_url":"https://api.github.com/users/tduva/gists{/gist_id}","starred_url":"https://api.github.com/users/tduva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tduva/subscriptions","organizations_url":"https://api.github.com/users/tduva/orgs","repos_url":"https://api.github.com/users/tduva/repos","events_url":"https://api.github.com/users/tduva/events{/privacy}","received_events_url":"https://api.github.com/users/tduva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tduva/TwitchPlayerPlus","description":"A set of tweaks for the HTML5 Twitch Player","fork":true,"url":"https://api.github.com/repos/tduva/TwitchPlayerPlus","forks_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/forks","keys_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/teams","hooks_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/hooks","issue_events_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/issues/events{/number}","events_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/events","assignees_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/assignees{/user}","branches_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/branches{/branch}","tags_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/tags","blobs_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/languages","stargazers_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/stargazers","contributors_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/contributors","subscribers_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/subscribers","subscription_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/subscription","commits_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/contents/{+path}","compare_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/merges","archive_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/downloads","issues_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/issues{/number}","pulls_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/labels{/name}","releases_url":"https://api.github.com/repos/tduva/TwitchPlayerPlus/releases{/id}","created_at":"2015-10-03T17:06:09Z","updated_at":"2015-10-03T17:06:10Z","pushed_at":"2015-10-04T20:34:41Z","git_url":"git://github.com/tduva/TwitchPlayerPlus.git","ssh_url":"git@github.com:tduva/TwitchPlayerPlus.git","clone_url":"https://github.com/tduva/TwitchPlayerPlus.git","svn_url":"https://github.com/tduva/TwitchPlayerPlus","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EhsanKia:master","ref":"master","sha":"e9768b5dff40b41815427666676ad5b64da65b47","user":{"login":"EhsanKia","id":1619970,"avatar_url":"https://avatars.githubusercontent.com/u/1619970?v=3","gravatar_id":"","url":"https://api.github.com/users/EhsanKia","html_url":"https://github.com/EhsanKia","followers_url":"https://api.github.com/users/EhsanKia/followers","following_url":"https://api.github.com/users/EhsanKia/following{/other_user}","gists_url":"https://api.github.com/users/EhsanKia/gists{/gist_id}","starred_url":"https://api.github.com/users/EhsanKia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EhsanKia/subscriptions","organizations_url":"https://api.github.com/users/EhsanKia/orgs","repos_url":"https://api.github.com/users/EhsanKia/repos","events_url":"https://api.github.com/users/EhsanKia/events{/privacy}","received_events_url":"https://api.github.com/users/EhsanKia/received_events","type":"User","site_admin":false},"repo":{"id":43592233,"name":"TwitchPlayerPlus","full_name":"EhsanKia/TwitchPlayerPlus","owner":{"login":"EhsanKia","id":1619970,"avatar_url":"https://avatars.githubusercontent.com/u/1619970?v=3","gravatar_id":"","url":"https://api.github.com/users/EhsanKia","html_url":"https://github.com/EhsanKia","followers_url":"https://api.github.com/users/EhsanKia/followers","following_url":"https://api.github.com/users/EhsanKia/following{/other_user}","gists_url":"https://api.github.com/users/EhsanKia/gists{/gist_id}","starred_url":"https://api.github.com/users/EhsanKia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EhsanKia/subscriptions","organizations_url":"https://api.github.com/users/EhsanKia/orgs","repos_url":"https://api.github.com/users/EhsanKia/repos","events_url":"https://api.github.com/users/EhsanKia/events{/privacy}","received_events_url":"https://api.github.com/users/EhsanKia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EhsanKia/TwitchPlayerPlus","description":"A set of tweaks for the HTML5 Twitch Player","fork":false,"url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus","forks_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/forks","keys_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/teams","hooks_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/hooks","issue_events_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/events{/number}","events_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/events","assignees_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/assignees{/user}","branches_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/branches{/branch}","tags_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/tags","blobs_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/languages","stargazers_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/stargazers","contributors_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/contributors","subscribers_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/subscribers","subscription_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/subscription","commits_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/contents/{+path}","compare_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/merges","archive_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/downloads","issues_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues{/number}","pulls_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/labels{/name}","releases_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/releases{/id}","created_at":"2015-10-03T08:05:28Z","updated_at":"2015-10-03T10:05:38Z","pushed_at":"2015-10-03T23:08:15Z","git_url":"git://github.com/EhsanKia/TwitchPlayerPlus.git","ssh_url":"git@github.com:EhsanKia/TwitchPlayerPlus.git","clone_url":"https://github.com/EhsanKia/TwitchPlayerPlus.git","svn_url":"https://github.com/EhsanKia/TwitchPlayerPlus","homepage":null,"size":0,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/2"},"html":{"href":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/2"},"issue":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/2"},"comments":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/statuses/def68db4bcda97d27dd81bbc62b6d31b4c6e5a7b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":8,"changed_files":2}}