{"action":"created","comment":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/25184442","id":25184442,"diff_hunk":"@@ -105,3 +105,59 @@ describe('Mocha Integration', function() {\n     });\n   });\n });\n+\n+describe('Mocha async \"done\" support', function() {\n+   this.timeout(2*1000);\n+\n+   var waited = false;\n+   var DELAY = 100; // ms enough to notice\n+\n+   // --- First, vanilla mocha \"it\" should support the \"done\" callback correctly.\n+\n+   // This it blocks until 'done' is invoked\n+   it('vanilla delayed', function it_vanillaDelayed(done) {\n+      setTimeout(function delayed_vanillaTimeout() {\n+         waited = true;\n+         done();\n+      }, DELAY);\n+   });\n+\n+   it('vanilla must have waited', function it_vanillaMustHaveWaited() {\n+      assert.strictEqual(waited, true);","path":"javascript/node/selenium-webdriver/test/testing/index_test.js","position":22,"original_position":22,"commit_id":"f6794f6c40e549ef5802ca5f2ba9f860685fa068","original_commit_id":"f6794f6c40e549ef5802ca5f2ba9f860685fa068","user":{"login":"jleyba","id":254985,"avatar_url":"https://avatars.githubusercontent.com/u/254985?v=3","gravatar_id":"","url":"https://api.github.com/users/jleyba","html_url":"https://github.com/jleyba","followers_url":"https://api.github.com/users/jleyba/followers","following_url":"https://api.github.com/users/jleyba/following{/other_user}","gists_url":"https://api.github.com/users/jleyba/gists{/gist_id}","starred_url":"https://api.github.com/users/jleyba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleyba/subscriptions","organizations_url":"https://api.github.com/users/jleyba/orgs","repos_url":"https://api.github.com/users/jleyba/repos","events_url":"https://api.github.com/users/jleyba/events{/privacy}","received_events_url":"https://api.github.com/users/jleyba/received_events","type":"User","site_admin":false},"body":"Tests should not depend on ordering.  Use\r\n\r\n    beforeEach(function() { waited = false; });\r\n    afterEach(function() { assert.strictEqual(waited, true); });","created_at":"2015-02-23T17:48:36Z","updated_at":"2015-02-23T17:48:36Z","html_url":"https://github.com/SeleniumHQ/selenium/pull/317#discussion_r25184442","pull_request_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/25184442"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/317#discussion_r25184442"},"pull_request":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317","id":29737481,"html_url":"https://github.com/SeleniumHQ/selenium/pull/317","diff_url":"https://github.com/SeleniumHQ/selenium/pull/317.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/317.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/317","number":317,"state":"open","locked":false,"title":"Webdriverjs mocha wrapper for 'it' should support the 'done' callback","user":{"login":"tullmann","id":5630863,"avatar_url":"https://avatars.githubusercontent.com/u/5630863?v=3","gravatar_id":"","url":"https://api.github.com/users/tullmann","html_url":"https://github.com/tullmann","followers_url":"https://api.github.com/users/tullmann/followers","following_url":"https://api.github.com/users/tullmann/following{/other_user}","gists_url":"https://api.github.com/users/tullmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tullmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tullmann/subscriptions","organizations_url":"https://api.github.com/users/tullmann/orgs","repos_url":"https://api.github.com/users/tullmann/repos","events_url":"https://api.github.com/users/tullmann/events{/privacy}","received_events_url":"https://api.github.com/users/tullmann/received_events","type":"User","site_admin":false},"body":"This pull request has three changes in it, one fixes some doc typos, one adds a test for the handling of the `done` callback on an `it`, and one patch fixes the bug.\r\n\r\nI believe this it the issue https://code.google.com/p/selenium/issues/detail?id=7277.  The fix in https://code.google.com/p/selenium/source/detail?r=88f6680bf0b5 does not, as far as I can see (or experience), do the right thing.\r\n\r\nI wasn't able to test this through \"./go\" (The documentation step blows up with 604 warnings?), so I only ran the mocha tests manually.","created_at":"2015-02-20T22:35:04Z","updated_at":"2015-02-23T17:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec254fdd4f24b73753176826366fac9eca52e22c","assignee":{"login":"jleyba","id":254985,"avatar_url":"https://avatars.githubusercontent.com/u/254985?v=3","gravatar_id":"","url":"https://api.github.com/users/jleyba","html_url":"https://github.com/jleyba","followers_url":"https://api.github.com/users/jleyba/followers","following_url":"https://api.github.com/users/jleyba/following{/other_user}","gists_url":"https://api.github.com/users/jleyba/gists{/gist_id}","starred_url":"https://api.github.com/users/jleyba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleyba/subscriptions","organizations_url":"https://api.github.com/users/jleyba/orgs","repos_url":"https://api.github.com/users/jleyba/repos","events_url":"https://api.github.com/users/jleyba/events{/privacy}","received_events_url":"https://api.github.com/users/jleyba/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/317/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/f6794f6c40e549ef5802ca5f2ba9f860685fa068","head":{"label":"tullmann:webdriverjs-mocha-async-callback","ref":"webdriverjs-mocha-async-callback","sha":"f6794f6c40e549ef5802ca5f2ba9f860685fa068","user":{"login":"tullmann","id":5630863,"avatar_url":"https://avatars.githubusercontent.com/u/5630863?v=3","gravatar_id":"","url":"https://api.github.com/users/tullmann","html_url":"https://github.com/tullmann","followers_url":"https://api.github.com/users/tullmann/followers","following_url":"https://api.github.com/users/tullmann/following{/other_user}","gists_url":"https://api.github.com/users/tullmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tullmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tullmann/subscriptions","organizations_url":"https://api.github.com/users/tullmann/orgs","repos_url":"https://api.github.com/users/tullmann/repos","events_url":"https://api.github.com/users/tullmann/events{/privacy}","received_events_url":"https://api.github.com/users/tullmann/received_events","type":"User","site_admin":false},"repo":{"id":30980494,"name":"selenium","full_name":"tullmann/selenium","owner":{"login":"tullmann","id":5630863,"avatar_url":"https://avatars.githubusercontent.com/u/5630863?v=3","gravatar_id":"","url":"https://api.github.com/users/tullmann","html_url":"https://github.com/tullmann","followers_url":"https://api.github.com/users/tullmann/followers","following_url":"https://api.github.com/users/tullmann/following{/other_user}","gists_url":"https://api.github.com/users/tullmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tullmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tullmann/subscriptions","organizations_url":"https://api.github.com/users/tullmann/orgs","repos_url":"https://api.github.com/users/tullmann/repos","events_url":"https://api.github.com/users/tullmann/events{/privacy}","received_events_url":"https://api.github.com/users/tullmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tullmann/selenium","description":"A mirror of the Selenium source. Please file issues in Google Code. Also confirm you have signed the CLA (http://goo.gl/qC50R) when making a Pull Request.","fork":true,"url":"https://api.github.com/repos/tullmann/selenium","forks_url":"https://api.github.com/repos/tullmann/selenium/forks","keys_url":"https://api.github.com/repos/tullmann/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tullmann/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tullmann/selenium/teams","hooks_url":"https://api.github.com/repos/tullmann/selenium/hooks","issue_events_url":"https://api.github.com/repos/tullmann/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/tullmann/selenium/events","assignees_url":"https://api.github.com/repos/tullmann/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/tullmann/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/tullmann/selenium/tags","blobs_url":"https://api.github.com/repos/tullmann/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tullmann/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tullmann/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/tullmann/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tullmann/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/tullmann/selenium/languages","stargazers_url":"https://api.github.com/repos/tullmann/selenium/stargazers","contributors_url":"https://api.github.com/repos/tullmann/selenium/contributors","subscribers_url":"https://api.github.com/repos/tullmann/selenium/subscribers","subscription_url":"https://api.github.com/repos/tullmann/selenium/subscription","commits_url":"https://api.github.com/repos/tullmann/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/tullmann/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/tullmann/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/tullmann/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/tullmann/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/tullmann/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tullmann/selenium/merges","archive_url":"https://api.github.com/repos/tullmann/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tullmann/selenium/downloads","issues_url":"https://api.github.com/repos/tullmann/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/tullmann/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/tullmann/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/tullmann/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tullmann/selenium/labels{/name}","releases_url":"https://api.github.com/repos/tullmann/selenium/releases{/id}","created_at":"2015-02-18T18:45:36Z","updated_at":"2015-02-18T18:45:50Z","pushed_at":"2015-02-20T22:20:37Z","git_url":"git://github.com/tullmann/selenium.git","ssh_url":"git@github.com:tullmann/selenium.git","clone_url":"https://github.com/tullmann/selenium.git","svn_url":"https://github.com/tullmann/selenium","homepage":"https://code.google.com/p/selenium/","size":1120956,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"da11d39a7884af64000c4875597583610abb7f79","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A mirror of the Selenium source. Please file issues in Google Code. Also confirm you have signed the CLA (http://goo.gl/qC50R) when making a Pull Request.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","created_at":"2013-01-14T21:40:56Z","updated_at":"2015-02-23T05:24:35Z","pushed_at":"2015-02-21T18:28:13Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"https://code.google.com/p/selenium/","size":1186484,"stargazers_count":622,"watchers_count":622,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":586,"mirror_url":"https://code.google.com/p/selenium/","open_issues_count":48,"forks":586,"open_issues":48,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/317"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/317"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/f6794f6c40e549ef5802ca5f2ba9f860685fa068"}}}}