{"action":"created","issue":{"url":"https://api.github.com/repos/coldfix/udiskie/issues/77","labels_url":"https://api.github.com/repos/coldfix/udiskie/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/coldfix/udiskie/issues/77/comments","events_url":"https://api.github.com/repos/coldfix/udiskie/issues/77/events","html_url":"https://github.com/coldfix/udiskie/pull/77","id":107671644,"number":77,"title":"Add exception check for missing Notify typelib","user":{"login":"khardix","id":2243379,"avatar_url":"https://avatars.githubusercontent.com/u/2243379?v=3","gravatar_id":"","url":"https://api.github.com/users/khardix","html_url":"https://github.com/khardix","followers_url":"https://api.github.com/users/khardix/followers","following_url":"https://api.github.com/users/khardix/following{/other_user}","gists_url":"https://api.github.com/users/khardix/gists{/gist_id}","starred_url":"https://api.github.com/users/khardix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khardix/subscriptions","organizations_url":"https://api.github.com/users/khardix/orgs","repos_url":"https://api.github.com/users/khardix/repos","events_url":"https://api.github.com/users/khardix/events{/privacy}","received_events_url":"https://api.github.com/users/khardix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T09:01:26Z","updated_at":"2015-09-22T11:21:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coldfix/udiskie/pulls/77","html_url":"https://github.com/coldfix/udiskie/pull/77","diff_url":"https://github.com/coldfix/udiskie/pull/77.diff","patch_url":"https://github.com/coldfix/udiskie/pull/77.patch"},"body":"When running udiskie without installed libnotify and leaving default options for the daemon in place, the daemon's setup fails when it tries to load nonexistent `gi.repository.Notify`.\r\n\r\nThis patch adds a quick try/except check around the typelib loading, which should log warning about missing typelib and then continue the setup."},"comment":{"url":"https://api.github.com/repos/coldfix/udiskie/issues/comments/142257945","html_url":"https://github.com/coldfix/udiskie/pull/77#issuecomment-142257945","issue_url":"https://api.github.com/repos/coldfix/udiskie/issues/77","id":142257945,"user":{"login":"coldfix","id":1816880,"avatar_url":"https://avatars.githubusercontent.com/u/1816880?v=3","gravatar_id":"","url":"https://api.github.com/users/coldfix","html_url":"https://github.com/coldfix","followers_url":"https://api.github.com/users/coldfix/followers","following_url":"https://api.github.com/users/coldfix/following{/other_user}","gists_url":"https://api.github.com/users/coldfix/gists{/gist_id}","starred_url":"https://api.github.com/users/coldfix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coldfix/subscriptions","organizations_url":"https://api.github.com/users/coldfix/orgs","repos_url":"https://api.github.com/users/coldfix/repos","events_url":"https://api.github.com/users/coldfix/events{/privacy}","received_events_url":"https://api.github.com/users/coldfix/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T11:21:42Z","updated_at":"2015-09-22T11:21:42Z","body":"Hey,\r\n\r\nI'll think about this. I see your point that failing to start the application because of an optional feature isn't very sensible when using the default parameters. On the other hand failing seems just the right thing to do, when udiskie is started with explicit request for notifications. I can see the following alternative solutions:\r\n\r\n- just improve error message when failing due to missing typelib (what went wrong? what can be done about it?)\r\n- fail if notifications are requested explicitly on the command line, just warn if using the default\r\n- disable notifications by default (which I think should have been the default from the start, but now it's too late for that..)"}}