{"action":"created","issue":{"url":"https://api.github.com/repos/teamed/quiz/issues/5","labels_url":"https://api.github.com/repos/teamed/quiz/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/teamed/quiz/issues/5/comments","events_url":"https://api.github.com/repos/teamed/quiz/issues/5/events","html_url":"https://github.com/teamed/quiz/pull/5","id":60849083,"number":5,"title":"Modify Document.php","user":{"login":"dollyaswin","id":107206,"avatar_url":"https://avatars.githubusercontent.com/u/107206?v=3","gravatar_id":"","url":"https://api.github.com/users/dollyaswin","html_url":"https://github.com/dollyaswin","followers_url":"https://api.github.com/users/dollyaswin/followers","following_url":"https://api.github.com/users/dollyaswin/following{/other_user}","gists_url":"https://api.github.com/users/dollyaswin/gists{/gist_id}","starred_url":"https://api.github.com/users/dollyaswin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dollyaswin/subscriptions","organizations_url":"https://api.github.com/users/dollyaswin/orgs","repos_url":"https://api.github.com/users/dollyaswin/repos","events_url":"https://api.github.com/users/dollyaswin/events{/privacy}","received_events_url":"https://api.github.com/users/dollyaswin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-12T16:37:19Z","updated_at":"2015-03-12T17:13:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/teamed/quiz/pulls/5","html_url":"https://github.com/teamed/quiz/pull/5","diff_url":"https://github.com/teamed/quiz/pull/5.diff","patch_url":"https://github.com/teamed/quiz/pull/5.patch"},"body":"- Replace init() to use Constructor\r\n- Replace assert() usage to use Exception"},"comment":{"url":"https://api.github.com/repos/teamed/quiz/issues/comments/78532673","html_url":"https://github.com/teamed/quiz/pull/5#issuecomment-78532673","issue_url":"https://api.github.com/repos/teamed/quiz/issues/5","id":78532673,"user":{"login":"jsowndarrajan","id":5653691,"avatar_url":"https://avatars.githubusercontent.com/u/5653691?v=3","gravatar_id":"","url":"https://api.github.com/users/jsowndarrajan","html_url":"https://github.com/jsowndarrajan","followers_url":"https://api.github.com/users/jsowndarrajan/followers","following_url":"https://api.github.com/users/jsowndarrajan/following{/other_user}","gists_url":"https://api.github.com/users/jsowndarrajan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsowndarrajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsowndarrajan/subscriptions","organizations_url":"https://api.github.com/users/jsowndarrajan/orgs","repos_url":"https://api.github.com/users/jsowndarrajan/repos","events_url":"https://api.github.com/users/jsowndarrajan/events{/privacy}","received_events_url":"https://api.github.com/users/jsowndarrajan/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T17:13:47Z","updated_at":"2015-03-12T17:13:47Z","body":"I entirely agree with what dollyaswin said. other than I recommend following options\r\n\r\n1. Instead of selecting all columns in SQL query, we could mention the proper column name\r\n2. I thought, passing the user object to the Document class is a bad practice.\r\n3. If we could inject SQL connection to the Document object, we can easily complete our tests by using mock objects.\r\n"}}