{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/data/issues/3036","labels_url":"https://api.github.com/repos/emberjs/data/issues/3036/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3036/comments","events_url":"https://api.github.com/repos/emberjs/data/issues/3036/events","html_url":"https://github.com/emberjs/data/pull/3036","id":72710019,"number":3036,"title":"Remove logic for camelCase-ing error keys in ActiveModelAdapter","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-02T22:38:18Z","updated_at":"2015-05-04T05:57:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/3036","html_url":"https://github.com/emberjs/data/pull/3036","diff_url":"https://github.com/emberjs/data/pull/3036.diff","patch_url":"https://github.com/emberjs/data/pull/3036.patch"},"body":"This addresses my comment made in https://github.com/emberjs/data/pull/3030#issuecomment-98396379, where I stated that the made changes of camelCase-ing the error keys are a serializer concern:\r\n\r\nSince c947e25 (introduced in #3030) the keys of the error object are camelCased in the adapter, which is actually a serializer concern. The JSONSerializer, from which the ActiveModelSerializer extends, does a normalization of the errors object in the `extractErrors` hook (see http://git.io/vJ0A6 & http://git.io/vJ0AS) and this hook gets called by the store when the adapter rejects (see http://git.io/vJ0AI), the camelCase can be removed from inside the adapter.\r\n\r\ncc @fivetanley @bdvholmes"},"comment":{"url":"https://api.github.com/repos/emberjs/data/issues/comments/98594330","html_url":"https://github.com/emberjs/data/pull/3036#issuecomment-98594330","issue_url":"https://api.github.com/repos/emberjs/data/issues/3036","id":98594330,"user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T05:57:08Z","updated_at":"2015-05-04T05:57:08Z","body":"There were no tests for `extractErrors`, so @bdvholmes raised an important issue."}}