{"action":"created","issue":{"url":"https://api.github.com/repos/rubinius/rubinius/issues/3318","labels_url":"https://api.github.com/repos/rubinius/rubinius/issues/3318/labels{/name}","comments_url":"https://api.github.com/repos/rubinius/rubinius/issues/3318/comments","events_url":"https://api.github.com/repos/rubinius/rubinius/issues/3318/events","html_url":"https://github.com/rubinius/rubinius/pull/3318","id":57751983,"number":3318,"title":"Spec size method calls on Enumerator instances returned by Enumerable methods.","user":{"login":"fmfdias","id":502548,"avatar_url":"https://avatars.githubusercontent.com/u/502548?v=3","gravatar_id":"","url":"https://api.github.com/users/fmfdias","html_url":"https://github.com/fmfdias","followers_url":"https://api.github.com/users/fmfdias/followers","following_url":"https://api.github.com/users/fmfdias/following{/other_user}","gists_url":"https://api.github.com/users/fmfdias/gists{/gist_id}","starred_url":"https://api.github.com/users/fmfdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmfdias/subscriptions","organizations_url":"https://api.github.com/users/fmfdias/orgs","repos_url":"https://api.github.com/users/fmfdias/repos","events_url":"https://api.github.com/users/fmfdias/events{/privacy}","received_events_url":"https://api.github.com/users/fmfdias/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-15T23:37:00Z","updated_at":"2015-02-16T02:50:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rubinius/rubinius/pulls/3318","html_url":"https://github.com/rubinius/rubinius/pull/3318","diff_url":"https://github.com/rubinius/rubinius/pull/3318.diff","patch_url":"https://github.com/rubinius/rubinius/pull/3318.patch"},"body":"Hi,\r\n\r\nA few days ago I've opened [this issue](https://github.com/rubinius/rubinius/issues/3306) regarding calling size on the Enumerator instance that results on calling the Enumerable#each_slice without a block.\r\n\r\nAt the time I only checked that method. A few days after I thought on checking other similar Enumerable methods that return an Enumerator, on MRI 2.1.5, Rubinius 2.5.2 and JRuby 9.0.0.0 pre1.\r\nRubinius returns nil on all the calls which is not the behavior of MRI. JRuby was only failing on each_slide.\r\nUnfortunately I wasn't able to finish it and inform you guys of it before the issue was handled and closed.\r\n\r\nI took a look at the tests that were added for the each_slice fix [pull request](https://github.com/rubinius/rubinius/pull/3315) and, based on it, decided to transform the checks I made in specs that could be useful.\r\n\r\nI tried to cover all the Enumerable methods that I could find. I also checked the Array class and added similar tests to the methods implemented/overridden by the Array class that are on the same situation.\r\n\r\nI hope it helps.\r\n\r\nThank you!"},"comment":{"url":"https://api.github.com/repos/rubinius/rubinius/issues/comments/74453586","html_url":"https://github.com/rubinius/rubinius/pull/3318#issuecomment-74453586","issue_url":"https://api.github.com/repos/rubinius/rubinius/issues/3318","id":74453586,"user":{"login":"jemc","id":4623870,"avatar_url":"https://avatars.githubusercontent.com/u/4623870?v=3","gravatar_id":"","url":"https://api.github.com/users/jemc","html_url":"https://github.com/jemc","followers_url":"https://api.github.com/users/jemc/followers","following_url":"https://api.github.com/users/jemc/following{/other_user}","gists_url":"https://api.github.com/users/jemc/gists{/gist_id}","starred_url":"https://api.github.com/users/jemc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jemc/subscriptions","organizations_url":"https://api.github.com/users/jemc/orgs","repos_url":"https://api.github.com/users/jemc/repos","events_url":"https://api.github.com/users/jemc/events{/privacy}","received_events_url":"https://api.github.com/users/jemc/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T02:50:18Z","updated_at":"2015-02-16T02:50:18Z","body":"@fmfdias \r\nThanks for taking the time to write some specs!  However, we need to tag these as failing so that they don't cause CI or`rake spec` failures.\r\n\r\nTake a look at `mspec tag --help` for more information, but the most basic tagging of failures looks something like `mspec tag fails ./spec`.  This will add files or lines to the directory structure in `./spec/tags` that mirrors the structure of the specs in `./spec`."}}