{"action":"created","comment":{"url":"https://api.github.com/repos/chebfun/chebfun/pulls/comments/32310663","id":32310663,"diff_hunk":"@@ -43,29 +43,23 @@\n % Here is a rough guide to how scale and accuracy information is propagated in\n % subsequent operations after construction:\n %   h = f + c:\n-%     h.vscale = getvscl(h);\n-%     h.epslevel = (f.epslevel*f.vscale + eps(c)) / h.vscale;\n+%     h.epslevel = (f.epslevel*f.vscale + eps(c)) / vscale(h);\n %\n %   h = f * c:\n-%     h.vscale = getvscl(h) = abs(c)*f.vscale;\n %     h.epslevel = f.epslevel + eps(c)/c;\n %\n %   h = f + g:\n-%     h.vscale = getvscl(h);\n %     h.epslevel = (f.epslevel*f.vscale + g.epslevel*g.vscale) / h.vscale\n %\n %   h = f .* g:\n-%     h.vscale = getvscl(h);\n %     h.epslevel = (f.epslevel + g.epslevel) * (f.vscale*g.vscale)/h.vscale","path":"@chebtech/chebtech.m","position":18,"original_position":18,"commit_id":"407e804a6d5917637b8046e9f58f61f4d65ed218","original_commit_id":"407e804a6d5917637b8046e9f58f61f4d65ed218","user":{"login":"jaurentz","id":7694954,"avatar_url":"https://avatars.githubusercontent.com/u/7694954?v=3","gravatar_id":"","url":"https://api.github.com/users/jaurentz","html_url":"https://github.com/jaurentz","followers_url":"https://api.github.com/users/jaurentz/followers","following_url":"https://api.github.com/users/jaurentz/following{/other_user}","gists_url":"https://api.github.com/users/jaurentz/gists{/gist_id}","starred_url":"https://api.github.com/users/jaurentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaurentz/subscriptions","organizations_url":"https://api.github.com/users/jaurentz/orgs","repos_url":"https://api.github.com/users/jaurentz/repos","events_url":"https://api.github.com/users/jaurentz/events{/privacy}","received_events_url":"https://api.github.com/users/jaurentz/received_events","type":"User","site_admin":false},"body":"Can you still use `f.vscale` and `g.vscale` here?","created_at":"2015-06-12T12:19:27Z","updated_at":"2015-06-12T12:19:27Z","html_url":"https://github.com/chebfun/chebfun/pull/1500#discussion_r32310663","pull_request_url":"https://api.github.com/repos/chebfun/chebfun/pulls/1500","_links":{"self":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/comments/32310663"},"html":{"href":"https://github.com/chebfun/chebfun/pull/1500#discussion_r32310663"},"pull_request":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1500"}}},"pull_request":{"url":"https://api.github.com/repos/chebfun/chebfun/pulls/1500","id":35642075,"html_url":"https://github.com/chebfun/chebfun/pull/1500","diff_url":"https://github.com/chebfun/chebfun/pull/1500.diff","patch_url":"https://github.com/chebfun/chebfun/pull/1500.patch","issue_url":"https://api.github.com/repos/chebfun/chebfun/issues/1500","number":1500,"state":"open","locked":false,"title":"Remove .vscale property from chebtechs.","user":{"login":"nickhale","id":2035010,"avatar_url":"https://avatars.githubusercontent.com/u/2035010?v=3","gravatar_id":"","url":"https://api.github.com/users/nickhale","html_url":"https://github.com/nickhale","followers_url":"https://api.github.com/users/nickhale/followers","following_url":"https://api.github.com/users/nickhale/following{/other_user}","gists_url":"https://api.github.com/users/nickhale/gists{/gist_id}","starred_url":"https://api.github.com/users/nickhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickhale/subscriptions","organizations_url":"https://api.github.com/users/nickhale/orgs","repos_url":"https://api.github.com/users/nickhale/repos","events_url":"https://api.github.com/users/nickhale/events{/privacy}","received_events_url":"https://api.github.com/users/nickhale/received_events","type":"User","site_admin":false},"body":"See discussion in #1479.\r\n\r\nThis was complicated somewhat by \r\n * a) The need to pass vscales in the construction process which do not correspond to function values.\r\n * b) The fact that we sometimes modified the coefficients, then called f.vscale to look at the old vscale.\r\n\r\nAs noted in #1479 if `.epslevels` are fully removed, then even more references to `.vscale` can go.\r\n\r\nPerformance seems comparable (at least in timing `chebtest chebtech`).","created_at":"2015-05-18T15:02:19Z","updated_at":"2015-06-12T12:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16102477f2e4aba4a4e7b3fb6dbe8da6e7e66551","assignee":{"login":"jaurentz","id":7694954,"avatar_url":"https://avatars.githubusercontent.com/u/7694954?v=3","gravatar_id":"","url":"https://api.github.com/users/jaurentz","html_url":"https://github.com/jaurentz","followers_url":"https://api.github.com/users/jaurentz/followers","following_url":"https://api.github.com/users/jaurentz/following{/other_user}","gists_url":"https://api.github.com/users/jaurentz/gists{/gist_id}","starred_url":"https://api.github.com/users/jaurentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaurentz/subscriptions","organizations_url":"https://api.github.com/users/jaurentz/orgs","repos_url":"https://api.github.com/users/jaurentz/repos","events_url":"https://api.github.com/users/jaurentz/events{/privacy}","received_events_url":"https://api.github.com/users/jaurentz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/chebfun/chebfun/pulls/1500/commits","review_comments_url":"https://api.github.com/repos/chebfun/chebfun/pulls/1500/comments","review_comment_url":"https://api.github.com/repos/chebfun/chebfun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chebfun/chebfun/issues/1500/comments","statuses_url":"https://api.github.com/repos/chebfun/chebfun/statuses/407e804a6d5917637b8046e9f58f61f4d65ed218","head":{"label":"chebfun:feature-remove-vscale","ref":"feature-remove-vscale","sha":"407e804a6d5917637b8046e9f58f61f4d65ed218","user":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"repo":{"id":7893220,"name":"chebfun","full_name":"chebfun/chebfun","owner":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chebfun/chebfun","description":"Chebfun is an open-source software system for numerical computing with functions.","fork":false,"url":"https://api.github.com/repos/chebfun/chebfun","forks_url":"https://api.github.com/repos/chebfun/chebfun/forks","keys_url":"https://api.github.com/repos/chebfun/chebfun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chebfun/chebfun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chebfun/chebfun/teams","hooks_url":"https://api.github.com/repos/chebfun/chebfun/hooks","issue_events_url":"https://api.github.com/repos/chebfun/chebfun/issues/events{/number}","events_url":"https://api.github.com/repos/chebfun/chebfun/events","assignees_url":"https://api.github.com/repos/chebfun/chebfun/assignees{/user}","branches_url":"https://api.github.com/repos/chebfun/chebfun/branches{/branch}","tags_url":"https://api.github.com/repos/chebfun/chebfun/tags","blobs_url":"https://api.github.com/repos/chebfun/chebfun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chebfun/chebfun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chebfun/chebfun/git/refs{/sha}","trees_url":"https://api.github.com/repos/chebfun/chebfun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chebfun/chebfun/statuses/{sha}","languages_url":"https://api.github.com/repos/chebfun/chebfun/languages","stargazers_url":"https://api.github.com/repos/chebfun/chebfun/stargazers","contributors_url":"https://api.github.com/repos/chebfun/chebfun/contributors","subscribers_url":"https://api.github.com/repos/chebfun/chebfun/subscribers","subscription_url":"https://api.github.com/repos/chebfun/chebfun/subscription","commits_url":"https://api.github.com/repos/chebfun/chebfun/commits{/sha}","git_commits_url":"https://api.github.com/repos/chebfun/chebfun/git/commits{/sha}","comments_url":"https://api.github.com/repos/chebfun/chebfun/comments{/number}","issue_comment_url":"https://api.github.com/repos/chebfun/chebfun/issues/comments{/number}","contents_url":"https://api.github.com/repos/chebfun/chebfun/contents/{+path}","compare_url":"https://api.github.com/repos/chebfun/chebfun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chebfun/chebfun/merges","archive_url":"https://api.github.com/repos/chebfun/chebfun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chebfun/chebfun/downloads","issues_url":"https://api.github.com/repos/chebfun/chebfun/issues{/number}","pulls_url":"https://api.github.com/repos/chebfun/chebfun/pulls{/number}","milestones_url":"https://api.github.com/repos/chebfun/chebfun/milestones{/number}","notifications_url":"https://api.github.com/repos/chebfun/chebfun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chebfun/chebfun/labels{/name}","releases_url":"https://api.github.com/repos/chebfun/chebfun/releases{/id}","created_at":"2013-01-29T13:59:55Z","updated_at":"2015-06-07T19:41:54Z","pushed_at":"2015-06-12T12:07:21Z","git_url":"git://github.com/chebfun/chebfun.git","ssh_url":"git@github.com:chebfun/chebfun.git","clone_url":"https://github.com/chebfun/chebfun.git","svn_url":"https://github.com/chebfun/chebfun","homepage":"http://www.chebfun.org/","size":34418,"stargazers_count":45,"watchers_count":45,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":168,"forks":7,"open_issues":168,"watchers":45,"default_branch":"development"}},"base":{"label":"chebfun:development","ref":"development","sha":"74ee7a4ffdff0b66db9d0bc020f1983cfd9f0917","user":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"repo":{"id":7893220,"name":"chebfun","full_name":"chebfun/chebfun","owner":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chebfun/chebfun","description":"Chebfun is an open-source software system for numerical computing with functions.","fork":false,"url":"https://api.github.com/repos/chebfun/chebfun","forks_url":"https://api.github.com/repos/chebfun/chebfun/forks","keys_url":"https://api.github.com/repos/chebfun/chebfun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chebfun/chebfun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chebfun/chebfun/teams","hooks_url":"https://api.github.com/repos/chebfun/chebfun/hooks","issue_events_url":"https://api.github.com/repos/chebfun/chebfun/issues/events{/number}","events_url":"https://api.github.com/repos/chebfun/chebfun/events","assignees_url":"https://api.github.com/repos/chebfun/chebfun/assignees{/user}","branches_url":"https://api.github.com/repos/chebfun/chebfun/branches{/branch}","tags_url":"https://api.github.com/repos/chebfun/chebfun/tags","blobs_url":"https://api.github.com/repos/chebfun/chebfun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chebfun/chebfun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chebfun/chebfun/git/refs{/sha}","trees_url":"https://api.github.com/repos/chebfun/chebfun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chebfun/chebfun/statuses/{sha}","languages_url":"https://api.github.com/repos/chebfun/chebfun/languages","stargazers_url":"https://api.github.com/repos/chebfun/chebfun/stargazers","contributors_url":"https://api.github.com/repos/chebfun/chebfun/contributors","subscribers_url":"https://api.github.com/repos/chebfun/chebfun/subscribers","subscription_url":"https://api.github.com/repos/chebfun/chebfun/subscription","commits_url":"https://api.github.com/repos/chebfun/chebfun/commits{/sha}","git_commits_url":"https://api.github.com/repos/chebfun/chebfun/git/commits{/sha}","comments_url":"https://api.github.com/repos/chebfun/chebfun/comments{/number}","issue_comment_url":"https://api.github.com/repos/chebfun/chebfun/issues/comments{/number}","contents_url":"https://api.github.com/repos/chebfun/chebfun/contents/{+path}","compare_url":"https://api.github.com/repos/chebfun/chebfun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chebfun/chebfun/merges","archive_url":"https://api.github.com/repos/chebfun/chebfun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chebfun/chebfun/downloads","issues_url":"https://api.github.com/repos/chebfun/chebfun/issues{/number}","pulls_url":"https://api.github.com/repos/chebfun/chebfun/pulls{/number}","milestones_url":"https://api.github.com/repos/chebfun/chebfun/milestones{/number}","notifications_url":"https://api.github.com/repos/chebfun/chebfun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chebfun/chebfun/labels{/name}","releases_url":"https://api.github.com/repos/chebfun/chebfun/releases{/id}","created_at":"2013-01-29T13:59:55Z","updated_at":"2015-06-07T19:41:54Z","pushed_at":"2015-06-12T12:07:21Z","git_url":"git://github.com/chebfun/chebfun.git","ssh_url":"git@github.com:chebfun/chebfun.git","clone_url":"https://github.com/chebfun/chebfun.git","svn_url":"https://github.com/chebfun/chebfun","homepage":"http://www.chebfun.org/","size":34418,"stargazers_count":45,"watchers_count":45,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":168,"forks":7,"open_issues":168,"watchers":45,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1500"},"html":{"href":"https://github.com/chebfun/chebfun/pull/1500"},"issue":{"href":"https://api.github.com/repos/chebfun/chebfun/issues/1500"},"comments":{"href":"https://api.github.com/repos/chebfun/chebfun/issues/1500/comments"},"review_comments":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1500/comments"},"review_comment":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1500/commits"},"statuses":{"href":"https://api.github.com/repos/chebfun/chebfun/statuses/407e804a6d5917637b8046e9f58f61f4d65ed218"}}}}