{"action":"created","comment":{"url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/comments/39588217","id":39588217,"diff_hunk":"@@ -0,0 +1,9 @@\n+.esp-overlay {\n+    position: absolute;\n+    background-color: white;\n+    border: 1px solid;\n+    border-top: 0;\n+    padding: 1em;\n+    display: none;\n+\tz-index: 9001; // ;)","path":"css/extensible-search-typeahead.css","position":8,"original_position":8,"commit_id":"536a5cc771a2ab42885eea462e517bface8e93ea","original_commit_id":"536a5cc771a2ab42885eea462e517bface8e93ea","user":{"login":"nglasl","id":3703500,"avatar_url":"https://avatars.githubusercontent.com/u/3703500?v=3","gravatar_id":"","url":"https://api.github.com/users/nglasl","html_url":"https://github.com/nglasl","followers_url":"https://api.github.com/users/nglasl/followers","following_url":"https://api.github.com/users/nglasl/following{/other_user}","gists_url":"https://api.github.com/users/nglasl/gists{/gist_id}","starred_url":"https://api.github.com/users/nglasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nglasl/subscriptions","organizations_url":"https://api.github.com/users/nglasl/orgs","repos_url":"https://api.github.com/users/nglasl/repos","events_url":"https://api.github.com/users/nglasl/events{/privacy}","received_events_url":"https://api.github.com/users/nglasl/received_events","type":"User","site_admin":false},"body":"Pls no. Does anything else actually overlap this?","created_at":"2015-09-16T02:23:24Z","updated_at":"2015-09-16T02:23:24Z","html_url":"https://github.com/nglasl/silverstripe-extensible-search/pull/7#discussion_r39588217","pull_request_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/comments/39588217"},"html":{"href":"https://github.com/nglasl/silverstripe-extensible-search/pull/7#discussion_r39588217"},"pull_request":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7","id":44318460,"html_url":"https://github.com/nglasl/silverstripe-extensible-search/pull/7","diff_url":"https://github.com/nglasl/silverstripe-extensible-search/pull/7.diff","patch_url":"https://github.com/nglasl/silverstripe-extensible-search/pull/7.patch","issue_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues/7","number":7,"state":"open","locked":false,"title":"Feature Typeahead - ready for review","user":{"login":"stephenmcm","id":2093185,"avatar_url":"https://avatars.githubusercontent.com/u/2093185?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenmcm","html_url":"https://github.com/stephenmcm","followers_url":"https://api.github.com/users/stephenmcm/followers","following_url":"https://api.github.com/users/stephenmcm/following{/other_user}","gists_url":"https://api.github.com/users/stephenmcm/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenmcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenmcm/subscriptions","organizations_url":"https://api.github.com/users/stephenmcm/orgs","repos_url":"https://api.github.com/users/stephenmcm/repos","events_url":"https://api.github.com/users/stephenmcm/events{/privacy}","received_events_url":"https://api.github.com/users/stephenmcm/received_events","type":"User","site_admin":false},"body":"Branch naming for the fail here...\r\n\r\nCurrently the ajax search suggesting aren't loading in correctly the typeahead is working.\r\nThe search suggestions ajax set likely needs to be ported to the typeahead.js style.\r\n\r\n### Known Issues\r\n\r\n - [x] Search suggestions ajax is broken :frowning: \r\n - [x] Typeahead overlay currently opens and closes on click only needs to have checks for focus and keyboard support\r\n - [x] Typeahead overlay currently likely not accessible\r\n - [x] Overlay is currently mildly dependent on Bootstrap\r\n - [x] Template is currently not completely namespaced\r\n - [x] Documentation on how typeahead/suggestions are implemented is lacking","created_at":"2015-09-07T04:00:34Z","updated_at":"2015-09-16T02:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac242007d92bfe78f8b408d15888125f67f00ec8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7/commits","review_comments_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7/comments","review_comment_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues/7/comments","statuses_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/statuses/536a5cc771a2ab42885eea462e517bface8e93ea","head":{"label":"stephenmcm:feature-searchsuggestions","ref":"feature-searchsuggestions","sha":"536a5cc771a2ab42885eea462e517bface8e93ea","user":{"login":"stephenmcm","id":2093185,"avatar_url":"https://avatars.githubusercontent.com/u/2093185?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenmcm","html_url":"https://github.com/stephenmcm","followers_url":"https://api.github.com/users/stephenmcm/followers","following_url":"https://api.github.com/users/stephenmcm/following{/other_user}","gists_url":"https://api.github.com/users/stephenmcm/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenmcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenmcm/subscriptions","organizations_url":"https://api.github.com/users/stephenmcm/orgs","repos_url":"https://api.github.com/users/stephenmcm/repos","events_url":"https://api.github.com/users/stephenmcm/events{/privacy}","received_events_url":"https://api.github.com/users/stephenmcm/received_events","type":"User","site_admin":false},"repo":{"id":41530943,"name":"silverstripe-extensible-search","full_name":"stephenmcm/silverstripe-extensible-search","owner":{"login":"stephenmcm","id":2093185,"avatar_url":"https://avatars.githubusercontent.com/u/2093185?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenmcm","html_url":"https://github.com/stephenmcm","followers_url":"https://api.github.com/users/stephenmcm/followers","following_url":"https://api.github.com/users/stephenmcm/following{/other_user}","gists_url":"https://api.github.com/users/stephenmcm/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenmcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenmcm/subscriptions","organizations_url":"https://api.github.com/users/stephenmcm/orgs","repos_url":"https://api.github.com/users/stephenmcm/repos","events_url":"https://api.github.com/users/stephenmcm/events{/privacy}","received_events_url":"https://api.github.com/users/stephenmcm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephenmcm/silverstripe-extensible-search","description":"A module for SilverStripe which will allow user customisation and developer extension of a search page instance, including analytics and suggestions.","fork":true,"url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search","forks_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/forks","keys_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/teams","hooks_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/hooks","issue_events_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/issues/events{/number}","events_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/events","assignees_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/assignees{/user}","branches_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/branches{/branch}","tags_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/tags","blobs_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/languages","stargazers_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/stargazers","contributors_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/contributors","subscribers_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/subscribers","subscription_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/subscription","commits_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/contents/{+path}","compare_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/merges","archive_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/downloads","issues_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/issues{/number}","pulls_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/labels{/name}","releases_url":"https://api.github.com/repos/stephenmcm/silverstripe-extensible-search/releases{/id}","created_at":"2015-08-28T06:25:20Z","updated_at":"2015-08-28T06:25:21Z","pushed_at":"2015-09-14T04:56:27Z","git_url":"git://github.com/stephenmcm/silverstripe-extensible-search.git","ssh_url":"git@github.com:stephenmcm/silverstripe-extensible-search.git","clone_url":"https://github.com/stephenmcm/silverstripe-extensible-search.git","svn_url":"https://github.com/stephenmcm/silverstripe-extensible-search","homepage":"","size":257,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nglasl:master","ref":"master","sha":"79f84b16e90912b0364de979d1ee81fd067d2567","user":{"login":"nglasl","id":3703500,"avatar_url":"https://avatars.githubusercontent.com/u/3703500?v=3","gravatar_id":"","url":"https://api.github.com/users/nglasl","html_url":"https://github.com/nglasl","followers_url":"https://api.github.com/users/nglasl/followers","following_url":"https://api.github.com/users/nglasl/following{/other_user}","gists_url":"https://api.github.com/users/nglasl/gists{/gist_id}","starred_url":"https://api.github.com/users/nglasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nglasl/subscriptions","organizations_url":"https://api.github.com/users/nglasl/orgs","repos_url":"https://api.github.com/users/nglasl/repos","events_url":"https://api.github.com/users/nglasl/events{/privacy}","received_events_url":"https://api.github.com/users/nglasl/received_events","type":"User","site_admin":false},"repo":{"id":20869066,"name":"silverstripe-extensible-search","full_name":"nglasl/silverstripe-extensible-search","owner":{"login":"nglasl","id":3703500,"avatar_url":"https://avatars.githubusercontent.com/u/3703500?v=3","gravatar_id":"","url":"https://api.github.com/users/nglasl","html_url":"https://github.com/nglasl","followers_url":"https://api.github.com/users/nglasl/followers","following_url":"https://api.github.com/users/nglasl/following{/other_user}","gists_url":"https://api.github.com/users/nglasl/gists{/gist_id}","starred_url":"https://api.github.com/users/nglasl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nglasl/subscriptions","organizations_url":"https://api.github.com/users/nglasl/orgs","repos_url":"https://api.github.com/users/nglasl/repos","events_url":"https://api.github.com/users/nglasl/events{/privacy}","received_events_url":"https://api.github.com/users/nglasl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nglasl/silverstripe-extensible-search","description":"A module for SilverStripe which will allow user customisation and developer extension of a search page instance, including analytics and suggestions.","fork":false,"url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search","forks_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/forks","keys_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/teams","hooks_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/hooks","issue_events_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues/events{/number}","events_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/events","assignees_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/assignees{/user}","branches_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/branches{/branch}","tags_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/tags","blobs_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/statuses/{sha}","languages_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/languages","stargazers_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/stargazers","contributors_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/contributors","subscribers_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/subscribers","subscription_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/subscription","commits_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/contents/{+path}","compare_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/merges","archive_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/downloads","issues_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues{/number}","pulls_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls{/number}","milestones_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/milestones{/number}","notifications_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/labels{/name}","releases_url":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/releases{/id}","created_at":"2014-06-16T01:13:10Z","updated_at":"2015-05-01T05:28:09Z","pushed_at":"2015-09-14T04:56:28Z","git_url":"git://github.com/nglasl/silverstripe-extensible-search.git","ssh_url":"git@github.com:nglasl/silverstripe-extensible-search.git","clone_url":"https://github.com/nglasl/silverstripe-extensible-search.git","svn_url":"https://github.com/nglasl/silverstripe-extensible-search","homepage":"","size":1007,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7"},"html":{"href":"https://github.com/nglasl/silverstripe-extensible-search/pull/7"},"issue":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues/7"},"comments":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/nglasl/silverstripe-extensible-search/statuses/536a5cc771a2ab42885eea462e517bface8e93ea"}}}}