{"action":"created","issue":{"url":"https://api.github.com/repos/vpulim/node-soap/issues/712","labels_url":"https://api.github.com/repos/vpulim/node-soap/issues/712/labels{/name}","comments_url":"https://api.github.com/repos/vpulim/node-soap/issues/712/comments","events_url":"https://api.github.com/repos/vpulim/node-soap/issues/712/events","html_url":"https://github.com/vpulim/node-soap/issues/712","id":105590361,"number":712,"title":"Readme","user":{"login":"360disrupt","id":7427903,"avatar_url":"https://avatars.githubusercontent.com/u/7427903?v=3","gravatar_id":"","url":"https://api.github.com/users/360disrupt","html_url":"https://github.com/360disrupt","followers_url":"https://api.github.com/users/360disrupt/followers","following_url":"https://api.github.com/users/360disrupt/following{/other_user}","gists_url":"https://api.github.com/users/360disrupt/gists{/gist_id}","starred_url":"https://api.github.com/users/360disrupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/360disrupt/subscriptions","organizations_url":"https://api.github.com/users/360disrupt/orgs","repos_url":"https://api.github.com/users/360disrupt/repos","events_url":"https://api.github.com/users/360disrupt/events{/privacy}","received_events_url":"https://api.github.com/users/360disrupt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-09T12:54:40Z","updated_at":"2015-09-24T20:53:43Z","closed_at":"2015-09-24T20:53:43Z","body":"Is this valid code in the Readme.md:\r\n```\r\nvar xml = require('fs').readFileSync('myservice.wsdl', 'utf8'),\r\n      server = http.createServer(function(request,response) {\r\n          response.end(\"404: Not Found: \"+request.url)\r\n      });\r\n```\r\n\r\nI guess it should be:\r\n```\r\nvar xml = require('fs').readFileSync('myservice.wsdl', 'utf8', function(){\r\n      server = http.createServer(function(request,response) {\r\n          response.end(\"404: Not Found: \"+request.url)\r\n      })});\r\n```"},"comment":{"url":"https://api.github.com/repos/vpulim/node-soap/issues/comments/143048138","html_url":"https://github.com/vpulim/node-soap/issues/712#issuecomment-143048138","issue_url":"https://api.github.com/repos/vpulim/node-soap/issues/712","id":143048138,"user":{"login":"herom","id":2472487,"avatar_url":"https://avatars.githubusercontent.com/u/2472487?v=3","gravatar_id":"","url":"https://api.github.com/users/herom","html_url":"https://github.com/herom","followers_url":"https://api.github.com/users/herom/followers","following_url":"https://api.github.com/users/herom/following{/other_user}","gists_url":"https://api.github.com/users/herom/gists{/gist_id}","starred_url":"https://api.github.com/users/herom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herom/subscriptions","organizations_url":"https://api.github.com/users/herom/orgs","repos_url":"https://api.github.com/users/herom/repos","events_url":"https://api.github.com/users/herom/events{/privacy}","received_events_url":"https://api.github.com/users/herom/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T20:53:43Z","updated_at":"2015-09-24T20:53:43Z","body":"@360disrupt  this code is absolutely valid, the only thing which is going on here, is that the declaration of the `xml` and `server` variables is not split up into their on lines. If you split it up, perhaps you'll see the correctness of the code sample\r\n\r\n```javascript\r\nvar xml = require('fs').readFileSync('myservice.wsdl', 'utf8'); // <-- notice that `readFileSync` is called, which returns the read file and therefore does not accept a callback as last param\r\n\r\nvar server = http.createServer(function(request,response) {\r\n          response.end(\"404: Not Found: \"+request.url)\r\n      });\r\n```"}}