{"action":"created","issue":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/2231","labels_url":"https://api.github.com/repos/syncthing/syncthing/issues/2231/labels{/name}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/2231/comments","events_url":"https://api.github.com/repos/syncthing/syncthing/issues/2231/events","html_url":"https://github.com/syncthing/syncthing/pull/2231","id":104869246,"number":2231,"title":"lib/symlinks need not depend on protocol","user":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/syncthing/syncthing/labels/pr-refactor","name":"pr-refactor","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-04T10:56:04Z","updated_at":"2015-09-11T11:26:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/2231","html_url":"https://github.com/syncthing/syncthing/pull/2231","diff_url":"https://github.com/syncthing/syncthing/pull/2231.diff","patch_url":"https://github.com/syncthing/syncthing/pull/2231.patch"},"body":"This one needs some review. It makes the symlink package use it's own TargetType enumeration instead of the protocol flags, to cut one unnecessary dependency. I'm not 100% certain I got the turns around Unknown and so right, especially as I slightly simplified the logic of SymlinkTypeEqual in walk.go to what I think the comment said..."},"comment":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/comments/139519650","html_url":"https://github.com/syncthing/syncthing/pull/2231#issuecomment-139519650","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/2231","id":139519650,"user":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T11:26:18Z","updated_at":"2015-09-11T11:26:18Z","body":"No, I think the behavior is the same as it was, unless there's still stuff I don't understand :)"}}