{"action":"created","issue":{"url":"https://api.github.com/repos/code-iai/ros_emacs_utils/issues/9","labels_url":"https://api.github.com/repos/code-iai/ros_emacs_utils/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/code-iai/ros_emacs_utils/issues/9/comments","events_url":"https://api.github.com/repos/code-iai/ros_emacs_utils/issues/9/events","html_url":"https://github.com/code-iai/ros_emacs_utils/pull/9","id":53174461,"number":9,"title":"Update rosemacs.el","user":{"login":"k-okada","id":493276,"avatar_url":"https://avatars.githubusercontent.com/u/493276?v=3","gravatar_id":"","url":"https://api.github.com/users/k-okada","html_url":"https://github.com/k-okada","followers_url":"https://api.github.com/users/k-okada/followers","following_url":"https://api.github.com/users/k-okada/following{/other_user}","gists_url":"https://api.github.com/users/k-okada/gists{/gist_id}","starred_url":"https://api.github.com/users/k-okada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-okada/subscriptions","organizations_url":"https://api.github.com/users/k-okada/orgs","repos_url":"https://api.github.com/users/k-okada/repos","events_url":"https://api.github.com/users/k-okada/events{/privacy}","received_events_url":"https://api.github.com/users/k-okada/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2014-12-31T09:03:38Z","updated_at":"2015-01-23T18:40:42Z","closed_at":"2015-01-23T18:40:42Z","pull_request":{"url":"https://api.github.com/repos/code-iai/ros_emacs_utils/pulls/9","html_url":"https://github.com/code-iai/ros_emacs_utils/pull/9","diff_url":"https://github.com/code-iai/ros_emacs_utils/pull/9.diff","patch_url":"https://github.com/code-iai/ros_emacs_utils/pull/9.patch"},"body":"on indigo(14.04) it fails on loading as follows:\r\n```\r\n/opt/ros/indigo/share/emacs/site-lisp/rosemacs.el\r\n`flet' is an obsolete macro (as of 24.3); use either `cl-flet' or `cl-letf'. [2 times]\r\n```"},"comment":{"url":"https://api.github.com/repos/code-iai/ros_emacs_utils/issues/comments/71241944","html_url":"https://github.com/code-iai/ros_emacs_utils/pull/9#issuecomment-71241944","issue_url":"https://api.github.com/repos/code-iai/ros_emacs_utils/issues/9","id":71241944,"user":{"login":"gaya-","id":1608016,"avatar_url":"https://avatars.githubusercontent.com/u/1608016?v=3","gravatar_id":"","url":"https://api.github.com/users/gaya-","html_url":"https://github.com/gaya-","followers_url":"https://api.github.com/users/gaya-/followers","following_url":"https://api.github.com/users/gaya-/following{/other_user}","gists_url":"https://api.github.com/users/gaya-/gists{/gist_id}","starred_url":"https://api.github.com/users/gaya-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaya-/subscriptions","organizations_url":"https://api.github.com/users/gaya-/orgs","repos_url":"https://api.github.com/users/gaya-/repos","events_url":"https://api.github.com/users/gaya-/events{/privacy}","received_events_url":"https://api.github.com/users/gaya-/received_events","type":"User","site_admin":false},"created_at":"2015-01-23T18:40:42Z","updated_at":"2015-01-23T18:40:42Z","body":"Sorry it took forever to process this pull request.\r\n\r\nA couple of notes:\r\n\r\n* \"on indigo(14.04) it fails on loading as follows...\" It should not be \"failing\" but only issuing a warning, as ```flet``` is declared obsolete but is still a valid function. The default behavior of Emacs is to continue execution on warnings.\r\n\r\n* [```cl-flet``` is not exactly equivalent to ```flet```](http://www.gnu.org/software/emacs/manual/html_node/cl/Obsolete-Macros.html), so in this particular case substitution will not achieve the expected behavior. Interestingly, I googled around and stumbled over the exact same issue on the original rosemacs repo: https://github.com/moesenle/rosemacs-debs/issues/2. Pity that, although the issue was solved, there was never a pull request, I guess the guys couldn't be bothered dealing with compatibility issues.\r\n\r\n* Because ```cl.el``` in general is an outdated version of ```cl-lib.el```, I ported all the code to the new ```cl-lib.el```, and because the change is so big, I decided to stop worrying about compatibility and created an extra branch for Emacs versions lower than 24.3 and only support modern emacsen on the master branch.\r\n\r\nThanks a lot to everyone for your contribution!\r\n\r\nSolved in https://github.com/code-iai/ros_emacs_utils/commit/abb4c49687a7d3c56cc945ecab679efc8ca46594#diff-a09e14295c5979c53a50dbbc3adf9f7dR449"}}