{"action":"created","comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/25843561","id":25843561,"diff_hunk":"@@ -562,6 +562,14 @@ void Seq::processMessages()\n                         break;\n                   case SeqMsgId::PLAY:\n                         putEvent(msg.event);\n+                        // Update initList immediately if there're some changes in mixer","path":"mscore/seq.cpp","position":null,"original_position":4,"commit_id":"dd0a599ef866604aae0afd50e0ed92911936afd6","original_commit_id":"a33d553531a0f7de5236d5d4c16dc644bf14645a","user":{"login":"Igevorse","id":6889805,"avatar_url":"https://avatars.githubusercontent.com/u/6889805?v=3","gravatar_id":"","url":"https://api.github.com/users/Igevorse","html_url":"https://github.com/Igevorse","followers_url":"https://api.github.com/users/Igevorse/followers","following_url":"https://api.github.com/users/Igevorse/following{/other_user}","gists_url":"https://api.github.com/users/Igevorse/gists{/gist_id}","starred_url":"https://api.github.com/users/Igevorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igevorse/subscriptions","organizations_url":"https://api.github.com/users/Igevorse/orgs","repos_url":"https://api.github.com/users/Igevorse/repos","events_url":"https://api.github.com/users/Igevorse/events{/privacy}","received_events_url":"https://api.github.com/users/Igevorse/received_events","type":"User","site_admin":false},"body":"@lasconic Yes, you're right. I was confused because seq->setControler() enqueues cross-thread calls... but in this case it doesn't make sence. Thanks.","created_at":"2015-03-05T07:25:46Z","updated_at":"2015-03-05T07:25:46Z","html_url":"https://github.com/musescore/MuseScore/pull/1838#discussion_r25843561","pull_request_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1838","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/25843561"},"html":{"href":"https://github.com/musescore/MuseScore/pull/1838#discussion_r25843561"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1838"}}},"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/1838","id":30489638,"html_url":"https://github.com/musescore/MuseScore/pull/1838","diff_url":"https://github.com/musescore/MuseScore/pull/1838.diff","patch_url":"https://github.com/musescore/MuseScore/pull/1838.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/1838","number":1838,"state":"open","locked":false,"title":"fix #49651: Changes in mixer do not affect instruments","user":{"login":"Igevorse","id":6889805,"avatar_url":"https://avatars.githubusercontent.com/u/6889805?v=3","gravatar_id":"","url":"https://api.github.com/users/Igevorse","html_url":"https://github.com/Igevorse","followers_url":"https://api.github.com/users/Igevorse/followers","following_url":"https://api.github.com/users/Igevorse/following{/other_user}","gists_url":"https://api.github.com/users/Igevorse/gists{/gist_id}","starred_url":"https://api.github.com/users/Igevorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igevorse/subscriptions","organizations_url":"https://api.github.com/users/Igevorse/orgs","repos_url":"https://api.github.com/users/Igevorse/repos","events_url":"https://api.github.com/users/Igevorse/events{/privacy}","received_events_url":"https://api.github.com/users/Igevorse/received_events","type":"User","site_admin":false},"body":"This happens because we don't update channels' init list immediately after changing parameters in mixer. When we hit \"Play\" we init instruments and rewrite its' values with old parameters.\r\nThis bug occurs only if \"Use Jack MIDI\" option enabled.","created_at":"2015-03-04T18:10:59Z","updated_at":"2015-03-05T07:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"611fd88244adf772dd1b09543a2d84d9b06b497f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1838/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1838/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/1838/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/dd0a599ef866604aae0afd50e0ed92911936afd6","head":{"label":"Igevorse:bugs","ref":"bugs","sha":"dd0a599ef866604aae0afd50e0ed92911936afd6","user":{"login":"Igevorse","id":6889805,"avatar_url":"https://avatars.githubusercontent.com/u/6889805?v=3","gravatar_id":"","url":"https://api.github.com/users/Igevorse","html_url":"https://github.com/Igevorse","followers_url":"https://api.github.com/users/Igevorse/followers","following_url":"https://api.github.com/users/Igevorse/following{/other_user}","gists_url":"https://api.github.com/users/Igevorse/gists{/gist_id}","starred_url":"https://api.github.com/users/Igevorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igevorse/subscriptions","organizations_url":"https://api.github.com/users/Igevorse/orgs","repos_url":"https://api.github.com/users/Igevorse/repos","events_url":"https://api.github.com/users/Igevorse/events{/privacy}","received_events_url":"https://api.github.com/users/Igevorse/received_events","type":"User","site_admin":false},"repo":{"id":17602466,"name":"MuseScore","full_name":"Igevorse/MuseScore","owner":{"login":"Igevorse","id":6889805,"avatar_url":"https://avatars.githubusercontent.com/u/6889805?v=3","gravatar_id":"","url":"https://api.github.com/users/Igevorse","html_url":"https://github.com/Igevorse","followers_url":"https://api.github.com/users/Igevorse/followers","following_url":"https://api.github.com/users/Igevorse/following{/other_user}","gists_url":"https://api.github.com/users/Igevorse/gists{/gist_id}","starred_url":"https://api.github.com/users/Igevorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igevorse/subscriptions","organizations_url":"https://api.github.com/users/Igevorse/orgs","repos_url":"https://api.github.com/users/Igevorse/repos","events_url":"https://api.github.com/users/Igevorse/events{/privacy}","received_events_url":"https://api.github.com/users/Igevorse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Igevorse/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/Igevorse/MuseScore","forks_url":"https://api.github.com/repos/Igevorse/MuseScore/forks","keys_url":"https://api.github.com/repos/Igevorse/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igevorse/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igevorse/MuseScore/teams","hooks_url":"https://api.github.com/repos/Igevorse/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/Igevorse/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/Igevorse/MuseScore/events","assignees_url":"https://api.github.com/repos/Igevorse/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/Igevorse/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/Igevorse/MuseScore/tags","blobs_url":"https://api.github.com/repos/Igevorse/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igevorse/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igevorse/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igevorse/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igevorse/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/Igevorse/MuseScore/languages","stargazers_url":"https://api.github.com/repos/Igevorse/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/Igevorse/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/Igevorse/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/Igevorse/MuseScore/subscription","commits_url":"https://api.github.com/repos/Igevorse/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igevorse/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igevorse/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igevorse/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igevorse/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/Igevorse/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igevorse/MuseScore/merges","archive_url":"https://api.github.com/repos/Igevorse/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igevorse/MuseScore/downloads","issues_url":"https://api.github.com/repos/Igevorse/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/Igevorse/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/Igevorse/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/Igevorse/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igevorse/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/Igevorse/MuseScore/releases{/id}","created_at":"2014-03-10T17:55:16Z","updated_at":"2014-06-16T07:20:13Z","pushed_at":"2015-03-05T07:24:11Z","git_url":"git://github.com/Igevorse/MuseScore.git","ssh_url":"git@github.com:Igevorse/MuseScore.git","clone_url":"https://github.com/Igevorse/MuseScore.git","svn_url":"https://github.com/Igevorse/MuseScore","homepage":"http://musescore.org","size":171881,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"95cc9d8cd2d95885a23ff1e0bcb77b7c81d1b6e4","user":{"login":"musescore","id":380563,"avatar_url":"https://avatars.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"name":"MuseScore","full_name":"musescore/MuseScore","owner":{"login":"musescore","id":380563,"avatar_url":"https://avatars.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","created_at":"2012-05-26T12:46:33Z","updated_at":"2015-03-04T21:06:42Z","pushed_at":"2015-03-04T21:06:42Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"http://musescore.org","size":337633,"stargazers_count":549,"watchers_count":549,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"open_issues_count":28,"forks":358,"open_issues":28,"watchers":549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1838"},"html":{"href":"https://github.com/musescore/MuseScore/pull/1838"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/1838"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/1838/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1838/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1838/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/dd0a599ef866604aae0afd50e0ed92911936afd6"}}}}