{"action":"closed","number":4118,"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4118","id":53107120,"html_url":"https://github.com/syl20bnr/spacemacs/pull/4118","diff_url":"https://github.com/syl20bnr/spacemacs/pull/4118.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/4118.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4118","number":4118,"state":"closed","locked":false,"title":"Make flycheck/flyspell hooks more explicit","user":{"login":"TheBB","id":619375,"avatar_url":"https://avatars.githubusercontent.com/u/619375?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBB","html_url":"https://github.com/TheBB","followers_url":"https://api.github.com/users/TheBB/followers","following_url":"https://api.github.com/users/TheBB/following{/other_user}","gists_url":"https://api.github.com/users/TheBB/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBB/subscriptions","organizations_url":"https://api.github.com/users/TheBB/orgs","repos_url":"https://api.github.com/users/TheBB/repos","events_url":"https://api.github.com/users/TheBB/events{/privacy}","received_events_url":"https://api.github.com/users/TheBB/received_events","type":"User","site_admin":false},"body":"The way I wrote `add-flyspell-hook` and `add-flycheck-hook` inadvertently caused the bug fixed by https://github.com/syl20bnr/spacemacs/commit/549219e58324373027c1466872da4a7dbe94977a. I'm more of a fan of this more explicity style.\r\n\r\nThere is precedent for doing a macro instead (see `add-company-hook`) but that one does a lot more.\r\n\r\nThis PR also moves the flyspell hook for org-mode into the org layer.","created_at":"2015-12-09T11:31:38Z","updated_at":"2015-12-11T08:14:43Z","closed_at":"2015-12-11T08:14:43Z","merged_at":null,"merge_commit_sha":"eb9630067b90ed0eed3fdb5c20bd1e31ad327f50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4118/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4118/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4118/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/4b47fb51adcce7fd150d6d59eceb7877a8c8a3ac","head":{"label":"TheBB:fly-hooks","ref":"fly-hooks","sha":"4b47fb51adcce7fd150d6d59eceb7877a8c8a3ac","user":{"login":"TheBB","id":619375,"avatar_url":"https://avatars.githubusercontent.com/u/619375?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBB","html_url":"https://github.com/TheBB","followers_url":"https://api.github.com/users/TheBB/followers","following_url":"https://api.github.com/users/TheBB/following{/other_user}","gists_url":"https://api.github.com/users/TheBB/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBB/subscriptions","organizations_url":"https://api.github.com/users/TheBB/orgs","repos_url":"https://api.github.com/users/TheBB/repos","events_url":"https://api.github.com/users/TheBB/events{/privacy}","received_events_url":"https://api.github.com/users/TheBB/received_events","type":"User","site_admin":false},"repo":{"id":35265464,"name":"spacemacs","full_name":"TheBB/spacemacs","owner":{"login":"TheBB","id":619375,"avatar_url":"https://avatars.githubusercontent.com/u/619375?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBB","html_url":"https://github.com/TheBB","followers_url":"https://api.github.com/users/TheBB/followers","following_url":"https://api.github.com/users/TheBB/following{/other_user}","gists_url":"https://api.github.com/users/TheBB/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBB/subscriptions","organizations_url":"https://api.github.com/users/TheBB/orgs","repos_url":"https://api.github.com/users/TheBB/repos","events_url":"https://api.github.com/users/TheBB/events{/privacy}","received_events_url":"https://api.github.com/users/TheBB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheBB/spacemacs","description":"Emacs advanced Kit focused on Evil: The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":true,"url":"https://api.github.com/repos/TheBB/spacemacs","forks_url":"https://api.github.com/repos/TheBB/spacemacs/forks","keys_url":"https://api.github.com/repos/TheBB/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheBB/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheBB/spacemacs/teams","hooks_url":"https://api.github.com/repos/TheBB/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/TheBB/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/TheBB/spacemacs/events","assignees_url":"https://api.github.com/repos/TheBB/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/TheBB/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/TheBB/spacemacs/tags","blobs_url":"https://api.github.com/repos/TheBB/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheBB/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheBB/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheBB/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheBB/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/TheBB/spacemacs/languages","stargazers_url":"https://api.github.com/repos/TheBB/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/TheBB/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/TheBB/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/TheBB/spacemacs/subscription","commits_url":"https://api.github.com/repos/TheBB/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheBB/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheBB/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheBB/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheBB/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/TheBB/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheBB/spacemacs/merges","archive_url":"https://api.github.com/repos/TheBB/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheBB/spacemacs/downloads","issues_url":"https://api.github.com/repos/TheBB/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/TheBB/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/TheBB/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/TheBB/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheBB/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/TheBB/spacemacs/releases{/id}","created_at":"2015-05-08T07:39:29Z","updated_at":"2015-08-17T11:17:16Z","pushed_at":"2015-12-09T11:41:29Z","git_url":"git://github.com/TheBB/spacemacs.git","ssh_url":"git@github.com:TheBB/spacemacs.git","clone_url":"https://github.com/TheBB/spacemacs.git","svn_url":"https://github.com/TheBB/spacemacs","homepage":"https://twitter.com/spacemacs","size":24584,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"98c07024f99f7e89878badd9d45b2bf3735e9c6b","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"An Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","created_at":"2012-12-17T21:34:03Z","updated_at":"2015-12-11T06:40:30Z","pushed_at":"2015-12-11T08:08:55Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"https://twitter.com/spacemacs","size":33049,"stargazers_count":4579,"watchers_count":4579,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1181,"mirror_url":null,"open_issues_count":636,"forks":1181,"open_issues":636,"watchers":4579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4118"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/4118"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4118"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4118/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4118/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4118/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/4b47fb51adcce7fd150d6d59eceb7877a8c8a3ac"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":42,"deletions":36,"changed_files":22}}