{"action":"created","comment":{"url":"https://api.github.com/repos/gogo/protobuf/pulls/comments/23125254","id":23125254,"diff_hunk":"@@ -99,7 +99,10 @@ func (this *pluginImports) GenerateImports(file *FileDescriptor) {\n type Single interface {\n \tUse() string\n \tIsUsed() bool\n-\tGenerate() string\n+\tName() string\n+\tLocation() string\n+\n+\tGenerate() string // DEPRECATED","path":"protoc-gen-gogo/generator/helper.go","position":17,"original_position":17,"commit_id":"de43db2d93f445b9fa1560b4f9aba579eb61a71d","original_commit_id":"de43db2d93f445b9fa1560b4f9aba579eb61a71d","user":{"login":"awalterschulze","id":1829933,"avatar_url":"https://avatars.githubusercontent.com/u/1829933?v=3","gravatar_id":"","url":"https://api.github.com/users/awalterschulze","html_url":"https://github.com/awalterschulze","followers_url":"https://api.github.com/users/awalterschulze/followers","following_url":"https://api.github.com/users/awalterschulze/following{/other_user}","gists_url":"https://api.github.com/users/awalterschulze/gists{/gist_id}","starred_url":"https://api.github.com/users/awalterschulze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalterschulze/subscriptions","organizations_url":"https://api.github.com/users/awalterschulze/orgs","repos_url":"https://api.github.com/users/awalterschulze/repos","events_url":"https://api.github.com/users/awalterschulze/events{/privacy}","received_events_url":"https://api.github.com/users/awalterschulze/received_events","type":"User","site_admin":false},"body":"Please delete this method in the interface and in the implementation.\r\nI don't like deprecated code lying around its not a necessity.","created_at":"2015-01-17T13:31:48Z","updated_at":"2015-01-17T13:31:48Z","html_url":"https://github.com/gogo/protobuf/pull/38#discussion_r23125254","pull_request_url":"https://api.github.com/repos/gogo/protobuf/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/comments/23125254"},"html":{"href":"https://github.com/gogo/protobuf/pull/38#discussion_r23125254"},"pull_request":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/gogo/protobuf/pulls/38","id":27327587,"html_url":"https://github.com/gogo/protobuf/pull/38","diff_url":"https://github.com/gogo/protobuf/pull/38.diff","patch_url":"https://github.com/gogo/protobuf/pull/38.patch","issue_url":"https://api.github.com/repos/gogo/protobuf/issues/38","number":38,"state":"open","locked":false,"title":"modify gogo to generate (more) stable import names","user":{"login":"PatrickDropbox","id":6808940,"avatar_url":"https://avatars.githubusercontent.com/u/6808940?v=3","gravatar_id":"","url":"https://api.github.com/users/PatrickDropbox","html_url":"https://github.com/PatrickDropbox","followers_url":"https://api.github.com/users/PatrickDropbox/followers","following_url":"https://api.github.com/users/PatrickDropbox/following{/other_user}","gists_url":"https://api.github.com/users/PatrickDropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickDropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickDropbox/subscriptions","organizations_url":"https://api.github.com/users/PatrickDropbox/orgs","repos_url":"https://api.github.com/users/PatrickDropbox/repos","events_url":"https://api.github.com/users/PatrickDropbox/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickDropbox/received_events","type":"User","site_admin":false},"body":"This reduces the churn in the generated code (at dropbox, we check in the generated code into our repos)","created_at":"2015-01-14T05:21:17Z","updated_at":"2015-01-17T13:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54ddfb46820750a1114cf9994333a3ef292bab0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gogo/protobuf/pulls/38/commits","review_comments_url":"https://api.github.com/repos/gogo/protobuf/pulls/38/comments","review_comment_url":"https://api.github.com/repos/gogo/protobuf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gogo/protobuf/issues/38/comments","statuses_url":"https://api.github.com/repos/gogo/protobuf/statuses/de43db2d93f445b9fa1560b4f9aba579eb61a71d","head":{"label":"PatrickDropbox:import-names","ref":"import-names","sha":"de43db2d93f445b9fa1560b4f9aba579eb61a71d","user":{"login":"PatrickDropbox","id":6808940,"avatar_url":"https://avatars.githubusercontent.com/u/6808940?v=3","gravatar_id":"","url":"https://api.github.com/users/PatrickDropbox","html_url":"https://github.com/PatrickDropbox","followers_url":"https://api.github.com/users/PatrickDropbox/followers","following_url":"https://api.github.com/users/PatrickDropbox/following{/other_user}","gists_url":"https://api.github.com/users/PatrickDropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickDropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickDropbox/subscriptions","organizations_url":"https://api.github.com/users/PatrickDropbox/orgs","repos_url":"https://api.github.com/users/PatrickDropbox/repos","events_url":"https://api.github.com/users/PatrickDropbox/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickDropbox/received_events","type":"User","site_admin":false},"repo":{"id":29227410,"name":"protobuf","full_name":"PatrickDropbox/protobuf","owner":{"login":"PatrickDropbox","id":6808940,"avatar_url":"https://avatars.githubusercontent.com/u/6808940?v=3","gravatar_id":"","url":"https://api.github.com/users/PatrickDropbox","html_url":"https://github.com/PatrickDropbox","followers_url":"https://api.github.com/users/PatrickDropbox/followers","following_url":"https://api.github.com/users/PatrickDropbox/following{/other_user}","gists_url":"https://api.github.com/users/PatrickDropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickDropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickDropbox/subscriptions","organizations_url":"https://api.github.com/users/PatrickDropbox/orgs","repos_url":"https://api.github.com/users/PatrickDropbox/repos","events_url":"https://api.github.com/users/PatrickDropbox/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickDropbox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PatrickDropbox/protobuf","description":"Protocol Buffers for Go with Gadgets","fork":true,"url":"https://api.github.com/repos/PatrickDropbox/protobuf","forks_url":"https://api.github.com/repos/PatrickDropbox/protobuf/forks","keys_url":"https://api.github.com/repos/PatrickDropbox/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PatrickDropbox/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PatrickDropbox/protobuf/teams","hooks_url":"https://api.github.com/repos/PatrickDropbox/protobuf/hooks","issue_events_url":"https://api.github.com/repos/PatrickDropbox/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/PatrickDropbox/protobuf/events","assignees_url":"https://api.github.com/repos/PatrickDropbox/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/PatrickDropbox/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/PatrickDropbox/protobuf/tags","blobs_url":"https://api.github.com/repos/PatrickDropbox/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PatrickDropbox/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PatrickDropbox/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/PatrickDropbox/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PatrickDropbox/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/PatrickDropbox/protobuf/languages","stargazers_url":"https://api.github.com/repos/PatrickDropbox/protobuf/stargazers","contributors_url":"https://api.github.com/repos/PatrickDropbox/protobuf/contributors","subscribers_url":"https://api.github.com/repos/PatrickDropbox/protobuf/subscribers","subscription_url":"https://api.github.com/repos/PatrickDropbox/protobuf/subscription","commits_url":"https://api.github.com/repos/PatrickDropbox/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/PatrickDropbox/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/PatrickDropbox/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/PatrickDropbox/protobuf/issues/comments/{number}","contents_url":"https://api.github.com/repos/PatrickDropbox/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/PatrickDropbox/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PatrickDropbox/protobuf/merges","archive_url":"https://api.github.com/repos/PatrickDropbox/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PatrickDropbox/protobuf/downloads","issues_url":"https://api.github.com/repos/PatrickDropbox/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/PatrickDropbox/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/PatrickDropbox/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/PatrickDropbox/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PatrickDropbox/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/PatrickDropbox/protobuf/releases{/id}","created_at":"2015-01-14T04:37:37Z","updated_at":"2015-01-14T04:37:38Z","pushed_at":"2015-01-14T20:20:19Z","git_url":"git://github.com/PatrickDropbox/protobuf.git","ssh_url":"git@github.com:PatrickDropbox/protobuf.git","clone_url":"https://github.com/PatrickDropbox/protobuf.git","svn_url":"https://github.com/PatrickDropbox/protobuf","homepage":"gogo.github.io","size":2096,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gogo:master","ref":"master","sha":"ad85480d189c7d0ad1fe7de2b29d3e1ff1c69883","user":{"login":"gogo","id":9958490,"avatar_url":"https://avatars.githubusercontent.com/u/9958490?v=3","gravatar_id":"","url":"https://api.github.com/users/gogo","html_url":"https://github.com/gogo","followers_url":"https://api.github.com/users/gogo/followers","following_url":"https://api.github.com/users/gogo/following{/other_user}","gists_url":"https://api.github.com/users/gogo/gists{/gist_id}","starred_url":"https://api.github.com/users/gogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogo/subscriptions","organizations_url":"https://api.github.com/users/gogo/orgs","repos_url":"https://api.github.com/users/gogo/repos","events_url":"https://api.github.com/users/gogo/events{/privacy}","received_events_url":"https://api.github.com/users/gogo/received_events","type":"Organization","site_admin":false},"repo":{"id":27483832,"name":"protobuf","full_name":"gogo/protobuf","owner":{"login":"gogo","id":9958490,"avatar_url":"https://avatars.githubusercontent.com/u/9958490?v=3","gravatar_id":"","url":"https://api.github.com/users/gogo","html_url":"https://github.com/gogo","followers_url":"https://api.github.com/users/gogo/followers","following_url":"https://api.github.com/users/gogo/following{/other_user}","gists_url":"https://api.github.com/users/gogo/gists{/gist_id}","starred_url":"https://api.github.com/users/gogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogo/subscriptions","organizations_url":"https://api.github.com/users/gogo/orgs","repos_url":"https://api.github.com/users/gogo/repos","events_url":"https://api.github.com/users/gogo/events{/privacy}","received_events_url":"https://api.github.com/users/gogo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gogo/protobuf","description":"Protocol Buffers for Go with Gadgets","fork":false,"url":"https://api.github.com/repos/gogo/protobuf","forks_url":"https://api.github.com/repos/gogo/protobuf/forks","keys_url":"https://api.github.com/repos/gogo/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gogo/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gogo/protobuf/teams","hooks_url":"https://api.github.com/repos/gogo/protobuf/hooks","issue_events_url":"https://api.github.com/repos/gogo/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/gogo/protobuf/events","assignees_url":"https://api.github.com/repos/gogo/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/gogo/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/gogo/protobuf/tags","blobs_url":"https://api.github.com/repos/gogo/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gogo/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gogo/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gogo/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gogo/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/gogo/protobuf/languages","stargazers_url":"https://api.github.com/repos/gogo/protobuf/stargazers","contributors_url":"https://api.github.com/repos/gogo/protobuf/contributors","subscribers_url":"https://api.github.com/repos/gogo/protobuf/subscribers","subscription_url":"https://api.github.com/repos/gogo/protobuf/subscription","commits_url":"https://api.github.com/repos/gogo/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gogo/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gogo/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gogo/protobuf/issues/comments/{number}","contents_url":"https://api.github.com/repos/gogo/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/gogo/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gogo/protobuf/merges","archive_url":"https://api.github.com/repos/gogo/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gogo/protobuf/downloads","issues_url":"https://api.github.com/repos/gogo/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/gogo/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/gogo/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/gogo/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gogo/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/gogo/protobuf/releases{/id}","created_at":"2014-12-03T11:27:10Z","updated_at":"2015-01-15T02:56:09Z","pushed_at":"2015-01-14T11:15:13Z","git_url":"git://github.com/gogo/protobuf.git","ssh_url":"git@github.com:gogo/protobuf.git","clone_url":"https://github.com/gogo/protobuf.git","svn_url":"https://github.com/gogo/protobuf","homepage":"gogo.github.io","size":2290,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/38"},"html":{"href":"https://github.com/gogo/protobuf/pull/38"},"issue":{"href":"https://api.github.com/repos/gogo/protobuf/issues/38"},"comments":{"href":"https://api.github.com/repos/gogo/protobuf/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/gogo/protobuf/statuses/de43db2d93f445b9fa1560b4f9aba579eb61a71d"}}}}