{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/1692","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/1692/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/1692/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/1692/events","html_url":"https://github.com/acemod/ACE3/pull/1692","id":89661380,"number":1692,"title":"Fix vanilla damage effects","user":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/acemod/ACE3/labels/Bug%20fix","name":"Bug fix","color":"009800"},{"url":"https://api.github.com/repos/acemod/ACE3/labels/WIP","name":"WIP","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/5","html_url":"https://github.com/acemod/ACE3/milestones/3.2.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/5/labels","id":1120679,"number":5,"title":"3.2.0","description":"","creator":{"login":"bux578","id":1235520,"avatar_url":"https://avatars.githubusercontent.com/u/1235520?v=3","gravatar_id":"","url":"https://api.github.com/users/bux578","html_url":"https://github.com/bux578","followers_url":"https://api.github.com/users/bux578/followers","following_url":"https://api.github.com/users/bux578/following{/other_user}","gists_url":"https://api.github.com/users/bux578/gists{/gist_id}","starred_url":"https://api.github.com/users/bux578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bux578/subscriptions","organizations_url":"https://api.github.com/users/bux578/orgs","repos_url":"https://api.github.com/users/bux578/repos","events_url":"https://api.github.com/users/bux578/events{/privacy}","received_events_url":"https://api.github.com/users/bux578/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":57,"state":"open","created_at":"2015-05-20T10:38:42Z","updated_at":"2015-07-02T13:58:12Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-06-19T21:07:34Z","updated_at":"2015-07-02T17:19:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/1692","html_url":"https://github.com/acemod/ACE3/pull/1692","diff_url":"https://github.com/acemod/ACE3/pull/1692.diff","patch_url":"https://github.com/acemod/ACE3/pull/1692.patch"},"body":"Vanilla plays damage effects when `damage unit` returns > 0. \r\n\r\nThe damage is increased when using return values in the `handleDamage` eventhandler. Returning 0 on the eventhandler appears to be breaking the current implementation of handleDamage in both basic and advanced (all units become invulnerable). \r\n\r\nSolution for advanced only at the moment is to reset damage in the caching and apply proper hitpoint damage after we are done processing the handleDamage calls. As an added side bonus this also seems to be fixing the flashing hitpoint textures."},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/118097971","html_url":"https://github.com/acemod/ACE3/pull/1692#issuecomment-118097971","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/1692","id":118097971,"user":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"created_at":"2015-07-02T17:19:41Z","updated_at":"2015-07-02T17:19:41Z","body":"So, should this be merged already @Glowbal?"}}