{"action":"created","comment":{"url":"https://api.github.com/repos/mavlink/mavlink/pulls/comments/24531766","id":24531766,"diff_hunk":"@@ -226,7 +226,7 @@ MAVLINK_HELPER void mavlink_update_checksum(mavlink_message_t* msg, uint8_t c)\n  * A typical use scenario of this function call is:\n  *\n  * @code\n- * #include <inttypes.h> // For fixed-width uint8_t type\n+ * #include <mavlink.h>","path":"pymavlink/generator/C/include_v1.0/mavlink_helpers.h","position":5,"original_position":5,"commit_id":"e2cfa55a6e4de5c60d5d8a8efc6d071dd5ecf8f5","original_commit_id":"e2cfa55a6e4de5c60d5d8a8efc6d071dd5ecf8f5","user":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars.githubusercontent.com/u/1208119?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"body":"Why this change? I'm slightly worried about recursive includes there - I recall some platforms having some order dependencies.","created_at":"2015-02-11T20:48:00Z","updated_at":"2015-02-11T20:48:00Z","html_url":"https://github.com/mavlink/mavlink/pull/323#discussion_r24531766","pull_request_url":"https://api.github.com/repos/mavlink/mavlink/pulls/323","_links":{"self":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/comments/24531766"},"html":{"href":"https://github.com/mavlink/mavlink/pull/323#discussion_r24531766"},"pull_request":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/mavlink/mavlink/pulls/323","id":28605055,"html_url":"https://github.com/mavlink/mavlink/pull/323","diff_url":"https://github.com/mavlink/mavlink/pull/323.diff","patch_url":"https://github.com/mavlink/mavlink/pull/323.patch","issue_url":"https://api.github.com/repos/mavlink/mavlink/issues/323","number":323,"state":"open","locked":false,"title":"Fix #includes referencing inttypes.h","user":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars.githubusercontent.com/u/206363?v=3","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"body":"@LorenzMeier here's your PR for #170!\r\n\r\nThis change has been limited to the 1.0 version of MAVLink, as this code change makes a firm cutoff on supported compilers at VS2010. I don't know if anyone was actually using those compilers with this library, because the old code actually did the opposite of what it should have done. And neither `<inttypes.h>` **nor** `<stdint.h>` are available in these older versions. So this really doesn't break the status quo, it just cleans it up and makes the errors more sane for users trying to compile with older MSVC compilers.\r\n\r\nThis has been tested with VS2013 as well as Microchip's XC16 compiler.","created_at":"2015-02-04T01:05:44Z","updated_at":"2015-02-11T20:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf6029c1b7dd9f289334049be91e9fecb30d36fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mavlink/mavlink/pulls/323/commits","review_comments_url":"https://api.github.com/repos/mavlink/mavlink/pulls/323/comments","review_comment_url":"https://api.github.com/repos/mavlink/mavlink/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mavlink/mavlink/issues/323/comments","statuses_url":"https://api.github.com/repos/mavlink/mavlink/statuses/e2cfa55a6e4de5c60d5d8a8efc6d071dd5ecf8f5","head":{"label":"Susurrus:inttypes","ref":"inttypes","sha":"e2cfa55a6e4de5c60d5d8a8efc6d071dd5ecf8f5","user":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars.githubusercontent.com/u/206363?v=3","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"repo":{"id":3308850,"name":"mavlink","full_name":"Susurrus/mavlink","owner":{"login":"Susurrus","id":206363,"avatar_url":"https://avatars.githubusercontent.com/u/206363?v=3","gravatar_id":"","url":"https://api.github.com/users/Susurrus","html_url":"https://github.com/Susurrus","followers_url":"https://api.github.com/users/Susurrus/followers","following_url":"https://api.github.com/users/Susurrus/following{/other_user}","gists_url":"https://api.github.com/users/Susurrus/gists{/gist_id}","starred_url":"https://api.github.com/users/Susurrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Susurrus/subscriptions","organizations_url":"https://api.github.com/users/Susurrus/orgs","repos_url":"https://api.github.com/users/Susurrus/repos","events_url":"https://api.github.com/users/Susurrus/events{/privacy}","received_events_url":"https://api.github.com/users/Susurrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Susurrus/mavlink","description":"MAVLink micro air vehicle marshalling / communication library","fork":true,"url":"https://api.github.com/repos/Susurrus/mavlink","forks_url":"https://api.github.com/repos/Susurrus/mavlink/forks","keys_url":"https://api.github.com/repos/Susurrus/mavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Susurrus/mavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Susurrus/mavlink/teams","hooks_url":"https://api.github.com/repos/Susurrus/mavlink/hooks","issue_events_url":"https://api.github.com/repos/Susurrus/mavlink/issues/events{/number}","events_url":"https://api.github.com/repos/Susurrus/mavlink/events","assignees_url":"https://api.github.com/repos/Susurrus/mavlink/assignees{/user}","branches_url":"https://api.github.com/repos/Susurrus/mavlink/branches{/branch}","tags_url":"https://api.github.com/repos/Susurrus/mavlink/tags","blobs_url":"https://api.github.com/repos/Susurrus/mavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Susurrus/mavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Susurrus/mavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/Susurrus/mavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Susurrus/mavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/Susurrus/mavlink/languages","stargazers_url":"https://api.github.com/repos/Susurrus/mavlink/stargazers","contributors_url":"https://api.github.com/repos/Susurrus/mavlink/contributors","subscribers_url":"https://api.github.com/repos/Susurrus/mavlink/subscribers","subscription_url":"https://api.github.com/repos/Susurrus/mavlink/subscription","commits_url":"https://api.github.com/repos/Susurrus/mavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/Susurrus/mavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/Susurrus/mavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/Susurrus/mavlink/issues/comments/{number}","contents_url":"https://api.github.com/repos/Susurrus/mavlink/contents/{+path}","compare_url":"https://api.github.com/repos/Susurrus/mavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Susurrus/mavlink/merges","archive_url":"https://api.github.com/repos/Susurrus/mavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Susurrus/mavlink/downloads","issues_url":"https://api.github.com/repos/Susurrus/mavlink/issues{/number}","pulls_url":"https://api.github.com/repos/Susurrus/mavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/Susurrus/mavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/Susurrus/mavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Susurrus/mavlink/labels{/name}","releases_url":"https://api.github.com/repos/Susurrus/mavlink/releases{/id}","created_at":"2012-01-30T21:04:04Z","updated_at":"2014-08-01T14:53:24Z","pushed_at":"2015-02-11T18:54:40Z","git_url":"git://github.com/Susurrus/mavlink.git","ssh_url":"git@github.com:Susurrus/mavlink.git","clone_url":"https://github.com/Susurrus/mavlink.git","svn_url":"https://github.com/Susurrus/mavlink","homepage":"http://qgroundcontrol.org/mavlink/","size":6522,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"3cbdda5c79735ec95632d057a200c8ed748bf451","user":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":2195723,"name":"mavlink","full_name":"mavlink/mavlink","owner":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mavlink/mavlink","description":"MAVLink micro air vehicle marshalling / communication library","fork":false,"url":"https://api.github.com/repos/mavlink/mavlink","forks_url":"https://api.github.com/repos/mavlink/mavlink/forks","keys_url":"https://api.github.com/repos/mavlink/mavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/mavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/mavlink/teams","hooks_url":"https://api.github.com/repos/mavlink/mavlink/hooks","issue_events_url":"https://api.github.com/repos/mavlink/mavlink/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/mavlink/events","assignees_url":"https://api.github.com/repos/mavlink/mavlink/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/mavlink/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/mavlink/tags","blobs_url":"https://api.github.com/repos/mavlink/mavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/mavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/mavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/mavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/mavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/mavlink/languages","stargazers_url":"https://api.github.com/repos/mavlink/mavlink/stargazers","contributors_url":"https://api.github.com/repos/mavlink/mavlink/contributors","subscribers_url":"https://api.github.com/repos/mavlink/mavlink/subscribers","subscription_url":"https://api.github.com/repos/mavlink/mavlink/subscription","commits_url":"https://api.github.com/repos/mavlink/mavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/mavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/mavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/mavlink/issues/comments/{number}","contents_url":"https://api.github.com/repos/mavlink/mavlink/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/mavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/mavlink/merges","archive_url":"https://api.github.com/repos/mavlink/mavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/mavlink/downloads","issues_url":"https://api.github.com/repos/mavlink/mavlink/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/mavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/mavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/mavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/mavlink/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/mavlink/releases{/id}","created_at":"2011-08-12T06:51:52Z","updated_at":"2015-02-11T20:24:36Z","pushed_at":"2015-02-11T20:24:36Z","git_url":"git://github.com/mavlink/mavlink.git","ssh_url":"git@github.com:mavlink/mavlink.git","clone_url":"https://github.com/mavlink/mavlink.git","svn_url":"https://github.com/mavlink/mavlink","homepage":"http://qgroundcontrol.org/mavlink/start","size":10583,"stargazers_count":186,"watchers_count":186,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":59,"forks":248,"open_issues":59,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/323"},"html":{"href":"https://github.com/mavlink/mavlink/pull/323"},"issue":{"href":"https://api.github.com/repos/mavlink/mavlink/issues/323"},"comments":{"href":"https://api.github.com/repos/mavlink/mavlink/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/mavlink/statuses/e2cfa55a6e4de5c60d5d8a8efc6d071dd5ecf8f5"}}}}