{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/27005110","id":27005110,"diff_hunk":"@@ -35,10 +35,8 @@\n \n body {\n   @include sans-family;\n-  line-height: 150%;\n+  line-height: 1.5;","path":"app/assets/stylesheets/active_admin/_base.scss","position":14,"original_position":14,"commit_id":"e346cda34f37f24b5960129dce28b6af7fae483c","original_commit_id":"e346cda34f37f24b5960129dce28b6af7fae483c","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Properties should be ordered background, color, font-size, line-height","created_at":"2015-03-24T06:16:48Z","updated_at":"2015-03-24T06:16:48Z","html_url":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r27005110","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/27005110"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r27005110"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","id":31797608,"html_url":"https://github.com/activeadmin/activeadmin/pull/3862","diff_url":"https://github.com/activeadmin/activeadmin/pull/3862.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3862.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862","number":3862,"state":"open","locked":false,"title":"WIP: Overhaul CSS for maintainability and customization","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"body":"I've seen that CSS overhauls drag on and not take place for ActiveAdmin and I feel like this is something I can help greatly with (I love using ActiveAdmin). I'm attempting to streamline the CSS to make it easier to maintain, improve and finally customize. I see this happening in several steps. I’ll know more as I progress but so far this is what I have in mind and how it will help:\r\n\r\n- [x] Replace reset with normalize.css (resets make debugging horrendously difficult)\r\n- [ ] Remove excessive styles e.g. gradients and shadows (keep default theme basic, only what’s necessary and we can build from there)\r\n- [ ] Remove a lot of cruft and unnecessary styles (seen several that have no effect or are repetitive, we can apply smarter defaults and have less CSS)\r\n- [ ] Configure component styles in variables following a similar convention to Foundation or Bootstrap (e.g. start off with something simple like status tag and go from there)\r\n\r\nWe could use a framework like Foundation or Bootstrap but having thought it through I think it would be best at first to configure as much styles as possible and also to remove excessive styles thus making it easier to support for customization and easier for users to customize. From there we'll see how things work out. Feel free to provide any feedback or thoughts. Thanks.","created_at":"2015-03-24T05:04:13Z","updated_at":"2015-03-24T06:16:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7abc81ce979626a6977db64f3bac1efb279dc8db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/e346cda34f37f24b5960129dce28b6af7fae483c","head":{"label":"javierjulio:update-css-with-overhaul","ref":"update-css-with-overhaul","sha":"e346cda34f37f24b5960129dce28b6af7fae483c","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"repo":{"id":32771575,"name":"activeadmin","full_name":"javierjulio/activeadmin","owner":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierjulio/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/javierjulio/activeadmin","forks_url":"https://api.github.com/repos/javierjulio/activeadmin/forks","keys_url":"https://api.github.com/repos/javierjulio/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierjulio/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierjulio/activeadmin/teams","hooks_url":"https://api.github.com/repos/javierjulio/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/javierjulio/activeadmin/events","assignees_url":"https://api.github.com/repos/javierjulio/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/javierjulio/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/javierjulio/activeadmin/tags","blobs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierjulio/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierjulio/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierjulio/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/javierjulio/activeadmin/languages","stargazers_url":"https://api.github.com/repos/javierjulio/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/javierjulio/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/javierjulio/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/javierjulio/activeadmin/subscription","commits_url":"https://api.github.com/repos/javierjulio/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierjulio/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierjulio/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierjulio/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/javierjulio/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierjulio/activeadmin/merges","archive_url":"https://api.github.com/repos/javierjulio/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierjulio/activeadmin/downloads","issues_url":"https://api.github.com/repos/javierjulio/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/javierjulio/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/javierjulio/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/javierjulio/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierjulio/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/javierjulio/activeadmin/releases{/id}","created_at":"2015-03-24T02:32:35Z","updated_at":"2015-03-24T02:32:38Z","pushed_at":"2015-03-24T06:16:41Z","git_url":"git://github.com/javierjulio/activeadmin.git","ssh_url":"git@github.com:javierjulio/activeadmin.git","clone_url":"https://github.com/javierjulio/activeadmin.git","svn_url":"https://github.com/javierjulio/activeadmin","homepage":"activeadmin.info","size":19207,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"078f234288a15982217ab2594631ef259985b16f","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-03-24T06:02:19Z","pushed_at":"2015-03-24T06:16:43Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19207,"stargazers_count":5795,"watchers_count":5795,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2070,"mirror_url":null,"open_issues_count":189,"forks":2070,"open_issues":189,"watchers":5795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/e346cda34f37f24b5960129dce28b6af7fae483c"}}}}