{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394/events","html_url":"https://github.com/joomla/joomla-cms/pull/7394","id":94090186,"number":7394,"title":"Multilanguage: making Protostar logo link multilang aware","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-07-09T16:13:05Z","updated_at":"2015-07-10T08:10:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7394","html_url":"https://github.com/joomla/joomla-cms/pull/7394","diff_url":"https://github.com/joomla/joomla-cms/pull/7394.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7394.patch"},"body":"In Protostar, the link used for the logo header is always a direct link to the home page.\r\nCode is \r\n```\r\n<a class=\"brand pull-left\" href=\"<?php echo $this->baseurl; ?>/\">\r\n```\r\nThis means that we get an url of the type `http://mysite.com/`\r\n\r\nIn a multilanguage site it means the url will display the site default language or browser default language home page (depending on \"Language Selection for new visitors\") when sef is off \r\n\r\nThis patch, depending if sef is on or off, creates the good url.\r\n\r\n1. Test sef on, \"Remove URL Language code\" set to Yes and with \"Use URL Rewriting\" set to Yes or No\r\n2. Test sef on, \"Remove URL Language code\" set to No and with \"Use URL Rewriting\" set to Yes or No \r\n3. Test with sef off \r\n\r\nIn each case, clicking on the logo will display the site home page in the language in use."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/120283228","html_url":"https://github.com/joomla/joomla-cms/pull/7394#issuecomment-120283228","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394","id":120283228,"user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"created_at":"2015-07-10T08:10:54Z","updated_at":"2015-07-10T08:10:54Z","body":"@Kubik-Rubik I have no idea what you are talking about..."}}