{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/dapp-bin/issues/27","labels_url":"https://api.github.com/repos/ethereum/dapp-bin/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/dapp-bin/issues/27/comments","events_url":"https://api.github.com/repos/ethereum/dapp-bin/issues/27/events","html_url":"https://github.com/ethereum/dapp-bin/pull/27","id":92635842,"number":27,"title":"Updated wallet.sol","user":{"login":"frozeman","id":232662,"avatar_url":"https://avatars.githubusercontent.com/u/232662?v=3","gravatar_id":"","url":"https://api.github.com/users/frozeman","html_url":"https://github.com/frozeman","followers_url":"https://api.github.com/users/frozeman/followers","following_url":"https://api.github.com/users/frozeman/following{/other_user}","gists_url":"https://api.github.com/users/frozeman/gists{/gist_id}","starred_url":"https://api.github.com/users/frozeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozeman/subscriptions","organizations_url":"https://api.github.com/users/frozeman/orgs","repos_url":"https://api.github.com/users/frozeman/repos","events_url":"https://api.github.com/users/frozeman/events{/privacy}","received_events_url":"https://api.github.com/users/frozeman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-02T13:21:13Z","updated_at":"2015-07-03T15:10:52Z","closed_at":"2015-07-03T15:09:02Z","pull_request":{"url":"https://api.github.com/repos/ethereum/dapp-bin/pulls/27","html_url":"https://github.com/ethereum/dapp-bin/pull/27","diff_url":"https://github.com/ethereum/dapp-bin/pull/27.diff","patch_url":"https://github.com/ethereum/dapp-bin/pull/27.patch"},"body":"This PR introduces 4 changes:\r\n\r\n- The operation hash includes the block number, so that every operation hash is unique.\r\nThis is necessary for any interface to display send requests to other wallet owners. As the previous operation hash could be the same when the recipient and the value is the same, it is impossible to determine whether the operation is a new one or an old, which was already confirmed by all owners at a previous time.\r\n- add function `hasConfirmed(operation, owner)`, which allows to check if a owner has already confirmed a transaction.\r\n- moved the variables to the top of the contracts, for better visibility.\r\n- Add identifier to the created event, to be able to track the creation of the contract and receive the contract address though this log. See the following pattern: https://gist.github.com/frozeman/655a9325a93ac198416e"},"comment":{"url":"https://api.github.com/repos/ethereum/dapp-bin/issues/comments/118371111","html_url":"https://github.com/ethereum/dapp-bin/pull/27#issuecomment-118371111","issue_url":"https://api.github.com/repos/ethereum/dapp-bin/issues/27","id":118371111,"user":{"login":"frozeman","id":232662,"avatar_url":"https://avatars.githubusercontent.com/u/232662?v=3","gravatar_id":"","url":"https://api.github.com/users/frozeman","html_url":"https://github.com/frozeman","followers_url":"https://api.github.com/users/frozeman/followers","following_url":"https://api.github.com/users/frozeman/following{/other_user}","gists_url":"https://api.github.com/users/frozeman/gists{/gist_id}","starred_url":"https://api.github.com/users/frozeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozeman/subscriptions","organizations_url":"https://api.github.com/users/frozeman/orgs","repos_url":"https://api.github.com/users/frozeman/repos","events_url":"https://api.github.com/users/frozeman/events{/privacy}","received_events_url":"https://api.github.com/users/frozeman/received_events","type":"User","site_admin":false},"created_at":"2015-07-03T15:10:52Z","updated_at":"2015-07-03T15:10:52Z","body":"ok"}}