{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/100","labels_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/100/comments","events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/100/events","html_url":"https://github.com/broadinstitute/viral-ngs/pull/100","id":58847823,"number":100,"title":"Irwin coord mapper","user":{"login":"iljungr","id":1295313,"avatar_url":"https://avatars.githubusercontent.com/u/1295313?v=3","gravatar_id":"","url":"https://api.github.com/users/iljungr","html_url":"https://github.com/iljungr","followers_url":"https://api.github.com/users/iljungr/followers","following_url":"https://api.github.com/users/iljungr/following{/other_user}","gists_url":"https://api.github.com/users/iljungr/gists{/gist_id}","starred_url":"https://api.github.com/users/iljungr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iljungr/subscriptions","organizations_url":"https://api.github.com/users/iljungr/orgs","repos_url":"https://api.github.com/users/iljungr/repos","events_url":"https://api.github.com/users/iljungr/events{/privacy}","received_events_url":"https://api.github.com/users/iljungr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-25T04:14:52Z","updated_at":"2015-02-25T19:34:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/100","html_url":"https://github.com/broadinstitute/viral-ngs/pull/100","diff_url":"https://github.com/broadinstitute/viral-ngs/pull/100.diff","patch_url":"https://github.com/broadinstitute/viral-ngs/pull/100.patch"},"body":"- Implemented CoordMapper with unit test. Space usage is not optimized in current implementation, but should be fine for viruses.\r\n- Made muscle quite by default."},"comment":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/comments/76037789","html_url":"https://github.com/broadinstitute/viral-ngs/pull/100#issuecomment-76037789","issue_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/100","id":76037789,"user":{"login":"iljungr","id":1295313,"avatar_url":"https://avatars.githubusercontent.com/u/1295313?v=3","gravatar_id":"","url":"https://api.github.com/users/iljungr","html_url":"https://github.com/iljungr","followers_url":"https://api.github.com/users/iljungr/followers","following_url":"https://api.github.com/users/iljungr/following{/other_user}","gists_url":"https://api.github.com/users/iljungr/gists{/gist_id}","starred_url":"https://api.github.com/users/iljungr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iljungr/subscriptions","organizations_url":"https://api.github.com/users/iljungr/orgs","repos_url":"https://api.github.com/users/iljungr/repos","events_url":"https://api.github.com/users/iljungr/events{/privacy}","received_events_url":"https://api.github.com/users/iljungr/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T19:34:16Z","updated_at":"2015-02-25T19:34:16Z","body":"There is no need to refactor in order to get better space utilization. Just define a class for storing the information that implements append, __len__, __getitem__, and __setitem__, that efficiently stores the elements in a list if there are many runs of consecutive integers. Then change the one line \"map = []\" to \"map = MyNewClass()\".\n\nI'll put comments in the code to that effect.\n\nOn Feb 25, 2015, at 9:31 AM, Daniel Park <notifications@github.com> wrote:\n\n> This is awesome. I'll stare at the edge cases more carefully later today when I get a chance, but my guess is that this is spot on. Nice thing is that we can refactor the implementation later on for better space utilization, but having the test coverage in place makes that far easier.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n\n"}}