{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/browser.html/pulls/comments/24949973","id":24949973,"diff_hunk":"@@ -13,18 +13,24 @@ const {Element} = require('./element');\n const {navigateTo, showTabStrip, focus} = require('./actions');\n const {KeyBindings} = require('./keyboard');\n const url = require('./util/url');\n+const {readTheme} = require('./theme');\n \n-const WindowControls = Component(options =>\n-  DOM.div({className: 'windowctrls'}, [\n+const WindowControls = Component(({webViewer}) => {\n+  const theme = readTheme(webViewer);\n+\n+  return DOM.div({className: 'windowctrls'}, [\n     DOM.div({className: 'windowctrl win-close-button',\n+             style: {backgroundColor: theme.close},","path":"src/browser/navigation-panel.js","position":13,"original_position":13,"commit_id":"6d7ed7778972062542f73fb291ad75f7dafd84a0","original_commit_id":"6d7ed7778972062542f73fb291ad75f7dafd84a0","user":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"body":"I was mainly interested in `readTheme` function so I would not have to say `style:{backgroundColor: theme.close}` but instead say a `style: theme.closeButton`, so that if in a future if we decide to style more than just `backgroundColor` we would have to only update `readTheme` function. ","created_at":"2015-02-18T23:00:48Z","updated_at":"2015-02-18T23:00:48Z","html_url":"https://github.com/mozilla/browser.html/pull/93#discussion_r24949973","pull_request_url":"https://api.github.com/repos/mozilla/browser.html/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/comments/24949973"},"html":{"href":"https://github.com/mozilla/browser.html/pull/93#discussion_r24949973"},"pull_request":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/browser.html/pulls/93","id":29556440,"html_url":"https://github.com/mozilla/browser.html/pull/93","diff_url":"https://github.com/mozilla/browser.html/pull/93.diff","patch_url":"https://github.com/mozilla/browser.html/pull/93.patch","issue_url":"https://api.github.com/repos/mozilla/browser.html/issues/93","number":93,"state":"open","locked":false,"title":"Add hardcoded color themes","user":{"login":"gordonbrander","id":58421,"avatar_url":"https://avatars.githubusercontent.com/u/58421?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonbrander","html_url":"https://github.com/gordonbrander","followers_url":"https://api.github.com/users/gordonbrander/followers","following_url":"https://api.github.com/users/gordonbrander/following{/other_user}","gists_url":"https://api.github.com/users/gordonbrander/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonbrander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonbrander/subscriptions","organizations_url":"https://api.github.com/users/gordonbrander/orgs","repos_url":"https://api.github.com/users/gordonbrander/repos","events_url":"https://api.github.com/users/gordonbrander/events{/privacy}","received_events_url":"https://api.github.com/users/gordonbrander/received_events","type":"User","site_admin":false},"body":"New commit on top of master, incorporating suggestions from\r\nhttps://github.com/mozilla/browser.html/pull/67","created_at":"2015-02-18T19:46:04Z","updated_at":"2015-02-18T23:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5445f2ffde5519e65152d8847c8b092b47d8551e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/browser.html/pulls/93/commits","review_comments_url":"https://api.github.com/repos/mozilla/browser.html/pulls/93/comments","review_comment_url":"https://api.github.com/repos/mozilla/browser.html/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/browser.html/issues/93/comments","statuses_url":"https://api.github.com/repos/mozilla/browser.html/statuses/6d7ed7778972062542f73fb291ad75f7dafd84a0","head":{"label":"gordonbrander:2015-02-colortheme2","ref":"2015-02-colortheme2","sha":"6d7ed7778972062542f73fb291ad75f7dafd84a0","user":{"login":"gordonbrander","id":58421,"avatar_url":"https://avatars.githubusercontent.com/u/58421?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonbrander","html_url":"https://github.com/gordonbrander","followers_url":"https://api.github.com/users/gordonbrander/followers","following_url":"https://api.github.com/users/gordonbrander/following{/other_user}","gists_url":"https://api.github.com/users/gordonbrander/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonbrander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonbrander/subscriptions","organizations_url":"https://api.github.com/users/gordonbrander/orgs","repos_url":"https://api.github.com/users/gordonbrander/repos","events_url":"https://api.github.com/users/gordonbrander/events{/privacy}","received_events_url":"https://api.github.com/users/gordonbrander/received_events","type":"User","site_admin":false},"repo":{"id":29149623,"name":"browser.html","full_name":"gordonbrander/browser.html","owner":{"login":"gordonbrander","id":58421,"avatar_url":"https://avatars.githubusercontent.com/u/58421?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonbrander","html_url":"https://github.com/gordonbrander","followers_url":"https://api.github.com/users/gordonbrander/followers","following_url":"https://api.github.com/users/gordonbrander/following{/other_user}","gists_url":"https://api.github.com/users/gordonbrander/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonbrander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonbrander/subscriptions","organizations_url":"https://api.github.com/users/gordonbrander/orgs","repos_url":"https://api.github.com/users/gordonbrander/repos","events_url":"https://api.github.com/users/gordonbrander/events{/privacy}","received_events_url":"https://api.github.com/users/gordonbrander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gordonbrander/browser.html","description":"Experimental browser built in HTML","fork":true,"url":"https://api.github.com/repos/gordonbrander/browser.html","forks_url":"https://api.github.com/repos/gordonbrander/browser.html/forks","keys_url":"https://api.github.com/repos/gordonbrander/browser.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gordonbrander/browser.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gordonbrander/browser.html/teams","hooks_url":"https://api.github.com/repos/gordonbrander/browser.html/hooks","issue_events_url":"https://api.github.com/repos/gordonbrander/browser.html/issues/events{/number}","events_url":"https://api.github.com/repos/gordonbrander/browser.html/events","assignees_url":"https://api.github.com/repos/gordonbrander/browser.html/assignees{/user}","branches_url":"https://api.github.com/repos/gordonbrander/browser.html/branches{/branch}","tags_url":"https://api.github.com/repos/gordonbrander/browser.html/tags","blobs_url":"https://api.github.com/repos/gordonbrander/browser.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gordonbrander/browser.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gordonbrander/browser.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/gordonbrander/browser.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gordonbrander/browser.html/statuses/{sha}","languages_url":"https://api.github.com/repos/gordonbrander/browser.html/languages","stargazers_url":"https://api.github.com/repos/gordonbrander/browser.html/stargazers","contributors_url":"https://api.github.com/repos/gordonbrander/browser.html/contributors","subscribers_url":"https://api.github.com/repos/gordonbrander/browser.html/subscribers","subscription_url":"https://api.github.com/repos/gordonbrander/browser.html/subscription","commits_url":"https://api.github.com/repos/gordonbrander/browser.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/gordonbrander/browser.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/gordonbrander/browser.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/gordonbrander/browser.html/issues/comments/{number}","contents_url":"https://api.github.com/repos/gordonbrander/browser.html/contents/{+path}","compare_url":"https://api.github.com/repos/gordonbrander/browser.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gordonbrander/browser.html/merges","archive_url":"https://api.github.com/repos/gordonbrander/browser.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gordonbrander/browser.html/downloads","issues_url":"https://api.github.com/repos/gordonbrander/browser.html/issues{/number}","pulls_url":"https://api.github.com/repos/gordonbrander/browser.html/pulls{/number}","milestones_url":"https://api.github.com/repos/gordonbrander/browser.html/milestones{/number}","notifications_url":"https://api.github.com/repos/gordonbrander/browser.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gordonbrander/browser.html/labels{/name}","releases_url":"https://api.github.com/repos/gordonbrander/browser.html/releases{/id}","created_at":"2015-01-12T18:22:12Z","updated_at":"2015-01-12T18:22:12Z","pushed_at":"2015-02-18T19:45:22Z","git_url":"git://github.com/gordonbrander/browser.html.git","ssh_url":"git@github.com:gordonbrander/browser.html.git","clone_url":"https://github.com/gordonbrander/browser.html.git","svn_url":"https://github.com/gordonbrander/browser.html","homepage":null,"size":5880,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"5a44f68ef8864026fbb4985ab8504a35fcc547c4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":28800891,"name":"browser.html","full_name":"mozilla/browser.html","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/browser.html","description":"Experimental browser built in HTML","fork":false,"url":"https://api.github.com/repos/mozilla/browser.html","forks_url":"https://api.github.com/repos/mozilla/browser.html/forks","keys_url":"https://api.github.com/repos/mozilla/browser.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/browser.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/browser.html/teams","hooks_url":"https://api.github.com/repos/mozilla/browser.html/hooks","issue_events_url":"https://api.github.com/repos/mozilla/browser.html/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/browser.html/events","assignees_url":"https://api.github.com/repos/mozilla/browser.html/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/browser.html/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/browser.html/tags","blobs_url":"https://api.github.com/repos/mozilla/browser.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/browser.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/browser.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/browser.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/browser.html/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/browser.html/languages","stargazers_url":"https://api.github.com/repos/mozilla/browser.html/stargazers","contributors_url":"https://api.github.com/repos/mozilla/browser.html/contributors","subscribers_url":"https://api.github.com/repos/mozilla/browser.html/subscribers","subscription_url":"https://api.github.com/repos/mozilla/browser.html/subscription","commits_url":"https://api.github.com/repos/mozilla/browser.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/browser.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/browser.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/browser.html/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/browser.html/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/browser.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/browser.html/merges","archive_url":"https://api.github.com/repos/mozilla/browser.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/browser.html/downloads","issues_url":"https://api.github.com/repos/mozilla/browser.html/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/browser.html/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/browser.html/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/browser.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/browser.html/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/browser.html/releases{/id}","created_at":"2015-01-05T06:39:24Z","updated_at":"2015-02-18T21:34:28Z","pushed_at":"2015-02-18T10:12:56Z","git_url":"git://github.com/mozilla/browser.html.git","ssh_url":"git@github.com:mozilla/browser.html.git","clone_url":"https://github.com/mozilla/browser.html.git","svn_url":"https://github.com/mozilla/browser.html","homepage":null,"size":22946,"stargazers_count":174,"watchers_count":174,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":38,"forks":24,"open_issues":38,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/93"},"html":{"href":"https://github.com/mozilla/browser.html/pull/93"},"issue":{"href":"https://api.github.com/repos/mozilla/browser.html/issues/93"},"comments":{"href":"https://api.github.com/repos/mozilla/browser.html/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/browser.html/statuses/6d7ed7778972062542f73fb291ad75f7dafd84a0"}}}}