{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/39684217","id":39684217,"diff_hunk":"@@ -26,15 +26,15 @@ public class CombatDebugOverlay : IPostRender, INotifyDamage\n \t{\n \t\treadonly DeveloperMode devMode;\n \n+\t\treadonly HealthInfo health;\n \t\tLazy<AttackBase> attack;\n \t\tLazy<IBodyOrientation> coords;\n-\t\tLazy<Health> health;","path":"OpenRA.Mods.Common/Traits/CombatDebugOverlay.cs","position":7,"original_position":7,"commit_id":"50a948bc2d6577a6d055657a195793cc51321824","original_commit_id":"50a948bc2d6577a6d055657a195793cc51321824","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=3","gravatar_id":"","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"body":"It is not removing the laziness from a (lazy loaded) trait; rather, it is replacing a trait with its trait info which is initialized before actor creation starts.","created_at":"2015-09-16T20:58:22Z","updated_at":"2015-09-16T20:58:22Z","html_url":"https://github.com/OpenRA/OpenRA/pull/9332#discussion_r39684217","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/39684217"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9332#discussion_r39684217"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332","id":44865339,"html_url":"https://github.com/OpenRA/OpenRA/pull/9332","diff_url":"https://github.com/OpenRA/OpenRA/pull/9332.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/9332.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9332","number":9332,"state":"open","locked":false,"title":"TraitInfo through ActorInfo and HasTrait Removal","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=3","gravatar_id":"","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"body":"Split and rebased from #8927; the reason for taking the earlier commits is the discussion about LINQ-like methods in the comments for #8927.\r\n\r\n*selfOrOtherActor*`.HasTrait<`*Trait*`>()` => *selfOrOtherActor*`.Info.TraitInfosAny<`*TraitInfo*`>`\r\n // with ITraitInfo restriction\r\n\r\n*actorInfo*`.Traits.Contains` => *actorInfo*`.HasTraitInfo` // with ITraitInfo restriction\r\n\r\n*actorInfo*`.Traits.Get` => *actorInfo*`.TraitInfo` // with ITraitInfo restriction\r\n\r\n*actorInfo*`.Traits.GetOrDefault` => *actorInfo*`.TraitInfoOrDefault` // with ITraitInfo restriction\r\n\r\nFoundation for a future PR for reducing trait access and allocation where trait state is not needed.\r\n\r\nSeparated because a few of these changes were put in #8848 to reduce ordering (`InitializeAfter<>`) and requirement (`Requires<>`) requirements and @pchote requested the changes be made everywhere before the split (`Requires<>` => `Requires<>` and `InitializeAfter<>`) in #8848.\r\n\r\nAlmost all of this is just `for f in $(git grep -lF ...); do sed -i s/.../.../g $f; done` substitutions with 1 method removed from `Actor` and 3 wrapper methods with `where T : ITraitInfo` added to `ActorInfo`.\r\n\r\n@RoosterDragon profile this one.","created_at":"2015-09-13T02:15:48Z","updated_at":"2015-09-16T20:58:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bfe2a86935bff7101f33209f30a11bc340eb0f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9332/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/50a948bc2d6577a6d055657a195793cc51321824","head":{"label":"atlimit8:TraitInfoAccess_1","ref":"TraitInfoAccess_1","sha":"50a948bc2d6577a6d055657a195793cc51321824","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=3","gravatar_id":"","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"repo":{"id":20511242,"name":"OpenRA","full_name":"atlimit8/OpenRA","owner":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=3","gravatar_id":"","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atlimit8/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/atlimit8/OpenRA","forks_url":"https://api.github.com/repos/atlimit8/OpenRA/forks","keys_url":"https://api.github.com/repos/atlimit8/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlimit8/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlimit8/OpenRA/teams","hooks_url":"https://api.github.com/repos/atlimit8/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/atlimit8/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/atlimit8/OpenRA/events","assignees_url":"https://api.github.com/repos/atlimit8/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/atlimit8/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/atlimit8/OpenRA/tags","blobs_url":"https://api.github.com/repos/atlimit8/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlimit8/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlimit8/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlimit8/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlimit8/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/atlimit8/OpenRA/languages","stargazers_url":"https://api.github.com/repos/atlimit8/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/atlimit8/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/atlimit8/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/atlimit8/OpenRA/subscription","commits_url":"https://api.github.com/repos/atlimit8/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlimit8/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlimit8/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlimit8/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlimit8/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/atlimit8/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlimit8/OpenRA/merges","archive_url":"https://api.github.com/repos/atlimit8/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlimit8/OpenRA/downloads","issues_url":"https://api.github.com/repos/atlimit8/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/atlimit8/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/atlimit8/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/atlimit8/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlimit8/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/atlimit8/OpenRA/releases{/id}","created_at":"2014-06-05T04:01:26Z","updated_at":"2014-12-09T11:26:08Z","pushed_at":"2015-09-16T09:20:09Z","git_url":"git://github.com/atlimit8/OpenRA.git","ssh_url":"git@github.com:atlimit8/OpenRA.git","clone_url":"https://github.com/atlimit8/OpenRA.git","svn_url":"https://github.com/atlimit8/OpenRA","homepage":"http://www.openra.net","size":93252,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"59edf85513f86b7e3d46a6523fa1785826503ad4","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-09-16T07:14:13Z","pushed_at":"2015-09-16T18:49:36Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":188975,"stargazers_count":2147,"watchers_count":2147,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":770,"mirror_url":null,"open_issues_count":903,"forks":770,"open_issues":903,"watchers":2147,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9332"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9332"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9332/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9332/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/50a948bc2d6577a6d055657a195793cc51321824"}}}}