{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/27369113","id":27369113,"diff_hunk":"@@ -215,7 +228,16 @@ public boolean equals(Object obj) {\n     @Override\n     public String toString() {\n         return \"DiscoveryResult [thingUID=\" + thingUID + \", properties=\" + properties + \", flag=\" + flag + \", label=\"\n-                + label + \", bridgeUID=\" + bridgeUID + \"]\";\n+                + label + \", bridgeUID=\" + bridgeUID + \", ttl=\" + timeToLive + \", createdAt=\" + createdAt + \"]\";\n+    }\n+    \n+    @Override\n+    public long getCreatedAt() {","path":"bundles/config/org.eclipse.smarthome.config.discovery/src/main/java/org/eclipse/smarthome/config/discovery/internal/DiscoveryResultImpl.java","position":null,"original_position":67,"commit_id":"a589dbcbfdd3c6fb2c451d9afed24dd9e90902b9","original_commit_id":"e11703328c00fa1ff016bce7747f920d319bb2ab","user":{"login":"dnobel","id":1380535,"avatar_url":"https://avatars.githubusercontent.com/u/1380535?v=3","gravatar_id":"","url":"https://api.github.com/users/dnobel","html_url":"https://github.com/dnobel","followers_url":"https://api.github.com/users/dnobel/followers","following_url":"https://api.github.com/users/dnobel/following{/other_user}","gists_url":"https://api.github.com/users/dnobel/gists{/gist_id}","starred_url":"https://api.github.com/users/dnobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnobel/subscriptions","organizations_url":"https://api.github.com/users/dnobel/orgs","repos_url":"https://api.github.com/users/dnobel/repos","events_url":"https://api.github.com/users/dnobel/events{/privacy}","received_events_url":"https://api.github.com/users/dnobel/received_events","type":"User","site_admin":false},"body":"Well, naming a variable \"timestamp\" would be the same as naming it \"integer\" or \"boolean\" or \"string\". It says nothing about the meaning of this variable. So what kind of timestamp is it? This was the reason why I suggested to give it another name. I know it is already merged, but we should avoid to name public methods or variables like this.","created_at":"2015-03-30T06:39:10Z","updated_at":"2015-03-30T06:39:10Z","html_url":"https://github.com/eclipse/smarthome/pull/235#discussion_r27369113","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/27369113"},"html":{"href":"https://github.com/eclipse/smarthome/pull/235#discussion_r27369113"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/235","id":31907399,"html_url":"https://github.com/eclipse/smarthome/pull/235","diff_url":"https://github.com/eclipse/smarthome/pull/235.diff","patch_url":"https://github.com/eclipse/smarthome/pull/235.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/235","number":235,"state":"closed","locked":false,"title":"Discovery extension","user":{"login":"afuechsel","id":6408058,"avatar_url":"https://avatars.githubusercontent.com/u/6408058?v=3","gravatar_id":"","url":"https://api.github.com/users/afuechsel","html_url":"https://github.com/afuechsel","followers_url":"https://api.github.com/users/afuechsel/followers","following_url":"https://api.github.com/users/afuechsel/following{/other_user}","gists_url":"https://api.github.com/users/afuechsel/gists{/gist_id}","starred_url":"https://api.github.com/users/afuechsel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afuechsel/subscriptions","organizations_url":"https://api.github.com/users/afuechsel/orgs","repos_url":"https://api.github.com/users/afuechsel/repos","events_url":"https://api.github.com/users/afuechsel/events{/privacy}","received_events_url":"https://api.github.com/users/afuechsel/received_events","type":"User","site_admin":false},"body":"added removeOlderThings for DiscoveryServices and a timeToLive for DiscoveryResults. HueBinding and YahooWeatherBinding extended to use removeOlderThings. UpnpDiscoveryParticipant extended to set the timeToLive.  ","created_at":"2015-03-25T10:02:19Z","updated_at":"2015-03-30T06:39:10Z","closed_at":"2015-03-27T11:26:48Z","merged_at":"2015-03-27T11:26:48Z","merge_commit_sha":"8380d47b21af4a2f470d89fb90288f1f5a077f07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/235/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/235/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/235/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/a589dbcbfdd3c6fb2c451d9afed24dd9e90902b9","head":{"label":"qivicon:discovery-extension","ref":"discovery-extension","sha":"a589dbcbfdd3c6fb2c451d9afed24dd9e90902b9","user":{"login":"qivicon","id":3966591,"avatar_url":"https://avatars.githubusercontent.com/u/3966591?v=3","gravatar_id":"","url":"https://api.github.com/users/qivicon","html_url":"https://github.com/qivicon","followers_url":"https://api.github.com/users/qivicon/followers","following_url":"https://api.github.com/users/qivicon/following{/other_user}","gists_url":"https://api.github.com/users/qivicon/gists{/gist_id}","starred_url":"https://api.github.com/users/qivicon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qivicon/subscriptions","organizations_url":"https://api.github.com/users/qivicon/orgs","repos_url":"https://api.github.com/users/qivicon/repos","events_url":"https://api.github.com/users/qivicon/events{/privacy}","received_events_url":"https://api.github.com/users/qivicon/received_events","type":"Organization","site_admin":false},"repo":{"id":17598413,"name":"smarthome","full_name":"qivicon/smarthome","owner":{"login":"qivicon","id":3966591,"avatar_url":"https://avatars.githubusercontent.com/u/3966591?v=3","gravatar_id":"","url":"https://api.github.com/users/qivicon","html_url":"https://github.com/qivicon","followers_url":"https://api.github.com/users/qivicon/followers","following_url":"https://api.github.com/users/qivicon/following{/other_user}","gists_url":"https://api.github.com/users/qivicon/gists{/gist_id}","starred_url":"https://api.github.com/users/qivicon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qivicon/subscriptions","organizations_url":"https://api.github.com/users/qivicon/orgs","repos_url":"https://api.github.com/users/qivicon/repos","events_url":"https://api.github.com/users/qivicon/events{/privacy}","received_events_url":"https://api.github.com/users/qivicon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qivicon/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/qivicon/smarthome","forks_url":"https://api.github.com/repos/qivicon/smarthome/forks","keys_url":"https://api.github.com/repos/qivicon/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qivicon/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qivicon/smarthome/teams","hooks_url":"https://api.github.com/repos/qivicon/smarthome/hooks","issue_events_url":"https://api.github.com/repos/qivicon/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/qivicon/smarthome/events","assignees_url":"https://api.github.com/repos/qivicon/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/qivicon/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/qivicon/smarthome/tags","blobs_url":"https://api.github.com/repos/qivicon/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qivicon/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qivicon/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/qivicon/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qivicon/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/qivicon/smarthome/languages","stargazers_url":"https://api.github.com/repos/qivicon/smarthome/stargazers","contributors_url":"https://api.github.com/repos/qivicon/smarthome/contributors","subscribers_url":"https://api.github.com/repos/qivicon/smarthome/subscribers","subscription_url":"https://api.github.com/repos/qivicon/smarthome/subscription","commits_url":"https://api.github.com/repos/qivicon/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/qivicon/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/qivicon/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/qivicon/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/qivicon/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/qivicon/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qivicon/smarthome/merges","archive_url":"https://api.github.com/repos/qivicon/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qivicon/smarthome/downloads","issues_url":"https://api.github.com/repos/qivicon/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/qivicon/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/qivicon/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/qivicon/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qivicon/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/qivicon/smarthome/releases{/id}","created_at":"2014-03-10T15:53:08Z","updated_at":"2015-03-26T09:41:24Z","pushed_at":"2015-03-30T06:28:33Z","git_url":"git://github.com/qivicon/smarthome.git","ssh_url":"git@github.com:qivicon/smarthome.git","clone_url":"https://github.com/qivicon/smarthome.git","svn_url":"https://github.com/qivicon/smarthome","homepage":null,"size":27043,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"daf67e9fd86f21b9670f2819213d557824aea366","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","created_at":"2014-01-09T20:47:19Z","updated_at":"2015-03-29T12:59:07Z","pushed_at":"2015-03-30T06:29:54Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":null,"size":11885,"stargazers_count":123,"watchers_count":123,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":6,"forks":114,"open_issues":6,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/235"},"html":{"href":"https://github.com/eclipse/smarthome/pull/235"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/235"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/a589dbcbfdd3c6fb2c451d9afed24dd9e90902b9"}}}}