{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/2228","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/2228/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/2228/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/2228/events","html_url":"https://github.com/musescore/MuseScore/pull/2228","id":107426869,"number":2228,"title":"fix #9352: instrument change transposition","user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-09-21T00:25:59Z","updated_at":"2015-11-02T04:30:10Z","closed_at":"2015-10-28T08:58:03Z","pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/2228","html_url":"https://github.com/musescore/MuseScore/pull/2228","diff_url":"https://github.com/musescore/MuseScore/pull/2228.diff","patch_url":"https://github.com/musescore/MuseScore/pull/2228.patch"},"body":"NOTE: I think this is now ready to merge.\r\n\r\nIt turns out most of the necessary framework was already in place to get Instrument change text to affect transposition.  After all, we already can retrieving the current instrument for a staff by tick, for playback purposes.  Mostly this PR is just a matter of adding the tick parameter when retrieving the current instrument for transposition purposes as well - and actually, more than a few places we were already doing this (leading to bugs, because it wasn't done consistently).\r\n\r\nBasiclly two things left to do:\r\n\r\n1) come up with a better solution for Score::transposeKeys() than my current hack of using a zero or octave interval to signify transposition into or out of concert pitch rather than by a fixed interval).  Should be just a matter of adding a nw parameter or two.\r\n\r\n2) In my current code, the Staff Properties dialog will show the correct instrument settings according to where you clicked when invoking the dialog.  However, any instrument changes you make end up affecting the entire duration of the score.  We will need to detect the proper range and limit the Score::transpositionChanged() to just that range.  In principle, it shouldn't be hard; I'm just not sure how I want to go about this.\r\n\r\nMeanwhile, though, everything else should work well enough to start testing, if anyone is so inclined."},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/152909902","html_url":"https://github.com/musescore/MuseScore/pull/2228#issuecomment-152909902","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/2228","id":152909902,"user":{"login":"ericfont","id":6502474,"avatar_url":"https://avatars.githubusercontent.com/u/6502474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfont","html_url":"https://github.com/ericfont","followers_url":"https://api.github.com/users/ericfont/followers","following_url":"https://api.github.com/users/ericfont/following{/other_user}","gists_url":"https://api.github.com/users/ericfont/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfont/subscriptions","organizations_url":"https://api.github.com/users/ericfont/orgs","repos_url":"https://api.github.com/users/ericfont/repos","events_url":"https://api.github.com/users/ericfont/events{/privacy}","received_events_url":"https://api.github.com/users/ericfont/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T04:30:10Z","updated_at":"2015-11-02T04:30:10Z","body":"I've been using this new instrument change transpose in latest nightly d45cc19 in a sax score that has quite a bit of swapping between bari, alto, tenor, sopr saxes.  I save the score and reopened and did some more editing, but I noticed a strange issue where *some* notes would be displayed exactly an octave higher than normal, both in screen render and pdf export.  I could fix this glitch by right clicking the corresponding change instrument text, selecting change instrument, and re-selecting the instrument that it should be at (indeed they were already previously configured and indicated the correct current instrument) and then when click OK, then all the glitched notes would return to their correct octave.  Even more confusingly, sometimes all notes in a particular section had the glitch, or sometimes it was just a few notes.  \r\n\r\nI'm going to look into more and try to find minimum replication steps and create a test score w/ bug report, but too sleepy right now."}}