{"action":"created","issue":{"url":"https://api.github.com/repos/wbsoft/frescobaldi/issues/760","labels_url":"https://api.github.com/repos/wbsoft/frescobaldi/issues/760/labels{/name}","comments_url":"https://api.github.com/repos/wbsoft/frescobaldi/issues/760/comments","events_url":"https://api.github.com/repos/wbsoft/frescobaldi/issues/760/events","html_url":"https://github.com/wbsoft/frescobaldi/issues/760","id":99898080,"number":760,"title":"[manuscript dev] multiple instances of viewers.ViewdocChooser","user":{"login":"PeterBjuhr","id":355116,"avatar_url":"https://avatars.githubusercontent.com/u/355116?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterBjuhr","html_url":"https://github.com/PeterBjuhr","followers_url":"https://api.github.com/users/PeterBjuhr/followers","following_url":"https://api.github.com/users/PeterBjuhr/following{/other_user}","gists_url":"https://api.github.com/users/PeterBjuhr/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterBjuhr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterBjuhr/subscriptions","organizations_url":"https://api.github.com/users/PeterBjuhr/orgs","repos_url":"https://api.github.com/users/PeterBjuhr/repos","events_url":"https://api.github.com/users/PeterBjuhr/events{/privacy}","received_events_url":"https://api.github.com/users/PeterBjuhr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/wbsoft/frescobaldi/milestones/5","html_url":"https://github.com/wbsoft/frescobaldi/milestones/Initial%20Manuscript%20Viewer","labels_url":"https://api.github.com/repos/wbsoft/frescobaldi/milestones/5/labels","id":1204203,"number":5,"title":"Initial Manuscript Viewer","description":"Working on a *Manuscript viewer* we want to bring that to a first deployable state. This explicitly doesn't comprise all the additional functionality we have in mind for the future","creator":{"login":"uliska","id":1812148,"avatar_url":"https://avatars.githubusercontent.com/u/1812148?v=3","gravatar_id":"","url":"https://api.github.com/users/uliska","html_url":"https://github.com/uliska","followers_url":"https://api.github.com/users/uliska/followers","following_url":"https://api.github.com/users/uliska/following{/other_user}","gists_url":"https://api.github.com/users/uliska/gists{/gist_id}","starred_url":"https://api.github.com/users/uliska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uliska/subscriptions","organizations_url":"https://api.github.com/users/uliska/orgs","repos_url":"https://api.github.com/users/uliska/repos","events_url":"https://api.github.com/users/uliska/events{/privacy}","received_events_url":"https://api.github.com/users/uliska/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":35,"state":"open","created_at":"2015-07-12T21:21:57Z","updated_at":"2015-08-13T23:02:03Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2015-08-09T13:44:00Z","updated_at":"2015-08-14T08:08:25Z","closed_at":null,"body":"When debugging something else I found out that multiple instances of `viewers.ViewdocChooser` (the `QComboBox` for the manuscript files) were created.\r\n\r\nThe instances are created when calling `createWidget` in `ViewdocChooserAction`.  `createWidget` is called when the action is added to a widget. And that is done by the toolbar which it should but also by `QMenu` objects which I believe is a problem. I think this must be happening in the context menu, but couldn't find where directly."},"comment":{"url":"https://api.github.com/repos/wbsoft/frescobaldi/issues/comments/131013238","html_url":"https://github.com/wbsoft/frescobaldi/issues/760#issuecomment-131013238","issue_url":"https://api.github.com/repos/wbsoft/frescobaldi/issues/760","id":131013238,"user":{"login":"PeterBjuhr","id":355116,"avatar_url":"https://avatars.githubusercontent.com/u/355116?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterBjuhr","html_url":"https://github.com/PeterBjuhr","followers_url":"https://api.github.com/users/PeterBjuhr/followers","following_url":"https://api.github.com/users/PeterBjuhr/following{/other_user}","gists_url":"https://api.github.com/users/PeterBjuhr/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterBjuhr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterBjuhr/subscriptions","organizations_url":"https://api.github.com/users/PeterBjuhr/orgs","repos_url":"https://api.github.com/users/PeterBjuhr/repos","events_url":"https://api.github.com/users/PeterBjuhr/events{/privacy}","received_events_url":"https://api.github.com/users/PeterBjuhr/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T08:08:25Z","updated_at":"2015-08-14T08:08:25Z","body":">>It turns out that if we add/place the documentchooser first in the\r\ntoolbar the problem is \"solved\". Although I think we can live with that\r\nlittle rearrangement,\r\n\r\n>What rearrangement would you suggest? \r\n\r\nWhat I meant was that having the documentchooser as the leftmost action isn't that bad if it would help anything. I'm far from convinced that we should do it so I'm not suggesting it!\r\n\r\n>The only one I can imagine would be moving the help button to the right end of the toolbar. But I'm not so sure I would like to \"live\" with that.\r\n\r\nActually I would prefer this move, I'll get back to this...\r\n\r\nAnd moving the documentchooser to the left would make the toolbar more consistent with the music view toolbar. So actually there are advantages to the rearrangement. But I think having the open and close buttons to the left is more intuitive. And as a solution to the problem it is obviously totally sweeping the issue under the rug.\r\n\r\n>Right now we assume we have a bug somewhere, be it in our coding or in Qt. And we hope to fix that one day, sooner or later. When we apply a workaround we assume this to be temporary.\r\nIt seems we have a choice between rearranging the buttons and suppressing adding the chooser to the toolbuttons' menus. Both are workarounds and no cures.\r\n\r\nI agree. And I haven't noticed any real problems so it may be a bug we can live with and hope it would one day be solved (maybe by a qt upgrade or by a redesign we are doing anyway). What I mean is that we may not actually need a temporary workaround. But what I would like before closing this is to make sure we are not doing something wrong ourselves. \r\n\r\n>>I can't reproduce this in the Musicviewer so it seems we will find the bug in the viewer/manuscript code after all!\r\n\r\n>So, what are the differences between the old and the new viewer?\r\n\r\n>The Musicview doesn't have the toolbar integrated but only in the mainwindow.\r\n\r\nDo you think it matters where the toolbar is placed? Maybe we could debug moving the toolbar and see if it makes any difference!?\r\n\r\n>The Musicview's toolbar doesn't have the help button nor the add/close actions - so the probable culprits aren't there.\r\n\r\nIn my test I put the print action before the documentchooser...\r\n\r\nI may be wrong but I think that if it really is a qt bug we should be able to reproduce it also in the music viewer (somehow...). Not being able to reproduce it strongly suggests to me that the problem lies in our coding."}}