{"action":"created","issue":{"url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/issues/30","labels_url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/issues/30/comments","events_url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/issues/30/events","html_url":"https://github.com/cl-plus-ssl/cl-plus-ssl/pull/30","id":121872567,"number":30,"title":"Verify hostname","user":{"login":"deadtrickster","id":172311,"avatar_url":"https://avatars.githubusercontent.com/u/172311?v=3","gravatar_id":"","url":"https://api.github.com/users/deadtrickster","html_url":"https://github.com/deadtrickster","followers_url":"https://api.github.com/users/deadtrickster/followers","following_url":"https://api.github.com/users/deadtrickster/following{/other_user}","gists_url":"https://api.github.com/users/deadtrickster/gists{/gist_id}","starred_url":"https://api.github.com/users/deadtrickster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadtrickster/subscriptions","organizations_url":"https://api.github.com/users/deadtrickster/orgs","repos_url":"https://api.github.com/users/deadtrickster/repos","events_url":"https://api.github.com/users/deadtrickster/events{/privacy}","received_events_url":"https://api.github.com/users/deadtrickster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-12-12T19:11:11Z","updated_at":"2015-12-22T01:32:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/pulls/30","html_url":"https://github.com/cl-plus-ssl/cl-plus-ssl/pull/30","diff_url":"https://github.com/cl-plus-ssl/cl-plus-ssl/pull/30.diff","patch_url":"https://github.com/cl-plus-ssl/cl-plus-ssl/pull/30.patch"},"body":"This should replace https://github.com/cl-plus-ssl/cl-plus-ssl/pull/8\r\n\r\nTODO:\r\n- [x] Complete ASN1 String types handling\r\n- [x] Null-pointer checks\r\n- [x] Error types"},"comment":{"url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/issues/comments/166474268","html_url":"https://github.com/cl-plus-ssl/cl-plus-ssl/pull/30#issuecomment-166474268","issue_url":"https://api.github.com/repos/cl-plus-ssl/cl-plus-ssl/issues/30","id":166474268,"user":{"login":"avodonosov","id":2444,"avatar_url":"https://avatars.githubusercontent.com/u/2444?v=3","gravatar_id":"","url":"https://api.github.com/users/avodonosov","html_url":"https://github.com/avodonosov","followers_url":"https://api.github.com/users/avodonosov/followers","following_url":"https://api.github.com/users/avodonosov/following{/other_user}","gists_url":"https://api.github.com/users/avodonosov/gists{/gist_id}","starred_url":"https://api.github.com/users/avodonosov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avodonosov/subscriptions","organizations_url":"https://api.github.com/users/avodonosov/orgs","repos_url":"https://api.github.com/users/avodonosov/repos","events_url":"https://api.github.com/users/avodonosov/events{/privacy}","received_events_url":"https://api.github.com/users/avodonosov/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T01:32:50Z","updated_at":"2015-12-22T01:32:50Z","body":"@deadtrickster , first of all, sorry for the slow review - please don't take it as if I'm not interested to have it merged, I just don't have enough free time after work. Also this pull request is relatively complex - a lot to learn (ASN.1, ASN.1 string types)\r\n\r\nI'd like to ask you to move the ffi definitions from x509.lisp to ffi.lisp. We currently have this separation, and the file name ffi.lisp tells the code reader this file contains ffi definitions. I understand one can question usefulness of such separation; maybe it's more convenient for you to edit x509 related foreign definitoins \"in place\", right near your lispy x509 wrappers. But if do so, we should refactor everything and remove ffi.lisp at all.\r\n\r\nffi.lisp name gives reader a signal \"ffi is here\". Thinking it's not useful is one thing. But leaving the ffi.lisp while using different principle of code organization, ffi.lisp name becomes a _wrong_ signal, it still tells \"ffi is here\" while it's false, ffi is not only there, but in other places too. And when we mix two classifications: some code is separated as ffi/not ffi, and other code is divided as x509/not x509, it's like for example say that mobile phones maybe classified as samsung phones, or black phones.\r\n\r\nIt's one argument. Another argument is that I hope to move the plain OpenSSL FFI bindings into a separate package; and have lispy wrappers in their own packages.\r\n\r\nAlso, moving the defs to ffi.lisp will it unnecessary to use `#.` with ffi contstans in x509.lisp."}}