{"action":"created","comment":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments/34089565","id":34089565,"diff_hunk":"@@ -354,7 +354,7 @@ local function SpawnStartUnit(teamID, playerID, isAI, bonusSpawn, notAtTheStartO\n \tlocal x,y,z\n \tlocal startPosition = luaSetStartPositions[teamID]\n \tif not startPosition then\n-\t\tif (startboxString and not Spring.GetTeamRulesParam(teamID, \"valid_startpos\")) or (not startboxString and notAtTheStartOfTheGame and (Game.startPosType == 2)) then\n+\t\tif (startboxString and not (Spring.GetTeamRulesParam(teamID, \"valid_startpos\") or isAI)) or (not startboxString and notAtTheStartOfTheGame and (Game.startPosType == 2)) then\n \t\t\tx,y,z = getMiddleOfStartBox(teamID)\n \t\telse\n \t\t\tx,y,z = Spring.GetTeamStartPosition(teamID)","path":"LuaRules/Gadgets/start_unit_setup.lua","position":8,"original_position":8,"commit_id":"0a5e8d5bbc859ab816dafe9e9d13df5460512d05","original_commit_id":"0a5e8d5bbc859ab816dafe9e9d13df5460512d05","user":{"login":"sprunk","id":2573076,"avatar_url":"https://avatars.githubusercontent.com/u/2573076?v=3","gravatar_id":"","url":"https://api.github.com/users/sprunk","html_url":"https://github.com/sprunk","followers_url":"https://api.github.com/users/sprunk/followers","following_url":"https://api.github.com/users/sprunk/following{/other_user}","gists_url":"https://api.github.com/users/sprunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sprunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprunk/subscriptions","organizations_url":"https://api.github.com/users/sprunk/orgs","repos_url":"https://api.github.com/users/sprunk/repos","events_url":"https://api.github.com/users/sprunk/events{/privacy}","received_events_url":"https://api.github.com/users/sprunk/received_events","type":"User","site_admin":false},"body":"Good idea.","created_at":"2015-07-07T20:56:21Z","updated_at":"2015-07-07T20:56:21Z","html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/906#discussion_r34089565","pull_request_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906","_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments/34089565"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/906#discussion_r34089565"},"pull_request":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906"}}},"pull_request":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906","id":39219039,"html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/906","diff_url":"https://github.com/ZeroK-RTS/Zero-K/pull/906.diff","patch_url":"https://github.com/ZeroK-RTS/Zero-K/pull/906.patch","issue_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/906","number":906,"state":"open","locked":false,"title":"Startboxes: let AI start anywhere","user":{"login":"sprunk","id":2573076,"avatar_url":"https://avatars.githubusercontent.com/u/2573076?v=3","gravatar_id":"","url":"https://api.github.com/users/sprunk","html_url":"https://github.com/sprunk","followers_url":"https://api.github.com/users/sprunk/followers","following_url":"https://api.github.com/users/sprunk/following{/other_user}","gists_url":"https://api.github.com/users/sprunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sprunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprunk/subscriptions","organizations_url":"https://api.github.com/users/sprunk/orgs","repos_url":"https://api.github.com/users/sprunk/repos","events_url":"https://api.github.com/users/sprunk/events{/privacy}","received_events_url":"https://api.github.com/users/sprunk/received_events","type":"User","site_admin":false},"body":"See #905\r\n\r\nPreviously AI couldn't pick a startpos at all and always got the default middle of startbox position.\r\nNow it will be able to start anywhere (including out of the box for cheating AI). Bots that don't pick any startpos always place a default one in the middle of the map and thus will now start there (mostly relevant for Null AI).\r\n\r\nThe obvious scope of picking inside own box is not possible because AllowStartPosition does not discern bots so it would not know which box to use.","created_at":"2015-07-05T10:48:13Z","updated_at":"2015-07-07T20:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8f48acb940e9b096e6978af5b58453c74bea2f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906/commits","review_comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906/comments","review_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/906/comments","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/0a5e8d5bbc859ab816dafe9e9d13df5460512d05","head":{"label":"sprunk:patch-18","ref":"patch-18","sha":"0a5e8d5bbc859ab816dafe9e9d13df5460512d05","user":{"login":"sprunk","id":2573076,"avatar_url":"https://avatars.githubusercontent.com/u/2573076?v=3","gravatar_id":"","url":"https://api.github.com/users/sprunk","html_url":"https://github.com/sprunk","followers_url":"https://api.github.com/users/sprunk/followers","following_url":"https://api.github.com/users/sprunk/following{/other_user}","gists_url":"https://api.github.com/users/sprunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sprunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprunk/subscriptions","organizations_url":"https://api.github.com/users/sprunk/orgs","repos_url":"https://api.github.com/users/sprunk/repos","events_url":"https://api.github.com/users/sprunk/events{/privacy}","received_events_url":"https://api.github.com/users/sprunk/received_events","type":"User","site_admin":false},"repo":{"id":22791055,"name":"Zero-K","full_name":"sprunk/Zero-K","owner":{"login":"sprunk","id":2573076,"avatar_url":"https://avatars.githubusercontent.com/u/2573076?v=3","gravatar_id":"","url":"https://api.github.com/users/sprunk","html_url":"https://github.com/sprunk","followers_url":"https://api.github.com/users/sprunk/followers","following_url":"https://api.github.com/users/sprunk/following{/other_user}","gists_url":"https://api.github.com/users/sprunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sprunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprunk/subscriptions","organizations_url":"https://api.github.com/users/sprunk/orgs","repos_url":"https://api.github.com/users/sprunk/repos","events_url":"https://api.github.com/users/sprunk/events{/privacy}","received_events_url":"https://api.github.com/users/sprunk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sprunk/Zero-K","description":"Open source RTS game running on the Spring engine","fork":true,"url":"https://api.github.com/repos/sprunk/Zero-K","forks_url":"https://api.github.com/repos/sprunk/Zero-K/forks","keys_url":"https://api.github.com/repos/sprunk/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sprunk/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sprunk/Zero-K/teams","hooks_url":"https://api.github.com/repos/sprunk/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/sprunk/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/sprunk/Zero-K/events","assignees_url":"https://api.github.com/repos/sprunk/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/sprunk/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/sprunk/Zero-K/tags","blobs_url":"https://api.github.com/repos/sprunk/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sprunk/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sprunk/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/sprunk/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sprunk/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/sprunk/Zero-K/languages","stargazers_url":"https://api.github.com/repos/sprunk/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/sprunk/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/sprunk/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/sprunk/Zero-K/subscription","commits_url":"https://api.github.com/repos/sprunk/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/sprunk/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/sprunk/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/sprunk/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/sprunk/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/sprunk/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sprunk/Zero-K/merges","archive_url":"https://api.github.com/repos/sprunk/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sprunk/Zero-K/downloads","issues_url":"https://api.github.com/repos/sprunk/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/sprunk/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/sprunk/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/sprunk/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sprunk/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/sprunk/Zero-K/releases{/id}","created_at":"2014-08-09T17:14:03Z","updated_at":"2014-09-12T18:11:27Z","pushed_at":"2015-07-07T20:54:47Z","git_url":"git://github.com/sprunk/Zero-K.git","ssh_url":"git@github.com:sprunk/Zero-K.git","clone_url":"https://github.com/sprunk/Zero-K.git","svn_url":"https://github.com/sprunk/Zero-K","homepage":null,"size":417880,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZeroK-RTS:master","ref":"master","sha":"1137a707641896109fca99f90d36a183aff3d663","user":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars.githubusercontent.com/u/5145185?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"repo":{"id":11837082,"name":"Zero-K","full_name":"ZeroK-RTS/Zero-K","owner":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars.githubusercontent.com/u/5145185?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZeroK-RTS/Zero-K","description":"Open source RTS game running on the Spring engine","fork":false,"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K","forks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/forks","keys_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/teams","hooks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/events","assignees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/tags","blobs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/languages","stargazers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscription","commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/merges","archive_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/downloads","issues_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/releases{/id}","created_at":"2013-08-02T06:57:00Z","updated_at":"2015-07-02T10:32:41Z","pushed_at":"2015-07-07T14:56:20Z","git_url":"git://github.com/ZeroK-RTS/Zero-K.git","ssh_url":"git@github.com:ZeroK-RTS/Zero-K.git","clone_url":"https://github.com/ZeroK-RTS/Zero-K.git","svn_url":"https://github.com/ZeroK-RTS/Zero-K","homepage":null,"size":426695,"stargazers_count":44,"watchers_count":44,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":59,"forks":35,"open_issues":59,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/906"},"issue":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/906"},"comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/0a5e8d5bbc859ab816dafe9e9d13df5460512d05"}}}}