{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/1","id":37219348,"html_url":"https://github.com/Joris-van-der-Wel/readable-blob-stream/pull/1","diff_url":"https://github.com/Joris-van-der-Wel/readable-blob-stream/pull/1.diff","patch_url":"https://github.com/Joris-van-der-Wel/readable-blob-stream/pull/1.patch","issue_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues/1","number":1,"state":"closed","locked":false,"title":"make work in electron/NW.js apps (without browserify)","user":{"login":"mmckegg","id":66834,"avatar_url":"https://avatars.githubusercontent.com/u/66834?v=3","gravatar_id":"","url":"https://api.github.com/users/mmckegg","html_url":"https://github.com/mmckegg","followers_url":"https://api.github.com/users/mmckegg/followers","following_url":"https://api.github.com/users/mmckegg/following{/other_user}","gists_url":"https://api.github.com/users/mmckegg/gists{/gist_id}","starred_url":"https://api.github.com/users/mmckegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmckegg/subscriptions","organizations_url":"https://api.github.com/users/mmckegg/orgs","repos_url":"https://api.github.com/users/mmckegg/repos","events_url":"https://api.github.com/users/mmckegg/events{/privacy}","received_events_url":"https://api.github.com/users/mmckegg/received_events","type":"User","site_admin":false},"body":"I was trying to use this module inside an [electron](https://github.com/atom/electron) app, but the explicit dependency on the browserify version of `Buffer` breaks the [conversion to `Buffer` check](https://github.com/Joris-van-der-Wel/readable-blob-stream/blob/master/index.js#L51) when running in directly in Node without browserify. \r\n\r\nThis is a problem in electron (and NW.js) because it has access to both DOM and Node objects. It simply fails with an error, because ReadableStream only excepts \"true\" Buffers when running in Node. \r\n\r\nRemoving the require fixed the problem, and now it works outside of browserify as expected .","created_at":"2015-06-09T04:51:29Z","updated_at":"2015-06-09T10:20:18Z","closed_at":"2015-06-09T10:20:18Z","merged_at":null,"merge_commit_sha":"adbefa73843c15f6edfe7889fb78a894b73edb89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues/1/comments","statuses_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/statuses/5881a17fd23435288c7591d7d34ce0dab5137fbc","head":{"label":"mmckegg:mmckegg-patch-1","ref":"mmckegg-patch-1","sha":"5881a17fd23435288c7591d7d34ce0dab5137fbc","user":{"login":"mmckegg","id":66834,"avatar_url":"https://avatars.githubusercontent.com/u/66834?v=3","gravatar_id":"","url":"https://api.github.com/users/mmckegg","html_url":"https://github.com/mmckegg","followers_url":"https://api.github.com/users/mmckegg/followers","following_url":"https://api.github.com/users/mmckegg/following{/other_user}","gists_url":"https://api.github.com/users/mmckegg/gists{/gist_id}","starred_url":"https://api.github.com/users/mmckegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmckegg/subscriptions","organizations_url":"https://api.github.com/users/mmckegg/orgs","repos_url":"https://api.github.com/users/mmckegg/repos","events_url":"https://api.github.com/users/mmckegg/events{/privacy}","received_events_url":"https://api.github.com/users/mmckegg/received_events","type":"User","site_admin":false},"repo":{"id":37110416,"name":"readable-blob-stream","full_name":"mmckegg/readable-blob-stream","owner":{"login":"mmckegg","id":66834,"avatar_url":"https://avatars.githubusercontent.com/u/66834?v=3","gravatar_id":"","url":"https://api.github.com/users/mmckegg","html_url":"https://github.com/mmckegg","followers_url":"https://api.github.com/users/mmckegg/followers","following_url":"https://api.github.com/users/mmckegg/following{/other_user}","gists_url":"https://api.github.com/users/mmckegg/gists{/gist_id}","starred_url":"https://api.github.com/users/mmckegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmckegg/subscriptions","organizations_url":"https://api.github.com/users/mmckegg/orgs","repos_url":"https://api.github.com/users/mmckegg/repos","events_url":"https://api.github.com/users/mmckegg/events{/privacy}","received_events_url":"https://api.github.com/users/mmckegg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmckegg/readable-blob-stream","description":"Read W3C Blob & File objects as a Node stream. Very useful with \"browserify\" and \"primus\" with \"ejson\" using pipe()","fork":true,"url":"https://api.github.com/repos/mmckegg/readable-blob-stream","forks_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/forks","keys_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/teams","hooks_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/hooks","issue_events_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/events","assignees_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/tags","blobs_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/languages","stargazers_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/stargazers","contributors_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/contributors","subscribers_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/subscribers","subscription_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/subscription","commits_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/merges","archive_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/downloads","issues_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/labels{/name}","releases_url":"https://api.github.com/repos/mmckegg/readable-blob-stream/releases{/id}","created_at":"2015-06-09T04:35:00Z","updated_at":"2015-06-09T04:35:00Z","pushed_at":"2015-06-09T04:47:10Z","git_url":"git://github.com/mmckegg/readable-blob-stream.git","ssh_url":"git@github.com:mmckegg/readable-blob-stream.git","clone_url":"https://github.com/mmckegg/readable-blob-stream.git","svn_url":"https://github.com/mmckegg/readable-blob-stream","homepage":null,"size":127,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Joris-van-der-Wel:master","ref":"master","sha":"fb79aa829d6fa5a19a71942984c300e93c1ceca4","user":{"login":"Joris-van-der-Wel","id":745898,"avatar_url":"https://avatars.githubusercontent.com/u/745898?v=3","gravatar_id":"","url":"https://api.github.com/users/Joris-van-der-Wel","html_url":"https://github.com/Joris-van-der-Wel","followers_url":"https://api.github.com/users/Joris-van-der-Wel/followers","following_url":"https://api.github.com/users/Joris-van-der-Wel/following{/other_user}","gists_url":"https://api.github.com/users/Joris-van-der-Wel/gists{/gist_id}","starred_url":"https://api.github.com/users/Joris-van-der-Wel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joris-van-der-Wel/subscriptions","organizations_url":"https://api.github.com/users/Joris-van-der-Wel/orgs","repos_url":"https://api.github.com/users/Joris-van-der-Wel/repos","events_url":"https://api.github.com/users/Joris-van-der-Wel/events{/privacy}","received_events_url":"https://api.github.com/users/Joris-van-der-Wel/received_events","type":"User","site_admin":false},"repo":{"id":26996838,"name":"readable-blob-stream","full_name":"Joris-van-der-Wel/readable-blob-stream","owner":{"login":"Joris-van-der-Wel","id":745898,"avatar_url":"https://avatars.githubusercontent.com/u/745898?v=3","gravatar_id":"","url":"https://api.github.com/users/Joris-van-der-Wel","html_url":"https://github.com/Joris-van-der-Wel","followers_url":"https://api.github.com/users/Joris-van-der-Wel/followers","following_url":"https://api.github.com/users/Joris-van-der-Wel/following{/other_user}","gists_url":"https://api.github.com/users/Joris-van-der-Wel/gists{/gist_id}","starred_url":"https://api.github.com/users/Joris-van-der-Wel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joris-van-der-Wel/subscriptions","organizations_url":"https://api.github.com/users/Joris-van-der-Wel/orgs","repos_url":"https://api.github.com/users/Joris-van-der-Wel/repos","events_url":"https://api.github.com/users/Joris-van-der-Wel/events{/privacy}","received_events_url":"https://api.github.com/users/Joris-van-der-Wel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Joris-van-der-Wel/readable-blob-stream","description":"Read W3C Blob & File objects as a Node stream. Very useful with \"browserify\" and \"primus\" with \"ejson\" using pipe()","fork":false,"url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream","forks_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/forks","keys_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/teams","hooks_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/hooks","issue_events_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues/events{/number}","events_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/events","assignees_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/assignees{/user}","branches_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/branches{/branch}","tags_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/tags","blobs_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/languages","stargazers_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/stargazers","contributors_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/contributors","subscribers_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/subscribers","subscription_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/subscription","commits_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/contents/{+path}","compare_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/merges","archive_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/downloads","issues_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues{/number}","pulls_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/labels{/name}","releases_url":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/releases{/id}","created_at":"2014-11-22T11:23:40Z","updated_at":"2015-06-09T08:34:01Z","pushed_at":"2015-06-09T10:17:20Z","git_url":"git://github.com/Joris-van-der-Wel/readable-blob-stream.git","ssh_url":"git@github.com:Joris-van-der-Wel/readable-blob-stream.git","clone_url":"https://github.com/Joris-van-der-Wel/readable-blob-stream.git","svn_url":"https://github.com/Joris-van-der-Wel/readable-blob-stream","homepage":null,"size":124,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/1"},"html":{"href":"https://github.com/Joris-van-der-Wel/readable-blob-stream/pull/1"},"issue":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues/1"},"comments":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Joris-van-der-Wel/readable-blob-stream/statuses/5881a17fd23435288c7591d7d34ce0dab5137fbc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":1}}