{"action":"created","comment":{"url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/comments/36015616","id":36015616,"diff_hunk":"@@ -15,31 +15,14 @@ class VideoPuppeteer(object):\n     Wrapper around HTML5 video element\n     \"\"\"\n \n-    # Adapted from\n-    # https://github.com/gavinsharp/aboutmedia/blob/master/chrome/content/aboutmedia.xhtml\n-    _debug_script = \"\"\"\n-    var mainWindow = window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)\n-        .getInterface(Components.interfaces.nsIWebNavigation)\n-        .QueryInterface(Components.interfaces.nsIDocShellTreeItem)\n-        .rootTreeItem\n-        .QueryInterface(Components.interfaces.nsIInterfaceRequestor)\n-        .getInterface(Components.interfaces.nsIDOMWindow);\n-    var tabbrowser = mainWindow.gBrowser;\n-    for (var i=0; i < tabbrowser.browsers.length; ++i) {\n-      var b = tabbrowser.getBrowserAtIndex(i);\n-      var media = b.contentDocumentAsCPOW.getElementsByTagName('video');\n-      for (var j=0; j < media.length; ++j) {\n-         var ms = media[j].mozMediaSourceObject;\n-         if (ms) {\n-           debugLines = ms.mozDebugReaderData.split(\\\"\\\\n\\\");\n-           return debugLines;\n-         }\n-      }\n-    }\"\"\"\n-\n-    def __init__(self, marionette, url, video_selector='video'):\n+    def __init__(self, marionette, url, video_selector='video', interval=1,\n+                 duration=None, stall_wait_time=3, timeout=None):","path":"media_utils/video_puppeteer.py","position":37,"original_position":37,"commit_id":"d5e8a99487c0874d3922918e5d92a57d8ebe5b9d","original_commit_id":"d5e8a99487c0874d3922918e5d92a57d8ebe5b9d","user":{"login":"sydvicious","id":984554,"avatar_url":"https://avatars.githubusercontent.com/u/984554?v=3","gravatar_id":"","url":"https://api.github.com/users/sydvicious","html_url":"https://github.com/sydvicious","followers_url":"https://api.github.com/users/sydvicious/followers","following_url":"https://api.github.com/users/sydvicious/following{/other_user}","gists_url":"https://api.github.com/users/sydvicious/gists{/gist_id}","starred_url":"https://api.github.com/users/sydvicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydvicious/subscriptions","organizations_url":"https://api.github.com/users/sydvicious/orgs","repos_url":"https://api.github.com/users/sydvicious/repos","events_url":"https://api.github.com/users/sydvicious/events{/privacy}","received_events_url":"https://api.github.com/users/sydvicious/received_events","type":"User","site_admin":false},"body":"Rationalized. If stall_wait_time is not specified, we don't check for stalls now.","created_at":"2015-07-31T20:57:09Z","updated_at":"2015-07-31T20:57:09Z","html_url":"https://github.com/mjzffr/firefox-media-tests/pull/12#discussion_r36015616","pull_request_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/comments/36015616"},"html":{"href":"https://github.com/mjzffr/firefox-media-tests/pull/12#discussion_r36015616"},"pull_request":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12","id":41181783,"html_url":"https://github.com/mjzffr/firefox-media-tests/pull/12","diff_url":"https://github.com/mjzffr/firefox-media-tests/pull/12.diff","patch_url":"https://github.com/mjzffr/firefox-media-tests/pull/12.patch","issue_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/12","number":12,"state":"open","locked":false,"title":"Bug 1188103: Do a better job detecting stalls without calling Firefox","user":{"login":"sydvicious","id":984554,"avatar_url":"https://avatars.githubusercontent.com/u/984554?v=3","gravatar_id":"","url":"https://api.github.com/users/sydvicious","html_url":"https://github.com/sydvicious","followers_url":"https://api.github.com/users/sydvicious/followers","following_url":"https://api.github.com/users/sydvicious/following{/other_user}","gists_url":"https://api.github.com/users/sydvicious/gists{/gist_id}","starred_url":"https://api.github.com/users/sydvicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydvicious/subscriptions","organizations_url":"https://api.github.com/users/sydvicious/orgs","repos_url":"https://api.github.com/users/sydvicious/repos","events_url":"https://api.github.com/users/sydvicious/events{/privacy}","received_events_url":"https://api.github.com/users/sydvicious/received_events","type":"User","site_admin":false},"body":"Bug 1183513: Do a better job detecting stalls without calling Firefox internal data structures. Restructure partial playback to be cleaner.\r\n\r\n@mjzffr , please review.","created_at":"2015-07-29T22:55:50Z","updated_at":"2015-07-31T20:57:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f948fa11897464093b5406932484563395bfe41e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12/commits","review_comments_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12/comments","review_comment_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/12/comments","statuses_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/statuses/d5e8a99487c0874d3922918e5d92a57d8ebe5b9d","head":{"label":"sydvicious:bug1182513-3","ref":"bug1182513-3","sha":"d5e8a99487c0874d3922918e5d92a57d8ebe5b9d","user":{"login":"sydvicious","id":984554,"avatar_url":"https://avatars.githubusercontent.com/u/984554?v=3","gravatar_id":"","url":"https://api.github.com/users/sydvicious","html_url":"https://github.com/sydvicious","followers_url":"https://api.github.com/users/sydvicious/followers","following_url":"https://api.github.com/users/sydvicious/following{/other_user}","gists_url":"https://api.github.com/users/sydvicious/gists{/gist_id}","starred_url":"https://api.github.com/users/sydvicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydvicious/subscriptions","organizations_url":"https://api.github.com/users/sydvicious/orgs","repos_url":"https://api.github.com/users/sydvicious/repos","events_url":"https://api.github.com/users/sydvicious/events{/privacy}","received_events_url":"https://api.github.com/users/sydvicious/received_events","type":"User","site_admin":false},"repo":{"id":33691401,"name":"firefox-media-tests","full_name":"sydvicious/firefox-media-tests","owner":{"login":"sydvicious","id":984554,"avatar_url":"https://avatars.githubusercontent.com/u/984554?v=3","gravatar_id":"","url":"https://api.github.com/users/sydvicious","html_url":"https://github.com/sydvicious","followers_url":"https://api.github.com/users/sydvicious/followers","following_url":"https://api.github.com/users/sydvicious/following{/other_user}","gists_url":"https://api.github.com/users/sydvicious/gists{/gist_id}","starred_url":"https://api.github.com/users/sydvicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydvicious/subscriptions","organizations_url":"https://api.github.com/users/sydvicious/orgs","repos_url":"https://api.github.com/users/sydvicious/repos","events_url":"https://api.github.com/users/sydvicious/events{/privacy}","received_events_url":"https://api.github.com/users/sydvicious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sydvicious/firefox-media-tests","description":"","fork":true,"url":"https://api.github.com/repos/sydvicious/firefox-media-tests","forks_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/forks","keys_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/teams","hooks_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/hooks","issue_events_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/issues/events{/number}","events_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/events","assignees_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/assignees{/user}","branches_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/branches{/branch}","tags_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/tags","blobs_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/languages","stargazers_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/stargazers","contributors_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/contributors","subscribers_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/subscribers","subscription_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/subscription","commits_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/contents/{+path}","compare_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/merges","archive_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/downloads","issues_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/issues{/number}","pulls_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/labels{/name}","releases_url":"https://api.github.com/repos/sydvicious/firefox-media-tests/releases{/id}","created_at":"2015-04-09T20:35:35Z","updated_at":"2015-05-07T22:18:48Z","pushed_at":"2015-07-31T20:53:22Z","git_url":"git://github.com/sydvicious/firefox-media-tests.git","ssh_url":"git@github.com:sydvicious/firefox-media-tests.git","clone_url":"https://github.com/sydvicious/firefox-media-tests.git","svn_url":"https://github.com/sydvicious/firefox-media-tests","homepage":null,"size":354,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjzffr:master","ref":"master","sha":"4116d66fbb559267e60c1e9bfa068170ee968f3a","user":{"login":"mjzffr","id":6024326,"avatar_url":"https://avatars.githubusercontent.com/u/6024326?v=3","gravatar_id":"","url":"https://api.github.com/users/mjzffr","html_url":"https://github.com/mjzffr","followers_url":"https://api.github.com/users/mjzffr/followers","following_url":"https://api.github.com/users/mjzffr/following{/other_user}","gists_url":"https://api.github.com/users/mjzffr/gists{/gist_id}","starred_url":"https://api.github.com/users/mjzffr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjzffr/subscriptions","organizations_url":"https://api.github.com/users/mjzffr/orgs","repos_url":"https://api.github.com/users/mjzffr/repos","events_url":"https://api.github.com/users/mjzffr/events{/privacy}","received_events_url":"https://api.github.com/users/mjzffr/received_events","type":"User","site_admin":false},"repo":{"id":30950784,"name":"firefox-media-tests","full_name":"mjzffr/firefox-media-tests","owner":{"login":"mjzffr","id":6024326,"avatar_url":"https://avatars.githubusercontent.com/u/6024326?v=3","gravatar_id":"","url":"https://api.github.com/users/mjzffr","html_url":"https://github.com/mjzffr","followers_url":"https://api.github.com/users/mjzffr/followers","following_url":"https://api.github.com/users/mjzffr/following{/other_user}","gists_url":"https://api.github.com/users/mjzffr/gists{/gist_id}","starred_url":"https://api.github.com/users/mjzffr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjzffr/subscriptions","organizations_url":"https://api.github.com/users/mjzffr/orgs","repos_url":"https://api.github.com/users/mjzffr/repos","events_url":"https://api.github.com/users/mjzffr/events{/privacy}","received_events_url":"https://api.github.com/users/mjzffr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjzffr/firefox-media-tests","description":"","fork":false,"url":"https://api.github.com/repos/mjzffr/firefox-media-tests","forks_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/forks","keys_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/teams","hooks_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/hooks","issue_events_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/events{/number}","events_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/events","assignees_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/assignees{/user}","branches_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/branches{/branch}","tags_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/tags","blobs_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/languages","stargazers_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/stargazers","contributors_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/contributors","subscribers_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/subscribers","subscription_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/subscription","commits_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/contents/{+path}","compare_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/merges","archive_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/downloads","issues_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues{/number}","pulls_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/labels{/name}","releases_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/releases{/id}","created_at":"2015-02-18T03:40:26Z","updated_at":"2015-06-09T14:42:36Z","pushed_at":"2015-07-31T17:44:16Z","git_url":"git://github.com/mjzffr/firefox-media-tests.git","ssh_url":"git@github.com:mjzffr/firefox-media-tests.git","clone_url":"https://github.com/mjzffr/firefox-media-tests.git","svn_url":"https://github.com/mjzffr/firefox-media-tests","homepage":null,"size":661,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12"},"html":{"href":"https://github.com/mjzffr/firefox-media-tests/pull/12"},"issue":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/12"},"comments":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/mjzffr/firefox-media-tests/statuses/d5e8a99487c0874d3922918e5d92a57d8ebe5b9d"}}}}