{"action":"created","issue":{"url":"https://api.github.com/repos/fabric8io/fabric8/issues/4927","labels_url":"https://api.github.com/repos/fabric8io/fabric8/issues/4927/labels{/name}","comments_url":"https://api.github.com/repos/fabric8io/fabric8/issues/4927/comments","events_url":"https://api.github.com/repos/fabric8io/fabric8/issues/4927/events","html_url":"https://github.com/fabric8io/fabric8/pull/4927","id":110641615,"number":4927,"title":"Harmonize environment variables in run script","user":{"login":"rhuss","id":99080,"avatar_url":"https://avatars.githubusercontent.com/u/99080?v=3","gravatar_id":"","url":"https://api.github.com/users/rhuss","html_url":"https://github.com/rhuss","followers_url":"https://api.github.com/users/rhuss/followers","following_url":"https://api.github.com/users/rhuss/following{/other_user}","gists_url":"https://api.github.com/users/rhuss/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuss/subscriptions","organizations_url":"https://api.github.com/users/rhuss/orgs","repos_url":"https://api.github.com/users/rhuss/repos","events_url":"https://api.github.com/users/rhuss/events{/privacy}","received_events_url":"https://api.github.com/users/rhuss/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-09T11:46:55Z","updated_at":"2015-10-13T06:57:00Z","closed_at":"2015-10-13T06:48:14Z","pull_request":{"url":"https://api.github.com/repos/fabric8io/fabric8/pulls/4927","html_url":"https://github.com/fabric8io/fabric8/pull/4927","diff_url":"https://github.com/fabric8io/fabric8/pull/4927.diff","patch_url":"https://github.com/fabric8io/fabric8/pull/4927.patch"},"body":"As already discussed the syntax of the run scripts should be synchronized. \r\n\r\nThe following was adapted, including fixes:\r\n\r\n* Checked for consistency in naming (i.e. prefix JAVA_)\r\n* Synced with variable names from fabric8/run-java\r\n* Consolidated environment variables influencing java options\r\n* Introduced local var convention to be lower case\r\n* Added missing check for JAVA_CLASSPATH env\r\n* Fixed bug because IFS  not reset\r\n* Introduced a JAVA_DEBUG_PORT option\r\n* Set line ending of .classpath from \\r\\n to \\n\r\n* Update readme.md\r\n\r\nFurther suggestions (not implemented)\r\n\r\n* change \".classpath\" to \"classpath\" to make it more visible (makes it easier to find when troubleshooting)\r\n* change etc/default to run-env.sh, colocated to the run script. Also because of maintainability: it easier to find and correlate when it is colocated.\r\n\r\nWhere I'm a bit unsure is why the separator in the .classpath file was chosen to be `\\r\\n` instead of plain `\\n` ? (should be feasible even on windows is fits better to the target environment which is unix anyway). Or why not simply already prepare the proper classpath (colon separated) when creating ?"},"comment":{"url":"https://api.github.com/repos/fabric8io/fabric8/issues/comments/147624352","html_url":"https://github.com/fabric8io/fabric8/pull/4927#issuecomment-147624352","issue_url":"https://api.github.com/repos/fabric8io/fabric8/issues/4927","id":147624352,"user":{"login":"rhuss","id":99080,"avatar_url":"https://avatars.githubusercontent.com/u/99080?v=3","gravatar_id":"","url":"https://api.github.com/users/rhuss","html_url":"https://github.com/rhuss","followers_url":"https://api.github.com/users/rhuss/followers","following_url":"https://api.github.com/users/rhuss/following{/other_user}","gists_url":"https://api.github.com/users/rhuss/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuss/subscriptions","organizations_url":"https://api.github.com/users/rhuss/orgs","repos_url":"https://api.github.com/users/rhuss/repos","events_url":"https://api.github.com/users/rhuss/events{/privacy}","received_events_url":"https://api.github.com/users/rhuss/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T06:57:00Z","updated_at":"2015-10-13T06:57:00Z","body":"Cool ;-) Just merged in my latest changes. I would be ready for a next release ;-)"}}