{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/40620490","id":40620490,"diff_hunk":"@@ -0,0 +1,8 @@\n+\n+<% unless options.api? -%>\n+//= link_tree ../images\n+<% end -%>\n+<% unless options.skip_javascript -%>\n+//= link_directory ../javascripts .js","path":"railties/lib/rails/generators/rails/app/templates/app/assets/config/manifest.js.tt","position":6,"original_position":6,"commit_id":"5fd64f853c145cf6648ca010bb44b7cb8fc5e6f5","original_commit_id":"5fd64f853c145cf6648ca010bb44b7cb8fc5e6f5","user":{"login":"jeremy","id":199,"avatar_url":"https://avatars.githubusercontent.com/u/199?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"body":"I think it is, because:\r\n1. Apps with multiple asset bundles are typically set up this way.\r\n2. Linking assets of the proper type (e.g. `.js` and `.css` not `.coffee`/`.es6` and `.scss`) with `link_directory` and `_tree` is not obvious to anyone. Defaulting to show the right way is instructive.\r\n3. Precompiling multiple bundles and even all files will become more common as people migrate to HTTP/2.\r\n3. Precompiling additional assets is usually cheap since the assets are already cached due to a `require_tree .` reference in `application.js/css`.","created_at":"2015-09-28T23:50:48Z","updated_at":"2015-09-28T23:50:48Z","html_url":"https://github.com/rails/rails/pull/21794#discussion_r40620490","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/21794","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/40620490"},"html":{"href":"https://github.com/rails/rails/pull/21794#discussion_r40620490"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/21794"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/21794","id":46120473,"html_url":"https://github.com/rails/rails/pull/21794","diff_url":"https://github.com/rails/rails/pull/21794.diff","patch_url":"https://github.com/rails/rails/pull/21794.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/21794","number":21794,"state":"open","locked":false,"title":"Eliminate overlapping `app/assets` load path","user":{"login":"jeremy","id":199,"avatar_url":"https://avatars.githubusercontent.com/u/199?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"body":"* Move `app/assets/manifest.js` to `app/assets/config/manifest.js`. Avoid the suggestion that you can/should deep-link `stylesheets/foo`.\r\n* Pull in all toplevel stylesheets and JavaScripts, not just `application.js` and `.css`. Demonstrate how to use `link_directory` with a specified `.js`/`.css` type.\r\n* Fix `RAILS_ENV` handling in assets tests.\r\n* Shush warnings spam from third-party libs that distract from tests.\r\n* Remove the `app/assets` toplevel path in https://github.com/rails/sprockets-rails/pull/277","created_at":"2015-09-28T04:57:25Z","updated_at":"2015-09-28T23:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d304b8031eb27a06c071c99807b21da7140d0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/21794/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/21794/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/21794/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/5fd64f853c145cf6648ca010bb44b7cb8fc5e6f5","head":{"label":"jeremy:sprockets/move-asset-manifest-from-toplevel-to-config-subdir","ref":"sprockets/move-asset-manifest-from-toplevel-to-config-subdir","sha":"5fd64f853c145cf6648ca010bb44b7cb8fc5e6f5","user":{"login":"jeremy","id":199,"avatar_url":"https://avatars.githubusercontent.com/u/199?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"repo":{"id":9247,"name":"rails","full_name":"jeremy/rails","owner":{"login":"jeremy","id":199,"avatar_url":"https://avatars.githubusercontent.com/u/199?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremy/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/jeremy/rails","forks_url":"https://api.github.com/repos/jeremy/rails/forks","keys_url":"https://api.github.com/repos/jeremy/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremy/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremy/rails/teams","hooks_url":"https://api.github.com/repos/jeremy/rails/hooks","issue_events_url":"https://api.github.com/repos/jeremy/rails/issues/events{/number}","events_url":"https://api.github.com/repos/jeremy/rails/events","assignees_url":"https://api.github.com/repos/jeremy/rails/assignees{/user}","branches_url":"https://api.github.com/repos/jeremy/rails/branches{/branch}","tags_url":"https://api.github.com/repos/jeremy/rails/tags","blobs_url":"https://api.github.com/repos/jeremy/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremy/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremy/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremy/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremy/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremy/rails/languages","stargazers_url":"https://api.github.com/repos/jeremy/rails/stargazers","contributors_url":"https://api.github.com/repos/jeremy/rails/contributors","subscribers_url":"https://api.github.com/repos/jeremy/rails/subscribers","subscription_url":"https://api.github.com/repos/jeremy/rails/subscription","commits_url":"https://api.github.com/repos/jeremy/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremy/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremy/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremy/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremy/rails/contents/{+path}","compare_url":"https://api.github.com/repos/jeremy/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremy/rails/merges","archive_url":"https://api.github.com/repos/jeremy/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremy/rails/downloads","issues_url":"https://api.github.com/repos/jeremy/rails/issues{/number}","pulls_url":"https://api.github.com/repos/jeremy/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremy/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremy/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremy/rails/labels{/name}","releases_url":"https://api.github.com/repos/jeremy/rails/releases{/id}","created_at":"2008-04-12T22:30:38Z","updated_at":"2014-09-05T20:34:20Z","pushed_at":"2015-09-28T04:56:45Z","git_url":"git://github.com/jeremy/rails.git","ssh_url":"git@github.com:jeremy/rails.git","clone_url":"https://github.com/jeremy/rails.git","svn_url":"https://github.com/jeremy/rails","homepage":"http://rubyonrails.org","size":113657,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"20fd3c5255b03f5441bed44b189c0cfa4425d747","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-09-28T23:49:36Z","pushed_at":"2015-09-28T22:34:02Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":463782,"stargazers_count":27844,"watchers_count":27844,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11199,"mirror_url":null,"open_issues_count":897,"forks":11199,"open_issues":897,"watchers":27844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/21794"},"html":{"href":"https://github.com/rails/rails/pull/21794"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/21794"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/21794/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/21794/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/21794/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/5fd64f853c145cf6648ca010bb44b7cb8fc5e6f5"}}}}