{"action":"created","issue":{"url":"https://api.github.com/repos/musicbrainz/picard/issues/433","labels_url":"https://api.github.com/repos/musicbrainz/picard/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/musicbrainz/picard/issues/433/comments","events_url":"https://api.github.com/repos/musicbrainz/picard/issues/433/events","html_url":"https://github.com/musicbrainz/picard/pull/433","id":111887400,"number":433,"title":"Make Picard tags more comprehensive.","user":{"login":"Sophist-UK","id":3001893,"avatar_url":"https://avatars.githubusercontent.com/u/3001893?v=3","gravatar_id":"","url":"https://api.github.com/users/Sophist-UK","html_url":"https://github.com/Sophist-UK","followers_url":"https://api.github.com/users/Sophist-UK/followers","following_url":"https://api.github.com/users/Sophist-UK/following{/other_user}","gists_url":"https://api.github.com/users/Sophist-UK/gists{/gist_id}","starred_url":"https://api.github.com/users/Sophist-UK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sophist-UK/subscriptions","organizations_url":"https://api.github.com/users/Sophist-UK/orgs","repos_url":"https://api.github.com/users/Sophist-UK/repos","events_url":"https://api.github.com/users/Sophist-UK/events{/privacy}","received_events_url":"https://api.github.com/users/Sophist-UK/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/musicbrainz/picard/labels/Needs%20more%20work","name":"Needs more work","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":35,"created_at":"2015-10-16T18:37:14Z","updated_at":"2015-11-21T12:00:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/musicbrainz/picard/pulls/433","html_url":"https://github.com/musicbrainz/picard/pull/433","diff_url":"https://github.com/musicbrainz/picard/pull/433.diff","patch_url":"https://github.com/musicbrainz/picard/pull/433.patch"},"body":"This PR will eventually provide a more comprehensive mapping of Picard tags onto tags supported by various file formats. My intention is to develop this in steps and share code at each step for review comments.\r\n\r\nStep 1: Improve compatibility with Jaikoz based on Philip Wolfer's spreadsheet (see first commit) and add support for as many ID3v2.4 tags that can be easily included. Data will be populated from the standard MB responses where data is included, otherwise they will be left to plugins to populate from e.g. AcousticBrainz, other MB calls for artist details etc.\r\n\r\n> **Step 1 is now complete**\r\n\r\nStep 2: Add test support for Step 1.\r\n\r\nStep 3: Bug fixing."},"comment":{"url":"https://api.github.com/repos/musicbrainz/picard/issues/comments/158634136","html_url":"https://github.com/musicbrainz/picard/pull/433#issuecomment-158634136","issue_url":"https://api.github.com/repos/musicbrainz/picard/issues/433","id":158634136,"user":{"login":"Sophist-UK","id":3001893,"avatar_url":"https://avatars.githubusercontent.com/u/3001893?v=3","gravatar_id":"","url":"https://api.github.com/users/Sophist-UK","html_url":"https://github.com/Sophist-UK","followers_url":"https://api.github.com/users/Sophist-UK/followers","following_url":"https://api.github.com/users/Sophist-UK/following{/other_user}","gists_url":"https://api.github.com/users/Sophist-UK/gists{/gist_id}","starred_url":"https://api.github.com/users/Sophist-UK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sophist-UK/subscriptions","organizations_url":"https://api.github.com/users/Sophist-UK/orgs","repos_url":"https://api.github.com/users/Sophist-UK/repos","events_url":"https://api.github.com/users/Sophist-UK/events{/privacy}","received_events_url":"https://api.github.com/users/Sophist-UK/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T12:00:50Z","updated_at":"2015-11-21T12:00:50Z","body":"I agree - this is a huge PR, and difficult to review.\r\n\r\nI also accept that there are some tweaks in here which could be separate PRs, but moving these out will not significantly improve its reviewability \r\n\r\nThere are two problems with breaking this into separate PRs:\r\n\r\na. There are lots of dependent changes - so its difficult to break it into independent PRs.\r\n\r\nb. The time required to get approval for one PR before submitting the next PR will make this too lengthy a process.\r\n\r\nI'm afraid that sometimes code changes are a rewrite rather than a simple modification, and that is the case for the format files.\r\n\r\nI'm afraid that this is just going  to be one of those PRs where you need to go with extensive testing against a real-life base of music to see if there are issues."}}