{"action":"created","comment":{"url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments/23710304","id":23710304,"diff_hunk":"@@ -611,4 +611,4 @@\n         makeApi(sinon);\n     }\n \n-})(typeof self !== \"undefined\" ? self : this);\n+})(typeof global !== 'undefined' ? global : this);","path":"lib/sinon/util/fake_xml_http_request.js","position":5,"original_position":5,"commit_id":"cb7d707c74be1f599a4bb83d4a60748d8eda4d80","original_commit_id":"cb7d707c74be1f599a4bb83d4a60748d8eda4d80","user":{"login":"fearphage","id":23887,"avatar_url":"https://avatars.githubusercontent.com/u/23887?v=3","gravatar_id":"","url":"https://api.github.com/users/fearphage","html_url":"https://github.com/fearphage","followers_url":"https://api.github.com/users/fearphage/followers","following_url":"https://api.github.com/users/fearphage/following{/other_user}","gists_url":"https://api.github.com/users/fearphage/gists{/gist_id}","starred_url":"https://api.github.com/users/fearphage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearphage/subscriptions","organizations_url":"https://api.github.com/users/fearphage/orgs","repos_url":"https://api.github.com/users/fearphage/repos","events_url":"https://api.github.com/users/fearphage/events{/privacy}","received_events_url":"https://api.github.com/users/fearphage/received_events","type":"User","site_admin":false},"body":"@cjohansen The build is failing on master because there are single quotes here instead of the jscs required double quotes. ","created_at":"2015-01-28T18:35:58Z","updated_at":"2015-01-28T18:35:58Z","html_url":"https://github.com/cjohansen/Sinon.JS/pull/661#discussion_r23710304","pull_request_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661","_links":{"self":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments/23710304"},"html":{"href":"https://github.com/cjohansen/Sinon.JS/pull/661#discussion_r23710304"},"pull_request":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661","id":27988975,"html_url":"https://github.com/cjohansen/Sinon.JS/pull/661","diff_url":"https://github.com/cjohansen/Sinon.JS/pull/661.diff","patch_url":"https://github.com/cjohansen/Sinon.JS/pull/661.patch","issue_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/661","number":661,"state":"closed","locked":false,"title":"Fix fakeXHR requests in Node.","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"body":"Sinon was unable to detect XHR support when loaded in certain\r\nNode environments. This was a regression introduced in #515\r\nto resolve #508 and #511.\r\n\r\nResolves #657 \r\n\r\n===\r\n\r\nReimplements #659. This one actually seems to work. Refer to that PR for a description on how to test it.","created_at":"2015-01-25T07:46:24Z","updated_at":"2015-01-28T18:35:58Z","closed_at":"2015-01-26T21:15:23Z","merged_at":"2015-01-26T21:15:23Z","merge_commit_sha":"e13f9bd6b69592b2f1843d1b8dbd91a67b6db4ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661/commits","review_comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661/comments","review_comment_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/661/comments","statuses_url":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/cb7d707c74be1f599a4bb83d4a60748d8eda4d80","head":{"label":"jmeas:fix-node","ref":"fix-node","sha":"cb7d707c74be1f599a4bb83d4a60748d8eda4d80","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"repo":{"id":29805133,"name":"Sinon.JS","full_name":"jmeas/Sinon.JS","owner":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmeas/Sinon.JS","description":"Test spies, stubs and mocks for JavaScript.","fork":true,"url":"https://api.github.com/repos/jmeas/Sinon.JS","forks_url":"https://api.github.com/repos/jmeas/Sinon.JS/forks","keys_url":"https://api.github.com/repos/jmeas/Sinon.JS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmeas/Sinon.JS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmeas/Sinon.JS/teams","hooks_url":"https://api.github.com/repos/jmeas/Sinon.JS/hooks","issue_events_url":"https://api.github.com/repos/jmeas/Sinon.JS/issues/events{/number}","events_url":"https://api.github.com/repos/jmeas/Sinon.JS/events","assignees_url":"https://api.github.com/repos/jmeas/Sinon.JS/assignees{/user}","branches_url":"https://api.github.com/repos/jmeas/Sinon.JS/branches{/branch}","tags_url":"https://api.github.com/repos/jmeas/Sinon.JS/tags","blobs_url":"https://api.github.com/repos/jmeas/Sinon.JS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmeas/Sinon.JS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmeas/Sinon.JS/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmeas/Sinon.JS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmeas/Sinon.JS/statuses/{sha}","languages_url":"https://api.github.com/repos/jmeas/Sinon.JS/languages","stargazers_url":"https://api.github.com/repos/jmeas/Sinon.JS/stargazers","contributors_url":"https://api.github.com/repos/jmeas/Sinon.JS/contributors","subscribers_url":"https://api.github.com/repos/jmeas/Sinon.JS/subscribers","subscription_url":"https://api.github.com/repos/jmeas/Sinon.JS/subscription","commits_url":"https://api.github.com/repos/jmeas/Sinon.JS/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmeas/Sinon.JS/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmeas/Sinon.JS/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmeas/Sinon.JS/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmeas/Sinon.JS/contents/{+path}","compare_url":"https://api.github.com/repos/jmeas/Sinon.JS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmeas/Sinon.JS/merges","archive_url":"https://api.github.com/repos/jmeas/Sinon.JS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmeas/Sinon.JS/downloads","issues_url":"https://api.github.com/repos/jmeas/Sinon.JS/issues{/number}","pulls_url":"https://api.github.com/repos/jmeas/Sinon.JS/pulls{/number}","milestones_url":"https://api.github.com/repos/jmeas/Sinon.JS/milestones{/number}","notifications_url":"https://api.github.com/repos/jmeas/Sinon.JS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmeas/Sinon.JS/labels{/name}","releases_url":"https://api.github.com/repos/jmeas/Sinon.JS/releases{/id}","created_at":"2015-01-25T06:20:04Z","updated_at":"2015-01-25T06:20:05Z","pushed_at":"2015-01-25T07:32:26Z","git_url":"git://github.com/jmeas/Sinon.JS.git","ssh_url":"git@github.com:jmeas/Sinon.JS.git","clone_url":"https://github.com/jmeas/Sinon.JS.git","svn_url":"https://github.com/jmeas/Sinon.JS","homepage":"http://sinonjs.org/","size":2145,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cjohansen:master","ref":"master","sha":"b7abdcae4c09a2ad515447a1b9666476b49193eb","user":{"login":"cjohansen","id":32871,"avatar_url":"https://avatars.githubusercontent.com/u/32871?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohansen","html_url":"https://github.com/cjohansen","followers_url":"https://api.github.com/users/cjohansen/followers","following_url":"https://api.github.com/users/cjohansen/following{/other_user}","gists_url":"https://api.github.com/users/cjohansen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohansen/subscriptions","organizations_url":"https://api.github.com/users/cjohansen/orgs","repos_url":"https://api.github.com/users/cjohansen/repos","events_url":"https://api.github.com/users/cjohansen/events{/privacy}","received_events_url":"https://api.github.com/users/cjohansen/received_events","type":"User","site_admin":false},"repo":{"id":747698,"name":"Sinon.JS","full_name":"cjohansen/Sinon.JS","owner":{"login":"cjohansen","id":32871,"avatar_url":"https://avatars.githubusercontent.com/u/32871?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohansen","html_url":"https://github.com/cjohansen","followers_url":"https://api.github.com/users/cjohansen/followers","following_url":"https://api.github.com/users/cjohansen/following{/other_user}","gists_url":"https://api.github.com/users/cjohansen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohansen/subscriptions","organizations_url":"https://api.github.com/users/cjohansen/orgs","repos_url":"https://api.github.com/users/cjohansen/repos","events_url":"https://api.github.com/users/cjohansen/events{/privacy}","received_events_url":"https://api.github.com/users/cjohansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjohansen/Sinon.JS","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/cjohansen/Sinon.JS","forks_url":"https://api.github.com/repos/cjohansen/Sinon.JS/forks","keys_url":"https://api.github.com/repos/cjohansen/Sinon.JS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjohansen/Sinon.JS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjohansen/Sinon.JS/teams","hooks_url":"https://api.github.com/repos/cjohansen/Sinon.JS/hooks","issue_events_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/events{/number}","events_url":"https://api.github.com/repos/cjohansen/Sinon.JS/events","assignees_url":"https://api.github.com/repos/cjohansen/Sinon.JS/assignees{/user}","branches_url":"https://api.github.com/repos/cjohansen/Sinon.JS/branches{/branch}","tags_url":"https://api.github.com/repos/cjohansen/Sinon.JS/tags","blobs_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/{sha}","languages_url":"https://api.github.com/repos/cjohansen/Sinon.JS/languages","stargazers_url":"https://api.github.com/repos/cjohansen/Sinon.JS/stargazers","contributors_url":"https://api.github.com/repos/cjohansen/Sinon.JS/contributors","subscribers_url":"https://api.github.com/repos/cjohansen/Sinon.JS/subscribers","subscription_url":"https://api.github.com/repos/cjohansen/Sinon.JS/subscription","commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/comments/{number}","contents_url":"https://api.github.com/repos/cjohansen/Sinon.JS/contents/{+path}","compare_url":"https://api.github.com/repos/cjohansen/Sinon.JS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjohansen/Sinon.JS/merges","archive_url":"https://api.github.com/repos/cjohansen/Sinon.JS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjohansen/Sinon.JS/downloads","issues_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues{/number}","pulls_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls{/number}","milestones_url":"https://api.github.com/repos/cjohansen/Sinon.JS/milestones{/number}","notifications_url":"https://api.github.com/repos/cjohansen/Sinon.JS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjohansen/Sinon.JS/labels{/name}","releases_url":"https://api.github.com/repos/cjohansen/Sinon.JS/releases{/id}","created_at":"2010-06-29T21:15:32Z","updated_at":"2015-01-28T17:56:16Z","pushed_at":"2015-01-26T21:35:00Z","git_url":"git://github.com/cjohansen/Sinon.JS.git","ssh_url":"git@github.com:cjohansen/Sinon.JS.git","clone_url":"https://github.com/cjohansen/Sinon.JS.git","svn_url":"https://github.com/cjohansen/Sinon.JS","homepage":"http://sinonjs.org/","size":3648,"stargazers_count":1820,"watchers_count":1820,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":86,"forks":300,"open_issues":86,"watchers":1820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661"},"html":{"href":"https://github.com/cjohansen/Sinon.JS/pull/661"},"issue":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/661"},"comments":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/cb7d707c74be1f599a4bb83d4a60748d8eda4d80"}}}}