{"action":"opened","number":24143,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/24143","id":32738668,"html_url":"https://github.com/rust-lang/rust/pull/24143","diff_url":"https://github.com/rust-lang/rust/pull/24143.diff","patch_url":"https://github.com/rust-lang/rust/pull/24143.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/24143","number":24143,"state":"open","locked":false,"title":"Improve extended errors (rustc --explain).","user":{"login":"michaelsproul","id":4452260,"avatar_url":"https://avatars.githubusercontent.com/u/4452260?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelsproul","html_url":"https://github.com/michaelsproul","followers_url":"https://api.github.com/users/michaelsproul/followers","following_url":"https://api.github.com/users/michaelsproul/following{/other_user}","gists_url":"https://api.github.com/users/michaelsproul/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelsproul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelsproul/subscriptions","organizations_url":"https://api.github.com/users/michaelsproul/orgs","repos_url":"https://api.github.com/users/michaelsproul/repos","events_url":"https://api.github.com/users/michaelsproul/events{/privacy}","received_events_url":"https://api.github.com/users/michaelsproul/received_events","type":"User","site_admin":false},"body":"I've taken another look at extended errors - fixing up the printing and adding a few more for match expressions.\r\n\r\nWith regards to printing, the previous behaviour was to just print the error message string directly, despite it containing indentation which caused it to overflow the standard terminal width of 80 columns (try `rustc --explain E0004`). The first approach I considered was to strip the leading whitespace from each line and lay out the text dynamically, inserting spaces in between. This approach became quite messy when taking multi-paragraph errors into account (and seemed overkill). The approach I settled on removes the indentation in the string itself and begins each message with a newline that is stripped before printing.\r\n\r\nI feel like complete extended errors would be nice to have for 1.0.0 and I'm happy to spearhead an effort to get them written. Brian got me onto writing them at an SF meetup and I think it shouldn't be too hard to get the remaining 80 or so written with the help of people who don't really work on compiler innards.","created_at":"2015-04-07T07:13:04Z","updated_at":"2015-04-07T07:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/24143/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/24143/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/24143/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ad2e506ca54c164306636014caeda4bb4669cbf2","head":{"label":"michaelsproul:extended-errors","ref":"extended-errors","sha":"ad2e506ca54c164306636014caeda4bb4669cbf2","user":{"login":"michaelsproul","id":4452260,"avatar_url":"https://avatars.githubusercontent.com/u/4452260?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelsproul","html_url":"https://github.com/michaelsproul","followers_url":"https://api.github.com/users/michaelsproul/followers","following_url":"https://api.github.com/users/michaelsproul/following{/other_user}","gists_url":"https://api.github.com/users/michaelsproul/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelsproul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelsproul/subscriptions","organizations_url":"https://api.github.com/users/michaelsproul/orgs","repos_url":"https://api.github.com/users/michaelsproul/repos","events_url":"https://api.github.com/users/michaelsproul/events{/privacy}","received_events_url":"https://api.github.com/users/michaelsproul/received_events","type":"User","site_admin":false},"repo":{"id":22588239,"name":"rust","full_name":"michaelsproul/rust","owner":{"login":"michaelsproul","id":4452260,"avatar_url":"https://avatars.githubusercontent.com/u/4452260?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelsproul","html_url":"https://github.com/michaelsproul","followers_url":"https://api.github.com/users/michaelsproul/followers","following_url":"https://api.github.com/users/michaelsproul/following{/other_user}","gists_url":"https://api.github.com/users/michaelsproul/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelsproul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelsproul/subscriptions","organizations_url":"https://api.github.com/users/michaelsproul/orgs","repos_url":"https://api.github.com/users/michaelsproul/repos","events_url":"https://api.github.com/users/michaelsproul/events{/privacy}","received_events_url":"https://api.github.com/users/michaelsproul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelsproul/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/michaelsproul/rust","forks_url":"https://api.github.com/repos/michaelsproul/rust/forks","keys_url":"https://api.github.com/repos/michaelsproul/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelsproul/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelsproul/rust/teams","hooks_url":"https://api.github.com/repos/michaelsproul/rust/hooks","issue_events_url":"https://api.github.com/repos/michaelsproul/rust/issues/events{/number}","events_url":"https://api.github.com/repos/michaelsproul/rust/events","assignees_url":"https://api.github.com/repos/michaelsproul/rust/assignees{/user}","branches_url":"https://api.github.com/repos/michaelsproul/rust/branches{/branch}","tags_url":"https://api.github.com/repos/michaelsproul/rust/tags","blobs_url":"https://api.github.com/repos/michaelsproul/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelsproul/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelsproul/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelsproul/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelsproul/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelsproul/rust/languages","stargazers_url":"https://api.github.com/repos/michaelsproul/rust/stargazers","contributors_url":"https://api.github.com/repos/michaelsproul/rust/contributors","subscribers_url":"https://api.github.com/repos/michaelsproul/rust/subscribers","subscription_url":"https://api.github.com/repos/michaelsproul/rust/subscription","commits_url":"https://api.github.com/repos/michaelsproul/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelsproul/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelsproul/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelsproul/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelsproul/rust/contents/{+path}","compare_url":"https://api.github.com/repos/michaelsproul/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelsproul/rust/merges","archive_url":"https://api.github.com/repos/michaelsproul/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelsproul/rust/downloads","issues_url":"https://api.github.com/repos/michaelsproul/rust/issues{/number}","pulls_url":"https://api.github.com/repos/michaelsproul/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelsproul/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelsproul/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelsproul/rust/labels{/name}","releases_url":"https://api.github.com/repos/michaelsproul/rust/releases{/id}","created_at":"2014-08-04T01:29:27Z","updated_at":"2015-01-16T00:38:00Z","pushed_at":"2015-04-07T07:12:14Z","git_url":"git://github.com/michaelsproul/rust.git","ssh_url":"git@github.com:michaelsproul/rust.git","clone_url":"https://github.com/michaelsproul/rust.git","svn_url":"https://github.com/michaelsproul/rust","homepage":"http://www.rust-lang.org","size":266308,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"b2e65ee6e4e1523b1d4c56ea0ec430e28946f2f4","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-04-07T07:01:36Z","pushed_at":"2015-04-07T07:00:15Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":539115,"stargazers_count":10151,"watchers_count":10151,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1952,"mirror_url":null,"open_issues_count":2060,"forks":1952,"open_issues":2060,"watchers":10151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24143"},"html":{"href":"https://github.com/rust-lang/rust/pull/24143"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24143"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24143/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24143/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24143/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ad2e506ca54c164306636014caeda4bb4669cbf2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":115,"deletions":32,"changed_files":2}}