{"action":"opened","number":787,"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/787","id":46250149,"html_url":"https://github.com/mozilla/olympia/pull/787","diff_url":"https://github.com/mozilla/olympia/pull/787.diff","patch_url":"https://github.com/mozilla/olympia/pull/787.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/787","number":787,"state":"open","locked":false,"title":"Move npm installation to Dockerfile","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"* Move the npm installation to the dockerfile (this means npm install is run by the build process on the hub)\r\n* Expose the various commands stylus/less etc via env vars and update the settings to use those.\r\n\r\nNote: This uses the same approach that marketplace uses. This wouldn't work well for any npm files that need to be found in a node_modules dir. But we're not running any js that should need to do that AFAIK.\r\n\r\nTo test this you'll need to do the following:\r\n\r\n* CD into your olympia checkout\r\n* Nuke node_modules in your tree (just to ensure there's no deps being used from there)\r\n* Build the image `docker build -t addons/olympia .`\r\n* Run it with `docker-compose up -d`","created_at":"2015-09-29T08:44:22Z","updated_at":"2015-09-29T08:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42f7bb0eee6bb9fd520cb52d1252bfc447e94b29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/787/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/787/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/787/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/5104fe4d470e841d6bcd4d03dda9ba93eb0539b5","head":{"label":"muffinresearch:move-npm-to-dockerfile","ref":"move-npm-to-dockerfile","sha":"5104fe4d470e841d6bcd4d03dda9ba93eb0539b5","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"repo":{"id":42522849,"name":"olympia","full_name":"muffinresearch/olympia","owner":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffinresearch/olympia","description":"addons.mozilla.org, reloaded.","fork":true,"url":"https://api.github.com/repos/muffinresearch/olympia","forks_url":"https://api.github.com/repos/muffinresearch/olympia/forks","keys_url":"https://api.github.com/repos/muffinresearch/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffinresearch/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffinresearch/olympia/teams","hooks_url":"https://api.github.com/repos/muffinresearch/olympia/hooks","issue_events_url":"https://api.github.com/repos/muffinresearch/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/muffinresearch/olympia/events","assignees_url":"https://api.github.com/repos/muffinresearch/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/muffinresearch/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/muffinresearch/olympia/tags","blobs_url":"https://api.github.com/repos/muffinresearch/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffinresearch/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffinresearch/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffinresearch/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffinresearch/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/muffinresearch/olympia/languages","stargazers_url":"https://api.github.com/repos/muffinresearch/olympia/stargazers","contributors_url":"https://api.github.com/repos/muffinresearch/olympia/contributors","subscribers_url":"https://api.github.com/repos/muffinresearch/olympia/subscribers","subscription_url":"https://api.github.com/repos/muffinresearch/olympia/subscription","commits_url":"https://api.github.com/repos/muffinresearch/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffinresearch/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffinresearch/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffinresearch/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/muffinresearch/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/muffinresearch/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffinresearch/olympia/merges","archive_url":"https://api.github.com/repos/muffinresearch/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffinresearch/olympia/downloads","issues_url":"https://api.github.com/repos/muffinresearch/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/muffinresearch/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/muffinresearch/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/muffinresearch/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffinresearch/olympia/labels{/name}","releases_url":"https://api.github.com/repos/muffinresearch/olympia/releases{/id}","created_at":"2015-09-15T13:59:59Z","updated_at":"2015-09-15T14:00:05Z","pushed_at":"2015-09-29T08:39:53Z","git_url":"git://github.com/muffinresearch/olympia.git","ssh_url":"git@github.com:muffinresearch/olympia.git","clone_url":"https://github.com/muffinresearch/olympia.git","svn_url":"https://github.com/muffinresearch/olympia","homepage":"https://addons.mozilla.org/","size":414447,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"48911a1ed3f04b81033206f8b040c573573a859f","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-09-18T08:59:39Z","pushed_at":"2015-09-29T08:44:22Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":476146,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":20,"forks":111,"open_issues":20,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/787"},"html":{"href":"https://github.com/mozilla/olympia/pull/787"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/787"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/5104fe4d470e841d6bcd4d03dda9ba93eb0539b5"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":13,"changed_files":4}}