{"action":"closed","number":617,"pull_request":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617","id":32638069,"html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617","diff_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617.diff","patch_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617.patch","issue_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617","number":617,"state":"closed","locked":false,"title":"Some more work on the material scripts","user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"body":"As discussed in #612 and #615, I've tried to correct some mistakes introduced previously due to a wrong understanding of what the arguments mean for the ambient, diffuse, specular and emissive lighting parameters.\r\n\r\nI enforced the default values for those that were not already custom, and used a minimal shininess value of 2.0 for the specular parameter, since Ogre advises against uses values ranging from 0 to 1.\r\n\r\nSome values were also rounded to decimals with one (or two in some cases) significant number, and I tried to fix the indentation (with a \"tabulation\" of 4 spaces).","created_at":"2015-04-04T19:07:25Z","updated_at":"2015-04-04T22:43:47Z","closed_at":"2015-04-04T22:43:47Z","merged_at":"2015-04-04T22:43:47Z","merge_commit_sha":"9869c562b0f629a313d560a8462f61a6621277ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617/commits","review_comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617/comments","review_comment_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617/comments","statuses_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/statuses/1a2c4c3cdf79d9b7314985f8568cc3c352a554c9","head":{"label":"akien-mga:development","ref":"development","sha":"1a2c4c3cdf79d9b7314985f8568cc3c352a554c9","user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"repo":{"id":22781778,"name":"OpenDungeons","full_name":"akien-mga/OpenDungeons","owner":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akien-mga/OpenDungeons","description":"Open source game inspired by Dungeon Keeper - Dark, damp and dangerous...","fork":true,"url":"https://api.github.com/repos/akien-mga/OpenDungeons","forks_url":"https://api.github.com/repos/akien-mga/OpenDungeons/forks","keys_url":"https://api.github.com/repos/akien-mga/OpenDungeons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akien-mga/OpenDungeons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akien-mga/OpenDungeons/teams","hooks_url":"https://api.github.com/repos/akien-mga/OpenDungeons/hooks","issue_events_url":"https://api.github.com/repos/akien-mga/OpenDungeons/issues/events{/number}","events_url":"https://api.github.com/repos/akien-mga/OpenDungeons/events","assignees_url":"https://api.github.com/repos/akien-mga/OpenDungeons/assignees{/user}","branches_url":"https://api.github.com/repos/akien-mga/OpenDungeons/branches{/branch}","tags_url":"https://api.github.com/repos/akien-mga/OpenDungeons/tags","blobs_url":"https://api.github.com/repos/akien-mga/OpenDungeons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akien-mga/OpenDungeons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akien-mga/OpenDungeons/git/refs{/sha}","trees_url":"https://api.github.com/repos/akien-mga/OpenDungeons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akien-mga/OpenDungeons/statuses/{sha}","languages_url":"https://api.github.com/repos/akien-mga/OpenDungeons/languages","stargazers_url":"https://api.github.com/repos/akien-mga/OpenDungeons/stargazers","contributors_url":"https://api.github.com/repos/akien-mga/OpenDungeons/contributors","subscribers_url":"https://api.github.com/repos/akien-mga/OpenDungeons/subscribers","subscription_url":"https://api.github.com/repos/akien-mga/OpenDungeons/subscription","commits_url":"https://api.github.com/repos/akien-mga/OpenDungeons/commits{/sha}","git_commits_url":"https://api.github.com/repos/akien-mga/OpenDungeons/git/commits{/sha}","comments_url":"https://api.github.com/repos/akien-mga/OpenDungeons/comments{/number}","issue_comment_url":"https://api.github.com/repos/akien-mga/OpenDungeons/issues/comments{/number}","contents_url":"https://api.github.com/repos/akien-mga/OpenDungeons/contents/{+path}","compare_url":"https://api.github.com/repos/akien-mga/OpenDungeons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akien-mga/OpenDungeons/merges","archive_url":"https://api.github.com/repos/akien-mga/OpenDungeons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akien-mga/OpenDungeons/downloads","issues_url":"https://api.github.com/repos/akien-mga/OpenDungeons/issues{/number}","pulls_url":"https://api.github.com/repos/akien-mga/OpenDungeons/pulls{/number}","milestones_url":"https://api.github.com/repos/akien-mga/OpenDungeons/milestones{/number}","notifications_url":"https://api.github.com/repos/akien-mga/OpenDungeons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akien-mga/OpenDungeons/labels{/name}","releases_url":"https://api.github.com/repos/akien-mga/OpenDungeons/releases{/id}","created_at":"2014-08-09T07:51:08Z","updated_at":"2015-04-04T20:58:11Z","pushed_at":"2015-04-04T20:58:11Z","git_url":"git://github.com/akien-mga/OpenDungeons.git","ssh_url":"git@github.com:akien-mga/OpenDungeons.git","clone_url":"https://github.com/akien-mga/OpenDungeons.git","svn_url":"https://github.com/akien-mga/OpenDungeons","homepage":"https://opendungeons.github.io","size":207391,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"OpenDungeons:development","ref":"development","sha":"799378eb4a477ac7f28b8983377616e89412928e","user":{"login":"OpenDungeons","id":8298376,"avatar_url":"https://avatars.githubusercontent.com/u/8298376?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenDungeons","html_url":"https://github.com/OpenDungeons","followers_url":"https://api.github.com/users/OpenDungeons/followers","following_url":"https://api.github.com/users/OpenDungeons/following{/other_user}","gists_url":"https://api.github.com/users/OpenDungeons/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenDungeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenDungeons/subscriptions","organizations_url":"https://api.github.com/users/OpenDungeons/orgs","repos_url":"https://api.github.com/users/OpenDungeons/repos","events_url":"https://api.github.com/users/OpenDungeons/events{/privacy}","received_events_url":"https://api.github.com/users/OpenDungeons/received_events","type":"Organization","site_admin":false},"repo":{"id":22376157,"name":"OpenDungeons","full_name":"OpenDungeons/OpenDungeons","owner":{"login":"OpenDungeons","id":8298376,"avatar_url":"https://avatars.githubusercontent.com/u/8298376?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenDungeons","html_url":"https://github.com/OpenDungeons","followers_url":"https://api.github.com/users/OpenDungeons/followers","following_url":"https://api.github.com/users/OpenDungeons/following{/other_user}","gists_url":"https://api.github.com/users/OpenDungeons/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenDungeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenDungeons/subscriptions","organizations_url":"https://api.github.com/users/OpenDungeons/orgs","repos_url":"https://api.github.com/users/OpenDungeons/repos","events_url":"https://api.github.com/users/OpenDungeons/events{/privacy}","received_events_url":"https://api.github.com/users/OpenDungeons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenDungeons/OpenDungeons","description":"Open source game inspired by Dungeon Keeper - Dark, damp and dangerous...","fork":false,"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons","forks_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/forks","keys_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/teams","hooks_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/hooks","issue_events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/events{/number}","events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/events","assignees_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/assignees{/user}","branches_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/branches{/branch}","tags_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/tags","blobs_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/languages","stargazers_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/stargazers","contributors_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/contributors","subscribers_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/subscribers","subscription_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/subscription","commits_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/contents/{+path}","compare_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/merges","archive_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/downloads","issues_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues{/number}","pulls_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/labels{/name}","releases_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/releases{/id}","created_at":"2014-07-29T10:24:41Z","updated_at":"2015-04-04T17:07:11Z","pushed_at":"2015-04-04T22:43:47Z","git_url":"git://github.com/OpenDungeons/OpenDungeons.git","ssh_url":"git@github.com:OpenDungeons/OpenDungeons.git","clone_url":"https://github.com/OpenDungeons/OpenDungeons.git","svn_url":"https://github.com/OpenDungeons/OpenDungeons","homepage":"http://opendungeons.sourceforge.net/","size":213440,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":38,"forks":9,"open_issues":38,"watchers":19,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617"},"html":{"href":"https://github.com/OpenDungeons/OpenDungeons/pull/617"},"issue":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617"},"comments":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/statuses/1a2c4c3cdf79d9b7314985f8568cc3c352a554c9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":10,"additions":860,"deletions":905,"changed_files":146}}