{"action":"created","issue":{"url":"https://api.github.com/repos/skunkwerks/swirl/issues/39","labels_url":"https://api.github.com/repos/skunkwerks/swirl/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/skunkwerks/swirl/issues/39/comments","events_url":"https://api.github.com/repos/skunkwerks/swirl/issues/39/events","html_url":"https://github.com/skunkwerks/swirl/pull/39","id":95430730,"number":39,"title":"swap orddict for maps","user":{"login":"dch","id":284368,"avatar_url":"https://avatars.githubusercontent.com/u/284368?v=3","gravatar_id":"","url":"https://api.github.com/users/dch","html_url":"https://github.com/dch","followers_url":"https://api.github.com/users/dch/followers","following_url":"https://api.github.com/users/dch/following{/other_user}","gists_url":"https://api.github.com/users/dch/gists{/gist_id}","starred_url":"https://api.github.com/users/dch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dch/subscriptions","organizations_url":"https://api.github.com/users/dch/orgs","repos_url":"https://api.github.com/users/dch/repos","events_url":"https://api.github.com/users/dch/events{/privacy}","received_events_url":"https://api.github.com/users/dch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/skunkwerks/swirl/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-16T13:15:19Z","updated_at":"2015-07-16T15:10:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/skunkwerks/swirl/pulls/39","html_url":"https://github.com/skunkwerks/swirl/pull/39","diff_url":"https://github.com/skunkwerks/swirl/pull/39.diff","patch_url":"https://github.com/skunkwerks/swirl/pull/39.patch"},"body":"Thanks Kansi! LGTM overall, nice work.\r\n\r\nThis needs a rebase after I added the ppspp_options_SUITE tests this morning. Good timing depending on your point of view!\r\n\r\nSome general comments:\r\n- these `%% @type options() = {options, options_dict()}.` need to stay duplicated, edoc/edown needs them for generating typespec info in the docs\r\n- please remove the commented-out orddict lines\r\n- where we are creating the option for the first time we should fail if the key already exists\r\n- ensure the function body comments are updated to match the changed code :-)\r\n\r\nBefore final push, we should squash this down to 1 commit, and confirm with `make reindent` that all is tidy. Your indentation (perhaps emacs?) is different to vim's one."},"comment":{"url":"https://api.github.com/repos/skunkwerks/swirl/issues/comments/121986700","html_url":"https://github.com/skunkwerks/swirl/pull/39#issuecomment-121986700","issue_url":"https://api.github.com/repos/skunkwerks/swirl/issues/39","id":121986700,"user":{"login":"dch","id":284368,"avatar_url":"https://avatars.githubusercontent.com/u/284368?v=3","gravatar_id":"","url":"https://api.github.com/users/dch","html_url":"https://github.com/dch","followers_url":"https://api.github.com/users/dch/followers","following_url":"https://api.github.com/users/dch/following{/other_user}","gists_url":"https://api.github.com/users/dch/gists{/gist_id}","starred_url":"https://api.github.com/users/dch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dch/subscriptions","organizations_url":"https://api.github.com/users/dch/orgs","repos_url":"https://api.github.com/users/dch/repos","events_url":"https://api.github.com/users/dch/events{/privacy}","received_events_url":"https://api.github.com/users/dch/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T15:10:42Z","updated_at":"2015-07-16T15:10:42Z","body":"@kansi ^^"}}