{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/36575051","id":36575051,"diff_hunk":"@@ -315,6 +315,72 @@ pub trait Read {\n         append_to_string(buf, |b| read_to_end(self, b))\n     }\n \n+    /// Read the exact number of bytes required to fill `buf`.\n+    ///\n+    /// This function reads as many bytes as necessary to completely fill the\n+    /// specified buffer `buf`.\n+    ///\n+    /// No guarantees are provided about the contents of `buf` when this\n+    /// function is called, implementations cannot rely on any property of the\n+    /// contents of `buf` being true. It is recommended that implementations\n+    /// only write data to `buf` instead of reading its contents.\n+    ///\n+    /// # Errors\n+    ///\n+    /// If this function encounters an error of the kind\n+    /// `ErrorKind::Interrupted` then the error is ignored and the operation\n+    /// will continue.\n+    ///\n+    /// If this function encounters an \"end of file\" before completely filling\n+    /// the buffer, it returns an error of the kind `ErrorKind::UnexpectedEOF`.\n+    /// The contents of `buf` are undefined in this case.","path":"src/libstd/io/mod.rs","position":22,"original_position":22,"commit_id":"4dd35f886c4ed712b7605b0bdb1efd86c233737c","original_commit_id":"4dd35f886c4ed712b7605b0bdb1efd86c233737c","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"Might want to say \"unspecified\" instead of \"undefined\" here to avoid conflating with undefined behavior.","created_at":"2015-08-08T04:36:06Z","updated_at":"2015-08-08T04:36:06Z","html_url":"https://github.com/rust-lang/rust/pull/27588#discussion_r36575051","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/27588","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/36575051"},"html":{"href":"https://github.com/rust-lang/rust/pull/27588#discussion_r36575051"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27588"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27588","id":41939947,"html_url":"https://github.com/rust-lang/rust/pull/27588","diff_url":"https://github.com/rust-lang/rust/pull/27588.diff","patch_url":"https://github.com/rust-lang/rust/pull/27588.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27588","number":27588,"state":"open","locked":false,"title":"Implement read_exact for the Read trait","user":{"login":"cesarb","id":31324,"avatar_url":"https://avatars.githubusercontent.com/u/31324?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarb","html_url":"https://github.com/cesarb","followers_url":"https://api.github.com/users/cesarb/followers","following_url":"https://api.github.com/users/cesarb/following{/other_user}","gists_url":"https://api.github.com/users/cesarb/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarb/subscriptions","organizations_url":"https://api.github.com/users/cesarb/orgs","repos_url":"https://api.github.com/users/cesarb/repos","events_url":"https://api.github.com/users/cesarb/events{/privacy}","received_events_url":"https://api.github.com/users/cesarb/received_events","type":"User","site_admin":false},"body":"This implements the proposed \"read_exact\" RFC (https://github.com/rust-lang/rfcs/pull/980).\r\n\r\nTracking issue: https://github.com/rust-lang/rust/issues/27585","created_at":"2015-08-07T22:41:56Z","updated_at":"2015-08-08T04:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec45092ffe02a42cf72beca8745961ad657fabd3","assignee":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/27588/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/27588/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27588/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/4dd35f886c4ed712b7605b0bdb1efd86c233737c","head":{"label":"cesarb:read_all","ref":"read_all","sha":"4dd35f886c4ed712b7605b0bdb1efd86c233737c","user":{"login":"cesarb","id":31324,"avatar_url":"https://avatars.githubusercontent.com/u/31324?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarb","html_url":"https://github.com/cesarb","followers_url":"https://api.github.com/users/cesarb/followers","following_url":"https://api.github.com/users/cesarb/following{/other_user}","gists_url":"https://api.github.com/users/cesarb/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarb/subscriptions","organizations_url":"https://api.github.com/users/cesarb/orgs","repos_url":"https://api.github.com/users/cesarb/repos","events_url":"https://api.github.com/users/cesarb/events{/privacy}","received_events_url":"https://api.github.com/users/cesarb/received_events","type":"User","site_admin":false},"repo":{"id":39361453,"name":"rust","full_name":"cesarb/rust","owner":{"login":"cesarb","id":31324,"avatar_url":"https://avatars.githubusercontent.com/u/31324?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarb","html_url":"https://github.com/cesarb","followers_url":"https://api.github.com/users/cesarb/followers","following_url":"https://api.github.com/users/cesarb/following{/other_user}","gists_url":"https://api.github.com/users/cesarb/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarb/subscriptions","organizations_url":"https://api.github.com/users/cesarb/orgs","repos_url":"https://api.github.com/users/cesarb/repos","events_url":"https://api.github.com/users/cesarb/events{/privacy}","received_events_url":"https://api.github.com/users/cesarb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cesarb/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/cesarb/rust","forks_url":"https://api.github.com/repos/cesarb/rust/forks","keys_url":"https://api.github.com/repos/cesarb/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesarb/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesarb/rust/teams","hooks_url":"https://api.github.com/repos/cesarb/rust/hooks","issue_events_url":"https://api.github.com/repos/cesarb/rust/issues/events{/number}","events_url":"https://api.github.com/repos/cesarb/rust/events","assignees_url":"https://api.github.com/repos/cesarb/rust/assignees{/user}","branches_url":"https://api.github.com/repos/cesarb/rust/branches{/branch}","tags_url":"https://api.github.com/repos/cesarb/rust/tags","blobs_url":"https://api.github.com/repos/cesarb/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesarb/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesarb/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesarb/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesarb/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/cesarb/rust/languages","stargazers_url":"https://api.github.com/repos/cesarb/rust/stargazers","contributors_url":"https://api.github.com/repos/cesarb/rust/contributors","subscribers_url":"https://api.github.com/repos/cesarb/rust/subscribers","subscription_url":"https://api.github.com/repos/cesarb/rust/subscription","commits_url":"https://api.github.com/repos/cesarb/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesarb/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesarb/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesarb/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesarb/rust/contents/{+path}","compare_url":"https://api.github.com/repos/cesarb/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesarb/rust/merges","archive_url":"https://api.github.com/repos/cesarb/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesarb/rust/downloads","issues_url":"https://api.github.com/repos/cesarb/rust/issues{/number}","pulls_url":"https://api.github.com/repos/cesarb/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/cesarb/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/cesarb/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesarb/rust/labels{/name}","releases_url":"https://api.github.com/repos/cesarb/rust/releases{/id}","created_at":"2015-07-20T03:30:26Z","updated_at":"2015-07-20T03:30:40Z","pushed_at":"2015-08-07T23:51:08Z","git_url":"git://github.com/cesarb/rust.git","ssh_url":"git@github.com:cesarb/rust.git","clone_url":"https://github.com/cesarb/rust.git","svn_url":"https://github.com/cesarb/rust","homepage":"http://www.rust-lang.org","size":305441,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"e5d90d98402475b6e154ce216f9efcb80da1a747","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-08-08T03:37:41Z","pushed_at":"2015-08-07T23:51:11Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":656410,"stargazers_count":12886,"watchers_count":12886,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2493,"mirror_url":null,"open_issues_count":2142,"forks":2493,"open_issues":2142,"watchers":12886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27588"},"html":{"href":"https://github.com/rust-lang/rust/pull/27588"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27588"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27588/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27588/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27588/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/4dd35f886c4ed712b7605b0bdb1efd86c233737c"}}}}