{"action":"created","comment":{"url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments/33768274","id":33768274,"diff_hunk":"@@ -144,8 +144,12 @@ def build_zone(domain, all_domains, additional_records, www_redirect_domains, en\n \t\trecords.append((None,  \"NS\",  \"ns1.%s.\" % env[\"PRIMARY_HOSTNAME\"], False))\n \n \t\t# Define ns2.PRIMARY_HOSTNAME or whatever the user overrides.\n-\t\tsecondary_ns = get_secondary_dns(additional_records) or (\"ns2.\" + env[\"PRIMARY_HOSTNAME\"])\n-\t\trecords.append((None,  \"NS\", secondary_ns+'.', False))\n+\t\t# User may provide one or more additional nameservers\n+\t\tif get_secondary_dns(additional_records):\n+\t\t\t\t[records.append((None,  \"NS\", secondary_ns+'.', False)) for secondary_ns in get_secondary_dns(additional_records)]","path":"management/dns_update.py","position":8,"original_position":8,"commit_id":"be586e4006aeff3bdb41c2028c0ced28a0c8bf63","original_commit_id":"be586e4006aeff3bdb41c2028c0ced28a0c8bf63","user":{"login":"JoshData","id":445875,"avatar_url":"https://avatars.githubusercontent.com/u/445875?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshData","html_url":"https://github.com/JoshData","followers_url":"https://api.github.com/users/JoshData/followers","following_url":"https://api.github.com/users/JoshData/following{/other_user}","gists_url":"https://api.github.com/users/JoshData/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshData/subscriptions","organizations_url":"https://api.github.com/users/JoshData/orgs","repos_url":"https://api.github.com/users/JoshData/repos","events_url":"https://api.github.com/users/JoshData/events{/privacy}","received_events_url":"https://api.github.com/users/JoshData/received_events","type":"User","site_admin":false},"body":"Also please avoid calling get_secondary_dns multiple times here.","created_at":"2015-07-02T11:20:11Z","updated_at":"2015-07-02T11:20:11Z","html_url":"https://github.com/mail-in-a-box/mailinabox/pull/476#discussion_r33768274","pull_request_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476","_links":{"self":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments/33768274"},"html":{"href":"https://github.com/mail-in-a-box/mailinabox/pull/476#discussion_r33768274"},"pull_request":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476"}}},"pull_request":{"url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476","id":39040486,"html_url":"https://github.com/mail-in-a-box/mailinabox/pull/476","diff_url":"https://github.com/mail-in-a-box/mailinabox/pull/476.diff","patch_url":"https://github.com/mail-in-a-box/mailinabox/pull/476.patch","issue_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/476","number":476,"state":"open","locked":false,"title":"Multiple secondary NS servers","user":{"login":"bbustin","id":5741673,"avatar_url":"https://avatars.githubusercontent.com/u/5741673?v=3","gravatar_id":"","url":"https://api.github.com/users/bbustin","html_url":"https://github.com/bbustin","followers_url":"https://api.github.com/users/bbustin/followers","following_url":"https://api.github.com/users/bbustin/following{/other_user}","gists_url":"https://api.github.com/users/bbustin/gists{/gist_id}","starred_url":"https://api.github.com/users/bbustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbustin/subscriptions","organizations_url":"https://api.github.com/users/bbustin/orgs","repos_url":"https://api.github.com/users/bbustin/repos","events_url":"https://api.github.com/users/bbustin/events{/privacy}","received_events_url":"https://api.github.com/users/bbustin/received_events","type":"User","site_admin":false},"body":"Added the ability to use more than one secondary NS server. Changes made to the daemon to allow this to work from the web interface.","created_at":"2015-07-02T01:18:20Z","updated_at":"2015-07-02T11:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28b39630f24e6e91f34a04ea5dbd6d5799e0f746","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476/commits","review_comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476/comments","review_comment_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/476/comments","statuses_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/be586e4006aeff3bdb41c2028c0ced28a0c8bf63","head":{"label":"bbustin:master","ref":"master","sha":"be586e4006aeff3bdb41c2028c0ced28a0c8bf63","user":{"login":"bbustin","id":5741673,"avatar_url":"https://avatars.githubusercontent.com/u/5741673?v=3","gravatar_id":"","url":"https://api.github.com/users/bbustin","html_url":"https://github.com/bbustin","followers_url":"https://api.github.com/users/bbustin/followers","following_url":"https://api.github.com/users/bbustin/following{/other_user}","gists_url":"https://api.github.com/users/bbustin/gists{/gist_id}","starred_url":"https://api.github.com/users/bbustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbustin/subscriptions","organizations_url":"https://api.github.com/users/bbustin/orgs","repos_url":"https://api.github.com/users/bbustin/repos","events_url":"https://api.github.com/users/bbustin/events{/privacy}","received_events_url":"https://api.github.com/users/bbustin/received_events","type":"User","site_admin":false},"repo":{"id":38388320,"name":"mailinabox","full_name":"bbustin/mailinabox","owner":{"login":"bbustin","id":5741673,"avatar_url":"https://avatars.githubusercontent.com/u/5741673?v=3","gravatar_id":"","url":"https://api.github.com/users/bbustin","html_url":"https://github.com/bbustin","followers_url":"https://api.github.com/users/bbustin/followers","following_url":"https://api.github.com/users/bbustin/following{/other_user}","gists_url":"https://api.github.com/users/bbustin/gists{/gist_id}","starred_url":"https://api.github.com/users/bbustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbustin/subscriptions","organizations_url":"https://api.github.com/users/bbustin/orgs","repos_url":"https://api.github.com/users/bbustin/repos","events_url":"https://api.github.com/users/bbustin/events{/privacy}","received_events_url":"https://api.github.com/users/bbustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbustin/mailinabox","description":"Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.","fork":true,"url":"https://api.github.com/repos/bbustin/mailinabox","forks_url":"https://api.github.com/repos/bbustin/mailinabox/forks","keys_url":"https://api.github.com/repos/bbustin/mailinabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbustin/mailinabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbustin/mailinabox/teams","hooks_url":"https://api.github.com/repos/bbustin/mailinabox/hooks","issue_events_url":"https://api.github.com/repos/bbustin/mailinabox/issues/events{/number}","events_url":"https://api.github.com/repos/bbustin/mailinabox/events","assignees_url":"https://api.github.com/repos/bbustin/mailinabox/assignees{/user}","branches_url":"https://api.github.com/repos/bbustin/mailinabox/branches{/branch}","tags_url":"https://api.github.com/repos/bbustin/mailinabox/tags","blobs_url":"https://api.github.com/repos/bbustin/mailinabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbustin/mailinabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbustin/mailinabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbustin/mailinabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbustin/mailinabox/statuses/{sha}","languages_url":"https://api.github.com/repos/bbustin/mailinabox/languages","stargazers_url":"https://api.github.com/repos/bbustin/mailinabox/stargazers","contributors_url":"https://api.github.com/repos/bbustin/mailinabox/contributors","subscribers_url":"https://api.github.com/repos/bbustin/mailinabox/subscribers","subscription_url":"https://api.github.com/repos/bbustin/mailinabox/subscription","commits_url":"https://api.github.com/repos/bbustin/mailinabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbustin/mailinabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbustin/mailinabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbustin/mailinabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbustin/mailinabox/contents/{+path}","compare_url":"https://api.github.com/repos/bbustin/mailinabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbustin/mailinabox/merges","archive_url":"https://api.github.com/repos/bbustin/mailinabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbustin/mailinabox/downloads","issues_url":"https://api.github.com/repos/bbustin/mailinabox/issues{/number}","pulls_url":"https://api.github.com/repos/bbustin/mailinabox/pulls{/number}","milestones_url":"https://api.github.com/repos/bbustin/mailinabox/milestones{/number}","notifications_url":"https://api.github.com/repos/bbustin/mailinabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbustin/mailinabox/labels{/name}","releases_url":"https://api.github.com/repos/bbustin/mailinabox/releases{/id}","created_at":"2015-07-01T18:38:20Z","updated_at":"2015-07-01T18:38:21Z","pushed_at":"2015-07-02T02:54:15Z","git_url":"git://github.com/bbustin/mailinabox.git","ssh_url":"git@github.com:bbustin/mailinabox.git","clone_url":"https://github.com/bbustin/mailinabox.git","svn_url":"https://github.com/bbustin/mailinabox","homepage":"https://mailinabox.email/","size":4414,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mail-in-a-box:master","ref":"master","sha":"c0ddceb2bd911f6e43623572b598af0377916aa3","user":{"login":"mail-in-a-box","id":8107370,"avatar_url":"https://avatars.githubusercontent.com/u/8107370?v=3","gravatar_id":"","url":"https://api.github.com/users/mail-in-a-box","html_url":"https://github.com/mail-in-a-box","followers_url":"https://api.github.com/users/mail-in-a-box/followers","following_url":"https://api.github.com/users/mail-in-a-box/following{/other_user}","gists_url":"https://api.github.com/users/mail-in-a-box/gists{/gist_id}","starred_url":"https://api.github.com/users/mail-in-a-box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mail-in-a-box/subscriptions","organizations_url":"https://api.github.com/users/mail-in-a-box/orgs","repos_url":"https://api.github.com/users/mail-in-a-box/repos","events_url":"https://api.github.com/users/mail-in-a-box/events{/privacy}","received_events_url":"https://api.github.com/users/mail-in-a-box/received_events","type":"Organization","site_admin":false},"repo":{"id":12271469,"name":"mailinabox","full_name":"mail-in-a-box/mailinabox","owner":{"login":"mail-in-a-box","id":8107370,"avatar_url":"https://avatars.githubusercontent.com/u/8107370?v=3","gravatar_id":"","url":"https://api.github.com/users/mail-in-a-box","html_url":"https://github.com/mail-in-a-box","followers_url":"https://api.github.com/users/mail-in-a-box/followers","following_url":"https://api.github.com/users/mail-in-a-box/following{/other_user}","gists_url":"https://api.github.com/users/mail-in-a-box/gists{/gist_id}","starred_url":"https://api.github.com/users/mail-in-a-box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mail-in-a-box/subscriptions","organizations_url":"https://api.github.com/users/mail-in-a-box/orgs","repos_url":"https://api.github.com/users/mail-in-a-box/repos","events_url":"https://api.github.com/users/mail-in-a-box/events{/privacy}","received_events_url":"https://api.github.com/users/mail-in-a-box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mail-in-a-box/mailinabox","description":"Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.","fork":false,"url":"https://api.github.com/repos/mail-in-a-box/mailinabox","forks_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/forks","keys_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/teams","hooks_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/hooks","issue_events_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/events{/number}","events_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/events","assignees_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/assignees{/user}","branches_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/branches{/branch}","tags_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/tags","blobs_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/{sha}","languages_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/languages","stargazers_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/stargazers","contributors_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/contributors","subscribers_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/subscribers","subscription_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/subscription","commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/contents/{+path}","compare_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/merges","archive_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/downloads","issues_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues{/number}","pulls_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls{/number}","milestones_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/milestones{/number}","notifications_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/labels{/name}","releases_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/releases{/id}","created_at":"2013-08-21T13:56:50Z","updated_at":"2015-07-02T10:25:04Z","pushed_at":"2015-07-02T10:55:06Z","git_url":"git://github.com/mail-in-a-box/mailinabox.git","ssh_url":"git@github.com:mail-in-a-box/mailinabox.git","clone_url":"https://github.com/mail-in-a-box/mailinabox.git","svn_url":"https://github.com/mail-in-a-box/mailinabox","homepage":"https://mailinabox.email/","size":4414,"stargazers_count":4011,"watchers_count":4011,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":71,"forks":252,"open_issues":71,"watchers":4011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476"},"html":{"href":"https://github.com/mail-in-a-box/mailinabox/pull/476"},"issue":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/476"},"comments":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/be586e4006aeff3bdb41c2028c0ced28a0c8bf63"}}}}