{"action":"created","comment":{"url":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments/29788209","id":29788209,"diff_hunk":"@@ -142,7 +142,9 @@ - (IBAction)beginStripeCheckout:(id)sender {\n     STPCheckoutOptions *options = [[STPCheckoutOptions alloc] initWithPublishableKey:[Stripe defaultPublishableKey]];\n     options.purchaseDescription = @\"Cool Shirt\";\n     options.purchaseAmount = 1000; // this is in cents\n+    options.requireBillingAddress = @YES;\n     options.logoColor = [UIColor purpleColor];","path":"Example/Stripe iOS Example (Custom)/ViewController.m","position":5,"original_position":5,"commit_id":"bdfbc5b03f74b3395378ba902a9a0df85afe31d3","original_commit_id":"bdfbc5b03f74b3395378ba902a9a0df85afe31d3","user":{"login":"jamesreggio","id":822205,"avatar_url":"https://avatars.githubusercontent.com/u/822205?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesreggio","html_url":"https://github.com/jamesreggio","followers_url":"https://api.github.com/users/jamesreggio/followers","following_url":"https://api.github.com/users/jamesreggio/following{/other_user}","gists_url":"https://api.github.com/users/jamesreggio/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesreggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesreggio/subscriptions","organizations_url":"https://api.github.com/users/jamesreggio/orgs","repos_url":"https://api.github.com/users/jamesreggio/repos","events_url":"https://api.github.com/users/jamesreggio/events{/privacy}","received_events_url":"https://api.github.com/users/jamesreggio/received_events","type":"User","site_admin":false},"body":"I'm guessing that this color isn't the best complement to the Dribble logo. Would you mind substituting the color-detection color in? It's this:\r\n\r\n```\r\nhex: \"#bd1f5b\"\r\nrgb: {r: 188, g: 31, b: 91}\r\n```","created_at":"2015-05-06T18:38:40Z","updated_at":"2015-05-06T18:38:40Z","html_url":"https://github.com/stripe/stripe-ios/pull/147#discussion_r29788209","pull_request_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments/29788209"},"html":{"href":"https://github.com/stripe/stripe-ios/pull/147#discussion_r29788209"},"pull_request":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/stripe/stripe-ios/pulls/147","id":34788325,"html_url":"https://github.com/stripe/stripe-ios/pull/147","diff_url":"https://github.com/stripe/stripe-ios/pull/147.diff","patch_url":"https://github.com/stripe/stripe-ios/pull/147.patch","issue_url":"https://api.github.com/repos/stripe/stripe-ios/issues/147","number":147,"state":"open","locked":false,"title":"Further improve UI/NSImage handling in checkout","user":{"login":"jflinter","id":740583,"avatar_url":"https://avatars.githubusercontent.com/u/740583?v=3","gravatar_id":"","url":"https://api.github.com/users/jflinter","html_url":"https://github.com/jflinter","followers_url":"https://api.github.com/users/jflinter/followers","following_url":"https://api.github.com/users/jflinter/following{/other_user}","gists_url":"https://api.github.com/users/jflinter/gists{/gist_id}","starred_url":"https://api.github.com/users/jflinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflinter/subscriptions","organizations_url":"https://api.github.com/users/jflinter/orgs","repos_url":"https://api.github.com/users/jflinter/repos","events_url":"https://api.github.com/users/jflinter/events{/privacy}","received_events_url":"https://api.github.com/users/jflinter/received_events","type":"User","site_admin":false},"body":"#146 fixes UIImage handling in checkout, but now that we're doing it with a `data:` URI and there's no temporary-file state to clean up, we can move all of this logic to `STPCheckoutOptions` where it belongs. (It'll also be way easier to test, when we finally get around to it).\r\n\r\nThis also fixes the issue for OSX, which is much easier now that everything lives in `STPCheckoutOptions`.\r\n\r\nr? @jamesreggio ","created_at":"2015-05-06T04:36:42Z","updated_at":"2015-05-06T18:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"081117faaebed662df923ac8ee0d44212ea9349b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/147/commits","review_comments_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/147/comments","review_comment_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stripe/stripe-ios/issues/147/comments","statuses_url":"https://api.github.com/repos/stripe/stripe-ios/statuses/bdfbc5b03f74b3395378ba902a9a0df85afe31d3","head":{"label":"stripe:jack-fix-checkout-images","ref":"jack-fix-checkout-images","sha":"bdfbc5b03f74b3395378ba902a9a0df85afe31d3","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6656911,"name":"stripe-ios","full_name":"stripe/stripe-ios","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-ios","description":"Stripe bindings for iOS and OS X","fork":false,"url":"https://api.github.com/repos/stripe/stripe-ios","forks_url":"https://api.github.com/repos/stripe/stripe-ios/forks","keys_url":"https://api.github.com/repos/stripe/stripe-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-ios/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-ios/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-ios/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-ios/events","assignees_url":"https://api.github.com/repos/stripe/stripe-ios/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-ios/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-ios/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-ios/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-ios/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-ios/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-ios/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-ios/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-ios/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-ios/merges","archive_url":"https://api.github.com/repos/stripe/stripe-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-ios/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-ios/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-ios/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-ios/releases{/id}","created_at":"2012-11-12T16:55:08Z","updated_at":"2015-05-06T12:44:10Z","pushed_at":"2015-05-06T04:45:33Z","git_url":"git://github.com/stripe/stripe-ios.git","ssh_url":"git@github.com:stripe/stripe-ios.git","clone_url":"https://github.com/stripe/stripe-ios.git","svn_url":"https://github.com/stripe/stripe-ios","homepage":"https://stripe.com","size":20153,"stargazers_count":373,"watchers_count":373,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":6,"forks":161,"open_issues":6,"watchers":373,"default_branch":"master"}},"base":{"label":"stripe:master","ref":"master","sha":"a0509e2ba7f25fcd308d5696a18483039053237e","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6656911,"name":"stripe-ios","full_name":"stripe/stripe-ios","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-ios","description":"Stripe bindings for iOS and OS X","fork":false,"url":"https://api.github.com/repos/stripe/stripe-ios","forks_url":"https://api.github.com/repos/stripe/stripe-ios/forks","keys_url":"https://api.github.com/repos/stripe/stripe-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-ios/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-ios/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-ios/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-ios/events","assignees_url":"https://api.github.com/repos/stripe/stripe-ios/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-ios/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-ios/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-ios/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-ios/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-ios/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-ios/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-ios/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-ios/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-ios/merges","archive_url":"https://api.github.com/repos/stripe/stripe-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-ios/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-ios/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-ios/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-ios/releases{/id}","created_at":"2012-11-12T16:55:08Z","updated_at":"2015-05-06T12:44:10Z","pushed_at":"2015-05-06T04:45:33Z","git_url":"git://github.com/stripe/stripe-ios.git","ssh_url":"git@github.com:stripe/stripe-ios.git","clone_url":"https://github.com/stripe/stripe-ios.git","svn_url":"https://github.com/stripe/stripe-ios","homepage":"https://stripe.com","size":20153,"stargazers_count":373,"watchers_count":373,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":6,"forks":161,"open_issues":6,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/147"},"html":{"href":"https://github.com/stripe/stripe-ios/pull/147"},"issue":{"href":"https://api.github.com/repos/stripe/stripe-ios/issues/147"},"comments":{"href":"https://api.github.com/repos/stripe/stripe-ios/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/stripe/stripe-ios/statuses/bdfbc5b03f74b3395378ba902a9a0df85afe31d3"}}}}