{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/47215432","id":47215432,"diff_hunk":"@@ -28,10 +29,24 @@ export default class ReplicaSetListController {\n    */\n   constructor($state, replicaSets) {\n     /** @export {!Array<backendApi.ReplicaSet>} */\n-    this.replicaSets = replicaSets.replicaSets;\n+    this.replicaSets = replicaSets.replicaSets || [];","path":"src/app/frontend/replicasetlist/replicasetlist_controller.js","position":13,"original_position":13,"commit_id":"16bc3716c3df27b25513b10ca26642db6c7c649b","original_commit_id":"b444e612047fcbf5f963e3311745b738184fe57d","user":{"login":"floreks","id":2285385,"avatar_url":"https://avatars.githubusercontent.com/u/2285385?v=3","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"body":"Next thing to remember is to initialize all arrays that belong to some structure. Problem here was that `ReplicaSetList` has `ReplicaSets []ReplicaSet` array and in fact when it is not initialized using `replicaSetList.ReplicaSets = make([]ReplicaSet, 0)` then this is just null pointer.","created_at":"2015-12-10T11:29:33Z","updated_at":"2015-12-10T11:29:33Z","html_url":"https://github.com/kubernetes/dashboard/pull/151#discussion_r47215432","pull_request_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/47215432"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/151#discussion_r47215432"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/151","id":53237298,"html_url":"https://github.com/kubernetes/dashboard/pull/151","diff_url":"https://github.com/kubernetes/dashboard/pull/151.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/151.patch","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/151","number":151,"state":"open","locked":false,"title":"Added functionality to delete replica set from events page","user":{"login":"floreks","id":2285385,"avatar_url":"https://avatars.githubusercontent.com/u/2285385?v=3","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"body":"- [x] Delete button on replica set detail page will open a dialog and ask user if he wants to delete current replica set.\r\n- [x] Added check on replica set list page to prevent it from showing when there are not replica sets. \r\n- [x] Added check to hide `Service` block on events page sidebar when there are no service related to replica set.\r\n\r\n![zrzut ekranu z 2015-12-10 11-03-21](https://cloud.githubusercontent.com/assets/2285385/11712469/a2df4dfe-9f2d-11e5-8f18-aa0194616fc7.png)\r\n","created_at":"2015-12-10T10:04:12Z","updated_at":"2015-12-10T11:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a830efe70d575c7a604db384a0ab246991f28e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/151/commits","review_comments_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/151/comments","review_comment_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/151/comments","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/16bc3716c3df27b25513b10ca26642db6c7c649b","head":{"label":"floreks:events-replicaset-delete","ref":"events-replicaset-delete","sha":"16bc3716c3df27b25513b10ca26642db6c7c649b","user":{"login":"floreks","id":2285385,"avatar_url":"https://avatars.githubusercontent.com/u/2285385?v=3","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"repo":{"id":45398177,"name":"dashboard","full_name":"floreks/dashboard","owner":{"login":"floreks","id":2285385,"avatar_url":"https://avatars.githubusercontent.com/u/2285385?v=3","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floreks/dashboard","description":"","fork":true,"url":"https://api.github.com/repos/floreks/dashboard","forks_url":"https://api.github.com/repos/floreks/dashboard/forks","keys_url":"https://api.github.com/repos/floreks/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floreks/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floreks/dashboard/teams","hooks_url":"https://api.github.com/repos/floreks/dashboard/hooks","issue_events_url":"https://api.github.com/repos/floreks/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/floreks/dashboard/events","assignees_url":"https://api.github.com/repos/floreks/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/floreks/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/floreks/dashboard/tags","blobs_url":"https://api.github.com/repos/floreks/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floreks/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floreks/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/floreks/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floreks/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/floreks/dashboard/languages","stargazers_url":"https://api.github.com/repos/floreks/dashboard/stargazers","contributors_url":"https://api.github.com/repos/floreks/dashboard/contributors","subscribers_url":"https://api.github.com/repos/floreks/dashboard/subscribers","subscription_url":"https://api.github.com/repos/floreks/dashboard/subscription","commits_url":"https://api.github.com/repos/floreks/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/floreks/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/floreks/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/floreks/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/floreks/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/floreks/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floreks/dashboard/merges","archive_url":"https://api.github.com/repos/floreks/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floreks/dashboard/downloads","issues_url":"https://api.github.com/repos/floreks/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/floreks/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/floreks/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/floreks/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floreks/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/floreks/dashboard/releases{/id}","created_at":"2015-11-02T14:06:15Z","updated_at":"2015-11-02T14:06:15Z","pushed_at":"2015-12-10T10:32:30Z","git_url":"git://github.com/floreks/dashboard.git","ssh_url":"git@github.com:floreks/dashboard.git","clone_url":"https://github.com/floreks/dashboard.git","svn_url":"https://github.com/floreks/dashboard","homepage":"","size":5809,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"bc8d7a11c6952fc2fd68d6bb5df204dea8c29d2f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":44350607,"name":"dashboard","full_name":"kubernetes/dashboard","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/dashboard","description":"","fork":false,"url":"https://api.github.com/repos/kubernetes/dashboard","forks_url":"https://api.github.com/repos/kubernetes/dashboard/forks","keys_url":"https://api.github.com/repos/kubernetes/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/dashboard/teams","hooks_url":"https://api.github.com/repos/kubernetes/dashboard/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/dashboard/events","assignees_url":"https://api.github.com/repos/kubernetes/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/dashboard/tags","blobs_url":"https://api.github.com/repos/kubernetes/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/dashboard/languages","stargazers_url":"https://api.github.com/repos/kubernetes/dashboard/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/dashboard/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/dashboard/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/dashboard/subscription","commits_url":"https://api.github.com/repos/kubernetes/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/dashboard/merges","archive_url":"https://api.github.com/repos/kubernetes/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/dashboard/downloads","issues_url":"https://api.github.com/repos/kubernetes/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/dashboard/releases{/id}","created_at":"2015-10-15T23:09:14Z","updated_at":"2015-12-10T07:34:11Z","pushed_at":"2015-12-10T10:55:24Z","git_url":"git://github.com/kubernetes/dashboard.git","ssh_url":"git@github.com:kubernetes/dashboard.git","clone_url":"https://github.com/kubernetes/dashboard.git","svn_url":"https://github.com/kubernetes/dashboard","homepage":"","size":5841,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":23,"forks":18,"open_issues":23,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/151"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/151"},"issue":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/151"},"comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/dashboard/statuses/16bc3716c3df27b25513b10ca26642db6c7c649b"}}}}