{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2397","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2397/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2397/comments","events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2397/events","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2397","id":107633071,"number":2397,"title":"Ensure that PRODUCT_NAME is set when used as a subproject","user":{"login":"tonyarnold","id":4802,"avatar_url":"https://avatars.githubusercontent.com/u/4802?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyarnold","html_url":"https://github.com/tonyarnold","followers_url":"https://api.github.com/users/tonyarnold/followers","following_url":"https://api.github.com/users/tonyarnold/following{/other_user}","gists_url":"https://api.github.com/users/tonyarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyarnold/subscriptions","organizations_url":"https://api.github.com/users/tonyarnold/orgs","repos_url":"https://api.github.com/users/tonyarnold/repos","events_url":"https://api.github.com/users/tonyarnold/events{/privacy}","received_events_url":"https://api.github.com/users/tonyarnold/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T02:13:28Z","updated_at":"2015-09-22T02:14:22Z","closed_at":"2015-09-22T02:14:22Z","pull_request":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2397","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2397","diff_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2397.diff","patch_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2397.patch"},"body":"When used as a subproject, the `$PRODUCT_NAME` variable was not being inferred from the xcconfigs. Setting the project level product name works around the problem (the tests use `$TARGET_NAME` and the frameworks all use `$PROJECT_NAME`). \r\n\r\nI'm sure there's a problem here deeper than what I've investigated, but this PR fixes the symptoms reasonably cleanly.\r\n\r\nFixes #2395."},"comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/comments/142160027","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2397#issuecomment-142160027","issue_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2397","id":142160027,"user":{"login":"tonyarnold","id":4802,"avatar_url":"https://avatars.githubusercontent.com/u/4802?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyarnold","html_url":"https://github.com/tonyarnold","followers_url":"https://api.github.com/users/tonyarnold/followers","following_url":"https://api.github.com/users/tonyarnold/following{/other_user}","gists_url":"https://api.github.com/users/tonyarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyarnold/subscriptions","organizations_url":"https://api.github.com/users/tonyarnold/orgs","repos_url":"https://api.github.com/users/tonyarnold/repos","events_url":"https://api.github.com/users/tonyarnold/events{/privacy}","received_events_url":"https://api.github.com/users/tonyarnold/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T02:14:22Z","updated_at":"2015-09-22T02:14:22Z","body":"Argh, my mistake — ignore this!"}}