{"action":"opened","issue":{"url":"https://api.github.com/repos/Reactive-Extensions/Rx.NET/issues/83","labels_url":"https://api.github.com/repos/Reactive-Extensions/Rx.NET/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/Reactive-Extensions/Rx.NET/issues/83/comments","events_url":"https://api.github.com/repos/Reactive-Extensions/Rx.NET/issues/83/events","html_url":"https://github.com/Reactive-Extensions/Rx.NET/issues/83","id":57451772,"number":83,"title":"Observable.Create not completing","user":{"login":"Lukazoid","id":1301620,"avatar_url":"https://avatars.githubusercontent.com/u/1301620?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukazoid","html_url":"https://github.com/Lukazoid","followers_url":"https://api.github.com/users/Lukazoid/followers","following_url":"https://api.github.com/users/Lukazoid/following{/other_user}","gists_url":"https://api.github.com/users/Lukazoid/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukazoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukazoid/subscriptions","organizations_url":"https://api.github.com/users/Lukazoid/orgs","repos_url":"https://api.github.com/users/Lukazoid/repos","events_url":"https://api.github.com/users/Lukazoid/events{/privacy}","received_events_url":"https://api.github.com/users/Lukazoid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-02-12T12:04:13Z","updated_at":"2015-02-12T12:04:13Z","closed_at":null,"body":"It appears that the following methods [IObservable<TResult> Create<TResult>(Func<IObserver<TResult>, CancellationToken, Task<IDisposable>> subscribeAsync)](https://github.com/Reactive-Extensions/Rx.NET/blob/fcf00a1d0c95672934609b6a2dbb4b93fca55428/Rx.NET/Source/System.Reactive.Linq/Reactive/Linq/QueryLanguage.Creation.cs#L62) and [IObservable<TResult> Create<TResult>(Func<IObserver<TResult>, CancellationToken, Task<Action>> subscribeAsync)](https://github.com/Reactive-Extensions/Rx.NET/blob/fcf00a1d0c95672934609b6a2dbb4b93fca55428/Rx.NET/Source/System.Reactive.Linq/Reactive/Linq/QueryLanguage.Creation.cs#L87) do not correctly mark the resulting `IObservable<TResult>` as complete when the asynchronous delegate completes.\r\n\r\nThis can be seen by the use of `Stubs.Nop` for the completion delegate [here](https://github.com/Reactive-Extensions/Rx.NET/blob/fcf00a1d0c95672934609b6a2dbb4b93fca55428/Rx.NET/Source/System.Reactive.Linq/Reactive/Linq/QueryLanguage.Creation.cs#L70):\r\n\r\n    var taskCompletionObserver = new AnonymousObserver<IDisposable>(d => subscription.Disposable = d ?? Disposable.Empty, observer.OnError, Stubs.Nop);\r\n\r\nand [here](https://github.com/Reactive-Extensions/Rx.NET/blob/fcf00a1d0c95672934609b6a2dbb4b93fca55428/Rx.NET/Source/System.Reactive.Linq/Reactive/Linq/QueryLanguage.Creation.cs#L95):\r\n\r\n    var taskCompletionObserver = new AnonymousObserver<Action>(a => subscription.Disposable = a != null ? Disposable.Create(a) : Disposable.Empty, observer.OnError, Stubs.Nop);\r\n\r\n\r\nI believe both of these `Stubs.Nop` calls should be replaced with `observer.OnComplete`.\r\n"}}