{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/dartdoc/issues/858","labels_url":"https://api.github.com/repos/dart-lang/dartdoc/issues/858/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/dartdoc/issues/858/comments","events_url":"https://api.github.com/repos/dart-lang/dartdoc/issues/858/events","html_url":"https://github.com/dart-lang/dartdoc/pull/858","id":102877130,"number":858,"title":"remove --package-root, use --input for the analysis root","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?v=3","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-24T19:51:08Z","updated_at":"2015-08-24T20:37:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dart-lang/dartdoc/pulls/858","html_url":"https://github.com/dart-lang/dartdoc/pull/858","diff_url":"https://github.com/dart-lang/dartdoc/pull/858.diff","patch_url":"https://github.com/dart-lang/dartdoc/pull/858.patch"},"body":"- Removed the `--package-root` option\r\n\r\nThis was implemented from the pov of the dartdoc tool (where to I load my code from?), rather than from the pov of the user (where are the packages by libraries needs to analyze correctly?). Even re-purposed, the --package-root would not have handled cases like libraries using sdk extensions.\r\n\r\nI removed it in favor of using the existing `--input` option to help us locate an analysis context. dartdoc can now generate docs for sky, when driven by their skydoc.py script, which runs from a different cwd than the `sky` package."},"comment":{"url":"https://api.github.com/repos/dart-lang/dartdoc/issues/comments/134372227","html_url":"https://github.com/dart-lang/dartdoc/pull/858#issuecomment-134372227","issue_url":"https://api.github.com/repos/dart-lang/dartdoc/issues/858","id":134372227,"user":{"login":"sethladd","id":5479,"avatar_url":"https://avatars.githubusercontent.com/u/5479?v=3","gravatar_id":"","url":"https://api.github.com/users/sethladd","html_url":"https://github.com/sethladd","followers_url":"https://api.github.com/users/sethladd/followers","following_url":"https://api.github.com/users/sethladd/following{/other_user}","gists_url":"https://api.github.com/users/sethladd/gists{/gist_id}","starred_url":"https://api.github.com/users/sethladd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethladd/subscriptions","organizations_url":"https://api.github.com/users/sethladd/orgs","repos_url":"https://api.github.com/users/sethladd/repos","events_url":"https://api.github.com/users/sethladd/events{/privacy}","received_events_url":"https://api.github.com/users/sethladd/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T20:37:24Z","updated_at":"2015-08-24T20:37:24Z","body":"lgtm"}}