{"action":"created","comment":{"url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/comments/43570210","id":43570210,"diff_hunk":"@@ -11,27 +11,34 @@\n /**\n  * Created by Pitchu on 10/19/2015.\n  */\n-public class SongDao {\n-    public int getSongId(Connection connection, String title)\n+public class SongDao implements ISongDao\n+{\n+    private Connection connection;\n+    public SongDao(Connection connection)\n+    {\n+        this.connection = connection;\n+    }\n+\n+    public Song getSongId(Song song)","path":"src/main/java/org/worshipsongs/importer/SongDao.java","position":14,"original_position":14,"commit_id":"730d2f02cbd950ac945efd3fa2a85439baae4925","original_commit_id":"730d2f02cbd950ac945efd3fa2a85439baae4925","user":{"login":"sskjames","id":229993,"avatar_url":"https://avatars.githubusercontent.com/u/229993?v=3","gravatar_id":"","url":"https://api.github.com/users/sskjames","html_url":"https://github.com/sskjames","followers_url":"https://api.github.com/users/sskjames/followers","following_url":"https://api.github.com/users/sskjames/following{/other_user}","gists_url":"https://api.github.com/users/sskjames/gists{/gist_id}","starred_url":"https://api.github.com/users/sskjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sskjames/subscriptions","organizations_url":"https://api.github.com/users/sskjames/orgs","repos_url":"https://api.github.com/users/sskjames/repos","events_url":"https://api.github.com/users/sskjames/events{/privacy}","received_events_url":"https://api.github.com/users/sskjames/received_events","type":"User","site_admin":false},"body":"Consider renaming the method as simply \"getId\". Consider changing the method signature as below:\r\n```\r\npublic int getId(String title)\r\n{\r\n...\r\n}\r\n```","created_at":"2015-10-31T10:03:32Z","updated_at":"2015-10-31T10:03:32Z","html_url":"https://github.com/crunchersaspire/worshipsongs-importer/pull/15#discussion_r43570210","pull_request_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/comments/43570210"},"html":{"href":"https://github.com/crunchersaspire/worshipsongs-importer/pull/15#discussion_r43570210"},"pull_request":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15","id":48731370,"html_url":"https://github.com/crunchersaspire/worshipsongs-importer/pull/15","diff_url":"https://github.com/crunchersaspire/worshipsongs-importer/pull/15.diff","patch_url":"https://github.com/crunchersaspire/worshipsongs-importer/pull/15.patch","issue_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues/15","number":15,"state":"open","locked":false,"title":"Resolved the exception","user":{"login":"pitchumani1989","id":8839835,"avatar_url":"https://avatars.githubusercontent.com/u/8839835?v=3","gravatar_id":"","url":"https://api.github.com/users/pitchumani1989","html_url":"https://github.com/pitchumani1989","followers_url":"https://api.github.com/users/pitchumani1989/followers","following_url":"https://api.github.com/users/pitchumani1989/following{/other_user}","gists_url":"https://api.github.com/users/pitchumani1989/gists{/gist_id}","starred_url":"https://api.github.com/users/pitchumani1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitchumani1989/subscriptions","organizations_url":"https://api.github.com/users/pitchumani1989/orgs","repos_url":"https://api.github.com/users/pitchumani1989/repos","events_url":"https://api.github.com/users/pitchumani1989/events{/privacy}","received_events_url":"https://api.github.com/users/pitchumani1989/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-26T12:10:03Z","updated_at":"2015-10-31T10:03:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8091fb7addf2a52a00988fa6431dc1b489cd870f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15/commits","review_comments_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15/comments","review_comment_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues/15/comments","statuses_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/statuses/730d2f02cbd950ac945efd3fa2a85439baae4925","head":{"label":"pitchumani1989:master","ref":"master","sha":"730d2f02cbd950ac945efd3fa2a85439baae4925","user":{"login":"pitchumani1989","id":8839835,"avatar_url":"https://avatars.githubusercontent.com/u/8839835?v=3","gravatar_id":"","url":"https://api.github.com/users/pitchumani1989","html_url":"https://github.com/pitchumani1989","followers_url":"https://api.github.com/users/pitchumani1989/followers","following_url":"https://api.github.com/users/pitchumani1989/following{/other_user}","gists_url":"https://api.github.com/users/pitchumani1989/gists{/gist_id}","starred_url":"https://api.github.com/users/pitchumani1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitchumani1989/subscriptions","organizations_url":"https://api.github.com/users/pitchumani1989/orgs","repos_url":"https://api.github.com/users/pitchumani1989/repos","events_url":"https://api.github.com/users/pitchumani1989/events{/privacy}","received_events_url":"https://api.github.com/users/pitchumani1989/received_events","type":"User","site_admin":false},"repo":{"id":43727625,"name":"worshipsongs-importer","full_name":"pitchumani1989/worshipsongs-importer","owner":{"login":"pitchumani1989","id":8839835,"avatar_url":"https://avatars.githubusercontent.com/u/8839835?v=3","gravatar_id":"","url":"https://api.github.com/users/pitchumani1989","html_url":"https://github.com/pitchumani1989","followers_url":"https://api.github.com/users/pitchumani1989/followers","following_url":"https://api.github.com/users/pitchumani1989/following{/other_user}","gists_url":"https://api.github.com/users/pitchumani1989/gists{/gist_id}","starred_url":"https://api.github.com/users/pitchumani1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitchumani1989/subscriptions","organizations_url":"https://api.github.com/users/pitchumani1989/orgs","repos_url":"https://api.github.com/users/pitchumani1989/repos","events_url":"https://api.github.com/users/pitchumani1989/events{/privacy}","received_events_url":"https://api.github.com/users/pitchumani1989/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pitchumani1989/worshipsongs-importer","description":"","fork":true,"url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer","forks_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/forks","keys_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/teams","hooks_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/hooks","issue_events_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/issues/events{/number}","events_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/events","assignees_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/assignees{/user}","branches_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/branches{/branch}","tags_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/tags","blobs_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/languages","stargazers_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/stargazers","contributors_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/contributors","subscribers_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/subscribers","subscription_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/subscription","commits_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/contents/{+path}","compare_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/merges","archive_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/downloads","issues_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/issues{/number}","pulls_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/labels{/name}","releases_url":"https://api.github.com/repos/pitchumani1989/worshipsongs-importer/releases{/id}","created_at":"2015-10-06T03:18:26Z","updated_at":"2015-10-06T03:22:20Z","pushed_at":"2015-10-30T09:14:55Z","git_url":"git://github.com/pitchumani1989/worshipsongs-importer.git","ssh_url":"git@github.com:pitchumani1989/worshipsongs-importer.git","clone_url":"https://github.com/pitchumani1989/worshipsongs-importer.git","svn_url":"https://github.com/pitchumani1989/worshipsongs-importer","homepage":null,"size":1060,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crunchersaspire:master","ref":"master","sha":"338393a69ee42853a8570c9ab4bd5695ea55091e","user":{"login":"crunchersaspire","id":8839657,"avatar_url":"https://avatars.githubusercontent.com/u/8839657?v=3","gravatar_id":"","url":"https://api.github.com/users/crunchersaspire","html_url":"https://github.com/crunchersaspire","followers_url":"https://api.github.com/users/crunchersaspire/followers","following_url":"https://api.github.com/users/crunchersaspire/following{/other_user}","gists_url":"https://api.github.com/users/crunchersaspire/gists{/gist_id}","starred_url":"https://api.github.com/users/crunchersaspire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crunchersaspire/subscriptions","organizations_url":"https://api.github.com/users/crunchersaspire/orgs","repos_url":"https://api.github.com/users/crunchersaspire/repos","events_url":"https://api.github.com/users/crunchersaspire/events{/privacy}","received_events_url":"https://api.github.com/users/crunchersaspire/received_events","type":"User","site_admin":false},"repo":{"id":43726794,"name":"worshipsongs-importer","full_name":"crunchersaspire/worshipsongs-importer","owner":{"login":"crunchersaspire","id":8839657,"avatar_url":"https://avatars.githubusercontent.com/u/8839657?v=3","gravatar_id":"","url":"https://api.github.com/users/crunchersaspire","html_url":"https://github.com/crunchersaspire","followers_url":"https://api.github.com/users/crunchersaspire/followers","following_url":"https://api.github.com/users/crunchersaspire/following{/other_user}","gists_url":"https://api.github.com/users/crunchersaspire/gists{/gist_id}","starred_url":"https://api.github.com/users/crunchersaspire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crunchersaspire/subscriptions","organizations_url":"https://api.github.com/users/crunchersaspire/orgs","repos_url":"https://api.github.com/users/crunchersaspire/repos","events_url":"https://api.github.com/users/crunchersaspire/events{/privacy}","received_events_url":"https://api.github.com/users/crunchersaspire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crunchersaspire/worshipsongs-importer","description":"Bulk import songs and attributes from text files","fork":false,"url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer","forks_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/forks","keys_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/teams","hooks_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/hooks","issue_events_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues/events{/number}","events_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/events","assignees_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/assignees{/user}","branches_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/branches{/branch}","tags_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/tags","blobs_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/languages","stargazers_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/stargazers","contributors_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/contributors","subscribers_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/subscribers","subscription_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/subscription","commits_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/contents/{+path}","compare_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/merges","archive_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/downloads","issues_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues{/number}","pulls_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/labels{/name}","releases_url":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/releases{/id}","created_at":"2015-10-06T02:54:37Z","updated_at":"2015-10-30T05:16:32Z","pushed_at":"2015-10-30T09:14:56Z","git_url":"git://github.com/crunchersaspire/worshipsongs-importer.git","ssh_url":"git@github.com:crunchersaspire/worshipsongs-importer.git","clone_url":"https://github.com/crunchersaspire/worshipsongs-importer.git","svn_url":"https://github.com/crunchersaspire/worshipsongs-importer","homepage":"","size":1139,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15"},"html":{"href":"https://github.com/crunchersaspire/worshipsongs-importer/pull/15"},"issue":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues/15"},"comments":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/crunchersaspire/worshipsongs-importer/statuses/730d2f02cbd950ac945efd3fa2a85439baae4925"}}}}