{"action":"opened","number":5439,"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/5439","id":27165612,"html_url":"https://github.com/numpy/numpy/pull/5439","diff_url":"https://github.com/numpy/numpy/pull/5439.diff","patch_url":"https://github.com/numpy/numpy/pull/5439.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/5439","number":5439,"state":"open","locked":false,"title":"TST: Update assert_array_almost_equal_nulp tests","user":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"This fix addresses Issue #347.\r\n\r\nAll of the tests in this class were using random numbers generated\r\nwithout a seed. This broke `test_simple` in a nondeterministic manner.\r\n\r\nRewrote all tests for this function. Instead of using random numbers,\r\nwell-defined arrays of widely varying amplitude were created instead.\r\nChanged the array modification values so that the test arrays were\r\neither just above or just below the NULP threshold.\r\n\r\nAdded tests for float64, float32, complex128, and complex64 dtypes, and\r\nadded both addition and subtraction tests. Tried to standardize the code\r\nfor all tests.","created_at":"2015-01-11T17:38:51Z","updated_at":"2015-01-11T17:38:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/5439/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/5439/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/5439/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/103fee0ddc23bf29367b052fd39a411c926daae5","head":{"label":"charris:gh-5347","ref":"gh-5347","sha":"103fee0ddc23bf29367b052fd39a411c926daae5","user":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"repo":{"id":908701,"name":"numpy","full_name":"charris/numpy","owner":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charris/numpy","description":"Fork of numpy/numpy","fork":true,"url":"https://api.github.com/repos/charris/numpy","forks_url":"https://api.github.com/repos/charris/numpy/forks","keys_url":"https://api.github.com/repos/charris/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charris/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charris/numpy/teams","hooks_url":"https://api.github.com/repos/charris/numpy/hooks","issue_events_url":"https://api.github.com/repos/charris/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/charris/numpy/events","assignees_url":"https://api.github.com/repos/charris/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/charris/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/charris/numpy/tags","blobs_url":"https://api.github.com/repos/charris/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charris/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charris/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/charris/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charris/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/charris/numpy/languages","stargazers_url":"https://api.github.com/repos/charris/numpy/stargazers","contributors_url":"https://api.github.com/repos/charris/numpy/contributors","subscribers_url":"https://api.github.com/repos/charris/numpy/subscribers","subscription_url":"https://api.github.com/repos/charris/numpy/subscription","commits_url":"https://api.github.com/repos/charris/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/charris/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/charris/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/charris/numpy/issues/comments/{number}","contents_url":"https://api.github.com/repos/charris/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/charris/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charris/numpy/merges","archive_url":"https://api.github.com/repos/charris/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charris/numpy/downloads","issues_url":"https://api.github.com/repos/charris/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/charris/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/charris/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/charris/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charris/numpy/labels{/name}","releases_url":"https://api.github.com/repos/charris/numpy/releases{/id}","created_at":"2010-09-13T23:57:46Z","updated_at":"2015-01-03T22:19:52Z","pushed_at":"2015-01-11T17:38:07Z","git_url":"git://github.com/charris/numpy.git","ssh_url":"git@github.com:charris/numpy.git","clone_url":"https://github.com/charris/numpy.git","svn_url":"https://github.com/charris/numpy","homepage":"","size":38522,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"ae2fbd3754d3fb60531705a4f212b9bdfbbdaefd","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments/{number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","created_at":"2010-09-13T23:02:39Z","updated_at":"2015-01-11T17:29:48Z","pushed_at":"2015-01-11T17:29:48Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":60312,"stargazers_count":1667,"watchers_count":1667,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":811,"mirror_url":null,"open_issues_count":778,"forks":811,"open_issues":778,"watchers":1667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5439"},"html":{"href":"https://github.com/numpy/numpy/pull/5439"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/5439"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/5439/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5439/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5439/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/103fee0ddc23bf29367b052fd39a411c926daae5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":164,"deletions":39,"changed_files":1}}