{"action":"created","issue":{"url":"https://api.github.com/repos/mpowaga/react-slider/issues/17","labels_url":"https://api.github.com/repos/mpowaga/react-slider/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/mpowaga/react-slider/issues/17/comments","events_url":"https://api.github.com/repos/mpowaga/react-slider/issues/17/events","html_url":"https://github.com/mpowaga/react-slider/pull/17","id":54260308,"number":17,"title":"Handle: CSS transform -> CSS positioning","user":{"login":"paulmelnikow","id":1487036,"avatar_url":"https://avatars.githubusercontent.com/u/1487036?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmelnikow","html_url":"https://github.com/paulmelnikow","followers_url":"https://api.github.com/users/paulmelnikow/followers","following_url":"https://api.github.com/users/paulmelnikow/following{/other_user}","gists_url":"https://api.github.com/users/paulmelnikow/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmelnikow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmelnikow/subscriptions","organizations_url":"https://api.github.com/users/paulmelnikow/orgs","repos_url":"https://api.github.com/users/paulmelnikow/repos","events_url":"https://api.github.com/users/paulmelnikow/events{/privacy}","received_events_url":"https://api.github.com/users/paulmelnikow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-13T22:52:49Z","updated_at":"2015-01-14T12:13:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mpowaga/react-slider/pulls/17","html_url":"https://github.com/mpowaga/react-slider/pull/17","diff_url":"https://github.com/mpowaga/react-slider/pull/17.diff","patch_url":"https://github.com/mpowaga/react-slider/pull/17.patch"},"body":"Hey, first off, thanks for your hard work on this awesome component!\r\n\r\nOur app uses `transform: rotate(45deg)` to make a diamond-shape handle.\r\n\r\nThis change allows our style to work. Without it, the transform style applied here overrides what's in the class.\r\n\r\nPositioning seems more intuitive, and matches what I've seen in e.g. jQueryUI Slider.\r\n\r\nAlternatively:\r\n- To specify multiple transforms to a single element, they need to be concatenated.\r\n- I could nest a second div inside the slider div. It's simpler though to have one element."},"comment":{"url":"https://api.github.com/repos/mpowaga/react-slider/issues/comments/69907866","html_url":"https://github.com/mpowaga/react-slider/pull/17#issuecomment-69907866","issue_url":"https://api.github.com/repos/mpowaga/react-slider/issues/17","id":69907866,"user":{"login":"cell303","id":951987,"avatar_url":"https://avatars.githubusercontent.com/u/951987?v=3","gravatar_id":"","url":"https://api.github.com/users/cell303","html_url":"https://github.com/cell303","followers_url":"https://api.github.com/users/cell303/followers","following_url":"https://api.github.com/users/cell303/following{/other_user}","gists_url":"https://api.github.com/users/cell303/gists{/gist_id}","starred_url":"https://api.github.com/users/cell303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cell303/subscriptions","organizations_url":"https://api.github.com/users/cell303/orgs","repos_url":"https://api.github.com/users/cell303/repos","events_url":"https://api.github.com/users/cell303/events{/privacy}","received_events_url":"https://api.github.com/users/cell303/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T12:13:22Z","updated_at":"2015-01-14T12:13:22Z","body":"First of all thanks for your kind words :)\r\n\r\nI have to say I'm no entirely convinced that this is a good idea. \r\nBasically the reason to use `transform` is that it should more performant (I use the component myself in a mobile web app). \r\nHowever it is not at all clear whether this is actually the case (could be that each handle having its own layer adds too much of an overhead). Also, positioning an absolute positioned element should not cause an entire reflow. But basically we don't know until we try out.\r\n\r\nUntil I can do some experiments I'd like to keep this open.\r\n\r\n\r\n\r\n\r\n"}}