{"action":"opened","number":120,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/120","id":31517532,"html_url":"https://github.com/apache/cloudstack/pull/120","diff_url":"https://github.com/apache/cloudstack/pull/120.diff","patch_url":"https://github.com/apache/cloudstack/pull/120.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/120","number":120,"state":"open","locked":false,"title":"CLOUDSTACK-8336: Adding test for shared network restart, with and without cleanup","user":{"login":"gauravaradhye","id":4161170,"avatar_url":"https://avatars.githubusercontent.com/u/4161170?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravaradhye","html_url":"https://github.com/gauravaradhye","followers_url":"https://api.github.com/users/gauravaradhye/followers","following_url":"https://api.github.com/users/gauravaradhye/following{/other_user}","gists_url":"https://api.github.com/users/gauravaradhye/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravaradhye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravaradhye/subscriptions","organizations_url":"https://api.github.com/users/gauravaradhye/orgs","repos_url":"https://api.github.com/users/gauravaradhye/repos","events_url":"https://api.github.com/users/gauravaradhye/events{/privacy}","received_events_url":"https://api.github.com/users/gauravaradhye/received_events","type":"User","site_admin":false},"body":"Network restart test case was missing in the repo for shared network. So adding a basic test case that will create a shared network, deploy a VM in it and restart the network with and without cleanup option. It also checks that the publicip of the router remains the same after restart.\r\n\r\nAlso fixed the pep8 issues already present in the file.\r\n\r\nLogs:\r\nTest Shared Network ALL ... SKIP: Skip\r\nTest Shared Network with scope account ... SKIP: Skip\r\nTest Shared Network with scope domain ... SKIP: Skip\r\nTest Shared Network with scope project ... SKIP: Skip\r\nTest Shared Network with used vlan 01 ... SKIP: skipped - This is a redundant case and also this                is causing issue\r\nfor rest fo the cases\r\nTest Shared Network with used vlan 02 ... SKIP: Skip\r\nTest VM deployment in shared and isolated networks ... SKIP: Skip\r\nTest Vm deployment with multiple shared networks ... SKIP: Skip\r\n@summary: ES1621:Allow creating shared networks with overlapping ... SKIP: Skip\r\nTest shared Network with subdomainaccess=False ... SKIP: Skip\r\nTest Shared Network with subdomainaccess=True ... SKIP: Skip\r\nTest restart shared Network ... === TestName: test_restart_network_1_True | Status : SUCCESS ===\r\nok\r\nTest restart shared Network ... === TestName: test_restart_network_2_False | Status : SUCCESS ===\r\nok\r\nTest shared network Offering 01 ... SKIP: Skip\r\nTest Shared Network Offering 02 ... SKIP: Skip\r\nTest Shared Network Offering 03 ... SKIP: Skip\r\n\r\n----------------------------------------------------------------------\r\nRan 16 tests in 408.267s\r\n\r\nOK (SKIP=14)","created_at":"2015-03-19T12:13:27Z","updated_at":"2015-03-19T12:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/120/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/120/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/120/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/5b9c889eabc7b37d4d2d7d6b11bd176e0eb71bc1","head":{"label":"gauravaradhye:8336","ref":"8336","sha":"5b9c889eabc7b37d4d2d7d6b11bd176e0eb71bc1","user":{"login":"gauravaradhye","id":4161170,"avatar_url":"https://avatars.githubusercontent.com/u/4161170?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravaradhye","html_url":"https://github.com/gauravaradhye","followers_url":"https://api.github.com/users/gauravaradhye/followers","following_url":"https://api.github.com/users/gauravaradhye/following{/other_user}","gists_url":"https://api.github.com/users/gauravaradhye/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravaradhye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravaradhye/subscriptions","organizations_url":"https://api.github.com/users/gauravaradhye/orgs","repos_url":"https://api.github.com/users/gauravaradhye/repos","events_url":"https://api.github.com/users/gauravaradhye/events{/privacy}","received_events_url":"https://api.github.com/users/gauravaradhye/received_events","type":"User","site_admin":false},"repo":{"id":31648314,"name":"cloudstack","full_name":"gauravaradhye/cloudstack","owner":{"login":"gauravaradhye","id":4161170,"avatar_url":"https://avatars.githubusercontent.com/u/4161170?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravaradhye","html_url":"https://github.com/gauravaradhye","followers_url":"https://api.github.com/users/gauravaradhye/followers","following_url":"https://api.github.com/users/gauravaradhye/following{/other_user}","gists_url":"https://api.github.com/users/gauravaradhye/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravaradhye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravaradhye/subscriptions","organizations_url":"https://api.github.com/users/gauravaradhye/orgs","repos_url":"https://api.github.com/users/gauravaradhye/repos","events_url":"https://api.github.com/users/gauravaradhye/events{/privacy}","received_events_url":"https://api.github.com/users/gauravaradhye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gauravaradhye/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/gauravaradhye/cloudstack","forks_url":"https://api.github.com/repos/gauravaradhye/cloudstack/forks","keys_url":"https://api.github.com/repos/gauravaradhye/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gauravaradhye/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gauravaradhye/cloudstack/teams","hooks_url":"https://api.github.com/repos/gauravaradhye/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/gauravaradhye/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/gauravaradhye/cloudstack/events","assignees_url":"https://api.github.com/repos/gauravaradhye/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/gauravaradhye/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/gauravaradhye/cloudstack/tags","blobs_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gauravaradhye/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/gauravaradhye/cloudstack/languages","stargazers_url":"https://api.github.com/repos/gauravaradhye/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/gauravaradhye/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/gauravaradhye/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/gauravaradhye/cloudstack/subscription","commits_url":"https://api.github.com/repos/gauravaradhye/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/gauravaradhye/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/gauravaradhye/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/gauravaradhye/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/gauravaradhye/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gauravaradhye/cloudstack/merges","archive_url":"https://api.github.com/repos/gauravaradhye/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gauravaradhye/cloudstack/downloads","issues_url":"https://api.github.com/repos/gauravaradhye/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/gauravaradhye/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/gauravaradhye/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/gauravaradhye/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gauravaradhye/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/gauravaradhye/cloudstack/releases{/id}","created_at":"2015-03-04T09:18:12Z","updated_at":"2015-03-12T12:38:51Z","pushed_at":"2015-03-19T12:10:43Z","git_url":"git://github.com/gauravaradhye/cloudstack.git","ssh_url":"git@github.com:gauravaradhye/cloudstack.git","clone_url":"https://github.com/gauravaradhye/cloudstack.git","svn_url":"https://github.com/gauravaradhye/cloudstack","homepage":null,"size":477292,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d7b4a1d8431079297f98ffe940ffcff2bfab0b8d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-03-19T09:21:10Z","pushed_at":"2015-03-19T09:21:10Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":717456,"stargazers_count":218,"watchers_count":218,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":250,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":7,"forks":250,"open_issues":7,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/120"},"html":{"href":"https://github.com/apache/cloudstack/pull/120"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/120"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/5b9c889eabc7b37d4d2d7d6b11bd176e0eb71bc1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":327,"deletions":119,"changed_files":1}}