{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/comments/27439145","id":27439145,"diff_hunk":"@@ -1,11 +1,11 @@\n <j:jelly xmlns:j=\"jelly:core\" xmlns:st=\"jelly:stapler\" xmlns:d=\"jelly:define\" xmlns:l=\"/lib/layout\" xmlns:t=\"/lib/hudson\" xmlns:f=\"/lib/form\">\r\n-\t<f:entry title=\"Copy folder only if the build is successful\">\r\n-\t\t<f:checkbox name=\"synergyPublisher.publish\" value=\"true\" checked=\"${instance.isPublish()}\"/>\r\n+\t<f:entry field=\"publish\">\r\n+\t\t<f:checkbox checked=\"${instance.isPublish()}\" title=\"Copy folder only if the build is successful\"/>\r","path":"src/main/resources/hudson/plugins/synergy/SynergyFolderPublisher/config.jelly","position":5,"original_position":5,"commit_id":"52d1c752e153605ea1e1a9423b626d00ebdcb8ae","original_commit_id":"52d1c752e153605ea1e1a9423b626d00ebdcb8ae","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"`checked` probably gratuitous.","created_at":"2015-03-30T22:43:03Z","updated_at":"2015-03-30T22:43:03Z","html_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13#discussion_r27439145","pull_request_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/comments/27439145"},"html":{"href":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13#discussion_r27439145"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13","id":32092750,"html_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13","diff_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13.diff","patch_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13.patch","issue_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13","number":13,"state":"open","locked":false,"title":"[FIXED JENKINS-27637] Refactor the plugin to use new model field databinding","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"body":"[JENKINS-27637](https://issues.jenkins-ci.org/browse/JENKINS-27637)\r\n\r\nCurrent implementation use Jenkins old style for databinding:\r\n\r\n```\r\n<f:entry title=\"Database\" help=\"/plugin/synergy/database.html\">\r\n\t\t<f:textbox name=\"synergy.database\" value=\"${scm.database}\" />\r\n</f:entry>\r\n```\r\nI just refactored this to use instead field argument:\r\n\r\n```\r\n<f:entry field=\"database\" title=\"Database\" help=\"${descriptor.getHelpFile('database')}\">\r\n\t\t<f:textbox />\r\n\t</f:entry>\r\n```\r\n\r\nAlso deleted all the:\r\n\r\n```\r\npublic Publisher newInstance(StaplerRequest req, JSONObject formData) throws FormException {\r\n...\r\n\r\nThe old databinding style makes not to save some fields correctly in new Jenkins installations.\r\n\r\nWhen this pull request is merged, I will create a new one to update pom.xml to a newer Jenkins version>1.424\r\n\r\n@reviewbybees\r\n@ndeloof\r\n\r\n","created_at":"2015-03-27T09:23:15Z","updated_at":"2015-03-30T22:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb2a7a61794cc2f2011036568b5cee078c3e696d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13/comments","statuses_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/statuses/52d1c752e153605ea1e1a9423b626d00ebdcb8ae","head":{"label":"fbelzunc:JENKINS-27637","ref":"JENKINS-27637","sha":"52d1c752e153605ea1e1a9423b626d00ebdcb8ae","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"repo":{"id":32951806,"name":"synergy_scm-plugin","full_name":"fbelzunc/synergy_scm-plugin","owner":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbelzunc/synergy_scm-plugin","description":"Jenkins synergy_scm plugin","fork":true,"url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin","forks_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/forks","keys_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/teams","hooks_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/hooks","issue_events_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/events","assignees_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/tags","blobs_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/languages","stargazers_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/stargazers","contributors_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/contributors","subscribers_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/subscribers","subscription_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/subscription","commits_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/merges","archive_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/downloads","issues_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fbelzunc/synergy_scm-plugin/releases{/id}","created_at":"2015-03-26T21:03:49Z","updated_at":"2015-03-26T21:03:49Z","pushed_at":"2015-03-30T19:56:23Z","git_url":"git://github.com/fbelzunc/synergy_scm-plugin.git","ssh_url":"git@github.com:fbelzunc/synergy_scm-plugin.git","clone_url":"https://github.com/fbelzunc/synergy_scm-plugin.git","svn_url":"https://github.com/fbelzunc/synergy_scm-plugin","homepage":"http://jenkins-ci.org/","size":246,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"581db6982eaccd46d3eb0474af175fc5c2dcdf96","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163779,"name":"synergy_scm-plugin","full_name":"jenkinsci/synergy_scm-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/synergy_scm-plugin","description":"Jenkins synergy_scm plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin","forks_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/releases{/id}","created_at":"2010-12-13T05:55:25Z","updated_at":"2015-01-24T21:36:43Z","pushed_at":"2015-03-30T19:56:23Z","git_url":"git://github.com/jenkinsci/synergy_scm-plugin.git","ssh_url":"git@github.com:jenkinsci/synergy_scm-plugin.git","clone_url":"https://github.com/jenkinsci/synergy_scm-plugin.git","svn_url":"https://github.com/jenkinsci/synergy_scm-plugin","homepage":"http://jenkins-ci.org/","size":389,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13"},"html":{"href":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13"},"issue":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13"},"comments":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/statuses/52d1c752e153605ea1e1a9423b626d00ebdcb8ae"}}}}