{"action":"created","issue":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5175","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5175/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5175/comments","events_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5175/events","html_url":"https://github.com/OrchardCMS/Orchard/issues/5175","id":69218623,"number":5175,"title":"Change Funcs and Actions to explicit delegate in public interfaces","user":{"login":"Piedone","id":1976647,"avatar_url":"https://avatars.githubusercontent.com/u/1976647?v=3","gravatar_id":"","url":"https://api.github.com/users/Piedone","html_url":"https://github.com/Piedone","followers_url":"https://api.github.com/users/Piedone/followers","following_url":"https://api.github.com/users/Piedone/following{/other_user}","gists_url":"https://api.github.com/users/Piedone/gists{/gist_id}","starred_url":"https://api.github.com/users/Piedone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piedone/subscriptions","organizations_url":"https://api.github.com/users/Piedone/orgs","repos_url":"https://api.github.com/users/Piedone/repos","events_url":"https://api.github.com/users/Piedone/events{/privacy}","received_events_url":"https://api.github.com/users/Piedone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-17T21:14:16Z","updated_at":"2015-04-17T21:37:38Z","closed_at":null,"body":"Having `Func<T1, T2, ...>` or `Action<T1, T2,...˙>` delegates in public interfaces is most of the times confusing, since you don't know the meaning of the arguments. If there is a single output or a single input/output argument, that is most of the time fine, but it's gets really hard to understand once we have three-four type parameters for `Func`.\r\n\r\nE.g. you have to dig through the code to eventually find out that the parameters of the `Func<string, string, string, PlacementInfo>` stored in `BuildShapeContext.FindPlacement` expects `shapeType, differentiator, location`.\r\n\r\nInstead, we could define explicit delegates, e.g. for the above:\r\n\r\n    public delegate PlacementInfo PlacementFinder(string shapeType, string differentiator, string location);\r\n\r\nI'm sure there are similar cases elsewhere too.\r\n\r\nA quite similar issue is #4759."},"comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/comments/94080300","html_url":"https://github.com/OrchardCMS/Orchard/issues/5175#issuecomment-94080300","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5175","id":94080300,"user":{"login":"Piedone","id":1976647,"avatar_url":"https://avatars.githubusercontent.com/u/1976647?v=3","gravatar_id":"","url":"https://api.github.com/users/Piedone","html_url":"https://github.com/Piedone","followers_url":"https://api.github.com/users/Piedone/followers","following_url":"https://api.github.com/users/Piedone/following{/other_user}","gists_url":"https://api.github.com/users/Piedone/gists{/gist_id}","starred_url":"https://api.github.com/users/Piedone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piedone/subscriptions","organizations_url":"https://api.github.com/users/Piedone/orgs","repos_url":"https://api.github.com/users/Piedone/repos","events_url":"https://api.github.com/users/Piedone/events{/privacy}","received_events_url":"https://api.github.com/users/Piedone/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T21:37:38Z","updated_at":"2015-04-17T21:37:38Z","body":"And this makes you wonder why GitHub doesn't have a voting feature for issues. Probably the only aspect in what Codeplex is better :-)."}}