{"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/comments/24303814","id":24303814,"diff_hunk":"@@ -90,13 +90,28 @@\n       return this.classPropertyCache[info.name];\n     }\n \n-    var props = this.serializeObject(_.pick(serializeObject, info.keys));\n+    // :FIXME: Properties should always be resolved on `object`.  This might\n+    // break memoization though.","path":"extension/js/agent/utils/serializeObject.js","position":6,"original_position":6,"commit_id":"b4df1bc09e6ea2814cec3008b3a3a4b691be85e9","original_commit_id":"b4df1bc09e6ea2814cec3008b3a3a4b691be85e9","user":{"login":"jiaweihli","id":351887,"avatar_url":"https://avatars.githubusercontent.com/u/351887?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaweihli","html_url":"https://github.com/jiaweihli","followers_url":"https://api.github.com/users/jiaweihli/followers","following_url":"https://api.github.com/users/jiaweihli/following{/other_user}","gists_url":"https://api.github.com/users/jiaweihli/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaweihli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaweihli/subscriptions","organizations_url":"https://api.github.com/users/jiaweihli/orgs","repos_url":"https://api.github.com/users/jiaweihli/repos","events_url":"https://api.github.com/users/jiaweihli/events{/privacy}","received_events_url":"https://api.github.com/users/jiaweihli/received_events","type":"User","site_admin":false},"body":"Not sure I understand - prototype methods that call `this` should start again at the bottom of the inheritance hierarchy again, right?","created_at":"2015-02-08T23:17:11Z","updated_at":"2015-02-08T23:17:11Z","html_url":"https://github.com/marionettejs/marionette.inspector/pull/229#discussion_r24303814","pull_request_url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/comments/24303814"},"html":{"href":"https://github.com/marionettejs/marionette.inspector/pull/229#discussion_r24303814"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229","id":28580830,"html_url":"https://github.com/marionettejs/marionette.inspector/pull/229","diff_url":"https://github.com/marionettejs/marionette.inspector/pull/229.diff","patch_url":"https://github.com/marionettejs/marionette.inspector/pull/229.patch","issue_url":"https://api.github.com/repos/marionettejs/marionette.inspector/issues/229","number":229,"state":"open","locked":false,"title":"fix(serializeObject): resolve prototype calls","user":{"login":"jiaweihli","id":351887,"avatar_url":"https://avatars.githubusercontent.com/u/351887?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaweihli","html_url":"https://github.com/jiaweihli","followers_url":"https://api.github.com/users/jiaweihli/followers","following_url":"https://api.github.com/users/jiaweihli/following{/other_user}","gists_url":"https://api.github.com/users/jiaweihli/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaweihli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaweihli/subscriptions","organizations_url":"https://api.github.com/users/jiaweihli/orgs","repos_url":"https://api.github.com/users/jiaweihli/repos","events_url":"https://api.github.com/users/jiaweihli/events{/privacy}","received_events_url":"https://api.github.com/users/jiaweihli/received_events","type":"User","site_admin":false},"body":"Methods defined on a prototype can reference `this`, which starts at the\r\nbottom of the hierarchy and attempts to resolve upwards.  However, the\r\ncurrent method of serialization begins resolution at the current\r\nancestor.","created_at":"2015-02-03T19:27:18Z","updated_at":"2015-02-08T23:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80d17efa564c81145ee498c9f777861111ca4b6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229/commits","review_comments_url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229/comments","review_comment_url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/comments/{number}","comments_url":"https://api.github.com/repos/marionettejs/marionette.inspector/issues/229/comments","statuses_url":"https://api.github.com/repos/marionettejs/marionette.inspector/statuses/b4df1bc09e6ea2814cec3008b3a3a4b691be85e9","head":{"label":"jiaweihli:fix-serialization","ref":"fix-serialization","sha":"b4df1bc09e6ea2814cec3008b3a3a4b691be85e9","user":{"login":"jiaweihli","id":351887,"avatar_url":"https://avatars.githubusercontent.com/u/351887?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaweihli","html_url":"https://github.com/jiaweihli","followers_url":"https://api.github.com/users/jiaweihli/followers","following_url":"https://api.github.com/users/jiaweihli/following{/other_user}","gists_url":"https://api.github.com/users/jiaweihli/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaweihli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaweihli/subscriptions","organizations_url":"https://api.github.com/users/jiaweihli/orgs","repos_url":"https://api.github.com/users/jiaweihli/repos","events_url":"https://api.github.com/users/jiaweihli/events{/privacy}","received_events_url":"https://api.github.com/users/jiaweihli/received_events","type":"User","site_admin":false},"repo":{"id":30216632,"name":"marionette.inspector","full_name":"jiaweihli/marionette.inspector","owner":{"login":"jiaweihli","id":351887,"avatar_url":"https://avatars.githubusercontent.com/u/351887?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaweihli","html_url":"https://github.com/jiaweihli","followers_url":"https://api.github.com/users/jiaweihli/followers","following_url":"https://api.github.com/users/jiaweihli/following{/other_user}","gists_url":"https://api.github.com/users/jiaweihli/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaweihli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaweihli/subscriptions","organizations_url":"https://api.github.com/users/jiaweihli/orgs","repos_url":"https://api.github.com/users/jiaweihli/repos","events_url":"https://api.github.com/users/jiaweihli/events{/privacy}","received_events_url":"https://api.github.com/users/jiaweihli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiaweihli/marionette.inspector","description":"Marionette Inspector - Explore your App","fork":true,"url":"https://api.github.com/repos/jiaweihli/marionette.inspector","forks_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/forks","keys_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/teams","hooks_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/hooks","issue_events_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/issues/events{/number}","events_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/events","assignees_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/assignees{/user}","branches_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/branches{/branch}","tags_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/tags","blobs_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/languages","stargazers_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/stargazers","contributors_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/contributors","subscribers_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/subscribers","subscription_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/subscription","commits_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/issues/comments/{number}","contents_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/contents/{+path}","compare_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/merges","archive_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/downloads","issues_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/issues{/number}","pulls_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/labels{/name}","releases_url":"https://api.github.com/repos/jiaweihli/marionette.inspector/releases{/id}","created_at":"2015-02-03T00:32:48Z","updated_at":"2015-02-03T00:32:49Z","pushed_at":"2015-02-03T00:45:57Z","git_url":"git://github.com/jiaweihli/marionette.inspector.git","ssh_url":"git@github.com:jiaweihli/marionette.inspector.git","clone_url":"https://github.com/jiaweihli/marionette.inspector.git","svn_url":"https://github.com/jiaweihli/marionette.inspector","homepage":"http://goo.gl/Wo3pju","size":3346,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:minor","ref":"minor","sha":"d57e02c95518aae004499e79ed97062c3a7a3bec","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":24510199,"name":"marionette.inspector","full_name":"marionettejs/marionette.inspector","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/marionette.inspector","description":"Marionette Inspector - Explore your App","fork":false,"url":"https://api.github.com/repos/marionettejs/marionette.inspector","forks_url":"https://api.github.com/repos/marionettejs/marionette.inspector/forks","keys_url":"https://api.github.com/repos/marionettejs/marionette.inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/marionette.inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/marionette.inspector/teams","hooks_url":"https://api.github.com/repos/marionettejs/marionette.inspector/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/marionette.inspector/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/marionette.inspector/events","assignees_url":"https://api.github.com/repos/marionettejs/marionette.inspector/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/marionette.inspector/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/marionette.inspector/tags","blobs_url":"https://api.github.com/repos/marionettejs/marionette.inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/marionette.inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/marionette.inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/marionette.inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/marionette.inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/marionette.inspector/languages","stargazers_url":"https://api.github.com/repos/marionettejs/marionette.inspector/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/marionette.inspector/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/marionette.inspector/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/marionette.inspector/subscription","commits_url":"https://api.github.com/repos/marionettejs/marionette.inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/marionette.inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/marionette.inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/marionette.inspector/issues/comments/{number}","contents_url":"https://api.github.com/repos/marionettejs/marionette.inspector/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/marionette.inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/marionette.inspector/merges","archive_url":"https://api.github.com/repos/marionettejs/marionette.inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/marionette.inspector/downloads","issues_url":"https://api.github.com/repos/marionettejs/marionette.inspector/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/marionette.inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/marionette.inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/marionette.inspector/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/marionette.inspector/releases{/id}","created_at":"2014-09-26T18:13:02Z","updated_at":"2015-02-08T18:34:56Z","pushed_at":"2015-02-08T18:34:56Z","git_url":"git://github.com/marionettejs/marionette.inspector.git","ssh_url":"git@github.com:marionettejs/marionette.inspector.git","clone_url":"https://github.com/marionettejs/marionette.inspector.git","svn_url":"https://github.com/marionettejs/marionette.inspector","homepage":"http://goo.gl/Wo3pju","size":3346,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":51,"forks":26,"open_issues":51,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229"},"html":{"href":"https://github.com/marionettejs/marionette.inspector/pull/229"},"issue":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/issues/229"},"comments":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/marionette.inspector/statuses/b4df1bc09e6ea2814cec3008b3a3a4b691be85e9"}}}}