{"action":"created","comment":{"url":"https://api.github.com/repos/namely/connect/pulls/comments/36221521","id":36221521,"diff_hunk":"@@ -0,0 +1,366 @@\n+[","path":"spec/fixtures/api_responses/net_suite_employees.json","position":1,"original_position":1,"commit_id":"8cc5e7a670d5189fc2c3e773d003c3f19bd02e9e","original_commit_id":"45e6169fa8b4ae75917e8333a5eda691be4b5059","user":{"login":"base10","id":26247,"avatar_url":"https://avatars.githubusercontent.com/u/26247?v=3","gravatar_id":"","url":"https://api.github.com/users/base10","html_url":"https://github.com/base10","followers_url":"https://api.github.com/users/base10/followers","following_url":"https://api.github.com/users/base10/following{/other_user}","gists_url":"https://api.github.com/users/base10/gists{/gist_id}","starred_url":"https://api.github.com/users/base10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/base10/subscriptions","organizations_url":"https://api.github.com/users/base10/orgs","repos_url":"https://api.github.com/users/base10/repos","events_url":"https://api.github.com/users/base10/events{/privacy}","received_events_url":"https://api.github.com/users/base10/received_events","type":"User","site_admin":false},"body":"I'm fine with trimming with what's in the file. \r\n\r\nIf I follow the second recommendation, is that in place of using the fixture file altogether or treating it like we would a factory where you get default info, but to avoid Mystery Guests, you specify what you're expecting to see?","created_at":"2015-08-04T18:09:19Z","updated_at":"2015-08-04T18:09:19Z","html_url":"https://github.com/namely/connect/pull/162#discussion_r36221521","pull_request_url":"https://api.github.com/repos/namely/connect/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/namely/connect/pulls/comments/36221521"},"html":{"href":"https://github.com/namely/connect/pull/162#discussion_r36221521"},"pull_request":{"href":"https://api.github.com/repos/namely/connect/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/namely/connect/pulls/162","id":41585131,"html_url":"https://github.com/namely/connect/pull/162","diff_url":"https://github.com/namely/connect/pull/162.diff","patch_url":"https://github.com/namely/connect/pull/162.patch","issue_url":"https://api.github.com/repos/namely/connect/issues/162","number":162,"state":"open","locked":false,"title":"Contact NetSuite, get a list of employees, determine profile fields","user":{"login":"base10","id":26247,"avatar_url":"https://avatars.githubusercontent.com/u/26247?v=3","gravatar_id":"","url":"https://api.github.com/users/base10","html_url":"https://github.com/base10","followers_url":"https://api.github.com/users/base10/followers","following_url":"https://api.github.com/users/base10/following{/other_user}","gists_url":"https://api.github.com/users/base10/gists{/gist_id}","starred_url":"https://api.github.com/users/base10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/base10/subscriptions","organizations_url":"https://api.github.com/users/base10/orgs","repos_url":"https://api.github.com/users/base10/repos","events_url":"https://api.github.com/users/base10/events{/privacy}","received_events_url":"https://api.github.com/users/base10/received_events","type":"User","site_admin":false},"body":"* NetSuite, through Cloud Elements, doesn't have a way to directly list\r\n  what fields are available on profiles\r\n* We want to get a full list of available fields for each integration\r\n* Introduces NetSuite::EmployeeField\r\n* Created fro NetSuite::Client#profile_fields\r\n* We aren't storing the information, but making it available when field\r\n  mappings between Namely and NetSuite are edited\r\n* This does not yet handle custom fields, since those are going to be\r\n  more complex\r\n* Since we don't want to count on Employee ids within NetSuite, we\r\n  request 5 employees, since that's the smallest window allowed for\r\n  getting a list of employees\r\n* Matches, where it can, the types of fields that we support in Namely\r\n  for mapping\r\n  * date\r\n  * text\r\n  * email\r\n* Also identifies other types that we don't yet handle in Namely for\r\n  mapping\r\n  * boolean\r\n  * fixnum\r\n  * object\r\n* The names for the non-supported field types may change\r\n* NetSuite::Client#profile_fields just hands back a list of\r\n  NetSuite::EmployeeField objects and presumes supported type filtering\r\n  is handled downstream\r\n* For: https://trello.com/c/mThbJz4M/","created_at":"2015-08-04T15:49:04Z","updated_at":"2015-08-04T18:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee9e5d06b902187da374b2f8276a566010466371","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/namely/connect/pulls/162/commits","review_comments_url":"https://api.github.com/repos/namely/connect/pulls/162/comments","review_comment_url":"https://api.github.com/repos/namely/connect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/namely/connect/issues/162/comments","statuses_url":"https://api.github.com/repos/namely/connect/statuses/8cc5e7a670d5189fc2c3e773d003c3f19bd02e9e","head":{"label":"namely:nlw-netsuite-employee-profile-retrieval","ref":"nlw-netsuite-employee-profile-retrieval","sha":"8cc5e7a670d5189fc2c3e773d003c3f19bd02e9e","user":{"login":"namely","id":1004321,"avatar_url":"https://avatars.githubusercontent.com/u/1004321?v=3","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"repo":{"id":26101808,"name":"connect","full_name":"namely/connect","owner":{"login":"namely","id":1004321,"avatar_url":"https://avatars.githubusercontent.com/u/1004321?v=3","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/namely/connect","description":"Namely Connect – Integrations with the Namely HRIS System.","fork":false,"url":"https://api.github.com/repos/namely/connect","forks_url":"https://api.github.com/repos/namely/connect/forks","keys_url":"https://api.github.com/repos/namely/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namely/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namely/connect/teams","hooks_url":"https://api.github.com/repos/namely/connect/hooks","issue_events_url":"https://api.github.com/repos/namely/connect/issues/events{/number}","events_url":"https://api.github.com/repos/namely/connect/events","assignees_url":"https://api.github.com/repos/namely/connect/assignees{/user}","branches_url":"https://api.github.com/repos/namely/connect/branches{/branch}","tags_url":"https://api.github.com/repos/namely/connect/tags","blobs_url":"https://api.github.com/repos/namely/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namely/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namely/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/namely/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namely/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/namely/connect/languages","stargazers_url":"https://api.github.com/repos/namely/connect/stargazers","contributors_url":"https://api.github.com/repos/namely/connect/contributors","subscribers_url":"https://api.github.com/repos/namely/connect/subscribers","subscription_url":"https://api.github.com/repos/namely/connect/subscription","commits_url":"https://api.github.com/repos/namely/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/namely/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/namely/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/namely/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/namely/connect/contents/{+path}","compare_url":"https://api.github.com/repos/namely/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namely/connect/merges","archive_url":"https://api.github.com/repos/namely/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namely/connect/downloads","issues_url":"https://api.github.com/repos/namely/connect/issues{/number}","pulls_url":"https://api.github.com/repos/namely/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/namely/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/namely/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namely/connect/labels{/name}","releases_url":"https://api.github.com/repos/namely/connect/releases{/id}","created_at":"2014-11-03T03:10:16Z","updated_at":"2015-07-29T20:15:07Z","pushed_at":"2015-08-04T18:03:52Z","git_url":"git://github.com/namely/connect.git","ssh_url":"git@github.com:namely/connect.git","clone_url":"https://github.com/namely/connect.git","svn_url":"https://github.com/namely/connect","homepage":"","size":4946,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"namely:master","ref":"master","sha":"d931b762c5478bcbe5adcc822e9d6b1bd6136345","user":{"login":"namely","id":1004321,"avatar_url":"https://avatars.githubusercontent.com/u/1004321?v=3","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"repo":{"id":26101808,"name":"connect","full_name":"namely/connect","owner":{"login":"namely","id":1004321,"avatar_url":"https://avatars.githubusercontent.com/u/1004321?v=3","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/namely/connect","description":"Namely Connect – Integrations with the Namely HRIS System.","fork":false,"url":"https://api.github.com/repos/namely/connect","forks_url":"https://api.github.com/repos/namely/connect/forks","keys_url":"https://api.github.com/repos/namely/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namely/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namely/connect/teams","hooks_url":"https://api.github.com/repos/namely/connect/hooks","issue_events_url":"https://api.github.com/repos/namely/connect/issues/events{/number}","events_url":"https://api.github.com/repos/namely/connect/events","assignees_url":"https://api.github.com/repos/namely/connect/assignees{/user}","branches_url":"https://api.github.com/repos/namely/connect/branches{/branch}","tags_url":"https://api.github.com/repos/namely/connect/tags","blobs_url":"https://api.github.com/repos/namely/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namely/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namely/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/namely/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namely/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/namely/connect/languages","stargazers_url":"https://api.github.com/repos/namely/connect/stargazers","contributors_url":"https://api.github.com/repos/namely/connect/contributors","subscribers_url":"https://api.github.com/repos/namely/connect/subscribers","subscription_url":"https://api.github.com/repos/namely/connect/subscription","commits_url":"https://api.github.com/repos/namely/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/namely/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/namely/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/namely/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/namely/connect/contents/{+path}","compare_url":"https://api.github.com/repos/namely/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namely/connect/merges","archive_url":"https://api.github.com/repos/namely/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namely/connect/downloads","issues_url":"https://api.github.com/repos/namely/connect/issues{/number}","pulls_url":"https://api.github.com/repos/namely/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/namely/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/namely/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namely/connect/labels{/name}","releases_url":"https://api.github.com/repos/namely/connect/releases{/id}","created_at":"2014-11-03T03:10:16Z","updated_at":"2015-07-29T20:15:07Z","pushed_at":"2015-08-04T18:03:52Z","git_url":"git://github.com/namely/connect.git","ssh_url":"git@github.com:namely/connect.git","clone_url":"https://github.com/namely/connect.git","svn_url":"https://github.com/namely/connect","homepage":"","size":4946,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/namely/connect/pulls/162"},"html":{"href":"https://github.com/namely/connect/pull/162"},"issue":{"href":"https://api.github.com/repos/namely/connect/issues/162"},"comments":{"href":"https://api.github.com/repos/namely/connect/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/namely/connect/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/namely/connect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/namely/connect/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/namely/connect/statuses/8cc5e7a670d5189fc2c3e773d003c3f19bd02e9e"}}}}