{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/38639668","id":38639668,"diff_hunk":"@@ -1,7 +0,0 @@\n-module Katello\n-  class MarketingProduct < Product","path":"app/models/katello/marketing_product.rb","position":2,"original_position":2,"commit_id":"ea47edfc6328b0483868be84525ed08d8800537e","original_commit_id":"ea47edfc6328b0483868be84525ed08d8800537e","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"Does this table need to be dropped?","created_at":"2015-09-03T12:26:11Z","updated_at":"2015-09-03T12:26:11Z","html_url":"https://github.com/Katello/katello/pull/5446#discussion_r38639668","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/5446","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/38639668"},"html":{"href":"https://github.com/Katello/katello/pull/5446#discussion_r38639668"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/5446"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/5446","id":43643744,"html_url":"https://github.com/Katello/katello/pull/5446","diff_url":"https://github.com/Katello/katello/pull/5446.diff","patch_url":"https://github.com/Katello/katello/pull/5446.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/5446","number":5446,"state":"open","locked":false,"title":"[DO NOT MERGE] Fixes #7891 - Convert Pools/Subscriptions from Elastic Search to the …","user":{"login":"johnpmitsch","id":5964462,"avatar_url":"https://avatars.githubusercontent.com/u/5964462?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"body":"…database\r\n\r\nOpening this up for initial review. This covers adding subscriptions to the database and converting to scoped search on subscriptions/pools.\r\n \r\nhere is what is left to-do\r\n- [x] Create Migration and Models\r\n- [x] Update AR relationships\r\n- [x] Importing data from candlepin\r\n- [x] Add importing data to re-index\r\n- [x] Update API\r\n- [x] Import/delete data on importing/deleting a manifest, candlepin events, and adding and removing from activation keys.\r\n- [x] Implement scoped search in the UI\r\n- [ ] Refactor broken tests\r\n- [ ] Write tests for new functionality\r\n- [ ] Clean up\r\n\r\nIssues that need to be resolved\r\n- [x] Adding and removing subscriptions from content hosts functioning but with errors.\r\n- [ ] Autocomplete not showing in UI for activation keys and content hosts\r\n- [ ] Subscription type attribute isn't loading in the UI\r\n- [ ] Subscription table in add and list/remove to activation key isn't showing any message when blank\r\n\r\n","created_at":"2015-08-28T16:02:47Z","updated_at":"2015-09-03T12:26:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2936e19464f3b96ede785ac0554d65dc9a925cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/5446/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/5446/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/5446/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/ea47edfc6328b0483868be84525ed08d8800537e","head":{"label":"johnpmitsch:subscriptions","ref":"subscriptions","sha":"ea47edfc6328b0483868be84525ed08d8800537e","user":{"login":"johnpmitsch","id":5964462,"avatar_url":"https://avatars.githubusercontent.com/u/5964462?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"repo":{"id":35971034,"name":"katello","full_name":"johnpmitsch/katello","owner":{"login":"johnpmitsch","id":5964462,"avatar_url":"https://avatars.githubusercontent.com/u/5964462?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnpmitsch/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/johnpmitsch/katello","forks_url":"https://api.github.com/repos/johnpmitsch/katello/forks","keys_url":"https://api.github.com/repos/johnpmitsch/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnpmitsch/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnpmitsch/katello/teams","hooks_url":"https://api.github.com/repos/johnpmitsch/katello/hooks","issue_events_url":"https://api.github.com/repos/johnpmitsch/katello/issues/events{/number}","events_url":"https://api.github.com/repos/johnpmitsch/katello/events","assignees_url":"https://api.github.com/repos/johnpmitsch/katello/assignees{/user}","branches_url":"https://api.github.com/repos/johnpmitsch/katello/branches{/branch}","tags_url":"https://api.github.com/repos/johnpmitsch/katello/tags","blobs_url":"https://api.github.com/repos/johnpmitsch/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnpmitsch/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnpmitsch/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnpmitsch/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnpmitsch/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/johnpmitsch/katello/languages","stargazers_url":"https://api.github.com/repos/johnpmitsch/katello/stargazers","contributors_url":"https://api.github.com/repos/johnpmitsch/katello/contributors","subscribers_url":"https://api.github.com/repos/johnpmitsch/katello/subscribers","subscription_url":"https://api.github.com/repos/johnpmitsch/katello/subscription","commits_url":"https://api.github.com/repos/johnpmitsch/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnpmitsch/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnpmitsch/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnpmitsch/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnpmitsch/katello/contents/{+path}","compare_url":"https://api.github.com/repos/johnpmitsch/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnpmitsch/katello/merges","archive_url":"https://api.github.com/repos/johnpmitsch/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnpmitsch/katello/downloads","issues_url":"https://api.github.com/repos/johnpmitsch/katello/issues{/number}","pulls_url":"https://api.github.com/repos/johnpmitsch/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/johnpmitsch/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/johnpmitsch/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnpmitsch/katello/labels{/name}","releases_url":"https://api.github.com/repos/johnpmitsch/katello/releases{/id}","created_at":"2015-05-20T19:57:53Z","updated_at":"2015-05-20T19:58:01Z","pushed_at":"2015-09-02T20:49:36Z","git_url":"git://github.com/johnpmitsch/katello.git","ssh_url":"git@github.com:johnpmitsch/katello.git","clone_url":"https://github.com/johnpmitsch/katello.git","svn_url":"https://github.com/johnpmitsch/katello","homepage":"katello.org","size":73284,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"c5ad085466a87e2ccdfe5d7173d96efcc21265a7","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","created_at":"2012-04-12T16:59:08Z","updated_at":"2015-08-13T18:20:46Z","pushed_at":"2015-09-02T22:44:20Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":237850,"stargazers_count":168,"watchers_count":168,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":94,"forks":113,"open_issues":94,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/5446"},"html":{"href":"https://github.com/Katello/katello/pull/5446"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/5446"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/5446/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/5446/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/5446/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/ea47edfc6328b0483868be84525ed08d8800537e"}}}}