{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/23486665","id":23486665,"diff_hunk":"@@ -67,7 +67,7 @@ namespace tables {\n \n /// Helper alias for TablePlugin names.\n typedef const std::string TableName;\n-typedef const std::vector<std::pair<std::string, std::string> > TableColumns;\n+typedef std::vector<std::pair<std::string, std::string> > TableColumns;","path":"include/osquery/tables.h","position":14,"original_position":14,"commit_id":"62a6018b4c0fb2f4516fca56a6a3125d17f74706","original_commit_id":"62a6018b4c0fb2f4516fca56a6a3125d17f74706","user":{"login":"zwass","id":575602,"avatar_url":"https://avatars.githubusercontent.com/u/575602?v=3","gravatar_id":"","url":"https://api.github.com/users/zwass","html_url":"https://github.com/zwass","followers_url":"https://api.github.com/users/zwass/followers","following_url":"https://api.github.com/users/zwass/following{/other_user}","gists_url":"https://api.github.com/users/zwass/gists{/gist_id}","starred_url":"https://api.github.com/users/zwass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwass/subscriptions","organizations_url":"https://api.github.com/users/zwass/orgs","repos_url":"https://api.github.com/users/zwass/repos","events_url":"https://api.github.com/users/zwass/events{/privacy}","received_events_url":"https://api.github.com/users/zwass/received_events","type":"User","site_admin":false},"body":"I needed to remove the `const` on this to use it in the `getQueryColumns` function. I added a `const` in the only place I could find the type used in non-generated code.","created_at":"2015-01-23T22:53:17Z","updated_at":"2015-01-23T22:53:17Z","html_url":"https://github.com/facebook/osquery/pull/670#discussion_r23486665","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/670","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/23486665"},"html":{"href":"https://github.com/facebook/osquery/pull/670#discussion_r23486665"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/670"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/670","id":27896248,"html_url":"https://github.com/facebook/osquery/pull/670","diff_url":"https://github.com/facebook/osquery/pull/670.diff","patch_url":"https://github.com/facebook/osquery/pull/670.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/670","number":670,"state":"open","locked":false,"title":"Add getQueryColumns function to core","user":{"login":"zwass","id":575602,"avatar_url":"https://avatars.githubusercontent.com/u/575602?v=3","gravatar_id":"","url":"https://api.github.com/users/zwass","html_url":"https://github.com/zwass","followers_url":"https://api.github.com/users/zwass/followers","following_url":"https://api.github.com/users/zwass/following{/other_user}","gists_url":"https://api.github.com/users/zwass/gists{/gist_id}","starred_url":"https://api.github.com/users/zwass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwass/subscriptions","organizations_url":"https://api.github.com/users/zwass/orgs","repos_url":"https://api.github.com/users/zwass/repos","events_url":"https://api.github.com/users/zwass/events{/privacy}","received_events_url":"https://api.github.com/users/zwass/received_events","type":"User","site_admin":false},"body":"This new getQueryColumns function allows us to determine what columns\nwill be returned by executing a given query. It is intended to be used\nwith the distributed query system, to determine a schema for the\nresults before sending the query.\n\nTested by unit tests. Also used valgrind and did not find errors that\nlooked related to this change (though there appear to be many errors\nrelated to glog logging).","created_at":"2015-01-23T02:11:24Z","updated_at":"2015-01-23T22:53:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41242e53eb04fd0d3a676bc674123d58bd62fc44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/670/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/670/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/670/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/62a6018b4c0fb2f4516fca56a6a3125d17f74706","head":{"label":"zwass:query_columns","ref":"query_columns","sha":"62a6018b4c0fb2f4516fca56a6a3125d17f74706","user":{"login":"zwass","id":575602,"avatar_url":"https://avatars.githubusercontent.com/u/575602?v=3","gravatar_id":"","url":"https://api.github.com/users/zwass","html_url":"https://github.com/zwass","followers_url":"https://api.github.com/users/zwass/followers","following_url":"https://api.github.com/users/zwass/following{/other_user}","gists_url":"https://api.github.com/users/zwass/gists{/gist_id}","starred_url":"https://api.github.com/users/zwass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwass/subscriptions","organizations_url":"https://api.github.com/users/zwass/orgs","repos_url":"https://api.github.com/users/zwass/repos","events_url":"https://api.github.com/users/zwass/events{/privacy}","received_events_url":"https://api.github.com/users/zwass/received_events","type":"User","site_admin":false},"repo":{"id":25948693,"name":"osquery","full_name":"zwass/osquery","owner":{"login":"zwass","id":575602,"avatar_url":"https://avatars.githubusercontent.com/u/575602?v=3","gravatar_id":"","url":"https://api.github.com/users/zwass","html_url":"https://github.com/zwass","followers_url":"https://api.github.com/users/zwass/followers","following_url":"https://api.github.com/users/zwass/following{/other_user}","gists_url":"https://api.github.com/users/zwass/gists{/gist_id}","starred_url":"https://api.github.com/users/zwass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwass/subscriptions","organizations_url":"https://api.github.com/users/zwass/orgs","repos_url":"https://api.github.com/users/zwass/repos","events_url":"https://api.github.com/users/zwass/events{/privacy}","received_events_url":"https://api.github.com/users/zwass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zwass/osquery","description":"Operating system instrumentation and monitoring","fork":true,"url":"https://api.github.com/repos/zwass/osquery","forks_url":"https://api.github.com/repos/zwass/osquery/forks","keys_url":"https://api.github.com/repos/zwass/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zwass/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zwass/osquery/teams","hooks_url":"https://api.github.com/repos/zwass/osquery/hooks","issue_events_url":"https://api.github.com/repos/zwass/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/zwass/osquery/events","assignees_url":"https://api.github.com/repos/zwass/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/zwass/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/zwass/osquery/tags","blobs_url":"https://api.github.com/repos/zwass/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zwass/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zwass/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/zwass/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zwass/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/zwass/osquery/languages","stargazers_url":"https://api.github.com/repos/zwass/osquery/stargazers","contributors_url":"https://api.github.com/repos/zwass/osquery/contributors","subscribers_url":"https://api.github.com/repos/zwass/osquery/subscribers","subscription_url":"https://api.github.com/repos/zwass/osquery/subscription","commits_url":"https://api.github.com/repos/zwass/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/zwass/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/zwass/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/zwass/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/zwass/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/zwass/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zwass/osquery/merges","archive_url":"https://api.github.com/repos/zwass/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zwass/osquery/downloads","issues_url":"https://api.github.com/repos/zwass/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/zwass/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/zwass/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/zwass/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zwass/osquery/labels{/name}","releases_url":"https://api.github.com/repos/zwass/osquery/releases{/id}","created_at":"2014-10-30T01:07:36Z","updated_at":"2015-01-22T17:17:48Z","pushed_at":"2015-01-23T22:51:32Z","git_url":"git://github.com/zwass/osquery.git","ssh_url":"git@github.com:zwass/osquery.git","clone_url":"https://github.com/zwass/osquery.git","svn_url":"https://github.com/zwass/osquery","homepage":"http://osquery.io","size":4053,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"803e72563a9b3548c3cba681433a68fb99ec29d1","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2015-01-23T17:47:02Z","pushed_at":"2015-01-22T22:01:56Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"http://osquery.io","size":10648,"stargazers_count":3527,"watchers_count":3527,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":241,"mirror_url":null,"open_issues_count":19,"forks":241,"open_issues":19,"watchers":3527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/670"},"html":{"href":"https://github.com/facebook/osquery/pull/670"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/670"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/62a6018b4c0fb2f4516fca56a6a3125d17f74706"}}}}