{"action":"created","issue":{"url":"https://api.github.com/repos/tumblr/TMCache/issues/71","labels_url":"https://api.github.com/repos/tumblr/TMCache/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/tumblr/TMCache/issues/71/comments","events_url":"https://api.github.com/repos/tumblr/TMCache/issues/71/events","html_url":"https://github.com/tumblr/TMCache/pull/71","id":50881339,"number":71,"title":"Fix deadlocking issues in TMMemoryCache related to thread starvation","user":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tumblr/TMCache/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2014-12-03T19:31:57Z","updated_at":"2015-03-03T14:34:08Z","closed_at":"2015-02-13T01:15:36Z","pull_request":{"url":"https://api.github.com/repos/tumblr/TMCache/pulls/71","html_url":"https://github.com/tumblr/TMCache/pull/71","diff_url":"https://github.com/tumblr/TMCache/pull/71.diff","patch_url":"https://github.com/tumblr/TMCache/pull/71.patch"},"body":"1. Re-architected everything to be synchronous by default and asynchronous methods are simply wrapped versions of the synchronous ones.\r\n2. Changed TMMemoryCache to use pthread_locks instead of dispatch_queues to protect resources (this is where we lose our performance, context switching is faster than locks).\r\n3. Added an integration test which shows the deadlocking (but passes with the above changes).\r\n\r\nThis results in a slight performance degradation, but it resolves deadlocking issues. Would love to get feedback on this or hear other ideas for resolving the issue."},"comment":{"url":"https://api.github.com/repos/tumblr/TMCache/issues/comments/76955820","html_url":"https://github.com/tumblr/TMCache/pull/71#issuecomment-76955820","issue_url":"https://api.github.com/repos/tumblr/TMCache/issues/71","id":76955820,"user":{"login":"irace","id":399560,"avatar_url":"https://avatars.githubusercontent.com/u/399560?v=3","gravatar_id":"","url":"https://api.github.com/users/irace","html_url":"https://github.com/irace","followers_url":"https://api.github.com/users/irace/followers","following_url":"https://api.github.com/users/irace/following{/other_user}","gists_url":"https://api.github.com/users/irace/gists{/gist_id}","starred_url":"https://api.github.com/users/irace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irace/subscriptions","organizations_url":"https://api.github.com/users/irace/orgs","repos_url":"https://api.github.com/users/irace/repos","events_url":"https://api.github.com/users/irace/events{/privacy}","received_events_url":"https://api.github.com/users/irace/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T14:34:08Z","updated_at":"2015-03-03T14:34:08Z","body":"@garrettmoon Ping! :smile: "}}