{"action":"created","issue":{"url":"https://api.github.com/repos/magit/magit/issues/1891","labels_url":"https://api.github.com/repos/magit/magit/issues/1891/labels{/name}","comments_url":"https://api.github.com/repos/magit/magit/issues/1891/comments","events_url":"https://api.github.com/repos/magit/magit/issues/1891/events","html_url":"https://github.com/magit/magit/issues/1891","id":84111360,"number":1891,"title":"Selected region adds one extra pixel at top and bottom","user":{"login":"wasamasa","id":3588994,"avatar_url":"https://avatars.githubusercontent.com/u/3588994?v=3","gravatar_id":"","url":"https://api.github.com/users/wasamasa","html_url":"https://github.com/wasamasa","followers_url":"https://api.github.com/users/wasamasa/followers","following_url":"https://api.github.com/users/wasamasa/following{/other_user}","gists_url":"https://api.github.com/users/wasamasa/gists{/gist_id}","starred_url":"https://api.github.com/users/wasamasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasamasa/subscriptions","organizations_url":"https://api.github.com/users/wasamasa/orgs","repos_url":"https://api.github.com/users/wasamasa/repos","events_url":"https://api.github.com/users/wasamasa/events{/privacy}","received_events_url":"https://api.github.com/users/wasamasa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magit/magit/labels/00%20bug","name":"00 bug","color":"e10c02"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/magit/magit/milestones/5","html_url":"https://github.com/magit/magit/milestones/2.1.0","labels_url":"https://api.github.com/repos/magit/magit/milestones/5/labels","id":336392,"number":5,"title":"2.1.0","description":"","creator":{"login":"tarsius","id":25046,"avatar_url":"https://avatars.githubusercontent.com/u/25046?v=3","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1281,"state":"closed","created_at":"2013-05-18T00:36:03Z","updated_at":"2015-07-10T10:44:32Z","due_on":"2015-06-30T22:00:00Z","closed_at":"2015-07-08T13:10:17Z"},"comments":9,"created_at":"2015-06-02T17:09:32Z","updated_at":"2015-08-03T13:30:46Z","closed_at":"2015-06-02T20:21:36Z","body":"If I select a region with the mouse in my changes, I can see two lines with 1px height at top and bottom which makes for a sort of neat effect, but introduces some visual artefacts. The most obvious one is that once the region goes beyond the changes, I get the regular region face instead of the overlay (?) applied on it. The other one is that movement of the region end makes the text \"wobble\" as it gets moved up and down around the borders.\r\n\r\nJudging by the sources this is the fault of `magit-diff-update-hunk-region`. I wonder why this experimental looking approach was chosen and why just using a face with the box property and a value of -1 to make the border point *inwards* (which avoids the text wobbling) wasn't considered. Another problem of it is that it works even worse in the terminal as the 1px high lines are turned into full-height lines which are even more intrusive than the old approach to this. Using a regular face would allow to make use of this gimmick in non-textual Emacs instances only."},"comment":{"url":"https://api.github.com/repos/magit/magit/issues/comments/127234008","html_url":"https://github.com/magit/magit/issues/1891#issuecomment-127234008","issue_url":"https://api.github.com/repos/magit/magit/issues/1891","id":127234008,"user":{"login":"npostavs","id":287742,"avatar_url":"https://avatars.githubusercontent.com/u/287742?v=3","gravatar_id":"","url":"https://api.github.com/users/npostavs","html_url":"https://github.com/npostavs","followers_url":"https://api.github.com/users/npostavs/followers","following_url":"https://api.github.com/users/npostavs/following{/other_user}","gists_url":"https://api.github.com/users/npostavs/gists{/gist_id}","starred_url":"https://api.github.com/users/npostavs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npostavs/subscriptions","organizations_url":"https://api.github.com/users/npostavs/orgs","repos_url":"https://api.github.com/users/npostavs/repos","events_url":"https://api.github.com/users/npostavs/events{/privacy}","received_events_url":"https://api.github.com/users/npostavs/received_events","type":"User","site_admin":false},"created_at":"2015-08-03T13:30:46Z","updated_at":"2015-08-03T13:30:46Z","body":"The `line-height` property applies to the newline\r\n\r\nhttp://www.gnu.org/software/emacs/manual/html_node/elisp/Line-Height.html\r\n\r\n>   A newline can have a ‘line-height’ text or overlay property that\r\ncontrols the total height of the display line ending in that newline.\r\n>\r\n>   If the property value is ‘t’, the newline character has no effect on\r\nthe displayed height of the line—the visible contents alone determine\r\nthe height."}}