{"action":"created","comment":{"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments/45552408","id":45552408,"diff_hunk":"@@ -17,6 +17,14 @@ class BatteryStateOfChargeService : public I_BatteryStateOfChargeService\n private:\n     // Convention is to have an _ after private members\n     const double initialStateOfChargePercent_;\n-\n+    double AvgCurrent;\n+    double initialCurrent;\n+    double changeTime;\n+    QTime prevTime;\n+    QTime currentTime;\n+    double AmpHours;\n+    double Current;","path":"src/BatteryStateOfChargeService.h","position":11,"original_position":11,"commit_id":"45c9e984dcc07b8288ae97a2ba6b152c6bfa6aef","original_commit_id":"45c9e984dcc07b8288ae97a2ba6b152c6bfa6aef","user":{"login":"enochtsang","id":9893396,"avatar_url":"https://avatars.githubusercontent.com/u/9893396?v=3","gravatar_id":"","url":"https://api.github.com/users/enochtsang","html_url":"https://github.com/enochtsang","followers_url":"https://api.github.com/users/enochtsang/followers","following_url":"https://api.github.com/users/enochtsang/following{/other_user}","gists_url":"https://api.github.com/users/enochtsang/gists{/gist_id}","starred_url":"https://api.github.com/users/enochtsang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enochtsang/subscriptions","organizations_url":"https://api.github.com/users/enochtsang/orgs","repos_url":"https://api.github.com/users/enochtsang/repos","events_url":"https://api.github.com/users/enochtsang/events{/privacy}","received_events_url":"https://api.github.com/users/enochtsang/received_events","type":"User","site_admin":false},"body":"You label the current time with `current` which is good, descriptive and I understand right away. This variable `Current` could use a prefix too, I wouldn't suggest `current` like you used for  `currentTime` (for obvious reasons).\r\n\r\nLikewise, because you used `prev` for `prevTime`, following the same naming for `initialCurrent` would be better.","created_at":"2015-11-21T23:22:48Z","updated_at":"2015-11-21T23:22:48Z","html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/10#discussion_r45552408","pull_request_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments/45552408"},"html":{"href":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/10#discussion_r45552408"},"pull_request":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10","id":51445934,"html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/10","diff_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/10.diff","patch_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/10.patch","issue_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/10","number":10,"state":"open","locked":false,"title":"Davis roman","user":{"login":"DavisRomn","id":15066667,"avatar_url":"https://avatars.githubusercontent.com/u/15066667?v=3","gravatar_id":"","url":"https://api.github.com/users/DavisRomn","html_url":"https://github.com/DavisRomn","followers_url":"https://api.github.com/users/DavisRomn/followers","following_url":"https://api.github.com/users/DavisRomn/following{/other_user}","gists_url":"https://api.github.com/users/DavisRomn/gists{/gist_id}","starred_url":"https://api.github.com/users/DavisRomn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavisRomn/subscriptions","organizations_url":"https://api.github.com/users/DavisRomn/orgs","repos_url":"https://api.github.com/users/DavisRomn/repos","events_url":"https://api.github.com/users/DavisRomn/events{/privacy}","received_events_url":"https://api.github.com/users/DavisRomn/received_events","type":"User","site_admin":false},"body":"Finished up and Fixed Errors","created_at":"2015-11-21T17:42:29Z","updated_at":"2015-11-21T23:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8367f3108d0a8cb66cdb45b352f9fb549886c01c","assignee":{"login":"enochtsang","id":9893396,"avatar_url":"https://avatars.githubusercontent.com/u/9893396?v=3","gravatar_id":"","url":"https://api.github.com/users/enochtsang","html_url":"https://github.com/enochtsang","followers_url":"https://api.github.com/users/enochtsang/followers","following_url":"https://api.github.com/users/enochtsang/following{/other_user}","gists_url":"https://api.github.com/users/enochtsang/gists{/gist_id}","starred_url":"https://api.github.com/users/enochtsang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enochtsang/subscriptions","organizations_url":"https://api.github.com/users/enochtsang/orgs","repos_url":"https://api.github.com/users/enochtsang/repos","events_url":"https://api.github.com/users/enochtsang/events{/privacy}","received_events_url":"https://api.github.com/users/enochtsang/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10/commits","review_comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10/comments","review_comment_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/10/comments","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/45c9e984dcc07b8288ae97a2ba6b152c6bfa6aef","head":{"label":"UCSolarCarTeam:Davis_Roman","ref":"Davis_Roman","sha":"45c9e984dcc07b8288ae97a2ba6b152c6bfa6aef","user":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":44296946,"name":"UofCSolarRecruitTraining","full_name":"UCSolarCarTeam/UofCSolarRecruitTraining","owner":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","description":"Intro project to learn c++ and QT","fork":false,"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining","forks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/forks","keys_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/teams","hooks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/hooks","issue_events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/events{/number}","events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/events","assignees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/assignees{/user}","branches_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/branches{/branch}","tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/tags","blobs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/languages","stargazers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/stargazers","contributors_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contributors","subscribers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscribers","subscription_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscription","commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contents/{+path}","compare_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/merges","archive_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/downloads","issues_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues{/number}","pulls_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/labels{/name}","releases_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/releases{/id}","created_at":"2015-10-15T06:02:46Z","updated_at":"2015-10-18T02:26:51Z","pushed_at":"2015-11-21T23:19:19Z","git_url":"git://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","ssh_url":"git@github.com:UCSolarCarTeam/UofCSolarRecruitTraining.git","clone_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","svn_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"UCSolarCarTeam:master","ref":"master","sha":"c529b5ff3eb30b76753996ad77d5ab1b1cb2ac2e","user":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":44296946,"name":"UofCSolarRecruitTraining","full_name":"UCSolarCarTeam/UofCSolarRecruitTraining","owner":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","description":"Intro project to learn c++ and QT","fork":false,"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining","forks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/forks","keys_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/teams","hooks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/hooks","issue_events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/events{/number}","events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/events","assignees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/assignees{/user}","branches_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/branches{/branch}","tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/tags","blobs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/languages","stargazers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/stargazers","contributors_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contributors","subscribers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscribers","subscription_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscription","commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contents/{+path}","compare_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/merges","archive_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/downloads","issues_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues{/number}","pulls_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/labels{/name}","releases_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/releases{/id}","created_at":"2015-10-15T06:02:46Z","updated_at":"2015-10-18T02:26:51Z","pushed_at":"2015-11-21T23:19:19Z","git_url":"git://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","ssh_url":"git@github.com:UCSolarCarTeam/UofCSolarRecruitTraining.git","clone_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","svn_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10"},"html":{"href":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/10"},"issue":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/10"},"comments":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/45c9e984dcc07b8288ae97a2ba6b152c6bfa6aef"}}}}