{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/340","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/340/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/340/events","html_url":"https://github.com/apache/cloudstack/pull/340","id":83479865,"number":340,"title":"CLOUDSTACK-8530: KVM hosts without active agents should be in Disconnected state","user":{"login":"bhaisaab","id":95203,"avatar_url":"https://avatars.githubusercontent.com/u/95203?v=3","gravatar_id":"","url":"https://api.github.com/users/bhaisaab","html_url":"https://github.com/bhaisaab","followers_url":"https://api.github.com/users/bhaisaab/followers","following_url":"https://api.github.com/users/bhaisaab/following{/other_user}","gists_url":"https://api.github.com/users/bhaisaab/gists{/gist_id}","starred_url":"https://api.github.com/users/bhaisaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhaisaab/subscriptions","organizations_url":"https://api.github.com/users/bhaisaab/orgs","repos_url":"https://api.github.com/users/bhaisaab/repos","events_url":"https://api.github.com/users/bhaisaab/events{/privacy}","received_events_url":"https://api.github.com/users/bhaisaab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-01T12:59:22Z","updated_at":"2015-06-01T19:51:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/340","html_url":"https://github.com/apache/cloudstack/pull/340","diff_url":"https://github.com/apache/cloudstack/pull/340.diff","patch_url":"https://github.com/apache/cloudstack/pull/340.patch"},"body":"KVM hosts which are up but their agents are shutdown should be put\r\nin disconnected state. This would avoid getting the VMs HA'd and other commands\r\nsuch as deploying a VM will exclude that host and save us from errors.\r\n\r\nThe improvement is that, we first try to contact the KVM host itself. If it fails\r\nwe assume that it's disconnected, and then ask its KVM neighbours if they can\r\ncheck its status. If all of the KVM neighbours tell us that it's Down and we're\r\nunable to reach the KVM host, then the host is possibly down. In case any of the\r\nKVM neighbours tell us that it's Up but we're unable to reach the KVM host then\r\nwe can be sure that the agent is offline but the host is running."},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/107684409","html_url":"https://github.com/apache/cloudstack/pull/340#issuecomment-107684409","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/340","id":107684409,"user":{"login":"mlsorensen","id":1047709,"avatar_url":"https://avatars.githubusercontent.com/u/1047709?v=3","gravatar_id":"","url":"https://api.github.com/users/mlsorensen","html_url":"https://github.com/mlsorensen","followers_url":"https://api.github.com/users/mlsorensen/followers","following_url":"https://api.github.com/users/mlsorensen/following{/other_user}","gists_url":"https://api.github.com/users/mlsorensen/gists{/gist_id}","starred_url":"https://api.github.com/users/mlsorensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlsorensen/subscriptions","organizations_url":"https://api.github.com/users/mlsorensen/orgs","repos_url":"https://api.github.com/users/mlsorensen/repos","events_url":"https://api.github.com/users/mlsorensen/events{/privacy}","received_events_url":"https://api.github.com/users/mlsorensen/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T19:51:30Z","updated_at":"2015-06-01T19:51:30Z","body":"Looks fine to me.\n\nOn Mon, Jun 1, 2015 at 12:13 PM, Rohit Yadav <notifications@github.com>\nwrote:\n\n> pinging KVM and HA gurus to help review this @kishankavala\n> <https://github.com/kishankavala> @wilderrodrigues\n> <https://github.com/wilderrodrigues> @remibergsma\n> <https://github.com/remibergsma> @mlsorensen\n> <https://github.com/mlsorensen> @abhinandanprateek\n> <https://github.com/abhinandanprateek> @devdeep\n> <https://github.com/devdeep> and others\n> thanks :)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/apache/cloudstack/pull/340#issuecomment-107674771>.\n>\n"}}