{"action":"closed","number":3151,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/3151","id":43732057,"html_url":"https://github.com/juju/juju/pull/3151","diff_url":"https://github.com/juju/juju/pull/3151.diff","patch_url":"https://github.com/juju/juju/pull/3151.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/3151","number":3151,"state":"closed","locked":false,"title":"State: separate collections for LastLogin and LastConnection","user":{"login":"waigani","id":33275,"avatar_url":"https://avatars.githubusercontent.com/u/33275?v=3","gravatar_id":"","url":"https://api.github.com/users/waigani","html_url":"https://github.com/waigani","followers_url":"https://api.github.com/users/waigani/followers","following_url":"https://api.github.com/users/waigani/following{/other_user}","gists_url":"https://api.github.com/users/waigani/gists{/gist_id}","starred_url":"https://api.github.com/users/waigani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waigani/subscriptions","organizations_url":"https://api.github.com/users/waigani/orgs","repos_url":"https://api.github.com/users/waigani/repos","events_url":"https://api.github.com/users/waigani/events{/privacy}","received_events_url":"https://api.github.com/users/waigani/received_events","type":"User","site_admin":false},"body":"Separate out LastLogin from the userDoc into it's own collection.\r\nOperate directly on docs in this collection without using txns. Do the\r\nsame for LastConnection in the envUserDoc. No tests where added as\r\nexisting behaviour should remain the same and is already covered.\r\n\r\nThis branch was previously reviewed, merged and reverted due to an \r\nupgrade error. This is a resubmission with the fix to that error. The fix \r\n(and only new code) is: state/upgrades.go:1612-1630\n\n(Review request: http://reviews.vapour.ws/r/2529/)","created_at":"2015-08-31T05:01:07Z","updated_at":"2015-08-31T08:29:50Z","closed_at":"2015-08-31T08:29:50Z","merged_at":"2015-08-31T08:29:50Z","merge_commit_sha":"4bbdfef4098b93a6d2ade2e7a698169f6819732c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/3151/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/3151/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/3151/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/39e77cf9ad3b3785d6e91e20093c33b5e2f7cf03","head":{"label":"waigani:last-conn-fix","ref":"last-conn-fix","sha":"39e77cf9ad3b3785d6e91e20093c33b5e2f7cf03","user":{"login":"waigani","id":33275,"avatar_url":"https://avatars.githubusercontent.com/u/33275?v=3","gravatar_id":"","url":"https://api.github.com/users/waigani","html_url":"https://github.com/waigani","followers_url":"https://api.github.com/users/waigani/followers","following_url":"https://api.github.com/users/waigani/following{/other_user}","gists_url":"https://api.github.com/users/waigani/gists{/gist_id}","starred_url":"https://api.github.com/users/waigani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waigani/subscriptions","organizations_url":"https://api.github.com/users/waigani/orgs","repos_url":"https://api.github.com/users/waigani/repos","events_url":"https://api.github.com/users/waigani/events{/privacy}","received_events_url":"https://api.github.com/users/waigani/received_events","type":"User","site_admin":false},"repo":{"id":20465970,"name":"juju","full_name":"waigani/juju","owner":{"login":"waigani","id":33275,"avatar_url":"https://avatars.githubusercontent.com/u/33275?v=3","gravatar_id":"","url":"https://api.github.com/users/waigani","html_url":"https://github.com/waigani","followers_url":"https://api.github.com/users/waigani/followers","following_url":"https://api.github.com/users/waigani/following{/other_user}","gists_url":"https://api.github.com/users/waigani/gists{/gist_id}","starred_url":"https://api.github.com/users/waigani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waigani/subscriptions","organizations_url":"https://api.github.com/users/waigani/orgs","repos_url":"https://api.github.com/users/waigani/repos","events_url":"https://api.github.com/users/waigani/events{/privacy}","received_events_url":"https://api.github.com/users/waigani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waigani/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/waigani/juju","forks_url":"https://api.github.com/repos/waigani/juju/forks","keys_url":"https://api.github.com/repos/waigani/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waigani/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waigani/juju/teams","hooks_url":"https://api.github.com/repos/waigani/juju/hooks","issue_events_url":"https://api.github.com/repos/waigani/juju/issues/events{/number}","events_url":"https://api.github.com/repos/waigani/juju/events","assignees_url":"https://api.github.com/repos/waigani/juju/assignees{/user}","branches_url":"https://api.github.com/repos/waigani/juju/branches{/branch}","tags_url":"https://api.github.com/repos/waigani/juju/tags","blobs_url":"https://api.github.com/repos/waigani/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waigani/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waigani/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/waigani/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waigani/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/waigani/juju/languages","stargazers_url":"https://api.github.com/repos/waigani/juju/stargazers","contributors_url":"https://api.github.com/repos/waigani/juju/contributors","subscribers_url":"https://api.github.com/repos/waigani/juju/subscribers","subscription_url":"https://api.github.com/repos/waigani/juju/subscription","commits_url":"https://api.github.com/repos/waigani/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/waigani/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/waigani/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/waigani/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/waigani/juju/contents/{+path}","compare_url":"https://api.github.com/repos/waigani/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waigani/juju/merges","archive_url":"https://api.github.com/repos/waigani/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waigani/juju/downloads","issues_url":"https://api.github.com/repos/waigani/juju/issues{/number}","pulls_url":"https://api.github.com/repos/waigani/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/waigani/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/waigani/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waigani/juju/labels{/name}","releases_url":"https://api.github.com/repos/waigani/juju/releases{/id}","created_at":"2014-06-04T01:27:31Z","updated_at":"2015-05-03T23:15:37Z","pushed_at":"2015-08-31T07:59:29Z","git_url":"git://github.com/waigani/juju.git","ssh_url":"git@github.com:waigani/juju.git","clone_url":"https://github.com/waigani/juju.git","svn_url":"https://github.com/waigani/juju","homepage":null,"size":59294,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"bab1210065a472a6e54d4491f9d11f9a123d6403","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2015-08-30T09:47:49Z","pushed_at":"2015-08-31T08:29:50Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":94396,"stargazers_count":313,"watchers_count":313,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":79,"forks":105,"open_issues":79,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/3151"},"html":{"href":"https://github.com/juju/juju/pull/3151"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/3151"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/3151/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/3151/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/3151/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/39e77cf9ad3b3785d6e91e20093c33b5e2f7cf03"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?v=3","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":714,"deletions":204,"changed_files":25}}