{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/47287324","id":47287324,"diff_hunk":"@@ -96,31 +98,41 @@ func ensureKubeE2EPrivilegedSA() {\n \t\tif err != nil {\n \t\t\tFatalErr(err)\n \t\t}\n-\t\tpriv, err := c.SecurityContextConstraints().Get(\"privileged\")\n-\t\tif err != nil {\n-\t\t\tif apierrs.IsNotFound(err) {\n-\t\t\t\treturn\n-\t\t\t}\n-\t\t\tFatalErr(err)\n-\t\t}\n \t\tnamespaces, err := c.Namespaces().List(labels.Everything(), fields.Everything())\n \t\tif err != nil {\n \t\t\tFatalErr(err)\n \t\t}\n-\t\tgroups := []string{}\n-\t\tfor _, name := range priv.Groups {\n-\t\t\tif !strings.Contains(name, \"e2e-\") {\n-\t\t\t\tgroups = append(groups, name)\n-\t\t\t}\n+\t\taddE2EServiceAccountsToSCC(c, namespaces, \"privileged\")","path":"test/extended/util/test.go","position":39,"original_position":39,"commit_id":"face0e3fe75466c00230c481362e0824287d0d05","original_commit_id":"face0e3fe75466c00230c481362e0824287d0d05","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"better comments:\r\n```\r\n// add to the \"privileged\" scc to ensure pods that explicitly request extra capabilities are not rejected\r\naddE2EServiceAccountsToSCC(c, namespaces, \"privileged\")\r\n// add to the \"anyuid\" scc to ensure pods that don't specify a uid don't get forced into a range (mimics upstream behavior)\r\naddE2EServiceAccountsToSCC(c, namespaces, \"anyuid\")\r\n```","created_at":"2015-12-10T21:18:59Z","updated_at":"2015-12-10T21:18:59Z","html_url":"https://github.com/openshift/origin/pull/6264#discussion_r47287324","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6264","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/47287324"},"html":{"href":"https://github.com/openshift/origin/pull/6264#discussion_r47287324"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6264"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6264","id":53313839,"html_url":"https://github.com/openshift/origin/pull/6264","diff_url":"https://github.com/openshift/origin/pull/6264.diff","patch_url":"https://github.com/openshift/origin/pull/6264.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6264","number":6264,"state":"open","locked":false,"title":"Fix replication controller usage in kube e2e tests","user":{"login":"marun","id":451477,"avatar_url":"https://avatars.githubusercontent.com/u/451477?v=3","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"body":"Some kube e2e tests (e.g. the one for NodePort services) use replication\r\ncontrollers to launch containers that require anyuid.  To enable this,\r\nthe test project service accounts need to be added to the anyuid scc.","created_at":"2015-12-10T20:43:14Z","updated_at":"2015-12-10T21:18:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"713a357b84f0a37ac60bd52ba63f069d9e089d5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6264/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6264/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6264/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/face0e3fe75466c00230c481362e0824287d0d05","head":{"label":"marun:fix-kube-e2e-rc","ref":"fix-kube-e2e-rc","sha":"face0e3fe75466c00230c481362e0824287d0d05","user":{"login":"marun","id":451477,"avatar_url":"https://avatars.githubusercontent.com/u/451477?v=3","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"repo":{"id":36902865,"name":"origin","full_name":"marun/origin","owner":{"login":"marun","id":451477,"avatar_url":"https://avatars.githubusercontent.com/u/451477?v=3","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marun/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/marun/origin","forks_url":"https://api.github.com/repos/marun/origin/forks","keys_url":"https://api.github.com/repos/marun/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marun/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marun/origin/teams","hooks_url":"https://api.github.com/repos/marun/origin/hooks","issue_events_url":"https://api.github.com/repos/marun/origin/issues/events{/number}","events_url":"https://api.github.com/repos/marun/origin/events","assignees_url":"https://api.github.com/repos/marun/origin/assignees{/user}","branches_url":"https://api.github.com/repos/marun/origin/branches{/branch}","tags_url":"https://api.github.com/repos/marun/origin/tags","blobs_url":"https://api.github.com/repos/marun/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marun/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marun/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/marun/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marun/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/marun/origin/languages","stargazers_url":"https://api.github.com/repos/marun/origin/stargazers","contributors_url":"https://api.github.com/repos/marun/origin/contributors","subscribers_url":"https://api.github.com/repos/marun/origin/subscribers","subscription_url":"https://api.github.com/repos/marun/origin/subscription","commits_url":"https://api.github.com/repos/marun/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/marun/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/marun/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/marun/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/marun/origin/contents/{+path}","compare_url":"https://api.github.com/repos/marun/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marun/origin/merges","archive_url":"https://api.github.com/repos/marun/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marun/origin/downloads","issues_url":"https://api.github.com/repos/marun/origin/issues{/number}","pulls_url":"https://api.github.com/repos/marun/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/marun/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/marun/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marun/origin/labels{/name}","releases_url":"https://api.github.com/repos/marun/origin/releases{/id}","created_at":"2015-06-05T00:21:35Z","updated_at":"2015-06-05T00:21:38Z","pushed_at":"2015-12-10T20:42:50Z","git_url":"git://github.com/marun/origin.git","ssh_url":"git@github.com:marun/origin.git","clone_url":"https://github.com/marun/origin.git","svn_url":"https://github.com/marun/origin","homepage":"http://www.openshift.org","size":177932,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d59fe3cc8acbacd48772e38cc8cdcf21720ac150","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-12-10T17:41:06Z","pushed_at":"2015-12-10T21:15:20Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":226717,"stargazers_count":860,"watchers_count":860,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":540,"mirror_url":null,"open_issues_count":727,"forks":540,"open_issues":727,"watchers":860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6264"},"html":{"href":"https://github.com/openshift/origin/pull/6264"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6264"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6264/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6264/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6264/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/face0e3fe75466c00230c481362e0824287d0d05"}}}}