{"action":"created","issue":{"url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/35","labels_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/35/comments","events_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/35/events","html_url":"https://github.com/adobe-type-tools/afdko/issues/35","id":57383633,"number":35,"title":"cvXX featureNames yields corrupt binary code","user":{"login":"adrientetar","id":1250894,"avatar_url":"https://avatars.githubusercontent.com/u/1250894?v=3","gravatar_id":"","url":"https://api.github.com/users/adrientetar","html_url":"https://github.com/adrientetar","followers_url":"https://api.github.com/users/adrientetar/followers","following_url":"https://api.github.com/users/adrientetar/following{/other_user}","gists_url":"https://api.github.com/users/adrientetar/gists{/gist_id}","starred_url":"https://api.github.com/users/adrientetar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrientetar/subscriptions","organizations_url":"https://api.github.com/users/adrientetar/orgs","repos_url":"https://api.github.com/users/adrientetar/repos","events_url":"https://api.github.com/users/adrientetar/events{/privacy}","received_events_url":"https://api.github.com/users/adrientetar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-02-11T21:56:38Z","updated_at":"2015-02-11T22:49:41Z","closed_at":null,"body":"I tried to add featureNames to my cvXX features in the same way it is done with ssXX, here is a sample code:\r\n\r\n~~~\r\nfeature cv01 {\r\n    featureNames {\r\n        name \"Superscript \\00AE\"; # Windows English\r\n        name 1 0 0 \"Superscript \\A8\"; # Mac English\r\n        name 3 1 0x040c \"\\00AE \\00E0 l\\2019exposant\"; # Windows French\r\n        name 1 0 1 \"\\A8 \\88 l\\D5exposant\"; # Mac French\r\n    };\r\n    [...]\r\n}\r\n~~~\r\n\r\nThe AFDKO gives no warning or error whatsoever yet ttx decompilation errors:\r\n\r\n~~~\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/__init__.py\", line 391, in __getitem__\r\n             table.decompile(data, self)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 44, in decompile\r\n             self.table.decompile(reader, font)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 568, in decompile\r\n             table[conv.name] = conv.read(reader, font, table)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otConverters.py\", line 245, in read\r\n             table.decompile(reader, font)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 563, in decompile\r\n             l.append(conv.read(reader, font, table))\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otConverters.py\", line 182, in read\r\n             table.decompile(reader, font)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 568, in decompile\r\n             table[conv.name] = conv.read(reader, font, table)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otConverters.py\", line 245, in read\r\n             table.decompile(reader, font)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 568, in decompile\r\n             table[conv.name] = conv.read(reader, font, table)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otConverters.py\", line 245, in read\r\n             table.decompile(reader, font)\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 563, in decompile\r\n             l.append(conv.read(reader, font, table))\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otConverters.py\", line 141, in read\r\n             return reader.readUInt24()\r\n           File \"/home/adrien/bin/FDK/Tools/linux/Python/lib/python2.7/site-packages/FontTools/fontTools/ttLib/tables/otBase.py\", line 162, in readUInt24\r\n             value, = struct.unpack(\"&gt;l\", b'\\0'+self.data[pos:newpos])\r\n         error: unpack requires a string argument of length 4\r\n~~~\r\n\r\nI may or may not be using wrong syntax or whatnot (I did not find relevant documentation on Adobe's website) but in any case, I don't think that the compiler should pull off what seems to be an alignment error in the generated code.\r\n\r\ncc @TiroTypeworks"},"comment":{"url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/comments/73982177","html_url":"https://github.com/adobe-type-tools/afdko/issues/35#issuecomment-73982177","issue_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/35","id":73982177,"user":{"login":"adrientetar","id":1250894,"avatar_url":"https://avatars.githubusercontent.com/u/1250894?v=3","gravatar_id":"","url":"https://api.github.com/users/adrientetar","html_url":"https://github.com/adrientetar","followers_url":"https://api.github.com/users/adrientetar/followers","following_url":"https://api.github.com/users/adrientetar/following{/other_user}","gists_url":"https://api.github.com/users/adrientetar/gists{/gist_id}","starred_url":"https://api.github.com/users/adrientetar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrientetar/subscriptions","organizations_url":"https://api.github.com/users/adrientetar/orgs","repos_url":"https://api.github.com/users/adrientetar/repos","events_url":"https://api.github.com/users/adrientetar/events{/privacy}","received_events_url":"https://api.github.com/users/adrientetar/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T22:49:41Z","updated_at":"2015-02-11T22:49:41Z","body":"Ah, I thought that by definitions you meant code in the AFDKO.\r\n\r\n> Currently a definition of use is provided only for the GPOS 'size' feature, and the GSUB stylistic alternates feature.\r\n\r\nWell, as I see it cvXX has a FeatureParams definition in the otspec that says how the various strings are used for a UI, what makes it so that it has no definition of use?"}}