{"action":"created","comment":{"url":"https://api.github.com/repos/scalingdata/Impala/pulls/comments/40575119","id":40575119,"diff_hunk":"@@ -0,0 +1,225 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+// Copied from:\n+//   https://github.com/apache/hadoop/blob/release-2.7.1/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/exception.c\n+// We need Hadoop 2.7 for Hortonworks HDP support, but libhdfs no longer exports\n+// getJNIEnv so we have to copy some source files like this to Impala. ROCANA-3465","path":"be/src/util/exception.c","position":22,"original_position":22,"commit_id":"533a7d65dfdf17ec1ce9c38116e3cb64ab8e6304","original_commit_id":"533a7d65dfdf17ec1ce9c38116e3cb64ab8e6304","user":{"login":"bradcupit","id":106213,"avatar_url":"https://avatars.githubusercontent.com/u/106213?v=3","gravatar_id":"","url":"https://api.github.com/users/bradcupit","html_url":"https://github.com/bradcupit","followers_url":"https://api.github.com/users/bradcupit/followers","following_url":"https://api.github.com/users/bradcupit/following{/other_user}","gists_url":"https://api.github.com/users/bradcupit/gists{/gist_id}","starred_url":"https://api.github.com/users/bradcupit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradcupit/subscriptions","organizations_url":"https://api.github.com/users/bradcupit/orgs","repos_url":"https://api.github.com/users/bradcupit/repos","events_url":"https://api.github.com/users/bradcupit/events{/privacy}","received_events_url":"https://api.github.com/users/bradcupit/received_events","type":"User","site_admin":false},"body":"Good question.\r\nIn the commit comment I mention which files did not change, meaning they were an exact duplicate of the HDFS files. The other files differ from HDFS, but only slightly. They had more functions than we needed so I did not pull all the functions in. I also adjusted the `#include`s.\r\n\r\nWe could put this as comments in the source files, but that documentation could get stale over time as we edit the files. On the other hand, maybe we'll never edit them.\r\n\r\nSo, any preference on how we document this?","created_at":"2015-09-28T16:47:55Z","updated_at":"2015-09-28T16:47:55Z","html_url":"https://github.com/scalingdata/Impala/pull/3#discussion_r40575119","pull_request_url":"https://api.github.com/repos/scalingdata/Impala/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/scalingdata/Impala/pulls/comments/40575119"},"html":{"href":"https://github.com/scalingdata/Impala/pull/3#discussion_r40575119"},"pull_request":{"href":"https://api.github.com/repos/scalingdata/Impala/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/scalingdata/Impala/pulls/3","id":46071840,"html_url":"https://github.com/scalingdata/Impala/pull/3","diff_url":"https://github.com/scalingdata/Impala/pull/3.diff","patch_url":"https://github.com/scalingdata/Impala/pull/3.patch","issue_url":"https://api.github.com/repos/scalingdata/Impala/issues/3","number":3,"state":"open","locked":false,"title":"ROCANA-3465 Get Impala C++ compiling against HDP libraries","user":{"login":"bradcupit","id":106213,"avatar_url":"https://avatars.githubusercontent.com/u/106213?v=3","gravatar_id":"","url":"https://api.github.com/users/bradcupit","html_url":"https://github.com/bradcupit","followers_url":"https://api.github.com/users/bradcupit/followers","following_url":"https://api.github.com/users/bradcupit/following{/other_user}","gists_url":"https://api.github.com/users/bradcupit/gists{/gist_id}","starred_url":"https://api.github.com/users/bradcupit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradcupit/subscriptions","organizations_url":"https://api.github.com/users/bradcupit/orgs","repos_url":"https://api.github.com/users/bradcupit/repos","events_url":"https://api.github.com/users/bradcupit/events{/privacy}","received_events_url":"https://api.github.com/users/bradcupit/received_events","type":"User","site_admin":false},"body":"The code in this commit is copied from https://github.com/apache/hadoop/tree/release-2.7.1/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs","created_at":"2015-09-26T01:04:14Z","updated_at":"2015-09-28T16:47:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4900109d03c1fe891e482d11c9f42a2eadf3eeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scalingdata/Impala/pulls/3/commits","review_comments_url":"https://api.github.com/repos/scalingdata/Impala/pulls/3/comments","review_comment_url":"https://api.github.com/repos/scalingdata/Impala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalingdata/Impala/issues/3/comments","statuses_url":"https://api.github.com/repos/scalingdata/Impala/statuses/533a7d65dfdf17ec1ce9c38116e3cb64ab8e6304","head":{"label":"scalingdata:ROCANA-3465","ref":"ROCANA-3465","sha":"533a7d65dfdf17ec1ce9c38116e3cb64ab8e6304","user":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"repo":{"id":41750127,"name":"Impala","full_name":"scalingdata/Impala","owner":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalingdata/Impala","description":"Real-time Query for Hadoop","fork":true,"url":"https://api.github.com/repos/scalingdata/Impala","forks_url":"https://api.github.com/repos/scalingdata/Impala/forks","keys_url":"https://api.github.com/repos/scalingdata/Impala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalingdata/Impala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalingdata/Impala/teams","hooks_url":"https://api.github.com/repos/scalingdata/Impala/hooks","issue_events_url":"https://api.github.com/repos/scalingdata/Impala/issues/events{/number}","events_url":"https://api.github.com/repos/scalingdata/Impala/events","assignees_url":"https://api.github.com/repos/scalingdata/Impala/assignees{/user}","branches_url":"https://api.github.com/repos/scalingdata/Impala/branches{/branch}","tags_url":"https://api.github.com/repos/scalingdata/Impala/tags","blobs_url":"https://api.github.com/repos/scalingdata/Impala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalingdata/Impala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalingdata/Impala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalingdata/Impala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalingdata/Impala/statuses/{sha}","languages_url":"https://api.github.com/repos/scalingdata/Impala/languages","stargazers_url":"https://api.github.com/repos/scalingdata/Impala/stargazers","contributors_url":"https://api.github.com/repos/scalingdata/Impala/contributors","subscribers_url":"https://api.github.com/repos/scalingdata/Impala/subscribers","subscription_url":"https://api.github.com/repos/scalingdata/Impala/subscription","commits_url":"https://api.github.com/repos/scalingdata/Impala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalingdata/Impala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalingdata/Impala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalingdata/Impala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalingdata/Impala/contents/{+path}","compare_url":"https://api.github.com/repos/scalingdata/Impala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalingdata/Impala/merges","archive_url":"https://api.github.com/repos/scalingdata/Impala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalingdata/Impala/downloads","issues_url":"https://api.github.com/repos/scalingdata/Impala/issues{/number}","pulls_url":"https://api.github.com/repos/scalingdata/Impala/pulls{/number}","milestones_url":"https://api.github.com/repos/scalingdata/Impala/milestones{/number}","notifications_url":"https://api.github.com/repos/scalingdata/Impala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalingdata/Impala/labels{/name}","releases_url":"https://api.github.com/repos/scalingdata/Impala/releases{/id}","created_at":"2015-09-01T16:26:05Z","updated_at":"2015-09-01T16:26:15Z","pushed_at":"2015-09-28T15:07:07Z","git_url":"git://github.com/scalingdata/Impala.git","ssh_url":"git@github.com:scalingdata/Impala.git","clone_url":"https://github.com/scalingdata/Impala.git","svn_url":"https://github.com/scalingdata/Impala","homepage":"http://impala.io","size":4766837,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"cdh5.4.5-rocana1.3.0"}},"base":{"label":"scalingdata:ROCANA-3463","ref":"ROCANA-3463","sha":"596a8b9ab29b47caec3af823924304087dfbf24d","user":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"repo":{"id":41750127,"name":"Impala","full_name":"scalingdata/Impala","owner":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalingdata/Impala","description":"Real-time Query for Hadoop","fork":true,"url":"https://api.github.com/repos/scalingdata/Impala","forks_url":"https://api.github.com/repos/scalingdata/Impala/forks","keys_url":"https://api.github.com/repos/scalingdata/Impala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalingdata/Impala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalingdata/Impala/teams","hooks_url":"https://api.github.com/repos/scalingdata/Impala/hooks","issue_events_url":"https://api.github.com/repos/scalingdata/Impala/issues/events{/number}","events_url":"https://api.github.com/repos/scalingdata/Impala/events","assignees_url":"https://api.github.com/repos/scalingdata/Impala/assignees{/user}","branches_url":"https://api.github.com/repos/scalingdata/Impala/branches{/branch}","tags_url":"https://api.github.com/repos/scalingdata/Impala/tags","blobs_url":"https://api.github.com/repos/scalingdata/Impala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalingdata/Impala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalingdata/Impala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalingdata/Impala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalingdata/Impala/statuses/{sha}","languages_url":"https://api.github.com/repos/scalingdata/Impala/languages","stargazers_url":"https://api.github.com/repos/scalingdata/Impala/stargazers","contributors_url":"https://api.github.com/repos/scalingdata/Impala/contributors","subscribers_url":"https://api.github.com/repos/scalingdata/Impala/subscribers","subscription_url":"https://api.github.com/repos/scalingdata/Impala/subscription","commits_url":"https://api.github.com/repos/scalingdata/Impala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalingdata/Impala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalingdata/Impala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalingdata/Impala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalingdata/Impala/contents/{+path}","compare_url":"https://api.github.com/repos/scalingdata/Impala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalingdata/Impala/merges","archive_url":"https://api.github.com/repos/scalingdata/Impala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalingdata/Impala/downloads","issues_url":"https://api.github.com/repos/scalingdata/Impala/issues{/number}","pulls_url":"https://api.github.com/repos/scalingdata/Impala/pulls{/number}","milestones_url":"https://api.github.com/repos/scalingdata/Impala/milestones{/number}","notifications_url":"https://api.github.com/repos/scalingdata/Impala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalingdata/Impala/labels{/name}","releases_url":"https://api.github.com/repos/scalingdata/Impala/releases{/id}","created_at":"2015-09-01T16:26:05Z","updated_at":"2015-09-01T16:26:15Z","pushed_at":"2015-09-28T15:07:07Z","git_url":"git://github.com/scalingdata/Impala.git","ssh_url":"git@github.com:scalingdata/Impala.git","clone_url":"https://github.com/scalingdata/Impala.git","svn_url":"https://github.com/scalingdata/Impala","homepage":"http://impala.io","size":4766837,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"cdh5.4.5-rocana1.3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/scalingdata/Impala/pulls/3"},"html":{"href":"https://github.com/scalingdata/Impala/pull/3"},"issue":{"href":"https://api.github.com/repos/scalingdata/Impala/issues/3"},"comments":{"href":"https://api.github.com/repos/scalingdata/Impala/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/scalingdata/Impala/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/scalingdata/Impala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalingdata/Impala/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/scalingdata/Impala/statuses/533a7d65dfdf17ec1ce9c38116e3cb64ab8e6304"}}}}