{"action":"created","comment":{"url":"https://api.github.com/repos/danvk/pileup.js/pulls/comments/25026673","id":25026673,"diff_hunk":"@@ -0,0 +1,67 @@\n+/** @flow */","path":"src/readableview.js","position":1,"original_position":1,"commit_id":"a060e41c5852d7392acada019f075b0e26ceee95","original_commit_id":"6509fe23a0acac15e930ab85cfab920189953665","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"body":"The [Google JS Style Guide](https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Naming__body) says:\r\n\r\n> In general, use ... filenameslikethis.js.\r\n> Filenames should be all lowercase in order to avoid confusion on case-sensitive platforms. Filenames should end in .js, and should contain no punctuation except for - or _ (prefer - to _).\r\n\r\nSo it should be either `readableview.js` or `readable-view.js`. Any preference?","created_at":"2015-02-19T21:20:49Z","updated_at":"2015-02-19T21:20:49Z","html_url":"https://github.com/danvk/pileup.js/pull/3#discussion_r25026673","pull_request_url":"https://api.github.com/repos/danvk/pileup.js/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/danvk/pileup.js/pulls/comments/25026673"},"html":{"href":"https://github.com/danvk/pileup.js/pull/3#discussion_r25026673"},"pull_request":{"href":"https://api.github.com/repos/danvk/pileup.js/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/danvk/pileup.js/pulls/3","id":29632185,"html_url":"https://github.com/danvk/pileup.js/pull/3","diff_url":"https://github.com/danvk/pileup.js/pull/3.diff","patch_url":"https://github.com/danvk/pileup.js/pull/3.patch","issue_url":"https://api.github.com/repos/danvk/pileup.js/issues/3","number":3,"state":"open","locked":false,"title":"A 2bit parser with tests using Flow","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"body":"See README.md for details on how to work with this.\r\n\r\nOne notable difference from the organization of CycleDash is that tests are always run in a browser (`grunt test` uses PhantomJS). I think this is the Right Way to do things for a few reasons:\r\n\r\n1. Our JS ultimately runs in a browser, so it makes sense to test it in a browser.\r\n2. We don't have to effectively re-build a browser in our tests by shimming things like the DOM and XMLHttpRequest in node.js. This also means that libraries like jQuery, sinon and D3 will behave more predictably.\r\n3. It will let us do true cross-browser testing, e.g. with [saucelabs](https://saucelabs.com/u/algolia-faux-jax)","created_at":"2015-02-19T17:41:43Z","updated_at":"2015-02-19T21:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7091537313b330b39064b25296dbb392e86a074","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/danvk/pileup.js/pulls/3/commits","review_comments_url":"https://api.github.com/repos/danvk/pileup.js/pulls/3/comments","review_comment_url":"https://api.github.com/repos/danvk/pileup.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/danvk/pileup.js/issues/3/comments","statuses_url":"https://api.github.com/repos/danvk/pileup.js/statuses/a060e41c5852d7392acada019f075b0e26ceee95","head":{"label":"flow","ref":"flow","sha":"a060e41c5852d7392acada019f075b0e26ceee95","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"repo":{"id":29933736,"name":"pileup.js","full_name":"danvk/pileup.js","owner":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danvk/pileup.js","description":"Interactive in-browser track viewer","fork":false,"url":"https://api.github.com/repos/danvk/pileup.js","forks_url":"https://api.github.com/repos/danvk/pileup.js/forks","keys_url":"https://api.github.com/repos/danvk/pileup.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danvk/pileup.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danvk/pileup.js/teams","hooks_url":"https://api.github.com/repos/danvk/pileup.js/hooks","issue_events_url":"https://api.github.com/repos/danvk/pileup.js/issues/events{/number}","events_url":"https://api.github.com/repos/danvk/pileup.js/events","assignees_url":"https://api.github.com/repos/danvk/pileup.js/assignees{/user}","branches_url":"https://api.github.com/repos/danvk/pileup.js/branches{/branch}","tags_url":"https://api.github.com/repos/danvk/pileup.js/tags","blobs_url":"https://api.github.com/repos/danvk/pileup.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danvk/pileup.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danvk/pileup.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/danvk/pileup.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danvk/pileup.js/statuses/{sha}","languages_url":"https://api.github.com/repos/danvk/pileup.js/languages","stargazers_url":"https://api.github.com/repos/danvk/pileup.js/stargazers","contributors_url":"https://api.github.com/repos/danvk/pileup.js/contributors","subscribers_url":"https://api.github.com/repos/danvk/pileup.js/subscribers","subscription_url":"https://api.github.com/repos/danvk/pileup.js/subscription","commits_url":"https://api.github.com/repos/danvk/pileup.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/danvk/pileup.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/danvk/pileup.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/danvk/pileup.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/danvk/pileup.js/contents/{+path}","compare_url":"https://api.github.com/repos/danvk/pileup.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danvk/pileup.js/merges","archive_url":"https://api.github.com/repos/danvk/pileup.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danvk/pileup.js/downloads","issues_url":"https://api.github.com/repos/danvk/pileup.js/issues{/number}","pulls_url":"https://api.github.com/repos/danvk/pileup.js/pulls{/number}","milestones_url":"https://api.github.com/repos/danvk/pileup.js/milestones{/number}","notifications_url":"https://api.github.com/repos/danvk/pileup.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danvk/pileup.js/labels{/name}","releases_url":"https://api.github.com/repos/danvk/pileup.js/releases{/id}","created_at":"2015-01-27T20:36:43Z","updated_at":"2015-01-28T02:45:13Z","pushed_at":"2015-02-19T20:41:25Z","git_url":"git://github.com/danvk/pileup.js.git","ssh_url":"git@github.com:danvk/pileup.js.git","clone_url":"https://github.com/danvk/pileup.js.git","svn_url":"https://github.com/danvk/pileup.js","homepage":null,"size":157,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"master","ref":"master","sha":"b4f31a4684672bb90c857c35c0ef98b6ff041f6f","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"repo":{"id":29933736,"name":"pileup.js","full_name":"danvk/pileup.js","owner":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danvk/pileup.js","description":"Interactive in-browser track viewer","fork":false,"url":"https://api.github.com/repos/danvk/pileup.js","forks_url":"https://api.github.com/repos/danvk/pileup.js/forks","keys_url":"https://api.github.com/repos/danvk/pileup.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danvk/pileup.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danvk/pileup.js/teams","hooks_url":"https://api.github.com/repos/danvk/pileup.js/hooks","issue_events_url":"https://api.github.com/repos/danvk/pileup.js/issues/events{/number}","events_url":"https://api.github.com/repos/danvk/pileup.js/events","assignees_url":"https://api.github.com/repos/danvk/pileup.js/assignees{/user}","branches_url":"https://api.github.com/repos/danvk/pileup.js/branches{/branch}","tags_url":"https://api.github.com/repos/danvk/pileup.js/tags","blobs_url":"https://api.github.com/repos/danvk/pileup.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danvk/pileup.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danvk/pileup.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/danvk/pileup.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danvk/pileup.js/statuses/{sha}","languages_url":"https://api.github.com/repos/danvk/pileup.js/languages","stargazers_url":"https://api.github.com/repos/danvk/pileup.js/stargazers","contributors_url":"https://api.github.com/repos/danvk/pileup.js/contributors","subscribers_url":"https://api.github.com/repos/danvk/pileup.js/subscribers","subscription_url":"https://api.github.com/repos/danvk/pileup.js/subscription","commits_url":"https://api.github.com/repos/danvk/pileup.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/danvk/pileup.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/danvk/pileup.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/danvk/pileup.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/danvk/pileup.js/contents/{+path}","compare_url":"https://api.github.com/repos/danvk/pileup.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danvk/pileup.js/merges","archive_url":"https://api.github.com/repos/danvk/pileup.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danvk/pileup.js/downloads","issues_url":"https://api.github.com/repos/danvk/pileup.js/issues{/number}","pulls_url":"https://api.github.com/repos/danvk/pileup.js/pulls{/number}","milestones_url":"https://api.github.com/repos/danvk/pileup.js/milestones{/number}","notifications_url":"https://api.github.com/repos/danvk/pileup.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danvk/pileup.js/labels{/name}","releases_url":"https://api.github.com/repos/danvk/pileup.js/releases{/id}","created_at":"2015-01-27T20:36:43Z","updated_at":"2015-01-28T02:45:13Z","pushed_at":"2015-02-19T20:41:25Z","git_url":"git://github.com/danvk/pileup.js.git","ssh_url":"git@github.com:danvk/pileup.js.git","clone_url":"https://github.com/danvk/pileup.js.git","svn_url":"https://github.com/danvk/pileup.js","homepage":null,"size":157,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danvk/pileup.js/pulls/3"},"html":{"href":"https://github.com/danvk/pileup.js/pull/3"},"issue":{"href":"https://api.github.com/repos/danvk/pileup.js/issues/3"},"comments":{"href":"https://api.github.com/repos/danvk/pileup.js/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/danvk/pileup.js/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/danvk/pileup.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/danvk/pileup.js/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/danvk/pileup.js/statuses/a060e41c5852d7392acada019f075b0e26ceee95"}}}}