{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/ElMassimo/journeyman/pulls/1","id":40323079,"html_url":"https://github.com/ElMassimo/journeyman/pull/1","diff_url":"https://github.com/ElMassimo/journeyman/pull/1.diff","patch_url":"https://github.com/ElMassimo/journeyman/pull/1.patch","issue_url":"https://api.github.com/repos/ElMassimo/journeyman/issues/1","number":1,"state":"closed","locked":false,"title":"Some thoughts and suggestions!","user":{"login":"maxjacobson","id":1421211,"avatar_url":"https://avatars.githubusercontent.com/u/1421211?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjacobson","html_url":"https://github.com/maxjacobson","followers_url":"https://api.github.com/users/maxjacobson/followers","following_url":"https://api.github.com/users/maxjacobson/following{/other_user}","gists_url":"https://api.github.com/users/maxjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjacobson/subscriptions","organizations_url":"https://api.github.com/users/maxjacobson/orgs","repos_url":"https://api.github.com/users/maxjacobson/repos","events_url":"https://api.github.com/users/maxjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/maxjacobson/received_events","type":"User","site_admin":false},"body":"Hey man!\r\n\r\nMany moons ago you asked me to take a look at the code here and give some thoughts. At the time, I put it on my todo list. @abmcdubb will not be surprised by how long it took me to do this; I have things on there to listen to a podcast she casually mentioned like 4 months ago and get back to her with thoughts on it.\r\n\r\nThe main thing I want is some more helpful exception when trying to use a non-existent factory; I've tripped up on that one and been confused by the error message. The other thing I recommend is raising the minimum ruby version, as the hash syntax isn't compatible with 1.9.3. The rest is miscellaneous thoughts\r\n\r\noh, and I extracted a gem from this: https://github.com/maxjacobson/stub_constant although it's not actually necessary to use here because it turns out you weren't stubbing any constants haha\r\n\r\nthere's a ton of super cool and interesting ruby code in here","created_at":"2015-07-20T04:34:58Z","updated_at":"2015-10-25T23:37:13Z","closed_at":"2015-10-25T23:37:13Z","merged_at":"2015-10-25T23:37:13Z","merge_commit_sha":"17ca773d852ce8f3a9c50b3bb92686811cef66aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ElMassimo/journeyman/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ElMassimo/journeyman/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ElMassimo/journeyman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElMassimo/journeyman/issues/1/comments","statuses_url":"https://api.github.com/repos/ElMassimo/journeyman/statuses/79b8d82ebbf5e4172e9dd426cbbb5bf2c99d5d54","head":{"label":"maxjacobson:mj-review","ref":"mj-review","sha":"79b8d82ebbf5e4172e9dd426cbbb5bf2c99d5d54","user":{"login":"maxjacobson","id":1421211,"avatar_url":"https://avatars.githubusercontent.com/u/1421211?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjacobson","html_url":"https://github.com/maxjacobson","followers_url":"https://api.github.com/users/maxjacobson/followers","following_url":"https://api.github.com/users/maxjacobson/following{/other_user}","gists_url":"https://api.github.com/users/maxjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjacobson/subscriptions","organizations_url":"https://api.github.com/users/maxjacobson/orgs","repos_url":"https://api.github.com/users/maxjacobson/repos","events_url":"https://api.github.com/users/maxjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/maxjacobson/received_events","type":"User","site_admin":false},"repo":{"id":39336649,"name":"journeyman","full_name":"maxjacobson/journeyman","owner":{"login":"maxjacobson","id":1421211,"avatar_url":"https://avatars.githubusercontent.com/u/1421211?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjacobson","html_url":"https://github.com/maxjacobson","followers_url":"https://api.github.com/users/maxjacobson/followers","following_url":"https://api.github.com/users/maxjacobson/following{/other_user}","gists_url":"https://api.github.com/users/maxjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjacobson/subscriptions","organizations_url":"https://api.github.com/users/maxjacobson/orgs","repos_url":"https://api.github.com/users/maxjacobson/repos","events_url":"https://api.github.com/users/maxjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/maxjacobson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxjacobson/journeyman","description":"Let your factories use your business logic, making them flexible and easier to update.","fork":true,"url":"https://api.github.com/repos/maxjacobson/journeyman","forks_url":"https://api.github.com/repos/maxjacobson/journeyman/forks","keys_url":"https://api.github.com/repos/maxjacobson/journeyman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxjacobson/journeyman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxjacobson/journeyman/teams","hooks_url":"https://api.github.com/repos/maxjacobson/journeyman/hooks","issue_events_url":"https://api.github.com/repos/maxjacobson/journeyman/issues/events{/number}","events_url":"https://api.github.com/repos/maxjacobson/journeyman/events","assignees_url":"https://api.github.com/repos/maxjacobson/journeyman/assignees{/user}","branches_url":"https://api.github.com/repos/maxjacobson/journeyman/branches{/branch}","tags_url":"https://api.github.com/repos/maxjacobson/journeyman/tags","blobs_url":"https://api.github.com/repos/maxjacobson/journeyman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxjacobson/journeyman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxjacobson/journeyman/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxjacobson/journeyman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxjacobson/journeyman/statuses/{sha}","languages_url":"https://api.github.com/repos/maxjacobson/journeyman/languages","stargazers_url":"https://api.github.com/repos/maxjacobson/journeyman/stargazers","contributors_url":"https://api.github.com/repos/maxjacobson/journeyman/contributors","subscribers_url":"https://api.github.com/repos/maxjacobson/journeyman/subscribers","subscription_url":"https://api.github.com/repos/maxjacobson/journeyman/subscription","commits_url":"https://api.github.com/repos/maxjacobson/journeyman/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxjacobson/journeyman/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxjacobson/journeyman/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxjacobson/journeyman/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxjacobson/journeyman/contents/{+path}","compare_url":"https://api.github.com/repos/maxjacobson/journeyman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxjacobson/journeyman/merges","archive_url":"https://api.github.com/repos/maxjacobson/journeyman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxjacobson/journeyman/downloads","issues_url":"https://api.github.com/repos/maxjacobson/journeyman/issues{/number}","pulls_url":"https://api.github.com/repos/maxjacobson/journeyman/pulls{/number}","milestones_url":"https://api.github.com/repos/maxjacobson/journeyman/milestones{/number}","notifications_url":"https://api.github.com/repos/maxjacobson/journeyman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxjacobson/journeyman/labels{/name}","releases_url":"https://api.github.com/repos/maxjacobson/journeyman/releases{/id}","created_at":"2015-07-19T14:30:48Z","updated_at":"2015-07-19T14:30:49Z","pushed_at":"2015-07-20T04:31:23Z","git_url":"git://github.com/maxjacobson/journeyman.git","ssh_url":"git@github.com:maxjacobson/journeyman.git","clone_url":"https://github.com/maxjacobson/journeyman.git","svn_url":"https://github.com/maxjacobson/journeyman","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ElMassimo:master","ref":"master","sha":"7c3692432655134b8c95b32db426ada67fe6eb87","user":{"login":"ElMassimo","id":1158253,"avatar_url":"https://avatars.githubusercontent.com/u/1158253?v=3","gravatar_id":"","url":"https://api.github.com/users/ElMassimo","html_url":"https://github.com/ElMassimo","followers_url":"https://api.github.com/users/ElMassimo/followers","following_url":"https://api.github.com/users/ElMassimo/following{/other_user}","gists_url":"https://api.github.com/users/ElMassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/ElMassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElMassimo/subscriptions","organizations_url":"https://api.github.com/users/ElMassimo/orgs","repos_url":"https://api.github.com/users/ElMassimo/repos","events_url":"https://api.github.com/users/ElMassimo/events{/privacy}","received_events_url":"https://api.github.com/users/ElMassimo/received_events","type":"User","site_admin":false},"repo":{"id":23007859,"name":"journeyman","full_name":"ElMassimo/journeyman","owner":{"login":"ElMassimo","id":1158253,"avatar_url":"https://avatars.githubusercontent.com/u/1158253?v=3","gravatar_id":"","url":"https://api.github.com/users/ElMassimo","html_url":"https://github.com/ElMassimo","followers_url":"https://api.github.com/users/ElMassimo/followers","following_url":"https://api.github.com/users/ElMassimo/following{/other_user}","gists_url":"https://api.github.com/users/ElMassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/ElMassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElMassimo/subscriptions","organizations_url":"https://api.github.com/users/ElMassimo/orgs","repos_url":"https://api.github.com/users/ElMassimo/repos","events_url":"https://api.github.com/users/ElMassimo/events{/privacy}","received_events_url":"https://api.github.com/users/ElMassimo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ElMassimo/journeyman","description":"Let your factories use your business logic, making them flexible and easier to update.","fork":false,"url":"https://api.github.com/repos/ElMassimo/journeyman","forks_url":"https://api.github.com/repos/ElMassimo/journeyman/forks","keys_url":"https://api.github.com/repos/ElMassimo/journeyman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElMassimo/journeyman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElMassimo/journeyman/teams","hooks_url":"https://api.github.com/repos/ElMassimo/journeyman/hooks","issue_events_url":"https://api.github.com/repos/ElMassimo/journeyman/issues/events{/number}","events_url":"https://api.github.com/repos/ElMassimo/journeyman/events","assignees_url":"https://api.github.com/repos/ElMassimo/journeyman/assignees{/user}","branches_url":"https://api.github.com/repos/ElMassimo/journeyman/branches{/branch}","tags_url":"https://api.github.com/repos/ElMassimo/journeyman/tags","blobs_url":"https://api.github.com/repos/ElMassimo/journeyman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElMassimo/journeyman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElMassimo/journeyman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElMassimo/journeyman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElMassimo/journeyman/statuses/{sha}","languages_url":"https://api.github.com/repos/ElMassimo/journeyman/languages","stargazers_url":"https://api.github.com/repos/ElMassimo/journeyman/stargazers","contributors_url":"https://api.github.com/repos/ElMassimo/journeyman/contributors","subscribers_url":"https://api.github.com/repos/ElMassimo/journeyman/subscribers","subscription_url":"https://api.github.com/repos/ElMassimo/journeyman/subscription","commits_url":"https://api.github.com/repos/ElMassimo/journeyman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElMassimo/journeyman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElMassimo/journeyman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElMassimo/journeyman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElMassimo/journeyman/contents/{+path}","compare_url":"https://api.github.com/repos/ElMassimo/journeyman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElMassimo/journeyman/merges","archive_url":"https://api.github.com/repos/ElMassimo/journeyman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElMassimo/journeyman/downloads","issues_url":"https://api.github.com/repos/ElMassimo/journeyman/issues{/number}","pulls_url":"https://api.github.com/repos/ElMassimo/journeyman/pulls{/number}","milestones_url":"https://api.github.com/repos/ElMassimo/journeyman/milestones{/number}","notifications_url":"https://api.github.com/repos/ElMassimo/journeyman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElMassimo/journeyman/labels{/name}","releases_url":"https://api.github.com/repos/ElMassimo/journeyman/releases{/id}","created_at":"2014-08-16T01:23:25Z","updated_at":"2015-07-21T04:14:00Z","pushed_at":"2015-10-25T23:37:13Z","git_url":"git://github.com/ElMassimo/journeyman.git","ssh_url":"git@github.com:ElMassimo/journeyman.git","clone_url":"https://github.com/ElMassimo/journeyman.git","svn_url":"https://github.com/ElMassimo/journeyman","homepage":null,"size":220,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElMassimo/journeyman/pulls/1"},"html":{"href":"https://github.com/ElMassimo/journeyman/pull/1"},"issue":{"href":"https://api.github.com/repos/ElMassimo/journeyman/issues/1"},"comments":{"href":"https://api.github.com/repos/ElMassimo/journeyman/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ElMassimo/journeyman/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ElMassimo/journeyman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElMassimo/journeyman/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ElMassimo/journeyman/statuses/79b8d82ebbf5e4172e9dd426cbbb5bf2c99d5d54"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ElMassimo","id":1158253,"avatar_url":"https://avatars.githubusercontent.com/u/1158253?v=3","gravatar_id":"","url":"https://api.github.com/users/ElMassimo","html_url":"https://github.com/ElMassimo","followers_url":"https://api.github.com/users/ElMassimo/followers","following_url":"https://api.github.com/users/ElMassimo/following{/other_user}","gists_url":"https://api.github.com/users/ElMassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/ElMassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElMassimo/subscriptions","organizations_url":"https://api.github.com/users/ElMassimo/orgs","repos_url":"https://api.github.com/users/ElMassimo/repos","events_url":"https://api.github.com/users/ElMassimo/events{/privacy}","received_events_url":"https://api.github.com/users/ElMassimo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":10,"additions":135,"deletions":97,"changed_files":14}}