{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/comments/37900156","id":37900156,"diff_hunk":"@@ -114,7 +114,7 @@ public static Method getGetterMethod(Class containingClass, String propertyName)\n                 + (propertyName.isEmpty() ? \"\" : propertyName.substring(0, 1).toUpperCase() + propertyName.substring(1));\n         try {\n             return containingClass.getMethod(getterName);\n-        } catch (NoSuchMethodException e) {}\n+        } catch (NoSuchMethodException e) { }","path":"optaplanner-core/src/main/java/org/optaplanner/core/impl/domain/common/ReflectionHelper.java","position":5,"original_position":5,"commit_id":"85ee7da67709cf79b63048f8c54f6c9ddd1a6e36","original_commit_id":"85ee7da67709cf79b63048f8c54f6c9ddd1a6e36","user":{"login":"oskopek","id":1811716,"avatar_url":"https://avatars.githubusercontent.com/u/1811716?v=3","gravatar_id":"","url":"https://api.github.com/users/oskopek","html_url":"https://github.com/oskopek","followers_url":"https://api.github.com/users/oskopek/followers","following_url":"https://api.github.com/users/oskopek/following{/other_user}","gists_url":"https://api.github.com/users/oskopek/gists{/gist_id}","starred_url":"https://api.github.com/users/oskopek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskopek/subscriptions","organizations_url":"https://api.github.com/users/oskopek/orgs","repos_url":"https://api.github.com/users/oskopek/repos","events_url":"https://api.github.com/users/oskopek/events{/privacy}","received_events_url":"https://api.github.com/users/oskopek/received_events","type":"User","site_admin":false},"body":"Because the WhitespaceAround (quite a useful check) can't be disabled to allow empty blocks. Fixed to\r\n```\r\n...\r\n} catch (NoSuchMethodException e) {\r\n    // intentionally empty\r\n}\r\n...\r\n```","created_at":"2015-08-25T18:20:49Z","updated_at":"2015-08-25T18:20:49Z","html_url":"https://github.com/droolsjbpm/optaplanner/pull/116#discussion_r37900156","pull_request_url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/comments/37900156"},"html":{"href":"https://github.com/droolsjbpm/optaplanner/pull/116#discussion_r37900156"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116","id":41229817,"html_url":"https://github.com/droolsjbpm/optaplanner/pull/116","diff_url":"https://github.com/droolsjbpm/optaplanner/pull/116.diff","patch_url":"https://github.com/droolsjbpm/optaplanner/pull/116.patch","issue_url":"https://api.github.com/repos/droolsjbpm/optaplanner/issues/116","number":116,"state":"closed","locked":false,"title":"Added modules to the maven-checkstyle-plugin","user":{"login":"oskopek","id":1811716,"avatar_url":"https://avatars.githubusercontent.com/u/1811716?v=3","gravatar_id":"","url":"https://api.github.com/users/oskopek","html_url":"https://github.com/oskopek","followers_url":"https://api.github.com/users/oskopek/followers","following_url":"https://api.github.com/users/oskopek/following{/other_user}","gists_url":"https://api.github.com/users/oskopek/gists{/gist_id}","starred_url":"https://api.github.com/users/oskopek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskopek/subscriptions","organizations_url":"https://api.github.com/users/oskopek/orgs","repos_url":"https://api.github.com/users/oskopek/repos","events_url":"https://api.github.com/users/oskopek/events{/privacy}","received_events_url":"https://api.github.com/users/oskopek/received_events","type":"User","site_admin":false},"body":"Feature proposal:\r\n* Added 25 (+3 out-commented) new modules to the `maven-checkstyle-plugin` (only module currently being run is `FileTabCharacter` which checks for tabs in files)\r\n* All of the modules except for one are run in the warning severity level\r\n  * `FileTabCharacter` is run in severity \"error\" as in the parent pom\r\n* All errors/warnings/info are reported to the console *(divergent behavior from the parent pom)*\r\n* All modules that fail and have a severity of \"error\" **fail the build** *(divergent behavior from the parent pom)*\r\n  * Note: currently only one module, `FileTabCharacter`\r\n* Adding/removing modules can be done incrementally as new issues emerge\r\n  * The severity of modules can also be increased/decreased on the go (on a per module basis)\r\n  * **Unfortunately, I have failed at finding modules that correspond with JDK8's javadoc doclint checks**, the only option I see is writing our own, which isn't really satisfactory.\r\n* Does it slow the build? Yes, but not really by much.\r\n  * On an average of 5 runs on my local machine, the complete build (`mvn clean install -Dfull`) runs about 15 seconds slower (which given the ~280s build is about 6%).\r\n  * **Note**: If you don't `clean` between the builds, there is virtually no delay (because of caching)\r\n    * See the logs without `clean` in their name.\r\n  * For details on the benchmark, see [my benchmark script and log](https://gist.github.com/oskopek/ab01b23ee951d3362bcc)\r\n* Currently, checkstyle reports ~100 warnings in the whole project. They're all fixed as part of this PR.\r\n* Also, there's a nice [plugin for IntelliJ](https://github.com/jshiell/checkstyle-idea)","created_at":"2015-07-30T12:50:08Z","updated_at":"2015-08-25T18:20:49Z","closed_at":"2015-08-25T14:21:18Z","merged_at":null,"merge_commit_sha":"f78a50de8d5e23fb1480da3f1ee25177fc160713","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/optaplanner/issues/116/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/optaplanner/statuses/85ee7da67709cf79b63048f8c54f6c9ddd1a6e36","head":{"label":"oskopek:feature-checkstyle-plugin","ref":"feature-checkstyle-plugin","sha":"85ee7da67709cf79b63048f8c54f6c9ddd1a6e36","user":{"login":"oskopek","id":1811716,"avatar_url":"https://avatars.githubusercontent.com/u/1811716?v=3","gravatar_id":"","url":"https://api.github.com/users/oskopek","html_url":"https://github.com/oskopek","followers_url":"https://api.github.com/users/oskopek/followers","following_url":"https://api.github.com/users/oskopek/following{/other_user}","gists_url":"https://api.github.com/users/oskopek/gists{/gist_id}","starred_url":"https://api.github.com/users/oskopek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskopek/subscriptions","organizations_url":"https://api.github.com/users/oskopek/orgs","repos_url":"https://api.github.com/users/oskopek/repos","events_url":"https://api.github.com/users/oskopek/events{/privacy}","received_events_url":"https://api.github.com/users/oskopek/received_events","type":"User","site_admin":false},"repo":{"id":11878050,"name":"optaplanner","full_name":"oskopek/optaplanner","owner":{"login":"oskopek","id":1811716,"avatar_url":"https://avatars.githubusercontent.com/u/1811716?v=3","gravatar_id":"","url":"https://api.github.com/users/oskopek","html_url":"https://github.com/oskopek","followers_url":"https://api.github.com/users/oskopek/followers","following_url":"https://api.github.com/users/oskopek/following{/other_user}","gists_url":"https://api.github.com/users/oskopek/gists{/gist_id}","starred_url":"https://api.github.com/users/oskopek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskopek/subscriptions","organizations_url":"https://api.github.com/users/oskopek/orgs","repos_url":"https://api.github.com/users/oskopek/repos","events_url":"https://api.github.com/users/oskopek/events{/privacy}","received_events_url":"https://api.github.com/users/oskopek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oskopek/optaplanner","description":"OptaPlanner optimizes business resource scheduling and planning.","fork":true,"url":"https://api.github.com/repos/oskopek/optaplanner","forks_url":"https://api.github.com/repos/oskopek/optaplanner/forks","keys_url":"https://api.github.com/repos/oskopek/optaplanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oskopek/optaplanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oskopek/optaplanner/teams","hooks_url":"https://api.github.com/repos/oskopek/optaplanner/hooks","issue_events_url":"https://api.github.com/repos/oskopek/optaplanner/issues/events{/number}","events_url":"https://api.github.com/repos/oskopek/optaplanner/events","assignees_url":"https://api.github.com/repos/oskopek/optaplanner/assignees{/user}","branches_url":"https://api.github.com/repos/oskopek/optaplanner/branches{/branch}","tags_url":"https://api.github.com/repos/oskopek/optaplanner/tags","blobs_url":"https://api.github.com/repos/oskopek/optaplanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oskopek/optaplanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oskopek/optaplanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/oskopek/optaplanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oskopek/optaplanner/statuses/{sha}","languages_url":"https://api.github.com/repos/oskopek/optaplanner/languages","stargazers_url":"https://api.github.com/repos/oskopek/optaplanner/stargazers","contributors_url":"https://api.github.com/repos/oskopek/optaplanner/contributors","subscribers_url":"https://api.github.com/repos/oskopek/optaplanner/subscribers","subscription_url":"https://api.github.com/repos/oskopek/optaplanner/subscription","commits_url":"https://api.github.com/repos/oskopek/optaplanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/oskopek/optaplanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/oskopek/optaplanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/oskopek/optaplanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/oskopek/optaplanner/contents/{+path}","compare_url":"https://api.github.com/repos/oskopek/optaplanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oskopek/optaplanner/merges","archive_url":"https://api.github.com/repos/oskopek/optaplanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oskopek/optaplanner/downloads","issues_url":"https://api.github.com/repos/oskopek/optaplanner/issues{/number}","pulls_url":"https://api.github.com/repos/oskopek/optaplanner/pulls{/number}","milestones_url":"https://api.github.com/repos/oskopek/optaplanner/milestones{/number}","notifications_url":"https://api.github.com/repos/oskopek/optaplanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oskopek/optaplanner/labels{/name}","releases_url":"https://api.github.com/repos/oskopek/optaplanner/releases{/id}","created_at":"2013-08-04T12:08:28Z","updated_at":"2015-06-26T11:02:58Z","pushed_at":"2015-08-25T17:20:05Z","git_url":"git://github.com/oskopek/optaplanner.git","ssh_url":"git@github.com:oskopek/optaplanner.git","clone_url":"https://github.com/oskopek/optaplanner.git","svn_url":"https://github.com/oskopek/optaplanner","homepage":"http://www.optaplanner.org","size":147905,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"a881873149f026d15bae7a3a63cb60e94129baf4","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1370858,"name":"optaplanner","full_name":"droolsjbpm/optaplanner","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/optaplanner","description":"Java planning engine: OptaPlanner optimizes business resource scheduling and planning.","fork":false,"url":"https://api.github.com/repos/droolsjbpm/optaplanner","forks_url":"https://api.github.com/repos/droolsjbpm/optaplanner/forks","keys_url":"https://api.github.com/repos/droolsjbpm/optaplanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/optaplanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/optaplanner/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/optaplanner/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/optaplanner/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/optaplanner/events","assignees_url":"https://api.github.com/repos/droolsjbpm/optaplanner/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/optaplanner/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/optaplanner/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/optaplanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/optaplanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/optaplanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/optaplanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/optaplanner/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/optaplanner/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/optaplanner/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/optaplanner/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/optaplanner/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/optaplanner/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/optaplanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/optaplanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/optaplanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/optaplanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/optaplanner/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/optaplanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/optaplanner/merges","archive_url":"https://api.github.com/repos/droolsjbpm/optaplanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/optaplanner/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/optaplanner/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/optaplanner/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/optaplanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/optaplanner/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/optaplanner/releases{/id}","created_at":"2011-02-15T19:38:23Z","updated_at":"2015-08-25T07:39:23Z","pushed_at":"2015-08-25T17:14:13Z","git_url":"git://github.com/droolsjbpm/optaplanner.git","ssh_url":"git@github.com:droolsjbpm/optaplanner.git","clone_url":"https://github.com/droolsjbpm/optaplanner.git","svn_url":"https://github.com/droolsjbpm/optaplanner","homepage":"http://www.optaplanner.org","size":173604,"stargazers_count":296,"watchers_count":296,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":4,"forks":211,"open_issues":4,"watchers":296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116"},"html":{"href":"https://github.com/droolsjbpm/optaplanner/pull/116"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/issues/116"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/optaplanner/statuses/85ee7da67709cf79b63048f8c54f6c9ddd1a6e36"}}}}