{"action":"created","issue":{"url":"https://api.github.com/repos/pyca/cryptography/issues/2108","labels_url":"https://api.github.com/repos/pyca/cryptography/issues/2108/labels{/name}","comments_url":"https://api.github.com/repos/pyca/cryptography/issues/2108/comments","events_url":"https://api.github.com/repos/pyca/cryptography/issues/2108/events","html_url":"https://github.com/pyca/cryptography/pull/2108","id":93019704,"number":2108,"title":"Dont bail if a certficate SAN has an unsupported GeneralName?","user":{"login":"JoshData","id":445875,"avatar_url":"https://avatars.githubusercontent.com/u/445875?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshData","html_url":"https://github.com/JoshData","followers_url":"https://api.github.com/users/JoshData/followers","following_url":"https://api.github.com/users/JoshData/following{/other_user}","gists_url":"https://api.github.com/users/JoshData/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshData/subscriptions","organizations_url":"https://api.github.com/users/JoshData/orgs","repos_url":"https://api.github.com/users/JoshData/repos","events_url":"https://api.github.com/users/JoshData/events{/privacy}","received_events_url":"https://api.github.com/users/JoshData/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pyca/cryptography/labels/x509","name":"x509","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/pyca/cryptography/milestones/11","html_url":"https://github.com/pyca/cryptography/milestones/Tenth%20Release","labels_url":"https://api.github.com/repos/pyca/cryptography/milestones/11/labels","id":1099545,"number":11,"title":"Tenth Release","description":"","creator":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":99,"state":"open","created_at":"2015-05-07T04:01:32Z","updated_at":"2015-07-05T14:19:07Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2015-07-04T15:10:10Z","updated_at":"2015-07-05T16:19:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/2108","html_url":"https://github.com/pyca/cryptography/pull/2108","diff_url":"https://github.com/pyca/cryptography/pull/2108.diff","patch_url":"https://github.com/pyca/cryptography/pull/2108.patch"},"body":"There are a few GeneralName types that aren't yet supported. I encountered an otherName in the wild (https://github.com/mail-in-a-box/mailinabox/issues/481). Rather than raising an exception and preventing the certificate from being loaded at all, it would be nice if the library is able to parse the certificate but leave the otherName as a placeholder.\r\n\r\nThis patch removes the `x509.UnsupportedGeneralNameType` exception and adds a new class `x509.UnsupportedGeneralName`.\r\n\r\nWhat do you think?\r\n\r\nI didn't update the tests. Wasn't sure quite how to do that."},"comment":{"url":"https://api.github.com/repos/pyca/cryptography/issues/comments/118636180","html_url":"https://github.com/pyca/cryptography/pull/2108#issuecomment-118636180","issue_url":"https://api.github.com/repos/pyca/cryptography/issues/2108","id":118636180,"user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"created_at":"2015-07-05T16:19:58Z","updated_at":"2015-07-05T16:19:58Z","body":"We're almost there! :smile:\r\n\r\nTwo things left that I see:\r\n* We have several uncovered lines and missed branches in the `OtherName` class. If you take a look in `test_x509_ext` you can see classes for testing the various general names (e.g. the `TestRegisteredID` class). Looks like you'll need tests for invalid type_id, invalid value, equality, not equal, and repr.\r\n* The docs job is failing spell check due to \"otherName\". I'd suggest handling this by putting double back ticks around it."}}