{"action":"created","issue":{"url":"https://api.github.com/repos/scalaj/scalaj-http/issues/83","labels_url":"https://api.github.com/repos/scalaj/scalaj-http/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/scalaj/scalaj-http/issues/83/comments","events_url":"https://api.github.com/repos/scalaj/scalaj-http/issues/83/events","html_url":"https://github.com/scalaj/scalaj-http/issues/83","id":115501186,"number":83,"title":"Duplicate headers should not be joined with comma","user":{"login":"ptxmac","id":56919,"avatar_url":"https://avatars.githubusercontent.com/u/56919?v=3","gravatar_id":"","url":"https://api.github.com/users/ptxmac","html_url":"https://github.com/ptxmac","followers_url":"https://api.github.com/users/ptxmac/followers","following_url":"https://api.github.com/users/ptxmac/following{/other_user}","gists_url":"https://api.github.com/users/ptxmac/gists{/gist_id}","starred_url":"https://api.github.com/users/ptxmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptxmac/subscriptions","organizations_url":"https://api.github.com/users/ptxmac/orgs","repos_url":"https://api.github.com/users/ptxmac/repos","events_url":"https://api.github.com/users/ptxmac/events{/privacy}","received_events_url":"https://api.github.com/users/ptxmac/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-06T13:04:23Z","updated_at":"2015-11-06T14:18:56Z","closed_at":"2015-11-06T14:18:25Z","body":"Current scalaj-http joins duplicate headrs with a comma. This is a big problem when parsing cookies.\r\nIf a page sets multiple cookies, they will be send as duplicate `Set-Cookie:` headers.\r\n\r\nA cookie header contains a `expires` field which is a human readable date containing a comma.\r\n\r\ne.g.\r\n\r\n```\r\nSet-Cookie: Some_login=35; path=/; expires=Fri, 01-Jan-2038 00:00:00 GMT; HttpOnly\r\nSet-Cookie: Some_logincookie=asd123; path=/; expires=Fri, 01-Jan-2038 00:00:00 GMT; HttpOnly\r\n```\r\n\r\nscalaj-http will join this as\r\n`Some_login=35; path=/; expires=Fri, 01-Jan-2038 00:00:00 GMT; HttpOnly, Some_logincookie=asd123; path=/; expires=Fri, 01-Jan-2038 00:00:00 GMT; HttpOnly`\r\n\r\nNow it's impossible to get back the original values. Splitting on `,` as a separator will result in 4 values because the timestamp include commas."},"comment":{"url":"https://api.github.com/repos/scalaj/scalaj-http/issues/comments/154419919","html_url":"https://github.com/scalaj/scalaj-http/issues/83#issuecomment-154419919","issue_url":"https://api.github.com/repos/scalaj/scalaj-http/issues/83","id":154419919,"user":{"login":"hoffrocket","id":24408,"avatar_url":"https://avatars.githubusercontent.com/u/24408?v=3","gravatar_id":"","url":"https://api.github.com/users/hoffrocket","html_url":"https://github.com/hoffrocket","followers_url":"https://api.github.com/users/hoffrocket/followers","following_url":"https://api.github.com/users/hoffrocket/following{/other_user}","gists_url":"https://api.github.com/users/hoffrocket/gists{/gist_id}","starred_url":"https://api.github.com/users/hoffrocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoffrocket/subscriptions","organizations_url":"https://api.github.com/users/hoffrocket/orgs","repos_url":"https://api.github.com/users/hoffrocket/repos","events_url":"https://api.github.com/users/hoffrocket/events{/privacy}","received_events_url":"https://api.github.com/users/hoffrocket/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T14:18:56Z","updated_at":"2015-11-06T14:18:56Z","body":"thanks. i'll push out a 2.0.0 release soon for this."}}