{"action":"created","issue":{"url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3930","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3930/labels{/name}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3930/comments","events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3930/events","html_url":"https://github.com/activeadmin/activeadmin/pull/3930","id":72895989,"number":3930,"title":"Fix the column_for_attribute deprecation warning for the last time","user":{"login":"seanlinsley","id":688886,"avatar_url":"https://avatars.githubusercontent.com/u/688886?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlinsley","html_url":"https://github.com/seanlinsley","followers_url":"https://api.github.com/users/seanlinsley/followers","following_url":"https://api.github.com/users/seanlinsley/following{/other_user}","gists_url":"https://api.github.com/users/seanlinsley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlinsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlinsley/subscriptions","organizations_url":"https://api.github.com/users/seanlinsley/orgs","repos_url":"https://api.github.com/users/seanlinsley/repos","events_url":"https://api.github.com/users/seanlinsley/events{/privacy}","received_events_url":"https://api.github.com/users/seanlinsley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-04T01:31:03Z","updated_at":"2015-10-11T14:55:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3930","html_url":"https://github.com/activeadmin/activeadmin/pull/3930","diff_url":"https://github.com/activeadmin/activeadmin/pull/3930.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3930.patch"},"body":"#3838\r\n\r\nTurns out we couldn’t use `type_for_column` since:\r\n- it’s not intended as a public method\r\n- it would return a null object if the column had the default value (nil)\r\n\r\nfor example:\r\n```\r\nexpected: \"No\"\r\n     got: \"\"\r\n\r\n(compared using ==)\r\n (RSpec::Expectations::ExpectationNotMetError)\r\n./features/step_definitions/table_steps.rb:96:in `assert_cells_match'\r\n./features/step_definitions/table_steps.rb:79:in `block (2 levels) in assert_tables_match'\r\n./features/step_definitions/table_steps.rb:75:in `each_index'\r\n./features/step_definitions/table_steps.rb:75:in `block in assert_tables_match'\r\n./features/step_definitions/table_steps.rb:74:in `each_index'\r\n./features/step_definitions/table_steps.rb:74:in `assert_tables_match'\r\n./features/step_definitions/table_steps.rb:115:in `/^I should see the \"([^\"]*)\" table:$/'\r\nfeatures/index/index_as_table.feature:252:in `Then I should see the \"index_table_posts\" table:'\r\n\r\nFailing Scenarios:\r\ncucumber features/index/index_as_table.feature:244 # Scenario: Sorting\r\n```"},"comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments/147205952","html_url":"https://github.com/activeadmin/activeadmin/pull/3930#issuecomment-147205952","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3930","id":147205952,"user":{"login":"seanlinsley","id":688886,"avatar_url":"https://avatars.githubusercontent.com/u/688886?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlinsley","html_url":"https://github.com/seanlinsley","followers_url":"https://api.github.com/users/seanlinsley/followers","following_url":"https://api.github.com/users/seanlinsley/following{/other_user}","gists_url":"https://api.github.com/users/seanlinsley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlinsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlinsley/subscriptions","organizations_url":"https://api.github.com/users/seanlinsley/orgs","repos_url":"https://api.github.com/users/seanlinsley/repos","events_url":"https://api.github.com/users/seanlinsley/events{/privacy}","received_events_url":"https://api.github.com/users/seanlinsley/received_events","type":"User","site_admin":false},"created_at":"2015-10-11T14:55:09Z","updated_at":"2015-10-11T14:55:09Z","body":"I'm working adding that test now.\r\n\r\n> @seanlinsley your commit run's as a ActiveAdmin repo commit (continuous-integration/travis-ci/push) and as a PR commit (continuous-integration/travis-ci/pr). That's happens only if a ActiveAdmin contributor creates a PR from a ActiveAdmin branch.\r\n\r\nIt seems like we should make it so `continuous-integration/travis-ci/pr` only happens on master, and on version branches like `0-6-stable`.\r\n"}}