{"action":"created","issue":{"url":"https://api.github.com/repos/PyAbel/PyAbel/issues/50","labels_url":"https://api.github.com/repos/PyAbel/PyAbel/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/PyAbel/PyAbel/issues/50/comments","events_url":"https://api.github.com/repos/PyAbel/PyAbel/issues/50/events","html_url":"https://github.com/PyAbel/PyAbel/pull/50","id":120837609,"number":50,"title":"Making Hansen-Law transform work for non-square images","user":{"login":"DanHickstein","id":1107796,"avatar_url":"https://avatars.githubusercontent.com/u/1107796?v=3","gravatar_id":"","url":"https://api.github.com/users/DanHickstein","html_url":"https://github.com/DanHickstein","followers_url":"https://api.github.com/users/DanHickstein/followers","following_url":"https://api.github.com/users/DanHickstein/following{/other_user}","gists_url":"https://api.github.com/users/DanHickstein/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHickstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHickstein/subscriptions","organizations_url":"https://api.github.com/users/DanHickstein/orgs","repos_url":"https://api.github.com/users/DanHickstein/repos","events_url":"https://api.github.com/users/DanHickstein/events{/privacy}","received_events_url":"https://api.github.com/users/DanHickstein/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/PyAbel/PyAbel/milestones/2","html_url":"https://github.com/PyAbel/PyAbel/milestones/Version%200.7","labels_url":"https://api.github.com/repos/PyAbel/PyAbel/milestones/2/labels","id":1423032,"number":2,"title":"Version 0.7","description":"Adding a few other inverse Abel implementations. Converge to a consistent user interface.","creator":{"login":"rth","id":630936,"avatar_url":"https://avatars.githubusercontent.com/u/630936?v=3","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":11,"state":"open","created_at":"2015-11-21T11:17:04Z","updated_at":"2015-12-08T11:15:30Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-12-07T18:30:52Z","updated_at":"2015-12-08T17:19:49Z","closed_at":"2015-12-08T09:27:38Z","pull_request":{"url":"https://api.github.com/repos/PyAbel/PyAbel/pulls/50","html_url":"https://github.com/PyAbel/PyAbel/pull/50","diff_url":"https://github.com/PyAbel/PyAbel/pull/50.diff","patch_url":"https://github.com/PyAbel/PyAbel/pull/50.patch"},"body":"Following the discussion in https://github.com/PyAbel/PyAbel/pull/49, this PR fixes the second-to-last line in the ``iabel_hansenlaw_transform`` function in order to allow the transform to work with non-square images. \r\n\r\nI am actually not sure if this line is even necessary. The center few pixels are noisy in either case, and I cannot really tell if there is a difference by eye. @stggh, does this line serve a specific purpose?\r\n\r\n___\r\n\r\nAlso, I added a ``np.atleast_2d()`` statement to make ``iabel_hansenlaw_transform`` work if it's passed an array that is 1D (also changed the ``np.gradient`` to work for 1D). \r\n\r\nDoes it make sense for ``iabel_hansenlaw`` to also work with 1D images? It will require a little bit of extra hacking, since the up/down quadrants concept doesn't apply. Right now, ``iabel_hansenlaw`` does not produce the right result when passed a 1D array due to the quadrants, so I made it throw an error if it gets a 1D array."},"comment":{"url":"https://api.github.com/repos/PyAbel/PyAbel/issues/comments/162950541","html_url":"https://github.com/PyAbel/PyAbel/pull/50#issuecomment-162950541","issue_url":"https://api.github.com/repos/PyAbel/PyAbel/issues/50","id":162950541,"user":{"login":"DanHickstein","id":1107796,"avatar_url":"https://avatars.githubusercontent.com/u/1107796?v=3","gravatar_id":"","url":"https://api.github.com/users/DanHickstein","html_url":"https://github.com/DanHickstein","followers_url":"https://api.github.com/users/DanHickstein/followers","following_url":"https://api.github.com/users/DanHickstein/following{/other_user}","gists_url":"https://api.github.com/users/DanHickstein/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHickstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHickstein/subscriptions","organizations_url":"https://api.github.com/users/DanHickstein/orgs","repos_url":"https://api.github.com/users/DanHickstein/repos","events_url":"https://api.github.com/users/DanHickstein/events{/privacy}","received_events_url":"https://api.github.com/users/DanHickstein/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T17:19:49Z","updated_at":"2015-12-08T17:19:49Z","body":"Oh, it just stops at ``n=N-2``? Interesting. Seems like cheating! :)"}}