{"action":"created","issue":{"url":"https://api.github.com/repos/steveswinsburg/gradebookNG/issues/152","labels_url":"https://api.github.com/repos/steveswinsburg/gradebookNG/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/steveswinsburg/gradebookNG/issues/152/comments","events_url":"https://api.github.com/repos/steveswinsburg/gradebookNG/issues/152/events","html_url":"https://github.com/steveswinsburg/gradebookNG/pull/152","id":96312662,"number":152,"title":"Feature/ta permissions","user":{"login":"steveswinsburg","id":129129,"avatar_url":"https://avatars.githubusercontent.com/u/129129?v=3","gravatar_id":"","url":"https://api.github.com/users/steveswinsburg","html_url":"https://github.com/steveswinsburg","followers_url":"https://api.github.com/users/steveswinsburg/followers","following_url":"https://api.github.com/users/steveswinsburg/following{/other_user}","gists_url":"https://api.github.com/users/steveswinsburg/gists{/gist_id}","starred_url":"https://api.github.com/users/steveswinsburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveswinsburg/subscriptions","organizations_url":"https://api.github.com/users/steveswinsburg/orgs","repos_url":"https://api.github.com/users/steveswinsburg/repos","events_url":"https://api.github.com/users/steveswinsburg/events{/privacy}","received_events_url":"https://api.github.com/users/steveswinsburg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-21T13:18:06Z","updated_at":"2015-07-23T05:16:07Z","closed_at":"2015-07-22T11:49:10Z","pull_request":{"url":"https://api.github.com/repos/steveswinsburg/gradebookNG/pulls/152","html_url":"https://github.com/steveswinsburg/gradebookNG/pull/152","diff_url":"https://github.com/steveswinsburg/gradebookNG/pull/152.diff","patch_url":"https://github.com/steveswinsburg/gradebookNG/pull/152.patch"},"body":"Added in the group and user checking if user is a TA. Tas should now only see users they have been given access to.\r\n\r\nAlso added in error page. Error will be thrown if user is on a page, then permissions are reduced and then click on a student to view their grades that they no longer has access to view."},"comment":{"url":"https://api.github.com/repos/steveswinsburg/gradebookNG/issues/comments/123968321","html_url":"https://github.com/steveswinsburg/gradebookNG/pull/152#issuecomment-123968321","issue_url":"https://api.github.com/repos/steveswinsburg/gradebookNG/issues/152","id":123968321,"user":{"login":"payten","id":608337,"avatar_url":"https://avatars.githubusercontent.com/u/608337?v=3","gravatar_id":"","url":"https://api.github.com/users/payten","html_url":"https://github.com/payten","followers_url":"https://api.github.com/users/payten/followers","following_url":"https://api.github.com/users/payten/following{/other_user}","gists_url":"https://api.github.com/users/payten/gists{/gist_id}","starred_url":"https://api.github.com/users/payten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payten/subscriptions","organizations_url":"https://api.github.com/users/payten/orgs","repos_url":"https://api.github.com/users/payten/repos","events_url":"https://api.github.com/users/payten/events{/privacy}","received_events_url":"https://api.github.com/users/payten/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T05:16:07Z","updated_at":"2015-07-23T05:16:07Z","body":"Hi @steveswinsburg,\r\n\r\nJust running through a few scenarios:\r\n\r\n- No rules:  I guess I imagined not being able to see any students and no grade items.  Also, should we disable or hide all the Edit, Move and Set Score actions for TAs?\r\n- \"View\" on category and all sections: All students display and grade items are limited to the category I selected and are read only. However, all the category totals columns are visible which causes a javascript error and Group by Categories doesn't work.\r\n- \"Grade\" on category and all sections: Javascript described above breaks editing.  When catching and ignoring the JS exception, everything seems to work otherwise!\r\n- \"Grade\" on category and a group: Works well.\r\n- \"View\" on category and all sections + \"Grade\" on same category and a group: Cells for all students are editable but hits \"Something went wrong\" page when trying to edit a student not in the \"Grade\" group.  Editing scores for students in the group worked nicely.\r\n- \"View\" on category and all sections + \"Grade\" on a different category and a group: \"Something went wrong\".\r\n\r\n\r\n"}}