{"action":"created","comment":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/23893921","id":23893921,"diff_hunk":"@@ -1085,25 +1085,41 @@ static const jsmntok_t * setPidExtendedField(const jsmntok_t *valueTok, const ch\n \treturn valueTok + 1;\n }\n \n+/* Max number of PIDs that can be written in the setOBD2Config message */\n+#define MAX_OBD2_MESSAGE_PIDS 10","path":"src/logger/loggerApi.c","position":5,"original_position":5,"commit_id":"a5df8c1ef8e172944c08230293cd2dfaefbfdb33","original_commit_id":"a5df8c1ef8e172944c08230293cd2dfaefbfdb33","user":{"login":"Jeff-Ciesielski","id":759677,"avatar_url":"https://avatars.githubusercontent.com/u/759677?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeff-Ciesielski","html_url":"https://github.com/Jeff-Ciesielski","followers_url":"https://api.github.com/users/Jeff-Ciesielski/followers","following_url":"https://api.github.com/users/Jeff-Ciesielski/following{/other_user}","gists_url":"https://api.github.com/users/Jeff-Ciesielski/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeff-Ciesielski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeff-Ciesielski/subscriptions","organizations_url":"https://api.github.com/users/Jeff-Ciesielski/orgs","repos_url":"https://api.github.com/users/Jeff-Ciesielski/repos","events_url":"https://api.github.com/users/Jeff-Ciesielski/events{/privacy}","received_events_url":"https://api.github.com/users/Jeff-Ciesielski/received_events","type":"User","site_admin":false},"body":"IMO I'd say better form to put it at the top. ","created_at":"2015-02-01T01:36:19Z","updated_at":"2015-02-01T01:36:19Z","html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/21#discussion_r23893921","pull_request_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/23893921"},"html":{"href":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/21#discussion_r23893921"},"pull_request":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21","id":28424359,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/21","diff_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/21.diff","patch_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/21.patch","issue_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/21","number":21,"state":"open","locked":false,"title":"update setObd2Config API to prevent API buffer overflow (V2.7.9 work in progress)","user":{"login":"brentpicasso","id":3267533,"avatar_url":"https://avatars.githubusercontent.com/u/3267533?v=3","gravatar_id":"","url":"https://api.github.com/users/brentpicasso","html_url":"https://github.com/brentpicasso","followers_url":"https://api.github.com/users/brentpicasso/followers","following_url":"https://api.github.com/users/brentpicasso/following{/other_user}","gists_url":"https://api.github.com/users/brentpicasso/gists{/gist_id}","starred_url":"https://api.github.com/users/brentpicasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentpicasso/subscriptions","organizations_url":"https://api.github.com/users/brentpicasso/orgs","repos_url":"https://api.github.com/users/brentpicasso/repos","events_url":"https://api.github.com/users/brentpicasso/events{/privacy}","received_events_url":"https://api.github.com/users/brentpicasso/received_events","type":"User","site_admin":false},"body":"This change adds a 'starting from index' for setting an array of OBD-II PIDs.  Reason: setting 20 PIDs all at once was overflowing the serial Rx buffer, and I felt it was wasteful to expand the buffer to accommodate the full message.  \r\n\r\nThis requires the app to set all 20 OBD-II pids in two steps, instead of setting all at once. up to 10 PIDs can be sent at a time. (20 separate single PID calls or 2 calls with 10 PIDs each can be made to set all 20 PIDs)\r\n\r\nAdded unit tests to check for success and failure modes.","created_at":"2015-02-01T01:16:03Z","updated_at":"2015-02-01T01:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c31d5f7e02040df1132a1c2733049431159869","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21/commits","review_comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21/comments","review_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/{number}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/21/comments","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/a5df8c1ef8e172944c08230293cd2dfaefbfdb33","head":{"label":"autosportlabs:v2.7.9_work_in_progress","ref":"v2.7.9_work_in_progress","sha":"a5df8c1ef8e172944c08230293cd2dfaefbfdb33","user":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10069490,"name":"RaceCapture-Pro_firmware","full_name":"autosportlabs/RaceCapture-Pro_firmware","owner":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","description":"Firmware for RaceCapture-Pro Data Acquisition, control and Telemetry system for motorsports","fork":false,"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware","forks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/forks","keys_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/teams","hooks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/hooks","issue_events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/events","assignees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/tags","blobs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/languages","stargazers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/stargazers","contributors_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contributors","subscribers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscribers","subscription_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscription","commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/comments/{number}","contents_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/merges","archive_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/downloads","issues_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/labels{/name}","releases_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/releases{/id}","created_at":"2013-05-15T02:30:10Z","updated_at":"2015-01-31T21:59:41Z","pushed_at":"2015-02-01T01:09:44Z","git_url":"git://github.com/autosportlabs/RaceCapture-Pro_firmware.git","ssh_url":"git@github.com:autosportlabs/RaceCapture-Pro_firmware.git","clone_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware.git","svn_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","homepage":null,"size":21158,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":6,"default_branch":"master"}},"base":{"label":"autosportlabs:master","ref":"master","sha":"101a962f6cffff49355d3da92717f074105b7526","user":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10069490,"name":"RaceCapture-Pro_firmware","full_name":"autosportlabs/RaceCapture-Pro_firmware","owner":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","description":"Firmware for RaceCapture-Pro Data Acquisition, control and Telemetry system for motorsports","fork":false,"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware","forks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/forks","keys_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/teams","hooks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/hooks","issue_events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/events","assignees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/tags","blobs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/languages","stargazers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/stargazers","contributors_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contributors","subscribers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscribers","subscription_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscription","commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/comments/{number}","contents_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/merges","archive_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/downloads","issues_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/labels{/name}","releases_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/releases{/id}","created_at":"2013-05-15T02:30:10Z","updated_at":"2015-01-31T21:59:41Z","pushed_at":"2015-02-01T01:09:44Z","git_url":"git://github.com/autosportlabs/RaceCapture-Pro_firmware.git","ssh_url":"git@github.com:autosportlabs/RaceCapture-Pro_firmware.git","clone_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware.git","svn_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","homepage":null,"size":21158,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21"},"html":{"href":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/21"},"issue":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/21"},"comments":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/a5df8c1ef8e172944c08230293cd2dfaefbfdb33"}}}}