{"action":"created","issue":{"url":"https://api.github.com/repos/markovmodel/variational/issues/26","labels_url":"https://api.github.com/repos/markovmodel/variational/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/markovmodel/variational/issues/26/comments","events_url":"https://api.github.com/repos/markovmodel/variational/issues/26/events","html_url":"https://github.com/markovmodel/variational/pull/26","id":119060762,"number":26,"title":"Fixed error in _M2_const if one of the two masks is None.","user":{"login":"fnueske","id":11500718,"avatar_url":"https://avatars.githubusercontent.com/u/11500718?v=3","gravatar_id":"","url":"https://api.github.com/users/fnueske","html_url":"https://github.com/fnueske","followers_url":"https://api.github.com/users/fnueske/followers","following_url":"https://api.github.com/users/fnueske/following{/other_user}","gists_url":"https://api.github.com/users/fnueske/gists{/gist_id}","starred_url":"https://api.github.com/users/fnueske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnueske/subscriptions","organizations_url":"https://api.github.com/users/fnueske/orgs","repos_url":"https://api.github.com/users/fnueske/repos","events_url":"https://api.github.com/users/fnueske/events{/privacy}","received_events_url":"https://api.github.com/users/fnueske/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-26T15:05:25Z","updated_at":"2015-11-26T15:26:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/markovmodel/variational/pulls/26","html_url":"https://github.com/markovmodel/variational/pull/26","diff_url":"https://github.com/markovmodel/variational/pull/26.diff","patch_url":"https://github.com/markovmodel/variational/pull/26.patch"},"body":"Hi, I found that variational/estimators/moments.py/_M2_const can crash if either of mask_X or mask_Y is None. This can happen as the use of _M2_const is only ruled out in _M2 if both are None.\r\n\r\nI have included this simple check which just replaces the mask which is None by the list of all columns. @franknoe , is it okay like this or would you like to solve this differently?"},"comment":{"url":"https://api.github.com/repos/markovmodel/variational/issues/comments/159937967","html_url":"https://github.com/markovmodel/variational/pull/26#issuecomment-159937967","issue_url":"https://api.github.com/repos/markovmodel/variational/issues/26","id":159937967,"user":{"login":"franknoe","id":6495810,"avatar_url":"https://avatars.githubusercontent.com/u/6495810?v=3","gravatar_id":"","url":"https://api.github.com/users/franknoe","html_url":"https://github.com/franknoe","followers_url":"https://api.github.com/users/franknoe/followers","following_url":"https://api.github.com/users/franknoe/following{/other_user}","gists_url":"https://api.github.com/users/franknoe/gists{/gist_id}","starred_url":"https://api.github.com/users/franknoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franknoe/subscriptions","organizations_url":"https://api.github.com/users/franknoe/orgs","repos_url":"https://api.github.com/users/franknoe/repos","events_url":"https://api.github.com/users/franknoe/events{/privacy}","received_events_url":"https://api.github.com/users/franknoe/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T15:26:47Z","updated_at":"2015-11-26T15:26:47Z","body":"OK. I can merge this, but I'd like to understand when this happens, because it isn't intended - so there might be another issue."}}