{"action":"closed","number":1911,"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1911","id":35457595,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1911","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1911.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1911.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1911","number":1911,"state":"closed","locked":false,"title":"fix in chain uncle tests","user":{"login":"CJentzsch","id":8452011,"avatar_url":"https://avatars.githubusercontent.com/u/8452011?v=3","gravatar_id":"","url":"https://api.github.com/users/CJentzsch","html_url":"https://github.com/CJentzsch","followers_url":"https://api.github.com/users/CJentzsch/followers","following_url":"https://api.github.com/users/CJentzsch/following{/other_user}","gists_url":"https://api.github.com/users/CJentzsch/gists{/gist_id}","starred_url":"https://api.github.com/users/CJentzsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJentzsch/subscriptions","organizations_url":"https://api.github.com/users/CJentzsch/orgs","repos_url":"https://api.github.com/users/CJentzsch/repos","events_url":"https://api.github.com/users/CJentzsch/events{/privacy}","received_events_url":"https://api.github.com/users/CJentzsch/received_events","type":"User","site_admin":false},"body":"I forgot to update to uncleHash of the blockHeader when testing invalid uncles, this is the fix.","created_at":"2015-05-14T20:17:16Z","updated_at":"2015-05-15T15:36:22Z","closed_at":"2015-05-15T15:36:22Z","merged_at":"2015-05-15T15:36:22Z","merge_commit_sha":"a2eb2610821096a116a2fb41f4af732444ea982d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1911/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1911/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1911/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/38bf18de816a6d62fcfae5c656b72633eeaa66cb","head":{"label":"CJentzsch:ficInChainUncleTests","ref":"ficInChainUncleTests","sha":"38bf18de816a6d62fcfae5c656b72633eeaa66cb","user":{"login":"CJentzsch","id":8452011,"avatar_url":"https://avatars.githubusercontent.com/u/8452011?v=3","gravatar_id":"","url":"https://api.github.com/users/CJentzsch","html_url":"https://github.com/CJentzsch","followers_url":"https://api.github.com/users/CJentzsch/followers","following_url":"https://api.github.com/users/CJentzsch/following{/other_user}","gists_url":"https://api.github.com/users/CJentzsch/gists{/gist_id}","starred_url":"https://api.github.com/users/CJentzsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJentzsch/subscriptions","organizations_url":"https://api.github.com/users/CJentzsch/orgs","repos_url":"https://api.github.com/users/CJentzsch/repos","events_url":"https://api.github.com/users/CJentzsch/events{/privacy}","received_events_url":"https://api.github.com/users/CJentzsch/received_events","type":"User","site_admin":false},"repo":{"id":22966652,"name":"cpp-ethereum","full_name":"CJentzsch/cpp-ethereum","owner":{"login":"CJentzsch","id":8452011,"avatar_url":"https://avatars.githubusercontent.com/u/8452011?v=3","gravatar_id":"","url":"https://api.github.com/users/CJentzsch","html_url":"https://github.com/CJentzsch","followers_url":"https://api.github.com/users/CJentzsch/followers","following_url":"https://api.github.com/users/CJentzsch/following{/other_user}","gists_url":"https://api.github.com/users/CJentzsch/gists{/gist_id}","starred_url":"https://api.github.com/users/CJentzsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJentzsch/subscriptions","organizations_url":"https://api.github.com/users/CJentzsch/orgs","repos_url":"https://api.github.com/users/CJentzsch/repos","events_url":"https://api.github.com/users/CJentzsch/events{/privacy}","received_events_url":"https://api.github.com/users/CJentzsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CJentzsch/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/CJentzsch/cpp-ethereum","forks_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/CJentzsch/cpp-ethereum/releases{/id}","created_at":"2014-08-14T19:52:36Z","updated_at":"2015-03-12T13:33:14Z","pushed_at":"2015-05-14T20:56:43Z","git_url":"git://github.com/CJentzsch/cpp-ethereum.git","ssh_url":"git@github.com:CJentzsch/cpp-ethereum.git","clone_url":"https://github.com/CJentzsch/cpp-ethereum.git","svn_url":"https://github.com/CJentzsch/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":23824,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"db7b5484f2edc067d0ddb2f9be8413ddc612bf30","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-05-15T07:29:28Z","pushed_at":"2015-05-15T15:36:22Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":99360,"stargazers_count":467,"watchers_count":467,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":164,"forks":165,"open_issues":164,"watchers":467,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1911"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1911"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1911"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1911/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1911/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1911/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/38bf18de816a6d62fcfae5c656b72633eeaa66cb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gavofyork","id":138296,"avatar_url":"https://avatars.githubusercontent.com/u/138296?v=3","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":12,"changed_files":1}}