{"action":"created","issue":{"url":"https://api.github.com/repos/ailon/PhoneNameResolver/issues/11","labels_url":"https://api.github.com/repos/ailon/PhoneNameResolver/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/ailon/PhoneNameResolver/issues/11/comments","events_url":"https://api.github.com/repos/ailon/PhoneNameResolver/issues/11/events","html_url":"https://github.com/ailon/PhoneNameResolver/issues/11","id":55377479,"number":11,"title":"Redundant information in last commit","user":{"login":"patrickfrei","id":7906165,"avatar_url":"https://avatars.githubusercontent.com/u/7906165?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickfrei","html_url":"https://github.com/patrickfrei","followers_url":"https://api.github.com/users/patrickfrei/followers","following_url":"https://api.github.com/users/patrickfrei/following{/other_user}","gists_url":"https://api.github.com/users/patrickfrei/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickfrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickfrei/subscriptions","organizations_url":"https://api.github.com/users/patrickfrei/orgs","repos_url":"https://api.github.com/users/patrickfrei/repos","events_url":"https://api.github.com/users/patrickfrei/events{/privacy}","received_events_url":"https://api.github.com/users/patrickfrei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-24T17:01:04Z","updated_at":"2015-02-22T11:52:43Z","closed_at":null,"body":"Hi ailon,\r\n\r\nIn lines 235-238: Why don't you just simly write...\r\nresult.CanonicalManufacturer = manufacturer;\r\n...?\r\n\r\nAnd in line 219:\r\nCanonicalManufacturer = manufacturer,\r\n\r\nFrom the switch/case statement in lines 25-26, the variable \"manufacturer\" is always filled with the respective manufacturer name (either Nokia or Microsoft). This would make the code easier and would also prevent an implementation of redundant Information, such as \"CanonicalManufacturer=\"MICROSOFT\" (see lines 522-525).  \r\n\r\nWhat do you think?\r\n\r\nBest regards,\r\nPatrick"},"comment":{"url":"https://api.github.com/repos/ailon/PhoneNameResolver/issues/comments/75432001","html_url":"https://github.com/ailon/PhoneNameResolver/issues/11#issuecomment-75432001","issue_url":"https://api.github.com/repos/ailon/PhoneNameResolver/issues/11","id":75432001,"user":{"login":"patrickfrei","id":7906165,"avatar_url":"https://avatars.githubusercontent.com/u/7906165?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickfrei","html_url":"https://github.com/patrickfrei","followers_url":"https://api.github.com/users/patrickfrei/followers","following_url":"https://api.github.com/users/patrickfrei/following{/other_user}","gists_url":"https://api.github.com/users/patrickfrei/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickfrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickfrei/subscriptions","organizations_url":"https://api.github.com/users/patrickfrei/orgs","repos_url":"https://api.github.com/users/patrickfrei/repos","events_url":"https://api.github.com/users/patrickfrei/events{/privacy}","received_events_url":"https://api.github.com/users/patrickfrei/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T11:52:43Z","updated_at":"2015-02-22T11:52:43Z","body":"Ok, thank you for your feedback!"}}