{"action":"created","issue":{"url":"https://api.github.com/repos/cloudwalkio/fleet-browser/issues/4","labels_url":"https://api.github.com/repos/cloudwalkio/fleet-browser/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/cloudwalkio/fleet-browser/issues/4/comments","events_url":"https://api.github.com/repos/cloudwalkio/fleet-browser/issues/4/events","html_url":"https://github.com/cloudwalkio/fleet-browser/issues/4","id":75340332,"number":4,"title":"Creating new units with multi-line commands can fail","user":{"login":"allanino","id":5325241,"avatar_url":"https://avatars.githubusercontent.com/u/5325241?v=3","gravatar_id":"","url":"https://api.github.com/users/allanino","html_url":"https://github.com/allanino","followers_url":"https://api.github.com/users/allanino/followers","following_url":"https://api.github.com/users/allanino/following{/other_user}","gists_url":"https://api.github.com/users/allanino/gists{/gist_id}","starred_url":"https://api.github.com/users/allanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanino/subscriptions","organizations_url":"https://api.github.com/users/allanino/orgs","repos_url":"https://api.github.com/users/allanino/repos","events_url":"https://api.github.com/users/allanino/events{/privacy}","received_events_url":"https://api.github.com/users/allanino/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-11T20:03:40Z","updated_at":"2015-06-03T19:16:31Z","closed_at":"2015-06-03T19:16:31Z","body":"The current function used to serialize unit files to JSON is a bit limited: https://github.com/cloudwalkio/fleet-browser/blob/master/app.py#L28\r\n\r\nIt doesn't work very well with multi-line commands. Fleet uses a go package to handle that: https://github.com/coreos/fleet/blob/077109f4dd5c99ed034cbed8307db9d516db9fc9/Godeps/_workspace/src/github.com/coreos/go-systemd/unit/deserialize.go\r\n\r\nWe should create something similar for Python."},"comment":{"url":"https://api.github.com/repos/cloudwalkio/fleet-browser/issues/comments/108585317","html_url":"https://github.com/cloudwalkio/fleet-browser/issues/4#issuecomment-108585317","issue_url":"https://api.github.com/repos/cloudwalkio/fleet-browser/issues/4","id":108585317,"user":{"login":"allanino","id":5325241,"avatar_url":"https://avatars.githubusercontent.com/u/5325241?v=3","gravatar_id":"","url":"https://api.github.com/users/allanino","html_url":"https://github.com/allanino","followers_url":"https://api.github.com/users/allanino/followers","following_url":"https://api.github.com/users/allanino/following{/other_user}","gists_url":"https://api.github.com/users/allanino/gists{/gist_id}","starred_url":"https://api.github.com/users/allanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanino/subscriptions","organizations_url":"https://api.github.com/users/allanino/orgs","repos_url":"https://api.github.com/users/allanino/repos","events_url":"https://api.github.com/users/allanino/events{/privacy}","received_events_url":"https://api.github.com/users/allanino/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T19:16:31Z","updated_at":"2015-06-03T19:16:31Z","body":"We haven't found any case of units not working properly after the commit above.\r\n\r\nAs this seems to handle the majority of cases and is much simpler than the proposed approach, I'm closing this for now.\r\n\r\nIf anyone found problems related to this, feel free to reopen this issue."}}