{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/test/issues/118","labels_url":"https://api.github.com/repos/dart-lang/test/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/test/issues/118/comments","events_url":"https://api.github.com/repos/dart-lang/test/issues/118/events","html_url":"https://github.com/dart-lang/test/pull/118","id":78744366,"number":118,"title":"Convert most Future-based code to async/await","user":{"login":"nex3","id":188,"avatar_url":"https://avatars.githubusercontent.com/u/188?v=3","gravatar_id":"","url":"https://api.github.com/users/nex3","html_url":"https://github.com/nex3","followers_url":"https://api.github.com/users/nex3/followers","following_url":"https://api.github.com/users/nex3/following{/other_user}","gists_url":"https://api.github.com/users/nex3/gists{/gist_id}","starred_url":"https://api.github.com/users/nex3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nex3/subscriptions","organizations_url":"https://api.github.com/users/nex3/orgs","repos_url":"https://api.github.com/users/nex3/repos","events_url":"https://api.github.com/users/nex3/events{/privacy}","received_events_url":"https://api.github.com/users/nex3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-20T23:34:52Z","updated_at":"2015-05-21T00:24:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dart-lang/test/pulls/118","html_url":"https://github.com/dart-lang/test/pull/118","diff_url":"https://github.com/dart-lang/test/pull/118.diff","patch_url":"https://github.com/dart-lang/test/pull/118.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dart-lang/test/118)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dart-lang/test/issues/comments/104078251","html_url":"https://github.com/dart-lang/test/pull/118#issuecomment-104078251","issue_url":"https://api.github.com/repos/dart-lang/test/issues/118","id":104078251,"user":{"login":"kevmoo","id":17034,"avatar_url":"https://avatars.githubusercontent.com/u/17034?v=3","gravatar_id":"","url":"https://api.github.com/users/kevmoo","html_url":"https://github.com/kevmoo","followers_url":"https://api.github.com/users/kevmoo/followers","following_url":"https://api.github.com/users/kevmoo/following{/other_user}","gists_url":"https://api.github.com/users/kevmoo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevmoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevmoo/subscriptions","organizations_url":"https://api.github.com/users/kevmoo/orgs","repos_url":"https://api.github.com/users/kevmoo/repos","events_url":"https://api.github.com/users/kevmoo/events{/privacy}","received_events_url":"https://api.github.com/users/kevmoo/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T00:24:09Z","updated_at":"2015-05-21T00:24:09Z","body":"See comments, especially String copy snafu. Otherwise, lgtm\n\n---\n\nReview status: all files reviewed, 4 unresolved discussions, some commit checks failed.\nReviewed files:\n- lib/pub_serve.dart @ r1\n- lib/src/backend/declarer.dart @ r1\n- lib/src/backend/group.dart @ r1\n- lib/src/backend/invoker.dart @ r1\n- lib/src/backend/live_test_controller.dart @ r1\n- lib/src/executable.dart @ r1\n- lib/src/runner/browser/browser_manager.dart @ r1\n- lib/src/runner/browser/chrome.dart @ r1\n- lib/src/runner/browser/compiler_pool.dart @ r1\n- lib/src/runner/browser/content_shell.dart @ r1\n- lib/src/runner/browser/dartium.dart @ r1\n- lib/src/runner/browser/firefox.dart @ r1\n- lib/src/runner/browser/iframe_listener.dart @ r1\n- lib/src/runner/browser/internet_explorer.dart @ r1\n- lib/src/runner/browser/phantom_js.dart @ r1\n- lib/src/runner/browser/safari.dart @ r1\n- lib/src/runner/browser/server.dart @ r1\n- lib/src/runner/browser/static/host.dart @ r1\n- lib/src/runner/engine.dart @ r1\n- lib/src/runner/loader.dart @ r1\n- lib/src/runner/reporter/compact.dart @ r1\n- lib/src/runner/reporter/expanded.dart @ r1\n- lib/src/runner/vm/isolate_listener.dart @ r1\n- lib/src/runner/vm/isolate_test.dart @ r1\n- lib/src/util/async_thunk.dart @ r1\n- lib/src/util/dart.dart @ r1\n- lib/src/util/io.dart @ r1\n- lib/src/util/isolate_wrapper.dart @ r1\n- lib/src/utils.dart @ r1\n- lib/test.dart @ r1\n- pubspec.yaml @ r1\n- test/backend/declarer_test.dart @ r1\n- test/backend/invoker_test.dart @ r1\n- test/frontend/expect_async_test.dart @ r1\n- test/frontend/matcher/completion_test.dart @ r1\n- test/frontend/matcher/prints_test.dart @ r1\n- test/frontend/matcher/throws_test.dart @ r1\n- test/frontend/matcher/throws_type_test.dart @ r1\n- test/io.dart @ r1\n- test/runner/browser/chrome_test.dart @ r1\n- test/runner/browser/content_shell_test.dart @ r1\n- test/runner/browser/dartium_test.dart @ r1\n- test/runner/browser/firefox_test.dart @ r1\n- test/runner/browser/internet_explorer_test.dart @ r1\n- test/runner/browser/loader_test.dart @ r1\n- test/runner/browser/phantom_js_test.dart @ r1\n- test/runner/browser/safari_test.dart @ r1\n- test/runner/engine_test.dart @ r1\n- test/runner/expanded_reporter_test.dart @ r1\n- test/runner/isolate_listener_test.dart @ r1\n- test/runner/loader_test.dart @ r1\n- test/runner/pub_serve_test.dart @ r1\n- test/runner/signal_test.dart @ r1\n- test/util/multi_channel_test.dart @ r1\n- test/util/one_off_handler_test.dart @ r1\n- test/util/path_handler_test.dart @ r1\n- test/utils.dart @ r1\n\n---\n\n<sup>**[lib/src/runner/browser/compiler_pool.dart, line 107 \\[r1\\]](https://reviewable.io:443/reviews/dart-lang/test/118#-JpnpsGGbIFU0JJF7QYf)** ([raw file](https://github.com/dart-lang/test/blob/e96b6a8d0dab42f2d3cbfcbdc7d8d5beb956d9b9/lib/src/runner/browser/compiler_pool.dart#L107)):</sup>\nAt least explain why you do it this way. I think I get it, but it feels weird...\n\n---\n\n<sup>**[lib/src/runner/browser/safari.dart, line 78 \\[r1\\]](https://reviewable.io:443/reviews/dart-lang/test/118#-JpnoZxXVKCPwmJlOQOP)** ([raw file](https://github.com/dart-lang/test/blob/e96b6a8d0dab42f2d3cbfcbdc7d8d5beb956d9b9/lib/src/runner/browser/safari.dart#L78)):</sup>\n`\"Failed to start Safari...`\n\n---\n\n<sup>**[lib/src/util/isolate_wrapper.dart, line 10 \\[r1\\]](https://reviewable.io:443/reviews/dart-lang/test/118#-JpnnduF4Q2esO2h5C5_)** ([raw file](https://github.com/dart-lang/test/blob/e96b6a8d0dab42f2d3cbfcbdc7d8d5beb956d9b9/lib/src/util/isolate_wrapper.dart#L10)):</sup>\nUnused.\n\n---\n\n<sup>**[test/runner/isolate_listener_test.dart, line 17 \\[r1\\]](https://reviewable.io:443/reviews/dart-lang/test/118#-JpnnlcwzgS96RiaaP8w)** ([raw file](https://github.com/dart-lang/test/blob/e96b6a8d0dab42f2d3cbfcbdc7d8d5beb956d9b9/test/runner/isolate_listener_test.dart#L17)):</sup>\nunused\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/dart-lang/test/118)\n<!-- Sent from Reviewable.io -->\n"}}