{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/22571476","id":22571476,"diff_hunk":"@@ -4404,6 +4404,9 @@ void PushOp::encode(bufferlist &bl) const\n   ENCODE_START(1, 1, bl);\n   ::encode(soid, bl);\n   ::encode(version, bl);\n+  ::encode(compression, bl);\n+  ::encode(src_len, bl);\n+  ::encode(src_data_crc, bl);","path":"src/osd/osd_types.cc","position":6,"original_position":6,"commit_id":"5294e4f6c2eef0d38e5a2ae0c3eaff658282bd64","original_commit_id":"5294e4f6c2eef0d38e5a2ae0c3eaff658282bd64","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"new fields need to go at the end, and we need to bump the version in the ENCODE_START macros.  but, i'm not sure we want to add this here...","created_at":"2015-01-07T05:20:51Z","updated_at":"2015-01-07T05:20:51Z","html_url":"https://github.com/ceph/ceph/pull/3303#discussion_r22571476","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/3303","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/22571476"},"html":{"href":"https://github.com/ceph/ceph/pull/3303#discussion_r22571476"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3303"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/3303","id":26934188,"html_url":"https://github.com/ceph/ceph/pull/3303","diff_url":"https://github.com/ceph/ceph/pull/3303.diff","patch_url":"https://github.com/ceph/ceph/pull/3303.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/3303","number":3303,"state":"open","locked":false,"title":"osd: compress data in recovery process","user":{"login":"XinzeChi","id":3147032,"avatar_url":"https://avatars.githubusercontent.com/u/3147032?v=3","gravatar_id":"","url":"https://api.github.com/users/XinzeChi","html_url":"https://github.com/XinzeChi","followers_url":"https://api.github.com/users/XinzeChi/followers","following_url":"https://api.github.com/users/XinzeChi/following{/other_user}","gists_url":"https://api.github.com/users/XinzeChi/gists{/gist_id}","starred_url":"https://api.github.com/users/XinzeChi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XinzeChi/subscriptions","organizations_url":"https://api.github.com/users/XinzeChi/orgs","repos_url":"https://api.github.com/users/XinzeChi/repos","events_url":"https://api.github.com/users/XinzeChi/events{/privacy}","received_events_url":"https://api.github.com/users/XinzeChi/received_events","type":"User","site_admin":false},"body":"Ceph may run out of network bandwith in recovery process, compress data if needed. \r\n\r\nBy default, I will use lz4. Maybe we can shoose any compression algorithm by user as ec pools does.\r\n\r\nTo run of my patch, First of all, we should install lz4 from https://code.google.com/p/lz4/.\r\n\r\nSigned-off-by: Xinze Chi <xmdxcxz@gmail.com>","created_at":"2015-01-07T02:38:06Z","updated_at":"2015-01-07T05:20:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb02691bf8e4c82632a7c1a089fc284b417f340","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/3303/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/3303/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/3303/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/5294e4f6c2eef0d38e5a2ae0c3eaff658282bd64","head":{"label":"XinzeChi:wip-push-compress","ref":"wip-push-compress","sha":"5294e4f6c2eef0d38e5a2ae0c3eaff658282bd64","user":{"login":"XinzeChi","id":3147032,"avatar_url":"https://avatars.githubusercontent.com/u/3147032?v=3","gravatar_id":"","url":"https://api.github.com/users/XinzeChi","html_url":"https://github.com/XinzeChi","followers_url":"https://api.github.com/users/XinzeChi/followers","following_url":"https://api.github.com/users/XinzeChi/following{/other_user}","gists_url":"https://api.github.com/users/XinzeChi/gists{/gist_id}","starred_url":"https://api.github.com/users/XinzeChi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XinzeChi/subscriptions","organizations_url":"https://api.github.com/users/XinzeChi/orgs","repos_url":"https://api.github.com/users/XinzeChi/repos","events_url":"https://api.github.com/users/XinzeChi/events{/privacy}","received_events_url":"https://api.github.com/users/XinzeChi/received_events","type":"User","site_admin":false},"repo":{"id":25850756,"name":"ceph","full_name":"XinzeChi/ceph","owner":{"login":"XinzeChi","id":3147032,"avatar_url":"https://avatars.githubusercontent.com/u/3147032?v=3","gravatar_id":"","url":"https://api.github.com/users/XinzeChi","html_url":"https://github.com/XinzeChi","followers_url":"https://api.github.com/users/XinzeChi/followers","following_url":"https://api.github.com/users/XinzeChi/following{/other_user}","gists_url":"https://api.github.com/users/XinzeChi/gists{/gist_id}","starred_url":"https://api.github.com/users/XinzeChi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XinzeChi/subscriptions","organizations_url":"https://api.github.com/users/XinzeChi/orgs","repos_url":"https://api.github.com/users/XinzeChi/repos","events_url":"https://api.github.com/users/XinzeChi/events{/privacy}","received_events_url":"https://api.github.com/users/XinzeChi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/XinzeChi/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/XinzeChi/ceph","forks_url":"https://api.github.com/repos/XinzeChi/ceph/forks","keys_url":"https://api.github.com/repos/XinzeChi/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XinzeChi/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XinzeChi/ceph/teams","hooks_url":"https://api.github.com/repos/XinzeChi/ceph/hooks","issue_events_url":"https://api.github.com/repos/XinzeChi/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/XinzeChi/ceph/events","assignees_url":"https://api.github.com/repos/XinzeChi/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/XinzeChi/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/XinzeChi/ceph/tags","blobs_url":"https://api.github.com/repos/XinzeChi/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XinzeChi/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XinzeChi/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/XinzeChi/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XinzeChi/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/XinzeChi/ceph/languages","stargazers_url":"https://api.github.com/repos/XinzeChi/ceph/stargazers","contributors_url":"https://api.github.com/repos/XinzeChi/ceph/contributors","subscribers_url":"https://api.github.com/repos/XinzeChi/ceph/subscribers","subscription_url":"https://api.github.com/repos/XinzeChi/ceph/subscription","commits_url":"https://api.github.com/repos/XinzeChi/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/XinzeChi/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/XinzeChi/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/XinzeChi/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/XinzeChi/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/XinzeChi/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XinzeChi/ceph/merges","archive_url":"https://api.github.com/repos/XinzeChi/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XinzeChi/ceph/downloads","issues_url":"https://api.github.com/repos/XinzeChi/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/XinzeChi/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/XinzeChi/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/XinzeChi/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XinzeChi/ceph/labels{/name}","releases_url":"https://api.github.com/repos/XinzeChi/ceph/releases{/id}","created_at":"2014-10-28T03:06:13Z","updated_at":"2014-10-28T03:19:44Z","pushed_at":"2015-01-07T03:44:50Z","git_url":"git://github.com/XinzeChi/ceph.git","ssh_url":"git@github.com:XinzeChi/ceph.git","clone_url":"https://github.com/XinzeChi/ceph.git","svn_url":"https://github.com/XinzeChi/ceph","homepage":"http://ceph.com","size":95221,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"6fd348fe43399a882906646004bf3f5a4cf9dabb","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-01-06T23:24:52Z","pushed_at":"2015-01-07T02:06:10Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":321775,"stargazers_count":1071,"watchers_count":1071,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":542,"mirror_url":null,"open_issues_count":87,"forks":542,"open_issues":87,"watchers":1071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3303"},"html":{"href":"https://github.com/ceph/ceph/pull/3303"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/3303"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/3303/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3303/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3303/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/5294e4f6c2eef0d38e5a2ae0c3eaff658282bd64"}}}}