{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1914","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1914/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1914/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1914/events","html_url":"https://github.com/ipfs/go-ipfs/pull/1914","id":114216503,"number":1914,"title":"fix webui log hanging bug","user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/RFCR","name":"RFCR","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-10-30T07:25:41Z","updated_at":"2015-11-08T23:55:33Z","closed_at":"2015-11-08T23:50:31Z","pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1914","html_url":"https://github.com/ipfs/go-ipfs/pull/1914","diff_url":"https://github.com/ipfs/go-ipfs/pull/1914.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1914.patch"},"body":"the webui can currently cause the entire daemon to deadlock because the writer set up when it queries the log endpoints is never closed (and will hang on writes). This causes all the calls to any log function to hang and subsequently deadlocks the daemon.\r\n\r\nI beleive this is the root cause of 1896, and after this PR, I am unable to repro by messing around via the webui.\r\n\r\nInterestingly, i was never able to get a repro via curl... only in-browser."},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/154887733","html_url":"https://github.com/ipfs/go-ipfs/pull/1914#issuecomment-154887733","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1914","id":154887733,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T23:55:33Z","updated_at":"2015-11-08T23:55:33Z","body":"@jbenet in the future, could you just say \"RFM\" or something and let me rebase and merge it in so we can get a straight line of history?"}}