{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/comments/45617658","id":45617658,"diff_hunk":"@@ -98,13 +99,15 @@ function isValidFTEmail(address) {\n }\n \n function isWhiteListedDomain(address) {\n-\t/*istanbul ignore else*/\n-  if (config.domainRegex) {\n-    let ftRegEx = new RegExp(config.domainRegex, 'i');\n-    return validator.isEmail(address) && ftRegEx.test(address);\n+  /*istanbul ignore else*/\n+  if (whiteListedDomains.length > 0) {\n+    return whiteListedDomains.some( function isWhiteListed(domain) {","path":"app/util/validator.js","position":null,"original_position":18,"commit_id":"7af6ada8bae860cf74bbc6cecf28cd6d347e29ed","original_commit_id":"65f19f57c393602580b65791129594e2dcdbd5db","user":{"login":"geek-caroline","id":1362205,"avatar_url":"https://avatars.githubusercontent.com/u/1362205?v=3","gravatar_id":"","url":"https://api.github.com/users/geek-caroline","html_url":"https://github.com/geek-caroline","followers_url":"https://api.github.com/users/geek-caroline/followers","following_url":"https://api.github.com/users/geek-caroline/following{/other_user}","gists_url":"https://api.github.com/users/geek-caroline/gists{/gist_id}","starred_url":"https://api.github.com/users/geek-caroline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek-caroline/subscriptions","organizations_url":"https://api.github.com/users/geek-caroline/orgs","repos_url":"https://api.github.com/users/geek-caroline/repos","events_url":"https://api.github.com/users/geek-caroline/events{/privacy}","received_events_url":"https://api.github.com/users/geek-caroline/received_events","type":"User","site_admin":false},"body":"Done :)","created_at":"2015-11-23T15:41:30Z","updated_at":"2015-11-23T15:41:30Z","html_url":"https://github.com/Financial-Times/simple-email-service/pull/42#discussion_r45617658","pull_request_url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/comments/45617658"},"html":{"href":"https://github.com/Financial-Times/simple-email-service/pull/42#discussion_r45617658"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42","id":50968736,"html_url":"https://github.com/Financial-Times/simple-email-service/pull/42","diff_url":"https://github.com/Financial-Times/simple-email-service/pull/42.diff","patch_url":"https://github.com/Financial-Times/simple-email-service/pull/42.patch","issue_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/42","number":42,"state":"open","locked":false,"title":"Changing whitelisted domain regex's to be a comma delimted list of do…","user":{"login":"geek-caroline","id":1362205,"avatar_url":"https://avatars.githubusercontent.com/u/1362205?v=3","gravatar_id":"","url":"https://api.github.com/users/geek-caroline","html_url":"https://github.com/geek-caroline","followers_url":"https://api.github.com/users/geek-caroline/followers","following_url":"https://api.github.com/users/geek-caroline/following{/other_user}","gists_url":"https://api.github.com/users/geek-caroline/gists{/gist_id}","starred_url":"https://api.github.com/users/geek-caroline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek-caroline/subscriptions","organizations_url":"https://api.github.com/users/geek-caroline/orgs","repos_url":"https://api.github.com/users/geek-caroline/repos","events_url":"https://api.github.com/users/geek-caroline/events{/privacy}","received_events_url":"https://api.github.com/users/geek-caroline/received_events","type":"User","site_admin":false},"body":"…mains and internalising the creation of regex's into the code","created_at":"2015-11-17T16:24:52Z","updated_at":"2015-11-23T15:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b7055f334a2ad092779bcde2cd86f48bee5bd19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/42/comments","statuses_url":"https://api.github.com/repos/Financial-Times/simple-email-service/statuses/7af6ada8bae860cf74bbc6cecf28cd6d347e29ed","head":{"label":"Financial-Times:internalise-regex-sending-domain","ref":"internalise-regex-sending-domain","sha":"7af6ada8bae860cf74bbc6cecf28cd6d347e29ed","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":36355348,"name":"simple-email-service","full_name":"Financial-Times/simple-email-service","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/simple-email-service","description":"A simple email api service.","fork":false,"url":"https://api.github.com/repos/Financial-Times/simple-email-service","forks_url":"https://api.github.com/repos/Financial-Times/simple-email-service/forks","keys_url":"https://api.github.com/repos/Financial-Times/simple-email-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/simple-email-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/simple-email-service/teams","hooks_url":"https://api.github.com/repos/Financial-Times/simple-email-service/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/simple-email-service/events","assignees_url":"https://api.github.com/repos/Financial-Times/simple-email-service/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/simple-email-service/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/simple-email-service/tags","blobs_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/simple-email-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/simple-email-service/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/simple-email-service/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/simple-email-service/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/simple-email-service/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/simple-email-service/subscription","commits_url":"https://api.github.com/repos/Financial-Times/simple-email-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/simple-email-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/simple-email-service/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/simple-email-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/simple-email-service/merges","archive_url":"https://api.github.com/repos/Financial-Times/simple-email-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/simple-email-service/downloads","issues_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/simple-email-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/simple-email-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/simple-email-service/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/simple-email-service/releases{/id}","created_at":"2015-05-27T08:57:49Z","updated_at":"2015-05-27T11:25:46Z","pushed_at":"2015-11-23T15:28:44Z","git_url":"git://github.com/Financial-Times/simple-email-service.git","ssh_url":"git@github.com:Financial-Times/simple-email-service.git","clone_url":"https://github.com/Financial-Times/simple-email-service.git","svn_url":"https://github.com/Financial-Times/simple-email-service","homepage":null,"size":226,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"019ff641b6bad70115253389ad4df05eae50cb53","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":36355348,"name":"simple-email-service","full_name":"Financial-Times/simple-email-service","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/simple-email-service","description":"A simple email api service.","fork":false,"url":"https://api.github.com/repos/Financial-Times/simple-email-service","forks_url":"https://api.github.com/repos/Financial-Times/simple-email-service/forks","keys_url":"https://api.github.com/repos/Financial-Times/simple-email-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/simple-email-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/simple-email-service/teams","hooks_url":"https://api.github.com/repos/Financial-Times/simple-email-service/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/simple-email-service/events","assignees_url":"https://api.github.com/repos/Financial-Times/simple-email-service/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/simple-email-service/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/simple-email-service/tags","blobs_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/simple-email-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/simple-email-service/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/simple-email-service/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/simple-email-service/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/simple-email-service/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/simple-email-service/subscription","commits_url":"https://api.github.com/repos/Financial-Times/simple-email-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/simple-email-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/simple-email-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/simple-email-service/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/simple-email-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/simple-email-service/merges","archive_url":"https://api.github.com/repos/Financial-Times/simple-email-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/simple-email-service/downloads","issues_url":"https://api.github.com/repos/Financial-Times/simple-email-service/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/simple-email-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/simple-email-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/simple-email-service/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/simple-email-service/releases{/id}","created_at":"2015-05-27T08:57:49Z","updated_at":"2015-05-27T11:25:46Z","pushed_at":"2015-11-23T15:28:44Z","git_url":"git://github.com/Financial-Times/simple-email-service.git","ssh_url":"git@github.com:Financial-Times/simple-email-service.git","clone_url":"https://github.com/Financial-Times/simple-email-service.git","svn_url":"https://github.com/Financial-Times/simple-email-service","homepage":null,"size":226,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42"},"html":{"href":"https://github.com/Financial-Times/simple-email-service/pull/42"},"issue":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/42"},"comments":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/simple-email-service/statuses/7af6ada8bae860cf74bbc6cecf28cd6d347e29ed"}}}}