{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/44706394","id":44706394,"diff_hunk":"@@ -149,16 +149,7 @@ def customiseSimL1EmulatorForPostLS1_25ns(process):\n def customiseSimL1EmulatorForPostLS1_Additional_HI(process):\n     # set the Stage 1 heavy ions-specific parameters\n     # all of these should eventually end up in a GT\n-    if hasattr(process,'RCTConfigProducers'):\n-        process.RCTConfigProducers.eicIsolationThreshold = cms.uint32(7)\n-        process.RCTConfigProducers.hOeCut = cms.double(999)\n-        process.RCTConfigProducers.eMinForHoECut = cms.double(999)\n-        process.RCTConfigProducers.eMaxForHoECut = cms.double(999)\n-        process.RCTConfigProducers.hMinForHoECut = cms.double(999)\n-        process.RCTConfigProducers.eMinForFGCut = cms.double(999)\n-    if hasattr(process,'caloStage1Params'):     \n-        process.caloStage1Params.jetSeedThreshold = cms.double(0.)\n-        process.caloStage1Params.regionPUSType = cms.string(\"zeroWall\")\n+    process.load('L1Trigger.L1TCalorimeter.caloStage1Params_HI_cfi')","path":"L1Trigger/L1TCommon/python/customsPostLS1.py","position":23,"original_position":23,"commit_id":"73780c6ea15bcd4e8475e6ad6a997cc0e5f51fc0","original_commit_id":"73780c6ea15bcd4e8475e6ad6a997cc0e5f51fc0","user":{"login":"richard-cms","id":4851503,"avatar_url":"https://avatars.githubusercontent.com/u/4851503?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-cms","html_url":"https://github.com/richard-cms","followers_url":"https://api.github.com/users/richard-cms/followers","following_url":"https://api.github.com/users/richard-cms/following{/other_user}","gists_url":"https://api.github.com/users/richard-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-cms/subscriptions","organizations_url":"https://api.github.com/users/richard-cms/orgs","repos_url":"https://api.github.com/users/richard-cms/repos","events_url":"https://api.github.com/users/richard-cms/events{/privacy}","received_events_url":"https://api.github.com/users/richard-cms/received_events","type":"User","site_admin":false},"body":"To my knowledge this settings are not used during RECO (we don't re-emulate L1 except during DQM and MC generation).","created_at":"2015-11-12T19:57:34Z","updated_at":"2015-11-12T19:57:34Z","html_url":"https://github.com/cms-sw/cmssw/pull/12364#discussion_r44706394","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/44706394"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/12364#discussion_r44706394"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364","id":50301708,"html_url":"https://github.com/cms-sw/cmssw/pull/12364","diff_url":"https://github.com/cms-sw/cmssw/pull/12364.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12364.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12364","number":12364,"state":"closed","locked":false,"title":"Set default HI Stage1 parameters","user":{"login":"richard-cms","id":4851503,"avatar_url":"https://avatars.githubusercontent.com/u/4851503?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-cms","html_url":"https://github.com/richard-cms","followers_url":"https://api.github.com/users/richard-cms/followers","following_url":"https://api.github.com/users/richard-cms/following{/other_user}","gists_url":"https://api.github.com/users/richard-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-cms/subscriptions","organizations_url":"https://api.github.com/users/richard-cms/orgs","repos_url":"https://api.github.com/users/richard-cms/repos","events_url":"https://api.github.com/users/richard-cms/events{/privacy}","received_events_url":"https://api.github.com/users/richard-cms/received_events","type":"User","site_admin":false},"body":"@mulhearn @mandrenguyen \r\nThis PR sets the default Stage1 Level-1 trigger parameters that we expect to use during data taking. It is meant to be merged before we start the HI MC campaign, but is not critical for data taking.\r\n\r\nHowever, since we expect to get a new GT with a proper payload soon, I will also make a PR which removes the override so that we will properly pull from the GT.\r\n\r\nPersonally, I think that we should merge both PRs at once and just make the new GT quickly, because the current customization settings are junk (before this PR) and then we will get the new conditions right when the new GT shows up without having to wait for yet another PR merge. Others can comment on whether this is a good idea or not.","created_at":"2015-11-10T19:48:35Z","updated_at":"2015-11-12T19:57:34Z","closed_at":"2015-11-12T14:28:40Z","merged_at":"2015-11-12T14:28:39Z","merge_commit_sha":"75cf04a6cc5d8dcd9dabd605b2b9cd7ec1a3c3ed","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":1506,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-11-12T14:28:40Z","due_on":"2015-05-31T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12364/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/73780c6ea15bcd4e8475e6ad6a997cc0e5f51fc0","head":{"label":"richard-cms:defaultHIParams_75X","ref":"defaultHIParams_75X","sha":"73780c6ea15bcd4e8475e6ad6a997cc0e5f51fc0","user":{"login":"richard-cms","id":4851503,"avatar_url":"https://avatars.githubusercontent.com/u/4851503?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-cms","html_url":"https://github.com/richard-cms","followers_url":"https://api.github.com/users/richard-cms/followers","following_url":"https://api.github.com/users/richard-cms/following{/other_user}","gists_url":"https://api.github.com/users/richard-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-cms/subscriptions","organizations_url":"https://api.github.com/users/richard-cms/orgs","repos_url":"https://api.github.com/users/richard-cms/repos","events_url":"https://api.github.com/users/richard-cms/events{/privacy}","received_events_url":"https://api.github.com/users/richard-cms/received_events","type":"User","site_admin":false},"repo":{"id":11765869,"name":"cmssw","full_name":"richard-cms/cmssw","owner":{"login":"richard-cms","id":4851503,"avatar_url":"https://avatars.githubusercontent.com/u/4851503?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-cms","html_url":"https://github.com/richard-cms","followers_url":"https://api.github.com/users/richard-cms/followers","following_url":"https://api.github.com/users/richard-cms/following{/other_user}","gists_url":"https://api.github.com/users/richard-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-cms/subscriptions","organizations_url":"https://api.github.com/users/richard-cms/orgs","repos_url":"https://api.github.com/users/richard-cms/repos","events_url":"https://api.github.com/users/richard-cms/events{/privacy}","received_events_url":"https://api.github.com/users/richard-cms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richard-cms/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/richard-cms/cmssw","forks_url":"https://api.github.com/repos/richard-cms/cmssw/forks","keys_url":"https://api.github.com/repos/richard-cms/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richard-cms/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richard-cms/cmssw/teams","hooks_url":"https://api.github.com/repos/richard-cms/cmssw/hooks","issue_events_url":"https://api.github.com/repos/richard-cms/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/richard-cms/cmssw/events","assignees_url":"https://api.github.com/repos/richard-cms/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/richard-cms/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/richard-cms/cmssw/tags","blobs_url":"https://api.github.com/repos/richard-cms/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richard-cms/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richard-cms/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/richard-cms/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richard-cms/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/richard-cms/cmssw/languages","stargazers_url":"https://api.github.com/repos/richard-cms/cmssw/stargazers","contributors_url":"https://api.github.com/repos/richard-cms/cmssw/contributors","subscribers_url":"https://api.github.com/repos/richard-cms/cmssw/subscribers","subscription_url":"https://api.github.com/repos/richard-cms/cmssw/subscription","commits_url":"https://api.github.com/repos/richard-cms/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/richard-cms/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/richard-cms/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/richard-cms/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/richard-cms/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/richard-cms/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richard-cms/cmssw/merges","archive_url":"https://api.github.com/repos/richard-cms/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richard-cms/cmssw/downloads","issues_url":"https://api.github.com/repos/richard-cms/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/richard-cms/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/richard-cms/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/richard-cms/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richard-cms/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/richard-cms/cmssw/releases{/id}","created_at":"2013-07-30T13:36:21Z","updated_at":"2014-06-13T12:43:02Z","pushed_at":"2015-11-10T19:55:00Z","git_url":"git://github.com/richard-cms/cmssw.git","ssh_url":"git@github.com:richard-cms/cmssw.git","clone_url":"https://github.com/richard-cms/cmssw.git","svn_url":"https://github.com/richard-cms/cmssw","homepage":"cms-sw.github.io/cmssw","size":762591,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_5_X","ref":"CMSSW_7_5_X","sha":"10ca840124f688e353b07dcd0954f27d0f8e11f9","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-11-12T14:10:31Z","pushed_at":"2015-11-12T19:56:16Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1321246,"stargazers_count":270,"watchers_count":270,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1620,"mirror_url":null,"open_issues_count":266,"forks":1620,"open_issues":266,"watchers":270,"default_branch":"CMSSW_8_0_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/12364"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/12364"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/12364/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12364/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/73780c6ea15bcd4e8475e6ad6a997cc0e5f51fc0"}}}}