{"action":"created","issue":{"url":"https://api.github.com/repos/IQSS/dataverse/issues/2422","labels_url":"https://api.github.com/repos/IQSS/dataverse/issues/2422/labels{/name}","comments_url":"https://api.github.com/repos/IQSS/dataverse/issues/2422/comments","events_url":"https://api.github.com/repos/IQSS/dataverse/issues/2422/events","html_url":"https://github.com/IQSS/dataverse/pull/2422","id":98277944,"number":2422,"title":"Use more generics, less trailing whitespace in the dataverse package (#775)","user":{"login":"bencomp","id":1303898,"avatar_url":"https://avatars.githubusercontent.com/u/1303898?v=3","gravatar_id":"","url":"https://api.github.com/users/bencomp","html_url":"https://github.com/bencomp","followers_url":"https://api.github.com/users/bencomp/followers","following_url":"https://api.github.com/users/bencomp/following{/other_user}","gists_url":"https://api.github.com/users/bencomp/gists{/gist_id}","starred_url":"https://api.github.com/users/bencomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencomp/subscriptions","organizations_url":"https://api.github.com/users/bencomp/orgs","repos_url":"https://api.github.com/users/bencomp/repos","events_url":"https://api.github.com/users/bencomp/events{/privacy}","received_events_url":"https://api.github.com/users/bencomp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-30T22:27:12Z","updated_at":"2015-08-03T20:19:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IQSS/dataverse/pulls/2422","html_url":"https://github.com/IQSS/dataverse/pull/2422","diff_url":"https://github.com/IQSS/dataverse/pull/2422.diff","patch_url":"https://github.com/IQSS/dataverse/pull/2422.patch"},"body":"- Use diamond operators or explicitly typed `List`s or `Map`s.\r\n- Use typed queries, don't use casts when unnecessary.\r\n- Make `ingestableAsTabular(DataFile dataFile)` return `false` when the input is `null` (instead of \"unknown\"/\"other\").\r\n- Add Javadoc to `getFileAccessRequesters`.\r\n- Turn some comments into javadoc by adding that extra asterisk.\r\n- Remove trailing whitespace using Netbeans.\r\n- Remove some preceding whitespace manually.\r\n\r\nIt really looks more scary than it is."},"comment":{"url":"https://api.github.com/repos/IQSS/dataverse/issues/comments/127395673","html_url":"https://github.com/IQSS/dataverse/pull/2422#issuecomment-127395673","issue_url":"https://api.github.com/repos/IQSS/dataverse/issues/2422","id":127395673,"user":{"login":"scolapasta","id":4268292,"avatar_url":"https://avatars.githubusercontent.com/u/4268292?v=3","gravatar_id":"","url":"https://api.github.com/users/scolapasta","html_url":"https://github.com/scolapasta","followers_url":"https://api.github.com/users/scolapasta/followers","following_url":"https://api.github.com/users/scolapasta/following{/other_user}","gists_url":"https://api.github.com/users/scolapasta/gists{/gist_id}","starred_url":"https://api.github.com/users/scolapasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scolapasta/subscriptions","organizations_url":"https://api.github.com/users/scolapasta/orgs","repos_url":"https://api.github.com/users/scolapasta/repos","events_url":"https://api.github.com/users/scolapasta/events{/privacy}","received_events_url":"https://api.github.com/users/scolapasta/received_events","type":"User","site_admin":false},"created_at":"2015-08-03T20:19:51Z","updated_at":"2015-08-03T20:19:51Z","body":"@landreev can you review this pull request, in particular the are around:\r\nMake ingestableAsTabular(DataFile dataFile) return false when the input is null (instead of \"unknown\"/\"other\")."}}