{"action":"created","issue":{"url":"https://api.github.com/repos/akka/akka/issues/17643","labels_url":"https://api.github.com/repos/akka/akka/issues/17643/labels{/name}","comments_url":"https://api.github.com/repos/akka/akka/issues/17643/comments","events_url":"https://api.github.com/repos/akka/akka/issues/17643/events","html_url":"https://github.com/akka/akka/pull/17643","id":84443357,"number":17643,"title":"per #17384 - Generalised Security Directives to accept Bearer Token Authentication","user":{"login":"pjan","id":98241,"avatar_url":"https://avatars.githubusercontent.com/u/98241?v=3","gravatar_id":"","url":"https://api.github.com/users/pjan","html_url":"https://github.com/pjan","followers_url":"https://api.github.com/users/pjan/followers","following_url":"https://api.github.com/users/pjan/following{/other_user}","gists_url":"https://api.github.com/users/pjan/gists{/gist_id}","starred_url":"https://api.github.com/users/pjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjan/subscriptions","organizations_url":"https://api.github.com/users/pjan/orgs","repos_url":"https://api.github.com/users/pjan/repos","events_url":"https://api.github.com/users/pjan/events{/privacy}","received_events_url":"https://api.github.com/users/pjan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-03T08:53:14Z","updated_at":"2015-06-12T14:08:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17643","html_url":"https://github.com/akka/akka/pull/17643","diff_url":"https://github.com/akka/akka/pull/17643.diff","patch_url":"https://github.com/akka/akka/pull/17643.patch"},"body":"As per promise to @rkuhn, an improved shot to allow Bearer Token Authentication, taking into accounts the comments made by @jrudolph in #17384, post the #17502 merge. Since the `OAuth2BearerToken` is part of the akka codebase, I opted to add support for it within the http module rather than provide additional facilities to provide it as a third party library.\r\n\r\n- Renamed `UserCredentials` to the more general `Credentials`, and its `userName` param to the more appropriate `identifier` in case it covers both `HttpBasicAuthentication` and `BearerTokenAuthentication`.\r\n- Dropped `Basic` from the directives, as they now similarly accept `Authenticator`s that handle `BasicHttpCredentials` and `OAuth2BearerToken`\r\n- Added and amended the tests for both scala and java side"},"comment":{"url":"https://api.github.com/repos/akka/akka/issues/comments/111506488","html_url":"https://github.com/akka/akka/pull/17643#issuecomment-111506488","issue_url":"https://api.github.com/repos/akka/akka/issues/17643","id":111506488,"user":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=3","gravatar_id":"","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T14:08:57Z","updated_at":"2015-06-12T14:08:57Z","body":"Ah, why is this PR tagged as \"per\", I thought this is persistence related :)"}}