{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/ENSL/ensl.org/pulls/13","id":34589229,"html_url":"https://github.com/ENSL/ensl.org/pull/13","diff_url":"https://github.com/ENSL/ensl.org/pull/13.diff","patch_url":"https://github.com/ENSL/ensl.org/pull/13.patch","issue_url":"https://api.github.com/repos/ENSL/ensl.org/issues/13","number":13,"state":"closed","locked":false,"title":"Fix error page for when the 404 is user not found","user":{"login":"cblanc","id":2160685,"avatar_url":"https://avatars.githubusercontent.com/u/2160685?v=3","gravatar_id":"","url":"https://api.github.com/users/cblanc","html_url":"https://github.com/cblanc","followers_url":"https://api.github.com/users/cblanc/followers","following_url":"https://api.github.com/users/cblanc/following{/other_user}","gists_url":"https://api.github.com/users/cblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/cblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblanc/subscriptions","organizations_url":"https://api.github.com/users/cblanc/orgs","repos_url":"https://api.github.com/users/cblanc/repos","events_url":"https://api.github.com/users/cblanc/events{/privacy}","received_events_url":"https://api.github.com/users/cblanc/received_events","type":"User","site_admin":false},"body":"I think I found the cause of our non-deterministic CI errors on the develop branch. Hopefully should be green now\r\n\r\nThere was a race-condition which was playing out in CI test. Tests running on the headless browser were running async requests parallel to the salient test requests. Sometimes they would run after the test had finished and database_cleaner had wiped the database. This resulted (on occasion) a record not found error which renders a 404 page. We're getting errors because the 404 page also requires a user to render a theme if the browser is already signed in with a valid user. Since the user is deleted an `ActionView::Template::Error` would bubble up through the app\r\n\r\nThe fix is to remove the custom styling from error pages. I've set this to default. The async requests will still happen in the background and they will continue to 404 after the database cleaner has done its thing\r\n\r\n","created_at":"2015-05-02T18:03:53Z","updated_at":"2015-05-02T18:35:03Z","closed_at":"2015-05-02T18:35:03Z","merged_at":"2015-05-02T18:35:03Z","merge_commit_sha":"b7c4fb3567992084801369ec7ec4f4adcc1a3cc5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ENSL/ensl.org/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ENSL/ensl.org/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ENSL/ensl.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ENSL/ensl.org/issues/13/comments","statuses_url":"https://api.github.com/repos/ENSL/ensl.org/statuses/932652a7268d7296ceaaec414d092479b7cef2b7","head":{"label":"cblanc:error_page_fix","ref":"error_page_fix","sha":"932652a7268d7296ceaaec414d092479b7cef2b7","user":{"login":"cblanc","id":2160685,"avatar_url":"https://avatars.githubusercontent.com/u/2160685?v=3","gravatar_id":"","url":"https://api.github.com/users/cblanc","html_url":"https://github.com/cblanc","followers_url":"https://api.github.com/users/cblanc/followers","following_url":"https://api.github.com/users/cblanc/following{/other_user}","gists_url":"https://api.github.com/users/cblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/cblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblanc/subscriptions","organizations_url":"https://api.github.com/users/cblanc/orgs","repos_url":"https://api.github.com/users/cblanc/repos","events_url":"https://api.github.com/users/cblanc/events{/privacy}","received_events_url":"https://api.github.com/users/cblanc/received_events","type":"User","site_admin":false},"repo":{"id":34605916,"name":"ensl.org","full_name":"cblanc/ensl.org","owner":{"login":"cblanc","id":2160685,"avatar_url":"https://avatars.githubusercontent.com/u/2160685?v=3","gravatar_id":"","url":"https://api.github.com/users/cblanc","html_url":"https://github.com/cblanc","followers_url":"https://api.github.com/users/cblanc/followers","following_url":"https://api.github.com/users/cblanc/following{/other_user}","gists_url":"https://api.github.com/users/cblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/cblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblanc/subscriptions","organizations_url":"https://api.github.com/users/cblanc/orgs","repos_url":"https://api.github.com/users/cblanc/repos","events_url":"https://api.github.com/users/cblanc/events{/privacy}","received_events_url":"https://api.github.com/users/cblanc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cblanc/ensl.org","description":"The ENSL website. http://ensl.org","fork":true,"url":"https://api.github.com/repos/cblanc/ensl.org","forks_url":"https://api.github.com/repos/cblanc/ensl.org/forks","keys_url":"https://api.github.com/repos/cblanc/ensl.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cblanc/ensl.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cblanc/ensl.org/teams","hooks_url":"https://api.github.com/repos/cblanc/ensl.org/hooks","issue_events_url":"https://api.github.com/repos/cblanc/ensl.org/issues/events{/number}","events_url":"https://api.github.com/repos/cblanc/ensl.org/events","assignees_url":"https://api.github.com/repos/cblanc/ensl.org/assignees{/user}","branches_url":"https://api.github.com/repos/cblanc/ensl.org/branches{/branch}","tags_url":"https://api.github.com/repos/cblanc/ensl.org/tags","blobs_url":"https://api.github.com/repos/cblanc/ensl.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cblanc/ensl.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cblanc/ensl.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/cblanc/ensl.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cblanc/ensl.org/statuses/{sha}","languages_url":"https://api.github.com/repos/cblanc/ensl.org/languages","stargazers_url":"https://api.github.com/repos/cblanc/ensl.org/stargazers","contributors_url":"https://api.github.com/repos/cblanc/ensl.org/contributors","subscribers_url":"https://api.github.com/repos/cblanc/ensl.org/subscribers","subscription_url":"https://api.github.com/repos/cblanc/ensl.org/subscription","commits_url":"https://api.github.com/repos/cblanc/ensl.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/cblanc/ensl.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/cblanc/ensl.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/cblanc/ensl.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/cblanc/ensl.org/contents/{+path}","compare_url":"https://api.github.com/repos/cblanc/ensl.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cblanc/ensl.org/merges","archive_url":"https://api.github.com/repos/cblanc/ensl.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cblanc/ensl.org/downloads","issues_url":"https://api.github.com/repos/cblanc/ensl.org/issues{/number}","pulls_url":"https://api.github.com/repos/cblanc/ensl.org/pulls{/number}","milestones_url":"https://api.github.com/repos/cblanc/ensl.org/milestones{/number}","notifications_url":"https://api.github.com/repos/cblanc/ensl.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cblanc/ensl.org/labels{/name}","releases_url":"https://api.github.com/repos/cblanc/ensl.org/releases{/id}","created_at":"2015-04-26T09:40:52Z","updated_at":"2015-04-26T09:40:53Z","pushed_at":"2015-05-02T17:07:30Z","git_url":"git://github.com/cblanc/ensl.org.git","ssh_url":"git@github.com:cblanc/ensl.org.git","clone_url":"https://github.com/cblanc/ensl.org.git","svn_url":"https://github.com/cblanc/ensl.org","homepage":null,"size":49182,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ENSL:develop","ref":"develop","sha":"b6d932310fb82e39496b0f572a7ece226a471ee7","user":{"login":"ENSL","id":7022038,"avatar_url":"https://avatars.githubusercontent.com/u/7022038?v=3","gravatar_id":"","url":"https://api.github.com/users/ENSL","html_url":"https://github.com/ENSL","followers_url":"https://api.github.com/users/ENSL/followers","following_url":"https://api.github.com/users/ENSL/following{/other_user}","gists_url":"https://api.github.com/users/ENSL/gists{/gist_id}","starred_url":"https://api.github.com/users/ENSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ENSL/subscriptions","organizations_url":"https://api.github.com/users/ENSL/orgs","repos_url":"https://api.github.com/users/ENSL/repos","events_url":"https://api.github.com/users/ENSL/events{/privacy}","received_events_url":"https://api.github.com/users/ENSL/received_events","type":"Organization","site_admin":false},"repo":{"id":18012876,"name":"ensl.org","full_name":"ENSL/ensl.org","owner":{"login":"ENSL","id":7022038,"avatar_url":"https://avatars.githubusercontent.com/u/7022038?v=3","gravatar_id":"","url":"https://api.github.com/users/ENSL","html_url":"https://github.com/ENSL","followers_url":"https://api.github.com/users/ENSL/followers","following_url":"https://api.github.com/users/ENSL/following{/other_user}","gists_url":"https://api.github.com/users/ENSL/gists{/gist_id}","starred_url":"https://api.github.com/users/ENSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ENSL/subscriptions","organizations_url":"https://api.github.com/users/ENSL/orgs","repos_url":"https://api.github.com/users/ENSL/repos","events_url":"https://api.github.com/users/ENSL/events{/privacy}","received_events_url":"https://api.github.com/users/ENSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ENSL/ensl.org","description":"The ENSL website. http://ensl.org","fork":false,"url":"https://api.github.com/repos/ENSL/ensl.org","forks_url":"https://api.github.com/repos/ENSL/ensl.org/forks","keys_url":"https://api.github.com/repos/ENSL/ensl.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ENSL/ensl.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ENSL/ensl.org/teams","hooks_url":"https://api.github.com/repos/ENSL/ensl.org/hooks","issue_events_url":"https://api.github.com/repos/ENSL/ensl.org/issues/events{/number}","events_url":"https://api.github.com/repos/ENSL/ensl.org/events","assignees_url":"https://api.github.com/repos/ENSL/ensl.org/assignees{/user}","branches_url":"https://api.github.com/repos/ENSL/ensl.org/branches{/branch}","tags_url":"https://api.github.com/repos/ENSL/ensl.org/tags","blobs_url":"https://api.github.com/repos/ENSL/ensl.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ENSL/ensl.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ENSL/ensl.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/ENSL/ensl.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ENSL/ensl.org/statuses/{sha}","languages_url":"https://api.github.com/repos/ENSL/ensl.org/languages","stargazers_url":"https://api.github.com/repos/ENSL/ensl.org/stargazers","contributors_url":"https://api.github.com/repos/ENSL/ensl.org/contributors","subscribers_url":"https://api.github.com/repos/ENSL/ensl.org/subscribers","subscription_url":"https://api.github.com/repos/ENSL/ensl.org/subscription","commits_url":"https://api.github.com/repos/ENSL/ensl.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/ENSL/ensl.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/ENSL/ensl.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/ENSL/ensl.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/ENSL/ensl.org/contents/{+path}","compare_url":"https://api.github.com/repos/ENSL/ensl.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ENSL/ensl.org/merges","archive_url":"https://api.github.com/repos/ENSL/ensl.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ENSL/ensl.org/downloads","issues_url":"https://api.github.com/repos/ENSL/ensl.org/issues{/number}","pulls_url":"https://api.github.com/repos/ENSL/ensl.org/pulls{/number}","milestones_url":"https://api.github.com/repos/ENSL/ensl.org/milestones{/number}","notifications_url":"https://api.github.com/repos/ENSL/ensl.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ENSL/ensl.org/labels{/name}","releases_url":"https://api.github.com/repos/ENSL/ensl.org/releases{/id}","created_at":"2014-03-22T15:39:53Z","updated_at":"2015-04-30T22:49:03Z","pushed_at":"2015-05-02T18:35:03Z","git_url":"git://github.com/ENSL/ensl.org.git","ssh_url":"git@github.com:ENSL/ensl.org.git","clone_url":"https://github.com/ENSL/ensl.org.git","svn_url":"https://github.com/ENSL/ensl.org","homepage":null,"size":49881,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ENSL/ensl.org/pulls/13"},"html":{"href":"https://github.com/ENSL/ensl.org/pull/13"},"issue":{"href":"https://api.github.com/repos/ENSL/ensl.org/issues/13"},"comments":{"href":"https://api.github.com/repos/ENSL/ensl.org/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ENSL/ensl.org/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ENSL/ensl.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ENSL/ensl.org/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ENSL/ensl.org/statuses/932652a7268d7296ceaaec414d092479b7cef2b7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"simplefl","id":11397995,"avatar_url":"https://avatars.githubusercontent.com/u/11397995?v=3","gravatar_id":"","url":"https://api.github.com/users/simplefl","html_url":"https://github.com/simplefl","followers_url":"https://api.github.com/users/simplefl/followers","following_url":"https://api.github.com/users/simplefl/following{/other_user}","gists_url":"https://api.github.com/users/simplefl/gists{/gist_id}","starred_url":"https://api.github.com/users/simplefl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplefl/subscriptions","organizations_url":"https://api.github.com/users/simplefl/orgs","repos_url":"https://api.github.com/users/simplefl/repos","events_url":"https://api.github.com/users/simplefl/events{/privacy}","received_events_url":"https://api.github.com/users/simplefl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}