{"action":"created","issue":{"url":"https://api.github.com/repos/diydrones/ardupilot/issues/2804","labels_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2804/labels{/name}","comments_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2804/comments","events_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2804/events","html_url":"https://github.com/diydrones/ardupilot/pull/2804","id":104919133,"number":2804,"title":"Adding RSSI to logging","user":{"login":"StewLG","id":7128339,"avatar_url":"https://avatars.githubusercontent.com/u/7128339?v=3","gravatar_id":"","url":"https://api.github.com/users/StewLG","html_url":"https://github.com/StewLG","followers_url":"https://api.github.com/users/StewLG/followers","following_url":"https://api.github.com/users/StewLG/following{/other_user}","gists_url":"https://api.github.com/users/StewLG/gists{/gist_id}","starred_url":"https://api.github.com/users/StewLG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StewLG/subscriptions","organizations_url":"https://api.github.com/users/StewLG/orgs","repos_url":"https://api.github.com/users/StewLG/repos","events_url":"https://api.github.com/users/StewLG/events{/privacy}","received_events_url":"https://api.github.com/users/StewLG/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-09-04T15:59:59Z","updated_at":"2015-09-07T15:38:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/diydrones/ardupilot/pulls/2804","html_url":"https://github.com/diydrones/ardupilot/pull/2804","diff_url":"https://github.com/diydrones/ardupilot/pull/2804.diff","patch_url":"https://github.com/diydrones/ardupilot/pull/2804.patch"},"body":"Adding RSSI value to logging using new RSSI library.\r\n\r\nCloses #2021. Closes  #2245. See also http://diydrones.com/forum/topics/is-rxrssi-not-being-logged-by-apm-at-all-1, and #2798, where @tridge asks for a log with rssi.\r\n\r\n![rssidemo](https://cloud.githubusercontent.com/assets/7128339/9688363/95105e0c-52e3-11e5-9c4e-f5622825593a.png)"},"comment":{"url":"https://api.github.com/repos/diydrones/ardupilot/issues/comments/138326867","html_url":"https://github.com/diydrones/ardupilot/pull/2804#issuecomment-138326867","issue_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2804","id":138326867,"user":{"login":"StewLG","id":7128339,"avatar_url":"https://avatars.githubusercontent.com/u/7128339?v=3","gravatar_id":"","url":"https://api.github.com/users/StewLG","html_url":"https://github.com/StewLG","followers_url":"https://api.github.com/users/StewLG/followers","following_url":"https://api.github.com/users/StewLG/following{/other_user}","gists_url":"https://api.github.com/users/StewLG/gists{/gist_id}","starred_url":"https://api.github.com/users/StewLG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StewLG/subscriptions","organizations_url":"https://api.github.com/users/StewLG/orgs","repos_url":"https://api.github.com/users/StewLG/repos","events_url":"https://api.github.com/users/StewLG/events{/privacy}","received_events_url":"https://api.github.com/users/StewLG/received_events","type":"User","site_admin":false},"created_at":"2015-09-07T15:38:50Z","updated_at":"2015-09-07T15:38:50Z","body":"> Maybe you can check how many characters we can fit into RCIN? It may be none in which case a new \r\n> message is the only solution and what you've done is then fine!\r\n\r\nThis fails to compile:\r\n\r\n    { LOG_RCIN_MSG, sizeof(log_RCIN), \\\r\n      \"RCIN\",  \"Qhhhhhhhhhhhhhhf\",     \"TimeUS,C1,C2,C3,C4,C5,C6,C7,C8,C9,C10,C11,C12,C13,C14,R\" }, \\\r\n\r\nSo, I believe I cannot add a field to RCIN, period. \r\n\r\n> If we think that we will put the RSSI values of all known links to the GCS in this message then maybe the \r\n> field could be \"RC\" for radio control? If we get the info from the 3DR radio in there we could have another \r\n> field called \"Telem\" eventually.\r\n\r\nI think I'm with Tom here that I'd be expecting rxrssi for the name so that it will line up with the rest of the UI, in particular the status panel:\r\n\r\n![rxrssi](https://cloud.githubusercontent.com/assets/7128339/9719673/7bb2b5cc-553b-11e5-87bc-c4860582085d.png)\r\n\r\nI could have it go RXRSSI -> RXRSSI, but that forecloses this ever being expanded to other kinds of RSSI. So I prefer RSSI->RXRSSI, which is the original PR, as submitted. \r\n\r\n"}}