{"action":"created","issue":{"url":"https://api.github.com/repos/magit/magit/issues/1911","labels_url":"https://api.github.com/repos/magit/magit/issues/1911/labels{/name}","comments_url":"https://api.github.com/repos/magit/magit/issues/1911/comments","events_url":"https://api.github.com/repos/magit/magit/issues/1911/events","html_url":"https://github.com/magit/magit/pull/1911","id":90387621,"number":1911,"title":"ssh-w32: new functions for ssh-agent on w32","user":{"login":"npostavs","id":287742,"avatar_url":"https://avatars.githubusercontent.com/u/287742?v=3","gravatar_id":"","url":"https://api.github.com/users/npostavs","html_url":"https://github.com/npostavs","followers_url":"https://api.github.com/users/npostavs/followers","following_url":"https://api.github.com/users/npostavs/following{/other_user}","gists_url":"https://api.github.com/users/npostavs/gists{/gist_id}","starred_url":"https://api.github.com/users/npostavs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npostavs/subscriptions","organizations_url":"https://api.github.com/users/npostavs/orgs","repos_url":"https://api.github.com/users/npostavs/repos","events_url":"https://api.github.com/users/npostavs/events{/privacy}","received_events_url":"https://api.github.com/users/npostavs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-23T13:22:30Z","updated_at":"2015-06-24T12:39:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/magit/magit/pulls/1911","html_url":"https://github.com/magit/magit/pull/1911","diff_url":"https://github.com/magit/magit/pull/1911.diff","patch_url":"https://github.com/magit/magit/pull/1911.patch"},"body":"Context: https://github.com/magit/magit/issues/1810#issuecomment-108123470\r\n\r\nI'm still a bit unsure about\r\n\r\n- naming\r\n- whether this should depend on magit for locating the executables (that's the current code), or is it better to avoid dependency and copy the logic instead?\r\n- entry points. Currently using `add-advice` on `magit-push` (might need `magit-fetch`, and `magit-pull` as well)."},"comment":{"url":"https://api.github.com/repos/magit/magit/issues/comments/114852684","html_url":"https://github.com/magit/magit/pull/1911#issuecomment-114852684","issue_url":"https://api.github.com/repos/magit/magit/issues/1911","id":114852684,"user":{"login":"tarsius","id":25046,"avatar_url":"https://avatars.githubusercontent.com/u/25046?v=3","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T12:39:29Z","updated_at":"2015-06-24T12:39:29Z","body":"> naming\r\n\r\nIn Emacs there are some windows specific libraries and I believe their names *begin* with `w32-`. Maybe do the same here. Or maybe something that implies \"it just works\" or \"servants doing the dirty work for you\", oh oh! what about `daphne.el`? (I've been watching a lot of Frasier lately).\r\n\r\n> entry points\r\n\r\nI think it should be kept in a separate repository. In any case it should be a separate elpa package since the free world doesn't need it and because it could be used by other packages that don't depend on magit themselves. Unlike `with-editor` which also can be used outside of magit, it additionally is only a optional dependency of magit - that's why I would treat these two libraries differently. \r\n\r\n> is it better to avoid dependency and copy the logic instead?\r\n\r\n....so: yes.\r\n\r\n> might need magit-fetch, and magit-pull as well\r\n\r\nThere's little doubt, now is there?\r\n\r\n> add-advice\r\n\r\nI might add hooks, but for now that seems fine.\r\n\r\nThe library headers has some problems, e.g. I am not the author."}}