{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/Vincit/moron.js/pulls/4","id":38732168,"html_url":"https://github.com/Vincit/moron.js/pull/4","diff_url":"https://github.com/Vincit/moron.js/pull/4.diff","patch_url":"https://github.com/Vincit/moron.js/pull/4.patch","issue_url":"https://api.github.com/repos/Vincit/moron.js/issues/4","number":4,"state":"open","locked":false,"title":"Enable running integration tests with other databases, even if one does not exist","user":{"login":"elhigu","id":696345,"avatar_url":"https://avatars.githubusercontent.com/u/696345?v=3","gravatar_id":"","url":"https://api.github.com/users/elhigu","html_url":"https://github.com/elhigu","followers_url":"https://api.github.com/users/elhigu/followers","following_url":"https://api.github.com/users/elhigu/following{/other_user}","gists_url":"https://api.github.com/users/elhigu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhigu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhigu/subscriptions","organizations_url":"https://api.github.com/users/elhigu/orgs","repos_url":"https://api.github.com/users/elhigu/repos","events_url":"https://api.github.com/users/elhigu/events{/privacy}","received_events_url":"https://api.github.com/users/elhigu/received_events","type":"User","site_admin":false},"body":"before() calls creating integration test DBs were outside of all describes() running the tests on each database. This caused all integration tests to not be run even if just one database connection could not be made.\r\n\r\nBasically I was running tests without mysql and got just error:\r\n\r\n```\r\nMikaels-MacBook-Pro:moron.js mikaelle$ npm test\r\n\r\n> moron@0.1.2 test /Users/mikaelle/Projects/Vincit/moron.js\r\n> istanbul --config=.istanbul.yml cover _mocha -- --slow 10 --timeout 5000 --reporter spec --recursive tests\r\n\r\nLoading config: /Users/mikaelle/Projects/Vincit/moron.js/.istanbul.yml\r\n\r\n\r\n  integration tests\r\nKnex:Error Pool2 - Error: connect ECONNREFUSED\r\nKnex:Error Pool2 - Error: connect ECONNREFUSED\r\n    1) \"before all\" hook\r\n\r\n  MoronModel\r\n    ✓ should parse relations into Model instances and remove them from database representation (7ms)\r\n    ✓ if jsonSchema is given, should remove all but schema properties from database representation (16ms)\r\n    ✓ should convert objects to json based on jsonSchema type\r\n    ✓ should convert objects to json based on jsonAttributes array\r\n    ...\r\n```\r\n\r\nAfter fix: \r\n\r\n```\r\nMikaels-MacBook-Pro:moron.js mikaelle$ npm test\r\n\r\n> moron@0.1.2 test /Users/mikaelle/Projects/Vincit/moron.js\r\n> istanbul --config=.istanbul.yml cover _mocha -- --slow 10 --timeout 5000 --reporter spec --recursive tests\r\n\r\nLoading config: /Users/mikaelle/Projects/Vincit/moron.js/.istanbul.yml\r\n\r\n\r\n  integration tests\r\nKnex:Error Pool2 - Error: connect ECONNREFUSED\r\nKnex:Error Pool2 - Error: connect ECONNREFUSED\r\n    sqlite3\r\n      MoronModel find queries\r\n        .query()\r\n          ✓ should return all rows when no knex methods are chained (16ms)\r\n          knex methods\r\n            ✓ .select()\r\n            ✓ .where()\r\n  ...\r\n\r\n        ✓ should fail without models\r\n        ✓ should fail if one of the model classes is not a subclass of MoronModel\r\n        ✓ should fail if all ModelClasses are not bound to the same knex connection\r\n        ✓ should commit transaction if no errors occur (13ms)\r\n        ✓ should rollback if an error occurs (1) (10ms)\r\n        ✓ should rollback if an error occurs (2) (8ms)\r\n        ✓ should skip queries after rollback (16ms)\r\n    mysql\r\n      1) \"before all\" hook\r\n\r\n  MoronModel\r\n    ✓ should parse relations into Model instances and remove them from database representation (7ms)\r\n    ✓ if jsonSchema is given, should remove all but schema properties from database representation (10ms)\r\n    ✓ should convert objects to json based on jsonSchema type (24ms)\r\n    ✓ should convert objects to json based on jsonAttributes array (9ms)\r\n\r\n  MoronModelBase\r\n    extend\r\n      ✓ should create a subclass\r\n      ✓ should create a subclass of subclass\r\n      ✓ should fail if the subclass constructor has no name\r\n  ...\r\n```\r\n\r\nSo just one platform fails anymore.","created_at":"2015-06-28T21:24:16Z","updated_at":"2015-06-28T21:24:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Vincit/moron.js/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Vincit/moron.js/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Vincit/moron.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vincit/moron.js/issues/4/comments","statuses_url":"https://api.github.com/repos/Vincit/moron.js/statuses/643bc670330acd025f88137b38352445bdb12f7b","head":{"label":"elhigu:pr-better-error-message-of-missing-database","ref":"pr-better-error-message-of-missing-database","sha":"643bc670330acd025f88137b38352445bdb12f7b","user":{"login":"elhigu","id":696345,"avatar_url":"https://avatars.githubusercontent.com/u/696345?v=3","gravatar_id":"","url":"https://api.github.com/users/elhigu","html_url":"https://github.com/elhigu","followers_url":"https://api.github.com/users/elhigu/followers","following_url":"https://api.github.com/users/elhigu/following{/other_user}","gists_url":"https://api.github.com/users/elhigu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhigu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhigu/subscriptions","organizations_url":"https://api.github.com/users/elhigu/orgs","repos_url":"https://api.github.com/users/elhigu/repos","events_url":"https://api.github.com/users/elhigu/events{/privacy}","received_events_url":"https://api.github.com/users/elhigu/received_events","type":"User","site_admin":false},"repo":{"id":37878780,"name":"moron.js","full_name":"elhigu/moron.js","owner":{"login":"elhigu","id":696345,"avatar_url":"https://avatars.githubusercontent.com/u/696345?v=3","gravatar_id":"","url":"https://api.github.com/users/elhigu","html_url":"https://github.com/elhigu","followers_url":"https://api.github.com/users/elhigu/followers","following_url":"https://api.github.com/users/elhigu/following{/other_user}","gists_url":"https://api.github.com/users/elhigu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhigu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhigu/subscriptions","organizations_url":"https://api.github.com/users/elhigu/orgs","repos_url":"https://api.github.com/users/elhigu/repos","events_url":"https://api.github.com/users/elhigu/events{/privacy}","received_events_url":"https://api.github.com/users/elhigu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elhigu/moron.js","description":"A Node.js ORM that doesn't get in your way.","fork":true,"url":"https://api.github.com/repos/elhigu/moron.js","forks_url":"https://api.github.com/repos/elhigu/moron.js/forks","keys_url":"https://api.github.com/repos/elhigu/moron.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elhigu/moron.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elhigu/moron.js/teams","hooks_url":"https://api.github.com/repos/elhigu/moron.js/hooks","issue_events_url":"https://api.github.com/repos/elhigu/moron.js/issues/events{/number}","events_url":"https://api.github.com/repos/elhigu/moron.js/events","assignees_url":"https://api.github.com/repos/elhigu/moron.js/assignees{/user}","branches_url":"https://api.github.com/repos/elhigu/moron.js/branches{/branch}","tags_url":"https://api.github.com/repos/elhigu/moron.js/tags","blobs_url":"https://api.github.com/repos/elhigu/moron.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elhigu/moron.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elhigu/moron.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/elhigu/moron.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elhigu/moron.js/statuses/{sha}","languages_url":"https://api.github.com/repos/elhigu/moron.js/languages","stargazers_url":"https://api.github.com/repos/elhigu/moron.js/stargazers","contributors_url":"https://api.github.com/repos/elhigu/moron.js/contributors","subscribers_url":"https://api.github.com/repos/elhigu/moron.js/subscribers","subscription_url":"https://api.github.com/repos/elhigu/moron.js/subscription","commits_url":"https://api.github.com/repos/elhigu/moron.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/elhigu/moron.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/elhigu/moron.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/elhigu/moron.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/elhigu/moron.js/contents/{+path}","compare_url":"https://api.github.com/repos/elhigu/moron.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elhigu/moron.js/merges","archive_url":"https://api.github.com/repos/elhigu/moron.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elhigu/moron.js/downloads","issues_url":"https://api.github.com/repos/elhigu/moron.js/issues{/number}","pulls_url":"https://api.github.com/repos/elhigu/moron.js/pulls{/number}","milestones_url":"https://api.github.com/repos/elhigu/moron.js/milestones{/number}","notifications_url":"https://api.github.com/repos/elhigu/moron.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elhigu/moron.js/labels{/name}","releases_url":"https://api.github.com/repos/elhigu/moron.js/releases{/id}","created_at":"2015-06-22T20:25:13Z","updated_at":"2015-06-22T20:25:13Z","pushed_at":"2015-06-28T21:19:13Z","git_url":"git://github.com/elhigu/moron.js.git","ssh_url":"git@github.com:elhigu/moron.js.git","clone_url":"https://github.com/elhigu/moron.js.git","svn_url":"https://github.com/elhigu/moron.js","homepage":"","size":1104,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vincit:master","ref":"master","sha":"e976456460c5e20f94ebaf8ad26a46c2af4cbbc2","user":{"login":"Vincit","id":710715,"avatar_url":"https://avatars.githubusercontent.com/u/710715?v=3","gravatar_id":"","url":"https://api.github.com/users/Vincit","html_url":"https://github.com/Vincit","followers_url":"https://api.github.com/users/Vincit/followers","following_url":"https://api.github.com/users/Vincit/following{/other_user}","gists_url":"https://api.github.com/users/Vincit/gists{/gist_id}","starred_url":"https://api.github.com/users/Vincit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vincit/subscriptions","organizations_url":"https://api.github.com/users/Vincit/orgs","repos_url":"https://api.github.com/users/Vincit/repos","events_url":"https://api.github.com/users/Vincit/events{/privacy}","received_events_url":"https://api.github.com/users/Vincit/received_events","type":"Organization","site_admin":false},"repo":{"id":33925906,"name":"moron.js","full_name":"Vincit/moron.js","owner":{"login":"Vincit","id":710715,"avatar_url":"https://avatars.githubusercontent.com/u/710715?v=3","gravatar_id":"","url":"https://api.github.com/users/Vincit","html_url":"https://github.com/Vincit","followers_url":"https://api.github.com/users/Vincit/followers","following_url":"https://api.github.com/users/Vincit/following{/other_user}","gists_url":"https://api.github.com/users/Vincit/gists{/gist_id}","starred_url":"https://api.github.com/users/Vincit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vincit/subscriptions","organizations_url":"https://api.github.com/users/Vincit/orgs","repos_url":"https://api.github.com/users/Vincit/repos","events_url":"https://api.github.com/users/Vincit/events{/privacy}","received_events_url":"https://api.github.com/users/Vincit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vincit/moron.js","description":"A Node.js ORM that doesn't get in your way.","fork":false,"url":"https://api.github.com/repos/Vincit/moron.js","forks_url":"https://api.github.com/repos/Vincit/moron.js/forks","keys_url":"https://api.github.com/repos/Vincit/moron.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vincit/moron.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vincit/moron.js/teams","hooks_url":"https://api.github.com/repos/Vincit/moron.js/hooks","issue_events_url":"https://api.github.com/repos/Vincit/moron.js/issues/events{/number}","events_url":"https://api.github.com/repos/Vincit/moron.js/events","assignees_url":"https://api.github.com/repos/Vincit/moron.js/assignees{/user}","branches_url":"https://api.github.com/repos/Vincit/moron.js/branches{/branch}","tags_url":"https://api.github.com/repos/Vincit/moron.js/tags","blobs_url":"https://api.github.com/repos/Vincit/moron.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vincit/moron.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vincit/moron.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vincit/moron.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vincit/moron.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Vincit/moron.js/languages","stargazers_url":"https://api.github.com/repos/Vincit/moron.js/stargazers","contributors_url":"https://api.github.com/repos/Vincit/moron.js/contributors","subscribers_url":"https://api.github.com/repos/Vincit/moron.js/subscribers","subscription_url":"https://api.github.com/repos/Vincit/moron.js/subscription","commits_url":"https://api.github.com/repos/Vincit/moron.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vincit/moron.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vincit/moron.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vincit/moron.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vincit/moron.js/contents/{+path}","compare_url":"https://api.github.com/repos/Vincit/moron.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vincit/moron.js/merges","archive_url":"https://api.github.com/repos/Vincit/moron.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vincit/moron.js/downloads","issues_url":"https://api.github.com/repos/Vincit/moron.js/issues{/number}","pulls_url":"https://api.github.com/repos/Vincit/moron.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Vincit/moron.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Vincit/moron.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vincit/moron.js/labels{/name}","releases_url":"https://api.github.com/repos/Vincit/moron.js/releases{/id}","created_at":"2015-04-14T10:36:51Z","updated_at":"2015-06-19T16:49:18Z","pushed_at":"2015-06-22T18:36:55Z","git_url":"git://github.com/Vincit/moron.js.git","ssh_url":"git@github.com:Vincit/moron.js.git","clone_url":"https://github.com/Vincit/moron.js.git","svn_url":"https://github.com/Vincit/moron.js","homepage":"","size":1268,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vincit/moron.js/pulls/4"},"html":{"href":"https://github.com/Vincit/moron.js/pull/4"},"issue":{"href":"https://api.github.com/repos/Vincit/moron.js/issues/4"},"comments":{"href":"https://api.github.com/repos/Vincit/moron.js/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Vincit/moron.js/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Vincit/moron.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vincit/moron.js/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Vincit/moron.js/statuses/643bc670330acd025f88137b38352445bdb12f7b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":9,"changed_files":1}}