{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/42930708","id":42930708,"diff_hunk":"@@ -81,9 +81,9 @@ class Thread {\n \t/*\n \t * Waits for thread to finish.\n \t * Note:  This does not stop a thread, you have to do this on your own.\n-\t * Returns immediately if the thread is not started.\n+\t * Returns immediately if the thread is not started or has already finished.","path":"src/threading/thread.h","position":5,"original_position":5,"commit_id":"50af0c435d63721ba2df8e491123a1166f17815c","original_commit_id":"50af0c435d63721ba2df8e491123a1166f17815c","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"Perhaps also point out what it returns?","created_at":"2015-10-24T05:43:35Z","updated_at":"2015-10-24T05:43:35Z","html_url":"https://github.com/minetest/minetest/pull/3281#discussion_r42930708","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3281","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/42930708"},"html":{"href":"https://github.com/minetest/minetest/pull/3281#discussion_r42930708"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3281"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3281","id":48623920,"html_url":"https://github.com/minetest/minetest/pull/3281","diff_url":"https://github.com/minetest/minetest/pull/3281.diff","patch_url":"https://github.com/minetest/minetest/pull/3281.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3281","number":3281,"state":"open","locked":false,"title":"Fix some threading things and add additional thread unittests","user":{"login":"kwolekr","id":630595,"avatar_url":"https://avatars.githubusercontent.com/u/630595?v=3","gravatar_id":"","url":"https://api.github.com/users/kwolekr","html_url":"https://github.com/kwolekr","followers_url":"https://api.github.com/users/kwolekr/followers","following_url":"https://api.github.com/users/kwolekr/following{/other_user}","gists_url":"https://api.github.com/users/kwolekr/gists{/gist_id}","starred_url":"https://api.github.com/users/kwolekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwolekr/subscriptions","organizations_url":"https://api.github.com/users/kwolekr/orgs","repos_url":"https://api.github.com/users/kwolekr/repos","events_url":"https://api.github.com/users/kwolekr/events{/privacy}","received_events_url":"https://api.github.com/users/kwolekr/received_events","type":"User","site_admin":false},"body":"- Fix thread name reset on start()\r\n- Fully reset thread state on kill()\r\n- Add unittests to check for correct object states under various circumstances\r\n\r\nJust making a PR for the CI checks :-)","created_at":"2015-10-23T20:04:58Z","updated_at":"2015-10-24T05:43:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"501b7db5d2f9530a0e8378babb8cbfde876eaece","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3281/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3281/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3281/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/50af0c435d63721ba2df8e491123a1166f17815c","head":{"label":"kwolekr:master","ref":"master","sha":"50af0c435d63721ba2df8e491123a1166f17815c","user":{"login":"kwolekr","id":630595,"avatar_url":"https://avatars.githubusercontent.com/u/630595?v=3","gravatar_id":"","url":"https://api.github.com/users/kwolekr","html_url":"https://github.com/kwolekr","followers_url":"https://api.github.com/users/kwolekr/followers","following_url":"https://api.github.com/users/kwolekr/following{/other_user}","gists_url":"https://api.github.com/users/kwolekr/gists{/gist_id}","starred_url":"https://api.github.com/users/kwolekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwolekr/subscriptions","organizations_url":"https://api.github.com/users/kwolekr/orgs","repos_url":"https://api.github.com/users/kwolekr/repos","events_url":"https://api.github.com/users/kwolekr/events{/privacy}","received_events_url":"https://api.github.com/users/kwolekr/received_events","type":"User","site_admin":false},"repo":{"id":6432264,"name":"minetest","full_name":"kwolekr/minetest","owner":{"login":"kwolekr","id":630595,"avatar_url":"https://avatars.githubusercontent.com/u/630595?v=3","gravatar_id":"","url":"https://api.github.com/users/kwolekr","html_url":"https://github.com/kwolekr","followers_url":"https://api.github.com/users/kwolekr/followers","following_url":"https://api.github.com/users/kwolekr/following{/other_user}","gists_url":"https://api.github.com/users/kwolekr/gists{/gist_id}","starred_url":"https://api.github.com/users/kwolekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwolekr/subscriptions","organizations_url":"https://api.github.com/users/kwolekr/orgs","repos_url":"https://api.github.com/users/kwolekr/repos","events_url":"https://api.github.com/users/kwolekr/events{/privacy}","received_events_url":"https://api.github.com/users/kwolekr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwolekr/minetest","description":"Minetest-c55, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/celeron55/minetest_game]","fork":true,"url":"https://api.github.com/repos/kwolekr/minetest","forks_url":"https://api.github.com/repos/kwolekr/minetest/forks","keys_url":"https://api.github.com/repos/kwolekr/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwolekr/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwolekr/minetest/teams","hooks_url":"https://api.github.com/repos/kwolekr/minetest/hooks","issue_events_url":"https://api.github.com/repos/kwolekr/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/kwolekr/minetest/events","assignees_url":"https://api.github.com/repos/kwolekr/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/kwolekr/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/kwolekr/minetest/tags","blobs_url":"https://api.github.com/repos/kwolekr/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwolekr/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwolekr/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwolekr/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwolekr/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/kwolekr/minetest/languages","stargazers_url":"https://api.github.com/repos/kwolekr/minetest/stargazers","contributors_url":"https://api.github.com/repos/kwolekr/minetest/contributors","subscribers_url":"https://api.github.com/repos/kwolekr/minetest/subscribers","subscription_url":"https://api.github.com/repos/kwolekr/minetest/subscription","commits_url":"https://api.github.com/repos/kwolekr/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwolekr/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwolekr/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwolekr/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwolekr/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/kwolekr/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwolekr/minetest/merges","archive_url":"https://api.github.com/repos/kwolekr/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwolekr/minetest/downloads","issues_url":"https://api.github.com/repos/kwolekr/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/kwolekr/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/kwolekr/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/kwolekr/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwolekr/minetest/labels{/name}","releases_url":"https://api.github.com/repos/kwolekr/minetest/releases{/id}","created_at":"2012-10-28T21:25:16Z","updated_at":"2015-05-08T04:06:18Z","pushed_at":"2015-10-23T20:03:46Z","git_url":"git://github.com/kwolekr/minetest.git","ssh_url":"git@github.com:kwolekr/minetest.git","clone_url":"https://github.com/kwolekr/minetest.git","svn_url":"https://github.com/kwolekr/minetest","homepage":"http://minetest.net/","size":40831,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"c32847838d72c327031520c48b76607b63da4ccc","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-10-24T00:08:57Z","pushed_at":"2015-10-23T22:12:12Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":106896,"stargazers_count":1663,"watchers_count":1663,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":554,"mirror_url":null,"open_issues_count":641,"forks":554,"open_issues":641,"watchers":1663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3281"},"html":{"href":"https://github.com/minetest/minetest/pull/3281"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3281"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3281/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3281/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3281/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/50af0c435d63721ba2df8e491123a1166f17815c"}}}}