{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/30","id":30075487,"html_url":"https://github.com/christianalfoni/formsy-react/pull/30","diff_url":"https://github.com/christianalfoni/formsy-react/pull/30.diff","patch_url":"https://github.com/christianalfoni/formsy-react/pull/30.patch","issue_url":"https://api.github.com/repos/christianalfoni/formsy-react/issues/30","number":30,"state":"closed","locked":false,"title":"Actually check for invalid floats","user":{"login":"hahahana","id":2406167,"avatar_url":"https://avatars.githubusercontent.com/u/2406167?v=3","gravatar_id":"","url":"https://api.github.com/users/hahahana","html_url":"https://github.com/hahahana","followers_url":"https://api.github.com/users/hahahana/followers","following_url":"https://api.github.com/users/hahahana/following{/other_user}","gists_url":"https://api.github.com/users/hahahana/gists{/gist_id}","starred_url":"https://api.github.com/users/hahahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hahahana/subscriptions","organizations_url":"https://api.github.com/users/hahahana/orgs","repos_url":"https://api.github.com/users/hahahana/repos","events_url":"https://api.github.com/users/hahahana/events{/privacy}","received_events_url":"https://api.github.com/users/hahahana/received_events","type":"User","site_admin":false},"body":"Good morning! So I realized that my prior pull request doesn't actually check to make sure that strings like '1.' don't count as floats. \r\n\r\nHere's an eample of my lack of understanding about this regex/javascript's match\r\n````\r\n('1.').match(/[-+]?(\\d*[.])?\\d+/)\r\n>> [\"1\", undefined]\r\n````\r\n\r\nSo I figured we could just check if the match actually is the original string. What do you think?","created_at":"2015-02-26T13:02:18Z","updated_at":"2015-02-26T13:15:19Z","closed_at":"2015-02-26T13:15:19Z","merged_at":"2015-02-26T13:15:19Z","merge_commit_sha":"24c9c0f347fa3a4bac8b7d4a2299f1ebd2fa890e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/30/commits","review_comments_url":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/30/comments","review_comment_url":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/christianalfoni/formsy-react/issues/30/comments","statuses_url":"https://api.github.com/repos/christianalfoni/formsy-react/statuses/9ef8590f809b66275b3d159bba304931902e5923","head":{"label":"hahahana:isNumeric","ref":"isNumeric","sha":"9ef8590f809b66275b3d159bba304931902e5923","user":{"login":"hahahana","id":2406167,"avatar_url":"https://avatars.githubusercontent.com/u/2406167?v=3","gravatar_id":"","url":"https://api.github.com/users/hahahana","html_url":"https://github.com/hahahana","followers_url":"https://api.github.com/users/hahahana/followers","following_url":"https://api.github.com/users/hahahana/following{/other_user}","gists_url":"https://api.github.com/users/hahahana/gists{/gist_id}","starred_url":"https://api.github.com/users/hahahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hahahana/subscriptions","organizations_url":"https://api.github.com/users/hahahana/orgs","repos_url":"https://api.github.com/users/hahahana/repos","events_url":"https://api.github.com/users/hahahana/events{/privacy}","received_events_url":"https://api.github.com/users/hahahana/received_events","type":"User","site_admin":false},"repo":{"id":31325911,"name":"formsy-react","full_name":"hahahana/formsy-react","owner":{"login":"hahahana","id":2406167,"avatar_url":"https://avatars.githubusercontent.com/u/2406167?v=3","gravatar_id":"","url":"https://api.github.com/users/hahahana","html_url":"https://github.com/hahahana","followers_url":"https://api.github.com/users/hahahana/followers","following_url":"https://api.github.com/users/hahahana/following{/other_user}","gists_url":"https://api.github.com/users/hahahana/gists{/gist_id}","starred_url":"https://api.github.com/users/hahahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hahahana/subscriptions","organizations_url":"https://api.github.com/users/hahahana/orgs","repos_url":"https://api.github.com/users/hahahana/repos","events_url":"https://api.github.com/users/hahahana/events{/privacy}","received_events_url":"https://api.github.com/users/hahahana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hahahana/formsy-react","description":"A form input builder and validator for React JS","fork":true,"url":"https://api.github.com/repos/hahahana/formsy-react","forks_url":"https://api.github.com/repos/hahahana/formsy-react/forks","keys_url":"https://api.github.com/repos/hahahana/formsy-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hahahana/formsy-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hahahana/formsy-react/teams","hooks_url":"https://api.github.com/repos/hahahana/formsy-react/hooks","issue_events_url":"https://api.github.com/repos/hahahana/formsy-react/issues/events{/number}","events_url":"https://api.github.com/repos/hahahana/formsy-react/events","assignees_url":"https://api.github.com/repos/hahahana/formsy-react/assignees{/user}","branches_url":"https://api.github.com/repos/hahahana/formsy-react/branches{/branch}","tags_url":"https://api.github.com/repos/hahahana/formsy-react/tags","blobs_url":"https://api.github.com/repos/hahahana/formsy-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hahahana/formsy-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hahahana/formsy-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/hahahana/formsy-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hahahana/formsy-react/statuses/{sha}","languages_url":"https://api.github.com/repos/hahahana/formsy-react/languages","stargazers_url":"https://api.github.com/repos/hahahana/formsy-react/stargazers","contributors_url":"https://api.github.com/repos/hahahana/formsy-react/contributors","subscribers_url":"https://api.github.com/repos/hahahana/formsy-react/subscribers","subscription_url":"https://api.github.com/repos/hahahana/formsy-react/subscription","commits_url":"https://api.github.com/repos/hahahana/formsy-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/hahahana/formsy-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/hahahana/formsy-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/hahahana/formsy-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/hahahana/formsy-react/contents/{+path}","compare_url":"https://api.github.com/repos/hahahana/formsy-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hahahana/formsy-react/merges","archive_url":"https://api.github.com/repos/hahahana/formsy-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hahahana/formsy-react/downloads","issues_url":"https://api.github.com/repos/hahahana/formsy-react/issues{/number}","pulls_url":"https://api.github.com/repos/hahahana/formsy-react/pulls{/number}","milestones_url":"https://api.github.com/repos/hahahana/formsy-react/milestones{/number}","notifications_url":"https://api.github.com/repos/hahahana/formsy-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hahahana/formsy-react/labels{/name}","releases_url":"https://api.github.com/repos/hahahana/formsy-react/releases{/id}","created_at":"2015-02-25T17:20:39Z","updated_at":"2015-02-25T18:53:34Z","pushed_at":"2015-02-26T12:59:25Z","git_url":"git://github.com/hahahana/formsy-react.git","ssh_url":"git@github.com:hahahana/formsy-react.git","clone_url":"https://github.com/hahahana/formsy-react.git","svn_url":"https://github.com/hahahana/formsy-react","homepage":null,"size":802,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"christianalfoni:master","ref":"master","sha":"72a7be5d647dbedfdc69562e371064be4f434b4e","user":{"login":"christianalfoni","id":3956929,"avatar_url":"https://avatars.githubusercontent.com/u/3956929?v=3","gravatar_id":"","url":"https://api.github.com/users/christianalfoni","html_url":"https://github.com/christianalfoni","followers_url":"https://api.github.com/users/christianalfoni/followers","following_url":"https://api.github.com/users/christianalfoni/following{/other_user}","gists_url":"https://api.github.com/users/christianalfoni/gists{/gist_id}","starred_url":"https://api.github.com/users/christianalfoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianalfoni/subscriptions","organizations_url":"https://api.github.com/users/christianalfoni/orgs","repos_url":"https://api.github.com/users/christianalfoni/repos","events_url":"https://api.github.com/users/christianalfoni/events{/privacy}","received_events_url":"https://api.github.com/users/christianalfoni/received_events","type":"User","site_admin":false},"repo":{"id":25566711,"name":"formsy-react","full_name":"christianalfoni/formsy-react","owner":{"login":"christianalfoni","id":3956929,"avatar_url":"https://avatars.githubusercontent.com/u/3956929?v=3","gravatar_id":"","url":"https://api.github.com/users/christianalfoni","html_url":"https://github.com/christianalfoni","followers_url":"https://api.github.com/users/christianalfoni/followers","following_url":"https://api.github.com/users/christianalfoni/following{/other_user}","gists_url":"https://api.github.com/users/christianalfoni/gists{/gist_id}","starred_url":"https://api.github.com/users/christianalfoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianalfoni/subscriptions","organizations_url":"https://api.github.com/users/christianalfoni/orgs","repos_url":"https://api.github.com/users/christianalfoni/repos","events_url":"https://api.github.com/users/christianalfoni/events{/privacy}","received_events_url":"https://api.github.com/users/christianalfoni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christianalfoni/formsy-react","description":"A form input builder and validator for React JS","fork":false,"url":"https://api.github.com/repos/christianalfoni/formsy-react","forks_url":"https://api.github.com/repos/christianalfoni/formsy-react/forks","keys_url":"https://api.github.com/repos/christianalfoni/formsy-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christianalfoni/formsy-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christianalfoni/formsy-react/teams","hooks_url":"https://api.github.com/repos/christianalfoni/formsy-react/hooks","issue_events_url":"https://api.github.com/repos/christianalfoni/formsy-react/issues/events{/number}","events_url":"https://api.github.com/repos/christianalfoni/formsy-react/events","assignees_url":"https://api.github.com/repos/christianalfoni/formsy-react/assignees{/user}","branches_url":"https://api.github.com/repos/christianalfoni/formsy-react/branches{/branch}","tags_url":"https://api.github.com/repos/christianalfoni/formsy-react/tags","blobs_url":"https://api.github.com/repos/christianalfoni/formsy-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christianalfoni/formsy-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christianalfoni/formsy-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/christianalfoni/formsy-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christianalfoni/formsy-react/statuses/{sha}","languages_url":"https://api.github.com/repos/christianalfoni/formsy-react/languages","stargazers_url":"https://api.github.com/repos/christianalfoni/formsy-react/stargazers","contributors_url":"https://api.github.com/repos/christianalfoni/formsy-react/contributors","subscribers_url":"https://api.github.com/repos/christianalfoni/formsy-react/subscribers","subscription_url":"https://api.github.com/repos/christianalfoni/formsy-react/subscription","commits_url":"https://api.github.com/repos/christianalfoni/formsy-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/christianalfoni/formsy-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/christianalfoni/formsy-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/christianalfoni/formsy-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/christianalfoni/formsy-react/contents/{+path}","compare_url":"https://api.github.com/repos/christianalfoni/formsy-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christianalfoni/formsy-react/merges","archive_url":"https://api.github.com/repos/christianalfoni/formsy-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christianalfoni/formsy-react/downloads","issues_url":"https://api.github.com/repos/christianalfoni/formsy-react/issues{/number}","pulls_url":"https://api.github.com/repos/christianalfoni/formsy-react/pulls{/number}","milestones_url":"https://api.github.com/repos/christianalfoni/formsy-react/milestones{/number}","notifications_url":"https://api.github.com/repos/christianalfoni/formsy-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christianalfoni/formsy-react/labels{/name}","releases_url":"https://api.github.com/repos/christianalfoni/formsy-react/releases{/id}","created_at":"2014-10-22T06:58:33Z","updated_at":"2015-02-26T13:15:19Z","pushed_at":"2015-02-26T13:15:19Z","git_url":"git://github.com/christianalfoni/formsy-react.git","ssh_url":"git@github.com:christianalfoni/formsy-react.git","clone_url":"https://github.com/christianalfoni/formsy-react.git","svn_url":"https://github.com/christianalfoni/formsy-react","homepage":null,"size":802,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/30"},"html":{"href":"https://github.com/christianalfoni/formsy-react/pull/30"},"issue":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/issues/30"},"comments":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/christianalfoni/formsy-react/statuses/9ef8590f809b66275b3d159bba304931902e5923"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"christianalfoni","id":3956929,"avatar_url":"https://avatars.githubusercontent.com/u/3956929?v=3","gravatar_id":"","url":"https://api.github.com/users/christianalfoni","html_url":"https://github.com/christianalfoni","followers_url":"https://api.github.com/users/christianalfoni/followers","following_url":"https://api.github.com/users/christianalfoni/following{/other_user}","gists_url":"https://api.github.com/users/christianalfoni/gists{/gist_id}","starred_url":"https://api.github.com/users/christianalfoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianalfoni/subscriptions","organizations_url":"https://api.github.com/users/christianalfoni/orgs","repos_url":"https://api.github.com/users/christianalfoni/repos","events_url":"https://api.github.com/users/christianalfoni/events{/privacy}","received_events_url":"https://api.github.com/users/christianalfoni/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":34,"deletions":1,"changed_files":2}}