{"action":"opened","number":6888,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6888","id":48675263,"html_url":"https://github.com/bitcoin/bitcoin/pull/6888","diff_url":"https://github.com/bitcoin/bitcoin/pull/6888.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6888.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6888","number":6888,"state":"open","locked":false,"title":"Clear strMiscWarning before running PartitionAlert","user":{"login":"CodeShark","id":894059,"avatar_url":"https://avatars.githubusercontent.com/u/894059?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeShark","html_url":"https://github.com/CodeShark","followers_url":"https://api.github.com/users/CodeShark/followers","following_url":"https://api.github.com/users/CodeShark/following{/other_user}","gists_url":"https://api.github.com/users/CodeShark/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeShark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeShark/subscriptions","organizations_url":"https://api.github.com/users/CodeShark/orgs","repos_url":"https://api.github.com/users/CodeShark/repos","events_url":"https://api.github.com/users/CodeShark/events{/privacy}","received_events_url":"https://api.github.com/users/CodeShark/received_events","type":"User","site_admin":false},"body":"I was getting strange travis errors earlier because some test that was running prior to PartitionAlert in alert_tests apparently was setting the strMiscWarning variable. Using a side effect such as this as an error handling mechanism is probably not a very good idea to begin with...but if we're going to do this, we should make sure to reset the variable before each call so we can tell which one set it.","created_at":"2015-10-25T09:49:43Z","updated_at":"2015-10-25T09:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49262c2c914a703a7e6887a05dd85e0c8345f795","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6888/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6888/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6888/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/143d17396906835c3a3ccd59e202f5327c05f63f","head":{"label":"CodeShark:alert_tests","ref":"alert_tests","sha":"143d17396906835c3a3ccd59e202f5327c05f63f","user":{"login":"CodeShark","id":894059,"avatar_url":"https://avatars.githubusercontent.com/u/894059?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeShark","html_url":"https://github.com/CodeShark","followers_url":"https://api.github.com/users/CodeShark/followers","following_url":"https://api.github.com/users/CodeShark/following{/other_user}","gists_url":"https://api.github.com/users/CodeShark/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeShark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeShark/subscriptions","organizations_url":"https://api.github.com/users/CodeShark/orgs","repos_url":"https://api.github.com/users/CodeShark/repos","events_url":"https://api.github.com/users/CodeShark/events{/privacy}","received_events_url":"https://api.github.com/users/CodeShark/received_events","type":"User","site_admin":false},"repo":{"id":7239671,"name":"bitcoin","full_name":"CodeShark/bitcoin","owner":{"login":"CodeShark","id":894059,"avatar_url":"https://avatars.githubusercontent.com/u/894059?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeShark","html_url":"https://github.com/CodeShark","followers_url":"https://api.github.com/users/CodeShark/followers","following_url":"https://api.github.com/users/CodeShark/following{/other_user}","gists_url":"https://api.github.com/users/CodeShark/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeShark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeShark/subscriptions","organizations_url":"https://api.github.com/users/CodeShark/orgs","repos_url":"https://api.github.com/users/CodeShark/repos","events_url":"https://api.github.com/users/CodeShark/events{/privacy}","received_events_url":"https://api.github.com/users/CodeShark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CodeShark/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/CodeShark/bitcoin","forks_url":"https://api.github.com/repos/CodeShark/bitcoin/forks","keys_url":"https://api.github.com/repos/CodeShark/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeShark/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeShark/bitcoin/teams","hooks_url":"https://api.github.com/repos/CodeShark/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/CodeShark/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/CodeShark/bitcoin/events","assignees_url":"https://api.github.com/repos/CodeShark/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/CodeShark/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/CodeShark/bitcoin/tags","blobs_url":"https://api.github.com/repos/CodeShark/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeShark/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeShark/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeShark/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeShark/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeShark/bitcoin/languages","stargazers_url":"https://api.github.com/repos/CodeShark/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/CodeShark/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/CodeShark/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/CodeShark/bitcoin/subscription","commits_url":"https://api.github.com/repos/CodeShark/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeShark/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeShark/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeShark/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeShark/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/CodeShark/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeShark/bitcoin/merges","archive_url":"https://api.github.com/repos/CodeShark/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeShark/bitcoin/downloads","issues_url":"https://api.github.com/repos/CodeShark/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/CodeShark/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeShark/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeShark/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeShark/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/CodeShark/bitcoin/releases{/id}","created_at":"2012-12-19T11:35:37Z","updated_at":"2014-07-27T14:54:12Z","pushed_at":"2015-10-25T09:46:18Z","git_url":"git://github.com/CodeShark/bitcoin.git","ssh_url":"git@github.com:CodeShark/bitcoin.git","clone_url":"https://github.com/CodeShark/bitcoin.git","svn_url":"https://github.com/CodeShark/bitcoin","homepage":"http://www.bitcoin.org","size":55280,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"46f74379b86be982b121bcb8c3cfe07fa80bffd0","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-10-25T06:32:44Z","pushed_at":"2015-10-25T09:49:43Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":142700,"stargazers_count":7677,"watchers_count":7677,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5297,"mirror_url":null,"open_issues_count":456,"forks":5297,"open_issues":456,"watchers":7677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6888"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6888"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6888"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6888/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6888/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6888/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/143d17396906835c3a3ccd59e202f5327c05f63f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}