{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3888","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3888/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3888/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3888/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3888","id":57444630,"number":3888,"title":"Private visibility is toxic to extensibility","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-12T10:50:49Z","updated_at":"2015-02-12T11:00:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3888","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3888","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/3888.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/3888.patch"},"body":"See #3874 "},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/74053022","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3888#issuecomment-74053022","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3888","id":74053022,"user":{"login":"MatthewBonner","id":7858744,"avatar_url":"https://avatars.githubusercontent.com/u/7858744?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewBonner","html_url":"https://github.com/MatthewBonner","followers_url":"https://api.github.com/users/MatthewBonner/followers","following_url":"https://api.github.com/users/MatthewBonner/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBonner/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBonner/subscriptions","organizations_url":"https://api.github.com/users/MatthewBonner/orgs","repos_url":"https://api.github.com/users/MatthewBonner/repos","events_url":"https://api.github.com/users/MatthewBonner/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBonner/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T11:00:24Z","updated_at":"2015-02-12T11:00:24Z","body":"I can't believe you have done this, surely there should be some sort of discussion around what kind of re factoring needs to take place? For instance, the properties you have made protected should be private, and you should either have protected or public accessors and mutators so that the class cannot be changed or the type if the property contains a scalar value."}}