{"action":"created","comment":{"url":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments/38564480","id":38564480,"diff_hunk":"@@ -39,224 +39,14 @@\n \n (require 'compile); for compilation-* below\n (require 'ess-utils)\n+(require 'julia-mode)","path":"lisp/ess-julia.el","position":13,"original_position":13,"commit_id":"b94e4c53b7568eb84fdd451ef5b7db3de1c499e9","original_commit_id":"b94e4c53b7568eb84fdd451ef5b7db3de1c499e9","user":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"body":"> Don't know how to properly go about it. Can you for now run make julia-mode.el from ESS/lisp/?\r\n\r\nalright, thanks for the easy workaround.","created_at":"2015-09-02T18:07:16Z","updated_at":"2015-09-02T18:07:16Z","html_url":"https://github.com/emacs-ess/ESS/pull/122#discussion_r38564480","pull_request_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments/38564480"},"html":{"href":"https://github.com/emacs-ess/ESS/pull/122#discussion_r38564480"},"pull_request":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/emacs-ess/ESS/pulls/122","id":24734234,"html_url":"https://github.com/emacs-ess/ESS/pull/122","diff_url":"https://github.com/emacs-ess/ESS/pull/122.diff","patch_url":"https://github.com/emacs-ess/ESS/pull/122.patch","issue_url":"https://api.github.com/repos/emacs-ess/ESS/issues/122","number":122,"state":"closed","locked":false,"title":"Depend on julia-mode.el","user":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars.githubusercontent.com/u/70800?v=3","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"body":"This PR changes ESS to use julia-mode.el for syntax highlighting and indentation, fixing #119. It also changes the ESS Julia commands to consistently use an `ess-` prefix to avoid name collisions.\r\n\r\nI'm completely unfamiliar with the ESS codebase, so please let me about any/all the silly mistakes I've made and what we need to get this merged.\r\n\r\nThanks :)","created_at":"2014-11-20T00:37:35Z","updated_at":"2015-09-02T18:07:16Z","closed_at":"2015-08-27T15:55:19Z","merged_at":"2015-08-27T15:55:19Z","merge_commit_sha":"cb607879230746af202a6402e26ea8a2103aa3e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/122/commits","review_comments_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/122/comments","review_comment_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/issues/122/comments","statuses_url":"https://api.github.com/repos/emacs-ess/ESS/statuses/b94e4c53b7568eb84fdd451ef5b7db3de1c499e9","head":{"label":"Wilfred:master","ref":"master","sha":"b94e4c53b7568eb84fdd451ef5b7db3de1c499e9","user":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars.githubusercontent.com/u/70800?v=3","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"repo":{"id":25891283,"name":"ESS","full_name":"Wilfred/ESS","owner":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars.githubusercontent.com/u/70800?v=3","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wilfred/ESS","description":"Git development branch","fork":true,"url":"https://api.github.com/repos/Wilfred/ESS","forks_url":"https://api.github.com/repos/Wilfred/ESS/forks","keys_url":"https://api.github.com/repos/Wilfred/ESS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wilfred/ESS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wilfred/ESS/teams","hooks_url":"https://api.github.com/repos/Wilfred/ESS/hooks","issue_events_url":"https://api.github.com/repos/Wilfred/ESS/issues/events{/number}","events_url":"https://api.github.com/repos/Wilfred/ESS/events","assignees_url":"https://api.github.com/repos/Wilfred/ESS/assignees{/user}","branches_url":"https://api.github.com/repos/Wilfred/ESS/branches{/branch}","tags_url":"https://api.github.com/repos/Wilfred/ESS/tags","blobs_url":"https://api.github.com/repos/Wilfred/ESS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wilfred/ESS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wilfred/ESS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wilfred/ESS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wilfred/ESS/statuses/{sha}","languages_url":"https://api.github.com/repos/Wilfred/ESS/languages","stargazers_url":"https://api.github.com/repos/Wilfred/ESS/stargazers","contributors_url":"https://api.github.com/repos/Wilfred/ESS/contributors","subscribers_url":"https://api.github.com/repos/Wilfred/ESS/subscribers","subscription_url":"https://api.github.com/repos/Wilfred/ESS/subscription","commits_url":"https://api.github.com/repos/Wilfred/ESS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wilfred/ESS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wilfred/ESS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wilfred/ESS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wilfred/ESS/contents/{+path}","compare_url":"https://api.github.com/repos/Wilfred/ESS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wilfred/ESS/merges","archive_url":"https://api.github.com/repos/Wilfred/ESS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wilfred/ESS/downloads","issues_url":"https://api.github.com/repos/Wilfred/ESS/issues{/number}","pulls_url":"https://api.github.com/repos/Wilfred/ESS/pulls{/number}","milestones_url":"https://api.github.com/repos/Wilfred/ESS/milestones{/number}","notifications_url":"https://api.github.com/repos/Wilfred/ESS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wilfred/ESS/labels{/name}","releases_url":"https://api.github.com/repos/Wilfred/ESS/releases{/id}","created_at":"2014-10-28T21:37:05Z","updated_at":"2014-11-29T13:49:52Z","pushed_at":"2015-08-26T20:55:44Z","git_url":"git://github.com/Wilfred/ESS.git","ssh_url":"git@github.com:Wilfred/ESS.git","clone_url":"https://github.com/Wilfred/ESS.git","svn_url":"https://github.com/Wilfred/ESS","homepage":"http://ess.r-project.org/","size":20788,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emacs-ess:master","ref":"master","sha":"e16e13d36a1e3fce928d1434f07e0dfd96cdf218","user":{"login":"emacs-ess","id":1433218,"avatar_url":"https://avatars.githubusercontent.com/u/1433218?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-ess","html_url":"https://github.com/emacs-ess","followers_url":"https://api.github.com/users/emacs-ess/followers","following_url":"https://api.github.com/users/emacs-ess/following{/other_user}","gists_url":"https://api.github.com/users/emacs-ess/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-ess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-ess/subscriptions","organizations_url":"https://api.github.com/users/emacs-ess/orgs","repos_url":"https://api.github.com/users/emacs-ess/repos","events_url":"https://api.github.com/users/emacs-ess/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-ess/received_events","type":"Organization","site_admin":false},"repo":{"id":3585447,"name":"ESS","full_name":"emacs-ess/ESS","owner":{"login":"emacs-ess","id":1433218,"avatar_url":"https://avatars.githubusercontent.com/u/1433218?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-ess","html_url":"https://github.com/emacs-ess","followers_url":"https://api.github.com/users/emacs-ess/followers","following_url":"https://api.github.com/users/emacs-ess/following{/other_user}","gists_url":"https://api.github.com/users/emacs-ess/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-ess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-ess/subscriptions","organizations_url":"https://api.github.com/users/emacs-ess/orgs","repos_url":"https://api.github.com/users/emacs-ess/repos","events_url":"https://api.github.com/users/emacs-ess/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-ess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emacs-ess/ESS","description":"Git development branch","fork":false,"url":"https://api.github.com/repos/emacs-ess/ESS","forks_url":"https://api.github.com/repos/emacs-ess/ESS/forks","keys_url":"https://api.github.com/repos/emacs-ess/ESS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emacs-ess/ESS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emacs-ess/ESS/teams","hooks_url":"https://api.github.com/repos/emacs-ess/ESS/hooks","issue_events_url":"https://api.github.com/repos/emacs-ess/ESS/issues/events{/number}","events_url":"https://api.github.com/repos/emacs-ess/ESS/events","assignees_url":"https://api.github.com/repos/emacs-ess/ESS/assignees{/user}","branches_url":"https://api.github.com/repos/emacs-ess/ESS/branches{/branch}","tags_url":"https://api.github.com/repos/emacs-ess/ESS/tags","blobs_url":"https://api.github.com/repos/emacs-ess/ESS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emacs-ess/ESS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emacs-ess/ESS/git/refs{/sha}","trees_url":"https://api.github.com/repos/emacs-ess/ESS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emacs-ess/ESS/statuses/{sha}","languages_url":"https://api.github.com/repos/emacs-ess/ESS/languages","stargazers_url":"https://api.github.com/repos/emacs-ess/ESS/stargazers","contributors_url":"https://api.github.com/repos/emacs-ess/ESS/contributors","subscribers_url":"https://api.github.com/repos/emacs-ess/ESS/subscribers","subscription_url":"https://api.github.com/repos/emacs-ess/ESS/subscription","commits_url":"https://api.github.com/repos/emacs-ess/ESS/commits{/sha}","git_commits_url":"https://api.github.com/repos/emacs-ess/ESS/git/commits{/sha}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/comments{/number}","issue_comment_url":"https://api.github.com/repos/emacs-ess/ESS/issues/comments{/number}","contents_url":"https://api.github.com/repos/emacs-ess/ESS/contents/{+path}","compare_url":"https://api.github.com/repos/emacs-ess/ESS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emacs-ess/ESS/merges","archive_url":"https://api.github.com/repos/emacs-ess/ESS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emacs-ess/ESS/downloads","issues_url":"https://api.github.com/repos/emacs-ess/ESS/issues{/number}","pulls_url":"https://api.github.com/repos/emacs-ess/ESS/pulls{/number}","milestones_url":"https://api.github.com/repos/emacs-ess/ESS/milestones{/number}","notifications_url":"https://api.github.com/repos/emacs-ess/ESS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emacs-ess/ESS/labels{/name}","releases_url":"https://api.github.com/repos/emacs-ess/ESS/releases{/id}","created_at":"2012-02-29T20:13:38Z","updated_at":"2015-08-30T18:46:49Z","pushed_at":"2015-09-02T16:47:26Z","git_url":"git://github.com/emacs-ess/ESS.git","ssh_url":"git@github.com:emacs-ess/ESS.git","clone_url":"https://github.com/emacs-ess/ESS.git","svn_url":"https://github.com/emacs-ess/ESS","homepage":"http://ess.r-project.org/","size":22875,"stargazers_count":207,"watchers_count":207,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":45,"forks":60,"open_issues":45,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/122"},"html":{"href":"https://github.com/emacs-ess/ESS/pull/122"},"issue":{"href":"https://api.github.com/repos/emacs-ess/ESS/issues/122"},"comments":{"href":"https://api.github.com/repos/emacs-ess/ESS/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/emacs-ess/ESS/statuses/b94e4c53b7568eb84fdd451ef5b7db3de1c499e9"}}}}