{"action":"created","issue":{"url":"https://api.github.com/repos/logcabin/logcabin/issues/128","labels_url":"https://api.github.com/repos/logcabin/logcabin/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/logcabin/logcabin/issues/128/comments","events_url":"https://api.github.com/repos/logcabin/logcabin/issues/128/events","html_url":"https://github.com/logcabin/logcabin/issues/128","id":69094638,"number":128,"title":"running tests","user":{"login":"krizajb","id":496094,"avatar_url":"https://avatars.githubusercontent.com/u/496094?v=3","gravatar_id":"","url":"https://api.github.com/users/krizajb","html_url":"https://github.com/krizajb","followers_url":"https://api.github.com/users/krizajb/followers","following_url":"https://api.github.com/users/krizajb/following{/other_user}","gists_url":"https://api.github.com/users/krizajb/gists{/gist_id}","starred_url":"https://api.github.com/users/krizajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizajb/subscriptions","organizations_url":"https://api.github.com/users/krizajb/orgs","repos_url":"https://api.github.com/users/krizajb/repos","events_url":"https://api.github.com/users/krizajb/events{/privacy}","received_events_url":"https://api.github.com/users/krizajb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/logcabin/logcabin/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"ongardie","id":463856,"avatar_url":"https://avatars.githubusercontent.com/u/463856?v=3","gravatar_id":"","url":"https://api.github.com/users/ongardie","html_url":"https://github.com/ongardie","followers_url":"https://api.github.com/users/ongardie/followers","following_url":"https://api.github.com/users/ongardie/following{/other_user}","gists_url":"https://api.github.com/users/ongardie/gists{/gist_id}","starred_url":"https://api.github.com/users/ongardie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ongardie/subscriptions","organizations_url":"https://api.github.com/users/ongardie/orgs","repos_url":"https://api.github.com/users/ongardie/repos","events_url":"https://api.github.com/users/ongardie/events{/privacy}","received_events_url":"https://api.github.com/users/ongardie/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/logcabin/logcabin/milestones/1","html_url":"https://github.com/logcabin/logcabin/milestones/1.0.0","labels_url":"https://api.github.com/repos/logcabin/logcabin/milestones/1/labels","id":1006282,"number":1,"title":"1.0.0","description":"Issues that would probably block a 1.0.0/stable release.","creator":{"login":"ongardie","id":463856,"avatar_url":"https://avatars.githubusercontent.com/u/463856?v=3","gravatar_id":"","url":"https://api.github.com/users/ongardie","html_url":"https://github.com/ongardie","followers_url":"https://api.github.com/users/ongardie/followers","following_url":"https://api.github.com/users/ongardie/following{/other_user}","gists_url":"https://api.github.com/users/ongardie/gists{/gist_id}","starred_url":"https://api.github.com/users/ongardie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ongardie/subscriptions","organizations_url":"https://api.github.com/users/ongardie/orgs","repos_url":"https://api.github.com/users/ongardie/repos","events_url":"https://api.github.com/users/ongardie/events{/privacy}","received_events_url":"https://api.github.com/users/ongardie/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":12,"state":"open","created_at":"2015-03-04T18:43:25Z","updated_at":"2015-04-20T17:53:49Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-04-17T08:29:34Z","updated_at":"2015-04-20T17:53:49Z","closed_at":"2015-04-20T17:53:49Z","body":"Hey, I followed your build instructions and tried to fire tests but without any success. Some of them fail but many of them crash because of a common reason which is: Missing fields in protocol buffer of type LogCabin.Server.SnapshotMetadata.Header: configuration.prev_configuration.servers[0].addresses. \r\n\r\nI am fairly new to protobuf, but as seen the Configuration included in SnapshotMetadata.Header requires prev_configuration to be set. I tried tracking down where the header could be setting/not setting the property but didn't manage to do so. So after few hours, I decided to bring that matter up here to maybe also help someone else. Do tests require some kind of configuration as well?\r\n\r\nWith VERBOSE env set to 1 I was able to track down some of the test cases crashing with the reason mentioned above:\r\nTEST_F(ServerStateMachineTest, applyThreadMain_exiting_TimingSensitive)\r\nTEST_F(ServerStateMachineTest, takeSnapshot)\r\nTEST_F(ServerRaftConsensusTest, init_withsnapshot)\r\nTEST_F(ServerRaftConsensusTest, getNextEntry_snapshot)\r\nTEST_F(ServerRaftConsensusTest, getSnapshotStats)\r\n...\r\n\r\nThank you."},"comment":{"url":"https://api.github.com/repos/logcabin/logcabin/issues/comments/94523781","html_url":"https://github.com/logcabin/logcabin/issues/128#issuecomment-94523781","issue_url":"https://api.github.com/repos/logcabin/logcabin/issues/128","id":94523781,"user":{"login":"ongardie","id":463856,"avatar_url":"https://avatars.githubusercontent.com/u/463856?v=3","gravatar_id":"","url":"https://api.github.com/users/ongardie","html_url":"https://github.com/ongardie","followers_url":"https://api.github.com/users/ongardie/followers","following_url":"https://api.github.com/users/ongardie/following{/other_user}","gists_url":"https://api.github.com/users/ongardie/gists{/gist_id}","starred_url":"https://api.github.com/users/ongardie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ongardie/subscriptions","organizations_url":"https://api.github.com/users/ongardie/orgs","repos_url":"https://api.github.com/users/ongardie/repos","events_url":"https://api.github.com/users/ongardie/events{/privacy}","received_events_url":"https://api.github.com/users/ongardie/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T17:53:49Z","updated_at":"2015-04-20T17:53:49Z","body":"Cool, I just updated the README accordingly in 05e0c17. I don't see any reason to use protobuf < v2.5 at this point, so let's not worry too much about this. I think most of the issues you were having centered around the ProtoBuf text format, which isn't used much outside of log messages and tests. There's probably some cleanup that we could do to make it pass with 2.3, but I vote for moving on with our lives :)"}}