{"action":"created","issue":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7959","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7959/labels{/name}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7959/comments","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7959/events","html_url":"https://github.com/gitlabhq/gitlabhq/pull/7959","id":44879335,"number":7959,"title":"Improve file icons rendering on tree","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/labels/Awaiting%20developer%20action/feedback","name":"Awaiting developer action/feedback","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2014-10-04T10:57:46Z","updated_at":"2015-03-27T14:40:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7959","html_url":"https://github.com/gitlabhq/gitlabhq/pull/7959","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/7959.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/7959.patch"},"body":"TODO list:\r\n\r\n- [x] Make decision about icons choose and methods\r\n- [x] Integrate new icons to tree index view\r\n- [x] Integrate new icons to tree file show view\r\n- [x] Write some test about the different icon rendering\r\n- [x] Update CHANGELOG\r\n\r\nReferred to [this request](http://feedback.gitlab.com/forums/176466-general/suggestions/6330830-use-different-icon-for-executable-files), I did some improvements to file icons rendering.\r\n\r\nThis mean:\r\n\r\n* Use [fa-fw](http://fortawesome.github.io/Font-Awesome/examples/#fixed-width) (fixed  width) class for homogeneous column sizes\r\n* [fa-file-text-o](http://fortawesome.github.io/Font-Awesome/icon/file-text-o/) for regular files.\r\n* [fa-share](http://fortawesome.github.io/Font-Awesome/icon/share/) icon for links.\r\n* [fa-file-code-o](http://fortawesome.github.io/Font-Awesome/icon/file-code-o/) icon for executable files.\r\n\r\nSo, from the actual design:\r\n![gitlab_icons_before](https://cloud.githubusercontent.com/assets/1698357/4515246/9511a41c-4bb2-11e4-875f-4eb08e64a409.jpg)\r\n\r\nI made this:\r\n![gitlab_icons_after](https://cloud.githubusercontent.com/assets/1698357/4515247/9ac62482-4bb2-11e4-8459-ae350e0575bb.jpg)\r\n\r\nThe share link sounds good for me, but I don't really like the file-code for binary, to tiny to differentiate and note really appropriate...\r\n\r\nSo I tried with [fa-terminal](http://fortawesome.github.io/Font-Awesome/icon/terminal/):\r\n![gitlab_icons_terminal](https://cloud.githubusercontent.com/assets/1698357/4515253/ecea30a0-4bb2-11e4-97ce-120190f3d6a4.jpg)\r\n\r\nWell, not really better. So what about [fa-cog](http://fortawesome.github.io/Font-Awesome/icon/cog/) ?\r\n![gitlab_icons_cog](https://cloud.githubusercontent.com/assets/1698357/4515258/0c50baf4-4bb3-11e4-9e13-3c775aaf859b.jpg)\r\n\r\nIn my opinion, I think fa-cog is the better rendering for binaries. But, well, doesn't really look like a file...\r\n\r\nTwo possible options:\r\n\r\n* Use fa-stack method for custom file icon as explained [here](http://blog.fontawesome.io/2014/09/25/custom-file-types-with-stacked-icons/), but I have to change the template code for this and this will force you to use file-icon in any way.\r\n* Integrate [Github octicons](https://octicons.github.com/) which has [binary](https://octicons.github.com/icon/file-binary/) and [symlink](https://octicons.github.com/icon/file-symlink-file/) icons.\r\n\r\nIf we choose the second option, I have to check before if Octicons and Font Awesome libraries can work together without any conflict. Furthermore, I think we will have to add some contributing rules indicate that the FA icons must be user in priority!\r\n\r\nI need your feedback to continue this work. If you have another ideas/solutions, please tell me more! :+1: \r\nTell me if you think I forgot something on the todo list. :wink: \r\n\r\nWaiting yours reviews."},"comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/86961663","html_url":"https://github.com/gitlabhq/gitlabhq/pull/7959#issuecomment-86961663","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7959","id":86961663,"user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T14:40:13Z","updated_at":"2015-03-27T14:40:13Z","body":"Files icons are now based on file extensions: https://github.com/gitlabhq/gitlabhq/pull/7959/files#diff-be07b0682a4ab4f2eae8adbafb3f3569R50\r\n\r\nI managed all font-awesome icons showed here: http://fontawesome.io/icons/#file-type"}}