{"action":"created","comment":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/38190897","id":38190897,"diff_hunk":"@@ -196,12 +164,8 @@ bool CBaseParameter::accessAsString(string& strValue, bool bSet, CParameterAcces\n     return true;\n }\n \n-bool CBaseParameter::accessAsStringArray(std::vector<string>& astrValues, bool bSet, CParameterAccessContext& parameterAccessContext) const\n+bool CBaseParameter::accessAsStringArray(std::vector<string>&, bool /*bSet*/, CParameterAccessContext&) const","path":"parameter/BaseParameter.cpp","position":100,"original_position":100,"commit_id":"990a4779df0f667f2fd5da4f2d221026d4aad956","original_commit_id":"990a4779df0f667f2fd5da4f2d221026d4aad956","user":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"body":"why did you remove the astrValues identifier here (you didn't do it line 135) ?","created_at":"2015-08-28T11:26:09Z","updated_at":"2015-08-28T11:26:09Z","html_url":"https://github.com/01org/parameter-framework/pull/173#discussion_r38190897","pull_request_url":"https://api.github.com/repos/01org/parameter-framework/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/38190897"},"html":{"href":"https://github.com/01org/parameter-framework/pull/173#discussion_r38190897"},"pull_request":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/173","id":43613031,"html_url":"https://github.com/01org/parameter-framework/pull/173","diff_url":"https://github.com/01org/parameter-framework/pull/173.diff","patch_url":"https://github.com/01org/parameter-framework/pull/173.patch","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/173","number":173,"state":"open","locked":false,"title":"Normalize unused parameter declaration","user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"body":"When a function parameter is unused, the compilator emits a warning.\r\nThere are several wais to avoid that, and thus express that this parameter is rightfully unused.\r\n\r\n 1. remove the unused parameter warning\r\n    => but their are errors when that would be hided\r\n 2. declare de parameter as `__attribute__((unused))`\r\n    => but it is gcc/clang specific\r\n 3. use the parameter in a no-op operation  (usually by casting it to `void`)\r\n    => but using the parameter declared as unused by this mean will not trigger an error\r\n 4. remove the parameter identifier (leaving the type) from the function\r\n    => but when the name is non redundant with the type, this looses information and thus make review harder.\r\n 5. comment the parameter identifier\r\n    => no drawback\r\n\r\nAs a result it has been chosen to normalize all unused parameters with the 5th solution.\r\nFor identifiers that are a repetition of their type have been removed (4).\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/173%23issuecomment-135735141%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/173%23issuecomment-135735141%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%20%40OznOg%20%40dawagner%20please%20review%22%2C%20%22created_at%22%3A%20%222015-08-28T10%3A43%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/173#issuecomment-135735141'>General Comment</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> :+1: @OznOg @dawagner please review\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/173?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/173?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/173'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-08-28T10:14:14Z","updated_at":"2015-08-28T11:26:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"734b8ebe44ec3c3dd2a8734825e3f57597ffae8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/parameter-framework/pulls/173/commits","review_comments_url":"https://api.github.com/repos/01org/parameter-framework/pulls/173/comments","review_comment_url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/173/comments","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/990a4779df0f667f2fd5da4f2d221026d4aad956","head":{"label":"krocard:Normalize_unused_parameter","ref":"Normalize_unused_parameter","sha":"990a4779df0f667f2fd5da4f2d221026d4aad956","user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"repo":{"id":24673385,"name":"parameter-framework","full_name":"krocard/parameter-framework","owner":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krocard/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":true,"url":"https://api.github.com/repos/krocard/parameter-framework","forks_url":"https://api.github.com/repos/krocard/parameter-framework/forks","keys_url":"https://api.github.com/repos/krocard/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krocard/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krocard/parameter-framework/teams","hooks_url":"https://api.github.com/repos/krocard/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/krocard/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/krocard/parameter-framework/events","assignees_url":"https://api.github.com/repos/krocard/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/krocard/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/krocard/parameter-framework/tags","blobs_url":"https://api.github.com/repos/krocard/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krocard/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krocard/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/krocard/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krocard/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/krocard/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/krocard/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/krocard/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/krocard/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/krocard/parameter-framework/subscription","commits_url":"https://api.github.com/repos/krocard/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/krocard/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/krocard/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/krocard/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/krocard/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/krocard/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krocard/parameter-framework/merges","archive_url":"https://api.github.com/repos/krocard/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krocard/parameter-framework/downloads","issues_url":"https://api.github.com/repos/krocard/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/krocard/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/krocard/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/krocard/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krocard/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/krocard/parameter-framework/releases{/id}","created_at":"2014-10-01T09:54:18Z","updated_at":"2015-04-13T15:36:05Z","pushed_at":"2015-08-28T11:20:15Z","git_url":"git://github.com/krocard/parameter-framework.git","ssh_url":"git@github.com:krocard/parameter-framework.git","clone_url":"https://github.com/krocard/parameter-framework.git","svn_url":"https://github.com/krocard/parameter-framework","homepage":"","size":3822,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:windows_port","ref":"windows_port","sha":"8b39f1db492c1f6a7dfbf1bd7aa473f511e4fd0d","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16009363,"name":"parameter-framework","full_name":"01org/parameter-framework","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":false,"url":"https://api.github.com/repos/01org/parameter-framework","forks_url":"https://api.github.com/repos/01org/parameter-framework/forks","keys_url":"https://api.github.com/repos/01org/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/parameter-framework/teams","hooks_url":"https://api.github.com/repos/01org/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/01org/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/01org/parameter-framework/events","assignees_url":"https://api.github.com/repos/01org/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/01org/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/01org/parameter-framework/tags","blobs_url":"https://api.github.com/repos/01org/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/01org/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/01org/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/01org/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/01org/parameter-framework/subscription","commits_url":"https://api.github.com/repos/01org/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/01org/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/parameter-framework/merges","archive_url":"https://api.github.com/repos/01org/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/parameter-framework/downloads","issues_url":"https://api.github.com/repos/01org/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/01org/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/01org/parameter-framework/releases{/id}","created_at":"2014-01-17T19:24:01Z","updated_at":"2015-08-19T13:07:43Z","pushed_at":"2015-08-28T10:42:26Z","git_url":"git://github.com/01org/parameter-framework.git","ssh_url":"git@github.com:01org/parameter-framework.git","clone_url":"https://github.com/01org/parameter-framework.git","svn_url":"https://github.com/01org/parameter-framework","homepage":"","size":48777,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":22,"forks":22,"open_issues":22,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/173"},"html":{"href":"https://github.com/01org/parameter-framework/pull/173"},"issue":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/173"},"comments":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/01org/parameter-framework/statuses/990a4779df0f667f2fd5da4f2d221026d4aad956"}}}}