{"action":"created","comment":{"url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/comments/40725977","id":40725977,"diff_hunk":"@@ -170,15 +193,15 @@\n      */\n     function logout() {\n         var deferred = jQuery.Deferred();\n-        var id = getAuthCredentials().id;\n+        var credentials = getAuthCredentials;","path":"scripts/lib/auth.js","position":59,"original_position":59,"commit_id":"53d4267935762d78176ab4c59711052d0a191767","original_commit_id":"53d4267935762d78176ab4c59711052d0a191767","user":{"login":"swashcap","id":1858316,"avatar_url":"https://avatars.githubusercontent.com/u/1858316?v=3","gravatar_id":"","url":"https://api.github.com/users/swashcap","html_url":"https://github.com/swashcap","followers_url":"https://api.github.com/users/swashcap/followers","following_url":"https://api.github.com/users/swashcap/following{/other_user}","gists_url":"https://api.github.com/users/swashcap/gists{/gist_id}","starred_url":"https://api.github.com/users/swashcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swashcap/subscriptions","organizations_url":"https://api.github.com/users/swashcap/orgs","repos_url":"https://api.github.com/users/swashcap/repos","events_url":"https://api.github.com/users/swashcap/events{/privacy}","received_events_url":"https://api.github.com/users/swashcap/received_events","type":"User","site_admin":false},"body":"Assignment. Needs to be execution.","created_at":"2015-09-29T20:39:26Z","updated_at":"2015-09-29T20:39:26Z","html_url":"https://github.com/MRN-Code/coins-logon-widget/pull/2#discussion_r40725977","pull_request_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/comments/40725977"},"html":{"href":"https://github.com/MRN-Code/coins-logon-widget/pull/2#discussion_r40725977"},"pull_request":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2","id":46323863,"html_url":"https://github.com/MRN-Code/coins-logon-widget/pull/2","diff_url":"https://github.com/MRN-Code/coins-logon-widget/pull/2.diff","patch_url":"https://github.com/MRN-Code/coins-logon-widget/pull/2.patch","issue_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/2","number":2,"state":"open","locked":false,"title":"remove auth cookie on logout","user":{"login":"dylancwood","id":5280961,"avatar_url":"https://avatars.githubusercontent.com/u/5280961?v=3","gravatar_id":"","url":"https://api.github.com/users/dylancwood","html_url":"https://github.com/dylancwood","followers_url":"https://api.github.com/users/dylancwood/followers","following_url":"https://api.github.com/users/dylancwood/following{/other_user}","gists_url":"https://api.github.com/users/dylancwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dylancwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylancwood/subscriptions","organizations_url":"https://api.github.com/users/dylancwood/orgs","repos_url":"https://api.github.com/users/dylancwood/repos","events_url":"https://api.github.com/users/dylancwood/events{/privacy}","received_events_url":"https://api.github.com/users/dylancwood/received_events","type":"User","site_admin":false},"body":"Regardless of success or failure, we should remove the auth cookie when `coinsLogonWidget.logout` is called. \r\n\r\n# Discussion\r\nFor now, the cookie name and domain name are hard-coded. I think that is alright, but we may eventually want to move them to `options`.","created_at":"2015-09-29T19:55:34Z","updated_at":"2015-09-29T20:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0440fb88eb78166fbfcc088a729f97dba41c841","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2/commits","review_comments_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2/comments","review_comment_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/2/comments","statuses_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/statuses/53d4267935762d78176ab4c59711052d0a191767","head":{"label":"MRN-Code:remove-cookies","ref":"remove-cookies","sha":"53d4267935762d78176ab4c59711052d0a191767","user":{"login":"MRN-Code","id":5330818,"avatar_url":"https://avatars.githubusercontent.com/u/5330818?v=3","gravatar_id":"","url":"https://api.github.com/users/MRN-Code","html_url":"https://github.com/MRN-Code","followers_url":"https://api.github.com/users/MRN-Code/followers","following_url":"https://api.github.com/users/MRN-Code/following{/other_user}","gists_url":"https://api.github.com/users/MRN-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/MRN-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRN-Code/subscriptions","organizations_url":"https://api.github.com/users/MRN-Code/orgs","repos_url":"https://api.github.com/users/MRN-Code/repos","events_url":"https://api.github.com/users/MRN-Code/events{/privacy}","received_events_url":"https://api.github.com/users/MRN-Code/received_events","type":"Organization","site_admin":false},"repo":{"id":39919030,"name":"coins-logon-widget","full_name":"MRN-Code/coins-logon-widget","owner":{"login":"MRN-Code","id":5330818,"avatar_url":"https://avatars.githubusercontent.com/u/5330818?v=3","gravatar_id":"","url":"https://api.github.com/users/MRN-Code","html_url":"https://github.com/MRN-Code","followers_url":"https://api.github.com/users/MRN-Code/followers","following_url":"https://api.github.com/users/MRN-Code/following{/other_user}","gists_url":"https://api.github.com/users/MRN-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/MRN-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRN-Code/subscriptions","organizations_url":"https://api.github.com/users/MRN-Code/orgs","repos_url":"https://api.github.com/users/MRN-Code/repos","events_url":"https://api.github.com/users/MRN-Code/events{/privacy}","received_events_url":"https://api.github.com/users/MRN-Code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MRN-Code/coins-logon-widget","description":"COINS Logon Widget.  Injectable utility to manage browser authorization with COINS","fork":false,"url":"https://api.github.com/repos/MRN-Code/coins-logon-widget","forks_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/forks","keys_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/teams","hooks_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/hooks","issue_events_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/events{/number}","events_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/events","assignees_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/assignees{/user}","branches_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/branches{/branch}","tags_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/tags","blobs_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/languages","stargazers_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/stargazers","contributors_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/contributors","subscribers_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/subscribers","subscription_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/subscription","commits_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/contents/{+path}","compare_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/merges","archive_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/downloads","issues_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues{/number}","pulls_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/labels{/name}","releases_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/releases{/id}","created_at":"2015-07-29T22:19:05Z","updated_at":"2015-08-03T17:14:55Z","pushed_at":"2015-09-29T20:02:06Z","git_url":"git://github.com/MRN-Code/coins-logon-widget.git","ssh_url":"git@github.com:MRN-Code/coins-logon-widget.git","clone_url":"https://github.com/MRN-Code/coins-logon-widget.git","svn_url":"https://github.com/MRN-Code/coins-logon-widget","homepage":null,"size":412,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MRN-Code:master","ref":"master","sha":"852542401c02d5416d3cff77521daf4ae738fd79","user":{"login":"MRN-Code","id":5330818,"avatar_url":"https://avatars.githubusercontent.com/u/5330818?v=3","gravatar_id":"","url":"https://api.github.com/users/MRN-Code","html_url":"https://github.com/MRN-Code","followers_url":"https://api.github.com/users/MRN-Code/followers","following_url":"https://api.github.com/users/MRN-Code/following{/other_user}","gists_url":"https://api.github.com/users/MRN-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/MRN-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRN-Code/subscriptions","organizations_url":"https://api.github.com/users/MRN-Code/orgs","repos_url":"https://api.github.com/users/MRN-Code/repos","events_url":"https://api.github.com/users/MRN-Code/events{/privacy}","received_events_url":"https://api.github.com/users/MRN-Code/received_events","type":"Organization","site_admin":false},"repo":{"id":39919030,"name":"coins-logon-widget","full_name":"MRN-Code/coins-logon-widget","owner":{"login":"MRN-Code","id":5330818,"avatar_url":"https://avatars.githubusercontent.com/u/5330818?v=3","gravatar_id":"","url":"https://api.github.com/users/MRN-Code","html_url":"https://github.com/MRN-Code","followers_url":"https://api.github.com/users/MRN-Code/followers","following_url":"https://api.github.com/users/MRN-Code/following{/other_user}","gists_url":"https://api.github.com/users/MRN-Code/gists{/gist_id}","starred_url":"https://api.github.com/users/MRN-Code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRN-Code/subscriptions","organizations_url":"https://api.github.com/users/MRN-Code/orgs","repos_url":"https://api.github.com/users/MRN-Code/repos","events_url":"https://api.github.com/users/MRN-Code/events{/privacy}","received_events_url":"https://api.github.com/users/MRN-Code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MRN-Code/coins-logon-widget","description":"COINS Logon Widget.  Injectable utility to manage browser authorization with COINS","fork":false,"url":"https://api.github.com/repos/MRN-Code/coins-logon-widget","forks_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/forks","keys_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/teams","hooks_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/hooks","issue_events_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/events{/number}","events_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/events","assignees_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/assignees{/user}","branches_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/branches{/branch}","tags_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/tags","blobs_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/languages","stargazers_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/stargazers","contributors_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/contributors","subscribers_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/subscribers","subscription_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/subscription","commits_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/contents/{+path}","compare_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/merges","archive_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/downloads","issues_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues{/number}","pulls_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/labels{/name}","releases_url":"https://api.github.com/repos/MRN-Code/coins-logon-widget/releases{/id}","created_at":"2015-07-29T22:19:05Z","updated_at":"2015-08-03T17:14:55Z","pushed_at":"2015-09-29T20:02:06Z","git_url":"git://github.com/MRN-Code/coins-logon-widget.git","ssh_url":"git@github.com:MRN-Code/coins-logon-widget.git","clone_url":"https://github.com/MRN-Code/coins-logon-widget.git","svn_url":"https://github.com/MRN-Code/coins-logon-widget","homepage":null,"size":412,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2"},"html":{"href":"https://github.com/MRN-Code/coins-logon-widget/pull/2"},"issue":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/2"},"comments":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/MRN-Code/coins-logon-widget/statuses/53d4267935762d78176ab4c59711052d0a191767"}}}}