{"push_id":669284915,"size":2,"distinct_size":2,"ref":"refs/heads/2.3","head":"a2223f6d2202af50ac2029bc9e2fa770de84fa3f","before":"79687d4dab8280e449c8c679f03d932f3997e3c5","commits":[{"sha":"613a7bfa549396c448ff464317726f4d91caadb2","author":{"email":"1778d353e423748da1b15382251aff71dba265f0@researchgate.net","name":"Daniel Tschinder"},"message":"[HttpFoundation] Fix baseUrl when script filename is contained in pathInfo","distinct":true,"url":"https://api.github.com/repos/symfony/HttpFoundation/commits/613a7bfa549396c448ff464317726f4d91caadb2"},{"sha":"a2223f6d2202af50ac2029bc9e2fa770de84fa3f","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #14335 [HttpFoundation] Fix baseUrl when script filename is contained in pathInfo (danez)\n\nThis PR was squashed before being merged into the 2.3 branch (closes #14335).\n\nDiscussion\n----------\n\n[HttpFoundation] Fix baseUrl when script filename is contained in pathInfo\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #13617\n| License       | MIT\n| Doc PR        |\n\nWhen the script filename is just /index.php, dirname() returns '/' for it. In Request::prepareBaseUrl() we append '/' to it (as introduced in #13039), which is wrong in this scenario as the resulting string is '//'.\n\nWhen we rtrim('/') the output of dirname() then '/' would be constructed in this case, and in all other cases it makes no difference as dirname() already trims the right forward slash if there are path segments.\n\nThe test-cases should clarify the exact scenario.\n\nCommits\n-------\n\nf24a6dd [HttpFoundation] Fix baseUrl when script filename is contained in pathInfo","distinct":true,"url":"https://api.github.com/repos/symfony/HttpFoundation/commits/a2223f6d2202af50ac2029bc9e2fa770de84fa3f"}]}