{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments/38052320","id":38052320,"diff_hunk":"@@ -573,35 +568,41 @@ def overview(self, request, tenant_id):\n         \"\"\"\n         serves the overview api call,returns all entities,checks and alarms\n         \"\"\"\n-        entities = self._entity_cache_for_tenant(tenant_id).entities_list\n-        checks = self._entity_cache_for_tenant(tenant_id).checks_list\n-        alarms = self._entity_cache_for_tenant(tenant_id).alarms_list\n-        metadata = {}\n-        metadata['count'] = len(entities)\n-        metadata['marker'] = None\n-        metadata['next_marker'] = None\n-        metadata['limit'] = 1000\n-        metadata['next_href'] = None\n-        values = []\n-        for e in entities:\n-            v = {}\n-            v['alarms'] = []\n-            for a in alarms:\n-                if a['entity_id'] == e['id']:\n-                    a = dict(a)\n-                    del a['entity_id']\n-                    v['alarms'].append(a)\n-            v['checks'] = []\n-            for c in checks:\n-                if c['entity_id'] == e['id']:\n-                    c = dict(c)\n-                    del c['entity_id']\n-                    v['checks'].append(c)\n-            v['entity'] = e\n-            v['latest_alarm_states'] = []\n-            values.append(v)\n-        request.setResponseCode(200)\n-        return json.dumps({'metadata': metadata, 'values': values})\n+        # This is a hack to make cloud control panel server details page finish loading the server\n+        # details\n+        if 'uri' in request.args:\n+            request.setResponseCode(404)\n+            return json.dumps({})\n+        else:","path":"mimic/rest/maas_api.py","position":66,"original_position":66,"commit_id":"9eee1ca3eef881b9a98ce33d4a437ef0d59f75c6","original_commit_id":"9eee1ca3eef881b9a98ce33d4a437ef0d59f75c6","user":{"login":"ksheedlo","id":1271410,"avatar_url":"https://avatars.githubusercontent.com/u/1271410?v=3","gravatar_id":"","url":"https://api.github.com/users/ksheedlo","html_url":"https://github.com/ksheedlo","followers_url":"https://api.github.com/users/ksheedlo/followers","following_url":"https://api.github.com/users/ksheedlo/following{/other_user}","gists_url":"https://api.github.com/users/ksheedlo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksheedlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksheedlo/subscriptions","organizations_url":"https://api.github.com/users/ksheedlo/orgs","repos_url":"https://api.github.com/users/ksheedlo/repos","events_url":"https://api.github.com/users/ksheedlo/events{/privacy}","received_events_url":"https://api.github.com/users/ksheedlo/received_events","type":"User","site_admin":false},"body":"I have a couple of concerns here.\r\n\r\n1. Why do we need to 404 in this case at all? Successfully getting the overview response shouldn't cause a page to hang. Is this a bug in Reach? and if so, can you post a gist or similar explaining it?\r\n2. Since you return at the end of the if block, you don't need the else block and re-indentation. I'd prefer you not indent everything over again if you don't have to.","created_at":"2015-08-27T00:42:01Z","updated_at":"2015-08-27T00:42:01Z","html_url":"https://github.com/rackerlabs/mimic/pull/200#discussion_r38052320","pull_request_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments/38052320"},"html":{"href":"https://github.com/rackerlabs/mimic/pull/200#discussion_r38052320"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/mimic/pulls/200","id":31170787,"html_url":"https://github.com/rackerlabs/mimic/pull/200","diff_url":"https://github.com/rackerlabs/mimic/pull/200.diff","patch_url":"https://github.com/rackerlabs/mimic/pull/200.patch","issue_url":"https://api.github.com/repos/rackerlabs/mimic/issues/200","number":200,"state":"open","locked":false,"title":"new plugins and altered responses to existing plugins for reach","user":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"body":"This PR serves as a record of *all* the code changes necessary to get the cloud control panel tests passing, and should be closed those changes have been split out into smaller units and merged.","created_at":"2015-03-13T22:53:56Z","updated_at":"2015-08-27T00:42:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16f07e332793b0952c6873b2f518a98f10fb365e","assignee":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/200/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/200/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/mimic/issues/200/comments","statuses_url":"https://api.github.com/repos/rackerlabs/mimic/statuses/9eee1ca3eef881b9a98ce33d4a437ef0d59f75c6","head":{"label":"rackerlabs:plugins_for_reach","ref":"plugins_for_reach","sha":"9eee1ca3eef881b9a98ce33d4a437ef0d59f75c6","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13158707,"name":"mimic","full_name":"rackerlabs/mimic","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/mimic","description":"An API mock service","fork":false,"url":"https://api.github.com/repos/rackerlabs/mimic","forks_url":"https://api.github.com/repos/rackerlabs/mimic/forks","keys_url":"https://api.github.com/repos/rackerlabs/mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/mimic/teams","hooks_url":"https://api.github.com/repos/rackerlabs/mimic/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/mimic/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/mimic/events","assignees_url":"https://api.github.com/repos/rackerlabs/mimic/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/mimic/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/mimic/tags","blobs_url":"https://api.github.com/repos/rackerlabs/mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/mimic/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/mimic/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/mimic/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/mimic/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/mimic/subscription","commits_url":"https://api.github.com/repos/rackerlabs/mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/mimic/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/mimic/merges","archive_url":"https://api.github.com/repos/rackerlabs/mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/mimic/downloads","issues_url":"https://api.github.com/repos/rackerlabs/mimic/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/mimic/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/mimic/releases{/id}","created_at":"2013-09-27T19:01:16Z","updated_at":"2015-08-24T15:14:20Z","pushed_at":"2015-08-26T22:17:47Z","git_url":"git://github.com/rackerlabs/mimic.git","ssh_url":"git@github.com:rackerlabs/mimic.git","clone_url":"https://github.com/rackerlabs/mimic.git","svn_url":"https://github.com/rackerlabs/mimic","homepage":"","size":5151,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":83,"forks":44,"open_issues":83,"watchers":89,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"43148c0fcd9c9eb54d80fb7010b2500c59253732","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13158707,"name":"mimic","full_name":"rackerlabs/mimic","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/mimic","description":"An API mock service","fork":false,"url":"https://api.github.com/repos/rackerlabs/mimic","forks_url":"https://api.github.com/repos/rackerlabs/mimic/forks","keys_url":"https://api.github.com/repos/rackerlabs/mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/mimic/teams","hooks_url":"https://api.github.com/repos/rackerlabs/mimic/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/mimic/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/mimic/events","assignees_url":"https://api.github.com/repos/rackerlabs/mimic/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/mimic/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/mimic/tags","blobs_url":"https://api.github.com/repos/rackerlabs/mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/mimic/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/mimic/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/mimic/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/mimic/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/mimic/subscription","commits_url":"https://api.github.com/repos/rackerlabs/mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/mimic/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/mimic/merges","archive_url":"https://api.github.com/repos/rackerlabs/mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/mimic/downloads","issues_url":"https://api.github.com/repos/rackerlabs/mimic/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/mimic/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/mimic/releases{/id}","created_at":"2013-09-27T19:01:16Z","updated_at":"2015-08-24T15:14:20Z","pushed_at":"2015-08-26T22:17:47Z","git_url":"git://github.com/rackerlabs/mimic.git","ssh_url":"git@github.com:rackerlabs/mimic.git","clone_url":"https://github.com/rackerlabs/mimic.git","svn_url":"https://github.com/rackerlabs/mimic","homepage":"","size":5151,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":83,"forks":44,"open_issues":83,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/200"},"html":{"href":"https://github.com/rackerlabs/mimic/pull/200"},"issue":{"href":"https://api.github.com/repos/rackerlabs/mimic/issues/200"},"comments":{"href":"https://api.github.com/repos/rackerlabs/mimic/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/mimic/statuses/9eee1ca3eef881b9a98ce33d4a437ef0d59f75c6"}}}}