{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/41684204","id":41684204,"diff_hunk":"@@ -35,23 +35,26 @@\n DEFAULT_USERNAME = 'perfkit'\n \n \n-class BaseVirtualMachineSpec(object):\n+class BaseVmSpec(object):\n   \"\"\"Storing various data about a single vm.\n \n   Attributes:\n-    project: The provider-specific project to associate the VM with (e.g.\n-      artisanal-lightbulb-883).\n     zone: The region / zone the in which to launch the VM.\n     machine_type: The provider-specific instance type (e.g. n1-standard-8).\n     image: The disk image to boot from.\n   \"\"\"\n \n-  def __init__(self, project, zone, machine_type, image):\n-    self.project = project\n+  def __init__(self, zone=None, machine_type=None, image=None):\n     self.zone = zone\n     self.machine_type = machine_type\n     self.image = image\n \n+  def ApplyFlags(self, flags):\n+    \"\"\"Applys flags to the VmSpec.\"\"\"","path":"perfkitbenchmarker/virtual_machine.py","position":null,"original_position":24,"commit_id":"4660ff656ec3af32c53685d2143498bb2d33fb37","original_commit_id":"8c44b7fcccf66feeca2930fffb93a8cc0fae253f","user":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2015-10-09T22:23:38Z","updated_at":"2015-10-09T22:23:38Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/510#discussion_r41684204","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/41684204"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/510#discussion_r41684204"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510","id":46670558,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/510","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/510.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/510.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/510","number":510,"state":"open","locked":false,"title":"Adds configs","user":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-02T19:07:12Z","updated_at":"2015-10-09T22:23:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fc9d2ee8fb32e5cd8cca80b0a6b4bf61100549b","assignee":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/510/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/4660ff656ec3af32c53685d2143498bb2d33fb37","head":{"label":"ehankland:config","ref":"config","sha":"4660ff656ec3af32c53685d2143498bb2d33fb37","user":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"repo":{"id":36402001,"name":"PerfKitBenchmarker","full_name":"ehankland/PerfKitBenchmarker","owner":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehankland/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/releases{/id}","created_at":"2015-05-27T23:24:42Z","updated_at":"2015-05-27T23:24:43Z","pushed_at":"2015-10-09T22:23:28Z","git_url":"git://github.com/ehankland/PerfKitBenchmarker.git","ssh_url":"git@github.com:ehankland/PerfKitBenchmarker.git","clone_url":"https://github.com/ehankland/PerfKitBenchmarker.git","svn_url":"https://github.com/ehankland/PerfKitBenchmarker","homepage":"","size":3102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"b52cb9fcbfc68dd1463884150895590a0afc5af7","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2015-10-09T22:20:08Z","pushed_at":"2015-10-09T22:23:28Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":84789,"stargazers_count":487,"watchers_count":487,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":101,"forks":82,"open_issues":101,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/510"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/510"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/4660ff656ec3af32c53685d2143498bb2d33fb37"}}}}