{"action":"opened","number":148,"pull_request":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/148","id":35023301,"html_url":"https://github.com/lightblue-platform/lightblue-rest/pull/148","diff_url":"https://github.com/lightblue-platform/lightblue-rest/pull/148.diff","patch_url":"https://github.com/lightblue-platform/lightblue-rest/pull/148.patch","issue_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/148","number":148,"state":"open","locked":false,"title":"Creating InitialLdapContext on every call to ldap","user":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"body":"Because it's likely to be responsible for ```Naming problem with LDAP for user: <user>: javax.naming.CommunicationException: connection closed [Root exception is java.io.IOException: connection closed``` errors. Most of the changes are for getting the ldap configs from CertLdapLoginModule down to LDAPSearcher.\r\n\r\nLdap lookup is expensive, but it will be done only when roles are not cached. We could further improve performance by introducing a real ldap connection pool (with validation and restoring stale connections).\r\n\r\n","created_at":"2015-05-08T16:14:28Z","updated_at":"2015-05-08T16:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/148/commits","review_comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/148/comments","review_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/148/comments","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/statuses/d3c347bb2410b3d9d39bde91c604bec54638df62","head":{"label":"paterczm:1.4.0fixes","ref":"1.4.0fixes","sha":"d3c347bb2410b3d9d39bde91c604bec54638df62","user":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"repo":{"id":32171878,"name":"lightblue-rest","full_name":"paterczm/lightblue-rest","owner":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paterczm/lightblue-rest","description":"","fork":true,"url":"https://api.github.com/repos/paterczm/lightblue-rest","forks_url":"https://api.github.com/repos/paterczm/lightblue-rest/forks","keys_url":"https://api.github.com/repos/paterczm/lightblue-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paterczm/lightblue-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paterczm/lightblue-rest/teams","hooks_url":"https://api.github.com/repos/paterczm/lightblue-rest/hooks","issue_events_url":"https://api.github.com/repos/paterczm/lightblue-rest/issues/events{/number}","events_url":"https://api.github.com/repos/paterczm/lightblue-rest/events","assignees_url":"https://api.github.com/repos/paterczm/lightblue-rest/assignees{/user}","branches_url":"https://api.github.com/repos/paterczm/lightblue-rest/branches{/branch}","tags_url":"https://api.github.com/repos/paterczm/lightblue-rest/tags","blobs_url":"https://api.github.com/repos/paterczm/lightblue-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paterczm/lightblue-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paterczm/lightblue-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/paterczm/lightblue-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paterczm/lightblue-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/paterczm/lightblue-rest/languages","stargazers_url":"https://api.github.com/repos/paterczm/lightblue-rest/stargazers","contributors_url":"https://api.github.com/repos/paterczm/lightblue-rest/contributors","subscribers_url":"https://api.github.com/repos/paterczm/lightblue-rest/subscribers","subscription_url":"https://api.github.com/repos/paterczm/lightblue-rest/subscription","commits_url":"https://api.github.com/repos/paterczm/lightblue-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/paterczm/lightblue-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/paterczm/lightblue-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/paterczm/lightblue-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/paterczm/lightblue-rest/contents/{+path}","compare_url":"https://api.github.com/repos/paterczm/lightblue-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paterczm/lightblue-rest/merges","archive_url":"https://api.github.com/repos/paterczm/lightblue-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paterczm/lightblue-rest/downloads","issues_url":"https://api.github.com/repos/paterczm/lightblue-rest/issues{/number}","pulls_url":"https://api.github.com/repos/paterczm/lightblue-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/paterczm/lightblue-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/paterczm/lightblue-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paterczm/lightblue-rest/labels{/name}","releases_url":"https://api.github.com/repos/paterczm/lightblue-rest/releases{/id}","created_at":"2015-03-13T17:57:08Z","updated_at":"2015-03-13T17:57:32Z","pushed_at":"2015-05-08T16:10:26Z","git_url":"git://github.com/paterczm/lightblue-rest.git","ssh_url":"git@github.com:paterczm/lightblue-rest.git","clone_url":"https://github.com/paterczm/lightblue-rest.git","svn_url":"https://github.com/paterczm/lightblue-rest","homepage":null,"size":12244,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightblue-platform:master","ref":"master","sha":"a11817149a97f2cdf85307aa7dfeb127ac22ef0f","user":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":23001404,"name":"lightblue-rest","full_name":"lightblue-platform/lightblue-rest","owner":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightblue-platform/lightblue-rest","description":"","fork":false,"url":"https://api.github.com/repos/lightblue-platform/lightblue-rest","forks_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/forks","keys_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/teams","hooks_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/hooks","issue_events_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/events{/number}","events_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/events","assignees_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/assignees{/user}","branches_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/branches{/branch}","tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/tags","blobs_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/languages","stargazers_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/stargazers","contributors_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/contributors","subscribers_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/subscribers","subscription_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/subscription","commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/contents/{+path}","compare_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/merges","archive_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/downloads","issues_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues{/number}","pulls_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/labels{/name}","releases_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/releases{/id}","created_at":"2014-08-15T19:59:57Z","updated_at":"2015-05-05T19:34:33Z","pushed_at":"2015-05-05T20:33:22Z","git_url":"git://github.com/lightblue-platform/lightblue-rest.git","ssh_url":"git@github.com:lightblue-platform/lightblue-rest.git","clone_url":"https://github.com/lightblue-platform/lightblue-rest.git","svn_url":"https://github.com/lightblue-platform/lightblue-rest","homepage":null,"size":13505,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":25,"forks":7,"open_issues":25,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/148"},"html":{"href":"https://github.com/lightblue-platform/lightblue-rest/pull/148"},"issue":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/148"},"comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/statuses/d3c347bb2410b3d9d39bde91c604bec54638df62"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":71,"deletions":41,"changed_files":7}}