{"action":"closed","number":2447,"pull_request":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/2447","id":43117213,"html_url":"https://github.com/cuberite/cuberite/pull/2447","diff_url":"https://github.com/cuberite/cuberite/pull/2447.diff","patch_url":"https://github.com/cuberite/cuberite/pull/2447.patch","issue_url":"https://api.github.com/repos/cuberite/cuberite/issues/2447","number":2447,"state":"closed","locked":false,"title":"Fix FreeBSD build by including signal.h","user":{"login":"mjhanninen","id":82970,"avatar_url":"https://avatars.githubusercontent.com/u/82970?v=3","gravatar_id":"","url":"https://api.github.com/users/mjhanninen","html_url":"https://github.com/mjhanninen","followers_url":"https://api.github.com/users/mjhanninen/followers","following_url":"https://api.github.com/users/mjhanninen/following{/other_user}","gists_url":"https://api.github.com/users/mjhanninen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhanninen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhanninen/subscriptions","organizations_url":"https://api.github.com/users/mjhanninen/orgs","repos_url":"https://api.github.com/users/mjhanninen/repos","events_url":"https://api.github.com/users/mjhanninen/events{/privacy}","received_events_url":"https://api.github.com/users/mjhanninen/received_events","type":"User","site_admin":false},"body":"On FreeBSD the build dies due to missing `signal.h`:\r\n\r\n    [ 97%] Building CXX object src/CMakeFiles/MCServer.dir/Root.cpp.o\r\n    /home/matti/cuberite/src/Root.cpp:301:51: error: use of undeclared identifier 'SIGKILL'\r\n                    if (pthread_kill(m_InputThread.native_handle(), SIGKILL) != 0)\r\n\r\nDependency on `signal.h` was introduced by #2427.\r\n\r\nThis PR fixes the build. However I wonder whether these POSIX headers should be included in less a case-by-case manner. I'm not a pro on that front so I couldn't tell.","created_at":"2015-08-23T07:42:59Z","updated_at":"2015-09-02T17:37:56Z","closed_at":"2015-09-02T17:37:56Z","merged_at":"2015-09-02T17:37:56Z","merge_commit_sha":"4143b9d0c78b9ba8c04b9b0293763496a275b1b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2447/commits","review_comments_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2447/comments","review_comment_url":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuberite/cuberite/issues/2447/comments","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/c3d84a24a9ae426a57301c1585468b6ea35bbaeb","head":{"label":"mjhanninen:fix-freebsd-signal-include","ref":"fix-freebsd-signal-include","sha":"c3d84a24a9ae426a57301c1585468b6ea35bbaeb","user":{"login":"mjhanninen","id":82970,"avatar_url":"https://avatars.githubusercontent.com/u/82970?v=3","gravatar_id":"","url":"https://api.github.com/users/mjhanninen","html_url":"https://github.com/mjhanninen","followers_url":"https://api.github.com/users/mjhanninen/followers","following_url":"https://api.github.com/users/mjhanninen/following{/other_user}","gists_url":"https://api.github.com/users/mjhanninen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhanninen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhanninen/subscriptions","organizations_url":"https://api.github.com/users/mjhanninen/orgs","repos_url":"https://api.github.com/users/mjhanninen/repos","events_url":"https://api.github.com/users/mjhanninen/events{/privacy}","received_events_url":"https://api.github.com/users/mjhanninen/received_events","type":"User","site_admin":false},"repo":{"id":39391065,"name":"cuberite","full_name":"mjhanninen/cuberite","owner":{"login":"mjhanninen","id":82970,"avatar_url":"https://avatars.githubusercontent.com/u/82970?v=3","gravatar_id":"","url":"https://api.github.com/users/mjhanninen","html_url":"https://github.com/mjhanninen","followers_url":"https://api.github.com/users/mjhanninen/followers","following_url":"https://api.github.com/users/mjhanninen/following{/other_user}","gists_url":"https://api.github.com/users/mjhanninen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhanninen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhanninen/subscriptions","organizations_url":"https://api.github.com/users/mjhanninen/orgs","repos_url":"https://api.github.com/users/mjhanninen/repos","events_url":"https://api.github.com/users/mjhanninen/events{/privacy}","received_events_url":"https://api.github.com/users/mjhanninen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjhanninen/cuberite","description":"A performant C++ Minecraft compatible game server","fork":true,"url":"https://api.github.com/repos/mjhanninen/cuberite","forks_url":"https://api.github.com/repos/mjhanninen/cuberite/forks","keys_url":"https://api.github.com/repos/mjhanninen/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjhanninen/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjhanninen/cuberite/teams","hooks_url":"https://api.github.com/repos/mjhanninen/cuberite/hooks","issue_events_url":"https://api.github.com/repos/mjhanninen/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/mjhanninen/cuberite/events","assignees_url":"https://api.github.com/repos/mjhanninen/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/mjhanninen/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/mjhanninen/cuberite/tags","blobs_url":"https://api.github.com/repos/mjhanninen/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjhanninen/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjhanninen/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjhanninen/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjhanninen/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/mjhanninen/cuberite/languages","stargazers_url":"https://api.github.com/repos/mjhanninen/cuberite/stargazers","contributors_url":"https://api.github.com/repos/mjhanninen/cuberite/contributors","subscribers_url":"https://api.github.com/repos/mjhanninen/cuberite/subscribers","subscription_url":"https://api.github.com/repos/mjhanninen/cuberite/subscription","commits_url":"https://api.github.com/repos/mjhanninen/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjhanninen/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjhanninen/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjhanninen/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjhanninen/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/mjhanninen/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjhanninen/cuberite/merges","archive_url":"https://api.github.com/repos/mjhanninen/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjhanninen/cuberite/downloads","issues_url":"https://api.github.com/repos/mjhanninen/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/mjhanninen/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/mjhanninen/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/mjhanninen/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjhanninen/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/mjhanninen/cuberite/releases{/id}","created_at":"2015-07-20T15:11:51Z","updated_at":"2015-07-20T15:11:55Z","pushed_at":"2015-08-27T05:15:19Z","git_url":"git://github.com/mjhanninen/cuberite.git","ssh_url":"git@github.com:mjhanninen/cuberite.git","clone_url":"https://github.com/mjhanninen/cuberite.git","svn_url":"https://github.com/mjhanninen/cuberite","homepage":"http://cuberite.org","size":77287,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cuberite:master","ref":"master","sha":"3b8dc45dc3418359b05ec54b90c94aa2b94405c8","user":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"repo":{"id":11693709,"name":"cuberite","full_name":"cuberite/cuberite","owner":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuberite/cuberite","description":"A performant C++ Minecraft compatible game server","fork":false,"url":"https://api.github.com/repos/cuberite/cuberite","forks_url":"https://api.github.com/repos/cuberite/cuberite/forks","keys_url":"https://api.github.com/repos/cuberite/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuberite/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuberite/cuberite/teams","hooks_url":"https://api.github.com/repos/cuberite/cuberite/hooks","issue_events_url":"https://api.github.com/repos/cuberite/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/cuberite/cuberite/events","assignees_url":"https://api.github.com/repos/cuberite/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/cuberite/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/cuberite/cuberite/tags","blobs_url":"https://api.github.com/repos/cuberite/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuberite/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuberite/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuberite/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/cuberite/cuberite/languages","stargazers_url":"https://api.github.com/repos/cuberite/cuberite/stargazers","contributors_url":"https://api.github.com/repos/cuberite/cuberite/contributors","subscribers_url":"https://api.github.com/repos/cuberite/cuberite/subscribers","subscription_url":"https://api.github.com/repos/cuberite/cuberite/subscription","commits_url":"https://api.github.com/repos/cuberite/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuberite/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuberite/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuberite/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuberite/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/cuberite/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuberite/cuberite/merges","archive_url":"https://api.github.com/repos/cuberite/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuberite/cuberite/downloads","issues_url":"https://api.github.com/repos/cuberite/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/cuberite/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/cuberite/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/cuberite/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuberite/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/cuberite/cuberite/releases{/id}","created_at":"2013-07-26T19:56:59Z","updated_at":"2015-09-01T17:48:38Z","pushed_at":"2015-09-02T17:37:56Z","git_url":"git://github.com/cuberite/cuberite.git","ssh_url":"git@github.com:cuberite/cuberite.git","clone_url":"https://github.com/cuberite/cuberite.git","svn_url":"https://github.com/cuberite/cuberite","homepage":"http://cuberite.org","size":167338,"stargazers_count":725,"watchers_count":725,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":382,"forks":230,"open_issues":382,"watchers":725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2447"},"html":{"href":"https://github.com/cuberite/cuberite/pull/2447"},"issue":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2447"},"comments":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2447/comments"},"review_comments":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2447/comments"},"review_comment":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2447/commits"},"statuses":{"href":"https://api.github.com/repos/cuberite/cuberite/statuses/c3d84a24a9ae426a57301c1585468b6ea35bbaeb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tigerw","id":2939130,"avatar_url":"https://avatars.githubusercontent.com/u/2939130?v=3","gravatar_id":"","url":"https://api.github.com/users/tigerw","html_url":"https://github.com/tigerw","followers_url":"https://api.github.com/users/tigerw/followers","following_url":"https://api.github.com/users/tigerw/following{/other_user}","gists_url":"https://api.github.com/users/tigerw/gists{/gist_id}","starred_url":"https://api.github.com/users/tigerw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigerw/subscriptions","organizations_url":"https://api.github.com/users/tigerw/orgs","repos_url":"https://api.github.com/users/tigerw/repos","events_url":"https://api.github.com/users/tigerw/events{/privacy}","received_events_url":"https://api.github.com/users/tigerw/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":7,"deletions":5,"changed_files":1}}