{"action":"closed","number":2063,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/2063","id":52084810,"html_url":"https://github.com/systemd/systemd/pull/2063","diff_url":"https://github.com/systemd/systemd/pull/2063.diff","patch_url":"https://github.com/systemd/systemd/pull/2063.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/2063","number":2063,"state":"closed","locked":false,"title":"journal: clean up permission setting and acl adjustements on user journals","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"First commit move acl-modifying code to acl-util. It also removes the call to fchmod(): we can expect the file to have correct permissions since we just created it with some mask or we created it before with the right permissions. If an admin changed the mode of the file, we should just let it be.\r\n\r\nSecond commit adds some tests which calls the acl-modifying code. The test doesn't show any problems, but it exercises the code in question which so far didn't have any unit tests.\r\n\r\nThe third commit fixes the problem in #1977 by not setting the mask if it is already set. We were only setting it to avoid having an invalid acl, and it turns out that with current inheritable permissions set on the parent directory, we *do* have a mask entry by default.\r\n\r\nThe fourth commit is for #1971. The fifth is for #1397.\r\n\r\nVersion 2 of #2057.","created_at":"2015-11-30T04:39:58Z","updated_at":"2015-11-30T16:53:39Z","closed_at":"2015-11-30T16:53:39Z","merged_at":"2015-11-30T16:53:39Z","merge_commit_sha":"4472e74dfe73674533a7e3ed20f4dceb1737fac2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/2063/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/2063/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/2063/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/afae249efa4774c6676738ac5de6aeb4daf4889f","head":{"label":"keszybz:issue-1977-2","ref":"issue-1977-2","sha":"afae249efa4774c6676738ac5de6aeb4daf4889f","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"repo":{"id":37000824,"name":"systemd","full_name":"keszybz/systemd","owner":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keszybz/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/keszybz/systemd","forks_url":"https://api.github.com/repos/keszybz/systemd/forks","keys_url":"https://api.github.com/repos/keszybz/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keszybz/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keszybz/systemd/teams","hooks_url":"https://api.github.com/repos/keszybz/systemd/hooks","issue_events_url":"https://api.github.com/repos/keszybz/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/keszybz/systemd/events","assignees_url":"https://api.github.com/repos/keszybz/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/keszybz/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/keszybz/systemd/tags","blobs_url":"https://api.github.com/repos/keszybz/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keszybz/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keszybz/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/keszybz/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keszybz/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/keszybz/systemd/languages","stargazers_url":"https://api.github.com/repos/keszybz/systemd/stargazers","contributors_url":"https://api.github.com/repos/keszybz/systemd/contributors","subscribers_url":"https://api.github.com/repos/keszybz/systemd/subscribers","subscription_url":"https://api.github.com/repos/keszybz/systemd/subscription","commits_url":"https://api.github.com/repos/keszybz/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/keszybz/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/keszybz/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/keszybz/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/keszybz/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/keszybz/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keszybz/systemd/merges","archive_url":"https://api.github.com/repos/keszybz/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keszybz/systemd/downloads","issues_url":"https://api.github.com/repos/keszybz/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/keszybz/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/keszybz/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/keszybz/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keszybz/systemd/labels{/name}","releases_url":"https://api.github.com/repos/keszybz/systemd/releases{/id}","created_at":"2015-06-07T01:43:08Z","updated_at":"2015-06-07T01:43:13Z","pushed_at":"2015-11-30T04:38:43Z","git_url":"git://github.com/keszybz/systemd.git","ssh_url":"git@github.com:keszybz/systemd.git","clone_url":"https://github.com/keszybz/systemd.git","svn_url":"https://github.com/keszybz/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":47598,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"3a89c3a0fcff52d02608da7d4f7d8183d620995b","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","created_at":"2015-03-25T15:27:27Z","updated_at":"2015-11-30T15:31:02Z","pushed_at":"2015-11-30T16:53:39Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":49976,"stargazers_count":716,"watchers_count":716,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":279,"mirror_url":null,"open_issues_count":262,"forks":279,"open_issues":262,"watchers":716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2063"},"html":{"href":"https://github.com/systemd/systemd/pull/2063"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/2063"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/2063/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2063/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2063/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/afae249efa4774c6676738ac5de6aeb4daf4889f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":5,"additions":149,"deletions":56,"changed_files":8}}