{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/nbviewer/issues/390","labels_url":"https://api.github.com/repos/jupyter/nbviewer/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/nbviewer/issues/390/comments","events_url":"https://api.github.com/repos/jupyter/nbviewer/issues/390/events","html_url":"https://github.com/jupyter/nbviewer/pull/390","id":53959830,"number":390,"title":"adding format /slides/ for reveal.js","user":{"login":"bollwyvl","id":45380,"avatar_url":"https://avatars.githubusercontent.com/u/45380?v=3","gravatar_id":"","url":"https://api.github.com/users/bollwyvl","html_url":"https://github.com/bollwyvl","followers_url":"https://api.github.com/users/bollwyvl/followers","following_url":"https://api.github.com/users/bollwyvl/following{/other_user}","gists_url":"https://api.github.com/users/bollwyvl/gists{/gist_id}","starred_url":"https://api.github.com/users/bollwyvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollwyvl/subscriptions","organizations_url":"https://api.github.com/users/bollwyvl/orgs","repos_url":"https://api.github.com/users/bollwyvl/repos","events_url":"https://api.github.com/users/bollwyvl/events{/privacy}","received_events_url":"https://api.github.com/users/bollwyvl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-10T14:34:05Z","updated_at":"2015-03-03T18:08:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jupyter/nbviewer/pulls/390","html_url":"https://github.com/jupyter/nbviewer/pull/390","diff_url":"https://github.com/jupyter/nbviewer/pull/390.diff","patch_url":"https://github.com/jupyter/nbviewer/pull/390.patch"},"body":"Reveal.js `master` just went [3.0](https://github.com/hakimel/reveal.js/releases/tag/3.0.0): congratulations, @hakimel, and thanks for all your hard work! :trophy:\r\n\r\nThis, and the fact that bower has quieted down (#378 and #388), made it an auspicious time to reintroduce the reveal.js-based /slides/ format originally thieved from #150, and to finish off the review debt of #359 incurred by my cowboy coding. While I couldn't help myself, and did move formats out of `app`, this should be a much more manageable chunk of changes to review.\r\n\r\nFrom a UI point of view, it looks exactly the same. I certainly welcome feedback on any choices made there!\r\n\r\nUnder the hood, differences from the last slides PR:\r\n- moved formats into their own file, as it was starting to get unwieldy\r\n  - these still need to probably refactored (in another PR...) into either:\r\n    - singleton classes\r\n    - a deep config object\r\n- passing the whole format to render (API change!) so that the reveal-specific post-processing can be done by the format\r\n\r\nThanks for all the support in getting (back) here!"},"comment":{"url":"https://api.github.com/repos/jupyter/nbviewer/issues/comments/77000456","html_url":"https://github.com/jupyter/nbviewer/pull/390#issuecomment-77000456","issue_url":"https://api.github.com/repos/jupyter/nbviewer/issues/390","id":77000456,"user":{"login":"bollwyvl","id":45380,"avatar_url":"https://avatars.githubusercontent.com/u/45380?v=3","gravatar_id":"","url":"https://api.github.com/users/bollwyvl","html_url":"https://github.com/bollwyvl","followers_url":"https://api.github.com/users/bollwyvl/followers","following_url":"https://api.github.com/users/bollwyvl/following{/other_user}","gists_url":"https://api.github.com/users/bollwyvl/gists{/gist_id}","starred_url":"https://api.github.com/users/bollwyvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollwyvl/subscriptions","organizations_url":"https://api.github.com/users/bollwyvl/orgs","repos_url":"https://api.github.com/users/bollwyvl/repos","events_url":"https://api.github.com/users/bollwyvl/events{/privacy}","received_events_url":"https://api.github.com/users/bollwyvl/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T18:08:19Z","updated_at":"2015-03-03T18:08:19Z","body":"Ok! Looking forward to it!\n"}}