{"action":"created","comment":{"url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/comments/27821812","id":27821812,"diff_hunk":"@@ -39,15 +40,21 @@ class ApiWrapper\n     protected $baseurl;\n \n \n-\n     /**\n      * @param string|null $api_key\n+     * @param HttpTransferInterface $httpClient\n      */\n-    public function __construct($api_key = null)\n+    public function __construct($api_key = null, HttpTransferInterface $httpClient = null)","path":"src/DocRaptor.php","position":36,"original_position":36,"commit_id":"8403d3f6ff690beb7637b9124b5e557b2fd46928","original_commit_id":"8403d3f6ff690beb7637b9124b5e557b2fd46928","user":{"login":"markushausammann","id":723043,"avatar_url":"https://avatars.githubusercontent.com/u/723043?v=3","gravatar_id":"","url":"https://api.github.com/users/markushausammann","html_url":"https://github.com/markushausammann","followers_url":"https://api.github.com/users/markushausammann/followers","following_url":"https://api.github.com/users/markushausammann/following{/other_user}","gists_url":"https://api.github.com/users/markushausammann/gists{/gist_id}","starred_url":"https://api.github.com/users/markushausammann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markushausammann/subscriptions","organizations_url":"https://api.github.com/users/markushausammann/orgs","repos_url":"https://api.github.com/users/markushausammann/repos","events_url":"https://api.github.com/users/markushausammann/events{/privacy}","received_events_url":"https://api.github.com/users/markushausammann/received_events","type":"User","site_admin":false},"body":"I think overall, it's neat now because the signature doesn't change, so if there are any old users, they can do the same as before (with the exception of composer autoloading and namespaces) but I can still skip the key and inject the client. (oops, I didn't tick the box that tests should be run before push, the tests are broken, need to adjust them) :-)","created_at":"2015-04-06T19:20:16Z","updated_at":"2015-04-06T19:20:16Z","html_url":"https://github.com/expectedbehavior/php-docraptor/pull/25#discussion_r27821812","pull_request_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/comments/27821812"},"html":{"href":"https://github.com/expectedbehavior/php-docraptor/pull/25#discussion_r27821812"},"pull_request":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25","id":32652578,"html_url":"https://github.com/expectedbehavior/php-docraptor/pull/25","diff_url":"https://github.com/expectedbehavior/php-docraptor/pull/25.diff","patch_url":"https://github.com/expectedbehavior/php-docraptor/pull/25.patch","issue_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/25","number":25,"state":"open","locked":false,"title":"Extract http client","user":{"login":"markushausammann","id":723043,"avatar_url":"https://avatars.githubusercontent.com/u/723043?v=3","gravatar_id":"","url":"https://api.github.com/users/markushausammann","html_url":"https://github.com/markushausammann","followers_url":"https://api.github.com/users/markushausammann/followers","following_url":"https://api.github.com/users/markushausammann/following{/other_user}","gists_url":"https://api.github.com/users/markushausammann/gists{/gist_id}","starred_url":"https://api.github.com/users/markushausammann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markushausammann/subscriptions","organizations_url":"https://api.github.com/users/markushausammann/orgs","repos_url":"https://api.github.com/users/markushausammann/repos","events_url":"https://api.github.com/users/markushausammann/events{/privacy}","received_events_url":"https://api.github.com/users/markushausammann/received_events","type":"User","site_admin":false},"body":"and other small commits\r\nalso more tests.","created_at":"2015-04-05T18:47:30Z","updated_at":"2015-04-06T19:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a69765136b8a12aeb555ee2721fd9c92539b9141","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25/commits","review_comments_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25/comments","review_comment_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/25/comments","statuses_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/statuses/8403d3f6ff690beb7637b9124b5e557b2fd46928","head":{"label":"expectedbehavior:extract-http-client","ref":"extract-http-client","sha":"8403d3f6ff690beb7637b9124b5e557b2fd46928","user":{"login":"expectedbehavior","id":62844,"avatar_url":"https://avatars.githubusercontent.com/u/62844?v=3","gravatar_id":"","url":"https://api.github.com/users/expectedbehavior","html_url":"https://github.com/expectedbehavior","followers_url":"https://api.github.com/users/expectedbehavior/followers","following_url":"https://api.github.com/users/expectedbehavior/following{/other_user}","gists_url":"https://api.github.com/users/expectedbehavior/gists{/gist_id}","starred_url":"https://api.github.com/users/expectedbehavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectedbehavior/subscriptions","organizations_url":"https://api.github.com/users/expectedbehavior/orgs","repos_url":"https://api.github.com/users/expectedbehavior/repos","events_url":"https://api.github.com/users/expectedbehavior/events{/privacy}","received_events_url":"https://api.github.com/users/expectedbehavior/received_events","type":"Organization","site_admin":false},"repo":{"id":12570975,"name":"php-docraptor","full_name":"expectedbehavior/php-docraptor","owner":{"login":"expectedbehavior","id":62844,"avatar_url":"https://avatars.githubusercontent.com/u/62844?v=3","gravatar_id":"","url":"https://api.github.com/users/expectedbehavior","html_url":"https://github.com/expectedbehavior","followers_url":"https://api.github.com/users/expectedbehavior/followers","following_url":"https://api.github.com/users/expectedbehavior/following{/other_user}","gists_url":"https://api.github.com/users/expectedbehavior/gists{/gist_id}","starred_url":"https://api.github.com/users/expectedbehavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectedbehavior/subscriptions","organizations_url":"https://api.github.com/users/expectedbehavior/orgs","repos_url":"https://api.github.com/users/expectedbehavior/repos","events_url":"https://api.github.com/users/expectedbehavior/events{/privacy}","received_events_url":"https://api.github.com/users/expectedbehavior/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/expectedbehavior/php-docraptor","description":"PHP consumer for the DocRaptor.com API","fork":true,"url":"https://api.github.com/repos/expectedbehavior/php-docraptor","forks_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/forks","keys_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/teams","hooks_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/hooks","issue_events_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/events{/number}","events_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/events","assignees_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/assignees{/user}","branches_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/branches{/branch}","tags_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/tags","blobs_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/refs{/sha}","trees_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/statuses/{sha}","languages_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/languages","stargazers_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/stargazers","contributors_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/contributors","subscribers_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/subscribers","subscription_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/subscription","commits_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/commits{/sha}","git_commits_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/commits{/sha}","comments_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/comments{/number}","issue_comment_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/comments{/number}","contents_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/contents/{+path}","compare_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/merges","archive_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/downloads","issues_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues{/number}","pulls_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls{/number}","milestones_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/milestones{/number}","notifications_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/labels{/name}","releases_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/releases{/id}","created_at":"2013-09-03T18:03:07Z","updated_at":"2015-04-05T20:30:03Z","pushed_at":"2015-04-06T19:15:28Z","git_url":"git://github.com/expectedbehavior/php-docraptor.git","ssh_url":"git@github.com:expectedbehavior/php-docraptor.git","clone_url":"https://github.com/expectedbehavior/php-docraptor.git","svn_url":"https://github.com/expectedbehavior/php-docraptor","homepage":"","size":404,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"expectedbehavior:master","ref":"master","sha":"f7bc961286cf0748b6438c82c06f0740c6d49d98","user":{"login":"expectedbehavior","id":62844,"avatar_url":"https://avatars.githubusercontent.com/u/62844?v=3","gravatar_id":"","url":"https://api.github.com/users/expectedbehavior","html_url":"https://github.com/expectedbehavior","followers_url":"https://api.github.com/users/expectedbehavior/followers","following_url":"https://api.github.com/users/expectedbehavior/following{/other_user}","gists_url":"https://api.github.com/users/expectedbehavior/gists{/gist_id}","starred_url":"https://api.github.com/users/expectedbehavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectedbehavior/subscriptions","organizations_url":"https://api.github.com/users/expectedbehavior/orgs","repos_url":"https://api.github.com/users/expectedbehavior/repos","events_url":"https://api.github.com/users/expectedbehavior/events{/privacy}","received_events_url":"https://api.github.com/users/expectedbehavior/received_events","type":"Organization","site_admin":false},"repo":{"id":12570975,"name":"php-docraptor","full_name":"expectedbehavior/php-docraptor","owner":{"login":"expectedbehavior","id":62844,"avatar_url":"https://avatars.githubusercontent.com/u/62844?v=3","gravatar_id":"","url":"https://api.github.com/users/expectedbehavior","html_url":"https://github.com/expectedbehavior","followers_url":"https://api.github.com/users/expectedbehavior/followers","following_url":"https://api.github.com/users/expectedbehavior/following{/other_user}","gists_url":"https://api.github.com/users/expectedbehavior/gists{/gist_id}","starred_url":"https://api.github.com/users/expectedbehavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expectedbehavior/subscriptions","organizations_url":"https://api.github.com/users/expectedbehavior/orgs","repos_url":"https://api.github.com/users/expectedbehavior/repos","events_url":"https://api.github.com/users/expectedbehavior/events{/privacy}","received_events_url":"https://api.github.com/users/expectedbehavior/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/expectedbehavior/php-docraptor","description":"PHP consumer for the DocRaptor.com API","fork":true,"url":"https://api.github.com/repos/expectedbehavior/php-docraptor","forks_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/forks","keys_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/teams","hooks_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/hooks","issue_events_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/events{/number}","events_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/events","assignees_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/assignees{/user}","branches_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/branches{/branch}","tags_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/tags","blobs_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/refs{/sha}","trees_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/statuses/{sha}","languages_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/languages","stargazers_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/stargazers","contributors_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/contributors","subscribers_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/subscribers","subscription_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/subscription","commits_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/commits{/sha}","git_commits_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/git/commits{/sha}","comments_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/comments{/number}","issue_comment_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/comments{/number}","contents_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/contents/{+path}","compare_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/merges","archive_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/downloads","issues_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues{/number}","pulls_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls{/number}","milestones_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/milestones{/number}","notifications_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/labels{/name}","releases_url":"https://api.github.com/repos/expectedbehavior/php-docraptor/releases{/id}","created_at":"2013-09-03T18:03:07Z","updated_at":"2015-04-05T20:30:03Z","pushed_at":"2015-04-06T19:15:28Z","git_url":"git://github.com/expectedbehavior/php-docraptor.git","ssh_url":"git@github.com:expectedbehavior/php-docraptor.git","clone_url":"https://github.com/expectedbehavior/php-docraptor.git","svn_url":"https://github.com/expectedbehavior/php-docraptor","homepage":"","size":404,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25"},"html":{"href":"https://github.com/expectedbehavior/php-docraptor/pull/25"},"issue":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/25"},"comments":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/expectedbehavior/php-docraptor/statuses/8403d3f6ff690beb7637b9124b5e557b2fd46928"}}}}