{"action":"created","comment":{"url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/comments/45644909","id":45644909,"diff_hunk":"@@ -98,14 +98,12 @@ export default React.createClass({\n     propTypes: {\n         onSubmit: PropTypes.func,\n         onChange: PropTypes.func,\n-        children: PropTypes.oneOfType([\n-            PropTypes.object,\n-            PropTypes.array\n-        ])\n+        children: PropTypes.node\n     },\n \n     onChange() {\n-        console.log('onChange');\n+        console.log('onChange', this.refs);","path":"src/form.js","position":13,"original_position":13,"commit_id":"7b10e629b91674821fe9e9eb77de8ab128817923","original_commit_id":"7b10e629b91674821fe9e9eb77de8ab128817923","user":{"login":"oconn","id":4649439,"avatar_url":"https://avatars.githubusercontent.com/u/4649439?v=3","gravatar_id":"","url":"https://api.github.com/users/oconn","html_url":"https://github.com/oconn","followers_url":"https://api.github.com/users/oconn/followers","following_url":"https://api.github.com/users/oconn/following{/other_user}","gists_url":"https://api.github.com/users/oconn/gists{/gist_id}","starred_url":"https://api.github.com/users/oconn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconn/subscriptions","organizations_url":"https://api.github.com/users/oconn/orgs","repos_url":"https://api.github.com/users/oconn/repos","events_url":"https://api.github.com/users/oconn/events{/privacy}","received_events_url":"https://api.github.com/users/oconn/received_events","type":"User","site_admin":false},"body":"@kaw2k do we want to leave this log statement in? ","created_at":"2015-11-23T19:03:07Z","updated_at":"2015-11-23T19:03:07Z","html_url":"https://github.com/willowtreeapps/wat-forms/pull/1#discussion_r45644909","pull_request_url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/comments/45644909"},"html":{"href":"https://github.com/willowtreeapps/wat-forms/pull/1#discussion_r45644909"},"pull_request":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1","id":51542954,"html_url":"https://github.com/willowtreeapps/wat-forms/pull/1","diff_url":"https://github.com/willowtreeapps/wat-forms/pull/1.diff","patch_url":"https://github.com/willowtreeapps/wat-forms/pull/1.patch","issue_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/1","number":1,"state":"open","locked":false,"title":"Removing the `ref` dependency from Form inputs","user":{"login":"kaw2k","id":694324,"avatar_url":"https://avatars.githubusercontent.com/u/694324?v=3","gravatar_id":"","url":"https://api.github.com/users/kaw2k","html_url":"https://github.com/kaw2k","followers_url":"https://api.github.com/users/kaw2k/followers","following_url":"https://api.github.com/users/kaw2k/following{/other_user}","gists_url":"https://api.github.com/users/kaw2k/gists{/gist_id}","starred_url":"https://api.github.com/users/kaw2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaw2k/subscriptions","organizations_url":"https://api.github.com/users/kaw2k/orgs","repos_url":"https://api.github.com/users/kaw2k/repos","events_url":"https://api.github.com/users/kaw2k/events{/privacy}","received_events_url":"https://api.github.com/users/kaw2k/received_events","type":"User","site_admin":false},"body":"Before we would require that all inputs need to specify `ref` in order to be serialized. Instead, we will require all form components to have a `name` prop (or something similar). The Form itself will handle refs and whatnot.\r\n\r\nOne major(?) drawback is that anything with a `name` prop will not be accessible to the parent component via `this.refs`. We will need to have a helper method on the form that can get inputs. This is due to the fact that we are cloning these elements and the parent looses scope. We should document this well. ","created_at":"2015-11-23T16:09:06Z","updated_at":"2015-11-23T19:03:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f233be85aeb92434b4fe901568a1de47fb9cd81","assignee":{"login":"oconn","id":4649439,"avatar_url":"https://avatars.githubusercontent.com/u/4649439?v=3","gravatar_id":"","url":"https://api.github.com/users/oconn","html_url":"https://github.com/oconn","followers_url":"https://api.github.com/users/oconn/followers","following_url":"https://api.github.com/users/oconn/following{/other_user}","gists_url":"https://api.github.com/users/oconn/gists{/gist_id}","starred_url":"https://api.github.com/users/oconn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconn/subscriptions","organizations_url":"https://api.github.com/users/oconn/orgs","repos_url":"https://api.github.com/users/oconn/repos","events_url":"https://api.github.com/users/oconn/events{/privacy}","received_events_url":"https://api.github.com/users/oconn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1/commits","review_comments_url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1/comments","review_comment_url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/1/comments","statuses_url":"https://api.github.com/repos/willowtreeapps/wat-forms/statuses/7b10e629b91674821fe9e9eb77de8ab128817923","head":{"label":"willowtreeapps:ref-removal","ref":"ref-removal","sha":"7b10e629b91674821fe9e9eb77de8ab128817923","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":42971819,"name":"wat-forms","full_name":"willowtreeapps/wat-forms","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/wat-forms","description":"React Forms","fork":false,"url":"https://api.github.com/repos/willowtreeapps/wat-forms","forks_url":"https://api.github.com/repos/willowtreeapps/wat-forms/forks","keys_url":"https://api.github.com/repos/willowtreeapps/wat-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/wat-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/wat-forms/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/wat-forms/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/wat-forms/events","assignees_url":"https://api.github.com/repos/willowtreeapps/wat-forms/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/wat-forms/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/wat-forms/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/wat-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/wat-forms/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/wat-forms/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/wat-forms/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/wat-forms/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/wat-forms/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/wat-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/wat-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/wat-forms/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/wat-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/wat-forms/merges","archive_url":"https://api.github.com/repos/willowtreeapps/wat-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/wat-forms/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/wat-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/wat-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/wat-forms/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/wat-forms/releases{/id}","created_at":"2015-09-23T01:49:30Z","updated_at":"2015-09-25T03:28:21Z","pushed_at":"2015-11-23T16:09:07Z","git_url":"git://github.com/willowtreeapps/wat-forms.git","ssh_url":"git@github.com:willowtreeapps/wat-forms.git","clone_url":"https://github.com/willowtreeapps/wat-forms.git","svn_url":"https://github.com/willowtreeapps/wat-forms","homepage":null,"size":10,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"willowtreeapps:master","ref":"master","sha":"38231203dea5954dae4e0cd488ac4f6bac511357","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":42971819,"name":"wat-forms","full_name":"willowtreeapps/wat-forms","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/wat-forms","description":"React Forms","fork":false,"url":"https://api.github.com/repos/willowtreeapps/wat-forms","forks_url":"https://api.github.com/repos/willowtreeapps/wat-forms/forks","keys_url":"https://api.github.com/repos/willowtreeapps/wat-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/wat-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/wat-forms/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/wat-forms/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/wat-forms/events","assignees_url":"https://api.github.com/repos/willowtreeapps/wat-forms/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/wat-forms/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/wat-forms/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/wat-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/wat-forms/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/wat-forms/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/wat-forms/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/wat-forms/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/wat-forms/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/wat-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/wat-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/wat-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/wat-forms/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/wat-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/wat-forms/merges","archive_url":"https://api.github.com/repos/willowtreeapps/wat-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/wat-forms/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/wat-forms/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/wat-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/wat-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/wat-forms/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/wat-forms/releases{/id}","created_at":"2015-09-23T01:49:30Z","updated_at":"2015-09-25T03:28:21Z","pushed_at":"2015-11-23T16:09:07Z","git_url":"git://github.com/willowtreeapps/wat-forms.git","ssh_url":"git@github.com:willowtreeapps/wat-forms.git","clone_url":"https://github.com/willowtreeapps/wat-forms.git","svn_url":"https://github.com/willowtreeapps/wat-forms","homepage":null,"size":10,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1"},"html":{"href":"https://github.com/willowtreeapps/wat-forms/pull/1"},"issue":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/1"},"comments":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/willowtreeapps/wat-forms/statuses/7b10e629b91674821fe9e9eb77de8ab128817923"}}}}