{"push_id":835076829,"size":25,"distinct_size":0,"ref":"refs/heads/deployed-to-production","head":"719077a005ef56a111124a43a20e0c427787b0d4","before":"9d9eb8f64645f9b88573459a08408a6200af2e2c","commits":[{"sha":"797f65207989f409f4c7a6a1a3b81ccdacadcd10","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Upgrades rails/mongoid and necessary gems\n\nThis takes care of the most involving parts of the upgrade. In summary:\n\n* Bring rails configuration up to date\n* Removed redundant mongo configuration\n* Removed redundant CVE monkey patch\n* Moved test helper methods into an accessible scope\n* Assert constrained routes raise routing errors\n* Fixed webmock stubs and removed duplicated/redundant attributes\n\nI've temporarily skipped one of the old `attr_accessible` specs. I'll\ncome back to this next and replace with strong parameters.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/797f65207989f409f4c7a6a1a3b81ccdacadcd10"},{"sha":"a88f6d2934feb7f3da24eab38aca8d24d6ee4b02","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Bumps other general dependencies\n\nI've used the pessimistic scheme with those dependencies we can trust to\nfollow semantic versioning. Database cleaner has gone as far as it can\ncurrently go due to a bug in their library.\n\nBumping formtastic required a few tweaks, namely\n`Organisation.to_options` and `Organisation#to_option` for the\nlabel/value pairs required to remove the `member_label` deprecation.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/a88f6d2934feb7f3da24eab38aca8d24d6ee4b02"},{"sha":"7140bc4e4e52a78e57a9d4f1653bc4ec01f999d0","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Use strong parameters when creating/updating need","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/7140bc4e4e52a78e57a9d4f1653bc4ec01f999d0"},{"sha":"06cbdbe971952f157e5f292b4320325a623c83b1","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Converts to strong parameters\n\nAlso took the opportunity to refactor in a few spots.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/06cbdbe971952f157e5f292b4320325a623c83b1"},{"sha":"dbd5406745da51f1b1c9122deda38ec7b4a0974a","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Removes redundant test\n\nTurns out this is just not necessary anyway. Nowhere are users created\nin response to user input, thus it doesn't need whitelisting, thus this\ntest is redundant.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/dbd5406745da51f1b1c9122deda38ec7b4a0974a"},{"sha":"2d4fe4c0acd3a0f2285807ea8a67fbd9308255b5","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Remove coverage\n\nIt's a vanity metric that nobody cares about.\n\nThis may require some tweakery to the CI configuration.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/2d4fe4c0acd3a0f2285807ea8a67fbd9308255b5"},{"sha":"fd6a2f746ed8b59ad07eef6cd5e4c36af3e540fc","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Add `gov-uk-lint` to enforce the styleguides\n\nAlso fixes up the violations that would have been included in the\ncurrent diff to `master`.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/fd6a2f746ed8b59ad07eef6cd5e4c36af3e540fc"},{"sha":"124eb190abc2a08a3f101d91f2ddbdcd1a1536c8","author":{"email":"9c380d388050cdb31e87cd3869c5eb2cbeac4079@gmail.com","name":"Paul Bowsher"},"message":"Merge pull request #142 from alphagov/rails-4x-upgrade\n\nUpgrade all the things","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/124eb190abc2a08a3f101d91f2ddbdcd1a1536c8"},{"sha":"1896418ebb0cd60c6887d5113ce8f8c76a305246","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Autocorrect violations in the `app` directory","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/1896418ebb0cd60c6887d5113ce8f8c76a305246"},{"sha":"02eed9651ba9d4bd0d8f58cef708e5372e2a21ef","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Autocorrect violations in the `config` directory","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/02eed9651ba9d4bd0d8f58cef708e5372e2a21ef"},{"sha":"cdf80cf0b5a10b844e59ae36a4b8f4a0098227d9","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Autocorrect violations in the `test` directory","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/cdf80cf0b5a10b844e59ae36a4b8f4a0098227d9"},{"sha":"dccac549ed0785f935134396c55c5a1ac334e688","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Autocorrect violations everywhere else","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/dccac549ed0785f935134396c55c5a1ac334e688"},{"sha":"b8e4cbbeb4fceab7f77ce5dbd1722ef8d6b93e32","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Fix oddly positioned default arguments\n\nCame across this oddity that was also flagged by the linter.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/b8e4cbbeb4fceab7f77ce5dbd1722ef8d6b93e32"},{"sha":"21b94241beaad17ca8a6a68a14b870935327a324","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Add space within hash braces\n\nThis is per our styleguide. Rubocop seems to have missed this one so\nI'll investigate whether this cop is incorrectly disabled or\nmisconfigured.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/21b94241beaad17ca8a6a68a14b870935327a324"},{"sha":"fb05b6de0bf5355870d03854fa021741333a38cd","author":{"email":"9c380d388050cdb31e87cd3869c5eb2cbeac4079@gmail.com","name":"Paul Bowsher"},"message":"Merge pull request #143 from alphagov/lint-autocorrects\n\nAutocorrect all the things","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/fb05b6de0bf5355870d03854fa021741333a38cd"},{"sha":"ae47ca72341aa241cececede1e780156363cbe18","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Explicitly require test dependencies\n\nThis is just generally good style, but also fixes an intermittent load\norder failure in the test suite that popped up in CI when ran with\n`bundle exec rake SEED=61059`\n\nAlso added this in the `nav_tabs_helper` test for consistency.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/ae47ca72341aa241cececede1e780156363cbe18"},{"sha":"0769e2682a95edb183a836fd952e56339461feda","author":{"email":"9c380d388050cdb31e87cd3869c5eb2cbeac4079@gmail.com","name":"Paul Bowsher"},"message":"Merge pull request #144 from alphagov/fix-nondeterministic-loading\n\nExplicitly require test dependencies","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/0769e2682a95edb183a836fd952e56339461feda"},{"sha":"2ef357f3794454443d73911aa2cf2037d5ba21ee","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Drop the `.css` from sass filenames\n\nThis will remove the deprecation messages in CI.","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/2ef357f3794454443d73911aa2cf2037d5ba21ee"},{"sha":"3f5cb7d54d7909c1d203b489f126eb95ff427277","author":{"email":"4587b71a81b1a01d774ffa648ef57e13aebc6730@gmail.com","name":"Jake Benilov"},"message":"Merge pull request #145 from alphagov/remove-sass-deprecations\n\nDrop the `.css` from sass filenames","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/3f5cb7d54d7909c1d203b489f126eb95ff427277"},{"sha":"d2a45dc50af0de0e376e4d1dd78c7e5e31e1b8d4","author":{"email":"daa5c1e9ec6da0d016c84052d1057fa3360b9f80@gmail.com","name":"Ben Lovell"},"message":"Fix attempted persistence of dynamic attributes\n\nMongoid was borked in production as a consequence of bumping\nalphagov/gds-sso to `11.0.0`. An attempt would be made to update the\ngiven user with the `organisation_content_id` attribute but the `User`\nmodel did not explicitly declare this attribute.\n\nFor reference, errors were of the following nature:\n\n```\nMongoid::Errors::UnknownAttribute: Problem: Attempted to set a value for\n'organisation_content_id' which is not allowed on the model User.\nSummary: Without including Mongoid::Attributes::Dynamic in your model\nand the attribute does not already exist in the attributes hash,\nattempting to call User#organisation_content_id= for it is not allowed.\nThis is also triggered by passing the attribute to any method that\naccepts an attributes hash, and is raised instead of getting a\nNoMethodError. Resolution: You can include Mongoid::Attributes::Dynamic\nif you expect to be writing values for undefined fields often.\n```","distinct":false,"url":"https://api.github.com/repos/alphagov/maslow/commits/d2a45dc50af0de0e376e4d1dd78c7e5e31e1b8d4"}]}