{"action":"opened","issue":{"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-suppressionlist/issues/48","labels_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-suppressionlist/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-suppressionlist/issues/48/comments","events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-suppressionlist/issues/48/events","html_url":"https://github.com/activeprospect/leadconduit-integration-suppressionlist/issues/48","id":111061873,"number":48,"title":"Value parsing using leadconduit-types is unnecessary","user":{"login":"alexkwolfe","id":569,"avatar_url":"https://avatars.githubusercontent.com/u/569?v=3","gravatar_id":"","url":"https://api.github.com/users/alexkwolfe","html_url":"https://github.com/alexkwolfe","followers_url":"https://api.github.com/users/alexkwolfe/followers","following_url":"https://api.github.com/users/alexkwolfe/following{/other_user}","gists_url":"https://api.github.com/users/alexkwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkwolfe/subscriptions","organizations_url":"https://api.github.com/users/alexkwolfe/orgs","repos_url":"https://api.github.com/users/alexkwolfe/repos","events_url":"https://api.github.com/users/alexkwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/alexkwolfe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-suppressionlist/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-12T21:44:45Z","updated_at":"2015-10-12T21:44:45Z","closed_at":null,"body":"The lead handler automatically parses values per the type declared in the response variables. Therefore, there is no need to use leadconduit-types to parse them in the integration. In fact, this can be detrimental if the integration is using an out-of-date leadconduit-types module (as this one is).\r\n\r\nThis line should not be calling `types.parse`:\r\nhttps://github.com/activeprospect/leadconduit-integration-suppressionlist/blob/master/src/query_item.coffee#L28\r\n\r\nIt's sufficient to just return the raw `added_at` value.\r\n\r\nI found this issue because this integration was choking because SuppressionList is returning `null` for the `added_at` property, and the dependent version of leadconduit-types can't deal with that. "}}