{"action":"reopened","number":24,"pull_request":{"url":"https://api.github.com/repos/fatih/structs/pulls/24","id":30453093,"html_url":"https://github.com/fatih/structs/pull/24","diff_url":"https://github.com/fatih/structs/pull/24.diff","patch_url":"https://github.com/fatih/structs/pull/24.patch","issue_url":"https://api.github.com/repos/fatih/structs/issues/24","number":24,"state":"open","locked":false,"title":"Custom default tag name for each struct","user":{"login":"nullbus","id":7009407,"avatar_url":"https://avatars.githubusercontent.com/u/7009407?v=3","gravatar_id":"","url":"https://api.github.com/users/nullbus","html_url":"https://github.com/nullbus","followers_url":"https://api.github.com/users/nullbus/followers","following_url":"https://api.github.com/users/nullbus/following{/other_user}","gists_url":"https://api.github.com/users/nullbus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullbus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullbus/subscriptions","organizations_url":"https://api.github.com/users/nullbus/orgs","repos_url":"https://api.github.com/users/nullbus/repos","events_url":"https://api.github.com/users/nullbus/events{/privacy}","received_events_url":"https://api.github.com/users/nullbus/received_events","type":"User","site_admin":false},"body":"I think modifying and using global variable is bad practice. If using this with many custom field tags, it can cause race condition.\r\nSo I made change to each struct to have default tag name. It will increase more goroutine safety.\r\n\r\nI wanted to eliminate the global DefaultTagName variable, but I didn't since it affects all users watching.\r\nTake a look and advice me if I did wrong.\r\nThank you!","created_at":"2015-03-04T10:22:50Z","updated_at":"2015-03-04T16:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56fdfcc5bffd758107bd6fd1afdd94e9fbd5e8e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fatih/structs/pulls/24/commits","review_comments_url":"https://api.github.com/repos/fatih/structs/pulls/24/comments","review_comment_url":"https://api.github.com/repos/fatih/structs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fatih/structs/issues/24/comments","statuses_url":"https://api.github.com/repos/fatih/structs/statuses/aaa985b57c885dc6740fbafeb9dc629d605d4024","head":{"label":"nullbus:master","ref":"master","sha":"aaa985b57c885dc6740fbafeb9dc629d605d4024","user":{"login":"nullbus","id":7009407,"avatar_url":"https://avatars.githubusercontent.com/u/7009407?v=3","gravatar_id":"","url":"https://api.github.com/users/nullbus","html_url":"https://github.com/nullbus","followers_url":"https://api.github.com/users/nullbus/followers","following_url":"https://api.github.com/users/nullbus/following{/other_user}","gists_url":"https://api.github.com/users/nullbus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullbus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullbus/subscriptions","organizations_url":"https://api.github.com/users/nullbus/orgs","repos_url":"https://api.github.com/users/nullbus/repos","events_url":"https://api.github.com/users/nullbus/events{/privacy}","received_events_url":"https://api.github.com/users/nullbus/received_events","type":"User","site_admin":false},"repo":{"id":31649110,"name":"structs","full_name":"nullbus/structs","owner":{"login":"nullbus","id":7009407,"avatar_url":"https://avatars.githubusercontent.com/u/7009407?v=3","gravatar_id":"","url":"https://api.github.com/users/nullbus","html_url":"https://github.com/nullbus","followers_url":"https://api.github.com/users/nullbus/followers","following_url":"https://api.github.com/users/nullbus/following{/other_user}","gists_url":"https://api.github.com/users/nullbus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullbus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullbus/subscriptions","organizations_url":"https://api.github.com/users/nullbus/orgs","repos_url":"https://api.github.com/users/nullbus/repos","events_url":"https://api.github.com/users/nullbus/events{/privacy}","received_events_url":"https://api.github.com/users/nullbus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nullbus/structs","description":"Utilities for Go structs","fork":true,"url":"https://api.github.com/repos/nullbus/structs","forks_url":"https://api.github.com/repos/nullbus/structs/forks","keys_url":"https://api.github.com/repos/nullbus/structs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nullbus/structs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nullbus/structs/teams","hooks_url":"https://api.github.com/repos/nullbus/structs/hooks","issue_events_url":"https://api.github.com/repos/nullbus/structs/issues/events{/number}","events_url":"https://api.github.com/repos/nullbus/structs/events","assignees_url":"https://api.github.com/repos/nullbus/structs/assignees{/user}","branches_url":"https://api.github.com/repos/nullbus/structs/branches{/branch}","tags_url":"https://api.github.com/repos/nullbus/structs/tags","blobs_url":"https://api.github.com/repos/nullbus/structs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nullbus/structs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nullbus/structs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nullbus/structs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nullbus/structs/statuses/{sha}","languages_url":"https://api.github.com/repos/nullbus/structs/languages","stargazers_url":"https://api.github.com/repos/nullbus/structs/stargazers","contributors_url":"https://api.github.com/repos/nullbus/structs/contributors","subscribers_url":"https://api.github.com/repos/nullbus/structs/subscribers","subscription_url":"https://api.github.com/repos/nullbus/structs/subscription","commits_url":"https://api.github.com/repos/nullbus/structs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nullbus/structs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nullbus/structs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nullbus/structs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nullbus/structs/contents/{+path}","compare_url":"https://api.github.com/repos/nullbus/structs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nullbus/structs/merges","archive_url":"https://api.github.com/repos/nullbus/structs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nullbus/structs/downloads","issues_url":"https://api.github.com/repos/nullbus/structs/issues{/number}","pulls_url":"https://api.github.com/repos/nullbus/structs/pulls{/number}","milestones_url":"https://api.github.com/repos/nullbus/structs/milestones{/number}","notifications_url":"https://api.github.com/repos/nullbus/structs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nullbus/structs/labels{/name}","releases_url":"https://api.github.com/repos/nullbus/structs/releases{/id}","created_at":"2015-03-04T09:36:41Z","updated_at":"2015-03-04T10:12:56Z","pushed_at":"2015-03-04T10:12:56Z","git_url":"git://github.com/nullbus/structs.git","ssh_url":"git@github.com:nullbus/structs.git","clone_url":"https://github.com/nullbus/structs.git","svn_url":"https://github.com/nullbus/structs","homepage":"http://godoc.org/github.com/fatih/structs","size":157,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fatih:master","ref":"master","sha":"bc210cbd8c7fe94bb15fa0d744bc60806f44345f","user":{"login":"fatih","id":438920,"avatar_url":"https://avatars.githubusercontent.com/u/438920?v=3","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"repo":{"id":22284914,"name":"structs","full_name":"fatih/structs","owner":{"login":"fatih","id":438920,"avatar_url":"https://avatars.githubusercontent.com/u/438920?v=3","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatih/structs","description":"Utilities for Go structs","fork":false,"url":"https://api.github.com/repos/fatih/structs","forks_url":"https://api.github.com/repos/fatih/structs/forks","keys_url":"https://api.github.com/repos/fatih/structs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatih/structs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatih/structs/teams","hooks_url":"https://api.github.com/repos/fatih/structs/hooks","issue_events_url":"https://api.github.com/repos/fatih/structs/issues/events{/number}","events_url":"https://api.github.com/repos/fatih/structs/events","assignees_url":"https://api.github.com/repos/fatih/structs/assignees{/user}","branches_url":"https://api.github.com/repos/fatih/structs/branches{/branch}","tags_url":"https://api.github.com/repos/fatih/structs/tags","blobs_url":"https://api.github.com/repos/fatih/structs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatih/structs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatih/structs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatih/structs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatih/structs/statuses/{sha}","languages_url":"https://api.github.com/repos/fatih/structs/languages","stargazers_url":"https://api.github.com/repos/fatih/structs/stargazers","contributors_url":"https://api.github.com/repos/fatih/structs/contributors","subscribers_url":"https://api.github.com/repos/fatih/structs/subscribers","subscription_url":"https://api.github.com/repos/fatih/structs/subscription","commits_url":"https://api.github.com/repos/fatih/structs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatih/structs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatih/structs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatih/structs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatih/structs/contents/{+path}","compare_url":"https://api.github.com/repos/fatih/structs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatih/structs/merges","archive_url":"https://api.github.com/repos/fatih/structs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatih/structs/downloads","issues_url":"https://api.github.com/repos/fatih/structs/issues{/number}","pulls_url":"https://api.github.com/repos/fatih/structs/pulls{/number}","milestones_url":"https://api.github.com/repos/fatih/structs/milestones{/number}","notifications_url":"https://api.github.com/repos/fatih/structs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatih/structs/labels{/name}","releases_url":"https://api.github.com/repos/fatih/structs/releases{/id}","created_at":"2014-07-26T11:08:52Z","updated_at":"2015-03-04T10:33:41Z","pushed_at":"2014-12-12T23:52:27Z","git_url":"git://github.com/fatih/structs.git","ssh_url":"git@github.com:fatih/structs.git","clone_url":"https://github.com/fatih/structs.git","svn_url":"https://github.com/fatih/structs","homepage":"http://godoc.org/github.com/fatih/structs","size":498,"stargazers_count":402,"watchers_count":402,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":1,"forks":31,"open_issues":1,"watchers":402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fatih/structs/pulls/24"},"html":{"href":"https://github.com/fatih/structs/pull/24"},"issue":{"href":"https://api.github.com/repos/fatih/structs/issues/24"},"comments":{"href":"https://api.github.com/repos/fatih/structs/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/fatih/structs/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/fatih/structs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fatih/structs/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/fatih/structs/statuses/aaa985b57c885dc6740fbafeb9dc629d605d4024"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":50,"deletions":23,"changed_files":3}}