{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/41556181","id":41556181,"diff_hunk":"@@ -15,7 +15,7 @@ extension RACScheduler: DateSchedulerType {\n \t}\n \n \tpublic func schedule(action: () -> ()) -> Disposable? {\n-\t\treturn self.schedule(action)\n+\t\treturn (self.schedule(action) as RACDisposable) as Disposable?","path":"ReactiveCocoa/Swift/ObjectiveCBridging.swift","position":null,"original_position":5,"commit_id":"078846a2a29f6da144d546411f34d95cc9fb0610","original_commit_id":"224124d1491576184c4fb704ee214309b0b7700b","user":{"login":"NachoSoto","id":685609,"avatar_url":"https://avatars.githubusercontent.com/u/685609?v=3","gravatar_id":"","url":"https://api.github.com/users/NachoSoto","html_url":"https://github.com/NachoSoto","followers_url":"https://api.github.com/users/NachoSoto/followers","following_url":"https://api.github.com/users/NachoSoto/following{/other_user}","gists_url":"https://api.github.com/users/NachoSoto/gists{/gist_id}","starred_url":"https://api.github.com/users/NachoSoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NachoSoto/subscriptions","organizations_url":"https://api.github.com/users/NachoSoto/orgs","repos_url":"https://api.github.com/users/NachoSoto/repos","events_url":"https://api.github.com/users/NachoSoto/events{/privacy}","received_events_url":"https://api.github.com/users/NachoSoto/received_events","type":"User","site_admin":false},"body":"Ooooh yes, we were talking about different things.\r\nI meant that in this example:\r\n\r\n```swift\r\nprotocol Disposable {}\r\nclass RACDisposable: Disposable {}\r\n\r\nclass RACScheduler: DateSchedulerType {\r\n  func schedule() -> Disposable! {\r\n     // This coercion works.\r\n     // But I think it's good to implement the method\r\n     // explicitly for documentation purposes.\r\n     // And I'm not 100% sure Swift would understand that\r\n     // that this DOES implement DateSchedulerType without it.\r\n     return RACDisposable()\r\n  }\r\n}\r\n```","created_at":"2015-10-08T19:20:57Z","updated_at":"2015-10-08T19:20:57Z","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2450#discussion_r41556181","pull_request_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450","_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/41556181"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2450#discussion_r41556181"},"pull_request":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450","id":47089159,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2450","diff_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2450.diff","patch_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2450.patch","issue_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2450","number":2450,"state":"open","locked":false,"title":"Fixed infinite recursion in RACScheduler.schedule","user":{"login":"NachoSoto","id":685609,"avatar_url":"https://avatars.githubusercontent.com/u/685609?v=3","gravatar_id":"","url":"https://api.github.com/users/NachoSoto","html_url":"https://github.com/NachoSoto","followers_url":"https://api.github.com/users/NachoSoto/followers","following_url":"https://api.github.com/users/NachoSoto/following{/other_user}","gists_url":"https://api.github.com/users/NachoSoto/gists{/gist_id}","starred_url":"https://api.github.com/users/NachoSoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NachoSoto/subscriptions","organizations_url":"https://api.github.com/users/NachoSoto/orgs","repos_url":"https://api.github.com/users/NachoSoto/repos","events_url":"https://api.github.com/users/NachoSoto/events{/privacy}","received_events_url":"https://api.github.com/users/NachoSoto/received_events","type":"User","site_admin":false},"body":"We ran into this infinite recursion in the Khan Academy app, and @andymatuschak traced down the issue to this.\r\nI added (previously lacking!) test coverage for this and fixed the implementation.","created_at":"2015-10-07T22:10:26Z","updated_at":"2015-10-08T19:20:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef48afe964c8cd29a64514e6c73fd0eeebf573bc","assignee":null,"milestone":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones/5","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/milestones/4.0","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones/5/labels","id":1167095,"number":5,"title":"4.0","description":"RAC4 targeting Swift 2","creator":{"login":"neilpa","id":42419,"avatar_url":"https://avatars.githubusercontent.com/u/42419?v=3","gravatar_id":"","url":"https://api.github.com/users/neilpa","html_url":"https://github.com/neilpa","followers_url":"https://api.github.com/users/neilpa/followers","following_url":"https://api.github.com/users/neilpa/following{/other_user}","gists_url":"https://api.github.com/users/neilpa/gists{/gist_id}","starred_url":"https://api.github.com/users/neilpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilpa/subscriptions","organizations_url":"https://api.github.com/users/neilpa/orgs","repos_url":"https://api.github.com/users/neilpa/repos","events_url":"https://api.github.com/users/neilpa/events{/privacy}","received_events_url":"https://api.github.com/users/neilpa/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":38,"state":"open","created_at":"2015-06-16T16:34:39Z","updated_at":"2015-10-07T22:10:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450/commits","review_comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450/comments","review_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2450/comments","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/078846a2a29f6da144d546411f34d95cc9fb0610","head":{"label":"NachoSoto:disposable-test","ref":"disposable-test","sha":"078846a2a29f6da144d546411f34d95cc9fb0610","user":{"login":"NachoSoto","id":685609,"avatar_url":"https://avatars.githubusercontent.com/u/685609?v=3","gravatar_id":"","url":"https://api.github.com/users/NachoSoto","html_url":"https://github.com/NachoSoto","followers_url":"https://api.github.com/users/NachoSoto/followers","following_url":"https://api.github.com/users/NachoSoto/following{/other_user}","gists_url":"https://api.github.com/users/NachoSoto/gists{/gist_id}","starred_url":"https://api.github.com/users/NachoSoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NachoSoto/subscriptions","organizations_url":"https://api.github.com/users/NachoSoto/orgs","repos_url":"https://api.github.com/users/NachoSoto/repos","events_url":"https://api.github.com/users/NachoSoto/events{/privacy}","received_events_url":"https://api.github.com/users/NachoSoto/received_events","type":"User","site_admin":false},"repo":{"id":30810172,"name":"ReactiveCocoa","full_name":"NachoSoto/ReactiveCocoa","owner":{"login":"NachoSoto","id":685609,"avatar_url":"https://avatars.githubusercontent.com/u/685609?v=3","gravatar_id":"","url":"https://api.github.com/users/NachoSoto","html_url":"https://github.com/NachoSoto","followers_url":"https://api.github.com/users/NachoSoto/followers","following_url":"https://api.github.com/users/NachoSoto/following{/other_user}","gists_url":"https://api.github.com/users/NachoSoto/gists{/gist_id}","starred_url":"https://api.github.com/users/NachoSoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NachoSoto/subscriptions","organizations_url":"https://api.github.com/users/NachoSoto/orgs","repos_url":"https://api.github.com/users/NachoSoto/repos","events_url":"https://api.github.com/users/NachoSoto/events{/privacy}","received_events_url":"https://api.github.com/users/NachoSoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NachoSoto/ReactiveCocoa","description":"A framework for composing and transforming streams of values","fork":true,"url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa","forks_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/NachoSoto/ReactiveCocoa/releases{/id}","created_at":"2015-02-14T22:03:23Z","updated_at":"2015-02-14T22:03:25Z","pushed_at":"2015-10-08T19:05:36Z","git_url":"git://github.com/NachoSoto/ReactiveCocoa.git","ssh_url":"git@github.com:NachoSoto/ReactiveCocoa.git","clone_url":"https://github.com/NachoSoto/ReactiveCocoa.git","svn_url":"https://github.com/NachoSoto/ReactiveCocoa","homepage":"","size":14472,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveCocoa:swift2","ref":"swift2","sha":"98f5adde278d4eb045515c73f44d15fa543667d4","user":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"repo":{"id":3606624,"name":"ReactiveCocoa","full_name":"ReactiveCocoa/ReactiveCocoa","owner":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","description":"Streams of values over time","fork":false,"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa","forks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/releases{/id}","created_at":"2012-03-02T22:11:24Z","updated_at":"2015-10-08T18:35:03Z","pushed_at":"2015-10-08T19:05:37Z","git_url":"git://github.com/ReactiveCocoa/ReactiveCocoa.git","ssh_url":"git@github.com:ReactiveCocoa/ReactiveCocoa.git","clone_url":"https://github.com/ReactiveCocoa/ReactiveCocoa.git","svn_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","homepage":"","size":29610,"stargazers_count":10531,"watchers_count":10531,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1793,"mirror_url":null,"open_issues_count":188,"forks":1793,"open_issues":188,"watchers":10531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2450"},"issue":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2450"},"comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2450/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2450/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/078846a2a29f6da144d546411f34d95cc9fb0610"}}}}