{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/32067660","id":32067660,"diff_hunk":"@@ -127,6 +127,16 @@ protected function makeInstance(array $attributes = [])\n             }\n \n             $definition = call_user_func($this->definitions[$this->class][$this->name], $this->faker);\n+            \n+            foreach($definition as $key => $attribute)\n+            {\n+                try {\n+                    $class = app($attribute);\n+                    if($class instanceof Model)","path":"src/Illuminate/Database/Eloquent/FactoryBuilder.php","position":9,"original_position":9,"commit_id":"8c7f920de008a4f1f7167dc8927ca0305563bf22","original_commit_id":"8c7f920de008a4f1f7167dc8927ca0305563bf22","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"cs","created_at":"2015-06-09T21:40:44Z","updated_at":"2015-06-09T21:40:44Z","html_url":"https://github.com/laravel/framework/pull/9171#discussion_r32067660","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/9171","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/32067660"},"html":{"href":"https://github.com/laravel/framework/pull/9171#discussion_r32067660"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/9171"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9171","id":37303000,"html_url":"https://github.com/laravel/framework/pull/9171","diff_url":"https://github.com/laravel/framework/pull/9171.diff","patch_url":"https://github.com/laravel/framework/pull/9171.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9171","number":9171,"state":"open","locked":false,"title":"Allow relationships in factory builder","user":{"login":"rweas","id":5386772,"avatar_url":"https://avatars.githubusercontent.com/u/5386772?v=3","gravatar_id":"","url":"https://api.github.com/users/rweas","html_url":"https://github.com/rweas","followers_url":"https://api.github.com/users/rweas/followers","following_url":"https://api.github.com/users/rweas/following{/other_user}","gists_url":"https://api.github.com/users/rweas/gists{/gist_id}","starred_url":"https://api.github.com/users/rweas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rweas/subscriptions","organizations_url":"https://api.github.com/users/rweas/orgs","repos_url":"https://api.github.com/users/rweas/repos","events_url":"https://api.github.com/users/rweas/events{/privacy}","received_events_url":"https://api.github.com/users/rweas/received_events","type":"User","site_admin":false},"body":"(I'm pretty sure I didn't do this perfectly but I hope that someone who is better than me at this gets the idea.) :)\r\nBasically I can put something like this in my FactoryBuilder.php file:\r\n\r\n'user_id' => App\\User::class\r\n\r\nand it will take the id of the user and set it as the attribute. I like this better than 'factory:User' because it will allow me to click through to the User model. If there's any way to make this cleaner or faster just tell me and I'll fix it ASAP! Especially the try catch because I feel like it's kind of hacky. Also comment if you think I should export this to its own function","created_at":"2015-06-09T21:38:06Z","updated_at":"2015-06-09T21:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4596dcbba5436c128ec28421bb79447f317f1b3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9171/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9171/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9171/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/8c7f920de008a4f1f7167dc8927ca0305563bf22","head":{"label":"rweas:patch-2","ref":"patch-2","sha":"8c7f920de008a4f1f7167dc8927ca0305563bf22","user":{"login":"rweas","id":5386772,"avatar_url":"https://avatars.githubusercontent.com/u/5386772?v=3","gravatar_id":"","url":"https://api.github.com/users/rweas","html_url":"https://github.com/rweas","followers_url":"https://api.github.com/users/rweas/followers","following_url":"https://api.github.com/users/rweas/following{/other_user}","gists_url":"https://api.github.com/users/rweas/gists{/gist_id}","starred_url":"https://api.github.com/users/rweas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rweas/subscriptions","organizations_url":"https://api.github.com/users/rweas/orgs","repos_url":"https://api.github.com/users/rweas/repos","events_url":"https://api.github.com/users/rweas/events{/privacy}","received_events_url":"https://api.github.com/users/rweas/received_events","type":"User","site_admin":false},"repo":{"id":34030117,"name":"framework","full_name":"rweas/framework","owner":{"login":"rweas","id":5386772,"avatar_url":"https://avatars.githubusercontent.com/u/5386772?v=3","gravatar_id":"","url":"https://api.github.com/users/rweas","html_url":"https://github.com/rweas","followers_url":"https://api.github.com/users/rweas/followers","following_url":"https://api.github.com/users/rweas/following{/other_user}","gists_url":"https://api.github.com/users/rweas/gists{/gist_id}","starred_url":"https://api.github.com/users/rweas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rweas/subscriptions","organizations_url":"https://api.github.com/users/rweas/orgs","repos_url":"https://api.github.com/users/rweas/repos","events_url":"https://api.github.com/users/rweas/events{/privacy}","received_events_url":"https://api.github.com/users/rweas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rweas/framework","description":"","fork":true,"url":"https://api.github.com/repos/rweas/framework","forks_url":"https://api.github.com/repos/rweas/framework/forks","keys_url":"https://api.github.com/repos/rweas/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rweas/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rweas/framework/teams","hooks_url":"https://api.github.com/repos/rweas/framework/hooks","issue_events_url":"https://api.github.com/repos/rweas/framework/issues/events{/number}","events_url":"https://api.github.com/repos/rweas/framework/events","assignees_url":"https://api.github.com/repos/rweas/framework/assignees{/user}","branches_url":"https://api.github.com/repos/rweas/framework/branches{/branch}","tags_url":"https://api.github.com/repos/rweas/framework/tags","blobs_url":"https://api.github.com/repos/rweas/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rweas/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rweas/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rweas/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rweas/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rweas/framework/languages","stargazers_url":"https://api.github.com/repos/rweas/framework/stargazers","contributors_url":"https://api.github.com/repos/rweas/framework/contributors","subscribers_url":"https://api.github.com/repos/rweas/framework/subscribers","subscription_url":"https://api.github.com/repos/rweas/framework/subscription","commits_url":"https://api.github.com/repos/rweas/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rweas/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rweas/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rweas/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rweas/framework/contents/{+path}","compare_url":"https://api.github.com/repos/rweas/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rweas/framework/merges","archive_url":"https://api.github.com/repos/rweas/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rweas/framework/downloads","issues_url":"https://api.github.com/repos/rweas/framework/issues{/number}","pulls_url":"https://api.github.com/repos/rweas/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rweas/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rweas/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rweas/framework/labels{/name}","releases_url":"https://api.github.com/repos/rweas/framework/releases{/id}","created_at":"2015-04-16T02:33:17Z","updated_at":"2015-04-16T02:33:22Z","pushed_at":"2015-06-09T21:37:45Z","git_url":"git://github.com/rweas/framework.git","ssh_url":"git@github.com:rweas/framework.git","clone_url":"https://github.com/rweas/framework.git","svn_url":"https://github.com/rweas/framework","homepage":"http://laravel.com","size":15264,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"3a44db7e70146dc1282b39887b5faa67c8583015","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-09T15:07:09Z","pushed_at":"2015-06-09T21:38:06Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":61999,"stargazers_count":3692,"watchers_count":3692,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2041,"mirror_url":null,"open_issues_count":66,"forks":2041,"open_issues":66,"watchers":3692,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9171"},"html":{"href":"https://github.com/laravel/framework/pull/9171"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9171"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9171/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9171/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9171/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/8c7f920de008a4f1f7167dc8927ca0305563bf22"}}}}