{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/28622067","id":28622067,"diff_hunk":"@@ -576,14 +576,24 @@ static public function isFileBlacklisted($filename) {\n \n \t/**\n \t * check if the directory should be ignored when scanning\n-\t * NOTE: the special directories . and .. would cause never ending recursion\n+\t * NOTE: the special directories . and .. would cause a never ending recursion\n \t * @param String $dir\n \t * @return boolean\n \t */\n \tstatic public function isIgnoredDir($dir) {\n+\t\t// check for . and ..\n \t\tif ($dir === '.' || $dir === '..') {\n \t\t\treturn true;\n \t\t}\n+\t\t// check for excluded directory\n+\t\t$excluded = \\OC_Config::getValue('excluded_directories', array());","path":"lib/private/files/filesystem.php","position":null,"original_position":15,"commit_id":"4f75f0ea840c07cda42d686f4c772afe4ba042e7","original_commit_id":"70916136fc037d21a612263fefcbe22eeeeed1ab","user":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-04-17T19:12:48Z","updated_at":"2015-04-17T19:12:48Z","html_url":"https://github.com/owncloud/core/pull/15478#discussion_r28622067","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/15478","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/28622067"},"html":{"href":"https://github.com/owncloud/core/pull/15478#discussion_r28622067"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/15478"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/15478","id":32864965,"html_url":"https://github.com/owncloud/core/pull/15478","diff_url":"https://github.com/owncloud/core/pull/15478.diff","patch_url":"https://github.com/owncloud/core/pull/15478.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/15478","number":15478,"state":"open","locked":false,"title":"Functionality: exlcude directories from beeing processed","user":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"body":"PR is related to: https://github.com/owncloud/core/issues/15385 (Exlude particular directories from beeing viewed, accessed and scanned)\r\n\r\nThis PR extends the current functionality of blacklisting for directories.\r\nThe blacklisted directories are not longer presented and scanned by owncloud.\r\n\r\nExamples from (new) config.sample.php\r\nExisting: ``'blacklisted_files' => array('.htaccess'),``\r\nAdded: ``'blacklisted_directories' => array('.snapshot', '~snapshot'),``\r\n\r\nI added ``blacklisted_directories`` to my config.php with the parameters from the config.sample.php, added a SMB share containing many directories having ~snapshot names --> they were excluded from scanning and presentation.\r\n\r\nExtended the test, added another directory to the list (movies root folder from our kamera) and added a second SMB share --> the directory having this name was also excluded.\r\n","created_at":"2015-04-08T14:25:13Z","updated_at":"2015-04-17T19:12:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6524aef035957ba569baeae96d6b9ffe4056c074","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-next","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-next","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":287,"closed_issues":1,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-04-17T16:08:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/15478/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/15478/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/15478/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/4f75f0ea840c07cda42d686f4c772afe4ba042e7","head":{"label":"mmattel:exclude_directories","ref":"exclude_directories","sha":"4f75f0ea840c07cda42d686f4c772afe4ba042e7","user":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"repo":{"id":28487280,"name":"core","full_name":"mmattel/core","owner":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmattel/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/mmattel/core","forks_url":"https://api.github.com/repos/mmattel/core/forks","keys_url":"https://api.github.com/repos/mmattel/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmattel/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmattel/core/teams","hooks_url":"https://api.github.com/repos/mmattel/core/hooks","issue_events_url":"https://api.github.com/repos/mmattel/core/issues/events{/number}","events_url":"https://api.github.com/repos/mmattel/core/events","assignees_url":"https://api.github.com/repos/mmattel/core/assignees{/user}","branches_url":"https://api.github.com/repos/mmattel/core/branches{/branch}","tags_url":"https://api.github.com/repos/mmattel/core/tags","blobs_url":"https://api.github.com/repos/mmattel/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmattel/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmattel/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmattel/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmattel/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mmattel/core/languages","stargazers_url":"https://api.github.com/repos/mmattel/core/stargazers","contributors_url":"https://api.github.com/repos/mmattel/core/contributors","subscribers_url":"https://api.github.com/repos/mmattel/core/subscribers","subscription_url":"https://api.github.com/repos/mmattel/core/subscription","commits_url":"https://api.github.com/repos/mmattel/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmattel/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmattel/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmattel/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmattel/core/contents/{+path}","compare_url":"https://api.github.com/repos/mmattel/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmattel/core/merges","archive_url":"https://api.github.com/repos/mmattel/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmattel/core/downloads","issues_url":"https://api.github.com/repos/mmattel/core/issues{/number}","pulls_url":"https://api.github.com/repos/mmattel/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mmattel/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mmattel/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmattel/core/labels{/name}","releases_url":"https://api.github.com/repos/mmattel/core/releases{/id}","created_at":"2014-12-25T17:27:50Z","updated_at":"2015-04-17T16:47:27Z","pushed_at":"2015-04-17T19:12:11Z","git_url":"git://github.com/mmattel/core.git","ssh_url":"git@github.com:mmattel/core.git","clone_url":"https://github.com/mmattel/core.git","svn_url":"https://github.com/mmattel/core","homepage":null,"size":186290,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"ae681f0061f534b48b45cf9a41f6110c0ff20b1d","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-04-17T16:02:23Z","pushed_at":"2015-04-17T19:12:16Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":1008837,"stargazers_count":3238,"watchers_count":3238,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1037,"mirror_url":null,"open_issues_count":1708,"forks":1037,"open_issues":1708,"watchers":3238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/15478"},"html":{"href":"https://github.com/owncloud/core/pull/15478"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/15478"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/15478/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/15478/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/15478/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/4f75f0ea840c07cda42d686f4c772afe4ba042e7"}}}}