{"action":"created","comment":{"url":"https://api.github.com/repos/SFTtech/openage/pulls/comments/26701058","id":26701058,"diff_hunk":"@@ -0,0 +1,37 @@\n+// Copyright 2015-2015 the openage authors. See copying.md for legal info.\n+\n+#ifndef OPENAGE_PLAYER_H_\n+#define OPENAGE_PLAYER_H_\n+\n+#include <string>\n+#include <unordered_map>\n+\n+#include \"unit/resource.h\"\n+\n+namespace openage {\n+\n+class Player {\n+public:\n+\tPlayer(unsigned int number);\n+\n+\tconst unsigned int player_number; \n+\n+\t/**\n+\t * would be better to have rgb color value\n+\t */\n+\tconst unsigned int color;","path":"cpp/player.h","position":22,"original_position":22,"commit_id":"182c3a5ff144295a5ae74a7ca2f8bea08d3a7c68","original_commit_id":"182c3a5ff144295a5ae74a7ca2f8bea08d3a7c68","user":{"login":"TheJJ","id":673543,"avatar_url":"https://avatars.githubusercontent.com/u/673543?v=3","gravatar_id":"","url":"https://api.github.com/users/TheJJ","html_url":"https://github.com/TheJJ","followers_url":"https://api.github.com/users/TheJJ/followers","following_url":"https://api.github.com/users/TheJJ/following{/other_user}","gists_url":"https://api.github.com/users/TheJJ/gists{/gist_id}","starred_url":"https://api.github.com/users/TheJJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheJJ/subscriptions","organizations_url":"https://api.github.com/users/TheJJ/orgs","repos_url":"https://api.github.com/users/TheJJ/repos","events_url":"https://api.github.com/users/TheJJ/events{/privacy}","received_events_url":"https://api.github.com/users/TheJJ/received_events","type":"User","site_admin":false},"body":"i planned to support rgb-teamcolors, but our recoloring shader has to be much more sophisticated for that.","created_at":"2015-03-18T19:59:50Z","updated_at":"2015-03-18T19:59:50Z","html_url":"https://github.com/SFTtech/openage/pull/172#discussion_r26701058","pull_request_url":"https://api.github.com/repos/SFTtech/openage/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/comments/26701058"},"html":{"href":"https://github.com/SFTtech/openage/pull/172#discussion_r26701058"},"pull_request":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/SFTtech/openage/pulls/172","id":24988409,"html_url":"https://github.com/SFTtech/openage/pull/172","diff_url":"https://github.com/SFTtech/openage/pull/172.diff","patch_url":"https://github.com/SFTtech/openage/pull/172.patch","issue_url":"https://api.github.com/repos/SFTtech/openage/issues/172","number":172,"state":"open","locked":false,"title":"Shots fired & Delta Graphics","user":{"login":"Jon0","id":3847361,"avatar_url":"https://avatars.githubusercontent.com/u/3847361?v=3","gravatar_id":"","url":"https://api.github.com/users/Jon0","html_url":"https://github.com/Jon0","followers_url":"https://api.github.com/users/Jon0/followers","following_url":"https://api.github.com/users/Jon0/following{/other_user}","gists_url":"https://api.github.com/users/Jon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Jon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jon0/subscriptions","organizations_url":"https://api.github.com/users/Jon0/orgs","repos_url":"https://api.github.com/users/Jon0/repos","events_url":"https://api.github.com/users/Jon0/events{/privacy}","received_events_url":"https://api.github.com/users/Jon0/received_events","type":"User","site_admin":false},"body":"Game Functions:\r\n* Projectiles use game data for range and arc shape\r\n* Any building can be used as a dropsite\r\n* Resource objects can be gathered from\r\n* F5/F9 quick save and load functions\r\n\r\nGraphics:\r\n* UnitTexture class handles delta graphics\r\n* Delta graphics can be animated and directional (ships)\r\n* TerrainObjects handle building annexes using child/parent spaces\r\n* Switch between villager graphics depending on which resource is gathered\r\n\r\nUser Interface:\r\n* Selection of units by boxing\r\n* Display of units hitpoints\r\n\r\nNotes:\r\nrequires assets to be reconverted.\r\n\r\ncurrently unsure how about the \"projectile_arc\" parameter from exported data should be used\r\nfor scorpions, projectile_arc = 0\r\nfor onagers, projectile_arc = 0.4\r\nfor regular archers, projectile_arc = -0.06\r\n\r\n","created_at":"2014-11-25T07:01:15Z","updated_at":"2015-03-18T19:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fa7cd5b71618872036c8305c9b913bec2bd8840","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SFTtech/openage/pulls/172/commits","review_comments_url":"https://api.github.com/repos/SFTtech/openage/pulls/172/comments","review_comment_url":"https://api.github.com/repos/SFTtech/openage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SFTtech/openage/issues/172/comments","statuses_url":"https://api.github.com/repos/SFTtech/openage/statuses/182c3a5ff144295a5ae74a7ca2f8bea08d3a7c68","head":{"label":"Jon0:arrows_fired","ref":"arrows_fired","sha":"182c3a5ff144295a5ae74a7ca2f8bea08d3a7c68","user":{"login":"Jon0","id":3847361,"avatar_url":"https://avatars.githubusercontent.com/u/3847361?v=3","gravatar_id":"","url":"https://api.github.com/users/Jon0","html_url":"https://github.com/Jon0","followers_url":"https://api.github.com/users/Jon0/followers","following_url":"https://api.github.com/users/Jon0/following{/other_user}","gists_url":"https://api.github.com/users/Jon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Jon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jon0/subscriptions","organizations_url":"https://api.github.com/users/Jon0/orgs","repos_url":"https://api.github.com/users/Jon0/repos","events_url":"https://api.github.com/users/Jon0/events{/privacy}","received_events_url":"https://api.github.com/users/Jon0/received_events","type":"User","site_admin":false},"repo":{"id":25803186,"name":"openage","full_name":"Jon0/openage","owner":{"login":"Jon0","id":3847361,"avatar_url":"https://avatars.githubusercontent.com/u/3847361?v=3","gravatar_id":"","url":"https://api.github.com/users/Jon0","html_url":"https://github.com/Jon0","followers_url":"https://api.github.com/users/Jon0/followers","following_url":"https://api.github.com/users/Jon0/following{/other_user}","gists_url":"https://api.github.com/users/Jon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Jon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jon0/subscriptions","organizations_url":"https://api.github.com/users/Jon0/orgs","repos_url":"https://api.github.com/users/Jon0/repos","events_url":"https://api.github.com/users/Jon0/events{/privacy}","received_events_url":"https://api.github.com/users/Jon0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jon0/openage","description":"Free (as in freedom) open source clone of the Age of Empires II engine.","fork":true,"url":"https://api.github.com/repos/Jon0/openage","forks_url":"https://api.github.com/repos/Jon0/openage/forks","keys_url":"https://api.github.com/repos/Jon0/openage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jon0/openage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jon0/openage/teams","hooks_url":"https://api.github.com/repos/Jon0/openage/hooks","issue_events_url":"https://api.github.com/repos/Jon0/openage/issues/events{/number}","events_url":"https://api.github.com/repos/Jon0/openage/events","assignees_url":"https://api.github.com/repos/Jon0/openage/assignees{/user}","branches_url":"https://api.github.com/repos/Jon0/openage/branches{/branch}","tags_url":"https://api.github.com/repos/Jon0/openage/tags","blobs_url":"https://api.github.com/repos/Jon0/openage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jon0/openage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jon0/openage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jon0/openage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jon0/openage/statuses/{sha}","languages_url":"https://api.github.com/repos/Jon0/openage/languages","stargazers_url":"https://api.github.com/repos/Jon0/openage/stargazers","contributors_url":"https://api.github.com/repos/Jon0/openage/contributors","subscribers_url":"https://api.github.com/repos/Jon0/openage/subscribers","subscription_url":"https://api.github.com/repos/Jon0/openage/subscription","commits_url":"https://api.github.com/repos/Jon0/openage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jon0/openage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jon0/openage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jon0/openage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jon0/openage/contents/{+path}","compare_url":"https://api.github.com/repos/Jon0/openage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jon0/openage/merges","archive_url":"https://api.github.com/repos/Jon0/openage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jon0/openage/downloads","issues_url":"https://api.github.com/repos/Jon0/openage/issues{/number}","pulls_url":"https://api.github.com/repos/Jon0/openage/pulls{/number}","milestones_url":"https://api.github.com/repos/Jon0/openage/milestones{/number}","notifications_url":"https://api.github.com/repos/Jon0/openage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jon0/openage/labels{/name}","releases_url":"https://api.github.com/repos/Jon0/openage/releases{/id}","created_at":"2014-10-27T04:28:20Z","updated_at":"2015-02-14T03:35:48Z","pushed_at":"2015-03-14T08:31:56Z","git_url":"git://github.com/Jon0/openage.git","ssh_url":"git@github.com:Jon0/openage.git","clone_url":"https://github.com/Jon0/openage.git","svn_url":"https://github.com/Jon0/openage","homepage":"http://openage.sft.mx","size":4922,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"SFTtech:master","ref":"master","sha":"f8e2cee870258e21455682820b72842f0a00217b","user":{"login":"SFTtech","id":1783325,"avatar_url":"https://avatars.githubusercontent.com/u/1783325?v=3","gravatar_id":"","url":"https://api.github.com/users/SFTtech","html_url":"https://github.com/SFTtech","followers_url":"https://api.github.com/users/SFTtech/followers","following_url":"https://api.github.com/users/SFTtech/following{/other_user}","gists_url":"https://api.github.com/users/SFTtech/gists{/gist_id}","starred_url":"https://api.github.com/users/SFTtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SFTtech/subscriptions","organizations_url":"https://api.github.com/users/SFTtech/orgs","repos_url":"https://api.github.com/users/SFTtech/repos","events_url":"https://api.github.com/users/SFTtech/events{/privacy}","received_events_url":"https://api.github.com/users/SFTtech/received_events","type":"Organization","site_admin":false},"repo":{"id":14095175,"name":"openage","full_name":"SFTtech/openage","owner":{"login":"SFTtech","id":1783325,"avatar_url":"https://avatars.githubusercontent.com/u/1783325?v=3","gravatar_id":"","url":"https://api.github.com/users/SFTtech","html_url":"https://github.com/SFTtech","followers_url":"https://api.github.com/users/SFTtech/followers","following_url":"https://api.github.com/users/SFTtech/following{/other_user}","gists_url":"https://api.github.com/users/SFTtech/gists{/gist_id}","starred_url":"https://api.github.com/users/SFTtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SFTtech/subscriptions","organizations_url":"https://api.github.com/users/SFTtech/orgs","repos_url":"https://api.github.com/users/SFTtech/repos","events_url":"https://api.github.com/users/SFTtech/events{/privacy}","received_events_url":"https://api.github.com/users/SFTtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SFTtech/openage","description":"Free (as in freedom) open source clone of the Age of Empires II engine.","fork":false,"url":"https://api.github.com/repos/SFTtech/openage","forks_url":"https://api.github.com/repos/SFTtech/openage/forks","keys_url":"https://api.github.com/repos/SFTtech/openage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SFTtech/openage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SFTtech/openage/teams","hooks_url":"https://api.github.com/repos/SFTtech/openage/hooks","issue_events_url":"https://api.github.com/repos/SFTtech/openage/issues/events{/number}","events_url":"https://api.github.com/repos/SFTtech/openage/events","assignees_url":"https://api.github.com/repos/SFTtech/openage/assignees{/user}","branches_url":"https://api.github.com/repos/SFTtech/openage/branches{/branch}","tags_url":"https://api.github.com/repos/SFTtech/openage/tags","blobs_url":"https://api.github.com/repos/SFTtech/openage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SFTtech/openage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SFTtech/openage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SFTtech/openage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SFTtech/openage/statuses/{sha}","languages_url":"https://api.github.com/repos/SFTtech/openage/languages","stargazers_url":"https://api.github.com/repos/SFTtech/openage/stargazers","contributors_url":"https://api.github.com/repos/SFTtech/openage/contributors","subscribers_url":"https://api.github.com/repos/SFTtech/openage/subscribers","subscription_url":"https://api.github.com/repos/SFTtech/openage/subscription","commits_url":"https://api.github.com/repos/SFTtech/openage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SFTtech/openage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SFTtech/openage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SFTtech/openage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SFTtech/openage/contents/{+path}","compare_url":"https://api.github.com/repos/SFTtech/openage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SFTtech/openage/merges","archive_url":"https://api.github.com/repos/SFTtech/openage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SFTtech/openage/downloads","issues_url":"https://api.github.com/repos/SFTtech/openage/issues{/number}","pulls_url":"https://api.github.com/repos/SFTtech/openage/pulls{/number}","milestones_url":"https://api.github.com/repos/SFTtech/openage/milestones{/number}","notifications_url":"https://api.github.com/repos/SFTtech/openage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SFTtech/openage/labels{/name}","releases_url":"https://api.github.com/repos/SFTtech/openage/releases{/id}","created_at":"2013-11-03T22:35:23Z","updated_at":"2015-03-17T14:53:07Z","pushed_at":"2015-03-16T20:55:22Z","git_url":"git://github.com/SFTtech/openage.git","ssh_url":"git@github.com:SFTtech/openage.git","clone_url":"https://github.com/SFTtech/openage.git","svn_url":"https://github.com/SFTtech/openage","homepage":"http://openage.sft.mx","size":7462,"stargazers_count":2915,"watchers_count":2915,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":70,"forks":250,"open_issues":70,"watchers":2915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/172"},"html":{"href":"https://github.com/SFTtech/openage/pull/172"},"issue":{"href":"https://api.github.com/repos/SFTtech/openage/issues/172"},"comments":{"href":"https://api.github.com/repos/SFTtech/openage/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/SFTtech/openage/statuses/182c3a5ff144295a5ae74a7ca2f8bea08d3a7c68"}}}}