{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments/41779810","id":41779810,"diff_hunk":"@@ -29,9 +30,9 @@\n \n (defn- make-client-common\n   [^String host opts]\n-  (let [opts (assoc opts :as :stream)","path":"src/clj_puppetdb/http.clj","position":14,"original_position":14,"commit_id":"1eb69e471ab80fd9f387f49dbf6ba47f4fa3e4aa","original_commit_id":"1eb69e471ab80fd9f387f49dbf6ba47f4fa3e4aa","user":{"login":"dmcpl","id":10402774,"avatar_url":"https://avatars.githubusercontent.com/u/10402774?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcpl","html_url":"https://github.com/dmcpl","followers_url":"https://api.github.com/users/dmcpl/followers","following_url":"https://api.github.com/users/dmcpl/following{/other_user}","gists_url":"https://api.github.com/users/dmcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcpl/subscriptions","organizations_url":"https://api.github.com/users/dmcpl/orgs","repos_url":"https://api.github.com/users/dmcpl/repos","events_url":"https://api.github.com/users/dmcpl/events{/privacy}","received_events_url":"https://api.github.com/users/dmcpl/received_events","type":"User","site_admin":false},"body":"I think the idea is that we now pass this down explicitly from the middleware like so: https://github.com/scottyw/pe-console-middleware/blob/8415e399f48fd7d4064c941dca05ac2035d07cf7/src/puppetlabs/pe_console_middleware/cm/pdb.clj#L22","created_at":"2015-10-12T17:25:41Z","updated_at":"2015-10-12T17:25:41Z","html_url":"https://github.com/puppetlabs/clj-puppetdb/pull/20#discussion_r41779810","pull_request_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments/41779810"},"html":{"href":"https://github.com/puppetlabs/clj-puppetdb/pull/20#discussion_r41779810"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20","id":47373881,"html_url":"https://github.com/puppetlabs/clj-puppetdb/pull/20","diff_url":"https://github.com/puppetlabs/clj-puppetdb/pull/20.diff","patch_url":"https://github.com/puppetlabs/clj-puppetdb/pull/20.patch","issue_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/20","number":20,"state":"open","locked":false,"title":"(PE-10513) Picking up unbuffered HTTP streaming in CM","user":{"login":"dmcpl","id":10402774,"avatar_url":"https://avatars.githubusercontent.com/u/10402774?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcpl","html_url":"https://github.com/dmcpl","followers_url":"https://api.github.com/users/dmcpl/followers","following_url":"https://api.github.com/users/dmcpl/following{/other_user}","gists_url":"https://api.github.com/users/dmcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcpl/subscriptions","organizations_url":"https://api.github.com/users/dmcpl/orgs","repos_url":"https://api.github.com/users/dmcpl/repos","events_url":"https://api.github.com/users/dmcpl/events{/privacy}","received_events_url":"https://api.github.com/users/dmcpl/received_events","type":"User","site_admin":false},"body":"Waiting for https://github.com/puppetlabs/clj-http-client/pull/42 to merge before this can go in. This change merely activates unbuffered streaming in clj-http-client. **Note: this will need an up-version in the project file for puppetlabs/http-client.**","created_at":"2015-10-11T19:44:19Z","updated_at":"2015-10-12T17:25:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8ab11c8af43c92dc1c0ce0627614bef45d98a4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/20/comments","statuses_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/statuses/1eb69e471ab80fd9f387f49dbf6ba47f4fa3e4aa","head":{"label":"dmcpl:unbuffered-streaming","ref":"unbuffered-streaming","sha":"1eb69e471ab80fd9f387f49dbf6ba47f4fa3e4aa","user":{"login":"dmcpl","id":10402774,"avatar_url":"https://avatars.githubusercontent.com/u/10402774?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcpl","html_url":"https://github.com/dmcpl","followers_url":"https://api.github.com/users/dmcpl/followers","following_url":"https://api.github.com/users/dmcpl/following{/other_user}","gists_url":"https://api.github.com/users/dmcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcpl/subscriptions","organizations_url":"https://api.github.com/users/dmcpl/orgs","repos_url":"https://api.github.com/users/dmcpl/repos","events_url":"https://api.github.com/users/dmcpl/events{/privacy}","received_events_url":"https://api.github.com/users/dmcpl/received_events","type":"User","site_admin":false},"repo":{"id":33526805,"name":"clj-puppetdb","full_name":"dmcpl/clj-puppetdb","owner":{"login":"dmcpl","id":10402774,"avatar_url":"https://avatars.githubusercontent.com/u/10402774?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcpl","html_url":"https://github.com/dmcpl","followers_url":"https://api.github.com/users/dmcpl/followers","following_url":"https://api.github.com/users/dmcpl/following{/other_user}","gists_url":"https://api.github.com/users/dmcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcpl/subscriptions","organizations_url":"https://api.github.com/users/dmcpl/orgs","repos_url":"https://api.github.com/users/dmcpl/repos","events_url":"https://api.github.com/users/dmcpl/events{/privacy}","received_events_url":"https://api.github.com/users/dmcpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmcpl/clj-puppetdb","description":"A Clojure library for querying the PuppetDB REST API","fork":true,"url":"https://api.github.com/repos/dmcpl/clj-puppetdb","forks_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/forks","keys_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/teams","hooks_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/events","assignees_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/tags","blobs_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/languages","stargazers_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/subscription","commits_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/merges","archive_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/downloads","issues_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/dmcpl/clj-puppetdb/releases{/id}","created_at":"2015-04-07T06:44:52Z","updated_at":"2015-04-20T15:41:59Z","pushed_at":"2015-10-12T15:02:29Z","git_url":"git://github.com/dmcpl/clj-puppetdb.git","ssh_url":"git@github.com:dmcpl/clj-puppetdb.git","clone_url":"https://github.com/dmcpl/clj-puppetdb.git","svn_url":"https://github.com/dmcpl/clj-puppetdb","homepage":"","size":216,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"88ae735c999ccd3411c078c8db36cc0a5990dbe2","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":30195532,"name":"clj-puppetdb","full_name":"puppetlabs/clj-puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/clj-puppetdb","description":"A Clojure library for querying the PuppetDB REST API","fork":true,"url":"https://api.github.com/repos/puppetlabs/clj-puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/releases{/id}","created_at":"2015-02-02T16:13:19Z","updated_at":"2015-04-15T15:33:35Z","pushed_at":"2015-10-12T15:02:29Z","git_url":"git://github.com/puppetlabs/clj-puppetdb.git","ssh_url":"git@github.com:puppetlabs/clj-puppetdb.git","clone_url":"https://github.com/puppetlabs/clj-puppetdb.git","svn_url":"https://github.com/puppetlabs/clj-puppetdb","homepage":"","size":337,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20"},"html":{"href":"https://github.com/puppetlabs/clj-puppetdb/pull/20"},"issue":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/20"},"comments":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/statuses/1eb69e471ab80fd9f387f49dbf6ba47f4fa3e4aa"}}}}