{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/29102033","id":29102033,"diff_hunk":"@@ -686,7 +686,7 @@ public function setAlias($alias, $id)\n             throw new InvalidArgumentException('$id must be a string, or an Alias object.');\n         }\n \n-        if ($alias === strtolower($id)) {\n+        if ($alias === $id) {","path":"src/Symfony/Component/DependencyInjection/ContainerBuilder.php","position":5,"original_position":5,"commit_id":"0d7f612d692520560dbc303e2471738acfb5b637","original_commit_id":"0d7f612d692520560dbc303e2471738acfb5b637","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"body":"this seems wrong: string === Alias can never be true","created_at":"2015-04-25T16:55:13Z","updated_at":"2015-04-25T16:55:13Z","html_url":"https://github.com/symfony/symfony/pull/14470#discussion_r29102033","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/14470","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/29102033"},"html":{"href":"https://github.com/symfony/symfony/pull/14470#discussion_r29102033"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14470"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/14470","id":34109053,"html_url":"https://github.com/symfony/symfony/pull/14470","diff_url":"https://github.com/symfony/symfony/pull/14470.diff","patch_url":"https://github.com/symfony/symfony/pull/14470.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/14470","number":14470,"state":"open","locked":false,"title":"[DependencyInjection] Removed extra strtolower calls","user":{"login":"dosten","id":510842,"avatar_url":"https://avatars.githubusercontent.com/u/510842?v=3","gravatar_id":"","url":"https://api.github.com/users/dosten","html_url":"https://github.com/dosten","followers_url":"https://api.github.com/users/dosten/followers","following_url":"https://api.github.com/users/dosten/following{/other_user}","gists_url":"https://api.github.com/users/dosten/gists{/gist_id}","starred_url":"https://api.github.com/users/dosten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosten/subscriptions","organizations_url":"https://api.github.com/users/dosten/orgs","repos_url":"https://api.github.com/users/dosten/repos","events_url":"https://api.github.com/users/dosten/events{/privacy}","received_events_url":"https://api.github.com/users/dosten/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\n`Alias` already lowercase the `$id` in the constructor. Using `ContainerBuilder::hasAlias()` and `ContainerBuilder::hasDefinition()` inside the code makes an extra strtolower call.","created_at":"2015-04-25T16:44:50Z","updated_at":"2015-04-25T16:55:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"275baed20ad0cdbdf7c64cb57995d286428e4f80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/14470/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/14470/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/14470/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/0d7f612d692520560dbc303e2471738acfb5b637","head":{"label":"dosten:extra-strtolower","ref":"extra-strtolower","sha":"0d7f612d692520560dbc303e2471738acfb5b637","user":{"login":"dosten","id":510842,"avatar_url":"https://avatars.githubusercontent.com/u/510842?v=3","gravatar_id":"","url":"https://api.github.com/users/dosten","html_url":"https://github.com/dosten","followers_url":"https://api.github.com/users/dosten/followers","following_url":"https://api.github.com/users/dosten/following{/other_user}","gists_url":"https://api.github.com/users/dosten/gists{/gist_id}","starred_url":"https://api.github.com/users/dosten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosten/subscriptions","organizations_url":"https://api.github.com/users/dosten/orgs","repos_url":"https://api.github.com/users/dosten/repos","events_url":"https://api.github.com/users/dosten/events{/privacy}","received_events_url":"https://api.github.com/users/dosten/received_events","type":"User","site_admin":false},"repo":{"id":21166471,"name":"symfony","full_name":"dosten/symfony","owner":{"login":"dosten","id":510842,"avatar_url":"https://avatars.githubusercontent.com/u/510842?v=3","gravatar_id":"","url":"https://api.github.com/users/dosten","html_url":"https://github.com/dosten","followers_url":"https://api.github.com/users/dosten/followers","following_url":"https://api.github.com/users/dosten/following{/other_user}","gists_url":"https://api.github.com/users/dosten/gists{/gist_id}","starred_url":"https://api.github.com/users/dosten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosten/subscriptions","organizations_url":"https://api.github.com/users/dosten/orgs","repos_url":"https://api.github.com/users/dosten/repos","events_url":"https://api.github.com/users/dosten/events{/privacy}","received_events_url":"https://api.github.com/users/dosten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dosten/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/dosten/symfony","forks_url":"https://api.github.com/repos/dosten/symfony/forks","keys_url":"https://api.github.com/repos/dosten/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dosten/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dosten/symfony/teams","hooks_url":"https://api.github.com/repos/dosten/symfony/hooks","issue_events_url":"https://api.github.com/repos/dosten/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/dosten/symfony/events","assignees_url":"https://api.github.com/repos/dosten/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/dosten/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/dosten/symfony/tags","blobs_url":"https://api.github.com/repos/dosten/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dosten/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dosten/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/dosten/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dosten/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/dosten/symfony/languages","stargazers_url":"https://api.github.com/repos/dosten/symfony/stargazers","contributors_url":"https://api.github.com/repos/dosten/symfony/contributors","subscribers_url":"https://api.github.com/repos/dosten/symfony/subscribers","subscription_url":"https://api.github.com/repos/dosten/symfony/subscription","commits_url":"https://api.github.com/repos/dosten/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/dosten/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/dosten/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/dosten/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/dosten/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/dosten/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dosten/symfony/merges","archive_url":"https://api.github.com/repos/dosten/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dosten/symfony/downloads","issues_url":"https://api.github.com/repos/dosten/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/dosten/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/dosten/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/dosten/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dosten/symfony/labels{/name}","releases_url":"https://api.github.com/repos/dosten/symfony/releases{/id}","created_at":"2014-06-24T13:55:23Z","updated_at":"2015-04-25T16:51:14Z","pushed_at":"2015-04-25T16:51:13Z","git_url":"git://github.com/dosten/symfony.git","ssh_url":"git@github.com:dosten/symfony.git","clone_url":"https://github.com/dosten/symfony.git","svn_url":"https://github.com/dosten/symfony","homepage":"symfony.com","size":56198,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.7"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"520660302a0fc7e7c74ca897a667702d8fa782ff","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-04-25T12:17:37Z","pushed_at":"2015-04-25T16:44:51Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":223261,"stargazers_count":10090,"watchers_count":10090,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3969,"mirror_url":null,"open_issues_count":827,"forks":3969,"open_issues":827,"watchers":10090,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14470"},"html":{"href":"https://github.com/symfony/symfony/pull/14470"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/14470"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/14470/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14470/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14470/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/0d7f612d692520560dbc303e2471738acfb5b637"}}}}