{"action":"created","issue":{"url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/issues/15","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/issues/15/comments","events_url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/issues/15/events","html_url":"https://github.com/Harvard-University-iCommons/django-auth-lti/pull/15","id":71637991,"number":15,"title":"example commit to show use of proposed ims_lti_py changes","user":{"login":"lbjay","id":76242,"avatar_url":"https://avatars.githubusercontent.com/u/76242?v=3","gravatar_id":"","url":"https://api.github.com/users/lbjay","html_url":"https://github.com/lbjay","followers_url":"https://api.github.com/users/lbjay/followers","following_url":"https://api.github.com/users/lbjay/following{/other_user}","gists_url":"https://api.github.com/users/lbjay/gists{/gist_id}","starred_url":"https://api.github.com/users/lbjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbjay/subscriptions","organizations_url":"https://api.github.com/users/lbjay/orgs","repos_url":"https://api.github.com/users/lbjay/repos","events_url":"https://api.github.com/users/lbjay/events{/privacy}","received_events_url":"https://api.github.com/users/lbjay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-28T16:29:31Z","updated_at":"2015-05-06T12:40:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/pulls/15","html_url":"https://github.com/Harvard-University-iCommons/django-auth-lti/pull/15","diff_url":"https://github.com/Harvard-University-iCommons/django-auth-lti/pull/15.diff","patch_url":"https://github.com/Harvard-University-iCommons/django-auth-lti/pull/15.patch"},"body":"I've recently done a major reworking of the ims_lti_py library and submitted a pull request here: https://github.com/tophatmonocle/ims_lti_py/pull/20. I tried to preserve the public api of the module as much as possible, but there's mucho structural changes under the hood, as well as a rewrite of at least 60% of the test suite. I've also created an github issue asking WTF is the status of the project: https://github.com/tophatmonocle/ims_lti_py/issues/19\r\n\r\nThis is a quick PR to show how django-auth-lti would need to be adapted to make use of the updated ims_lti_py. Just looking for comments/feedback on both PRs at the moment. I'm using django-auth-lti in a grand total of one LTI tool, so my use cases and experience are pretty limited.\r\n\r\nThe major change to django-auth-lti is that the tool provider's `is_valid_reqeust()` method now requires an instance of an oauthlib.oauth1 RequestValidator. I implemented something simple in `validator.py`, but it could be done in other ways. (For instance, the LTIAuthBackend could subclass RequestValidator and pass itself in.)\r\n\r\ncc: @rascalking @douglashall @djcp @elliottyates @cmurtaugh @bermudezjd \r\n"},"comment":{"url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/issues/comments/99434362","html_url":"https://github.com/Harvard-University-iCommons/django-auth-lti/pull/15#issuecomment-99434362","issue_url":"https://api.github.com/repos/Harvard-University-iCommons/django-auth-lti/issues/15","id":99434362,"user":{"login":"lbjay","id":76242,"avatar_url":"https://avatars.githubusercontent.com/u/76242?v=3","gravatar_id":"","url":"https://api.github.com/users/lbjay","html_url":"https://github.com/lbjay","followers_url":"https://api.github.com/users/lbjay/followers","following_url":"https://api.github.com/users/lbjay/following{/other_user}","gists_url":"https://api.github.com/users/lbjay/gists{/gist_id}","starred_url":"https://api.github.com/users/lbjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbjay/subscriptions","organizations_url":"https://api.github.com/users/lbjay/orgs","repos_url":"https://api.github.com/users/lbjay/repos","events_url":"https://api.github.com/users/lbjay/events{/privacy}","received_events_url":"https://api.github.com/users/lbjay/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T12:40:23Z","updated_at":"2015-05-06T12:40:23Z","body":"Update: at some point in the (hopefully) near future I'll clean this up, add tests and do a formal pull requests. In the meantime, feedback still welcome. The additional requirement of needing a request validator class is not a minor thing, so I anticipate a slow process of acceptance/merge from your end.\r\n\r\nThe app I'm currently working on is making use of the branch from our [harvard-dce fork](https://github.com/harvard-dce/django-auth-lti/tree/ims-lti-py-oauthlib) for the time being. For the curious, I've got a request validator class that uses redis for nonce checking at https://github.com/harvard-dce/dce_course_admin/blob/lti-auth-improvements/course_admin/validator.py"}}