{"action":"created","issue":{"url":"https://api.github.com/repos/oalders/http-browserdetect/issues/95","labels_url":"https://api.github.com/repos/oalders/http-browserdetect/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/oalders/http-browserdetect/issues/95/comments","events_url":"https://api.github.com/repos/oalders/http-browserdetect/issues/95/events","html_url":"https://github.com/oalders/http-browserdetect/pull/95","id":58257251,"number":95,"title":"Make things faster, also fix issue #85","user":{"login":"andrewmoise","id":8404538,"avatar_url":"https://avatars.githubusercontent.com/u/8404538?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewmoise","html_url":"https://github.com/andrewmoise","followers_url":"https://api.github.com/users/andrewmoise/followers","following_url":"https://api.github.com/users/andrewmoise/following{/other_user}","gists_url":"https://api.github.com/users/andrewmoise/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmoise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmoise/subscriptions","organizations_url":"https://api.github.com/users/andrewmoise/orgs","repos_url":"https://api.github.com/users/andrewmoise/repos","events_url":"https://api.github.com/users/andrewmoise/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmoise/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-02-19T19:35:38Z","updated_at":"2015-02-24T14:59:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oalders/http-browserdetect/pulls/95","html_url":"https://github.com/oalders/http-browserdetect/pull/95","diff_url":"https://github.com/oalders/http-browserdetect/pull/95.diff","patch_url":"https://github.com/oalders/http-browserdetect/pull/95.patch"},"body":"I'm working on a log file analyzer, and when running on a decent-size log file it takes 5 minutes to parse the log, of which 1 minute is spent in HTTP::BrowserDetect. That's too much :-). I spent some time making the obvious speedups I could see; they're described in more detail in the commits, but it reduced the 60 seconds it was spending on browser detection down to 30 seconds.\r\n\r\nThese are pretty extensive changes, so I wouldn't expect you to merge them immediately and without question, but I actually think they're good changes. In addition to making things faster, they make things more straightforward. We used to run the OS and robot tests, then the browser tests, then the OS and robot tests *again*, with a tiny number of them having different results based on the browser tests, and I think sometimes even a test would be set to 1 and then set to 0 later on because a special case was detected. Some of that is removed now, and some is highlighted where it takes place even if it's still around. We only run the OS and robot tests once.\r\n\r\nAlso, I finally fixed issue #85, which is great for me because I get to stop looking at the warnings, and I added a test appropriate to that case.\r\n\r\nThanks in advance, again let me know anything I should be doing different (or anything I did wrong) as I'm not too familiar with git/github."},"comment":{"url":"https://api.github.com/repos/oalders/http-browserdetect/issues/comments/75771548","html_url":"https://github.com/oalders/http-browserdetect/pull/95#issuecomment-75771548","issue_url":"https://api.github.com/repos/oalders/http-browserdetect/issues/95","id":75771548,"user":{"login":"oalders","id":96205,"avatar_url":"https://avatars.githubusercontent.com/u/96205?v=3","gravatar_id":"","url":"https://api.github.com/users/oalders","html_url":"https://github.com/oalders","followers_url":"https://api.github.com/users/oalders/followers","following_url":"https://api.github.com/users/oalders/following{/other_user}","gists_url":"https://api.github.com/users/oalders/gists{/gist_id}","starred_url":"https://api.github.com/users/oalders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oalders/subscriptions","organizations_url":"https://api.github.com/users/oalders/orgs","repos_url":"https://api.github.com/users/oalders/repos","events_url":"https://api.github.com/users/oalders/events{/privacy}","received_events_url":"https://api.github.com/users/oalders/received_events","type":"User","site_admin":false},"created_at":"2015-02-24T14:59:10Z","updated_at":"2015-02-24T14:59:10Z","body":"Ah, I had a closer look at the tests and I see what you're saying.  Personally, I'm not at all interested in bugwards compatibility.  "}}