{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3144","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3144/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3144/comments","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3144/events","html_url":"https://github.com/mozilla/fxa-content-server/pull/3144","id":110186970,"number":3144,"title":"feat(client): notify other tabs of successful sign in/out","user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/fxa-content-server/labels/waffle:progress","name":"waffle:progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-07T09:38:22Z","updated_at":"2015-10-13T10:45:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3144","html_url":"https://github.com/mozilla/fxa-content-server/pull/3144","diff_url":"https://github.com/mozilla/fxa-content-server/pull/3144.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/3144.patch"},"body":"Fixes #3024, redirecting to sign-in/settings across multiple tabs.\r\n\r\nDeliberately does not address OAuth sign-in because of potential unintended consequences from redirecting to a relier URL more than once. Maybe that is something that can be opted in to per-relier in the future. There's also no attempt to cover successful sign-up here either.\r\n\r\nBecause `InterTabChannelMixin` is now a dependency of the sign-in and settings views, there was a little bit of collateral damage (`force_auth::initialize`, the router tests) where the new dependency also needed to be met.\r\n\r\nThe change makes use of the broker capabilities, which weren't comprehensively covered by the unit tests before. So I added a bunch of assertions for their default capabilities as part of this change, since some of the new tests assumed that the capabilities would be correct.\r\n\r\nThere is no new functional test for OAuth sign-in, because I couldn't work out how to reliably test that a thing *doesn't* happen with Selenium. If I simply `findById('fxa-signin-header')`, it succeeds immediately instead of waiting for navigation. I could `sleep()`, but I've been bitten by those before; if you have better suggestions, I'll be happy to implement them. The OAuth behaviour is covered in the unit tests though, by stubbing `hasCapability` to return `false` and asserting that the sign-in activity does not occur."},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/147679346","html_url":"https://github.com/mozilla/fxa-content-server/pull/3144#issuecomment-147679346","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3144","id":147679346,"user":{"login":"GitCop","id":7943652,"avatar_url":"https://avatars.githubusercontent.com/u/7943652?v=3","gravatar_id":"","url":"https://api.github.com/users/GitCop","html_url":"https://github.com/GitCop","followers_url":"https://api.github.com/users/GitCop/followers","following_url":"https://api.github.com/users/GitCop/following{/other_user}","gists_url":"https://api.github.com/users/GitCop/gists{/gist_id}","starred_url":"https://api.github.com/users/GitCop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitCop/subscriptions","organizations_url":"https://api.github.com/users/GitCop/orgs","repos_url":"https://api.github.com/users/GitCop/repos","events_url":"https://api.github.com/users/GitCop/events{/privacy}","received_events_url":"https://api.github.com/users/GitCop/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T10:45:31Z","updated_at":"2015-10-13T10:45:31Z","body":"There were the following issues with your Pull Request\n\n * Commit: 5fafa7fdc9e3ea2796c081656e7f229649031376\n  * Commits must be in the following format: **%{type}(%{scope}): %{description}**\n\nGuidelines are available at https://github.com/mozilla/fxa-content-server/blob/master/CONTRIBUTING.md#git-commit-guidelines\n\n---\nThis message was auto-generated by https://gitcop.com\n"}}