{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/31087238","id":31087238,"diff_hunk":"@@ -17,11 +44,12 @@ The `getColumns()` method defines how a storm tuple maps to a list of columns re\n **The order of the returned list is important. The place holders in the supplied queries are resolved in the same order as returned list.**\n For example if the user supplied insert query is `insert into user(user_id, user_name, create_date) values (?,?, now())` the 1st item \n of the returned list of `getColumns` method will map to the 1st place holder and the 2nd to the 2nd and so on. We do not parse\n-the supplied queries to try and resolve place holder by column names. \n+the supplied queries to try and resolve place holder by column names. Not making any assumptions about the query syntax allows this connector\n+to be used by some non-standard sql frameworks like Pheonix which only supports upsert into.\n \n ### JdbcInsertBolt\n-To use the `JdbcInsertBolt`, you construct an instance of it and specify a configuration key in your storm config that holds the \n-hikari configuration map and a `JdbcMapper` implementation that coverts storm tuple to DB row. In addition, you must either supply \n+To use the `JdbcInsertBolt`, you construct an instance of it by specifying a `ConnectionProvider` implementation\n+and a `JdbcMapper` implementation that coverts storm tuple to DB row. In addition, you must either supply","path":"external/storm-jdbc/README.md","position":51,"original_position":51,"commit_id":"7771a4ddd7bbbda4cbb799b14e06d05693d834e6","original_commit_id":"7771a4ddd7bbbda4cbb799b14e06d05693d834e6","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"body":"coverts -> converts","created_at":"2015-05-26T22:41:30Z","updated_at":"2015-05-26T22:41:30Z","html_url":"https://github.com/apache/storm/pull/556#discussion_r31087238","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/556","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/31087238"},"html":{"href":"https://github.com/apache/storm/pull/556#discussion_r31087238"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/556","id":35655345,"html_url":"https://github.com/apache/storm/pull/556","diff_url":"https://github.com/apache/storm/pull/556.diff","patch_url":"https://github.com/apache/storm/pull/556.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/556","number":556,"state":"open","locked":false,"title":"STORM-821: Adding connection provider interface to decouple jdbc conn…","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"…ector from a single connection pooling implementation.","created_at":"2015-05-18T17:28:35Z","updated_at":"2015-05-26T22:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a764ba8b90349418ddb09ba4845756e5d8effd5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/556/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/556/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/556/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/7771a4ddd7bbbda4cbb799b14e06d05693d834e6","head":{"label":"Parth-Brahmbhatt:STORM-821","ref":"STORM-821","sha":"7771a4ddd7bbbda4cbb799b14e06d05693d834e6","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"repo":{"id":20899571,"name":"incubator-storm","full_name":"Parth-Brahmbhatt/incubator-storm","owner":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Parth-Brahmbhatt/incubator-storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm","forks_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/forks","keys_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/teams","hooks_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/hooks","issue_events_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues/events{/number}","events_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/events","assignees_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/assignees{/user}","branches_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/branches{/branch}","tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/tags","blobs_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/statuses/{sha}","languages_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/languages","stargazers_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/stargazers","contributors_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/contributors","subscribers_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/subscribers","subscription_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/subscription","commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/contents/{+path}","compare_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/merges","archive_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/downloads","issues_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues{/number}","pulls_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/pulls{/number}","milestones_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/milestones{/number}","notifications_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/labels{/name}","releases_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/releases{/id}","created_at":"2014-06-16T20:27:09Z","updated_at":"2015-01-14T20:29:44Z","pushed_at":"2015-05-20T21:50:04Z","git_url":"git://github.com/Parth-Brahmbhatt/incubator-storm.git","ssh_url":"git@github.com:Parth-Brahmbhatt/incubator-storm.git","clone_url":"https://github.com/Parth-Brahmbhatt/incubator-storm.git","svn_url":"https://github.com/Parth-Brahmbhatt/incubator-storm","homepage":null,"size":21560,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:0.10.x-branch","ref":"0.10.x-branch","sha":"bafb86bb01c29bf77f312ab346dd0a9c48293c36","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-05-26T16:24:30Z","pushed_at":"2015-05-26T19:36:29Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":945151,"stargazers_count":1953,"watchers_count":1953,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1305,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":72,"forks":1305,"open_issues":72,"watchers":1953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/556"},"html":{"href":"https://github.com/apache/storm/pull/556"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/556"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/7771a4ddd7bbbda4cbb799b14e06d05693d834e6"}}}}