{"action":"created","comment":{"url":"https://api.github.com/repos/benvanik/xenia/pulls/comments/30947734","id":30947734,"diff_hunk":"@@ -306,8 +306,8 @@ SHIM_CALL MmAllocatePhysicalMemoryEx_shim(PPCContext* ppc_state,\n   // and the memory must be allocated there. I haven't seen a game do this,\n   // and instead they all do min=0 / max=-1 to indicate the system should pick.\n   // If we have to suport arbitrary placement things will get nasty.\n-  assert_true(min_addr_range == 0);\n-  assert_true(max_addr_range == 0xFFFFFFFF);\n+  //assert_true(min_addr_range == 0);","path":"src/xenia/kernel/xboxkrnl_memory.cc","position":6,"original_position":6,"commit_id":"61e9ba665b3a83d370d947566a6eaa62cc9d68af","original_commit_id":"61e9ba665b3a83d370d947566a6eaa62cc9d68af","user":{"login":"DrChat","id":2402369,"avatar_url":"https://avatars.githubusercontent.com/u/2402369?v=3","gravatar_id":"","url":"https://api.github.com/users/DrChat","html_url":"https://github.com/DrChat","followers_url":"https://api.github.com/users/DrChat/followers","following_url":"https://api.github.com/users/DrChat/following{/other_user}","gists_url":"https://api.github.com/users/DrChat/gists{/gist_id}","starred_url":"https://api.github.com/users/DrChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrChat/subscriptions","organizations_url":"https://api.github.com/users/DrChat/orgs","repos_url":"https://api.github.com/users/DrChat/repos","events_url":"https://api.github.com/users/DrChat/events{/privacy}","received_events_url":"https://api.github.com/users/DrChat/received_events","type":"User","site_admin":false},"body":"Yeah, it looks like it's working OK. I'll do that.","created_at":"2015-05-23T19:52:16Z","updated_at":"2015-05-23T19:52:16Z","html_url":"https://github.com/benvanik/xenia/pull/220#discussion_r30947734","pull_request_url":"https://api.github.com/repos/benvanik/xenia/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/comments/30947734"},"html":{"href":"https://github.com/benvanik/xenia/pull/220#discussion_r30947734"},"pull_request":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/benvanik/xenia/pulls/220","id":36092558,"html_url":"https://github.com/benvanik/xenia/pull/220","diff_url":"https://github.com/benvanik/xenia/pull/220.diff","patch_url":"https://github.com/benvanik/xenia/pull/220.patch","issue_url":"https://api.github.com/repos/benvanik/xenia/issues/220","number":220,"state":"open","locked":false,"title":"A few fixes for portal","user":{"login":"DrChat","id":2402369,"avatar_url":"https://avatars.githubusercontent.com/u/2402369?v=3","gravatar_id":"","url":"https://api.github.com/users/DrChat","html_url":"https://github.com/DrChat","followers_url":"https://api.github.com/users/DrChat/followers","following_url":"https://api.github.com/users/DrChat/following{/other_user}","gists_url":"https://api.github.com/users/DrChat/gists{/gist_id}","starred_url":"https://api.github.com/users/DrChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrChat/subscriptions","organizations_url":"https://api.github.com/users/DrChat/orgs","repos_url":"https://api.github.com/users/DrChat/repos","events_url":"https://api.github.com/users/DrChat/events{/privacy}","received_events_url":"https://api.github.com/users/DrChat/received_events","type":"User","site_admin":false},"body":"Gets portal up to the point where it freezes initializing the audio system (cause of thread pcr+0x10C not being correct CPU id)","created_at":"2015-05-23T19:41:09Z","updated_at":"2015-05-23T19:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"509560567eaa6fe81ba56aabcaa904c58d4b163c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/benvanik/xenia/pulls/220/commits","review_comments_url":"https://api.github.com/repos/benvanik/xenia/pulls/220/comments","review_comment_url":"https://api.github.com/repos/benvanik/xenia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benvanik/xenia/issues/220/comments","statuses_url":"https://api.github.com/repos/benvanik/xenia/statuses/61e9ba665b3a83d370d947566a6eaa62cc9d68af","head":{"label":"DrChat:portal_fixes","ref":"portal_fixes","sha":"61e9ba665b3a83d370d947566a6eaa62cc9d68af","user":{"login":"DrChat","id":2402369,"avatar_url":"https://avatars.githubusercontent.com/u/2402369?v=3","gravatar_id":"","url":"https://api.github.com/users/DrChat","html_url":"https://github.com/DrChat","followers_url":"https://api.github.com/users/DrChat/followers","following_url":"https://api.github.com/users/DrChat/following{/other_user}","gists_url":"https://api.github.com/users/DrChat/gists{/gist_id}","starred_url":"https://api.github.com/users/DrChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrChat/subscriptions","organizations_url":"https://api.github.com/users/DrChat/orgs","repos_url":"https://api.github.com/users/DrChat/repos","events_url":"https://api.github.com/users/DrChat/events{/privacy}","received_events_url":"https://api.github.com/users/DrChat/received_events","type":"User","site_admin":false},"repo":{"id":34922300,"name":"xenia","full_name":"DrChat/xenia","owner":{"login":"DrChat","id":2402369,"avatar_url":"https://avatars.githubusercontent.com/u/2402369?v=3","gravatar_id":"","url":"https://api.github.com/users/DrChat","html_url":"https://github.com/DrChat","followers_url":"https://api.github.com/users/DrChat/followers","following_url":"https://api.github.com/users/DrChat/following{/other_user}","gists_url":"https://api.github.com/users/DrChat/gists{/gist_id}","starred_url":"https://api.github.com/users/DrChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrChat/subscriptions","organizations_url":"https://api.github.com/users/DrChat/orgs","repos_url":"https://api.github.com/users/DrChat/repos","events_url":"https://api.github.com/users/DrChat/events{/privacy}","received_events_url":"https://api.github.com/users/DrChat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrChat/xenia","description":"Xbox 360 Emulator Research Project ","fork":true,"url":"https://api.github.com/repos/DrChat/xenia","forks_url":"https://api.github.com/repos/DrChat/xenia/forks","keys_url":"https://api.github.com/repos/DrChat/xenia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrChat/xenia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrChat/xenia/teams","hooks_url":"https://api.github.com/repos/DrChat/xenia/hooks","issue_events_url":"https://api.github.com/repos/DrChat/xenia/issues/events{/number}","events_url":"https://api.github.com/repos/DrChat/xenia/events","assignees_url":"https://api.github.com/repos/DrChat/xenia/assignees{/user}","branches_url":"https://api.github.com/repos/DrChat/xenia/branches{/branch}","tags_url":"https://api.github.com/repos/DrChat/xenia/tags","blobs_url":"https://api.github.com/repos/DrChat/xenia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrChat/xenia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrChat/xenia/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrChat/xenia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrChat/xenia/statuses/{sha}","languages_url":"https://api.github.com/repos/DrChat/xenia/languages","stargazers_url":"https://api.github.com/repos/DrChat/xenia/stargazers","contributors_url":"https://api.github.com/repos/DrChat/xenia/contributors","subscribers_url":"https://api.github.com/repos/DrChat/xenia/subscribers","subscription_url":"https://api.github.com/repos/DrChat/xenia/subscription","commits_url":"https://api.github.com/repos/DrChat/xenia/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrChat/xenia/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrChat/xenia/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrChat/xenia/issues/comments{/number}","contents_url":"https://api.github.com/repos/DrChat/xenia/contents/{+path}","compare_url":"https://api.github.com/repos/DrChat/xenia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrChat/xenia/merges","archive_url":"https://api.github.com/repos/DrChat/xenia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrChat/xenia/downloads","issues_url":"https://api.github.com/repos/DrChat/xenia/issues{/number}","pulls_url":"https://api.github.com/repos/DrChat/xenia/pulls{/number}","milestones_url":"https://api.github.com/repos/DrChat/xenia/milestones{/number}","notifications_url":"https://api.github.com/repos/DrChat/xenia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrChat/xenia/labels{/name}","releases_url":"https://api.github.com/repos/DrChat/xenia/releases{/id}","created_at":"2015-05-01T20:21:14Z","updated_at":"2015-05-07T02:21:11Z","pushed_at":"2015-05-23T19:35:18Z","git_url":"git://github.com/DrChat/xenia.git","ssh_url":"git@github.com:DrChat/xenia.git","clone_url":"https://github.com/DrChat/xenia.git","svn_url":"https://github.com/DrChat/xenia","homepage":"http://xenia.jp","size":9422,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benvanik:master","ref":"master","sha":"1222fc6ef7ee9da1c69fdbc89577525d3cb80174","user":{"login":"benvanik","id":75337,"avatar_url":"https://avatars.githubusercontent.com/u/75337?v=3","gravatar_id":"","url":"https://api.github.com/users/benvanik","html_url":"https://github.com/benvanik","followers_url":"https://api.github.com/users/benvanik/followers","following_url":"https://api.github.com/users/benvanik/following{/other_user}","gists_url":"https://api.github.com/users/benvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/benvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvanik/subscriptions","organizations_url":"https://api.github.com/users/benvanik/orgs","repos_url":"https://api.github.com/users/benvanik/repos","events_url":"https://api.github.com/users/benvanik/events{/privacy}","received_events_url":"https://api.github.com/users/benvanik/received_events","type":"User","site_admin":false},"repo":{"id":7550637,"name":"xenia","full_name":"benvanik/xenia","owner":{"login":"benvanik","id":75337,"avatar_url":"https://avatars.githubusercontent.com/u/75337?v=3","gravatar_id":"","url":"https://api.github.com/users/benvanik","html_url":"https://github.com/benvanik","followers_url":"https://api.github.com/users/benvanik/followers","following_url":"https://api.github.com/users/benvanik/following{/other_user}","gists_url":"https://api.github.com/users/benvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/benvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvanik/subscriptions","organizations_url":"https://api.github.com/users/benvanik/orgs","repos_url":"https://api.github.com/users/benvanik/repos","events_url":"https://api.github.com/users/benvanik/events{/privacy}","received_events_url":"https://api.github.com/users/benvanik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benvanik/xenia","description":"Xbox 360 Emulator Research Project ","fork":false,"url":"https://api.github.com/repos/benvanik/xenia","forks_url":"https://api.github.com/repos/benvanik/xenia/forks","keys_url":"https://api.github.com/repos/benvanik/xenia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benvanik/xenia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benvanik/xenia/teams","hooks_url":"https://api.github.com/repos/benvanik/xenia/hooks","issue_events_url":"https://api.github.com/repos/benvanik/xenia/issues/events{/number}","events_url":"https://api.github.com/repos/benvanik/xenia/events","assignees_url":"https://api.github.com/repos/benvanik/xenia/assignees{/user}","branches_url":"https://api.github.com/repos/benvanik/xenia/branches{/branch}","tags_url":"https://api.github.com/repos/benvanik/xenia/tags","blobs_url":"https://api.github.com/repos/benvanik/xenia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benvanik/xenia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benvanik/xenia/git/refs{/sha}","trees_url":"https://api.github.com/repos/benvanik/xenia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benvanik/xenia/statuses/{sha}","languages_url":"https://api.github.com/repos/benvanik/xenia/languages","stargazers_url":"https://api.github.com/repos/benvanik/xenia/stargazers","contributors_url":"https://api.github.com/repos/benvanik/xenia/contributors","subscribers_url":"https://api.github.com/repos/benvanik/xenia/subscribers","subscription_url":"https://api.github.com/repos/benvanik/xenia/subscription","commits_url":"https://api.github.com/repos/benvanik/xenia/commits{/sha}","git_commits_url":"https://api.github.com/repos/benvanik/xenia/git/commits{/sha}","comments_url":"https://api.github.com/repos/benvanik/xenia/comments{/number}","issue_comment_url":"https://api.github.com/repos/benvanik/xenia/issues/comments{/number}","contents_url":"https://api.github.com/repos/benvanik/xenia/contents/{+path}","compare_url":"https://api.github.com/repos/benvanik/xenia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benvanik/xenia/merges","archive_url":"https://api.github.com/repos/benvanik/xenia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benvanik/xenia/downloads","issues_url":"https://api.github.com/repos/benvanik/xenia/issues{/number}","pulls_url":"https://api.github.com/repos/benvanik/xenia/pulls{/number}","milestones_url":"https://api.github.com/repos/benvanik/xenia/milestones{/number}","notifications_url":"https://api.github.com/repos/benvanik/xenia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benvanik/xenia/labels{/name}","releases_url":"https://api.github.com/repos/benvanik/xenia/releases{/id}","created_at":"2013-01-10T23:20:45Z","updated_at":"2015-05-22T14:38:19Z","pushed_at":"2015-05-23T19:41:10Z","git_url":"git://github.com/benvanik/xenia.git","ssh_url":"git@github.com:benvanik/xenia.git","clone_url":"https://github.com/benvanik/xenia.git","svn_url":"https://github.com/benvanik/xenia","homepage":"http://xenia.jp","size":15406,"stargazers_count":1118,"watchers_count":1118,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":103,"mirror_url":null,"open_issues_count":63,"forks":103,"open_issues":63,"watchers":1118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/220"},"html":{"href":"https://github.com/benvanik/xenia/pull/220"},"issue":{"href":"https://api.github.com/repos/benvanik/xenia/issues/220"},"comments":{"href":"https://api.github.com/repos/benvanik/xenia/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/benvanik/xenia/statuses/61e9ba665b3a83d370d947566a6eaa62cc9d68af"}}}}