{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/2835","labels_url":"https://api.github.com/repos/videojs/video.js/issues/2835/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2835/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/2835/events","html_url":"https://github.com/videojs/video.js/pull/2835","id":118160370,"number":2835,"title":"Check for text track changes that occurred before tech was listening","user":{"login":"gesinger","id":356726,"avatar_url":"https://avatars.githubusercontent.com/u/356726?v=3","gravatar_id":"","url":"https://api.github.com/users/gesinger","html_url":"https://github.com/gesinger","followers_url":"https://api.github.com/users/gesinger/followers","following_url":"https://api.github.com/users/gesinger/following{/other_user}","gists_url":"https://api.github.com/users/gesinger/gists{/gist_id}","starred_url":"https://api.github.com/users/gesinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gesinger/subscriptions","organizations_url":"https://api.github.com/users/gesinger/orgs","repos_url":"https://api.github.com/users/gesinger/repos","events_url":"https://api.github.com/users/gesinger/events{/privacy}","received_events_url":"https://api.github.com/users/gesinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-21T01:35:08Z","updated_at":"2015-11-21T01:42:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2835","html_url":"https://github.com/videojs/video.js/pull/2835","diff_url":"https://github.com/videojs/video.js/pull/2835.diff","patch_url":"https://github.com/videojs/video.js/pull/2835.patch"},"body":"If any code sets a track mode during player setup (e.g., `track.mode = 'showing'`) for non native text tracks, there is a race case where the player may not be listening for changes on the track. For instance:\r\n\r\n```javascript\r\nvar player = videojs('my-video', {\r\n    html5: {\r\n        nativeTextTracks: false\r\n    }\r\n});\r\n\r\nvar track = player.addTextTrack('captions');\r\ntrack.mode = 'showing';\r\n```\r\n\r\nThe caption settings will show the captions as on for the track, but the captions will not show up on the video unless a user switches to fullscreen or changes the caption settings (both will update display appropriately).\r\n\r\nThis change ensures that before videojs starts listening to change events on tracks, it gets any changes that may have happened between then and the start of setup."},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/158573236","html_url":"https://github.com/videojs/video.js/pull/2835#issuecomment-158573236","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2835","id":158573236,"user":{"login":"pam","id":8315782,"avatar_url":"https://avatars.githubusercontent.com/u/8315782?v=3","gravatar_id":"","url":"https://api.github.com/users/pam","html_url":"https://github.com/pam","followers_url":"https://api.github.com/users/pam/followers","following_url":"https://api.github.com/users/pam/following{/other_user}","gists_url":"https://api.github.com/users/pam/gists{/gist_id}","starred_url":"https://api.github.com/users/pam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pam/subscriptions","organizations_url":"https://api.github.com/users/pam/orgs","repos_url":"https://api.github.com/users/pam/repos","events_url":"https://api.github.com/users/pam/events{/privacy}","received_events_url":"https://api.github.com/users/pam/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T01:42:02Z","updated_at":"2015-11-21T01:42:02Z","body":"\n**Tests passed.** Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: **CONFIRMED**\n\nCommit: 8a3a97ecc936e34ca052570e4efb14ea1d8e1e45\nBuild details: https://travis-ci.org/pam/video.js/builds/92385457\n\n(*Please note that this is a [fully automated](https://github.com/twbs/savage) comment.*)\n      "}}