{"action":"created","issue":{"url":"https://api.github.com/repos/bwapi/bwapi/issues/561","labels_url":"https://api.github.com/repos/bwapi/bwapi/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/bwapi/bwapi/issues/561/comments","events_url":"https://api.github.com/repos/bwapi/bwapi/issues/561/events","html_url":"https://github.com/bwapi/bwapi/issues/561","id":58640641,"number":561,"title":"Some suggestions for \"save_replay\" option improvement","user":{"login":"Predelnik","id":2133957,"avatar_url":"https://avatars.githubusercontent.com/u/2133957?v=3","gravatar_id":"","url":"https://api.github.com/users/Predelnik","html_url":"https://github.com/Predelnik","followers_url":"https://api.github.com/users/Predelnik/followers","following_url":"https://api.github.com/users/Predelnik/following{/other_user}","gists_url":"https://api.github.com/users/Predelnik/gists{/gist_id}","starred_url":"https://api.github.com/users/Predelnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Predelnik/subscriptions","organizations_url":"https://api.github.com/users/Predelnik/orgs","repos_url":"https://api.github.com/users/Predelnik/repos","events_url":"https://api.github.com/users/Predelnik/events{/privacy}","received_events_url":"https://api.github.com/users/Predelnik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bwapi/bwapi/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/bwapi/bwapi/labels/Priority-Low","name":"Priority-Low","color":"FFFFFF"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bwapi/bwapi/milestones/2","html_url":"https://github.com/bwapi/bwapi/milestones/4.1.1","labels_url":"https://api.github.com/repos/bwapi/bwapi/milestones/2/labels","id":959632,"number":2,"title":"4.1.1","description":"This milestone should contain bug fixes and general improvements for 4.1.0.\r\nThe changes may be cherry picked to the 4.1.0 branch.\r\n\r\n","creator":{"login":"heinermann","id":1966366,"avatar_url":"https://avatars.githubusercontent.com/u/1966366?v=3","gravatar_id":"","url":"https://api.github.com/users/heinermann","html_url":"https://github.com/heinermann","followers_url":"https://api.github.com/users/heinermann/followers","following_url":"https://api.github.com/users/heinermann/following{/other_user}","gists_url":"https://api.github.com/users/heinermann/gists{/gist_id}","starred_url":"https://api.github.com/users/heinermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heinermann/subscriptions","organizations_url":"https://api.github.com/users/heinermann/orgs","repos_url":"https://api.github.com/users/heinermann/repos","events_url":"https://api.github.com/users/heinermann/events{/privacy}","received_events_url":"https://api.github.com/users/heinermann/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":7,"state":"open","created_at":"2015-01-31T19:18:36Z","updated_at":"2015-02-27T20:52:31Z","due_on":"2015-02-28T05:00:00Z","closed_at":null},"comments":8,"created_at":"2015-02-23T20:08:44Z","updated_at":"2015-02-28T20:34:18Z","closed_at":null,"body":"I implemented some of these changes locally and I want to question is these improvements are good or not to be pushed to bwapi and also to provide some reasoning for them:\r\n\r\n1. Add variable to contain game result for `save_replay`. For example I added `%GAMERESULT%` variable which equals `win` in case of winning and `loss` in case of losing. Maybe it could also be name of winning player, but personallly I like the simple win/loss variant better.\r\n\r\n  _Usage_: after playing a lot of games with no gui on max speed it allows quickly to find replays where bot lost and watch them ignoring others, also adds a free way to quickly glance over the statistics. There could be other workarounds probably, like finding it from replays content or making bot store indexes of lost games but it seems like this one is the simplest and could be done without much fuss.\r\n\r\n2.  For default starcraft AI I think that `%ENEMYNAME%` should be always the same, I don't believe that anyone have much interest against which tribe/brood they were playing :) Taking example from default Starcraft autoreplay it could be just named \"Comp\"\r\n\r\n3. Not exactly about `save_replay` but I guess it's connected. There are options for choosing random race from any pair of them randomized by bwapi before the game. But I think that technically there should also be option to select out of all 3 randomized by bwapi and it differs from `Random` in the following:\r\n\r\n      * Bots will play differently knowing the race they play against, so technically it will be totally different test case\r\n      * `save_replay` will write the correct race letter in that case and not U as in Unknown :)\r\n\r\n  Since it's mostly concerning default AI it's not that significant of course but I think such option could be useful. Suggested name: \"RandomTPZ\" similar to 2-race randoming options.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bwapi/bwapi/issues/comments/76544596","html_url":"https://github.com/bwapi/bwapi/issues/561#issuecomment-76544596","issue_url":"https://api.github.com/repos/bwapi/bwapi/issues/561","id":76544596,"user":{"login":"heinermann","id":1966366,"avatar_url":"https://avatars.githubusercontent.com/u/1966366?v=3","gravatar_id":"","url":"https://api.github.com/users/heinermann","html_url":"https://github.com/heinermann","followers_url":"https://api.github.com/users/heinermann/followers","following_url":"https://api.github.com/users/heinermann/following{/other_user}","gists_url":"https://api.github.com/users/heinermann/gists{/gist_id}","starred_url":"https://api.github.com/users/heinermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heinermann/subscriptions","organizations_url":"https://api.github.com/users/heinermann/orgs","repos_url":"https://api.github.com/users/heinermann/repos","events_url":"https://api.github.com/users/heinermann/events{/privacy}","received_events_url":"https://api.github.com/users/heinermann/received_events","type":"User","site_admin":false},"created_at":"2015-02-28T20:34:18Z","updated_at":"2015-02-28T20:34:18Z","body":"1. You're right. Try `Util/Convenience.h`.\r\n2. Sounds good. Maybe we can add a BWAPI AutoMenuType internally which acts as a BWAPI Type. Possibly in another issue.\r\n3. OK I'll work on some of the things then.\r\n"}}