{"action":"created","comment":{"url":"https://api.github.com/repos/super626/cocos2d-x/pulls/comments/26723460","id":26723460,"diff_hunk":"@@ -898,7 +899,18 @@ void Label::draw(Renderer *renderer, const Mat4 &transform, uint32_t flags)\n     // Don't do calculate the culling if the transform was not updated\n     bool transformUpdated = flags & FLAGS_TRANSFORM_DIRTY;\n #if CC_USE_CULLING\n-    _insideBounds = transformUpdated ? renderer->checkVisibility(transform, _contentSize) : _insideBounds;\n+    auto camera = Camera::getVisitingCamera();\n+    auto tmpViewMatrixed = camera->getViewMatrix();","path":"cocos/2d/CCLabel.cpp","position":14,"original_position":14,"commit_id":"b74621d2d761b5621ec745d39dd039f40729e0db","original_commit_id":"b74621d2d761b5621ec745d39dd039f40729e0db","user":{"login":"super626","id":4159090,"avatar_url":"https://avatars.githubusercontent.com/u/4159090?v=3","gravatar_id":"","url":"https://api.github.com/users/super626","html_url":"https://github.com/super626","followers_url":"https://api.github.com/users/super626/followers","following_url":"https://api.github.com/users/super626/following{/other_user}","gists_url":"https://api.github.com/users/super626/gists{/gist_id}","starred_url":"https://api.github.com/users/super626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/super626/subscriptions","organizations_url":"https://api.github.com/users/super626/orgs","repos_url":"https://api.github.com/users/super626/repos","events_url":"https://api.github.com/users/super626/events{/privacy}","received_events_url":"https://api.github.com/users/super626/received_events","type":"User","site_admin":false},"body":"visiting camera may be null","created_at":"2015-03-19T01:19:37Z","updated_at":"2015-03-19T01:19:37Z","html_url":"https://github.com/super626/cocos2d-x/pull/257#discussion_r26723460","pull_request_url":"https://api.github.com/repos/super626/cocos2d-x/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/super626/cocos2d-x/pulls/comments/26723460"},"html":{"href":"https://github.com/super626/cocos2d-x/pull/257#discussion_r26723460"},"pull_request":{"href":"https://api.github.com/repos/super626/cocos2d-x/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/super626/cocos2d-x/pulls/257","id":31321809,"html_url":"https://github.com/super626/cocos2d-x/pull/257","diff_url":"https://github.com/super626/cocos2d-x/pull/257.diff","patch_url":"https://github.com/super626/cocos2d-x/pull/257.patch","issue_url":"https://api.github.com/repos/super626/cocos2d-x/issues/257","number":257,"state":"open","locked":false,"title":"fix culling","user":{"login":"tangziwen","id":3488056,"avatar_url":"https://avatars.githubusercontent.com/u/3488056?v=3","gravatar_id":"","url":"https://api.github.com/users/tangziwen","html_url":"https://github.com/tangziwen","followers_url":"https://api.github.com/users/tangziwen/followers","following_url":"https://api.github.com/users/tangziwen/following{/other_user}","gists_url":"https://api.github.com/users/tangziwen/gists{/gist_id}","starred_url":"https://api.github.com/users/tangziwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangziwen/subscriptions","organizations_url":"https://api.github.com/users/tangziwen/orgs","repos_url":"https://api.github.com/users/tangziwen/repos","events_url":"https://api.github.com/users/tangziwen/events{/privacy}","received_events_url":"https://api.github.com/users/tangziwen/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-17T10:17:46Z","updated_at":"2015-03-19T01:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80a2ba52f2d28aa96dc5b05ca60c927fe2a27545","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/super626/cocos2d-x/pulls/257/commits","review_comments_url":"https://api.github.com/repos/super626/cocos2d-x/pulls/257/comments","review_comment_url":"https://api.github.com/repos/super626/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/super626/cocos2d-x/issues/257/comments","statuses_url":"https://api.github.com/repos/super626/cocos2d-x/statuses/b74621d2d761b5621ec745d39dd039f40729e0db","head":{"label":"tangziwen:v3","ref":"v3","sha":"b74621d2d761b5621ec745d39dd039f40729e0db","user":{"login":"tangziwen","id":3488056,"avatar_url":"https://avatars.githubusercontent.com/u/3488056?v=3","gravatar_id":"","url":"https://api.github.com/users/tangziwen","html_url":"https://github.com/tangziwen","followers_url":"https://api.github.com/users/tangziwen/followers","following_url":"https://api.github.com/users/tangziwen/following{/other_user}","gists_url":"https://api.github.com/users/tangziwen/gists{/gist_id}","starred_url":"https://api.github.com/users/tangziwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangziwen/subscriptions","organizations_url":"https://api.github.com/users/tangziwen/orgs","repos_url":"https://api.github.com/users/tangziwen/repos","events_url":"https://api.github.com/users/tangziwen/events{/privacy}","received_events_url":"https://api.github.com/users/tangziwen/received_events","type":"User","site_admin":false},"repo":{"id":24621473,"name":"cocos2d-x","full_name":"tangziwen/cocos2d-x","owner":{"login":"tangziwen","id":3488056,"avatar_url":"https://avatars.githubusercontent.com/u/3488056?v=3","gravatar_id":"","url":"https://api.github.com/users/tangziwen","html_url":"https://github.com/tangziwen","followers_url":"https://api.github.com/users/tangziwen/followers","following_url":"https://api.github.com/users/tangziwen/following{/other_user}","gists_url":"https://api.github.com/users/tangziwen/gists{/gist_id}","starred_url":"https://api.github.com/users/tangziwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangziwen/subscriptions","organizations_url":"https://api.github.com/users/tangziwen/orgs","repos_url":"https://api.github.com/users/tangziwen/repos","events_url":"https://api.github.com/users/tangziwen/events{/privacy}","received_events_url":"https://api.github.com/users/tangziwen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tangziwen/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/tangziwen/cocos2d-x","forks_url":"https://api.github.com/repos/tangziwen/cocos2d-x/forks","keys_url":"https://api.github.com/repos/tangziwen/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangziwen/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangziwen/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/tangziwen/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/tangziwen/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/tangziwen/cocos2d-x/events","assignees_url":"https://api.github.com/repos/tangziwen/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/tangziwen/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/tangziwen/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/tangziwen/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangziwen/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangziwen/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangziwen/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangziwen/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/tangziwen/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/tangziwen/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/tangziwen/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/tangziwen/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/tangziwen/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/tangziwen/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangziwen/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangziwen/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangziwen/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangziwen/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/tangziwen/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangziwen/cocos2d-x/merges","archive_url":"https://api.github.com/repos/tangziwen/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangziwen/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/tangziwen/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/tangziwen/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/tangziwen/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/tangziwen/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangziwen/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/tangziwen/cocos2d-x/releases{/id}","created_at":"2014-09-30T02:34:41Z","updated_at":"2014-10-29T14:04:00Z","pushed_at":"2015-03-17T10:16:10Z","git_url":"git://github.com/tangziwen/cocos2d-x.git","ssh_url":"git@github.com:tangziwen/cocos2d-x.git","clone_url":"https://github.com/tangziwen/cocos2d-x.git","svn_url":"https://github.com/tangziwen/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":867689,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"v3_merge"}},"base":{"label":"super626:fixculling","ref":"fixculling","sha":"c89ac9f3362f44c93d7fdfebebcab4cbfad208ac","user":{"login":"super626","id":4159090,"avatar_url":"https://avatars.githubusercontent.com/u/4159090?v=3","gravatar_id":"","url":"https://api.github.com/users/super626","html_url":"https://github.com/super626","followers_url":"https://api.github.com/users/super626/followers","following_url":"https://api.github.com/users/super626/following{/other_user}","gists_url":"https://api.github.com/users/super626/gists{/gist_id}","starred_url":"https://api.github.com/users/super626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/super626/subscriptions","organizations_url":"https://api.github.com/users/super626/orgs","repos_url":"https://api.github.com/users/super626/repos","events_url":"https://api.github.com/users/super626/events{/privacy}","received_events_url":"https://api.github.com/users/super626/received_events","type":"User","site_admin":false},"repo":{"id":18664943,"name":"cocos2d-x","full_name":"super626/cocos2d-x","owner":{"login":"super626","id":4159090,"avatar_url":"https://avatars.githubusercontent.com/u/4159090?v=3","gravatar_id":"","url":"https://api.github.com/users/super626","html_url":"https://github.com/super626","followers_url":"https://api.github.com/users/super626/followers","following_url":"https://api.github.com/users/super626/following{/other_user}","gists_url":"https://api.github.com/users/super626/gists{/gist_id}","starred_url":"https://api.github.com/users/super626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/super626/subscriptions","organizations_url":"https://api.github.com/users/super626/orgs","repos_url":"https://api.github.com/users/super626/repos","events_url":"https://api.github.com/users/super626/events{/privacy}","received_events_url":"https://api.github.com/users/super626/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/super626/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/super626/cocos2d-x","forks_url":"https://api.github.com/repos/super626/cocos2d-x/forks","keys_url":"https://api.github.com/repos/super626/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/super626/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/super626/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/super626/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/super626/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/super626/cocos2d-x/events","assignees_url":"https://api.github.com/repos/super626/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/super626/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/super626/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/super626/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/super626/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/super626/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/super626/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/super626/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/super626/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/super626/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/super626/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/super626/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/super626/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/super626/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/super626/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/super626/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/super626/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/super626/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/super626/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/super626/cocos2d-x/merges","archive_url":"https://api.github.com/repos/super626/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/super626/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/super626/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/super626/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/super626/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/super626/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/super626/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/super626/cocos2d-x/releases{/id}","created_at":"2014-04-11T06:39:38Z","updated_at":"2015-03-18T03:58:52Z","pushed_at":"2015-03-18T03:58:52Z","git_url":"git://github.com/super626/cocos2d-x.git","ssh_url":"git@github.com:super626/cocos2d-x.git","clone_url":"https://github.com/super626/cocos2d-x.git","svn_url":"https://github.com/super626/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":932038,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":6,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/super626/cocos2d-x/pulls/257"},"html":{"href":"https://github.com/super626/cocos2d-x/pull/257"},"issue":{"href":"https://api.github.com/repos/super626/cocos2d-x/issues/257"},"comments":{"href":"https://api.github.com/repos/super626/cocos2d-x/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/super626/cocos2d-x/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/super626/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/super626/cocos2d-x/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/super626/cocos2d-x/statuses/b74621d2d761b5621ec745d39dd039f40729e0db"}}}}