{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/41343164","id":41343164,"diff_hunk":"@@ -137,8 +137,25 @@ RingView.prototype = {\n     // Display the proper screen widgets.\n     this.ringDisplay.dataset.ringType = alert.type;\n \n+    var displayedTime;\n+    if (alert.type === 'alarm') {\n+      // Display the time as specified with \"hour\" and \"minute\". The timestamp\n+      // stored by mozAlarms does not move when the timezone changes, so we\n+      // cannot just use the value stored in '.time'. See\n+      // https://bugzilla.mozilla.org/show_bug.cgi?id=1178208#c4\n+      displayedTime = new Date();\n+      displayedTime.setHours(alert.hour);\n+      displayedTime.setMinutes(alert.minute);","path":"apps/clock/js/ring_view.js","position":12,"original_position":12,"commit_id":"d3bb1be638cf25ef0748f669b4eb1cf0de3a07c6","original_commit_id":"d3bb1be638cf25ef0748f669b4eb1cf0de3a07c6","user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"body":"why not `displayedTime = Date.now()` ?","created_at":"2015-10-07T01:28:08Z","updated_at":"2015-10-07T01:28:08Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/32253#discussion_r41343164","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/41343164"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32253#discussion_r41343164"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253","id":46845465,"html_url":"https://github.com/mozilla-b2g/gaia/pull/32253","diff_url":"https://github.com/mozilla-b2g/gaia/pull/32253.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/32253.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32253","number":32253,"state":"open","locked":false,"title":"Bug 1178208 - Wrong time is displayed when the alarm rings after a ti…","user":{"login":"mcav","id":42708,"avatar_url":"https://avatars.githubusercontent.com/u/42708?v=3","gravatar_id":"","url":"https://api.github.com/users/mcav","html_url":"https://github.com/mcav","followers_url":"https://api.github.com/users/mcav/followers","following_url":"https://api.github.com/users/mcav/following{/other_user}","gists_url":"https://api.github.com/users/mcav/gists{/gist_id}","starred_url":"https://api.github.com/users/mcav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcav/subscriptions","organizations_url":"https://api.github.com/users/mcav/orgs","repos_url":"https://api.github.com/users/mcav/repos","events_url":"https://api.github.com/users/mcav/events{/privacy}","received_events_url":"https://api.github.com/users/mcav/received_events","type":"User","site_admin":false},"body":"…me zone change.","created_at":"2015-10-05T23:06:53Z","updated_at":"2015-10-07T01:28:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b01912e9886b4baa4e796608f7a79220295c65a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32253/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/d3bb1be638cf25ef0748f669b4eb1cf0de3a07c6","head":{"label":"mcav:clock-displayed-timezone","ref":"clock-displayed-timezone","sha":"d3bb1be638cf25ef0748f669b4eb1cf0de3a07c6","user":{"login":"mcav","id":42708,"avatar_url":"https://avatars.githubusercontent.com/u/42708?v=3","gravatar_id":"","url":"https://api.github.com/users/mcav","html_url":"https://github.com/mcav","followers_url":"https://api.github.com/users/mcav/followers","following_url":"https://api.github.com/users/mcav/following{/other_user}","gists_url":"https://api.github.com/users/mcav/gists{/gist_id}","starred_url":"https://api.github.com/users/mcav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcav/subscriptions","organizations_url":"https://api.github.com/users/mcav/orgs","repos_url":"https://api.github.com/users/mcav/repos","events_url":"https://api.github.com/users/mcav/events{/privacy}","received_events_url":"https://api.github.com/users/mcav/received_events","type":"User","site_admin":false},"repo":{"id":12065405,"name":"gaia","full_name":"mcav/gaia","owner":{"login":"mcav","id":42708,"avatar_url":"https://avatars.githubusercontent.com/u/42708?v=3","gravatar_id":"","url":"https://api.github.com/users/mcav","html_url":"https://github.com/mcav","followers_url":"https://api.github.com/users/mcav/followers","following_url":"https://api.github.com/users/mcav/following{/other_user}","gists_url":"https://api.github.com/users/mcav/gists{/gist_id}","starred_url":"https://api.github.com/users/mcav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcav/subscriptions","organizations_url":"https://api.github.com/users/mcav/orgs","repos_url":"https://api.github.com/users/mcav/repos","events_url":"https://api.github.com/users/mcav/events{/privacy}","received_events_url":"https://api.github.com/users/mcav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcav/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/mcav/gaia","forks_url":"https://api.github.com/repos/mcav/gaia/forks","keys_url":"https://api.github.com/repos/mcav/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcav/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcav/gaia/teams","hooks_url":"https://api.github.com/repos/mcav/gaia/hooks","issue_events_url":"https://api.github.com/repos/mcav/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mcav/gaia/events","assignees_url":"https://api.github.com/repos/mcav/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mcav/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mcav/gaia/tags","blobs_url":"https://api.github.com/repos/mcav/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcav/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcav/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcav/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcav/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mcav/gaia/languages","stargazers_url":"https://api.github.com/repos/mcav/gaia/stargazers","contributors_url":"https://api.github.com/repos/mcav/gaia/contributors","subscribers_url":"https://api.github.com/repos/mcav/gaia/subscribers","subscription_url":"https://api.github.com/repos/mcav/gaia/subscription","commits_url":"https://api.github.com/repos/mcav/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcav/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcav/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcav/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcav/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mcav/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcav/gaia/merges","archive_url":"https://api.github.com/repos/mcav/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcav/gaia/downloads","issues_url":"https://api.github.com/repos/mcav/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mcav/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mcav/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mcav/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcav/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mcav/gaia/releases{/id}","created_at":"2013-08-12T20:19:57Z","updated_at":"2015-05-01T23:44:47Z","pushed_at":"2015-10-06T00:17:07Z","git_url":"git://github.com/mcav/gaia.git","ssh_url":"git@github.com:mcav/gaia.git","clone_url":"https://github.com/mcav/gaia.git","svn_url":"https://github.com/mcav/gaia","homepage":"https://wiki.mozilla.org/B2G","size":945204,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"f78efe5c801c26b11dd96f0a190fa8b644d7e5de","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-10-06T13:28:32Z","pushed_at":"2015-10-07T01:12:48Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1641572,"stargazers_count":1991,"watchers_count":1991,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2459,"mirror_url":null,"open_issues_count":1223,"forks":2459,"open_issues":1223,"watchers":1991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32253"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32253"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32253/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32253/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/d3bb1be638cf25ef0748f669b4eb1cf0de3a07c6"}}}}