{"push_id":736313008,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"0ec6b2269025b7647aa461c2e8b88fedb57bfa8c","before":"b9eeabdb892391aea9fd6bd965d0448e75b8c7bb","commits":[{"sha":"0ec6b2269025b7647aa461c2e8b88fedb57bfa8c","author":{"email":"60258c486a9660a474d408e6013543d2add80a76@redhat.com","name":"Nir Soffer"},"message":"sudoers: Restrict usage of systemd-run\n\nIn commit 608e92e1bdd70 (utils: Add systemd_run command modifier) we\nadded systemd-run to the allowed commands in the sudoers configuration.\nThis change introduced a security breach, allowing vdsm to run any binary\nusing systemd-run.\n\nThis patch restricts usage of systemd-run to the mount command when\nusing glusterfs storage domain. Due to sudoers syntax, it is not\npossible to allow any option in the systedmd-run command, and we must\nspecify the exact commend.\n\nWe also use systemd-run also for ifup and dhclinet, but these run from\nsupervdsm, so sudoers configuration is not needed.\n\nThis is an ugly fix for this security issue. A nicer fix requires more\nwork, calling the mount command in suprvdsm.\n\nChange-Id: If39394371acd0f4c49433adf79638a8547bf81ec\nSigned-off-by: Nir Soffer <nsoffer@redhat.com>\nReviewed-on: https://gerrit.ovirt.org/43937\nContinuous-Integration: Jenkins CI\nReviewed-by: Dan Kenigsberg <danken@redhat.com>","distinct":true,"url":"https://api.github.com/repos/oVirt/vdsm/commits/0ec6b2269025b7647aa461c2e8b88fedb57bfa8c"}]}