{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/11759","labels_url":"https://api.github.com/repos/docker/docker/issues/11759/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/11759/comments","events_url":"https://api.github.com/repos/docker/docker/issues/11759/events","html_url":"https://github.com/docker/docker/pull/11759","id":64346147,"number":11759,"title":"Add support for extending the .dockercfg file","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/Distribution","name":"Distribution","color":"e11d21"},{"url":"https://api.github.com/repos/docker/docker/labels/status/2-needs-code-review","name":"status/2-needs-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-03-25T18:53:11Z","updated_at":"2015-04-15T21:26:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11759","html_url":"https://github.com/docker/docker/pull/11759","diff_url":"https://github.com/docker/docker/pull/11759.diff","patch_url":"https://github.com/docker/docker/pull/11759.patch"},"body":"This PR does a couple of things:\r\n- makes loading of the .dockercfg file part of the DockerCli creation so\r\n  that we only need to load it once and not at lots of spots throughout\r\n  the code\r\n- moves the current auth stuff in the config struct down one level so that new\r\n  fields can be added w/o breaking the existing auth config logic\r\n- add testcases to verify that we can read .dockercfg files in the old\r\n  and new format - but always save in the new format\r\n\r\nNext steps if this is accepted:\r\n- move the config file processing out from under 'registry' since it\r\n  not registry specific any more\r\n- see what additional fields might be needed - yes I have some in mind :-)\r\n\r\nSigned-off-by: Doug Davis <dug@us.ibm.com>\r\n\r\n/cc @crosbymichael @nathanleclaire"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/93574095","html_url":"https://github.com/docker/docker/pull/11759#issuecomment-93574095","issue_url":"https://api.github.com/repos/docker/docker/issues/11759","id":93574095,"user":{"login":"icecrime","id":1564054,"avatar_url":"https://avatars.githubusercontent.com/u/1564054?v=3","gravatar_id":"","url":"https://api.github.com/users/icecrime","html_url":"https://github.com/icecrime","followers_url":"https://api.github.com/users/icecrime/followers","following_url":"https://api.github.com/users/icecrime/following{/other_user}","gists_url":"https://api.github.com/users/icecrime/gists{/gist_id}","starred_url":"https://api.github.com/users/icecrime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icecrime/subscriptions","organizations_url":"https://api.github.com/users/icecrime/orgs","repos_url":"https://api.github.com/users/icecrime/repos","events_url":"https://api.github.com/users/icecrime/events{/privacy}","received_events_url":"https://api.github.com/users/icecrime/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T21:26:29Z","updated_at":"2015-04-15T21:26:29Z","body":"I guess this one could be closed then (sorry, there's really too many information and cross references for me to follow here)."}}