{"action":"created","issue":{"url":"https://api.github.com/repos/cloudflare/cfssl/issues/132","labels_url":"https://api.github.com/repos/cloudflare/cfssl/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/132/comments","events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/132/events","html_url":"https://github.com/cloudflare/cfssl/pull/132","id":62245298,"number":132,"title":"Get missing info from CSR fields","user":{"login":"dr107","id":3991437,"avatar_url":"https://avatars.githubusercontent.com/u/3991437?v=3","gravatar_id":"","url":"https://api.github.com/users/dr107","html_url":"https://github.com/dr107","followers_url":"https://api.github.com/users/dr107/followers","following_url":"https://api.github.com/users/dr107/following{/other_user}","gists_url":"https://api.github.com/users/dr107/gists{/gist_id}","starred_url":"https://api.github.com/users/dr107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr107/subscriptions","organizations_url":"https://api.github.com/users/dr107/orgs","repos_url":"https://api.github.com/users/dr107/repos","events_url":"https://api.github.com/users/dr107/events{/privacy}","received_events_url":"https://api.github.com/users/dr107/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-03-17T00:37:58Z","updated_at":"2015-03-25T00:30:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/132","html_url":"https://github.com/cloudflare/cfssl/pull/132","diff_url":"https://github.com/cloudflare/cfssl/pull/132.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/132.patch"},"body":"If there is info missing in the API request, supplement it with\r\ninformation pulled out of the CSR pem.\r\n\r\nTBD: add unit tests. I'm putting this PR up early to give the CFSSL devs a chance to get started on code review."},"comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments/85757298","html_url":"https://github.com/cloudflare/cfssl/pull/132#issuecomment-85757298","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/132","id":85757298,"user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T00:30:14Z","updated_at":"2015-03-25T00:30:14Z","body":"Let's make a bigger and more complete change. Step back, you can see signer.ParseCertificateRequest is doing 3 things: parse and verify CSR, override subject and override hosts. And we are adding a new SubjectOverride function for the new logic. It's very patchy.\r\nCan you reduce ParseCertificateRequest to do CSR parsing only. And move subject override and hosts override to individual functions in signer/local. This way, the override logic is confined to signer/local, and it is easier to test."}}