{"action":"created","issue":{"url":"https://api.github.com/repos/makersacademy/instagram-challenge/issues/140","labels_url":"https://api.github.com/repos/makersacademy/instagram-challenge/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/makersacademy/instagram-challenge/issues/140/comments","events_url":"https://api.github.com/repos/makersacademy/instagram-challenge/issues/140/events","html_url":"https://github.com/makersacademy/instagram-challenge/pull/140","id":119388271,"number":140,"title":"Instagram Challenge(WIP)","user":{"login":"Alaanzr","id":13439766,"avatar_url":"https://avatars.githubusercontent.com/u/13439766?v=3","gravatar_id":"","url":"https://api.github.com/users/Alaanzr","html_url":"https://github.com/Alaanzr","followers_url":"https://api.github.com/users/Alaanzr/followers","following_url":"https://api.github.com/users/Alaanzr/following{/other_user}","gists_url":"https://api.github.com/users/Alaanzr/gists{/gist_id}","starred_url":"https://api.github.com/users/Alaanzr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alaanzr/subscriptions","organizations_url":"https://api.github.com/users/Alaanzr/orgs","repos_url":"https://api.github.com/users/Alaanzr/repos","events_url":"https://api.github.com/users/Alaanzr/events{/privacy}","received_events_url":"https://api.github.com/users/Alaanzr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/makersacademy/instagram-challenge/labels/QA","name":"QA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-29T21:04:37Z","updated_at":"2015-12-04T17:22:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/makersacademy/instagram-challenge/pulls/140","html_url":"https://github.com/makersacademy/instagram-challenge/pull/140","diff_url":"https://github.com/makersacademy/instagram-challenge/pull/140.diff","patch_url":"https://github.com/makersacademy/instagram-challenge/pull/140.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/makersacademy/instagram-challenge/issues/comments/162027246","html_url":"https://github.com/makersacademy/instagram-challenge/pull/140#issuecomment-162027246","issue_url":"https://api.github.com/repos/makersacademy/instagram-challenge/issues/140","id":162027246,"user":{"login":"tansaku","id":30216,"avatar_url":"https://avatars.githubusercontent.com/u/30216?v=3","gravatar_id":"","url":"https://api.github.com/users/tansaku","html_url":"https://github.com/tansaku","followers_url":"https://api.github.com/users/tansaku/followers","following_url":"https://api.github.com/users/tansaku/following{/other_user}","gists_url":"https://api.github.com/users/tansaku/gists{/gist_id}","starred_url":"https://api.github.com/users/tansaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tansaku/subscriptions","organizations_url":"https://api.github.com/users/tansaku/orgs","repos_url":"https://api.github.com/users/tansaku/repos","events_url":"https://api.github.com/users/tansaku/events{/privacy}","received_events_url":"https://api.github.com/users/tansaku/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T17:22:26Z","updated_at":"2015-12-04T17:22:26Z","body":"You had your instagram_challenge reviewed by **Adrian Booth**.\n### The good points are:\n* Consistent indentation\n* Tests DRY\n* Models appropriately tested\n* All controller methods short and succinct\n* Thin controllers with minimal logic\n\n### You should consider the following improvements:\n* Installation/Usage Instructions should be in README\n* Ensure Rakefile has Appropriate Tasks\n* Gemfile should use Test Groups\n* Ensure spec_helper.rb is Configured Correctly\n* Ensure Asset Routes are Set Correctly\n* Feature tests should be declarative, not imperative\n* Delete empty helper files\n* Use nested forms where appropriate\n* No need to set instance vars when redirecting\n* Avoid Duplicated Model Logic\n* Lack of connection between models\n* Differentiate between relative and absolute paths\n* Feature tests should use 'within' for precision\n* Tests should separate out expectations where appropriate\n* Use Asset Path correctly for Responsive Images\n* Use partials appropriately\n* Replace instance variables with local variables\n* Avoid Law of Demeter Violations\n* Prefer other Semantic HTML Elements to Divs Where Possible\n* Avoid anonymous javascript functions\n\n### Additional comments:\nNeeds a lot of work. Not fully tested and does appear slightly rushed. I'd guess with more time it could be brushed up a lot. I saw comments in the code but wasn't able to comment on pictures when I used it in the browser. But Instagram itself wasn't built in 2 days, so 48 hours isn't nearly enough time\n\nCheck out this link as it helps make more sense of Rails. This tutorial isn't test driven so don't take it too seriously, but it helps explain a few Rails concepts more clearly. \n\nhttp://www.devwalks.com/lets-build-instagram-in-rails-part-1/\n\n\nsee https://github.com/makersacademy/instagram_challenge/blob/master/docs/review.md for more details on the items above"}}