{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/8","id":41646161,"html_url":"https://github.com/ebsco/edsapi-koha-plugin/pull/8","diff_url":"https://github.com/ebsco/edsapi-koha-plugin/pull/8.diff","patch_url":"https://github.com/ebsco/edsapi-koha-plugin/pull/8.patch","issue_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues/8","number":8,"state":"closed","locked":false,"title":"Check if defaultParams is undefined before concatenating","user":{"login":"minusdavid","id":6335343,"avatar_url":"https://avatars.githubusercontent.com/u/6335343?v=3","gravatar_id":"","url":"https://api.github.com/users/minusdavid","html_url":"https://github.com/minusdavid","followers_url":"https://api.github.com/users/minusdavid/followers","following_url":"https://api.github.com/users/minusdavid/following{/other_user}","gists_url":"https://api.github.com/users/minusdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/minusdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minusdavid/subscriptions","organizations_url":"https://api.github.com/users/minusdavid/orgs","repos_url":"https://api.github.com/users/minusdavid/repos","events_url":"https://api.github.com/users/minusdavid/events{/privacy}","received_events_url":"https://api.github.com/users/minusdavid/received_events","type":"User","site_admin":false},"body":"This patch sets \"defaultParams\" to blank if it's undefined.\r\nOtherwise, if you're missing \"defaultParams\" in the\r\n\"edsConfig\" object stored in local storage, you'll get\r\nthe string \"undefined\" in your search string, which\r\ncauses it to return no search results.\r\n\r\nFor example:\r\n/plugin/Koha/Plugin/EDS/opac/eds-search.pl?q=Search?\r\nquery-1=AND,:{test}undefined&default=1\r\n\r\n_TEST PLAN_\r\n\r\nAssuming that you already have \"defaultParams\" in your local storage...\r\n\r\n0) Do a \"Discovery\" search and note that you get results\r\n1) At the \"eds-search.pl\" page, press F12\r\n2) Click on the \"Resources\" tab\r\n3) Click the arrow next to \"Local Storage\" and\r\nclick on the web address listed thre.\r\n4) Go to the \"jStorage\" key\r\n5) Right click on the value to the right of it and click\r\n\"Edit Value\"\r\n\r\n6) At this point, it would be easiest to Ctrl+A Ctrl+C,\r\nand then edit the text in a text editor.\r\n7) Search for \"defaultParams\" and remove that property\r\nfrom the object.\r\n8) Copy from the text editor back into the local storage\r\nkey-value table.\r\n9) Refresh the page\r\n10) Click \"Go\" again on your search\r\n11) Note that your URL appears as above and your\r\nsearch box will have \"undefined\" concatenated to the\r\nend of your actual search string.","created_at":"2015-08-05T06:10:16Z","updated_at":"2015-08-05T06:55:19Z","closed_at":"2015-08-05T06:55:19Z","merged_at":null,"merge_commit_sha":"ee2a645d1abb3b55b03132136b893a857c62d989","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues/8/comments","statuses_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/statuses/226b1e8d7ba1586073ea0424cbc36500628c2d08","head":{"label":"minusdavid:master","ref":"master","sha":"226b1e8d7ba1586073ea0424cbc36500628c2d08","user":{"login":"minusdavid","id":6335343,"avatar_url":"https://avatars.githubusercontent.com/u/6335343?v=3","gravatar_id":"","url":"https://api.github.com/users/minusdavid","html_url":"https://github.com/minusdavid","followers_url":"https://api.github.com/users/minusdavid/followers","following_url":"https://api.github.com/users/minusdavid/following{/other_user}","gists_url":"https://api.github.com/users/minusdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/minusdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minusdavid/subscriptions","organizations_url":"https://api.github.com/users/minusdavid/orgs","repos_url":"https://api.github.com/users/minusdavid/repos","events_url":"https://api.github.com/users/minusdavid/events{/privacy}","received_events_url":"https://api.github.com/users/minusdavid/received_events","type":"User","site_admin":false},"repo":{"id":40226808,"name":"edsapi-koha-plugin","full_name":"minusdavid/edsapi-koha-plugin","owner":{"login":"minusdavid","id":6335343,"avatar_url":"https://avatars.githubusercontent.com/u/6335343?v=3","gravatar_id":"","url":"https://api.github.com/users/minusdavid","html_url":"https://github.com/minusdavid","followers_url":"https://api.github.com/users/minusdavid/followers","following_url":"https://api.github.com/users/minusdavid/following{/other_user}","gists_url":"https://api.github.com/users/minusdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/minusdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minusdavid/subscriptions","organizations_url":"https://api.github.com/users/minusdavid/orgs","repos_url":"https://api.github.com/users/minusdavid/repos","events_url":"https://api.github.com/users/minusdavid/events{/privacy}","received_events_url":"https://api.github.com/users/minusdavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minusdavid/edsapi-koha-plugin","description":"edsapi-koha-plugin","fork":true,"url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin","forks_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/forks","keys_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/teams","hooks_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/hooks","issue_events_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/events","assignees_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/tags","blobs_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/languages","stargazers_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/stargazers","contributors_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/contributors","subscribers_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/subscribers","subscription_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/subscription","commits_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/merges","archive_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/downloads","issues_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/labels{/name}","releases_url":"https://api.github.com/repos/minusdavid/edsapi-koha-plugin/releases{/id}","created_at":"2015-08-05T05:42:59Z","updated_at":"2015-08-05T05:43:00Z","pushed_at":"2015-08-05T06:03:54Z","git_url":"git://github.com/minusdavid/edsapi-koha-plugin.git","ssh_url":"git@github.com:minusdavid/edsapi-koha-plugin.git","clone_url":"https://github.com/minusdavid/edsapi-koha-plugin.git","svn_url":"https://github.com/minusdavid/edsapi-koha-plugin","homepage":null,"size":4219,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ebsco:master","ref":"master","sha":"b6050b25de58b36ed8c5d9f7b2be5b9757860973","user":{"login":"ebsco","id":4976370,"avatar_url":"https://avatars.githubusercontent.com/u/4976370?v=3","gravatar_id":"","url":"https://api.github.com/users/ebsco","html_url":"https://github.com/ebsco","followers_url":"https://api.github.com/users/ebsco/followers","following_url":"https://api.github.com/users/ebsco/following{/other_user}","gists_url":"https://api.github.com/users/ebsco/gists{/gist_id}","starred_url":"https://api.github.com/users/ebsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebsco/subscriptions","organizations_url":"https://api.github.com/users/ebsco/orgs","repos_url":"https://api.github.com/users/ebsco/repos","events_url":"https://api.github.com/users/ebsco/events{/privacy}","received_events_url":"https://api.github.com/users/ebsco/received_events","type":"Organization","site_admin":false},"repo":{"id":22232318,"name":"edsapi-koha-plugin","full_name":"ebsco/edsapi-koha-plugin","owner":{"login":"ebsco","id":4976370,"avatar_url":"https://avatars.githubusercontent.com/u/4976370?v=3","gravatar_id":"","url":"https://api.github.com/users/ebsco","html_url":"https://github.com/ebsco","followers_url":"https://api.github.com/users/ebsco/followers","following_url":"https://api.github.com/users/ebsco/following{/other_user}","gists_url":"https://api.github.com/users/ebsco/gists{/gist_id}","starred_url":"https://api.github.com/users/ebsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebsco/subscriptions","organizations_url":"https://api.github.com/users/ebsco/orgs","repos_url":"https://api.github.com/users/ebsco/repos","events_url":"https://api.github.com/users/ebsco/events{/privacy}","received_events_url":"https://api.github.com/users/ebsco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebsco/edsapi-koha-plugin","description":"edsapi-koha-plugin","fork":false,"url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin","forks_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/forks","keys_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/teams","hooks_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/hooks","issue_events_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/events","assignees_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/tags","blobs_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/languages","stargazers_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/stargazers","contributors_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/contributors","subscribers_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/subscribers","subscription_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/subscription","commits_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/merges","archive_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/downloads","issues_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/releases{/id}","created_at":"2014-07-24T21:40:36Z","updated_at":"2015-07-07T00:35:02Z","pushed_at":"2015-08-05T06:10:16Z","git_url":"git://github.com/ebsco/edsapi-koha-plugin.git","ssh_url":"git@github.com:ebsco/edsapi-koha-plugin.git","clone_url":"https://github.com/ebsco/edsapi-koha-plugin.git","svn_url":"https://github.com/ebsco/edsapi-koha-plugin","homepage":null,"size":4219,"stargazers_count":2,"watchers_count":2,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/8"},"html":{"href":"https://github.com/ebsco/edsapi-koha-plugin/pull/8"},"issue":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues/8"},"comments":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ebsco/edsapi-koha-plugin/statuses/226b1e8d7ba1586073ea0424cbc36500628c2d08"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}