{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/35048022","id":35048022,"diff_hunk":"@@ -38,11 +39,13 @@\n /**\n  * Read data from remote data server using Netty.\n  */\n-public final class NettyRemoteBlockReader implements RemoteBlockReader {\n+public final class NettyRemoteBlockReader implements Closeable, RemoteBlockReader {","path":"clients/unshaded/src/main/java/tachyon/client/netty/NettyRemoteBlockReader.java","position":13,"original_position":13,"commit_id":"5aa46d8a98376bbd2f218386ce246437636cafe7","original_commit_id":"ccb60a872a5d850dcfab94b5acbc2462ebe5e050","user":{"login":"gpang","id":429032,"avatar_url":"https://avatars.githubusercontent.com/u/429032?v=3","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"body":"If RemoteBlockReader implements Closeable, then you don't have to check for:\r\n\r\ninstanceof NettyRemoteBlockReader\r\n\r\nwhen you close the reader.","created_at":"2015-07-20T21:43:34Z","updated_at":"2015-07-20T21:43:34Z","html_url":"https://github.com/amplab/tachyon/pull/1131#discussion_r35048022","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1131","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/35048022"},"html":{"href":"https://github.com/amplab/tachyon/pull/1131#discussion_r35048022"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1131"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1131","id":40193011,"html_url":"https://github.com/amplab/tachyon/pull/1131","diff_url":"https://github.com/amplab/tachyon/pull/1131.diff","patch_url":"https://github.com/amplab/tachyon/pull/1131.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1131","number":1131,"state":"open","locked":false,"title":"[TACHYON-639] Avoid copying ByteBuf data to DataByteBuffer in RPCBlockResponse#decode()","user":{"login":"ooq","id":5876435,"avatar_url":"https://avatars.githubusercontent.com/u/5876435?v=3","gravatar_id":"","url":"https://api.github.com/users/ooq","html_url":"https://github.com/ooq","followers_url":"https://api.github.com/users/ooq/followers","following_url":"https://api.github.com/users/ooq/following{/other_user}","gists_url":"https://api.github.com/users/ooq/gists{/gist_id}","starred_url":"https://api.github.com/users/ooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooq/subscriptions","organizations_url":"https://api.github.com/users/ooq/orgs","repos_url":"https://api.github.com/users/ooq/repos","events_url":"https://api.github.com/users/ooq/events{/privacy}","received_events_url":"https://api.github.com/users/ooq/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-639\r\n\r\n@gpang ","created_at":"2015-07-17T01:28:01Z","updated_at":"2015-07-20T21:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b74cd3d024105b6434e40844db253166840c7258","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1131/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1131/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1131/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/5aa46d8a98376bbd2f218386ce246437636cafe7","head":{"label":"ooq:TACHYON-639","ref":"TACHYON-639","sha":"5aa46d8a98376bbd2f218386ce246437636cafe7","user":{"login":"ooq","id":5876435,"avatar_url":"https://avatars.githubusercontent.com/u/5876435?v=3","gravatar_id":"","url":"https://api.github.com/users/ooq","html_url":"https://github.com/ooq","followers_url":"https://api.github.com/users/ooq/followers","following_url":"https://api.github.com/users/ooq/following{/other_user}","gists_url":"https://api.github.com/users/ooq/gists{/gist_id}","starred_url":"https://api.github.com/users/ooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooq/subscriptions","organizations_url":"https://api.github.com/users/ooq/orgs","repos_url":"https://api.github.com/users/ooq/repos","events_url":"https://api.github.com/users/ooq/events{/privacy}","received_events_url":"https://api.github.com/users/ooq/received_events","type":"User","site_admin":false},"repo":{"id":14292154,"name":"tachyon","full_name":"ooq/tachyon","owner":{"login":"ooq","id":5876435,"avatar_url":"https://avatars.githubusercontent.com/u/5876435?v=3","gravatar_id":"","url":"https://api.github.com/users/ooq","html_url":"https://github.com/ooq","followers_url":"https://api.github.com/users/ooq/followers","following_url":"https://api.github.com/users/ooq/following{/other_user}","gists_url":"https://api.github.com/users/ooq/gists{/gist_id}","starred_url":"https://api.github.com/users/ooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooq/subscriptions","organizations_url":"https://api.github.com/users/ooq/orgs","repos_url":"https://api.github.com/users/ooq/repos","events_url":"https://api.github.com/users/ooq/events{/privacy}","received_events_url":"https://api.github.com/users/ooq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ooq/tachyon","description":"Reliable File Sharing at Memory Speed Across Cluster Frameworks","fork":true,"url":"https://api.github.com/repos/ooq/tachyon","forks_url":"https://api.github.com/repos/ooq/tachyon/forks","keys_url":"https://api.github.com/repos/ooq/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooq/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooq/tachyon/teams","hooks_url":"https://api.github.com/repos/ooq/tachyon/hooks","issue_events_url":"https://api.github.com/repos/ooq/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/ooq/tachyon/events","assignees_url":"https://api.github.com/repos/ooq/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/ooq/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/ooq/tachyon/tags","blobs_url":"https://api.github.com/repos/ooq/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooq/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooq/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooq/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooq/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/ooq/tachyon/languages","stargazers_url":"https://api.github.com/repos/ooq/tachyon/stargazers","contributors_url":"https://api.github.com/repos/ooq/tachyon/contributors","subscribers_url":"https://api.github.com/repos/ooq/tachyon/subscribers","subscription_url":"https://api.github.com/repos/ooq/tachyon/subscription","commits_url":"https://api.github.com/repos/ooq/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooq/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooq/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooq/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooq/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/ooq/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooq/tachyon/merges","archive_url":"https://api.github.com/repos/ooq/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooq/tachyon/downloads","issues_url":"https://api.github.com/repos/ooq/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/ooq/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/ooq/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/ooq/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooq/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/ooq/tachyon/releases{/id}","created_at":"2013-11-11T05:13:26Z","updated_at":"2015-02-22T19:32:20Z","pushed_at":"2015-07-20T21:17:15Z","git_url":"git://github.com/ooq/tachyon.git","ssh_url":"git@github.com:ooq/tachyon.git","clone_url":"https://github.com/ooq/tachyon.git","svn_url":"https://github.com/ooq/tachyon","homepage":"http://tachyon-project.org","size":14810,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"f9bfdf0e72f7433d177ee7fe1d5fdc408e1eabec","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-07-20T13:49:09Z","pushed_at":"2015-07-20T21:17:17Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":35908,"stargazers_count":1480,"watchers_count":1480,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":561,"mirror_url":null,"open_issues_count":21,"forks":561,"open_issues":21,"watchers":1480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1131"},"html":{"href":"https://github.com/amplab/tachyon/pull/1131"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1131"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1131/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1131/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1131/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/5aa46d8a98376bbd2f218386ce246437636cafe7"}}}}