{"action":"created","issue":{"url":"https://api.github.com/repos/shellinabox/shellinabox/issues/338","labels_url":"https://api.github.com/repos/shellinabox/shellinabox/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/shellinabox/shellinabox/issues/338/comments","events_url":"https://api.github.com/repos/shellinabox/shellinabox/issues/338/events","html_url":"https://github.com/shellinabox/shellinabox/pull/338","id":103567261,"number":338,"title":"Kill children with HUP instead of TERM at end of session","user":{"login":"BenjiWiebe","id":6827166,"avatar_url":"https://avatars.githubusercontent.com/u/6827166?v=3","gravatar_id":"","url":"https://api.github.com/users/BenjiWiebe","html_url":"https://github.com/BenjiWiebe","followers_url":"https://api.github.com/users/BenjiWiebe/followers","following_url":"https://api.github.com/users/BenjiWiebe/following{/other_user}","gists_url":"https://api.github.com/users/BenjiWiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjiWiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjiWiebe/subscriptions","organizations_url":"https://api.github.com/users/BenjiWiebe/orgs","repos_url":"https://api.github.com/users/BenjiWiebe/repos","events_url":"https://api.github.com/users/BenjiWiebe/events{/privacy}","received_events_url":"https://api.github.com/users/BenjiWiebe/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-08-27T18:27:16Z","updated_at":"2015-08-27T21:50:06Z","closed_at":"2015-08-27T21:49:37Z","pull_request":{"url":"https://api.github.com/repos/shellinabox/shellinabox/pulls/338","html_url":"https://github.com/shellinabox/shellinabox/pull/338","diff_url":"https://github.com/shellinabox/shellinabox/pull/338.diff","patch_url":"https://github.com/shellinabox/shellinabox/pull/338.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/shellinabox/shellinabox/issues/comments/135565471","html_url":"https://github.com/shellinabox/shellinabox/pull/338#issuecomment-135565471","issue_url":"https://api.github.com/repos/shellinabox/shellinabox/issues/338","id":135565471,"user":{"login":"KLuka","id":1918763,"avatar_url":"https://avatars.githubusercontent.com/u/1918763?v=3","gravatar_id":"","url":"https://api.github.com/users/KLuka","html_url":"https://github.com/KLuka","followers_url":"https://api.github.com/users/KLuka/followers","following_url":"https://api.github.com/users/KLuka/following{/other_user}","gists_url":"https://api.github.com/users/KLuka/gists{/gist_id}","starred_url":"https://api.github.com/users/KLuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KLuka/subscriptions","organizations_url":"https://api.github.com/users/KLuka/orgs","repos_url":"https://api.github.com/users/KLuka/repos","events_url":"https://api.github.com/users/KLuka/events{/privacy}","received_events_url":"https://api.github.com/users/KLuka/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T21:50:06Z","updated_at":"2015-08-27T21:50:06Z","body":"Great solution :+1: I tested it also with SSH and LOGIN service. Thanks you for your patches.\r\n\r\nI also noticed that when using LOGIN service with sudo command `kill()` function returns an error (as it should) but the child exits anyway. Do you have any clue what is happening here? This may actually be the complete solution for #103 :smile: \r\n\r\n```\r\n[server] Command line:  ./shellinaboxd -d -u shellinabox -g shellinabox -t -s /:LOGIN -p 5002\r\n...\r\n[server] Timeout. Closing session!\r\n[server] Session c-dwj7RG7UaxeeXCXbR8mw done.\r\n[server] Terminating child 25712 failed! [Operation not permitted]\r\n[server] Child 25712 exited with exit code 0.\r\n[server] Timeout. Closing session!\r\n[server] Session T8hUwBayoSkWyrJYoXy/NA done.\r\n[server] Terminating child 25713 failed! [Operation not permitted]\r\n```\r\n\r\nLOGIN processes, before they were killed:\r\n```\r\n4     0 25712 25709  20   0   4600  3636 wait   Ss   pts/15     0:00 login -p -h luka-pc\r\n4     0 25713 25709  20   0   4600  3644 wait   Ss   pts/16     0:00 login -p -h luka-pc\r\n```\r\n\r\n"}}