{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/26082884","id":26082884,"diff_hunk":"@@ -489,7 +489,12 @@ func TestOverrideSubject(t *testing.T) {\n \n \ts := newCustomSigner(t, testECDSACaFile, testECDSACaKeyFile)\n \n-\tcertPEM, err := s.Sign(signer.SignRequest{Hostname: \"localhost\", Request: string(csrPEM), Subject: req})\n+\tcertPEM, err := s.Sign(signer.SignRequest{\n+\t\tHosts:   []string{\"127.0.0.1\", \"localhost\"},\n+\t\tRequest: string(csrPEM),\n+\t\tSubject: req,\n+\t})\n+","path":"signer/local/local_test.go","position":102,"original_position":102,"commit_id":"e9d5a2c101288a25db21aa3878e617beca13ba97","original_commit_id":"e9d5a2c101288a25db21aa3878e617beca13ba97","user":{"login":"kisom","id":175578,"avatar_url":"https://avatars.githubusercontent.com/u/175578?v=3","gravatar_id":"","url":"https://api.github.com/users/kisom","html_url":"https://github.com/kisom","followers_url":"https://api.github.com/users/kisom/followers","following_url":"https://api.github.com/users/kisom/following{/other_user}","gists_url":"https://api.github.com/users/kisom/gists{/gist_id}","starred_url":"https://api.github.com/users/kisom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kisom/subscriptions","organizations_url":"https://api.github.com/users/kisom/orgs","repos_url":"https://api.github.com/users/kisom/repos","events_url":"https://api.github.com/users/kisom/events{/privacy}","received_events_url":"https://api.github.com/users/kisom/received_events","type":"User","site_admin":false},"body":"helpers.ParseCertificatePEM should do the trick.","created_at":"2015-03-09T22:23:38Z","updated_at":"2015-03-09T22:23:38Z","html_url":"https://github.com/cloudflare/cfssl/pull/118#discussion_r26082884","pull_request_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/26082884"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/118#discussion_r26082884"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/118","id":30192190,"html_url":"https://github.com/cloudflare/cfssl/pull/118","diff_url":"https://github.com/cloudflare/cfssl/pull/118.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/118.patch","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/118","number":118,"state":"open","locked":false,"title":"Multiple hostnames","user":{"login":"dr107","id":3991437,"avatar_url":"https://avatars.githubusercontent.com/u/3991437?v=3","gravatar_id":"","url":"https://api.github.com/users/dr107","html_url":"https://github.com/dr107","followers_url":"https://api.github.com/users/dr107/followers","following_url":"https://api.github.com/users/dr107/following{/other_user}","gists_url":"https://api.github.com/users/dr107/gists{/gist_id}","starred_url":"https://api.github.com/users/dr107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr107/subscriptions","organizations_url":"https://api.github.com/users/dr107/orgs","repos_url":"https://api.github.com/users/dr107/repos","events_url":"https://api.github.com/users/dr107/events{/privacy}","received_events_url":"https://api.github.com/users/dr107/received_events","type":"User","site_admin":false},"body":"Change the cli to accept multiple hostnames on the command line.\r\n\r\nTODO:\r\n\tadd tests\r\n\tupdate documentation","created_at":"2015-02-27T19:12:22Z","updated_at":"2015-03-09T22:23:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d9bc09c8ed5940ca238f041f6a7ae3af533f708","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/118/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/118/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/118/comments","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/e9d5a2c101288a25db21aa3878e617beca13ba97","head":{"label":"dr107:dan/signer_multiple_hostnames","ref":"dan/signer_multiple_hostnames","sha":"e9d5a2c101288a25db21aa3878e617beca13ba97","user":{"login":"dr107","id":3991437,"avatar_url":"https://avatars.githubusercontent.com/u/3991437?v=3","gravatar_id":"","url":"https://api.github.com/users/dr107","html_url":"https://github.com/dr107","followers_url":"https://api.github.com/users/dr107/followers","following_url":"https://api.github.com/users/dr107/following{/other_user}","gists_url":"https://api.github.com/users/dr107/gists{/gist_id}","starred_url":"https://api.github.com/users/dr107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr107/subscriptions","organizations_url":"https://api.github.com/users/dr107/orgs","repos_url":"https://api.github.com/users/dr107/repos","events_url":"https://api.github.com/users/dr107/events{/privacy}","received_events_url":"https://api.github.com/users/dr107/received_events","type":"User","site_admin":false},"repo":{"id":30153690,"name":"cfssl","full_name":"dr107/cfssl","owner":{"login":"dr107","id":3991437,"avatar_url":"https://avatars.githubusercontent.com/u/3991437?v=3","gravatar_id":"","url":"https://api.github.com/users/dr107","html_url":"https://github.com/dr107","followers_url":"https://api.github.com/users/dr107/followers","following_url":"https://api.github.com/users/dr107/following{/other_user}","gists_url":"https://api.github.com/users/dr107/gists{/gist_id}","starred_url":"https://api.github.com/users/dr107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr107/subscriptions","organizations_url":"https://api.github.com/users/dr107/orgs","repos_url":"https://api.github.com/users/dr107/repos","events_url":"https://api.github.com/users/dr107/events{/privacy}","received_events_url":"https://api.github.com/users/dr107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dr107/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":true,"url":"https://api.github.com/repos/dr107/cfssl","forks_url":"https://api.github.com/repos/dr107/cfssl/forks","keys_url":"https://api.github.com/repos/dr107/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dr107/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dr107/cfssl/teams","hooks_url":"https://api.github.com/repos/dr107/cfssl/hooks","issue_events_url":"https://api.github.com/repos/dr107/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/dr107/cfssl/events","assignees_url":"https://api.github.com/repos/dr107/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/dr107/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/dr107/cfssl/tags","blobs_url":"https://api.github.com/repos/dr107/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dr107/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dr107/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/dr107/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dr107/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/dr107/cfssl/languages","stargazers_url":"https://api.github.com/repos/dr107/cfssl/stargazers","contributors_url":"https://api.github.com/repos/dr107/cfssl/contributors","subscribers_url":"https://api.github.com/repos/dr107/cfssl/subscribers","subscription_url":"https://api.github.com/repos/dr107/cfssl/subscription","commits_url":"https://api.github.com/repos/dr107/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/dr107/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/dr107/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/dr107/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/dr107/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/dr107/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dr107/cfssl/merges","archive_url":"https://api.github.com/repos/dr107/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dr107/cfssl/downloads","issues_url":"https://api.github.com/repos/dr107/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/dr107/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/dr107/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/dr107/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dr107/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/dr107/cfssl/releases{/id}","created_at":"2015-02-01T17:39:59Z","updated_at":"2015-02-20T00:49:26Z","pushed_at":"2015-03-07T16:57:20Z","git_url":"git://github.com/dr107/cfssl.git","ssh_url":"git@github.com:dr107/cfssl.git","clone_url":"https://github.com/dr107/cfssl.git","svn_url":"https://github.com/dr107/cfssl","homepage":"https://blog.cloudflare.com/introducing-cfssl","size":1437,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"fa2257d82c1486d6da8577b4c194003729626275","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":21591001,"name":"cfssl","full_name":"cloudflare/cfssl","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":false,"url":"https://api.github.com/repos/cloudflare/cfssl","forks_url":"https://api.github.com/repos/cloudflare/cfssl/forks","keys_url":"https://api.github.com/repos/cloudflare/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cfssl/teams","hooks_url":"https://api.github.com/repos/cloudflare/cfssl/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cfssl/events","assignees_url":"https://api.github.com/repos/cloudflare/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cfssl/tags","blobs_url":"https://api.github.com/repos/cloudflare/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cfssl/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cfssl/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cfssl/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cfssl/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cfssl/subscription","commits_url":"https://api.github.com/repos/cloudflare/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cfssl/merges","archive_url":"https://api.github.com/repos/cloudflare/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cfssl/downloads","issues_url":"https://api.github.com/repos/cloudflare/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cfssl/releases{/id}","created_at":"2014-07-07T23:49:12Z","updated_at":"2015-03-09T20:17:59Z","pushed_at":"2015-03-09T19:36:50Z","git_url":"git://github.com/cloudflare/cfssl.git","ssh_url":"git@github.com:cloudflare/cfssl.git","clone_url":"https://github.com/cloudflare/cfssl.git","svn_url":"https://github.com/cloudflare/cfssl","homepage":"https://blog.cloudflare.com/introducing-cfssl","size":5029,"stargazers_count":479,"watchers_count":479,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":24,"forks":38,"open_issues":24,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/118"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/118"},"issue":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/118"},"comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cfssl/statuses/e9d5a2c101288a25db21aa3878e617beca13ba97"}}}}