{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/24231276","id":24231276,"diff_hunk":"@@ -431,18 +436,20 @@ public SubsystemRegistration registerSubsystem(String name, int majorVersion, in\n \n         @Override\n         public SubsystemRegistration registerSubsystem(String name, int majorVersion, int minorVersion, int microVersion, boolean deprecated) {\n+            return registerSubsystem(name, ModelVersion.create(majorVersion, minorVersion, microVersion), deprecated);\n+        }\n+\n+        public SubsystemRegistration registerSubsystem(String name, ModelVersion version, boolean deprecated) {\n             assert name != null : \"name is null\";\n             checkNewSubystem(extension.extensionModuleName, name);\n             SubsystemInformationImpl info = extension.getSubsystemInfo(name);\n-            info.setMajorVersion(majorVersion);\n-            info.setMinorVersion(minorVersion);\n-            info.setMicroVersion(microVersion);\n+            info.setVersion(version);","path":"controller/src/main/java/org/jboss/as/controller/extension/ExtensionRegistry.java","position":26,"original_position":26,"commit_id":"2469401134433a8d1c16cd851e72a546a2abc5d3","original_commit_id":"2469401134433a8d1c16cd851e72a546a2abc5d3","user":{"login":"kabir","id":49927,"avatar_url":"https://avatars.githubusercontent.com/u/49927?v=3","gravatar_id":"","url":"https://api.github.com/users/kabir","html_url":"https://github.com/kabir","followers_url":"https://api.github.com/users/kabir/followers","following_url":"https://api.github.com/users/kabir/following{/other_user}","gists_url":"https://api.github.com/users/kabir/gists{/gist_id}","starred_url":"https://api.github.com/users/kabir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabir/subscriptions","organizations_url":"https://api.github.com/users/kabir/orgs","repos_url":"https://api.github.com/users/kabir/repos","events_url":"https://api.github.com/users/kabir/events{/privacy}","received_events_url":"https://api.github.com/users/kabir/received_events","type":"User","site_admin":false},"body":"I think I would throw an exception if version is null, and get rid of the null checks in SubsystemInformationImpl","created_at":"2015-02-06T09:56:32Z","updated_at":"2015-02-06T09:56:32Z","html_url":"https://github.com/wildfly/wildfly-core/pull/473#discussion_r24231276","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/24231276"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/473#discussion_r24231276"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473","id":28720396,"html_url":"https://github.com/wildfly/wildfly-core/pull/473","diff_url":"https://github.com/wildfly/wildfly-core/pull/473.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/473.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/473","number":473,"state":"open","locked":false,"title":"[WFCORE-531] Update subsystem registration to use a ModelVersion instead of the component parts of the version.","user":{"login":"darranl","id":481922,"avatar_url":"https://avatars.githubusercontent.com/u/481922?v=3","gravatar_id":"","url":"https://api.github.com/users/darranl","html_url":"https://github.com/darranl","followers_url":"https://api.github.com/users/darranl/followers","following_url":"https://api.github.com/users/darranl/following{/other_user}","gists_url":"https://api.github.com/users/darranl/gists{/gist_id}","starred_url":"https://api.github.com/users/darranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darranl/subscriptions","organizations_url":"https://api.github.com/users/darranl/orgs","repos_url":"https://api.github.com/users/darranl/repos","events_url":"https://api.github.com/users/darranl/events{/privacy}","received_events_url":"https://api.github.com/users/darranl/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-05T12:25:56Z","updated_at":"2015-02-06T09:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e89580b30643156c970390e25f26d27c413877e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/473/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/2469401134433a8d1c16cd851e72a546a2abc5d3","head":{"label":"darranl:WFCORE-531","ref":"WFCORE-531","sha":"2469401134433a8d1c16cd851e72a546a2abc5d3","user":{"login":"darranl","id":481922,"avatar_url":"https://avatars.githubusercontent.com/u/481922?v=3","gravatar_id":"","url":"https://api.github.com/users/darranl","html_url":"https://github.com/darranl","followers_url":"https://api.github.com/users/darranl/followers","following_url":"https://api.github.com/users/darranl/following{/other_user}","gists_url":"https://api.github.com/users/darranl/gists{/gist_id}","starred_url":"https://api.github.com/users/darranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darranl/subscriptions","organizations_url":"https://api.github.com/users/darranl/orgs","repos_url":"https://api.github.com/users/darranl/repos","events_url":"https://api.github.com/users/darranl/events{/privacy}","received_events_url":"https://api.github.com/users/darranl/received_events","type":"User","site_admin":false},"repo":{"id":21458662,"name":"wildfly-core","full_name":"darranl/wildfly-core","owner":{"login":"darranl","id":481922,"avatar_url":"https://avatars.githubusercontent.com/u/481922?v=3","gravatar_id":"","url":"https://api.github.com/users/darranl","html_url":"https://github.com/darranl","followers_url":"https://api.github.com/users/darranl/followers","following_url":"https://api.github.com/users/darranl/following{/other_user}","gists_url":"https://api.github.com/users/darranl/gists{/gist_id}","starred_url":"https://api.github.com/users/darranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darranl/subscriptions","organizations_url":"https://api.github.com/users/darranl/orgs","repos_url":"https://api.github.com/users/darranl/repos","events_url":"https://api.github.com/users/darranl/events{/privacy}","received_events_url":"https://api.github.com/users/darranl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darranl/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/darranl/wildfly-core","forks_url":"https://api.github.com/repos/darranl/wildfly-core/forks","keys_url":"https://api.github.com/repos/darranl/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darranl/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darranl/wildfly-core/teams","hooks_url":"https://api.github.com/repos/darranl/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/darranl/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/darranl/wildfly-core/events","assignees_url":"https://api.github.com/repos/darranl/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/darranl/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/darranl/wildfly-core/tags","blobs_url":"https://api.github.com/repos/darranl/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darranl/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darranl/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/darranl/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darranl/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/darranl/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/darranl/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/darranl/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/darranl/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/darranl/wildfly-core/subscription","commits_url":"https://api.github.com/repos/darranl/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/darranl/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/darranl/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/darranl/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/darranl/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/darranl/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darranl/wildfly-core/merges","archive_url":"https://api.github.com/repos/darranl/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darranl/wildfly-core/downloads","issues_url":"https://api.github.com/repos/darranl/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/darranl/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/darranl/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/darranl/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darranl/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/darranl/wildfly-core/releases{/id}","created_at":"2014-07-03T10:22:44Z","updated_at":"2015-02-04T08:19:50Z","pushed_at":"2015-02-05T15:24:28Z","git_url":"git://github.com/darranl/wildfly-core.git","ssh_url":"git@github.com:darranl/wildfly-core.git","clone_url":"https://github.com/darranl/wildfly-core.git","svn_url":"https://github.com/darranl/wildfly-core","homepage":null,"size":36943,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"c8791a3fab55c7ef94bb32135cf05a1a8f7797a4","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2015-02-04T23:19:18Z","pushed_at":"2015-02-04T23:19:18Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":41474,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":19,"forks":93,"open_issues":19,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/473"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/473"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/2469401134433a8d1c16cd851e72a546a2abc5d3"}}}}