{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/evdb/HTTP-Async/pulls/11","id":36563497,"html_url":"https://github.com/evdb/HTTP-Async/pull/11","diff_url":"https://github.com/evdb/HTTP-Async/pull/11.diff","patch_url":"https://github.com/evdb/HTTP-Async/pull/11.patch","issue_url":"https://api.github.com/repos/evdb/HTTP-Async/issues/11","number":11,"state":"closed","locked":false,"title":"Make add_with_opts throw error on invalid options.","user":{"login":"tgt","id":472609,"avatar_url":"https://avatars.githubusercontent.com/u/472609?v=3","gravatar_id":"","url":"https://api.github.com/users/tgt","html_url":"https://github.com/tgt","followers_url":"https://api.github.com/users/tgt/followers","following_url":"https://api.github.com/users/tgt/following{/other_user}","gists_url":"https://api.github.com/users/tgt/gists{/gist_id}","starred_url":"https://api.github.com/users/tgt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgt/subscriptions","organizations_url":"https://api.github.com/users/tgt/orgs","repos_url":"https://api.github.com/users/tgt/repos","events_url":"https://api.github.com/users/tgt/events{/privacy}","received_events_url":"https://api.github.com/users/tgt/received_events","type":"User","site_admin":false},"body":"The new method throws an error when it receives an invalid option, but the add_with_opts method did not. This caught me out when I accidentally passed proxy_address and proxy_port rather than proxy_host and proxy_port to it. This resulted in it attempting to treat the host of my request as the proxy and hanging until the request timed out.","created_at":"2015-05-30T10:18:43Z","updated_at":"2015-05-30T10:22:23Z","closed_at":"2015-05-30T10:22:23Z","merged_at":"2015-05-30T10:22:23Z","merge_commit_sha":"f34306995ba88e6ec3995e5e973b3398dab74c1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/evdb/HTTP-Async/pulls/11/commits","review_comments_url":"https://api.github.com/repos/evdb/HTTP-Async/pulls/11/comments","review_comment_url":"https://api.github.com/repos/evdb/HTTP-Async/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evdb/HTTP-Async/issues/11/comments","statuses_url":"https://api.github.com/repos/evdb/HTTP-Async/statuses/49fbf09b949ffa55fec66735d43908b975394c49","head":{"label":"tgt:master","ref":"master","sha":"49fbf09b949ffa55fec66735d43908b975394c49","user":{"login":"tgt","id":472609,"avatar_url":"https://avatars.githubusercontent.com/u/472609?v=3","gravatar_id":"","url":"https://api.github.com/users/tgt","html_url":"https://github.com/tgt","followers_url":"https://api.github.com/users/tgt/followers","following_url":"https://api.github.com/users/tgt/following{/other_user}","gists_url":"https://api.github.com/users/tgt/gists{/gist_id}","starred_url":"https://api.github.com/users/tgt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgt/subscriptions","organizations_url":"https://api.github.com/users/tgt/orgs","repos_url":"https://api.github.com/users/tgt/repos","events_url":"https://api.github.com/users/tgt/events{/privacy}","received_events_url":"https://api.github.com/users/tgt/received_events","type":"User","site_admin":false},"repo":{"id":36552906,"name":"HTTP-Async","full_name":"tgt/HTTP-Async","owner":{"login":"tgt","id":472609,"avatar_url":"https://avatars.githubusercontent.com/u/472609?v=3","gravatar_id":"","url":"https://api.github.com/users/tgt","html_url":"https://github.com/tgt","followers_url":"https://api.github.com/users/tgt/followers","following_url":"https://api.github.com/users/tgt/following{/other_user}","gists_url":"https://api.github.com/users/tgt/gists{/gist_id}","starred_url":"https://api.github.com/users/tgt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgt/subscriptions","organizations_url":"https://api.github.com/users/tgt/orgs","repos_url":"https://api.github.com/users/tgt/repos","events_url":"https://api.github.com/users/tgt/events{/privacy}","received_events_url":"https://api.github.com/users/tgt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgt/HTTP-Async","description":"process multiple HTTP requests in parallel without blocking","fork":true,"url":"https://api.github.com/repos/tgt/HTTP-Async","forks_url":"https://api.github.com/repos/tgt/HTTP-Async/forks","keys_url":"https://api.github.com/repos/tgt/HTTP-Async/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgt/HTTP-Async/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgt/HTTP-Async/teams","hooks_url":"https://api.github.com/repos/tgt/HTTP-Async/hooks","issue_events_url":"https://api.github.com/repos/tgt/HTTP-Async/issues/events{/number}","events_url":"https://api.github.com/repos/tgt/HTTP-Async/events","assignees_url":"https://api.github.com/repos/tgt/HTTP-Async/assignees{/user}","branches_url":"https://api.github.com/repos/tgt/HTTP-Async/branches{/branch}","tags_url":"https://api.github.com/repos/tgt/HTTP-Async/tags","blobs_url":"https://api.github.com/repos/tgt/HTTP-Async/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgt/HTTP-Async/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgt/HTTP-Async/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgt/HTTP-Async/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgt/HTTP-Async/statuses/{sha}","languages_url":"https://api.github.com/repos/tgt/HTTP-Async/languages","stargazers_url":"https://api.github.com/repos/tgt/HTTP-Async/stargazers","contributors_url":"https://api.github.com/repos/tgt/HTTP-Async/contributors","subscribers_url":"https://api.github.com/repos/tgt/HTTP-Async/subscribers","subscription_url":"https://api.github.com/repos/tgt/HTTP-Async/subscription","commits_url":"https://api.github.com/repos/tgt/HTTP-Async/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgt/HTTP-Async/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgt/HTTP-Async/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgt/HTTP-Async/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgt/HTTP-Async/contents/{+path}","compare_url":"https://api.github.com/repos/tgt/HTTP-Async/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgt/HTTP-Async/merges","archive_url":"https://api.github.com/repos/tgt/HTTP-Async/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgt/HTTP-Async/downloads","issues_url":"https://api.github.com/repos/tgt/HTTP-Async/issues{/number}","pulls_url":"https://api.github.com/repos/tgt/HTTP-Async/pulls{/number}","milestones_url":"https://api.github.com/repos/tgt/HTTP-Async/milestones{/number}","notifications_url":"https://api.github.com/repos/tgt/HTTP-Async/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgt/HTTP-Async/labels{/name}","releases_url":"https://api.github.com/repos/tgt/HTTP-Async/releases{/id}","created_at":"2015-05-30T10:02:49Z","updated_at":"2015-05-30T10:02:49Z","pushed_at":"2015-05-30T10:15:32Z","git_url":"git://github.com/tgt/HTTP-Async.git","ssh_url":"git@github.com:tgt/HTTP-Async.git","clone_url":"https://github.com/tgt/HTTP-Async.git","svn_url":"https://github.com/tgt/HTTP-Async","homepage":"http://search.cpan.org/dist/HTTP-Async/lib/HTTP/Async.pm","size":353,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"evdb:master","ref":"master","sha":"29b19144747d1877807efe5e6015bfc3307ccb9f","user":{"login":"evdb","id":187630,"avatar_url":"https://avatars.githubusercontent.com/u/187630?v=3","gravatar_id":"","url":"https://api.github.com/users/evdb","html_url":"https://github.com/evdb","followers_url":"https://api.github.com/users/evdb/followers","following_url":"https://api.github.com/users/evdb/following{/other_user}","gists_url":"https://api.github.com/users/evdb/gists{/gist_id}","starred_url":"https://api.github.com/users/evdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evdb/subscriptions","organizations_url":"https://api.github.com/users/evdb/orgs","repos_url":"https://api.github.com/users/evdb/repos","events_url":"https://api.github.com/users/evdb/events{/privacy}","received_events_url":"https://api.github.com/users/evdb/received_events","type":"User","site_admin":false},"repo":{"id":1545386,"name":"HTTP-Async","full_name":"evdb/HTTP-Async","owner":{"login":"evdb","id":187630,"avatar_url":"https://avatars.githubusercontent.com/u/187630?v=3","gravatar_id":"","url":"https://api.github.com/users/evdb","html_url":"https://github.com/evdb","followers_url":"https://api.github.com/users/evdb/followers","following_url":"https://api.github.com/users/evdb/following{/other_user}","gists_url":"https://api.github.com/users/evdb/gists{/gist_id}","starred_url":"https://api.github.com/users/evdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evdb/subscriptions","organizations_url":"https://api.github.com/users/evdb/orgs","repos_url":"https://api.github.com/users/evdb/repos","events_url":"https://api.github.com/users/evdb/events{/privacy}","received_events_url":"https://api.github.com/users/evdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evdb/HTTP-Async","description":"process multiple HTTP requests in parallel without blocking","fork":false,"url":"https://api.github.com/repos/evdb/HTTP-Async","forks_url":"https://api.github.com/repos/evdb/HTTP-Async/forks","keys_url":"https://api.github.com/repos/evdb/HTTP-Async/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evdb/HTTP-Async/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evdb/HTTP-Async/teams","hooks_url":"https://api.github.com/repos/evdb/HTTP-Async/hooks","issue_events_url":"https://api.github.com/repos/evdb/HTTP-Async/issues/events{/number}","events_url":"https://api.github.com/repos/evdb/HTTP-Async/events","assignees_url":"https://api.github.com/repos/evdb/HTTP-Async/assignees{/user}","branches_url":"https://api.github.com/repos/evdb/HTTP-Async/branches{/branch}","tags_url":"https://api.github.com/repos/evdb/HTTP-Async/tags","blobs_url":"https://api.github.com/repos/evdb/HTTP-Async/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evdb/HTTP-Async/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evdb/HTTP-Async/git/refs{/sha}","trees_url":"https://api.github.com/repos/evdb/HTTP-Async/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evdb/HTTP-Async/statuses/{sha}","languages_url":"https://api.github.com/repos/evdb/HTTP-Async/languages","stargazers_url":"https://api.github.com/repos/evdb/HTTP-Async/stargazers","contributors_url":"https://api.github.com/repos/evdb/HTTP-Async/contributors","subscribers_url":"https://api.github.com/repos/evdb/HTTP-Async/subscribers","subscription_url":"https://api.github.com/repos/evdb/HTTP-Async/subscription","commits_url":"https://api.github.com/repos/evdb/HTTP-Async/commits{/sha}","git_commits_url":"https://api.github.com/repos/evdb/HTTP-Async/git/commits{/sha}","comments_url":"https://api.github.com/repos/evdb/HTTP-Async/comments{/number}","issue_comment_url":"https://api.github.com/repos/evdb/HTTP-Async/issues/comments{/number}","contents_url":"https://api.github.com/repos/evdb/HTTP-Async/contents/{+path}","compare_url":"https://api.github.com/repos/evdb/HTTP-Async/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evdb/HTTP-Async/merges","archive_url":"https://api.github.com/repos/evdb/HTTP-Async/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evdb/HTTP-Async/downloads","issues_url":"https://api.github.com/repos/evdb/HTTP-Async/issues{/number}","pulls_url":"https://api.github.com/repos/evdb/HTTP-Async/pulls{/number}","milestones_url":"https://api.github.com/repos/evdb/HTTP-Async/milestones{/number}","notifications_url":"https://api.github.com/repos/evdb/HTTP-Async/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evdb/HTTP-Async/labels{/name}","releases_url":"https://api.github.com/repos/evdb/HTTP-Async/releases{/id}","created_at":"2011-03-30T08:48:42Z","updated_at":"2015-03-09T08:22:10Z","pushed_at":"2015-05-30T10:22:23Z","git_url":"git://github.com/evdb/HTTP-Async.git","ssh_url":"git@github.com:evdb/HTTP-Async.git","clone_url":"https://github.com/evdb/HTTP-Async.git","svn_url":"https://github.com/evdb/HTTP-Async","homepage":"http://search.cpan.org/dist/HTTP-Async/lib/HTTP/Async.pm","size":353,"stargazers_count":6,"watchers_count":6,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evdb/HTTP-Async/pulls/11"},"html":{"href":"https://github.com/evdb/HTTP-Async/pull/11"},"issue":{"href":"https://api.github.com/repos/evdb/HTTP-Async/issues/11"},"comments":{"href":"https://api.github.com/repos/evdb/HTTP-Async/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/evdb/HTTP-Async/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/evdb/HTTP-Async/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evdb/HTTP-Async/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/evdb/HTTP-Async/statuses/49fbf09b949ffa55fec66735d43908b975394c49"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kaoru","id":89070,"avatar_url":"https://avatars.githubusercontent.com/u/89070?v=3","gravatar_id":"","url":"https://api.github.com/users/kaoru","html_url":"https://github.com/kaoru","followers_url":"https://api.github.com/users/kaoru/followers","following_url":"https://api.github.com/users/kaoru/following{/other_user}","gists_url":"https://api.github.com/users/kaoru/gists{/gist_id}","starred_url":"https://api.github.com/users/kaoru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaoru/subscriptions","organizations_url":"https://api.github.com/users/kaoru/orgs","repos_url":"https://api.github.com/users/kaoru/repos","events_url":"https://api.github.com/users/kaoru/events{/privacy}","received_events_url":"https://api.github.com/users/kaoru/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":48,"deletions":1,"changed_files":2}}