{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/comments/45832848","id":45832848,"diff_hunk":"@@ -0,0 +1,79 @@\n+# This recipe doesn't do anything other than deal with SSL keys and certificates.\n+# Everything else for civetweb setup is in conf.rb.  It could arguably be merged\n+# into radosgw.rb; it only exists as a separate file because it used to be\n+# radosgw_apache2.rb\n+\n+if node[\"ceph\"][\"radosgw\"][\"ssl\"][\"enabled\"]\n+  certfile      = node[\"ceph\"][\"radosgw\"][\"ssl\"][\"certfile\"]\n+  keyfile       = node[\"ceph\"][\"radosgw\"][\"ssl\"][\"keyfile\"]\n+  pemfile       = node[\"ceph\"][\"radosgw\"][\"ssl\"][\"pemfile\"]\n+  if  node[\"ceph\"][\"radosgw\"][\"ssl\"][\"generate_certs\"]\n+    package \"openssl\"\n+    ruby_block \"generate_certs for radosgw\" do\n+        block do\n+          unless ::File.exists? certfile and ::File.exists? keyfile\n+            require \"fileutils\"\n+\n+            Chef::Log.info(\"Generating SSL certificate for radosgw...\")\n+\n+            [:certfile, :keyfile].each do |k|\n+              dir = File.dirname(node[:ceph][:radosgw][:ssl][k])\n+              FileUtils.mkdir_p(dir) unless File.exists?(dir)","path":"chef/cookbooks/ceph/recipes/radosgw_civetweb.rb","position":21,"original_position":21,"commit_id":"47f25f42bf46b2bc2e1be5011577e1ec33548f26","original_commit_id":"47f25f42bf46b2bc2e1be5011577e1ec33548f26","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Lint/DeprecatedClassMethods: `File.exists?` is deprecated in favor of `File.exist?`.<br>Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)","created_at":"2015-11-25T06:19:50Z","updated_at":"2015-11-25T06:19:50Z","html_url":"https://github.com/crowbar/crowbar-ceph/pull/6#discussion_r45832848","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/comments/45832848"},"html":{"href":"https://github.com/crowbar/crowbar-ceph/pull/6#discussion_r45832848"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6","id":43248382,"html_url":"https://github.com/crowbar/crowbar-ceph/pull/6","diff_url":"https://github.com/crowbar/crowbar-ceph/pull/6.diff","patch_url":"https://github.com/crowbar/crowbar-ceph/pull/6.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-ceph/issues/6","number":6,"state":"open","locked":false,"title":"radosgw: Deploy radosgw using civetweb","user":{"login":"tserong","id":754700,"avatar_url":"https://avatars.githubusercontent.com/u/754700?v=3","gravatar_id":"","url":"https://api.github.com/users/tserong","html_url":"https://github.com/tserong","followers_url":"https://api.github.com/users/tserong/followers","following_url":"https://api.github.com/users/tserong/following{/other_user}","gists_url":"https://api.github.com/users/tserong/gists{/gist_id}","starred_url":"https://api.github.com/users/tserong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tserong/subscriptions","organizations_url":"https://api.github.com/users/tserong/orgs","repos_url":"https://api.github.com/users/tserong/repos","events_url":"https://api.github.com/users/tserong/events{/privacy}","received_events_url":"https://api.github.com/users/tserong/received_events","type":"User","site_admin":false},"body":"This is approximately what would need to be done to deploy radosgw using\r\ncivetweb, instead of apache.\r\n\r\nOutstanding Issues:\r\n\r\n* SSL doesn't presently work due to unversioned libssl.so and\r\n  libcrypto.so being dlopen()'d (see http://tracker.ceph.com/issues/11239\r\n  and https://bugzilla.suse.com/show_bug.cgi?id=942874), but you can\r\n  fake it up with a couple of symlinks to test.\r\n\r\n* Discrepancy between apache-style separate SSL key and certfiles, and\r\n  civetweb combined pemfile.  I'm not sure how best to address that (see\r\n  question in source).\r\n\r\nAlso, the radosgw_apache2.rb recipe and related templates should be\r\ndeleted.\r\n\r\nSigned-off-by: Tim Serong <tserong@suse.com>","created_at":"2015-08-25T04:20:36Z","updated_at":"2015-11-25T06:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8abc10de57c3f07e351f766dc2550c81e6d690d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ceph/issues/6/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ceph/statuses/47f25f42bf46b2bc2e1be5011577e1ec33548f26","head":{"label":"tserong:wip-rgw-civetweb","ref":"wip-rgw-civetweb","sha":"47f25f42bf46b2bc2e1be5011577e1ec33548f26","user":{"login":"tserong","id":754700,"avatar_url":"https://avatars.githubusercontent.com/u/754700?v=3","gravatar_id":"","url":"https://api.github.com/users/tserong","html_url":"https://github.com/tserong","followers_url":"https://api.github.com/users/tserong/followers","following_url":"https://api.github.com/users/tserong/following{/other_user}","gists_url":"https://api.github.com/users/tserong/gists{/gist_id}","starred_url":"https://api.github.com/users/tserong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tserong/subscriptions","organizations_url":"https://api.github.com/users/tserong/orgs","repos_url":"https://api.github.com/users/tserong/repos","events_url":"https://api.github.com/users/tserong/events{/privacy}","received_events_url":"https://api.github.com/users/tserong/received_events","type":"User","site_admin":false},"repo":{"id":41339766,"name":"crowbar-ceph","full_name":"tserong/crowbar-ceph","owner":{"login":"tserong","id":754700,"avatar_url":"https://avatars.githubusercontent.com/u/754700?v=3","gravatar_id":"","url":"https://api.github.com/users/tserong","html_url":"https://github.com/tserong","followers_url":"https://api.github.com/users/tserong/followers","following_url":"https://api.github.com/users/tserong/following{/other_user}","gists_url":"https://api.github.com/users/tserong/gists{/gist_id}","starred_url":"https://api.github.com/users/tserong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tserong/subscriptions","organizations_url":"https://api.github.com/users/tserong/orgs","repos_url":"https://api.github.com/users/tserong/repos","events_url":"https://api.github.com/users/tserong/events{/privacy}","received_events_url":"https://api.github.com/users/tserong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tserong/crowbar-ceph","description":"Ceph deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/tserong/crowbar-ceph","forks_url":"https://api.github.com/repos/tserong/crowbar-ceph/forks","keys_url":"https://api.github.com/repos/tserong/crowbar-ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tserong/crowbar-ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tserong/crowbar-ceph/teams","hooks_url":"https://api.github.com/repos/tserong/crowbar-ceph/hooks","issue_events_url":"https://api.github.com/repos/tserong/crowbar-ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tserong/crowbar-ceph/events","assignees_url":"https://api.github.com/repos/tserong/crowbar-ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tserong/crowbar-ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tserong/crowbar-ceph/tags","blobs_url":"https://api.github.com/repos/tserong/crowbar-ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tserong/crowbar-ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tserong/crowbar-ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tserong/crowbar-ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tserong/crowbar-ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tserong/crowbar-ceph/languages","stargazers_url":"https://api.github.com/repos/tserong/crowbar-ceph/stargazers","contributors_url":"https://api.github.com/repos/tserong/crowbar-ceph/contributors","subscribers_url":"https://api.github.com/repos/tserong/crowbar-ceph/subscribers","subscription_url":"https://api.github.com/repos/tserong/crowbar-ceph/subscription","commits_url":"https://api.github.com/repos/tserong/crowbar-ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tserong/crowbar-ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tserong/crowbar-ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tserong/crowbar-ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tserong/crowbar-ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tserong/crowbar-ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tserong/crowbar-ceph/merges","archive_url":"https://api.github.com/repos/tserong/crowbar-ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tserong/crowbar-ceph/downloads","issues_url":"https://api.github.com/repos/tserong/crowbar-ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tserong/crowbar-ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tserong/crowbar-ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tserong/crowbar-ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tserong/crowbar-ceph/labels{/name}","releases_url":"https://api.github.com/repos/tserong/crowbar-ceph/releases{/id}","created_at":"2015-08-25T03:03:27Z","updated_at":"2015-08-25T03:03:27Z","pushed_at":"2015-11-25T06:19:39Z","git_url":"git://github.com/tserong/crowbar-ceph.git","ssh_url":"git@github.com:tserong/crowbar-ceph.git","clone_url":"https://github.com/tserong/crowbar-ceph.git","svn_url":"https://github.com/tserong/crowbar-ceph","homepage":null,"size":395,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"3ce17f0b8ad707b9683b8302d57e5465eebf5b5f","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006924,"name":"crowbar-ceph","full_name":"crowbar/crowbar-ceph","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-ceph","description":"Ceph deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-ceph","forks_url":"https://api.github.com/repos/crowbar/crowbar-ceph/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-ceph/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-ceph/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-ceph/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-ceph/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-ceph/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-ceph/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-ceph/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-ceph/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-ceph/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-ceph/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-ceph/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-ceph/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-ceph/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-ceph/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-ceph/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-ceph/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-ceph/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-ceph/releases{/id}","created_at":"2015-07-13T10:56:14Z","updated_at":"2015-08-20T13:43:43Z","pushed_at":"2015-11-25T06:19:40Z","git_url":"git://github.com/crowbar/crowbar-ceph.git","ssh_url":"git@github.com:crowbar/crowbar-ceph.git","clone_url":"https://github.com/crowbar/crowbar-ceph.git","svn_url":"https://github.com/crowbar/crowbar-ceph","homepage":null,"size":411,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6"},"html":{"href":"https://github.com/crowbar/crowbar-ceph/pull/6"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/issues/6"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-ceph/statuses/47f25f42bf46b2bc2e1be5011577e1ec33548f26"}}}}