{"action":"created","comment":{"url":"https://api.github.com/repos/getlantern/flashlight-build/pulls/comments/24714860","id":24714860,"diff_hunk":"@@ -336,5 +347,16 @@ func (updated *Config) updateFrom(updateBytes []byte) error {\n \tfor _, server := range servers {\n \t\tupdated.Client.FrontedServers = append(updated.Client.FrontedServers, server)\n \t}\n+\n+\t// Same with global whitelist\n+\t// Would be nice to combine this with the above at some point!","path":"src/github.com/getlantern/flashlight/config/config.go","position":38,"original_position":38,"commit_id":"e1b3f36a8de1b097c992e3088e5240a5d3b11bc8","original_commit_id":"89fe2a0f1b1ea365b951d4d54328b10953b16cae","user":{"login":"oxtoacart","id":5000654,"avatar_url":"https://avatars.githubusercontent.com/u/5000654?v=3","gravatar_id":"","url":"https://api.github.com/users/oxtoacart","html_url":"https://github.com/oxtoacart","followers_url":"https://api.github.com/users/oxtoacart/followers","following_url":"https://api.github.com/users/oxtoacart/following{/other_user}","gists_url":"https://api.github.com/users/oxtoacart/gists{/gist_id}","starred_url":"https://api.github.com/users/oxtoacart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxtoacart/subscriptions","organizations_url":"https://api.github.com/users/oxtoacart/orgs","repos_url":"https://api.github.com/users/oxtoacart/repos","events_url":"https://api.github.com/users/oxtoacart/events{/privacy}","received_events_url":"https://api.github.com/users/oxtoacart/received_events","type":"User","site_admin":false},"body":"Might be tough to do without generics :(","created_at":"2015-02-14T15:18:16Z","updated_at":"2015-02-14T15:18:16Z","html_url":"https://github.com/getlantern/flashlight-build/pull/41#discussion_r24714860","pull_request_url":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/getlantern/flashlight-build/pulls/comments/24714860"},"html":{"href":"https://github.com/getlantern/flashlight-build/pull/41#discussion_r24714860"},"pull_request":{"href":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41","id":29227354,"html_url":"https://github.com/getlantern/flashlight-build/pull/41","diff_url":"https://github.com/getlantern/flashlight-build/pull/41.diff","patch_url":"https://github.com/getlantern/flashlight-build/pull/41.patch","issue_url":"https://api.github.com/repos/getlantern/flashlight-build/issues/41","number":41,"state":"open","locked":false,"title":"Whitelist functionality","user":{"login":"atavism","id":6346213,"avatar_url":"https://avatars.githubusercontent.com/u/6346213?v=3","gravatar_id":"","url":"https://api.github.com/users/atavism","html_url":"https://github.com/atavism","followers_url":"https://api.github.com/users/atavism/followers","following_url":"https://api.github.com/users/atavism/following{/other_user}","gists_url":"https://api.github.com/users/atavism/gists{/gist_id}","starred_url":"https://api.github.com/users/atavism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atavism/subscriptions","organizations_url":"https://api.github.com/users/atavism/orgs","repos_url":"https://api.github.com/users/atavism/repos","events_url":"https://api.github.com/users/atavism/events{/privacy}","received_events_url":"https://api.github.com/users/atavism/received_events","type":"User","site_admin":false},"body":"Still need to add extra unit tests; in particular, I want to add a mock YAML config to better test whitelist customization. I'd also like to add a test verifying sites we add to cloud.yaml end up propagating to a mock PAC file. Nevertheless, opening the PR for now to offer an overview of changes.\r\n\r\nThe original PR was 1,500 files long. I removed three packages that were showing up in the diff: src/golang.org/x/, src/code.google.com/p/freetype-go/, and the UI updates (that's on a corresponding issue-2195).\r\n\r\nThis also includes changes for https://github.com/getlantern/lantern/issues/2231 https://github.com/getlantern/lantern/issues/2205 and https://github.com/getlantern/lantern/issues/2218","created_at":"2015-02-12T23:33:04Z","updated_at":"2015-02-14T15:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9987d20d55963a08ec63c436bb274386a2c3d71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41/commits","review_comments_url":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41/comments","review_comment_url":"https://api.github.com/repos/getlantern/flashlight-build/pulls/comments/{number}","comments_url":"https://api.github.com/repos/getlantern/flashlight-build/issues/41/comments","statuses_url":"https://api.github.com/repos/getlantern/flashlight-build/statuses/e1b3f36a8de1b097c992e3088e5240a5d3b11bc8","head":{"label":"getlantern:issue-2195","ref":"issue-2195","sha":"e1b3f36a8de1b097c992e3088e5240a5d3b11bc8","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":27652771,"name":"flashlight-build","full_name":"getlantern/flashlight-build","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/flashlight-build","description":"Repeatable builds for flashlight, using gox","fork":false,"url":"https://api.github.com/repos/getlantern/flashlight-build","forks_url":"https://api.github.com/repos/getlantern/flashlight-build/forks","keys_url":"https://api.github.com/repos/getlantern/flashlight-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/flashlight-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/flashlight-build/teams","hooks_url":"https://api.github.com/repos/getlantern/flashlight-build/hooks","issue_events_url":"https://api.github.com/repos/getlantern/flashlight-build/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/flashlight-build/events","assignees_url":"https://api.github.com/repos/getlantern/flashlight-build/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/flashlight-build/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/flashlight-build/tags","blobs_url":"https://api.github.com/repos/getlantern/flashlight-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/flashlight-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/flashlight-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/flashlight-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/flashlight-build/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/flashlight-build/languages","stargazers_url":"https://api.github.com/repos/getlantern/flashlight-build/stargazers","contributors_url":"https://api.github.com/repos/getlantern/flashlight-build/contributors","subscribers_url":"https://api.github.com/repos/getlantern/flashlight-build/subscribers","subscription_url":"https://api.github.com/repos/getlantern/flashlight-build/subscription","commits_url":"https://api.github.com/repos/getlantern/flashlight-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/flashlight-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/flashlight-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/flashlight-build/issues/comments/{number}","contents_url":"https://api.github.com/repos/getlantern/flashlight-build/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/flashlight-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/flashlight-build/merges","archive_url":"https://api.github.com/repos/getlantern/flashlight-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/flashlight-build/downloads","issues_url":"https://api.github.com/repos/getlantern/flashlight-build/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/flashlight-build/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/flashlight-build/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/flashlight-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/flashlight-build/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/flashlight-build/releases{/id}","created_at":"2014-12-06T23:27:18Z","updated_at":"2015-02-14T05:42:08Z","pushed_at":"2015-02-14T15:17:52Z","git_url":"git://github.com/getlantern/flashlight-build.git","ssh_url":"git@github.com:getlantern/flashlight-build.git","clone_url":"https://github.com/getlantern/flashlight-build.git","svn_url":"https://github.com/getlantern/flashlight-build","homepage":"","size":127257,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"devel"}},"base":{"label":"getlantern:valencia","ref":"valencia","sha":"2ebb5cdb248677cd979c356ef830e92b42ef3445","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":27652771,"name":"flashlight-build","full_name":"getlantern/flashlight-build","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/flashlight-build","description":"Repeatable builds for flashlight, using gox","fork":false,"url":"https://api.github.com/repos/getlantern/flashlight-build","forks_url":"https://api.github.com/repos/getlantern/flashlight-build/forks","keys_url":"https://api.github.com/repos/getlantern/flashlight-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/flashlight-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/flashlight-build/teams","hooks_url":"https://api.github.com/repos/getlantern/flashlight-build/hooks","issue_events_url":"https://api.github.com/repos/getlantern/flashlight-build/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/flashlight-build/events","assignees_url":"https://api.github.com/repos/getlantern/flashlight-build/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/flashlight-build/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/flashlight-build/tags","blobs_url":"https://api.github.com/repos/getlantern/flashlight-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/flashlight-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/flashlight-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/flashlight-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/flashlight-build/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/flashlight-build/languages","stargazers_url":"https://api.github.com/repos/getlantern/flashlight-build/stargazers","contributors_url":"https://api.github.com/repos/getlantern/flashlight-build/contributors","subscribers_url":"https://api.github.com/repos/getlantern/flashlight-build/subscribers","subscription_url":"https://api.github.com/repos/getlantern/flashlight-build/subscription","commits_url":"https://api.github.com/repos/getlantern/flashlight-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/flashlight-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/flashlight-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/flashlight-build/issues/comments/{number}","contents_url":"https://api.github.com/repos/getlantern/flashlight-build/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/flashlight-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/flashlight-build/merges","archive_url":"https://api.github.com/repos/getlantern/flashlight-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/flashlight-build/downloads","issues_url":"https://api.github.com/repos/getlantern/flashlight-build/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/flashlight-build/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/flashlight-build/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/flashlight-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/flashlight-build/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/flashlight-build/releases{/id}","created_at":"2014-12-06T23:27:18Z","updated_at":"2015-02-14T05:42:08Z","pushed_at":"2015-02-14T15:17:52Z","git_url":"git://github.com/getlantern/flashlight-build.git","ssh_url":"git@github.com:getlantern/flashlight-build.git","clone_url":"https://github.com/getlantern/flashlight-build.git","svn_url":"https://github.com/getlantern/flashlight-build","homepage":"","size":127257,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41"},"html":{"href":"https://github.com/getlantern/flashlight-build/pull/41"},"issue":{"href":"https://api.github.com/repos/getlantern/flashlight-build/issues/41"},"comments":{"href":"https://api.github.com/repos/getlantern/flashlight-build/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/getlantern/flashlight-build/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/getlantern/flashlight-build/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/getlantern/flashlight-build/statuses/e1b3f36a8de1b097c992e3088e5240a5d3b11bc8"}}}}