{"action":"created","issue":{"url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/188","labels_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/188/comments","events_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/188/events","html_url":"https://github.com/ocombe/ocLazyLoad/pull/188","id":81982490,"number":188,"title":"fix(user-agent): guard against null-refs when parsing Safari user-agents","user":{"login":"booleanbetrayal","id":981825,"avatar_url":"https://avatars.githubusercontent.com/u/981825?v=3","gravatar_id":"","url":"https://api.github.com/users/booleanbetrayal","html_url":"https://github.com/booleanbetrayal","followers_url":"https://api.github.com/users/booleanbetrayal/followers","following_url":"https://api.github.com/users/booleanbetrayal/following{/other_user}","gists_url":"https://api.github.com/users/booleanbetrayal/gists{/gist_id}","starred_url":"https://api.github.com/users/booleanbetrayal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booleanbetrayal/subscriptions","organizations_url":"https://api.github.com/users/booleanbetrayal/orgs","repos_url":"https://api.github.com/users/booleanbetrayal/repos","events_url":"https://api.github.com/users/booleanbetrayal/events{/privacy}","received_events_url":"https://api.github.com/users/booleanbetrayal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-28T15:25:27Z","updated_at":"2015-05-28T19:10:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocombe/ocLazyLoad/pulls/188","html_url":"https://github.com/ocombe/ocLazyLoad/pull/188","diff_url":"https://github.com/ocombe/ocLazyLoad/pull/188.diff","patch_url":"https://github.com/ocombe/ocLazyLoad/pull/188.patch"},"body":"the specific problematic user-agent that we ran into was googlebot's:\r\n\r\n`AdsBot-Google-Mobile (+http://www.google.com/mobile/adsbot.html) Mozilla (iPhone; U; CPU iPhone OS 3 0 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile Safari`\r\n\r\nI removed the blacklisting of Chrome and PhantomJS from the conditional as neither have \"version\" anywhere in their agents, and the more generalized fix should catch them fine. \r\n\r\nDidn't produce dist assets, but can do so if needed. Likewise, let me know if you want any tweaks to the implementation."},"comment":{"url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/comments/106569036","html_url":"https://github.com/ocombe/ocLazyLoad/pull/188#issuecomment-106569036","issue_url":"https://api.github.com/repos/ocombe/ocLazyLoad/issues/188","id":106569036,"user":{"login":"ocombe","id":265378,"avatar_url":"https://avatars.githubusercontent.com/u/265378?v=3","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T19:10:40Z","updated_at":"2015-05-28T19:10:40Z","body":"Damn user agent tests, that's why I didn't want to include this test in the first place, but there was no easy other way to \"fix\" this bug :(\r\nThanks for the PR, I'll run it against a few browsers to make sure and merge it if everything is ok :)"}}