{"action":"closed","number":258,"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/258","id":21737486,"html_url":"https://github.com/SeleniumHQ/selenium/pull/258","diff_url":"https://github.com/SeleniumHQ/selenium/pull/258.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/258.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/258","number":258,"state":"closed","locked":false,"title":"Remove Browser Connection driver extension and add Network Connection driver extension","user":{"login":"jimvm","id":976767,"avatar_url":"https://avatars.githubusercontent.com/u/976767?v=3","gravatar_id":"","url":"https://api.github.com/users/jimvm","html_url":"https://github.com/jimvm","followers_url":"https://api.github.com/users/jimvm/followers","following_url":"https://api.github.com/users/jimvm/following{/other_user}","gists_url":"https://api.github.com/users/jimvm/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvm/subscriptions","organizations_url":"https://api.github.com/users/jimvm/orgs","repos_url":"https://api.github.com/users/jimvm/repos","events_url":"https://api.github.com/users/jimvm/events{/privacy}","received_events_url":"https://api.github.com/users/jimvm/received_events","type":"User","site_admin":false},"body":"This is related to this issue: https://code.google.com/p/selenium/issues/detail?id=7315\r\n\r\nIt's basically the Ruby version of this commit: https://github.com/SeleniumHQ/selenium/commit/8629dc6ec6ddd96bbe0975ee86d0c4c2f4b9ebb2\r\n\r\nHasBrowserConnection is a driver extension that is only an option for the Android driver. The\r\nSelendroid JSON Wire implementation doesn't support the `browser_connection` method anymore,\r\nso all code related to this driver extension can be removed from the Ruby bindings.\r\n\r\nThe new Selendroid JSON Wire method `network_connection` returns the connection type on a GET request and changes the connection type on a POST request. Currently you can only switch between Airplane mode and All mode. (The implementation is here: https://github.com/selendroid/selendroid/blob/master/selendroid-standalone/src/main/java/io/selendroid/server/handler/NetworkConnectionHandler.java.)\r\n\r\nThe new HasNetworkConnection driver extension can handle all types even though that doesn't work yet. In case an unknown type is returned `network_connection_type` returns this unknown type value. I just wanted to have something for this possibility. Can someone think of something better to return if this happens? \r\n\r\nI did have some problems with getting the integration specs running for Selendroid. Could someone help verify that these specs pass?\r\n\r\nI haven't signed the CLA yet. I will do that once these changes are approved.\r\n\r\n","created_at":"2014-09-24T19:15:57Z","updated_at":"2015-03-02T21:40:11Z","closed_at":"2015-03-02T21:40:11Z","merged_at":null,"merge_commit_sha":"a8a634a9e2a21fabe40804e950311189d22c9946","assignee":{"login":"jarib","id":572,"avatar_url":"https://avatars.githubusercontent.com/u/572?v=3","gravatar_id":"","url":"https://api.github.com/users/jarib","html_url":"https://github.com/jarib","followers_url":"https://api.github.com/users/jarib/followers","following_url":"https://api.github.com/users/jarib/following{/other_user}","gists_url":"https://api.github.com/users/jarib/gists{/gist_id}","starred_url":"https://api.github.com/users/jarib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarib/subscriptions","organizations_url":"https://api.github.com/users/jarib/orgs","repos_url":"https://api.github.com/users/jarib/repos","events_url":"https://api.github.com/users/jarib/events{/privacy}","received_events_url":"https://api.github.com/users/jarib/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/258/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/258/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/258/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/fe86d4fd7c650601aea418f307c01188dbe32739","head":{"label":"jimvm:browser_connection_removal","ref":"browser_connection_removal","sha":"fe86d4fd7c650601aea418f307c01188dbe32739","user":{"login":"jimvm","id":976767,"avatar_url":"https://avatars.githubusercontent.com/u/976767?v=3","gravatar_id":"","url":"https://api.github.com/users/jimvm","html_url":"https://github.com/jimvm","followers_url":"https://api.github.com/users/jimvm/followers","following_url":"https://api.github.com/users/jimvm/following{/other_user}","gists_url":"https://api.github.com/users/jimvm/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvm/subscriptions","organizations_url":"https://api.github.com/users/jimvm/orgs","repos_url":"https://api.github.com/users/jimvm/repos","events_url":"https://api.github.com/users/jimvm/events{/privacy}","received_events_url":"https://api.github.com/users/jimvm/received_events","type":"User","site_admin":false},"repo":{"id":23222438,"name":"selenium","full_name":"jimvm/selenium","owner":{"login":"jimvm","id":976767,"avatar_url":"https://avatars.githubusercontent.com/u/976767?v=3","gravatar_id":"","url":"https://api.github.com/users/jimvm","html_url":"https://github.com/jimvm","followers_url":"https://api.github.com/users/jimvm/followers","following_url":"https://api.github.com/users/jimvm/following{/other_user}","gists_url":"https://api.github.com/users/jimvm/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvm/subscriptions","organizations_url":"https://api.github.com/users/jimvm/orgs","repos_url":"https://api.github.com/users/jimvm/repos","events_url":"https://api.github.com/users/jimvm/events{/privacy}","received_events_url":"https://api.github.com/users/jimvm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimvm/selenium","description":"A mirror of the Selenium source. Please file issues in Google Code. Also confirm you have signed the CLA (http://goo.gl/qC50R) when making a Pull Request.","fork":true,"url":"https://api.github.com/repos/jimvm/selenium","forks_url":"https://api.github.com/repos/jimvm/selenium/forks","keys_url":"https://api.github.com/repos/jimvm/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimvm/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimvm/selenium/teams","hooks_url":"https://api.github.com/repos/jimvm/selenium/hooks","issue_events_url":"https://api.github.com/repos/jimvm/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/jimvm/selenium/events","assignees_url":"https://api.github.com/repos/jimvm/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/jimvm/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/jimvm/selenium/tags","blobs_url":"https://api.github.com/repos/jimvm/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimvm/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimvm/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimvm/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimvm/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/jimvm/selenium/languages","stargazers_url":"https://api.github.com/repos/jimvm/selenium/stargazers","contributors_url":"https://api.github.com/repos/jimvm/selenium/contributors","subscribers_url":"https://api.github.com/repos/jimvm/selenium/subscribers","subscription_url":"https://api.github.com/repos/jimvm/selenium/subscription","commits_url":"https://api.github.com/repos/jimvm/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimvm/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimvm/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimvm/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimvm/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/jimvm/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimvm/selenium/merges","archive_url":"https://api.github.com/repos/jimvm/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimvm/selenium/downloads","issues_url":"https://api.github.com/repos/jimvm/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/jimvm/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/jimvm/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/jimvm/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimvm/selenium/labels{/name}","releases_url":"https://api.github.com/repos/jimvm/selenium/releases{/id}","created_at":"2014-08-22T11:00:05Z","updated_at":"2015-01-17T13:53:59Z","pushed_at":"2015-01-17T15:13:37Z","git_url":"git://github.com/jimvm/selenium.git","ssh_url":"git@github.com:jimvm/selenium.git","clone_url":"https://github.com/jimvm/selenium.git","svn_url":"https://github.com/jimvm/selenium","homepage":"https://code.google.com/p/selenium/","size":1120636,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"8666096ba21bae021b0b27c8640fa3d45a7baaf1","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A mirror of the Selenium source. Please file issues in Google Code. Also confirm you have signed the CLA (http://goo.gl/qC50R) when making a Pull Request.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","created_at":"2013-01-14T21:40:56Z","updated_at":"2015-03-02T21:39:22Z","pushed_at":"2015-03-02T21:39:22Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"https://code.google.com/p/selenium/","size":1226432,"stargazers_count":636,"watchers_count":636,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":593,"mirror_url":"https://code.google.com/p/selenium/","open_issues_count":28,"forks":593,"open_issues":28,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/258"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/258"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/258"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/fe86d4fd7c650601aea418f307c01188dbe32739"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":13,"review_comments":1,"commits":5,"additions":106,"deletions":45,"changed_files":9}}