{"action":"created","issue":{"url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/issues/6","labels_url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/issues/6/comments","events_url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/issues/6/events","html_url":"https://github.com/upphiminn/d3.ForceBundle/pull/6","id":84944224,"number":6,"title":"Add rejected edges back to the output with undefined value","user":{"login":"Domajno","id":1223778,"avatar_url":"https://avatars.githubusercontent.com/u/1223778?v=3","gravatar_id":"","url":"https://api.github.com/users/Domajno","html_url":"https://github.com/Domajno","followers_url":"https://api.github.com/users/Domajno/followers","following_url":"https://api.github.com/users/Domajno/following{/other_user}","gists_url":"https://api.github.com/users/Domajno/gists{/gist_id}","starred_url":"https://api.github.com/users/Domajno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Domajno/subscriptions","organizations_url":"https://api.github.com/users/Domajno/orgs","repos_url":"https://api.github.com/users/Domajno/repos","events_url":"https://api.github.com/users/Domajno/events{/privacy}","received_events_url":"https://api.github.com/users/Domajno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-04T06:39:31Z","updated_at":"2015-06-04T07:58:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/pulls/6","html_url":"https://github.com/upphiminn/d3.ForceBundle/pull/6","diff_url":"https://github.com/upphiminn/d3.ForceBundle/pull/6.diff","patch_url":"https://github.com/upphiminn/d3.ForceBundle/pull/6.patch"},"body":"Hi\r\n\r\nI had this example where I had data set of 500 edges containing also weights and additional metadata about them. As the output of d3.ForceBundle I got an array of 478 elements but I didn't know which edges were deleted so I couldn't associate this metadata with the new edges anymore. \r\n\r\nWhat I suggest is to always return an array of the same size as the input edges array but some elements may be undefined - those which were rejected. I guess there are many ways to approach this problem and this is one possible solution.\r\n\r\nCheers\r\nDominik"},"comment":{"url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/issues/comments/108772601","html_url":"https://github.com/upphiminn/d3.ForceBundle/pull/6#issuecomment-108772601","issue_url":"https://api.github.com/repos/upphiminn/d3.ForceBundle/issues/6","id":108772601,"user":{"login":"godoorsun","id":844871,"avatar_url":"https://avatars.githubusercontent.com/u/844871?v=3","gravatar_id":"","url":"https://api.github.com/users/godoorsun","html_url":"https://github.com/godoorsun","followers_url":"https://api.github.com/users/godoorsun/followers","following_url":"https://api.github.com/users/godoorsun/following{/other_user}","gists_url":"https://api.github.com/users/godoorsun/gists{/gist_id}","starred_url":"https://api.github.com/users/godoorsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godoorsun/subscriptions","organizations_url":"https://api.github.com/users/godoorsun/orgs","repos_url":"https://api.github.com/users/godoorsun/repos","events_url":"https://api.github.com/users/godoorsun/events{/privacy}","received_events_url":"https://api.github.com/users/godoorsun/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T07:58:53Z","updated_at":"2015-06-04T07:58:53Z","body":"Hi, Dominik,\r\n\r\nI think the deleted (or filtered) edges may be absolute horizontal or vertical edges, may be you can have a try of this fork version here:\r\nhttps://github.com/godoorsun/d3.ForceBundle\r\nwhich is discussed in my yesterday's pull request.\r\nhttps://github.com/upphiminn/d3.ForceBundle/pull/5\r\n"}}