{"action":"created","issue":{"url":"https://api.github.com/repos/refinery/refinerycms/issues/2920","labels_url":"https://api.github.com/repos/refinery/refinerycms/issues/2920/labels{/name}","comments_url":"https://api.github.com/repos/refinery/refinerycms/issues/2920/comments","events_url":"https://api.github.com/repos/refinery/refinerycms/issues/2920/events","html_url":"https://github.com/refinery/refinerycms/pull/2920","id":60451276,"number":2920,"title":"Iconfont","user":{"login":"anitagraham","id":397118,"avatar_url":"https://avatars.githubusercontent.com/u/397118?v=3","gravatar_id":"","url":"https://api.github.com/users/anitagraham","html_url":"https://github.com/anitagraham","followers_url":"https://api.github.com/users/anitagraham/followers","following_url":"https://api.github.com/users/anitagraham/following{/other_user}","gists_url":"https://api.github.com/users/anitagraham/gists{/gist_id}","starred_url":"https://api.github.com/users/anitagraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anitagraham/subscriptions","organizations_url":"https://api.github.com/users/anitagraham/orgs","repos_url":"https://api.github.com/users/anitagraham/repos","events_url":"https://api.github.com/users/anitagraham/events{/privacy}","received_events_url":"https://api.github.com/users/anitagraham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-03-10T05:00:08Z","updated_at":"2015-03-12T04:53:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/refinery/refinerycms/pulls/2920","html_url":"https://github.com/refinery/refinerycms/pull/2920","diff_url":"https://github.com/refinery/refinerycms/pull/2920.diff","patch_url":"https://github.com/refinery/refinerycms/pull/2920.patch"},"body":"Use the Font-Awesome iconfont instead of individual icon files.\r\n\r\n**SCSS and appearance changes**\r\n* Use SCSS partials and `@import` them.\r\n* Implement long-lost login spinner \r\n* Snug page-part controls up to top border\r\n* Basic CSS changes to use icons.\r\n* Icons all grey (#888) except for Delete and Error icons (red)\r\n* Add fonts to vendor: the font used is a cut-down version of fontAwesome with just the icons used by Refinery (and a couple more that might be needed). *See list at end*\r\n* Add sort down, sortup icons (although not yet used as a class)\r\n* Make draft page check box float to the right\r\n\r\n\r\n**Changes in views to use iconfont**\r\n* Add `action_icon` and `action_label` methods in tag_helper.rb. Display an action with either an icon or label.\r\n* Change action `link_to`s to call `action_icon` or `action_label`\r\n\r\n**Changes in specs to accomodate icon use**\r\n* Trigger clicks on links which poltergeist can’t see\r\n* Make locale marker tests see the new markers\r\n\r\n**Other**\r\n* Change generators to use `action_label` and `action_icon`\r\n\r\n**Icons in fontfiles**\r\nThe icons were taken from [Font Awesome](http://fortawesome.github.io/Font-Awesome/icons/). [Icomoon](https://icomoon.io/app/#/select) was used to select the following icons and create fonts with them.\r\narrow-circle-o-down\r\narrow-circle-o-up\r\narrows-h\r\narrows-v\r\ncheck\r\ncheck-circle\r\ncheck-circle-o\r\ncheck-square-o\r\nclose\r\ncog\r\ncogs\r\ncomment\r\ncomment-o\r\ndownload\r\nedit\r\nenvelope\r\nenvelope-o\r\nexchange\r\nexclamation-circle\r\nexclamation-triangle\r\neye\r\nfile\r\nfile-archive-o\r\nfile-audio-o\r\nfile-code-o\r\nfile-excel-o\r\nfile-image-o\r\nfile-movie-o\r\nfile-o\r\nfile-pdf-o\r\nfile-powerpoint-o\r\nfile-text\r\nfile-text-o\r\nfile-word-o\r\nfolder\r\nfolder-o\r\nfolder-open\r\nfolder-open-o\r\ninfo-circle\r\nminus-circle\r\nplus-circle\r\nquestion-circle\r\nrandom\r\nsearch\r\nsort\r\nspinner\r\nth\r\nth-list\r\ntimes-circle\r\ntimes-circle-o\r\ntrash-o\r\nupload\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/refinery/refinerycms/issues/comments/78423732","html_url":"https://github.com/refinery/refinerycms/pull/2920#issuecomment-78423732","issue_url":"https://api.github.com/repos/refinery/refinerycms/issues/2920","id":78423732,"user":{"login":"anitagraham","id":397118,"avatar_url":"https://avatars.githubusercontent.com/u/397118?v=3","gravatar_id":"","url":"https://api.github.com/users/anitagraham","html_url":"https://github.com/anitagraham","followers_url":"https://api.github.com/users/anitagraham/followers","following_url":"https://api.github.com/users/anitagraham/following{/other_user}","gists_url":"https://api.github.com/users/anitagraham/gists{/gist_id}","starred_url":"https://api.github.com/users/anitagraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anitagraham/subscriptions","organizations_url":"https://api.github.com/users/anitagraham/orgs","repos_url":"https://api.github.com/users/anitagraham/repos","events_url":"https://api.github.com/users/anitagraham/events{/privacy}","received_events_url":"https://api.github.com/users/anitagraham/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T04:53:10Z","updated_at":"2015-03-12T04:53:10Z","body":"Icon colours are easy to change. I changed them last night to use #404650, which @parndt is using in another branch for the site bar.\r\n\r\nYes, don't know what to do about icon colours. My first screen shots had tertiary colours (rose, azure, violet etc) for the icons but I thought it might look better in grey except warnings. And information blue is a standard of a sort.\r\n\r\nDiscussion and guidance welcome. Also, the colours are set in core/app/assets/stylesheets/_colours.scss so it's easy to change them. I'll change the info icon colour to grey too and  move those icons up again. (I fixed it, but may have lost the fix during rebase).\r\n\r\nPage Load time: does seem reduced. Enough that I notice/saw the page-branch gifs loading and taking a long time. They *could* be done with svg or icons too, I suppose, but I've never really looked at how they work in detail.  "}}