{"action":"created","issue":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1384","labels_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1384/labels{/name}","comments_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1384/comments","events_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1384/events","html_url":"https://github.com/lisa-lab/pylearn2/pull/1384","id":56711756,"number":1384,"title":"Remove method todo write me. They are on Op methods documented in Theano...","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-05T18:48:32Z","updated_at":"2015-02-05T20:22:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1384","html_url":"https://github.com/lisa-lab/pylearn2/pull/1384","diff_url":"https://github.com/lisa-lab/pylearn2/pull/1384.diff","patch_url":"https://github.com/lisa-lab/pylearn2/pull/1384.patch"},"body":".... We should not ducument all of their implementation."},"comment":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/comments/73119449","html_url":"https://github.com/lisa-lab/pylearn2/pull/1384#issuecomment-73119449","issue_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1384","id":73119449,"user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"created_at":"2015-02-05T20:22:38Z","updated_at":"2015-02-05T20:22:38Z","body":"I think added the WRITEME was done fast due to the volume of change needed.\nI think it is good that by default we expect them to be documented.\nOtherwise, it is too easy to do nothing and have no warning/errors that the\ndoc is missing.\n\nSo I think a list of methods that do not need to be documented is good.\n\nI would filter on more particular then the method node. I would make this\ncase, if the class is an instannce of theano.Op and for those method name,\ndisable the error.\n\nOn Thu, Feb 5, 2015 at 2:39 PM, Bart van Merriënboer <\nnotifications@github.com> wrote:\n\n> I agree, but I think that the blanket requirement of forcing each object\n> to have a docstring might be counter-productive in general. It seems to\n> have mostly lead to large amount of \"WRITEME\" statements, so maybe we\n> should consider disabling it altogether instead of making an exception for\n> these methods.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/lisa-lab/pylearn2/pull/1384#issuecomment-73111855>.\n>\n"}}