{"action":"created","issue":{"url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/issues/41","labels_url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/issues/41/comments","events_url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/issues/41/events","html_url":"https://github.com/utiasASRL/batch-informed-trees/pull/41","id":98039685,"number":41,"title":"Support BITstar use in MoveIt, generic implementation of cost functions to support all optimization objectives","user":{"login":"sonny-tarbouriech","id":10675307,"avatar_url":"https://avatars.githubusercontent.com/u/10675307?v=3","gravatar_id":"","url":"https://api.github.com/users/sonny-tarbouriech","html_url":"https://github.com/sonny-tarbouriech","followers_url":"https://api.github.com/users/sonny-tarbouriech/followers","following_url":"https://api.github.com/users/sonny-tarbouriech/following{/other_user}","gists_url":"https://api.github.com/users/sonny-tarbouriech/gists{/gist_id}","starred_url":"https://api.github.com/users/sonny-tarbouriech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonny-tarbouriech/subscriptions","organizations_url":"https://api.github.com/users/sonny-tarbouriech/orgs","repos_url":"https://api.github.com/users/sonny-tarbouriech/repos","events_url":"https://api.github.com/users/sonny-tarbouriech/events{/privacy}","received_events_url":"https://api.github.com/users/sonny-tarbouriech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-29T22:05:26Z","updated_at":"2015-07-29T22:54:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/pulls/41","html_url":"https://github.com/utiasASRL/batch-informed-trees/pull/41","diff_url":"https://github.com/utiasASRL/batch-informed-trees/pull/41.diff","patch_url":"https://github.com/utiasASRL/batch-informed-trees/pull/41.patch"},"body":"Hi Jonathan,\r\nI create this PR in case you want to see the changes I made in your code to have a working version with MoveIt!. I also adapted the functions you implemented in BITstar and IntegratedQueue classes that make operations on costs. Now objectives that maximize the cost function can also be used. "},"comment":{"url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/issues/comments/126120343","html_url":"https://github.com/utiasASRL/batch-informed-trees/pull/41#issuecomment-126120343","issue_url":"https://api.github.com/repos/utiasASRL/batch-informed-trees/issues/41","id":126120343,"user":{"login":"gammell","id":5250910,"avatar_url":"https://avatars.githubusercontent.com/u/5250910?v=3","gravatar_id":"","url":"https://api.github.com/users/gammell","html_url":"https://github.com/gammell","followers_url":"https://api.github.com/users/gammell/followers","following_url":"https://api.github.com/users/gammell/following{/other_user}","gists_url":"https://api.github.com/users/gammell/gists{/gist_id}","starred_url":"https://api.github.com/users/gammell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammell/subscriptions","organizations_url":"https://api.github.com/users/gammell/orgs","repos_url":"https://api.github.com/users/gammell/repos","events_url":"https://api.github.com/users/gammell/events{/privacy}","received_events_url":"https://api.github.com/users/gammell/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T22:54:29Z","updated_at":"2015-07-29T22:54:29Z","body":"Hi Sonny,\r\nThanks for the PR, I really appreciate it!\r\n\r\nI've included some comments and questions in line, I hope they don't sound negative, I really don't mean them to.\r\n\r\nI really should put a comment in the code explaining why I don't use thee `OptimizationObjective::isCostBetterThan` function, and maybe a check at construction that warns if it seems like you're using an `OptimizationObjective` where smaller costs aren't better."}}