{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/27024149","id":27024149,"diff_hunk":"@@ -106,6 +105,7 @@ public void inject(AdvancedCache<Object, Object> cache, @ComponentName(CACHE_MAR\n       this.persistenceExecutor = persistenceExecutor;\n       this.byteBufferFactory = byteBufferFactory;\n       this.marshalledEntryFactory = marshalledEntryFactory;\n+      this.cacheStoreFactoryRegistry = cache.getComponentRegistry().getGlobalComponentRegistry().getComponent(CacheStoreFactoryRegistry.class);","path":"core/src/main/java/org/infinispan/persistence/manager/PersistenceManagerImpl.java","position":41,"original_position":41,"commit_id":"1ce607923de2194da8a6da9b5d8aa3346ab51f1a","original_commit_id":"1ce607923de2194da8a6da9b5d8aa3346ab51f1a","user":{"login":"galderz","id":50187,"avatar_url":"https://avatars.githubusercontent.com/u/50187?v=3","gravatar_id":"","url":"https://api.github.com/users/galderz","html_url":"https://github.com/galderz","followers_url":"https://api.github.com/users/galderz/followers","following_url":"https://api.github.com/users/galderz/following{/other_user}","gists_url":"https://api.github.com/users/galderz/gists{/gist_id}","starred_url":"https://api.github.com/users/galderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galderz/subscriptions","organizations_url":"https://api.github.com/users/galderz/orgs","repos_url":"https://api.github.com/users/galderz/repos","events_url":"https://api.github.com/users/galderz/events{/privacy}","received_events_url":"https://api.github.com/users/galderz/received_events","type":"User","site_admin":false},"body":"This isn't be a good approach, you shouldn't need to lookup `CacheStoreFactoryRegistry` component here, you simply have to add it as parameter in the `inject` method and the internals take of it.","created_at":"2015-03-24T12:55:31Z","updated_at":"2015-03-24T12:55:31Z","html_url":"https://github.com/infinispan/infinispan/pull/3317#discussion_r27024149","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3317","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/27024149"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3317#discussion_r27024149"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3317"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3317","id":31409086,"html_url":"https://github.com/infinispan/infinispan/pull/3317","diff_url":"https://github.com/infinispan/infinispan/pull/3317.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3317.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3317","number":3317,"state":"open","locked":false,"title":"ISPN-5131 Deployable Cache Stores implementation","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"Hey!\r\n\r\nPlease take a look at proposed implementation of https://issues.jboss.org/browse/ISPN-5131\r\n\r\nKey features:\r\n* Introduced `CacheStoreFactory` and `CacheStoreFactoryRegistry` in order to control Cache Stores instantiation in pluggable fashion\r\n* Added processors for all kind of Custom Cache Stores in Infinispan subsystem\r\n* Added `DeployedStoreConfiguration` and `DeployedStoreConfigurationBuilder` to allow lazy instantiation of Custom Stores\r\n\r\nHow it works?\r\n* At first we create add `DeployedCacheStoreFactory` to `CacheStoreFactoryRegistry`. From that point on, each time `PersistenceManagerImpl` wants to create a new Cache Loader/Writer - it also scans deployed stores.\r\n* In `POST_MODULE` phase we discover Deployed Cache Stores (it happens before installing main Infinispan services) and add them to `DeployedCacheStoreFactory`. From that point `PersistenceManagerImpl` will be able to \"see\" them.\r\n* Finally we use `DeployedStoreConfiguration` and `DeployedStoreConfigurationBuilder` to delay initialization of Deployed Cache Stores (because their classes might not be initialized yet).\r\n\r\nThanks!","created_at":"2015-03-18T08:44:13Z","updated_at":"2015-03-24T12:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a5bcccf36285560dfeb9254a9471dc3dae4f229","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3317/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3317/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3317/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/1ce607923de2194da8a6da9b5d8aa3346ab51f1a","head":{"label":"slaskawi:ISPN-5131_Deployable_Cache_Stores","ref":"ISPN-5131_Deployable_Cache_Stores","sha":"1ce607923de2194da8a6da9b5d8aa3346ab51f1a","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"repo":{"id":23697744,"name":"infinispan","full_name":"slaskawi/infinispan","owner":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slaskawi/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/slaskawi/infinispan","forks_url":"https://api.github.com/repos/slaskawi/infinispan/forks","keys_url":"https://api.github.com/repos/slaskawi/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slaskawi/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slaskawi/infinispan/teams","hooks_url":"https://api.github.com/repos/slaskawi/infinispan/hooks","issue_events_url":"https://api.github.com/repos/slaskawi/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/slaskawi/infinispan/events","assignees_url":"https://api.github.com/repos/slaskawi/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/slaskawi/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/slaskawi/infinispan/tags","blobs_url":"https://api.github.com/repos/slaskawi/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slaskawi/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slaskawi/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/slaskawi/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slaskawi/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/slaskawi/infinispan/languages","stargazers_url":"https://api.github.com/repos/slaskawi/infinispan/stargazers","contributors_url":"https://api.github.com/repos/slaskawi/infinispan/contributors","subscribers_url":"https://api.github.com/repos/slaskawi/infinispan/subscribers","subscription_url":"https://api.github.com/repos/slaskawi/infinispan/subscription","commits_url":"https://api.github.com/repos/slaskawi/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/slaskawi/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/slaskawi/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/slaskawi/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/slaskawi/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/slaskawi/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slaskawi/infinispan/merges","archive_url":"https://api.github.com/repos/slaskawi/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slaskawi/infinispan/downloads","issues_url":"https://api.github.com/repos/slaskawi/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/slaskawi/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/slaskawi/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/slaskawi/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slaskawi/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/slaskawi/infinispan/releases{/id}","created_at":"2014-09-05T09:35:13Z","updated_at":"2015-01-22T12:12:41Z","pushed_at":"2015-03-20T12:49:14Z","git_url":"git://github.com/slaskawi/infinispan.git","ssh_url":"git@github.com:slaskawi/infinispan.git","clone_url":"https://github.com/slaskawi/infinispan.git","svn_url":"https://github.com/slaskawi/infinispan","homepage":"http://www.infinispan.org","size":69011,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"5a9132ec9a5c066253cddfd09c59e2c06c129e4c","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2015-03-24T09:16:32Z","pushed_at":"2015-03-24T10:36:28Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":139824,"stargazers_count":367,"watchers_count":367,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":17,"forks":277,"open_issues":17,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3317"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3317"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3317"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3317/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3317/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3317/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/1ce607923de2194da8a6da9b5d8aa3346ab51f1a"}}}}