{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/40426032","id":40426032,"diff_hunk":"@@ -0,0 +1,60 @@\n+﻿\"use strict\";\n+(function (root, factory) {\n+    if (typeof define === \"function\" && define.amd) {\n+        define([\"d3\", \"require\", \"./amchartFactory\", \"./c3chartFactory\", \"./chartFactory\", \"./commonFactory\", \"./formFactory\", \"./googleFactory\", \"./graphFactory\", \"./layoutFactory\", \"./mapFactory\", \"./marshallerFactory\", \"./otherFactory\", \"./treeFactory\"], factory);\n+    } else {\n+        root.test_Factory = factory(root.d3, root.require, root.test_amchartFactory, root.test_c3chartFactory, root.test_chartFactory, root.test_commonFactory, root.test_formFactory, root.test_googleFactory, root.test_graphFactory, root.test_layoutFactory, root.test_mapFactory, root.test_marshallerFactory, root.test_otherFactory, root.test_treeFactory);\n+    }\n+}(this, function (d3, require, amchartFactory, c3chartFactory, chartFactory, commonFactory, formFactory, googleFactory, graphFactory, layoutFactory, mapFactory, marshallerFactory, otherFactory, treeFactory) {\n+    var bundles = { common: commonFactory, chart: chartFactory, amchart: amchartFactory, google: googleFactory, c3chart: c3chartFactory, map: mapFactory, tree: treeFactory, graph: graphFactory, other: otherFactory, form: formFactory, layout: layoutFactory, marshaller: marshallerFactory };\n+    var bundlesCatMap = {};\n+    var bundlesWidgetMap = {};\n+    d3.map(bundles).entries().forEach(function (bundle) {\n+        var folderID = bundle.key;\n+        d3.map(bundle.value).entries().forEach(function (widget) {\n+            var widgetID = widget.key;\n+            d3.map(widget.value).entries().forEach(function (sample) {\n+                var sampleID = sample.key;\n+                var widgetPath = \"src/\" + folderID + \"/\" + widgetID;\n+                var widgetTestData = {\n+                    folder: folderID,\n+                    file: widgetID,\n+                    sample: sampleID,\n+                    widgetPath: widgetPath,","path":"test/Factory.js","position":23,"original_position":23,"commit_id":"5b996a0523a63ad803eb1fc5fe9eac36a1e2e167","original_commit_id":"5b996a0523a63ad803eb1fc5fe9eac36a1e2e167","user":{"login":"dtsnell4","id":4304235,"avatar_url":"https://avatars.githubusercontent.com/u/4304235?v=3","gravatar_id":"","url":"https://api.github.com/users/dtsnell4","html_url":"https://github.com/dtsnell4","followers_url":"https://api.github.com/users/dtsnell4/followers","following_url":"https://api.github.com/users/dtsnell4/following{/other_user}","gists_url":"https://api.github.com/users/dtsnell4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsnell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsnell4/subscriptions","organizations_url":"https://api.github.com/users/dtsnell4/orgs","repos_url":"https://api.github.com/users/dtsnell4/repos","events_url":"https://api.github.com/users/dtsnell4/events{/privacy}","received_events_url":"https://api.github.com/users/dtsnell4/received_events","type":"User","site_admin":false},"body":"@GordonSmith I have discovered what I believe is an issue with this line.  There is the possibility for some widgets, such as Composition, to not have a path (i.e. there is no \"src/common/Composition\").  This causes an issue when looping through all of of the widgets getting their paths, and I suspect would also when trying to create a Composition widget using createFunction() in Factory.js.  ","created_at":"2015-09-25T12:56:05Z","updated_at":"2015-09-25T12:56:05Z","html_url":"https://github.com/hpcc-systems/Visualization/pull/912#discussion_r40426032","pull_request_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/40426032"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/912#discussion_r40426032"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912","id":44595967,"html_url":"https://github.com/hpcc-systems/Visualization/pull/912","diff_url":"https://github.com/hpcc-systems/Visualization/pull/912.diff","patch_url":"https://github.com/hpcc-systems/Visualization/pull/912.patch","issue_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/912","number":912,"state":"closed","locked":false,"title":"GH-442 Refactor Widget testData call","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"Fixes GH-442\r\n\r\nSigned-off-by: Gordon Smith <gordon.smith@lexisnexis.com>","created_at":"2015-09-09T20:25:56Z","updated_at":"2015-09-25T12:56:05Z","closed_at":"2015-09-15T14:06:03Z","merged_at":"2015-09-15T14:06:03Z","merge_commit_sha":"e2e3feeb96e4bdb6c513ddf5da6d55287ffc86b5","assignee":null,"milestone":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones/13","html_url":"https://github.com/hpcc-systems/Visualization/milestones/1.8.0","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones/13/labels","id":1249469,"number":13,"title":"1.8.0","description":"","creator":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":39,"state":"open","created_at":"2015-08-11T05:42:31Z","updated_at":"2015-09-23T10:58:42Z","due_on":"2015-09-17T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/912/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/5b996a0523a63ad803eb1fc5fe9eac36a1e2e167","head":{"label":"GordonSmith:GH-442","ref":"GH-442","sha":"5b996a0523a63ad803eb1fc5fe9eac36a1e2e167","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"repo":{"id":22138152,"name":"Visualization","full_name":"GordonSmith/Visualization","owner":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GordonSmith/Visualization","description":"","fork":true,"url":"https://api.github.com/repos/GordonSmith/Visualization","forks_url":"https://api.github.com/repos/GordonSmith/Visualization/forks","keys_url":"https://api.github.com/repos/GordonSmith/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GordonSmith/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GordonSmith/Visualization/teams","hooks_url":"https://api.github.com/repos/GordonSmith/Visualization/hooks","issue_events_url":"https://api.github.com/repos/GordonSmith/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/GordonSmith/Visualization/events","assignees_url":"https://api.github.com/repos/GordonSmith/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/GordonSmith/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/GordonSmith/Visualization/tags","blobs_url":"https://api.github.com/repos/GordonSmith/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GordonSmith/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GordonSmith/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/GordonSmith/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GordonSmith/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/GordonSmith/Visualization/languages","stargazers_url":"https://api.github.com/repos/GordonSmith/Visualization/stargazers","contributors_url":"https://api.github.com/repos/GordonSmith/Visualization/contributors","subscribers_url":"https://api.github.com/repos/GordonSmith/Visualization/subscribers","subscription_url":"https://api.github.com/repos/GordonSmith/Visualization/subscription","commits_url":"https://api.github.com/repos/GordonSmith/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/GordonSmith/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/GordonSmith/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/GordonSmith/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/GordonSmith/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/GordonSmith/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GordonSmith/Visualization/merges","archive_url":"https://api.github.com/repos/GordonSmith/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GordonSmith/Visualization/downloads","issues_url":"https://api.github.com/repos/GordonSmith/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/GordonSmith/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/GordonSmith/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/GordonSmith/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GordonSmith/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/GordonSmith/Visualization/releases{/id}","created_at":"2014-07-23T08:23:34Z","updated_at":"2015-05-08T12:23:51Z","pushed_at":"2015-09-25T08:45:07Z","git_url":"git://github.com/GordonSmith/Visualization.git","ssh_url":"git@github.com:GordonSmith/Visualization.git","clone_url":"https://github.com/GordonSmith/Visualization.git","svn_url":"https://github.com/GordonSmith/Visualization","homepage":null,"size":10585,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-1.8.0","ref":"candidate-1.8.0","sha":"1e8a9ad69e48728c189cc389640b1d6d67a8cd20","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":22117259,"name":"Visualization","full_name":"hpcc-systems/Visualization","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/Visualization","description":"Common Visualization Components","fork":false,"url":"https://api.github.com/repos/hpcc-systems/Visualization","forks_url":"https://api.github.com/repos/hpcc-systems/Visualization/forks","keys_url":"https://api.github.com/repos/hpcc-systems/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/Visualization/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/Visualization/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/Visualization/events","assignees_url":"https://api.github.com/repos/hpcc-systems/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/Visualization/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/Visualization/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/Visualization/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/Visualization/merges","archive_url":"https://api.github.com/repos/hpcc-systems/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/Visualization/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/Visualization/releases{/id}","created_at":"2014-07-22T19:13:04Z","updated_at":"2015-09-03T17:59:15Z","pushed_at":"2015-09-23T15:13:29Z","git_url":"git://github.com/hpcc-systems/Visualization.git","ssh_url":"git@github.com:hpcc-systems/Visualization.git","clone_url":"https://github.com/hpcc-systems/Visualization.git","svn_url":"https://github.com/hpcc-systems/Visualization","homepage":"","size":19844,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":83,"forks":22,"open_issues":83,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/912"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/912"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/912/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/912/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/5b996a0523a63ad803eb1fc5fe9eac36a1e2e167"}}}}