{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/33","id":26852180,"html_url":"https://github.com/opentechinstitute/mlab-observatory/pull/33","diff_url":"https://github.com/opentechinstitute/mlab-observatory/pull/33.diff","patch_url":"https://github.com/opentechinstitute/mlab-observatory/pull/33.patch","issue_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues/33","number":33,"state":"closed","locked":false,"title":"Various updates","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"body":"I wrote a bunch of code over the holiday slowdown thinking that I could use git magic later to group the commits into neat, cohesive pull requests, but it turns out it's not so easy to do that so my pull requests got a little convoluted and I apologize. This pull request does the following:\r\n\r\n* Fixes sample_checking.py to use the `SingleTelescopeResultReader` class to parse Telescope input files (previously it used the `parse_filename_for_metadata` and `parse_data_file` but these are now module private - insofar as naming conventionsl let us pretend things are private).\r\n\r\n* Changes `TelescopeResultReader` so that it's an iterator over all the parsed rows (like the Python file `open` API is with lines of text) instead of the caller having to call `read_rows`. Now functions that are expecting a list of raw Telescope data rows can receive a `TelescopeResultReader` and not know the difference.\r\n  * As a result of the above, we update `sample_checking.py` to just pass along a `TelescopeResultReader` object when it calls `add_to_counts()` instead of having to explicitly call `read_rows`.\r\n\r\nYou're welcome to review the pull request commit-by-commit if it's easier (though I will generally try to prevent making pull requests where you have to do that because it's usually a pain)","created_at":"2015-01-05T21:26:13Z","updated_at":"2015-01-06T16:06:38Z","closed_at":"2015-01-06T16:06:38Z","merged_at":"2015-01-06T16:06:38Z","merge_commit_sha":"318cd9c198c59c0119578965dba4db4c937111f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/33/commits","review_comments_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/33/comments","review_comment_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues/33/comments","statuses_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/statuses/d644ac0179316f0904fdd793efe412cc9e955592","head":{"label":"mtlynch:reader-iterator","ref":"reader-iterator","sha":"d644ac0179316f0904fdd793efe412cc9e955592","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"repo":{"id":26779674,"name":"mlab-observatory","full_name":"mtlynch/mlab-observatory","owner":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtlynch/mlab-observatory","description":"","fork":true,"url":"https://api.github.com/repos/mtlynch/mlab-observatory","forks_url":"https://api.github.com/repos/mtlynch/mlab-observatory/forks","keys_url":"https://api.github.com/repos/mtlynch/mlab-observatory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtlynch/mlab-observatory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtlynch/mlab-observatory/teams","hooks_url":"https://api.github.com/repos/mtlynch/mlab-observatory/hooks","issue_events_url":"https://api.github.com/repos/mtlynch/mlab-observatory/issues/events{/number}","events_url":"https://api.github.com/repos/mtlynch/mlab-observatory/events","assignees_url":"https://api.github.com/repos/mtlynch/mlab-observatory/assignees{/user}","branches_url":"https://api.github.com/repos/mtlynch/mlab-observatory/branches{/branch}","tags_url":"https://api.github.com/repos/mtlynch/mlab-observatory/tags","blobs_url":"https://api.github.com/repos/mtlynch/mlab-observatory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtlynch/mlab-observatory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtlynch/mlab-observatory/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtlynch/mlab-observatory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtlynch/mlab-observatory/statuses/{sha}","languages_url":"https://api.github.com/repos/mtlynch/mlab-observatory/languages","stargazers_url":"https://api.github.com/repos/mtlynch/mlab-observatory/stargazers","contributors_url":"https://api.github.com/repos/mtlynch/mlab-observatory/contributors","subscribers_url":"https://api.github.com/repos/mtlynch/mlab-observatory/subscribers","subscription_url":"https://api.github.com/repos/mtlynch/mlab-observatory/subscription","commits_url":"https://api.github.com/repos/mtlynch/mlab-observatory/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtlynch/mlab-observatory/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtlynch/mlab-observatory/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtlynch/mlab-observatory/issues/comments/{number}","contents_url":"https://api.github.com/repos/mtlynch/mlab-observatory/contents/{+path}","compare_url":"https://api.github.com/repos/mtlynch/mlab-observatory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtlynch/mlab-observatory/merges","archive_url":"https://api.github.com/repos/mtlynch/mlab-observatory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtlynch/mlab-observatory/downloads","issues_url":"https://api.github.com/repos/mtlynch/mlab-observatory/issues{/number}","pulls_url":"https://api.github.com/repos/mtlynch/mlab-observatory/pulls{/number}","milestones_url":"https://api.github.com/repos/mtlynch/mlab-observatory/milestones{/number}","notifications_url":"https://api.github.com/repos/mtlynch/mlab-observatory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtlynch/mlab-observatory/labels{/name}","releases_url":"https://api.github.com/repos/mtlynch/mlab-observatory/releases{/id}","created_at":"2014-11-17T22:08:50Z","updated_at":"2015-01-05T16:24:04Z","pushed_at":"2015-01-06T16:05:16Z","git_url":"git://github.com/mtlynch/mlab-observatory.git","ssh_url":"git@github.com:mtlynch/mlab-observatory.git","clone_url":"https://github.com/mtlynch/mlab-observatory.git","svn_url":"https://github.com/mtlynch/mlab-observatory","homepage":null,"size":10107,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentechinstitute:master","ref":"master","sha":"3e9092780d61607ac4ea564795890d6d3698815f","user":{"login":"opentechinstitute","id":1743675,"avatar_url":"https://avatars.githubusercontent.com/u/1743675?v=3","gravatar_id":"","url":"https://api.github.com/users/opentechinstitute","html_url":"https://github.com/opentechinstitute","followers_url":"https://api.github.com/users/opentechinstitute/followers","following_url":"https://api.github.com/users/opentechinstitute/following{/other_user}","gists_url":"https://api.github.com/users/opentechinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/opentechinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentechinstitute/subscriptions","organizations_url":"https://api.github.com/users/opentechinstitute/orgs","repos_url":"https://api.github.com/users/opentechinstitute/repos","events_url":"https://api.github.com/users/opentechinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/opentechinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":22655633,"name":"mlab-observatory","full_name":"opentechinstitute/mlab-observatory","owner":{"login":"opentechinstitute","id":1743675,"avatar_url":"https://avatars.githubusercontent.com/u/1743675?v=3","gravatar_id":"","url":"https://api.github.com/users/opentechinstitute","html_url":"https://github.com/opentechinstitute","followers_url":"https://api.github.com/users/opentechinstitute/followers","following_url":"https://api.github.com/users/opentechinstitute/following{/other_user}","gists_url":"https://api.github.com/users/opentechinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/opentechinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentechinstitute/subscriptions","organizations_url":"https://api.github.com/users/opentechinstitute/orgs","repos_url":"https://api.github.com/users/opentechinstitute/repos","events_url":"https://api.github.com/users/opentechinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/opentechinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentechinstitute/mlab-observatory","description":"","fork":false,"url":"https://api.github.com/repos/opentechinstitute/mlab-observatory","forks_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/forks","keys_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/teams","hooks_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/hooks","issue_events_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues/events{/number}","events_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/events","assignees_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/assignees{/user}","branches_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/branches{/branch}","tags_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/tags","blobs_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/statuses/{sha}","languages_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/languages","stargazers_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/stargazers","contributors_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/contributors","subscribers_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/subscribers","subscription_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/subscription","commits_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues/comments/{number}","contents_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/contents/{+path}","compare_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/merges","archive_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/downloads","issues_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues{/number}","pulls_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls{/number}","milestones_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/milestones{/number}","notifications_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/labels{/name}","releases_url":"https://api.github.com/repos/opentechinstitute/mlab-observatory/releases{/id}","created_at":"2014-08-05T18:59:12Z","updated_at":"2015-01-06T16:06:38Z","pushed_at":"2015-01-06T16:06:38Z","git_url":"git://github.com/opentechinstitute/mlab-observatory.git","ssh_url":"git@github.com:opentechinstitute/mlab-observatory.git","clone_url":"https://github.com/opentechinstitute/mlab-observatory.git","svn_url":"https://github.com/opentechinstitute/mlab-observatory","homepage":null,"size":10803,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/33"},"html":{"href":"https://github.com/opentechinstitute/mlab-observatory/pull/33"},"issue":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues/33"},"comments":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/opentechinstitute/mlab-observatory/statuses/d644ac0179316f0904fdd793efe412cc9e955592"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":132,"deletions":88,"changed_files":5}}