{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12866","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12866/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12866/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12866/events","html_url":"https://github.com/kubernetes/kubernetes/issues/12866","id":101699336,"number":12866,"title":"Add more probe control parameters","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/api","name":"area/api","color":"e1ed21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"closed","locked":false,"assignee":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/16","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2-candidate","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/16/labels","id":1278500,"number":16,"title":"v1.2-candidate","description":"Things to consider for next minor release.","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":183,"closed_issues":16,"state":"open","created_at":"2015-08-29T03:54:34Z","updated_at":"2015-11-07T09:35:19Z","due_on":null,"closed_at":null},"comments":22,"created_at":"2015-08-18T16:50:41Z","updated_at":"2015-11-07T09:35:19Z","closed_at":"2015-11-07T09:35:19Z","body":"Resurrected from #66 and #761.\r\n\r\nProbe currently supports the following control parameters:\r\n```\r\n\t// Length of time before health checking is activated.  In seconds.\r\n\tInitialDelaySeconds int64 `json:\"initialDelaySeconds,omitempty\" description:\"number of seconds after the container has started before liveness probes are initiated; see http://releases.k8s.io/HEAD/docs/user-guide/pod-states.md#container-probes\"`\r\n\t// Length of time before health checking times out.  In seconds.\r\n\tTimeoutSeconds int64 `json:\"timeoutSeconds,omitempty\" description:\"number of seconds after which liveness probes timeout; defaults to 1 second; see http://releases.k8s.io/HEAD/docs/user-guide/pod-states.md#container-probes\"`\r\n```\r\n\r\nWe should add the following common control parameters (matching, for instance, [AppEngine's parameters](https://cloud.google.com/appengine/docs/managed-vms/config#health_checking) and [GCE's parameters](https://cloud.google.com/compute/docs/reference/latest/httpHealthChecks)):\r\n```\r\n// How often to probe\r\nPeriodSeconds *int64\r\n// Minimum consecutive successes for the probe to be considered successful after having reached the FailureThreshold; defaults to 1; must be 1 for liveness \r\nSuccessThreshold *int\r\n// Minimum consecutive failures for the probe to be considered failed; defaults to 1\r\nFailureThreshold *int\r\n```\r\n\r\nAt some point we'll probably want to add an enable/disable boolean, since it's convenient to be able to disable liveness probes without losing the parameter settings, but that's less critical than the above."}}