{"action":"created","comment":{"url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/comments/43188792","id":43188792,"diff_hunk":"@@ -151,8 +155,12 @@ function GeometrySet GeometryStack.evaluate!(EvalContext context) {\n         Generator generator = op;\n         if(generator)\n           cachePoint = GeometryCache();\n-        else\n-          cachePoint = GeometryAttributeCache(op);\n+        else // modifier\n+        {\n+          // #8 Bugfix: Explicit type cast for interfaces in KL, otherwise GeometryAttributeCache returns null\n+          BaseModifier mod = op; \n+          cachePoint = GeometryAttributeCache(mod);\n+        }\n         this.cachePoints[i] = cachePoint;","path":"Ext/GeometryStack/GeometryStack.kl","position":78,"original_position":78,"commit_id":"9a4508505f060c52e61b1db3468f5f04698b14e7","original_commit_id":"9a4508505f060c52e61b1db3468f5f04698b14e7","user":{"login":"phtaylor","id":840121,"avatar_url":"https://avatars.githubusercontent.com/u/840121?v=3","gravatar_id":"","url":"https://api.github.com/users/phtaylor","html_url":"https://github.com/phtaylor","followers_url":"https://api.github.com/users/phtaylor/followers","following_url":"https://api.github.com/users/phtaylor/following{/other_user}","gists_url":"https://api.github.com/users/phtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/phtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phtaylor/subscriptions","organizations_url":"https://api.github.com/users/phtaylor/orgs","repos_url":"https://api.github.com/users/phtaylor/repos","events_url":"https://api.github.com/users/phtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/phtaylor/received_events","type":"User","site_admin":false},"body":"this is an interesting change in behavior for the 2.X compiler. I have been noticing errors like these, but didn't determine what the exact cause was. What is happening, is GeometryAttributeCache(op) gets treated like a 'casting' instead of a constructor. (yes, that is quite ambiguous). My work around was always to add an extra integer arg to the constructors so it would look like this: GeometryAttributeCache(op, 3), forcing it to not turn into a cast. ","created_at":"2015-10-27T21:17:24Z","updated_at":"2015-10-27T21:17:24Z","html_url":"https://github.com/fabric-engine/RiggingToolbox/pull/9#discussion_r43188792","pull_request_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/comments/43188792"},"html":{"href":"https://github.com/fabric-engine/RiggingToolbox/pull/9#discussion_r43188792"},"pull_request":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9","id":48689369,"html_url":"https://github.com/fabric-engine/RiggingToolbox/pull/9","diff_url":"https://github.com/fabric-engine/RiggingToolbox/pull/9.diff","patch_url":"https://github.com/fabric-engine/RiggingToolbox/pull/9.patch","issue_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues/9","number":9,"state":"open","locked":false,"title":"Pablo","user":{"login":"BigRoy","id":2439881,"avatar_url":"https://avatars.githubusercontent.com/u/2439881?v=3","gravatar_id":"","url":"https://api.github.com/users/BigRoy","html_url":"https://github.com/BigRoy","followers_url":"https://api.github.com/users/BigRoy/followers","following_url":"https://api.github.com/users/BigRoy/following{/other_user}","gists_url":"https://api.github.com/users/BigRoy/gists{/gist_id}","starred_url":"https://api.github.com/users/BigRoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigRoy/subscriptions","organizations_url":"https://api.github.com/users/BigRoy/orgs","repos_url":"https://api.github.com/users/BigRoy/repos","events_url":"https://api.github.com/users/BigRoy/events{/privacy}","received_events_url":"https://api.github.com/users/BigRoy/received_events","type":"User","site_admin":false},"body":"Changes to make RiggingToolbox functional in Fabric Engine 2.0 (Pablo) and Canvas.\r\n\r\n- Fix 2.0 incompatibility issues. (Also see #8)\r\n- Add parentheses to method calls to avoid deprecated syntax\r\n- Some minor bugfixes\r\n- Tested functionality by rebuilding graph from one of the examples, see [test video](https://twitter.com/Royn3D/status/658385300062904320)\r\n\r\nOnce merged next step would be adding Canvas presets and examples; other than that code seems to be fully functional right now.","created_at":"2015-10-25T22:11:22Z","updated_at":"2015-10-27T21:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a89fd52355a1b3eb2705d1f570a19c5bb1061201","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9/commits","review_comments_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9/comments","review_comment_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues/9/comments","statuses_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/statuses/9a4508505f060c52e61b1db3468f5f04698b14e7","head":{"label":"BigRoy:pablo","ref":"pablo","sha":"9a4508505f060c52e61b1db3468f5f04698b14e7","user":{"login":"BigRoy","id":2439881,"avatar_url":"https://avatars.githubusercontent.com/u/2439881?v=3","gravatar_id":"","url":"https://api.github.com/users/BigRoy","html_url":"https://github.com/BigRoy","followers_url":"https://api.github.com/users/BigRoy/followers","following_url":"https://api.github.com/users/BigRoy/following{/other_user}","gists_url":"https://api.github.com/users/BigRoy/gists{/gist_id}","starred_url":"https://api.github.com/users/BigRoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigRoy/subscriptions","organizations_url":"https://api.github.com/users/BigRoy/orgs","repos_url":"https://api.github.com/users/BigRoy/repos","events_url":"https://api.github.com/users/BigRoy/events{/privacy}","received_events_url":"https://api.github.com/users/BigRoy/received_events","type":"User","site_admin":false},"repo":{"id":44841102,"name":"RiggingToolbox","full_name":"BigRoy/RiggingToolbox","owner":{"login":"BigRoy","id":2439881,"avatar_url":"https://avatars.githubusercontent.com/u/2439881?v=3","gravatar_id":"","url":"https://api.github.com/users/BigRoy","html_url":"https://github.com/BigRoy","followers_url":"https://api.github.com/users/BigRoy/followers","following_url":"https://api.github.com/users/BigRoy/following{/other_user}","gists_url":"https://api.github.com/users/BigRoy/gists{/gist_id}","starred_url":"https://api.github.com/users/BigRoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigRoy/subscriptions","organizations_url":"https://api.github.com/users/BigRoy/orgs","repos_url":"https://api.github.com/users/BigRoy/repos","events_url":"https://api.github.com/users/BigRoy/events{/privacy}","received_events_url":"https://api.github.com/users/BigRoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BigRoy/RiggingToolbox","description":"Useful services for rigging using Fabric Engine","fork":true,"url":"https://api.github.com/repos/BigRoy/RiggingToolbox","forks_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/forks","keys_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/teams","hooks_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/hooks","issue_events_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/issues/events{/number}","events_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/events","assignees_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/assignees{/user}","branches_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/branches{/branch}","tags_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/tags","blobs_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/languages","stargazers_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/stargazers","contributors_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/contributors","subscribers_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/subscribers","subscription_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/subscription","commits_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/contents/{+path}","compare_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/merges","archive_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/downloads","issues_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/issues{/number}","pulls_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/labels{/name}","releases_url":"https://api.github.com/repos/BigRoy/RiggingToolbox/releases{/id}","created_at":"2015-10-23T22:07:41Z","updated_at":"2015-10-23T22:07:42Z","pushed_at":"2015-10-26T19:29:18Z","git_url":"git://github.com/BigRoy/RiggingToolbox.git","ssh_url":"git@github.com:BigRoy/RiggingToolbox.git","clone_url":"https://github.com/BigRoy/RiggingToolbox.git","svn_url":"https://github.com/BigRoy/RiggingToolbox","homepage":"","size":1103,"stargazers_count":0,"watchers_count":0,"language":"Mathematica","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rivera"}},"base":{"label":"fabric-engine:pablo","ref":"pablo","sha":"63f0b5398f1a59eeb22787877aa0e9dd306762d3","user":{"login":"fabric-engine","id":724960,"avatar_url":"https://avatars.githubusercontent.com/u/724960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric-engine","html_url":"https://github.com/fabric-engine","followers_url":"https://api.github.com/users/fabric-engine/followers","following_url":"https://api.github.com/users/fabric-engine/following{/other_user}","gists_url":"https://api.github.com/users/fabric-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric-engine/subscriptions","organizations_url":"https://api.github.com/users/fabric-engine/orgs","repos_url":"https://api.github.com/users/fabric-engine/repos","events_url":"https://api.github.com/users/fabric-engine/events{/privacy}","received_events_url":"https://api.github.com/users/fabric-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":24109657,"name":"RiggingToolbox","full_name":"fabric-engine/RiggingToolbox","owner":{"login":"fabric-engine","id":724960,"avatar_url":"https://avatars.githubusercontent.com/u/724960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric-engine","html_url":"https://github.com/fabric-engine","followers_url":"https://api.github.com/users/fabric-engine/followers","following_url":"https://api.github.com/users/fabric-engine/following{/other_user}","gists_url":"https://api.github.com/users/fabric-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric-engine/subscriptions","organizations_url":"https://api.github.com/users/fabric-engine/orgs","repos_url":"https://api.github.com/users/fabric-engine/repos","events_url":"https://api.github.com/users/fabric-engine/events{/privacy}","received_events_url":"https://api.github.com/users/fabric-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric-engine/RiggingToolbox","description":"Useful services for rigging using Fabric Engine","fork":false,"url":"https://api.github.com/repos/fabric-engine/RiggingToolbox","forks_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/forks","keys_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/teams","hooks_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/hooks","issue_events_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues/events{/number}","events_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/events","assignees_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/assignees{/user}","branches_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/branches{/branch}","tags_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/tags","blobs_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/languages","stargazers_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/stargazers","contributors_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/contributors","subscribers_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/subscribers","subscription_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/subscription","commits_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/contents/{+path}","compare_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/merges","archive_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/downloads","issues_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues{/number}","pulls_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/labels{/name}","releases_url":"https://api.github.com/repos/fabric-engine/RiggingToolbox/releases{/id}","created_at":"2014-09-16T17:20:28Z","updated_at":"2015-10-25T17:17:12Z","pushed_at":"2015-10-27T14:48:19Z","git_url":"git://github.com/fabric-engine/RiggingToolbox.git","ssh_url":"git@github.com:fabric-engine/RiggingToolbox.git","clone_url":"https://github.com/fabric-engine/RiggingToolbox.git","svn_url":"https://github.com/fabric-engine/RiggingToolbox","homepage":"","size":1335,"stargazers_count":31,"watchers_count":31,"language":"Mathematica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":3,"forks":22,"open_issues":3,"watchers":31,"default_branch":"rivera"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9"},"html":{"href":"https://github.com/fabric-engine/RiggingToolbox/pull/9"},"issue":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues/9"},"comments":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/fabric-engine/RiggingToolbox/statuses/9a4508505f060c52e61b1db3468f5f04698b14e7"}}}}