{"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/uyjulian/spc2it/pulls/6","id":34637567,"html_url":"https://github.com/uyjulian/spc2it/pull/6","diff_url":"https://github.com/uyjulian/spc2it/pull/6.diff","patch_url":"https://github.com/uyjulian/spc2it/pull/6.patch","issue_url":"https://api.github.com/repos/uyjulian/spc2it/issues/6","number":6,"state":"open","locked":false,"title":"Make sure length isn't set before using default","user":{"login":"valsu","id":12234737,"avatar_url":"https://avatars.githubusercontent.com/u/12234737?v=3","gravatar_id":"","url":"https://api.github.com/users/valsu","html_url":"https://github.com/valsu","followers_url":"https://api.github.com/users/valsu/followers","following_url":"https://api.github.com/users/valsu/following{/other_user}","gists_url":"https://api.github.com/users/valsu/gists{/gist_id}","starred_url":"https://api.github.com/users/valsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valsu/subscriptions","organizations_url":"https://api.github.com/users/valsu/orgs","repos_url":"https://api.github.com/users/valsu/repos","events_url":"https://api.github.com/users/valsu/events{/privacy}","received_events_url":"https://api.github.com/users/valsu/received_events","type":"User","site_admin":false},"body":"`if' should be `else if', or else there's a logical error within the parameter check: That is, if both limit and SPCtime are not set, limit will be set to 60, even if the user has provided a custom track length via the `-t' parameter.","created_at":"2015-05-04T13:34:42Z","updated_at":"2015-05-04T13:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uyjulian/spc2it/pulls/6/commits","review_comments_url":"https://api.github.com/repos/uyjulian/spc2it/pulls/6/comments","review_comment_url":"https://api.github.com/repos/uyjulian/spc2it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uyjulian/spc2it/issues/6/comments","statuses_url":"https://api.github.com/repos/uyjulian/spc2it/statuses/980155837ac143e6600e20adc841ab2a90fef802","head":{"label":"valsu:patch-1","ref":"patch-1","sha":"980155837ac143e6600e20adc841ab2a90fef802","user":{"login":"valsu","id":12234737,"avatar_url":"https://avatars.githubusercontent.com/u/12234737?v=3","gravatar_id":"","url":"https://api.github.com/users/valsu","html_url":"https://github.com/valsu","followers_url":"https://api.github.com/users/valsu/followers","following_url":"https://api.github.com/users/valsu/following{/other_user}","gists_url":"https://api.github.com/users/valsu/gists{/gist_id}","starred_url":"https://api.github.com/users/valsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valsu/subscriptions","organizations_url":"https://api.github.com/users/valsu/orgs","repos_url":"https://api.github.com/users/valsu/repos","events_url":"https://api.github.com/users/valsu/events{/privacy}","received_events_url":"https://api.github.com/users/valsu/received_events","type":"User","site_admin":false},"repo":{"id":35036250,"name":"spc2it","full_name":"valsu/spc2it","owner":{"login":"valsu","id":12234737,"avatar_url":"https://avatars.githubusercontent.com/u/12234737?v=3","gravatar_id":"","url":"https://api.github.com/users/valsu","html_url":"https://github.com/valsu","followers_url":"https://api.github.com/users/valsu/followers","following_url":"https://api.github.com/users/valsu/following{/other_user}","gists_url":"https://api.github.com/users/valsu/gists{/gist_id}","starred_url":"https://api.github.com/users/valsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valsu/subscriptions","organizations_url":"https://api.github.com/users/valsu/orgs","repos_url":"https://api.github.com/users/valsu/repos","events_url":"https://api.github.com/users/valsu/events{/privacy}","received_events_url":"https://api.github.com/users/valsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valsu/spc2it","description":"Convert SPC files to IT (Impulse Tracker) files, #spc2it on freenode","fork":true,"url":"https://api.github.com/repos/valsu/spc2it","forks_url":"https://api.github.com/repos/valsu/spc2it/forks","keys_url":"https://api.github.com/repos/valsu/spc2it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valsu/spc2it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valsu/spc2it/teams","hooks_url":"https://api.github.com/repos/valsu/spc2it/hooks","issue_events_url":"https://api.github.com/repos/valsu/spc2it/issues/events{/number}","events_url":"https://api.github.com/repos/valsu/spc2it/events","assignees_url":"https://api.github.com/repos/valsu/spc2it/assignees{/user}","branches_url":"https://api.github.com/repos/valsu/spc2it/branches{/branch}","tags_url":"https://api.github.com/repos/valsu/spc2it/tags","blobs_url":"https://api.github.com/repos/valsu/spc2it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valsu/spc2it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valsu/spc2it/git/refs{/sha}","trees_url":"https://api.github.com/repos/valsu/spc2it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valsu/spc2it/statuses/{sha}","languages_url":"https://api.github.com/repos/valsu/spc2it/languages","stargazers_url":"https://api.github.com/repos/valsu/spc2it/stargazers","contributors_url":"https://api.github.com/repos/valsu/spc2it/contributors","subscribers_url":"https://api.github.com/repos/valsu/spc2it/subscribers","subscription_url":"https://api.github.com/repos/valsu/spc2it/subscription","commits_url":"https://api.github.com/repos/valsu/spc2it/commits{/sha}","git_commits_url":"https://api.github.com/repos/valsu/spc2it/git/commits{/sha}","comments_url":"https://api.github.com/repos/valsu/spc2it/comments{/number}","issue_comment_url":"https://api.github.com/repos/valsu/spc2it/issues/comments{/number}","contents_url":"https://api.github.com/repos/valsu/spc2it/contents/{+path}","compare_url":"https://api.github.com/repos/valsu/spc2it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valsu/spc2it/merges","archive_url":"https://api.github.com/repos/valsu/spc2it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valsu/spc2it/downloads","issues_url":"https://api.github.com/repos/valsu/spc2it/issues{/number}","pulls_url":"https://api.github.com/repos/valsu/spc2it/pulls{/number}","milestones_url":"https://api.github.com/repos/valsu/spc2it/milestones{/number}","notifications_url":"https://api.github.com/repos/valsu/spc2it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valsu/spc2it/labels{/name}","releases_url":"https://api.github.com/repos/valsu/spc2it/releases{/id}","created_at":"2015-05-04T13:26:48Z","updated_at":"2015-05-04T13:26:49Z","pushed_at":"2015-05-04T13:34:17Z","git_url":"git://github.com/valsu/spc2it.git","ssh_url":"git@github.com:valsu/spc2it.git","clone_url":"https://github.com/valsu/spc2it.git","svn_url":"https://github.com/valsu/spc2it","homepage":"","size":304,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uyjulian:master","ref":"master","sha":"d3d1b524032f668be8ee20d25339e1c635fb9bcf","user":{"login":"uyjulian","id":1689374,"avatar_url":"https://avatars.githubusercontent.com/u/1689374?v=3","gravatar_id":"","url":"https://api.github.com/users/uyjulian","html_url":"https://github.com/uyjulian","followers_url":"https://api.github.com/users/uyjulian/followers","following_url":"https://api.github.com/users/uyjulian/following{/other_user}","gists_url":"https://api.github.com/users/uyjulian/gists{/gist_id}","starred_url":"https://api.github.com/users/uyjulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyjulian/subscriptions","organizations_url":"https://api.github.com/users/uyjulian/orgs","repos_url":"https://api.github.com/users/uyjulian/repos","events_url":"https://api.github.com/users/uyjulian/events{/privacy}","received_events_url":"https://api.github.com/users/uyjulian/received_events","type":"User","site_admin":false},"repo":{"id":28649037,"name":"spc2it","full_name":"uyjulian/spc2it","owner":{"login":"uyjulian","id":1689374,"avatar_url":"https://avatars.githubusercontent.com/u/1689374?v=3","gravatar_id":"","url":"https://api.github.com/users/uyjulian","html_url":"https://github.com/uyjulian","followers_url":"https://api.github.com/users/uyjulian/followers","following_url":"https://api.github.com/users/uyjulian/following{/other_user}","gists_url":"https://api.github.com/users/uyjulian/gists{/gist_id}","starred_url":"https://api.github.com/users/uyjulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyjulian/subscriptions","organizations_url":"https://api.github.com/users/uyjulian/orgs","repos_url":"https://api.github.com/users/uyjulian/repos","events_url":"https://api.github.com/users/uyjulian/events{/privacy}","received_events_url":"https://api.github.com/users/uyjulian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uyjulian/spc2it","description":"Convert SPC files to IT (Impulse Tracker) files, #spc2it on freenode","fork":false,"url":"https://api.github.com/repos/uyjulian/spc2it","forks_url":"https://api.github.com/repos/uyjulian/spc2it/forks","keys_url":"https://api.github.com/repos/uyjulian/spc2it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uyjulian/spc2it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uyjulian/spc2it/teams","hooks_url":"https://api.github.com/repos/uyjulian/spc2it/hooks","issue_events_url":"https://api.github.com/repos/uyjulian/spc2it/issues/events{/number}","events_url":"https://api.github.com/repos/uyjulian/spc2it/events","assignees_url":"https://api.github.com/repos/uyjulian/spc2it/assignees{/user}","branches_url":"https://api.github.com/repos/uyjulian/spc2it/branches{/branch}","tags_url":"https://api.github.com/repos/uyjulian/spc2it/tags","blobs_url":"https://api.github.com/repos/uyjulian/spc2it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uyjulian/spc2it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uyjulian/spc2it/git/refs{/sha}","trees_url":"https://api.github.com/repos/uyjulian/spc2it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uyjulian/spc2it/statuses/{sha}","languages_url":"https://api.github.com/repos/uyjulian/spc2it/languages","stargazers_url":"https://api.github.com/repos/uyjulian/spc2it/stargazers","contributors_url":"https://api.github.com/repos/uyjulian/spc2it/contributors","subscribers_url":"https://api.github.com/repos/uyjulian/spc2it/subscribers","subscription_url":"https://api.github.com/repos/uyjulian/spc2it/subscription","commits_url":"https://api.github.com/repos/uyjulian/spc2it/commits{/sha}","git_commits_url":"https://api.github.com/repos/uyjulian/spc2it/git/commits{/sha}","comments_url":"https://api.github.com/repos/uyjulian/spc2it/comments{/number}","issue_comment_url":"https://api.github.com/repos/uyjulian/spc2it/issues/comments{/number}","contents_url":"https://api.github.com/repos/uyjulian/spc2it/contents/{+path}","compare_url":"https://api.github.com/repos/uyjulian/spc2it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uyjulian/spc2it/merges","archive_url":"https://api.github.com/repos/uyjulian/spc2it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uyjulian/spc2it/downloads","issues_url":"https://api.github.com/repos/uyjulian/spc2it/issues{/number}","pulls_url":"https://api.github.com/repos/uyjulian/spc2it/pulls{/number}","milestones_url":"https://api.github.com/repos/uyjulian/spc2it/milestones{/number}","notifications_url":"https://api.github.com/repos/uyjulian/spc2it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uyjulian/spc2it/labels{/name}","releases_url":"https://api.github.com/repos/uyjulian/spc2it/releases{/id}","created_at":"2014-12-30T23:28:00Z","updated_at":"2015-03-19T13:29:38Z","pushed_at":"2015-05-04T13:34:42Z","git_url":"git://github.com/uyjulian/spc2it.git","ssh_url":"git@github.com:uyjulian/spc2it.git","clone_url":"https://github.com/uyjulian/spc2it.git","svn_url":"https://github.com/uyjulian/spc2it","homepage":"","size":304,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uyjulian/spc2it/pulls/6"},"html":{"href":"https://github.com/uyjulian/spc2it/pull/6"},"issue":{"href":"https://api.github.com/repos/uyjulian/spc2it/issues/6"},"comments":{"href":"https://api.github.com/repos/uyjulian/spc2it/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/uyjulian/spc2it/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/uyjulian/spc2it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uyjulian/spc2it/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/uyjulian/spc2it/statuses/980155837ac143e6600e20adc841ab2a90fef802"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}