{"action":"closed","number":237,"pull_request":{"url":"https://api.github.com/repos/rubyzip/rubyzip/pulls/237","id":38466941,"html_url":"https://github.com/rubyzip/rubyzip/pull/237","diff_url":"https://github.com/rubyzip/rubyzip/pull/237.diff","patch_url":"https://github.com/rubyzip/rubyzip/pull/237.patch","issue_url":"https://api.github.com/repos/rubyzip/rubyzip/issues/237","number":237,"state":"closed","locked":false,"title":"Do something more expected with new file permissions.","user":{"login":"hainesr","id":143558,"avatar_url":"https://avatars.githubusercontent.com/u/143558?v=3","gravatar_id":"","url":"https://api.github.com/users/hainesr","html_url":"https://github.com/hainesr","followers_url":"https://api.github.com/users/hainesr/followers","following_url":"https://api.github.com/users/hainesr/following{/other_user}","gists_url":"https://api.github.com/users/hainesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hainesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainesr/subscriptions","organizations_url":"https://api.github.com/users/hainesr/orgs","repos_url":"https://api.github.com/users/hainesr/repos","events_url":"https://api.github.com/users/hainesr/events{/privacy}","received_events_url":"https://api.github.com/users/hainesr/received_events","type":"User","site_admin":false},"body":"This fixes #204.\r\n\r\nInstead of inheriting the permissions from the tmp directory, new files should\r\nhave permissions that reflect the defaults on the system taking umask into\r\naccount.\r\n\r\nIt seems that (unix) permissions of 666 - umask are as close to a standard as\r\nanything [1] and that 'touch' uses this. On Windows it seems sensible to just\r\nuse 644 directly [2].\r\n\r\n[1] http://unix.stackexchange.com/a/102080\r\n[2] http://ruby-doc.org/core-1.9.3/File.html","created_at":"2015-06-24T17:34:46Z","updated_at":"2015-06-25T06:13:10Z","closed_at":"2015-06-25T06:13:10Z","merged_at":"2015-06-25T06:13:10Z","merge_commit_sha":"f3393a4c1f5d8ad721da781183c4f592f1dccb28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rubyzip/rubyzip/pulls/237/commits","review_comments_url":"https://api.github.com/repos/rubyzip/rubyzip/pulls/237/comments","review_comment_url":"https://api.github.com/repos/rubyzip/rubyzip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyzip/rubyzip/issues/237/comments","statuses_url":"https://api.github.com/repos/rubyzip/rubyzip/statuses/8edb2bd6e6d12e51dd2c2d9a1c1f3d712a097c38","head":{"label":"hainesr:create-file-perms","ref":"create-file-perms","sha":"8edb2bd6e6d12e51dd2c2d9a1c1f3d712a097c38","user":{"login":"hainesr","id":143558,"avatar_url":"https://avatars.githubusercontent.com/u/143558?v=3","gravatar_id":"","url":"https://api.github.com/users/hainesr","html_url":"https://github.com/hainesr","followers_url":"https://api.github.com/users/hainesr/followers","following_url":"https://api.github.com/users/hainesr/following{/other_user}","gists_url":"https://api.github.com/users/hainesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hainesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainesr/subscriptions","organizations_url":"https://api.github.com/users/hainesr/orgs","repos_url":"https://api.github.com/users/hainesr/repos","events_url":"https://api.github.com/users/hainesr/events{/privacy}","received_events_url":"https://api.github.com/users/hainesr/received_events","type":"User","site_admin":false},"repo":{"id":21067525,"name":"rubyzip","full_name":"hainesr/rubyzip","owner":{"login":"hainesr","id":143558,"avatar_url":"https://avatars.githubusercontent.com/u/143558?v=3","gravatar_id":"","url":"https://api.github.com/users/hainesr","html_url":"https://github.com/hainesr","followers_url":"https://api.github.com/users/hainesr/followers","following_url":"https://api.github.com/users/hainesr/following{/other_user}","gists_url":"https://api.github.com/users/hainesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hainesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainesr/subscriptions","organizations_url":"https://api.github.com/users/hainesr/orgs","repos_url":"https://api.github.com/users/hainesr/repos","events_url":"https://api.github.com/users/hainesr/events{/privacy}","received_events_url":"https://api.github.com/users/hainesr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hainesr/rubyzip","description":"Offical Rubyzip repository","fork":true,"url":"https://api.github.com/repos/hainesr/rubyzip","forks_url":"https://api.github.com/repos/hainesr/rubyzip/forks","keys_url":"https://api.github.com/repos/hainesr/rubyzip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hainesr/rubyzip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hainesr/rubyzip/teams","hooks_url":"https://api.github.com/repos/hainesr/rubyzip/hooks","issue_events_url":"https://api.github.com/repos/hainesr/rubyzip/issues/events{/number}","events_url":"https://api.github.com/repos/hainesr/rubyzip/events","assignees_url":"https://api.github.com/repos/hainesr/rubyzip/assignees{/user}","branches_url":"https://api.github.com/repos/hainesr/rubyzip/branches{/branch}","tags_url":"https://api.github.com/repos/hainesr/rubyzip/tags","blobs_url":"https://api.github.com/repos/hainesr/rubyzip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hainesr/rubyzip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hainesr/rubyzip/git/refs{/sha}","trees_url":"https://api.github.com/repos/hainesr/rubyzip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hainesr/rubyzip/statuses/{sha}","languages_url":"https://api.github.com/repos/hainesr/rubyzip/languages","stargazers_url":"https://api.github.com/repos/hainesr/rubyzip/stargazers","contributors_url":"https://api.github.com/repos/hainesr/rubyzip/contributors","subscribers_url":"https://api.github.com/repos/hainesr/rubyzip/subscribers","subscription_url":"https://api.github.com/repos/hainesr/rubyzip/subscription","commits_url":"https://api.github.com/repos/hainesr/rubyzip/commits{/sha}","git_commits_url":"https://api.github.com/repos/hainesr/rubyzip/git/commits{/sha}","comments_url":"https://api.github.com/repos/hainesr/rubyzip/comments{/number}","issue_comment_url":"https://api.github.com/repos/hainesr/rubyzip/issues/comments{/number}","contents_url":"https://api.github.com/repos/hainesr/rubyzip/contents/{+path}","compare_url":"https://api.github.com/repos/hainesr/rubyzip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hainesr/rubyzip/merges","archive_url":"https://api.github.com/repos/hainesr/rubyzip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hainesr/rubyzip/downloads","issues_url":"https://api.github.com/repos/hainesr/rubyzip/issues{/number}","pulls_url":"https://api.github.com/repos/hainesr/rubyzip/pulls{/number}","milestones_url":"https://api.github.com/repos/hainesr/rubyzip/milestones{/number}","notifications_url":"https://api.github.com/repos/hainesr/rubyzip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hainesr/rubyzip/labels{/name}","releases_url":"https://api.github.com/repos/hainesr/rubyzip/releases{/id}","created_at":"2014-06-21T12:00:41Z","updated_at":"2015-02-07T11:10:01Z","pushed_at":"2015-06-24T21:59:35Z","git_url":"git://github.com/hainesr/rubyzip.git","ssh_url":"git@github.com:hainesr/rubyzip.git","clone_url":"https://github.com/hainesr/rubyzip.git","svn_url":"https://github.com/hainesr/rubyzip","homepage":"","size":1496,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubyzip:master","ref":"master","sha":"bbd7cc42167e70eafa4da114e4c8f431bb569789","user":{"login":"rubyzip","id":4912536,"avatar_url":"https://avatars.githubusercontent.com/u/4912536?v=3","gravatar_id":"","url":"https://api.github.com/users/rubyzip","html_url":"https://github.com/rubyzip","followers_url":"https://api.github.com/users/rubyzip/followers","following_url":"https://api.github.com/users/rubyzip/following{/other_user}","gists_url":"https://api.github.com/users/rubyzip/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyzip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyzip/subscriptions","organizations_url":"https://api.github.com/users/rubyzip/orgs","repos_url":"https://api.github.com/users/rubyzip/repos","events_url":"https://api.github.com/users/rubyzip/events{/privacy}","received_events_url":"https://api.github.com/users/rubyzip/received_events","type":"Organization","site_admin":false},"repo":{"id":935822,"name":"rubyzip","full_name":"rubyzip/rubyzip","owner":{"login":"rubyzip","id":4912536,"avatar_url":"https://avatars.githubusercontent.com/u/4912536?v=3","gravatar_id":"","url":"https://api.github.com/users/rubyzip","html_url":"https://github.com/rubyzip","followers_url":"https://api.github.com/users/rubyzip/followers","following_url":"https://api.github.com/users/rubyzip/following{/other_user}","gists_url":"https://api.github.com/users/rubyzip/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyzip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyzip/subscriptions","organizations_url":"https://api.github.com/users/rubyzip/orgs","repos_url":"https://api.github.com/users/rubyzip/repos","events_url":"https://api.github.com/users/rubyzip/events{/privacy}","received_events_url":"https://api.github.com/users/rubyzip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyzip/rubyzip","description":"Offical Rubyzip repository","fork":false,"url":"https://api.github.com/repos/rubyzip/rubyzip","forks_url":"https://api.github.com/repos/rubyzip/rubyzip/forks","keys_url":"https://api.github.com/repos/rubyzip/rubyzip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyzip/rubyzip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyzip/rubyzip/teams","hooks_url":"https://api.github.com/repos/rubyzip/rubyzip/hooks","issue_events_url":"https://api.github.com/repos/rubyzip/rubyzip/issues/events{/number}","events_url":"https://api.github.com/repos/rubyzip/rubyzip/events","assignees_url":"https://api.github.com/repos/rubyzip/rubyzip/assignees{/user}","branches_url":"https://api.github.com/repos/rubyzip/rubyzip/branches{/branch}","tags_url":"https://api.github.com/repos/rubyzip/rubyzip/tags","blobs_url":"https://api.github.com/repos/rubyzip/rubyzip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyzip/rubyzip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyzip/rubyzip/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyzip/rubyzip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyzip/rubyzip/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyzip/rubyzip/languages","stargazers_url":"https://api.github.com/repos/rubyzip/rubyzip/stargazers","contributors_url":"https://api.github.com/repos/rubyzip/rubyzip/contributors","subscribers_url":"https://api.github.com/repos/rubyzip/rubyzip/subscribers","subscription_url":"https://api.github.com/repos/rubyzip/rubyzip/subscription","commits_url":"https://api.github.com/repos/rubyzip/rubyzip/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyzip/rubyzip/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyzip/rubyzip/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyzip/rubyzip/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyzip/rubyzip/contents/{+path}","compare_url":"https://api.github.com/repos/rubyzip/rubyzip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyzip/rubyzip/merges","archive_url":"https://api.github.com/repos/rubyzip/rubyzip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyzip/rubyzip/downloads","issues_url":"https://api.github.com/repos/rubyzip/rubyzip/issues{/number}","pulls_url":"https://api.github.com/repos/rubyzip/rubyzip/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyzip/rubyzip/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyzip/rubyzip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyzip/rubyzip/labels{/name}","releases_url":"https://api.github.com/repos/rubyzip/rubyzip/releases{/id}","created_at":"2010-09-24T10:50:15Z","updated_at":"2015-06-20T13:30:00Z","pushed_at":"2015-06-25T06:13:10Z","git_url":"git://github.com/rubyzip/rubyzip.git","ssh_url":"git@github.com:rubyzip/rubyzip.git","clone_url":"https://github.com/rubyzip/rubyzip.git","svn_url":"https://github.com/rubyzip/rubyzip","homepage":"","size":2489,"stargazers_count":522,"watchers_count":522,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":34,"forks":144,"open_issues":34,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyzip/rubyzip/pulls/237"},"html":{"href":"https://github.com/rubyzip/rubyzip/pull/237"},"issue":{"href":"https://api.github.com/repos/rubyzip/rubyzip/issues/237"},"comments":{"href":"https://api.github.com/repos/rubyzip/rubyzip/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyzip/rubyzip/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyzip/rubyzip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyzip/rubyzip/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/rubyzip/rubyzip/statuses/8edb2bd6e6d12e51dd2c2d9a1c1f3d712a097c38"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"simonoff","id":14304,"avatar_url":"https://avatars.githubusercontent.com/u/14304?v=3","gravatar_id":"","url":"https://api.github.com/users/simonoff","html_url":"https://github.com/simonoff","followers_url":"https://api.github.com/users/simonoff/followers","following_url":"https://api.github.com/users/simonoff/following{/other_user}","gists_url":"https://api.github.com/users/simonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/simonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonoff/subscriptions","organizations_url":"https://api.github.com/users/simonoff/orgs","repos_url":"https://api.github.com/users/simonoff/repos","events_url":"https://api.github.com/users/simonoff/events{/privacy}","received_events_url":"https://api.github.com/users/simonoff/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":86,"deletions":2,"changed_files":3}}