{"action":"created","comment":{"url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/comments/23917171","id":23917171,"diff_hunk":"@@ -224,14 +225,26 @@ sub _get_TECAN_file_content_per_URI {\n       my $input_buffer_string  = qq{A;BUFF;;96-TROUGH;$inp_loc_dec;;$buffer_volume};\n       my $output_buffer_string = qq{D;$output_barcode;;$output_type;$out_loc_dec;;$buffer_volume};\n \n-      push @sample_output, $input_sample_string;\n-      push @sample_output, $output_sample_string;\n-      push @sample_output, $w_string;\n-      push @buffer_output, $input_buffer_string;\n-      push @buffer_output, $output_buffer_string;\n-      push @buffer_output, $w_string;\n+      push @sample_output, {\n+        output_location => $out_loc_dec,\n+        output          => join \"\\n\", $input_sample_string, $output_sample_string, $w_string,\n+      };\n+\n+      push @buffer_output, {\n+        output_location => $out_loc_dec,\n+        output => join \"\\n\", $input_buffer_string, $output_buffer_string, $w_string,\n+      };\n     }\n   }\n+\n+  @sample_output = map { $_->{'output'} } sort {\n+    $a->{'output_location'} <=> $b->{'output_location'}\n+  } @sample_output;","path":"src/perl/lib/wtsi_clarity/epp/generic/worksheet_attacher.pm","position":41,"original_position":41,"commit_id":"49ae41bbeca1d1d639603fbfd928af1741769a9e","original_commit_id":"49ae41bbeca1d1d639603fbfd928af1741769a9e","user":{"login":"ke4","id":2183410,"avatar_url":"https://avatars.githubusercontent.com/u/2183410?v=3","gravatar_id":"","url":"https://api.github.com/users/ke4","html_url":"https://github.com/ke4","followers_url":"https://api.github.com/users/ke4/followers","following_url":"https://api.github.com/users/ke4/following{/other_user}","gists_url":"https://api.github.com/users/ke4/gists{/gist_id}","starred_url":"https://api.github.com/users/ke4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke4/subscriptions","organizations_url":"https://api.github.com/users/ke4/orgs","repos_url":"https://api.github.com/users/ke4/repos","events_url":"https://api.github.com/users/ke4/events{/privacy}","received_events_url":"https://api.github.com/users/ke4/received_events","type":"User","site_admin":false},"body":"The code suggests the 'output_location' should be a number, because it compares the 2 values with the '<=>' operator, but there is no check for this in the code. I would add this validation right after getting the value.","created_at":"2015-02-02T10:44:25Z","updated_at":"2015-02-02T10:44:25Z","html_url":"https://github.com/wtsi-clarity/wtsi_clarity/pull/256#discussion_r23917171","pull_request_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/comments/23917171"},"html":{"href":"https://github.com/wtsi-clarity/wtsi_clarity/pull/256#discussion_r23917171"},"pull_request":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256","id":28456672,"html_url":"https://github.com/wtsi-clarity/wtsi_clarity/pull/256","diff_url":"https://github.com/wtsi-clarity/wtsi_clarity/pull/256.diff","patch_url":"https://github.com/wtsi-clarity/wtsi_clarity/pull/256.patch","issue_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues/256","number":256,"state":"open","locked":false,"title":"Worksheet attacher sorts Tecan commands by destination column","user":{"login":"jbeast","id":1383212,"avatar_url":"https://avatars.githubusercontent.com/u/1383212?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeast","html_url":"https://github.com/jbeast","followers_url":"https://api.github.com/users/jbeast/followers","following_url":"https://api.github.com/users/jbeast/following{/other_user}","gists_url":"https://api.github.com/users/jbeast/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeast/subscriptions","organizations_url":"https://api.github.com/users/jbeast/orgs","repos_url":"https://api.github.com/users/jbeast/repos","events_url":"https://api.github.com/users/jbeast/events{/privacy}","received_events_url":"https://api.github.com/users/jbeast/received_events","type":"User","site_admin":false},"body":"To make the Tecan robot more efficient we need to sort by destination column","created_at":"2015-02-02T10:10:13Z","updated_at":"2015-02-02T10:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a40b089d4fa8a067740c198508e85e811912fb2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256/commits","review_comments_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256/comments","review_comment_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues/256/comments","statuses_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/statuses/49ae41bbeca1d1d639603fbfd928af1741769a9e","head":{"label":"jbeast:efficient_tecan","ref":"efficient_tecan","sha":"49ae41bbeca1d1d639603fbfd928af1741769a9e","user":{"login":"jbeast","id":1383212,"avatar_url":"https://avatars.githubusercontent.com/u/1383212?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeast","html_url":"https://github.com/jbeast","followers_url":"https://api.github.com/users/jbeast/followers","following_url":"https://api.github.com/users/jbeast/following{/other_user}","gists_url":"https://api.github.com/users/jbeast/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeast/subscriptions","organizations_url":"https://api.github.com/users/jbeast/orgs","repos_url":"https://api.github.com/users/jbeast/repos","events_url":"https://api.github.com/users/jbeast/events{/privacy}","received_events_url":"https://api.github.com/users/jbeast/received_events","type":"User","site_admin":false},"repo":{"id":18632478,"name":"wtsi_clarity","full_name":"jbeast/wtsi_clarity","owner":{"login":"jbeast","id":1383212,"avatar_url":"https://avatars.githubusercontent.com/u/1383212?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeast","html_url":"https://github.com/jbeast","followers_url":"https://api.github.com/users/jbeast/followers","following_url":"https://api.github.com/users/jbeast/following{/other_user}","gists_url":"https://api.github.com/users/jbeast/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeast/subscriptions","organizations_url":"https://api.github.com/users/jbeast/orgs","repos_url":"https://api.github.com/users/jbeast/repos","events_url":"https://api.github.com/users/jbeast/events{/privacy}","received_events_url":"https://api.github.com/users/jbeast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbeast/wtsi_clarity","description":"Custom scripting for GenoLogics (http://www.genologics.com) Clarity LIMS at Wellcome Trust Sanger Institute ","fork":true,"url":"https://api.github.com/repos/jbeast/wtsi_clarity","forks_url":"https://api.github.com/repos/jbeast/wtsi_clarity/forks","keys_url":"https://api.github.com/repos/jbeast/wtsi_clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbeast/wtsi_clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbeast/wtsi_clarity/teams","hooks_url":"https://api.github.com/repos/jbeast/wtsi_clarity/hooks","issue_events_url":"https://api.github.com/repos/jbeast/wtsi_clarity/issues/events{/number}","events_url":"https://api.github.com/repos/jbeast/wtsi_clarity/events","assignees_url":"https://api.github.com/repos/jbeast/wtsi_clarity/assignees{/user}","branches_url":"https://api.github.com/repos/jbeast/wtsi_clarity/branches{/branch}","tags_url":"https://api.github.com/repos/jbeast/wtsi_clarity/tags","blobs_url":"https://api.github.com/repos/jbeast/wtsi_clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbeast/wtsi_clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbeast/wtsi_clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbeast/wtsi_clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbeast/wtsi_clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/jbeast/wtsi_clarity/languages","stargazers_url":"https://api.github.com/repos/jbeast/wtsi_clarity/stargazers","contributors_url":"https://api.github.com/repos/jbeast/wtsi_clarity/contributors","subscribers_url":"https://api.github.com/repos/jbeast/wtsi_clarity/subscribers","subscription_url":"https://api.github.com/repos/jbeast/wtsi_clarity/subscription","commits_url":"https://api.github.com/repos/jbeast/wtsi_clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbeast/wtsi_clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbeast/wtsi_clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbeast/wtsi_clarity/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbeast/wtsi_clarity/contents/{+path}","compare_url":"https://api.github.com/repos/jbeast/wtsi_clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbeast/wtsi_clarity/merges","archive_url":"https://api.github.com/repos/jbeast/wtsi_clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbeast/wtsi_clarity/downloads","issues_url":"https://api.github.com/repos/jbeast/wtsi_clarity/issues{/number}","pulls_url":"https://api.github.com/repos/jbeast/wtsi_clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/jbeast/wtsi_clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/jbeast/wtsi_clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbeast/wtsi_clarity/labels{/name}","releases_url":"https://api.github.com/repos/jbeast/wtsi_clarity/releases{/id}","created_at":"2014-04-10T10:25:12Z","updated_at":"2014-09-09T17:30:28Z","pushed_at":"2015-02-02T10:08:05Z","git_url":"git://github.com/jbeast/wtsi_clarity.git","ssh_url":"git@github.com:jbeast/wtsi_clarity.git","clone_url":"https://github.com/jbeast/wtsi_clarity.git","svn_url":"https://github.com/jbeast/wtsi_clarity","homepage":null,"size":3975,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wtsi-clarity:devel","ref":"devel","sha":"da69d7b12f4f47b4ebc4b2c8a739d5240d12bee7","user":{"login":"wtsi-clarity","id":7203099,"avatar_url":"https://avatars.githubusercontent.com/u/7203099?v=3","gravatar_id":"","url":"https://api.github.com/users/wtsi-clarity","html_url":"https://github.com/wtsi-clarity","followers_url":"https://api.github.com/users/wtsi-clarity/followers","following_url":"https://api.github.com/users/wtsi-clarity/following{/other_user}","gists_url":"https://api.github.com/users/wtsi-clarity/gists{/gist_id}","starred_url":"https://api.github.com/users/wtsi-clarity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtsi-clarity/subscriptions","organizations_url":"https://api.github.com/users/wtsi-clarity/orgs","repos_url":"https://api.github.com/users/wtsi-clarity/repos","events_url":"https://api.github.com/users/wtsi-clarity/events{/privacy}","received_events_url":"https://api.github.com/users/wtsi-clarity/received_events","type":"Organization","site_admin":false},"repo":{"id":18512431,"name":"wtsi_clarity","full_name":"wtsi-clarity/wtsi_clarity","owner":{"login":"wtsi-clarity","id":7203099,"avatar_url":"https://avatars.githubusercontent.com/u/7203099?v=3","gravatar_id":"","url":"https://api.github.com/users/wtsi-clarity","html_url":"https://github.com/wtsi-clarity","followers_url":"https://api.github.com/users/wtsi-clarity/followers","following_url":"https://api.github.com/users/wtsi-clarity/following{/other_user}","gists_url":"https://api.github.com/users/wtsi-clarity/gists{/gist_id}","starred_url":"https://api.github.com/users/wtsi-clarity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtsi-clarity/subscriptions","organizations_url":"https://api.github.com/users/wtsi-clarity/orgs","repos_url":"https://api.github.com/users/wtsi-clarity/repos","events_url":"https://api.github.com/users/wtsi-clarity/events{/privacy}","received_events_url":"https://api.github.com/users/wtsi-clarity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wtsi-clarity/wtsi_clarity","description":"Custom scripting for Clarity LIMS (http://www.genologics.com) at Wellcome Trust Sanger Institute ","fork":false,"url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity","forks_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/forks","keys_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/teams","hooks_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/hooks","issue_events_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues/events{/number}","events_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/events","assignees_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/assignees{/user}","branches_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/branches{/branch}","tags_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/tags","blobs_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/languages","stargazers_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/stargazers","contributors_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/contributors","subscribers_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/subscribers","subscription_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/subscription","commits_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues/comments/{number}","contents_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/contents/{+path}","compare_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/merges","archive_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/downloads","issues_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues{/number}","pulls_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/labels{/name}","releases_url":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/releases{/id}","created_at":"2014-04-07T09:45:26Z","updated_at":"2015-01-30T16:08:31Z","pushed_at":"2015-01-30T16:49:15Z","git_url":"git://github.com/wtsi-clarity/wtsi_clarity.git","ssh_url":"git@github.com:wtsi-clarity/wtsi_clarity.git","clone_url":"https://github.com/wtsi-clarity/wtsi_clarity.git","svn_url":"https://github.com/wtsi-clarity/wtsi_clarity","homepage":"","size":7797,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":15,"forks":7,"open_issues":15,"watchers":0,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256"},"html":{"href":"https://github.com/wtsi-clarity/wtsi_clarity/pull/256"},"issue":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues/256"},"comments":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/wtsi-clarity/wtsi_clarity/statuses/49ae41bbeca1d1d639603fbfd928af1741769a9e"}}}}