{"comment":{"url":"https://api.github.com/repos/10up/ElasticPress/comments/10214465","html_url":"https://github.com/10up/ElasticPress/commit/aa867037fa796bae20ca5a9e61f7f919d795591a#commitcomment-10214465","id":10214465,"user":{"login":"mikaelmattsson","id":2428696,"avatar_url":"https://avatars.githubusercontent.com/u/2428696?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelmattsson","html_url":"https://github.com/mikaelmattsson","followers_url":"https://api.github.com/users/mikaelmattsson/followers","following_url":"https://api.github.com/users/mikaelmattsson/following{/other_user}","gists_url":"https://api.github.com/users/mikaelmattsson/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelmattsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelmattsson/subscriptions","organizations_url":"https://api.github.com/users/mikaelmattsson/orgs","repos_url":"https://api.github.com/users/mikaelmattsson/repos","events_url":"https://api.github.com/users/mikaelmattsson/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelmattsson/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"aa867037fa796bae20ca5a9e61f7f919d795591a","created_at":"2015-03-16T13:59:07Z","updated_at":"2015-03-16T13:59:07Z","body":"You don't need the constant for the root path but i prefer it before using relative paths or calling plugin_dir_path.\r\n\r\nI think I would prefer `config` over `includes` for this. The name `includes` would imply that the directory/folder could contain anything, including logic. `config` would imply that the directory/folder only include data and no functions or classes. But I don't really care what it is called.\r\n\r\nSure, the path could be filterable. The ep_config_mapping filter would be sufficient in most cases but it would not hurt to add one more in case one would want to change the mappings completely."}}