{"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/22749906","id":22749906,"diff_hunk":"@@ -93,7 +88,9 @@ def convert_bind_vars(bind_variables):\n       new_vars[key] = times.DateTimeToString(val)\n     elif isinstance(val, datetime.date):\n       new_vars[key] = times.DateToString(val)\n-    elif isinstance(val, (int, long, float, str, List, NoneType)):\n+    elif isinstance(val, set):","path":"py/vtdb/field_types.py","position":17,"original_position":17,"commit_id":"d06a54e57e7e9f905676c8a270c283b553396cd5","original_commit_id":"d06a54e57e7e9f905676c8a270c283b553396cd5","user":{"login":"shrutip","id":5050399,"avatar_url":"https://avatars.githubusercontent.com/u/5050399?v=3","gravatar_id":"","url":"https://api.github.com/users/shrutip","html_url":"https://github.com/shrutip","followers_url":"https://api.github.com/users/shrutip/followers","following_url":"https://api.github.com/users/shrutip/following{/other_user}","gists_url":"https://api.github.com/users/shrutip/gists{/gist_id}","starred_url":"https://api.github.com/users/shrutip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrutip/subscriptions","organizations_url":"https://api.github.com/users/shrutip/orgs","repos_url":"https://api.github.com/users/shrutip/repos","events_url":"https://api.github.com/users/shrutip/events{/privacy}","received_events_url":"https://api.github.com/users/shrutip/received_events","type":"User","site_admin":false},"body":"Yes because otherwise the bind var appears as set([1,23]) and gets sent as is, which doesn't get converted right at the protocol level and vttablet throws an error to the effect - invalid uin8[] arg ...\r\n\r\ndbapi indicates expect an iterable type.","created_at":"2015-01-09T23:04:06Z","updated_at":"2015-01-09T23:04:06Z","html_url":"https://github.com/youtube/vitess/pull/305#discussion_r22749906","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/22749906"},"html":{"href":"https://github.com/youtube/vitess/pull/305#discussion_r22749906"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/305","id":27135524,"html_url":"https://github.com/youtube/vitess/pull/305","diff_url":"https://github.com/youtube/vitess/pull/305.diff","patch_url":"https://github.com/youtube/vitess/pull/305.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/305","number":305,"state":"open","locked":false,"title":"Native support of list bound bind variables.","user":{"login":"shrutip","id":5050399,"avatar_url":"https://avatars.githubusercontent.com/u/5050399?v=3","gravatar_id":"","url":"https://api.github.com/users/shrutip","html_url":"https://github.com/shrutip","followers_url":"https://api.github.com/users/shrutip/followers","following_url":"https://api.github.com/users/shrutip/following{/other_user}","gists_url":"https://api.github.com/users/shrutip/gists{/gist_id}","starred_url":"https://api.github.com/users/shrutip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrutip/subscriptions","organizations_url":"https://api.github.com/users/shrutip/orgs","repos_url":"https://api.github.com/users/shrutip/repos","events_url":"https://api.github.com/users/shrutip/events{/privacy}","received_events_url":"https://api.github.com/users/shrutip/received_events","type":"User","site_admin":false},"body":"@sougou @alainjobart @liguo ","created_at":"2015-01-09T22:48:45Z","updated_at":"2015-01-09T23:04:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9830511927a8790aa0eab0f98b3b2d1df6898f00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/305/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/305/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments/{number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/305/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/d06a54e57e7e9f905676c8a270c283b553396cd5","head":{"label":"youtube:vtclient","ref":"vtclient","sha":"d06a54e57e7e9f905676c8a270c283b553396cd5","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments/{number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-01-09T21:56:49Z","pushed_at":"2015-01-09T22:47:02Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":56905,"stargazers_count":1972,"watchers_count":1972,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":9,"forks":231,"open_issues":9,"watchers":1972,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"2227ad5a135d4f11b6d99ab90e7f7ccd143b80e4","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments/{number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-01-09T21:56:49Z","pushed_at":"2015-01-09T22:47:02Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":56905,"stargazers_count":1972,"watchers_count":1972,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":9,"forks":231,"open_issues":9,"watchers":1972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/305"},"html":{"href":"https://github.com/youtube/vitess/pull/305"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/305"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/d06a54e57e7e9f905676c8a270c283b553396cd5"}}}}