{"action":"created","issue":{"url":"https://api.github.com/repos/neo4j/neo4j/issues/5629","labels_url":"https://api.github.com/repos/neo4j/neo4j/issues/5629/labels{/name}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/5629/comments","events_url":"https://api.github.com/repos/neo4j/neo4j/issues/5629/events","html_url":"https://github.com/neo4j/neo4j/pull/5629","id":111390987,"number":5629,"title":"Log the first heartbeat after a series of missed","user":{"login":"thobe","id":104385,"avatar_url":"https://avatars.githubusercontent.com/u/104385?v=3","gravatar_id":"","url":"https://api.github.com/users/thobe","html_url":"https://github.com/thobe","followers_url":"https://api.github.com/users/thobe/followers","following_url":"https://api.github.com/users/thobe/following{/other_user}","gists_url":"https://api.github.com/users/thobe/gists{/gist_id}","starred_url":"https://api.github.com/users/thobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thobe/subscriptions","organizations_url":"https://api.github.com/users/thobe/orgs","repos_url":"https://api.github.com/users/thobe/repos","events_url":"https://api.github.com/users/thobe/events{/privacy}","received_events_url":"https://api.github.com/users/thobe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neo4j/neo4j/labels/2.3","name":"2.3","color":"5319e7"},{"url":"https://api.github.com/repos/neo4j/neo4j/labels/kernel","name":"kernel","color":"0052cc"},{"url":"https://api.github.com/repos/neo4j/neo4j/labels/NOT%20READY%20FOR%20MERGE","name":"NOT READY FOR MERGE","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"milestone":null,"comments":21,"created_at":"2015-10-14T12:49:01Z","updated_at":"2015-11-13T12:43:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/5629","html_url":"https://github.com/neo4j/neo4j/pull/5629","diff_url":"https://github.com/neo4j/neo4j/pull/5629.diff","patch_url":"https://github.com/neo4j/neo4j/pull/5629.patch"},"body":"Previously we logged all heartbeat messages. This is too much logging for the system to handle, so we removed it. This change introduces logging of the interesting heartbeat messages, the ones for when the heartbeat comes back after having missed a few beats.\r\n\r\nIn order to ensure that logging from anywhere in the clustering code does not affect the cluster stability, all logging from the clustering code is made asynchronous."},"comment":{"url":"https://api.github.com/repos/neo4j/neo4j/issues/comments/156423287","html_url":"https://github.com/neo4j/neo4j/pull/5629#issuecomment-156423287","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/5629","id":156423287,"user":{"login":"thobe","id":104385,"avatar_url":"https://avatars.githubusercontent.com/u/104385?v=3","gravatar_id":"","url":"https://api.github.com/users/thobe","html_url":"https://github.com/thobe","followers_url":"https://api.github.com/users/thobe/followers","following_url":"https://api.github.com/users/thobe/following{/other_user}","gists_url":"https://api.github.com/users/thobe/gists{/gist_id}","starred_url":"https://api.github.com/users/thobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thobe/subscriptions","organizations_url":"https://api.github.com/users/thobe/orgs","repos_url":"https://api.github.com/users/thobe/repos","events_url":"https://api.github.com/users/thobe/events{/privacy}","received_events_url":"https://api.github.com/users/thobe/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T12:43:50Z","updated_at":"2015-11-13T12:43:50Z","body":"@tinwelint timestamps for actual log-event time has been added: https://github.com/neo4j/neo4j/pull/5629/files#diff-98b920bc20ec71b0684b5d65867fd074R150\r\nAlthough not for bulk logging.\r\n\r\nThe FeatureToggles have been stripped down to the essential bits, the hack has been removed that made them controversial to some. The question is of package. Since the use cases for it are spread over the \"early\" modules (`kernel` and the modules it depends on) it has been put in the `unsafe` module, since all other things depend on this. They aren't unsafe, so it doesn't really feel right for it to be defined here though, but it's hard to find a good home in an existing module. Since that is the module the class is in, it is in the only package in that module. Since I don't think we will expand the use of FeatureToggles in 2.3, I think this is good enough, and we can focus on finding a better home for it in 3.0, and defer the decision of where it actually goes until later. The place where it is now is a sufficiently discouraging place that we should have no trouble moving it without prior notice."}}