{"action":"created","comment":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/31645909","id":31645909,"diff_hunk":"@@ -495,7 +492,7 @@ static ssize_t gnix_cq_readfrom(struct fid_cq *cq, void *buf, size_t count,\n \n \tfastlock_release(&cq_priv->lock);\n \n-\treturn read_count;\n+\treturn read_count ?: -FI_EAGAIN;","path":"prov/gni/src/gnix_cq.c","position":21,"original_position":21,"commit_id":"1198cdc312588f83a59c78c4c8e67d2cf81d7a5d","original_commit_id":"1198cdc312588f83a59c78c4c8e67d2cf81d7a5d","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"body":"just curious is the triad def such that if there is nothing before the : will it return the\r\nread_count in this case?  I'd prefer to have it more explicit and have\r\n```return read_count ? read_count : -FI_EAGAIN:```\r\n","created_at":"2015-06-03T17:11:36Z","updated_at":"2015-06-03T17:11:36Z","html_url":"https://github.com/ofi-cray/libfabric-cray/pull/210#discussion_r31645909","pull_request_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/31645909"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/210#discussion_r31645909"},"pull_request":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210","id":36839656,"html_url":"https://github.com/ofi-cray/libfabric-cray/pull/210","diff_url":"https://github.com/ofi-cray/libfabric-cray/pull/210.diff","patch_url":"https://github.com/ofi-cray/libfabric-cray/pull/210.patch","issue_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/210","number":210,"state":"open","locked":false,"title":"Fix issue reading from empty queue.","user":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"body":"Fixes ofi-cray/libfabric-cray#192.\r\n\r\nSigned-off-by: Zach Tiffany <ztiffany@cray.com>","created_at":"2015-06-03T14:41:48Z","updated_at":"2015-06-03T17:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da90e9c3844d7d7ce6dcc14ac83a7a0f8640701","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210/commits","review_comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210/comments","review_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/210/comments","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/1198cdc312588f83a59c78c4c8e67d2cf81d7a5d","head":{"label":"ztiffany:cqr","ref":"cqr","sha":"1198cdc312588f83a59c78c4c8e67d2cf81d7a5d","user":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"repo":{"id":32935123,"name":"libfabric-cray","full_name":"ztiffany/libfabric-cray","owner":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ztiffany/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ztiffany/libfabric-cray","forks_url":"https://api.github.com/repos/ztiffany/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ztiffany/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ztiffany/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ztiffany/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ztiffany/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ztiffany/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ztiffany/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ztiffany/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ztiffany/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ztiffany/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ztiffany/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ztiffany/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ztiffany/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ztiffany/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ztiffany/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ztiffany/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ztiffany/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ztiffany/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ztiffany/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ztiffany/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ztiffany/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ztiffany/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ztiffany/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ztiffany/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ztiffany/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ztiffany/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ztiffany/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ztiffany/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ztiffany/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ztiffany/libfabric-cray/releases{/id}","created_at":"2015-03-26T15:19:55Z","updated_at":"2015-03-26T15:19:56Z","pushed_at":"2015-06-03T14:41:15Z","git_url":"git://github.com/ztiffany/libfabric-cray.git","ssh_url":"git@github.com:ztiffany/libfabric-cray.git","clone_url":"https://github.com/ztiffany/libfabric-cray.git","svn_url":"https://github.com/ztiffany/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":7096,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofi-cray:master","ref":"master","sha":"7ab4b09982814f35f55586e3b1598297a5734b3e","user":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"repo":{"id":29607348,"name":"libfabric-cray","full_name":"ofi-cray/libfabric-cray","owner":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofi-cray/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ofi-cray/libfabric-cray","forks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/releases{/id}","created_at":"2015-01-21T19:30:52Z","updated_at":"2015-05-12T21:53:26Z","pushed_at":"2015-06-03T14:41:48Z","git_url":"git://github.com/ofi-cray/libfabric-cray.git","ssh_url":"git@github.com:ofi-cray/libfabric-cray.git","clone_url":"https://github.com/ofi-cray/libfabric-cray.git","svn_url":"https://github.com/ofi-cray/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":11971,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":24,"forks":3,"open_issues":24,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/210"},"issue":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/210"},"comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/1198cdc312588f83a59c78c4c8e67d2cf81d7a5d"}}}}