{"action":"opened","number":1457,"pull_request":{"url":"https://api.github.com/repos/Rdatatable/data.table/pulls/1457","id":52285706,"html_url":"https://github.com/Rdatatable/data.table/pull/1457","diff_url":"https://github.com/Rdatatable/data.table/pull/1457.diff","patch_url":"https://github.com/Rdatatable/data.table/pull/1457.patch","issue_url":"https://api.github.com/repos/Rdatatable/data.table/issues/1457","number":1457,"state":"open","locked":false,"title":"Ensure .so install name & filename match on OSX (fixes #1144)","user":{"login":"chenghlee","id":3485949,"avatar_url":"https://avatars.githubusercontent.com/u/3485949?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghlee","html_url":"https://github.com/chenghlee","followers_url":"https://api.github.com/users/chenghlee/followers","following_url":"https://api.github.com/users/chenghlee/following{/other_user}","gists_url":"https://api.github.com/users/chenghlee/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghlee/subscriptions","organizations_url":"https://api.github.com/users/chenghlee/orgs","repos_url":"https://api.github.com/users/chenghlee/repos","events_url":"https://api.github.com/users/chenghlee/events{/privacy}","received_events_url":"https://api.github.com/users/chenghlee/received_events","type":"User","site_admin":false},"body":"OS X convention requires that the basename part of a shared library's\r\ninstall name (i.e., install name minus directory components) match the\r\nactual filename of said shared library. Otherwise, the dynamic linker\r\n(and related tools) could get confused when trying to find, process,\r\nand/or load the dynamic library.\r\n\r\nOn OS X, the \"mv\" command at the end of the build process changes the\r\nshared library filename to \"datatable.so\" while leaving the install name\r\nas \"data.table.so\", so we need to run install_name_tool(1) to fix the\r\ninstall name to match the filename. Currently not a big issue for most\r\nusers (since not much else links to this shared library), but not doing\r\nthis causes issues with build systems (e.g., conda) that end up\r\nmodifying the .so's RPATH for some reason.","created_at":"2015-12-01T17:05:27Z","updated_at":"2015-12-01T17:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Rdatatable/data.table/pulls/1457/commits","review_comments_url":"https://api.github.com/repos/Rdatatable/data.table/pulls/1457/comments","review_comment_url":"https://api.github.com/repos/Rdatatable/data.table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rdatatable/data.table/issues/1457/comments","statuses_url":"https://api.github.com/repos/Rdatatable/data.table/statuses/0234b38f276820160f5cc38f17646c636d6c62b1","head":{"label":"chenghlee:fix-1144","ref":"fix-1144","sha":"0234b38f276820160f5cc38f17646c636d6c62b1","user":{"login":"chenghlee","id":3485949,"avatar_url":"https://avatars.githubusercontent.com/u/3485949?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghlee","html_url":"https://github.com/chenghlee","followers_url":"https://api.github.com/users/chenghlee/followers","following_url":"https://api.github.com/users/chenghlee/following{/other_user}","gists_url":"https://api.github.com/users/chenghlee/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghlee/subscriptions","organizations_url":"https://api.github.com/users/chenghlee/orgs","repos_url":"https://api.github.com/users/chenghlee/repos","events_url":"https://api.github.com/users/chenghlee/events{/privacy}","received_events_url":"https://api.github.com/users/chenghlee/received_events","type":"User","site_admin":false},"repo":{"id":47147690,"name":"data.table","full_name":"chenghlee/data.table","owner":{"login":"chenghlee","id":3485949,"avatar_url":"https://avatars.githubusercontent.com/u/3485949?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghlee","html_url":"https://github.com/chenghlee","followers_url":"https://api.github.com/users/chenghlee/followers","following_url":"https://api.github.com/users/chenghlee/following{/other_user}","gists_url":"https://api.github.com/users/chenghlee/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghlee/subscriptions","organizations_url":"https://api.github.com/users/chenghlee/orgs","repos_url":"https://api.github.com/users/chenghlee/repos","events_url":"https://api.github.com/users/chenghlee/events{/privacy}","received_events_url":"https://api.github.com/users/chenghlee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chenghlee/data.table","description":"R's data.table package extends data.frame. More info: ","fork":true,"url":"https://api.github.com/repos/chenghlee/data.table","forks_url":"https://api.github.com/repos/chenghlee/data.table/forks","keys_url":"https://api.github.com/repos/chenghlee/data.table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenghlee/data.table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenghlee/data.table/teams","hooks_url":"https://api.github.com/repos/chenghlee/data.table/hooks","issue_events_url":"https://api.github.com/repos/chenghlee/data.table/issues/events{/number}","events_url":"https://api.github.com/repos/chenghlee/data.table/events","assignees_url":"https://api.github.com/repos/chenghlee/data.table/assignees{/user}","branches_url":"https://api.github.com/repos/chenghlee/data.table/branches{/branch}","tags_url":"https://api.github.com/repos/chenghlee/data.table/tags","blobs_url":"https://api.github.com/repos/chenghlee/data.table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenghlee/data.table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenghlee/data.table/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenghlee/data.table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenghlee/data.table/statuses/{sha}","languages_url":"https://api.github.com/repos/chenghlee/data.table/languages","stargazers_url":"https://api.github.com/repos/chenghlee/data.table/stargazers","contributors_url":"https://api.github.com/repos/chenghlee/data.table/contributors","subscribers_url":"https://api.github.com/repos/chenghlee/data.table/subscribers","subscription_url":"https://api.github.com/repos/chenghlee/data.table/subscription","commits_url":"https://api.github.com/repos/chenghlee/data.table/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenghlee/data.table/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenghlee/data.table/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenghlee/data.table/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenghlee/data.table/contents/{+path}","compare_url":"https://api.github.com/repos/chenghlee/data.table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenghlee/data.table/merges","archive_url":"https://api.github.com/repos/chenghlee/data.table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenghlee/data.table/downloads","issues_url":"https://api.github.com/repos/chenghlee/data.table/issues{/number}","pulls_url":"https://api.github.com/repos/chenghlee/data.table/pulls{/number}","milestones_url":"https://api.github.com/repos/chenghlee/data.table/milestones{/number}","notifications_url":"https://api.github.com/repos/chenghlee/data.table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenghlee/data.table/labels{/name}","releases_url":"https://api.github.com/repos/chenghlee/data.table/releases{/id}","created_at":"2015-11-30T21:40:03Z","updated_at":"2015-11-30T21:40:06Z","pushed_at":"2015-12-01T17:05:00Z","git_url":"git://github.com/chenghlee/data.table.git","ssh_url":"git@github.com:chenghlee/data.table.git","clone_url":"https://github.com/chenghlee/data.table.git","svn_url":"https://github.com/chenghlee/data.table","homepage":"https://github.com/Rdatatable/data.table/wiki","size":11611,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Rdatatable:master","ref":"master","sha":"6a675fe43b922c0906ec34bf3f933430263b7da2","user":{"login":"Rdatatable","id":7824179,"avatar_url":"https://avatars.githubusercontent.com/u/7824179?v=3","gravatar_id":"","url":"https://api.github.com/users/Rdatatable","html_url":"https://github.com/Rdatatable","followers_url":"https://api.github.com/users/Rdatatable/followers","following_url":"https://api.github.com/users/Rdatatable/following{/other_user}","gists_url":"https://api.github.com/users/Rdatatable/gists{/gist_id}","starred_url":"https://api.github.com/users/Rdatatable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rdatatable/subscriptions","organizations_url":"https://api.github.com/users/Rdatatable/orgs","repos_url":"https://api.github.com/users/Rdatatable/repos","events_url":"https://api.github.com/users/Rdatatable/events{/privacy}","received_events_url":"https://api.github.com/users/Rdatatable/received_events","type":"Organization","site_admin":false},"repo":{"id":20597509,"name":"data.table","full_name":"Rdatatable/data.table","owner":{"login":"Rdatatable","id":7824179,"avatar_url":"https://avatars.githubusercontent.com/u/7824179?v=3","gravatar_id":"","url":"https://api.github.com/users/Rdatatable","html_url":"https://github.com/Rdatatable","followers_url":"https://api.github.com/users/Rdatatable/followers","following_url":"https://api.github.com/users/Rdatatable/following{/other_user}","gists_url":"https://api.github.com/users/Rdatatable/gists{/gist_id}","starred_url":"https://api.github.com/users/Rdatatable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rdatatable/subscriptions","organizations_url":"https://api.github.com/users/Rdatatable/orgs","repos_url":"https://api.github.com/users/Rdatatable/repos","events_url":"https://api.github.com/users/Rdatatable/events{/privacy}","received_events_url":"https://api.github.com/users/Rdatatable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rdatatable/data.table","description":"R's data.table package extends data.frame. More info: ","fork":false,"url":"https://api.github.com/repos/Rdatatable/data.table","forks_url":"https://api.github.com/repos/Rdatatable/data.table/forks","keys_url":"https://api.github.com/repos/Rdatatable/data.table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rdatatable/data.table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rdatatable/data.table/teams","hooks_url":"https://api.github.com/repos/Rdatatable/data.table/hooks","issue_events_url":"https://api.github.com/repos/Rdatatable/data.table/issues/events{/number}","events_url":"https://api.github.com/repos/Rdatatable/data.table/events","assignees_url":"https://api.github.com/repos/Rdatatable/data.table/assignees{/user}","branches_url":"https://api.github.com/repos/Rdatatable/data.table/branches{/branch}","tags_url":"https://api.github.com/repos/Rdatatable/data.table/tags","blobs_url":"https://api.github.com/repos/Rdatatable/data.table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rdatatable/data.table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rdatatable/data.table/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rdatatable/data.table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rdatatable/data.table/statuses/{sha}","languages_url":"https://api.github.com/repos/Rdatatable/data.table/languages","stargazers_url":"https://api.github.com/repos/Rdatatable/data.table/stargazers","contributors_url":"https://api.github.com/repos/Rdatatable/data.table/contributors","subscribers_url":"https://api.github.com/repos/Rdatatable/data.table/subscribers","subscription_url":"https://api.github.com/repos/Rdatatable/data.table/subscription","commits_url":"https://api.github.com/repos/Rdatatable/data.table/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rdatatable/data.table/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rdatatable/data.table/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rdatatable/data.table/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rdatatable/data.table/contents/{+path}","compare_url":"https://api.github.com/repos/Rdatatable/data.table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rdatatable/data.table/merges","archive_url":"https://api.github.com/repos/Rdatatable/data.table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rdatatable/data.table/downloads","issues_url":"https://api.github.com/repos/Rdatatable/data.table/issues{/number}","pulls_url":"https://api.github.com/repos/Rdatatable/data.table/pulls{/number}","milestones_url":"https://api.github.com/repos/Rdatatable/data.table/milestones{/number}","notifications_url":"https://api.github.com/repos/Rdatatable/data.table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rdatatable/data.table/labels{/name}","releases_url":"https://api.github.com/repos/Rdatatable/data.table/releases{/id}","created_at":"2014-06-07T16:38:05Z","updated_at":"2015-12-01T15:46:29Z","pushed_at":"2015-11-28T17:42:57Z","git_url":"git://github.com/Rdatatable/data.table.git","ssh_url":"git@github.com:Rdatatable/data.table.git","clone_url":"https://github.com/Rdatatable/data.table.git","svn_url":"https://github.com/Rdatatable/data.table","homepage":"https://github.com/Rdatatable/data.table/wiki","size":11674,"stargazers_count":513,"watchers_count":513,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":438,"mirror_url":null,"open_issues_count":375,"forks":438,"open_issues":375,"watchers":513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rdatatable/data.table/pulls/1457"},"html":{"href":"https://github.com/Rdatatable/data.table/pull/1457"},"issue":{"href":"https://api.github.com/repos/Rdatatable/data.table/issues/1457"},"comments":{"href":"https://api.github.com/repos/Rdatatable/data.table/issues/1457/comments"},"review_comments":{"href":"https://api.github.com/repos/Rdatatable/data.table/pulls/1457/comments"},"review_comment":{"href":"https://api.github.com/repos/Rdatatable/data.table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rdatatable/data.table/pulls/1457/commits"},"statuses":{"href":"https://api.github.com/repos/Rdatatable/data.table/statuses/0234b38f276820160f5cc38f17646c636d6c62b1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":2}}