{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/27609391","id":27609391,"diff_hunk":"@@ -459,22 +461,33 @@ char *read_string(FILE *fd, size_t cnt)\n   return (char *)str;\n }\n \n-/// Write a number to file \"fd\", MSB first, in \"len\" bytes.\n-/// @return OK/FAIL.\n-int put_bytes(FILE *fd, uintmax_t number, unsigned int len)\n+/// Writes a number to file \"fd\", MSB first, in \"len\" bytes.\n+/// @returns false in case of an error.","path":"src/nvim/misc2.c","position":24,"original_position":24,"commit_id":"3fe99f375d2ce6ca760a7f8e157abac8fd770c0e","original_commit_id":"3fe99f375d2ce6ca760a7f8e157abac8fd770c0e","user":{"login":"glts","id":1483271,"avatar_url":"https://avatars.githubusercontent.com/u/1483271?v=3","gravatar_id":"","url":"https://api.github.com/users/glts","html_url":"https://github.com/glts","followers_url":"https://api.github.com/users/glts/followers","following_url":"https://api.github.com/users/glts/following{/other_user}","gists_url":"https://api.github.com/users/glts/gists{/gist_id}","starred_url":"https://api.github.com/users/glts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glts/subscriptions","organizations_url":"https://api.github.com/users/glts/orgs","repos_url":"https://api.github.com/users/glts/repos","events_url":"https://api.github.com/users/glts/events{/privacy}","received_events_url":"https://api.github.com/users/glts/received_events","type":"User","site_admin":false},"body":"Isn't `@return` the convential tag for the return value? I didn't know that the `@returns` alias existed, but I see you've used it throughout.","created_at":"2015-04-01T20:43:00Z","updated_at":"2015-04-01T20:43:00Z","html_url":"https://github.com/neovim/neovim/pull/1805#discussion_r27609391","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/1805","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/27609391"},"html":{"href":"https://github.com/neovim/neovim/pull/1805#discussion_r27609391"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1805"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1805","id":27204140,"html_url":"https://github.com/neovim/neovim/pull/1805","diff_url":"https://github.com/neovim/neovim/pull/1805.diff","patch_url":"https://github.com/neovim/neovim/pull/1805.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1805","number":1805,"state":"open","locked":false,"title":"[RFC] vim-patch: Port parts of Vim 7.4.399.","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"body":"The `read_string`, `put_bytes`, and `put_time` functions in `misc2.c` are only used in `spell.c`; should they be moved there (in a separate commit)?\r\n\r\nThis is probably pretty horrible to review; I wanted to post the original patch minus the crypto stuff here, but if I make an error there, it's only more confusing. I tried to move around function definitions a bit so that the hunks align better in the diff, but it didn't always work out.\r\n\r\nI made some fairly minor \"crypto clean-up\" changes in related parts of the code (e.g. the `memline.c` changes); if you want, I can put this in a separate commit.\r\n\r\nhttps://code.google.com/p/vim/source/detail?r=v7-4-399","created_at":"2015-01-12T16:02:36Z","updated_at":"2015-04-01T20:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bb2b2d970d434d61f326998e9f8e3d4d6abde4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1805/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1805/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1805/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/3fe99f375d2ce6ca760a7f8e157abac8fd770c0e","head":{"label":"fwalch:vim-7.4.399","ref":"vim-7.4.399","sha":"3fe99f375d2ce6ca760a7f8e157abac8fd770c0e","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"repo":{"id":20288605,"name":"neovim","full_name":"fwalch/neovim","owner":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fwalch/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/fwalch/neovim","forks_url":"https://api.github.com/repos/fwalch/neovim/forks","keys_url":"https://api.github.com/repos/fwalch/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwalch/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwalch/neovim/teams","hooks_url":"https://api.github.com/repos/fwalch/neovim/hooks","issue_events_url":"https://api.github.com/repos/fwalch/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/fwalch/neovim/events","assignees_url":"https://api.github.com/repos/fwalch/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/fwalch/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/fwalch/neovim/tags","blobs_url":"https://api.github.com/repos/fwalch/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwalch/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwalch/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwalch/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwalch/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/fwalch/neovim/languages","stargazers_url":"https://api.github.com/repos/fwalch/neovim/stargazers","contributors_url":"https://api.github.com/repos/fwalch/neovim/contributors","subscribers_url":"https://api.github.com/repos/fwalch/neovim/subscribers","subscription_url":"https://api.github.com/repos/fwalch/neovim/subscription","commits_url":"https://api.github.com/repos/fwalch/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwalch/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwalch/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwalch/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/fwalch/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/fwalch/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwalch/neovim/merges","archive_url":"https://api.github.com/repos/fwalch/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwalch/neovim/downloads","issues_url":"https://api.github.com/repos/fwalch/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/fwalch/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/fwalch/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/fwalch/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwalch/neovim/labels{/name}","releases_url":"https://api.github.com/repos/fwalch/neovim/releases{/id}","created_at":"2014-05-29T09:18:20Z","updated_at":"2015-03-22T13:06:18Z","pushed_at":"2015-04-01T13:32:29Z","git_url":"git://github.com/fwalch/neovim.git","ssh_url":"git@github.com:fwalch/neovim.git","clone_url":"https://github.com/fwalch/neovim.git","svn_url":"https://github.com/fwalch/neovim","homepage":"http://neovim.org/","size":29093,"stargazers_count":1,"watchers_count":1,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"3e6989b5ec5096d2ac2afd0642cb8bd45c8e3f7e","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-04-01T20:16:45Z","pushed_at":"2015-04-01T18:38:42Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org","size":56115,"stargazers_count":12672,"watchers_count":12672,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":857,"mirror_url":null,"open_issues_count":440,"forks":857,"open_issues":440,"watchers":12672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1805"},"html":{"href":"https://github.com/neovim/neovim/pull/1805"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1805"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1805/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1805/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1805/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/3fe99f375d2ce6ca760a7f8e157abac8fd770c0e"}}}}