{"action":"created","issue":{"url":"https://api.github.com/repos/okTurtles/dnschain/issues/166","labels_url":"https://api.github.com/repos/okTurtles/dnschain/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/okTurtles/dnschain/issues/166/comments","events_url":"https://api.github.com/repos/okTurtles/dnschain/issues/166/events","html_url":"https://github.com/okTurtles/dnschain/pull/166","id":103669461,"number":166,"title":"added support for CORS HTTP headers","user":{"login":"bumi","id":318,"avatar_url":"https://avatars.githubusercontent.com/u/318?v=3","gravatar_id":"","url":"https://api.github.com/users/bumi","html_url":"https://github.com/bumi","followers_url":"https://api.github.com/users/bumi/followers","following_url":"https://api.github.com/users/bumi/following{/other_user}","gists_url":"https://api.github.com/users/bumi/gists{/gist_id}","starred_url":"https://api.github.com/users/bumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bumi/subscriptions","organizations_url":"https://api.github.com/users/bumi/orgs","repos_url":"https://api.github.com/users/bumi/repos","events_url":"https://api.github.com/users/bumi/events{/privacy}","received_events_url":"https://api.github.com/users/bumi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-08-28T08:23:56Z","updated_at":"2015-09-02T02:32:14Z","closed_at":"2015-09-02T02:26:29Z","pull_request":{"url":"https://api.github.com/repos/okTurtles/dnschain/pulls/166","html_url":"https://github.com/okTurtles/dnschain/pull/166","diff_url":"https://github.com/okTurtles/dnschain/pull/166.diff","patch_url":"https://github.com/okTurtles/dnschain/pull/166.patch"},"body":"Sets the Cross-Origin Resource Sharing (CORS) headers in a global express middleware.\r\nThis option is configurable and **disabled** by default.\r\n\r\nTo enable CORS use the following config entry:\r\n\r\n```\r\n[http]\r\ncors: true\r\n```\r\n-------\r\nSee #162 for original PR discussion about enabling CORS. This PR makes CORS configurable and disables CORS by default. \r\n\r\nI have a test that checks if CORS is disabled (having only the default configuration). But I am not sure how to change a global option on the fly within a test that affects the server bootup. - if needed. \r\n"},"comment":{"url":"https://api.github.com/repos/okTurtles/dnschain/issues/comments/136916802","html_url":"https://github.com/okTurtles/dnschain/pull/166#issuecomment-136916802","issue_url":"https://api.github.com/repos/okTurtles/dnschain/issues/166","id":136916802,"user":{"login":"taoeffect","id":138706,"avatar_url":"https://avatars.githubusercontent.com/u/138706?v=3","gravatar_id":"","url":"https://api.github.com/users/taoeffect","html_url":"https://github.com/taoeffect","followers_url":"https://api.github.com/users/taoeffect/followers","following_url":"https://api.github.com/users/taoeffect/following{/other_user}","gists_url":"https://api.github.com/users/taoeffect/gists{/gist_id}","starred_url":"https://api.github.com/users/taoeffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoeffect/subscriptions","organizations_url":"https://api.github.com/users/taoeffect/orgs","repos_url":"https://api.github.com/users/taoeffect/repos","events_url":"https://api.github.com/users/taoeffect/events{/privacy}","received_events_url":"https://api.github.com/users/taoeffect/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T02:32:14Z","updated_at":"2015-09-02T02:32:14Z","body":"> It's so funny, we've fixed iojs and broke the other two builds.\r\n\r\nWeird! After I merged it Travis appears fixed! No idea why it showed your PR as broken but worked after merge, but am glad that's the case, one less thing to fix. :)"}}