{"action":"created","comment":{"url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/comments/29617344","id":29617344,"diff_hunk":"@@ -10,8 +10,37 @@\n     <packaging>jar</packaging>\n     <name>Jasig CAS Client for Java - Core</name>\n \n+    <build>\n+        <plugins>\n+            <plugin>\n+                <groupId>org.apache.maven.plugins</groupId>\n+                <artifactId>maven-jar-plugin</artifactId>\n+                <version>2.6</version>\n+                <executions>\n+                    <execution>\n+                        <goals>\n+                            <goal>test-jar</goal>\n+                        </goals>\n+                    </execution>\n+                </executions>\n+            </plugin>\n+        </plugins>\n+    </build>\n+\n     <dependencies>\n         <dependency>\n+            <groupId>commons-lang</groupId>","path":"cas-client-core/pom.xml","position":23,"original_position":23,"commit_id":"2362d6ac179072ec0d1a040c7cdf7d3132931494","original_commit_id":"8038e69fc09feaa8a2dd4d1780a7e9521b9ad8f4","user":{"login":"serac","id":111432,"avatar_url":"https://avatars.githubusercontent.com/u/111432?v=3","gravatar_id":"","url":"https://api.github.com/users/serac","html_url":"https://github.com/serac","followers_url":"https://api.github.com/users/serac/followers","following_url":"https://api.github.com/users/serac/following{/other_user}","gists_url":"https://api.github.com/users/serac/gists{/gist_id}","starred_url":"https://api.github.com/users/serac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serac/subscriptions","organizations_url":"https://api.github.com/users/serac/orgs","repos_url":"https://api.github.com/users/serac/repos","events_url":"https://api.github.com/users/serac/events{/privacy}","received_events_url":"https://api.github.com/users/serac/received_events","type":"User","site_admin":false},"body":"Sounds good but let's do that in a separate issue/pull.","created_at":"2015-05-04T19:58:56Z","updated_at":"2015-05-04T19:58:56Z","html_url":"https://github.com/Jasig/java-cas-client/pull/101#discussion_r29617344","pull_request_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/comments/29617344"},"html":{"href":"https://github.com/Jasig/java-cas-client/pull/101#discussion_r29617344"},"pull_request":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101","id":33295912,"html_url":"https://github.com/Jasig/java-cas-client/pull/101","diff_url":"https://github.com/Jasig/java-cas-client/pull/101.diff","patch_url":"https://github.com/Jasig/java-cas-client/pull/101.patch","issue_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/101","number":101,"state":"open","locked":false,"title":"Remove OpenSAML and consolidate SAML components in support module","user":{"login":"serac","id":111432,"avatar_url":"https://avatars.githubusercontent.com/u/111432?v=3","gravatar_id":"","url":"https://api.github.com/users/serac","html_url":"https://github.com/serac","followers_url":"https://api.github.com/users/serac/followers","following_url":"https://api.github.com/users/serac/following{/other_user}","gists_url":"https://api.github.com/users/serac/gists{/gist_id}","starred_url":"https://api.github.com/users/serac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serac/subscriptions","organizations_url":"https://api.github.com/users/serac/orgs","repos_url":"https://api.github.com/users/serac/repos","events_url":"https://api.github.com/users/serac/events{/privacy}","received_events_url":"https://api.github.com/users/serac/received_events","type":"User","site_admin":false},"body":"Replace OpenSAML parsing of SAML 1.1 requests with simple XPath-based implementation and move SAML components into cas-client-support-saml module. The Tomcat modules depend on SAML components, but the new module is marked as optional.","created_at":"2015-04-14T20:22:29Z","updated_at":"2015-05-04T19:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"404ce716f1f85cea72a093a4138238231dbd98a5","assignee":{"login":"battags","id":58269,"avatar_url":"https://avatars.githubusercontent.com/u/58269?v=3","gravatar_id":"","url":"https://api.github.com/users/battags","html_url":"https://github.com/battags","followers_url":"https://api.github.com/users/battags/followers","following_url":"https://api.github.com/users/battags/following{/other_user}","gists_url":"https://api.github.com/users/battags/gists{/gist_id}","starred_url":"https://api.github.com/users/battags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/battags/subscriptions","organizations_url":"https://api.github.com/users/battags/orgs","repos_url":"https://api.github.com/users/battags/repos","events_url":"https://api.github.com/users/battags/events{/privacy}","received_events_url":"https://api.github.com/users/battags/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Jasig/java-cas-client/milestones/1","html_url":"https://github.com/Jasig/java-cas-client/milestones/3.3.0","labels_url":"https://api.github.com/repos/Jasig/java-cas-client/milestones/1/labels","id":358628,"number":1,"title":"3.3.0","description":"","creator":{"login":"battags","id":58269,"avatar_url":"https://avatars.githubusercontent.com/u/58269?v=3","gravatar_id":"","url":"https://api.github.com/users/battags","html_url":"https://github.com/battags","followers_url":"https://api.github.com/users/battags/followers","following_url":"https://api.github.com/users/battags/following{/other_user}","gists_url":"https://api.github.com/users/battags/gists{/gist_id}","starred_url":"https://api.github.com/users/battags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/battags/subscriptions","organizations_url":"https://api.github.com/users/battags/orgs","repos_url":"https://api.github.com/users/battags/repos","events_url":"https://api.github.com/users/battags/events{/privacy}","received_events_url":"https://api.github.com/users/battags/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2013-06-18T23:33:53Z","updated_at":"2015-04-14T20:23:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101/commits","review_comments_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101/comments","review_comment_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/101/comments","statuses_url":"https://api.github.com/repos/Jasig/java-cas-client/statuses/2362d6ac179072ec0d1a040c7cdf7d3132931494","head":{"label":"Jasig:no-opensaml","ref":"no-opensaml","sha":"2362d6ac179072ec0d1a040c7cdf7d3132931494","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":3645037,"name":"java-cas-client","full_name":"Jasig/java-cas-client","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/java-cas-client","description":"Jasig Java CAS Client","fork":false,"url":"https://api.github.com/repos/Jasig/java-cas-client","forks_url":"https://api.github.com/repos/Jasig/java-cas-client/forks","keys_url":"https://api.github.com/repos/Jasig/java-cas-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/java-cas-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/java-cas-client/teams","hooks_url":"https://api.github.com/repos/Jasig/java-cas-client/hooks","issue_events_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/java-cas-client/events","assignees_url":"https://api.github.com/repos/Jasig/java-cas-client/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/java-cas-client/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/java-cas-client/tags","blobs_url":"https://api.github.com/repos/Jasig/java-cas-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/java-cas-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/java-cas-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/java-cas-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/java-cas-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/java-cas-client/languages","stargazers_url":"https://api.github.com/repos/Jasig/java-cas-client/stargazers","contributors_url":"https://api.github.com/repos/Jasig/java-cas-client/contributors","subscribers_url":"https://api.github.com/repos/Jasig/java-cas-client/subscribers","subscription_url":"https://api.github.com/repos/Jasig/java-cas-client/subscription","commits_url":"https://api.github.com/repos/Jasig/java-cas-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/java-cas-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/java-cas-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jasig/java-cas-client/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/java-cas-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/java-cas-client/merges","archive_url":"https://api.github.com/repos/Jasig/java-cas-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/java-cas-client/downloads","issues_url":"https://api.github.com/repos/Jasig/java-cas-client/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/java-cas-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/java-cas-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/java-cas-client/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/java-cas-client/releases{/id}","created_at":"2012-03-07T02:29:34Z","updated_at":"2015-04-20T10:54:50Z","pushed_at":"2015-04-20T14:35:33Z","git_url":"git://github.com/Jasig/java-cas-client.git","ssh_url":"git@github.com:Jasig/java-cas-client.git","clone_url":"https://github.com/Jasig/java-cas-client.git","svn_url":"https://github.com/Jasig/java-cas-client","homepage":"https://wiki.jasig.org/display/CASC/CAS+Client+for+Java+3.1","size":3420,"stargazers_count":85,"watchers_count":85,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":14,"forks":105,"open_issues":14,"watchers":85,"default_branch":"master"}},"base":{"label":"Jasig:master","ref":"master","sha":"0e78ca914c7f65941f7efbdd03fc27923139fd3e","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":3645037,"name":"java-cas-client","full_name":"Jasig/java-cas-client","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/java-cas-client","description":"Jasig Java CAS Client","fork":false,"url":"https://api.github.com/repos/Jasig/java-cas-client","forks_url":"https://api.github.com/repos/Jasig/java-cas-client/forks","keys_url":"https://api.github.com/repos/Jasig/java-cas-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/java-cas-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/java-cas-client/teams","hooks_url":"https://api.github.com/repos/Jasig/java-cas-client/hooks","issue_events_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/java-cas-client/events","assignees_url":"https://api.github.com/repos/Jasig/java-cas-client/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/java-cas-client/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/java-cas-client/tags","blobs_url":"https://api.github.com/repos/Jasig/java-cas-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/java-cas-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/java-cas-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/java-cas-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/java-cas-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/java-cas-client/languages","stargazers_url":"https://api.github.com/repos/Jasig/java-cas-client/stargazers","contributors_url":"https://api.github.com/repos/Jasig/java-cas-client/contributors","subscribers_url":"https://api.github.com/repos/Jasig/java-cas-client/subscribers","subscription_url":"https://api.github.com/repos/Jasig/java-cas-client/subscription","commits_url":"https://api.github.com/repos/Jasig/java-cas-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/java-cas-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/java-cas-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jasig/java-cas-client/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/java-cas-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/java-cas-client/merges","archive_url":"https://api.github.com/repos/Jasig/java-cas-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/java-cas-client/downloads","issues_url":"https://api.github.com/repos/Jasig/java-cas-client/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/java-cas-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/java-cas-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/java-cas-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/java-cas-client/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/java-cas-client/releases{/id}","created_at":"2012-03-07T02:29:34Z","updated_at":"2015-04-20T10:54:50Z","pushed_at":"2015-04-20T14:35:33Z","git_url":"git://github.com/Jasig/java-cas-client.git","ssh_url":"git@github.com:Jasig/java-cas-client.git","clone_url":"https://github.com/Jasig/java-cas-client.git","svn_url":"https://github.com/Jasig/java-cas-client","homepage":"https://wiki.jasig.org/display/CASC/CAS+Client+for+Java+3.1","size":3420,"stargazers_count":85,"watchers_count":85,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":14,"forks":105,"open_issues":14,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101"},"html":{"href":"https://github.com/Jasig/java-cas-client/pull/101"},"issue":{"href":"https://api.github.com/repos/Jasig/java-cas-client/issues/101"},"comments":{"href":"https://api.github.com/repos/Jasig/java-cas-client/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jasig/java-cas-client/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/java-cas-client/statuses/2362d6ac179072ec0d1a040c7cdf7d3132931494"}}}}