{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/core/pulls/comments/30594660","id":30594660,"diff_hunk":"@@ -0,0 +1,151 @@\n+import { duplicate } from './lang';\n+\n+/**\n+ * A object with string keys and string or string array values that describes a query string.\n+ */\n+type ParamList = { [key: string]: string | string[] };\n+\n+/**\n+ * Parse a query string, returning a ParamList object.\n+ */\n+function parseQueryString(input: string): ParamList {\n+\tconst query = <{ [key: string]: string[] }> {};\n+\tinput.split('&').forEach(entry => {","path":"src/UrlSearchParams.ts","position":13,"original_position":13,"commit_id":"6c4e91cb134de5ddc4c96bbc18985337a2d16162","original_commit_id":"6c4e91cb134de5ddc4c96bbc18985337a2d16162","user":{"login":"jason0x43","id":1042866,"avatar_url":"https://avatars.githubusercontent.com/u/1042866?v=3","gravatar_id":"","url":"https://api.github.com/users/jason0x43","html_url":"https://github.com/jason0x43","followers_url":"https://api.github.com/users/jason0x43/followers","following_url":"https://api.github.com/users/jason0x43/following{/other_user}","gists_url":"https://api.github.com/users/jason0x43/gists{/gist_id}","starred_url":"https://api.github.com/users/jason0x43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason0x43/subscriptions","organizations_url":"https://api.github.com/users/jason0x43/orgs","repos_url":"https://api.github.com/users/jason0x43/repos","events_url":"https://api.github.com/users/jason0x43/events{/privacy}","received_events_url":"https://api.github.com/users/jason0x43/received_events","type":"User","site_admin":false},"body":"`for...of` seems like a good fit. I feel like our style guide is giving up one of the main benefits of arrow functions, though, in not recommending them for their compactness (which is kind of the whole point of the syntax).","created_at":"2015-05-19T12:45:17Z","updated_at":"2015-05-19T12:45:17Z","html_url":"https://github.com/dojo/core/pull/13#discussion_r30594660","pull_request_url":"https://api.github.com/repos/dojo/core/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/dojo/core/pulls/comments/30594660"},"html":{"href":"https://github.com/dojo/core/pull/13#discussion_r30594660"},"pull_request":{"href":"https://api.github.com/repos/dojo/core/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/dojo/core/pulls/13","id":35674792,"html_url":"https://github.com/dojo/core/pull/13","diff_url":"https://github.com/dojo/core/pull/13.diff","patch_url":"https://github.com/dojo/core/pull/13.patch","issue_url":"https://api.github.com/repos/dojo/core/issues/13","number":13,"state":"open","locked":false,"title":"Add UrlSearchParams and unit tests","user":{"login":"jason0x43","id":1042866,"avatar_url":"https://avatars.githubusercontent.com/u/1042866?v=3","gravatar_id":"","url":"https://api.github.com/users/jason0x43","html_url":"https://github.com/jason0x43","followers_url":"https://api.github.com/users/jason0x43/followers","following_url":"https://api.github.com/users/jason0x43/following{/other_user}","gists_url":"https://api.github.com/users/jason0x43/gists{/gist_id}","starred_url":"https://api.github.com/users/jason0x43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason0x43/subscriptions","organizations_url":"https://api.github.com/users/jason0x43/orgs","repos_url":"https://api.github.com/users/jason0x43/repos","events_url":"https://api.github.com/users/jason0x43/events{/privacy}","received_events_url":"https://api.github.com/users/jason0x43/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-18T21:20:57Z","updated_at":"2015-05-19T12:45:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b648768f00ce93d7da43870ab663ce9657d26b43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dojo/core/pulls/13/commits","review_comments_url":"https://api.github.com/repos/dojo/core/pulls/13/comments","review_comment_url":"https://api.github.com/repos/dojo/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/core/issues/13/comments","statuses_url":"https://api.github.com/repos/dojo/core/statuses/6c4e91cb134de5ddc4c96bbc18985337a2d16162","head":{"label":"jason0x43:urlsearchparams","ref":"urlsearchparams","sha":"6c4e91cb134de5ddc4c96bbc18985337a2d16162","user":{"login":"jason0x43","id":1042866,"avatar_url":"https://avatars.githubusercontent.com/u/1042866?v=3","gravatar_id":"","url":"https://api.github.com/users/jason0x43","html_url":"https://github.com/jason0x43","followers_url":"https://api.github.com/users/jason0x43/followers","following_url":"https://api.github.com/users/jason0x43/following{/other_user}","gists_url":"https://api.github.com/users/jason0x43/gists{/gist_id}","starred_url":"https://api.github.com/users/jason0x43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason0x43/subscriptions","organizations_url":"https://api.github.com/users/jason0x43/orgs","repos_url":"https://api.github.com/users/jason0x43/repos","events_url":"https://api.github.com/users/jason0x43/events{/privacy}","received_events_url":"https://api.github.com/users/jason0x43/received_events","type":"User","site_admin":false},"repo":{"id":35299464,"name":"core","full_name":"jason0x43/core","owner":{"login":"jason0x43","id":1042866,"avatar_url":"https://avatars.githubusercontent.com/u/1042866?v=3","gravatar_id":"","url":"https://api.github.com/users/jason0x43","html_url":"https://github.com/jason0x43","followers_url":"https://api.github.com/users/jason0x43/followers","following_url":"https://api.github.com/users/jason0x43/following{/other_user}","gists_url":"https://api.github.com/users/jason0x43/gists{/gist_id}","starred_url":"https://api.github.com/users/jason0x43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason0x43/subscriptions","organizations_url":"https://api.github.com/users/jason0x43/orgs","repos_url":"https://api.github.com/users/jason0x43/repos","events_url":"https://api.github.com/users/jason0x43/events{/privacy}","received_events_url":"https://api.github.com/users/jason0x43/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jason0x43/core","description":"TypeScript and JavaScript core library utilities","fork":true,"url":"https://api.github.com/repos/jason0x43/core","forks_url":"https://api.github.com/repos/jason0x43/core/forks","keys_url":"https://api.github.com/repos/jason0x43/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason0x43/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason0x43/core/teams","hooks_url":"https://api.github.com/repos/jason0x43/core/hooks","issue_events_url":"https://api.github.com/repos/jason0x43/core/issues/events{/number}","events_url":"https://api.github.com/repos/jason0x43/core/events","assignees_url":"https://api.github.com/repos/jason0x43/core/assignees{/user}","branches_url":"https://api.github.com/repos/jason0x43/core/branches{/branch}","tags_url":"https://api.github.com/repos/jason0x43/core/tags","blobs_url":"https://api.github.com/repos/jason0x43/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason0x43/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason0x43/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason0x43/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason0x43/core/statuses/{sha}","languages_url":"https://api.github.com/repos/jason0x43/core/languages","stargazers_url":"https://api.github.com/repos/jason0x43/core/stargazers","contributors_url":"https://api.github.com/repos/jason0x43/core/contributors","subscribers_url":"https://api.github.com/repos/jason0x43/core/subscribers","subscription_url":"https://api.github.com/repos/jason0x43/core/subscription","commits_url":"https://api.github.com/repos/jason0x43/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason0x43/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason0x43/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason0x43/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason0x43/core/contents/{+path}","compare_url":"https://api.github.com/repos/jason0x43/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason0x43/core/merges","archive_url":"https://api.github.com/repos/jason0x43/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason0x43/core/downloads","issues_url":"https://api.github.com/repos/jason0x43/core/issues{/number}","pulls_url":"https://api.github.com/repos/jason0x43/core/pulls{/number}","milestones_url":"https://api.github.com/repos/jason0x43/core/milestones{/number}","notifications_url":"https://api.github.com/repos/jason0x43/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason0x43/core/labels{/name}","releases_url":"https://api.github.com/repos/jason0x43/core/releases{/id}","created_at":"2015-05-08T20:07:20Z","updated_at":"2015-05-08T20:07:21Z","pushed_at":"2015-05-18T21:49:10Z","git_url":"git://github.com/jason0x43/core.git","ssh_url":"git@github.com:jason0x43/core.git","clone_url":"https://github.com/jason0x43/core.git","svn_url":"https://github.com/jason0x43/core","homepage":null,"size":412,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"57e981140194cd6a265bc2249e0197e340133a98","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":31790386,"name":"core","full_name":"dojo/core","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/core","description":"Dojo 2 package containing TypeScript and JavaScript core utilities","fork":false,"url":"https://api.github.com/repos/dojo/core","forks_url":"https://api.github.com/repos/dojo/core/forks","keys_url":"https://api.github.com/repos/dojo/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/core/teams","hooks_url":"https://api.github.com/repos/dojo/core/hooks","issue_events_url":"https://api.github.com/repos/dojo/core/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/core/events","assignees_url":"https://api.github.com/repos/dojo/core/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/core/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/core/tags","blobs_url":"https://api.github.com/repos/dojo/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/core/languages","stargazers_url":"https://api.github.com/repos/dojo/core/stargazers","contributors_url":"https://api.github.com/repos/dojo/core/contributors","subscribers_url":"https://api.github.com/repos/dojo/core/subscribers","subscription_url":"https://api.github.com/repos/dojo/core/subscription","commits_url":"https://api.github.com/repos/dojo/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/core/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/core/merges","archive_url":"https://api.github.com/repos/dojo/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/core/downloads","issues_url":"https://api.github.com/repos/dojo/core/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/core/labels{/name}","releases_url":"https://api.github.com/repos/dojo/core/releases{/id}","created_at":"2015-03-06T21:44:31Z","updated_at":"2015-05-19T07:46:49Z","pushed_at":"2015-05-18T21:36:38Z","git_url":"git://github.com/dojo/core.git","ssh_url":"git@github.com:dojo/core.git","clone_url":"https://github.com/dojo/core.git","svn_url":"https://github.com/dojo/core","homepage":"","size":1767,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/core/pulls/13"},"html":{"href":"https://github.com/dojo/core/pull/13"},"issue":{"href":"https://api.github.com/repos/dojo/core/issues/13"},"comments":{"href":"https://api.github.com/repos/dojo/core/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/core/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/core/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/core/statuses/6c4e91cb134de5ddc4c96bbc18985337a2d16162"}}}}