{"action":"created","issue":{"url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1981","labels_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1981/labels{/name}","comments_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1981/comments","events_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1981/events","html_url":"https://github.com/learning-unlimited/ESP-Website/pull/1981","id":123061600,"number":1981,"title":"Run linter-style checks for future Django support","user":{"login":"mgersh","id":2846855,"avatar_url":"https://avatars.githubusercontent.com/u/2846855?v=3","gravatar_id":"","url":"https://api.github.com/users/mgersh","html_url":"https://github.com/mgersh","followers_url":"https://api.github.com/users/mgersh/followers","following_url":"https://api.github.com/users/mgersh/following{/other_user}","gists_url":"https://api.github.com/users/mgersh/gists{/gist_id}","starred_url":"https://api.github.com/users/mgersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgersh/subscriptions","organizations_url":"https://api.github.com/users/mgersh/orgs","repos_url":"https://api.github.com/users/mgersh/repos","events_url":"https://api.github.com/users/mgersh/events{/privacy}","received_events_url":"https://api.github.com/users/mgersh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-19T04:29:03Z","updated_at":"2015-12-21T03:45:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/learning-unlimited/ESP-Website/pulls/1981","html_url":"https://github.com/learning-unlimited/ESP-Website/pull/1981","diff_url":"https://github.com/learning-unlimited/ESP-Website/pull/1981.diff","patch_url":"https://github.com/learning-unlimited/ESP-Website/pull/1981.patch"},"body":"This is intended to make gradually adding support for future Django versions easier, and hopefully make the next upgrade easier when it eventually happens. It creates a separate Travis job which runs a custom script to check for adding uses of features that won't work anymore and might not have test coverage but are greppable.\r\n\r\nRight now there's a check in the script for every feature that has a backwards-incompatible change in 1.9, or is deprecated and will be removed in 1.9 or 1.10, as long as it's anywhere remotely close to greppable. Many of them are commented out. Some of those are because we're still using the feature, some of them are false positives. Some of the false positives are because I didn't feel like spending much time thinking about any individual check and wrote a lot of them in obviously sloppy ways, so at this point those checks are mostly just placeholders for better checks. Some of them will just be hard to filter out with this style of check.\r\n\r\nThe idea is that once we've fixed a check, we uncomment it, which allows us to avoid adding any more uses, and when we eventually upgrade we won't have to recheck all of these. It also serves as a to-do list.\r\n\r\nA lot of these checks can be deleted if we ever implement logging for deprecation warnings."},"comment":{"url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/comments/166191935","html_url":"https://github.com/learning-unlimited/ESP-Website/pull/1981#issuecomment-166191935","issue_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1981","id":166191935,"user":{"login":"luac","id":1305639,"avatar_url":"https://avatars.githubusercontent.com/u/1305639?v=3","gravatar_id":"","url":"https://api.github.com/users/luac","html_url":"https://github.com/luac","followers_url":"https://api.github.com/users/luac/followers","following_url":"https://api.github.com/users/luac/following{/other_user}","gists_url":"https://api.github.com/users/luac/gists{/gist_id}","starred_url":"https://api.github.com/users/luac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luac/subscriptions","organizations_url":"https://api.github.com/users/luac/orgs","repos_url":"https://api.github.com/users/luac/repos","events_url":"https://api.github.com/users/luac/events{/privacy}","received_events_url":"https://api.github.com/users/luac/received_events","type":"User","site_admin":false},"created_at":"2015-12-21T03:45:51Z","updated_at":"2015-12-21T03:45:51Z","body":"Seems like we ought to be able to make a setting that flips any changes we want to make for future Django, though I don't know what those changes are and if it would be too messy to do like that."}}