{"action":"opened","number":105,"pull_request":{"url":"https://api.github.com/repos/google/brotli/pulls/105","id":35016421,"html_url":"https://github.com/google/brotli/pull/105","diff_url":"https://github.com/google/brotli/pull/105.diff","patch_url":"https://github.com/google/brotli/pull/105.patch","issue_url":"https://api.github.com/repos/google/brotli/issues/105","number":105,"state":"open","locked":false,"title":"[python] expose new encoder parameters as kwargs of brotli.compress","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"I added support for the new BrotliParams to the Python extension, as requested in https://github.com/google/brotli/issues/72.\r\nI also modified the bro.py script so that we can control these parameters from the command line.\r\n\r\nI have a question. In the encode.h, it's written that the parameter \"quality\" has to be in the range from 0 to 11. I presume this range is inclusive. Now, if I set the quality between 1 and 11, the output changes accordingly. However, if I set it to 0, the output is always truncated to the same 10 bytes. Does this mean that 0 is an invalid value for the 'quality' parameter?\r\n\r\nThanks.\r\n\r\nC.","created_at":"2015-05-08T14:58:15Z","updated_at":"2015-05-08T14:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/brotli/pulls/105/commits","review_comments_url":"https://api.github.com/repos/google/brotli/pulls/105/comments","review_comment_url":"https://api.github.com/repos/google/brotli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/brotli/issues/105/comments","statuses_url":"https://api.github.com/repos/google/brotli/statuses/971aad00b5e065dc8f6f856c023e7e65be33fbb1","head":{"label":"anthrotype:newparams","ref":"newparams","sha":"971aad00b5e065dc8f6f856c023e7e65be33fbb1","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"repo":{"id":27078302,"name":"brotli","full_name":"anthrotype/brotli","owner":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthrotype/brotli","description":"Brotli compression format","fork":true,"url":"https://api.github.com/repos/anthrotype/brotli","forks_url":"https://api.github.com/repos/anthrotype/brotli/forks","keys_url":"https://api.github.com/repos/anthrotype/brotli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthrotype/brotli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthrotype/brotli/teams","hooks_url":"https://api.github.com/repos/anthrotype/brotli/hooks","issue_events_url":"https://api.github.com/repos/anthrotype/brotli/issues/events{/number}","events_url":"https://api.github.com/repos/anthrotype/brotli/events","assignees_url":"https://api.github.com/repos/anthrotype/brotli/assignees{/user}","branches_url":"https://api.github.com/repos/anthrotype/brotli/branches{/branch}","tags_url":"https://api.github.com/repos/anthrotype/brotli/tags","blobs_url":"https://api.github.com/repos/anthrotype/brotli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthrotype/brotli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthrotype/brotli/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthrotype/brotli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthrotype/brotli/statuses/{sha}","languages_url":"https://api.github.com/repos/anthrotype/brotli/languages","stargazers_url":"https://api.github.com/repos/anthrotype/brotli/stargazers","contributors_url":"https://api.github.com/repos/anthrotype/brotli/contributors","subscribers_url":"https://api.github.com/repos/anthrotype/brotli/subscribers","subscription_url":"https://api.github.com/repos/anthrotype/brotli/subscription","commits_url":"https://api.github.com/repos/anthrotype/brotli/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthrotype/brotli/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthrotype/brotli/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthrotype/brotli/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthrotype/brotli/contents/{+path}","compare_url":"https://api.github.com/repos/anthrotype/brotli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthrotype/brotli/merges","archive_url":"https://api.github.com/repos/anthrotype/brotli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthrotype/brotli/downloads","issues_url":"https://api.github.com/repos/anthrotype/brotli/issues{/number}","pulls_url":"https://api.github.com/repos/anthrotype/brotli/pulls{/number}","milestones_url":"https://api.github.com/repos/anthrotype/brotli/milestones{/number}","notifications_url":"https://api.github.com/repos/anthrotype/brotli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthrotype/brotli/labels{/name}","releases_url":"https://api.github.com/repos/anthrotype/brotli/releases{/id}","created_at":"2014-11-24T14:08:16Z","updated_at":"2015-05-08T09:13:13Z","pushed_at":"2015-05-08T14:49:20Z","git_url":"git://github.com/anthrotype/brotli.git","ssh_url":"git@github.com:anthrotype/brotli.git","clone_url":"https://github.com/anthrotype/brotli.git","svn_url":"https://github.com/anthrotype/brotli","homepage":"","size":2801,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"288f70d7ea1b0a4356d8ed331fdd28674b8ea4e6","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":24993138,"name":"brotli","full_name":"google/brotli","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/brotli","description":"Brotli compression format","fork":false,"url":"https://api.github.com/repos/google/brotli","forks_url":"https://api.github.com/repos/google/brotli/forks","keys_url":"https://api.github.com/repos/google/brotli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/brotli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/brotli/teams","hooks_url":"https://api.github.com/repos/google/brotli/hooks","issue_events_url":"https://api.github.com/repos/google/brotli/issues/events{/number}","events_url":"https://api.github.com/repos/google/brotli/events","assignees_url":"https://api.github.com/repos/google/brotli/assignees{/user}","branches_url":"https://api.github.com/repos/google/brotli/branches{/branch}","tags_url":"https://api.github.com/repos/google/brotli/tags","blobs_url":"https://api.github.com/repos/google/brotli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/brotli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/brotli/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/brotli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/brotli/statuses/{sha}","languages_url":"https://api.github.com/repos/google/brotli/languages","stargazers_url":"https://api.github.com/repos/google/brotli/stargazers","contributors_url":"https://api.github.com/repos/google/brotli/contributors","subscribers_url":"https://api.github.com/repos/google/brotli/subscribers","subscription_url":"https://api.github.com/repos/google/brotli/subscription","commits_url":"https://api.github.com/repos/google/brotli/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/brotli/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/brotli/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/brotli/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/brotli/contents/{+path}","compare_url":"https://api.github.com/repos/google/brotli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/brotli/merges","archive_url":"https://api.github.com/repos/google/brotli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/brotli/downloads","issues_url":"https://api.github.com/repos/google/brotli/issues{/number}","pulls_url":"https://api.github.com/repos/google/brotli/pulls{/number}","milestones_url":"https://api.github.com/repos/google/brotli/milestones{/number}","notifications_url":"https://api.github.com/repos/google/brotli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/brotli/labels{/name}","releases_url":"https://api.github.com/repos/google/brotli/releases{/id}","created_at":"2014-10-09T14:35:14Z","updated_at":"2015-05-08T09:11:22Z","pushed_at":"2015-05-08T09:11:22Z","git_url":"git://github.com/google/brotli.git","ssh_url":"git@github.com:google/brotli.git","clone_url":"https://github.com/google/brotli.git","svn_url":"https://github.com/google/brotli","homepage":"","size":3146,"stargazers_count":64,"watchers_count":64,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":7,"forks":16,"open_issues":7,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/brotli/pulls/105"},"html":{"href":"https://github.com/google/brotli/pull/105"},"issue":{"href":"https://api.github.com/repos/google/brotli/issues/105"},"comments":{"href":"https://api.github.com/repos/google/brotli/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/google/brotli/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/google/brotli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/brotli/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/google/brotli/statuses/971aad00b5e065dc8f6f856c023e7e65be33fbb1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":200,"deletions":84,"changed_files":2}}