{"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/33415976","id":33415976,"diff_hunk":"@@ -0,0 +1,29 @@\n+//Returns the lowest turf available on a given Z-level, defaults to space.\n+var/global/list/base_turf_by_z = list()","path":"code/game/base_turf.dm","position":2,"original_position":2,"commit_id":"3cd029bd165d01e6f930e6d62907fc4c58ead716","original_commit_id":"3cd029bd165d01e6f930e6d62907fc4c58ead716","user":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"body":"this should be a var on the map datum or even z level datums","created_at":"2015-06-27T20:36:56Z","updated_at":"2015-06-27T20:36:56Z","html_url":"https://github.com/d3athrow/vgstation13/pull/5167#discussion_r33415976","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/33415976"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/5167#discussion_r33415976"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167","id":38715092,"html_url":"https://github.com/d3athrow/vgstation13/pull/5167","diff_url":"https://github.com/d3athrow/vgstation13/pull/5167.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/5167.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/5167","number":5167,"state":"open","locked":false,"title":"Port experimental base_turf system from Baystation","user":{"login":"dylanstrategie","id":6137403,"avatar_url":"https://avatars.githubusercontent.com/u/6137403?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanstrategie","html_url":"https://github.com/dylanstrategie","followers_url":"https://api.github.com/users/dylanstrategie/followers","following_url":"https://api.github.com/users/dylanstrategie/following{/other_user}","gists_url":"https://api.github.com/users/dylanstrategie/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanstrategie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanstrategie/subscriptions","organizations_url":"https://api.github.com/users/dylanstrategie/orgs","repos_url":"https://api.github.com/users/dylanstrategie/repos","events_url":"https://api.github.com/users/dylanstrategie/events{/privacy}","received_events_url":"https://api.github.com/users/dylanstrategie/received_events","type":"User","site_admin":false},"body":"Fuck you too for not even trying when you were working on Endgame @N3X15\r\n\r\nBecause Baystation has finally gotten around to it, and because the code looked simple, I decided to get my hands on porting a system that allows up to define base_turfs. As a bonus, it also defines them per Z-level. So if you wanted, you could have a space station, and a Z-level on a map-spanning asteroid, and then an away mission on land, all in the same file\r\n\r\nNote that you can modify it mid-round via a DEBUG flag verb, it will however only affect destroyed turfs (it won't change space, which I suppose is intentional)\r\n\r\nTested were destroying walls and floors and even dropping a bomb in the middle of Medbay\r\n\r\nNot tested were more finicky conditions like the Singularity or buildmode. I simply replaced all ChangeTurf() instructions that pointed to space, because that is how Baystation implemented it\r\n\r\nOnly problem with this is that it doesn't work on a per-map basis, so unless some wizardry is done on that code, it'll be hard to get anything interesting going with it\r\n\r\nDiscussions go below. Since this is pure code refactor, I doubt there'll be much up to debate","created_at":"2015-06-27T20:28:12Z","updated_at":"2015-06-27T20:36:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca25a41a3e515c90c5d18a19eee8b71a95c9d4c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/5167/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/3cd029bd165d01e6f930e6d62907fc4c58ead716","head":{"label":"dylanstrategie:Base-Turf-Port","ref":"Base-Turf-Port","sha":"3cd029bd165d01e6f930e6d62907fc4c58ead716","user":{"login":"dylanstrategie","id":6137403,"avatar_url":"https://avatars.githubusercontent.com/u/6137403?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanstrategie","html_url":"https://github.com/dylanstrategie","followers_url":"https://api.github.com/users/dylanstrategie/followers","following_url":"https://api.github.com/users/dylanstrategie/following{/other_user}","gists_url":"https://api.github.com/users/dylanstrategie/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanstrategie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanstrategie/subscriptions","organizations_url":"https://api.github.com/users/dylanstrategie/orgs","repos_url":"https://api.github.com/users/dylanstrategie/repos","events_url":"https://api.github.com/users/dylanstrategie/events{/privacy}","received_events_url":"https://api.github.com/users/dylanstrategie/received_events","type":"User","site_admin":false},"repo":{"id":37889804,"name":"vgstation13","full_name":"dylanstrategie/vgstation13","owner":{"login":"dylanstrategie","id":6137403,"avatar_url":"https://avatars.githubusercontent.com/u/6137403?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanstrategie","html_url":"https://github.com/dylanstrategie","followers_url":"https://api.github.com/users/dylanstrategie/followers","following_url":"https://api.github.com/users/dylanstrategie/following{/other_user}","gists_url":"https://api.github.com/users/dylanstrategie/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanstrategie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanstrategie/subscriptions","organizations_url":"https://api.github.com/users/dylanstrategie/orgs","repos_url":"https://api.github.com/users/dylanstrategie/repos","events_url":"https://api.github.com/users/dylanstrategie/events{/privacy}","received_events_url":"https://api.github.com/users/dylanstrategie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dylanstrategie/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/dylanstrategie/vgstation13","forks_url":"https://api.github.com/repos/dylanstrategie/vgstation13/forks","keys_url":"https://api.github.com/repos/dylanstrategie/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dylanstrategie/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dylanstrategie/vgstation13/teams","hooks_url":"https://api.github.com/repos/dylanstrategie/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/dylanstrategie/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/dylanstrategie/vgstation13/events","assignees_url":"https://api.github.com/repos/dylanstrategie/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/dylanstrategie/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/dylanstrategie/vgstation13/tags","blobs_url":"https://api.github.com/repos/dylanstrategie/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dylanstrategie/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dylanstrategie/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/dylanstrategie/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dylanstrategie/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/dylanstrategie/vgstation13/languages","stargazers_url":"https://api.github.com/repos/dylanstrategie/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/dylanstrategie/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/dylanstrategie/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/dylanstrategie/vgstation13/subscription","commits_url":"https://api.github.com/repos/dylanstrategie/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/dylanstrategie/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/dylanstrategie/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/dylanstrategie/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/dylanstrategie/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/dylanstrategie/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dylanstrategie/vgstation13/merges","archive_url":"https://api.github.com/repos/dylanstrategie/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dylanstrategie/vgstation13/downloads","issues_url":"https://api.github.com/repos/dylanstrategie/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/dylanstrategie/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/dylanstrategie/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/dylanstrategie/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dylanstrategie/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/dylanstrategie/vgstation13/releases{/id}","created_at":"2015-06-23T01:20:23Z","updated_at":"2015-06-23T01:20:35Z","pushed_at":"2015-06-27T20:26:59Z","git_url":"git://github.com/dylanstrategie/vgstation13.git","ssh_url":"git@github.com:dylanstrategie/vgstation13.git","clone_url":"https://github.com/dylanstrategie/vgstation13.git","svn_url":"https://github.com/dylanstrategie/vgstation13","homepage":"","size":894762,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"cf24a5bc1d4626513d98157fd6cbbe81d3b4d22f","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2015-06-19T02:20:46Z","pushed_at":"2015-06-27T20:28:12Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1103587,"stargazers_count":60,"watchers_count":60,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":714,"forks":172,"open_issues":714,"watchers":60,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/5167"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/5167"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/5167/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/5167/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/3cd029bd165d01e6f930e6d62907fc4c58ead716"}}}}