{"action":"created","comment":{"url":"https://api.github.com/repos/18F/openFEC/pulls/comments/40092042","id":40092042,"diff_hunk":"@@ -33,8 +33,6 @@ select\n     items_on_hand_liquidated as items_on_hand_liquidated,\n     loans_received_from_cand_per as loans_received_from_candidate_period,\n     loans_received_from_cand_ytd as loans_received_from_candidate_ytd,\n-    net_contb_sum_page_per as net_contributions_period,\n-    net_op_exp_sum_page_per as net_operating_expenditures_period,","path":"data/sql_updates/create_reports_presidential_view.sql","position":5,"original_position":5,"commit_id":"7d2d4bcdc20e7ec926cd4458b390edc6b40bf4af","original_commit_id":"7d2d4bcdc20e7ec926cd4458b390edc6b40bf4af","user":{"login":"LindsayYoung","id":4406333,"avatar_url":"https://avatars.githubusercontent.com/u/4406333?v=3","gravatar_id":"","url":"https://api.github.com/users/LindsayYoung","html_url":"https://github.com/LindsayYoung","followers_url":"https://api.github.com/users/LindsayYoung/followers","following_url":"https://api.github.com/users/LindsayYoung/following{/other_user}","gists_url":"https://api.github.com/users/LindsayYoung/gists{/gist_id}","starred_url":"https://api.github.com/users/LindsayYoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindsayYoung/subscriptions","organizations_url":"https://api.github.com/users/LindsayYoung/orgs","repos_url":"https://api.github.com/users/LindsayYoung/repos","events_url":"https://api.github.com/users/LindsayYoung/events{/privacy}","received_events_url":"https://api.github.com/users/LindsayYoung/received_events","type":"User","site_admin":false},"body":"We want to take the sums out of totals, but I think we should leave them in all the reports, since this is data reported by the committee and we do display it in the summaries. ","created_at":"2015-09-22T14:24:17Z","updated_at":"2015-09-22T14:24:17Z","html_url":"https://github.com/18F/openFEC/pull/1213#discussion_r40092042","pull_request_url":"https://api.github.com/repos/18F/openFEC/pulls/1213","_links":{"self":{"href":"https://api.github.com/repos/18F/openFEC/pulls/comments/40092042"},"html":{"href":"https://github.com/18F/openFEC/pull/1213#discussion_r40092042"},"pull_request":{"href":"https://api.github.com/repos/18F/openFEC/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/18F/openFEC/pulls/1213","id":45568941,"html_url":"https://github.com/18F/openFEC/pull/1213","diff_url":"https://github.com/18F/openFEC/pull/1213.diff","patch_url":"https://github.com/18F/openFEC/pull/1213.patch","issue_url":"https://api.github.com/repos/18F/openFEC/issues/1213","number":1213,"state":"open","locked":false,"title":"Feature/fix cumulative totals","user":{"login":"jmcarp","id":1633460,"avatar_url":"https://avatars.githubusercontent.com/u/1633460?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"body":"Fix net contributions for presidential data.\r\n\r\nUnlike Congressional and PAC and Party reports, Presidential reports\r\ndon't include \"net contributions\" and \"net expenditures\" fields that are\r\ndistinct from from total contributions and expenditures. Currently,\r\nwe're treating cycle-to-date contributions and expenditures as net for\r\nthe reporting period, which leads to dramatically inflated estimates in\r\nthe API. This patch removes net contributions and expenditures from\r\npresidential reports, since they don't seem to exist, and uses the most\r\nrecent cycle-to-date contributions and expenditures values for\r\npresidential totals instead of summing cumulative totals from each\r\nreport.\r\n\r\n[Resolves #1212]\r\n\r\nPinging @LindsayYoung for review.","created_at":"2015-09-21T16:20:10Z","updated_at":"2015-09-22T14:24:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a798228a76a861e3507ddb58251e1a4adbb1af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/18F/openFEC/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/18F/openFEC/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/18F/openFEC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/openFEC/issues/1213/comments","statuses_url":"https://api.github.com/repos/18F/openFEC/statuses/7d2d4bcdc20e7ec926cd4458b390edc6b40bf4af","head":{"label":"jmcarp:feature/fix-cumulative-totals","ref":"feature/fix-cumulative-totals","sha":"7d2d4bcdc20e7ec926cd4458b390edc6b40bf4af","user":{"login":"jmcarp","id":1633460,"avatar_url":"https://avatars.githubusercontent.com/u/1633460?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"repo":{"id":33560779,"name":"openFEC","full_name":"jmcarp/openFEC","owner":{"login":"jmcarp","id":1633460,"avatar_url":"https://avatars.githubusercontent.com/u/1633460?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmcarp/openFEC","description":"An experiment in taking data from the Federal Election Commission and harmonizing/cleaning it up to make it easier for external developers to use and analyze.","fork":true,"url":"https://api.github.com/repos/jmcarp/openFEC","forks_url":"https://api.github.com/repos/jmcarp/openFEC/forks","keys_url":"https://api.github.com/repos/jmcarp/openFEC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcarp/openFEC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcarp/openFEC/teams","hooks_url":"https://api.github.com/repos/jmcarp/openFEC/hooks","issue_events_url":"https://api.github.com/repos/jmcarp/openFEC/issues/events{/number}","events_url":"https://api.github.com/repos/jmcarp/openFEC/events","assignees_url":"https://api.github.com/repos/jmcarp/openFEC/assignees{/user}","branches_url":"https://api.github.com/repos/jmcarp/openFEC/branches{/branch}","tags_url":"https://api.github.com/repos/jmcarp/openFEC/tags","blobs_url":"https://api.github.com/repos/jmcarp/openFEC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcarp/openFEC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcarp/openFEC/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcarp/openFEC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcarp/openFEC/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcarp/openFEC/languages","stargazers_url":"https://api.github.com/repos/jmcarp/openFEC/stargazers","contributors_url":"https://api.github.com/repos/jmcarp/openFEC/contributors","subscribers_url":"https://api.github.com/repos/jmcarp/openFEC/subscribers","subscription_url":"https://api.github.com/repos/jmcarp/openFEC/subscription","commits_url":"https://api.github.com/repos/jmcarp/openFEC/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcarp/openFEC/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcarp/openFEC/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcarp/openFEC/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmcarp/openFEC/contents/{+path}","compare_url":"https://api.github.com/repos/jmcarp/openFEC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcarp/openFEC/merges","archive_url":"https://api.github.com/repos/jmcarp/openFEC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcarp/openFEC/downloads","issues_url":"https://api.github.com/repos/jmcarp/openFEC/issues{/number}","pulls_url":"https://api.github.com/repos/jmcarp/openFEC/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcarp/openFEC/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcarp/openFEC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcarp/openFEC/labels{/name}","releases_url":"https://api.github.com/repos/jmcarp/openFEC/releases{/id}","created_at":"2015-04-07T18:28:37Z","updated_at":"2015-04-07T18:28:38Z","pushed_at":"2015-09-22T14:00:08Z","git_url":"git://github.com/jmcarp/openFEC.git","ssh_url":"git@github.com:jmcarp/openFEC.git","clone_url":"https://github.com/jmcarp/openFEC.git","svn_url":"https://github.com/jmcarp/openFEC","homepage":null,"size":46342,"stargazers_count":0,"watchers_count":0,"language":"SQLPL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"18F:develop","ref":"develop","sha":"a18512644cbcd7f63aa89d6453954b893cc876e1","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":23116127,"name":"openFEC","full_name":"18F/openFEC","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/openFEC","description":"The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.","fork":false,"url":"https://api.github.com/repos/18F/openFEC","forks_url":"https://api.github.com/repos/18F/openFEC/forks","keys_url":"https://api.github.com/repos/18F/openFEC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/openFEC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/openFEC/teams","hooks_url":"https://api.github.com/repos/18F/openFEC/hooks","issue_events_url":"https://api.github.com/repos/18F/openFEC/issues/events{/number}","events_url":"https://api.github.com/repos/18F/openFEC/events","assignees_url":"https://api.github.com/repos/18F/openFEC/assignees{/user}","branches_url":"https://api.github.com/repos/18F/openFEC/branches{/branch}","tags_url":"https://api.github.com/repos/18F/openFEC/tags","blobs_url":"https://api.github.com/repos/18F/openFEC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/openFEC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/openFEC/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/openFEC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/openFEC/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/openFEC/languages","stargazers_url":"https://api.github.com/repos/18F/openFEC/stargazers","contributors_url":"https://api.github.com/repos/18F/openFEC/contributors","subscribers_url":"https://api.github.com/repos/18F/openFEC/subscribers","subscription_url":"https://api.github.com/repos/18F/openFEC/subscription","commits_url":"https://api.github.com/repos/18F/openFEC/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/openFEC/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/openFEC/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/openFEC/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/openFEC/contents/{+path}","compare_url":"https://api.github.com/repos/18F/openFEC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/openFEC/merges","archive_url":"https://api.github.com/repos/18F/openFEC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/openFEC/downloads","issues_url":"https://api.github.com/repos/18F/openFEC/issues{/number}","pulls_url":"https://api.github.com/repos/18F/openFEC/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/openFEC/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/openFEC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/openFEC/labels{/name}","releases_url":"https://api.github.com/repos/18F/openFEC/releases{/id}","created_at":"2014-08-19T15:51:14Z","updated_at":"2015-09-12T19:48:26Z","pushed_at":"2015-09-22T14:11:27Z","git_url":"git://github.com/18F/openFEC.git","ssh_url":"git@github.com:18F/openFEC.git","clone_url":"https://github.com/18F/openFEC.git","svn_url":"https://github.com/18F/openFEC","homepage":"https://api.open.fec.gov/developers","size":47127,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":98,"forks":20,"open_issues":98,"watchers":97,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/openFEC/pulls/1213"},"html":{"href":"https://github.com/18F/openFEC/pull/1213"},"issue":{"href":"https://api.github.com/repos/18F/openFEC/issues/1213"},"comments":{"href":"https://api.github.com/repos/18F/openFEC/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/openFEC/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/openFEC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/openFEC/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/18F/openFEC/statuses/7d2d4bcdc20e7ec926cd4458b390edc6b40bf4af"}}}}