{"action":"created","comment":{"url":"https://api.github.com/repos/debops/ansible-tinc/pulls/comments/37442795","id":37442795,"diff_hunk":"@@ -115,6 +115,14 @@\n   with_dict: tinc_external_hosts\n   when: tinc_external_hosts is defined and tinc_external_hosts\n \n+- name: check systemd\n+  shell: \"cat /proc/1/comm\"\n+  ignore_errors: yes","path":"tasks/main.yml","position":6,"original_position":6,"commit_id":"c63338dc9a78ed87a13e6b56bb652aea50d697d3","original_commit_id":"c63338dc9a78ed87a13e6b56bb652aea50d697d3","user":{"login":"drybjed","id":1043958,"avatar_url":"https://avatars.githubusercontent.com/u/1043958?v=3","gravatar_id":"","url":"https://api.github.com/users/drybjed","html_url":"https://github.com/drybjed","followers_url":"https://api.github.com/users/drybjed/followers","following_url":"https://api.github.com/users/drybjed/following{/other_user}","gists_url":"https://api.github.com/users/drybjed/gists{/gist_id}","starred_url":"https://api.github.com/users/drybjed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drybjed/subscriptions","organizations_url":"https://api.github.com/users/drybjed/orgs","repos_url":"https://api.github.com/users/drybjed/repos","events_url":"https://api.github.com/users/drybjed/events{/privacy}","received_events_url":"https://api.github.com/users/drybjed/received_events","type":"User","site_admin":false},"body":"I don't accept `ignore_errors: Tru` in roles - you should handle the errors, not ignore them. For this check, you could test if `/run/systemd/system` directory is present, it's a pretty good indicator that a given host is running using `systemd`.\r\n\r\nAlso, if you only set up the unit files, you can do it without checking if `systemd` is present; default Wheezy installation contains `/etc/systemd/` directory with proper structure, you can just put units there regardless. They will be used when needed.","created_at":"2015-08-19T17:31:54Z","updated_at":"2015-08-19T17:31:54Z","html_url":"https://github.com/debops/ansible-tinc/pull/4#discussion_r37442795","pull_request_url":"https://api.github.com/repos/debops/ansible-tinc/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/debops/ansible-tinc/pulls/comments/37442795"},"html":{"href":"https://github.com/debops/ansible-tinc/pull/4#discussion_r37442795"},"pull_request":{"href":"https://api.github.com/repos/debops/ansible-tinc/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/debops/ansible-tinc/pulls/4","id":42789885,"html_url":"https://github.com/debops/ansible-tinc/pull/4","diff_url":"https://github.com/debops/ansible-tinc/pull/4.diff","patch_url":"https://github.com/debops/ansible-tinc/pull/4.patch","issue_url":"https://api.github.com/repos/debops/ansible-tinc/issues/4","number":4,"state":"open","locked":false,"title":"add Systemd tinc@.service","user":{"login":"le9i0nx","id":814292,"avatar_url":"https://avatars.githubusercontent.com/u/814292?v=3","gravatar_id":"","url":"https://api.github.com/users/le9i0nx","html_url":"https://github.com/le9i0nx","followers_url":"https://api.github.com/users/le9i0nx/followers","following_url":"https://api.github.com/users/le9i0nx/following{/other_user}","gists_url":"https://api.github.com/users/le9i0nx/gists{/gist_id}","starred_url":"https://api.github.com/users/le9i0nx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le9i0nx/subscriptions","organizations_url":"https://api.github.com/users/le9i0nx/orgs","repos_url":"https://api.github.com/users/le9i0nx/repos","events_url":"https://api.github.com/users/le9i0nx/events{/privacy}","received_events_url":"https://api.github.com/users/le9i0nx/received_events","type":"User","site_admin":false},"body":"added service, if there is systemd, which monitors the process and restarts if it falls.","created_at":"2015-08-19T08:44:54Z","updated_at":"2015-08-19T17:31:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c197169707f1133ca02a7c75fa874747e0d93ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/debops/ansible-tinc/pulls/4/commits","review_comments_url":"https://api.github.com/repos/debops/ansible-tinc/pulls/4/comments","review_comment_url":"https://api.github.com/repos/debops/ansible-tinc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/debops/ansible-tinc/issues/4/comments","statuses_url":"https://api.github.com/repos/debops/ansible-tinc/statuses/c63338dc9a78ed87a13e6b56bb652aea50d697d3","head":{"label":"le9i0nx:systemd","ref":"systemd","sha":"c63338dc9a78ed87a13e6b56bb652aea50d697d3","user":{"login":"le9i0nx","id":814292,"avatar_url":"https://avatars.githubusercontent.com/u/814292?v=3","gravatar_id":"","url":"https://api.github.com/users/le9i0nx","html_url":"https://github.com/le9i0nx","followers_url":"https://api.github.com/users/le9i0nx/followers","following_url":"https://api.github.com/users/le9i0nx/following{/other_user}","gists_url":"https://api.github.com/users/le9i0nx/gists{/gist_id}","starred_url":"https://api.github.com/users/le9i0nx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le9i0nx/subscriptions","organizations_url":"https://api.github.com/users/le9i0nx/orgs","repos_url":"https://api.github.com/users/le9i0nx/repos","events_url":"https://api.github.com/users/le9i0nx/events{/privacy}","received_events_url":"https://api.github.com/users/le9i0nx/received_events","type":"User","site_admin":false},"repo":{"id":40710506,"name":"ansible-tinc","full_name":"le9i0nx/ansible-tinc","owner":{"login":"le9i0nx","id":814292,"avatar_url":"https://avatars.githubusercontent.com/u/814292?v=3","gravatar_id":"","url":"https://api.github.com/users/le9i0nx","html_url":"https://github.com/le9i0nx","followers_url":"https://api.github.com/users/le9i0nx/followers","following_url":"https://api.github.com/users/le9i0nx/following{/other_user}","gists_url":"https://api.github.com/users/le9i0nx/gists{/gist_id}","starred_url":"https://api.github.com/users/le9i0nx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le9i0nx/subscriptions","organizations_url":"https://api.github.com/users/le9i0nx/orgs","repos_url":"https://api.github.com/users/le9i0nx/repos","events_url":"https://api.github.com/users/le9i0nx/events{/privacy}","received_events_url":"https://api.github.com/users/le9i0nx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/le9i0nx/ansible-tinc","description":"Configure tinc mesh VPN network","fork":true,"url":"https://api.github.com/repos/le9i0nx/ansible-tinc","forks_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/forks","keys_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/teams","hooks_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/hooks","issue_events_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/issues/events{/number}","events_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/events","assignees_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/assignees{/user}","branches_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/branches{/branch}","tags_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/tags","blobs_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/statuses/{sha}","languages_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/languages","stargazers_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/stargazers","contributors_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/contributors","subscribers_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/subscribers","subscription_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/subscription","commits_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/contents/{+path}","compare_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/merges","archive_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/downloads","issues_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/issues{/number}","pulls_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/pulls{/number}","milestones_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/milestones{/number}","notifications_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/labels{/name}","releases_url":"https://api.github.com/repos/le9i0nx/ansible-tinc/releases{/id}","created_at":"2015-08-14T10:51:27Z","updated_at":"2015-07-20T14:32:19Z","pushed_at":"2015-08-19T08:26:43Z","git_url":"git://github.com/le9i0nx/ansible-tinc.git","ssh_url":"git@github.com:le9i0nx/ansible-tinc.git","clone_url":"https://github.com/le9i0nx/ansible-tinc.git","svn_url":"https://github.com/le9i0nx/ansible-tinc","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"debops:master","ref":"master","sha":"41f2d1db677fe7306c8c11686b8783e4e3faf86b","user":{"login":"debops","id":8523739,"avatar_url":"https://avatars.githubusercontent.com/u/8523739?v=3","gravatar_id":"","url":"https://api.github.com/users/debops","html_url":"https://github.com/debops","followers_url":"https://api.github.com/users/debops/followers","following_url":"https://api.github.com/users/debops/following{/other_user}","gists_url":"https://api.github.com/users/debops/gists{/gist_id}","starred_url":"https://api.github.com/users/debops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debops/subscriptions","organizations_url":"https://api.github.com/users/debops/orgs","repos_url":"https://api.github.com/users/debops/repos","events_url":"https://api.github.com/users/debops/events{/privacy}","received_events_url":"https://api.github.com/users/debops/received_events","type":"Organization","site_admin":false},"repo":{"id":35940001,"name":"ansible-tinc","full_name":"debops/ansible-tinc","owner":{"login":"debops","id":8523739,"avatar_url":"https://avatars.githubusercontent.com/u/8523739?v=3","gravatar_id":"","url":"https://api.github.com/users/debops","html_url":"https://github.com/debops","followers_url":"https://api.github.com/users/debops/followers","following_url":"https://api.github.com/users/debops/following{/other_user}","gists_url":"https://api.github.com/users/debops/gists{/gist_id}","starred_url":"https://api.github.com/users/debops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debops/subscriptions","organizations_url":"https://api.github.com/users/debops/orgs","repos_url":"https://api.github.com/users/debops/repos","events_url":"https://api.github.com/users/debops/events{/privacy}","received_events_url":"https://api.github.com/users/debops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/debops/ansible-tinc","description":"Configure tinc mesh VPN network","fork":false,"url":"https://api.github.com/repos/debops/ansible-tinc","forks_url":"https://api.github.com/repos/debops/ansible-tinc/forks","keys_url":"https://api.github.com/repos/debops/ansible-tinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debops/ansible-tinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debops/ansible-tinc/teams","hooks_url":"https://api.github.com/repos/debops/ansible-tinc/hooks","issue_events_url":"https://api.github.com/repos/debops/ansible-tinc/issues/events{/number}","events_url":"https://api.github.com/repos/debops/ansible-tinc/events","assignees_url":"https://api.github.com/repos/debops/ansible-tinc/assignees{/user}","branches_url":"https://api.github.com/repos/debops/ansible-tinc/branches{/branch}","tags_url":"https://api.github.com/repos/debops/ansible-tinc/tags","blobs_url":"https://api.github.com/repos/debops/ansible-tinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debops/ansible-tinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debops/ansible-tinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/debops/ansible-tinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debops/ansible-tinc/statuses/{sha}","languages_url":"https://api.github.com/repos/debops/ansible-tinc/languages","stargazers_url":"https://api.github.com/repos/debops/ansible-tinc/stargazers","contributors_url":"https://api.github.com/repos/debops/ansible-tinc/contributors","subscribers_url":"https://api.github.com/repos/debops/ansible-tinc/subscribers","subscription_url":"https://api.github.com/repos/debops/ansible-tinc/subscription","commits_url":"https://api.github.com/repos/debops/ansible-tinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/debops/ansible-tinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/debops/ansible-tinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/debops/ansible-tinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/debops/ansible-tinc/contents/{+path}","compare_url":"https://api.github.com/repos/debops/ansible-tinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debops/ansible-tinc/merges","archive_url":"https://api.github.com/repos/debops/ansible-tinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debops/ansible-tinc/downloads","issues_url":"https://api.github.com/repos/debops/ansible-tinc/issues{/number}","pulls_url":"https://api.github.com/repos/debops/ansible-tinc/pulls{/number}","milestones_url":"https://api.github.com/repos/debops/ansible-tinc/milestones{/number}","notifications_url":"https://api.github.com/repos/debops/ansible-tinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debops/ansible-tinc/labels{/name}","releases_url":"https://api.github.com/repos/debops/ansible-tinc/releases{/id}","created_at":"2015-05-20T09:54:45Z","updated_at":"2015-07-20T14:32:19Z","pushed_at":"2015-08-19T08:44:55Z","git_url":"git://github.com/debops/ansible-tinc.git","ssh_url":"git@github.com:debops/ansible-tinc.git","clone_url":"https://github.com/debops/ansible-tinc.git","svn_url":"https://github.com/debops/ansible-tinc","homepage":null,"size":170,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/debops/ansible-tinc/pulls/4"},"html":{"href":"https://github.com/debops/ansible-tinc/pull/4"},"issue":{"href":"https://api.github.com/repos/debops/ansible-tinc/issues/4"},"comments":{"href":"https://api.github.com/repos/debops/ansible-tinc/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/debops/ansible-tinc/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/debops/ansible-tinc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/debops/ansible-tinc/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/debops/ansible-tinc/statuses/c63338dc9a78ed87a13e6b56bb652aea50d697d3"}}}}