{"action":"opened","issue":{"url":"https://api.github.com/repos/WebReflection/ie8/issues/14","labels_url":"https://api.github.com/repos/WebReflection/ie8/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/WebReflection/ie8/issues/14/comments","events_url":"https://api.github.com/repos/WebReflection/ie8/issues/14/events","html_url":"https://github.com/WebReflection/ie8/issues/14","id":55516786,"number":14,"title":"IE9 doesn't like the Comment and Text nodeValue shims","user":{"login":"shawnbot","id":113896,"avatar_url":"https://avatars.githubusercontent.com/u/113896?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnbot","html_url":"https://github.com/shawnbot","followers_url":"https://api.github.com/users/shawnbot/followers","following_url":"https://api.github.com/users/shawnbot/following{/other_user}","gists_url":"https://api.github.com/users/shawnbot/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnbot/subscriptions","organizations_url":"https://api.github.com/users/shawnbot/orgs","repos_url":"https://api.github.com/users/shawnbot/repos","events_url":"https://api.github.com/users/shawnbot/events{/privacy}","received_events_url":"https://api.github.com/users/shawnbot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-01-26T18:12:36Z","updated_at":"2015-01-26T18:12:36Z","closed_at":null,"body":"I'm running [aight v2](https://github.com/shawnbot/aight/pull/38) tests on IE8 and 9 (not pushed yet, but will be soon), and IE9 is failing as a result of the [Text#nodeValue shim](https://github.com/WebReflection/ie8/blob/master/src/ie8.js#L189-L193). I've followed this down into the guts of `ie8.js` and found that the fallback descriptors are undefined in `commonTextContent()` for both the Text#nodeValue and [Comment#nodeValue](https://github.com/WebReflection/ie8/blob/master/src/ie8.js#L177-L181), which causes the shimmed property getter and setter to throw an exception when the accessors are called, e.g. `Unable to get value of the property 'get': object is null or undefined`. My patch just returns early from `commonTextContent()` when the fallback descriptor is undefined, but this doesn't seem like *quite* the right thing to do.\r\n\r\nI know that `ie8.js` is intended for IE8, but I need a lot of those shims in aight for IE9 support as well. In this specific case, though, IE9's native Text#nodeValue implementation works. So, should I fork this repo and make some aight-specific patches for IE9 compatibility, or would you prefer to do some light-weight feature detection that ensures it'll just work in IE9?"}}