{"action":"created","issue":{"url":"https://api.github.com/repos/xetorthio/jedis/issues/946","labels_url":"https://api.github.com/repos/xetorthio/jedis/issues/946/labels{/name}","comments_url":"https://api.github.com/repos/xetorthio/jedis/issues/946/comments","events_url":"https://api.github.com/repos/xetorthio/jedis/issues/946/events","html_url":"https://github.com/xetorthio/jedis/pull/946","id":67884986,"number":946,"title":"Release all resources from disconnect regardless of IOException","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xetorthio/jedis/labels/WAIT%20FOR%20MORE%20REVIEWS","name":"WAIT FOR MORE REVIEWS","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/xetorthio/jedis/milestones/19","html_url":"https://github.com/xetorthio/jedis/milestones/2.7.1","labels_url":"https://api.github.com/repos/xetorthio/jedis/milestones/19/labels","id":1053014,"number":19,"title":"2.7.1","description":"","creator":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2015-04-04T22:05:10Z","updated_at":"2015-04-12T23:24:27Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2015-04-12T08:04:18Z","updated_at":"2015-04-16T11:07:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xetorthio/jedis/pulls/946","html_url":"https://github.com/xetorthio/jedis/pull/946","diff_url":"https://github.com/xetorthio/jedis/pull/946.diff","patch_url":"https://github.com/xetorthio/jedis/pull/946.patch"},"body":"Sorry I'm too late on applying #847. (Thanks @allanwax!)\r\n\r\nWhen IOException occurs on disconnect, it forces to close others with finally statement.\r\nIMO it would be safe to use first IOException on disconnect to report JedisConnectionException.\r\nI'm not 100% sure it's the best way, so any opinions are greatly appreciated.\r\n\r\nPlease review and comment. Thanks!"},"comment":{"url":"https://api.github.com/repos/xetorthio/jedis/issues/comments/93709383","html_url":"https://github.com/xetorthio/jedis/pull/946#issuecomment-93709383","issue_url":"https://api.github.com/repos/xetorthio/jedis/issues/946","id":93709383,"user":{"login":"marcosnils","id":1578458,"avatar_url":"https://avatars.githubusercontent.com/u/1578458?v=3","gravatar_id":"","url":"https://api.github.com/users/marcosnils","html_url":"https://github.com/marcosnils","followers_url":"https://api.github.com/users/marcosnils/followers","following_url":"https://api.github.com/users/marcosnils/following{/other_user}","gists_url":"https://api.github.com/users/marcosnils/gists{/gist_id}","starred_url":"https://api.github.com/users/marcosnils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcosnils/subscriptions","organizations_url":"https://api.github.com/users/marcosnils/orgs","repos_url":"https://api.github.com/users/marcosnils/repos","events_url":"https://api.github.com/users/marcosnils/events{/privacy}","received_events_url":"https://api.github.com/users/marcosnils/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T11:07:17Z","updated_at":"2015-04-16T11:07:17Z","body":"@HeartSaVioR LGTM!. \r\n"}}