{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/59","id":27556467,"html_url":"https://github.com/alexdalitz/dnsruby/pull/59","diff_url":"https://github.com/alexdalitz/dnsruby/pull/59.diff","patch_url":"https://github.com/alexdalitz/dnsruby/pull/59.patch","issue_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/59","number":59,"state":"closed","locked":false,"title":"Fix zone reader adding unwanted dot to relative hostnames being converted to absolute","user":{"login":"tg90nor","id":683563,"avatar_url":"https://avatars.githubusercontent.com/u/683563?v=3","gravatar_id":"","url":"https://api.github.com/users/tg90nor","html_url":"https://github.com/tg90nor","followers_url":"https://api.github.com/users/tg90nor/followers","following_url":"https://api.github.com/users/tg90nor/following{/other_user}","gists_url":"https://api.github.com/users/tg90nor/gists{/gist_id}","starred_url":"https://api.github.com/users/tg90nor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tg90nor/subscriptions","organizations_url":"https://api.github.com/users/tg90nor/orgs","repos_url":"https://api.github.com/users/tg90nor/repos","events_url":"https://api.github.com/users/tg90nor/events{/privacy}","received_events_url":"https://api.github.com/users/tg90nor/received_events","type":"User","site_admin":false},"body":"This fixes a bug where the zone reader would add @origin.to_s + \".\" to relative hostnames in the record data. Since @origin already ends with a dot, the result would be the hostname ending in two dots, which is invalid.\r\nI also uncommented the test case I wrote for it in my last pull request.","created_at":"2015-01-17T12:57:37Z","updated_at":"2015-01-17T13:06:22Z","closed_at":"2015-01-17T13:06:22Z","merged_at":"2015-01-17T13:06:22Z","merge_commit_sha":"5c7311062c51ccce043dc305966e20dc9555a569","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/59/commits","review_comments_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/59/comments","review_comment_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/59/comments","statuses_url":"https://api.github.com/repos/alexdalitz/dnsruby/statuses/d71478c65ef9a912d6b07014f68089f6f299c687","head":{"label":"tg90nor:fix-double-dots-in-relative-cname-import","ref":"fix-double-dots-in-relative-cname-import","sha":"d71478c65ef9a912d6b07014f68089f6f299c687","user":{"login":"tg90nor","id":683563,"avatar_url":"https://avatars.githubusercontent.com/u/683563?v=3","gravatar_id":"","url":"https://api.github.com/users/tg90nor","html_url":"https://github.com/tg90nor","followers_url":"https://api.github.com/users/tg90nor/followers","following_url":"https://api.github.com/users/tg90nor/following{/other_user}","gists_url":"https://api.github.com/users/tg90nor/gists{/gist_id}","starred_url":"https://api.github.com/users/tg90nor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tg90nor/subscriptions","organizations_url":"https://api.github.com/users/tg90nor/orgs","repos_url":"https://api.github.com/users/tg90nor/repos","events_url":"https://api.github.com/users/tg90nor/events{/privacy}","received_events_url":"https://api.github.com/users/tg90nor/received_events","type":"User","site_admin":false},"repo":{"id":28222967,"name":"dnsruby","full_name":"tg90nor/dnsruby","owner":{"login":"tg90nor","id":683563,"avatar_url":"https://avatars.githubusercontent.com/u/683563?v=3","gravatar_id":"","url":"https://api.github.com/users/tg90nor","html_url":"https://github.com/tg90nor","followers_url":"https://api.github.com/users/tg90nor/followers","following_url":"https://api.github.com/users/tg90nor/following{/other_user}","gists_url":"https://api.github.com/users/tg90nor/gists{/gist_id}","starred_url":"https://api.github.com/users/tg90nor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tg90nor/subscriptions","organizations_url":"https://api.github.com/users/tg90nor/orgs","repos_url":"https://api.github.com/users/tg90nor/repos","events_url":"https://api.github.com/users/tg90nor/events{/privacy}","received_events_url":"https://api.github.com/users/tg90nor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tg90nor/dnsruby","description":"Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project","fork":true,"url":"https://api.github.com/repos/tg90nor/dnsruby","forks_url":"https://api.github.com/repos/tg90nor/dnsruby/forks","keys_url":"https://api.github.com/repos/tg90nor/dnsruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tg90nor/dnsruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tg90nor/dnsruby/teams","hooks_url":"https://api.github.com/repos/tg90nor/dnsruby/hooks","issue_events_url":"https://api.github.com/repos/tg90nor/dnsruby/issues/events{/number}","events_url":"https://api.github.com/repos/tg90nor/dnsruby/events","assignees_url":"https://api.github.com/repos/tg90nor/dnsruby/assignees{/user}","branches_url":"https://api.github.com/repos/tg90nor/dnsruby/branches{/branch}","tags_url":"https://api.github.com/repos/tg90nor/dnsruby/tags","blobs_url":"https://api.github.com/repos/tg90nor/dnsruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tg90nor/dnsruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tg90nor/dnsruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/tg90nor/dnsruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tg90nor/dnsruby/statuses/{sha}","languages_url":"https://api.github.com/repos/tg90nor/dnsruby/languages","stargazers_url":"https://api.github.com/repos/tg90nor/dnsruby/stargazers","contributors_url":"https://api.github.com/repos/tg90nor/dnsruby/contributors","subscribers_url":"https://api.github.com/repos/tg90nor/dnsruby/subscribers","subscription_url":"https://api.github.com/repos/tg90nor/dnsruby/subscription","commits_url":"https://api.github.com/repos/tg90nor/dnsruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/tg90nor/dnsruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/tg90nor/dnsruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/tg90nor/dnsruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/tg90nor/dnsruby/contents/{+path}","compare_url":"https://api.github.com/repos/tg90nor/dnsruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tg90nor/dnsruby/merges","archive_url":"https://api.github.com/repos/tg90nor/dnsruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tg90nor/dnsruby/downloads","issues_url":"https://api.github.com/repos/tg90nor/dnsruby/issues{/number}","pulls_url":"https://api.github.com/repos/tg90nor/dnsruby/pulls{/number}","milestones_url":"https://api.github.com/repos/tg90nor/dnsruby/milestones{/number}","notifications_url":"https://api.github.com/repos/tg90nor/dnsruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tg90nor/dnsruby/labels{/name}","releases_url":"https://api.github.com/repos/tg90nor/dnsruby/releases{/id}","created_at":"2014-12-19T09:25:08Z","updated_at":"2014-12-19T09:25:09Z","pushed_at":"2015-01-17T12:53:21Z","git_url":"git://github.com/tg90nor/dnsruby.git","ssh_url":"git@github.com:tg90nor/dnsruby.git","clone_url":"https://github.com/tg90nor/dnsruby.git","svn_url":"https://github.com/tg90nor/dnsruby","homepage":"","size":1368,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexdalitz:master","ref":"master","sha":"af4ff1c22414d3b5cb05c550b02c85caf4d547ed","user":{"login":"alexdalitz","id":7693018,"avatar_url":"https://avatars.githubusercontent.com/u/7693018?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdalitz","html_url":"https://github.com/alexdalitz","followers_url":"https://api.github.com/users/alexdalitz/followers","following_url":"https://api.github.com/users/alexdalitz/following{/other_user}","gists_url":"https://api.github.com/users/alexdalitz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdalitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdalitz/subscriptions","organizations_url":"https://api.github.com/users/alexdalitz/orgs","repos_url":"https://api.github.com/users/alexdalitz/repos","events_url":"https://api.github.com/users/alexdalitz/events{/privacy}","received_events_url":"https://api.github.com/users/alexdalitz/received_events","type":"User","site_admin":false},"repo":{"id":24405039,"name":"dnsruby","full_name":"alexdalitz/dnsruby","owner":{"login":"alexdalitz","id":7693018,"avatar_url":"https://avatars.githubusercontent.com/u/7693018?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdalitz","html_url":"https://github.com/alexdalitz","followers_url":"https://api.github.com/users/alexdalitz/followers","following_url":"https://api.github.com/users/alexdalitz/following{/other_user}","gists_url":"https://api.github.com/users/alexdalitz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdalitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdalitz/subscriptions","organizations_url":"https://api.github.com/users/alexdalitz/orgs","repos_url":"https://api.github.com/users/alexdalitz/repos","events_url":"https://api.github.com/users/alexdalitz/events{/privacy}","received_events_url":"https://api.github.com/users/alexdalitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexdalitz/dnsruby","description":"Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project","fork":false,"url":"https://api.github.com/repos/alexdalitz/dnsruby","forks_url":"https://api.github.com/repos/alexdalitz/dnsruby/forks","keys_url":"https://api.github.com/repos/alexdalitz/dnsruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexdalitz/dnsruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexdalitz/dnsruby/teams","hooks_url":"https://api.github.com/repos/alexdalitz/dnsruby/hooks","issue_events_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/events{/number}","events_url":"https://api.github.com/repos/alexdalitz/dnsruby/events","assignees_url":"https://api.github.com/repos/alexdalitz/dnsruby/assignees{/user}","branches_url":"https://api.github.com/repos/alexdalitz/dnsruby/branches{/branch}","tags_url":"https://api.github.com/repos/alexdalitz/dnsruby/tags","blobs_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexdalitz/dnsruby/statuses/{sha}","languages_url":"https://api.github.com/repos/alexdalitz/dnsruby/languages","stargazers_url":"https://api.github.com/repos/alexdalitz/dnsruby/stargazers","contributors_url":"https://api.github.com/repos/alexdalitz/dnsruby/contributors","subscribers_url":"https://api.github.com/repos/alexdalitz/dnsruby/subscribers","subscription_url":"https://api.github.com/repos/alexdalitz/dnsruby/subscription","commits_url":"https://api.github.com/repos/alexdalitz/dnsruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexdalitz/dnsruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/alexdalitz/dnsruby/contents/{+path}","compare_url":"https://api.github.com/repos/alexdalitz/dnsruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexdalitz/dnsruby/merges","archive_url":"https://api.github.com/repos/alexdalitz/dnsruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexdalitz/dnsruby/downloads","issues_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues{/number}","pulls_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls{/number}","milestones_url":"https://api.github.com/repos/alexdalitz/dnsruby/milestones{/number}","notifications_url":"https://api.github.com/repos/alexdalitz/dnsruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexdalitz/dnsruby/labels{/name}","releases_url":"https://api.github.com/repos/alexdalitz/dnsruby/releases{/id}","created_at":"2014-09-24T07:27:33Z","updated_at":"2015-01-17T08:11:43Z","pushed_at":"2015-01-17T13:06:23Z","git_url":"git://github.com/alexdalitz/dnsruby.git","ssh_url":"git@github.com:alexdalitz/dnsruby.git","clone_url":"https://github.com/alexdalitz/dnsruby.git","svn_url":"https://github.com/alexdalitz/dnsruby","homepage":"","size":1777,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/59"},"html":{"href":"https://github.com/alexdalitz/dnsruby/pull/59"},"issue":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/issues/59"},"comments":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/statuses/d71478c65ef9a912d6b07014f68089f6f299c687"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexdalitz","id":7693018,"avatar_url":"https://avatars.githubusercontent.com/u/7693018?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdalitz","html_url":"https://github.com/alexdalitz","followers_url":"https://api.github.com/users/alexdalitz/followers","following_url":"https://api.github.com/users/alexdalitz/following{/other_user}","gists_url":"https://api.github.com/users/alexdalitz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdalitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdalitz/subscriptions","organizations_url":"https://api.github.com/users/alexdalitz/orgs","repos_url":"https://api.github.com/users/alexdalitz/repos","events_url":"https://api.github.com/users/alexdalitz/events{/privacy}","received_events_url":"https://api.github.com/users/alexdalitz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}