{"comment":{"url":"https://api.github.com/repos/nds5yf/THzCAI/comments/12135858","html_url":"https://github.com/nds5yf/THzCAI/commit/9fd0ae6ec84d13fe43afa6d3531c1282c9c840de#commitcomment-12135858","id":12135858,"user":{"login":"mbe9a","id":12703334,"avatar_url":"https://avatars.githubusercontent.com/u/12703334?v=3","gravatar_id":"","url":"https://api.github.com/users/mbe9a","html_url":"https://github.com/mbe9a","followers_url":"https://api.github.com/users/mbe9a/followers","following_url":"https://api.github.com/users/mbe9a/following{/other_user}","gists_url":"https://api.github.com/users/mbe9a/gists{/gist_id}","starred_url":"https://api.github.com/users/mbe9a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbe9a/subscriptions","organizations_url":"https://api.github.com/users/mbe9a/orgs","repos_url":"https://api.github.com/users/mbe9a/repos","events_url":"https://api.github.com/users/mbe9a/events{/privacy}","received_events_url":"https://api.github.com/users/mbe9a/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"9fd0ae6ec84d13fe43afa6d3531c1282c9c840de","created_at":"2015-07-13T15:18:07Z","updated_at":"2015-07-13T15:18:07Z","body":"I updated ANA to inherit the ZVA40 object- that was a good idea. I think\nthe ESP300 object in skrf.vi.stages is not usable because GpibInstrument is\nused in the constructor.\n\nAre you referring to hard coding the canvas size in the hadamard\nconstructor?\n\nOn Sat, Jul 11, 2015 at 8:15 AM, alex arsenovic <notifications@github.com>\nwrote:\n\n> this is good.\n> suggestions.\n>\n> for the ANA, ESP or other vi's you can inherit the object directly,\n> instead of assigning it to a property. this method scales better, because\n> you can keep inheriting.\n>\n> i wouldnt hard-code anything that depends on image resolution or frequency\n> band. for example the steps between teh calibration standards will change\n> with frequency band. we can define these in terms of electrical length as\n> apposed to physical length, and they will scale automatically. ill do this.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/nds5yf/THzCAI/commit/9fd0ae6ec84d13fe43afa6d3531c1282c9c840de#commitcomment-12118694>\n> .\n>\n\n\n\n-- \nMichael Eller\nUniversity of Virginia, Class of 2017\nComputer Engineering Undergraduate\n"}}