{"action":"created","comment":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments/32116836","id":32116836,"diff_hunk":"@@ -210,17 +199,6 @@ function RSA() {\n       return key;\n     }\n \n-    function convertKeyOperation(keyop, errmsg) {\n-      return new Promise(function(resolve, reject) {\n-        keyop.onerror = function (err) { \n-          reject(new Error(errmsg));\n-        }\n-        keyop.oncomplete = function (e) {\n-          resolve(e.target.result);\n-        }\n-      });\n-    }\n-","path":"src/crypto/public_key/rsa.js","position":81,"original_position":81,"commit_id":"bce42f60d6276871a41add196064da84fca8fd2f","original_commit_id":"bce42f60d6276871a41add196064da84fca8fd2f","user":{"login":"tanx","id":1374174,"avatar_url":"https://avatars.githubusercontent.com/u/1374174?v=3","gravatar_id":"","url":"https://api.github.com/users/tanx","html_url":"https://github.com/tanx","followers_url":"https://api.github.com/users/tanx/followers","following_url":"https://api.github.com/users/tanx/following{/other_user}","gists_url":"https://api.github.com/users/tanx/gists{/gist_id}","starred_url":"https://api.github.com/users/tanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanx/subscriptions","organizations_url":"https://api.github.com/users/tanx/orgs","repos_url":"https://api.github.com/users/tanx/repos","events_url":"https://api.github.com/users/tanx/events{/privacy}","received_events_url":"https://api.github.com/users/tanx/received_events","type":"User","site_admin":false},"body":"Have your rebased on top of the current OpenPGP.js master? ;)","created_at":"2015-06-10T13:31:19Z","updated_at":"2015-06-10T13:31:19Z","html_url":"https://github.com/openpgpjs/openpgpjs/pull/327#discussion_r32116836","pull_request_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments/32116836"},"html":{"href":"https://github.com/openpgpjs/openpgpjs/pull/327#discussion_r32116836"},"pull_request":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327","id":37358202,"html_url":"https://github.com/openpgpjs/openpgpjs/pull/327","diff_url":"https://github.com/openpgpjs/openpgpjs/pull/327.diff","patch_url":"https://github.com/openpgpjs/openpgpjs/pull/327.patch","issue_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/327","number":327,"state":"open","locked":false,"title":"Optimized memory footprint for encrypting and decrypting","user":{"login":"plaincode","id":421410,"avatar_url":"https://avatars.githubusercontent.com/u/421410?v=3","gravatar_id":"","url":"https://api.github.com/users/plaincode","html_url":"https://github.com/plaincode","followers_url":"https://api.github.com/users/plaincode/followers","following_url":"https://api.github.com/users/plaincode/following{/other_user}","gists_url":"https://api.github.com/users/plaincode/gists{/gist_id}","starred_url":"https://api.github.com/users/plaincode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaincode/subscriptions","organizations_url":"https://api.github.com/users/plaincode/orgs","repos_url":"https://api.github.com/users/plaincode/repos","events_url":"https://api.github.com/users/plaincode/events{/privacy}","received_events_url":"https://api.github.com/users/plaincode/received_events","type":"User","site_admin":false},"body":"On webkit based engines use intermediate arrays in favour of string concatenation.\r\n\r\nThis highly improves the memory consumption used on Chrome and Safari.","created_at":"2015-06-10T13:28:15Z","updated_at":"2015-06-10T13:31:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5599846981208e0702941efe965e301ffa0e1e0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327/commits","review_comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327/comments","review_comment_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/327/comments","statuses_url":"https://api.github.com/repos/openpgpjs/openpgpjs/statuses/bce42f60d6276871a41add196064da84fca8fd2f","head":{"label":"1and1:master","ref":"master","sha":"bce42f60d6276871a41add196064da84fca8fd2f","user":{"login":"1and1","id":743115,"avatar_url":"https://avatars.githubusercontent.com/u/743115?v=3","gravatar_id":"","url":"https://api.github.com/users/1and1","html_url":"https://github.com/1and1","followers_url":"https://api.github.com/users/1and1/followers","following_url":"https://api.github.com/users/1and1/following{/other_user}","gists_url":"https://api.github.com/users/1and1/gists{/gist_id}","starred_url":"https://api.github.com/users/1and1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1and1/subscriptions","organizations_url":"https://api.github.com/users/1and1/orgs","repos_url":"https://api.github.com/users/1and1/repos","events_url":"https://api.github.com/users/1and1/events{/privacy}","received_events_url":"https://api.github.com/users/1and1/received_events","type":"Organization","site_admin":false},"repo":{"id":37188268,"name":"openpgpjs","full_name":"1and1/openpgpjs","owner":{"login":"1and1","id":743115,"avatar_url":"https://avatars.githubusercontent.com/u/743115?v=3","gravatar_id":"","url":"https://api.github.com/users/1and1","html_url":"https://github.com/1and1","followers_url":"https://api.github.com/users/1and1/followers","following_url":"https://api.github.com/users/1and1/following{/other_user}","gists_url":"https://api.github.com/users/1and1/gists{/gist_id}","starred_url":"https://api.github.com/users/1and1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1and1/subscriptions","organizations_url":"https://api.github.com/users/1and1/orgs","repos_url":"https://api.github.com/users/1and1/repos","events_url":"https://api.github.com/users/1and1/events{/privacy}","received_events_url":"https://api.github.com/users/1and1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/1and1/openpgpjs","description":"OpenPGP implementation for JavaScript","fork":true,"url":"https://api.github.com/repos/1and1/openpgpjs","forks_url":"https://api.github.com/repos/1and1/openpgpjs/forks","keys_url":"https://api.github.com/repos/1and1/openpgpjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1and1/openpgpjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1and1/openpgpjs/teams","hooks_url":"https://api.github.com/repos/1and1/openpgpjs/hooks","issue_events_url":"https://api.github.com/repos/1and1/openpgpjs/issues/events{/number}","events_url":"https://api.github.com/repos/1and1/openpgpjs/events","assignees_url":"https://api.github.com/repos/1and1/openpgpjs/assignees{/user}","branches_url":"https://api.github.com/repos/1and1/openpgpjs/branches{/branch}","tags_url":"https://api.github.com/repos/1and1/openpgpjs/tags","blobs_url":"https://api.github.com/repos/1and1/openpgpjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1and1/openpgpjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1and1/openpgpjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/1and1/openpgpjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1and1/openpgpjs/statuses/{sha}","languages_url":"https://api.github.com/repos/1and1/openpgpjs/languages","stargazers_url":"https://api.github.com/repos/1and1/openpgpjs/stargazers","contributors_url":"https://api.github.com/repos/1and1/openpgpjs/contributors","subscribers_url":"https://api.github.com/repos/1and1/openpgpjs/subscribers","subscription_url":"https://api.github.com/repos/1and1/openpgpjs/subscription","commits_url":"https://api.github.com/repos/1and1/openpgpjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/1and1/openpgpjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/1and1/openpgpjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/1and1/openpgpjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/1and1/openpgpjs/contents/{+path}","compare_url":"https://api.github.com/repos/1and1/openpgpjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1and1/openpgpjs/merges","archive_url":"https://api.github.com/repos/1and1/openpgpjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1and1/openpgpjs/downloads","issues_url":"https://api.github.com/repos/1and1/openpgpjs/issues{/number}","pulls_url":"https://api.github.com/repos/1and1/openpgpjs/pulls{/number}","milestones_url":"https://api.github.com/repos/1and1/openpgpjs/milestones{/number}","notifications_url":"https://api.github.com/repos/1and1/openpgpjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1and1/openpgpjs/labels{/name}","releases_url":"https://api.github.com/repos/1and1/openpgpjs/releases{/id}","created_at":"2015-06-10T09:36:45Z","updated_at":"2015-06-10T09:36:46Z","pushed_at":"2015-06-10T13:27:55Z","git_url":"git://github.com/1and1/openpgpjs.git","ssh_url":"git@github.com:1and1/openpgpjs.git","clone_url":"https://github.com/1and1/openpgpjs.git","svn_url":"https://github.com/1and1/openpgpjs","homepage":"http://openpgpjs.org","size":21380,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openpgpjs:master","ref":"master","sha":"ac8d991bc3195371608ece9d68ca08c613bb8aae","user":{"login":"openpgpjs","id":1206249,"avatar_url":"https://avatars.githubusercontent.com/u/1206249?v=3","gravatar_id":"","url":"https://api.github.com/users/openpgpjs","html_url":"https://github.com/openpgpjs","followers_url":"https://api.github.com/users/openpgpjs/followers","following_url":"https://api.github.com/users/openpgpjs/following{/other_user}","gists_url":"https://api.github.com/users/openpgpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/openpgpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpgpjs/subscriptions","organizations_url":"https://api.github.com/users/openpgpjs/orgs","repos_url":"https://api.github.com/users/openpgpjs/repos","events_url":"https://api.github.com/users/openpgpjs/events{/privacy}","received_events_url":"https://api.github.com/users/openpgpjs/received_events","type":"Organization","site_admin":false},"repo":{"id":2765899,"name":"openpgpjs","full_name":"openpgpjs/openpgpjs","owner":{"login":"openpgpjs","id":1206249,"avatar_url":"https://avatars.githubusercontent.com/u/1206249?v=3","gravatar_id":"","url":"https://api.github.com/users/openpgpjs","html_url":"https://github.com/openpgpjs","followers_url":"https://api.github.com/users/openpgpjs/followers","following_url":"https://api.github.com/users/openpgpjs/following{/other_user}","gists_url":"https://api.github.com/users/openpgpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/openpgpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpgpjs/subscriptions","organizations_url":"https://api.github.com/users/openpgpjs/orgs","repos_url":"https://api.github.com/users/openpgpjs/repos","events_url":"https://api.github.com/users/openpgpjs/events{/privacy}","received_events_url":"https://api.github.com/users/openpgpjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openpgpjs/openpgpjs","description":"OpenPGP implementation for JavaScript","fork":false,"url":"https://api.github.com/repos/openpgpjs/openpgpjs","forks_url":"https://api.github.com/repos/openpgpjs/openpgpjs/forks","keys_url":"https://api.github.com/repos/openpgpjs/openpgpjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openpgpjs/openpgpjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openpgpjs/openpgpjs/teams","hooks_url":"https://api.github.com/repos/openpgpjs/openpgpjs/hooks","issue_events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/events{/number}","events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/events","assignees_url":"https://api.github.com/repos/openpgpjs/openpgpjs/assignees{/user}","branches_url":"https://api.github.com/repos/openpgpjs/openpgpjs/branches{/branch}","tags_url":"https://api.github.com/repos/openpgpjs/openpgpjs/tags","blobs_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openpgpjs/openpgpjs/statuses/{sha}","languages_url":"https://api.github.com/repos/openpgpjs/openpgpjs/languages","stargazers_url":"https://api.github.com/repos/openpgpjs/openpgpjs/stargazers","contributors_url":"https://api.github.com/repos/openpgpjs/openpgpjs/contributors","subscribers_url":"https://api.github.com/repos/openpgpjs/openpgpjs/subscribers","subscription_url":"https://api.github.com/repos/openpgpjs/openpgpjs/subscription","commits_url":"https://api.github.com/repos/openpgpjs/openpgpjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openpgpjs/openpgpjs/contents/{+path}","compare_url":"https://api.github.com/repos/openpgpjs/openpgpjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openpgpjs/openpgpjs/merges","archive_url":"https://api.github.com/repos/openpgpjs/openpgpjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openpgpjs/openpgpjs/downloads","issues_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues{/number}","pulls_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls{/number}","milestones_url":"https://api.github.com/repos/openpgpjs/openpgpjs/milestones{/number}","notifications_url":"https://api.github.com/repos/openpgpjs/openpgpjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openpgpjs/openpgpjs/labels{/name}","releases_url":"https://api.github.com/repos/openpgpjs/openpgpjs/releases{/id}","created_at":"2011-11-13T10:36:43Z","updated_at":"2015-06-10T00:49:18Z","pushed_at":"2015-06-10T13:28:15Z","git_url":"git://github.com/openpgpjs/openpgpjs.git","ssh_url":"git@github.com:openpgpjs/openpgpjs.git","clone_url":"https://github.com/openpgpjs/openpgpjs.git","svn_url":"https://github.com/openpgpjs/openpgpjs","homepage":"http://openpgpjs.org","size":21380,"stargazers_count":1446,"watchers_count":1446,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":187,"mirror_url":null,"open_issues_count":74,"forks":187,"open_issues":74,"watchers":1446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327"},"html":{"href":"https://github.com/openpgpjs/openpgpjs/pull/327"},"issue":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/327"},"comments":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/statuses/bce42f60d6276871a41add196064da84fca8fd2f"}}}}