{"action":"created","issue":{"url":"https://api.github.com/repos/cargomedia/cm-janus/issues/18","labels_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/18/comments","events_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/18/events","html_url":"https://github.com/cargomedia/cm-janus/pull/18","id":115102173,"number":18,"title":"Feedback of unexpected/error cases.","user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cargomedia/cm-janus/labels/selfmade","name":"selfmade","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-11-04T17:17:06Z","updated_at":"2015-11-05T18:50:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/18","html_url":"https://github.com/cargomedia/cm-janus/pull/18","diff_url":"https://github.com/cargomedia/cm-janus/pull/18.diff","patch_url":"https://github.com/cargomedia/cm-janus/pull/18.patch"},"body":"For example.\r\n-------------------------------------------------\r\n```json\r\n{\r\n  \"janus\" : \"error\",\r\n    \"transaction\" : \"--------\"\r\n    \"error\" : {\r\n      \"code\" : 405\r\n      \"reason\" : \"Illegal plugin to access\"\r\n    }\r\n}\r\n```\r\n- ProxyConnection.onAttach:\r\n\r\n  ```js\r\n  if (!this.isAllowedPlugin(message.plugin)) {\r\n    return Promise.reject('Disallowed plugin ' + message.plugin);\r\n  }\r\n  ```\r\n- ProxyConnection.pluginFactory:\r\n\r\n  ```js\r\n    if (!pluginClass) {\r\n      throw new Error('Invalid plugin');\r\n    }\r\n  ```\r\n\r\n----------------------------------------------------------------------------------\r\n```json\r\n{\r\n  \"janus\" : \"error\",\r\n    \"transaction\" : \"--------\"\r\n    \"error\" : {\r\n      \"code\" : 403\r\n      \"reason\" : \"Unauthorized request\"\r\n    }\r\n}\r\n```\r\n\r\n- BrowserConnection._onMessage:\r\n\r\n  ```js\r\n  auth.authorizeConnection(this, token)\r\n  ```\r\n- BrowserConnection._send:\r\n\r\n  ```js\r\n  auth.isValidConnection(this)\r\n  ```\r\n\r\n- PluginStreaming.onCreate:\r\n\r\n  ```js\r\n  auth.canPublish\r\n  ```\r\n\r\n- PluginStreaming.onWatch:\r\n\r\n  ```js\r\n  auth.canSubscribe\r\n  ```\r\n\r\n--------------------------------------------------------------\r\n\r\n- ProxyConnection.onCreate. Just remove the error case.\r\n- ProxyConnection.onDestroy. Remove it. Clear sessionId in hangup."},"comment":{"url":"https://api.github.com/repos/cargomedia/cm-janus/issues/comments/154150735","html_url":"https://github.com/cargomedia/cm-janus/pull/18#issuecomment-154150735","issue_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/18","id":154150735,"user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T18:50:06Z","updated_at":"2015-11-05T18:50:06Z","body":"paired with @tomaszdurka "}}