{"action":"created","issue":{"url":"https://api.github.com/repos/Qucs/qucs/issues/369","labels_url":"https://api.github.com/repos/Qucs/qucs/issues/369/labels{/name}","comments_url":"https://api.github.com/repos/Qucs/qucs/issues/369/comments","events_url":"https://api.github.com/repos/Qucs/qucs/issues/369/events","html_url":"https://github.com/Qucs/qucs/pull/369","id":107261881,"number":369,"title":"Re-add .moc.cpp to SUFFIXES to correct dependency","user":{"login":"in3otd","id":9018179,"avatar_url":"https://avatars.githubusercontent.com/u/9018179?v=3","gravatar_id":"","url":"https://api.github.com/users/in3otd","html_url":"https://github.com/in3otd","followers_url":"https://api.github.com/users/in3otd/followers","following_url":"https://api.github.com/users/in3otd/following{/other_user}","gists_url":"https://api.github.com/users/in3otd/gists{/gist_id}","starred_url":"https://api.github.com/users/in3otd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in3otd/subscriptions","organizations_url":"https://api.github.com/users/in3otd/orgs","repos_url":"https://api.github.com/users/in3otd/repos","events_url":"https://api.github.com/users/in3otd/events{/privacy}","received_events_url":"https://api.github.com/users/in3otd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-18T19:20:20Z","updated_at":"2015-09-18T19:41:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Qucs/qucs/pulls/369","html_url":"https://github.com/Qucs/qucs/pull/369","diff_url":"https://github.com/Qucs/qucs/pull/369.diff","patch_url":"https://github.com/Qucs/qucs/pull/369.patch"},"body":"While moving back and forth between branches and recompiling, I got some strange errors on `qucs.moc.cpp`. Digging a little bit, I saw that `make` did not recognize that `qucs.h` changed and so did not regenerate the corresponding `qucs.moc.cpp`.\r\nApparently this is due to the fact that the line\r\n```\r\nSUFFIXES = .moc.cpp\r\n```\r\nwas erroneously removed from `qucs/Makefile.am` in commit cb288ebc8f7c35586ca9ed72685e61fe711d6af5 so that the dependency\r\non the `.h` file was not honored.\r\n\r\nNot sure why the rule worked when `qucs.moc.cpp` was not present but not when `qucs.h` was modified...\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Qucs/qucs/issues/comments/141548707","html_url":"https://github.com/Qucs/qucs/pull/369#issuecomment-141548707","issue_url":"https://api.github.com/repos/Qucs/qucs/issues/369","id":141548707,"user":{"login":"felix-salfelder","id":1772519,"avatar_url":"https://avatars.githubusercontent.com/u/1772519?v=3","gravatar_id":"","url":"https://api.github.com/users/felix-salfelder","html_url":"https://github.com/felix-salfelder","followers_url":"https://api.github.com/users/felix-salfelder/followers","following_url":"https://api.github.com/users/felix-salfelder/following{/other_user}","gists_url":"https://api.github.com/users/felix-salfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/felix-salfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix-salfelder/subscriptions","organizations_url":"https://api.github.com/users/felix-salfelder/orgs","repos_url":"https://api.github.com/users/felix-salfelder/repos","events_url":"https://api.github.com/users/felix-salfelder/events{/privacy}","received_events_url":"https://api.github.com/users/felix-salfelder/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T19:41:05Z","updated_at":"2015-09-18T19:41:05Z","body":"d'uh. guess what d7598a10e4ad0c is about. it took me half a day to figure out what's actually wrong.\r\napparently, removing the suffixes causes even more trouble.\r\n\r\n':D'"}}