{"push_id":544278700,"size":67,"distinct_size":67,"ref":"refs/heads/master","head":"589af4a412b7d57e206a28b7d335ab6cb0029df7","before":"d33a745d5b7a2663380d375430eeb17bd56963f5","commits":[{"sha":"f77ee0a402a355de0f1c7e0f517d6776e4fdf47b","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Tweak object header UI\n\nSummary: Increase font size and contrast of all Object Headers.\n\nTest Plan:\nSample a few, find it easier to read. I've been using this locally for a while.\n\n{F261868}\n\n{F261869}\n\nReviewers: epriestley, btrahan\n\nReviewed By: btrahan\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D11221","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/f77ee0a402a355de0f1c7e0f517d6776e4fdf47b"},{"sha":"384b670709aaab1e926372c29f5dc882ab433873","author":{"email":"3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","name":"Bob Trahan"},"message":"Fix string truncation calls all over the codebase.\n\nSummary: Fixes T6608, though I'll also clean up the comment for PhutilStringTruncator in another diff. If I understand correctly, before T1191, MySQL column length was by character count and post T1191 its by byte count. Ergo, most of these changes are going from codepoint -> bytes. See test plan for complete list of what was and was not done.\n\nTest Plan:\nThought very carefully about each callsite and made changes as appropos. \"Display\" means the string is clearly used for display-only purposes and correctly uses \"glyph\" already.\n\ngrep -rn PhutilUTF8StringTruncator *\n\napplications/calendar/query/PhabricatorCalendarEventSearchEngine.php:217:        ->addAttribute(id(new PhutilUTF8StringTruncator())  -- display\napplications/chatlog/controller/PhabricatorChatLogChannelLogController.php:111:      $author = id(new PhutilUTF8StringTruncator())  -- display\napplications/conduit/method/ConduitConnectConduitAPIMethod.php:62:    $client_description = id(new PhutilUTF8StringTruncator()) -- was codepoint, changed to bytes\napplications/conpherence/view/ConpherenceFileWidgetView.php:22:        ->setFileName(id(new PhutilUTF8StringTruncator()) -- display\napplications/differential/controller/DifferentialDiffViewController.php:65:            id(new PhutilUTF8StringTruncator()) -- display\napplications/differential/event/DifferentialHovercardEventListener.php:69:        id(new PhutilUTF8StringTruncator()) -- display\napplications/differential/parser/DifferentialCommitMessageParser.php:144:      $short = id(new PhutilUTF8StringTruncator()) -- was glyphs, made to bytes\napplications/differential/view/DifferentialLocalCommitsView.php:80:      $summary = id(new PhutilUTF8StringTruncator()) -- display\napplications/diffusion/controller/DiffusionBrowseFileController.php:686:            id(new PhutilUTF8StringTruncator()) -- display\napplications/feed/story/PhabricatorFeedStory.php:392:      $text = id(new PhutilUTF8StringTruncator()) -- display, unless people are saving the results of renderSummary() somewhere...\napplications/harbormaster/storage/build/HarbormasterBuild.php:216:    $log_source = id(new PhutilUTF8StringTruncator()) -- was codepoints now bytes\napplications/herald/storage/transcript/HeraldObjectTranscript.php:55:        // NOTE: PhutilUTF8StringTruncator has huge runtime for giant strings. -- not applicable\napplications/maniphest/export/ManiphestExcelDefaultFormat.php:107:        id(new PhutilUTF8StringTruncator()) -- bytes\napplications/metamta/storage/PhabricatorMetaMTAMail.php:587:        $body = id(new PhutilUTF8StringTruncator()) -- bytes\napplications/people/event/PhabricatorPeopleHovercardEventListener.php:62:        id(new PhutilUTF8StringTruncator()) -- display\napplications/phame/conduit/PhameCreatePostConduitAPIMethod.php:93:      id(new PhutilUTF8StringTruncator()) -- was codepoints, now bytes\napplications/pholio/storage/PholioTransaction.php:300:        id(new PhutilUTF8StringTruncator()) -- display\napplications/phortune/provider/PhortuneBalancedPaymentProvider.php:147:    $charge_as = id(new PhutilUTF8StringTruncator()) -- bytes\napplications/ponder/storage/PonderAnswerTransaction.php:86:          id(new PhutilUTF8StringTruncator()) -- display\napplications/ponder/storage/PonderQuestionTransaction.php:267:            id(new PhutilUTF8StringTruncator()) -- display\napplications/ponder/storage/PonderQuestionTransaction.php:276:            id(new PhutilUTF8StringTruncator()) -- display\napplications/repository/storage/PhabricatorRepositoryCommitData.php:43:    $summary = id(new PhutilUTF8StringTruncator()) -- was codepoints, now bytes\napplications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php:20:    $data->setAuthorName(id(new PhutilUTF8StringTruncator()) -- was codepoints, now bytes\napplications/slowvote/query/PhabricatorSlowvoteSearchEngine.php:158:        $item->addAttribute(id(new PhutilUTF8StringTruncator()) -- display\ninfrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php:317:    $host = id(new PhutilUTF8StringTruncator()) -- bytes\nview/form/control/AphrontFormPolicyControl.php:61:      $policy_short_name = id(new PhutilUTF8StringTruncator()) -- glyphs, probably display only\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6608\n\nDifferential Revision: https://secure.phabricator.com/D11219","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/384b670709aaab1e926372c29f5dc882ab433873"},{"sha":"311747bd5e58de1053c7a3aced97785e4b64f3ac","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Change CLOSED colors to Indigo over Black\n\nSummary: CLosed is a pretty important state and black tends to blend in a bit. This bumps to an alternate color to improve ability to scan and know state of objects.\n\nTest Plan:\nReview a number of closed objects. I will follow up with another diff on 'Archived' colors.\n\n{F261895}\n\nReviewers: btrahan, epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D11222","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/311747bd5e58de1053c7a3aced97785e4b64f3ac"},{"sha":"dd42020ef3bc16c30f0a605441386bd357425750","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Use `PhabricatorAuditEditor` to write revert edges\n\nSummary: Use `PhabricatorAuditEditor` instead of `PhabricatorEdgeEditor` when writing reverts edges. This ensures that a transaction is created in addition to the edge.\n\nTest Plan: Reverted a commit and pushed to remote. Saw a row created in `phabricator_audit.audit_transaction_comment`. Interestingly, I can't actually see the transaction at http://phabricator.local/r${CALLSIGN}${REVERTED_COMMIT_HASH}.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D11212","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/dd42020ef3bc16c30f0a605441386bd357425750"},{"sha":"ad1da6ec5ed325a742a9f01f91f221f0052a79a2","author":{"email":"3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","name":"Bob Trahan"},"message":"Projects - display \"members\" link in disabled style if user can't edit project\n\nSummary: Fixes T6862.\n\nTest Plan: viewed a project list and saw disabled-style \"Members\" links as appropos\n\nReviewers: epriestley, chad\n\nReviewed By: chad\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6862\n\nDifferential Revision: https://secure.phabricator.com/D11229","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/ad1da6ec5ed325a742a9f01f91f221f0052a79a2"},{"sha":"204ae221d2705be36a30e93cd2426516929f0c48","author":{"email":"2544c3322fa46d7c21c4e7b362b2d75d60b17add@gmail.com","name":"lkassianik"},"message":"Fixes T6637, \"closing by commit\" should update task status and specify responsible commit, but drop the artificial comment.\n\nSummary: When updating the status of a task via commit, transaction should show responsible commit and status update if it was changed.\n\nTest Plan: Push a commit \"Fixes Txx\", transaction should include status update and commit number.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6637\n\nDifferential Revision: https://secure.phabricator.com/D11230","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/204ae221d2705be36a30e93cd2426516929f0c48"},{"sha":"87c1d004be0236ad989800ffb184caa37152a6e0","author":{"email":"2544c3322fa46d7c21c4e7b362b2d75d60b17add@gmail.com","name":"lkassianik"},"message":"T6597, Uninstalled applications are still linked on Application launcher\n\nSummary: Fixes T6597, Uninstalled applications should not be clickable when searching \"All Applications\" in the Applications launcher\n\nTest Plan: Navigate too /applications/query/all, uninstall an application, navigate back to all applications. Uninstalled application title should not be clickable.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6597\n\nDifferential Revision: https://secure.phabricator.com/D11223","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/87c1d004be0236ad989800ffb184caa37152a6e0"},{"sha":"7c124d78542f50b061b34ad196b341b424c976c0","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Rename `PhutilRealnameContextFreeGrammar` for consistency\n\nSummary: Ref T5655. Depends on D11226.\n\nTest Plan: See D11226.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T5655\n\nDifferential Revision: https://secure.phabricator.com/D11227","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/7c124d78542f50b061b34ad196b341b424c976c0"},{"sha":"f2e87aad89e9d464038cc5095acb5e5dbdb32e4d","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Rename the `PhabricatorAuthFactorTOTP` class for consistency\n\nSummary: Ref T5655.\n\nTest Plan: `grep`\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T5655\n\nDifferential Revision: https://secure.phabricator.com/D11191","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/f2e87aad89e9d464038cc5095acb5e5dbdb32e4d"},{"sha":"d4f992d2ed09349755757d02bc887f80b464ad9b","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Continue after rejecting commits from a commit query\n\nSummary: Fixes T6880. If matching commits have no visible/loadable repository, we shouldn't keep going forward in the loop.\n\nTest Plan: Havne't built a repro locally yet so not 100% sure this fixes it.\n\nReviewers: btrahan, mbishopim3, fabe\n\nReviewed By: mbishopim3, fabe\n\nSubscribers: mbishopim3, epriestley\n\nManiphest Tasks: T6880\n\nDifferential Revision: https://secure.phabricator.com/D11251","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/d4f992d2ed09349755757d02bc887f80b464ad9b"},{"sha":"a455e50e299878fa0765c9395730adfc80cf8ff9","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Build a Conpherence thread index\n\nSummary:\nRef T3165. Builds a dedicated index for Conpherence to avoid scale/policy filtering concerns.\n\n  - This is pretty one-off but I think it's generally OK.\n  - There's no UI for it.\n  - `ConpherenceFulltextQuery` is very low-level. You would need to do another query on the PHIDs it returns to actually show anything to the user.\n  - The `previousTransactionPHID` is so you can load chat context efficiently. Specifically, if you want to show results like this:\n\n> previous line of context\n> **line of chat that matches the query**\n> next line of context\n\n...you can read the previous lines out of `previousTransactionPHID` directly, and the next lines by issuing one query with `WHERE previousTransactionPHID IN (...)`.\n\nI'm not 100% sure this is useful, but it seemed like a reasonable thing to provide, since there's no way to query this efficiently otherwise and I figure a lot of chat might make way more sense with a couple of lines of context.\n\nTest Plan:\n  - Indexed a thread manually (whole thing indexed).\n  - Indexed a thread by updating it (just the new comment indexed).\n  - Wrote a hacky test script and got reasonable-looking query results.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nManiphest Tasks: T3165\n\nDifferential Revision: https://secure.phabricator.com/D11234","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/a455e50e299878fa0765c9395730adfc80cf8ff9"},{"sha":"b2e71bcb70714bd20c22a5c34b1719ac52504b13","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Don't say \"K&R style\" in coding conventions\n\nSummary: We technically don't use K&R. These documents and the rest of the codebase are full of examples of the correct style, which should be unambiguous to a reasonable reader.\n\nTest Plan: reading\n\nReviewers: staticshock, btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nDifferential Revision: https://secure.phabricator.com/D11255","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/b2e71bcb70714bd20c22a5c34b1719ac52504b13"},{"sha":"3e421c74503c18c5fc54f646b21a287e60743548","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Normalize 'Archived' states in object headers\n\nSummary: Quick pass at cleaning up language, icons, colors for 'Archive' and 'Activate' on various objects.\n\nTest Plan:\nTested archiving and activating each object changed.\n\n{F262694}\n\n{F262697}\n\nReviewers: btrahan, epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D11256","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/3e421c74503c18c5fc54f646b21a287e60743548"},{"sha":"648fa2e1bcc68011c7ad53bba185ed58c4b0f67f","author":{"email":"3abdeb20bbfaf7f3efaf2a217619f0ce681d08bb@phacility.com","name":"Bob Trahan"},"message":"Repositories - Move scripts/repository/reparse.php to bin/repository reparse\n\nSummary:\nFixes T5966. Accomplishes a few things\n\n - see title\n - adds a force-autoclose flag and the plumbing for it\n - removes references to some HarborMaster thing that used to key off commits and seems long dead, but forgotten :/\n\nTest Plan:\nran a few commands. These first three had great success:\n\n`./repository reparse --all FIRSTREPO --message --change  --herald --owners`\n`./repository reparse --all FIRSTREPO --message --change  --herald --owners --min-date yesterday`\n`./repository reparse --all FIRSTREPO --message --change  --herald --owners --min-date yesterday --force-autoclose`\n\n...and these next two showed me some errors as expected:\n\n`./repository reparse --all FIRSTREPO --message --change  --herald --owners --min-date garbagedata`\n`./repository reparse --all GARBAGEREPO --message --change  --herald --owners`\n\nAlso, made a diff in a repository with autoclose disabled and commited the diff. Later, reparse the diff with force-autoclose. Verified the diff closed and that the reason \"why\" had the proper message text.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: joshuaspence, epriestley, Korvin\n\nManiphest Tasks: T5966\n\nDifferential Revision: https://secure.phabricator.com/D10492","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/648fa2e1bcc68011c7ad53bba185ed58c4b0f67f"},{"sha":"9c568802bb7759df0177031e1b3ba9be5d20eb82","author":{"email":"2544c3322fa46d7c21c4e7b362b2d75d60b17add@gmail.com","name":"lkassianik"},"message":"T6555, When creating a task with a non existing parent parameter, phabricator should 404\n\nSummary: Fixes T6555, The following should 404: /maniphest/task/create/?parent=asdf, /maniphest/task/create/?parent=0, /maniphest/task/create/?parent=999999 (where T999999 does not exist)\n\nTest Plan: Navigate to /maniphest/task/create/?parent=asdf or /maniphest/task/create/?parent=0 or /maniphest/task/create/?parent=999999 (where T999999 does not exist). See 404.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6555\n\nDifferential Revision: https://secure.phabricator.com/D11258","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/9c568802bb7759df0177031e1b3ba9be5d20eb82"},{"sha":"7756484a000c18860bf18a3e6cc578db7f3da66a","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix method visibility for `AphrontFormControl` methods\n\nSummary: Ref T6822.\n\nTest Plan: Visual inspection. These methods are only called from within the `AphrontFormControl` class.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6822\n\nDifferential Revision: https://secure.phabricator.com/D11249","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/7756484a000c18860bf18a3e6cc578db7f3da66a"},{"sha":"44093da93c9acd3508a76632e77baf98f368c736","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix method visibility for `PhabricatorRepositoryCommitParserWorker` subclasses\n\nSummary: Ref T6822.\n\nTest Plan: Visual inspection. This method is only called from within the `PhabricatorRepositoryCommitParserWorker` class.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6822\n\nDifferential Revision: https://secure.phabricator.com/D11248","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/44093da93c9acd3508a76632e77baf98f368c736"},{"sha":"2c855a89934898913d7dcdd15ac9629e1b0ec0b8","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix method visibility for `PhabricatorConfigStorageSchema` methods\n\nSummary: Ref T6822.\n\nTest Plan: Visual inspection. These methods are only called from within the `PhabricatorConfigStorageSchema` class.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6822\n\nDifferential Revision: https://secure.phabricator.com/D11247","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/2c855a89934898913d7dcdd15ac9629e1b0ec0b8"},{"sha":"81972b61d7527353e30e4c3d9fe6a434877522d7","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix method visibility for `PhabricatorBitbucketAuthProvider::getProviderConfigurationHelp()`\n\nSummary: Ref T6822.\n\nTest Plan: Visual inspection. This method is only called from within `PhabricatorOAuthAuthProvider` subclasses.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6822\n\nDifferential Revision: https://secure.phabricator.com/D11246","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/81972b61d7527353e30e4c3d9fe6a434877522d7"},{"sha":"ade6f82dd578e8ebecd236402c37efaa3875fcee","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix method visibility for `LiskFixtureTestCase::getPhabricatorTestCaseConfiguration()`\n\nSummary: Ref T6822.\n\nTest Plan: Visual inspection. This method is only called from within the `PhabricatorTestCase` class.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T6822\n\nDifferential Revision: https://secure.phabricator.com/D11245","distinct":true,"url":"https://api.github.com/repos/aik099/phabricator/commits/ade6f82dd578e8ebecd236402c37efaa3875fcee"}]}