{"action":"created","issue":{"url":"https://api.github.com/repos/rackt/redux/issues/839","labels_url":"https://api.github.com/repos/rackt/redux/issues/839/labels{/name}","comments_url":"https://api.github.com/repos/rackt/redux/issues/839/comments","events_url":"https://api.github.com/repos/rackt/redux/issues/839/events","html_url":"https://github.com/rackt/redux/issues/839","id":109617534,"number":839,"title":"Emphasize defining selectors alongside reducers in examples","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rackt/redux/labels/examples","name":"examples","color":"006b75"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-03T11:11:34Z","updated_at":"2015-11-07T15:09:23Z","closed_at":"2015-11-07T15:09:23Z","body":"We should use selectors in our examples like we do here: https://github.com/voronianski/flux-comparison/pull/64.\r\n\r\nOtherwise people are having a hard time how to change the state shape safely because they have to update their `mapStateToProps` all over the project."},"comment":{"url":"https://api.github.com/repos/rackt/redux/issues/comments/154713108","html_url":"https://github.com/rackt/redux/issues/839#issuecomment-154713108","issue_url":"https://api.github.com/repos/rackt/redux/issues/839","id":154713108,"user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"created_at":"2015-11-07T15:09:23Z","updated_at":"2015-11-07T15:09:23Z","body":"Not necessarily. I mostly mean the idea of exporting selector functions from reducer. They don't have to be powered by reselect (although it's a nice optimization).\r\n\r\nIn fact we already moved shopping cart example from Flux comparison into Redux repo, so this issue can be closed, as it adequately demonstrates the technique."}}