{"action":"created","comment":{"url":"https://api.github.com/repos/RubyMoney/money/pulls/comments/22862669","id":22862669,"diff_hunk":"@@ -28,6 +30,7 @@ class UndefinedSmallestDenomination < StandardError; end\n   def cents\n     fractional\n   end\n+  alias_method :pence, :cents","path":"lib/money/money.rb","position":null,"original_position":20,"commit_id":"11f838af4213962fb6e401a038c497bc0d04941a","original_commit_id":"ba1cca03b20dc49e38378ff60ca99116b488f23b","user":{"login":"georgemillo","id":2656485,"avatar_url":"https://avatars.githubusercontent.com/u/2656485?v=3","gravatar_id":"","url":"https://api.github.com/users/georgemillo","html_url":"https://github.com/georgemillo","followers_url":"https://api.github.com/users/georgemillo/followers","following_url":"https://api.github.com/users/georgemillo/following{/other_user}","gists_url":"https://api.github.com/users/georgemillo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgemillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgemillo/subscriptions","organizations_url":"https://api.github.com/users/georgemillo/orgs","repos_url":"https://api.github.com/users/georgemillo/repos","events_url":"https://api.github.com/users/georgemillo/events{/privacy}","received_events_url":"https://api.github.com/users/georgemillo/received_events","type":"User","site_admin":false},"body":"Okay, I've removed it and rebased.\r\n\r\nWhy remove cents though? It seems useful to me as (I imagine) that the Money gem will be used with USD (and CAD, AUD, NZD, several other currencies which use 'cents') very frequently and this could make code more readable.\r\n\r\nThat being said, I think the name 'cents' is kinda ambiguous. If you told me to give you the \"cents\" from \"$12.34\", I wouldn't be sure if you meant \"1234 cents\" or \"34 cents\" (i.e. just the part after the decimal point.) A more clear name might be `in_cents`.","created_at":"2015-01-13T13:58:15Z","updated_at":"2015-01-13T13:58:15Z","html_url":"https://github.com/RubyMoney/money/pull/477#discussion_r22862669","pull_request_url":"https://api.github.com/repos/RubyMoney/money/pulls/477","_links":{"self":{"href":"https://api.github.com/repos/RubyMoney/money/pulls/comments/22862669"},"html":{"href":"https://github.com/RubyMoney/money/pull/477#discussion_r22862669"},"pull_request":{"href":"https://api.github.com/repos/RubyMoney/money/pulls/477"}}},"pull_request":{"url":"https://api.github.com/repos/RubyMoney/money/pulls/477","id":27265087,"html_url":"https://github.com/RubyMoney/money/pull/477","diff_url":"https://github.com/RubyMoney/money/pull/477.diff","patch_url":"https://github.com/RubyMoney/money/pull/477.patch","issue_url":"https://api.github.com/repos/RubyMoney/money/issues/477","number":477,"state":"open","locked":false,"title":"Extracting 'constructor' functions to a module, adding aliases and GBP","user":{"login":"georgemillo","id":2656485,"avatar_url":"https://avatars.githubusercontent.com/u/2656485?v=3","gravatar_id":"","url":"https://api.github.com/users/georgemillo","html_url":"https://github.com/georgemillo","followers_url":"https://api.github.com/users/georgemillo/followers","following_url":"https://api.github.com/users/georgemillo/following{/other_user}","gists_url":"https://api.github.com/users/georgemillo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgemillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgemillo/subscriptions","organizations_url":"https://api.github.com/users/georgemillo/orgs","repos_url":"https://api.github.com/users/georgemillo/repos","events_url":"https://api.github.com/users/georgemillo/events{/privacy}","received_events_url":"https://api.github.com/users/georgemillo/received_events","type":"User","site_admin":false},"body":"First commit: aliases constructor methods like \"Money.usd_dollar\" to their 3-letter ISO codes (e.g. Money.usd).\r\n\r\nSecond commit: extracted these functions to a module as they're closely related and modular (and the parent 'money.rb' file is huge.)\r\n\r\nThird commit: added similar methods for British pounds (if we're going to include CAD then it only makes sense to include GBP too).","created_at":"2015-01-13T11:40:54Z","updated_at":"2015-01-13T13:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa242daf12643fcee808a65ba712ab2cc9ad4173","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RubyMoney/money/pulls/477/commits","review_comments_url":"https://api.github.com/repos/RubyMoney/money/pulls/477/comments","review_comment_url":"https://api.github.com/repos/RubyMoney/money/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RubyMoney/money/issues/477/comments","statuses_url":"https://api.github.com/repos/RubyMoney/money/statuses/11f838af4213962fb6e401a038c497bc0d04941a","head":{"label":"RubyMoney:constructors","ref":"constructors","sha":"11f838af4213962fb6e401a038c497bc0d04941a","user":{"login":"RubyMoney","id":351550,"avatar_url":"https://avatars.githubusercontent.com/u/351550?v=3","gravatar_id":"","url":"https://api.github.com/users/RubyMoney","html_url":"https://github.com/RubyMoney","followers_url":"https://api.github.com/users/RubyMoney/followers","following_url":"https://api.github.com/users/RubyMoney/following{/other_user}","gists_url":"https://api.github.com/users/RubyMoney/gists{/gist_id}","starred_url":"https://api.github.com/users/RubyMoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubyMoney/subscriptions","organizations_url":"https://api.github.com/users/RubyMoney/orgs","repos_url":"https://api.github.com/users/RubyMoney/repos","events_url":"https://api.github.com/users/RubyMoney/events{/privacy}","received_events_url":"https://api.github.com/users/RubyMoney/received_events","type":"Organization","site_admin":false},"repo":{"id":70121,"name":"money","full_name":"RubyMoney/money","owner":{"login":"RubyMoney","id":351550,"avatar_url":"https://avatars.githubusercontent.com/u/351550?v=3","gravatar_id":"","url":"https://api.github.com/users/RubyMoney","html_url":"https://github.com/RubyMoney","followers_url":"https://api.github.com/users/RubyMoney/followers","following_url":"https://api.github.com/users/RubyMoney/following{/other_user}","gists_url":"https://api.github.com/users/RubyMoney/gists{/gist_id}","starred_url":"https://api.github.com/users/RubyMoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubyMoney/subscriptions","organizations_url":"https://api.github.com/users/RubyMoney/orgs","repos_url":"https://api.github.com/users/RubyMoney/repos","events_url":"https://api.github.com/users/RubyMoney/events{/privacy}","received_events_url":"https://api.github.com/users/RubyMoney/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RubyMoney/money","description":"A Ruby Library for dealing with money and currency conversion.","fork":false,"url":"https://api.github.com/repos/RubyMoney/money","forks_url":"https://api.github.com/repos/RubyMoney/money/forks","keys_url":"https://api.github.com/repos/RubyMoney/money/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RubyMoney/money/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RubyMoney/money/teams","hooks_url":"https://api.github.com/repos/RubyMoney/money/hooks","issue_events_url":"https://api.github.com/repos/RubyMoney/money/issues/events{/number}","events_url":"https://api.github.com/repos/RubyMoney/money/events","assignees_url":"https://api.github.com/repos/RubyMoney/money/assignees{/user}","branches_url":"https://api.github.com/repos/RubyMoney/money/branches{/branch}","tags_url":"https://api.github.com/repos/RubyMoney/money/tags","blobs_url":"https://api.github.com/repos/RubyMoney/money/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RubyMoney/money/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RubyMoney/money/git/refs{/sha}","trees_url":"https://api.github.com/repos/RubyMoney/money/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RubyMoney/money/statuses/{sha}","languages_url":"https://api.github.com/repos/RubyMoney/money/languages","stargazers_url":"https://api.github.com/repos/RubyMoney/money/stargazers","contributors_url":"https://api.github.com/repos/RubyMoney/money/contributors","subscribers_url":"https://api.github.com/repos/RubyMoney/money/subscribers","subscription_url":"https://api.github.com/repos/RubyMoney/money/subscription","commits_url":"https://api.github.com/repos/RubyMoney/money/commits{/sha}","git_commits_url":"https://api.github.com/repos/RubyMoney/money/git/commits{/sha}","comments_url":"https://api.github.com/repos/RubyMoney/money/comments{/number}","issue_comment_url":"https://api.github.com/repos/RubyMoney/money/issues/comments/{number}","contents_url":"https://api.github.com/repos/RubyMoney/money/contents/{+path}","compare_url":"https://api.github.com/repos/RubyMoney/money/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RubyMoney/money/merges","archive_url":"https://api.github.com/repos/RubyMoney/money/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RubyMoney/money/downloads","issues_url":"https://api.github.com/repos/RubyMoney/money/issues{/number}","pulls_url":"https://api.github.com/repos/RubyMoney/money/pulls{/number}","milestones_url":"https://api.github.com/repos/RubyMoney/money/milestones{/number}","notifications_url":"https://api.github.com/repos/RubyMoney/money/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RubyMoney/money/labels{/name}","releases_url":"https://api.github.com/repos/RubyMoney/money/releases{/id}","created_at":"2008-10-31T15:05:03Z","updated_at":"2015-01-13T13:51:43Z","pushed_at":"2015-01-13T13:55:05Z","git_url":"git://github.com/RubyMoney/money.git","ssh_url":"git@github.com:RubyMoney/money.git","clone_url":"https://github.com/RubyMoney/money.git","svn_url":"https://github.com/RubyMoney/money","homepage":"http://rubymoney.github.io/money","size":3546,"stargazers_count":1172,"watchers_count":1172,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":291,"mirror_url":null,"open_issues_count":3,"forks":291,"open_issues":3,"watchers":1172,"default_branch":"master"}},"base":{"label":"RubyMoney:master","ref":"master","sha":"6a3398933d81f6c676835abd3fc9dd17248adb9b","user":{"login":"RubyMoney","id":351550,"avatar_url":"https://avatars.githubusercontent.com/u/351550?v=3","gravatar_id":"","url":"https://api.github.com/users/RubyMoney","html_url":"https://github.com/RubyMoney","followers_url":"https://api.github.com/users/RubyMoney/followers","following_url":"https://api.github.com/users/RubyMoney/following{/other_user}","gists_url":"https://api.github.com/users/RubyMoney/gists{/gist_id}","starred_url":"https://api.github.com/users/RubyMoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubyMoney/subscriptions","organizations_url":"https://api.github.com/users/RubyMoney/orgs","repos_url":"https://api.github.com/users/RubyMoney/repos","events_url":"https://api.github.com/users/RubyMoney/events{/privacy}","received_events_url":"https://api.github.com/users/RubyMoney/received_events","type":"Organization","site_admin":false},"repo":{"id":70121,"name":"money","full_name":"RubyMoney/money","owner":{"login":"RubyMoney","id":351550,"avatar_url":"https://avatars.githubusercontent.com/u/351550?v=3","gravatar_id":"","url":"https://api.github.com/users/RubyMoney","html_url":"https://github.com/RubyMoney","followers_url":"https://api.github.com/users/RubyMoney/followers","following_url":"https://api.github.com/users/RubyMoney/following{/other_user}","gists_url":"https://api.github.com/users/RubyMoney/gists{/gist_id}","starred_url":"https://api.github.com/users/RubyMoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubyMoney/subscriptions","organizations_url":"https://api.github.com/users/RubyMoney/orgs","repos_url":"https://api.github.com/users/RubyMoney/repos","events_url":"https://api.github.com/users/RubyMoney/events{/privacy}","received_events_url":"https://api.github.com/users/RubyMoney/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RubyMoney/money","description":"A Ruby Library for dealing with money and currency conversion.","fork":false,"url":"https://api.github.com/repos/RubyMoney/money","forks_url":"https://api.github.com/repos/RubyMoney/money/forks","keys_url":"https://api.github.com/repos/RubyMoney/money/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RubyMoney/money/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RubyMoney/money/teams","hooks_url":"https://api.github.com/repos/RubyMoney/money/hooks","issue_events_url":"https://api.github.com/repos/RubyMoney/money/issues/events{/number}","events_url":"https://api.github.com/repos/RubyMoney/money/events","assignees_url":"https://api.github.com/repos/RubyMoney/money/assignees{/user}","branches_url":"https://api.github.com/repos/RubyMoney/money/branches{/branch}","tags_url":"https://api.github.com/repos/RubyMoney/money/tags","blobs_url":"https://api.github.com/repos/RubyMoney/money/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RubyMoney/money/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RubyMoney/money/git/refs{/sha}","trees_url":"https://api.github.com/repos/RubyMoney/money/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RubyMoney/money/statuses/{sha}","languages_url":"https://api.github.com/repos/RubyMoney/money/languages","stargazers_url":"https://api.github.com/repos/RubyMoney/money/stargazers","contributors_url":"https://api.github.com/repos/RubyMoney/money/contributors","subscribers_url":"https://api.github.com/repos/RubyMoney/money/subscribers","subscription_url":"https://api.github.com/repos/RubyMoney/money/subscription","commits_url":"https://api.github.com/repos/RubyMoney/money/commits{/sha}","git_commits_url":"https://api.github.com/repos/RubyMoney/money/git/commits{/sha}","comments_url":"https://api.github.com/repos/RubyMoney/money/comments{/number}","issue_comment_url":"https://api.github.com/repos/RubyMoney/money/issues/comments/{number}","contents_url":"https://api.github.com/repos/RubyMoney/money/contents/{+path}","compare_url":"https://api.github.com/repos/RubyMoney/money/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RubyMoney/money/merges","archive_url":"https://api.github.com/repos/RubyMoney/money/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RubyMoney/money/downloads","issues_url":"https://api.github.com/repos/RubyMoney/money/issues{/number}","pulls_url":"https://api.github.com/repos/RubyMoney/money/pulls{/number}","milestones_url":"https://api.github.com/repos/RubyMoney/money/milestones{/number}","notifications_url":"https://api.github.com/repos/RubyMoney/money/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RubyMoney/money/labels{/name}","releases_url":"https://api.github.com/repos/RubyMoney/money/releases{/id}","created_at":"2008-10-31T15:05:03Z","updated_at":"2015-01-13T13:51:43Z","pushed_at":"2015-01-13T13:55:05Z","git_url":"git://github.com/RubyMoney/money.git","ssh_url":"git@github.com:RubyMoney/money.git","clone_url":"https://github.com/RubyMoney/money.git","svn_url":"https://github.com/RubyMoney/money","homepage":"http://rubymoney.github.io/money","size":3546,"stargazers_count":1172,"watchers_count":1172,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":291,"mirror_url":null,"open_issues_count":3,"forks":291,"open_issues":3,"watchers":1172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RubyMoney/money/pulls/477"},"html":{"href":"https://github.com/RubyMoney/money/pull/477"},"issue":{"href":"https://api.github.com/repos/RubyMoney/money/issues/477"},"comments":{"href":"https://api.github.com/repos/RubyMoney/money/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/RubyMoney/money/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/RubyMoney/money/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RubyMoney/money/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/RubyMoney/money/statuses/11f838af4213962fb6e401a038c497bc0d04941a"}}}}