{"action":"created","comment":{"url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments/38873782","id":38873782,"diff_hunk":"@@ -114,6 +114,17 @@ public override object FromBinary(byte[] bytes, Type type)\n         {\n             var proto = DaemonMsgCreateData.ParseFrom(bytes);\n             var clazz = Type.GetType(proto.Props.Clazz);\n+\n+            if (clazz == null)\n+            {\n+                var msg =\n+                    string.Format(\n+                        \"Could not find '{0}' in loaded assemblies. If this is a remote/cluster deploy scenario, \" +\n+                        \"ensure the remote system has referenced the assembly containing this type.\", proto.Props.Clazz);\n+                    \n+                throw new ActorInitializationException(msg);","path":"src/core/Akka.Remote/Serialization/DaemonMsgCreateSerializer.cs","position":12,"original_position":12,"commit_id":"903aa14f80696adb28e1b7d8832c85a70ff8dbcf","original_commit_id":"903aa14f80696adb28e1b7d8832c85a70ff8dbcf","user":{"login":"rogeralsing","id":647031,"avatar_url":"https://avatars.githubusercontent.com/u/647031?v=3","gravatar_id":"","url":"https://api.github.com/users/rogeralsing","html_url":"https://github.com/rogeralsing","followers_url":"https://api.github.com/users/rogeralsing/followers","following_url":"https://api.github.com/users/rogeralsing/following{/other_user}","gists_url":"https://api.github.com/users/rogeralsing/gists{/gist_id}","starred_url":"https://api.github.com/users/rogeralsing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogeralsing/subscriptions","organizations_url":"https://api.github.com/users/rogeralsing/orgs","repos_url":"https://api.github.com/users/rogeralsing/repos","events_url":"https://api.github.com/users/rogeralsing/events{/privacy}","received_events_url":"https://api.github.com/users/rogeralsing/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-09-07T16:53:13Z","updated_at":"2015-09-07T16:53:13Z","html_url":"https://github.com/akkadotnet/akka.net/pull/1286#discussion_r38873782","pull_request_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286","_links":{"self":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments/38873782"},"html":{"href":"https://github.com/akkadotnet/akka.net/pull/1286#discussion_r38873782"},"pull_request":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286"}}},"pull_request":{"url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286","id":43774585,"html_url":"https://github.com/akkadotnet/akka.net/pull/1286","diff_url":"https://github.com/akkadotnet/akka.net/pull/1286.diff","patch_url":"https://github.com/akkadotnet/akka.net/pull/1286.patch","issue_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/1286","number":1286,"state":"open","locked":false,"title":"Better exception message when a remote actor deploy fails because of missing reference #1279","user":{"login":"rdavisau","id":7392704,"avatar_url":"https://avatars.githubusercontent.com/u/7392704?v=3","gravatar_id":"","url":"https://api.github.com/users/rdavisau","html_url":"https://github.com/rdavisau","followers_url":"https://api.github.com/users/rdavisau/followers","following_url":"https://api.github.com/users/rdavisau/following{/other_user}","gists_url":"https://api.github.com/users/rdavisau/gists{/gist_id}","starred_url":"https://api.github.com/users/rdavisau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdavisau/subscriptions","organizations_url":"https://api.github.com/users/rdavisau/orgs","repos_url":"https://api.github.com/users/rdavisau/repos","events_url":"https://api.github.com/users/rdavisau/events{/privacy}","received_events_url":"https://api.github.com/users/rdavisau/received_events","type":"User","site_admin":false},"body":"This addresses #1279. \r\n\r\nAs suggested, I added checks to the `Props` constructors to handle cases where the `type` constructor parameter was `null`. I added a single test for the six methods changed (if preferred, I can split them out). Finally, I added the check to `DaemonMsgCreateSerializer` - when `GetType` returns `null` for the actor type name, an exception is thrown informing the user that the type should be referenced.","created_at":"2015-08-31T15:11:55Z","updated_at":"2015-09-07T16:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f30266e83692ca7b3dc87afb9e3f55dc398814ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286/commits","review_comments_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286/comments","review_comment_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/1286/comments","statuses_url":"https://api.github.com/repos/akkadotnet/akka.net/statuses/903aa14f80696adb28e1b7d8832c85a70ff8dbcf","head":{"label":"rdavisau:better-exceptions-for-unreferenced-actor-types-1279","ref":"better-exceptions-for-unreferenced-actor-types-1279","sha":"903aa14f80696adb28e1b7d8832c85a70ff8dbcf","user":{"login":"rdavisau","id":7392704,"avatar_url":"https://avatars.githubusercontent.com/u/7392704?v=3","gravatar_id":"","url":"https://api.github.com/users/rdavisau","html_url":"https://github.com/rdavisau","followers_url":"https://api.github.com/users/rdavisau/followers","following_url":"https://api.github.com/users/rdavisau/following{/other_user}","gists_url":"https://api.github.com/users/rdavisau/gists{/gist_id}","starred_url":"https://api.github.com/users/rdavisau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdavisau/subscriptions","organizations_url":"https://api.github.com/users/rdavisau/orgs","repos_url":"https://api.github.com/users/rdavisau/repos","events_url":"https://api.github.com/users/rdavisau/events{/privacy}","received_events_url":"https://api.github.com/users/rdavisau/received_events","type":"User","site_admin":false},"repo":{"id":41662284,"name":"akka.net","full_name":"rdavisau/akka.net","owner":{"login":"rdavisau","id":7392704,"avatar_url":"https://avatars.githubusercontent.com/u/7392704?v=3","gravatar_id":"","url":"https://api.github.com/users/rdavisau","html_url":"https://github.com/rdavisau","followers_url":"https://api.github.com/users/rdavisau/followers","following_url":"https://api.github.com/users/rdavisau/following{/other_user}","gists_url":"https://api.github.com/users/rdavisau/gists{/gist_id}","starred_url":"https://api.github.com/users/rdavisau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdavisau/subscriptions","organizations_url":"https://api.github.com/users/rdavisau/orgs","repos_url":"https://api.github.com/users/rdavisau/repos","events_url":"https://api.github.com/users/rdavisau/events{/privacy}","received_events_url":"https://api.github.com/users/rdavisau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdavisau/akka.net","description":"Port of Akka actors for .NET","fork":true,"url":"https://api.github.com/repos/rdavisau/akka.net","forks_url":"https://api.github.com/repos/rdavisau/akka.net/forks","keys_url":"https://api.github.com/repos/rdavisau/akka.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdavisau/akka.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdavisau/akka.net/teams","hooks_url":"https://api.github.com/repos/rdavisau/akka.net/hooks","issue_events_url":"https://api.github.com/repos/rdavisau/akka.net/issues/events{/number}","events_url":"https://api.github.com/repos/rdavisau/akka.net/events","assignees_url":"https://api.github.com/repos/rdavisau/akka.net/assignees{/user}","branches_url":"https://api.github.com/repos/rdavisau/akka.net/branches{/branch}","tags_url":"https://api.github.com/repos/rdavisau/akka.net/tags","blobs_url":"https://api.github.com/repos/rdavisau/akka.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdavisau/akka.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdavisau/akka.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdavisau/akka.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdavisau/akka.net/statuses/{sha}","languages_url":"https://api.github.com/repos/rdavisau/akka.net/languages","stargazers_url":"https://api.github.com/repos/rdavisau/akka.net/stargazers","contributors_url":"https://api.github.com/repos/rdavisau/akka.net/contributors","subscribers_url":"https://api.github.com/repos/rdavisau/akka.net/subscribers","subscription_url":"https://api.github.com/repos/rdavisau/akka.net/subscription","commits_url":"https://api.github.com/repos/rdavisau/akka.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdavisau/akka.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdavisau/akka.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdavisau/akka.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdavisau/akka.net/contents/{+path}","compare_url":"https://api.github.com/repos/rdavisau/akka.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdavisau/akka.net/merges","archive_url":"https://api.github.com/repos/rdavisau/akka.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdavisau/akka.net/downloads","issues_url":"https://api.github.com/repos/rdavisau/akka.net/issues{/number}","pulls_url":"https://api.github.com/repos/rdavisau/akka.net/pulls{/number}","milestones_url":"https://api.github.com/repos/rdavisau/akka.net/milestones{/number}","notifications_url":"https://api.github.com/repos/rdavisau/akka.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdavisau/akka.net/labels{/name}","releases_url":"https://api.github.com/repos/rdavisau/akka.net/releases{/id}","created_at":"2015-08-31T07:38:40Z","updated_at":"2015-08-31T07:38:43Z","pushed_at":"2015-08-31T15:18:53Z","git_url":"git://github.com/rdavisau/akka.net.git","ssh_url":"git@github.com:rdavisau/akka.net.git","clone_url":"https://github.com/rdavisau/akka.net.git","svn_url":"https://github.com/rdavisau/akka.net","homepage":"http://getakka.net","size":44914,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"akkadotnet:dev","ref":"dev","sha":"43f06cf5be4dfe746e935967e6ccdd91d7de76a5","user":{"login":"akkadotnet","id":7003835,"avatar_url":"https://avatars.githubusercontent.com/u/7003835?v=3","gravatar_id":"","url":"https://api.github.com/users/akkadotnet","html_url":"https://github.com/akkadotnet","followers_url":"https://api.github.com/users/akkadotnet/followers","following_url":"https://api.github.com/users/akkadotnet/following{/other_user}","gists_url":"https://api.github.com/users/akkadotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/akkadotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkadotnet/subscriptions","organizations_url":"https://api.github.com/users/akkadotnet/orgs","repos_url":"https://api.github.com/users/akkadotnet/repos","events_url":"https://api.github.com/users/akkadotnet/events{/privacy}","received_events_url":"https://api.github.com/users/akkadotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15509440,"name":"akka.net","full_name":"akkadotnet/akka.net","owner":{"login":"akkadotnet","id":7003835,"avatar_url":"https://avatars.githubusercontent.com/u/7003835?v=3","gravatar_id":"","url":"https://api.github.com/users/akkadotnet","html_url":"https://github.com/akkadotnet","followers_url":"https://api.github.com/users/akkadotnet/followers","following_url":"https://api.github.com/users/akkadotnet/following{/other_user}","gists_url":"https://api.github.com/users/akkadotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/akkadotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkadotnet/subscriptions","organizations_url":"https://api.github.com/users/akkadotnet/orgs","repos_url":"https://api.github.com/users/akkadotnet/repos","events_url":"https://api.github.com/users/akkadotnet/events{/privacy}","received_events_url":"https://api.github.com/users/akkadotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akkadotnet/akka.net","description":"Port of Akka actors for .NET","fork":false,"url":"https://api.github.com/repos/akkadotnet/akka.net","forks_url":"https://api.github.com/repos/akkadotnet/akka.net/forks","keys_url":"https://api.github.com/repos/akkadotnet/akka.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akkadotnet/akka.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akkadotnet/akka.net/teams","hooks_url":"https://api.github.com/repos/akkadotnet/akka.net/hooks","issue_events_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/events{/number}","events_url":"https://api.github.com/repos/akkadotnet/akka.net/events","assignees_url":"https://api.github.com/repos/akkadotnet/akka.net/assignees{/user}","branches_url":"https://api.github.com/repos/akkadotnet/akka.net/branches{/branch}","tags_url":"https://api.github.com/repos/akkadotnet/akka.net/tags","blobs_url":"https://api.github.com/repos/akkadotnet/akka.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akkadotnet/akka.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akkadotnet/akka.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/akkadotnet/akka.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akkadotnet/akka.net/statuses/{sha}","languages_url":"https://api.github.com/repos/akkadotnet/akka.net/languages","stargazers_url":"https://api.github.com/repos/akkadotnet/akka.net/stargazers","contributors_url":"https://api.github.com/repos/akkadotnet/akka.net/contributors","subscribers_url":"https://api.github.com/repos/akkadotnet/akka.net/subscribers","subscription_url":"https://api.github.com/repos/akkadotnet/akka.net/subscription","commits_url":"https://api.github.com/repos/akkadotnet/akka.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/akkadotnet/akka.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/akkadotnet/akka.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/akkadotnet/akka.net/contents/{+path}","compare_url":"https://api.github.com/repos/akkadotnet/akka.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akkadotnet/akka.net/merges","archive_url":"https://api.github.com/repos/akkadotnet/akka.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akkadotnet/akka.net/downloads","issues_url":"https://api.github.com/repos/akkadotnet/akka.net/issues{/number}","pulls_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls{/number}","milestones_url":"https://api.github.com/repos/akkadotnet/akka.net/milestones{/number}","notifications_url":"https://api.github.com/repos/akkadotnet/akka.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akkadotnet/akka.net/labels{/name}","releases_url":"https://api.github.com/repos/akkadotnet/akka.net/releases{/id}","created_at":"2013-12-29T14:17:38Z","updated_at":"2015-09-07T09:32:23Z","pushed_at":"2015-09-07T06:14:32Z","git_url":"git://github.com/akkadotnet/akka.net.git","ssh_url":"git@github.com:akkadotnet/akka.net.git","clone_url":"https://github.com/akkadotnet/akka.net.git","svn_url":"https://github.com/akkadotnet/akka.net","homepage":"http://getakka.net","size":59489,"stargazers_count":1145,"watchers_count":1145,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":120,"forks":265,"open_issues":120,"watchers":1145,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286"},"html":{"href":"https://github.com/akkadotnet/akka.net/pull/1286"},"issue":{"href":"https://api.github.com/repos/akkadotnet/akka.net/issues/1286"},"comments":{"href":"https://api.github.com/repos/akkadotnet/akka.net/issues/1286/comments"},"review_comments":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286/comments"},"review_comment":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1286/commits"},"statuses":{"href":"https://api.github.com/repos/akkadotnet/akka.net/statuses/903aa14f80696adb28e1b7d8832c85a70ff8dbcf"}}}}