{"action":"closed","number":3279,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/3279","id":45051673,"html_url":"https://github.com/Sylius/Sylius/pull/3279","diff_url":"https://github.com/Sylius/Sylius/pull/3279.diff","patch_url":"https://github.com/Sylius/Sylius/pull/3279.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/3279","number":3279,"state":"closed","locked":false,"title":"[Core] Promotion item based flag removal","user":{"login":"PWalkow","id":1130582,"avatar_url":"https://avatars.githubusercontent.com/u/1130582?v=3","gravatar_id":"","url":"https://api.github.com/users/PWalkow","html_url":"https://github.com/PWalkow","followers_url":"https://api.github.com/users/PWalkow/followers","following_url":"https://api.github.com/users/PWalkow/following{/other_user}","gists_url":"https://api.github.com/users/PWalkow/gists{/gist_id}","starred_url":"https://api.github.com/users/PWalkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PWalkow/subscriptions","organizations_url":"https://api.github.com/users/PWalkow/orgs","repos_url":"https://api.github.com/users/PWalkow/repos","events_url":"https://api.github.com/users/PWalkow/events{/privacy}","received_events_url":"https://api.github.com/users/PWalkow/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | yes, if some was using that flag\r\n| Fixed tickets | [https://github.com/Sylius/Sylius/issues/1810]\r\n| License       | MIT\r\n\r\nAccording to the https://github.com/Sylius/Sylius/issues/1810 first step to further improve promotion is remove `promotion.item_based` from parameters and OrderPromotionListener.","created_at":"2015-09-15T13:52:37Z","updated_at":"2015-11-02T15:23:07Z","closed_at":"2015-11-02T15:23:07Z","merged_at":"2015-11-02T15:23:07Z","merge_commit_sha":"24cf2d61a04d33e45fe7f48b3386a94fd501ffa7","assignee":null,"milestone":{"url":"https://api.github.com/repos/Sylius/Sylius/milestones/3","html_url":"https://github.com/Sylius/Sylius/milestones/v0.16.0","labels_url":"https://api.github.com/repos/Sylius/Sylius/milestones/3/labels","id":1104561,"number":3,"title":"v0.16.0","description":"Version v0.16.0 of Sylius platform.","creator":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"open_issues":74,"closed_issues":75,"state":"open","created_at":"2015-05-11T11:10:02Z","updated_at":"2015-11-02T15:23:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3279/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3279/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/3279/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/42e29e74017e7b07fee58a828cd0b8e3b359a504","head":{"label":"PWalkow:promotion-item-based-flag-removal","ref":"promotion-item-based-flag-removal","sha":"42e29e74017e7b07fee58a828cd0b8e3b359a504","user":{"login":"PWalkow","id":1130582,"avatar_url":"https://avatars.githubusercontent.com/u/1130582?v=3","gravatar_id":"","url":"https://api.github.com/users/PWalkow","html_url":"https://github.com/PWalkow","followers_url":"https://api.github.com/users/PWalkow/followers","following_url":"https://api.github.com/users/PWalkow/following{/other_user}","gists_url":"https://api.github.com/users/PWalkow/gists{/gist_id}","starred_url":"https://api.github.com/users/PWalkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PWalkow/subscriptions","organizations_url":"https://api.github.com/users/PWalkow/orgs","repos_url":"https://api.github.com/users/PWalkow/repos","events_url":"https://api.github.com/users/PWalkow/events{/privacy}","received_events_url":"https://api.github.com/users/PWalkow/received_events","type":"User","site_admin":false},"repo":{"id":40906020,"name":"Sylius","full_name":"PWalkow/Sylius","owner":{"login":"PWalkow","id":1130582,"avatar_url":"https://avatars.githubusercontent.com/u/1130582?v=3","gravatar_id":"","url":"https://api.github.com/users/PWalkow","html_url":"https://github.com/PWalkow","followers_url":"https://api.github.com/users/PWalkow/followers","following_url":"https://api.github.com/users/PWalkow/following{/other_user}","gists_url":"https://api.github.com/users/PWalkow/gists{/gist_id}","starred_url":"https://api.github.com/users/PWalkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PWalkow/subscriptions","organizations_url":"https://api.github.com/users/PWalkow/orgs","repos_url":"https://api.github.com/users/PWalkow/repos","events_url":"https://api.github.com/users/PWalkow/events{/privacy}","received_events_url":"https://api.github.com/users/PWalkow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PWalkow/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/PWalkow/Sylius","forks_url":"https://api.github.com/repos/PWalkow/Sylius/forks","keys_url":"https://api.github.com/repos/PWalkow/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PWalkow/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PWalkow/Sylius/teams","hooks_url":"https://api.github.com/repos/PWalkow/Sylius/hooks","issue_events_url":"https://api.github.com/repos/PWalkow/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/PWalkow/Sylius/events","assignees_url":"https://api.github.com/repos/PWalkow/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/PWalkow/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/PWalkow/Sylius/tags","blobs_url":"https://api.github.com/repos/PWalkow/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PWalkow/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PWalkow/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/PWalkow/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PWalkow/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/PWalkow/Sylius/languages","stargazers_url":"https://api.github.com/repos/PWalkow/Sylius/stargazers","contributors_url":"https://api.github.com/repos/PWalkow/Sylius/contributors","subscribers_url":"https://api.github.com/repos/PWalkow/Sylius/subscribers","subscription_url":"https://api.github.com/repos/PWalkow/Sylius/subscription","commits_url":"https://api.github.com/repos/PWalkow/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/PWalkow/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/PWalkow/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/PWalkow/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/PWalkow/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/PWalkow/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PWalkow/Sylius/merges","archive_url":"https://api.github.com/repos/PWalkow/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PWalkow/Sylius/downloads","issues_url":"https://api.github.com/repos/PWalkow/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/PWalkow/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/PWalkow/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/PWalkow/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PWalkow/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/PWalkow/Sylius/releases{/id}","created_at":"2015-08-17T15:29:24Z","updated_at":"2015-08-17T15:29:30Z","pushed_at":"2015-10-30T09:33:41Z","git_url":"git://github.com/PWalkow/Sylius.git","ssh_url":"git@github.com:PWalkow/Sylius.git","clone_url":"https://github.com/PWalkow/Sylius.git","svn_url":"https://github.com/PWalkow/Sylius","homepage":"Sylius.org","size":19539,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"54ff288acf36f40979a6be13675bf0037c3bb3ec","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","created_at":"2011-11-05T22:05:52Z","updated_at":"2015-11-02T12:49:11Z","pushed_at":"2015-11-02T15:23:07Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"Sylius.org","size":70321,"stargazers_count":2024,"watchers_count":2024,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":738,"mirror_url":null,"open_issues_count":547,"forks":738,"open_issues":547,"watchers":2024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3279"},"html":{"href":"https://github.com/Sylius/Sylius/pull/3279"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/3279"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/3279/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3279/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3279/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/42e29e74017e7b07fee58a828cd0b8e3b359a504"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":2,"additions":148,"deletions":59,"changed_files":9}}