{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/104","id":41890746,"html_url":"https://github.com/AtomLinter/linter-clang/pull/104","diff_url":"https://github.com/AtomLinter/linter-clang/pull/104.diff","patch_url":"https://github.com/AtomLinter/linter-clang/pull/104.patch","issue_url":"https://api.github.com/repos/AtomLinter/linter-clang/issues/104","number":104,"state":"closed","locked":false,"title":"Split the per-language default flags","user":{"login":"yihangho","id":4226956,"avatar_url":"https://avatars.githubusercontent.com/u/4226956?v=3","gravatar_id":"","url":"https://api.github.com/users/yihangho","html_url":"https://github.com/yihangho","followers_url":"https://api.github.com/users/yihangho/followers","following_url":"https://api.github.com/users/yihangho/following{/other_user}","gists_url":"https://api.github.com/users/yihangho/gists{/gist_id}","starred_url":"https://api.github.com/users/yihangho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihangho/subscriptions","organizations_url":"https://api.github.com/users/yihangho/orgs","repos_url":"https://api.github.com/users/yihangho/repos","events_url":"https://api.github.com/users/yihangho/events{/privacy}","received_events_url":"https://api.github.com/users/yihangho/received_events","type":"User","site_admin":false},"body":"The default flags are fed into clang as one command line argument. For example, the default C++ flags are `-Wall -std=c++11`. This whole chunk is treated as one command line argument, rather than two. This is supported by the fact that clang is complaining: \"warning: unknown warning option '-Wall -std=c++11' [-Wunknown-warning-option]\".\r\n\r\nThis commit split the default flags into multiple strings. For example, `-Wall -std=c++11` becomes `-Wall` and `-std=c++11`.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/atomlinter/linter-clang/104)\n<!-- Reviewable:end -->\n","created_at":"2015-08-07T13:20:15Z","updated_at":"2015-08-11T06:10:49Z","closed_at":"2015-08-11T06:10:49Z","merged_at":"2015-08-11T06:10:49Z","merge_commit_sha":"c8803ba52deae09da6677c994cc9c185190e87d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/104/commits","review_comments_url":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/104/comments","review_comment_url":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomLinter/linter-clang/issues/104/comments","statuses_url":"https://api.github.com/repos/AtomLinter/linter-clang/statuses/cd8a36cefd4cb0586c9b274f0d740e242aeac3b2","head":{"label":"yihangho:split-args","ref":"split-args","sha":"cd8a36cefd4cb0586c9b274f0d740e242aeac3b2","user":{"login":"yihangho","id":4226956,"avatar_url":"https://avatars.githubusercontent.com/u/4226956?v=3","gravatar_id":"","url":"https://api.github.com/users/yihangho","html_url":"https://github.com/yihangho","followers_url":"https://api.github.com/users/yihangho/followers","following_url":"https://api.github.com/users/yihangho/following{/other_user}","gists_url":"https://api.github.com/users/yihangho/gists{/gist_id}","starred_url":"https://api.github.com/users/yihangho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihangho/subscriptions","organizations_url":"https://api.github.com/users/yihangho/orgs","repos_url":"https://api.github.com/users/yihangho/repos","events_url":"https://api.github.com/users/yihangho/events{/privacy}","received_events_url":"https://api.github.com/users/yihangho/received_events","type":"User","site_admin":false},"repo":{"id":40360252,"name":"linter-clang","full_name":"yihangho/linter-clang","owner":{"login":"yihangho","id":4226956,"avatar_url":"https://avatars.githubusercontent.com/u/4226956?v=3","gravatar_id":"","url":"https://api.github.com/users/yihangho","html_url":"https://github.com/yihangho","followers_url":"https://api.github.com/users/yihangho/followers","following_url":"https://api.github.com/users/yihangho/following{/other_user}","gists_url":"https://api.github.com/users/yihangho/gists{/gist_id}","starred_url":"https://api.github.com/users/yihangho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihangho/subscriptions","organizations_url":"https://api.github.com/users/yihangho/orgs","repos_url":"https://api.github.com/users/yihangho/repos","events_url":"https://api.github.com/users/yihangho/events{/privacy}","received_events_url":"https://api.github.com/users/yihangho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yihangho/linter-clang","description":"Lint C-based files using Clang.","fork":true,"url":"https://api.github.com/repos/yihangho/linter-clang","forks_url":"https://api.github.com/repos/yihangho/linter-clang/forks","keys_url":"https://api.github.com/repos/yihangho/linter-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yihangho/linter-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yihangho/linter-clang/teams","hooks_url":"https://api.github.com/repos/yihangho/linter-clang/hooks","issue_events_url":"https://api.github.com/repos/yihangho/linter-clang/issues/events{/number}","events_url":"https://api.github.com/repos/yihangho/linter-clang/events","assignees_url":"https://api.github.com/repos/yihangho/linter-clang/assignees{/user}","branches_url":"https://api.github.com/repos/yihangho/linter-clang/branches{/branch}","tags_url":"https://api.github.com/repos/yihangho/linter-clang/tags","blobs_url":"https://api.github.com/repos/yihangho/linter-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yihangho/linter-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yihangho/linter-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/yihangho/linter-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yihangho/linter-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/yihangho/linter-clang/languages","stargazers_url":"https://api.github.com/repos/yihangho/linter-clang/stargazers","contributors_url":"https://api.github.com/repos/yihangho/linter-clang/contributors","subscribers_url":"https://api.github.com/repos/yihangho/linter-clang/subscribers","subscription_url":"https://api.github.com/repos/yihangho/linter-clang/subscription","commits_url":"https://api.github.com/repos/yihangho/linter-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/yihangho/linter-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/yihangho/linter-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/yihangho/linter-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/yihangho/linter-clang/contents/{+path}","compare_url":"https://api.github.com/repos/yihangho/linter-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yihangho/linter-clang/merges","archive_url":"https://api.github.com/repos/yihangho/linter-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yihangho/linter-clang/downloads","issues_url":"https://api.github.com/repos/yihangho/linter-clang/issues{/number}","pulls_url":"https://api.github.com/repos/yihangho/linter-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/yihangho/linter-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/yihangho/linter-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yihangho/linter-clang/labels{/name}","releases_url":"https://api.github.com/repos/yihangho/linter-clang/releases{/id}","created_at":"2015-08-07T12:50:23Z","updated_at":"2015-08-07T12:50:24Z","pushed_at":"2015-08-07T13:17:44Z","git_url":"git://github.com/yihangho/linter-clang.git","ssh_url":"git@github.com:yihangho/linter-clang.git","clone_url":"https://github.com/yihangho/linter-clang.git","svn_url":"https://github.com/yihangho/linter-clang","homepage":"","size":854,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AtomLinter:master","ref":"master","sha":"acafbb100512cba58cff655a7cb0febc57144836","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":21005742,"name":"linter-clang","full_name":"AtomLinter/linter-clang","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/linter-clang","description":"Lint C-based files using Clang.","fork":false,"url":"https://api.github.com/repos/AtomLinter/linter-clang","forks_url":"https://api.github.com/repos/AtomLinter/linter-clang/forks","keys_url":"https://api.github.com/repos/AtomLinter/linter-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/linter-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/linter-clang/teams","hooks_url":"https://api.github.com/repos/AtomLinter/linter-clang/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/linter-clang/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/linter-clang/events","assignees_url":"https://api.github.com/repos/AtomLinter/linter-clang/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/linter-clang/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/linter-clang/tags","blobs_url":"https://api.github.com/repos/AtomLinter/linter-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/linter-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/linter-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/linter-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/linter-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/linter-clang/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/linter-clang/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/linter-clang/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/linter-clang/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/linter-clang/subscription","commits_url":"https://api.github.com/repos/AtomLinter/linter-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/linter-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/linter-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/linter-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/linter-clang/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/linter-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/linter-clang/merges","archive_url":"https://api.github.com/repos/AtomLinter/linter-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/linter-clang/downloads","issues_url":"https://api.github.com/repos/AtomLinter/linter-clang/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/linter-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/linter-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/linter-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/linter-clang/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/linter-clang/releases{/id}","created_at":"2014-06-19T15:36:21Z","updated_at":"2015-08-02T02:38:22Z","pushed_at":"2015-08-11T06:10:49Z","git_url":"git://github.com/AtomLinter/linter-clang.git","ssh_url":"git@github.com:AtomLinter/linter-clang.git","clone_url":"https://github.com/AtomLinter/linter-clang.git","svn_url":"https://github.com/AtomLinter/linter-clang","homepage":"","size":854,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":7,"forks":14,"open_issues":7,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/104"},"html":{"href":"https://github.com/AtomLinter/linter-clang/pull/104"},"issue":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/issues/104"},"comments":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/AtomLinter/linter-clang/statuses/cd8a36cefd4cb0586c9b274f0d740e242aeac3b2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k2b6s9j","id":594124,"avatar_url":"https://avatars.githubusercontent.com/u/594124?v=3","gravatar_id":"","url":"https://api.github.com/users/k2b6s9j","html_url":"https://github.com/k2b6s9j","followers_url":"https://api.github.com/users/k2b6s9j/followers","following_url":"https://api.github.com/users/k2b6s9j/following{/other_user}","gists_url":"https://api.github.com/users/k2b6s9j/gists{/gist_id}","starred_url":"https://api.github.com/users/k2b6s9j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k2b6s9j/subscriptions","organizations_url":"https://api.github.com/users/k2b6s9j/orgs","repos_url":"https://api.github.com/users/k2b6s9j/repos","events_url":"https://api.github.com/users/k2b6s9j/events{/privacy}","received_events_url":"https://api.github.com/users/k2b6s9j/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}