{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/39047889","id":39047889,"diff_hunk":"@@ -19,13 +22,31 @@\n   @include align-items(center, center);\n }\n .OrganizationList-user {\n+  box-sizing: border-box;\n+  position: relative;\n   width: 100%;\n \n-  &:not(:first-child) { border-top: 1px solid $cStructure-softLine; }\n+  &:not(:last-child) { border-bottom: 1px solid $cStructure-softLine; }\n+}\n+// TODO: this is duplicated from .DatasetsList-item, can we consolidate these styles somehow?","path":"app/assets/stylesheets/organization/organization_users_list.css.scss","position":28,"original_position":28,"commit_id":"9e555f252baa0260447fdadf5511d55f365b755d","original_commit_id":"9e555f252baa0260447fdadf5511d55f365b755d","user":{"login":"MariaCheca","id":2141690,"avatar_url":"https://avatars.githubusercontent.com/u/2141690?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaCheca","html_url":"https://github.com/MariaCheca","followers_url":"https://api.github.com/users/MariaCheca/followers","following_url":"https://api.github.com/users/MariaCheca/following{/other_user}","gists_url":"https://api.github.com/users/MariaCheca/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaCheca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaCheca/subscriptions","organizations_url":"https://api.github.com/users/MariaCheca/orgs","repos_url":"https://api.github.com/users/MariaCheca/repos","events_url":"https://api.github.com/users/MariaCheca/events{/privacy}","received_events_url":"https://api.github.com/users/MariaCheca/received_events","type":"User","site_admin":false},"body":"We could start a new stylesheet for this elements with many CSS properties used in multiple views. A good reference to start would be the visual styleguide (buttons, paragraphs, border lines, etc).","created_at":"2015-09-09T14:20:42Z","updated_at":"2015-09-09T14:20:42Z","html_url":"https://github.com/CartoDB/cartodb/pull/5431#discussion_r39047889","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/39047889"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/5431#discussion_r39047889"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431","id":44441598,"html_url":"https://github.com/CartoDB/cartodb/pull/5431","diff_url":"https://github.com/CartoDB/cartodb/pull/5431.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/5431.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/5431","number":5431,"state":"open","locked":false,"title":"Add users to group","user":{"login":"viddo","id":978461,"avatar_url":"https://avatars.githubusercontent.com/u/978461?v=3","gravatar_id":"","url":"https://api.github.com/users/viddo","html_url":"https://github.com/viddo","followers_url":"https://api.github.com/users/viddo/followers","following_url":"https://api.github.com/users/viddo/following{/other_user}","gists_url":"https://api.github.com/users/viddo/gists{/gist_id}","starred_url":"https://api.github.com/users/viddo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viddo/subscriptions","organizations_url":"https://api.github.com/users/viddo/orgs","repos_url":"https://api.github.com/users/viddo/repos","events_url":"https://api.github.com/users/viddo/events{/privacy}","received_events_url":"https://api.github.com/users/viddo/received_events","type":"User","site_admin":false},"body":"Part-milestone for #4883\r\n\r\nThis implements the feature of adding (in batch) users to group\r\n\r\nThe UI proposal had two different states depending on the group having users or not, which made things very complicated so opted for a simpler version to start with, showing the add-users modal if entering a group with no members.\r\n\r\nRefactored the share-permissions view to reuse the \"organization users\" part that contains the search bar since the logic/view here is exactly the same (although allow to inject how the list-view should be created since that varies for the context).\r\n\r\n![screen shot 2015-09-08 at 19 29 00](https://cloud.githubusercontent.com/assets/978461/9742364/f0970238-565f-11e5-844d-583774e90b9d.png)\r\n![screen shot 2015-09-08 at 19 29 09](https://cloud.githubusercontent.com/assets/978461/9742365/f0bcee12-565f-11e5-8f52-433fda065dcf.png)\r\n\r\nAlso had to re-organize the files (move to organization/ dir), since there were a bunch of setup stuff that was needed for this entry point too (e.g. header dropdowns etc.)\r\n\r\n@juanignaciosl can you review?","created_at":"2015-09-08T14:51:22Z","updated_at":"2015-09-09T14:20:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e58016df6027ca5dcd7adc1da387f1f2b366334","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/5431/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/9e555f252baa0260447fdadf5511d55f365b755d","head":{"label":"CartoDB:4883-add-group-users2","ref":"4883-add-group-users2","sha":"9e555f252baa0260447fdadf5511d55f365b755d","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","created_at":"2012-07-05T15:23:45Z","updated_at":"2015-09-09T02:07:15Z","pushed_at":"2015-09-09T14:20:02Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://cartodb.com","size":504473,"stargazers_count":918,"watchers_count":918,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"open_issues_count":830,"forks":214,"open_issues":830,"watchers":918,"default_branch":"master"}},"base":{"label":"CartoDB:4924-Group_metadata_API_endpoints","ref":"4924-Group_metadata_API_endpoints","sha":"a5f5c5ff894a83229479520338d4f09b9ed32d94","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","created_at":"2012-07-05T15:23:45Z","updated_at":"2015-09-09T02:07:15Z","pushed_at":"2015-09-09T14:20:02Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://cartodb.com","size":504473,"stargazers_count":918,"watchers_count":918,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"open_issues_count":830,"forks":214,"open_issues":830,"watchers":918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/5431"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/5431"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/5431/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/5431/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/9e555f252baa0260447fdadf5511d55f365b755d"}}}}