{"action":"created","issue":{"url":"https://api.github.com/repos/mgonto/angular-wizard/issues/48","labels_url":"https://api.github.com/repos/mgonto/angular-wizard/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/mgonto/angular-wizard/issues/48/comments","events_url":"https://api.github.com/repos/mgonto/angular-wizard/issues/48/events","html_url":"https://github.com/mgonto/angular-wizard/pull/48","id":42712197,"number":48,"title":"Removed lodash dependency","user":{"login":"softwaredoug","id":629060,"avatar_url":"https://avatars.githubusercontent.com/u/629060?v=3","gravatar_id":"","url":"https://api.github.com/users/softwaredoug","html_url":"https://github.com/softwaredoug","followers_url":"https://api.github.com/users/softwaredoug/followers","following_url":"https://api.github.com/users/softwaredoug/following{/other_user}","gists_url":"https://api.github.com/users/softwaredoug/gists{/gist_id}","starred_url":"https://api.github.com/users/softwaredoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softwaredoug/subscriptions","organizations_url":"https://api.github.com/users/softwaredoug/orgs","repos_url":"https://api.github.com/users/softwaredoug/repos","events_url":"https://api.github.com/users/softwaredoug/events{/privacy}","received_events_url":"https://api.github.com/users/softwaredoug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-09-14T04:09:53Z","updated_at":"2015-06-02T16:48:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mgonto/angular-wizard/pulls/48","html_url":"https://github.com/mgonto/angular-wizard/pull/48","diff_url":"https://github.com/mgonto/angular-wizard/pull/48.diff","patch_url":"https://github.com/mgonto/angular-wizard/pull/48.patch"},"body":"Thanks for your awesome directive, we get a ton of usage out of it\r\n\r\nWe weren't using lodash in our project, and while I wanted your awesome wizard directive, I'm a bit anal about layering on extra dependencies for a couple of reasons:\r\n\r\n1. Lodash added size to our JS for a library we don't use. Something like 20-30K after minifying depending on how smart we were with using lodash's official minified build. I think you only use 3-4 functions, some of which have equivelant helpers in angular (isUndefined etc). \r\n2. Possibility for conflicts with other libraries that use different versions of lodash. A lesser concern, but many prefer finding things to use with a flat dependency graph\r\n\r\nSo I went ahead and removed lodash in my fork.\r\n\r\n- Replaced _ helpers with angular equivelants where possible\r\n- Reimplemented usage of `indexOf` as `stepIdx` function\r\n- Reimplemented usages of `findWhere` with `stepByTitle`\r\n\r\nWon't be offended if you think lodash is worth keeping around, my fork can continue to support the crowd that wants to only depend on angular.\r\n\r\nThanks for your consideration\r\n-Doug"},"comment":{"url":"https://api.github.com/repos/mgonto/angular-wizard/issues/comments/108012105","html_url":"https://github.com/mgonto/angular-wizard/pull/48#issuecomment-108012105","issue_url":"https://api.github.com/repos/mgonto/angular-wizard/issues/48","id":108012105,"user":{"login":"tschneid","id":2089573,"avatar_url":"https://avatars.githubusercontent.com/u/2089573?v=3","gravatar_id":"","url":"https://api.github.com/users/tschneid","html_url":"https://github.com/tschneid","followers_url":"https://api.github.com/users/tschneid/followers","following_url":"https://api.github.com/users/tschneid/following{/other_user}","gists_url":"https://api.github.com/users/tschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/tschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschneid/subscriptions","organizations_url":"https://api.github.com/users/tschneid/orgs","repos_url":"https://api.github.com/users/tschneid/repos","events_url":"https://api.github.com/users/tschneid/events{/privacy}","received_events_url":"https://api.github.com/users/tschneid/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T16:48:16Z","updated_at":"2015-06-02T16:48:16Z","body":":+1: "}}