{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/944","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/944/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/944/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/944/events","html_url":"https://github.com/apache/cloudstack/pull/944","id":111983633,"number":944,"title":"Create test cases to getPatchFilePath method and class names changed ","user":{"login":"pedro-martins","id":8620806,"avatar_url":"https://avatars.githubusercontent.com/u/8620806?v=3","gravatar_id":"","url":"https://api.github.com/users/pedro-martins","html_url":"https://github.com/pedro-martins","followers_url":"https://api.github.com/users/pedro-martins/followers","following_url":"https://api.github.com/users/pedro-martins/following{/other_user}","gists_url":"https://api.github.com/users/pedro-martins/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-martins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-martins/subscriptions","organizations_url":"https://api.github.com/users/pedro-martins/orgs","repos_url":"https://api.github.com/users/pedro-martins/repos","events_url":"https://api.github.com/users/pedro-martins/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-martins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-17T20:40:09Z","updated_at":"2015-11-21T21:34:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/944","html_url":"https://github.com/apache/cloudstack/pull/944","diff_url":"https://github.com/apache/cloudstack/pull/944.diff","patch_url":"https://github.com/apache/cloudstack/pull/944.patch"},"body":"In this commit we created tests cases for the respective classes in package  “com.cloud.hypervisor.xenserver.resource”.\r\n \r\nWe added test cases to check the implementation of  “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.getPatchFiles”. Therefore, we test in a more comprehensive way the tests that already exist to check the code of “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.getPatchFilePath”.\r\n \r\nWe added a new abstract class, called com.cloud.hypervisor.xenserver.resource.CitrixResourceBaseTest.java\r\n \r\nThis class has two tests methods:\r\n \r\n* com.cloud.hypervisor.xenserver.resource.CitrixResourceBaseTest.testGetPathFilesExeption(CitrixResourceBase), this method tests if the getPatchFilePath() method throws the com.cloud.utils.exception.CloudRuntimeException.CloudRuntimeException when the com.cloud.utils.script.Script.findScript(String, String) return a null value;\r\n* com.cloud.hypervisor.xenserver.resource.CitrixResourceBaseTest.testGetPathFilesListReturned(CitrixResourceBase), this method tests the correct return value from getPatchFilePath() method, basically, verify if the returned list contain the file with the same absolute path that was retrieved from the findScript method.\r\n \r\nWe also changed the name of those test classes, the change was basically remove the “Path” word from the name of classes.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/158683799","html_url":"https://github.com/apache/cloudstack/pull/944#issuecomment-158683799","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/944","id":158683799,"user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T21:34:29Z","updated_at":"2015-11-21T21:34:29Z","body":"@pedro-martins like the code one question about CitrixResourceBaseTest. And also: can you rebase on a commit beyond 4.6 and not merge, please?"}}