{"action":"closed","issue":{"url":"https://api.github.com/repos/crysalead-js/dom-layer/issues/2","labels_url":"https://api.github.com/repos/crysalead-js/dom-layer/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/crysalead-js/dom-layer/issues/2/comments","events_url":"https://api.github.com/repos/crysalead-js/dom-layer/issues/2/events","html_url":"https://github.com/crysalead-js/dom-layer/issues/2","id":76218705,"number":2,"title":"attributes and properties","user":{"login":"justmeandtaken","id":10112825,"avatar_url":"https://avatars.githubusercontent.com/u/10112825?v=3","gravatar_id":"","url":"https://api.github.com/users/justmeandtaken","html_url":"https://github.com/justmeandtaken","followers_url":"https://api.github.com/users/justmeandtaken/followers","following_url":"https://api.github.com/users/justmeandtaken/following{/other_user}","gists_url":"https://api.github.com/users/justmeandtaken/gists{/gist_id}","starred_url":"https://api.github.com/users/justmeandtaken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmeandtaken/subscriptions","organizations_url":"https://api.github.com/users/justmeandtaken/orgs","repos_url":"https://api.github.com/users/justmeandtaken/repos","events_url":"https://api.github.com/users/justmeandtaken/events{/privacy}","received_events_url":"https://api.github.com/users/justmeandtaken/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-14T03:48:58Z","updated_at":"2015-05-15T13:28:55Z","closed_at":"2015-05-15T13:28:55Z","body":"@jails In the **/setter/apply-attrs** you are setting the attributes directly. But you have another function for this as well in the **domElements**. Shouldn't you have used that function here? As it is now, it's not reacting on null and undefined attributes etc. And there are no option for removing an attribute, is it?\r\n\r\nAnd you are using toLowerCase() for attribute setter, but regarding the upcoming DOM Living specs you shouldn't do that. See this section: **4.8. Interface Element - to set an attribute**\r\n\r\nFor properties I see the same thing.  You do this for both value and style elements, using functions from **domElement**\r\n\r\nFor attributes such as class, there will be an issue with SVG elements if you try to set an clasName on a SVG - it will throw something like *\"trying to set a property with only a setter\"* \r\n\r\nSo regarding the classes, you also here should have used functions from domElement, or?\r\nFor the class methods are not used anywhere...\r\n\r\nThen again, you will get an issue with IE9 that in fact don't have classList support.\r\n"}}