{"action":"created","issue":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2799","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2799/labels{/name}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2799/comments","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2799/events","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2799","id":113883810,"number":2799,"title":"Adding fix for filtering out views in CollectionView.reorder()","user":{"login":"msiconolfi","id":2567736,"avatar_url":"https://avatars.githubusercontent.com/u/2567736?v=3","gravatar_id":"","url":"https://api.github.com/users/msiconolfi","html_url":"https://github.com/msiconolfi","followers_url":"https://api.github.com/users/msiconolfi/followers","following_url":"https://api.github.com/users/msiconolfi/following{/other_user}","gists_url":"https://api.github.com/users/msiconolfi/gists{/gist_id}","starred_url":"https://api.github.com/users/msiconolfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiconolfi/subscriptions","organizations_url":"https://api.github.com/users/msiconolfi/orgs","repos_url":"https://api.github.com/users/msiconolfi/repos","events_url":"https://api.github.com/users/msiconolfi/events{/privacy}","received_events_url":"https://api.github.com/users/msiconolfi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones/34","html_url":"https://github.com/marionettejs/backbone.marionette/milestones/v2.4.4","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones/34/labels","id":1387312,"number":34,"title":"v2.4.4","description":null,"creator":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2015-11-01T14:30:59Z","updated_at":"2015-11-02T22:02:34Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-10-28T17:58:45Z","updated_at":"2015-11-03T16:12:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2799","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2799","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/2799.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/2799.patch"},"body":"Based on my finding in this [Issue](https://github.com/marionettejs/backbone.marionette/issues/2797) I have created a pull request to address the issue.\r\n\r\nThe previous `CollectionView.reorder()` did not remove any previous views that might have been filtered out after calling `._filteredSortedModels()`. This patch will identify the models that have been filtered out and manually remove their views using the `.removeChildView()` method. \r\n\r\nI added some test cases to cover this logic.\r\n\r\n*Note* This is my second PR as the first one I had made against `master` as opposed to `patch`"},"comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments/153401131","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2799#issuecomment-153401131","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2799","id":153401131,"user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T16:12:28Z","updated_at":"2015-11-03T16:12:28Z","body":":+1: "}}