{"action":"created","issue":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1064","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1064/labels{/name}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1064/comments","events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1064/events","html_url":"https://github.com/RPCS3/rpcs3/issues/1064","id":69336266,"number":1064,"title":"Various static analysis warnings (by  @Syphurith)","user":{"login":"Bigpet","id":465677,"avatar_url":"https://avatars.githubusercontent.com/u/465677?v=3","gravatar_id":"","url":"https://api.github.com/users/Bigpet","html_url":"https://github.com/Bigpet","followers_url":"https://api.github.com/users/Bigpet/followers","following_url":"https://api.github.com/users/Bigpet/following{/other_user}","gists_url":"https://api.github.com/users/Bigpet/gists{/gist_id}","starred_url":"https://api.github.com/users/Bigpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bigpet/subscriptions","organizations_url":"https://api.github.com/users/Bigpet/orgs","repos_url":"https://api.github.com/users/Bigpet/repos","events_url":"https://api.github.com/users/Bigpet/events{/privacy}","received_events_url":"https://api.github.com/users/Bigpet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-18T18:40:25Z","updated_at":"2015-08-11T18:19:43Z","closed_at":null,"body":"Alright, since we have too many `TODO:`s strewn about in the code I want to highlight these to stay visible after #1059 is merged\r\n\r\n- [ ] [always false if (unsigned < 0)](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Crypto/lz.cpp#L143)\r\n- [ ] [unsigned <=0 , maybe it should be ==0 maybe something else](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Crypto/sha1.cpp#L236)\r\n- [ ] [= and == precedence is probably wrong, some braces would help](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Emu/ARMv7/Modules/sceLibc.cpp#L31)\r\n- [ ] [std::remove_if without erase](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Emu/Cell/PPULLVMRecompiler.cpp#L5823)\r\n- [ ] [if and else if with identical condition](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Emu/SysCalls/Modules/cellAdec.cpp#L199)\r\n- [ ] [another if and else if with same condition](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Emu/SysCalls/Modules/cellVdec.cpp#L171)\r\n- [ ] [check if discarded return values are important](https://github.com/RPCS3/rpcs3/blob/fd34d11eec5069f8d39b51bab67c316ae6c057eb/rpcs3/Gui/InterpreterDisAsm.cpp#L517-L522)"},"comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments/130002058","html_url":"https://github.com/RPCS3/rpcs3/issues/1064#issuecomment-130002058","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1064","id":130002058,"user":{"login":"paulsapps","id":7420121,"avatar_url":"https://avatars.githubusercontent.com/u/7420121?v=3","gravatar_id":"","url":"https://api.github.com/users/paulsapps","html_url":"https://github.com/paulsapps","followers_url":"https://api.github.com/users/paulsapps/followers","following_url":"https://api.github.com/users/paulsapps/following{/other_user}","gists_url":"https://api.github.com/users/paulsapps/gists{/gist_id}","starred_url":"https://api.github.com/users/paulsapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulsapps/subscriptions","organizations_url":"https://api.github.com/users/paulsapps/orgs","repos_url":"https://api.github.com/users/paulsapps/repos","events_url":"https://api.github.com/users/paulsapps/events{/privacy}","received_events_url":"https://api.github.com/users/paulsapps/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T18:19:43Z","updated_at":"2015-08-11T18:19:43Z","body":"One idea for the future is add null rendering backend so on travis you can run valgrind against hello world app for say 5 seconds to check main code paths dont have any obvious memory bugs"}}