{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/1","id":32370314,"html_url":"https://github.com/jacobrosenthal/bs2-serialport/pull/1","diff_url":"https://github.com/jacobrosenthal/bs2-serialport/pull/1.diff","patch_url":"https://github.com/jacobrosenthal/bs2-serialport/pull/1.patch","issue_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/1","number":1,"state":"closed","locked":false,"title":"implement bs2-serialport as a protocol instead of a serialport abstraction","user":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"body":"The way @monteslu referred to this was \"protocol\".\r\n\r\nBelow is my understanding and thoughts on the API abstractions:\r\n* Transport: implements `.write` and `on('data')` - e.g. node-serialport, browser-serialport\r\n* Protocol: implements mid level abstractions like `.reset`, `.signoff` and `.send` - the protocol is tied to a transport in most cases.  This project could be renamed to `bs2-serial-protocol`\r\n* Programmer: implements the high level abstractions such as `.identify`, `.challenge`, and `.bootload` - the programmer receives a protocol and calls methods on it for the programming lifecycle.\r\n\r\n@monteslu @jacobrosenthal thoughts?","created_at":"2015-03-31T21:57:46Z","updated_at":"2015-04-09T00:17:46Z","closed_at":"2015-04-09T00:17:46Z","merged_at":"2015-04-09T00:17:46Z","merge_commit_sha":"2e3d3acfd4effab2839e4f8463282984a43c070f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/1/comments","statuses_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/statuses/cc29979a401a2ae66639fccd48445b02dcedc136","head":{"label":"jacobrosenthal:protocol","ref":"protocol","sha":"cc29979a401a2ae66639fccd48445b02dcedc136","user":{"login":"jacobrosenthal","id":455796,"avatar_url":"https://avatars.githubusercontent.com/u/455796?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobrosenthal","html_url":"https://github.com/jacobrosenthal","followers_url":"https://api.github.com/users/jacobrosenthal/followers","following_url":"https://api.github.com/users/jacobrosenthal/following{/other_user}","gists_url":"https://api.github.com/users/jacobrosenthal/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobrosenthal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobrosenthal/subscriptions","organizations_url":"https://api.github.com/users/jacobrosenthal/orgs","repos_url":"https://api.github.com/users/jacobrosenthal/repos","events_url":"https://api.github.com/users/jacobrosenthal/events{/privacy}","received_events_url":"https://api.github.com/users/jacobrosenthal/received_events","type":"User","site_admin":false},"repo":{"id":32599463,"name":"bs2-serialport","full_name":"jacobrosenthal/bs2-serialport","owner":{"login":"jacobrosenthal","id":455796,"avatar_url":"https://avatars.githubusercontent.com/u/455796?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobrosenthal","html_url":"https://github.com/jacobrosenthal","followers_url":"https://api.github.com/users/jacobrosenthal/followers","following_url":"https://api.github.com/users/jacobrosenthal/following{/other_user}","gists_url":"https://api.github.com/users/jacobrosenthal/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobrosenthal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobrosenthal/subscriptions","organizations_url":"https://api.github.com/users/jacobrosenthal/orgs","repos_url":"https://api.github.com/users/jacobrosenthal/repos","events_url":"https://api.github.com/users/jacobrosenthal/events{/privacy}","received_events_url":"https://api.github.com/users/jacobrosenthal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacobrosenthal/bs2-serialport","description":"bs2 wrapper for node-serialport","fork":false,"url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport","forks_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/forks","keys_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/teams","hooks_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/hooks","issue_events_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/events{/number}","events_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/events","assignees_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/assignees{/user}","branches_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/branches{/branch}","tags_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/tags","blobs_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/statuses/{sha}","languages_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/languages","stargazers_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/stargazers","contributors_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/contributors","subscribers_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/subscribers","subscription_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/subscription","commits_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/contents/{+path}","compare_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/merges","archive_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/downloads","issues_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues{/number}","pulls_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls{/number}","milestones_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/milestones{/number}","notifications_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/labels{/name}","releases_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/releases{/id}","created_at":"2015-03-20T18:10:13Z","updated_at":"2015-03-20T18:10:23Z","pushed_at":"2015-04-09T00:17:46Z","git_url":"git://github.com/jacobrosenthal/bs2-serialport.git","ssh_url":"git@github.com:jacobrosenthal/bs2-serialport.git","clone_url":"https://github.com/jacobrosenthal/bs2-serialport.git","svn_url":"https://github.com/jacobrosenthal/bs2-serialport","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jacobrosenthal:master","ref":"master","sha":"6a5da06c00253366a00e29bd52cf6f6a43ad6da6","user":{"login":"jacobrosenthal","id":455796,"avatar_url":"https://avatars.githubusercontent.com/u/455796?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobrosenthal","html_url":"https://github.com/jacobrosenthal","followers_url":"https://api.github.com/users/jacobrosenthal/followers","following_url":"https://api.github.com/users/jacobrosenthal/following{/other_user}","gists_url":"https://api.github.com/users/jacobrosenthal/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobrosenthal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobrosenthal/subscriptions","organizations_url":"https://api.github.com/users/jacobrosenthal/orgs","repos_url":"https://api.github.com/users/jacobrosenthal/repos","events_url":"https://api.github.com/users/jacobrosenthal/events{/privacy}","received_events_url":"https://api.github.com/users/jacobrosenthal/received_events","type":"User","site_admin":false},"repo":{"id":32599463,"name":"bs2-serialport","full_name":"jacobrosenthal/bs2-serialport","owner":{"login":"jacobrosenthal","id":455796,"avatar_url":"https://avatars.githubusercontent.com/u/455796?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobrosenthal","html_url":"https://github.com/jacobrosenthal","followers_url":"https://api.github.com/users/jacobrosenthal/followers","following_url":"https://api.github.com/users/jacobrosenthal/following{/other_user}","gists_url":"https://api.github.com/users/jacobrosenthal/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobrosenthal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobrosenthal/subscriptions","organizations_url":"https://api.github.com/users/jacobrosenthal/orgs","repos_url":"https://api.github.com/users/jacobrosenthal/repos","events_url":"https://api.github.com/users/jacobrosenthal/events{/privacy}","received_events_url":"https://api.github.com/users/jacobrosenthal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacobrosenthal/bs2-serialport","description":"bs2 wrapper for node-serialport","fork":false,"url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport","forks_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/forks","keys_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/teams","hooks_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/hooks","issue_events_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/events{/number}","events_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/events","assignees_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/assignees{/user}","branches_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/branches{/branch}","tags_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/tags","blobs_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/statuses/{sha}","languages_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/languages","stargazers_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/stargazers","contributors_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/contributors","subscribers_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/subscribers","subscription_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/subscription","commits_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/contents/{+path}","compare_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/merges","archive_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/downloads","issues_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues{/number}","pulls_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls{/number}","milestones_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/milestones{/number}","notifications_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/labels{/name}","releases_url":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/releases{/id}","created_at":"2015-03-20T18:10:13Z","updated_at":"2015-03-20T18:10:23Z","pushed_at":"2015-04-09T00:17:46Z","git_url":"git://github.com/jacobrosenthal/bs2-serialport.git","ssh_url":"git@github.com:jacobrosenthal/bs2-serialport.git","clone_url":"https://github.com/jacobrosenthal/bs2-serialport.git","svn_url":"https://github.com/jacobrosenthal/bs2-serialport","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/1"},"html":{"href":"https://github.com/jacobrosenthal/bs2-serialport/pull/1"},"issue":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/1"},"comments":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jacobrosenthal/bs2-serialport/statuses/cc29979a401a2ae66639fccd48445b02dcedc136"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":8,"additions":220,"deletions":39,"changed_files":2}}