{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/48149835","id":48149835,"diff_hunk":"@@ -0,0 +1,22 @@\n+'use strict';\n+var common = require('../common');\n+var assert = require('assert');\n+\n+var fs = require('fs');\n+var dgram = require('dgram');\n+var callbacks = 0;\n+var client, timer, buf;\n+\n+client = dgram.createSocket('udp4');\n+\n+buf = new Buffer(256);\n+\n+client.send(buf, common.PORT, '127.0.0.1', function(err, bytes) {\n+  assert.equal(bytes, buf.length);\n+  clearTimeout(timer);\n+  client.close();\n+});\n+\n+timer = setTimeout(function() {\n+  throw new Error('Timeout');\n+}, 200);","path":"test/parallel/test-dgram-send-callback-buffer.js","position":22,"original_position":22,"commit_id":"b10d44d78293aca740dee5965fbaa27f05e70799","original_commit_id":"b10d44d78293aca740dee5965fbaa27f05e70799","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"body":"I am actually not sure why these tests are time-bound.","created_at":"2015-12-21T14:27:17Z","updated_at":"2015-12-21T14:27:17Z","html_url":"https://github.com/nodejs/node/pull/4374#discussion_r48149835","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4374","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/48149835"},"html":{"href":"https://github.com/nodejs/node/pull/4374#discussion_r48149835"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4374"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4374","id":54232762,"html_url":"https://github.com/nodejs/node/pull/4374","diff_url":"https://github.com/nodejs/node/pull/4374.diff","patch_url":"https://github.com/nodejs/node/pull/4374.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4374","number":4374,"state":"open","locked":false,"title":"dgram: support multiple buffers","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"This PR adds support for:\r\n\r\n* `socket.send(buf, port, host, [, callback])`\r\n* `socket.send([buf1, buf2, ... ], port, host, [, callback])`\r\n\r\nFixes https://github.com/nodejs/node/issues/4302.\r\n\r\nThis is probably missing some benchmarks, and might like an optimization pass, but I would like to get some feedbacks first :).\r\n\r\ncc @ronkorving @indutny @saghul\r\n","created_at":"2015-12-21T08:51:50Z","updated_at":"2015-12-21T14:27:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ef1ef45c69a45ce987063aeb8bb65d4a694d2d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4374/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4374/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4374/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b10d44d78293aca740dee5965fbaa27f05e70799","head":{"label":"mcollina:new-dgram","ref":"new-dgram","sha":"b10d44d78293aca740dee5965fbaa27f05e70799","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"repo":{"id":36234606,"name":"node","full_name":"mcollina/node","owner":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcollina/node","description":"My fork of node","fork":true,"url":"https://api.github.com/repos/mcollina/node","forks_url":"https://api.github.com/repos/mcollina/node/forks","keys_url":"https://api.github.com/repos/mcollina/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcollina/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcollina/node/teams","hooks_url":"https://api.github.com/repos/mcollina/node/hooks","issue_events_url":"https://api.github.com/repos/mcollina/node/issues/events{/number}","events_url":"https://api.github.com/repos/mcollina/node/events","assignees_url":"https://api.github.com/repos/mcollina/node/assignees{/user}","branches_url":"https://api.github.com/repos/mcollina/node/branches{/branch}","tags_url":"https://api.github.com/repos/mcollina/node/tags","blobs_url":"https://api.github.com/repos/mcollina/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcollina/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcollina/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcollina/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcollina/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mcollina/node/languages","stargazers_url":"https://api.github.com/repos/mcollina/node/stargazers","contributors_url":"https://api.github.com/repos/mcollina/node/contributors","subscribers_url":"https://api.github.com/repos/mcollina/node/subscribers","subscription_url":"https://api.github.com/repos/mcollina/node/subscription","commits_url":"https://api.github.com/repos/mcollina/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcollina/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcollina/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcollina/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcollina/node/contents/{+path}","compare_url":"https://api.github.com/repos/mcollina/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcollina/node/merges","archive_url":"https://api.github.com/repos/mcollina/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcollina/node/downloads","issues_url":"https://api.github.com/repos/mcollina/node/issues{/number}","pulls_url":"https://api.github.com/repos/mcollina/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mcollina/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mcollina/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcollina/node/labels{/name}","releases_url":"https://api.github.com/repos/mcollina/node/releases{/id}","created_at":"2015-05-25T14:06:50Z","updated_at":"2015-10-08T12:01:10Z","pushed_at":"2015-12-21T12:26:05Z","git_url":"git://github.com/mcollina/node.git","ssh_url":"git@github.com:mcollina/node.git","clone_url":"https://github.com/mcollina/node.git","svn_url":"https://github.com/mcollina/node","homepage":"","size":160581,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"14f81a022dec3994a0a7fd034b91058d6bd2d975","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-12-21T14:23:34Z","pushed_at":"2015-12-21T14:15:06Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":180555,"stargazers_count":18485,"watchers_count":18485,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2099,"mirror_url":null,"open_issues_count":635,"forks":2099,"open_issues":635,"watchers":18485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4374"},"html":{"href":"https://github.com/nodejs/node/pull/4374"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4374"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4374/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4374/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4374/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b10d44d78293aca740dee5965fbaa27f05e70799"}}}}