{"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/comments/47044575","id":47044575,"diff_hunk":"@@ -107,16 +109,11 @@ class BlockingProcess(\n     }\n \n     try {\n-      val stdin =\n-        context.actorOf(OutputStreamSubscriber.props(process.getOutputStream), \"stdin\")\n+      val stdin = Sink.outputStream(process.getOutputStream)\n+      val stdout = Source.inputStream(process.getInputStream)\n+      val stderr = Source.inputStream(process.getErrorStream)","path":"src/main/scala/akka/contrib/process/BlockingProcess.scala","position":35,"original_position":35,"commit_id":"84bbf12e9a00a2404af7ea0c998c94918673102a","original_commit_id":"84bbf12e9a00a2404af7ea0c998c94918673102a","user":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"body":"To be honest - I'm not sure.\r\n\r\nThe Actor within the `Source.inputStream()` is created by calling `materializer.actorOf` - so my understanding this means this Actor is the child of where the Source is materialized. I'm not 100% sure if my understanding is corrrect.\r\n\r\nPerhaps someone from Akka team can help clarify please (@2m or @ktoso) ? \r\n","created_at":"2015-12-09T02:22:44Z","updated_at":"2015-12-09T02:22:44Z","html_url":"https://github.com/typesafehub/akka-contrib-extra/pull/46#discussion_r47044575","pull_request_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/comments/47044575"},"html":{"href":"https://github.com/typesafehub/akka-contrib-extra/pull/46#discussion_r47044575"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46","id":53059264,"html_url":"https://github.com/typesafehub/akka-contrib-extra/pull/46","diff_url":"https://github.com/typesafehub/akka-contrib-extra/pull/46.diff","patch_url":"https://github.com/typesafehub/akka-contrib-extra/pull/46.patch","issue_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues/46","number":46,"state":"open","locked":false,"title":"WIP - DON'T MERGE - Trying to migrate to out of the box Source.inputStream() and Sink.outputStream()","user":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"body":"This PR is created to share the progress of migrating to Akka Stream's `Source.inputStream()` and `Sink.outputStream()`","created_at":"2015-12-09T00:13:58Z","updated_at":"2015-12-09T02:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0bb201cf32e7469e0bef45115400c17317eb832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46/commits","review_comments_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46/comments","review_comment_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues/46/comments","statuses_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/statuses/84bbf12e9a00a2404af7ea0c998c94918673102a","head":{"label":"fsat:stream-source","ref":"stream-source","sha":"84bbf12e9a00a2404af7ea0c998c94918673102a","user":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"repo":{"id":47518199,"name":"akka-contrib-extra","full_name":"fsat/akka-contrib-extra","owner":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fsat/akka-contrib-extra","description":"Reactive Runtime Akka contributions","fork":true,"url":"https://api.github.com/repos/fsat/akka-contrib-extra","forks_url":"https://api.github.com/repos/fsat/akka-contrib-extra/forks","keys_url":"https://api.github.com/repos/fsat/akka-contrib-extra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsat/akka-contrib-extra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsat/akka-contrib-extra/teams","hooks_url":"https://api.github.com/repos/fsat/akka-contrib-extra/hooks","issue_events_url":"https://api.github.com/repos/fsat/akka-contrib-extra/issues/events{/number}","events_url":"https://api.github.com/repos/fsat/akka-contrib-extra/events","assignees_url":"https://api.github.com/repos/fsat/akka-contrib-extra/assignees{/user}","branches_url":"https://api.github.com/repos/fsat/akka-contrib-extra/branches{/branch}","tags_url":"https://api.github.com/repos/fsat/akka-contrib-extra/tags","blobs_url":"https://api.github.com/repos/fsat/akka-contrib-extra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsat/akka-contrib-extra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsat/akka-contrib-extra/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsat/akka-contrib-extra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsat/akka-contrib-extra/statuses/{sha}","languages_url":"https://api.github.com/repos/fsat/akka-contrib-extra/languages","stargazers_url":"https://api.github.com/repos/fsat/akka-contrib-extra/stargazers","contributors_url":"https://api.github.com/repos/fsat/akka-contrib-extra/contributors","subscribers_url":"https://api.github.com/repos/fsat/akka-contrib-extra/subscribers","subscription_url":"https://api.github.com/repos/fsat/akka-contrib-extra/subscription","commits_url":"https://api.github.com/repos/fsat/akka-contrib-extra/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsat/akka-contrib-extra/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsat/akka-contrib-extra/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsat/akka-contrib-extra/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsat/akka-contrib-extra/contents/{+path}","compare_url":"https://api.github.com/repos/fsat/akka-contrib-extra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsat/akka-contrib-extra/merges","archive_url":"https://api.github.com/repos/fsat/akka-contrib-extra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsat/akka-contrib-extra/downloads","issues_url":"https://api.github.com/repos/fsat/akka-contrib-extra/issues{/number}","pulls_url":"https://api.github.com/repos/fsat/akka-contrib-extra/pulls{/number}","milestones_url":"https://api.github.com/repos/fsat/akka-contrib-extra/milestones{/number}","notifications_url":"https://api.github.com/repos/fsat/akka-contrib-extra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsat/akka-contrib-extra/labels{/name}","releases_url":"https://api.github.com/repos/fsat/akka-contrib-extra/releases{/id}","created_at":"2015-12-06T23:24:44Z","updated_at":"2015-12-06T23:24:44Z","pushed_at":"2015-12-09T01:15:35Z","git_url":"git://github.com/fsat/akka-contrib-extra.git","ssh_url":"git@github.com:fsat/akka-contrib-extra.git","clone_url":"https://github.com/fsat/akka-contrib-extra.git","svn_url":"https://github.com/fsat/akka-contrib-extra","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"0371ceb2a27225cb961a55c4af7289d751ed155e","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":26474077,"name":"akka-contrib-extra","full_name":"typesafehub/akka-contrib-extra","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/akka-contrib-extra","description":"Reactive Runtime Akka contributions","fork":false,"url":"https://api.github.com/repos/typesafehub/akka-contrib-extra","forks_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/forks","keys_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/teams","hooks_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/events","assignees_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/tags","blobs_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/languages","stargazers_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/subscription","commits_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/merges","archive_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/downloads","issues_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/akka-contrib-extra/releases{/id}","created_at":"2014-11-11T07:21:00Z","updated_at":"2015-05-06T08:41:48Z","pushed_at":"2015-12-09T01:15:36Z","git_url":"git://github.com/typesafehub/akka-contrib-extra.git","ssh_url":"git@github.com:typesafehub/akka-contrib-extra.git","clone_url":"https://github.com/typesafehub/akka-contrib-extra.git","svn_url":"https://github.com/typesafehub/akka-contrib-extra","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46"},"html":{"href":"https://github.com/typesafehub/akka-contrib-extra/pull/46"},"issue":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues/46"},"comments":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/akka-contrib-extra/statuses/84bbf12e9a00a2404af7ea0c998c94918673102a"}}}}