{"action":"created","comment":{"url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/comments/37725987","id":37725987,"diff_hunk":"@@ -506,25 +599,40 @@ public synchronized void start() {\n             errorCount++;\n             addError(\"No encoder was configured for appender \" + name + \".\");","path":"src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java","position":283,"original_position":283,"commit_id":"8ca35ecfbc361376cd23efad5bcc7348b818c469","original_commit_id":"8ca35ecfbc361376cd23efad5bcc7348b818c469","user":{"login":"brenuart","id":3028601,"avatar_url":"https://avatars.githubusercontent.com/u/3028601?v=3","gravatar_id":"","url":"https://api.github.com/users/brenuart","html_url":"https://github.com/brenuart","followers_url":"https://api.github.com/users/brenuart/followers","following_url":"https://api.github.com/users/brenuart/following{/other_user}","gists_url":"https://api.github.com/users/brenuart/gists{/gist_id}","starred_url":"https://api.github.com/users/brenuart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenuart/subscriptions","organizations_url":"https://api.github.com/users/brenuart/orgs","repos_url":"https://api.github.com/users/brenuart/repos","events_url":"https://api.github.com/users/brenuart/events{/privacy}","received_events_url":"https://api.github.com/users/brenuart/received_events","type":"User","site_admin":false},"body":"Some but not all error report the appender name in the message.\r\nAs far as I can tell, this is not needed as logback core already includes enough information about the failing appender when throwing its exception.\r\nI propose to remove the appender name from every error messages generated by the appender.","created_at":"2015-08-24T07:47:14Z","updated_at":"2015-08-24T07:47:14Z","html_url":"https://github.com/logstash/logstash-logback-encoder/pull/116#discussion_r37725987","pull_request_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/comments/37725987"},"html":{"href":"https://github.com/logstash/logstash-logback-encoder/pull/116#discussion_r37725987"},"pull_request":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116","id":41074294,"html_url":"https://github.com/logstash/logstash-logback-encoder/pull/116","diff_url":"https://github.com/logstash/logstash-logback-encoder/pull/116.diff","patch_url":"https://github.com/logstash/logstash-logback-encoder/pull/116.patch","issue_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues/116","number":116,"state":"open","locked":false,"title":"TcpSocketAppender Failover implementation","user":{"login":"brenuart","id":3028601,"avatar_url":"https://avatars.githubusercontent.com/u/3028601?v=3","gravatar_id":"","url":"https://api.github.com/users/brenuart","html_url":"https://github.com/brenuart","followers_url":"https://api.github.com/users/brenuart/followers","following_url":"https://api.github.com/users/brenuart/following{/other_user}","gists_url":"https://api.github.com/users/brenuart/gists{/gist_id}","starred_url":"https://api.github.com/users/brenuart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenuart/subscriptions","organizations_url":"https://api.github.com/users/brenuart/orgs","repos_url":"https://api.github.com/users/brenuart/repos","events_url":"https://api.github.com/users/brenuart/events{/privacy}","received_events_url":"https://api.github.com/users/brenuart/received_events","type":"User","site_admin":false},"body":"See https://github.com/logstash/logstash-logback-encoder/issues/115\r\n\r\nThis PR holds a first quick-and-dirty attempts to implement the feature. Please, have a look for review and comments.\r\n\r\n##### Short description of changes\r\nA comma separated list of `host:port` pairs can be specified via the `<hostAddresses>` configuration property. The first host is the primary, while the others are considered secondaries.\r\n\r\nThe appender tries to connect to the primary and fallbacks to a secondary when unavailable. Hosts are tried in the order they appear in the `<hostAddresses>` property.\r\n\r\nWhen connected to a secondary, the appender tries to reconnect to the primary after `<reconnectionToPrimaryDelay>` time.\r\n","created_at":"2015-07-28T23:54:01Z","updated_at":"2015-08-24T07:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c59794cb0788059ba1a9a2793d2f19bfdc68f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116/commits","review_comments_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116/comments","review_comment_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues/116/comments","statuses_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/statuses/8ca35ecfbc361376cd23efad5bcc7348b818c469","head":{"label":"brenuart:failover","ref":"failover","sha":"8ca35ecfbc361376cd23efad5bcc7348b818c469","user":{"login":"brenuart","id":3028601,"avatar_url":"https://avatars.githubusercontent.com/u/3028601?v=3","gravatar_id":"","url":"https://api.github.com/users/brenuart","html_url":"https://github.com/brenuart","followers_url":"https://api.github.com/users/brenuart/followers","following_url":"https://api.github.com/users/brenuart/following{/other_user}","gists_url":"https://api.github.com/users/brenuart/gists{/gist_id}","starred_url":"https://api.github.com/users/brenuart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenuart/subscriptions","organizations_url":"https://api.github.com/users/brenuart/orgs","repos_url":"https://api.github.com/users/brenuart/repos","events_url":"https://api.github.com/users/brenuart/events{/privacy}","received_events_url":"https://api.github.com/users/brenuart/received_events","type":"User","site_admin":false},"repo":{"id":39852392,"name":"logstash-logback-encoder","full_name":"brenuart/logstash-logback-encoder","owner":{"login":"brenuart","id":3028601,"avatar_url":"https://avatars.githubusercontent.com/u/3028601?v=3","gravatar_id":"","url":"https://api.github.com/users/brenuart","html_url":"https://github.com/brenuart","followers_url":"https://api.github.com/users/brenuart/followers","following_url":"https://api.github.com/users/brenuart/following{/other_user}","gists_url":"https://api.github.com/users/brenuart/gists{/gist_id}","starred_url":"https://api.github.com/users/brenuart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenuart/subscriptions","organizations_url":"https://api.github.com/users/brenuart/orgs","repos_url":"https://api.github.com/users/brenuart/repos","events_url":"https://api.github.com/users/brenuart/events{/privacy}","received_events_url":"https://api.github.com/users/brenuart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brenuart/logstash-logback-encoder","description":"Logback encoder which creates JSON for use with Logstash","fork":true,"url":"https://api.github.com/repos/brenuart/logstash-logback-encoder","forks_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/forks","keys_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/teams","hooks_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/hooks","issue_events_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/issues/events{/number}","events_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/events","assignees_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/assignees{/user}","branches_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/branches{/branch}","tags_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/tags","blobs_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/statuses/{sha}","languages_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/languages","stargazers_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/stargazers","contributors_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/contributors","subscribers_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/subscribers","subscription_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/subscription","commits_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/contents/{+path}","compare_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/merges","archive_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/downloads","issues_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/issues{/number}","pulls_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/pulls{/number}","milestones_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/milestones{/number}","notifications_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/labels{/name}","releases_url":"https://api.github.com/repos/brenuart/logstash-logback-encoder/releases{/id}","created_at":"2015-07-28T18:58:48Z","updated_at":"2015-07-28T18:58:49Z","pushed_at":"2015-08-02T22:34:40Z","git_url":"git://github.com/brenuart/logstash-logback-encoder.git","ssh_url":"git@github.com:brenuart/logstash-logback-encoder.git","clone_url":"https://github.com/brenuart/logstash-logback-encoder.git","svn_url":"https://github.com/brenuart/logstash-logback-encoder","homepage":"","size":763,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash:master","ref":"master","sha":"287f1b77838d7fbf01080f691374ee68c7aed5e8","user":{"login":"logstash","id":509506,"avatar_url":"https://avatars.githubusercontent.com/u/509506?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash","html_url":"https://github.com/logstash","followers_url":"https://api.github.com/users/logstash/followers","following_url":"https://api.github.com/users/logstash/following{/other_user}","gists_url":"https://api.github.com/users/logstash/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash/subscriptions","organizations_url":"https://api.github.com/users/logstash/orgs","repos_url":"https://api.github.com/users/logstash/repos","events_url":"https://api.github.com/users/logstash/events{/privacy}","received_events_url":"https://api.github.com/users/logstash/received_events","type":"Organization","site_admin":false},"repo":{"id":8559429,"name":"logstash-logback-encoder","full_name":"logstash/logstash-logback-encoder","owner":{"login":"logstash","id":509506,"avatar_url":"https://avatars.githubusercontent.com/u/509506?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash","html_url":"https://github.com/logstash","followers_url":"https://api.github.com/users/logstash/followers","following_url":"https://api.github.com/users/logstash/following{/other_user}","gists_url":"https://api.github.com/users/logstash/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash/subscriptions","organizations_url":"https://api.github.com/users/logstash/orgs","repos_url":"https://api.github.com/users/logstash/repos","events_url":"https://api.github.com/users/logstash/events{/privacy}","received_events_url":"https://api.github.com/users/logstash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash/logstash-logback-encoder","description":"Logback encoder which creates JSON for use with Logstash","fork":false,"url":"https://api.github.com/repos/logstash/logstash-logback-encoder","forks_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/forks","keys_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/teams","hooks_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/hooks","issue_events_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues/events{/number}","events_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/events","assignees_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/assignees{/user}","branches_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/branches{/branch}","tags_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/tags","blobs_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/languages","stargazers_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/stargazers","contributors_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/contributors","subscribers_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/subscribers","subscription_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/subscription","commits_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/contents/{+path}","compare_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/merges","archive_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/downloads","issues_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues{/number}","pulls_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/labels{/name}","releases_url":"https://api.github.com/repos/logstash/logstash-logback-encoder/releases{/id}","created_at":"2013-03-04T16:19:08Z","updated_at":"2015-08-21T05:37:39Z","pushed_at":"2015-08-24T06:16:28Z","git_url":"git://github.com/logstash/logstash-logback-encoder.git","ssh_url":"git@github.com:logstash/logstash-logback-encoder.git","clone_url":"https://github.com/logstash/logstash-logback-encoder.git","svn_url":"https://github.com/logstash/logstash-logback-encoder","homepage":"","size":1952,"stargazers_count":227,"watchers_count":227,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":6,"forks":80,"open_issues":6,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116"},"html":{"href":"https://github.com/logstash/logstash-logback-encoder/pull/116"},"issue":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues/116"},"comments":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/logstash/logstash-logback-encoder/statuses/8ca35ecfbc361376cd23efad5bcc7348b818c469"}}}}