{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/29052693","id":29052693,"diff_hunk":"@@ -0,0 +1,103 @@\n+beforeEach module 'app'\n+\n+describe 'inspectdata', ->\n+\n+    $rootScope = $compile = null\n+\n+    injected = ($injector) ->\n+        $compile = $injector.get('$compile')\n+        $rootScope = $injector.get('$rootScope')\n+\n+    beforeEach inject injected\n+\n+    it 'should inspect data correctly', ->","path":"www/md_base/src/app/common/directives/inspectdata/inspectdata.spec.coffee","position":13,"original_position":13,"commit_id":"52668367fae8de274f3bd91c05e0952bf87ba6a9","original_commit_id":"52668367fae8de274f3bd91c05e0952bf87ba6a9","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"body":"nornally you should test only one thing for each test.\r\nyou can factorize in beforeeach the initialization of the directive, and then test each feature in a different 'it'","created_at":"2015-04-24T14:28:28Z","updated_at":"2015-04-24T14:28:28Z","html_url":"https://github.com/buildbot/buildbot/pull/1639#discussion_r29052693","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1639","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/29052693"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1639#discussion_r29052693"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1639","id":33822518,"html_url":"https://github.com/buildbot/buildbot/pull/1639","diff_url":"https://github.com/buildbot/buildbot/pull/1639.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1639.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1639","number":1639,"state":"open","locked":false,"title":"[WIP] MD: the about page","user":{"login":"shanzi","id":557294,"avatar_url":"https://avatars.githubusercontent.com/u/557294?v=3","gravatar_id":"","url":"https://api.github.com/users/shanzi","html_url":"https://github.com/shanzi","followers_url":"https://api.github.com/users/shanzi/followers","following_url":"https://api.github.com/users/shanzi/following{/other_user}","gists_url":"https://api.github.com/users/shanzi/gists{/gist_id}","starred_url":"https://api.github.com/users/shanzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanzi/subscriptions","organizations_url":"https://api.github.com/users/shanzi/orgs","repos_url":"https://api.github.com/users/shanzi/repos","events_url":"https://api.github.com/users/shanzi/events{/privacy}","received_events_url":"https://api.github.com/users/shanzi/received_events","type":"User","site_admin":false},"body":"Here is the about page, half finished.\r\n\r\nThe page is responsive to the width of page. When it is thin:\r\n\r\n![aboutview-thin](https://cloud.githubusercontent.com/assets/557294/7266578/93904322-e8de-11e4-8a8b-ea7846c8f411.png)\r\n\r\nwhen it is fat:\r\n\r\n![aboutview-fat](https://cloud.githubusercontent.com/assets/557294/7266582/9a5a3a96-e8de-11e4-8208-9af4995f2967.png)\r\n\r\nI wrote a directive to displaying objects like the old `rawdata` directive, but is more elegant and clean. I omitted the nested displaying function, but using `JSON.stringify` for a better view of the value. The field can be collapsed or expanded displaying JSON in different indention.\r\n\r\nField collapsed:\r\n\r\n![field-collapsed](https://cloud.githubusercontent.com/assets/557294/7266602/eaef4a14-e8de-11e4-8c30-f4fd7e5cfc7a.png)\r\n\r\nField expanded:\r\n\r\n![field-expanded](https://cloud.githubusercontent.com/assets/557294/7266610/f615439e-e8de-11e4-93b6-f2ecb3ee2d43.png)\r\n\r\nLive demo at: http://buildbot.apps.io-meter.com/#/about\r\n\r\n**NOTE**: as displaying the api specs depend on `buildbotService`, it has not been added yet.\r\n\r\n### TODO\r\n- [x] tests for `inpectdata` directive\r\n- [ ] add animation when collapse and expand field\r\n- [ ] displaying API spec\r\n","created_at":"2015-04-22T03:06:52Z","updated_at":"2015-04-24T14:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90b930a7fcb1d48a207f6f28c933c8b183bf5c4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1639/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/52668367fae8de274f3bd91c05e0952bf87ba6a9","head":{"label":"shanzi:md","ref":"md","sha":"52668367fae8de274f3bd91c05e0952bf87ba6a9","user":{"login":"shanzi","id":557294,"avatar_url":"https://avatars.githubusercontent.com/u/557294?v=3","gravatar_id":"","url":"https://api.github.com/users/shanzi","html_url":"https://github.com/shanzi","followers_url":"https://api.github.com/users/shanzi/followers","following_url":"https://api.github.com/users/shanzi/following{/other_user}","gists_url":"https://api.github.com/users/shanzi/gists{/gist_id}","starred_url":"https://api.github.com/users/shanzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanzi/subscriptions","organizations_url":"https://api.github.com/users/shanzi/orgs","repos_url":"https://api.github.com/users/shanzi/repos","events_url":"https://api.github.com/users/shanzi/events{/privacy}","received_events_url":"https://api.github.com/users/shanzi/received_events","type":"User","site_admin":false},"repo":{"id":31756463,"name":"buildbot","full_name":"shanzi/buildbot","owner":{"login":"shanzi","id":557294,"avatar_url":"https://avatars.githubusercontent.com/u/557294?v=3","gravatar_id":"","url":"https://api.github.com/users/shanzi","html_url":"https://github.com/shanzi","followers_url":"https://api.github.com/users/shanzi/followers","following_url":"https://api.github.com/users/shanzi/following{/other_user}","gists_url":"https://api.github.com/users/shanzi/gists{/gist_id}","starred_url":"https://api.github.com/users/shanzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanzi/subscriptions","organizations_url":"https://api.github.com/users/shanzi/orgs","repos_url":"https://api.github.com/users/shanzi/repos","events_url":"https://api.github.com/users/shanzi/events{/privacy}","received_events_url":"https://api.github.com/users/shanzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shanzi/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/shanzi/buildbot","forks_url":"https://api.github.com/repos/shanzi/buildbot/forks","keys_url":"https://api.github.com/repos/shanzi/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shanzi/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shanzi/buildbot/teams","hooks_url":"https://api.github.com/repos/shanzi/buildbot/hooks","issue_events_url":"https://api.github.com/repos/shanzi/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/shanzi/buildbot/events","assignees_url":"https://api.github.com/repos/shanzi/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/shanzi/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/shanzi/buildbot/tags","blobs_url":"https://api.github.com/repos/shanzi/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shanzi/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shanzi/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/shanzi/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shanzi/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/shanzi/buildbot/languages","stargazers_url":"https://api.github.com/repos/shanzi/buildbot/stargazers","contributors_url":"https://api.github.com/repos/shanzi/buildbot/contributors","subscribers_url":"https://api.github.com/repos/shanzi/buildbot/subscribers","subscription_url":"https://api.github.com/repos/shanzi/buildbot/subscription","commits_url":"https://api.github.com/repos/shanzi/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/shanzi/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/shanzi/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/shanzi/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/shanzi/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/shanzi/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shanzi/buildbot/merges","archive_url":"https://api.github.com/repos/shanzi/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shanzi/buildbot/downloads","issues_url":"https://api.github.com/repos/shanzi/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/shanzi/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/shanzi/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/shanzi/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shanzi/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/shanzi/buildbot/releases{/id}","created_at":"2015-03-06T06:49:16Z","updated_at":"2015-04-08T15:17:36Z","pushed_at":"2015-04-24T10:55:46Z","git_url":"git://github.com/shanzi/buildbot.git","ssh_url":"git@github.com:shanzi/buildbot.git","clone_url":"https://github.com/shanzi/buildbot.git","svn_url":"https://github.com/shanzi/buildbot","homepage":"http://buildbot.net","size":35329,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"f7050f8a2fc98c985ea27302aafd97a857f9d92d","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","created_at":"2010-07-06T17:56:53Z","updated_at":"2015-04-24T12:50:43Z","pushed_at":"2015-04-24T10:55:47Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":51631,"stargazers_count":1507,"watchers_count":1507,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":688,"mirror_url":null,"open_issues_count":18,"forks":688,"open_issues":18,"watchers":1507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1639"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1639"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1639"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/52668367fae8de274f3bd91c05e0952bf87ba6a9"}}}}