{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17382","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17382/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17382/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17382/events","html_url":"https://github.com/kubernetes/kubernetes/pull/17382","id":117429096,"number":17382,"title":"Rewrite cmd/linkcheck","user":{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-11-17T19:22:21Z","updated_at":"2015-11-23T22:57:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17382","html_url":"https://github.com/kubernetes/kubernetes/pull/17382","diff_url":"https://github.com/kubernetes/kubernetes/pull/17382.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17382.patch"},"body":"***The first commit is #17381***. Fix #15916, #16233.\r\n\r\nNow the linkcheck actually visits a url and checks the response code. It reports url as invalid if the status code >=400.\r\n\r\nThis check requires a long time to run. Checking docs/ folder alone takes around 5 minutes. Some possible improvements:\r\n1. only run the check on the diff of a PR;\r\n2. add a whitelist of valid URLs, and update the whitelist periodically.\r\n\r\nAny suggestions?\r\ncc @lavalamp @nikhiljindal @bgrant0607 @timstclair \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/159094249","html_url":"https://github.com/kubernetes/kubernetes/pull/17382#issuecomment-159094249","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17382","id":159094249,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T22:57:39Z","updated_at":"2015-11-23T22:57:39Z","body":"GCE e2e test build/test **passed** for commit 1576aab95ec2a8ae74e0057e6f1fe0b66f973e07.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/1576aab95ec2a8ae74e0057e6f1fe0b66f973e07/kubernetes-pull-build-test-e2e-gce/17684/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/1576aab95ec2a8ae74e0057e6f1fe0b66f973e07/kubernetes-pull-build-test-e2e-gce/17684/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//17684)\n"}}