{"action":"created","issue":{"url":"https://api.github.com/repos/cogneco/ooc-kean/issues/739","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/739/labels{/name}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/739/comments","events_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/739/events","html_url":"https://github.com/cogneco/ooc-kean/issues/739","id":116352896,"number":739,"title":"Clean math classes and covers","user":{"login":"marcusnaslund","id":14308896,"avatar_url":"https://avatars.githubusercontent.com/u/14308896?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusnaslund","html_url":"https://github.com/marcusnaslund","followers_url":"https://api.github.com/users/marcusnaslund/followers","following_url":"https://api.github.com/users/marcusnaslund/following{/other_user}","gists_url":"https://api.github.com/users/marcusnaslund/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusnaslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusnaslund/subscriptions","organizations_url":"https://api.github.com/users/marcusnaslund/orgs","repos_url":"https://api.github.com/users/marcusnaslund/repos","events_url":"https://api.github.com/users/marcusnaslund/events{/privacy}","received_events_url":"https://api.github.com/users/marcusnaslund/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cogneco/ooc-kean/labels/code%20quality","name":"code quality","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cogneco/ooc-kean/milestones/4","html_url":"https://github.com/cogneco/ooc-kean/milestones/Cleanup","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/milestones/4/labels","id":1377591,"number":4,"title":"Cleanup","description":"Trivial, non-urgent cleanup &mdash; unused functions, classes, and such.","creator":{"login":"davidhesselbom","id":4319680,"avatar_url":"https://avatars.githubusercontent.com/u/4319680?v=3","gravatar_id":"","url":"https://api.github.com/users/davidhesselbom","html_url":"https://github.com/davidhesselbom","followers_url":"https://api.github.com/users/davidhesselbom/followers","following_url":"https://api.github.com/users/davidhesselbom/following{/other_user}","gists_url":"https://api.github.com/users/davidhesselbom/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhesselbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhesselbom/subscriptions","organizations_url":"https://api.github.com/users/davidhesselbom/orgs","repos_url":"https://api.github.com/users/davidhesselbom/repos","events_url":"https://api.github.com/users/davidhesselbom/events{/privacy}","received_events_url":"https://api.github.com/users/davidhesselbom/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":42,"state":"open","created_at":"2015-10-26T16:34:28Z","updated_at":"2015-12-17T12:00:12Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-11-11T15:07:51Z","updated_at":"2015-12-22T15:46:44Z","closed_at":null,"body":"Most of these classes/covers were ported directly from their C# counterparts and haven't been maintained properly since then. A lot of code can be cleaned up, rearranged or removed to make these classes/covers easier to understand, bugfix and maintain:\r\n\r\n- [x] Rearrange the order of methods and operators to make the code easier to read. Be consistent with the ordering (from the top) members, properties, constructors, `free`, public methods, private methods, operators.\r\n- [ ] Introduce the `semiparameter` property for `(this width + this height) / 2` in covers where it is used a lot. See issue #600 \r\n- [ ] Improve performance by changing `this[]`-calls to `thisPointer[]`-type-calls wherever needed.\r\n- [ ] Write short methods and properties on one line instead of three.\r\n- [ ] Remove unneccessary imports (like `structs/ArrayList`)\r\n- [ ] Add `toText()` and deprecate `toString()`: #774 \r\n- [ ] Also relevant: Improve the test coverage: #492 \r\n\r\nThis applies to all files in `source/math`."},"comment":{"url":"https://api.github.com/repos/cogneco/ooc-kean/issues/comments/166651962","html_url":"https://github.com/cogneco/ooc-kean/issues/739#issuecomment-166651962","issue_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/739","id":166651962,"user":{"login":"thomasfanell","id":12230189,"avatar_url":"https://avatars.githubusercontent.com/u/12230189?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasfanell","html_url":"https://github.com/thomasfanell","followers_url":"https://api.github.com/users/thomasfanell/followers","following_url":"https://api.github.com/users/thomasfanell/following{/other_user}","gists_url":"https://api.github.com/users/thomasfanell/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasfanell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasfanell/subscriptions","organizations_url":"https://api.github.com/users/thomasfanell/orgs","repos_url":"https://api.github.com/users/thomasfanell/repos","events_url":"https://api.github.com/users/thomasfanell/events{/privacy}","received_events_url":"https://api.github.com/users/thomasfanell/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T15:46:44Z","updated_at":"2015-12-22T15:46:44Z","body":"> Right. I will try to update this to something more useful.\r\n\r\nFixed."}}