{"action":"created","comment":{"url":"https://api.github.com/repos/petroav/presto-admin/pulls/comments/33789372","id":33789372,"diff_hunk":"@@ -133,7 +134,7 @@ def build_dist_if_necessary(self):\n             self.build_installer_in_docker()\n         return DIST_DIR\n \n-    def build_installer_in_docker(self):\n+    def build_installer_in_docker(self, online_installer=False):\n         container_name = 'installer'","path":"tests/product/base_product_case.py","position":16,"original_position":16,"commit_id":"11e82605f8a6ef7c86265cd98cc1cf0e02974494","original_commit_id":"11e82605f8a6ef7c86265cd98cc1cf0e02974494","user":{"login":"petroav","id":665991,"avatar_url":"https://avatars.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"body":"That is the non-unique container name. When it gets passes to the DockerCluster constructor it will be suffixed with a unique identifier.","created_at":"2015-07-02T15:26:35Z","updated_at":"2015-07-02T15:26:35Z","html_url":"https://github.com/petroav/presto-admin/pull/1#discussion_r33789372","pull_request_url":"https://api.github.com/repos/petroav/presto-admin/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/petroav/presto-admin/pulls/comments/33789372"},"html":{"href":"https://github.com/petroav/presto-admin/pull/1#discussion_r33789372"},"pull_request":{"href":"https://api.github.com/repos/petroav/presto-admin/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/petroav/presto-admin/pulls/1","id":38896815,"html_url":"https://github.com/petroav/presto-admin/pull/1","diff_url":"https://github.com/petroav/presto-admin/pull/1.diff","patch_url":"https://github.com/petroav/presto-admin/pull/1.patch","issue_url":"https://api.github.com/repos/petroav/presto-admin/issues/1","number":1,"state":"closed","locked":false,"title":"pa test: improve installer tests","user":{"login":"petroav","id":665991,"avatar_url":"https://avatars.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"body":"* Build installer in centos container\r\n* Actually install presto-admin in container with no\r\n  internal connectivity\r\n\r\nTask: SWARM-586\r\nTesting: make clean dist docs lint test-all","created_at":"2015-06-30T16:22:40Z","updated_at":"2015-07-02T15:26:35Z","closed_at":"2015-07-01T16:13:08Z","merged_at":null,"merge_commit_sha":"6759228b20af2c92f7a40450b23f45e76e6b8da5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/petroav/presto-admin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/petroav/presto-admin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/petroav/presto-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/petroav/presto-admin/issues/1/comments","statuses_url":"https://api.github.com/repos/petroav/presto-admin/statuses/11e82605f8a6ef7c86265cd98cc1cf0e02974494","head":{"label":"petroav:online-offline","ref":"online-offline","sha":"11e82605f8a6ef7c86265cd98cc1cf0e02974494","user":{"login":"petroav","id":665991,"avatar_url":"https://avatars.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"repo":{"id":38002805,"name":"presto-admin","full_name":"petroav/presto-admin","owner":{"login":"petroav","id":665991,"avatar_url":"https://avatars.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petroav/presto-admin","description":"A tool to install, configure and manage Presto installations","fork":true,"url":"https://api.github.com/repos/petroav/presto-admin","forks_url":"https://api.github.com/repos/petroav/presto-admin/forks","keys_url":"https://api.github.com/repos/petroav/presto-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petroav/presto-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petroav/presto-admin/teams","hooks_url":"https://api.github.com/repos/petroav/presto-admin/hooks","issue_events_url":"https://api.github.com/repos/petroav/presto-admin/issues/events{/number}","events_url":"https://api.github.com/repos/petroav/presto-admin/events","assignees_url":"https://api.github.com/repos/petroav/presto-admin/assignees{/user}","branches_url":"https://api.github.com/repos/petroav/presto-admin/branches{/branch}","tags_url":"https://api.github.com/repos/petroav/presto-admin/tags","blobs_url":"https://api.github.com/repos/petroav/presto-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petroav/presto-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petroav/presto-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/petroav/presto-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petroav/presto-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/petroav/presto-admin/languages","stargazers_url":"https://api.github.com/repos/petroav/presto-admin/stargazers","contributors_url":"https://api.github.com/repos/petroav/presto-admin/contributors","subscribers_url":"https://api.github.com/repos/petroav/presto-admin/subscribers","subscription_url":"https://api.github.com/repos/petroav/presto-admin/subscription","commits_url":"https://api.github.com/repos/petroav/presto-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/petroav/presto-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/petroav/presto-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/petroav/presto-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/petroav/presto-admin/contents/{+path}","compare_url":"https://api.github.com/repos/petroav/presto-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petroav/presto-admin/merges","archive_url":"https://api.github.com/repos/petroav/presto-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petroav/presto-admin/downloads","issues_url":"https://api.github.com/repos/petroav/presto-admin/issues{/number}","pulls_url":"https://api.github.com/repos/petroav/presto-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/petroav/presto-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/petroav/presto-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petroav/presto-admin/labels{/name}","releases_url":"https://api.github.com/repos/petroav/presto-admin/releases{/id}","created_at":"2015-06-24T18:19:23Z","updated_at":"2015-06-24T18:19:23Z","pushed_at":"2015-07-01T20:31:24Z","git_url":"git://github.com/petroav/presto-admin.git","ssh_url":"git@github.com:petroav/presto-admin.git","clone_url":"https://github.com/petroav/presto-admin.git","svn_url":"https://github.com/petroav/presto-admin","homepage":"","size":918,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"petroav:unique","ref":"unique","sha":"34191288d76d19d2fb7fe405ed4cdc400b2a3b28","user":{"login":"petroav","id":665991,"avatar_url":"https://avatars.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"repo":{"id":38002805,"name":"presto-admin","full_name":"petroav/presto-admin","owner":{"login":"petroav","id":665991,"avatar_url":"https://avatars.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petroav/presto-admin","description":"A tool to install, configure and manage Presto installations","fork":true,"url":"https://api.github.com/repos/petroav/presto-admin","forks_url":"https://api.github.com/repos/petroav/presto-admin/forks","keys_url":"https://api.github.com/repos/petroav/presto-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petroav/presto-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petroav/presto-admin/teams","hooks_url":"https://api.github.com/repos/petroav/presto-admin/hooks","issue_events_url":"https://api.github.com/repos/petroav/presto-admin/issues/events{/number}","events_url":"https://api.github.com/repos/petroav/presto-admin/events","assignees_url":"https://api.github.com/repos/petroav/presto-admin/assignees{/user}","branches_url":"https://api.github.com/repos/petroav/presto-admin/branches{/branch}","tags_url":"https://api.github.com/repos/petroav/presto-admin/tags","blobs_url":"https://api.github.com/repos/petroav/presto-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petroav/presto-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petroav/presto-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/petroav/presto-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petroav/presto-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/petroav/presto-admin/languages","stargazers_url":"https://api.github.com/repos/petroav/presto-admin/stargazers","contributors_url":"https://api.github.com/repos/petroav/presto-admin/contributors","subscribers_url":"https://api.github.com/repos/petroav/presto-admin/subscribers","subscription_url":"https://api.github.com/repos/petroav/presto-admin/subscription","commits_url":"https://api.github.com/repos/petroav/presto-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/petroav/presto-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/petroav/presto-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/petroav/presto-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/petroav/presto-admin/contents/{+path}","compare_url":"https://api.github.com/repos/petroav/presto-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petroav/presto-admin/merges","archive_url":"https://api.github.com/repos/petroav/presto-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petroav/presto-admin/downloads","issues_url":"https://api.github.com/repos/petroav/presto-admin/issues{/number}","pulls_url":"https://api.github.com/repos/petroav/presto-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/petroav/presto-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/petroav/presto-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petroav/presto-admin/labels{/name}","releases_url":"https://api.github.com/repos/petroav/presto-admin/releases{/id}","created_at":"2015-06-24T18:19:23Z","updated_at":"2015-06-24T18:19:23Z","pushed_at":"2015-07-01T20:31:24Z","git_url":"git://github.com/petroav/presto-admin.git","ssh_url":"git@github.com:petroav/presto-admin.git","clone_url":"https://github.com/petroav/presto-admin.git","svn_url":"https://github.com/petroav/presto-admin","homepage":"","size":918,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/petroav/presto-admin/pulls/1"},"html":{"href":"https://github.com/petroav/presto-admin/pull/1"},"issue":{"href":"https://api.github.com/repos/petroav/presto-admin/issues/1"},"comments":{"href":"https://api.github.com/repos/petroav/presto-admin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/petroav/presto-admin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/petroav/presto-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/petroav/presto-admin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/petroav/presto-admin/statuses/11e82605f8a6ef7c86265cd98cc1cf0e02974494"}}}}