{"action":"created","issue":{"url":"https://api.github.com/repos/lytics/metafora/issues/122","labels_url":"https://api.github.com/repos/lytics/metafora/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/lytics/metafora/issues/122/comments","events_url":"https://api.github.com/repos/lytics/metafora/issues/122/events","html_url":"https://github.com/lytics/metafora/pull/122","id":78638338,"number":122,"title":"Fix bad behavior where fair balancer would spin after releasing tasks","user":{"login":"schmichael","id":113362,"avatar_url":"https://avatars.githubusercontent.com/u/113362?v=3","gravatar_id":"","url":"https://api.github.com/users/schmichael","html_url":"https://github.com/schmichael","followers_url":"https://api.github.com/users/schmichael/followers","following_url":"https://api.github.com/users/schmichael/following{/other_user}","gists_url":"https://api.github.com/users/schmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/schmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmichael/subscriptions","organizations_url":"https://api.github.com/users/schmichael/orgs","repos_url":"https://api.github.com/users/schmichael/repos","events_url":"https://api.github.com/users/schmichael/events{/privacy}","received_events_url":"https://api.github.com/users/schmichael/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-20T18:29:18Z","updated_at":"2015-05-20T18:33:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lytics/metafora/pulls/122","html_url":"https://github.com/lytics/metafora/pull/122","diff_url":"https://github.com/lytics/metafora/pull/122.diff","patch_url":"https://github.com/lytics/metafora/pull/122.patch"},"body":"The problem:\r\n\r\n* `FairBalancer.Balance()` releases tasks and sets the internal delay\r\n* Coordinator tries to claim rebalanced tasks, Claim fails, sets ignore\r\n  * This step repeats until `Balance()` is called again\r\n\r\nThe affects:\r\n\r\n* Spams logs (because often only 1 or 2 tasks are released)\r\n* Prevents any new claims after a rebalance which could cause a\r\n  misbalanced cluster and more balancing!\r\n\r\nThe fix:\r\n\r\nSet an *absolute* time for the delay instead of a relative time. Once\r\nthe delay expires, all tasks can be claimed even if they're the ones\r\nrecently released.\r\n\r\nThis should prevent a node from reclaiming tasks it *just* released, but\r\nit doesn't totally prevent the node from claiming tasks until the next\r\nBalance call."},"comment":{"url":"https://api.github.com/repos/lytics/metafora/issues/comments/103988204","html_url":"https://github.com/lytics/metafora/pull/122#issuecomment-103988204","issue_url":"https://api.github.com/repos/lytics/metafora/issues/122","id":103988204,"user":{"login":"kyledj","id":245654,"avatar_url":"https://avatars.githubusercontent.com/u/245654?v=3","gravatar_id":"","url":"https://api.github.com/users/kyledj","html_url":"https://github.com/kyledj","followers_url":"https://api.github.com/users/kyledj/followers","following_url":"https://api.github.com/users/kyledj/following{/other_user}","gists_url":"https://api.github.com/users/kyledj/gists{/gist_id}","starred_url":"https://api.github.com/users/kyledj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyledj/subscriptions","organizations_url":"https://api.github.com/users/kyledj/orgs","repos_url":"https://api.github.com/users/kyledj/repos","events_url":"https://api.github.com/users/kyledj/events{/privacy}","received_events_url":"https://api.github.com/users/kyledj/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T18:33:33Z","updated_at":"2015-05-20T18:33:33Z","body":":no_entry::no_entry::no_entry:\r\n:no_entry::grey_question::no_entry:\r\n:no_entry::no_entry::no_entry:"}}