{"action":"created","comment":{"url":"https://api.github.com/repos/blinkmobile/forms/pulls/comments/37499318","id":37499318,"diff_hunk":"@@ -19,6 +19,9 @@ define(function (require) {\n   // view mixins\n   var toggleClass = require('forms/mixins/view-helper-mixins').toggleClass;\n \n+  var dirtyClassName = 'bm-formelement-dirty';\n+  var pristineClassName = 'bm-formelement-pristine';\n+  var invalidClassName = 'bm-formelement-invalid';","path":"forms/jqm/element.js","position":6,"original_position":6,"commit_id":"908ae5a337dd0362743c8b4d3ed7ffafbf086b94","original_commit_id":"908ae5a337dd0362743c8b4d3ed7ffafbf086b94","user":{"login":"jokeyrhyme","id":479816,"avatar_url":"https://avatars.githubusercontent.com/u/479816?v=3","gravatar_id":"","url":"https://api.github.com/users/jokeyrhyme","html_url":"https://github.com/jokeyrhyme","followers_url":"https://api.github.com/users/jokeyrhyme/followers","following_url":"https://api.github.com/users/jokeyrhyme/following{/other_user}","gists_url":"https://api.github.com/users/jokeyrhyme/gists{/gist_id}","starred_url":"https://api.github.com/users/jokeyrhyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokeyrhyme/subscriptions","organizations_url":"https://api.github.com/users/jokeyrhyme/orgs","repos_url":"https://api.github.com/users/jokeyrhyme/repos","events_url":"https://api.github.com/users/jokeyrhyme/events{/privacy}","received_events_url":"https://api.github.com/users/jokeyrhyme/received_events","type":"User","site_admin":false},"body":"The pre-ES2015 convention for constants is to name them like ALL_CAPS. Actually, even _with_ the ES2015 `const` keyword I think it's probably helpful to be able to visually identify constants like this.","created_at":"2015-08-20T06:43:29Z","updated_at":"2015-08-20T06:43:29Z","html_url":"https://github.com/blinkmobile/forms/pull/27#discussion_r37499318","pull_request_url":"https://api.github.com/repos/blinkmobile/forms/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/blinkmobile/forms/pulls/comments/37499318"},"html":{"href":"https://github.com/blinkmobile/forms/pull/27#discussion_r37499318"},"pull_request":{"href":"https://api.github.com/repos/blinkmobile/forms/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/blinkmobile/forms/pulls/27","id":42894395,"html_url":"https://github.com/blinkmobile/forms/pull/27","diff_url":"https://github.com/blinkmobile/forms/pull/27.diff","patch_url":"https://github.com/blinkmobile/forms/pull/27.patch","issue_url":"https://api.github.com/repos/blinkmobile/forms/issues/27","number":27,"state":"open","locked":false,"title":"FORMS-194 # BEM CSS classes on (Sub)Forms and Elements","user":{"login":"simonmarklar","id":2966718,"avatar_url":"https://avatars.githubusercontent.com/u/2966718?v=3","gravatar_id":"","url":"https://api.github.com/users/simonmarklar","html_url":"https://github.com/simonmarklar","followers_url":"https://api.github.com/users/simonmarklar/followers","following_url":"https://api.github.com/users/simonmarklar/following{/other_user}","gists_url":"https://api.github.com/users/simonmarklar/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmarklar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmarklar/subscriptions","organizations_url":"https://api.github.com/users/simonmarklar/orgs","repos_url":"https://api.github.com/users/simonmarklar/repos","events_url":"https://api.github.com/users/simonmarklar/events{/privacy}","received_events_url":"https://api.github.com/users/simonmarklar/received_events","type":"User","site_admin":false},"body":"- Add bm-form and bm-formelement classes\r\n- Remove view listener for model.attributes.class and associated functions\r\n- Move any DOM element attributes into the attributes function for Element\r\n  View\r\n- Clean up Element View initialisation","created_at":"2015-08-20T06:04:27Z","updated_at":"2015-08-20T06:43:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc723c40998807121442e7584cf8382b13b842a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/blinkmobile/forms/pulls/27/commits","review_comments_url":"https://api.github.com/repos/blinkmobile/forms/pulls/27/comments","review_comment_url":"https://api.github.com/repos/blinkmobile/forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blinkmobile/forms/issues/27/comments","statuses_url":"https://api.github.com/repos/blinkmobile/forms/statuses/908ae5a337dd0362743c8b4d3ed7ffafbf086b94","head":{"label":"blinkmobile:feature/FORMS-194","ref":"feature/FORMS-194","sha":"908ae5a337dd0362743c8b4d3ed7ffafbf086b94","user":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars.githubusercontent.com/u/2390706?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":38464432,"name":"forms","full_name":"blinkmobile/forms","owner":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars.githubusercontent.com/u/2390706?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blinkmobile/forms","description":"execute a definition, creating Models and Views to capture data from users","fork":false,"url":"https://api.github.com/repos/blinkmobile/forms","forks_url":"https://api.github.com/repos/blinkmobile/forms/forks","keys_url":"https://api.github.com/repos/blinkmobile/forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blinkmobile/forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blinkmobile/forms/teams","hooks_url":"https://api.github.com/repos/blinkmobile/forms/hooks","issue_events_url":"https://api.github.com/repos/blinkmobile/forms/issues/events{/number}","events_url":"https://api.github.com/repos/blinkmobile/forms/events","assignees_url":"https://api.github.com/repos/blinkmobile/forms/assignees{/user}","branches_url":"https://api.github.com/repos/blinkmobile/forms/branches{/branch}","tags_url":"https://api.github.com/repos/blinkmobile/forms/tags","blobs_url":"https://api.github.com/repos/blinkmobile/forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blinkmobile/forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blinkmobile/forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/blinkmobile/forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blinkmobile/forms/statuses/{sha}","languages_url":"https://api.github.com/repos/blinkmobile/forms/languages","stargazers_url":"https://api.github.com/repos/blinkmobile/forms/stargazers","contributors_url":"https://api.github.com/repos/blinkmobile/forms/contributors","subscribers_url":"https://api.github.com/repos/blinkmobile/forms/subscribers","subscription_url":"https://api.github.com/repos/blinkmobile/forms/subscription","commits_url":"https://api.github.com/repos/blinkmobile/forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/blinkmobile/forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/blinkmobile/forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/blinkmobile/forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/blinkmobile/forms/contents/{+path}","compare_url":"https://api.github.com/repos/blinkmobile/forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blinkmobile/forms/merges","archive_url":"https://api.github.com/repos/blinkmobile/forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blinkmobile/forms/downloads","issues_url":"https://api.github.com/repos/blinkmobile/forms/issues{/number}","pulls_url":"https://api.github.com/repos/blinkmobile/forms/pulls{/number}","milestones_url":"https://api.github.com/repos/blinkmobile/forms/milestones{/number}","notifications_url":"https://api.github.com/repos/blinkmobile/forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blinkmobile/forms/labels{/name}","releases_url":"https://api.github.com/repos/blinkmobile/forms/releases{/id}","created_at":"2015-07-03T01:05:11Z","updated_at":"2015-07-03T01:07:51Z","pushed_at":"2015-08-20T06:23:14Z","git_url":"git://github.com/blinkmobile/forms.git","ssh_url":"git@github.com:blinkmobile/forms.git","clone_url":"https://github.com/blinkmobile/forms.git","svn_url":"https://github.com/blinkmobile/forms","homepage":null,"size":3223,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"blinkmobile:develop","ref":"develop","sha":"8d5c11c575e5f3d01004ee5557d1206c5a5855f4","user":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars.githubusercontent.com/u/2390706?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":38464432,"name":"forms","full_name":"blinkmobile/forms","owner":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars.githubusercontent.com/u/2390706?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blinkmobile/forms","description":"execute a definition, creating Models and Views to capture data from users","fork":false,"url":"https://api.github.com/repos/blinkmobile/forms","forks_url":"https://api.github.com/repos/blinkmobile/forms/forks","keys_url":"https://api.github.com/repos/blinkmobile/forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blinkmobile/forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blinkmobile/forms/teams","hooks_url":"https://api.github.com/repos/blinkmobile/forms/hooks","issue_events_url":"https://api.github.com/repos/blinkmobile/forms/issues/events{/number}","events_url":"https://api.github.com/repos/blinkmobile/forms/events","assignees_url":"https://api.github.com/repos/blinkmobile/forms/assignees{/user}","branches_url":"https://api.github.com/repos/blinkmobile/forms/branches{/branch}","tags_url":"https://api.github.com/repos/blinkmobile/forms/tags","blobs_url":"https://api.github.com/repos/blinkmobile/forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blinkmobile/forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blinkmobile/forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/blinkmobile/forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blinkmobile/forms/statuses/{sha}","languages_url":"https://api.github.com/repos/blinkmobile/forms/languages","stargazers_url":"https://api.github.com/repos/blinkmobile/forms/stargazers","contributors_url":"https://api.github.com/repos/blinkmobile/forms/contributors","subscribers_url":"https://api.github.com/repos/blinkmobile/forms/subscribers","subscription_url":"https://api.github.com/repos/blinkmobile/forms/subscription","commits_url":"https://api.github.com/repos/blinkmobile/forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/blinkmobile/forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/blinkmobile/forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/blinkmobile/forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/blinkmobile/forms/contents/{+path}","compare_url":"https://api.github.com/repos/blinkmobile/forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blinkmobile/forms/merges","archive_url":"https://api.github.com/repos/blinkmobile/forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blinkmobile/forms/downloads","issues_url":"https://api.github.com/repos/blinkmobile/forms/issues{/number}","pulls_url":"https://api.github.com/repos/blinkmobile/forms/pulls{/number}","milestones_url":"https://api.github.com/repos/blinkmobile/forms/milestones{/number}","notifications_url":"https://api.github.com/repos/blinkmobile/forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blinkmobile/forms/labels{/name}","releases_url":"https://api.github.com/repos/blinkmobile/forms/releases{/id}","created_at":"2015-07-03T01:05:11Z","updated_at":"2015-07-03T01:07:51Z","pushed_at":"2015-08-20T06:23:14Z","git_url":"git://github.com/blinkmobile/forms.git","ssh_url":"git@github.com:blinkmobile/forms.git","clone_url":"https://github.com/blinkmobile/forms.git","svn_url":"https://github.com/blinkmobile/forms","homepage":null,"size":3223,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/blinkmobile/forms/pulls/27"},"html":{"href":"https://github.com/blinkmobile/forms/pull/27"},"issue":{"href":"https://api.github.com/repos/blinkmobile/forms/issues/27"},"comments":{"href":"https://api.github.com/repos/blinkmobile/forms/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/blinkmobile/forms/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/blinkmobile/forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blinkmobile/forms/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/blinkmobile/forms/statuses/908ae5a337dd0362743c8b4d3ed7ffafbf086b94"}}}}