{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/37413384","id":37413384,"diff_hunk":"@@ -77,7 +78,7 @@ def sparse_center_data(X, y, fit_intercept, normalize=False):\n     return X, y, X_mean, y_mean, X_std\n \n \n-def center_data(X, y, fit_intercept, normalize=False, copy=True,\n+def  center_data(X, y, fit_intercept, normalize=False, copy=True,","path":"sklearn/linear_model/base.py","position":13,"original_position":13,"commit_id":"77b70122a5b14aa9d2688cdff450a23aa5f4411e","original_commit_id":"77b70122a5b14aa9d2688cdff450a23aa5f4411e","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"oups. Extra space","created_at":"2015-08-19T13:26:23Z","updated_at":"2015-08-19T13:26:23Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5133#discussion_r37413384","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/37413384"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5133#discussion_r37413384"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133","id":42688310,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5133","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5133.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5133.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5133","number":5133,"state":"open","locked":false,"title":"[MRG+1] Removing repeated input checking in Lasso and DictLearning","user":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"body":"I use :\r\n- a `check_input` flag in `coordinate_descent.enet_path`, that is set to `False` when called from `ElasticNet.fit`\r\n - a `check_input` flag in `coordinate_descent.ElasticNet.fit`, that is set to `False` when called from `sparse_encode`\r\n\r\nI changed the condition for overriding provided Gram Matrix in `linear_model.base._pre_fit`, in order not to do a pass on data when fit_intercept and normalize are set to False (in master, we override Gram matrix if we find that X was changed by centering and rescaling, even when these are disabled, which wastes computation).\r\n\r\nI also avoid computing `cov` in `sparse_encode` when using coordiante_descent, as `cov` computation is done within the `Lasso` class.\r\n\r\nOn provided  `plot_online_sparse_pca` example, we gain a factor 2 in performance.","created_at":"2015-08-18T11:34:45Z","updated_at":"2015-08-19T13:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d30c89f17cdc6dce96e1ac073da3f1c4488c9da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5133/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/77b70122a5b14aa9d2688cdff450a23aa5f4411e","head":{"label":"arthurmensch:lasso_perf_checks","ref":"lasso_perf_checks","sha":"77b70122a5b14aa9d2688cdff450a23aa5f4411e","user":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"repo":{"id":36289937,"name":"scikit-learn","full_name":"arthurmensch/scikit-learn","owner":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arthurmensch/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/arthurmensch/scikit-learn","forks_url":"https://api.github.com/repos/arthurmensch/scikit-learn/forks","keys_url":"https://api.github.com/repos/arthurmensch/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arthurmensch/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arthurmensch/scikit-learn/teams","hooks_url":"https://api.github.com/repos/arthurmensch/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/arthurmensch/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/arthurmensch/scikit-learn/events","assignees_url":"https://api.github.com/repos/arthurmensch/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/arthurmensch/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/arthurmensch/scikit-learn/tags","blobs_url":"https://api.github.com/repos/arthurmensch/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arthurmensch/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arthurmensch/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/arthurmensch/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arthurmensch/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/arthurmensch/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/arthurmensch/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/arthurmensch/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/arthurmensch/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/arthurmensch/scikit-learn/subscription","commits_url":"https://api.github.com/repos/arthurmensch/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/arthurmensch/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/arthurmensch/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/arthurmensch/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/arthurmensch/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/arthurmensch/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arthurmensch/scikit-learn/merges","archive_url":"https://api.github.com/repos/arthurmensch/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arthurmensch/scikit-learn/downloads","issues_url":"https://api.github.com/repos/arthurmensch/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/arthurmensch/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/arthurmensch/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/arthurmensch/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arthurmensch/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/arthurmensch/scikit-learn/releases{/id}","created_at":"2015-05-26T10:53:11Z","updated_at":"2015-05-26T10:53:18Z","pushed_at":"2015-08-19T12:58:03Z","git_url":"git://github.com/arthurmensch/scikit-learn.git","ssh_url":"git@github.com:arthurmensch/scikit-learn.git","clone_url":"https://github.com/arthurmensch/scikit-learn.git","svn_url":"https://github.com/arthurmensch/scikit-learn","homepage":"http://scikit-learn.org","size":65410,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"89ddbe26a7595e3a8643e31661eb51b90b77f49a","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-08-19T13:01:50Z","pushed_at":"2015-08-19T12:58:06Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":131194,"stargazers_count":7220,"watchers_count":7220,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4264,"mirror_url":null,"open_issues_count":766,"forks":4264,"open_issues":766,"watchers":7220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5133"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5133"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5133/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5133/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/77b70122a5b14aa9d2688cdff450a23aa5f4411e"}}}}