{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/1158","labels_url":"https://api.github.com/repos/facebook/osquery/issues/1158/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/1158/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/1158/events","html_url":"https://github.com/facebook/osquery/pull/1158","id":80016217,"number":1158,"title":"TLS/Enroll plugin workflow optimizations","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/osquery/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/osquery/labels/ready%20for%20review","name":"ready for review","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-24T01:54:31Z","updated_at":"2015-05-26T16:42:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/1158","html_url":"https://github.com/facebook/osquery/pull/1158","diff_url":"https://github.com/facebook/osquery/pull/1158.diff","patch_url":"https://github.com/facebook/osquery/pull/1158.patch"},"body":"A work in progress stressing the config, enrollment, and eventually logging TLS-based plugins through integration testing.\r\n\r\n1. Move RocksDB/Internal-Query away from the SDK. There is still a dependency from EventSubscribers on the RocksDB API.\r\n2. Use a \"database\" registry to represent calls to the internal storage representation. In every instance this will remain RocksDB.\r\n3. Prefer to optimize for size. I've tried including link time optimizations and it does save near a half-MB of output but it may have unknown run-time impacts. Anecdotal, I've seen publisher-tests failing (so for now, NO `-flto` please).\r\n4. On some linux systems librt is provided in static-compilation form. We do not want to link librt statically."},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/105597911","html_url":"https://github.com/facebook/osquery/pull/1158#issuecomment-105597911","issue_url":"https://api.github.com/repos/facebook/osquery/issues/1158","id":105597911,"user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T16:42:14Z","updated_at":"2015-05-26T16:42:14Z","body":"ok to test"}}