{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/22650791","id":22650791,"diff_hunk":"@@ -1429,7 +1441,10 @@ Generating URLs with Query Strings\n The ``generate`` method takes an array of wildcard values to generate the URI.\n But if you pass extra ones, they will be added to the URI as a query string::\n \n-    $this->get('router')->generate('blog', array('page' => 2, 'category' => 'Symfony'));\n+    $this->get('router')->generate('blog', array(\n+        'page' => 2,\n+        'category' => 'Symfony'","path":"book/routing.rst","position":106,"original_position":106,"commit_id":"ddf0bc9f82fa8f01f53fc7ca229101ed40d632f2","original_commit_id":"ddf0bc9f82fa8f01f53fc7ca229101ed40d632f2","user":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"body":"Crap, missed the comma, losing my sharpness I guess :D\r\n\r\nYea, usually docs have the trailing comma and as contribution docs has a section about having trailing comma, in my opinion it's a good idea to follow that rule in docs also.","created_at":"2015-01-08T13:17:48Z","updated_at":"2015-01-08T13:17:48Z","html_url":"https://github.com/symfony/symfony-docs/pull/4760#discussion_r22650791","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/22650791"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4760#discussion_r22650791"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760","id":26795793,"html_url":"https://github.com/symfony/symfony-docs/pull/4760","diff_url":"https://github.com/symfony/symfony-docs/pull/4760.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4760.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4760","number":4760,"state":"closed","locked":false,"title":"Update routing.rst","user":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | yes\r\n| New docs?     | no\r\n| Applies to    | 2.3\r\n| Fixed tickets |","created_at":"2015-01-04T14:42:25Z","updated_at":"2015-01-08T13:17:48Z","closed_at":"2015-01-08T12:13:53Z","merged_at":"2015-01-08T12:13:53Z","merge_commit_sha":"138bd4d88ca9e1fa9f3391e0901ed1b7ac1e06c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4760/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/ddf0bc9f82fa8f01f53fc7ca229101ed40d632f2","head":{"label":"ifdattic:patch-2","ref":"patch-2","sha":"ddf0bc9f82fa8f01f53fc7ca229101ed40d632f2","user":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"repo":{"id":28569056,"name":"symfony-docs","full_name":"ifdattic/symfony-docs","owner":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifdattic/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/ifdattic/symfony-docs","forks_url":"https://api.github.com/repos/ifdattic/symfony-docs/forks","keys_url":"https://api.github.com/repos/ifdattic/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifdattic/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifdattic/symfony-docs/teams","hooks_url":"https://api.github.com/repos/ifdattic/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/ifdattic/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/ifdattic/symfony-docs/events","assignees_url":"https://api.github.com/repos/ifdattic/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/ifdattic/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/ifdattic/symfony-docs/tags","blobs_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifdattic/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ifdattic/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/ifdattic/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/ifdattic/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/ifdattic/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/ifdattic/symfony-docs/subscription","commits_url":"https://api.github.com/repos/ifdattic/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifdattic/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifdattic/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/ifdattic/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/ifdattic/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifdattic/symfony-docs/merges","archive_url":"https://api.github.com/repos/ifdattic/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifdattic/symfony-docs/downloads","issues_url":"https://api.github.com/repos/ifdattic/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/ifdattic/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ifdattic/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ifdattic/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifdattic/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/ifdattic/symfony-docs/releases{/id}","created_at":"2014-12-28T18:58:06Z","updated_at":"2014-12-28T18:58:09Z","pushed_at":"2015-01-08T11:03:57Z","git_url":"git://github.com/ifdattic/symfony-docs.git","ssh_url":"git@github.com:ifdattic/symfony-docs.git","clone_url":"https://github.com/ifdattic/symfony-docs.git","svn_url":"https://github.com/ifdattic/symfony-docs","homepage":"http://symfony.com/doc/current/","size":25064,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"050722520fef04d96335f2d28219bf7465e29d2b","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2015-01-08T12:19:47Z","pushed_at":"2015-01-08T12:19:46Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":51914,"stargazers_count":944,"watchers_count":944,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1638,"mirror_url":null,"open_issues_count":258,"forks":1638,"open_issues":258,"watchers":944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4760"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4760"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4760/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4760/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/ddf0bc9f82fa8f01f53fc7ca229101ed40d632f2"}}}}