{"action":"created","issue":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/509","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/509/labels{/name}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/509/comments","events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/509/events","html_url":"https://github.com/opensim-org/opensim-core/pull/509","id":89890835,"number":509,"title":"DataTable Class (Review round 2)","user":{"login":"klshrinidhi","id":1181669,"avatar_url":"https://avatars.githubusercontent.com/u/1181669?v=3","gravatar_id":"","url":"https://api.github.com/users/klshrinidhi","html_url":"https://github.com/klshrinidhi","followers_url":"https://api.github.com/users/klshrinidhi/followers","following_url":"https://api.github.com/users/klshrinidhi/following{/other_user}","gists_url":"https://api.github.com/users/klshrinidhi/gists{/gist_id}","starred_url":"https://api.github.com/users/klshrinidhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshrinidhi/subscriptions","organizations_url":"https://api.github.com/users/klshrinidhi/orgs","repos_url":"https://api.github.com/users/klshrinidhi/repos","events_url":"https://api.github.com/users/klshrinidhi/events{/privacy}","received_events_url":"https://api.github.com/users/klshrinidhi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-21T09:55:37Z","updated_at":"2015-06-23T00:30:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/509","html_url":"https://github.com/opensim-org/opensim-core/pull/509","diff_url":"https://github.com/opensim-org/opensim-core/pull/509.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/509.patch"},"body":"Files to review:\r\n* OpenSim/Common/DataTable.h\r\n* OpenSim/Examples/DataTable/example.cpp\r\n* OpenSim/Common/Test/DataTable.cpp\r\n\r\nI have implemented following based on review in #499 :\r\n* Add member functions to retrieve matrix view from DataTable.\r\n* Fix typo.\r\n* Change indent size from 2 spaces to 4 spaces.\r\n* Change name of columnExists() to hasColumn().\r\n* Remove \"Type\" suffix from type aliases.\r\n* Change parameter names from \"ndir\" to \"numEntries\" and \"dir\" to \"dim\". \r\n* Add resize operation to DataTable.\r\n* Add an assert to make sure the number is 32 bits.\r\n* Change occurrences of \"col\" to \"column\" in interface of DataTable.\r\n* Change name of metaDataSize() to getMetaDataSize().\r\n* Change name of metaDataExists() to hasMetaData().\r\n* Change name of rmvMetaData() to removeMetaData().\r\n* Remove function call updAsMatrix() in the functions to concatenate two DataTables.\r\n* Change name of getAsMatrix to copyAsMatrix.\r\n* Change raw pointer in metadata to a smart pointer with clone on copy semantics.\r\n* Change function parameter names to look like function names.\r\n* Use equality operator to compare input iterator.\r\n* Group methods into categories for Doxygen documentation.\r\n* Change name of insertColLabel functions to setColLabel.\r\n* Change the name of rbind<> and cbind<> functions to add<>ByRow and add<>ByCol.\r\n* Split the exception InvalidEntry into -- NotEnoughElements, NumberOfColsMismatch, NumberOfRowsMismatch, InvalidEntry. \r\n* Change names of constants to CamelCase. Change enums member names to CamelCase.\r\n* Remove default constructor syntax using empty braces \"{}\".\r\n* Replace types specified using decltype with full type name. This make it easier/explicit to read examples.\r\n* Change names of all the data members of DataTable to have a prefix \"m_\".\r\n* All the exceptions thrown should now produce more info on what exactly went wrong. Eg. what was expected in input and what was received.\r\n* Derive all exceptions from OpenSim::Exception..\r\n* Add virtual member functions to AbstractDataTable to provide access to column labels.\r\n* Change comments from /// to /**.... */.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/opensim-org/opensim-core/509)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/114312030","html_url":"https://github.com/opensim-org/opensim-core/pull/509#issuecomment-114312030","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/509","id":114312030,"user":{"login":"chrisdembia","id":846001,"avatar_url":"https://avatars.githubusercontent.com/u/846001?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdembia","html_url":"https://github.com/chrisdembia","followers_url":"https://api.github.com/users/chrisdembia/followers","following_url":"https://api.github.com/users/chrisdembia/following{/other_user}","gists_url":"https://api.github.com/users/chrisdembia/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdembia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdembia/subscriptions","organizations_url":"https://api.github.com/users/chrisdembia/orgs","repos_url":"https://api.github.com/users/chrisdembia/repos","events_url":"https://api.github.com/users/chrisdembia/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdembia/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T00:30:36Z","updated_at":"2015-06-23T00:30:36Z","body":"> Reviewable is not giving me code highlighting on header files. The support guy said its a \"bug in language auto detect\" and I should give him \"10 minutes to push a fix\" (!).\r\n\r\nAre we seriously the first C++ project trying to use it?"}}