{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/16171","labels_url":"https://api.github.com/repos/docker/docker/issues/16171/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/16171/comments","events_url":"https://api.github.com/repos/docker/docker/issues/16171/events","html_url":"https://github.com/docker/docker/pull/16171","id":105535675,"number":16171,"title":"Golint only on changed files","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-09T07:28:30Z","updated_at":"2015-09-09T10:12:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16171","html_url":"https://github.com/docker/docker/pull/16171","diff_url":"https://github.com/docker/docker/pull/16171.diff","patch_url":"https://github.com/docker/docker/pull/16171.patch"},"body":"Just a real quick follow-up to #16096, based on @runcom  [comment](https://github.com/docker/docker/pull/16096#discussion_r38878781), now that we know for a fact that the source is `linted`, **we might want to run `golint` only on changed files**. 🐙\r\n\r\nThis updates `validate-lint` to used `validate_diff` command (this makes the bash code even smaller and cleaner :stuck_out_tongue_closed_eyes:).\r\n\r\n🐹 I've put some `lint` errors to make sure and prove that it works :smile_cat:.\r\n\r\nGiven the follwing diff…\r\n```diff\r\ndiff --git a/cliconfig/config.go b/cliconfig/config.go\r\nindex 4e289a7..89ba0ea 100644\r\n--- a/cliconfig/config.go\r\n+++ b/cliconfig/config.go\r\n@@ -1,3 +1,4 @@\r\n+// Something is wrong here too\r\n package cliconfig\r\n \r\n import (\r\n@@ -35,6 +36,9 @@ func init() {\r\n        }\r\n }\r\n \r\n+func Blabla() {\r\n+}\r\n+\r\n // ConfigDir returns the directory the configuration file is stored in\r\n func ConfigDir() string {\r\n        return configDir\r\n```\r\n\r\n… the output is as follow:\r\n\r\n```bash\r\n---> Making bundle: validate-lint (in bundles/1.9.0-dev/validate-lint)\r\nErrors from golint:\r\ncliconfig/config.go:1:1: package comment should be of the form \"Package cliconfig ...\"\r\ncliconfig/config.go:39:1: exported function Blabla should have comment or be unexported\r\n```\r\n\r\n🐸\r\n\r\n/cc @icecrime @jfrazelle @tianon \r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/138864489","html_url":"https://github.com/docker/docker/pull/16171#issuecomment-138864489","issue_url":"https://api.github.com/repos/docker/docker/issues/16171","id":138864489,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T10:12:58Z","updated_at":"2015-09-09T10:12:58Z","body":"Let's see if there's interest in adding such option; I've never done a release, so not sure if it's useful :smile:"}}