{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/16","id":47108302,"html_url":"https://github.com/QuickenLoans/MessageRouter/pull/16","diff_url":"https://github.com/QuickenLoans/MessageRouter/pull/16.diff","patch_url":"https://github.com/QuickenLoans/MessageRouter/pull/16.patch","issue_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues/16","number":16,"state":"closed","locked":false,"title":"v2 Refactor","user":{"login":"pblasucci","id":476772,"avatar_url":"https://avatars.githubusercontent.com/u/476772?v=3","gravatar_id":"","url":"https://api.github.com/users/pblasucci","html_url":"https://github.com/pblasucci","followers_url":"https://api.github.com/users/pblasucci/followers","following_url":"https://api.github.com/users/pblasucci/following{/other_user}","gists_url":"https://api.github.com/users/pblasucci/gists{/gist_id}","starred_url":"https://api.github.com/users/pblasucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pblasucci/subscriptions","organizations_url":"https://api.github.com/users/pblasucci/orgs","repos_url":"https://api.github.com/users/pblasucci/repos","events_url":"https://api.github.com/users/pblasucci/events{/privacy}","received_events_url":"https://api.github.com/users/pblasucci/received_events","type":"User","site_admin":false},"body":"This is a pretty substantial overhaul. The major changes are:\r\n\r\n1. Reduced source to two solutions (this eliminates unused and redundant types, as well as simplifies hosting the message router)\r\n    1. `MessageRouter` contains the actual implementation of message router and reflection routines private to the implementation of message router.\r\n    2. `MessageRouter.Common` contains the core interfaces and general purpose reflection routines\r\n2. Reworked `IHandleCommand` and `IHandleEvent` to support cooperative cancellation\r\n3. Heavily reworked `MessageRouter`:\r\n    1. Top-level supervising agent attempts to pass errors to a global error handler (specified on construction)\r\n    2. Intermediate (never terminating) supervising agents have been removed\r\n    3. Each message-executing agent exploits the task-based nature of `IHandle*` to provide better concurrency\r\n    4. Success/failure callback invocation is now managed by `MessageRouter` rather than in the handlers\r\n    5. Errors from all handlers for a given message are aggregated and reported to the failure callback once, after all handlers have run\r\n    6. Used type system to explicitly codify rules and results around dynamically loading/invoking message handlers\r\n    7. Improved type-safety of dynamic loading by introducing quotations\r\n    8. Relegated CLR delegates (`Action`,`Func`) to interface definitions\r\n4. Reflection API in `MessageRouter.Common` has been simplified and focused for the task of hosting the message router and associated messages and handlers\r\n5. Extended testing to cover C# and VB\r\n6. Switched from unlicense to Apache license\r\n7. Updated version of ProjectScaffold (and related tools)\r\n8. Initial work on documentation\r\n\r\nThe vast majority of this patch is rock-solid and ready for use. However, there are still a few loose ends:\r\n\r\n+ Sufficiently better documentation is needed\r\n+ NuGet package creation needs reworking\r\n","created_at":"2015-10-08T03:32:27Z","updated_at":"2015-10-09T15:53:58Z","closed_at":"2015-10-09T15:53:58Z","merged_at":"2015-10-09T15:53:58Z","merge_commit_sha":"e6aa9f8c5e6628a8b7491e19b63f12aa26af6c6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/16/commits","review_comments_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/16/comments","review_comment_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues/16/comments","statuses_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/statuses/16d2d85f68ab3a2dbdd715d6100872082d3122fd","head":{"label":"pblasucci:new_scaffold","ref":"new_scaffold","sha":"16d2d85f68ab3a2dbdd715d6100872082d3122fd","user":{"login":"pblasucci","id":476772,"avatar_url":"https://avatars.githubusercontent.com/u/476772?v=3","gravatar_id":"","url":"https://api.github.com/users/pblasucci","html_url":"https://github.com/pblasucci","followers_url":"https://api.github.com/users/pblasucci/followers","following_url":"https://api.github.com/users/pblasucci/following{/other_user}","gists_url":"https://api.github.com/users/pblasucci/gists{/gist_id}","starred_url":"https://api.github.com/users/pblasucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pblasucci/subscriptions","organizations_url":"https://api.github.com/users/pblasucci/orgs","repos_url":"https://api.github.com/users/pblasucci/repos","events_url":"https://api.github.com/users/pblasucci/events{/privacy}","received_events_url":"https://api.github.com/users/pblasucci/received_events","type":"User","site_admin":false},"repo":{"id":30944413,"name":"MessageRouter","full_name":"pblasucci/MessageRouter","owner":{"login":"pblasucci","id":476772,"avatar_url":"https://avatars.githubusercontent.com/u/476772?v=3","gravatar_id":"","url":"https://api.github.com/users/pblasucci","html_url":"https://github.com/pblasucci","followers_url":"https://api.github.com/users/pblasucci/followers","following_url":"https://api.github.com/users/pblasucci/following{/other_user}","gists_url":"https://api.github.com/users/pblasucci/gists{/gist_id}","starred_url":"https://api.github.com/users/pblasucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pblasucci/subscriptions","organizations_url":"https://api.github.com/users/pblasucci/orgs","repos_url":"https://api.github.com/users/pblasucci/repos","events_url":"https://api.github.com/users/pblasucci/events{/privacy}","received_events_url":"https://api.github.com/users/pblasucci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pblasucci/MessageRouter","description":"A CQRS (Event-driven) message router in F#","fork":true,"url":"https://api.github.com/repos/pblasucci/MessageRouter","forks_url":"https://api.github.com/repos/pblasucci/MessageRouter/forks","keys_url":"https://api.github.com/repos/pblasucci/MessageRouter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pblasucci/MessageRouter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pblasucci/MessageRouter/teams","hooks_url":"https://api.github.com/repos/pblasucci/MessageRouter/hooks","issue_events_url":"https://api.github.com/repos/pblasucci/MessageRouter/issues/events{/number}","events_url":"https://api.github.com/repos/pblasucci/MessageRouter/events","assignees_url":"https://api.github.com/repos/pblasucci/MessageRouter/assignees{/user}","branches_url":"https://api.github.com/repos/pblasucci/MessageRouter/branches{/branch}","tags_url":"https://api.github.com/repos/pblasucci/MessageRouter/tags","blobs_url":"https://api.github.com/repos/pblasucci/MessageRouter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pblasucci/MessageRouter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pblasucci/MessageRouter/git/refs{/sha}","trees_url":"https://api.github.com/repos/pblasucci/MessageRouter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pblasucci/MessageRouter/statuses/{sha}","languages_url":"https://api.github.com/repos/pblasucci/MessageRouter/languages","stargazers_url":"https://api.github.com/repos/pblasucci/MessageRouter/stargazers","contributors_url":"https://api.github.com/repos/pblasucci/MessageRouter/contributors","subscribers_url":"https://api.github.com/repos/pblasucci/MessageRouter/subscribers","subscription_url":"https://api.github.com/repos/pblasucci/MessageRouter/subscription","commits_url":"https://api.github.com/repos/pblasucci/MessageRouter/commits{/sha}","git_commits_url":"https://api.github.com/repos/pblasucci/MessageRouter/git/commits{/sha}","comments_url":"https://api.github.com/repos/pblasucci/MessageRouter/comments{/number}","issue_comment_url":"https://api.github.com/repos/pblasucci/MessageRouter/issues/comments{/number}","contents_url":"https://api.github.com/repos/pblasucci/MessageRouter/contents/{+path}","compare_url":"https://api.github.com/repos/pblasucci/MessageRouter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pblasucci/MessageRouter/merges","archive_url":"https://api.github.com/repos/pblasucci/MessageRouter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pblasucci/MessageRouter/downloads","issues_url":"https://api.github.com/repos/pblasucci/MessageRouter/issues{/number}","pulls_url":"https://api.github.com/repos/pblasucci/MessageRouter/pulls{/number}","milestones_url":"https://api.github.com/repos/pblasucci/MessageRouter/milestones{/number}","notifications_url":"https://api.github.com/repos/pblasucci/MessageRouter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pblasucci/MessageRouter/labels{/name}","releases_url":"https://api.github.com/repos/pblasucci/MessageRouter/releases{/id}","created_at":"2015-02-17T23:54:41Z","updated_at":"2015-02-17T23:54:42Z","pushed_at":"2015-10-08T03:03:43Z","git_url":"git://github.com/pblasucci/MessageRouter.git","ssh_url":"git@github.com:pblasucci/MessageRouter.git","clone_url":"https://github.com/pblasucci/MessageRouter.git","svn_url":"https://github.com/pblasucci/MessageRouter","homepage":"http://quickenloans.github.io/MessageRouter/","size":1530,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QuickenLoans:master","ref":"master","sha":"c262f6372c60d9140ce26c5661bb28e1897647ba","user":{"login":"QuickenLoans","id":1609849,"avatar_url":"https://avatars.githubusercontent.com/u/1609849?v=3","gravatar_id":"","url":"https://api.github.com/users/QuickenLoans","html_url":"https://github.com/QuickenLoans","followers_url":"https://api.github.com/users/QuickenLoans/followers","following_url":"https://api.github.com/users/QuickenLoans/following{/other_user}","gists_url":"https://api.github.com/users/QuickenLoans/gists{/gist_id}","starred_url":"https://api.github.com/users/QuickenLoans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuickenLoans/subscriptions","organizations_url":"https://api.github.com/users/QuickenLoans/orgs","repos_url":"https://api.github.com/users/QuickenLoans/repos","events_url":"https://api.github.com/users/QuickenLoans/events{/privacy}","received_events_url":"https://api.github.com/users/QuickenLoans/received_events","type":"Organization","site_admin":false},"repo":{"id":25660163,"name":"MessageRouter","full_name":"QuickenLoans/MessageRouter","owner":{"login":"QuickenLoans","id":1609849,"avatar_url":"https://avatars.githubusercontent.com/u/1609849?v=3","gravatar_id":"","url":"https://api.github.com/users/QuickenLoans","html_url":"https://github.com/QuickenLoans","followers_url":"https://api.github.com/users/QuickenLoans/followers","following_url":"https://api.github.com/users/QuickenLoans/following{/other_user}","gists_url":"https://api.github.com/users/QuickenLoans/gists{/gist_id}","starred_url":"https://api.github.com/users/QuickenLoans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuickenLoans/subscriptions","organizations_url":"https://api.github.com/users/QuickenLoans/orgs","repos_url":"https://api.github.com/users/QuickenLoans/repos","events_url":"https://api.github.com/users/QuickenLoans/events{/privacy}","received_events_url":"https://api.github.com/users/QuickenLoans/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QuickenLoans/MessageRouter","description":"A CQRS (Event-driven) message router in F#","fork":false,"url":"https://api.github.com/repos/QuickenLoans/MessageRouter","forks_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/forks","keys_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/teams","hooks_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/hooks","issue_events_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues/events{/number}","events_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/events","assignees_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/assignees{/user}","branches_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/branches{/branch}","tags_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/tags","blobs_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/statuses/{sha}","languages_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/languages","stargazers_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/stargazers","contributors_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/contributors","subscribers_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/subscribers","subscription_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/subscription","commits_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/contents/{+path}","compare_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/merges","archive_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/downloads","issues_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues{/number}","pulls_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls{/number}","milestones_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/milestones{/number}","notifications_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/labels{/name}","releases_url":"https://api.github.com/repos/QuickenLoans/MessageRouter/releases{/id}","created_at":"2014-10-23T22:12:00Z","updated_at":"2015-01-23T15:14:24Z","pushed_at":"2015-10-09T15:53:58Z","git_url":"git://github.com/QuickenLoans/MessageRouter.git","ssh_url":"git@github.com:QuickenLoans/MessageRouter.git","clone_url":"https://github.com/QuickenLoans/MessageRouter.git","svn_url":"https://github.com/QuickenLoans/MessageRouter","homepage":"http://quickenloans.github.io/MessageRouter/","size":1519,"stargazers_count":3,"watchers_count":3,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/16"},"html":{"href":"https://github.com/QuickenLoans/MessageRouter/pull/16"},"issue":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues/16"},"comments":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/QuickenLoans/MessageRouter/statuses/16d2d85f68ab3a2dbdd715d6100872082d3122fd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"johnbfair","id":340827,"avatar_url":"https://avatars.githubusercontent.com/u/340827?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbfair","html_url":"https://github.com/johnbfair","followers_url":"https://api.github.com/users/johnbfair/followers","following_url":"https://api.github.com/users/johnbfair/following{/other_user}","gists_url":"https://api.github.com/users/johnbfair/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbfair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbfair/subscriptions","organizations_url":"https://api.github.com/users/johnbfair/orgs","repos_url":"https://api.github.com/users/johnbfair/repos","events_url":"https://api.github.com/users/johnbfair/events{/privacy}","received_events_url":"https://api.github.com/users/johnbfair/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":7,"additions":2865,"deletions":2609,"changed_files":111}}