{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/29418215","id":29418215,"diff_hunk":"@@ -41,7 +42,9 @@\n     /**\n      * Prefix of the packages that should be hidden.\n      */\n-    private List<String> masks;\n+    private List<String> masksClasses;\n+\n+    private List<String> masksResources;","path":"core/src/main/java/hudson/util/MaskingClassLoader.java","position":15,"original_position":15,"commit_id":"7db618e64a8b70514df227dd706566e93a0e112c","original_commit_id":"7db618e64a8b70514df227dd706566e93a0e112c","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"minor: items could be made final","created_at":"2015-04-30T10:23:08Z","updated_at":"2015-04-30T10:23:08Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1598#discussion_r29418215","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/29418215"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1598#discussion_r29418215"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598","id":30760957,"html_url":"https://github.com/jenkinsci/jenkins/pull/1598","diff_url":"https://github.com/jenkinsci/jenkins/pull/1598.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1598.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1598","number":1598,"state":"open","locked":false,"title":"[FIXED JENKINS-27289] Make MaskingClassLoader work on slaves","user":{"login":"liorhson","id":6830400,"avatar_url":"https://avatars.githubusercontent.com/u/6830400?v=3","gravatar_id":"","url":"https://api.github.com/users/liorhson","html_url":"https://github.com/liorhson","followers_url":"https://api.github.com/users/liorhson/followers","following_url":"https://api.github.com/users/liorhson/following{/other_user}","gists_url":"https://api.github.com/users/liorhson/gists{/gist_id}","starred_url":"https://api.github.com/users/liorhson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liorhson/subscriptions","organizations_url":"https://api.github.com/users/liorhson/orgs","repos_url":"https://api.github.com/users/liorhson/repos","events_url":"https://api.github.com/users/liorhson/events{/privacy}","received_events_url":"https://api.github.com/users/liorhson/received_events","type":"User","site_admin":false},"body":"Masking classLoader doesn`t work on remote Slave\r\n\r\nAfter upgrading the Apache **httpClient** to 4.4, I found that other plugins such as Git-Client/Maven-plugin that also uses httpClient with different versions collapses with ours. So After I added the Mask-Classes attribute the problem was gone, but it looks like this isolated environment dose not apply for Slaves.\r\nI found out that in the `RemoteClassLoader` while it tries to find a specific class URL, `Which.classFileUrl(class)` uses the `getResource` method. This method is not override by the `hudson.util.MaskingClassLoader`. So the class comes from the right source under the plugin itself, but the resource URL of the same class can came from other source such as other plugins that contain the same classes.\r\n\r\nLink to Jira: https://issues.jenkins-ci.org/browse/JENKINS-27289","created_at":"2015-03-09T13:44:39Z","updated_at":"2015-04-30T10:23:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62caded97f01cbe0b60e2a512e9f3011a2034eb7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1598/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/7db618e64a8b70514df227dd706566e93a0e112c","head":{"label":"liorhson:JENKINS-27289","ref":"JENKINS-27289","sha":"7db618e64a8b70514df227dd706566e93a0e112c","user":{"login":"liorhson","id":6830400,"avatar_url":"https://avatars.githubusercontent.com/u/6830400?v=3","gravatar_id":"","url":"https://api.github.com/users/liorhson","html_url":"https://github.com/liorhson","followers_url":"https://api.github.com/users/liorhson/followers","following_url":"https://api.github.com/users/liorhson/following{/other_user}","gists_url":"https://api.github.com/users/liorhson/gists{/gist_id}","starred_url":"https://api.github.com/users/liorhson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liorhson/subscriptions","organizations_url":"https://api.github.com/users/liorhson/orgs","repos_url":"https://api.github.com/users/liorhson/repos","events_url":"https://api.github.com/users/liorhson/events{/privacy}","received_events_url":"https://api.github.com/users/liorhson/received_events","type":"User","site_admin":false},"repo":{"id":31895145,"name":"jenkins","full_name":"liorhson/jenkins","owner":{"login":"liorhson","id":6830400,"avatar_url":"https://avatars.githubusercontent.com/u/6830400?v=3","gravatar_id":"","url":"https://api.github.com/users/liorhson","html_url":"https://github.com/liorhson","followers_url":"https://api.github.com/users/liorhson/followers","following_url":"https://api.github.com/users/liorhson/following{/other_user}","gists_url":"https://api.github.com/users/liorhson/gists{/gist_id}","starred_url":"https://api.github.com/users/liorhson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liorhson/subscriptions","organizations_url":"https://api.github.com/users/liorhson/orgs","repos_url":"https://api.github.com/users/liorhson/repos","events_url":"https://api.github.com/users/liorhson/events{/privacy}","received_events_url":"https://api.github.com/users/liorhson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liorhson/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/liorhson/jenkins","forks_url":"https://api.github.com/repos/liorhson/jenkins/forks","keys_url":"https://api.github.com/repos/liorhson/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liorhson/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liorhson/jenkins/teams","hooks_url":"https://api.github.com/repos/liorhson/jenkins/hooks","issue_events_url":"https://api.github.com/repos/liorhson/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/liorhson/jenkins/events","assignees_url":"https://api.github.com/repos/liorhson/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/liorhson/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/liorhson/jenkins/tags","blobs_url":"https://api.github.com/repos/liorhson/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liorhson/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liorhson/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/liorhson/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liorhson/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/liorhson/jenkins/languages","stargazers_url":"https://api.github.com/repos/liorhson/jenkins/stargazers","contributors_url":"https://api.github.com/repos/liorhson/jenkins/contributors","subscribers_url":"https://api.github.com/repos/liorhson/jenkins/subscribers","subscription_url":"https://api.github.com/repos/liorhson/jenkins/subscription","commits_url":"https://api.github.com/repos/liorhson/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/liorhson/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/liorhson/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/liorhson/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/liorhson/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/liorhson/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liorhson/jenkins/merges","archive_url":"https://api.github.com/repos/liorhson/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liorhson/jenkins/downloads","issues_url":"https://api.github.com/repos/liorhson/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/liorhson/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/liorhson/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/liorhson/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liorhson/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/liorhson/jenkins/releases{/id}","created_at":"2015-03-09T11:38:07Z","updated_at":"2015-03-09T12:54:32Z","pushed_at":"2015-03-09T13:37:14Z","git_url":"git://github.com/liorhson/jenkins.git","ssh_url":"git@github.com:liorhson/jenkins.git","clone_url":"https://github.com/liorhson/jenkins.git","svn_url":"https://github.com/liorhson/jenkins","homepage":"http://jenkins-ci.org/","size":82868,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"e9bf4b71cd0b988a0466d024bf78a8e44cc222fe","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-04-30T07:07:18Z","pushed_at":"2015-04-30T00:10:21Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":419730,"stargazers_count":4014,"watchers_count":4014,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1795,"mirror_url":null,"open_issues_count":105,"forks":1795,"open_issues":105,"watchers":4014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1598"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1598"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1598/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1598/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/7db618e64a8b70514df227dd706566e93a0e112c"}}}}