{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/ava/pulls/comments/48388718","id":48388718,"diff_hunk":"@@ -230,33 +251,23 @@ Test.prototype._publicApi = function () {\n \tapi.plan = this.plan.bind(this);\n \n \tfunction skipFn() {\n-\t\tself._assert();\n+\t\tself._assert(Promise.resolve());","path":"lib/test.js","position":108,"original_position":108,"commit_id":"26f6fa9608009093d7d8c1468f03cc4b15bcef52","original_commit_id":"26f6fa9608009093d7d8c1468f03cc4b15bcef52","user":{"login":"jamestalmage","id":4082216,"avatar_url":"https://avatars.githubusercontent.com/u/4082216?v=3","gravatar_id":"","url":"https://api.github.com/users/jamestalmage","html_url":"https://github.com/jamestalmage","followers_url":"https://api.github.com/users/jamestalmage/followers","following_url":"https://api.github.com/users/jamestalmage/following{/other_user}","gists_url":"https://api.github.com/users/jamestalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestalmage/subscriptions","organizations_url":"https://api.github.com/users/jamestalmage/orgs","repos_url":"https://api.github.com/users/jamestalmage/repos","events_url":"https://api.github.com/users/jamestalmage/events{/privacy}","received_events_url":"https://api.github.com/users/jamestalmage/received_events","type":"User","site_admin":false},"body":"Agreed. I wrote this before I saw how you optimized the `onAssertion` callback. You can disregard.","created_at":"2015-12-24T00:16:10Z","updated_at":"2015-12-24T00:16:10Z","html_url":"https://github.com/sindresorhus/ava/pull/360#discussion_r48388718","pull_request_url":"https://api.github.com/repos/sindresorhus/ava/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/comments/48388718"},"html":{"href":"https://github.com/sindresorhus/ava/pull/360#discussion_r48388718"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/ava/pulls/360","id":54507918,"html_url":"https://github.com/sindresorhus/ava/pull/360","diff_url":"https://github.com/sindresorhus/ava/pull/360.diff","patch_url":"https://github.com/sindresorhus/ava/pull/360.patch","issue_url":"https://api.github.com/repos/sindresorhus/ava/issues/360","number":360,"state":"open","locked":false,"title":"Fix promise assertions","user":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"body":"Hi All,\r\n\r\nHere's the fix for #309, It has a good number of tests, but let me know if there's anything I should change.","created_at":"2015-12-23T21:23:07Z","updated_at":"2015-12-24T00:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"102d0d437c1faaddcfd1fdf7924b0e481334f03a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/ava/pulls/360/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/ava/pulls/360/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/ava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/ava/issues/360/comments","statuses_url":"https://api.github.com/repos/sindresorhus/ava/statuses/26f6fa9608009093d7d8c1468f03cc4b15bcef52","head":{"label":"ariporad:fix-promise-assertions","ref":"fix-promise-assertions","sha":"26f6fa9608009093d7d8c1468f03cc4b15bcef52","user":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"repo":{"id":48470372,"name":"ava","full_name":"ariporad/ava","owner":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariporad/ava","description":"Futuristic test runner :rocket:","fork":true,"url":"https://api.github.com/repos/ariporad/ava","forks_url":"https://api.github.com/repos/ariporad/ava/forks","keys_url":"https://api.github.com/repos/ariporad/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariporad/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariporad/ava/teams","hooks_url":"https://api.github.com/repos/ariporad/ava/hooks","issue_events_url":"https://api.github.com/repos/ariporad/ava/issues/events{/number}","events_url":"https://api.github.com/repos/ariporad/ava/events","assignees_url":"https://api.github.com/repos/ariporad/ava/assignees{/user}","branches_url":"https://api.github.com/repos/ariporad/ava/branches{/branch}","tags_url":"https://api.github.com/repos/ariporad/ava/tags","blobs_url":"https://api.github.com/repos/ariporad/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariporad/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariporad/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariporad/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariporad/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/ariporad/ava/languages","stargazers_url":"https://api.github.com/repos/ariporad/ava/stargazers","contributors_url":"https://api.github.com/repos/ariporad/ava/contributors","subscribers_url":"https://api.github.com/repos/ariporad/ava/subscribers","subscription_url":"https://api.github.com/repos/ariporad/ava/subscription","commits_url":"https://api.github.com/repos/ariporad/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariporad/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariporad/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariporad/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariporad/ava/contents/{+path}","compare_url":"https://api.github.com/repos/ariporad/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariporad/ava/merges","archive_url":"https://api.github.com/repos/ariporad/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariporad/ava/downloads","issues_url":"https://api.github.com/repos/ariporad/ava/issues{/number}","pulls_url":"https://api.github.com/repos/ariporad/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/ariporad/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/ariporad/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariporad/ava/labels{/name}","releases_url":"https://api.github.com/repos/ariporad/ava/releases{/id}","created_at":"2015-12-23T05:12:46Z","updated_at":"2015-12-23T05:12:48Z","pushed_at":"2015-12-24T00:14:47Z","git_url":"git://github.com/ariporad/ava.git","ssh_url":"git@github.com:ariporad/ava.git","clone_url":"https://github.com/ariporad/ava.git","svn_url":"https://github.com/ariporad/ava","homepage":"","size":3022,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"65ae07c76b2a5927e6bcc00630a691c98f6e7c46","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":26820798,"name":"ava","full_name":"sindresorhus/ava","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/ava","description":"Futuristic test runner :rocket:","fork":false,"url":"https://api.github.com/repos/sindresorhus/ava","forks_url":"https://api.github.com/repos/sindresorhus/ava/forks","keys_url":"https://api.github.com/repos/sindresorhus/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/ava/teams","hooks_url":"https://api.github.com/repos/sindresorhus/ava/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/ava/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/ava/events","assignees_url":"https://api.github.com/repos/sindresorhus/ava/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/ava/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/ava/tags","blobs_url":"https://api.github.com/repos/sindresorhus/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/ava/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/ava/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/ava/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/ava/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/ava/subscription","commits_url":"https://api.github.com/repos/sindresorhus/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/ava/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/ava/merges","archive_url":"https://api.github.com/repos/sindresorhus/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/ava/downloads","issues_url":"https://api.github.com/repos/sindresorhus/ava/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/ava/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/ava/releases{/id}","created_at":"2014-11-18T17:20:26Z","updated_at":"2015-12-23T11:22:17Z","pushed_at":"2015-12-23T22:42:27Z","git_url":"git://github.com/sindresorhus/ava.git","ssh_url":"git@github.com:sindresorhus/ava.git","clone_url":"https://github.com/sindresorhus/ava.git","svn_url":"https://github.com/sindresorhus/ava","homepage":"","size":3192,"stargazers_count":2053,"watchers_count":2053,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":69,"forks":66,"open_issues":69,"watchers":2053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/360"},"html":{"href":"https://github.com/sindresorhus/ava/pull/360"},"issue":{"href":"https://api.github.com/repos/sindresorhus/ava/issues/360"},"comments":{"href":"https://api.github.com/repos/sindresorhus/ava/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/ava/statuses/26f6fa9608009093d7d8c1468f03cc4b15bcef52"}}}}