{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/24352688","id":24352688,"diff_hunk":"@@ -410,7 +485,7 @@ def install_binfile(from, op_file, target)\n # Change directory into the puppet root so we don't get the wrong files for install.\n FileUtils.cd File.dirname(__FILE__) do\n   # Set these values to what you want installed.\n-  configs = glob(%w{conf/auth.conf})\n+  configs = glob(%w{conf/auth.conf conf/puppet.conf})","path":"install.rb","position":153,"original_position":153,"commit_id":"0e510e5e56c057076736f53d647a6bf419eedb98","original_commit_id":"0e510e5e56c057076736f53d647a6bf419eedb98","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":"This breaks Windows","created_at":"2015-02-09T18:42:20Z","updated_at":"2015-02-09T18:42:20Z","html_url":"https://github.com/puppetlabs/puppet/pull/3556#discussion_r24352688","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/24352688"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3556#discussion_r24352688"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556","id":28511532,"html_url":"https://github.com/puppetlabs/puppet/pull/3556","diff_url":"https://github.com/puppetlabs/puppet/pull/3556.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3556.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3556","number":3556,"state":"open","locked":false,"title":"(DO NOT MERGE) (PUP-3809) Separate code and config directories","user":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"body":"This PR introduces the new $puppetdir directory setting that will be the parent of the existing $confdir and the new $codedir.\r\n\r\nThe following settings have moved out from under $confdir entirely and are now under $codedir:\r\n* $environmentpath (note that manifests and modules are rooted at this, so they've effectively moved)\r\n* $hiera_config\r\n* $basemodulepath\r\n\r\nIn addition, the $ssldir has been moved out from under $confdir and is now directly under $puppetdir.\r\n\r\nThe directory structure now looks like:\r\n```bash\r\n$puppetdir\r\n  $codedir\r\n  $confdir\r\n  $ssldir\r\n```\r\n\r\nThese changes pass spec tests, but I have not ran acceptance tests yet.\r\n\r\nHappy to squash commits if desired.\r\n  ","created_at":"2015-02-02T23:07:47Z","updated_at":"2015-02-09T18:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d5a7ead33a4e3087c557612a53041216cefdef1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3556/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/0e510e5e56c057076736f53d647a6bf419eedb98","head":{"label":"nwolfe:pup3809-separate-code-conf-dirs","ref":"pup3809-separate-code-conf-dirs","sha":"0e510e5e56c057076736f53d647a6bf419eedb98","user":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"repo":{"id":19999538,"name":"puppet","full_name":"nwolfe/puppet","owner":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nwolfe/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/nwolfe/puppet","forks_url":"https://api.github.com/repos/nwolfe/puppet/forks","keys_url":"https://api.github.com/repos/nwolfe/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwolfe/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwolfe/puppet/teams","hooks_url":"https://api.github.com/repos/nwolfe/puppet/hooks","issue_events_url":"https://api.github.com/repos/nwolfe/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/nwolfe/puppet/events","assignees_url":"https://api.github.com/repos/nwolfe/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/nwolfe/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/nwolfe/puppet/tags","blobs_url":"https://api.github.com/repos/nwolfe/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwolfe/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwolfe/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwolfe/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwolfe/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/nwolfe/puppet/languages","stargazers_url":"https://api.github.com/repos/nwolfe/puppet/stargazers","contributors_url":"https://api.github.com/repos/nwolfe/puppet/contributors","subscribers_url":"https://api.github.com/repos/nwolfe/puppet/subscribers","subscription_url":"https://api.github.com/repos/nwolfe/puppet/subscription","commits_url":"https://api.github.com/repos/nwolfe/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwolfe/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwolfe/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwolfe/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/nwolfe/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/nwolfe/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwolfe/puppet/merges","archive_url":"https://api.github.com/repos/nwolfe/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwolfe/puppet/downloads","issues_url":"https://api.github.com/repos/nwolfe/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/nwolfe/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/nwolfe/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/nwolfe/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwolfe/puppet/labels{/name}","releases_url":"https://api.github.com/repos/nwolfe/puppet/releases{/id}","created_at":"2014-05-20T22:16:15Z","updated_at":"2014-06-09T22:53:33Z","pushed_at":"2015-02-09T18:36:01Z","git_url":"git://github.com/nwolfe/puppet.git","ssh_url":"git@github.com:nwolfe/puppet.git","clone_url":"https://github.com/nwolfe/puppet.git","svn_url":"https://github.com/nwolfe/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":45413,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"306b3a701983777e045d601cedcf6e5a5b7ce9ac","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-02-09T13:46:44Z","pushed_at":"2015-02-09T18:33:55Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":106324,"stargazers_count":2952,"watchers_count":2952,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1262,"mirror_url":null,"open_issues_count":26,"forks":1262,"open_issues":26,"watchers":2952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3556"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3556"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3556/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3556/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/0e510e5e56c057076736f53d647a6bf419eedb98"}}}}