{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/35078428","id":35078428,"diff_hunk":"@@ -187,6 +187,64 @@ case class Like(left: Expression, right: Expression)\n   override def matches(regex: Pattern, str: String): Boolean = regex.matcher(str).matches()\n \n   override def toString: String = s\"$left LIKE $right\"\n+\n+  override protected def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {\n+    val patternClass = classOf[Pattern].getName\n+\n+    val literalRight: String = right match {\n+      case x @ Literal(value: String, StringType) => escape(value)\n+      case _ => null\n+    }\n+\n+    val leftGen = left.gen(ctx)\n+    val rightGen = right.gen(ctx)\n+\n+    val patternCode =\n+      if (literalRight != null) {\n+        s\"${patternClass} pattern = $patternClass.compile($literalRight);\"\n+      } else {\n+        s\"\"\"\n+          StringBuilder regex = new StringBuilder(\"(?s)\");\n+          for (int idx = 1; idx < rightStr.length(); idx++) {\n+            char prev = rightStr.charAt(idx - 1);\n+            char curr = rightStr.charAt(idx);\n+            if (prev == '\\\\\\\\') {\n+              if (curr == '_') {\n+                regex.append(\"_\");\n+              } else if (curr == '%') {\n+                regex.append(\"%\");\n+              } else {\n+                regex.append(${patternClass}.quote(\"\\\\\\\\\" + curr));\n+              }\n+            } else {\n+              if (curr != '\\\\\\\\') {\n+                if (curr == '_') {\n+                  regex.append(\".\");\n+                } else if (curr == '%') {\n+                  regex.append(\".*\");\n+                } else {\n+                  regex.append(${patternClass}.quote((new Character(curr)).toString()));\n+                }\n+              }\n+            }\n+          }\n+          ${patternClass} pattern = ${patternClass}.compile(regex.toString());\n+        \"\"\"\n+      }","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala","position":47,"original_position":47,"commit_id":"69f0fb614f2efefdced341294c1de8d84fcb4708","original_commit_id":"69f0fb614f2efefdced341294c1de8d84fcb4708","user":{"login":"tarekauel","id":5320817,"avatar_url":"https://avatars.githubusercontent.com/u/5320817?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekauel","html_url":"https://github.com/tarekauel","followers_url":"https://api.github.com/users/tarekauel/followers","following_url":"https://api.github.com/users/tarekauel/following{/other_user}","gists_url":"https://api.github.com/users/tarekauel/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekauel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekauel/subscriptions","organizations_url":"https://api.github.com/users/tarekauel/orgs","repos_url":"https://api.github.com/users/tarekauel/repos","events_url":"https://api.github.com/users/tarekauel/events{/privacy}","received_events_url":"https://api.github.com/users/tarekauel/received_events","type":"User","site_admin":false},"body":"That is exactly what we want. `escape` is totally independent from the expression itself, isn't it. This simplifies the codegen, removes duplicated code and has no negative impact.","created_at":"2015-07-21T08:12:22Z","updated_at":"2015-07-21T08:12:22Z","html_url":"https://github.com/apache/spark/pull/7561#discussion_r35078428","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7561","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/35078428"},"html":{"href":"https://github.com/apache/spark/pull/7561#discussion_r35078428"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7561"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7561","id":40426927,"html_url":"https://github.com/apache/spark/pull/7561","diff_url":"https://github.com/apache/spark/pull/7561.diff","patch_url":"https://github.com/apache/spark/pull/7561.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7561","number":7561,"state":"open","locked":false,"title":"[SPARK-9152][SQL] Implement code generation for Like and RLike","user":{"login":"viirya","id":68855,"avatar_url":"https://avatars.githubusercontent.com/u/68855?v=3","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.apache.org/jira/browse/SPARK-9152\r\n\r\nThis PR implements code generation for `Like` and `RLike`.\r\n","created_at":"2015-07-21T06:42:28Z","updated_at":"2015-07-21T08:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ad0dece6ce73c1a3ea1a7b6e1389ced2a641948","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7561/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7561/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7561/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/69f0fb614f2efefdced341294c1de8d84fcb4708","head":{"label":"viirya:like_rlike_codegen","ref":"like_rlike_codegen","sha":"69f0fb614f2efefdced341294c1de8d84fcb4708","user":{"login":"viirya","id":68855,"avatar_url":"https://avatars.githubusercontent.com/u/68855?v=3","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"repo":{"id":21467907,"name":"spark-1","full_name":"viirya/spark-1","owner":{"login":"viirya","id":68855,"avatar_url":"https://avatars.githubusercontent.com/u/68855?v=3","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viirya/spark-1","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/viirya/spark-1","forks_url":"https://api.github.com/repos/viirya/spark-1/forks","keys_url":"https://api.github.com/repos/viirya/spark-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viirya/spark-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viirya/spark-1/teams","hooks_url":"https://api.github.com/repos/viirya/spark-1/hooks","issue_events_url":"https://api.github.com/repos/viirya/spark-1/issues/events{/number}","events_url":"https://api.github.com/repos/viirya/spark-1/events","assignees_url":"https://api.github.com/repos/viirya/spark-1/assignees{/user}","branches_url":"https://api.github.com/repos/viirya/spark-1/branches{/branch}","tags_url":"https://api.github.com/repos/viirya/spark-1/tags","blobs_url":"https://api.github.com/repos/viirya/spark-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viirya/spark-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viirya/spark-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/viirya/spark-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viirya/spark-1/statuses/{sha}","languages_url":"https://api.github.com/repos/viirya/spark-1/languages","stargazers_url":"https://api.github.com/repos/viirya/spark-1/stargazers","contributors_url":"https://api.github.com/repos/viirya/spark-1/contributors","subscribers_url":"https://api.github.com/repos/viirya/spark-1/subscribers","subscription_url":"https://api.github.com/repos/viirya/spark-1/subscription","commits_url":"https://api.github.com/repos/viirya/spark-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/viirya/spark-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/viirya/spark-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/viirya/spark-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/viirya/spark-1/contents/{+path}","compare_url":"https://api.github.com/repos/viirya/spark-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viirya/spark-1/merges","archive_url":"https://api.github.com/repos/viirya/spark-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viirya/spark-1/downloads","issues_url":"https://api.github.com/repos/viirya/spark-1/issues{/number}","pulls_url":"https://api.github.com/repos/viirya/spark-1/pulls{/number}","milestones_url":"https://api.github.com/repos/viirya/spark-1/milestones{/number}","notifications_url":"https://api.github.com/repos/viirya/spark-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viirya/spark-1/labels{/name}","releases_url":"https://api.github.com/repos/viirya/spark-1/releases{/id}","created_at":"2014-07-03T15:40:08Z","updated_at":"2015-05-08T15:19:23Z","pushed_at":"2015-07-21T06:41:02Z","git_url":"git://github.com/viirya/spark-1.git","ssh_url":"git@github.com:viirya/spark-1.git","clone_url":"https://github.com/viirya/spark-1.git","svn_url":"https://github.com/viirya/spark-1","homepage":null,"size":111239,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1ddd0f2f1688560f88470e312b72af04364e2d49","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-21T08:06:14Z","pushed_at":"2015-07-21T08:08:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1571156,"stargazers_count":4811,"watchers_count":4811,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4310,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":336,"forks":4310,"open_issues":336,"watchers":4811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7561"},"html":{"href":"https://github.com/apache/spark/pull/7561"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7561"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7561/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7561/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7561/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/69f0fb614f2efefdced341294c1de8d84fcb4708"}}}}