{"action":"created","comment":{"url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/comments/25362615","id":25362615,"diff_hunk":"@@ -18,21 +18,10 @@\n   /**\n    * Creates the exception passing the failed link.\n    *\n-   * @param link  the link which could not be resolved\n-   * @param causeMessage  the reason why the link could not be resolved\n+   * @param message  the reason why the link could not be resolved, null tolerant\n    */\n-  public LinkResolutionException(Link<?> link, String causeMessage) {\n-    super(\"Unable to resolve link: \" + link + \" - \" + String.valueOf(causeMessage));\n-  }\n-\n-  /**\n-   * Creates the exception passing the failed link.\n-   *\n-   * @param link  the link which could not be resolved\n-   * @param cause  the reason why the link could not be resolved\n-   */\n-  public LinkResolutionException(Link<?> link, Failure cause) {\n-    super(\"Unable to resolve link: \" + link + \" - \" + (cause != null ? cause.getMessage() : \"<no cause>\"));\n+  public LinkResolutionException(@Nullable String message) {","path":"modules/collect/src/main/java/com/opengamma/collect/id/LinkResolutionException.java","position":29,"original_position":29,"commit_id":"d0bfc92e090ada572a460597d49ed39d63d257b0","original_commit_id":"d0bfc92e090ada572a460597d49ed39d63d257b0","user":{"login":"julianhowarth","id":3205453,"avatar_url":"https://avatars.githubusercontent.com/u/3205453?v=3","gravatar_id":"","url":"https://api.github.com/users/julianhowarth","html_url":"https://github.com/julianhowarth","followers_url":"https://api.github.com/users/julianhowarth/followers","following_url":"https://api.github.com/users/julianhowarth/following{/other_user}","gists_url":"https://api.github.com/users/julianhowarth/gists{/gist_id}","starred_url":"https://api.github.com/users/julianhowarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianhowarth/subscriptions","organizations_url":"https://api.github.com/users/julianhowarth/orgs","repos_url":"https://api.github.com/users/julianhowarth/repos","events_url":"https://api.github.com/users/julianhowarth/events{/privacy}","received_events_url":"https://api.github.com/users/julianhowarth/received_events","type":"User","site_admin":false},"body":"Not sure about the change to this class. Aren't we realistically only going to get LinkResolutionExceptions from failed links? If so, why not allow the  link to form part of the exception? ","created_at":"2015-02-25T18:03:43Z","updated_at":"2015-02-25T18:03:43Z","html_url":"https://github.com/OpenGamma/OG-Commons/pull/65#discussion_r25362615","pull_request_url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/comments/25362615"},"html":{"href":"https://github.com/OpenGamma/OG-Commons/pull/65#discussion_r25362615"},"pull_request":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65","id":29921294,"html_url":"https://github.com/OpenGamma/OG-Commons/pull/65","diff_url":"https://github.com/OpenGamma/OG-Commons/pull/65.diff","patch_url":"https://github.com/OpenGamma/OG-Commons/pull/65.patch","issue_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/65","number":65,"state":"open","locked":false,"title":"PLT-659 Enhanced links","user":{"login":"jodastephen","id":213212,"avatar_url":"https://avatars.githubusercontent.com/u/213212?v=3","gravatar_id":"","url":"https://api.github.com/users/jodastephen","html_url":"https://github.com/jodastephen","followers_url":"https://api.github.com/users/jodastephen/followers","following_url":"https://api.github.com/users/jodastephen/following{/other_user}","gists_url":"https://api.github.com/users/jodastephen/gists{/gist_id}","starred_url":"https://api.github.com/users/jodastephen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodastephen/subscriptions","organizations_url":"https://api.github.com/users/jodastephen/orgs","repos_url":"https://api.github.com/users/jodastephen/repos","events_url":"https://api.github.com/users/jodastephen/events{/privacy}","received_events_url":"https://api.github.com/users/jodastephen/received_events","type":"User","site_admin":false},"body":"Handle links with generic types as a target. This means using the Guava `TypeToken`, but keeping it out of the state of beans (as it cannot be converted to/from a string). The existing `Class` based method can forward to the `TypeToken` one.\r\n\r\nIntroduce `Resolvable` as an abstraction for domain objects that can resolve. This will allow a complete immutable domain model to handle resolving links.\r\n\r\nSimplify `LinkResolutionException`.","created_at":"2015-02-24T18:10:40Z","updated_at":"2015-02-25T18:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df0b2350531bda57d1a1d879378ccb31cfd05105","assignee":{"login":"julianhowarth","id":3205453,"avatar_url":"https://avatars.githubusercontent.com/u/3205453?v=3","gravatar_id":"","url":"https://api.github.com/users/julianhowarth","html_url":"https://github.com/julianhowarth","followers_url":"https://api.github.com/users/julianhowarth/followers","following_url":"https://api.github.com/users/julianhowarth/following{/other_user}","gists_url":"https://api.github.com/users/julianhowarth/gists{/gist_id}","starred_url":"https://api.github.com/users/julianhowarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianhowarth/subscriptions","organizations_url":"https://api.github.com/users/julianhowarth/orgs","repos_url":"https://api.github.com/users/julianhowarth/repos","events_url":"https://api.github.com/users/julianhowarth/events{/privacy}","received_events_url":"https://api.github.com/users/julianhowarth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65/commits","review_comments_url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65/comments","review_comment_url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/65/comments","statuses_url":"https://api.github.com/repos/OpenGamma/OG-Commons/statuses/d0bfc92e090ada572a460597d49ed39d63d257b0","head":{"label":"OpenGamma:topic/PLT-659","ref":"topic/PLT-659","sha":"d0bfc92e090ada572a460597d49ed39d63d257b0","user":{"login":"OpenGamma","id":120064,"avatar_url":"https://avatars.githubusercontent.com/u/120064?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenGamma","html_url":"https://github.com/OpenGamma","followers_url":"https://api.github.com/users/OpenGamma/followers","following_url":"https://api.github.com/users/OpenGamma/following{/other_user}","gists_url":"https://api.github.com/users/OpenGamma/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGamma/subscriptions","organizations_url":"https://api.github.com/users/OpenGamma/orgs","repos_url":"https://api.github.com/users/OpenGamma/repos","events_url":"https://api.github.com/users/OpenGamma/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGamma/received_events","type":"Organization","site_admin":false},"repo":{"id":20916831,"name":"OG-Commons","full_name":"OpenGamma/OG-Commons","owner":{"login":"OpenGamma","id":120064,"avatar_url":"https://avatars.githubusercontent.com/u/120064?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenGamma","html_url":"https://github.com/OpenGamma","followers_url":"https://api.github.com/users/OpenGamma/followers","following_url":"https://api.github.com/users/OpenGamma/following{/other_user}","gists_url":"https://api.github.com/users/OpenGamma/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGamma/subscriptions","organizations_url":"https://api.github.com/users/OpenGamma/orgs","repos_url":"https://api.github.com/users/OpenGamma/repos","events_url":"https://api.github.com/users/OpenGamma/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGamma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenGamma/OG-Commons","description":"Libraries of common code supporting OpenGamma","fork":false,"url":"https://api.github.com/repos/OpenGamma/OG-Commons","forks_url":"https://api.github.com/repos/OpenGamma/OG-Commons/forks","keys_url":"https://api.github.com/repos/OpenGamma/OG-Commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenGamma/OG-Commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenGamma/OG-Commons/teams","hooks_url":"https://api.github.com/repos/OpenGamma/OG-Commons/hooks","issue_events_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/events{/number}","events_url":"https://api.github.com/repos/OpenGamma/OG-Commons/events","assignees_url":"https://api.github.com/repos/OpenGamma/OG-Commons/assignees{/user}","branches_url":"https://api.github.com/repos/OpenGamma/OG-Commons/branches{/branch}","tags_url":"https://api.github.com/repos/OpenGamma/OG-Commons/tags","blobs_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenGamma/OG-Commons/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenGamma/OG-Commons/languages","stargazers_url":"https://api.github.com/repos/OpenGamma/OG-Commons/stargazers","contributors_url":"https://api.github.com/repos/OpenGamma/OG-Commons/contributors","subscribers_url":"https://api.github.com/repos/OpenGamma/OG-Commons/subscribers","subscription_url":"https://api.github.com/repos/OpenGamma/OG-Commons/subscription","commits_url":"https://api.github.com/repos/OpenGamma/OG-Commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenGamma/OG-Commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenGamma/OG-Commons/contents/{+path}","compare_url":"https://api.github.com/repos/OpenGamma/OG-Commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenGamma/OG-Commons/merges","archive_url":"https://api.github.com/repos/OpenGamma/OG-Commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenGamma/OG-Commons/downloads","issues_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues{/number}","pulls_url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenGamma/OG-Commons/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenGamma/OG-Commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenGamma/OG-Commons/labels{/name}","releases_url":"https://api.github.com/repos/OpenGamma/OG-Commons/releases{/id}","created_at":"2014-06-17T08:59:44Z","updated_at":"2015-02-19T11:39:20Z","pushed_at":"2015-02-24T18:09:36Z","git_url":"git://github.com/OpenGamma/OG-Commons.git","ssh_url":"git@github.com:OpenGamma/OG-Commons.git","clone_url":"https://github.com/OpenGamma/OG-Commons.git","svn_url":"https://github.com/OpenGamma/OG-Commons","homepage":"","size":3503,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":11,"default_branch":"master"}},"base":{"label":"OpenGamma:master","ref":"master","sha":"80edbed800e6c8c7698bfd02412811871c9df160","user":{"login":"OpenGamma","id":120064,"avatar_url":"https://avatars.githubusercontent.com/u/120064?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenGamma","html_url":"https://github.com/OpenGamma","followers_url":"https://api.github.com/users/OpenGamma/followers","following_url":"https://api.github.com/users/OpenGamma/following{/other_user}","gists_url":"https://api.github.com/users/OpenGamma/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGamma/subscriptions","organizations_url":"https://api.github.com/users/OpenGamma/orgs","repos_url":"https://api.github.com/users/OpenGamma/repos","events_url":"https://api.github.com/users/OpenGamma/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGamma/received_events","type":"Organization","site_admin":false},"repo":{"id":20916831,"name":"OG-Commons","full_name":"OpenGamma/OG-Commons","owner":{"login":"OpenGamma","id":120064,"avatar_url":"https://avatars.githubusercontent.com/u/120064?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenGamma","html_url":"https://github.com/OpenGamma","followers_url":"https://api.github.com/users/OpenGamma/followers","following_url":"https://api.github.com/users/OpenGamma/following{/other_user}","gists_url":"https://api.github.com/users/OpenGamma/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGamma/subscriptions","organizations_url":"https://api.github.com/users/OpenGamma/orgs","repos_url":"https://api.github.com/users/OpenGamma/repos","events_url":"https://api.github.com/users/OpenGamma/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGamma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenGamma/OG-Commons","description":"Libraries of common code supporting OpenGamma","fork":false,"url":"https://api.github.com/repos/OpenGamma/OG-Commons","forks_url":"https://api.github.com/repos/OpenGamma/OG-Commons/forks","keys_url":"https://api.github.com/repos/OpenGamma/OG-Commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenGamma/OG-Commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenGamma/OG-Commons/teams","hooks_url":"https://api.github.com/repos/OpenGamma/OG-Commons/hooks","issue_events_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/events{/number}","events_url":"https://api.github.com/repos/OpenGamma/OG-Commons/events","assignees_url":"https://api.github.com/repos/OpenGamma/OG-Commons/assignees{/user}","branches_url":"https://api.github.com/repos/OpenGamma/OG-Commons/branches{/branch}","tags_url":"https://api.github.com/repos/OpenGamma/OG-Commons/tags","blobs_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenGamma/OG-Commons/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenGamma/OG-Commons/languages","stargazers_url":"https://api.github.com/repos/OpenGamma/OG-Commons/stargazers","contributors_url":"https://api.github.com/repos/OpenGamma/OG-Commons/contributors","subscribers_url":"https://api.github.com/repos/OpenGamma/OG-Commons/subscribers","subscription_url":"https://api.github.com/repos/OpenGamma/OG-Commons/subscription","commits_url":"https://api.github.com/repos/OpenGamma/OG-Commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenGamma/OG-Commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenGamma/OG-Commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenGamma/OG-Commons/contents/{+path}","compare_url":"https://api.github.com/repos/OpenGamma/OG-Commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenGamma/OG-Commons/merges","archive_url":"https://api.github.com/repos/OpenGamma/OG-Commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenGamma/OG-Commons/downloads","issues_url":"https://api.github.com/repos/OpenGamma/OG-Commons/issues{/number}","pulls_url":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenGamma/OG-Commons/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenGamma/OG-Commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenGamma/OG-Commons/labels{/name}","releases_url":"https://api.github.com/repos/OpenGamma/OG-Commons/releases{/id}","created_at":"2014-06-17T08:59:44Z","updated_at":"2015-02-19T11:39:20Z","pushed_at":"2015-02-24T18:09:36Z","git_url":"git://github.com/OpenGamma/OG-Commons.git","ssh_url":"git@github.com:OpenGamma/OG-Commons.git","clone_url":"https://github.com/OpenGamma/OG-Commons.git","svn_url":"https://github.com/OpenGamma/OG-Commons","homepage":"","size":3503,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65"},"html":{"href":"https://github.com/OpenGamma/OG-Commons/pull/65"},"issue":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/65"},"comments":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/OpenGamma/OG-Commons/statuses/d0bfc92e090ada572a460597d49ed39d63d257b0"}}}}