{"action":"created","issue":{"url":"https://api.github.com/repos/bastibe/PySoundFile/issues/121","labels_url":"https://api.github.com/repos/bastibe/PySoundFile/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/bastibe/PySoundFile/issues/121/comments","events_url":"https://api.github.com/repos/bastibe/PySoundFile/issues/121/events","html_url":"https://github.com/bastibe/PySoundFile/pull/121","id":64884619,"number":121,"title":"support unicode filenames","user":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-28T01:43:12Z","updated_at":"2015-03-28T09:29:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bastibe/PySoundFile/pulls/121","html_url":"https://github.com/bastibe/PySoundFile/pull/121","diff_url":"https://github.com/bastibe/PySoundFile/pull/121.diff","patch_url":"https://github.com/bastibe/PySoundFile/pull/121.patch"},"body":"I ran into a problem when one of my filenames was `u'file.ogg'` rather than `'file.ogg'` (str).\r\n\r\nThis patch swaps out the string type-check for `six.string_types`.  (I also threw it on `mode` while we're at it.)\r\n\r\nThis does add a dependency on the `six` module, so I understand if you'd prefer to do it manually instead.\r\n\r\nProbably, there are other places where the code can be patched up to work more smoothly with unicode and/or general py2/py3 compatibility.  I haven't done a thorough check though."},"comment":{"url":"https://api.github.com/repos/bastibe/PySoundFile/issues/comments/87197651","html_url":"https://github.com/bastibe/PySoundFile/pull/121#issuecomment-87197651","issue_url":"https://api.github.com/repos/bastibe/PySoundFile/issues/121","id":87197651,"user":{"login":"mgeier","id":705404,"avatar_url":"https://avatars.githubusercontent.com/u/705404?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeier","html_url":"https://github.com/mgeier","followers_url":"https://api.github.com/users/mgeier/followers","following_url":"https://api.github.com/users/mgeier/following{/other_user}","gists_url":"https://api.github.com/users/mgeier/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeier/subscriptions","organizations_url":"https://api.github.com/users/mgeier/orgs","repos_url":"https://api.github.com/users/mgeier/repos","events_url":"https://api.github.com/users/mgeier/events{/privacy}","received_events_url":"https://api.github.com/users/mgeier/received_events","type":"User","site_admin":false},"created_at":"2015-03-28T09:29:43Z","updated_at":"2015-03-28T09:29:43Z","body":"Incidentally, I created a PR for the same problem a few days ago: #119.\r\nMine doesn't add another dependency and it (hopefully) takes care of the other places where `str()` was used before.\r\n\r\nCan you please review/improve #119?"}}