{"action":"created","comment":{"url":"https://api.github.com/repos/bundler/gemstash/pulls/comments/46240019","id":46240019,"diff_hunk":"@@ -77,27 +77,27 @@ def ask_memcached_details\n \n       def ask_database\n         say_current_config(:db_adapter, \"Current database adapter\")\n-        options = %w(sqlite3 postgres)\n+        options = %w(sqlite3 postgres mysql)\n         database = nil\n \n         until database\n-          database = @cli.ask \"What database adapter? [SQLITE3, postgres]\"\n+          database = @cli.ask \"What database adapter? [SQLITE3, postgres, mysql]\"\n           database = database.downcase\n           database = \"sqlite3\" if database.empty?\n           database = nil unless options.include?(database)\n         end\n \n         @config[:db_adapter] = database\n-        ask_postgres_details if database == \"postgres\"\n+        ask_database_details(database) unless database == \"sqlite3\"\n       end\n \n-      def ask_postgres_details\n+      def ask_database_details(database = \"postgres\")","path":"lib/gemstash/cli/setup.rb","position":22,"original_position":22,"commit_id":"efe2e9687842336ae5188238545c9238629f84da","original_commit_id":"efe2e9687842336ae5188238545c9238629f84da","user":{"login":"smellsblue","id":150632,"avatar_url":"https://avatars.githubusercontent.com/u/150632?v=3","gravatar_id":"","url":"https://api.github.com/users/smellsblue","html_url":"https://github.com/smellsblue","followers_url":"https://api.github.com/users/smellsblue/followers","following_url":"https://api.github.com/users/smellsblue/following{/other_user}","gists_url":"https://api.github.com/users/smellsblue/gists{/gist_id}","starred_url":"https://api.github.com/users/smellsblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smellsblue/subscriptions","organizations_url":"https://api.github.com/users/smellsblue/orgs","repos_url":"https://api.github.com/users/smellsblue/repos","events_url":"https://api.github.com/users/smellsblue/events{/privacy}","received_events_url":"https://api.github.com/users/smellsblue/received_events","type":"User","site_admin":false},"body":"Is the default value necessary? It seems like a value is always provided","created_at":"2015-12-01T04:48:21Z","updated_at":"2015-12-01T04:48:21Z","html_url":"https://github.com/bundler/gemstash/pull/52#discussion_r46240019","pull_request_url":"https://api.github.com/repos/bundler/gemstash/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/bundler/gemstash/pulls/comments/46240019"},"html":{"href":"https://github.com/bundler/gemstash/pull/52#discussion_r46240019"},"pull_request":{"href":"https://api.github.com/repos/bundler/gemstash/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/bundler/gemstash/pulls/52","id":52067130,"html_url":"https://github.com/bundler/gemstash/pull/52","diff_url":"https://github.com/bundler/gemstash/pull/52.diff","patch_url":"https://github.com/bundler/gemstash/pull/52.patch","issue_url":"https://api.github.com/repos/bundler/gemstash/issues/52","number":52,"state":"open","locked":false,"title":"Support mysql as DB backend","user":{"login":"pcarranza","id":4496338,"avatar_url":"https://avatars.githubusercontent.com/u/4496338?v=3","gravatar_id":"","url":"https://api.github.com/users/pcarranza","html_url":"https://github.com/pcarranza","followers_url":"https://api.github.com/users/pcarranza/followers","following_url":"https://api.github.com/users/pcarranza/following{/other_user}","gists_url":"https://api.github.com/users/pcarranza/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarranza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarranza/subscriptions","organizations_url":"https://api.github.com/users/pcarranza/orgs","repos_url":"https://api.github.com/users/pcarranza/repos","events_url":"https://api.github.com/users/pcarranza/events{/privacy}","received_events_url":"https://api.github.com/users/pcarranza/received_events","type":"User","site_admin":false},"body":"This provides mysql as DB backend, and also reduces the size of the authorization key because mysql does not support keys so large (and they are not necessary)\r\n\r\nFixes #51 \r\n\r\ncc @indirect @smellsblue ","created_at":"2015-11-29T18:05:59Z","updated_at":"2015-12-01T04:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33814419ff66aa8ecc9f0b61270a211c1aadb2d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bundler/gemstash/pulls/52/commits","review_comments_url":"https://api.github.com/repos/bundler/gemstash/pulls/52/comments","review_comment_url":"https://api.github.com/repos/bundler/gemstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bundler/gemstash/issues/52/comments","statuses_url":"https://api.github.com/repos/bundler/gemstash/statuses/efe2e9687842336ae5188238545c9238629f84da","head":{"label":"bundler:support-mysql","ref":"support-mysql","sha":"efe2e9687842336ae5188238545c9238629f84da","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":42746109,"name":"gemstash","full_name":"bundler/gemstash","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/gemstash","description":null,"fork":false,"url":"https://api.github.com/repos/bundler/gemstash","forks_url":"https://api.github.com/repos/bundler/gemstash/forks","keys_url":"https://api.github.com/repos/bundler/gemstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/gemstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/gemstash/teams","hooks_url":"https://api.github.com/repos/bundler/gemstash/hooks","issue_events_url":"https://api.github.com/repos/bundler/gemstash/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/gemstash/events","assignees_url":"https://api.github.com/repos/bundler/gemstash/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/gemstash/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/gemstash/tags","blobs_url":"https://api.github.com/repos/bundler/gemstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/gemstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/gemstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/gemstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/gemstash/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/gemstash/languages","stargazers_url":"https://api.github.com/repos/bundler/gemstash/stargazers","contributors_url":"https://api.github.com/repos/bundler/gemstash/contributors","subscribers_url":"https://api.github.com/repos/bundler/gemstash/subscribers","subscription_url":"https://api.github.com/repos/bundler/gemstash/subscription","commits_url":"https://api.github.com/repos/bundler/gemstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/gemstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/gemstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/gemstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/gemstash/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/gemstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/gemstash/merges","archive_url":"https://api.github.com/repos/bundler/gemstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/gemstash/downloads","issues_url":"https://api.github.com/repos/bundler/gemstash/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/gemstash/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/gemstash/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/gemstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/gemstash/labels{/name}","releases_url":"https://api.github.com/repos/bundler/gemstash/releases{/id}","created_at":"2015-09-18T20:41:41Z","updated_at":"2015-12-01T03:41:11Z","pushed_at":"2015-11-30T20:13:53Z","git_url":"git://github.com/bundler/gemstash.git","ssh_url":"git@github.com:bundler/gemstash.git","clone_url":"https://github.com/bundler/gemstash.git","svn_url":"https://github.com/bundler/gemstash","homepage":null,"size":364,"stargazers_count":74,"watchers_count":74,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":74,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"51916692ccfc60aafbdd7df61a3234f35e6c5d03","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":42746109,"name":"gemstash","full_name":"bundler/gemstash","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/gemstash","description":null,"fork":false,"url":"https://api.github.com/repos/bundler/gemstash","forks_url":"https://api.github.com/repos/bundler/gemstash/forks","keys_url":"https://api.github.com/repos/bundler/gemstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/gemstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/gemstash/teams","hooks_url":"https://api.github.com/repos/bundler/gemstash/hooks","issue_events_url":"https://api.github.com/repos/bundler/gemstash/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/gemstash/events","assignees_url":"https://api.github.com/repos/bundler/gemstash/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/gemstash/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/gemstash/tags","blobs_url":"https://api.github.com/repos/bundler/gemstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/gemstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/gemstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/gemstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/gemstash/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/gemstash/languages","stargazers_url":"https://api.github.com/repos/bundler/gemstash/stargazers","contributors_url":"https://api.github.com/repos/bundler/gemstash/contributors","subscribers_url":"https://api.github.com/repos/bundler/gemstash/subscribers","subscription_url":"https://api.github.com/repos/bundler/gemstash/subscription","commits_url":"https://api.github.com/repos/bundler/gemstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/gemstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/gemstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/gemstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/gemstash/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/gemstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/gemstash/merges","archive_url":"https://api.github.com/repos/bundler/gemstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/gemstash/downloads","issues_url":"https://api.github.com/repos/bundler/gemstash/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/gemstash/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/gemstash/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/gemstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/gemstash/labels{/name}","releases_url":"https://api.github.com/repos/bundler/gemstash/releases{/id}","created_at":"2015-09-18T20:41:41Z","updated_at":"2015-12-01T03:41:11Z","pushed_at":"2015-11-30T20:13:53Z","git_url":"git://github.com/bundler/gemstash.git","ssh_url":"git@github.com:bundler/gemstash.git","clone_url":"https://github.com/bundler/gemstash.git","svn_url":"https://github.com/bundler/gemstash","homepage":null,"size":364,"stargazers_count":74,"watchers_count":74,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/gemstash/pulls/52"},"html":{"href":"https://github.com/bundler/gemstash/pull/52"},"issue":{"href":"https://api.github.com/repos/bundler/gemstash/issues/52"},"comments":{"href":"https://api.github.com/repos/bundler/gemstash/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/gemstash/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/gemstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bundler/gemstash/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/gemstash/statuses/efe2e9687842336ae5188238545c9238629f84da"}}}}