{"action":"created","issue":{"url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1447","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1447/labels{/name}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1447/comments","events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1447/events","html_url":"https://github.com/ImageEngine/gaffer/pull/1447","id":102136983,"number":1447,"title":"Resize node","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=3","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-08-20T13:19:16Z","updated_at":"2015-08-26T17:07:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1447","html_url":"https://github.com/ImageEngine/gaffer/pull/1447","diff_url":"https://github.com/ImageEngine/gaffer/pull/1447.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1447.patch"},"body":"This adds a Resize node to GafferImage, which gives an image a new format and scales the contents appropriately, with fit modes to determine exactly how this is done. Internally it uses an instance of a new Resample node to do the necessary filtering - this builds on the ideas Luke was exploring in #833. Performance is within a few percent of the existing Reformat node, and the internal Resample also provides the ability to override filter width, which hopefully provides a good basis for use in the internal implementation of a Blur node recipe Luke concocted previously.\r\n\r\nThe new node uses OIIO::Filter2D to provide filters rather than GafferImage::Filter. OIIO provides a broader range of filters, and a more flexible and intuitive API, so @HughMacdonald and I felt it was best to adopt theirs rather than continue work on ours. If this PR gets merged, the plan going forwards is to update ImageTransform to use Resample internally and then remove Filter, FilterPlug and Reformat from GafferImage.\r\n\r\nSince the Resample and Resize nodes modify data and display windows, this will need modifying to take Hugh's work on #1444 into account if that is merged first. I've tried to comment the spots that will need changing to make this a bit less painful, but I may have missed a couple.\r\n"},"comment":{"url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments/135110106","html_url":"https://github.com/ImageEngine/gaffer/pull/1447#issuecomment-135110106","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1447","id":135110106,"user":{"login":"HughMacdonald","id":625512,"avatar_url":"https://avatars.githubusercontent.com/u/625512?v=3","gravatar_id":"","url":"https://api.github.com/users/HughMacdonald","html_url":"https://github.com/HughMacdonald","followers_url":"https://api.github.com/users/HughMacdonald/followers","following_url":"https://api.github.com/users/HughMacdonald/following{/other_user}","gists_url":"https://api.github.com/users/HughMacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/HughMacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HughMacdonald/subscriptions","organizations_url":"https://api.github.com/users/HughMacdonald/orgs","repos_url":"https://api.github.com/users/HughMacdonald/repos","events_url":"https://api.github.com/users/HughMacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/HughMacdonald/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T17:07:39Z","updated_at":"2015-08-26T17:07:39Z","body":"Yeah, I'm fine - the upscale issues are ones everyone is aware of, and the UI end of Crop vs Resize is a conversation I'd like to continue, but I would say it's all good to get out there"}}