{"action":"created","comment":{"url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/comments/23218987","id":23218987,"diff_hunk":"@@ -59,13 +59,20 @@ func (h *delegateHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {\n \n // TODO: replace this with clientcmd","path":"pkg/standalone/standalone.go","position":2,"original_position":2,"commit_id":"7a39f990483f69faaa907b9f57e7a4c0e89f3d01","original_commit_id":"7a39f990483f69faaa907b9f57e7a4c0e89f3d01","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"If you're feeling up to it we would like to collapse down onto clientcmd, but I don't think it's a hard requirement at this point.","created_at":"2015-01-20T12:36:19Z","updated_at":"2015-01-20T12:36:19Z","html_url":"https://github.com/EricMountain-1A/kubernetes/pull/1#discussion_r23218987","pull_request_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/comments/23218987"},"html":{"href":"https://github.com/EricMountain-1A/kubernetes/pull/1#discussion_r23218987"},"pull_request":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1","id":27610906,"html_url":"https://github.com/EricMountain-1A/kubernetes/pull/1","diff_url":"https://github.com/EricMountain-1A/kubernetes/pull/1.diff","patch_url":"https://github.com/EricMountain-1A/kubernetes/pull/1.patch","issue_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/1","number":1,"state":"open","locked":false,"title":"Fix local-up-cluster.sh+test-cmd.sh to have APIServer client","user":{"login":"EricMountain-1A","id":8555225,"avatar_url":"https://avatars.githubusercontent.com/u/8555225?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMountain-1A","html_url":"https://github.com/EricMountain-1A","followers_url":"https://api.github.com/users/EricMountain-1A/followers","following_url":"https://api.github.com/users/EricMountain-1A/following{/other_user}","gists_url":"https://api.github.com/users/EricMountain-1A/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMountain-1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMountain-1A/subscriptions","organizations_url":"https://api.github.com/users/EricMountain-1A/orgs","repos_url":"https://api.github.com/users/EricMountain-1A/repos","events_url":"https://api.github.com/users/EricMountain-1A/events{/privacy}","received_events_url":"https://api.github.com/users/EricMountain-1A/received_events","type":"User","site_admin":false},"body":"hack/test-cmd.sh and hack/local-up-cluster.sh panic due when no auth credentials are supplied to connect to the API server:\r\n\r\n````\r\nW0119 12:36:25.235155   17155 kubelet.go:124] No API client: stat /home/eric/go/src/github.com/EricMountain-1A/kubernetes/hack/.test-cmd-auth: no such file or directory\r\n...\r\nI0119 12:36:25.235712   17155 util.go:51] Recovered from panic: \"invalid memory address or nil pointer dereference\" (runtime error: invalid memory address or nil pointer dereference)\r\n````\r\n\r\nAlso, local-up-cluster fails to deploy pods since no client is available in this case.\r\n\r\nBoth these scripts are intended to use APIServer's localhost port 8080 access which requires no auth checks.\r\n\r\nThis patch:\r\n\r\n* Avoids nil deref in listwatch and provides an error message instead when no client is available.\r\n* --auth_path is no longer mandatory to create a client.Config.\r\n* --auth_path is no longer passed in test-cmd.sh nor local-up-cluster.sh. (It pointed at a non-existing file, hack/.test-cmd-auth.)\r\n","created_at":"2015-01-19T14:41:02Z","updated_at":"2015-01-20T12:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e12012b4e31ef0c01ad5ce5f74836976455a181c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1/commits","review_comments_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1/comments","review_comment_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/1/comments","statuses_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/statuses/7a39f990483f69faaa907b9f57e7a4c0e89f3d01","head":{"label":"EricMountain-1A:nullptr-apiclientstandalone-dev","ref":"nullptr-apiclientstandalone-dev","sha":"7a39f990483f69faaa907b9f57e7a4c0e89f3d01","user":{"login":"EricMountain-1A","id":8555225,"avatar_url":"https://avatars.githubusercontent.com/u/8555225?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMountain-1A","html_url":"https://github.com/EricMountain-1A","followers_url":"https://api.github.com/users/EricMountain-1A/followers","following_url":"https://api.github.com/users/EricMountain-1A/following{/other_user}","gists_url":"https://api.github.com/users/EricMountain-1A/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMountain-1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMountain-1A/subscriptions","organizations_url":"https://api.github.com/users/EricMountain-1A/orgs","repos_url":"https://api.github.com/users/EricMountain-1A/repos","events_url":"https://api.github.com/users/EricMountain-1A/events{/privacy}","received_events_url":"https://api.github.com/users/EricMountain-1A/received_events","type":"User","site_admin":false},"repo":{"id":29344333,"name":"kubernetes","full_name":"EricMountain-1A/kubernetes","owner":{"login":"EricMountain-1A","id":8555225,"avatar_url":"https://avatars.githubusercontent.com/u/8555225?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMountain-1A","html_url":"https://github.com/EricMountain-1A","followers_url":"https://api.github.com/users/EricMountain-1A/followers","following_url":"https://api.github.com/users/EricMountain-1A/following{/other_user}","gists_url":"https://api.github.com/users/EricMountain-1A/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMountain-1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMountain-1A/subscriptions","organizations_url":"https://api.github.com/users/EricMountain-1A/orgs","repos_url":"https://api.github.com/users/EricMountain-1A/repos","events_url":"https://api.github.com/users/EricMountain-1A/events{/privacy}","received_events_url":"https://api.github.com/users/EricMountain-1A/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricMountain-1A/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/EricMountain-1A/kubernetes","forks_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/forks","keys_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/teams","hooks_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/events","assignees_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/tags","blobs_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/languages","stargazers_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/subscription","commits_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/merges","archive_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/downloads","issues_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/releases{/id}","created_at":"2015-01-16T10:43:00Z","updated_at":"2015-01-20T09:28:45Z","pushed_at":"2015-01-20T09:28:44Z","git_url":"git://github.com/EricMountain-1A/kubernetes.git","ssh_url":"git@github.com:EricMountain-1A/kubernetes.git","clone_url":"https://github.com/EricMountain-1A/kubernetes.git","svn_url":"https://github.com/EricMountain-1A/kubernetes","homepage":null,"size":24267,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"EricMountain-1A:master","ref":"master","sha":"b1f5b3f2873a3f10a9940dc5b83087d6eff4ab65","user":{"login":"EricMountain-1A","id":8555225,"avatar_url":"https://avatars.githubusercontent.com/u/8555225?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMountain-1A","html_url":"https://github.com/EricMountain-1A","followers_url":"https://api.github.com/users/EricMountain-1A/followers","following_url":"https://api.github.com/users/EricMountain-1A/following{/other_user}","gists_url":"https://api.github.com/users/EricMountain-1A/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMountain-1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMountain-1A/subscriptions","organizations_url":"https://api.github.com/users/EricMountain-1A/orgs","repos_url":"https://api.github.com/users/EricMountain-1A/repos","events_url":"https://api.github.com/users/EricMountain-1A/events{/privacy}","received_events_url":"https://api.github.com/users/EricMountain-1A/received_events","type":"User","site_admin":false},"repo":{"id":29344333,"name":"kubernetes","full_name":"EricMountain-1A/kubernetes","owner":{"login":"EricMountain-1A","id":8555225,"avatar_url":"https://avatars.githubusercontent.com/u/8555225?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMountain-1A","html_url":"https://github.com/EricMountain-1A","followers_url":"https://api.github.com/users/EricMountain-1A/followers","following_url":"https://api.github.com/users/EricMountain-1A/following{/other_user}","gists_url":"https://api.github.com/users/EricMountain-1A/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMountain-1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMountain-1A/subscriptions","organizations_url":"https://api.github.com/users/EricMountain-1A/orgs","repos_url":"https://api.github.com/users/EricMountain-1A/repos","events_url":"https://api.github.com/users/EricMountain-1A/events{/privacy}","received_events_url":"https://api.github.com/users/EricMountain-1A/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricMountain-1A/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/EricMountain-1A/kubernetes","forks_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/forks","keys_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/teams","hooks_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/events","assignees_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/tags","blobs_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/languages","stargazers_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/subscription","commits_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/merges","archive_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/downloads","issues_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/EricMountain-1A/kubernetes/releases{/id}","created_at":"2015-01-16T10:43:00Z","updated_at":"2015-01-20T09:28:45Z","pushed_at":"2015-01-20T09:28:44Z","git_url":"git://github.com/EricMountain-1A/kubernetes.git","ssh_url":"git@github.com:EricMountain-1A/kubernetes.git","clone_url":"https://github.com/EricMountain-1A/kubernetes.git","svn_url":"https://github.com/EricMountain-1A/kubernetes","homepage":null,"size":24267,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1"},"html":{"href":"https://github.com/EricMountain-1A/kubernetes/pull/1"},"issue":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/1"},"comments":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/EricMountain-1A/kubernetes/statuses/7a39f990483f69faaa907b9f57e7a4c0e89f3d01"}}}}