{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42322748","id":42322748,"diff_hunk":"@@ -25,22 +40,17 @@ public sealed partial class ClientWebSocket : WebSocket\n                 WebSocketValidate.ThrowPlatformNotSupportedException();\n             }\n         }\n+\n+        private WebSocketHandle(WinHttpWebSocket webSocket)\n+        {\n+            _webSocket = webSocket;\n+        }\n         \n-        private Task ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)\n+        public async Task ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)\n         {\n-            var winHttpWebSocket = new WinHttpWebSocket();\n-            _innerWebSocket = winHttpWebSocket;\n-\n             try\n             {\n-                // Change internal state to 'connected' to enable the other methods\n-                if ((InternalState)Interlocked.CompareExchange(ref _state, (int)InternalState.Connected, (int)InternalState.Connecting) != InternalState.Connecting)\n-                {\n-                    // Aborted/Disposed during connect.\n-                    throw new ObjectDisposedException(GetType().FullName);\n-                }\n-\n-                return winHttpWebSocket.ConnectAsync(uri, cancellationToken, _options);\n+                await _webSocket.ConnectAsync(uri, cancellationToken, options);","path":"src/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Win32.cs","position":61,"original_position":61,"commit_id":"dcfea18a1143a624ce373509a52c478ec66dcd8a","original_commit_id":"dcfea18a1143a624ce373509a52c478ec66dcd8a","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Should add .ConfigureAwait(false) to the end.","created_at":"2015-10-18T16:27:24Z","updated_at":"2015-10-18T16:27:24Z","html_url":"https://github.com/dotnet/corefx/pull/3922#discussion_r42322748","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3922","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42322748"},"html":{"href":"https://github.com/dotnet/corefx/pull/3922#discussion_r42322748"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3922"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3922","id":47969382,"html_url":"https://github.com/dotnet/corefx/pull/3922","diff_url":"https://github.com/dotnet/corefx/pull/3922.diff","patch_url":"https://github.com/dotnet/corefx/pull/3922.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3922","number":3922,"state":"open","locked":false,"title":"Add a temporary PAL for ClientWebSocket.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"On Windows, the PAL delegates to WinHttpWebSocket; on *nix, all methods\r\nthrow PlatformNotSupportedException.","created_at":"2015-10-16T22:55:36Z","updated_at":"2015-10-18T16:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fcb7c1d093499e951fe28a468749bfd9391ac13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3922/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3922/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3922/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/dcfea18a1143a624ce373509a52c478ec66dcd8a","head":{"label":"pgavlin:WebSocketClientPNSE","ref":"WebSocketClientPNSE","sha":"dcfea18a1143a624ce373509a52c478ec66dcd8a","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":27393660,"name":"corefx","full_name":"pgavlin/corefx","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/pgavlin/corefx","forks_url":"https://api.github.com/repos/pgavlin/corefx/forks","keys_url":"https://api.github.com/repos/pgavlin/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/corefx/teams","hooks_url":"https://api.github.com/repos/pgavlin/corefx/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/corefx/events","assignees_url":"https://api.github.com/repos/pgavlin/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/corefx/tags","blobs_url":"https://api.github.com/repos/pgavlin/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/corefx/languages","stargazers_url":"https://api.github.com/repos/pgavlin/corefx/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/corefx/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/corefx/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/corefx/subscription","commits_url":"https://api.github.com/repos/pgavlin/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/corefx/merges","archive_url":"https://api.github.com/repos/pgavlin/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/corefx/downloads","issues_url":"https://api.github.com/repos/pgavlin/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/corefx/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/corefx/releases{/id}","created_at":"2014-12-01T18:38:07Z","updated_at":"2014-12-01T18:38:09Z","pushed_at":"2015-10-18T02:15:38Z","git_url":"git://github.com/pgavlin/corefx.git","ssh_url":"git@github.com:pgavlin/corefx.git","clone_url":"https://github.com/pgavlin/corefx.git","svn_url":"https://github.com/pgavlin/corefx","homepage":"","size":37332,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5fbab81ad714672c087a2458c151f58b32f83b47","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-10-17T22:22:45Z","pushed_at":"2015-10-18T16:16:01Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":82546,"stargazers_count":8456,"watchers_count":8456,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1849,"mirror_url":null,"open_issues_count":650,"forks":1849,"open_issues":650,"watchers":8456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3922"},"html":{"href":"https://github.com/dotnet/corefx/pull/3922"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3922"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3922/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3922/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3922/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/dcfea18a1143a624ce373509a52c478ec66dcd8a"}}}}