{"action":"opened","number":2692,"pull_request":{"url":"https://api.github.com/repos/ajaxorg/ace/pulls/2692","id":47073147,"html_url":"https://github.com/ajaxorg/ace/pull/2692","diff_url":"https://github.com/ajaxorg/ace/pull/2692.diff","patch_url":"https://github.com/ajaxorg/ace/pull/2692.patch","issue_url":"https://api.github.com/repos/ajaxorg/ace/issues/2692","number":2692,"state":"open","locked":false,"title":"iSearch quits on unrecognized keys (closes #2691)","user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"body":"Based on suggested code in #2691.\r\n\r\nNote the one extra change to the return value of `handleKeyboard` -- this was necessary to ensure that the handler was actually able to see these commands, and they weren't silently 'consumed' -- I don't yet understand why this is the case but can you sanity check whether this is the appropriate solution?","created_at":"2015-10-07T19:48:17Z","updated_at":"2015-10-07T19:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ajaxorg/ace/pulls/2692/commits","review_comments_url":"https://api.github.com/repos/ajaxorg/ace/pulls/2692/comments","review_comment_url":"https://api.github.com/repos/ajaxorg/ace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ajaxorg/ace/issues/2692/comments","statuses_url":"https://api.github.com/repos/ajaxorg/ace/statuses/8704fe23401c44a66f943651e9daf3787a54d569","head":{"label":"kevinushey:bugfix/isearch-detach-on-unrecognized-command","ref":"bugfix/isearch-detach-on-unrecognized-command","sha":"8704fe23401c44a66f943651e9daf3787a54d569","user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"repo":{"id":28248040,"name":"ace","full_name":"kevinushey/ace","owner":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinushey/ace","description":"Ace (Ajax.org Cloud9 Editor)","fork":true,"url":"https://api.github.com/repos/kevinushey/ace","forks_url":"https://api.github.com/repos/kevinushey/ace/forks","keys_url":"https://api.github.com/repos/kevinushey/ace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinushey/ace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinushey/ace/teams","hooks_url":"https://api.github.com/repos/kevinushey/ace/hooks","issue_events_url":"https://api.github.com/repos/kevinushey/ace/issues/events{/number}","events_url":"https://api.github.com/repos/kevinushey/ace/events","assignees_url":"https://api.github.com/repos/kevinushey/ace/assignees{/user}","branches_url":"https://api.github.com/repos/kevinushey/ace/branches{/branch}","tags_url":"https://api.github.com/repos/kevinushey/ace/tags","blobs_url":"https://api.github.com/repos/kevinushey/ace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinushey/ace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinushey/ace/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinushey/ace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinushey/ace/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinushey/ace/languages","stargazers_url":"https://api.github.com/repos/kevinushey/ace/stargazers","contributors_url":"https://api.github.com/repos/kevinushey/ace/contributors","subscribers_url":"https://api.github.com/repos/kevinushey/ace/subscribers","subscription_url":"https://api.github.com/repos/kevinushey/ace/subscription","commits_url":"https://api.github.com/repos/kevinushey/ace/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinushey/ace/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinushey/ace/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinushey/ace/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinushey/ace/contents/{+path}","compare_url":"https://api.github.com/repos/kevinushey/ace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinushey/ace/merges","archive_url":"https://api.github.com/repos/kevinushey/ace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinushey/ace/downloads","issues_url":"https://api.github.com/repos/kevinushey/ace/issues{/number}","pulls_url":"https://api.github.com/repos/kevinushey/ace/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinushey/ace/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinushey/ace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinushey/ace/labels{/name}","releases_url":"https://api.github.com/repos/kevinushey/ace/releases{/id}","created_at":"2014-12-19T22:01:53Z","updated_at":"2014-12-19T22:01:57Z","pushed_at":"2015-10-07T19:46:21Z","git_url":"git://github.com/kevinushey/ace.git","ssh_url":"git@github.com:kevinushey/ace.git","clone_url":"https://github.com/kevinushey/ace.git","svn_url":"https://github.com/kevinushey/ace","homepage":"http://ace.c9.io","size":31892,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ajaxorg:master","ref":"master","sha":"e137ce698a5c68329303e719972cd49cff3f9a95","user":{"login":"ajaxorg","id":168515,"avatar_url":"https://avatars.githubusercontent.com/u/168515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaxorg","html_url":"https://github.com/ajaxorg","followers_url":"https://api.github.com/users/ajaxorg/followers","following_url":"https://api.github.com/users/ajaxorg/following{/other_user}","gists_url":"https://api.github.com/users/ajaxorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaxorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaxorg/subscriptions","organizations_url":"https://api.github.com/users/ajaxorg/orgs","repos_url":"https://api.github.com/users/ajaxorg/repos","events_url":"https://api.github.com/users/ajaxorg/events{/privacy}","received_events_url":"https://api.github.com/users/ajaxorg/received_events","type":"Organization","site_admin":false},"repo":{"id":1028340,"name":"ace","full_name":"ajaxorg/ace","owner":{"login":"ajaxorg","id":168515,"avatar_url":"https://avatars.githubusercontent.com/u/168515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaxorg","html_url":"https://github.com/ajaxorg","followers_url":"https://api.github.com/users/ajaxorg/followers","following_url":"https://api.github.com/users/ajaxorg/following{/other_user}","gists_url":"https://api.github.com/users/ajaxorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaxorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaxorg/subscriptions","organizations_url":"https://api.github.com/users/ajaxorg/orgs","repos_url":"https://api.github.com/users/ajaxorg/repos","events_url":"https://api.github.com/users/ajaxorg/events{/privacy}","received_events_url":"https://api.github.com/users/ajaxorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ajaxorg/ace","description":"Ace (Ajax.org Cloud9 Editor)","fork":false,"url":"https://api.github.com/repos/ajaxorg/ace","forks_url":"https://api.github.com/repos/ajaxorg/ace/forks","keys_url":"https://api.github.com/repos/ajaxorg/ace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajaxorg/ace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajaxorg/ace/teams","hooks_url":"https://api.github.com/repos/ajaxorg/ace/hooks","issue_events_url":"https://api.github.com/repos/ajaxorg/ace/issues/events{/number}","events_url":"https://api.github.com/repos/ajaxorg/ace/events","assignees_url":"https://api.github.com/repos/ajaxorg/ace/assignees{/user}","branches_url":"https://api.github.com/repos/ajaxorg/ace/branches{/branch}","tags_url":"https://api.github.com/repos/ajaxorg/ace/tags","blobs_url":"https://api.github.com/repos/ajaxorg/ace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajaxorg/ace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajaxorg/ace/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajaxorg/ace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajaxorg/ace/statuses/{sha}","languages_url":"https://api.github.com/repos/ajaxorg/ace/languages","stargazers_url":"https://api.github.com/repos/ajaxorg/ace/stargazers","contributors_url":"https://api.github.com/repos/ajaxorg/ace/contributors","subscribers_url":"https://api.github.com/repos/ajaxorg/ace/subscribers","subscription_url":"https://api.github.com/repos/ajaxorg/ace/subscription","commits_url":"https://api.github.com/repos/ajaxorg/ace/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajaxorg/ace/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajaxorg/ace/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajaxorg/ace/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajaxorg/ace/contents/{+path}","compare_url":"https://api.github.com/repos/ajaxorg/ace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajaxorg/ace/merges","archive_url":"https://api.github.com/repos/ajaxorg/ace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajaxorg/ace/downloads","issues_url":"https://api.github.com/repos/ajaxorg/ace/issues{/number}","pulls_url":"https://api.github.com/repos/ajaxorg/ace/pulls{/number}","milestones_url":"https://api.github.com/repos/ajaxorg/ace/milestones{/number}","notifications_url":"https://api.github.com/repos/ajaxorg/ace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajaxorg/ace/labels{/name}","releases_url":"https://api.github.com/repos/ajaxorg/ace/releases{/id}","created_at":"2010-10-27T10:43:36Z","updated_at":"2015-10-07T17:31:39Z","pushed_at":"2015-10-07T19:48:17Z","git_url":"git://github.com/ajaxorg/ace.git","ssh_url":"git@github.com:ajaxorg/ace.git","clone_url":"https://github.com/ajaxorg/ace.git","svn_url":"https://github.com/ajaxorg/ace","homepage":"http://ace.c9.io","size":59286,"stargazers_count":11424,"watchers_count":11424,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2684,"mirror_url":null,"open_issues_count":394,"forks":2684,"open_issues":394,"watchers":11424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/2692"},"html":{"href":"https://github.com/ajaxorg/ace/pull/2692"},"issue":{"href":"https://api.github.com/repos/ajaxorg/ace/issues/2692"},"comments":{"href":"https://api.github.com/repos/ajaxorg/ace/issues/2692/comments"},"review_comments":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/2692/comments"},"review_comment":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/2692/commits"},"statuses":{"href":"https://api.github.com/repos/ajaxorg/ace/statuses/8704fe23401c44a66f943651e9daf3787a54d569"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}