{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/25082684","id":25082684,"diff_hunk":"@@ -43,9 +43,9 @@ void snippet_library::add_snippet_from_json( const std::string &category, JsonOb\n \n int snippet_library::add_snippet(const std::string &category, const std::string &text)\n {\n-    int hash = djb2_hash( (const unsigned char *)text.c_str() );\n-    snippets.insert( std::pair<int, std::string>(hash, text) );\n-    categories.insert( std::pair<std::string, int>(category, hash) );\n+    auto const hash = static_cast<int>(std::hash<std::string> {}(text));\n+    snippets.insert( make_pair(hash, text) );\n+    categories.insert( make_pair(category, hash) );","path":"src/text_snippets.cpp","position":9,"original_position":9,"commit_id":"d43f191a281627589fd6e7dc0fee9ca8b4a8da8d","original_commit_id":"d43f191a281627589fd6e7dc0fee9ca8b4a8da8d","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"body":"A note in the snippets header perhaps, but there's no reason for the hash\nfunction to reference things that use it, that's just asking to get out of\nsync.\n","created_at":"2015-02-20T16:41:44Z","updated_at":"2015-02-20T16:41:44Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11305#discussion_r25082684","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/25082684"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11305#discussion_r25082684"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305","id":29510378,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11305","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11305.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11305.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11305","number":11305,"state":"closed","locked":false,"title":"A fix for seeding the rng under older win GCC","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"body":"+ fix seeding as the title says.\r\n+ eliminate `djb2_hash`.\r\n+ fix a likely old bug where even if a seed was used, the rng would be seeded again anyway.","created_at":"2015-02-18T09:14:50Z","updated_at":"2015-02-20T16:41:44Z","closed_at":"2015-02-20T06:42:08Z","merged_at":null,"merge_commit_sha":"d427ef7b159b865bd4eec1dddfad8d941b2c6a9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11305/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/d43f191a281627589fd6e7dc0fee9ca8b4a8da8d","head":{"label":"bkentel:fix-random-seed","ref":"fix-random-seed","sha":"d43f191a281627589fd6e7dc0fee9ca8b4a8da8d","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"repo":{"id":28679284,"name":"Cataclysm-DDA","full_name":"bkentel/Cataclysm-DDA","owner":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkentel/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/bkentel/Cataclysm-DDA","forks_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/releases{/id}","created_at":"2015-01-01T02:36:43Z","updated_at":"2015-02-20T14:25:30Z","pushed_at":"2015-02-20T14:25:29Z","git_url":"git://github.com/bkentel/Cataclysm-DDA.git","ssh_url":"git@github.com:bkentel/Cataclysm-DDA.git","clone_url":"https://github.com/bkentel/Cataclysm-DDA.git","svn_url":"https://github.com/bkentel/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":356464,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"14fea4514ebb5d161de81473ffd1aec5e2ab5aab","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-02-20T10:20:47Z","pushed_at":"2015-02-20T10:20:47Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":429088,"stargazers_count":606,"watchers_count":606,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"open_issues_count":836,"forks":652,"open_issues":836,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11305"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11305"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11305/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11305/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/d43f191a281627589fd6e7dc0fee9ca8b4a8da8d"}}}}