{"action":"created","issue":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/646","labels_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/646/comments","events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/646/events","html_url":"https://github.com/JioCloud/puppet-rjil/pull/646","id":87479985,"number":646,"title":"Use interface and ip address based on the subnet","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-11T20:07:52Z","updated_at":"2015-06-25T03:43:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/646","html_url":"https://github.com/JioCloud/puppet-rjil/pull/646","diff_url":"https://github.com/JioCloud/puppet-rjil/pull/646.diff","patch_url":"https://github.com/JioCloud/puppet-rjil/pull/646.patch"},"body":"Currently we assume that the ip address we need to configure in the cloud is\r\nalways setup on same interface on a specific set of servers/cloud provider,\r\nwhich can be incorrect because of number of reasons\r\n1. what if we had to use different nic port because of one bad port\r\n2. compute node have the ip of physical interface will be moved to vhost0 in\r\nwhich case you need special consideration - like custom facts\r\n\r\nRather the subnet is more consistent, this patch adds code to create custom\r\nfacts for ipaddress and interface based on subnet like interface_10_0_0_0_8 with\r\nvalue eth0 in case eth0 have subnet configured 10.0.0.0/8.\r\n\r\nThis will allow us to use the fact ipaddress_{subnet} and interface_{subnet}\r\nwhereever required, as far as correct subnet provided, this will provide\r\nconsistant network config across the servers.\r\n\r\nThis should fix the issue #643."},"comment":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/comments/115091828","html_url":"https://github.com/JioCloud/puppet-rjil/pull/646#issuecomment-115091828","issue_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/646","id":115091828,"user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"created_at":"2015-06-25T03:43:10Z","updated_at":"2015-06-25T03:43:10Z","body":"@bodepd @sorenh could you please review it. I have triggered a test build, if all goes well, I would like to get it merged - so I dont have to create another set of facts for undercloud prestaging work. "}}