{"action":"created","issue":{"url":"https://api.github.com/repos/FortySevenEffects/arduino_midi_library/issues/33","labels_url":"https://api.github.com/repos/FortySevenEffects/arduino_midi_library/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/FortySevenEffects/arduino_midi_library/issues/33/comments","events_url":"https://api.github.com/repos/FortySevenEffects/arduino_midi_library/issues/33/events","html_url":"https://github.com/FortySevenEffects/arduino_midi_library/issues/33","id":69578646,"number":33,"title":"MIDI_CREATE_DEFAULT_INSTANCE","user":{"login":"NicoHood","id":6888294,"avatar_url":"https://avatars.githubusercontent.com/u/6888294?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoHood","html_url":"https://github.com/NicoHood","followers_url":"https://api.github.com/users/NicoHood/followers","following_url":"https://api.github.com/users/NicoHood/following{/other_user}","gists_url":"https://api.github.com/users/NicoHood/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoHood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoHood/subscriptions","organizations_url":"https://api.github.com/users/NicoHood/orgs","repos_url":"https://api.github.com/users/NicoHood/repos","events_url":"https://api.github.com/users/NicoHood/events{/privacy}","received_events_url":"https://api.github.com/users/NicoHood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-20T12:43:48Z","updated_at":"2015-04-21T14:39:59Z","closed_at":null,"body":"Is it possible that you can replace this:\r\nhttps://github.com/FortySevenEffects/arduino_midi_library/blob/master/src/midi_Defs.h#L172\r\n\r\nWith this now:\r\nhttps://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/variants/leonardo/pins_arduino.h#L358\r\n\r\nEven 1.0.6 compatible:\r\nhttps://github.com/arduino/Arduino/blob/ide-1.0.x/hardware/arduino/variants/leonardo/pins_arduino.h\r\n\r\nNot sure if the older 1.0.5 has this definition, but its outdated. This definition is more general and should work with more MCUs."},"comment":{"url":"https://api.github.com/repos/FortySevenEffects/arduino_midi_library/issues/comments/94818779","html_url":"https://github.com/FortySevenEffects/arduino_midi_library/issues/33#issuecomment-94818779","issue_url":"https://api.github.com/repos/FortySevenEffects/arduino_midi_library/issues/33","id":94818779,"user":{"login":"Nantonos","id":2506926,"avatar_url":"https://avatars.githubusercontent.com/u/2506926?v=3","gravatar_id":"","url":"https://api.github.com/users/Nantonos","html_url":"https://github.com/Nantonos","followers_url":"https://api.github.com/users/Nantonos/followers","following_url":"https://api.github.com/users/Nantonos/following{/other_user}","gists_url":"https://api.github.com/users/Nantonos/gists{/gist_id}","starred_url":"https://api.github.com/users/Nantonos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nantonos/subscriptions","organizations_url":"https://api.github.com/users/Nantonos/orgs","repos_url":"https://api.github.com/users/Nantonos/repos","events_url":"https://api.github.com/users/Nantonos/events{/privacy}","received_events_url":"https://api.github.com/users/Nantonos/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T14:39:59Z","updated_at":"2015-04-21T14:39:59Z","body":"It is not clear that SERIAL_PORT_HARDWARE would do the right thing on Arduino DUE.\r\n\r\nOn DUE, I see these\r\n#define SERIAL_PORT_MONITOR         Serial\r\n#define SERIAL_PORT_USBVIRTUAL      SerialUSB\r\n#define SERIAL_PORT_HARDWARE_OPEN   Serial1\r\n#define SERIAL_PORT_HARDWARE_OPEN1  Serial2\r\n#define SERIAL_PORT_HARDWARE_OPEN2  Serial3\r\n#define SERIAL_PORT_HARDWARE        Serial\r\n#define SERIAL_PORT_HARDWARE1       Serial1\r\n#define SERIAL_PORT_HARDWARE2       Serial2\r\n#define SERIAL_PORT_HARDWARE3       Serial3\r\n\r\nOn Leonardo, in variants/leonardo/pins_arduino.h I see\r\n#define SERIAL_PORT_MONITOR        Serial\r\n#define SERIAL_PORT_USBVIRTUAL     Serial\r\n#define SERIAL_PORT_HARDWARE       Serial1\r\n#define SERIAL_PORT_HARDWARE_OPEN  Serial1\r\n(note that HARDWARE1 is not defined)\r\n\r\nOn Robot, in variants/robot_motor/pins_arduino.h there is\r\n#define SERIAL_PORT_MONITOR        Serial\r\n#define SERIAL_PORT_USBVIRTUAL     Serial\r\n#define SERIAL_PORT_HARDWARE       Serial1\r\n(which is annoying, as SERIAL_PORT_HARDWARE_OPEN is not defined)\r\n\r\nsimilarly for Robot, in variants/robot_control/pins_arduino.h there is\r\n#define SERIAL_PORT_MONITOR        Serial\r\n#define SERIAL_PORT_USBVIRTUAL     Serial\r\n#define SERIAL_PORT_HARDWARE       Serial1\r\n\r\nfor Teensy 3.0 and 3.1, in teensy/cores/teensy3/pins_arduino.h is\r\n#define SERIAL_PORT_MONITOR             Serial\r\n#define SERIAL_PORT_USBVIRTUAL          Serial\r\n#define SERIAL_PORT_HARDWARE            Serial1\r\n#define SERIAL_PORT_HARDWARE1           Serial2\r\n#define SERIAL_PORT_HARDWARE2           Serial3\r\n#define SERIAL_PORT_HARDWARE_OPEN       Serial1\r\n#define SERIAL_PORT_HARDWARE_OPEN1      Serial2\r\n#define SERIAL_PORT_HARDWARE_OPEN2      Serial3\r\n"}}