{"comment":{"url":"https://api.github.com/repos/jgm/cmark/comments/11725149","html_url":"https://github.com/jgm/cmark/commit/cdcb65c5a209a1a3be4a1b9e804f5a4292127509#commitcomment-11725149","id":11725149,"user":{"login":"nwellnhof","id":63962,"avatar_url":"https://avatars.githubusercontent.com/u/63962?v=3","gravatar_id":"","url":"https://api.github.com/users/nwellnhof","html_url":"https://github.com/nwellnhof","followers_url":"https://api.github.com/users/nwellnhof/followers","following_url":"https://api.github.com/users/nwellnhof/following{/other_user}","gists_url":"https://api.github.com/users/nwellnhof/gists{/gist_id}","starred_url":"https://api.github.com/users/nwellnhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwellnhof/subscriptions","organizations_url":"https://api.github.com/users/nwellnhof/orgs","repos_url":"https://api.github.com/users/nwellnhof/repos","events_url":"https://api.github.com/users/nwellnhof/events{/privacy}","received_events_url":"https://api.github.com/users/nwellnhof/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"cdcb65c5a209a1a3be4a1b9e804f5a4292127509","created_at":"2015-06-17T13:38:18Z","updated_at":"2015-06-17T13:38:18Z","body":"On 17/06/2015 02:37, John MacFarlane wrote:\n> OK, tried your lightweight approach (if I understood it\n> right). Performance is a bit worse for the test case\n> with a million entities (roughly 96 vs 76) but I don't\n> think I'm too worried about that. Performance shouldn't\n> be at all degraded for sources without many entities.\n\nYes, that's what I had in mind.\n\nMaybe we should rename entities.h to entities.inc. Like case_fold_switch.inc \nit isn't actually a header file but the auto-generated part of a source file. \nAny other source file including entities.h would create its own private copy \nof the table.\n\n> It did significantly reduce the binary size -- though as\n> I explained in my last message, I'm still not sure why.\n> I'm probably missing something simple.\n\nI have no idea.\n\nNick\n\n"}}