{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/14","id":20655216,"html_url":"https://github.com/synapsestudios/synapse-common/pull/14","diff_url":"https://github.com/synapsestudios/synapse-common/pull/14.diff","patch_url":"https://github.com/synapsestudios/synapse-common/pull/14.patch","issue_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues/14","number":14,"state":"closed","locked":false,"title":"Make underscore a dependency","user":{"login":"synbot","id":341352,"avatar_url":"https://avatars.githubusercontent.com/u/341352?v=3","gravatar_id":"","url":"https://api.github.com/users/synbot","html_url":"https://github.com/synbot","followers_url":"https://api.github.com/users/synbot/followers","following_url":"https://api.github.com/users/synbot/following{/other_user}","gists_url":"https://api.github.com/users/synbot/gists{/gist_id}","starred_url":"https://api.github.com/users/synbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synbot/subscriptions","organizations_url":"https://api.github.com/users/synbot/orgs","repos_url":"https://api.github.com/users/synbot/repos","events_url":"https://api.github.com/users/synbot/events{/privacy}","received_events_url":"https://api.github.com/users/synbot/received_events","type":"User","site_admin":false},"body":"Underscore is used directly by synapse-common, not as a plugin. It needs to be listed as a dependency.\r\n\r\n### Acceptance Criteria\r\n1. Make underscore (and Q) a dependency, not a devDependency\r\n1. Update underscore to 1.7.0","created_at":"2014-09-03T04:28:01Z","updated_at":"2015-02-05T22:56:03Z","closed_at":"2015-02-05T22:56:03Z","merged_at":"2015-02-05T22:56:03Z","merge_commit_sha":"61a85c2f4568710549db6aca995813ba6b107d5c","assignee":{"login":"areida","id":369030,"avatar_url":"https://avatars.githubusercontent.com/u/369030?v=3","gravatar_id":"","url":"https://api.github.com/users/areida","html_url":"https://github.com/areida","followers_url":"https://api.github.com/users/areida/followers","following_url":"https://api.github.com/users/areida/following{/other_user}","gists_url":"https://api.github.com/users/areida/gists{/gist_id}","starred_url":"https://api.github.com/users/areida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/areida/subscriptions","organizations_url":"https://api.github.com/users/areida/orgs","repos_url":"https://api.github.com/users/areida/repos","events_url":"https://api.github.com/users/areida/events{/privacy}","received_events_url":"https://api.github.com/users/areida/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/synapsestudios/synapse-common/milestones/1","labels_url":"https://api.github.com/repos/synapsestudios/synapse-common/milestones/1/labels","id":708259,"number":1,"title":"Sprint ∞","description":"","creator":{"login":"bobeagan","id":100226,"avatar_url":"https://avatars.githubusercontent.com/u/100226?v=3","gravatar_id":"","url":"https://api.github.com/users/bobeagan","html_url":"https://github.com/bobeagan","followers_url":"https://api.github.com/users/bobeagan/followers","following_url":"https://api.github.com/users/bobeagan/following{/other_user}","gists_url":"https://api.github.com/users/bobeagan/gists{/gist_id}","starred_url":"https://api.github.com/users/bobeagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobeagan/subscriptions","organizations_url":"https://api.github.com/users/bobeagan/orgs","repos_url":"https://api.github.com/users/bobeagan/repos","events_url":"https://api.github.com/users/bobeagan/events{/privacy}","received_events_url":"https://api.github.com/users/bobeagan/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":26,"state":"open","created_at":"2014-07-02T16:18:14Z","updated_at":"2015-02-05T22:56:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/14/commits","review_comments_url":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/14/comments","review_comment_url":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/comments/{number}","comments_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues/14/comments","statuses_url":"https://api.github.com/repos/synapsestudios/synapse-common/statuses/cde9c5f9cdab3373968775a18400e728fe52fd7a","head":{"label":"synapsestudios:feature/14-underscore-dependency","ref":"feature/14-underscore-dependency","sha":"cde9c5f9cdab3373968775a18400e728fe52fd7a","user":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars.githubusercontent.com/u/197868?v=3","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"repo":{"id":19247850,"name":"synapse-common","full_name":"synapsestudios/synapse-common","owner":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars.githubusercontent.com/u/197868?v=3","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/synapsestudios/synapse-common","description":"","fork":false,"url":"https://api.github.com/repos/synapsestudios/synapse-common","forks_url":"https://api.github.com/repos/synapsestudios/synapse-common/forks","keys_url":"https://api.github.com/repos/synapsestudios/synapse-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/synapsestudios/synapse-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/synapsestudios/synapse-common/teams","hooks_url":"https://api.github.com/repos/synapsestudios/synapse-common/hooks","issue_events_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues/events{/number}","events_url":"https://api.github.com/repos/synapsestudios/synapse-common/events","assignees_url":"https://api.github.com/repos/synapsestudios/synapse-common/assignees{/user}","branches_url":"https://api.github.com/repos/synapsestudios/synapse-common/branches{/branch}","tags_url":"https://api.github.com/repos/synapsestudios/synapse-common/tags","blobs_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/synapsestudios/synapse-common/statuses/{sha}","languages_url":"https://api.github.com/repos/synapsestudios/synapse-common/languages","stargazers_url":"https://api.github.com/repos/synapsestudios/synapse-common/stargazers","contributors_url":"https://api.github.com/repos/synapsestudios/synapse-common/contributors","subscribers_url":"https://api.github.com/repos/synapsestudios/synapse-common/subscribers","subscription_url":"https://api.github.com/repos/synapsestudios/synapse-common/subscription","commits_url":"https://api.github.com/repos/synapsestudios/synapse-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/synapsestudios/synapse-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues/comments/{number}","contents_url":"https://api.github.com/repos/synapsestudios/synapse-common/contents/{+path}","compare_url":"https://api.github.com/repos/synapsestudios/synapse-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/synapsestudios/synapse-common/merges","archive_url":"https://api.github.com/repos/synapsestudios/synapse-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/synapsestudios/synapse-common/downloads","issues_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues{/number}","pulls_url":"https://api.github.com/repos/synapsestudios/synapse-common/pulls{/number}","milestones_url":"https://api.github.com/repos/synapsestudios/synapse-common/milestones{/number}","notifications_url":"https://api.github.com/repos/synapsestudios/synapse-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/synapsestudios/synapse-common/labels{/name}","releases_url":"https://api.github.com/repos/synapsestudios/synapse-common/releases{/id}","created_at":"2014-04-28T17:40:09Z","updated_at":"2015-02-05T21:55:38Z","pushed_at":"2015-02-05T22:56:03Z","git_url":"git://github.com/synapsestudios/synapse-common.git","ssh_url":"git@github.com:synapsestudios/synapse-common.git","clone_url":"https://github.com/synapsestudios/synapse-common.git","svn_url":"https://github.com/synapsestudios/synapse-common","homepage":null,"size":728,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"synapsestudios:master","ref":"master","sha":"c2ca709802ab4dbbba59cb25763f7fad417e4b4d","user":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars.githubusercontent.com/u/197868?v=3","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"repo":{"id":19247850,"name":"synapse-common","full_name":"synapsestudios/synapse-common","owner":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars.githubusercontent.com/u/197868?v=3","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/synapsestudios/synapse-common","description":"","fork":false,"url":"https://api.github.com/repos/synapsestudios/synapse-common","forks_url":"https://api.github.com/repos/synapsestudios/synapse-common/forks","keys_url":"https://api.github.com/repos/synapsestudios/synapse-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/synapsestudios/synapse-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/synapsestudios/synapse-common/teams","hooks_url":"https://api.github.com/repos/synapsestudios/synapse-common/hooks","issue_events_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues/events{/number}","events_url":"https://api.github.com/repos/synapsestudios/synapse-common/events","assignees_url":"https://api.github.com/repos/synapsestudios/synapse-common/assignees{/user}","branches_url":"https://api.github.com/repos/synapsestudios/synapse-common/branches{/branch}","tags_url":"https://api.github.com/repos/synapsestudios/synapse-common/tags","blobs_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/synapsestudios/synapse-common/statuses/{sha}","languages_url":"https://api.github.com/repos/synapsestudios/synapse-common/languages","stargazers_url":"https://api.github.com/repos/synapsestudios/synapse-common/stargazers","contributors_url":"https://api.github.com/repos/synapsestudios/synapse-common/contributors","subscribers_url":"https://api.github.com/repos/synapsestudios/synapse-common/subscribers","subscription_url":"https://api.github.com/repos/synapsestudios/synapse-common/subscription","commits_url":"https://api.github.com/repos/synapsestudios/synapse-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/synapsestudios/synapse-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/synapsestudios/synapse-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues/comments/{number}","contents_url":"https://api.github.com/repos/synapsestudios/synapse-common/contents/{+path}","compare_url":"https://api.github.com/repos/synapsestudios/synapse-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/synapsestudios/synapse-common/merges","archive_url":"https://api.github.com/repos/synapsestudios/synapse-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/synapsestudios/synapse-common/downloads","issues_url":"https://api.github.com/repos/synapsestudios/synapse-common/issues{/number}","pulls_url":"https://api.github.com/repos/synapsestudios/synapse-common/pulls{/number}","milestones_url":"https://api.github.com/repos/synapsestudios/synapse-common/milestones{/number}","notifications_url":"https://api.github.com/repos/synapsestudios/synapse-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/synapsestudios/synapse-common/labels{/name}","releases_url":"https://api.github.com/repos/synapsestudios/synapse-common/releases{/id}","created_at":"2014-04-28T17:40:09Z","updated_at":"2015-02-05T21:55:38Z","pushed_at":"2015-02-05T22:56:03Z","git_url":"git://github.com/synapsestudios/synapse-common.git","ssh_url":"git@github.com:synapsestudios/synapse-common.git","clone_url":"https://github.com/synapsestudios/synapse-common.git","svn_url":"https://github.com/synapsestudios/synapse-common","homepage":null,"size":728,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/14"},"html":{"href":"https://github.com/synapsestudios/synapse-common/pull/14"},"issue":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/issues/14"},"comments":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/synapsestudios/synapse-common/statuses/cde9c5f9cdab3373968775a18400e728fe52fd7a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"paulstatezny","id":4662353,"avatar_url":"https://avatars.githubusercontent.com/u/4662353?v=3","gravatar_id":"","url":"https://api.github.com/users/paulstatezny","html_url":"https://github.com/paulstatezny","followers_url":"https://api.github.com/users/paulstatezny/followers","following_url":"https://api.github.com/users/paulstatezny/following{/other_user}","gists_url":"https://api.github.com/users/paulstatezny/gists{/gist_id}","starred_url":"https://api.github.com/users/paulstatezny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulstatezny/subscriptions","organizations_url":"https://api.github.com/users/paulstatezny/orgs","repos_url":"https://api.github.com/users/paulstatezny/repos","events_url":"https://api.github.com/users/paulstatezny/events{/privacy}","received_events_url":"https://api.github.com/users/paulstatezny/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}