{"action":"opened","number":1369,"pull_request":{"url":"https://api.github.com/repos/opencog/opencog/pulls/1369","id":30696632,"html_url":"https://github.com/opencog/opencog/pull/1369","diff_url":"https://github.com/opencog/opencog/pull/1369.diff","patch_url":"https://github.com/opencog/opencog/pull/1369.patch","issue_url":"https://api.github.com/repos/opencog/opencog/issues/1369","number":1369,"state":"open","locked":false,"title":"Refactor user function calls and added test to PythonEvalUTest","user":{"login":"inflector","id":1048706,"avatar_url":"https://avatars.githubusercontent.com/u/1048706?v=3","gravatar_id":"","url":"https://api.github.com/users/inflector","html_url":"https://github.com/inflector","followers_url":"https://api.github.com/users/inflector/followers","following_url":"https://api.github.com/users/inflector/following{/other_user}","gists_url":"https://api.github.com/users/inflector/gists{/gist_id}","starred_url":"https://api.github.com/users/inflector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inflector/subscriptions","organizations_url":"https://api.github.com/users/inflector/orgs","repos_url":"https://api.github.com/users/inflector/repos","events_url":"https://api.github.com/users/inflector/events{/privacy}","received_events_url":"https://api.github.com/users/inflector/received_events","type":"User","site_admin":false},"body":"1. Refactored the way user functions are called so now both `Handle PythonEval::apply` and `TruthValuePtr PythonEval::apply_tv` use the same code.\r\n1. Refactored the Python error message building code so it's now in once place.\r\n1. Added test of cog-execute and cog-evaluate nodes to test `PythonEval::apply` and `PythonEval::apply_tv` to PythonEvalUTest.\r\n\r\nThere is one more significant refactor left that is not part of this pull request, the change to direct execution of user functions from the current Python function `execute_user_function` calling the user function.","created_at":"2015-03-07T03:43:24Z","updated_at":"2015-03-07T03:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencog/opencog/pulls/1369/commits","review_comments_url":"https://api.github.com/repos/opencog/opencog/pulls/1369/comments","review_comment_url":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/opencog/issues/1369/comments","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/66c287206d5460ca133031013e153af32e41c2e0","head":{"label":"inflector:refactor-and-test","ref":"refactor-and-test","sha":"66c287206d5460ca133031013e153af32e41c2e0","user":{"login":"inflector","id":1048706,"avatar_url":"https://avatars.githubusercontent.com/u/1048706?v=3","gravatar_id":"","url":"https://api.github.com/users/inflector","html_url":"https://github.com/inflector","followers_url":"https://api.github.com/users/inflector/followers","following_url":"https://api.github.com/users/inflector/following{/other_user}","gists_url":"https://api.github.com/users/inflector/gists{/gist_id}","starred_url":"https://api.github.com/users/inflector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inflector/subscriptions","organizations_url":"https://api.github.com/users/inflector/orgs","repos_url":"https://api.github.com/users/inflector/repos","events_url":"https://api.github.com/users/inflector/events{/privacy}","received_events_url":"https://api.github.com/users/inflector/received_events","type":"User","site_admin":false},"repo":{"id":30973962,"name":"opencog","full_name":"inflector/opencog","owner":{"login":"inflector","id":1048706,"avatar_url":"https://avatars.githubusercontent.com/u/1048706?v=3","gravatar_id":"","url":"https://api.github.com/users/inflector","html_url":"https://github.com/inflector","followers_url":"https://api.github.com/users/inflector/followers","following_url":"https://api.github.com/users/inflector/following{/other_user}","gists_url":"https://api.github.com/users/inflector/gists{/gist_id}","starred_url":"https://api.github.com/users/inflector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inflector/subscriptions","organizations_url":"https://api.github.com/users/inflector/orgs","repos_url":"https://api.github.com/users/inflector/repos","events_url":"https://api.github.com/users/inflector/events{/privacy}","received_events_url":"https://api.github.com/users/inflector/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inflector/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":true,"url":"https://api.github.com/repos/inflector/opencog","forks_url":"https://api.github.com/repos/inflector/opencog/forks","keys_url":"https://api.github.com/repos/inflector/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inflector/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inflector/opencog/teams","hooks_url":"https://api.github.com/repos/inflector/opencog/hooks","issue_events_url":"https://api.github.com/repos/inflector/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/inflector/opencog/events","assignees_url":"https://api.github.com/repos/inflector/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/inflector/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/inflector/opencog/tags","blobs_url":"https://api.github.com/repos/inflector/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inflector/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inflector/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/inflector/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inflector/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/inflector/opencog/languages","stargazers_url":"https://api.github.com/repos/inflector/opencog/stargazers","contributors_url":"https://api.github.com/repos/inflector/opencog/contributors","subscribers_url":"https://api.github.com/repos/inflector/opencog/subscribers","subscription_url":"https://api.github.com/repos/inflector/opencog/subscription","commits_url":"https://api.github.com/repos/inflector/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/inflector/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/inflector/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/inflector/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/inflector/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/inflector/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inflector/opencog/merges","archive_url":"https://api.github.com/repos/inflector/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inflector/opencog/downloads","issues_url":"https://api.github.com/repos/inflector/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/inflector/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/inflector/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/inflector/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inflector/opencog/labels{/name}","releases_url":"https://api.github.com/repos/inflector/opencog/releases{/id}","created_at":"2015-02-18T16:26:02Z","updated_at":"2015-03-07T03:19:37Z","pushed_at":"2015-03-07T03:20:58Z","git_url":"git://github.com/inflector/opencog.git","ssh_url":"git@github.com:inflector/opencog.git","clone_url":"https://github.com/inflector/opencog.git","svn_url":"https://github.com/inflector/opencog","homepage":"http://wiki.opencog.org/w/Development","size":136216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"5eb89e935ffb8ee97fa680078fec7e1c2b5f28fa","user":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":6365343,"name":"opencog","full_name":"opencog/opencog","owner":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":false,"url":"https://api.github.com/repos/opencog/opencog","forks_url":"https://api.github.com/repos/opencog/opencog/forks","keys_url":"https://api.github.com/repos/opencog/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/opencog/teams","hooks_url":"https://api.github.com/repos/opencog/opencog/hooks","issue_events_url":"https://api.github.com/repos/opencog/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/opencog/events","assignees_url":"https://api.github.com/repos/opencog/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/opencog/tags","blobs_url":"https://api.github.com/repos/opencog/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/opencog/languages","stargazers_url":"https://api.github.com/repos/opencog/opencog/stargazers","contributors_url":"https://api.github.com/repos/opencog/opencog/contributors","subscribers_url":"https://api.github.com/repos/opencog/opencog/subscribers","subscription_url":"https://api.github.com/repos/opencog/opencog/subscription","commits_url":"https://api.github.com/repos/opencog/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/opencog/merges","archive_url":"https://api.github.com/repos/opencog/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/opencog/downloads","issues_url":"https://api.github.com/repos/opencog/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/opencog/labels{/name}","releases_url":"https://api.github.com/repos/opencog/opencog/releases{/id}","created_at":"2012-10-24T06:10:15Z","updated_at":"2015-03-07T01:04:21Z","pushed_at":"2015-03-06T21:32:34Z","git_url":"git://github.com/opencog/opencog.git","ssh_url":"git@github.com:opencog/opencog.git","clone_url":"https://github.com/opencog/opencog.git","svn_url":"https://github.com/opencog/opencog","homepage":"http://wiki.opencog.org/w/Development","size":146721,"stargazers_count":514,"watchers_count":514,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":78,"forks":247,"open_issues":78,"watchers":514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1369"},"html":{"href":"https://github.com/opencog/opencog/pull/1369"},"issue":{"href":"https://api.github.com/repos/opencog/opencog/issues/1369"},"comments":{"href":"https://api.github.com/repos/opencog/opencog/issues/1369/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1369/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1369/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/opencog/statuses/66c287206d5460ca133031013e153af32e41c2e0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":266,"deletions":244,"changed_files":6}}