{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/41925234","id":41925234,"diff_hunk":"@@ -147,6 +147,44 @@ describe('ReactDOMComponent', function() {\n       expect(console.error.argsForCall.length).toBe(2);\n     });\n \n+    it('should warn about styles with numeric string values for non-unitless properties', function() {\n+      spyOn(console, 'error');\n+\n+      var div = document.createElement('div');\n+      var One = React.createClass({\n+        render: function() {\n+          return this.props.inline ? <span style={{fontSize: '1'}} /> : <div style={{fontSize: '1'}} />;\n+        }","path":"src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js","position":24,"original_position":24,"commit_id":"4416cd6c0da2111e96cbbbb6ff696fd488fee6f8","original_commit_id":"4416cd6c0da2111e96cbbbb6ff696fd488fee6f8","user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"body":"Linter requires trailing comma.  You can run the linter by executing `npm run lint`","created_at":"2015-10-13T21:06:00Z","updated_at":"2015-10-13T21:06:00Z","html_url":"https://github.com/facebook/react/pull/5140#discussion_r41925234","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/5140","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/41925234"},"html":{"href":"https://github.com/facebook/react/pull/5140#discussion_r41925234"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/5140"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/5140","id":47432866,"html_url":"https://github.com/facebook/react/pull/5140","diff_url":"https://github.com/facebook/react/pull/5140.diff","patch_url":"https://github.com/facebook/react/pull/5140.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/5140","number":5140,"state":"open","locked":false,"title":"Fix #1357. Don't append \"px\" suffix to CSS string values.","user":{"login":"pluma","id":1280922,"avatar_url":"https://avatars.githubusercontent.com/u/1280922?v=3","gravatar_id":"","url":"https://api.github.com/users/pluma","html_url":"https://github.com/pluma","followers_url":"https://api.github.com/users/pluma/followers","following_url":"https://api.github.com/users/pluma/following{/other_user}","gists_url":"https://api.github.com/users/pluma/gists{/gist_id}","starred_url":"https://api.github.com/users/pluma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluma/subscriptions","organizations_url":"https://api.github.com/users/pluma/orgs","repos_url":"https://api.github.com/users/pluma/repos","events_url":"https://api.github.com/users/pluma/events{/privacy}","received_events_url":"https://api.github.com/users/pluma/received_events","type":"User","site_admin":false},"body":"This implements the change discussed in #1357 by simply not appending \"px\" if the CSS value is already a string.","created_at":"2015-10-12T15:29:30Z","updated_at":"2015-10-13T21:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae491d3eb084c7d9f422851e12ba1e4db0729bb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/5140/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/5140/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/5140/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/4416cd6c0da2111e96cbbbb6ff696fd488fee6f8","head":{"label":"pluma:patch-1","ref":"patch-1","sha":"4416cd6c0da2111e96cbbbb6ff696fd488fee6f8","user":{"login":"pluma","id":1280922,"avatar_url":"https://avatars.githubusercontent.com/u/1280922?v=3","gravatar_id":"","url":"https://api.github.com/users/pluma","html_url":"https://github.com/pluma","followers_url":"https://api.github.com/users/pluma/followers","following_url":"https://api.github.com/users/pluma/following{/other_user}","gists_url":"https://api.github.com/users/pluma/gists{/gist_id}","starred_url":"https://api.github.com/users/pluma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluma/subscriptions","organizations_url":"https://api.github.com/users/pluma/orgs","repos_url":"https://api.github.com/users/pluma/repos","events_url":"https://api.github.com/users/pluma/events{/privacy}","received_events_url":"https://api.github.com/users/pluma/received_events","type":"User","site_admin":false},"repo":{"id":44115021,"name":"react","full_name":"pluma/react","owner":{"login":"pluma","id":1280922,"avatar_url":"https://avatars.githubusercontent.com/u/1280922?v=3","gravatar_id":"","url":"https://api.github.com/users/pluma","html_url":"https://github.com/pluma","followers_url":"https://api.github.com/users/pluma/followers","following_url":"https://api.github.com/users/pluma/following{/other_user}","gists_url":"https://api.github.com/users/pluma/gists{/gist_id}","starred_url":"https://api.github.com/users/pluma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluma/subscriptions","organizations_url":"https://api.github.com/users/pluma/orgs","repos_url":"https://api.github.com/users/pluma/repos","events_url":"https://api.github.com/users/pluma/events{/privacy}","received_events_url":"https://api.github.com/users/pluma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pluma/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/pluma/react","forks_url":"https://api.github.com/repos/pluma/react/forks","keys_url":"https://api.github.com/repos/pluma/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluma/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluma/react/teams","hooks_url":"https://api.github.com/repos/pluma/react/hooks","issue_events_url":"https://api.github.com/repos/pluma/react/issues/events{/number}","events_url":"https://api.github.com/repos/pluma/react/events","assignees_url":"https://api.github.com/repos/pluma/react/assignees{/user}","branches_url":"https://api.github.com/repos/pluma/react/branches{/branch}","tags_url":"https://api.github.com/repos/pluma/react/tags","blobs_url":"https://api.github.com/repos/pluma/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluma/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluma/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluma/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluma/react/statuses/{sha}","languages_url":"https://api.github.com/repos/pluma/react/languages","stargazers_url":"https://api.github.com/repos/pluma/react/stargazers","contributors_url":"https://api.github.com/repos/pluma/react/contributors","subscribers_url":"https://api.github.com/repos/pluma/react/subscribers","subscription_url":"https://api.github.com/repos/pluma/react/subscription","commits_url":"https://api.github.com/repos/pluma/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluma/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluma/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluma/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluma/react/contents/{+path}","compare_url":"https://api.github.com/repos/pluma/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluma/react/merges","archive_url":"https://api.github.com/repos/pluma/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluma/react/downloads","issues_url":"https://api.github.com/repos/pluma/react/issues{/number}","pulls_url":"https://api.github.com/repos/pluma/react/pulls{/number}","milestones_url":"https://api.github.com/repos/pluma/react/milestones{/number}","notifications_url":"https://api.github.com/repos/pluma/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluma/react/labels{/name}","releases_url":"https://api.github.com/repos/pluma/react/releases{/id}","created_at":"2015-10-12T15:05:22Z","updated_at":"2015-10-12T15:05:28Z","pushed_at":"2015-10-13T18:42:00Z","git_url":"git://github.com/pluma/react.git","ssh_url":"git@github.com:pluma/react.git","clone_url":"https://github.com/pluma/react.git","svn_url":"https://github.com/pluma/react","homepage":"https://facebook.github.io/react/","size":67125,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"01817c143c3cf3cb552e4c898dad78774f85a431","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","created_at":"2013-05-24T16:15:54Z","updated_at":"2015-10-13T21:04:48Z","pushed_at":"2015-10-13T19:19:24Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":117357,"stargazers_count":29503,"watchers_count":29503,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4505,"mirror_url":null,"open_issues_count":560,"forks":4505,"open_issues":560,"watchers":29503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/5140"},"html":{"href":"https://github.com/facebook/react/pull/5140"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/5140"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/5140/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/5140/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/5140/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/4416cd6c0da2111e96cbbbb6ff696fd488fee6f8"}}}}