{"action":"opened","number":29,"pull_request":{"url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/29","id":51866019,"html_url":"https://github.com/CVM/Magento_GoogleTagManager/pull/29","diff_url":"https://github.com/CVM/Magento_GoogleTagManager/pull/29.diff","patch_url":"https://github.com/CVM/Magento_GoogleTagManager/pull/29.patch","issue_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues/29","number":29,"state":"open","locked":false,"title":"Only output transactionShippingMethod for non-virtual Orders","user":{"login":"wpalmer","id":357044,"avatar_url":"https://avatars.githubusercontent.com/u/357044?v=3","gravatar_id":"","url":"https://api.github.com/users/wpalmer","html_url":"https://github.com/wpalmer","followers_url":"https://api.github.com/users/wpalmer/followers","following_url":"https://api.github.com/users/wpalmer/following{/other_user}","gists_url":"https://api.github.com/users/wpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/wpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpalmer/subscriptions","organizations_url":"https://api.github.com/users/wpalmer/orgs","repos_url":"https://api.github.com/users/wpalmer/repos","events_url":"https://api.github.com/users/wpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/wpalmer/received_events","type":"User","site_admin":false},"body":"transactionShippingMethod was unconditionally attempting to output the\r\nshipping \"Carrier Code\". This is fine in most cases, but for \"virtual\"\r\norders, no CarrierCode is defined, resulting in an illegal offset error\r\n(internal to Magento) when the non-existent carrier information is\r\nrequested.\r\n\r\nTo avoid this, add a ->getIsVirtual() check on the $order, and only\r\nrequest Shipping Carrier information for non-Virtual orders. This is the\r\nsame logic (though not exactly the same method) used within core Magento\r\ncode within the Checkout process, and so appears to be an expected\r\ncondition for accessing such data.","created_at":"2015-11-26T02:16:03Z","updated_at":"2015-11-26T02:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/29/commits","review_comments_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/29/comments","review_comment_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues/29/comments","statuses_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/statuses/766fdc0f05c32eecf48f936bc755e7d9ec72b4ae","head":{"label":"wpalmer:virtual-orders-fix","ref":"virtual-orders-fix","sha":"766fdc0f05c32eecf48f936bc755e7d9ec72b4ae","user":{"login":"wpalmer","id":357044,"avatar_url":"https://avatars.githubusercontent.com/u/357044?v=3","gravatar_id":"","url":"https://api.github.com/users/wpalmer","html_url":"https://github.com/wpalmer","followers_url":"https://api.github.com/users/wpalmer/followers","following_url":"https://api.github.com/users/wpalmer/following{/other_user}","gists_url":"https://api.github.com/users/wpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/wpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpalmer/subscriptions","organizations_url":"https://api.github.com/users/wpalmer/orgs","repos_url":"https://api.github.com/users/wpalmer/repos","events_url":"https://api.github.com/users/wpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/wpalmer/received_events","type":"User","site_admin":false},"repo":{"id":46898537,"name":"Magento_GoogleTagManager","full_name":"wpalmer/Magento_GoogleTagManager","owner":{"login":"wpalmer","id":357044,"avatar_url":"https://avatars.githubusercontent.com/u/357044?v=3","gravatar_id":"","url":"https://api.github.com/users/wpalmer","html_url":"https://github.com/wpalmer","followers_url":"https://api.github.com/users/wpalmer/followers","following_url":"https://api.github.com/users/wpalmer/following{/other_user}","gists_url":"https://api.github.com/users/wpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/wpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpalmer/subscriptions","organizations_url":"https://api.github.com/users/wpalmer/orgs","repos_url":"https://api.github.com/users/wpalmer/repos","events_url":"https://api.github.com/users/wpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/wpalmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wpalmer/Magento_GoogleTagManager","description":"Google Tag Manager extension for Magento","fork":true,"url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager","forks_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/forks","keys_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/teams","hooks_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/hooks","issue_events_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/issues/events{/number}","events_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/events","assignees_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/assignees{/user}","branches_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/branches{/branch}","tags_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/tags","blobs_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/statuses/{sha}","languages_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/languages","stargazers_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/stargazers","contributors_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/contributors","subscribers_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/subscribers","subscription_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/subscription","commits_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/contents/{+path}","compare_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/merges","archive_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/downloads","issues_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/issues{/number}","pulls_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/pulls{/number}","milestones_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/milestones{/number}","notifications_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/labels{/name}","releases_url":"https://api.github.com/repos/wpalmer/Magento_GoogleTagManager/releases{/id}","created_at":"2015-11-26T02:05:51Z","updated_at":"2015-11-26T02:05:52Z","pushed_at":"2015-11-26T02:11:59Z","git_url":"git://github.com/wpalmer/Magento_GoogleTagManager.git","ssh_url":"git@github.com:wpalmer/Magento_GoogleTagManager.git","clone_url":"https://github.com/wpalmer/Magento_GoogleTagManager.git","svn_url":"https://github.com/wpalmer/Magento_GoogleTagManager","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CVM:master","ref":"master","sha":"873577c7c8ef001437d3795e0ef1d165010c431a","user":{"login":"CVM","id":752458,"avatar_url":"https://avatars.githubusercontent.com/u/752458?v=3","gravatar_id":"","url":"https://api.github.com/users/CVM","html_url":"https://github.com/CVM","followers_url":"https://api.github.com/users/CVM/followers","following_url":"https://api.github.com/users/CVM/following{/other_user}","gists_url":"https://api.github.com/users/CVM/gists{/gist_id}","starred_url":"https://api.github.com/users/CVM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVM/subscriptions","organizations_url":"https://api.github.com/users/CVM/orgs","repos_url":"https://api.github.com/users/CVM/repos","events_url":"https://api.github.com/users/CVM/events{/privacy}","received_events_url":"https://api.github.com/users/CVM/received_events","type":"User","site_admin":false},"repo":{"id":9856464,"name":"Magento_GoogleTagManager","full_name":"CVM/Magento_GoogleTagManager","owner":{"login":"CVM","id":752458,"avatar_url":"https://avatars.githubusercontent.com/u/752458?v=3","gravatar_id":"","url":"https://api.github.com/users/CVM","html_url":"https://github.com/CVM","followers_url":"https://api.github.com/users/CVM/followers","following_url":"https://api.github.com/users/CVM/following{/other_user}","gists_url":"https://api.github.com/users/CVM/gists{/gist_id}","starred_url":"https://api.github.com/users/CVM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVM/subscriptions","organizations_url":"https://api.github.com/users/CVM/orgs","repos_url":"https://api.github.com/users/CVM/repos","events_url":"https://api.github.com/users/CVM/events{/privacy}","received_events_url":"https://api.github.com/users/CVM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CVM/Magento_GoogleTagManager","description":"Google Tag Manager extension for Magento","fork":false,"url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager","forks_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/forks","keys_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/teams","hooks_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/hooks","issue_events_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues/events{/number}","events_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/events","assignees_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/assignees{/user}","branches_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/branches{/branch}","tags_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/tags","blobs_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/statuses/{sha}","languages_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/languages","stargazers_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/stargazers","contributors_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/contributors","subscribers_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/subscribers","subscription_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/subscription","commits_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/contents/{+path}","compare_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/merges","archive_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/downloads","issues_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues{/number}","pulls_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls{/number}","milestones_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/milestones{/number}","notifications_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/labels{/name}","releases_url":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/releases{/id}","created_at":"2013-05-04T16:06:27Z","updated_at":"2015-10-09T00:22:44Z","pushed_at":"2015-11-26T02:16:03Z","git_url":"git://github.com/CVM/Magento_GoogleTagManager.git","ssh_url":"git@github.com:CVM/Magento_GoogleTagManager.git","clone_url":"https://github.com/CVM/Magento_GoogleTagManager.git","svn_url":"https://github.com/CVM/Magento_GoogleTagManager","homepage":null,"size":209,"stargazers_count":46,"watchers_count":46,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":14,"forks":47,"open_issues":14,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/29"},"html":{"href":"https://github.com/CVM/Magento_GoogleTagManager/pull/29"},"issue":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues/29"},"comments":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/CVM/Magento_GoogleTagManager/statuses/766fdc0f05c32eecf48f936bc755e7d9ec72b4ae"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}