{"action":"created","issue":{"url":"https://api.github.com/repos/cvut/fittable/issues/3","labels_url":"https://api.github.com/repos/cvut/fittable/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/cvut/fittable/issues/3/comments","events_url":"https://api.github.com/repos/cvut/fittable/issues/3/events","html_url":"https://github.com/cvut/fittable/issues/3","id":67380152,"number":3,"title":"Suggestion: Do not commit generated files to the source tree","user":{"login":"jnv","id":616767,"avatar_url":"https://avatars.githubusercontent.com/u/616767?v=3","gravatar_id":"","url":"https://api.github.com/users/jnv","html_url":"https://github.com/jnv","followers_url":"https://api.github.com/users/jnv/followers","following_url":"https://api.github.com/users/jnv/following{/other_user}","gists_url":"https://api.github.com/users/jnv/gists{/gist_id}","starred_url":"https://api.github.com/users/jnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnv/subscriptions","organizations_url":"https://api.github.com/users/jnv/orgs","repos_url":"https://api.github.com/users/jnv/repos","events_url":"https://api.github.com/users/jnv/events{/privacy}","received_events_url":"https://api.github.com/users/jnv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"MMajko","id":3010503,"avatar_url":"https://avatars.githubusercontent.com/u/3010503?v=3","gravatar_id":"","url":"https://api.github.com/users/MMajko","html_url":"https://github.com/MMajko","followers_url":"https://api.github.com/users/MMajko/followers","following_url":"https://api.github.com/users/MMajko/following{/other_user}","gists_url":"https://api.github.com/users/MMajko/gists{/gist_id}","starred_url":"https://api.github.com/users/MMajko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMajko/subscriptions","organizations_url":"https://api.github.com/users/MMajko/orgs","repos_url":"https://api.github.com/users/MMajko/repos","events_url":"https://api.github.com/users/MMajko/events{/privacy}","received_events_url":"https://api.github.com/users/MMajko/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-04-09T14:57:54Z","updated_at":"2015-04-10T17:04:23Z","closed_at":null,"body":"It is not very clear which files are generated and which are not, I'd guess that [src/js/app.es5.js](https://github.com/cvut/fittable/blob/master/src/js/app.es5.js) is a source file, but it is apparently concatenated by Browserify. Even the files in `dist/` mess up commits and make code review harder, so I would recommend to ignore generated files completely.\r\n\r\nYou can commit bundles to a separate branch, e.g. `gh-pages` along with demo for GitHub pages. Eventually, this step can be automated by CI."},"comment":{"url":"https://api.github.com/repos/cvut/fittable/issues/comments/91622606","html_url":"https://github.com/cvut/fittable/issues/3#issuecomment-91622606","issue_url":"https://api.github.com/repos/cvut/fittable/issues/3","id":91622606,"user":{"login":"jirutka","id":949228,"avatar_url":"https://avatars.githubusercontent.com/u/949228?v=3","gravatar_id":"","url":"https://api.github.com/users/jirutka","html_url":"https://github.com/jirutka","followers_url":"https://api.github.com/users/jirutka/followers","following_url":"https://api.github.com/users/jirutka/following{/other_user}","gists_url":"https://api.github.com/users/jirutka/gists{/gist_id}","starred_url":"https://api.github.com/users/jirutka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirutka/subscriptions","organizations_url":"https://api.github.com/users/jirutka/orgs","repos_url":"https://api.github.com/users/jirutka/repos","events_url":"https://api.github.com/users/jirutka/events{/privacy}","received_events_url":"https://api.github.com/users/jirutka/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T17:04:23Z","updated_at":"2015-04-10T17:04:23Z","body":"@MMajko, I don’t agree. Yes, the project is in very early stage of development, but this isn’t a reason for not giving a sh*t about things like committing generated files. There are several reasons:\r\n\r\n1. As @jnv already mentioned, it complicates code reviews, because it’s not entirely clear what is the source that should be reviewed and what is some generated mess.\r\n2. You’re using Code Climate (or at least have the badge in readme), that’s good. However, as you see, you have very low score, just because it analyses generated files too. Thus the score is not relevant now.\r\n3. It doesn’t make any sense to commit generated code, that you can easily generate again, since you have all the configuration in the repository.\r\n4. Using `.gitignore` isn’t a rocket science, there’s no chore with it."}}