{"action":"closed","number":88,"pull_request":{"url":"https://api.github.com/repos/albertlatacz/java-repl/pulls/88","id":45321233,"html_url":"https://github.com/albertlatacz/java-repl/pull/88","diff_url":"https://github.com/albertlatacz/java-repl/pull/88.diff","patch_url":"https://github.com/albertlatacz/java-repl/pull/88.patch","issue_url":"https://api.github.com/repos/albertlatacz/java-repl/issues/88","number":88,"state":"closed","locked":false,"title":"Fixing String evaluation","user":{"login":"csrcordeiro","id":1211625,"avatar_url":"https://avatars.githubusercontent.com/u/1211625?v=3","gravatar_id":"","url":"https://api.github.com/users/csrcordeiro","html_url":"https://github.com/csrcordeiro","followers_url":"https://api.github.com/users/csrcordeiro/followers","following_url":"https://api.github.com/users/csrcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/csrcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/csrcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrcordeiro/subscriptions","organizations_url":"https://api.github.com/users/csrcordeiro/orgs","repos_url":"https://api.github.com/users/csrcordeiro/repos","events_url":"https://api.github.com/users/csrcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/csrcordeiro/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nRecently I made a very simple test with the REPL and found a weird error. The test went something like this:\r\n ```\r\nWelcome to JavaREPL version dev.build (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_51)\r\nType expression to evaluate, :help for more options or press tab to auto-complete.\r\njava> String a = \"My String\"\r\njava.lang.String a = \"My String\"\r\njava> String b = \"My String\"\r\njava.lang.String b = \"My String\"\r\njava> a == b\r\nERROR: illegal start of expression\r\n    = b;\r\n    ^\r\njava> :quit\r\n\r\nTerminating...\r\n```\r\nBy taking a look at the code I could spot the cause, it turns out that the evaluation was being parsed as an `Assignment` but in this case it should be a `Value`.\r\n\r\nI believe this PR is the most simple solution I could find. Feedback on code is always welcome.\r\n\r\nP.S: This project is just awesome! ","created_at":"2015-09-17T17:58:49Z","updated_at":"2015-11-22T22:24:51Z","closed_at":"2015-11-22T22:24:51Z","merged_at":"2015-11-22T22:24:51Z","merge_commit_sha":"c15331ce85a1634d4fc4260f24acd635e481365a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/albertlatacz/java-repl/pulls/88/commits","review_comments_url":"https://api.github.com/repos/albertlatacz/java-repl/pulls/88/comments","review_comment_url":"https://api.github.com/repos/albertlatacz/java-repl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/albertlatacz/java-repl/issues/88/comments","statuses_url":"https://api.github.com/repos/albertlatacz/java-repl/statuses/4c763f2936b6b3f9c6c93ff2ed566269288eded0","head":{"label":"csrcordeiro:string-check","ref":"string-check","sha":"4c763f2936b6b3f9c6c93ff2ed566269288eded0","user":{"login":"csrcordeiro","id":1211625,"avatar_url":"https://avatars.githubusercontent.com/u/1211625?v=3","gravatar_id":"","url":"https://api.github.com/users/csrcordeiro","html_url":"https://github.com/csrcordeiro","followers_url":"https://api.github.com/users/csrcordeiro/followers","following_url":"https://api.github.com/users/csrcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/csrcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/csrcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrcordeiro/subscriptions","organizations_url":"https://api.github.com/users/csrcordeiro/orgs","repos_url":"https://api.github.com/users/csrcordeiro/repos","events_url":"https://api.github.com/users/csrcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/csrcordeiro/received_events","type":"User","site_admin":false},"repo":{"id":42662383,"name":"java-repl","full_name":"csrcordeiro/java-repl","owner":{"login":"csrcordeiro","id":1211625,"avatar_url":"https://avatars.githubusercontent.com/u/1211625?v=3","gravatar_id":"","url":"https://api.github.com/users/csrcordeiro","html_url":"https://github.com/csrcordeiro","followers_url":"https://api.github.com/users/csrcordeiro/followers","following_url":"https://api.github.com/users/csrcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/csrcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/csrcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrcordeiro/subscriptions","organizations_url":"https://api.github.com/users/csrcordeiro/orgs","repos_url":"https://api.github.com/users/csrcordeiro/repos","events_url":"https://api.github.com/users/csrcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/csrcordeiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csrcordeiro/java-repl","description":"Read Eval Print Loop for Java","fork":true,"url":"https://api.github.com/repos/csrcordeiro/java-repl","forks_url":"https://api.github.com/repos/csrcordeiro/java-repl/forks","keys_url":"https://api.github.com/repos/csrcordeiro/java-repl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csrcordeiro/java-repl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csrcordeiro/java-repl/teams","hooks_url":"https://api.github.com/repos/csrcordeiro/java-repl/hooks","issue_events_url":"https://api.github.com/repos/csrcordeiro/java-repl/issues/events{/number}","events_url":"https://api.github.com/repos/csrcordeiro/java-repl/events","assignees_url":"https://api.github.com/repos/csrcordeiro/java-repl/assignees{/user}","branches_url":"https://api.github.com/repos/csrcordeiro/java-repl/branches{/branch}","tags_url":"https://api.github.com/repos/csrcordeiro/java-repl/tags","blobs_url":"https://api.github.com/repos/csrcordeiro/java-repl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csrcordeiro/java-repl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csrcordeiro/java-repl/git/refs{/sha}","trees_url":"https://api.github.com/repos/csrcordeiro/java-repl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csrcordeiro/java-repl/statuses/{sha}","languages_url":"https://api.github.com/repos/csrcordeiro/java-repl/languages","stargazers_url":"https://api.github.com/repos/csrcordeiro/java-repl/stargazers","contributors_url":"https://api.github.com/repos/csrcordeiro/java-repl/contributors","subscribers_url":"https://api.github.com/repos/csrcordeiro/java-repl/subscribers","subscription_url":"https://api.github.com/repos/csrcordeiro/java-repl/subscription","commits_url":"https://api.github.com/repos/csrcordeiro/java-repl/commits{/sha}","git_commits_url":"https://api.github.com/repos/csrcordeiro/java-repl/git/commits{/sha}","comments_url":"https://api.github.com/repos/csrcordeiro/java-repl/comments{/number}","issue_comment_url":"https://api.github.com/repos/csrcordeiro/java-repl/issues/comments{/number}","contents_url":"https://api.github.com/repos/csrcordeiro/java-repl/contents/{+path}","compare_url":"https://api.github.com/repos/csrcordeiro/java-repl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csrcordeiro/java-repl/merges","archive_url":"https://api.github.com/repos/csrcordeiro/java-repl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csrcordeiro/java-repl/downloads","issues_url":"https://api.github.com/repos/csrcordeiro/java-repl/issues{/number}","pulls_url":"https://api.github.com/repos/csrcordeiro/java-repl/pulls{/number}","milestones_url":"https://api.github.com/repos/csrcordeiro/java-repl/milestones{/number}","notifications_url":"https://api.github.com/repos/csrcordeiro/java-repl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csrcordeiro/java-repl/labels{/name}","releases_url":"https://api.github.com/repos/csrcordeiro/java-repl/releases{/id}","created_at":"2015-09-17T14:53:16Z","updated_at":"2015-09-17T14:53:17Z","pushed_at":"2015-09-17T17:30:05Z","git_url":"git://github.com/csrcordeiro/java-repl.git","ssh_url":"git@github.com:csrcordeiro/java-repl.git","clone_url":"https://github.com/csrcordeiro/java-repl.git","svn_url":"https://github.com/csrcordeiro/java-repl","homepage":"http://www.javarepl.com","size":75968,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"albertlatacz:master","ref":"master","sha":"484e62947e1ce03912e082f56da1ef1b85464c58","user":{"login":"albertlatacz","id":2648270,"avatar_url":"https://avatars.githubusercontent.com/u/2648270?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlatacz","html_url":"https://github.com/albertlatacz","followers_url":"https://api.github.com/users/albertlatacz/followers","following_url":"https://api.github.com/users/albertlatacz/following{/other_user}","gists_url":"https://api.github.com/users/albertlatacz/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlatacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlatacz/subscriptions","organizations_url":"https://api.github.com/users/albertlatacz/orgs","repos_url":"https://api.github.com/users/albertlatacz/repos","events_url":"https://api.github.com/users/albertlatacz/events{/privacy}","received_events_url":"https://api.github.com/users/albertlatacz/received_events","type":"User","site_admin":false},"repo":{"id":8900007,"name":"java-repl","full_name":"albertlatacz/java-repl","owner":{"login":"albertlatacz","id":2648270,"avatar_url":"https://avatars.githubusercontent.com/u/2648270?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlatacz","html_url":"https://github.com/albertlatacz","followers_url":"https://api.github.com/users/albertlatacz/followers","following_url":"https://api.github.com/users/albertlatacz/following{/other_user}","gists_url":"https://api.github.com/users/albertlatacz/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlatacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlatacz/subscriptions","organizations_url":"https://api.github.com/users/albertlatacz/orgs","repos_url":"https://api.github.com/users/albertlatacz/repos","events_url":"https://api.github.com/users/albertlatacz/events{/privacy}","received_events_url":"https://api.github.com/users/albertlatacz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albertlatacz/java-repl","description":"Read Eval Print Loop for Java","fork":false,"url":"https://api.github.com/repos/albertlatacz/java-repl","forks_url":"https://api.github.com/repos/albertlatacz/java-repl/forks","keys_url":"https://api.github.com/repos/albertlatacz/java-repl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertlatacz/java-repl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertlatacz/java-repl/teams","hooks_url":"https://api.github.com/repos/albertlatacz/java-repl/hooks","issue_events_url":"https://api.github.com/repos/albertlatacz/java-repl/issues/events{/number}","events_url":"https://api.github.com/repos/albertlatacz/java-repl/events","assignees_url":"https://api.github.com/repos/albertlatacz/java-repl/assignees{/user}","branches_url":"https://api.github.com/repos/albertlatacz/java-repl/branches{/branch}","tags_url":"https://api.github.com/repos/albertlatacz/java-repl/tags","blobs_url":"https://api.github.com/repos/albertlatacz/java-repl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertlatacz/java-repl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertlatacz/java-repl/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertlatacz/java-repl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertlatacz/java-repl/statuses/{sha}","languages_url":"https://api.github.com/repos/albertlatacz/java-repl/languages","stargazers_url":"https://api.github.com/repos/albertlatacz/java-repl/stargazers","contributors_url":"https://api.github.com/repos/albertlatacz/java-repl/contributors","subscribers_url":"https://api.github.com/repos/albertlatacz/java-repl/subscribers","subscription_url":"https://api.github.com/repos/albertlatacz/java-repl/subscription","commits_url":"https://api.github.com/repos/albertlatacz/java-repl/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertlatacz/java-repl/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertlatacz/java-repl/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertlatacz/java-repl/issues/comments{/number}","contents_url":"https://api.github.com/repos/albertlatacz/java-repl/contents/{+path}","compare_url":"https://api.github.com/repos/albertlatacz/java-repl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertlatacz/java-repl/merges","archive_url":"https://api.github.com/repos/albertlatacz/java-repl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertlatacz/java-repl/downloads","issues_url":"https://api.github.com/repos/albertlatacz/java-repl/issues{/number}","pulls_url":"https://api.github.com/repos/albertlatacz/java-repl/pulls{/number}","milestones_url":"https://api.github.com/repos/albertlatacz/java-repl/milestones{/number}","notifications_url":"https://api.github.com/repos/albertlatacz/java-repl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertlatacz/java-repl/labels{/name}","releases_url":"https://api.github.com/repos/albertlatacz/java-repl/releases{/id}","created_at":"2013-03-20T09:00:52Z","updated_at":"2015-11-22T11:45:20Z","pushed_at":"2015-11-22T22:24:52Z","git_url":"git://github.com/albertlatacz/java-repl.git","ssh_url":"git@github.com:albertlatacz/java-repl.git","clone_url":"https://github.com/albertlatacz/java-repl.git","svn_url":"https://github.com/albertlatacz/java-repl","homepage":"http://www.javarepl.com","size":77310,"stargazers_count":686,"watchers_count":686,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":37,"forks":105,"open_issues":37,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/albertlatacz/java-repl/pulls/88"},"html":{"href":"https://github.com/albertlatacz/java-repl/pull/88"},"issue":{"href":"https://api.github.com/repos/albertlatacz/java-repl/issues/88"},"comments":{"href":"https://api.github.com/repos/albertlatacz/java-repl/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/albertlatacz/java-repl/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/albertlatacz/java-repl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/albertlatacz/java-repl/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/albertlatacz/java-repl/statuses/4c763f2936b6b3f9c6c93ff2ed566269288eded0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"albertlatacz","id":2648270,"avatar_url":"https://avatars.githubusercontent.com/u/2648270?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlatacz","html_url":"https://github.com/albertlatacz","followers_url":"https://api.github.com/users/albertlatacz/followers","following_url":"https://api.github.com/users/albertlatacz/following{/other_user}","gists_url":"https://api.github.com/users/albertlatacz/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlatacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlatacz/subscriptions","organizations_url":"https://api.github.com/users/albertlatacz/orgs","repos_url":"https://api.github.com/users/albertlatacz/repos","events_url":"https://api.github.com/users/albertlatacz/events{/privacy}","received_events_url":"https://api.github.com/users/albertlatacz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":3}}