{"action":"created","comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/comments/34239250","id":34239250,"diff_hunk":"@@ -696,7 +696,8 @@ L.Map = L.Evented.extend({\n \t\tfor (var i = 0; i < targets.length; i++) {\r\n \t\t\tif (targets[i].listens(type, true)) {\r\n \t\t\t\ttargets[i].fire(type, data, true);\r\n-\t\t\t\tif (data.originalEvent._stopped) { return; }\r\n+\t\t\t\tif (data.originalEvent._stopped\r\n+\t\t\t\t\t|| (targets[i].options.unpropagateEvents && targets[i].options.unpropagateEvents.indexOf(type) !== -1)) { return; }\r","path":"src/map/Map.js","position":6,"original_position":6,"commit_id":"4078bc8ac6d642f4f31586c4ff8274428e1ea9d9","original_commit_id":"4078bc8ac6d642f4f31586c4ff8274428e1ea9d9","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"body":"Huuuu, good catch! Should we switch to using an array instead? Not sure about perfs :/","created_at":"2015-07-09T09:46:39Z","updated_at":"2015-07-09T09:46:39Z","html_url":"https://github.com/Leaflet/Leaflet/pull/3605#discussion_r34239250","pull_request_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605","_links":{"self":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/comments/34239250"},"html":{"href":"https://github.com/Leaflet/Leaflet/pull/3605#discussion_r34239250"},"pull_request":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605"}}},"pull_request":{"url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605","id":39459951,"html_url":"https://github.com/Leaflet/Leaflet/pull/3605","diff_url":"https://github.com/Leaflet/Leaflet/pull/3605.diff","patch_url":"https://github.com/Leaflet/Leaflet/pull/3605.patch","issue_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/3605","number":3605,"state":"open","locked":false,"title":"Stop click on _openPopup","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"body":"Fix #3604.\r\nI had a quick break.\r\nBubbling from marker is supposed to be the default, now, so I just stopped the event on `_openPopup`.\r\nI could also just add it on `bindPopup`, if you prefer this pattern.","created_at":"2015-07-08T09:58:00Z","updated_at":"2015-07-09T09:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48a5c072a458b6495a4d993f649c097c5eb70f92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605/commits","review_comments_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605/comments","review_comment_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/3605/comments","statuses_url":"https://api.github.com/repos/Leaflet/Leaflet/statuses/4078bc8ac6d642f4f31586c4ff8274428e1ea9d9","head":{"label":"Leaflet:stop-click-on-openpopup","ref":"stop-click-on-openpopup","sha":"4078bc8ac6d642f4f31586c4ff8274428e1ea9d9","user":{"login":"Leaflet","id":2854298,"avatar_url":"https://avatars.githubusercontent.com/u/2854298?v=3","gravatar_id":"","url":"https://api.github.com/users/Leaflet","html_url":"https://github.com/Leaflet","followers_url":"https://api.github.com/users/Leaflet/followers","following_url":"https://api.github.com/users/Leaflet/following{/other_user}","gists_url":"https://api.github.com/users/Leaflet/gists{/gist_id}","starred_url":"https://api.github.com/users/Leaflet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leaflet/subscriptions","organizations_url":"https://api.github.com/users/Leaflet/orgs","repos_url":"https://api.github.com/users/Leaflet/repos","events_url":"https://api.github.com/users/Leaflet/events{/privacy}","received_events_url":"https://api.github.com/users/Leaflet/received_events","type":"Organization","site_admin":false},"repo":{"id":931135,"name":"Leaflet","full_name":"Leaflet/Leaflet","owner":{"login":"Leaflet","id":2854298,"avatar_url":"https://avatars.githubusercontent.com/u/2854298?v=3","gravatar_id":"","url":"https://api.github.com/users/Leaflet","html_url":"https://github.com/Leaflet","followers_url":"https://api.github.com/users/Leaflet/followers","following_url":"https://api.github.com/users/Leaflet/following{/other_user}","gists_url":"https://api.github.com/users/Leaflet/gists{/gist_id}","starred_url":"https://api.github.com/users/Leaflet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leaflet/subscriptions","organizations_url":"https://api.github.com/users/Leaflet/orgs","repos_url":"https://api.github.com/users/Leaflet/repos","events_url":"https://api.github.com/users/Leaflet/events{/privacy}","received_events_url":"https://api.github.com/users/Leaflet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Leaflet/Leaflet","description":"JavaScript library for mobile-friendly interactive maps","fork":false,"url":"https://api.github.com/repos/Leaflet/Leaflet","forks_url":"https://api.github.com/repos/Leaflet/Leaflet/forks","keys_url":"https://api.github.com/repos/Leaflet/Leaflet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leaflet/Leaflet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leaflet/Leaflet/teams","hooks_url":"https://api.github.com/repos/Leaflet/Leaflet/hooks","issue_events_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/events{/number}","events_url":"https://api.github.com/repos/Leaflet/Leaflet/events","assignees_url":"https://api.github.com/repos/Leaflet/Leaflet/assignees{/user}","branches_url":"https://api.github.com/repos/Leaflet/Leaflet/branches{/branch}","tags_url":"https://api.github.com/repos/Leaflet/Leaflet/tags","blobs_url":"https://api.github.com/repos/Leaflet/Leaflet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leaflet/Leaflet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leaflet/Leaflet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leaflet/Leaflet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leaflet/Leaflet/statuses/{sha}","languages_url":"https://api.github.com/repos/Leaflet/Leaflet/languages","stargazers_url":"https://api.github.com/repos/Leaflet/Leaflet/stargazers","contributors_url":"https://api.github.com/repos/Leaflet/Leaflet/contributors","subscribers_url":"https://api.github.com/repos/Leaflet/Leaflet/subscribers","subscription_url":"https://api.github.com/repos/Leaflet/Leaflet/subscription","commits_url":"https://api.github.com/repos/Leaflet/Leaflet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leaflet/Leaflet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leaflet/Leaflet/contents/{+path}","compare_url":"https://api.github.com/repos/Leaflet/Leaflet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leaflet/Leaflet/merges","archive_url":"https://api.github.com/repos/Leaflet/Leaflet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leaflet/Leaflet/downloads","issues_url":"https://api.github.com/repos/Leaflet/Leaflet/issues{/number}","pulls_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls{/number}","milestones_url":"https://api.github.com/repos/Leaflet/Leaflet/milestones{/number}","notifications_url":"https://api.github.com/repos/Leaflet/Leaflet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leaflet/Leaflet/labels{/name}","releases_url":"https://api.github.com/repos/Leaflet/Leaflet/releases{/id}","created_at":"2010-09-22T16:57:44Z","updated_at":"2015-07-09T08:54:48Z","pushed_at":"2015-07-09T09:29:33Z","git_url":"git://github.com/Leaflet/Leaflet.git","ssh_url":"git@github.com:Leaflet/Leaflet.git","clone_url":"https://github.com/Leaflet/Leaflet.git","svn_url":"https://github.com/Leaflet/Leaflet","homepage":"http://leafletjs.com","size":44003,"stargazers_count":11049,"watchers_count":11049,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":2005,"mirror_url":null,"open_issues_count":206,"forks":2005,"open_issues":206,"watchers":11049,"default_branch":"master"}},"base":{"label":"Leaflet:master","ref":"master","sha":"d2513b2d53ba64217b61456844e7c47f6bb9ef65","user":{"login":"Leaflet","id":2854298,"avatar_url":"https://avatars.githubusercontent.com/u/2854298?v=3","gravatar_id":"","url":"https://api.github.com/users/Leaflet","html_url":"https://github.com/Leaflet","followers_url":"https://api.github.com/users/Leaflet/followers","following_url":"https://api.github.com/users/Leaflet/following{/other_user}","gists_url":"https://api.github.com/users/Leaflet/gists{/gist_id}","starred_url":"https://api.github.com/users/Leaflet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leaflet/subscriptions","organizations_url":"https://api.github.com/users/Leaflet/orgs","repos_url":"https://api.github.com/users/Leaflet/repos","events_url":"https://api.github.com/users/Leaflet/events{/privacy}","received_events_url":"https://api.github.com/users/Leaflet/received_events","type":"Organization","site_admin":false},"repo":{"id":931135,"name":"Leaflet","full_name":"Leaflet/Leaflet","owner":{"login":"Leaflet","id":2854298,"avatar_url":"https://avatars.githubusercontent.com/u/2854298?v=3","gravatar_id":"","url":"https://api.github.com/users/Leaflet","html_url":"https://github.com/Leaflet","followers_url":"https://api.github.com/users/Leaflet/followers","following_url":"https://api.github.com/users/Leaflet/following{/other_user}","gists_url":"https://api.github.com/users/Leaflet/gists{/gist_id}","starred_url":"https://api.github.com/users/Leaflet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leaflet/subscriptions","organizations_url":"https://api.github.com/users/Leaflet/orgs","repos_url":"https://api.github.com/users/Leaflet/repos","events_url":"https://api.github.com/users/Leaflet/events{/privacy}","received_events_url":"https://api.github.com/users/Leaflet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Leaflet/Leaflet","description":"JavaScript library for mobile-friendly interactive maps","fork":false,"url":"https://api.github.com/repos/Leaflet/Leaflet","forks_url":"https://api.github.com/repos/Leaflet/Leaflet/forks","keys_url":"https://api.github.com/repos/Leaflet/Leaflet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leaflet/Leaflet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leaflet/Leaflet/teams","hooks_url":"https://api.github.com/repos/Leaflet/Leaflet/hooks","issue_events_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/events{/number}","events_url":"https://api.github.com/repos/Leaflet/Leaflet/events","assignees_url":"https://api.github.com/repos/Leaflet/Leaflet/assignees{/user}","branches_url":"https://api.github.com/repos/Leaflet/Leaflet/branches{/branch}","tags_url":"https://api.github.com/repos/Leaflet/Leaflet/tags","blobs_url":"https://api.github.com/repos/Leaflet/Leaflet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leaflet/Leaflet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leaflet/Leaflet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leaflet/Leaflet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leaflet/Leaflet/statuses/{sha}","languages_url":"https://api.github.com/repos/Leaflet/Leaflet/languages","stargazers_url":"https://api.github.com/repos/Leaflet/Leaflet/stargazers","contributors_url":"https://api.github.com/repos/Leaflet/Leaflet/contributors","subscribers_url":"https://api.github.com/repos/Leaflet/Leaflet/subscribers","subscription_url":"https://api.github.com/repos/Leaflet/Leaflet/subscription","commits_url":"https://api.github.com/repos/Leaflet/Leaflet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leaflet/Leaflet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leaflet/Leaflet/contents/{+path}","compare_url":"https://api.github.com/repos/Leaflet/Leaflet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leaflet/Leaflet/merges","archive_url":"https://api.github.com/repos/Leaflet/Leaflet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leaflet/Leaflet/downloads","issues_url":"https://api.github.com/repos/Leaflet/Leaflet/issues{/number}","pulls_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls{/number}","milestones_url":"https://api.github.com/repos/Leaflet/Leaflet/milestones{/number}","notifications_url":"https://api.github.com/repos/Leaflet/Leaflet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leaflet/Leaflet/labels{/name}","releases_url":"https://api.github.com/repos/Leaflet/Leaflet/releases{/id}","created_at":"2010-09-22T16:57:44Z","updated_at":"2015-07-09T08:54:48Z","pushed_at":"2015-07-09T09:29:33Z","git_url":"git://github.com/Leaflet/Leaflet.git","ssh_url":"git@github.com:Leaflet/Leaflet.git","clone_url":"https://github.com/Leaflet/Leaflet.git","svn_url":"https://github.com/Leaflet/Leaflet","homepage":"http://leafletjs.com","size":44003,"stargazers_count":11049,"watchers_count":11049,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":2005,"mirror_url":null,"open_issues_count":206,"forks":2005,"open_issues":206,"watchers":11049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605"},"html":{"href":"https://github.com/Leaflet/Leaflet/pull/3605"},"issue":{"href":"https://api.github.com/repos/Leaflet/Leaflet/issues/3605"},"comments":{"href":"https://api.github.com/repos/Leaflet/Leaflet/issues/3605/comments"},"review_comments":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605/comments"},"review_comment":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/3605/commits"},"statuses":{"href":"https://api.github.com/repos/Leaflet/Leaflet/statuses/4078bc8ac6d642f4f31586c4ff8274428e1ea9d9"}}}}