{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/22710185","id":22710185,"diff_hunk":"@@ -0,0 +1,173 @@\n+class QuestionnaireStep1Form\n+  include ActiveModel::Model\n+\n+  attr_accessor :firm_email_address,\n+                :firm_telephone_number,\n+                :main_office_line_1,\n+                :main_office_line_2,\n+                :main_office_town,\n+                :main_office_county,\n+                :main_office_postcode,\n+                :accept_customers_from,\n+                :advice_in_person,\n+                :advice_by_other_methods,\n+                :free_initial_meeting,\n+                :initial_meeting_duration,\n+                :initial_advice_fee_structure,\n+                :ongoing_advice_fee_structure,\n+                :allow_customers_to_pay_for_advice,\n+                :minimum_fixed_one_off_fee_amount\n+\n+  validates :firm_email_address,\n+            presence: true,\n+            length: {maximum: 50},","path":"app/forms/questionnaire_step1_form.rb","position":23,"original_position":23,"commit_id":"3c4fd0091aa25aa3c5b156f6be5dbafc719c0ddc","original_commit_id":"93b87541b2bae244616e57e07bbf4e5a0c19549c","user":{"login":"benlovell","id":41963,"avatar_url":"https://avatars.githubusercontent.com/u/41963?v=3","gravatar_id":"","url":"https://api.github.com/users/benlovell","html_url":"https://github.com/benlovell","followers_url":"https://api.github.com/users/benlovell/followers","following_url":"https://api.github.com/users/benlovell/following{/other_user}","gists_url":"https://api.github.com/users/benlovell/gists{/gist_id}","starred_url":"https://api.github.com/users/benlovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlovell/subscriptions","organizations_url":"https://api.github.com/users/benlovell/orgs","repos_url":"https://api.github.com/users/benlovell/repos","events_url":"https://api.github.com/users/benlovell/events{/privacy}","received_events_url":"https://api.github.com/users/benlovell/received_events","type":"User","site_admin":false},"body":"Spaces in the braces here and elsewhere.","created_at":"2015-01-09T10:52:04Z","updated_at":"2015-01-09T10:52:04Z","html_url":"https://github.com/moneyadviceservice/rad/pull/59#discussion_r22710185","pull_request_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/22710185"},"html":{"href":"https://github.com/moneyadviceservice/rad/pull/59#discussion_r22710185"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59","id":26944348,"html_url":"https://github.com/moneyadviceservice/rad/pull/59","diff_url":"https://github.com/moneyadviceservice/rad/pull/59.diff","patch_url":"https://github.com/moneyadviceservice/rad/pull/59.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/59","number":59,"state":"open","locked":false,"title":"[WIP] Firm Questionnaire","user":{"login":"lshepstone","id":1371053,"avatar_url":"https://avatars.githubusercontent.com/u/1371053?v=3","gravatar_id":"","url":"https://api.github.com/users/lshepstone","html_url":"https://github.com/lshepstone","followers_url":"https://api.github.com/users/lshepstone/followers","following_url":"https://api.github.com/users/lshepstone/following{/other_user}","gists_url":"https://api.github.com/users/lshepstone/gists{/gist_id}","starred_url":"https://api.github.com/users/lshepstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lshepstone/subscriptions","organizations_url":"https://api.github.com/users/lshepstone/orgs","repos_url":"https://api.github.com/users/lshepstone/repos","events_url":"https://api.github.com/users/lshepstone/events{/privacy}","received_events_url":"https://api.github.com/users/lshepstone/received_events","type":"User","site_admin":false},"body":"Firms questionnaire, step 1 - work in progress. Things to consider:\r\n\r\n1) Routing declarations, particularly the hacky `only: []`\r\n2) Dedicated controller with only actions for `get` and `post` to questionnaire steps\r\n3) Possibly using Virtus to split out the address part of the questionnaire\r\n4) Additional validations around the postcode, and perhaps for field lengths as well\r\n\r\n@benlovell if you have a moment, let me know your thoughts.","created_at":"2015-01-07T08:45:52Z","updated_at":"2015-01-09T10:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e234776bbe4be45dcdbc5568a8671033e2760024","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/59/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/3c4fd0091aa25aa3c5b156f6be5dbafc719c0ddc","head":{"label":"moneyadviceservice:questionnaire","ref":"questionnaire","sha":"3c4fd0091aa25aa3c5b156f6be5dbafc719c0ddc","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":26871523,"name":"rad","full_name":"moneyadviceservice/rad","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/rad","description":"Retirement Adviser Directory","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/rad","forks_url":"https://api.github.com/repos/moneyadviceservice/rad/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/rad/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/rad/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/rad/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/rad/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/rad/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/rad/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/rad/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/rad/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/rad/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/rad/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/rad/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/rad/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/rad/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/rad/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/rad/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/rad/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/rad/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/rad/releases{/id}","created_at":"2014-11-19T16:55:48Z","updated_at":"2015-01-08T12:52:41Z","pushed_at":"2015-01-09T10:51:17Z","git_url":"git://github.com/moneyadviceservice/rad.git","ssh_url":"git@github.com:moneyadviceservice/rad.git","clone_url":"https://github.com/moneyadviceservice/rad.git","svn_url":"https://github.com/moneyadviceservice/rad","homepage":"","size":1947,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"2d85f6b586bf8db95db98745b7c3b5a649933b3f","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":26871523,"name":"rad","full_name":"moneyadviceservice/rad","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/rad","description":"Retirement Adviser Directory","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/rad","forks_url":"https://api.github.com/repos/moneyadviceservice/rad/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/rad/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/rad/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/rad/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/rad/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/rad/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/rad/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/rad/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/rad/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/rad/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/rad/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/rad/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/rad/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/rad/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/rad/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/rad/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/rad/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/rad/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/rad/releases{/id}","created_at":"2014-11-19T16:55:48Z","updated_at":"2015-01-08T12:52:41Z","pushed_at":"2015-01-09T10:51:17Z","git_url":"git://github.com/moneyadviceservice/rad.git","ssh_url":"git@github.com:moneyadviceservice/rad.git","clone_url":"https://github.com/moneyadviceservice/rad.git","svn_url":"https://github.com/moneyadviceservice/rad","homepage":"","size":1947,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59"},"html":{"href":"https://github.com/moneyadviceservice/rad/pull/59"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/rad/issues/59"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/rad/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/rad/statuses/3c4fd0091aa25aa3c5b156f6be5dbafc719c0ddc"}}}}