{"action":"created","issue":{"url":"https://api.github.com/repos/Jasig/cas/issues/973","labels_url":"https://api.github.com/repos/Jasig/cas/issues/973/labels{/name}","comments_url":"https://api.github.com/repos/Jasig/cas/issues/973/comments","events_url":"https://api.github.com/repos/Jasig/cas/issues/973/events","html_url":"https://github.com/Jasig/cas/pull/973","id":81357572,"number":973,"title":"Update OAuthConstants.java","user":{"login":"JanuszP","id":654305,"avatar_url":"https://avatars.githubusercontent.com/u/654305?v=3","gravatar_id":"","url":"https://api.github.com/users/JanuszP","html_url":"https://github.com/JanuszP","followers_url":"https://api.github.com/users/JanuszP/followers","following_url":"https://api.github.com/users/JanuszP/following{/other_user}","gists_url":"https://api.github.com/users/JanuszP/gists{/gist_id}","starred_url":"https://api.github.com/users/JanuszP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanuszP/subscriptions","organizations_url":"https://api.github.com/users/JanuszP/orgs","repos_url":"https://api.github.com/users/JanuszP/repos","events_url":"https://api.github.com/users/JanuszP/events{/privacy}","received_events_url":"https://api.github.com/users/JanuszP/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Jasig/cas/labels/4.0","name":"4.0","color":"bfd4f2"},{"url":"https://api.github.com/repos/Jasig/cas/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/Jasig/cas/labels/OAuth","name":"OAuth","color":"5319e7"},{"url":"https://api.github.com/repos/Jasig/cas/labels/Trivial","name":"Trivial","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Jasig/cas/milestones/2","html_url":"https://github.com/Jasig/cas/milestones/4.1.0","labels_url":"https://api.github.com/repos/Jasig/cas/milestones/2/labels","id":721279,"number":2,"title":"4.1.0","description":"CAS 4.1.0 Release","creator":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":312,"state":"open","created_at":"2014-07-15T06:16:10Z","updated_at":"2015-05-27T09:02:55Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-05-27T08:59:19Z","updated_at":"2015-05-27T10:44:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Jasig/cas/pulls/973","html_url":"https://github.com/Jasig/cas/pull/973","diff_url":"https://github.com/Jasig/cas/pull/973.diff","patch_url":"https://github.com/Jasig/cas/pull/973.patch"},"body":"As far as I can tell bearer token should be written with uppercase B, ie:\r\n - https://tools.ietf.org/html/rfc6750#section-2.1\r\n - http://stackoverflow.com/questions/22229996/basic-http-and-bearer-token-authentication\r\n\r\nI'm not very fluent with RFC docs so I'm not sure how \"bearer\" should be treated. Currently the problem occurs in OAuth20ProfileController.handleRequestInternal() (line 71), this can be fixed by making authHeader lowercase before comparision, but that would allow usage of constructs like \"bEarer\" etc. which doesn't seem right.\r\n\r\nAccording to https://tools.ietf.org/html/rfc6750#section-1.1 case sensitive comparision should be used, so it might be better to change OAuthConstants.BEARER_TOKEN to \"Bearer\"."},"comment":{"url":"https://api.github.com/repos/Jasig/cas/issues/comments/105862546","html_url":"https://github.com/Jasig/cas/pull/973#issuecomment-105862546","issue_url":"https://api.github.com/repos/Jasig/cas/issues/973","id":105862546,"user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"created_at":"2015-05-27T10:44:54Z","updated_at":"2015-05-27T10:44:54Z","body":"+1 the RFC is the reference\r\n\r\nBTW, how did you find out that it should be written with an uppercase letter?"}}