{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/comments/24719036","id":24719036,"diff_hunk":"@@ -12,28 +12,6 @@ import Interface = require('../interface');\n var SESSIONSTORE = new SessionStore(conf.get('expiration'));\n \n // PUBLIC FUNCTIONS\n-export function createSession(req: Interface.IOurRequest,","path":"lib/middleware/api-session.ts","position":4,"original_position":4,"commit_id":"3facbdb7e091c849e5afc623d6bbf3888a77772d","original_commit_id":"3facbdb7e091c849e5afc623d6bbf3888a77772d","user":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"body":"What's the motivation for removing this?  It seems to be conflating the work done in `handleSession`, which seems to be doing quite a bit for different types of operations.","created_at":"2015-02-15T02:03:10Z","updated_at":"2015-02-15T02:03:10Z","html_url":"https://github.com/bloomberg/blpapi-http/pull/73#discussion_r24719036","pull_request_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/comments/24719036"},"html":{"href":"https://github.com/bloomberg/blpapi-http/pull/73#discussion_r24719036"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73","id":29290154,"html_url":"https://github.com/bloomberg/blpapi-http/pull/73","diff_url":"https://github.com/bloomberg/blpapi-http/pull/73.diff","patch_url":"https://github.com/bloomberg/blpapi-http/pull/73.patch","issue_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/73","number":73,"state":"open","locked":false,"title":"Convert to new URL scheme.","user":{"login":"yupinghu","id":7786724,"avatar_url":"https://avatars.githubusercontent.com/u/7786724?v=3","gravatar_id":"","url":"https://api.github.com/users/yupinghu","html_url":"https://github.com/yupinghu","followers_url":"https://api.github.com/users/yupinghu/followers","following_url":"https://api.github.com/users/yupinghu/following{/other_user}","gists_url":"https://api.github.com/users/yupinghu/gists{/gist_id}","starred_url":"https://api.github.com/users/yupinghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupinghu/subscriptions","organizations_url":"https://api.github.com/users/yupinghu/orgs","repos_url":"https://api.github.com/users/yupinghu/repos","events_url":"https://api.github.com/users/yupinghu/events{/privacy}","received_events_url":"https://api.github.com/users/yupinghu/received_events","type":"User","site_admin":false},"body":"Closes #59.","created_at":"2015-02-13T19:08:18Z","updated_at":"2015-02-15T02:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcd52e97f69c156d9695c96ef2230c87e5f94b2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73/commits","review_comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73/comments","review_comment_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/73/comments","statuses_url":"https://api.github.com/repos/bloomberg/blpapi-http/statuses/3facbdb7e091c849e5afc623d6bbf3888a77772d","head":{"label":"yupinghu:urlscheme","ref":"urlscheme","sha":"3facbdb7e091c849e5afc623d6bbf3888a77772d","user":{"login":"yupinghu","id":7786724,"avatar_url":"https://avatars.githubusercontent.com/u/7786724?v=3","gravatar_id":"","url":"https://api.github.com/users/yupinghu","html_url":"https://github.com/yupinghu","followers_url":"https://api.github.com/users/yupinghu/followers","following_url":"https://api.github.com/users/yupinghu/following{/other_user}","gists_url":"https://api.github.com/users/yupinghu/gists{/gist_id}","starred_url":"https://api.github.com/users/yupinghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupinghu/subscriptions","organizations_url":"https://api.github.com/users/yupinghu/orgs","repos_url":"https://api.github.com/users/yupinghu/repos","events_url":"https://api.github.com/users/yupinghu/events{/privacy}","received_events_url":"https://api.github.com/users/yupinghu/received_events","type":"User","site_admin":false},"repo":{"id":28936983,"name":"blpapi-http","full_name":"yupinghu/blpapi-http","owner":{"login":"yupinghu","id":7786724,"avatar_url":"https://avatars.githubusercontent.com/u/7786724?v=3","gravatar_id":"","url":"https://api.github.com/users/yupinghu","html_url":"https://github.com/yupinghu","followers_url":"https://api.github.com/users/yupinghu/followers","following_url":"https://api.github.com/users/yupinghu/following{/other_user}","gists_url":"https://api.github.com/users/yupinghu/gists{/gist_id}","starred_url":"https://api.github.com/users/yupinghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupinghu/subscriptions","organizations_url":"https://api.github.com/users/yupinghu/orgs","repos_url":"https://api.github.com/users/yupinghu/repos","events_url":"https://api.github.com/users/yupinghu/events{/privacy}","received_events_url":"https://api.github.com/users/yupinghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yupinghu/blpapi-http","description":"HTTP wrapper for Bloomberg Open API","fork":true,"url":"https://api.github.com/repos/yupinghu/blpapi-http","forks_url":"https://api.github.com/repos/yupinghu/blpapi-http/forks","keys_url":"https://api.github.com/repos/yupinghu/blpapi-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yupinghu/blpapi-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yupinghu/blpapi-http/teams","hooks_url":"https://api.github.com/repos/yupinghu/blpapi-http/hooks","issue_events_url":"https://api.github.com/repos/yupinghu/blpapi-http/issues/events{/number}","events_url":"https://api.github.com/repos/yupinghu/blpapi-http/events","assignees_url":"https://api.github.com/repos/yupinghu/blpapi-http/assignees{/user}","branches_url":"https://api.github.com/repos/yupinghu/blpapi-http/branches{/branch}","tags_url":"https://api.github.com/repos/yupinghu/blpapi-http/tags","blobs_url":"https://api.github.com/repos/yupinghu/blpapi-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yupinghu/blpapi-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yupinghu/blpapi-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/yupinghu/blpapi-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yupinghu/blpapi-http/statuses/{sha}","languages_url":"https://api.github.com/repos/yupinghu/blpapi-http/languages","stargazers_url":"https://api.github.com/repos/yupinghu/blpapi-http/stargazers","contributors_url":"https://api.github.com/repos/yupinghu/blpapi-http/contributors","subscribers_url":"https://api.github.com/repos/yupinghu/blpapi-http/subscribers","subscription_url":"https://api.github.com/repos/yupinghu/blpapi-http/subscription","commits_url":"https://api.github.com/repos/yupinghu/blpapi-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/yupinghu/blpapi-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/yupinghu/blpapi-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/yupinghu/blpapi-http/issues/comments/{number}","contents_url":"https://api.github.com/repos/yupinghu/blpapi-http/contents/{+path}","compare_url":"https://api.github.com/repos/yupinghu/blpapi-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yupinghu/blpapi-http/merges","archive_url":"https://api.github.com/repos/yupinghu/blpapi-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yupinghu/blpapi-http/downloads","issues_url":"https://api.github.com/repos/yupinghu/blpapi-http/issues{/number}","pulls_url":"https://api.github.com/repos/yupinghu/blpapi-http/pulls{/number}","milestones_url":"https://api.github.com/repos/yupinghu/blpapi-http/milestones{/number}","notifications_url":"https://api.github.com/repos/yupinghu/blpapi-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yupinghu/blpapi-http/labels{/name}","releases_url":"https://api.github.com/repos/yupinghu/blpapi-http/releases{/id}","created_at":"2015-01-07T22:19:41Z","updated_at":"2015-02-11T21:05:42Z","pushed_at":"2015-02-14T00:44:15Z","git_url":"git://github.com/yupinghu/blpapi-http.git","ssh_url":"git@github.com:yupinghu/blpapi-http.git","clone_url":"https://github.com/yupinghu/blpapi-http.git","svn_url":"https://github.com/yupinghu/blpapi-http","homepage":null,"size":359,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"bloomberg:develop","ref":"develop","sha":"2d658128903a5b5cacc0b6200056bf4960b74874","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":25042195,"name":"blpapi-http","full_name":"bloomberg/blpapi-http","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/blpapi-http","description":"HTTP wrapper for Bloomberg Open API","fork":false,"url":"https://api.github.com/repos/bloomberg/blpapi-http","forks_url":"https://api.github.com/repos/bloomberg/blpapi-http/forks","keys_url":"https://api.github.com/repos/bloomberg/blpapi-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/blpapi-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/blpapi-http/teams","hooks_url":"https://api.github.com/repos/bloomberg/blpapi-http/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/blpapi-http/events","assignees_url":"https://api.github.com/repos/bloomberg/blpapi-http/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/blpapi-http/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/blpapi-http/tags","blobs_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/blpapi-http/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/blpapi-http/languages","stargazers_url":"https://api.github.com/repos/bloomberg/blpapi-http/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/blpapi-http/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/blpapi-http/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/blpapi-http/subscription","commits_url":"https://api.github.com/repos/bloomberg/blpapi-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/comments/{number}","contents_url":"https://api.github.com/repos/bloomberg/blpapi-http/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/blpapi-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/blpapi-http/merges","archive_url":"https://api.github.com/repos/bloomberg/blpapi-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/blpapi-http/downloads","issues_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/blpapi-http/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/blpapi-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/blpapi-http/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/blpapi-http/releases{/id}","created_at":"2014-10-10T15:45:55Z","updated_at":"2015-02-13T20:10:39Z","pushed_at":"2015-02-13T21:55:04Z","git_url":"git://github.com/bloomberg/blpapi-http.git","ssh_url":"git@github.com:bloomberg/blpapi-http.git","clone_url":"https://github.com/bloomberg/blpapi-http.git","svn_url":"https://github.com/bloomberg/blpapi-http","homepage":null,"size":1201,"stargazers_count":14,"watchers_count":14,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":28,"forks":16,"open_issues":28,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73"},"html":{"href":"https://github.com/bloomberg/blpapi-http/pull/73"},"issue":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/issues/73"},"comments":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/statuses/3facbdb7e091c849e5afc623d6bbf3888a77772d"}}}}