{"action":"created","issue":{"url":"https://api.github.com/repos/tidepool-org/sundial/issues/23","labels_url":"https://api.github.com/repos/tidepool-org/sundial/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/tidepool-org/sundial/issues/23/comments","events_url":"https://api.github.com/repos/tidepool-org/sundial/issues/23/events","html_url":"https://github.com/tidepool-org/sundial/pull/23","id":111723968,"number":23,"title":"fix tests","user":{"login":"jebeck","id":1588547,"avatar_url":"https://avatars.githubusercontent.com/u/1588547?v=3","gravatar_id":"","url":"https://api.github.com/users/jebeck","html_url":"https://github.com/jebeck","followers_url":"https://api.github.com/users/jebeck/followers","following_url":"https://api.github.com/users/jebeck/following{/other_user}","gists_url":"https://api.github.com/users/jebeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jebeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebeck/subscriptions","organizations_url":"https://api.github.com/users/jebeck/orgs","repos_url":"https://api.github.com/users/jebeck/repos","events_url":"https://api.github.com/users/jebeck/events{/privacy}","received_events_url":"https://api.github.com/users/jebeck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-15T22:51:57Z","updated_at":"2015-10-15T23:41:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tidepool-org/sundial/pulls/23","html_url":"https://github.com/tidepool-org/sundial/pull/23","diff_url":"https://github.com/tidepool-org/sundial/pull/23.diff","patch_url":"https://github.com/tidepool-org/sundial/pull/23.patch"},"body":"The first commit here adds the ability to run the tests in Chrome using [testem](https://github.com/airportyh/testem) (IMO, this is faster to set up than Karma, and I just wanted to see if the tests were broken in-browser).\r\n\r\nIf you check out the first commit and run the tests with `npm run browser-tests` you'll see two failures. The second commit fixes those failures by removing reliance on the prior behavior of JavaScript Date in Chrome (that passing a Date string like `2015-01-01T00:00:00` with no TZ info would be interpreted as a UTC timestamp equivalent to `2015-01-01T00:00:00.000Z`).\r\n\r\nI suggest for now that we commit to running tests regularly/daily locally in-browser and discuss the prioritization of getting tests running with CI in real browsers - and not only that, but in real browsers *in non-UTC time* (whatever remote machines are running the browsers can't be UTC boxes, if we want to expose these types of issues)."},"comment":{"url":"https://api.github.com/repos/tidepool-org/sundial/issues/comments/148552654","html_url":"https://github.com/tidepool-org/sundial/pull/23#issuecomment-148552654","issue_url":"https://api.github.com/repos/tidepool-org/sundial/issues/23","id":148552654,"user":{"login":"jh-bate","id":5168993,"avatar_url":"https://avatars.githubusercontent.com/u/5168993?v=3","gravatar_id":"","url":"https://api.github.com/users/jh-bate","html_url":"https://github.com/jh-bate","followers_url":"https://api.github.com/users/jh-bate/followers","following_url":"https://api.github.com/users/jh-bate/following{/other_user}","gists_url":"https://api.github.com/users/jh-bate/gists{/gist_id}","starred_url":"https://api.github.com/users/jh-bate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh-bate/subscriptions","organizations_url":"https://api.github.com/users/jh-bate/orgs","repos_url":"https://api.github.com/users/jh-bate/repos","events_url":"https://api.github.com/users/jh-bate/events{/privacy}","received_events_url":"https://api.github.com/users/jh-bate/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T23:41:13Z","updated_at":"2015-10-15T23:41:13Z","body":"LGTM  \r\n\r\n- same obvious comment that you mention above relying on someone to run these is a losing battle - it has to be CI\r\n- would be good to have a comment in the readme about how to run the tests  "}}