{"action":"created","issue":{"url":"https://api.github.com/repos/jsocol/pystatsd/issues/64","labels_url":"https://api.github.com/repos/jsocol/pystatsd/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/jsocol/pystatsd/issues/64/comments","events_url":"https://api.github.com/repos/jsocol/pystatsd/issues/64/events","html_url":"https://github.com/jsocol/pystatsd/pull/64","id":98700120,"number":64,"title":"Ignore RuntimeErrors together with socket errors","user":{"login":"jstasiak","id":36209,"avatar_url":"https://avatars.githubusercontent.com/u/36209?v=3","gravatar_id":"","url":"https://api.github.com/users/jstasiak","html_url":"https://github.com/jstasiak","followers_url":"https://api.github.com/users/jstasiak/followers","following_url":"https://api.github.com/users/jstasiak/following{/other_user}","gists_url":"https://api.github.com/users/jstasiak/gists{/gist_id}","starred_url":"https://api.github.com/users/jstasiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstasiak/subscriptions","organizations_url":"https://api.github.com/users/jstasiak/orgs","repos_url":"https://api.github.com/users/jstasiak/repos","events_url":"https://api.github.com/users/jstasiak/events{/privacy}","received_events_url":"https://api.github.com/users/jstasiak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-03T08:54:21Z","updated_at":"2015-08-15T19:15:15Z","closed_at":"2015-08-07T20:11:06Z","pull_request":{"url":"https://api.github.com/repos/jsocol/pystatsd/pulls/64","html_url":"https://github.com/jsocol/pystatsd/pull/64","diff_url":"https://github.com/jsocol/pystatsd/pull/64.diff","patch_url":"https://github.com/jsocol/pystatsd/pull/64.patch"},"body":"When Python's standard library is patched with Eventlet the exception\r\nraised when two threads access the same socket simultaneously is\r\nRuntimeError and I think it makes sense to include it here.\r\n\r\nThe downside is it may start ignoring too wide variety of exceptions but\r\non the other hand I can't think of any other RuntimeErrors that can be\r\nraised here."},"comment":{"url":"https://api.github.com/repos/jsocol/pystatsd/issues/comments/131427315","html_url":"https://github.com/jsocol/pystatsd/pull/64#issuecomment-131427315","issue_url":"https://api.github.com/repos/jsocol/pystatsd/issues/64","id":131427315,"user":{"login":"jstasiak","id":36209,"avatar_url":"https://avatars.githubusercontent.com/u/36209?v=3","gravatar_id":"","url":"https://api.github.com/users/jstasiak","html_url":"https://github.com/jstasiak","followers_url":"https://api.github.com/users/jstasiak/followers","following_url":"https://api.github.com/users/jstasiak/following{/other_user}","gists_url":"https://api.github.com/users/jstasiak/gists{/gist_id}","starred_url":"https://api.github.com/users/jstasiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstasiak/subscriptions","organizations_url":"https://api.github.com/users/jstasiak/orgs","repos_url":"https://api.github.com/users/jstasiak/repos","events_url":"https://api.github.com/users/jstasiak/events{/privacy}","received_events_url":"https://api.github.com/users/jstasiak/received_events","type":"User","site_admin":false},"created_at":"2015-08-15T19:15:15Z","updated_at":"2015-08-15T19:15:15Z","body":"@jsocol I know what you mean, I'd not have added this case if socket errors weren't already being silenced here. I'm thinking making this behaviour configurable wouldn't be difficult in case someone needed an insight into this.\r\n\r\n@tuukkamustonen We've been monkey patching pystatsd to achieve what this patch does. I think gevent is compatible with Python standard library in this regard and the exception it raises there is ``socket.error`` so all is good even without this patch."}}