{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/32922736","id":32922736,"diff_hunk":"@@ -16,6 +16,7 @@ endif()\n \n ## For profilling with gprof\n # add_definitions(\"-pg\")\n+add_definitions(\"-Wall -Wextra\")","path":"Linear_cell_complex/demo/Linear_cell_complex/CMakeLists.txt","position":4,"original_position":4,"commit_id":"6395db7d5ea16c324619ea33b77552b289727aaf","original_commit_id":"6395db7d5ea16c324619ea33b77552b289727aaf","user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"body":"That cannot be accepted into CGAL: you cannot decide which compiler flags the users may want. What is more, unless I read wrongly, you enable flags on all platforms, and that will creates compilation errors on all platforms that do not understand those flags (old versions of gcc, and all Microsoft compilers).\r\n","created_at":"2015-06-22T10:55:04Z","updated_at":"2015-06-22T10:55:04Z","html_url":"https://github.com/CGAL/cgal/pull/127#discussion_r32922736","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/32922736"},"html":{"href":"https://github.com/CGAL/cgal/pull/127#discussion_r32922736"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/127","id":38042015,"html_url":"https://github.com/CGAL/cgal/pull/127","diff_url":"https://github.com/CGAL/cgal/pull/127.diff","patch_url":"https://github.com/CGAL/cgal/pull/127.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/127","number":127,"state":"open","locked":false,"title":"Combinatorial map save load gdamiand","user":{"login":"gdamiand","id":944526,"avatar_url":"https://avatars.githubusercontent.com/u/944526?v=3","gravatar_id":"","url":"https://api.github.com/users/gdamiand","html_url":"https://github.com/gdamiand","followers_url":"https://api.github.com/users/gdamiand/followers","following_url":"https://api.github.com/users/gdamiand/following{/other_user}","gists_url":"https://api.github.com/users/gdamiand/gists{/gist_id}","starred_url":"https://api.github.com/users/gdamiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdamiand/subscriptions","organizations_url":"https://api.github.com/users/gdamiand/orgs","repos_url":"https://api.github.com/users/gdamiand/repos","events_url":"https://api.github.com/users/gdamiand/events{/privacy}","received_events_url":"https://api.github.com/users/gdamiand/received_events","type":"User","site_admin":false},"body":"Improvement of the LCC demo.\r\nAdd save/load functions, a function to merge coplanar faces, update the OpenGL drawing to allow to draw non convex faces.\r\n\r\nTested in https://cgal.geometryfactory.com/CGAL/Members/testsuite/results-4.7-Ic-60.shtml","created_at":"2015-06-18T19:14:21Z","updated_at":"2015-06-22T10:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f6283a0e1b7d66efd609b31a36393e9c5777890","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/127/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/127/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/127/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/6395db7d5ea16c324619ea33b77552b289727aaf","head":{"label":"gdamiand:Combinatorial_map_save_load-gdamiand","ref":"Combinatorial_map_save_load-gdamiand","sha":"6395db7d5ea16c324619ea33b77552b289727aaf","user":{"login":"gdamiand","id":944526,"avatar_url":"https://avatars.githubusercontent.com/u/944526?v=3","gravatar_id":"","url":"https://api.github.com/users/gdamiand","html_url":"https://github.com/gdamiand","followers_url":"https://api.github.com/users/gdamiand/followers","following_url":"https://api.github.com/users/gdamiand/following{/other_user}","gists_url":"https://api.github.com/users/gdamiand/gists{/gist_id}","starred_url":"https://api.github.com/users/gdamiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdamiand/subscriptions","organizations_url":"https://api.github.com/users/gdamiand/orgs","repos_url":"https://api.github.com/users/gdamiand/repos","events_url":"https://api.github.com/users/gdamiand/events{/privacy}","received_events_url":"https://api.github.com/users/gdamiand/received_events","type":"User","site_admin":false},"repo":{"id":31699148,"name":"cgal","full_name":"gdamiand/cgal","owner":{"login":"gdamiand","id":944526,"avatar_url":"https://avatars.githubusercontent.com/u/944526?v=3","gravatar_id":"","url":"https://api.github.com/users/gdamiand","html_url":"https://github.com/gdamiand","followers_url":"https://api.github.com/users/gdamiand/followers","following_url":"https://api.github.com/users/gdamiand/following{/other_user}","gists_url":"https://api.github.com/users/gdamiand/gists{/gist_id}","starred_url":"https://api.github.com/users/gdamiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdamiand/subscriptions","organizations_url":"https://api.github.com/users/gdamiand/orgs","repos_url":"https://api.github.com/users/gdamiand/repos","events_url":"https://api.github.com/users/gdamiand/events{/privacy}","received_events_url":"https://api.github.com/users/gdamiand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdamiand/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/gdamiand/cgal","forks_url":"https://api.github.com/repos/gdamiand/cgal/forks","keys_url":"https://api.github.com/repos/gdamiand/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdamiand/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdamiand/cgal/teams","hooks_url":"https://api.github.com/repos/gdamiand/cgal/hooks","issue_events_url":"https://api.github.com/repos/gdamiand/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/gdamiand/cgal/events","assignees_url":"https://api.github.com/repos/gdamiand/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/gdamiand/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/gdamiand/cgal/tags","blobs_url":"https://api.github.com/repos/gdamiand/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdamiand/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdamiand/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdamiand/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdamiand/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/gdamiand/cgal/languages","stargazers_url":"https://api.github.com/repos/gdamiand/cgal/stargazers","contributors_url":"https://api.github.com/repos/gdamiand/cgal/contributors","subscribers_url":"https://api.github.com/repos/gdamiand/cgal/subscribers","subscription_url":"https://api.github.com/repos/gdamiand/cgal/subscription","commits_url":"https://api.github.com/repos/gdamiand/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdamiand/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdamiand/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdamiand/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdamiand/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/gdamiand/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdamiand/cgal/merges","archive_url":"https://api.github.com/repos/gdamiand/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdamiand/cgal/downloads","issues_url":"https://api.github.com/repos/gdamiand/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/gdamiand/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/gdamiand/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/gdamiand/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdamiand/cgal/labels{/name}","releases_url":"https://api.github.com/repos/gdamiand/cgal/releases{/id}","created_at":"2015-03-05T06:21:41Z","updated_at":"2015-03-05T06:22:38Z","pushed_at":"2015-06-18T19:21:07Z","git_url":"git://github.com/gdamiand/cgal.git","ssh_url":"git@github.com:gdamiand/cgal.git","clone_url":"https://github.com/gdamiand/cgal.git","svn_url":"https://github.com/gdamiand/cgal","homepage":"http://www.cgal.org","size":507928,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"97cd20e8de8048d52f686f311e8cb4e69fc064fb","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","created_at":"2014-10-01T12:22:47Z","updated_at":"2015-06-19T10:19:31Z","pushed_at":"2015-06-22T10:51:15Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"http://www.cgal.org","size":599657,"stargazers_count":72,"watchers_count":72,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":37,"forks":42,"open_issues":37,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/127"},"html":{"href":"https://github.com/CGAL/cgal/pull/127"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/127"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/6395db7d5ea16c324619ea33b77552b289727aaf"}}}}