{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-router/issues/2415","labels_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2415/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2415/comments","events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2415/events","html_url":"https://github.com/angular-ui/ui-router/pull/2415","id":121323641,"number":2415,"title":"fix(urlMatcherFactory.js): change to allow url query param names to c…","user":{"login":"SmilingJoe","id":204793,"avatar_url":"https://avatars.githubusercontent.com/u/204793?v=3","gravatar_id":"","url":"https://api.github.com/users/SmilingJoe","html_url":"https://github.com/SmilingJoe","followers_url":"https://api.github.com/users/SmilingJoe/followers","following_url":"https://api.github.com/users/SmilingJoe/following{/other_user}","gists_url":"https://api.github.com/users/SmilingJoe/gists{/gist_id}","starred_url":"https://api.github.com/users/SmilingJoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmilingJoe/subscriptions","organizations_url":"https://api.github.com/users/SmilingJoe/orgs","repos_url":"https://api.github.com/users/SmilingJoe/repos","events_url":"https://api.github.com/users/SmilingJoe/events{/privacy}","received_events_url":"https://api.github.com/users/SmilingJoe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-09T19:45:51Z","updated_at":"2015-12-11T20:43:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2415","html_url":"https://github.com/angular-ui/ui-router/pull/2415","diff_url":"https://github.com/angular-ui/ui-router/pull/2415.diff","patch_url":"https://github.com/angular-ui/ui-router/pull/2415.patch"},"body":"…ontain periods\r\n\r\nThis change modifies the searchPlaceholder regex to include the period\r\ncharacter as valid for url query param names. This change also modifies\r\nthe regex found in the addParameter function which validates the param\r\nname just prior to adding to the list of parameters. A new set of unit\r\ntests were added to urlMatcherFactorySpec to ensure this modification\r\nworks correctly.\r\n\r\nThis change fixes issue [#2395](https://github.com/angular-ui/ui-router/issues/2395)"},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments/164042971","html_url":"https://github.com/angular-ui/ui-router/pull/2415#issuecomment-164042971","issue_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2415","id":164042971,"user":{"login":"SmilingJoe","id":204793,"avatar_url":"https://avatars.githubusercontent.com/u/204793?v=3","gravatar_id":"","url":"https://api.github.com/users/SmilingJoe","html_url":"https://github.com/SmilingJoe","followers_url":"https://api.github.com/users/SmilingJoe/followers","following_url":"https://api.github.com/users/SmilingJoe/following{/other_user}","gists_url":"https://api.github.com/users/SmilingJoe/gists{/gist_id}","starred_url":"https://api.github.com/users/SmilingJoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmilingJoe/subscriptions","organizations_url":"https://api.github.com/users/SmilingJoe/orgs","repos_url":"https://api.github.com/users/SmilingJoe/repos","events_url":"https://api.github.com/users/SmilingJoe/events{/privacy}","received_events_url":"https://api.github.com/users/SmilingJoe/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T20:43:08Z","updated_at":"2015-12-11T20:43:08Z","body":"Ok, I'll work on incorporating those into this PR on Monday."}}