{"action":"created","comment":{"url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments/41724147","id":41724147,"diff_hunk":"@@ -89,13 +41,67 @@ def self.server_render_js_with_console_logging(js_code)\n         if console_script_lines\n           console_script_lines.each do |line|\n             match = re.match(line)\n-            if match\n-              Rails.logger.info { \"[react_on_rails] #{match[:msg]}\" }\n-            end\n+            Rails.logger.info { \"[react_on_rails] #{match[:msg]}\" } if match\n           end\n         end\n       end\n       result\n     end\n+\n+    class << self","path":"lib/react_on_rails/server_rendering_pool.rb","position":98,"original_position":98,"commit_id":"e3a32e0231fde376bc1f7bc87a39071e49d9396c","original_commit_id":"e3a32e0231fde376bc1f7bc87a39071e49d9396c","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"This should make the module methods private. At least it does it on a class. @samnang correct?","created_at":"2015-10-12T05:17:39Z","updated_at":"2015-10-12T05:17:39Z","html_url":"https://github.com/shakacode/react_on_rails/pull/55#discussion_r41724147","pull_request_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments/41724147"},"html":{"href":"https://github.com/shakacode/react_on_rails/pull/55#discussion_r41724147"},"pull_request":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55","id":47386223,"html_url":"https://github.com/shakacode/react_on_rails/pull/55","diff_url":"https://github.com/shakacode/react_on_rails/pull/55.diff","patch_url":"https://github.com/shakacode/react_on_rails/pull/55.patch","issue_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/55","number":55,"state":"open","locked":false,"title":"Support React 0.14","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"* Also fixed linting errors","created_at":"2015-10-12T05:12:24Z","updated_at":"2015-10-12T05:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8412a4f75c3bde0fb5e403da889e4b5aa3b26e95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55/commits","review_comments_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55/comments","review_comment_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/55/comments","statuses_url":"https://api.github.com/repos/shakacode/react_on_rails/statuses/e3a32e0231fde376bc1f7bc87a39071e49d9396c","head":{"label":"shakacode:update-dependencies","ref":"update-dependencies","sha":"e3a32e0231fde376bc1f7bc87a39071e49d9396c","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":41117523,"name":"react_on_rails","full_name":"shakacode/react_on_rails","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/react_on_rails","description":"Integration of React + Webpack + Rails to build Universal (Isomorphic) Apps","fork":false,"url":"https://api.github.com/repos/shakacode/react_on_rails","forks_url":"https://api.github.com/repos/shakacode/react_on_rails/forks","keys_url":"https://api.github.com/repos/shakacode/react_on_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/react_on_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/react_on_rails/teams","hooks_url":"https://api.github.com/repos/shakacode/react_on_rails/hooks","issue_events_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/react_on_rails/events","assignees_url":"https://api.github.com/repos/shakacode/react_on_rails/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/react_on_rails/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/react_on_rails/tags","blobs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/react_on_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/react_on_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/react_on_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/react_on_rails/languages","stargazers_url":"https://api.github.com/repos/shakacode/react_on_rails/stargazers","contributors_url":"https://api.github.com/repos/shakacode/react_on_rails/contributors","subscribers_url":"https://api.github.com/repos/shakacode/react_on_rails/subscribers","subscription_url":"https://api.github.com/repos/shakacode/react_on_rails/subscription","commits_url":"https://api.github.com/repos/shakacode/react_on_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/react_on_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/react_on_rails/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/react_on_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/react_on_rails/merges","archive_url":"https://api.github.com/repos/shakacode/react_on_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/react_on_rails/downloads","issues_url":"https://api.github.com/repos/shakacode/react_on_rails/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/react_on_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/react_on_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/react_on_rails/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/react_on_rails/releases{/id}","created_at":"2015-08-20T20:31:54Z","updated_at":"2015-10-11T20:21:22Z","pushed_at":"2015-10-12T05:12:24Z","git_url":"git://github.com/shakacode/react_on_rails.git","ssh_url":"git@github.com:shakacode/react_on_rails.git","clone_url":"https://github.com/shakacode/react_on_rails.git","svn_url":"https://github.com/shakacode/react_on_rails","homepage":null,"size":792,"stargazers_count":121,"watchers_count":121,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":19,"forks":13,"open_issues":19,"watchers":121,"default_branch":"master"}},"base":{"label":"shakacode:master","ref":"master","sha":"3f8f8d5cc0d78a4e885b819c33a9460ea01ef79a","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":41117523,"name":"react_on_rails","full_name":"shakacode/react_on_rails","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/react_on_rails","description":"Integration of React + Webpack + Rails to build Universal (Isomorphic) Apps","fork":false,"url":"https://api.github.com/repos/shakacode/react_on_rails","forks_url":"https://api.github.com/repos/shakacode/react_on_rails/forks","keys_url":"https://api.github.com/repos/shakacode/react_on_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/react_on_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/react_on_rails/teams","hooks_url":"https://api.github.com/repos/shakacode/react_on_rails/hooks","issue_events_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/react_on_rails/events","assignees_url":"https://api.github.com/repos/shakacode/react_on_rails/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/react_on_rails/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/react_on_rails/tags","blobs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/react_on_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/react_on_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/react_on_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/react_on_rails/languages","stargazers_url":"https://api.github.com/repos/shakacode/react_on_rails/stargazers","contributors_url":"https://api.github.com/repos/shakacode/react_on_rails/contributors","subscribers_url":"https://api.github.com/repos/shakacode/react_on_rails/subscribers","subscription_url":"https://api.github.com/repos/shakacode/react_on_rails/subscription","commits_url":"https://api.github.com/repos/shakacode/react_on_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/react_on_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/react_on_rails/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/react_on_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/react_on_rails/merges","archive_url":"https://api.github.com/repos/shakacode/react_on_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/react_on_rails/downloads","issues_url":"https://api.github.com/repos/shakacode/react_on_rails/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/react_on_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/react_on_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/react_on_rails/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/react_on_rails/releases{/id}","created_at":"2015-08-20T20:31:54Z","updated_at":"2015-10-11T20:21:22Z","pushed_at":"2015-10-12T05:12:24Z","git_url":"git://github.com/shakacode/react_on_rails.git","ssh_url":"git@github.com:shakacode/react_on_rails.git","clone_url":"https://github.com/shakacode/react_on_rails.git","svn_url":"https://github.com/shakacode/react_on_rails","homepage":null,"size":792,"stargazers_count":121,"watchers_count":121,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":19,"forks":13,"open_issues":19,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55"},"html":{"href":"https://github.com/shakacode/react_on_rails/pull/55"},"issue":{"href":"https://api.github.com/repos/shakacode/react_on_rails/issues/55"},"comments":{"href":"https://api.github.com/repos/shakacode/react_on_rails/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/shakacode/react_on_rails/statuses/e3a32e0231fde376bc1f7bc87a39071e49d9396c"}}}}