{"action":"closed","number":1310,"pull_request":{"url":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/1310","id":39214234,"html_url":"https://github.com/sparklemotion/nokogiri/pull/1310","diff_url":"https://github.com/sparklemotion/nokogiri/pull/1310.diff","patch_url":"https://github.com/sparklemotion/nokogiri/pull/1310.patch","issue_url":"https://api.github.com/repos/sparklemotion/nokogiri/issues/1310","number":1310,"state":"closed","locked":false,"title":"Fix windows native build with RubyInstaller and DevKit","user":{"login":"larskanis","id":176234,"avatar_url":"https://avatars.githubusercontent.com/u/176234?v=3","gravatar_id":"","url":"https://api.github.com/users/larskanis","html_url":"https://github.com/larskanis","followers_url":"https://api.github.com/users/larskanis/followers","following_url":"https://api.github.com/users/larskanis/following{/other_user}","gists_url":"https://api.github.com/users/larskanis/gists{/gist_id}","starred_url":"https://api.github.com/users/larskanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskanis/subscriptions","organizations_url":"https://api.github.com/users/larskanis/orgs","repos_url":"https://api.github.com/users/larskanis/repos","events_url":"https://api.github.com/users/larskanis/events{/privacy}","received_events_url":"https://api.github.com/users/larskanis/received_events","type":"User","site_admin":false},"body":"This depends on https://github.com/flavorjones/mini_portile/pull/51 in regards to the handling of configure_options. I therefore assigned a git link in the Gemfile, temporary.\r\n\r\nRubys stdlib shellwords is generelly an issue on Windows. It's sadly, but Windows uses several different ways to escape command line options. While shellwords mostly works in Msys bash (and therefore in a Makefile), it is completely wrong in cmd.exe or msvcrt based programs. It's annoying, but escape rules in mkmf.rb functions (like try_compile etc) are different to that of $CPPFLAGS etc. which run in a Makefile. I made an attempt to codify the different escape rules in, but don't think this is necessary for nokogiri:\r\n   https://github.com/larskanis/shellwords/tree/master/lib/shellwords\r\n\r\nAs a compromise I used String#inspect for the lists of patches. This works well enough on all platforms.\r\n\r\nThis fixes https://github.com/sparklemotion/nokogiri/issues/1190 and already includes  https://github.com/sparklemotion/nokogiri/pull/1308 , to make sure, that the native build is actively checked.\r\n","created_at":"2015-07-04T23:38:53Z","updated_at":"2015-08-24T17:34:29Z","closed_at":"2015-08-24T17:34:29Z","merged_at":null,"merge_commit_sha":"9135dfd159d20452f89eaae746616b613913c852","assignee":{"login":"flavorjones","id":8207,"avatar_url":"https://avatars.githubusercontent.com/u/8207?v=3","gravatar_id":"","url":"https://api.github.com/users/flavorjones","html_url":"https://github.com/flavorjones","followers_url":"https://api.github.com/users/flavorjones/followers","following_url":"https://api.github.com/users/flavorjones/following{/other_user}","gists_url":"https://api.github.com/users/flavorjones/gists{/gist_id}","starred_url":"https://api.github.com/users/flavorjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavorjones/subscriptions","organizations_url":"https://api.github.com/users/flavorjones/orgs","repos_url":"https://api.github.com/users/flavorjones/repos","events_url":"https://api.github.com/users/flavorjones/events{/privacy}","received_events_url":"https://api.github.com/users/flavorjones/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/sparklemotion/nokogiri/milestones/6","html_url":"https://github.com/sparklemotion/nokogiri/milestones/1.6.7","labels_url":"https://api.github.com/repos/sparklemotion/nokogiri/milestones/6/labels","id":968165,"number":6,"title":"1.6.7","description":null,"creator":{"login":"flavorjones","id":8207,"avatar_url":"https://avatars.githubusercontent.com/u/8207?v=3","gravatar_id":"","url":"https://api.github.com/users/flavorjones","html_url":"https://github.com/flavorjones","followers_url":"https://api.github.com/users/flavorjones/followers","following_url":"https://api.github.com/users/flavorjones/following{/other_user}","gists_url":"https://api.github.com/users/flavorjones/gists{/gist_id}","starred_url":"https://api.github.com/users/flavorjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavorjones/subscriptions","organizations_url":"https://api.github.com/users/flavorjones/orgs","repos_url":"https://api.github.com/users/flavorjones/repos","events_url":"https://api.github.com/users/flavorjones/events{/privacy}","received_events_url":"https://api.github.com/users/flavorjones/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2015-02-06T03:36:27Z","updated_at":"2015-08-24T17:34:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sparklemotion/nokogiri/issues/1310/comments","statuses_url":"https://api.github.com/repos/sparklemotion/nokogiri/statuses/205dfa6255eccebd739143fafdb6e37656af7da3","head":{"label":"larskanis:fix-windows-native-build","ref":"fix-windows-native-build","sha":"205dfa6255eccebd739143fafdb6e37656af7da3","user":{"login":"larskanis","id":176234,"avatar_url":"https://avatars.githubusercontent.com/u/176234?v=3","gravatar_id":"","url":"https://api.github.com/users/larskanis","html_url":"https://github.com/larskanis","followers_url":"https://api.github.com/users/larskanis/followers","following_url":"https://api.github.com/users/larskanis/following{/other_user}","gists_url":"https://api.github.com/users/larskanis/gists{/gist_id}","starred_url":"https://api.github.com/users/larskanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskanis/subscriptions","organizations_url":"https://api.github.com/users/larskanis/orgs","repos_url":"https://api.github.com/users/larskanis/repos","events_url":"https://api.github.com/users/larskanis/events{/privacy}","received_events_url":"https://api.github.com/users/larskanis/received_events","type":"User","site_admin":false},"repo":{"id":13387637,"name":"nokogiri","full_name":"larskanis/nokogiri","owner":{"login":"larskanis","id":176234,"avatar_url":"https://avatars.githubusercontent.com/u/176234?v=3","gravatar_id":"","url":"https://api.github.com/users/larskanis","html_url":"https://github.com/larskanis","followers_url":"https://api.github.com/users/larskanis/followers","following_url":"https://api.github.com/users/larskanis/following{/other_user}","gists_url":"https://api.github.com/users/larskanis/gists{/gist_id}","starred_url":"https://api.github.com/users/larskanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskanis/subscriptions","organizations_url":"https://api.github.com/users/larskanis/orgs","repos_url":"https://api.github.com/users/larskanis/repos","events_url":"https://api.github.com/users/larskanis/events{/privacy}","received_events_url":"https://api.github.com/users/larskanis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larskanis/nokogiri","description":"Nokogiri (鋸) is an HTML, XML, SAX, and Reader parser with XPath and CSS selector support.","fork":true,"url":"https://api.github.com/repos/larskanis/nokogiri","forks_url":"https://api.github.com/repos/larskanis/nokogiri/forks","keys_url":"https://api.github.com/repos/larskanis/nokogiri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larskanis/nokogiri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larskanis/nokogiri/teams","hooks_url":"https://api.github.com/repos/larskanis/nokogiri/hooks","issue_events_url":"https://api.github.com/repos/larskanis/nokogiri/issues/events{/number}","events_url":"https://api.github.com/repos/larskanis/nokogiri/events","assignees_url":"https://api.github.com/repos/larskanis/nokogiri/assignees{/user}","branches_url":"https://api.github.com/repos/larskanis/nokogiri/branches{/branch}","tags_url":"https://api.github.com/repos/larskanis/nokogiri/tags","blobs_url":"https://api.github.com/repos/larskanis/nokogiri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larskanis/nokogiri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larskanis/nokogiri/git/refs{/sha}","trees_url":"https://api.github.com/repos/larskanis/nokogiri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larskanis/nokogiri/statuses/{sha}","languages_url":"https://api.github.com/repos/larskanis/nokogiri/languages","stargazers_url":"https://api.github.com/repos/larskanis/nokogiri/stargazers","contributors_url":"https://api.github.com/repos/larskanis/nokogiri/contributors","subscribers_url":"https://api.github.com/repos/larskanis/nokogiri/subscribers","subscription_url":"https://api.github.com/repos/larskanis/nokogiri/subscription","commits_url":"https://api.github.com/repos/larskanis/nokogiri/commits{/sha}","git_commits_url":"https://api.github.com/repos/larskanis/nokogiri/git/commits{/sha}","comments_url":"https://api.github.com/repos/larskanis/nokogiri/comments{/number}","issue_comment_url":"https://api.github.com/repos/larskanis/nokogiri/issues/comments{/number}","contents_url":"https://api.github.com/repos/larskanis/nokogiri/contents/{+path}","compare_url":"https://api.github.com/repos/larskanis/nokogiri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larskanis/nokogiri/merges","archive_url":"https://api.github.com/repos/larskanis/nokogiri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larskanis/nokogiri/downloads","issues_url":"https://api.github.com/repos/larskanis/nokogiri/issues{/number}","pulls_url":"https://api.github.com/repos/larskanis/nokogiri/pulls{/number}","milestones_url":"https://api.github.com/repos/larskanis/nokogiri/milestones{/number}","notifications_url":"https://api.github.com/repos/larskanis/nokogiri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larskanis/nokogiri/labels{/name}","releases_url":"https://api.github.com/repos/larskanis/nokogiri/releases{/id}","created_at":"2013-10-07T15:32:00Z","updated_at":"2015-07-03T16:01:06Z","pushed_at":"2015-07-05T18:38:24Z","git_url":"git://github.com/larskanis/nokogiri.git","ssh_url":"git@github.com:larskanis/nokogiri.git","clone_url":"https://github.com/larskanis/nokogiri.git","svn_url":"https://github.com/larskanis/nokogiri","homepage":"http://nokogiri.org/","size":7686,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"sparklemotion:master","ref":"master","sha":"1be883111f80048d6e88201d263c83e0c37c90fa","user":{"login":"sparklemotion","id":1851072,"avatar_url":"https://avatars.githubusercontent.com/u/1851072?v=3","gravatar_id":"","url":"https://api.github.com/users/sparklemotion","html_url":"https://github.com/sparklemotion","followers_url":"https://api.github.com/users/sparklemotion/followers","following_url":"https://api.github.com/users/sparklemotion/following{/other_user}","gists_url":"https://api.github.com/users/sparklemotion/gists{/gist_id}","starred_url":"https://api.github.com/users/sparklemotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparklemotion/subscriptions","organizations_url":"https://api.github.com/users/sparklemotion/orgs","repos_url":"https://api.github.com/users/sparklemotion/repos","events_url":"https://api.github.com/users/sparklemotion/events{/privacy}","received_events_url":"https://api.github.com/users/sparklemotion/received_events","type":"Organization","site_admin":false},"repo":{"id":33945,"name":"nokogiri","full_name":"sparklemotion/nokogiri","owner":{"login":"sparklemotion","id":1851072,"avatar_url":"https://avatars.githubusercontent.com/u/1851072?v=3","gravatar_id":"","url":"https://api.github.com/users/sparklemotion","html_url":"https://github.com/sparklemotion","followers_url":"https://api.github.com/users/sparklemotion/followers","following_url":"https://api.github.com/users/sparklemotion/following{/other_user}","gists_url":"https://api.github.com/users/sparklemotion/gists{/gist_id}","starred_url":"https://api.github.com/users/sparklemotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparklemotion/subscriptions","organizations_url":"https://api.github.com/users/sparklemotion/orgs","repos_url":"https://api.github.com/users/sparklemotion/repos","events_url":"https://api.github.com/users/sparklemotion/events{/privacy}","received_events_url":"https://api.github.com/users/sparklemotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sparklemotion/nokogiri","description":"Nokogiri (鋸) is an HTML, XML, SAX, and Reader parser with XPath and CSS selector support.","fork":false,"url":"https://api.github.com/repos/sparklemotion/nokogiri","forks_url":"https://api.github.com/repos/sparklemotion/nokogiri/forks","keys_url":"https://api.github.com/repos/sparklemotion/nokogiri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparklemotion/nokogiri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparklemotion/nokogiri/teams","hooks_url":"https://api.github.com/repos/sparklemotion/nokogiri/hooks","issue_events_url":"https://api.github.com/repos/sparklemotion/nokogiri/issues/events{/number}","events_url":"https://api.github.com/repos/sparklemotion/nokogiri/events","assignees_url":"https://api.github.com/repos/sparklemotion/nokogiri/assignees{/user}","branches_url":"https://api.github.com/repos/sparklemotion/nokogiri/branches{/branch}","tags_url":"https://api.github.com/repos/sparklemotion/nokogiri/tags","blobs_url":"https://api.github.com/repos/sparklemotion/nokogiri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparklemotion/nokogiri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparklemotion/nokogiri/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparklemotion/nokogiri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparklemotion/nokogiri/statuses/{sha}","languages_url":"https://api.github.com/repos/sparklemotion/nokogiri/languages","stargazers_url":"https://api.github.com/repos/sparklemotion/nokogiri/stargazers","contributors_url":"https://api.github.com/repos/sparklemotion/nokogiri/contributors","subscribers_url":"https://api.github.com/repos/sparklemotion/nokogiri/subscribers","subscription_url":"https://api.github.com/repos/sparklemotion/nokogiri/subscription","commits_url":"https://api.github.com/repos/sparklemotion/nokogiri/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparklemotion/nokogiri/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparklemotion/nokogiri/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparklemotion/nokogiri/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparklemotion/nokogiri/contents/{+path}","compare_url":"https://api.github.com/repos/sparklemotion/nokogiri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparklemotion/nokogiri/merges","archive_url":"https://api.github.com/repos/sparklemotion/nokogiri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparklemotion/nokogiri/downloads","issues_url":"https://api.github.com/repos/sparklemotion/nokogiri/issues{/number}","pulls_url":"https://api.github.com/repos/sparklemotion/nokogiri/pulls{/number}","milestones_url":"https://api.github.com/repos/sparklemotion/nokogiri/milestones{/number}","notifications_url":"https://api.github.com/repos/sparklemotion/nokogiri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparklemotion/nokogiri/labels{/name}","releases_url":"https://api.github.com/repos/sparklemotion/nokogiri/releases{/id}","created_at":"2008-07-14T15:34:32Z","updated_at":"2015-08-23T14:44:00Z","pushed_at":"2015-08-24T04:20:04Z","git_url":"git://github.com/sparklemotion/nokogiri.git","ssh_url":"git@github.com:sparklemotion/nokogiri.git","clone_url":"https://github.com/sparklemotion/nokogiri.git","svn_url":"https://github.com/sparklemotion/nokogiri","homepage":"http://nokogiri.org/","size":16417,"stargazers_count":3400,"watchers_count":3400,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":476,"mirror_url":null,"open_issues_count":232,"forks":476,"open_issues":232,"watchers":3400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/1310"},"html":{"href":"https://github.com/sparklemotion/nokogiri/pull/1310"},"issue":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/issues/1310"},"comments":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/sparklemotion/nokogiri/statuses/205dfa6255eccebd739143fafdb6e37656af7da3"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":9,"review_comments":2,"commits":2,"additions":42,"deletions":17,"changed_files":4}}