{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31290827","id":31290827,"diff_hunk":"@@ -66,9 +68,13 @@ func GetMountRefs(mounter Interface, mountPath string) ([]string, error) {\n \n \t// Find all references to the device.\n \tvar refs []string\n-\tfor i := range mps {\n-\t\tif mps[i].Device == deviceName && mps[i].Path != mountPath {\n-\t\t\trefs = append(refs, mps[i].Path)\n+\tif deviceName == \"\" {\n+\t\tglog.Warningf(\"could not determine device for path: %s\", mountPath)","path":"pkg/util/mount/mount.go","position":17,"original_position":17,"commit_id":"76b51af4ff15dc395ab25bec69e832497800245a","original_commit_id":"76b51af4ff15dc395ab25bec69e832497800245a","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"nit: %q instead of %s which usually helps with debugging.","created_at":"2015-05-29T00:29:33Z","updated_at":"2015-05-29T00:29:33Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8912#discussion_r31290827","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31290827"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8912#discussion_r31290827"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912","id":36393600,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8912","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8912.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8912.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8912","number":8912,"state":"open","locked":false,"title":"Ensure kubelet root is not a symlink","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"The dismount detection logic was broken when /var/lib/kubelet was a symlink. This is because mounts are reported with the canonicalized (dereferenced-symlinks) path, and that wasn't matching the path we expected.\r\n\r\nWe used a symlink on AWS to put /var/lib/kubelet onto /mnt/kubelet, but now we tell kubelet the correct path.\r\n\r\nIn that example, the mounts are reported as \"/mnt/kubelet/...\", but we were looking for \"/var/lib/kubelet/...\"","created_at":"2015-05-28T10:44:50Z","updated_at":"2015-05-29T00:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49c387e2bf49fbf000f295a9617205b5a1a6ed62","assignee":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8912/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/76b51af4ff15dc395ab25bec69e832497800245a","head":{"label":"justinsb:volumes_kubelet_root_not_symlink","ref":"volumes_kubelet_root_not_symlink","sha":"76b51af4ff15dc395ab25bec69e832497800245a","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"repo":{"id":26103010,"name":"kubernetes","full_name":"justinsb/kubernetes","owner":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinsb/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/justinsb/kubernetes","forks_url":"https://api.github.com/repos/justinsb/kubernetes/forks","keys_url":"https://api.github.com/repos/justinsb/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinsb/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinsb/kubernetes/teams","hooks_url":"https://api.github.com/repos/justinsb/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/justinsb/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/justinsb/kubernetes/events","assignees_url":"https://api.github.com/repos/justinsb/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/justinsb/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/justinsb/kubernetes/tags","blobs_url":"https://api.github.com/repos/justinsb/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinsb/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinsb/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinsb/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinsb/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/justinsb/kubernetes/languages","stargazers_url":"https://api.github.com/repos/justinsb/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/justinsb/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/justinsb/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/justinsb/kubernetes/subscription","commits_url":"https://api.github.com/repos/justinsb/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinsb/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinsb/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinsb/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinsb/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/justinsb/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinsb/kubernetes/merges","archive_url":"https://api.github.com/repos/justinsb/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinsb/kubernetes/downloads","issues_url":"https://api.github.com/repos/justinsb/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/justinsb/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/justinsb/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/justinsb/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinsb/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/justinsb/kubernetes/releases{/id}","created_at":"2014-11-03T03:53:05Z","updated_at":"2015-02-24T20:55:05Z","pushed_at":"2015-05-28T10:58:21Z","git_url":"git://github.com/justinsb/kubernetes.git","ssh_url":"git@github.com:justinsb/kubernetes.git","clone_url":"https://github.com/justinsb/kubernetes.git","svn_url":"https://github.com/justinsb/kubernetes","homepage":null,"size":61651,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6ffe46a9e0ef94be20e93f409dbf19b0f19f9320","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-05-28T23:22:31Z","pushed_at":"2015-05-29T00:25:02Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":297256,"stargazers_count":7972,"watchers_count":7972,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1667,"mirror_url":null,"open_issues_count":1240,"forks":1667,"open_issues":1240,"watchers":7972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8912"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8912"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8912/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8912/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/76b51af4ff15dc395ab25bec69e832497800245a"}}}}