{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments/31529233","id":31529233,"diff_hunk":"@@ -257,6 +258,37 @@ func (m *Memberlist) probeNode(node *nodeState) {\n \t\t}\n \t}\n \n+\t// Also make an attempt to contact the node directly over TCP. This\n+\t// helps prevent confused clients who get isolated from UDP traffic\n+\t// but can still speak TCP (which also means they can possibly report\n+\t// misinformation to other nodes via anti-entropy), avoiding flapping in\n+\t// the cluster.\n+\tfallbackCh := make(chan bool)\n+\tif node.PMax >= 3 {\n+\t\tdestAddr := &net.TCPAddr{IP: node.Addr, Port: int(node.Port)}","path":"state.go","position":19,"original_position":19,"commit_id":"3e161d2c9161ba7f9f8ff091f57c8f6affccbbea","original_commit_id":"3e161d2c9161ba7f9f8ff091f57c8f6affccbbea","user":{"login":"slackpad","id":673509,"avatar_url":"https://avatars.githubusercontent.com/u/673509?v=3","gravatar_id":"","url":"https://api.github.com/users/slackpad","html_url":"https://github.com/slackpad","followers_url":"https://api.github.com/users/slackpad/followers","following_url":"https://api.github.com/users/slackpad/following{/other_user}","gists_url":"https://api.github.com/users/slackpad/gists{/gist_id}","starred_url":"https://api.github.com/users/slackpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackpad/subscriptions","organizations_url":"https://api.github.com/users/slackpad/orgs","repos_url":"https://api.github.com/users/slackpad/repos","events_url":"https://api.github.com/users/slackpad/events{/privacy}","received_events_url":"https://api.github.com/users/slackpad/received_events","type":"User","site_admin":false},"body":"Haha - I had the bool and took it out because it felt weird to have that extra interface just for that behavior. After sleeping on it, though, I agree with you it would simplify things on the side where things are already complicated, and it'll get rid of the `dial` call outside of the `net` module - I'll change it.","created_at":"2015-06-02T14:37:44Z","updated_at":"2015-06-02T14:37:44Z","html_url":"https://github.com/hashicorp/memberlist/pull/37#discussion_r31529233","pull_request_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments/31529233"},"html":{"href":"https://github.com/hashicorp/memberlist/pull/37#discussion_r31529233"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/memberlist/pulls/37","id":36696695,"html_url":"https://github.com/hashicorp/memberlist/pull/37","diff_url":"https://github.com/hashicorp/memberlist/pull/37.diff","patch_url":"https://github.com/hashicorp/memberlist/pull/37.patch","issue_url":"https://api.github.com/repos/hashicorp/memberlist/issues/37","number":37,"state":"open","locked":false,"title":"Adds TCP direct pings.","user":{"login":"slackpad","id":673509,"avatar_url":"https://avatars.githubusercontent.com/u/673509?v=3","gravatar_id":"","url":"https://api.github.com/users/slackpad","html_url":"https://github.com/slackpad","followers_url":"https://api.github.com/users/slackpad/followers","following_url":"https://api.github.com/users/slackpad/following{/other_user}","gists_url":"https://api.github.com/users/slackpad/gists{/gist_id}","starred_url":"https://api.github.com/users/slackpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackpad/subscriptions","organizations_url":"https://api.github.com/users/slackpad/orgs","repos_url":"https://api.github.com/users/slackpad/repos","events_url":"https://api.github.com/users/slackpad/events{/privacy}","received_events_url":"https://api.github.com/users/slackpad/received_events","type":"User","site_admin":false},"body":"Here's an initial cut at the fix for hashicorp/consul#742. It adds a TCP-based direct ping pipelined with the normal UDP indirect pings if the direct UDP ping fails. If all the UDP-based pings fail and the TCP-based ping works, then a log message will be generated to alert the user that their networking config isn't right.","created_at":"2015-06-02T05:55:07Z","updated_at":"2015-06-02T14:37:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c5f628a8aaa0dc0ad2d69bb17369fa5b4a8d1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/37/commits","review_comments_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/37/comments","review_comment_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/memberlist/issues/37/comments","statuses_url":"https://api.github.com/repos/hashicorp/memberlist/statuses/3e161d2c9161ba7f9f8ff091f57c8f6affccbbea","head":{"label":"hashicorp:f-tcp-pings","ref":"f-tcp-pings","sha":"3e161d2c9161ba7f9f8ff091f57c8f6affccbbea","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":12712630,"name":"memberlist","full_name":"hashicorp/memberlist","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/memberlist","description":"Golang package for gossip based membership and failure detection","fork":false,"url":"https://api.github.com/repos/hashicorp/memberlist","forks_url":"https://api.github.com/repos/hashicorp/memberlist/forks","keys_url":"https://api.github.com/repos/hashicorp/memberlist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/memberlist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/memberlist/teams","hooks_url":"https://api.github.com/repos/hashicorp/memberlist/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/memberlist/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/memberlist/events","assignees_url":"https://api.github.com/repos/hashicorp/memberlist/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/memberlist/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/memberlist/tags","blobs_url":"https://api.github.com/repos/hashicorp/memberlist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/memberlist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/memberlist/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/memberlist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/memberlist/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/memberlist/languages","stargazers_url":"https://api.github.com/repos/hashicorp/memberlist/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/memberlist/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/memberlist/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/memberlist/subscription","commits_url":"https://api.github.com/repos/hashicorp/memberlist/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/memberlist/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/memberlist/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/memberlist/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/memberlist/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/memberlist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/memberlist/merges","archive_url":"https://api.github.com/repos/hashicorp/memberlist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/memberlist/downloads","issues_url":"https://api.github.com/repos/hashicorp/memberlist/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/memberlist/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/memberlist/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/memberlist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/memberlist/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/memberlist/releases{/id}","created_at":"2013-09-09T20:59:27Z","updated_at":"2015-06-02T09:49:39Z","pushed_at":"2015-06-02T05:55:08Z","git_url":"git://github.com/hashicorp/memberlist.git","ssh_url":"git@github.com:hashicorp/memberlist.git","clone_url":"https://github.com/hashicorp/memberlist.git","svn_url":"https://github.com/hashicorp/memberlist","homepage":null,"size":1776,"stargazers_count":240,"watchers_count":240,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":3,"forks":44,"open_issues":3,"watchers":240,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"6025015f2dc659ca2c735112d37e753bda6e329d","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":12712630,"name":"memberlist","full_name":"hashicorp/memberlist","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/memberlist","description":"Golang package for gossip based membership and failure detection","fork":false,"url":"https://api.github.com/repos/hashicorp/memberlist","forks_url":"https://api.github.com/repos/hashicorp/memberlist/forks","keys_url":"https://api.github.com/repos/hashicorp/memberlist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/memberlist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/memberlist/teams","hooks_url":"https://api.github.com/repos/hashicorp/memberlist/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/memberlist/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/memberlist/events","assignees_url":"https://api.github.com/repos/hashicorp/memberlist/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/memberlist/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/memberlist/tags","blobs_url":"https://api.github.com/repos/hashicorp/memberlist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/memberlist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/memberlist/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/memberlist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/memberlist/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/memberlist/languages","stargazers_url":"https://api.github.com/repos/hashicorp/memberlist/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/memberlist/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/memberlist/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/memberlist/subscription","commits_url":"https://api.github.com/repos/hashicorp/memberlist/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/memberlist/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/memberlist/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/memberlist/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/memberlist/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/memberlist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/memberlist/merges","archive_url":"https://api.github.com/repos/hashicorp/memberlist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/memberlist/downloads","issues_url":"https://api.github.com/repos/hashicorp/memberlist/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/memberlist/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/memberlist/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/memberlist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/memberlist/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/memberlist/releases{/id}","created_at":"2013-09-09T20:59:27Z","updated_at":"2015-06-02T09:49:39Z","pushed_at":"2015-06-02T05:55:08Z","git_url":"git://github.com/hashicorp/memberlist.git","ssh_url":"git@github.com:hashicorp/memberlist.git","clone_url":"https://github.com/hashicorp/memberlist.git","svn_url":"https://github.com/hashicorp/memberlist","homepage":null,"size":1776,"stargazers_count":240,"watchers_count":240,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":3,"forks":44,"open_issues":3,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/37"},"html":{"href":"https://github.com/hashicorp/memberlist/pull/37"},"issue":{"href":"https://api.github.com/repos/hashicorp/memberlist/issues/37"},"comments":{"href":"https://api.github.com/repos/hashicorp/memberlist/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/memberlist/statuses/3e161d2c9161ba7f9f8ff091f57c8f6affccbbea"}}}}