{"action":"closed","number":208,"pull_request":{"url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/208","id":35937336,"html_url":"https://github.com/alphagov/finder-frontend/pull/208","diff_url":"https://github.com/alphagov/finder-frontend/pull/208.diff","patch_url":"https://github.com/alphagov/finder-frontend/pull/208.patch","issue_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/208","number":208,"state":"closed","locked":false,"title":"Disable atom feed if finder has a default order","user":{"login":"tommyp","id":449004,"avatar_url":"https://avatars.githubusercontent.com/u/449004?v=3","gravatar_id":"","url":"https://api.github.com/users/tommyp","html_url":"https://github.com/tommyp","followers_url":"https://api.github.com/users/tommyp/followers","following_url":"https://api.github.com/users/tommyp/following{/other_user}","gists_url":"https://api.github.com/users/tommyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tommyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommyp/subscriptions","organizations_url":"https://api.github.com/users/tommyp/orgs","repos_url":"https://api.github.com/users/tommyp/repos","events_url":"https://api.github.com/users/tommyp/events{/privacy}","received_events_url":"https://api.github.com/users/tommyp/received_events","type":"User","site_admin":false},"body":"When a Finder has a default_order we want to disable the atom feed from\r\nappearing. The current behaviour of a Finder having an atom feed is\r\nunchanged unless the Finder has a default_order. This commit changes the\r\natom_url method to return nil if the Finder has a default order, hides\r\nthe atom_url link if that is nil in the hash and only responds to the\r\natom format if the atom_url method isn't nil.","created_at":"2015-05-21T14:11:12Z","updated_at":"2015-05-26T09:58:10Z","closed_at":"2015-05-26T09:58:10Z","merged_at":"2015-05-26T09:58:10Z","merge_commit_sha":"1e20aa7449cd1422891f96288cf4dc65627fa556","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/208/commits","review_comments_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/208/comments","review_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/208/comments","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/8add194a797ebc6217fe805d22d85f5b27ab235d","head":{"label":"alphagov:disable-atom-feed","ref":"disable-atom-feed","sha":"8add194a797ebc6217fe805d22d85f5b27ab235d","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176176,"name":"finder-frontend","full_name":"alphagov/finder-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/finder-frontend","description":"Faceted searching over documents.","fork":false,"url":"https://api.github.com/repos/alphagov/finder-frontend","forks_url":"https://api.github.com/repos/alphagov/finder-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/finder-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finder-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finder-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/finder-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finder-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/finder-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finder-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finder-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finder-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finder-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finder-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/finder-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finder-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finder-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finder-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/finder-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finder-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/finder-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finder-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finder-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/finder-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finder-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/finder-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finder-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finder-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finder-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finder-frontend/releases{/id}","created_at":"2014-01-23T15:21:03Z","updated_at":"2015-05-07T10:11:47Z","pushed_at":"2015-05-26T09:58:11Z","git_url":"git://github.com/alphagov/finder-frontend.git","ssh_url":"git@github.com:alphagov/finder-frontend.git","clone_url":"https://github.com/alphagov/finder-frontend.git","svn_url":"https://github.com/alphagov/finder-frontend","homepage":"","size":6094,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"3af261f47821271ae1612d8ee0f9ee0ea623f189","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176176,"name":"finder-frontend","full_name":"alphagov/finder-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/finder-frontend","description":"Faceted searching over documents.","fork":false,"url":"https://api.github.com/repos/alphagov/finder-frontend","forks_url":"https://api.github.com/repos/alphagov/finder-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/finder-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finder-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finder-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/finder-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finder-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/finder-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finder-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finder-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finder-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finder-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finder-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/finder-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finder-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finder-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finder-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/finder-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finder-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/finder-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finder-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finder-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/finder-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finder-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/finder-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finder-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finder-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finder-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finder-frontend/releases{/id}","created_at":"2014-01-23T15:21:03Z","updated_at":"2015-05-07T10:11:47Z","pushed_at":"2015-05-26T09:58:11Z","git_url":"git://github.com/alphagov/finder-frontend.git","ssh_url":"git@github.com:alphagov/finder-frontend.git","clone_url":"https://github.com/alphagov/finder-frontend.git","svn_url":"https://github.com/alphagov/finder-frontend","homepage":"","size":6094,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/208"},"html":{"href":"https://github.com/alphagov/finder-frontend/pull/208"},"issue":{"href":"https://api.github.com/repos/alphagov/finder-frontend/issues/208"},"comments":{"href":"https://api.github.com/repos/alphagov/finder-frontend/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/finder-frontend/statuses/8add194a797ebc6217fe805d22d85f5b27ab235d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"evilstreak","id":74812,"avatar_url":"https://avatars.githubusercontent.com/u/74812?v=3","gravatar_id":"","url":"https://api.github.com/users/evilstreak","html_url":"https://github.com/evilstreak","followers_url":"https://api.github.com/users/evilstreak/followers","following_url":"https://api.github.com/users/evilstreak/following{/other_user}","gists_url":"https://api.github.com/users/evilstreak/gists{/gist_id}","starred_url":"https://api.github.com/users/evilstreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilstreak/subscriptions","organizations_url":"https://api.github.com/users/evilstreak/orgs","repos_url":"https://api.github.com/users/evilstreak/repos","events_url":"https://api.github.com/users/evilstreak/events{/privacy}","received_events_url":"https://api.github.com/users/evilstreak/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":1,"additions":32,"deletions":7,"changed_files":4}}