{"action":"created","issue":{"url":"https://api.github.com/repos/cowboyd/therubyracer/issues/368","labels_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/368/comments","events_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/368/events","html_url":"https://github.com/cowboyd/therubyracer/pull/368","id":95984386,"number":368,"title":"normalize value handling","user":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-20T04:35:06Z","updated_at":"2015-07-21T11:52:52Z","closed_at":"2015-07-21T11:51:56Z","pull_request":{"url":"https://api.github.com/repos/cowboyd/therubyracer/pulls/368","html_url":"https://github.com/cowboyd/therubyracer/pull/368","diff_url":"https://github.com/cowboyd/therubyracer/pull/368.diff","patch_url":"https://github.com/cowboyd/therubyracer/pull/368.patch"},"body":"This pull requests normalizes value handling in two ways. First, gets rid of the special cases for `Undefined` and `Null` which are actually represented as objects inside v8, so should be represented as objects in our C layer. (we should also add at some point impmente `V8::C::V8::Undefined(@isolate)` and `V8::C::V8::Null(@isolate) ` in order to retreive those values explicitly)\r\n\r\nSecond, it makes the normal `Value::operator VALUE()` perform the thunk-down on type so that when returning a `v8::Value` to Ruby, there's nothing more to do than use the normal `Value(isolate, handle)` constructor to get the most specific Ruby class."},"comment":{"url":"https://api.github.com/repos/cowboyd/therubyracer/issues/comments/123280089","html_url":"https://github.com/cowboyd/therubyracer/pull/368#issuecomment-123280089","issue_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/368","id":123280089,"user":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T11:52:52Z","updated_at":"2015-07-21T11:52:52Z","body":"Awesome! Merged."}}