{"action":"created","comment":{"url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/comments/31165781","id":31165781,"diff_hunk":"@@ -47,7 +51,13 @@\n (defn upload-to-s3\n   \"Uploads the generated xml file to the specified S3 bucket.\"\n   [ctx]\n-  (let [new-filename (xml-filename ctx)]\n-    (put-object (str \"processed-feeds/\" new-filename)\n-                (.toFile (:xml-output-file ctx)))\n-    (assoc ctx :generated-xml-filename new-filename)))\n+  (let [zip-filename (str (xml-filename ctx) \".zip\")\n+        xml-file (-> ctx :xml-output-file .toFile)\n+        zip-file (ZipFile. zip-filename)\n+        zip-params (doto (ZipParameters.)\n+                     (.setCompressionLevel\n+                      Zip4jConstants/DEFLATE_LEVEL_NORMAL))]\n+    (.createZipFile zip-file xml-file zip-params)","path":"src/vip/data_processor/s3.clj","position":29,"original_position":29,"commit_id":"1ba3c10da5b9fa5fb76072e181bc0f0de5eef5d8","original_commit_id":"1ba3c10da5b9fa5fb76072e181bc0f0de5eef5d8","user":{"login":"tank157","id":4147,"avatar_url":"https://avatars.githubusercontent.com/u/4147?v=3","gravatar_id":"","url":"https://api.github.com/users/tank157","html_url":"https://github.com/tank157","followers_url":"https://api.github.com/users/tank157/followers","following_url":"https://api.github.com/users/tank157/following{/other_user}","gists_url":"https://api.github.com/users/tank157/gists{/gist_id}","starred_url":"https://api.github.com/users/tank157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tank157/subscriptions","organizations_url":"https://api.github.com/users/tank157/orgs","repos_url":"https://api.github.com/users/tank157/repos","events_url":"https://api.github.com/users/tank157/events{/privacy}","received_events_url":"https://api.github.com/users/tank157/received_events","type":"User","site_admin":false},"body":"So is this going to write a file, and if so, do we need to do any cleanup? I assume it's in a tmp folder type situation, but even those can fill up.","created_at":"2015-05-27T18:36:14Z","updated_at":"2015-05-27T18:36:14Z","html_url":"https://github.com/votinginfoproject/data-processor/pull/56#discussion_r31165781","pull_request_url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/comments/31165781"},"html":{"href":"https://github.com/votinginfoproject/data-processor/pull/56#discussion_r31165781"},"pull_request":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56","id":36329414,"html_url":"https://github.com/votinginfoproject/data-processor/pull/56","diff_url":"https://github.com/votinginfoproject/data-processor/pull/56.diff","patch_url":"https://github.com/votinginfoproject/data-processor/pull/56.patch","issue_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues/56","number":56,"state":"open","locked":false,"title":"[CS WR] zip up the final xml","user":{"login":"bwreid","id":1316902,"avatar_url":"https://avatars.githubusercontent.com/u/1316902?v=3","gravatar_id":"","url":"https://api.github.com/users/bwreid","html_url":"https://github.com/bwreid","followers_url":"https://api.github.com/users/bwreid/followers","following_url":"https://api.github.com/users/bwreid/following{/other_user}","gists_url":"https://api.github.com/users/bwreid/gists{/gist_id}","starred_url":"https://api.github.com/users/bwreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwreid/subscriptions","organizations_url":"https://api.github.com/users/bwreid/orgs","repos_url":"https://api.github.com/users/bwreid/repos","events_url":"https://api.github.com/users/bwreid/events{/privacy}","received_events_url":"https://api.github.com/users/bwreid/received_events","type":"User","site_admin":false},"body":"[Pivotal Card 94345396](https://www.pivotaltracker.com/story/show/94345396)\r\n\r\nThis PR allows us to zip the final XML that is outputted by data-processor.","created_at":"2015-05-27T17:42:38Z","updated_at":"2015-05-27T18:36:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77a408d9c2ca05efe5a736216aea4275ae346d28","assignee":{"login":"tank157","id":4147,"avatar_url":"https://avatars.githubusercontent.com/u/4147?v=3","gravatar_id":"","url":"https://api.github.com/users/tank157","html_url":"https://github.com/tank157","followers_url":"https://api.github.com/users/tank157/followers","following_url":"https://api.github.com/users/tank157/following{/other_user}","gists_url":"https://api.github.com/users/tank157/gists{/gist_id}","starred_url":"https://api.github.com/users/tank157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tank157/subscriptions","organizations_url":"https://api.github.com/users/tank157/orgs","repos_url":"https://api.github.com/users/tank157/repos","events_url":"https://api.github.com/users/tank157/events{/privacy}","received_events_url":"https://api.github.com/users/tank157/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56/commits","review_comments_url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56/comments","review_comment_url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues/56/comments","statuses_url":"https://api.github.com/repos/votinginfoproject/data-processor/statuses/1ba3c10da5b9fa5fb76072e181bc0f0de5eef5d8","head":{"label":"votinginfoproject:zip-xml","ref":"zip-xml","sha":"1ba3c10da5b9fa5fb76072e181bc0f0de5eef5d8","user":{"login":"votinginfoproject","id":317805,"avatar_url":"https://avatars.githubusercontent.com/u/317805?v=3","gravatar_id":"","url":"https://api.github.com/users/votinginfoproject","html_url":"https://github.com/votinginfoproject","followers_url":"https://api.github.com/users/votinginfoproject/followers","following_url":"https://api.github.com/users/votinginfoproject/following{/other_user}","gists_url":"https://api.github.com/users/votinginfoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/votinginfoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votinginfoproject/subscriptions","organizations_url":"https://api.github.com/users/votinginfoproject/orgs","repos_url":"https://api.github.com/users/votinginfoproject/repos","events_url":"https://api.github.com/users/votinginfoproject/events{/privacy}","received_events_url":"https://api.github.com/users/votinginfoproject/received_events","type":"Organization","site_admin":false},"repo":{"id":29880296,"name":"data-processor","full_name":"votinginfoproject/data-processor","owner":{"login":"votinginfoproject","id":317805,"avatar_url":"https://avatars.githubusercontent.com/u/317805?v=3","gravatar_id":"","url":"https://api.github.com/users/votinginfoproject","html_url":"https://github.com/votinginfoproject","followers_url":"https://api.github.com/users/votinginfoproject/followers","following_url":"https://api.github.com/users/votinginfoproject/following{/other_user}","gists_url":"https://api.github.com/users/votinginfoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/votinginfoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votinginfoproject/subscriptions","organizations_url":"https://api.github.com/users/votinginfoproject/orgs","repos_url":"https://api.github.com/users/votinginfoproject/repos","events_url":"https://api.github.com/users/votinginfoproject/events{/privacy}","received_events_url":"https://api.github.com/users/votinginfoproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/votinginfoproject/data-processor","description":"VIP data processing","fork":false,"url":"https://api.github.com/repos/votinginfoproject/data-processor","forks_url":"https://api.github.com/repos/votinginfoproject/data-processor/forks","keys_url":"https://api.github.com/repos/votinginfoproject/data-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/votinginfoproject/data-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/votinginfoproject/data-processor/teams","hooks_url":"https://api.github.com/repos/votinginfoproject/data-processor/hooks","issue_events_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues/events{/number}","events_url":"https://api.github.com/repos/votinginfoproject/data-processor/events","assignees_url":"https://api.github.com/repos/votinginfoproject/data-processor/assignees{/user}","branches_url":"https://api.github.com/repos/votinginfoproject/data-processor/branches{/branch}","tags_url":"https://api.github.com/repos/votinginfoproject/data-processor/tags","blobs_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/votinginfoproject/data-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/votinginfoproject/data-processor/languages","stargazers_url":"https://api.github.com/repos/votinginfoproject/data-processor/stargazers","contributors_url":"https://api.github.com/repos/votinginfoproject/data-processor/contributors","subscribers_url":"https://api.github.com/repos/votinginfoproject/data-processor/subscribers","subscription_url":"https://api.github.com/repos/votinginfoproject/data-processor/subscription","commits_url":"https://api.github.com/repos/votinginfoproject/data-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/votinginfoproject/data-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/votinginfoproject/data-processor/contents/{+path}","compare_url":"https://api.github.com/repos/votinginfoproject/data-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/votinginfoproject/data-processor/merges","archive_url":"https://api.github.com/repos/votinginfoproject/data-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/votinginfoproject/data-processor/downloads","issues_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues{/number}","pulls_url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/votinginfoproject/data-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/votinginfoproject/data-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/votinginfoproject/data-processor/labels{/name}","releases_url":"https://api.github.com/repos/votinginfoproject/data-processor/releases{/id}","created_at":"2015-01-26T20:34:26Z","updated_at":"2015-05-08T19:59:05Z","pushed_at":"2015-05-27T17:42:38Z","git_url":"git://github.com/votinginfoproject/data-processor.git","ssh_url":"git@github.com:votinginfoproject/data-processor.git","clone_url":"https://github.com/votinginfoproject/data-processor.git","svn_url":"https://github.com/votinginfoproject/data-processor","homepage":null,"size":1780,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"votinginfoproject:master","ref":"master","sha":"df208e3b5174ed0aeb09a4beff0219c5e8ea6ac0","user":{"login":"votinginfoproject","id":317805,"avatar_url":"https://avatars.githubusercontent.com/u/317805?v=3","gravatar_id":"","url":"https://api.github.com/users/votinginfoproject","html_url":"https://github.com/votinginfoproject","followers_url":"https://api.github.com/users/votinginfoproject/followers","following_url":"https://api.github.com/users/votinginfoproject/following{/other_user}","gists_url":"https://api.github.com/users/votinginfoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/votinginfoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votinginfoproject/subscriptions","organizations_url":"https://api.github.com/users/votinginfoproject/orgs","repos_url":"https://api.github.com/users/votinginfoproject/repos","events_url":"https://api.github.com/users/votinginfoproject/events{/privacy}","received_events_url":"https://api.github.com/users/votinginfoproject/received_events","type":"Organization","site_admin":false},"repo":{"id":29880296,"name":"data-processor","full_name":"votinginfoproject/data-processor","owner":{"login":"votinginfoproject","id":317805,"avatar_url":"https://avatars.githubusercontent.com/u/317805?v=3","gravatar_id":"","url":"https://api.github.com/users/votinginfoproject","html_url":"https://github.com/votinginfoproject","followers_url":"https://api.github.com/users/votinginfoproject/followers","following_url":"https://api.github.com/users/votinginfoproject/following{/other_user}","gists_url":"https://api.github.com/users/votinginfoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/votinginfoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votinginfoproject/subscriptions","organizations_url":"https://api.github.com/users/votinginfoproject/orgs","repos_url":"https://api.github.com/users/votinginfoproject/repos","events_url":"https://api.github.com/users/votinginfoproject/events{/privacy}","received_events_url":"https://api.github.com/users/votinginfoproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/votinginfoproject/data-processor","description":"VIP data processing","fork":false,"url":"https://api.github.com/repos/votinginfoproject/data-processor","forks_url":"https://api.github.com/repos/votinginfoproject/data-processor/forks","keys_url":"https://api.github.com/repos/votinginfoproject/data-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/votinginfoproject/data-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/votinginfoproject/data-processor/teams","hooks_url":"https://api.github.com/repos/votinginfoproject/data-processor/hooks","issue_events_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues/events{/number}","events_url":"https://api.github.com/repos/votinginfoproject/data-processor/events","assignees_url":"https://api.github.com/repos/votinginfoproject/data-processor/assignees{/user}","branches_url":"https://api.github.com/repos/votinginfoproject/data-processor/branches{/branch}","tags_url":"https://api.github.com/repos/votinginfoproject/data-processor/tags","blobs_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/votinginfoproject/data-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/votinginfoproject/data-processor/languages","stargazers_url":"https://api.github.com/repos/votinginfoproject/data-processor/stargazers","contributors_url":"https://api.github.com/repos/votinginfoproject/data-processor/contributors","subscribers_url":"https://api.github.com/repos/votinginfoproject/data-processor/subscribers","subscription_url":"https://api.github.com/repos/votinginfoproject/data-processor/subscription","commits_url":"https://api.github.com/repos/votinginfoproject/data-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/votinginfoproject/data-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/votinginfoproject/data-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/votinginfoproject/data-processor/contents/{+path}","compare_url":"https://api.github.com/repos/votinginfoproject/data-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/votinginfoproject/data-processor/merges","archive_url":"https://api.github.com/repos/votinginfoproject/data-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/votinginfoproject/data-processor/downloads","issues_url":"https://api.github.com/repos/votinginfoproject/data-processor/issues{/number}","pulls_url":"https://api.github.com/repos/votinginfoproject/data-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/votinginfoproject/data-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/votinginfoproject/data-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/votinginfoproject/data-processor/labels{/name}","releases_url":"https://api.github.com/repos/votinginfoproject/data-processor/releases{/id}","created_at":"2015-01-26T20:34:26Z","updated_at":"2015-05-08T19:59:05Z","pushed_at":"2015-05-27T17:42:38Z","git_url":"git://github.com/votinginfoproject/data-processor.git","ssh_url":"git@github.com:votinginfoproject/data-processor.git","clone_url":"https://github.com/votinginfoproject/data-processor.git","svn_url":"https://github.com/votinginfoproject/data-processor","homepage":null,"size":1780,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56"},"html":{"href":"https://github.com/votinginfoproject/data-processor/pull/56"},"issue":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/issues/56"},"comments":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/votinginfoproject/data-processor/statuses/1ba3c10da5b9fa5fb76072e181bc0f0de5eef5d8"}}}}