{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/236","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/236/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/236/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/236/events","html_url":"https://github.com/ocaml/ocaml/pull/236","id":105035622,"number":236,"title":"Add byte_size and kind_byte_size to Bigarray","user":{"login":"marklrh","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/marklrh","html_url":"https://github.com/marklrh","followers_url":"https://api.github.com/users/marklrh/followers","following_url":"https://api.github.com/users/marklrh/following{/other_user}","gists_url":"https://api.github.com/users/marklrh/gists{/gist_id}","starred_url":"https://api.github.com/users/marklrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklrh/subscriptions","organizations_url":"https://api.github.com/users/marklrh/orgs","repos_url":"https://api.github.com/users/marklrh/repos","events_url":"https://api.github.com/users/marklrh/events{/privacy}","received_events_url":"https://api.github.com/users/marklrh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-05T16:23:28Z","updated_at":"2015-10-09T15:31:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/236","html_url":"https://github.com/ocaml/ocaml/pull/236","diff_url":"https://github.com/ocaml/ocaml/pull/236.diff","patch_url":"https://github.com/ocaml/ocaml/pull/236.patch"},"body":"I removed my last commit and made this patch simpler\r\n\r\n* This patch **adds** ``byte_size`` and ``kind_byte_size`` APIs to ``Bigarray`` module.\r\n\r\n  * ``byte_size`` is implemented by wrapping function ``caml_ba_byte_size``.\r\n  * ``kind_byte_size`` is implemented by hardcoding byte size information. \r\n\r\n* This patch **resolves** [Mantis 6263](http://caml.inria.fr/mantis/view.php?id=6263)\r\n\r\n* Test cases can be found under ``/testsuite/tests/lib-bigarray``\r\n"},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/146904506","html_url":"https://github.com/ocaml/ocaml/pull/236#issuecomment-146904506","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/236","id":146904506,"user":{"login":"damiendoligez","id":19104,"avatar_url":"https://avatars.githubusercontent.com/u/19104?v=3","gravatar_id":"","url":"https://api.github.com/users/damiendoligez","html_url":"https://github.com/damiendoligez","followers_url":"https://api.github.com/users/damiendoligez/followers","following_url":"https://api.github.com/users/damiendoligez/following{/other_user}","gists_url":"https://api.github.com/users/damiendoligez/gists{/gist_id}","starred_url":"https://api.github.com/users/damiendoligez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiendoligez/subscriptions","organizations_url":"https://api.github.com/users/damiendoligez/orgs","repos_url":"https://api.github.com/users/damiendoligez/repos","events_url":"https://api.github.com/users/damiendoligez/events{/privacy}","received_events_url":"https://api.github.com/users/damiendoligez/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T15:31:53Z","updated_at":"2015-10-09T15:31:53Z","body":"I'm OK for merging this, but why do you say that `byte_size` is implemented by wrapping `caml_ba_byte_size`? As far as I can tell from your patch, you're simply recomputing the size in OCaml.\r\n"}}