{"action":"created","comment":{"url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/comments/31808640","id":31808640,"diff_hunk":"@@ -0,0 +1,87 @@\n+/**\n+ * Copyright 2014-2015 Linagora, Université Joseph Fourier, Floralis\n+ *\n+ * The present code is developed in the scope of the joint LINAGORA -\n+ * Université Joseph Fourier - Floralis research program and is designated\n+ * as a \"Result\" pursuant to the terms and conditions of the LINAGORA\n+ * - Université Joseph Fourier - Floralis research program. Each copyright\n+ * holder of Results enumerated here above fully & independently holds complete\n+ * ownership of the complete Intellectual Property rights applicable to the whole\n+ * of said Results, and may freely exploit it in any manner which does not infringe\n+ * the moral rights of the other copyright holders.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package net.roboconf.messaging.rabbitmq;\n+\n+import java.util.LinkedHashMap;\n+import java.util.Map;\n+\n+import net.roboconf.messaging.api.MessagingConstants;\n+\n+/**\n+ * Constants related to the RabbitMQ messaging client factory.\n+ * @author Pierre Bourret - Université Joseph Fourier\n+ */\n+public final class RabbitMqConstants {\n+\n+\t// Prevent instantiation.\n+\tprivate RabbitMqConstants() {\n+\t}\n+\n+\t/**\n+\t * The factory's name for RabbitMQ clients.\n+\t */\n+\tpublic static final String RABBITMQ_FACTORY_TYPE = \"rabbitmq\";\n+\n+\t/**\n+\t * The prefix for all RabbitMQ-related properties.\n+\t */\n+\tprivate static final String RABBITMQ_PROPERTY_PREFIX = MessagingConstants.MESSAGING_PROPERTY_PREFIX + \".\" + RABBITMQ_FACTORY_TYPE;","path":"core/roboconf-messaging-rabbitmq/src/main/java/net/roboconf/messaging/rabbitmq/RabbitMqConstants.java","position":51,"original_position":51,"commit_id":"2951a66a4bd3d14250ca9071e1b253a3d7935902","original_commit_id":"2951a66a4bd3d14250ca9071e1b253a3d7935902","user":{"login":"vincent-zurczak","id":1104790,"avatar_url":"https://avatars.githubusercontent.com/u/1104790?v=3","gravatar_id":"","url":"https://api.github.com/users/vincent-zurczak","html_url":"https://github.com/vincent-zurczak","followers_url":"https://api.github.com/users/vincent-zurczak/followers","following_url":"https://api.github.com/users/vincent-zurczak/following{/other_user}","gists_url":"https://api.github.com/users/vincent-zurczak/gists{/gist_id}","starred_url":"https://api.github.com/users/vincent-zurczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincent-zurczak/subscriptions","organizations_url":"https://api.github.com/users/vincent-zurczak/orgs","repos_url":"https://api.github.com/users/vincent-zurczak/repos","events_url":"https://api.github.com/users/vincent-zurczak/events{/privacy}","received_events_url":"https://api.github.com/users/vincent-zurczak/received_events","type":"User","site_admin":false},"body":"Is it necessary to have so long property names?\r\nCan't we consider a shorter prefix. **rabbitmq** is enough IMO.","created_at":"2015-06-05T12:39:37Z","updated_at":"2015-06-05T12:39:37Z","html_url":"https://github.com/roboconf/roboconf-platform/pull/309#discussion_r31808640","pull_request_url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/comments/31808640"},"html":{"href":"https://github.com/roboconf/roboconf-platform/pull/309#discussion_r31808640"},"pull_request":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309","id":36050510,"html_url":"https://github.com/roboconf/roboconf-platform/pull/309","diff_url":"https://github.com/roboconf/roboconf-platform/pull/309.diff","patch_url":"https://github.com/roboconf/roboconf-platform/pull/309.patch","issue_url":"https://api.github.com/repos/roboconf/roboconf-platform/issues/309","number":309,"state":"open","locked":false,"title":"Feature: generic messaging","user":{"login":"bourretp","id":613344,"avatar_url":"https://avatars.githubusercontent.com/u/613344?v=3","gravatar_id":"","url":"https://api.github.com/users/bourretp","html_url":"https://github.com/bourretp","followers_url":"https://api.github.com/users/bourretp/followers","following_url":"https://api.github.com/users/bourretp/following{/other_user}","gists_url":"https://api.github.com/users/bourretp/gists{/gist_id}","starred_url":"https://api.github.com/users/bourretp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bourretp/subscriptions","organizations_url":"https://api.github.com/users/bourretp/orgs","repos_url":"https://api.github.com/users/bourretp/repos","events_url":"https://api.github.com/users/bourretp/events{/privacy}","received_events_url":"https://api.github.com/users/bourretp/received_events","type":"User","site_admin":false},"body":"This PR add an indirection level in the messaging API.\r\nThe RabbitMQ provider is moved in a specific bundle (#278).\r\nMore providers can be added (e.g. Apache QPID #257, HTTP #279) by exposing a specific `MessagingClientFactory` service.","created_at":"2015-05-22T17:08:22Z","updated_at":"2015-06-05T12:39:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba748222718cee9e7cb2da783b1beab4fbe39beb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309/commits","review_comments_url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309/comments","review_comment_url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roboconf/roboconf-platform/issues/309/comments","statuses_url":"https://api.github.com/repos/roboconf/roboconf-platform/statuses/2951a66a4bd3d14250ca9071e1b253a3d7935902","head":{"label":"bourretp:feature/generic-messaging","ref":"feature/generic-messaging","sha":"2951a66a4bd3d14250ca9071e1b253a3d7935902","user":{"login":"bourretp","id":613344,"avatar_url":"https://avatars.githubusercontent.com/u/613344?v=3","gravatar_id":"","url":"https://api.github.com/users/bourretp","html_url":"https://github.com/bourretp","followers_url":"https://api.github.com/users/bourretp/followers","following_url":"https://api.github.com/users/bourretp/following{/other_user}","gists_url":"https://api.github.com/users/bourretp/gists{/gist_id}","starred_url":"https://api.github.com/users/bourretp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bourretp/subscriptions","organizations_url":"https://api.github.com/users/bourretp/orgs","repos_url":"https://api.github.com/users/bourretp/repos","events_url":"https://api.github.com/users/bourretp/events{/privacy}","received_events_url":"https://api.github.com/users/bourretp/received_events","type":"User","site_admin":false},"repo":{"id":30346550,"name":"roboconf-platform","full_name":"bourretp/roboconf-platform","owner":{"login":"bourretp","id":613344,"avatar_url":"https://avatars.githubusercontent.com/u/613344?v=3","gravatar_id":"","url":"https://api.github.com/users/bourretp","html_url":"https://github.com/bourretp","followers_url":"https://api.github.com/users/bourretp/followers","following_url":"https://api.github.com/users/bourretp/following{/other_user}","gists_url":"https://api.github.com/users/bourretp/gists{/gist_id}","starred_url":"https://api.github.com/users/bourretp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bourretp/subscriptions","organizations_url":"https://api.github.com/users/bourretp/orgs","repos_url":"https://api.github.com/users/bourretp/repos","events_url":"https://api.github.com/users/bourretp/events{/privacy}","received_events_url":"https://api.github.com/users/bourretp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bourretp/roboconf-platform","description":"The core modules and the platform","fork":true,"url":"https://api.github.com/repos/bourretp/roboconf-platform","forks_url":"https://api.github.com/repos/bourretp/roboconf-platform/forks","keys_url":"https://api.github.com/repos/bourretp/roboconf-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bourretp/roboconf-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bourretp/roboconf-platform/teams","hooks_url":"https://api.github.com/repos/bourretp/roboconf-platform/hooks","issue_events_url":"https://api.github.com/repos/bourretp/roboconf-platform/issues/events{/number}","events_url":"https://api.github.com/repos/bourretp/roboconf-platform/events","assignees_url":"https://api.github.com/repos/bourretp/roboconf-platform/assignees{/user}","branches_url":"https://api.github.com/repos/bourretp/roboconf-platform/branches{/branch}","tags_url":"https://api.github.com/repos/bourretp/roboconf-platform/tags","blobs_url":"https://api.github.com/repos/bourretp/roboconf-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bourretp/roboconf-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bourretp/roboconf-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/bourretp/roboconf-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bourretp/roboconf-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/bourretp/roboconf-platform/languages","stargazers_url":"https://api.github.com/repos/bourretp/roboconf-platform/stargazers","contributors_url":"https://api.github.com/repos/bourretp/roboconf-platform/contributors","subscribers_url":"https://api.github.com/repos/bourretp/roboconf-platform/subscribers","subscription_url":"https://api.github.com/repos/bourretp/roboconf-platform/subscription","commits_url":"https://api.github.com/repos/bourretp/roboconf-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/bourretp/roboconf-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/bourretp/roboconf-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/bourretp/roboconf-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/bourretp/roboconf-platform/contents/{+path}","compare_url":"https://api.github.com/repos/bourretp/roboconf-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bourretp/roboconf-platform/merges","archive_url":"https://api.github.com/repos/bourretp/roboconf-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bourretp/roboconf-platform/downloads","issues_url":"https://api.github.com/repos/bourretp/roboconf-platform/issues{/number}","pulls_url":"https://api.github.com/repos/bourretp/roboconf-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/bourretp/roboconf-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/bourretp/roboconf-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bourretp/roboconf-platform/labels{/name}","releases_url":"https://api.github.com/repos/bourretp/roboconf-platform/releases{/id}","created_at":"2015-02-05T09:00:14Z","updated_at":"2015-04-28T12:37:00Z","pushed_at":"2015-06-05T12:05:01Z","git_url":"git://github.com/bourretp/roboconf-platform.git","ssh_url":"git@github.com:bourretp/roboconf-platform.git","clone_url":"https://github.com/bourretp/roboconf-platform.git","svn_url":"https://github.com/bourretp/roboconf-platform","homepage":"","size":4643,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roboconf:master","ref":"master","sha":"21f046bc7d8e010fc4ee419332061873462b206a","user":{"login":"roboconf","id":6438255,"avatar_url":"https://avatars.githubusercontent.com/u/6438255?v=3","gravatar_id":"","url":"https://api.github.com/users/roboconf","html_url":"https://github.com/roboconf","followers_url":"https://api.github.com/users/roboconf/followers","following_url":"https://api.github.com/users/roboconf/following{/other_user}","gists_url":"https://api.github.com/users/roboconf/gists{/gist_id}","starred_url":"https://api.github.com/users/roboconf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboconf/subscriptions","organizations_url":"https://api.github.com/users/roboconf/orgs","repos_url":"https://api.github.com/users/roboconf/repos","events_url":"https://api.github.com/users/roboconf/events{/privacy}","received_events_url":"https://api.github.com/users/roboconf/received_events","type":"Organization","site_admin":false},"repo":{"id":17637707,"name":"roboconf-platform","full_name":"roboconf/roboconf-platform","owner":{"login":"roboconf","id":6438255,"avatar_url":"https://avatars.githubusercontent.com/u/6438255?v=3","gravatar_id":"","url":"https://api.github.com/users/roboconf","html_url":"https://github.com/roboconf","followers_url":"https://api.github.com/users/roboconf/followers","following_url":"https://api.github.com/users/roboconf/following{/other_user}","gists_url":"https://api.github.com/users/roboconf/gists{/gist_id}","starred_url":"https://api.github.com/users/roboconf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboconf/subscriptions","organizations_url":"https://api.github.com/users/roboconf/orgs","repos_url":"https://api.github.com/users/roboconf/repos","events_url":"https://api.github.com/users/roboconf/events{/privacy}","received_events_url":"https://api.github.com/users/roboconf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roboconf/roboconf-platform","description":"The core modules and the platform","fork":false,"url":"https://api.github.com/repos/roboconf/roboconf-platform","forks_url":"https://api.github.com/repos/roboconf/roboconf-platform/forks","keys_url":"https://api.github.com/repos/roboconf/roboconf-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roboconf/roboconf-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roboconf/roboconf-platform/teams","hooks_url":"https://api.github.com/repos/roboconf/roboconf-platform/hooks","issue_events_url":"https://api.github.com/repos/roboconf/roboconf-platform/issues/events{/number}","events_url":"https://api.github.com/repos/roboconf/roboconf-platform/events","assignees_url":"https://api.github.com/repos/roboconf/roboconf-platform/assignees{/user}","branches_url":"https://api.github.com/repos/roboconf/roboconf-platform/branches{/branch}","tags_url":"https://api.github.com/repos/roboconf/roboconf-platform/tags","blobs_url":"https://api.github.com/repos/roboconf/roboconf-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roboconf/roboconf-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roboconf/roboconf-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/roboconf/roboconf-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roboconf/roboconf-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/roboconf/roboconf-platform/languages","stargazers_url":"https://api.github.com/repos/roboconf/roboconf-platform/stargazers","contributors_url":"https://api.github.com/repos/roboconf/roboconf-platform/contributors","subscribers_url":"https://api.github.com/repos/roboconf/roboconf-platform/subscribers","subscription_url":"https://api.github.com/repos/roboconf/roboconf-platform/subscription","commits_url":"https://api.github.com/repos/roboconf/roboconf-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/roboconf/roboconf-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/roboconf/roboconf-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/roboconf/roboconf-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/roboconf/roboconf-platform/contents/{+path}","compare_url":"https://api.github.com/repos/roboconf/roboconf-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roboconf/roboconf-platform/merges","archive_url":"https://api.github.com/repos/roboconf/roboconf-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roboconf/roboconf-platform/downloads","issues_url":"https://api.github.com/repos/roboconf/roboconf-platform/issues{/number}","pulls_url":"https://api.github.com/repos/roboconf/roboconf-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/roboconf/roboconf-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/roboconf/roboconf-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roboconf/roboconf-platform/labels{/name}","releases_url":"https://api.github.com/repos/roboconf/roboconf-platform/releases{/id}","created_at":"2014-03-11T16:29:42Z","updated_at":"2015-05-04T15:49:42Z","pushed_at":"2015-06-05T12:05:02Z","git_url":"git://github.com/roboconf/roboconf-platform.git","ssh_url":"git@github.com:roboconf/roboconf-platform.git","clone_url":"https://github.com/roboconf/roboconf-platform.git","svn_url":"https://github.com/roboconf/roboconf-platform","homepage":"","size":6141,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":73,"forks":9,"open_issues":73,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309"},"html":{"href":"https://github.com/roboconf/roboconf-platform/pull/309"},"issue":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/issues/309"},"comments":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/roboconf/roboconf-platform/statuses/2951a66a4bd3d14250ca9071e1b253a3d7935902"}}}}