{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/jc00ke/guard-puma/pulls/15","id":43830183,"html_url":"https://github.com/jc00ke/guard-puma/pull/15","diff_url":"https://github.com/jc00ke/guard-puma/pull/15.diff","patch_url":"https://github.com/jc00ke/guard-puma/pull/15.patch","issue_url":"https://api.github.com/repos/jc00ke/guard-puma/issues/15","number":15,"state":"closed","locked":false,"title":"If config is provided it takes precedence.","user":{"login":"glenngillen","id":855109,"avatar_url":"https://avatars.githubusercontent.com/u/855109?v=3","gravatar_id":"","url":"https://api.github.com/users/glenngillen","html_url":"https://github.com/glenngillen","followers_url":"https://api.github.com/users/glenngillen/followers","following_url":"https://api.github.com/users/glenngillen/following{/other_user}","gists_url":"https://api.github.com/users/glenngillen/gists{/gist_id}","starred_url":"https://api.github.com/users/glenngillen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenngillen/subscriptions","organizations_url":"https://api.github.com/users/glenngillen/orgs","repos_url":"https://api.github.com/users/glenngillen/repos","events_url":"https://api.github.com/users/glenngillen/events{/privacy}","received_events_url":"https://api.github.com/users/glenngillen/received_events","type":"User","site_admin":false},"body":"I'm sure this overlooks a number of edge cases, but hopefully this pull request can start a discussion on what else I need to consider in this patch.\r\n\r\nOur problem was that we're specifying Puma config options in a config file. `guard-puma` *always* provides a command-line flags to the `puma` executable, which will in turn try to apply both sets of options. This would mean the app running on the default port of 4000 in addition to the one we've specified in `config/puma.rb` or an \"Address already in use - bind(2) for \"0.0.0.0\" port XXXX\" if we tried to specify the port as an option to `guard-puma`.\r\n\r\nThis change makes the assumption that if you're using a config file then you're responsible for setting all options within that file.\r\n","created_at":"2015-09-01T02:01:30Z","updated_at":"2015-10-12T22:16:55Z","closed_at":"2015-10-12T22:16:55Z","merged_at":"2015-10-12T22:16:55Z","merge_commit_sha":"6b8b8ea9cc6423df97d645e4ebffc31a7364bb90","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jc00ke/guard-puma/pulls/15/commits","review_comments_url":"https://api.github.com/repos/jc00ke/guard-puma/pulls/15/comments","review_comment_url":"https://api.github.com/repos/jc00ke/guard-puma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jc00ke/guard-puma/issues/15/comments","statuses_url":"https://api.github.com/repos/jc00ke/guard-puma/statuses/3781e7d86bc255ab2fbc6979032cb2f28980b966","head":{"label":"glenngillen:optional-options","ref":"optional-options","sha":"3781e7d86bc255ab2fbc6979032cb2f28980b966","user":{"login":"glenngillen","id":855109,"avatar_url":"https://avatars.githubusercontent.com/u/855109?v=3","gravatar_id":"","url":"https://api.github.com/users/glenngillen","html_url":"https://github.com/glenngillen","followers_url":"https://api.github.com/users/glenngillen/followers","following_url":"https://api.github.com/users/glenngillen/following{/other_user}","gists_url":"https://api.github.com/users/glenngillen/gists{/gist_id}","starred_url":"https://api.github.com/users/glenngillen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenngillen/subscriptions","organizations_url":"https://api.github.com/users/glenngillen/orgs","repos_url":"https://api.github.com/users/glenngillen/repos","events_url":"https://api.github.com/users/glenngillen/events{/privacy}","received_events_url":"https://api.github.com/users/glenngillen/received_events","type":"User","site_admin":false},"repo":{"id":41710220,"name":"guard-puma","full_name":"glenngillen/guard-puma","owner":{"login":"glenngillen","id":855109,"avatar_url":"https://avatars.githubusercontent.com/u/855109?v=3","gravatar_id":"","url":"https://api.github.com/users/glenngillen","html_url":"https://github.com/glenngillen","followers_url":"https://api.github.com/users/glenngillen/followers","following_url":"https://api.github.com/users/glenngillen/following{/other_user}","gists_url":"https://api.github.com/users/glenngillen/gists{/gist_id}","starred_url":"https://api.github.com/users/glenngillen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenngillen/subscriptions","organizations_url":"https://api.github.com/users/glenngillen/orgs","repos_url":"https://api.github.com/users/glenngillen/repos","events_url":"https://api.github.com/users/glenngillen/events{/privacy}","received_events_url":"https://api.github.com/users/glenngillen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glenngillen/guard-puma","description":"Restart puma when files change","fork":true,"url":"https://api.github.com/repos/glenngillen/guard-puma","forks_url":"https://api.github.com/repos/glenngillen/guard-puma/forks","keys_url":"https://api.github.com/repos/glenngillen/guard-puma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glenngillen/guard-puma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glenngillen/guard-puma/teams","hooks_url":"https://api.github.com/repos/glenngillen/guard-puma/hooks","issue_events_url":"https://api.github.com/repos/glenngillen/guard-puma/issues/events{/number}","events_url":"https://api.github.com/repos/glenngillen/guard-puma/events","assignees_url":"https://api.github.com/repos/glenngillen/guard-puma/assignees{/user}","branches_url":"https://api.github.com/repos/glenngillen/guard-puma/branches{/branch}","tags_url":"https://api.github.com/repos/glenngillen/guard-puma/tags","blobs_url":"https://api.github.com/repos/glenngillen/guard-puma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glenngillen/guard-puma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glenngillen/guard-puma/git/refs{/sha}","trees_url":"https://api.github.com/repos/glenngillen/guard-puma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glenngillen/guard-puma/statuses/{sha}","languages_url":"https://api.github.com/repos/glenngillen/guard-puma/languages","stargazers_url":"https://api.github.com/repos/glenngillen/guard-puma/stargazers","contributors_url":"https://api.github.com/repos/glenngillen/guard-puma/contributors","subscribers_url":"https://api.github.com/repos/glenngillen/guard-puma/subscribers","subscription_url":"https://api.github.com/repos/glenngillen/guard-puma/subscription","commits_url":"https://api.github.com/repos/glenngillen/guard-puma/commits{/sha}","git_commits_url":"https://api.github.com/repos/glenngillen/guard-puma/git/commits{/sha}","comments_url":"https://api.github.com/repos/glenngillen/guard-puma/comments{/number}","issue_comment_url":"https://api.github.com/repos/glenngillen/guard-puma/issues/comments{/number}","contents_url":"https://api.github.com/repos/glenngillen/guard-puma/contents/{+path}","compare_url":"https://api.github.com/repos/glenngillen/guard-puma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glenngillen/guard-puma/merges","archive_url":"https://api.github.com/repos/glenngillen/guard-puma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glenngillen/guard-puma/downloads","issues_url":"https://api.github.com/repos/glenngillen/guard-puma/issues{/number}","pulls_url":"https://api.github.com/repos/glenngillen/guard-puma/pulls{/number}","milestones_url":"https://api.github.com/repos/glenngillen/guard-puma/milestones{/number}","notifications_url":"https://api.github.com/repos/glenngillen/guard-puma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glenngillen/guard-puma/labels{/name}","releases_url":"https://api.github.com/repos/glenngillen/guard-puma/releases{/id}","created_at":"2015-09-01T01:39:47Z","updated_at":"2015-09-01T01:39:48Z","pushed_at":"2015-09-01T04:57:45Z","git_url":"git://github.com/glenngillen/guard-puma.git","ssh_url":"git@github.com:glenngillen/guard-puma.git","clone_url":"https://github.com/glenngillen/guard-puma.git","svn_url":"https://github.com/glenngillen/guard-puma","homepage":"","size":131,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jc00ke:master","ref":"master","sha":"2de7cac4a16fdf87037e304ce8ed6f25d9ec6788","user":{"login":"jc00ke","id":18191,"avatar_url":"https://avatars.githubusercontent.com/u/18191?v=3","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"repo":{"id":3783809,"name":"guard-puma","full_name":"jc00ke/guard-puma","owner":{"login":"jc00ke","id":18191,"avatar_url":"https://avatars.githubusercontent.com/u/18191?v=3","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jc00ke/guard-puma","description":"Restart puma when files change","fork":false,"url":"https://api.github.com/repos/jc00ke/guard-puma","forks_url":"https://api.github.com/repos/jc00ke/guard-puma/forks","keys_url":"https://api.github.com/repos/jc00ke/guard-puma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jc00ke/guard-puma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jc00ke/guard-puma/teams","hooks_url":"https://api.github.com/repos/jc00ke/guard-puma/hooks","issue_events_url":"https://api.github.com/repos/jc00ke/guard-puma/issues/events{/number}","events_url":"https://api.github.com/repos/jc00ke/guard-puma/events","assignees_url":"https://api.github.com/repos/jc00ke/guard-puma/assignees{/user}","branches_url":"https://api.github.com/repos/jc00ke/guard-puma/branches{/branch}","tags_url":"https://api.github.com/repos/jc00ke/guard-puma/tags","blobs_url":"https://api.github.com/repos/jc00ke/guard-puma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jc00ke/guard-puma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jc00ke/guard-puma/git/refs{/sha}","trees_url":"https://api.github.com/repos/jc00ke/guard-puma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jc00ke/guard-puma/statuses/{sha}","languages_url":"https://api.github.com/repos/jc00ke/guard-puma/languages","stargazers_url":"https://api.github.com/repos/jc00ke/guard-puma/stargazers","contributors_url":"https://api.github.com/repos/jc00ke/guard-puma/contributors","subscribers_url":"https://api.github.com/repos/jc00ke/guard-puma/subscribers","subscription_url":"https://api.github.com/repos/jc00ke/guard-puma/subscription","commits_url":"https://api.github.com/repos/jc00ke/guard-puma/commits{/sha}","git_commits_url":"https://api.github.com/repos/jc00ke/guard-puma/git/commits{/sha}","comments_url":"https://api.github.com/repos/jc00ke/guard-puma/comments{/number}","issue_comment_url":"https://api.github.com/repos/jc00ke/guard-puma/issues/comments{/number}","contents_url":"https://api.github.com/repos/jc00ke/guard-puma/contents/{+path}","compare_url":"https://api.github.com/repos/jc00ke/guard-puma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jc00ke/guard-puma/merges","archive_url":"https://api.github.com/repos/jc00ke/guard-puma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jc00ke/guard-puma/downloads","issues_url":"https://api.github.com/repos/jc00ke/guard-puma/issues{/number}","pulls_url":"https://api.github.com/repos/jc00ke/guard-puma/pulls{/number}","milestones_url":"https://api.github.com/repos/jc00ke/guard-puma/milestones{/number}","notifications_url":"https://api.github.com/repos/jc00ke/guard-puma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jc00ke/guard-puma/labels{/name}","releases_url":"https://api.github.com/repos/jc00ke/guard-puma/releases{/id}","created_at":"2012-03-21T05:58:54Z","updated_at":"2015-09-30T06:22:49Z","pushed_at":"2015-10-12T22:16:55Z","git_url":"git://github.com/jc00ke/guard-puma.git","ssh_url":"git@github.com:jc00ke/guard-puma.git","clone_url":"https://github.com/jc00ke/guard-puma.git","svn_url":"https://github.com/jc00ke/guard-puma","homepage":"","size":365,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jc00ke/guard-puma/pulls/15"},"html":{"href":"https://github.com/jc00ke/guard-puma/pull/15"},"issue":{"href":"https://api.github.com/repos/jc00ke/guard-puma/issues/15"},"comments":{"href":"https://api.github.com/repos/jc00ke/guard-puma/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/jc00ke/guard-puma/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/jc00ke/guard-puma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jc00ke/guard-puma/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/jc00ke/guard-puma/statuses/3781e7d86bc255ab2fbc6979032cb2f28980b966"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jc00ke","id":18191,"avatar_url":"https://avatars.githubusercontent.com/u/18191?v=3","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":25,"deletions":11,"changed_files":3}}