{"comment":{"url":"https://api.github.com/repos/tych0/lxd/comments/10196903","html_url":"https://github.com/tych0/lxd/commit/c6c4a31981e8c7b660692d413060b6ef3b906c3a#commitcomment-10196903","id":10196903,"user":{"login":"tych0","id":785111,"avatar_url":"https://avatars.githubusercontent.com/u/785111?v=3","gravatar_id":"","url":"https://api.github.com/users/tych0","html_url":"https://github.com/tych0","followers_url":"https://api.github.com/users/tych0/followers","following_url":"https://api.github.com/users/tych0/following{/other_user}","gists_url":"https://api.github.com/users/tych0/gists{/gist_id}","starred_url":"https://api.github.com/users/tych0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tych0/subscriptions","organizations_url":"https://api.github.com/users/tych0/orgs","repos_url":"https://api.github.com/users/tych0/repos","events_url":"https://api.github.com/users/tych0/events{/privacy}","received_events_url":"https://api.github.com/users/tych0/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"c6c4a31981e8c7b660692d413060b6ef3b906c3a","created_at":"2015-03-14T03:47:40Z","updated_at":"2015-03-14T03:47:40Z","body":"On Mar 13, 2015 8:46 PM, \"Serge Hallyn\" <notifications@github.com> wrote:\n>\n> I'm confused about this commit.\n>\n> The rootfs will be rsynced so that on the target host it will have the\nsame idmap as it did on the source. You send an idmap from the source, and\nuse that to shift the rootfs.\n\nIt doesn't. I guess we should be using some rsync flags to preserve the\nuids? The problem is that the sink may have a different I'd map than the\nsource, so we should reshift anyway.\n\n>\n> I would think you'd want to claculate the delta between the source idmap\nand the idmap at the target - or just verify that the source idmap falls\nwithin the target idmap range.\n\nThat's effectively what happens.\n>\n> I'm mostly trying to check my assumptions - I don't think getting that\ncorrect now is necessary for this patchset to be merged.\n\nMe too. What happens with our current rsync invocation doesn't work without\nthis. I also think this is the easiest way to move to different uid maps,\nbut I'm open to suggestions.\n\n>\n> —\n> Reply to this email directly or view it on GitHub.\n"}}