{"action":"created","comment":{"url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/comments/48608601","id":48608601,"diff_hunk":"@@ -263,21 +267,22 @@ private void updateServer() {\n     }\n \n     private CatalogProvider getProvider() {\n-        if (isServerUp(getServer())) {\n-            if (resolver == null) {\n-                provider = new SolrCatalogProvider(getServer(),\n-                        filterAdapter,\n-                        solrFilterDelegateFactory);\n-            } else {\n-                provider = new SolrCatalogProvider(getServer(),\n-                        filterAdapter,\n-                        solrFilterDelegateFactory,\n-                        resolver);\n+        if (firstUse) {","path":"catalog/solr/catalog-solr-external-provider/src/main/java/ddf/catalog/solr/external/SolrHttpCatalogProvider.java","position":39,"original_position":39,"commit_id":"c5755e2abe394d5acee684529e2b7a316d555630","original_commit_id":"c5755e2abe394d5acee684529e2b7a316d555630","user":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars.githubusercontent.com/u/8660335?v=3","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"body":"Well, the problem with reverting to the `firstUse` pattern is that this no longer fixes the bug(s) it was supposed to fix. This logic doesn't configure the catalog provider. It sounds like we just need to check if the provider has already been initialized in the `isServerUp()` check at the top.\r\n\r\nI can work with you and @NGoss on this more when everyone gets back from vacation. I don't think it's ready for a PR as-is, so you might want to close the one that's currently out.","created_at":"2015-12-30T15:11:19Z","updated_at":"2015-12-30T15:11:19Z","html_url":"https://github.com/brendan-hofmann/ddf/pull/1#discussion_r48608601","pull_request_url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/comments/48608601"},"html":{"href":"https://github.com/brendan-hofmann/ddf/pull/1#discussion_r48608601"},"pull_request":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1","id":54484000,"html_url":"https://github.com/brendan-hofmann/ddf/pull/1","diff_url":"https://github.com/brendan-hofmann/ddf/pull/1.diff","patch_url":"https://github.com/brendan-hofmann/ddf/pull/1.patch","issue_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues/1","number":1,"state":"closed","locked":false,"title":"DDF-1710 Fix testCswQueryWithValidationCheckerPlugin()","user":{"login":"harrison-tarr","id":14062223,"avatar_url":"https://avatars.githubusercontent.com/u/14062223?v=3","gravatar_id":"","url":"https://api.github.com/users/harrison-tarr","html_url":"https://github.com/harrison-tarr","followers_url":"https://api.github.com/users/harrison-tarr/followers","following_url":"https://api.github.com/users/harrison-tarr/following{/other_user}","gists_url":"https://api.github.com/users/harrison-tarr/gists{/gist_id}","starred_url":"https://api.github.com/users/harrison-tarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrison-tarr/subscriptions","organizations_url":"https://api.github.com/users/harrison-tarr/orgs","repos_url":"https://api.github.com/users/harrison-tarr/repos","events_url":"https://api.github.com/users/harrison-tarr/events{/privacy}","received_events_url":"https://api.github.com/users/harrison-tarr/received_events","type":"User","site_admin":false},"body":"Reconfiguring the Solr Catalog Provider was causing itest failures","created_at":"2015-12-23T16:18:01Z","updated_at":"2015-12-30T15:11:20Z","closed_at":"2015-12-23T18:57:56Z","merged_at":"2015-12-23T18:57:56Z","merge_commit_sha":"581d77e9d38d7e4d8582dd094e3af73e6d796a27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1/commits","review_comments_url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1/comments","review_comment_url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues/1/comments","statuses_url":"https://api.github.com/repos/brendan-hofmann/ddf/statuses/c5755e2abe394d5acee684529e2b7a316d555630","head":{"label":"harrison-tarr:DDF-1710","ref":"DDF-1710","sha":"c5755e2abe394d5acee684529e2b7a316d555630","user":{"login":"harrison-tarr","id":14062223,"avatar_url":"https://avatars.githubusercontent.com/u/14062223?v=3","gravatar_id":"","url":"https://api.github.com/users/harrison-tarr","html_url":"https://github.com/harrison-tarr","followers_url":"https://api.github.com/users/harrison-tarr/followers","following_url":"https://api.github.com/users/harrison-tarr/following{/other_user}","gists_url":"https://api.github.com/users/harrison-tarr/gists{/gist_id}","starred_url":"https://api.github.com/users/harrison-tarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrison-tarr/subscriptions","organizations_url":"https://api.github.com/users/harrison-tarr/orgs","repos_url":"https://api.github.com/users/harrison-tarr/repos","events_url":"https://api.github.com/users/harrison-tarr/events{/privacy}","received_events_url":"https://api.github.com/users/harrison-tarr/received_events","type":"User","site_admin":false},"repo":{"id":41703445,"name":"ddf","full_name":"harrison-tarr/ddf","owner":{"login":"harrison-tarr","id":14062223,"avatar_url":"https://avatars.githubusercontent.com/u/14062223?v=3","gravatar_id":"","url":"https://api.github.com/users/harrison-tarr","html_url":"https://github.com/harrison-tarr","followers_url":"https://api.github.com/users/harrison-tarr/followers","following_url":"https://api.github.com/users/harrison-tarr/following{/other_user}","gists_url":"https://api.github.com/users/harrison-tarr/gists{/gist_id}","starred_url":"https://api.github.com/users/harrison-tarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrison-tarr/subscriptions","organizations_url":"https://api.github.com/users/harrison-tarr/orgs","repos_url":"https://api.github.com/users/harrison-tarr/repos","events_url":"https://api.github.com/users/harrison-tarr/events{/privacy}","received_events_url":"https://api.github.com/users/harrison-tarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harrison-tarr/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/harrison-tarr/ddf","forks_url":"https://api.github.com/repos/harrison-tarr/ddf/forks","keys_url":"https://api.github.com/repos/harrison-tarr/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harrison-tarr/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harrison-tarr/ddf/teams","hooks_url":"https://api.github.com/repos/harrison-tarr/ddf/hooks","issue_events_url":"https://api.github.com/repos/harrison-tarr/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/harrison-tarr/ddf/events","assignees_url":"https://api.github.com/repos/harrison-tarr/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/harrison-tarr/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/harrison-tarr/ddf/tags","blobs_url":"https://api.github.com/repos/harrison-tarr/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harrison-tarr/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harrison-tarr/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/harrison-tarr/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harrison-tarr/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/harrison-tarr/ddf/languages","stargazers_url":"https://api.github.com/repos/harrison-tarr/ddf/stargazers","contributors_url":"https://api.github.com/repos/harrison-tarr/ddf/contributors","subscribers_url":"https://api.github.com/repos/harrison-tarr/ddf/subscribers","subscription_url":"https://api.github.com/repos/harrison-tarr/ddf/subscription","commits_url":"https://api.github.com/repos/harrison-tarr/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/harrison-tarr/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/harrison-tarr/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/harrison-tarr/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/harrison-tarr/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/harrison-tarr/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harrison-tarr/ddf/merges","archive_url":"https://api.github.com/repos/harrison-tarr/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harrison-tarr/ddf/downloads","issues_url":"https://api.github.com/repos/harrison-tarr/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/harrison-tarr/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/harrison-tarr/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/harrison-tarr/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harrison-tarr/ddf/labels{/name}","releases_url":"https://api.github.com/repos/harrison-tarr/ddf/releases{/id}","created_at":"2015-08-31T22:18:51Z","updated_at":"2015-08-31T22:19:01Z","pushed_at":"2015-12-30T14:34:30Z","git_url":"git://github.com/harrison-tarr/ddf.git","ssh_url":"git@github.com:harrison-tarr/ddf.git","clone_url":"https://github.com/harrison-tarr/ddf.git","svn_url":"https://github.com/harrison-tarr/ddf","homepage":"","size":125443,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brendan-hofmann:DDF-1710","ref":"DDF-1710","sha":"b0285ce2d026cf5d066342f080a68be2b8364261","user":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars.githubusercontent.com/u/8660335?v=3","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"repo":{"id":29319681,"name":"ddf","full_name":"brendan-hofmann/ddf","owner":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars.githubusercontent.com/u/8660335?v=3","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendan-hofmann/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/brendan-hofmann/ddf","forks_url":"https://api.github.com/repos/brendan-hofmann/ddf/forks","keys_url":"https://api.github.com/repos/brendan-hofmann/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendan-hofmann/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendan-hofmann/ddf/teams","hooks_url":"https://api.github.com/repos/brendan-hofmann/ddf/hooks","issue_events_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/brendan-hofmann/ddf/events","assignees_url":"https://api.github.com/repos/brendan-hofmann/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/brendan-hofmann/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/brendan-hofmann/ddf/tags","blobs_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendan-hofmann/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/brendan-hofmann/ddf/languages","stargazers_url":"https://api.github.com/repos/brendan-hofmann/ddf/stargazers","contributors_url":"https://api.github.com/repos/brendan-hofmann/ddf/contributors","subscribers_url":"https://api.github.com/repos/brendan-hofmann/ddf/subscribers","subscription_url":"https://api.github.com/repos/brendan-hofmann/ddf/subscription","commits_url":"https://api.github.com/repos/brendan-hofmann/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendan-hofmann/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendan-hofmann/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/brendan-hofmann/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendan-hofmann/ddf/merges","archive_url":"https://api.github.com/repos/brendan-hofmann/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendan-hofmann/ddf/downloads","issues_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/brendan-hofmann/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/brendan-hofmann/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendan-hofmann/ddf/labels{/name}","releases_url":"https://api.github.com/repos/brendan-hofmann/ddf/releases{/id}","created_at":"2015-01-15T21:43:26Z","updated_at":"2015-01-15T21:43:27Z","pushed_at":"2015-12-23T20:51:36Z","git_url":"git://github.com/brendan-hofmann/ddf.git","ssh_url":"git@github.com:brendan-hofmann/ddf.git","clone_url":"https://github.com/brendan-hofmann/ddf.git","svn_url":"https://github.com/brendan-hofmann/ddf","homepage":"","size":124866,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1"},"html":{"href":"https://github.com/brendan-hofmann/ddf/pull/1"},"issue":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/issues/1"},"comments":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/brendan-hofmann/ddf/statuses/c5755e2abe394d5acee684529e2b7a316d555630"}}}}