{"action":"created","comment":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/comments/41268441","id":41268441,"diff_hunk":"@@ -0,0 +1,5 @@\n+useragent0.value=.*ArcGIS.*\n+useragent1.value=.*uDig.*\n+useragent2.value=.*QGIS.*","path":"security-proxy/src/deb/resources/etc/georchestra/security-proxy/user-agents.properties","position":3,"original_position":3,"commit_id":"92f7b704149df01ba3613d7c5ab9e31b7df16360","original_commit_id":"92f7b704149df01ba3613d7c5ab9e31b7df16360","user":{"login":"fvanderbiest","id":265319,"avatar_url":"https://avatars.githubusercontent.com/u/265319?v=3","gravatar_id":"","url":"https://api.github.com/users/fvanderbiest","html_url":"https://github.com/fvanderbiest","followers_url":"https://api.github.com/users/fvanderbiest/followers","following_url":"https://api.github.com/users/fvanderbiest/following{/other_user}","gists_url":"https://api.github.com/users/fvanderbiest/gists{/gist_id}","starred_url":"https://api.github.com/users/fvanderbiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvanderbiest/subscriptions","organizations_url":"https://api.github.com/users/fvanderbiest/orgs","repos_url":"https://api.github.com/users/fvanderbiest/repos","events_url":"https://api.github.com/users/fvanderbiest/events{/privacy}","received_events_url":"https://api.github.com/users/fvanderbiest/received_events","type":"User","site_admin":false},"body":"The above 3 lines should be removed (or at least commented out)\r\nSee https://github.com/georchestra/georchestra/blob/15.06/security-proxy/src/main/webapp/WEB-INF/applicationContext-security.xml#L52-L56","created_at":"2015-10-06T14:11:01Z","updated_at":"2015-10-06T14:11:01Z","html_url":"https://github.com/georchestra/georchestra/pull/1036#discussion_r41268441","pull_request_url":"https://api.github.com/repos/georchestra/georchestra/pulls/1036","_links":{"self":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/comments/41268441"},"html":{"href":"https://github.com/georchestra/georchestra/pull/1036#discussion_r41268441"},"pull_request":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1036"}}},"pull_request":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/1036","id":43757856,"html_url":"https://github.com/georchestra/georchestra/pull/1036","diff_url":"https://github.com/georchestra/georchestra/pull/1036.diff","patch_url":"https://github.com/georchestra/georchestra/pull/1036.patch","issue_url":"https://api.github.com/repos/georchestra/georchestra/issues/1036","number":1036,"state":"open","locked":false,"title":"security-proxy - datadirisation","user":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?v=3","gravatar_id":"","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"body":"This represents the current diff between my georchestra-datadir and master, against the security-proxy submodule.\r\n\r\nSince this was a requirement asked by our customers during the last codesprint, this PR also addresses the fact that the config-security configuration for URLs vs Role mapping can now be exported into the georchestra datadir.\r\n\r\nThis also introduces debian | rpm package capabilities, deactivated by default, but can be triggered by activating the debianPackage|rpmPackage profile in the pom.\r\n\r\nTests: \r\n* [x] compilation OK\r\n*  [x] testsuite OK\r\n* [x] tested at runtime (ROOT-generic.war with the georchestra.datadir env variable) OK\r\n* [x] tested at runtime (without the georchestra.datadir en variable, hacking the deployed configuration) OK\r\n\r\nWarning:\r\n\r\nthis PR requires the previous one to be integrated (see https://github.com/georchestra/georchestra/pull/1035). Unless this one is merged, travis-ci will complain\r\n","created_at":"2015-08-31T12:10:23Z","updated_at":"2015-10-06T14:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d64b7605eda9f40496103399acedd99dcbf98c70","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/georchestra/georchestra/pulls/1036/commits","review_comments_url":"https://api.github.com/repos/georchestra/georchestra/pulls/1036/comments","review_comment_url":"https://api.github.com/repos/georchestra/georchestra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/georchestra/georchestra/issues/1036/comments","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/92f7b704149df01ba3613d7c5ab9e31b7df16360","head":{"label":"georchestra:security-proxy-datadir","ref":"security-proxy-datadir","sha":"92f7b704149df01ba3613d7c5ab9e31b7df16360","user":{"login":"georchestra","id":773831,"avatar_url":"https://avatars.githubusercontent.com/u/773831?v=3","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":6066709,"name":"georchestra","full_name":"georchestra/georchestra","owner":{"login":"georchestra","id":773831,"avatar_url":"https://avatars.githubusercontent.com/u/773831?v=3","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/georchestra/georchestra","description":"This is the main geOrchestra Spatial Data Infrastructure repository","fork":false,"url":"https://api.github.com/repos/georchestra/georchestra","forks_url":"https://api.github.com/repos/georchestra/georchestra/forks","keys_url":"https://api.github.com/repos/georchestra/georchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georchestra/georchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georchestra/georchestra/teams","hooks_url":"https://api.github.com/repos/georchestra/georchestra/hooks","issue_events_url":"https://api.github.com/repos/georchestra/georchestra/issues/events{/number}","events_url":"https://api.github.com/repos/georchestra/georchestra/events","assignees_url":"https://api.github.com/repos/georchestra/georchestra/assignees{/user}","branches_url":"https://api.github.com/repos/georchestra/georchestra/branches{/branch}","tags_url":"https://api.github.com/repos/georchestra/georchestra/tags","blobs_url":"https://api.github.com/repos/georchestra/georchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georchestra/georchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georchestra/georchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/georchestra/georchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/georchestra/georchestra/languages","stargazers_url":"https://api.github.com/repos/georchestra/georchestra/stargazers","contributors_url":"https://api.github.com/repos/georchestra/georchestra/contributors","subscribers_url":"https://api.github.com/repos/georchestra/georchestra/subscribers","subscription_url":"https://api.github.com/repos/georchestra/georchestra/subscription","commits_url":"https://api.github.com/repos/georchestra/georchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/georchestra/georchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/georchestra/georchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/georchestra/georchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/georchestra/georchestra/contents/{+path}","compare_url":"https://api.github.com/repos/georchestra/georchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georchestra/georchestra/merges","archive_url":"https://api.github.com/repos/georchestra/georchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georchestra/georchestra/downloads","issues_url":"https://api.github.com/repos/georchestra/georchestra/issues{/number}","pulls_url":"https://api.github.com/repos/georchestra/georchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/georchestra/georchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/georchestra/georchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georchestra/georchestra/labels{/name}","releases_url":"https://api.github.com/repos/georchestra/georchestra/releases{/id}","created_at":"2012-10-03T20:55:45Z","updated_at":"2015-09-30T21:11:42Z","pushed_at":"2015-10-06T13:58:36Z","git_url":"git://github.com/georchestra/georchestra.git","ssh_url":"git@github.com:georchestra/georchestra.git","clone_url":"https://github.com/georchestra/georchestra.git","svn_url":"https://github.com/georchestra/georchestra","homepage":"http://www.georchestra.org/","size":301835,"stargazers_count":23,"watchers_count":23,"language":"Game Maker Language","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":273,"forks":41,"open_issues":273,"watchers":23,"default_branch":"15.06"}},"base":{"label":"georchestra:master","ref":"master","sha":"7cb242501e3f7f9113f489491abe013317f884f9","user":{"login":"georchestra","id":773831,"avatar_url":"https://avatars.githubusercontent.com/u/773831?v=3","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":6066709,"name":"georchestra","full_name":"georchestra/georchestra","owner":{"login":"georchestra","id":773831,"avatar_url":"https://avatars.githubusercontent.com/u/773831?v=3","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/georchestra/georchestra","description":"This is the main geOrchestra Spatial Data Infrastructure repository","fork":false,"url":"https://api.github.com/repos/georchestra/georchestra","forks_url":"https://api.github.com/repos/georchestra/georchestra/forks","keys_url":"https://api.github.com/repos/georchestra/georchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georchestra/georchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georchestra/georchestra/teams","hooks_url":"https://api.github.com/repos/georchestra/georchestra/hooks","issue_events_url":"https://api.github.com/repos/georchestra/georchestra/issues/events{/number}","events_url":"https://api.github.com/repos/georchestra/georchestra/events","assignees_url":"https://api.github.com/repos/georchestra/georchestra/assignees{/user}","branches_url":"https://api.github.com/repos/georchestra/georchestra/branches{/branch}","tags_url":"https://api.github.com/repos/georchestra/georchestra/tags","blobs_url":"https://api.github.com/repos/georchestra/georchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georchestra/georchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georchestra/georchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/georchestra/georchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/georchestra/georchestra/languages","stargazers_url":"https://api.github.com/repos/georchestra/georchestra/stargazers","contributors_url":"https://api.github.com/repos/georchestra/georchestra/contributors","subscribers_url":"https://api.github.com/repos/georchestra/georchestra/subscribers","subscription_url":"https://api.github.com/repos/georchestra/georchestra/subscription","commits_url":"https://api.github.com/repos/georchestra/georchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/georchestra/georchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/georchestra/georchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/georchestra/georchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/georchestra/georchestra/contents/{+path}","compare_url":"https://api.github.com/repos/georchestra/georchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georchestra/georchestra/merges","archive_url":"https://api.github.com/repos/georchestra/georchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georchestra/georchestra/downloads","issues_url":"https://api.github.com/repos/georchestra/georchestra/issues{/number}","pulls_url":"https://api.github.com/repos/georchestra/georchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/georchestra/georchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/georchestra/georchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georchestra/georchestra/labels{/name}","releases_url":"https://api.github.com/repos/georchestra/georchestra/releases{/id}","created_at":"2012-10-03T20:55:45Z","updated_at":"2015-09-30T21:11:42Z","pushed_at":"2015-10-06T13:58:36Z","git_url":"git://github.com/georchestra/georchestra.git","ssh_url":"git@github.com:georchestra/georchestra.git","clone_url":"https://github.com/georchestra/georchestra.git","svn_url":"https://github.com/georchestra/georchestra","homepage":"http://www.georchestra.org/","size":301835,"stargazers_count":23,"watchers_count":23,"language":"Game Maker Language","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":273,"forks":41,"open_issues":273,"watchers":23,"default_branch":"15.06"}},"_links":{"self":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1036"},"html":{"href":"https://github.com/georchestra/georchestra/pull/1036"},"issue":{"href":"https://api.github.com/repos/georchestra/georchestra/issues/1036"},"comments":{"href":"https://api.github.com/repos/georchestra/georchestra/issues/1036/comments"},"review_comments":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1036/comments"},"review_comment":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/1036/commits"},"statuses":{"href":"https://api.github.com/repos/georchestra/georchestra/statuses/92f7b704149df01ba3613d7c5ab9e31b7df16360"}}}}