{"action":"created","comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/24718065","id":24718065,"diff_hunk":"@@ -193,37 +194,152 @@ function rules.apply(c)\n     rules.execute(c, props, callbacks)\n end\n \n+--- Get a property value\n+-- @param c The client.\n+-- @param property The property name\n+-- @param value The property value\n+-- @param ignore_function A table of properties where functions should not be executed\n+local funcion get_property(c,property,value,ignore_function)\n+    if not property or not value then return end\n+\n+    if type(property) ~= \"function\" or ignore_function[property] then\n+        return value\n+    else\n+        return value(c)\n+    end\n+    return  and value or (ignore_function[property] and property or )","path":"lib/awful/rules.lua.in","position":25,"original_position":25,"commit_id":"9f88fd2b1ee3fb4aff6b5c0eecb3c38e981e1a06","original_commit_id":"9f88fd2b1ee3fb4aff6b5c0eecb3c38e981e1a06","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"body":"This line is never executed.","created_at":"2015-02-14T23:00:52Z","updated_at":"2015-02-14T23:00:52Z","html_url":"https://github.com/awesomeWM/awesome/pull/53#discussion_r24718065","pull_request_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/24718065"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/53#discussion_r24718065"},"pull_request":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/53","id":22677323,"html_url":"https://github.com/awesomeWM/awesome/pull/53","diff_url":"https://github.com/awesomeWM/awesome/pull/53.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/53.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/53","number":53,"state":"open","locked":false,"title":"Awful.rules refactor","user":{"login":"Elv13","id":340384,"avatar_url":"https://avatars.githubusercontent.com/u/340384?v=3","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"body":"This PR merge Tyrannical extra properties with awful.rules. So now, 'master', 'slave', 'centered' and 'new_tag' are allowed. Using 2 API only caused frustrations for users who wanted the properties without having to use Tyrannical. I also took time to add extra check for some of the properties, hence all the extra code.\r\n\r\napply_properties return a set of tags, this is required to eventually merge with Tyrannical logic.\r\n\r\nThis is for master only and had very limited testing. \r\n\r\nThis replace another commit from an old pull request","created_at":"2014-10-13T22:44:21Z","updated_at":"2015-02-14T23:00:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2123ced0a4de3cdc499704b6fd818af35e8bbe68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/53/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/53/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/53/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/9f88fd2b1ee3fb4aff6b5c0eecb3c38e981e1a06","head":{"label":"Elv13:awful_rules_refactor","ref":"awful_rules_refactor","sha":"9f88fd2b1ee3fb4aff6b5c0eecb3c38e981e1a06","user":{"login":"Elv13","id":340384,"avatar_url":"https://avatars.githubusercontent.com/u/340384?v=3","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"repo":{"id":17379398,"name":"awesome-1","full_name":"Elv13/awesome-1","owner":{"login":"Elv13","id":340384,"avatar_url":"https://avatars.githubusercontent.com/u/340384?v=3","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Elv13/awesome-1","description":"Semi-official mirror of the awesome window manager from git://git.naquadah.org/awesome.git, updated hourly.","fork":true,"url":"https://api.github.com/repos/Elv13/awesome-1","forks_url":"https://api.github.com/repos/Elv13/awesome-1/forks","keys_url":"https://api.github.com/repos/Elv13/awesome-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elv13/awesome-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elv13/awesome-1/teams","hooks_url":"https://api.github.com/repos/Elv13/awesome-1/hooks","issue_events_url":"https://api.github.com/repos/Elv13/awesome-1/issues/events{/number}","events_url":"https://api.github.com/repos/Elv13/awesome-1/events","assignees_url":"https://api.github.com/repos/Elv13/awesome-1/assignees{/user}","branches_url":"https://api.github.com/repos/Elv13/awesome-1/branches{/branch}","tags_url":"https://api.github.com/repos/Elv13/awesome-1/tags","blobs_url":"https://api.github.com/repos/Elv13/awesome-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elv13/awesome-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elv13/awesome-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elv13/awesome-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elv13/awesome-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Elv13/awesome-1/languages","stargazers_url":"https://api.github.com/repos/Elv13/awesome-1/stargazers","contributors_url":"https://api.github.com/repos/Elv13/awesome-1/contributors","subscribers_url":"https://api.github.com/repos/Elv13/awesome-1/subscribers","subscription_url":"https://api.github.com/repos/Elv13/awesome-1/subscription","commits_url":"https://api.github.com/repos/Elv13/awesome-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elv13/awesome-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elv13/awesome-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elv13/awesome-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/Elv13/awesome-1/contents/{+path}","compare_url":"https://api.github.com/repos/Elv13/awesome-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elv13/awesome-1/merges","archive_url":"https://api.github.com/repos/Elv13/awesome-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elv13/awesome-1/downloads","issues_url":"https://api.github.com/repos/Elv13/awesome-1/issues{/number}","pulls_url":"https://api.github.com/repos/Elv13/awesome-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Elv13/awesome-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Elv13/awesome-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elv13/awesome-1/labels{/name}","releases_url":"https://api.github.com/repos/Elv13/awesome-1/releases{/id}","created_at":"2014-03-03T20:41:58Z","updated_at":"2014-11-01T22:48:43Z","pushed_at":"2015-02-10T19:29:00Z","git_url":"git://github.com/Elv13/awesome-1.git","ssh_url":"git@github.com:Elv13/awesome-1.git","clone_url":"https://github.com/Elv13/awesome-1.git","svn_url":"https://github.com/Elv13/awesome-1","homepage":"https://awesome.naquadah.org/","size":7981,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"d76e20bbcefd28de17300f2766a28bffb6bcafe3","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments/{number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","created_at":"2014-03-03T19:56:16Z","updated_at":"2015-02-14T22:37:38Z","pushed_at":"2015-02-14T22:37:37Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesome.naquadah.org/","size":9804,"stargazers_count":195,"watchers_count":195,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":32,"forks":36,"open_issues":32,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/53"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/53"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/53"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/9f88fd2b1ee3fb4aff6b5c0eecb3c38e981e1a06"}}}}