{"action":"closed","number":163,"pull_request":{"url":"https://api.github.com/repos/rubenarslan/formr.org/pulls/163","id":39702245,"html_url":"https://github.com/rubenarslan/formr.org/pull/163","diff_url":"https://github.com/rubenarslan/formr.org/pull/163.diff","patch_url":"https://github.com/rubenarslan/formr.org/pull/163.patch","issue_url":"https://api.github.com/repos/rubenarslan/formr.org/issues/163","number":163,"state":"closed","locked":false,"title":"internal posting should not be dependent if dynamic values are set or not","user":{"login":"cyriltata","id":2277095,"avatar_url":"https://avatars.githubusercontent.com/u/2277095?v=3","gravatar_id":"","url":"https://api.github.com/users/cyriltata","html_url":"https://github.com/cyriltata","followers_url":"https://api.github.com/users/cyriltata/followers","following_url":"https://api.github.com/users/cyriltata/following{/other_user}","gists_url":"https://api.github.com/users/cyriltata/gists{/gist_id}","starred_url":"https://api.github.com/users/cyriltata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyriltata/subscriptions","organizations_url":"https://api.github.com/users/cyriltata/orgs","repos_url":"https://api.github.com/users/cyriltata/repos","events_url":"https://api.github.com/users/cyriltata/events{/privacy}","received_events_url":"https://api.github.com/users/cyriltata/received_events","type":"User","site_admin":false},"body":"- The error we made was that an 'internal post' occurred only if there are dynamic values and apparently this is not the only situation where an internal post should happen. User can set even a calculate item that does not require a dynamic value.\r\n- This commit just moves that aspect out of Survey::parseShowIfsAndDynamicValues()","created_at":"2015-07-10T16:43:40Z","updated_at":"2015-07-10T16:43:58Z","closed_at":"2015-07-10T16:43:58Z","merged_at":"2015-07-10T16:43:58Z","merge_commit_sha":"cadf44dbce8fd70e0bbbdff5929515f8ced9ab47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rubenarslan/formr.org/pulls/163/commits","review_comments_url":"https://api.github.com/repos/rubenarslan/formr.org/pulls/163/comments","review_comment_url":"https://api.github.com/repos/rubenarslan/formr.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubenarslan/formr.org/issues/163/comments","statuses_url":"https://api.github.com/repos/rubenarslan/formr.org/statuses/eab5a6b18e483fc4512e11f2fe3fb96d91d2c273","head":{"label":"cyriltata:develop","ref":"develop","sha":"eab5a6b18e483fc4512e11f2fe3fb96d91d2c273","user":{"login":"cyriltata","id":2277095,"avatar_url":"https://avatars.githubusercontent.com/u/2277095?v=3","gravatar_id":"","url":"https://api.github.com/users/cyriltata","html_url":"https://github.com/cyriltata","followers_url":"https://api.github.com/users/cyriltata/followers","following_url":"https://api.github.com/users/cyriltata/following{/other_user}","gists_url":"https://api.github.com/users/cyriltata/gists{/gist_id}","starred_url":"https://api.github.com/users/cyriltata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyriltata/subscriptions","organizations_url":"https://api.github.com/users/cyriltata/orgs","repos_url":"https://api.github.com/users/cyriltata/repos","events_url":"https://api.github.com/users/cyriltata/events{/privacy}","received_events_url":"https://api.github.com/users/cyriltata/received_events","type":"User","site_admin":false},"repo":{"id":25216696,"name":"formr.org","full_name":"cyriltata/formr.org","owner":{"login":"cyriltata","id":2277095,"avatar_url":"https://avatars.githubusercontent.com/u/2277095?v=3","gravatar_id":"","url":"https://api.github.com/users/cyriltata","html_url":"https://github.com/cyriltata","followers_url":"https://api.github.com/users/cyriltata/followers","following_url":"https://api.github.com/users/cyriltata/following{/other_user}","gists_url":"https://api.github.com/users/cyriltata/gists{/gist_id}","starred_url":"https://api.github.com/users/cyriltata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyriltata/subscriptions","organizations_url":"https://api.github.com/users/cyriltata/orgs","repos_url":"https://api.github.com/users/cyriltata/repos","events_url":"https://api.github.com/users/cyriltata/events{/privacy}","received_events_url":"https://api.github.com/users/cyriltata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyriltata/formr.org","description":"chain simple forms / surveys into longer runs using the power of R to generate pretty feedback and complex designs","fork":true,"url":"https://api.github.com/repos/cyriltata/formr.org","forks_url":"https://api.github.com/repos/cyriltata/formr.org/forks","keys_url":"https://api.github.com/repos/cyriltata/formr.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyriltata/formr.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyriltata/formr.org/teams","hooks_url":"https://api.github.com/repos/cyriltata/formr.org/hooks","issue_events_url":"https://api.github.com/repos/cyriltata/formr.org/issues/events{/number}","events_url":"https://api.github.com/repos/cyriltata/formr.org/events","assignees_url":"https://api.github.com/repos/cyriltata/formr.org/assignees{/user}","branches_url":"https://api.github.com/repos/cyriltata/formr.org/branches{/branch}","tags_url":"https://api.github.com/repos/cyriltata/formr.org/tags","blobs_url":"https://api.github.com/repos/cyriltata/formr.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyriltata/formr.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyriltata/formr.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyriltata/formr.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyriltata/formr.org/statuses/{sha}","languages_url":"https://api.github.com/repos/cyriltata/formr.org/languages","stargazers_url":"https://api.github.com/repos/cyriltata/formr.org/stargazers","contributors_url":"https://api.github.com/repos/cyriltata/formr.org/contributors","subscribers_url":"https://api.github.com/repos/cyriltata/formr.org/subscribers","subscription_url":"https://api.github.com/repos/cyriltata/formr.org/subscription","commits_url":"https://api.github.com/repos/cyriltata/formr.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyriltata/formr.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyriltata/formr.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyriltata/formr.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyriltata/formr.org/contents/{+path}","compare_url":"https://api.github.com/repos/cyriltata/formr.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyriltata/formr.org/merges","archive_url":"https://api.github.com/repos/cyriltata/formr.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyriltata/formr.org/downloads","issues_url":"https://api.github.com/repos/cyriltata/formr.org/issues{/number}","pulls_url":"https://api.github.com/repos/cyriltata/formr.org/pulls{/number}","milestones_url":"https://api.github.com/repos/cyriltata/formr.org/milestones{/number}","notifications_url":"https://api.github.com/repos/cyriltata/formr.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyriltata/formr.org/labels{/name}","releases_url":"https://api.github.com/repos/cyriltata/formr.org/releases{/id}","created_at":"2014-10-14T16:51:59Z","updated_at":"2015-02-23T15:29:34Z","pushed_at":"2015-07-10T16:40:32Z","git_url":"git://github.com/cyriltata/formr.org.git","ssh_url":"git@github.com:cyriltata/formr.org.git","clone_url":"https://github.com/cyriltata/formr.org.git","svn_url":"https://github.com/cyriltata/formr.org","homepage":"formr.org","size":72703,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubenarslan:develop","ref":"develop","sha":"f1c913e7984ec8aa275d6cb74233f7e6ce205dc6","user":{"login":"rubenarslan","id":831109,"avatar_url":"https://avatars.githubusercontent.com/u/831109?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenarslan","html_url":"https://github.com/rubenarslan","followers_url":"https://api.github.com/users/rubenarslan/followers","following_url":"https://api.github.com/users/rubenarslan/following{/other_user}","gists_url":"https://api.github.com/users/rubenarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenarslan/subscriptions","organizations_url":"https://api.github.com/users/rubenarslan/orgs","repos_url":"https://api.github.com/users/rubenarslan/repos","events_url":"https://api.github.com/users/rubenarslan/events{/privacy}","received_events_url":"https://api.github.com/users/rubenarslan/received_events","type":"User","site_admin":false},"repo":{"id":11849439,"name":"formr.org","full_name":"rubenarslan/formr.org","owner":{"login":"rubenarslan","id":831109,"avatar_url":"https://avatars.githubusercontent.com/u/831109?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenarslan","html_url":"https://github.com/rubenarslan","followers_url":"https://api.github.com/users/rubenarslan/followers","following_url":"https://api.github.com/users/rubenarslan/following{/other_user}","gists_url":"https://api.github.com/users/rubenarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenarslan/subscriptions","organizations_url":"https://api.github.com/users/rubenarslan/orgs","repos_url":"https://api.github.com/users/rubenarslan/repos","events_url":"https://api.github.com/users/rubenarslan/events{/privacy}","received_events_url":"https://api.github.com/users/rubenarslan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubenarslan/formr.org","description":"chain simple forms / surveys into longer runs using the power of R to generate pretty feedback and complex designs","fork":false,"url":"https://api.github.com/repos/rubenarslan/formr.org","forks_url":"https://api.github.com/repos/rubenarslan/formr.org/forks","keys_url":"https://api.github.com/repos/rubenarslan/formr.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubenarslan/formr.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubenarslan/formr.org/teams","hooks_url":"https://api.github.com/repos/rubenarslan/formr.org/hooks","issue_events_url":"https://api.github.com/repos/rubenarslan/formr.org/issues/events{/number}","events_url":"https://api.github.com/repos/rubenarslan/formr.org/events","assignees_url":"https://api.github.com/repos/rubenarslan/formr.org/assignees{/user}","branches_url":"https://api.github.com/repos/rubenarslan/formr.org/branches{/branch}","tags_url":"https://api.github.com/repos/rubenarslan/formr.org/tags","blobs_url":"https://api.github.com/repos/rubenarslan/formr.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubenarslan/formr.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubenarslan/formr.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubenarslan/formr.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubenarslan/formr.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rubenarslan/formr.org/languages","stargazers_url":"https://api.github.com/repos/rubenarslan/formr.org/stargazers","contributors_url":"https://api.github.com/repos/rubenarslan/formr.org/contributors","subscribers_url":"https://api.github.com/repos/rubenarslan/formr.org/subscribers","subscription_url":"https://api.github.com/repos/rubenarslan/formr.org/subscription","commits_url":"https://api.github.com/repos/rubenarslan/formr.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubenarslan/formr.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubenarslan/formr.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubenarslan/formr.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubenarslan/formr.org/contents/{+path}","compare_url":"https://api.github.com/repos/rubenarslan/formr.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubenarslan/formr.org/merges","archive_url":"https://api.github.com/repos/rubenarslan/formr.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubenarslan/formr.org/downloads","issues_url":"https://api.github.com/repos/rubenarslan/formr.org/issues{/number}","pulls_url":"https://api.github.com/repos/rubenarslan/formr.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rubenarslan/formr.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rubenarslan/formr.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubenarslan/formr.org/labels{/name}","releases_url":"https://api.github.com/repos/rubenarslan/formr.org/releases{/id}","created_at":"2013-08-02T18:05:28Z","updated_at":"2015-07-02T16:47:22Z","pushed_at":"2015-07-10T16:43:58Z","git_url":"git://github.com/rubenarslan/formr.org.git","ssh_url":"git@github.com:rubenarslan/formr.org.git","clone_url":"https://github.com/rubenarslan/formr.org.git","svn_url":"https://github.com/rubenarslan/formr.org","homepage":"formr.org","size":74271,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":29,"forks":7,"open_issues":29,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubenarslan/formr.org/pulls/163"},"html":{"href":"https://github.com/rubenarslan/formr.org/pull/163"},"issue":{"href":"https://api.github.com/repos/rubenarslan/formr.org/issues/163"},"comments":{"href":"https://api.github.com/repos/rubenarslan/formr.org/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/rubenarslan/formr.org/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/rubenarslan/formr.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubenarslan/formr.org/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/rubenarslan/formr.org/statuses/eab5a6b18e483fc4512e11f2fe3fb96d91d2c273"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cyriltata","id":2277095,"avatar_url":"https://avatars.githubusercontent.com/u/2277095?v=3","gravatar_id":"","url":"https://api.github.com/users/cyriltata","html_url":"https://github.com/cyriltata","followers_url":"https://api.github.com/users/cyriltata/followers","following_url":"https://api.github.com/users/cyriltata/following{/other_user}","gists_url":"https://api.github.com/users/cyriltata/gists{/gist_id}","starred_url":"https://api.github.com/users/cyriltata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyriltata/subscriptions","organizations_url":"https://api.github.com/users/cyriltata/orgs","repos_url":"https://api.github.com/users/cyriltata/repos","events_url":"https://api.github.com/users/cyriltata/events{/privacy}","received_events_url":"https://api.github.com/users/cyriltata/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":27,"changed_files":2}}