{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/got/pulls/comments/34762617","id":34762617,"diff_hunk":"@@ -185,6 +186,18 @@ got('todomvc.com', {\n ```\n \n \n+## Node 0.10\n+\n+It is a known issue with Node [http.Agent](https://nodejs.org/docs/v0.10.39/api/http.html#http_class_http_agent) and `agent.maxSockets`, which is set to `5`. This can cause low performance of application and (in rare cases) deadlocks. To avoid this you can set it manually:","path":"readme.md","position":68,"original_position":68,"commit_id":"04dbc4b7289f4642feefc20aad5f53812cdf0514","original_commit_id":"04dbc4b7289f4642feefc20aad5f53812cdf0514","user":{"login":"floatdrop","id":365089,"avatar_url":"https://avatars.githubusercontent.com/u/365089?v=3","gravatar_id":"","url":"https://api.github.com/users/floatdrop","html_url":"https://github.com/floatdrop","followers_url":"https://api.github.com/users/floatdrop/followers","following_url":"https://api.github.com/users/floatdrop/following{/other_user}","gists_url":"https://api.github.com/users/floatdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/floatdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floatdrop/subscriptions","organizations_url":"https://api.github.com/users/floatdrop/orgs","repos_url":"https://api.github.com/users/floatdrop/repos","events_url":"https://api.github.com/users/floatdrop/events{/privacy}","received_events_url":"https://api.github.com/users/floatdrop/received_events","type":"User","site_admin":false},"body":"Fixed a little bit - but still can be wrong/confusing.\r\n\r\np.s. This agent tuning does not affects compatibility (it will work on 0.10) - but, in some cases, performance.","created_at":"2015-07-16T07:42:36Z","updated_at":"2015-07-16T07:42:36Z","html_url":"https://github.com/sindresorhus/got/pull/82#discussion_r34762617","pull_request_url":"https://api.github.com/repos/sindresorhus/got/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/comments/34762617"},"html":{"href":"https://github.com/sindresorhus/got/pull/82#discussion_r34762617"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/got/pulls/82","id":40005976,"html_url":"https://github.com/sindresorhus/got/pull/82","diff_url":"https://github.com/sindresorhus/got/pull/82.diff","patch_url":"https://github.com/sindresorhus/got/pull/82.patch","issue_url":"https://api.github.com/repos/sindresorhus/got/issues/82","number":82,"state":"open","locked":false,"title":"4.0.0","user":{"login":"floatdrop","id":365089,"avatar_url":"https://avatars.githubusercontent.com/u/365089?v=3","gravatar_id":"","url":"https://api.github.com/users/floatdrop","html_url":"https://github.com/floatdrop","followers_url":"https://api.github.com/users/floatdrop/followers","following_url":"https://api.github.com/users/floatdrop/following{/other_user}","gists_url":"https://api.github.com/users/floatdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/floatdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floatdrop/subscriptions","organizations_url":"https://api.github.com/users/floatdrop/orgs","repos_url":"https://api.github.com/users/floatdrop/repos","events_url":"https://api.github.com/users/floatdrop/events{/privacy}","received_events_url":"https://api.github.com/users/floatdrop/received_events","type":"User","site_admin":false},"body":":dragon_face: Here be dragons!\r\n\r\n### infinity-agent removed\r\n\r\nMain reason to use `infinity-agent` was to fix internal `maxSockets` property on 0.10 version of NodeJS. But this approach is not quite configurable and not quite composable with custom agent, which could be necessary to fix #79 \r\n\r\nSo `infinity-agent` should be dropped in favore to readme section with workaround:\r\n\r\n```js\r\nrequire('http').globalAgent.maxSockets = Infinity;\r\nrequire('https').globalAgent.maxSockets = Infinity;\r\n```\r\n\r\n### Promise API\r\n\r\nAs discussed in #66. [`pinkie-promise`](http://npmjs.com/pinkie-promise) was taken as fallback for native Promise.\r\n\r\nI did not put shortcut for streams yet, because it looks like boilerplate.","created_at":"2015-07-15T10:01:00Z","updated_at":"2015-07-16T07:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67dd2ffb11aaa3c867dc0b10761b730066c78556","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/got/pulls/82/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/got/pulls/82/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/got/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/got/issues/82/comments","statuses_url":"https://api.github.com/repos/sindresorhus/got/statuses/04dbc4b7289f4642feefc20aad5f53812cdf0514","head":{"label":"floatdrop:4.0.0","ref":"4.0.0","sha":"04dbc4b7289f4642feefc20aad5f53812cdf0514","user":{"login":"floatdrop","id":365089,"avatar_url":"https://avatars.githubusercontent.com/u/365089?v=3","gravatar_id":"","url":"https://api.github.com/users/floatdrop","html_url":"https://github.com/floatdrop","followers_url":"https://api.github.com/users/floatdrop/followers","following_url":"https://api.github.com/users/floatdrop/following{/other_user}","gists_url":"https://api.github.com/users/floatdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/floatdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floatdrop/subscriptions","organizations_url":"https://api.github.com/users/floatdrop/orgs","repos_url":"https://api.github.com/users/floatdrop/repos","events_url":"https://api.github.com/users/floatdrop/events{/privacy}","received_events_url":"https://api.github.com/users/floatdrop/received_events","type":"User","site_admin":false},"repo":{"id":34558898,"name":"got","full_name":"floatdrop/got","owner":{"login":"floatdrop","id":365089,"avatar_url":"https://avatars.githubusercontent.com/u/365089?v=3","gravatar_id":"","url":"https://api.github.com/users/floatdrop","html_url":"https://github.com/floatdrop","followers_url":"https://api.github.com/users/floatdrop/followers","following_url":"https://api.github.com/users/floatdrop/following{/other_user}","gists_url":"https://api.github.com/users/floatdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/floatdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floatdrop/subscriptions","organizations_url":"https://api.github.com/users/floatdrop/orgs","repos_url":"https://api.github.com/users/floatdrop/repos","events_url":"https://api.github.com/users/floatdrop/events{/privacy}","received_events_url":"https://api.github.com/users/floatdrop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floatdrop/got","description":"Simplified HTTP/HTTPS requests","fork":true,"url":"https://api.github.com/repos/floatdrop/got","forks_url":"https://api.github.com/repos/floatdrop/got/forks","keys_url":"https://api.github.com/repos/floatdrop/got/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floatdrop/got/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floatdrop/got/teams","hooks_url":"https://api.github.com/repos/floatdrop/got/hooks","issue_events_url":"https://api.github.com/repos/floatdrop/got/issues/events{/number}","events_url":"https://api.github.com/repos/floatdrop/got/events","assignees_url":"https://api.github.com/repos/floatdrop/got/assignees{/user}","branches_url":"https://api.github.com/repos/floatdrop/got/branches{/branch}","tags_url":"https://api.github.com/repos/floatdrop/got/tags","blobs_url":"https://api.github.com/repos/floatdrop/got/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floatdrop/got/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floatdrop/got/git/refs{/sha}","trees_url":"https://api.github.com/repos/floatdrop/got/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floatdrop/got/statuses/{sha}","languages_url":"https://api.github.com/repos/floatdrop/got/languages","stargazers_url":"https://api.github.com/repos/floatdrop/got/stargazers","contributors_url":"https://api.github.com/repos/floatdrop/got/contributors","subscribers_url":"https://api.github.com/repos/floatdrop/got/subscribers","subscription_url":"https://api.github.com/repos/floatdrop/got/subscription","commits_url":"https://api.github.com/repos/floatdrop/got/commits{/sha}","git_commits_url":"https://api.github.com/repos/floatdrop/got/git/commits{/sha}","comments_url":"https://api.github.com/repos/floatdrop/got/comments{/number}","issue_comment_url":"https://api.github.com/repos/floatdrop/got/issues/comments{/number}","contents_url":"https://api.github.com/repos/floatdrop/got/contents/{+path}","compare_url":"https://api.github.com/repos/floatdrop/got/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floatdrop/got/merges","archive_url":"https://api.github.com/repos/floatdrop/got/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floatdrop/got/downloads","issues_url":"https://api.github.com/repos/floatdrop/got/issues{/number}","pulls_url":"https://api.github.com/repos/floatdrop/got/pulls{/number}","milestones_url":"https://api.github.com/repos/floatdrop/got/milestones{/number}","notifications_url":"https://api.github.com/repos/floatdrop/got/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floatdrop/got/labels{/name}","releases_url":"https://api.github.com/repos/floatdrop/got/releases{/id}","created_at":"2015-04-25T06:58:30Z","updated_at":"2015-04-27T05:37:24Z","pushed_at":"2015-07-15T10:20:35Z","git_url":"git://github.com/floatdrop/got.git","ssh_url":"git@github.com:floatdrop/got.git","clone_url":"https://github.com/floatdrop/got.git","svn_url":"https://github.com/floatdrop/got","homepage":"","size":612,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"7bc82b8eb63893f264d3c109abe1530ca74a3fb0","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":18193978,"name":"got","full_name":"sindresorhus/got","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/got","description":"Simplified HTTP/HTTPS requests","fork":false,"url":"https://api.github.com/repos/sindresorhus/got","forks_url":"https://api.github.com/repos/sindresorhus/got/forks","keys_url":"https://api.github.com/repos/sindresorhus/got/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/got/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/got/teams","hooks_url":"https://api.github.com/repos/sindresorhus/got/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/got/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/got/events","assignees_url":"https://api.github.com/repos/sindresorhus/got/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/got/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/got/tags","blobs_url":"https://api.github.com/repos/sindresorhus/got/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/got/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/got/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/got/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/got/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/got/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/got/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/got/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/got/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/got/subscription","commits_url":"https://api.github.com/repos/sindresorhus/got/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/got/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/got/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/got/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/got/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/got/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/got/merges","archive_url":"https://api.github.com/repos/sindresorhus/got/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/got/downloads","issues_url":"https://api.github.com/repos/sindresorhus/got/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/got/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/got/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/got/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/got/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/got/releases{/id}","created_at":"2014-03-27T22:40:49Z","updated_at":"2015-07-16T01:51:36Z","pushed_at":"2015-07-15T10:20:36Z","git_url":"git://github.com/sindresorhus/got.git","ssh_url":"git@github.com:sindresorhus/got.git","clone_url":"https://github.com/sindresorhus/got.git","svn_url":"https://github.com/sindresorhus/got","homepage":"","size":1315,"stargazers_count":329,"watchers_count":329,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":7,"forks":15,"open_issues":7,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/82"},"html":{"href":"https://github.com/sindresorhus/got/pull/82"},"issue":{"href":"https://api.github.com/repos/sindresorhus/got/issues/82"},"comments":{"href":"https://api.github.com/repos/sindresorhus/got/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/got/statuses/04dbc4b7289f4642feefc20aad5f53812cdf0514"}}}}