{"action":"opened","number":247,"pull_request":{"url":"https://api.github.com/repos/t4t5/sweetalert/pulls/247","id":27038611,"html_url":"https://github.com/t4t5/sweetalert/pull/247","diff_url":"https://github.com/t4t5/sweetalert/pull/247.diff","patch_url":"https://github.com/t4t5/sweetalert/pull/247.patch","issue_url":"https://api.github.com/repos/t4t5/sweetalert/issues/247","number":247,"state":"open","locked":false,"title":"adding closing function and making the confirmbutton optional","user":{"login":"pascalwacker","id":772008,"avatar_url":"https://avatars.githubusercontent.com/u/772008?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalwacker","html_url":"https://github.com/pascalwacker","followers_url":"https://api.github.com/users/pascalwacker/followers","following_url":"https://api.github.com/users/pascalwacker/following{/other_user}","gists_url":"https://api.github.com/users/pascalwacker/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalwacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalwacker/subscriptions","organizations_url":"https://api.github.com/users/pascalwacker/orgs","repos_url":"https://api.github.com/users/pascalwacker/repos","events_url":"https://api.github.com/users/pascalwacker/events{/privacy}","received_events_url":"https://api.github.com/users/pascalwacker/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nI really like your work, but unfortunately it didn't fit exactly my needs, so I decided to fork it and modify it.\r\n\r\nBasically what I did was making the confirmbutton optional. As default it's still shown, so for all existing users, nothing will change. If someone feels the need to show a sweetalert box without any button, he/she can pass the showConfirmButton param as false and there you go, the button is gone.\r\n\r\nThe following question is now, how should we close it? Easy! just call `swal(false);`. If you feel like, you can also give an close function as second parameter like `swal(false, function() { alert('Modal is closing'); });`\r\n\r\nI hope you like the modifications.\r\n\r\nCheers Pascal Wacker\r\n\r\nP.S. I'm so exited, my first github modification :D","created_at":"2015-01-08T16:10:03Z","updated_at":"2015-01-08T16:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/t4t5/sweetalert/pulls/247/commits","review_comments_url":"https://api.github.com/repos/t4t5/sweetalert/pulls/247/comments","review_comment_url":"https://api.github.com/repos/t4t5/sweetalert/pulls/comments/{number}","comments_url":"https://api.github.com/repos/t4t5/sweetalert/issues/247/comments","statuses_url":"https://api.github.com/repos/t4t5/sweetalert/statuses/e3e2728d3739057a6e12c81d5b4427a619974170","head":{"label":"pascalwacker:closefunction","ref":"closefunction","sha":"e3e2728d3739057a6e12c81d5b4427a619974170","user":{"login":"pascalwacker","id":772008,"avatar_url":"https://avatars.githubusercontent.com/u/772008?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalwacker","html_url":"https://github.com/pascalwacker","followers_url":"https://api.github.com/users/pascalwacker/followers","following_url":"https://api.github.com/users/pascalwacker/following{/other_user}","gists_url":"https://api.github.com/users/pascalwacker/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalwacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalwacker/subscriptions","organizations_url":"https://api.github.com/users/pascalwacker/orgs","repos_url":"https://api.github.com/users/pascalwacker/repos","events_url":"https://api.github.com/users/pascalwacker/events{/privacy}","received_events_url":"https://api.github.com/users/pascalwacker/received_events","type":"User","site_admin":false},"repo":{"id":28973520,"name":"sweetalert","full_name":"pascalwacker/sweetalert","owner":{"login":"pascalwacker","id":772008,"avatar_url":"https://avatars.githubusercontent.com/u/772008?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalwacker","html_url":"https://github.com/pascalwacker","followers_url":"https://api.github.com/users/pascalwacker/followers","following_url":"https://api.github.com/users/pascalwacker/following{/other_user}","gists_url":"https://api.github.com/users/pascalwacker/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalwacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalwacker/subscriptions","organizations_url":"https://api.github.com/users/pascalwacker/orgs","repos_url":"https://api.github.com/users/pascalwacker/repos","events_url":"https://api.github.com/users/pascalwacker/events{/privacy}","received_events_url":"https://api.github.com/users/pascalwacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pascalwacker/sweetalert","description":"A beautiful replacement for JavaScript's \"alert\"","fork":true,"url":"https://api.github.com/repos/pascalwacker/sweetalert","forks_url":"https://api.github.com/repos/pascalwacker/sweetalert/forks","keys_url":"https://api.github.com/repos/pascalwacker/sweetalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascalwacker/sweetalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascalwacker/sweetalert/teams","hooks_url":"https://api.github.com/repos/pascalwacker/sweetalert/hooks","issue_events_url":"https://api.github.com/repos/pascalwacker/sweetalert/issues/events{/number}","events_url":"https://api.github.com/repos/pascalwacker/sweetalert/events","assignees_url":"https://api.github.com/repos/pascalwacker/sweetalert/assignees{/user}","branches_url":"https://api.github.com/repos/pascalwacker/sweetalert/branches{/branch}","tags_url":"https://api.github.com/repos/pascalwacker/sweetalert/tags","blobs_url":"https://api.github.com/repos/pascalwacker/sweetalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascalwacker/sweetalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascalwacker/sweetalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascalwacker/sweetalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascalwacker/sweetalert/statuses/{sha}","languages_url":"https://api.github.com/repos/pascalwacker/sweetalert/languages","stargazers_url":"https://api.github.com/repos/pascalwacker/sweetalert/stargazers","contributors_url":"https://api.github.com/repos/pascalwacker/sweetalert/contributors","subscribers_url":"https://api.github.com/repos/pascalwacker/sweetalert/subscribers","subscription_url":"https://api.github.com/repos/pascalwacker/sweetalert/subscription","commits_url":"https://api.github.com/repos/pascalwacker/sweetalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascalwacker/sweetalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascalwacker/sweetalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascalwacker/sweetalert/issues/comments/{number}","contents_url":"https://api.github.com/repos/pascalwacker/sweetalert/contents/{+path}","compare_url":"https://api.github.com/repos/pascalwacker/sweetalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascalwacker/sweetalert/merges","archive_url":"https://api.github.com/repos/pascalwacker/sweetalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascalwacker/sweetalert/downloads","issues_url":"https://api.github.com/repos/pascalwacker/sweetalert/issues{/number}","pulls_url":"https://api.github.com/repos/pascalwacker/sweetalert/pulls{/number}","milestones_url":"https://api.github.com/repos/pascalwacker/sweetalert/milestones{/number}","notifications_url":"https://api.github.com/repos/pascalwacker/sweetalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascalwacker/sweetalert/labels{/name}","releases_url":"https://api.github.com/repos/pascalwacker/sweetalert/releases{/id}","created_at":"2015-01-08T16:01:23Z","updated_at":"2015-01-08T16:01:24Z","pushed_at":"2015-01-08T16:02:34Z","git_url":"git://github.com/pascalwacker/sweetalert.git","ssh_url":"git@github.com:pascalwacker/sweetalert.git","clone_url":"https://github.com/pascalwacker/sweetalert.git","svn_url":"https://github.com/pascalwacker/sweetalert","homepage":null,"size":4178,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"t4t5:master","ref":"master","sha":"f2230d69a5968dbe070d31a39aec498bad42490f","user":{"login":"t4t5","id":2598660,"avatar_url":"https://avatars.githubusercontent.com/u/2598660?v=3","gravatar_id":"","url":"https://api.github.com/users/t4t5","html_url":"https://github.com/t4t5","followers_url":"https://api.github.com/users/t4t5/followers","following_url":"https://api.github.com/users/t4t5/following{/other_user}","gists_url":"https://api.github.com/users/t4t5/gists{/gist_id}","starred_url":"https://api.github.com/users/t4t5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t4t5/subscriptions","organizations_url":"https://api.github.com/users/t4t5/orgs","repos_url":"https://api.github.com/users/t4t5/repos","events_url":"https://api.github.com/users/t4t5/events{/privacy}","received_events_url":"https://api.github.com/users/t4t5/received_events","type":"User","site_admin":false},"repo":{"id":24635156,"name":"sweetalert","full_name":"t4t5/sweetalert","owner":{"login":"t4t5","id":2598660,"avatar_url":"https://avatars.githubusercontent.com/u/2598660?v=3","gravatar_id":"","url":"https://api.github.com/users/t4t5","html_url":"https://github.com/t4t5","followers_url":"https://api.github.com/users/t4t5/followers","following_url":"https://api.github.com/users/t4t5/following{/other_user}","gists_url":"https://api.github.com/users/t4t5/gists{/gist_id}","starred_url":"https://api.github.com/users/t4t5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t4t5/subscriptions","organizations_url":"https://api.github.com/users/t4t5/orgs","repos_url":"https://api.github.com/users/t4t5/repos","events_url":"https://api.github.com/users/t4t5/events{/privacy}","received_events_url":"https://api.github.com/users/t4t5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t4t5/sweetalert","description":"A beautiful replacement for JavaScript's \"alert\"","fork":false,"url":"https://api.github.com/repos/t4t5/sweetalert","forks_url":"https://api.github.com/repos/t4t5/sweetalert/forks","keys_url":"https://api.github.com/repos/t4t5/sweetalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t4t5/sweetalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t4t5/sweetalert/teams","hooks_url":"https://api.github.com/repos/t4t5/sweetalert/hooks","issue_events_url":"https://api.github.com/repos/t4t5/sweetalert/issues/events{/number}","events_url":"https://api.github.com/repos/t4t5/sweetalert/events","assignees_url":"https://api.github.com/repos/t4t5/sweetalert/assignees{/user}","branches_url":"https://api.github.com/repos/t4t5/sweetalert/branches{/branch}","tags_url":"https://api.github.com/repos/t4t5/sweetalert/tags","blobs_url":"https://api.github.com/repos/t4t5/sweetalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t4t5/sweetalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t4t5/sweetalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/t4t5/sweetalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t4t5/sweetalert/statuses/{sha}","languages_url":"https://api.github.com/repos/t4t5/sweetalert/languages","stargazers_url":"https://api.github.com/repos/t4t5/sweetalert/stargazers","contributors_url":"https://api.github.com/repos/t4t5/sweetalert/contributors","subscribers_url":"https://api.github.com/repos/t4t5/sweetalert/subscribers","subscription_url":"https://api.github.com/repos/t4t5/sweetalert/subscription","commits_url":"https://api.github.com/repos/t4t5/sweetalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/t4t5/sweetalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/t4t5/sweetalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/t4t5/sweetalert/issues/comments/{number}","contents_url":"https://api.github.com/repos/t4t5/sweetalert/contents/{+path}","compare_url":"https://api.github.com/repos/t4t5/sweetalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t4t5/sweetalert/merges","archive_url":"https://api.github.com/repos/t4t5/sweetalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t4t5/sweetalert/downloads","issues_url":"https://api.github.com/repos/t4t5/sweetalert/issues{/number}","pulls_url":"https://api.github.com/repos/t4t5/sweetalert/pulls{/number}","milestones_url":"https://api.github.com/repos/t4t5/sweetalert/milestones{/number}","notifications_url":"https://api.github.com/repos/t4t5/sweetalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t4t5/sweetalert/labels{/name}","releases_url":"https://api.github.com/repos/t4t5/sweetalert/releases{/id}","created_at":"2014-09-30T11:12:48Z","updated_at":"2015-01-08T15:48:45Z","pushed_at":"2014-12-22T20:00:19Z","git_url":"git://github.com/t4t5/sweetalert.git","ssh_url":"git@github.com:t4t5/sweetalert.git","clone_url":"https://github.com/t4t5/sweetalert.git","svn_url":"https://github.com/t4t5/sweetalert","homepage":null,"size":4178,"stargazers_count":9128,"watchers_count":9128,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":832,"mirror_url":null,"open_issues_count":146,"forks":832,"open_issues":146,"watchers":9128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/t4t5/sweetalert/pulls/247"},"html":{"href":"https://github.com/t4t5/sweetalert/pull/247"},"issue":{"href":"https://api.github.com/repos/t4t5/sweetalert/issues/247"},"comments":{"href":"https://api.github.com/repos/t4t5/sweetalert/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/t4t5/sweetalert/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/t4t5/sweetalert/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/t4t5/sweetalert/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/t4t5/sweetalert/statuses/e3e2728d3739057a6e12c81d5b4427a619974170"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":1,"changed_files":2}}