{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/stetho/pulls/comments/27742736","id":27742736,"diff_hunk":"@@ -32,61 +31,13 @@ protected void onCopyAttributes(View element, AttributeAccumulator attributes) {\n     }\n   }\n \n-  private static int getResourcePackageId(int id) {\n-    return (id >>> 24) & 0xff;\n-  }\n-\n   @Nullable\n   private static String getIdAttribute(View element) {\n-    // Adapted from View.toString()\n-\n     int id = element.getId();\n     if (id == View.NO_ID) {","path":"stetho/src/main/java/com/facebook/stetho/inspector/elements/android/ViewDescriptor.java","position":26,"original_position":26,"commit_id":"decc00f3b9cbec6588ed9636d321d7941b41642c","original_commit_id":"f9050f41d978634ce39ff5cd8092e6190a652d5e","user":{"login":"rickbrew","id":10873410,"avatar_url":"https://avatars.githubusercontent.com/u/10873410?v=3","gravatar_id":"","url":"https://api.github.com/users/rickbrew","html_url":"https://github.com/rickbrew","followers_url":"https://api.github.com/users/rickbrew/followers","following_url":"https://api.github.com/users/rickbrew/following{/other_user}","gists_url":"https://api.github.com/users/rickbrew/gists{/gist_id}","starred_url":"https://api.github.com/users/rickbrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickbrew/subscriptions","organizations_url":"https://api.github.com/users/rickbrew/orgs","repos_url":"https://api.github.com/users/rickbrew/repos","events_url":"https://api.github.com/users/rickbrew/events{/privacy}","received_events_url":"https://api.github.com/users/rickbrew/received_events","type":"User","site_admin":false},"body":"why don't we make it so that getIdStringQuietly() handles the 'id == NO_ID' case?","created_at":"2015-04-03T17:39:33Z","updated_at":"2015-04-03T17:39:33Z","html_url":"https://github.com/facebook/stetho/pull/129#discussion_r27742736","pull_request_url":"https://api.github.com/repos/facebook/stetho/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/facebook/stetho/pulls/comments/27742736"},"html":{"href":"https://github.com/facebook/stetho/pull/129#discussion_r27742736"},"pull_request":{"href":"https://api.github.com/repos/facebook/stetho/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/stetho/pulls/129","id":32565756,"html_url":"https://github.com/facebook/stetho/pull/129","diff_url":"https://github.com/facebook/stetho/pull/129.diff","patch_url":"https://github.com/facebook/stetho/pull/129.patch","issue_url":"https://api.github.com/repos/facebook/stetho/issues/129","number":129,"state":"open","locked":false,"title":"Bring id pretty printing to <fragment> support as well.","user":{"login":"jasta","id":83791,"avatar_url":"https://avatars.githubusercontent.com/u/83791?v=3","gravatar_id":"","url":"https://api.github.com/users/jasta","html_url":"https://github.com/jasta","followers_url":"https://api.github.com/users/jasta/followers","following_url":"https://api.github.com/users/jasta/following{/other_user}","gists_url":"https://api.github.com/users/jasta/gists{/gist_id}","starred_url":"https://api.github.com/users/jasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasta/subscriptions","organizations_url":"https://api.github.com/users/jasta/orgs","repos_url":"https://api.github.com/users/jasta/repos","events_url":"https://api.github.com/users/jasta/events{/privacy}","received_events_url":"https://api.github.com/users/jasta/received_events","type":"User","site_admin":false},"body":"Previously only View instances in the DOM would format ids using human\r\nreadable names.  This refactors the logic into a common class and\r\nmodifies FragmentDescriptor to support this.","created_at":"2015-04-03T02:09:47Z","updated_at":"2015-04-03T17:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eea3f5ff20eb453b51cf15df2f760e86bd66472","assignee":{"login":"rickbrew","id":10873410,"avatar_url":"https://avatars.githubusercontent.com/u/10873410?v=3","gravatar_id":"","url":"https://api.github.com/users/rickbrew","html_url":"https://github.com/rickbrew","followers_url":"https://api.github.com/users/rickbrew/followers","following_url":"https://api.github.com/users/rickbrew/following{/other_user}","gists_url":"https://api.github.com/users/rickbrew/gists{/gist_id}","starred_url":"https://api.github.com/users/rickbrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickbrew/subscriptions","organizations_url":"https://api.github.com/users/rickbrew/orgs","repos_url":"https://api.github.com/users/rickbrew/repos","events_url":"https://api.github.com/users/rickbrew/events{/privacy}","received_events_url":"https://api.github.com/users/rickbrew/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/stetho/pulls/129/commits","review_comments_url":"https://api.github.com/repos/facebook/stetho/pulls/129/comments","review_comment_url":"https://api.github.com/repos/facebook/stetho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/stetho/issues/129/comments","statuses_url":"https://api.github.com/repos/facebook/stetho/statuses/decc00f3b9cbec6588ed9636d321d7941b41642c","head":{"label":"jasta:better-fragment-id","ref":"better-fragment-id","sha":"decc00f3b9cbec6588ed9636d321d7941b41642c","user":{"login":"jasta","id":83791,"avatar_url":"https://avatars.githubusercontent.com/u/83791?v=3","gravatar_id":"","url":"https://api.github.com/users/jasta","html_url":"https://github.com/jasta","followers_url":"https://api.github.com/users/jasta/followers","following_url":"https://api.github.com/users/jasta/following{/other_user}","gists_url":"https://api.github.com/users/jasta/gists{/gist_id}","starred_url":"https://api.github.com/users/jasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasta/subscriptions","organizations_url":"https://api.github.com/users/jasta/orgs","repos_url":"https://api.github.com/users/jasta/repos","events_url":"https://api.github.com/users/jasta/events{/privacy}","received_events_url":"https://api.github.com/users/jasta/received_events","type":"User","site_admin":false},"repo":{"id":30987450,"name":"stetho","full_name":"jasta/stetho","owner":{"login":"jasta","id":83791,"avatar_url":"https://avatars.githubusercontent.com/u/83791?v=3","gravatar_id":"","url":"https://api.github.com/users/jasta","html_url":"https://github.com/jasta","followers_url":"https://api.github.com/users/jasta/followers","following_url":"https://api.github.com/users/jasta/following{/other_user}","gists_url":"https://api.github.com/users/jasta/gists{/gist_id}","starred_url":"https://api.github.com/users/jasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasta/subscriptions","organizations_url":"https://api.github.com/users/jasta/orgs","repos_url":"https://api.github.com/users/jasta/repos","events_url":"https://api.github.com/users/jasta/events{/privacy}","received_events_url":"https://api.github.com/users/jasta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasta/stetho","description":"Stetho is a debug bridge for Android applications, enabling the powerful Chrome Developer Tools and much more.","fork":true,"url":"https://api.github.com/repos/jasta/stetho","forks_url":"https://api.github.com/repos/jasta/stetho/forks","keys_url":"https://api.github.com/repos/jasta/stetho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasta/stetho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasta/stetho/teams","hooks_url":"https://api.github.com/repos/jasta/stetho/hooks","issue_events_url":"https://api.github.com/repos/jasta/stetho/issues/events{/number}","events_url":"https://api.github.com/repos/jasta/stetho/events","assignees_url":"https://api.github.com/repos/jasta/stetho/assignees{/user}","branches_url":"https://api.github.com/repos/jasta/stetho/branches{/branch}","tags_url":"https://api.github.com/repos/jasta/stetho/tags","blobs_url":"https://api.github.com/repos/jasta/stetho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasta/stetho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasta/stetho/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasta/stetho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasta/stetho/statuses/{sha}","languages_url":"https://api.github.com/repos/jasta/stetho/languages","stargazers_url":"https://api.github.com/repos/jasta/stetho/stargazers","contributors_url":"https://api.github.com/repos/jasta/stetho/contributors","subscribers_url":"https://api.github.com/repos/jasta/stetho/subscribers","subscription_url":"https://api.github.com/repos/jasta/stetho/subscription","commits_url":"https://api.github.com/repos/jasta/stetho/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasta/stetho/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasta/stetho/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasta/stetho/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasta/stetho/contents/{+path}","compare_url":"https://api.github.com/repos/jasta/stetho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasta/stetho/merges","archive_url":"https://api.github.com/repos/jasta/stetho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasta/stetho/downloads","issues_url":"https://api.github.com/repos/jasta/stetho/issues{/number}","pulls_url":"https://api.github.com/repos/jasta/stetho/pulls{/number}","milestones_url":"https://api.github.com/repos/jasta/stetho/milestones{/number}","notifications_url":"https://api.github.com/repos/jasta/stetho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasta/stetho/labels{/name}","releases_url":"https://api.github.com/repos/jasta/stetho/releases{/id}","created_at":"2015-02-18T21:17:34Z","updated_at":"2015-03-28T21:14:57Z","pushed_at":"2015-04-03T17:38:22Z","git_url":"git://github.com/jasta/stetho.git","ssh_url":"git@github.com:jasta/stetho.git","clone_url":"https://github.com/jasta/stetho.git","svn_url":"https://github.com/jasta/stetho","homepage":"http://facebook.github.io/stetho/","size":1224,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"acd73cd2c5238e9d5365dd5b3271c452291dcf54","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29703871,"name":"stetho","full_name":"facebook/stetho","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/stetho","description":"Stetho is a debug bridge for Android applications, enabling the powerful Chrome Developer Tools and much more.","fork":false,"url":"https://api.github.com/repos/facebook/stetho","forks_url":"https://api.github.com/repos/facebook/stetho/forks","keys_url":"https://api.github.com/repos/facebook/stetho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/stetho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/stetho/teams","hooks_url":"https://api.github.com/repos/facebook/stetho/hooks","issue_events_url":"https://api.github.com/repos/facebook/stetho/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/stetho/events","assignees_url":"https://api.github.com/repos/facebook/stetho/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/stetho/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/stetho/tags","blobs_url":"https://api.github.com/repos/facebook/stetho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/stetho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/stetho/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/stetho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/stetho/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/stetho/languages","stargazers_url":"https://api.github.com/repos/facebook/stetho/stargazers","contributors_url":"https://api.github.com/repos/facebook/stetho/contributors","subscribers_url":"https://api.github.com/repos/facebook/stetho/subscribers","subscription_url":"https://api.github.com/repos/facebook/stetho/subscription","commits_url":"https://api.github.com/repos/facebook/stetho/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/stetho/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/stetho/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/stetho/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/stetho/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/stetho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/stetho/merges","archive_url":"https://api.github.com/repos/facebook/stetho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/stetho/downloads","issues_url":"https://api.github.com/repos/facebook/stetho/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/stetho/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/stetho/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/stetho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/stetho/labels{/name}","releases_url":"https://api.github.com/repos/facebook/stetho/releases{/id}","created_at":"2015-01-22T22:34:10Z","updated_at":"2015-04-03T17:31:04Z","pushed_at":"2015-04-03T17:38:22Z","git_url":"git://github.com/facebook/stetho.git","ssh_url":"git@github.com:facebook/stetho.git","clone_url":"https://github.com/facebook/stetho.git","svn_url":"https://github.com/facebook/stetho","homepage":"http://facebook.github.io/stetho/","size":2188,"stargazers_count":2174,"watchers_count":2174,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":132,"mirror_url":null,"open_issues_count":19,"forks":132,"open_issues":19,"watchers":2174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/stetho/pulls/129"},"html":{"href":"https://github.com/facebook/stetho/pull/129"},"issue":{"href":"https://api.github.com/repos/facebook/stetho/issues/129"},"comments":{"href":"https://api.github.com/repos/facebook/stetho/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/stetho/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/stetho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/stetho/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/stetho/statuses/decc00f3b9cbec6588ed9636d321d7941b41642c"}}}}