{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/41053291","id":41053291,"diff_hunk":"@@ -191,9 +191,12 @@ MCHarfbuzzSkiaFace *MCHarfbuzzGetFaceForSkiaTypeface(SkTypeface *p_typeface, uin\n \tif (t_success)\n \t{\n \t\tMCHarfbuzzSkiaFace *t_hb_sk_face;\n-\t\tt_hb_sk_face = (MCHarfbuzzSkiaFace *)MCGCacheTableGet(s_hb_face_cache, t_key, sizeof(t_id));\n-\t\tif (t_hb_sk_face != nil)\n+\t\t// IM-2015-10-02: [[ Bug 14786 ]] Make sure we store & dereference the *pointer* to MCHarfbuzzSkiaFace\n+\t\t//    instead of its contents.\n+\t\tt_hb_sk_face_ptr = (MCHarfbuzzSkiaFace **)MCGCacheTableGet(s_hb_face_cache, t_key, sizeof(t_id));","path":"libgraphics/src/mblandroidtext.cpp","position":8,"original_position":8,"commit_id":"71d5356328089d3055dceb4ca1874422bfbf13c2","original_commit_id":"71d5356328089d3055dceb4ca1874422bfbf13c2","user":{"login":"livecodepanos","id":5111835,"avatar_url":"https://avatars.githubusercontent.com/u/5111835?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodepanos","html_url":"https://github.com/livecodepanos","followers_url":"https://api.github.com/users/livecodepanos/followers","following_url":"https://api.github.com/users/livecodepanos/following{/other_user}","gists_url":"https://api.github.com/users/livecodepanos/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodepanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodepanos/subscriptions","organizations_url":"https://api.github.com/users/livecodepanos/orgs","repos_url":"https://api.github.com/users/livecodepanos/repos","events_url":"https://api.github.com/users/livecodepanos/events{/privacy}","received_events_url":"https://api.github.com/users/livecodepanos/received_events","type":"User","site_admin":false},"body":"Yeah you found it! One thing though, I think you forgot the declaration of ```MCHarfbuzzSkiaFace **t_hb_sk_face_ptr;```","created_at":"2015-10-02T18:38:10Z","updated_at":"2015-10-02T18:38:10Z","html_url":"https://github.com/livecode/livecode/pull/2973#discussion_r41053291","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/2973","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/41053291"},"html":{"href":"https://github.com/livecode/livecode/pull/2973#discussion_r41053291"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/2973"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/2973","id":46655577,"html_url":"https://github.com/livecode/livecode/pull/2973","diff_url":"https://github.com/livecode/livecode/pull/2973.diff","patch_url":"https://github.com/livecode/livecode/pull/2973.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/2973","number":2973,"state":"open","locked":false,"title":"[[ Bug 14786 ]] Fix random crash when changing textsize on Android","user":{"login":"livecodeian","id":3985900,"avatar_url":"https://avatars.githubusercontent.com/u/3985900?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeian","html_url":"https://github.com/livecodeian","followers_url":"https://api.github.com/users/livecodeian/followers","following_url":"https://api.github.com/users/livecodeian/following{/other_user}","gists_url":"https://api.github.com/users/livecodeian/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeian/subscriptions","organizations_url":"https://api.github.com/users/livecodeian/orgs","repos_url":"https://api.github.com/users/livecodeian/repos","events_url":"https://api.github.com/users/livecodeian/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeian/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-02T16:37:54Z","updated_at":"2015-10-02T18:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc8c8c91e0dec645ad3ace60a5cafeec2b25d4af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/2973/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/2973/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/2973/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/71d5356328089d3055dceb4ca1874422bfbf13c2","head":{"label":"livecodeian:bugfix-14786","ref":"bugfix-14786","sha":"71d5356328089d3055dceb4ca1874422bfbf13c2","user":{"login":"livecodeian","id":3985900,"avatar_url":"https://avatars.githubusercontent.com/u/3985900?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeian","html_url":"https://github.com/livecodeian","followers_url":"https://api.github.com/users/livecodeian/followers","following_url":"https://api.github.com/users/livecodeian/following{/other_user}","gists_url":"https://api.github.com/users/livecodeian/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeian/subscriptions","organizations_url":"https://api.github.com/users/livecodeian/orgs","repos_url":"https://api.github.com/users/livecodeian/repos","events_url":"https://api.github.com/users/livecodeian/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeian/received_events","type":"User","site_admin":false},"repo":{"id":9372560,"name":"livecode","full_name":"livecodeian/livecode","owner":{"login":"livecodeian","id":3985900,"avatar_url":"https://avatars.githubusercontent.com/u/3985900?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeian","html_url":"https://github.com/livecodeian","followers_url":"https://api.github.com/users/livecodeian/followers","following_url":"https://api.github.com/users/livecodeian/following{/other_user}","gists_url":"https://api.github.com/users/livecodeian/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeian/subscriptions","organizations_url":"https://api.github.com/users/livecodeian/orgs","repos_url":"https://api.github.com/users/livecodeian/repos","events_url":"https://api.github.com/users/livecodeian/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/livecodeian/livecode","description":"","fork":true,"url":"https://api.github.com/repos/livecodeian/livecode","forks_url":"https://api.github.com/repos/livecodeian/livecode/forks","keys_url":"https://api.github.com/repos/livecodeian/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecodeian/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecodeian/livecode/teams","hooks_url":"https://api.github.com/repos/livecodeian/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecodeian/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecodeian/livecode/events","assignees_url":"https://api.github.com/repos/livecodeian/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecodeian/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecodeian/livecode/tags","blobs_url":"https://api.github.com/repos/livecodeian/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecodeian/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecodeian/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecodeian/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecodeian/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecodeian/livecode/languages","stargazers_url":"https://api.github.com/repos/livecodeian/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecodeian/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecodeian/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecodeian/livecode/subscription","commits_url":"https://api.github.com/repos/livecodeian/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecodeian/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecodeian/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecodeian/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecodeian/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecodeian/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecodeian/livecode/merges","archive_url":"https://api.github.com/repos/livecodeian/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecodeian/livecode/downloads","issues_url":"https://api.github.com/repos/livecodeian/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecodeian/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecodeian/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecodeian/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecodeian/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecodeian/livecode/releases{/id}","created_at":"2013-04-11T14:42:23Z","updated_at":"2014-06-23T12:26:19Z","pushed_at":"2015-10-02T16:36:34Z","git_url":"git://github.com/livecodeian/livecode.git","ssh_url":"git@github.com:livecodeian/livecode.git","clone_url":"https://github.com/livecodeian/livecode.git","svn_url":"https://github.com/livecodeian/livecode","homepage":null,"size":94602,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"livecode:develop-7.0","ref":"develop-7.0","sha":"919ad215bed900f07d30faca69de84c27745b52d","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","created_at":"2013-04-10T00:15:57Z","updated_at":"2015-09-25T17:03:31Z","pushed_at":"2015-10-02T18:24:52Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":null,"size":298542,"stargazers_count":96,"watchers_count":96,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":50,"forks":84,"open_issues":50,"watchers":96,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/2973"},"html":{"href":"https://github.com/livecode/livecode/pull/2973"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/2973"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/2973/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/2973/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/2973/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/71d5356328089d3055dceb4ca1874422bfbf13c2"}}}}