{"comment":{"url":"https://api.github.com/repos/jenkinsci/docker-plugin/comments/10517848","html_url":"https://github.com/jenkinsci/docker-plugin/commit/bdde16c512c9f72eabc209b7d369f258c987a7af#commitcomment-10517848","id":10517848,"user":{"login":"magnayn","id":53653,"avatar_url":"https://avatars.githubusercontent.com/u/53653?v=3","gravatar_id":"","url":"https://api.github.com/users/magnayn","html_url":"https://github.com/magnayn","followers_url":"https://api.github.com/users/magnayn/followers","following_url":"https://api.github.com/users/magnayn/following{/other_user}","gists_url":"https://api.github.com/users/magnayn/gists{/gist_id}","starred_url":"https://api.github.com/users/magnayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnayn/subscriptions","organizations_url":"https://api.github.com/users/magnayn/orgs","repos_url":"https://api.github.com/users/magnayn/repos","events_url":"https://api.github.com/users/magnayn/events{/privacy}","received_events_url":"https://api.github.com/users/magnayn/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"bdde16c512c9f72eabc209b7d369f258c987a7af","created_at":"2015-04-01T11:03:17Z","updated_at":"2015-04-01T11:03:17Z","body":"Oh, right, so you *don't* have a fix for shade/hpi mismatch.\n\nOf course it's understood how and whether it works; shading isn't exactly a\ncomplex process, therefore I disagree with your characterisation. When the\nclassref issue arose, it's easy to understand *why* it occurs - so it's\nlogical to look at other plugins (particularly ones with input from core\ndevs) to see how they have attacked the same problem. The fact that they\n*also* haven't a fix for the shade/hpi mismatch suggests that it may be a\nnon-trivial fix. Certainly non-trivial compared with what they have\nactually done, which is to access classes in shaded packages directly.\n\nAccessing classes by their shaded names is not ideal. But it works - right\nnow - and 'truth&beauty' solutions can come afterwards. It is, after all,\njust a search and replace change.\n\n\n\nOn Wed, Apr 1, 2015 at 11:29 AM, Kanstantsin Shautsou <\nnotifications@github.com> wrote:\n\n> Shading+hpi issue i found only yesterday and i already debugging it. In\n> wip branch i have some other clean-ups for poms. I don't care about\n> jclouds. If you want develop this plugin in such way \"i fixed somehow and\n> it looks to work\" and \"i copy-pasted some crap and it looks to work\", then\n> i gave up. You can continue doing alpha, beta after your every not reviewed\n> merge and ask people to test and infinitely getting bug reports.\n> How contributors should understand code when even author doesn't know how\n> and whether it works?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/jenkinsci/docker-plugin/commit/bdde16c512c9f72eabc209b7d369f258c987a7af#commitcomment-10517358>\n> .\n>\n"}}