{"action":"opened","number":1525,"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1525","id":42019324,"html_url":"https://github.com/sunpy/sunpy/pull/1525","diff_url":"https://github.com/sunpy/sunpy/pull/1525.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1525.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1525","number":1525,"state":"open","locked":false,"title":"Removed findpeaks from SunPy","user":{"login":"wafels","id":983575,"avatar_url":"https://avatars.githubusercontent.com/u/983575?v=3","gravatar_id":"","url":"https://api.github.com/users/wafels","html_url":"https://github.com/wafels","followers_url":"https://api.github.com/users/wafels/followers","following_url":"https://api.github.com/users/wafels/following{/other_user}","gists_url":"https://api.github.com/users/wafels/gists{/gist_id}","starred_url":"https://api.github.com/users/wafels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wafels/subscriptions","organizations_url":"https://api.github.com/users/wafels/orgs","repos_url":"https://api.github.com/users/wafels/repos","events_url":"https://api.github.com/users/wafels/events{/privacy}","received_events_url":"https://api.github.com/users/wafels/received_events","type":"User","site_admin":false},"body":"The function findpeaks occurs in two places in SunPy.  The first place is its definition in util/util.py.  The second place is its test util/tests/test_util.py.  It is not used in any other place in SunPy.  Also, although the findpeaks passes its test, it does not work correctly in that it does not identify the index of the local peaks.  This PR removes findpeaks from SunPy since (a) it is not used by SunPy, and (b) it is wrong.","created_at":"2015-08-10T13:25:15Z","updated_at":"2015-08-10T13:25:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1525/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1525/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1525/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/66bf6dc3b7e6584f8ed9ef3d665cc41ee0e94dcb","head":{"label":"wafels:remove_findpeaks","ref":"remove_findpeaks","sha":"66bf6dc3b7e6584f8ed9ef3d665cc41ee0e94dcb","user":{"login":"wafels","id":983575,"avatar_url":"https://avatars.githubusercontent.com/u/983575?v=3","gravatar_id":"","url":"https://api.github.com/users/wafels","html_url":"https://github.com/wafels","followers_url":"https://api.github.com/users/wafels/followers","following_url":"https://api.github.com/users/wafels/following{/other_user}","gists_url":"https://api.github.com/users/wafels/gists{/gist_id}","starred_url":"https://api.github.com/users/wafels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wafels/subscriptions","organizations_url":"https://api.github.com/users/wafels/orgs","repos_url":"https://api.github.com/users/wafels/repos","events_url":"https://api.github.com/users/wafels/events{/privacy}","received_events_url":"https://api.github.com/users/wafels/received_events","type":"User","site_admin":false},"repo":{"id":13273447,"name":"sunpy","full_name":"wafels/sunpy","owner":{"login":"wafels","id":983575,"avatar_url":"https://avatars.githubusercontent.com/u/983575?v=3","gravatar_id":"","url":"https://api.github.com/users/wafels","html_url":"https://github.com/wafels","followers_url":"https://api.github.com/users/wafels/followers","following_url":"https://api.github.com/users/wafels/following{/other_user}","gists_url":"https://api.github.com/users/wafels/gists{/gist_id}","starred_url":"https://api.github.com/users/wafels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wafels/subscriptions","organizations_url":"https://api.github.com/users/wafels/orgs","repos_url":"https://api.github.com/users/wafels/repos","events_url":"https://api.github.com/users/wafels/events{/privacy}","received_events_url":"https://api.github.com/users/wafels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wafels/sunpy","description":"SunPy - Python for solar physics","fork":true,"url":"https://api.github.com/repos/wafels/sunpy","forks_url":"https://api.github.com/repos/wafels/sunpy/forks","keys_url":"https://api.github.com/repos/wafels/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wafels/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wafels/sunpy/teams","hooks_url":"https://api.github.com/repos/wafels/sunpy/hooks","issue_events_url":"https://api.github.com/repos/wafels/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/wafels/sunpy/events","assignees_url":"https://api.github.com/repos/wafels/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/wafels/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/wafels/sunpy/tags","blobs_url":"https://api.github.com/repos/wafels/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wafels/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wafels/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wafels/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wafels/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/wafels/sunpy/languages","stargazers_url":"https://api.github.com/repos/wafels/sunpy/stargazers","contributors_url":"https://api.github.com/repos/wafels/sunpy/contributors","subscribers_url":"https://api.github.com/repos/wafels/sunpy/subscribers","subscription_url":"https://api.github.com/repos/wafels/sunpy/subscription","commits_url":"https://api.github.com/repos/wafels/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wafels/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wafels/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wafels/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wafels/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/wafels/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wafels/sunpy/merges","archive_url":"https://api.github.com/repos/wafels/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wafels/sunpy/downloads","issues_url":"https://api.github.com/repos/wafels/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/wafels/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/wafels/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/wafels/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wafels/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/wafels/sunpy/releases{/id}","created_at":"2013-10-02T14:35:50Z","updated_at":"2015-04-04T14:33:06Z","pushed_at":"2015-08-10T13:19:34Z","git_url":"git://github.com/wafels/sunpy.git","ssh_url":"git@github.com:wafels/sunpy.git","clone_url":"https://github.com/wafels/sunpy.git","svn_url":"https://github.com/wafels/sunpy","homepage":"http://www.sunpy.org","size":36776,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"bc2747b07fd502064b38c0168dac4b0e061f68a6","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"name":"sunpy","full_name":"sunpy/sunpy","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for solar physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","created_at":"2011-08-06T15:34:08Z","updated_at":"2015-07-15T06:50:02Z","pushed_at":"2015-08-10T13:23:35Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":145311,"stargazers_count":191,"watchers_count":191,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":213,"forks":127,"open_issues":213,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1525"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1525"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1525"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1525/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1525/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1525/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/66bf6dc3b7e6584f8ed9ef3d665cc41ee0e94dcb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":25,"changed_files":2}}