{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/43351654","id":43351654,"diff_hunk":"@@ -0,0 +1,138 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+#pragma once\n+\n+#include \"pal_types.h\"\n+\n+#include <curl/curl.h>\n+\n+#define CurlOptionLongBase 0\n+#define CurlOptionObjectPointBase 10000\n+#define CurlOptionFunctionPointBase 20000\n+\n+enum PAL_CURLoption : int32_t\n+{\n+    PAL_CURLOPT_INFILESIZE = CurlOptionLongBase + 14,","path":"src/Native/System.Net.Http.Native/pal_easy.h","position":16,"original_position":16,"commit_id":"46b18084392228baaf73461d766015001ac8d215","original_commit_id":"46b18084392228baaf73461d766015001ac8d215","user":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"body":"A question here, since we are in the native world here, can't we just say ```PAL_CURLOPT_INFILESIZE = CURLOPT_INFILESIZE``` ? Is there any advantage of expanding the macro here?\r\n\r\n\r\n","created_at":"2015-10-29T06:00:15Z","updated_at":"2015-10-29T06:00:15Z","html_url":"https://github.com/dotnet/corefx/pull/4216#discussion_r43351654","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/4216","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/43351654"},"html":{"href":"https://github.com/dotnet/corefx/pull/4216#discussion_r43351654"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4216"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/4216","id":49075278,"html_url":"https://github.com/dotnet/corefx/pull/4216","diff_url":"https://github.com/dotnet/corefx/pull/4216.diff","patch_url":"https://github.com/dotnet/corefx/pull/4216.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/4216","number":4216,"state":"open","locked":false,"title":"Shim libcurl slist and easy functions","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"Add shims for Interop.libcurl_slist.cs functions.\r\n\r\nAdd shims for libcurl curl_easy_* functions.\r\n\r\n@kapilash @vijaykota @nguerrera @sokket @stephentoub @bartonjs ","created_at":"2015-10-28T22:20:33Z","updated_at":"2015-10-29T06:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df489166037e105669b96e287e19bf185356fa00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/4216/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/4216/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/4216/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/46b18084392228baaf73461d766015001ac8d215","head":{"label":"eerhardt:ShimLibCurl","ref":"ShimLibCurl","sha":"46b18084392228baaf73461d766015001ac8d215","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"repo":{"id":38781378,"name":"corefx","full_name":"eerhardt/corefx","owner":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eerhardt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/eerhardt/corefx","forks_url":"https://api.github.com/repos/eerhardt/corefx/forks","keys_url":"https://api.github.com/repos/eerhardt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eerhardt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eerhardt/corefx/teams","hooks_url":"https://api.github.com/repos/eerhardt/corefx/hooks","issue_events_url":"https://api.github.com/repos/eerhardt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/eerhardt/corefx/events","assignees_url":"https://api.github.com/repos/eerhardt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/eerhardt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/eerhardt/corefx/tags","blobs_url":"https://api.github.com/repos/eerhardt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eerhardt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eerhardt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/eerhardt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eerhardt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/eerhardt/corefx/languages","stargazers_url":"https://api.github.com/repos/eerhardt/corefx/stargazers","contributors_url":"https://api.github.com/repos/eerhardt/corefx/contributors","subscribers_url":"https://api.github.com/repos/eerhardt/corefx/subscribers","subscription_url":"https://api.github.com/repos/eerhardt/corefx/subscription","commits_url":"https://api.github.com/repos/eerhardt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/eerhardt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/eerhardt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/eerhardt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/eerhardt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/eerhardt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eerhardt/corefx/merges","archive_url":"https://api.github.com/repos/eerhardt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eerhardt/corefx/downloads","issues_url":"https://api.github.com/repos/eerhardt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/eerhardt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/eerhardt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/eerhardt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eerhardt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/eerhardt/corefx/releases{/id}","created_at":"2015-07-08T21:38:15Z","updated_at":"2015-07-08T21:38:34Z","pushed_at":"2015-10-28T22:13:40Z","git_url":"git://github.com/eerhardt/corefx.git","ssh_url":"git@github.com:eerhardt/corefx.git","clone_url":"https://github.com/eerhardt/corefx.git","svn_url":"https://github.com/eerhardt/corefx","homepage":"http://dotnet.github.io/core/","size":38131,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"40ca2da8cfb7329b29f717448b29d77ae34f2d0d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-10-28T22:23:12Z","pushed_at":"2015-10-29T05:18:01Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":88467,"stargazers_count":8505,"watchers_count":8505,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1867,"mirror_url":null,"open_issues_count":660,"forks":1867,"open_issues":660,"watchers":8505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4216"},"html":{"href":"https://github.com/dotnet/corefx/pull/4216"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4216"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4216/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4216/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4216/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/46b18084392228baaf73461d766015001ac8d215"}}}}