{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/24290214","id":24290214,"diff_hunk":"@@ -47,6 +47,7 @@ int random_read(char *buf, unsigned int num)\n void random_poweron(void)\n {\n     NRF_RNG->POWER = 1;\n+    NRF_RNG->TASKS_START = 1;","path":"cpu/nrf51822/periph/random.c","position":4,"original_position":4,"commit_id":"28008dcee850e91e83dadda71554a81d181bb8a3","original_commit_id":"28008dcee850e91e83dadda71554a81d181bb8a3","user":{"login":"LudwigOrtmann","id":3739173,"avatar_url":"https://avatars.githubusercontent.com/u/3739173?v=3","gravatar_id":"","url":"https://api.github.com/users/LudwigOrtmann","html_url":"https://github.com/LudwigOrtmann","followers_url":"https://api.github.com/users/LudwigOrtmann/followers","following_url":"https://api.github.com/users/LudwigOrtmann/following{/other_user}","gists_url":"https://api.github.com/users/LudwigOrtmann/gists{/gist_id}","starred_url":"https://api.github.com/users/LudwigOrtmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LudwigOrtmann/subscriptions","organizations_url":"https://api.github.com/users/LudwigOrtmann/orgs","repos_url":"https://api.github.com/users/LudwigOrtmann/repos","events_url":"https://api.github.com/users/LudwigOrtmann/events{/privacy}","received_events_url":"https://api.github.com/users/LudwigOrtmann/received_events","type":"User","site_admin":false},"body":"It feels like this could as well go into init .. but I didn't read the datasheet. Please comment","created_at":"2015-02-07T15:51:29Z","updated_at":"2015-02-07T15:51:29Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/2236#discussion_r24290214","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/24290214"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2236#discussion_r24290214"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236","id":26627063,"html_url":"https://github.com/RIOT-OS/RIOT/pull/2236","diff_url":"https://github.com/RIOT-OS/RIOT/pull/2236.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/2236.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2236","number":2236,"state":"open","locked":false,"title":"New package for ECDH and ECDSA","user":{"login":"d00616","id":519822,"avatar_url":"https://avatars.githubusercontent.com/u/519822?v=3","gravatar_id":"","url":"https://api.github.com/users/d00616","html_url":"https://github.com/d00616","followers_url":"https://api.github.com/users/d00616/followers","following_url":"https://api.github.com/users/d00616/following{/other_user}","gists_url":"https://api.github.com/users/d00616/gists{/gist_id}","starred_url":"https://api.github.com/users/d00616/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00616/subscriptions","organizations_url":"https://api.github.com/users/d00616/orgs","repos_url":"https://api.github.com/users/d00616/repos","events_url":"https://api.github.com/users/d00616/events{/privacy}","received_events_url":"https://api.github.com/users/d00616/received_events","type":"User","site_admin":false},"body":"I have added this http://kmackay.ca/micro-ecc/ to RIOT OS. This functionality is useful to negotiate an key over an unencrypted channel or to sign data.\r\n\r\nI have tested the test procedure on an native system and on an nRF51822 (PCA10000) CPU. On native target sometimes signature tests are failing. ~~It looks like native random function not serving data. When i start the same binary after some seconds all tests are fine.~~\r\n\r\n~~It looks like the native random function is not ready for cryptography, because it uses the C pseudo random function. Is this right?~~\r\n\r\nI can change micro-ecc package to use original micro-ecc random sources and use periph/random only on non native targets.","created_at":"2014-12-28T19:39:36Z","updated_at":"2015-02-07T15:51:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f440e7703d71530175ac5014b32165fbd18080b","assignee":{"login":"LudwigOrtmann","id":3739173,"avatar_url":"https://avatars.githubusercontent.com/u/3739173?v=3","gravatar_id":"","url":"https://api.github.com/users/LudwigOrtmann","html_url":"https://github.com/LudwigOrtmann","followers_url":"https://api.github.com/users/LudwigOrtmann/followers","following_url":"https://api.github.com/users/LudwigOrtmann/following{/other_user}","gists_url":"https://api.github.com/users/LudwigOrtmann/gists{/gist_id}","starred_url":"https://api.github.com/users/LudwigOrtmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LudwigOrtmann/subscriptions","organizations_url":"https://api.github.com/users/LudwigOrtmann/orgs","repos_url":"https://api.github.com/users/LudwigOrtmann/repos","events_url":"https://api.github.com/users/LudwigOrtmann/events{/privacy}","received_events_url":"https://api.github.com/users/LudwigOrtmann/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2236/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/28008dcee850e91e83dadda71554a81d181bb8a3","head":{"label":"d00616:new_micro-ecc","ref":"new_micro-ecc","sha":"28008dcee850e91e83dadda71554a81d181bb8a3","user":{"login":"d00616","id":519822,"avatar_url":"https://avatars.githubusercontent.com/u/519822?v=3","gravatar_id":"","url":"https://api.github.com/users/d00616","html_url":"https://github.com/d00616","followers_url":"https://api.github.com/users/d00616/followers","following_url":"https://api.github.com/users/d00616/following{/other_user}","gists_url":"https://api.github.com/users/d00616/gists{/gist_id}","starred_url":"https://api.github.com/users/d00616/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00616/subscriptions","organizations_url":"https://api.github.com/users/d00616/orgs","repos_url":"https://api.github.com/users/d00616/repos","events_url":"https://api.github.com/users/d00616/events{/privacy}","received_events_url":"https://api.github.com/users/d00616/received_events","type":"User","site_admin":false},"repo":{"id":28537586,"name":"RIOT","full_name":"d00616/RIOT","owner":{"login":"d00616","id":519822,"avatar_url":"https://avatars.githubusercontent.com/u/519822?v=3","gravatar_id":"","url":"https://api.github.com/users/d00616","html_url":"https://github.com/d00616","followers_url":"https://api.github.com/users/d00616/followers","following_url":"https://api.github.com/users/d00616/following{/other_user}","gists_url":"https://api.github.com/users/d00616/gists{/gist_id}","starred_url":"https://api.github.com/users/d00616/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00616/subscriptions","organizations_url":"https://api.github.com/users/d00616/orgs","repos_url":"https://api.github.com/users/d00616/repos","events_url":"https://api.github.com/users/d00616/events{/privacy}","received_events_url":"https://api.github.com/users/d00616/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d00616/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/d00616/RIOT","forks_url":"https://api.github.com/repos/d00616/RIOT/forks","keys_url":"https://api.github.com/repos/d00616/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d00616/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d00616/RIOT/teams","hooks_url":"https://api.github.com/repos/d00616/RIOT/hooks","issue_events_url":"https://api.github.com/repos/d00616/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/d00616/RIOT/events","assignees_url":"https://api.github.com/repos/d00616/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/d00616/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/d00616/RIOT/tags","blobs_url":"https://api.github.com/repos/d00616/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d00616/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d00616/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/d00616/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d00616/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/d00616/RIOT/languages","stargazers_url":"https://api.github.com/repos/d00616/RIOT/stargazers","contributors_url":"https://api.github.com/repos/d00616/RIOT/contributors","subscribers_url":"https://api.github.com/repos/d00616/RIOT/subscribers","subscription_url":"https://api.github.com/repos/d00616/RIOT/subscription","commits_url":"https://api.github.com/repos/d00616/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/d00616/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/d00616/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/d00616/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/d00616/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/d00616/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d00616/RIOT/merges","archive_url":"https://api.github.com/repos/d00616/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d00616/RIOT/downloads","issues_url":"https://api.github.com/repos/d00616/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/d00616/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/d00616/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/d00616/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d00616/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/d00616/RIOT/releases{/id}","created_at":"2014-12-27T13:42:54Z","updated_at":"2015-01-31T19:25:42Z","pushed_at":"2015-02-07T15:43:47Z","git_url":"git://github.com/d00616/RIOT.git","ssh_url":"git@github.com:d00616/RIOT.git","clone_url":"https://github.com/d00616/RIOT.git","svn_url":"https://github.com/d00616/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":14034,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"e6c4181c943754a587182bcf8b662ca76021afd6","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-02-07T08:07:11Z","pushed_at":"2015-02-06T15:06:49Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":82665,"stargazers_count":250,"watchers_count":250,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":286,"forks":204,"open_issues":286,"watchers":250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2236"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2236"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2236/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2236/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/28008dcee850e91e83dadda71554a81d181bb8a3"}}}}