{"action":"created","comment":{"url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/comments/29417057","id":29417057,"diff_hunk":"@@ -46,6 +46,15 @@ let wildcard_case int_cases =\n     let to_int = [%e Exp.function_ int_cases] in\n     Pervasives.compare (to_int lhs) (to_int rhs)]\n \n+let attr_warning expr =\n+  let loc = !default_loc in\n+  let structure = {pstr_desc = Pstr_eval (expr, []); pstr_loc = loc} in\n+  {txt = \"ocaml.warning\"; loc}, PStr [structure]","path":"src_plugins/ppx_deriving_ord.ml","position":7,"original_position":7,"commit_id":"f4de2c532a4daafa6feb6b268e4d248e6da0f241","original_commit_id":"f4de2c532a4daafa6feb6b268e4d248e6da0f241","user":{"login":"whitequark","id":54771,"avatar_url":"https://avatars.githubusercontent.com/u/54771?v=3","gravatar_id":"","url":"https://api.github.com/users/whitequark","html_url":"https://github.com/whitequark","followers_url":"https://api.github.com/users/whitequark/followers","following_url":"https://api.github.com/users/whitequark/following{/other_user}","gists_url":"https://api.github.com/users/whitequark/gists{/gist_id}","starred_url":"https://api.github.com/users/whitequark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitequark/subscriptions","organizations_url":"https://api.github.com/users/whitequark/orgs","repos_url":"https://api.github.com/users/whitequark/repos","events_url":"https://api.github.com/users/whitequark/events{/privacy}","received_events_url":"https://api.github.com/users/whitequark/received_events","type":"User","site_admin":false},"body":"Could this be generically useful in `Ppx_deriving`?","created_at":"2015-04-30T10:01:12Z","updated_at":"2015-04-30T10:01:12Z","html_url":"https://github.com/whitequark/ppx_deriving/pull/35#discussion_r29417057","pull_request_url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/comments/29417057"},"html":{"href":"https://github.com/whitequark/ppx_deriving/pull/35#discussion_r29417057"},"pull_request":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35","id":34444573,"html_url":"https://github.com/whitequark/ppx_deriving/pull/35","diff_url":"https://github.com/whitequark/ppx_deriving/pull/35.diff","patch_url":"https://github.com/whitequark/ppx_deriving/pull/35.patch","issue_url":"https://api.github.com/repos/whitequark/ppx_deriving/issues/35","number":35,"state":"open","locked":false,"title":"Remove warning 4","user":{"login":"braibant","id":621053,"avatar_url":"https://avatars.githubusercontent.com/u/621053?v=3","gravatar_id":"","url":"https://api.github.com/users/braibant","html_url":"https://github.com/braibant","followers_url":"https://api.github.com/users/braibant/followers","following_url":"https://api.github.com/users/braibant/following{/other_user}","gists_url":"https://api.github.com/users/braibant/gists{/gist_id}","starred_url":"https://api.github.com/users/braibant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braibant/subscriptions","organizations_url":"https://api.github.com/users/braibant/orgs","repos_url":"https://api.github.com/users/braibant/repos","events_url":"https://api.github.com/users/braibant/events{/privacy}","received_events_url":"https://api.github.com/users/braibant/received_events","type":"User","site_admin":false},"body":"Warning 4 is triggered by the code produced with the ppx_deriving_ord plugin (which uses wildcards). The warning does not make much sense in that case (because the code is auto generated), hence it can be safely deactivated in the `match` construct built by `ord`.","created_at":"2015-04-30T09:56:55Z","updated_at":"2015-04-30T10:01:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e93c2b006eb131733de527d3d36b0a891fa78cc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35/commits","review_comments_url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35/comments","review_comment_url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whitequark/ppx_deriving/issues/35/comments","statuses_url":"https://api.github.com/repos/whitequark/ppx_deriving/statuses/f4de2c532a4daafa6feb6b268e4d248e6da0f241","head":{"label":"braibant:remove_warning_4","ref":"remove_warning_4","sha":"f4de2c532a4daafa6feb6b268e4d248e6da0f241","user":{"login":"braibant","id":621053,"avatar_url":"https://avatars.githubusercontent.com/u/621053?v=3","gravatar_id":"","url":"https://api.github.com/users/braibant","html_url":"https://github.com/braibant","followers_url":"https://api.github.com/users/braibant/followers","following_url":"https://api.github.com/users/braibant/following{/other_user}","gists_url":"https://api.github.com/users/braibant/gists{/gist_id}","starred_url":"https://api.github.com/users/braibant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braibant/subscriptions","organizations_url":"https://api.github.com/users/braibant/orgs","repos_url":"https://api.github.com/users/braibant/repos","events_url":"https://api.github.com/users/braibant/events{/privacy}","received_events_url":"https://api.github.com/users/braibant/received_events","type":"User","site_admin":false},"repo":{"id":34846896,"name":"ppx_deriving","full_name":"braibant/ppx_deriving","owner":{"login":"braibant","id":621053,"avatar_url":"https://avatars.githubusercontent.com/u/621053?v=3","gravatar_id":"","url":"https://api.github.com/users/braibant","html_url":"https://github.com/braibant","followers_url":"https://api.github.com/users/braibant/followers","following_url":"https://api.github.com/users/braibant/following{/other_user}","gists_url":"https://api.github.com/users/braibant/gists{/gist_id}","starred_url":"https://api.github.com/users/braibant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braibant/subscriptions","organizations_url":"https://api.github.com/users/braibant/orgs","repos_url":"https://api.github.com/users/braibant/repos","events_url":"https://api.github.com/users/braibant/events{/privacy}","received_events_url":"https://api.github.com/users/braibant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/braibant/ppx_deriving","description":"Type-driven code generation for OCaml >=4.02","fork":true,"url":"https://api.github.com/repos/braibant/ppx_deriving","forks_url":"https://api.github.com/repos/braibant/ppx_deriving/forks","keys_url":"https://api.github.com/repos/braibant/ppx_deriving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/braibant/ppx_deriving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/braibant/ppx_deriving/teams","hooks_url":"https://api.github.com/repos/braibant/ppx_deriving/hooks","issue_events_url":"https://api.github.com/repos/braibant/ppx_deriving/issues/events{/number}","events_url":"https://api.github.com/repos/braibant/ppx_deriving/events","assignees_url":"https://api.github.com/repos/braibant/ppx_deriving/assignees{/user}","branches_url":"https://api.github.com/repos/braibant/ppx_deriving/branches{/branch}","tags_url":"https://api.github.com/repos/braibant/ppx_deriving/tags","blobs_url":"https://api.github.com/repos/braibant/ppx_deriving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/braibant/ppx_deriving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/braibant/ppx_deriving/git/refs{/sha}","trees_url":"https://api.github.com/repos/braibant/ppx_deriving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/braibant/ppx_deriving/statuses/{sha}","languages_url":"https://api.github.com/repos/braibant/ppx_deriving/languages","stargazers_url":"https://api.github.com/repos/braibant/ppx_deriving/stargazers","contributors_url":"https://api.github.com/repos/braibant/ppx_deriving/contributors","subscribers_url":"https://api.github.com/repos/braibant/ppx_deriving/subscribers","subscription_url":"https://api.github.com/repos/braibant/ppx_deriving/subscription","commits_url":"https://api.github.com/repos/braibant/ppx_deriving/commits{/sha}","git_commits_url":"https://api.github.com/repos/braibant/ppx_deriving/git/commits{/sha}","comments_url":"https://api.github.com/repos/braibant/ppx_deriving/comments{/number}","issue_comment_url":"https://api.github.com/repos/braibant/ppx_deriving/issues/comments{/number}","contents_url":"https://api.github.com/repos/braibant/ppx_deriving/contents/{+path}","compare_url":"https://api.github.com/repos/braibant/ppx_deriving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/braibant/ppx_deriving/merges","archive_url":"https://api.github.com/repos/braibant/ppx_deriving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/braibant/ppx_deriving/downloads","issues_url":"https://api.github.com/repos/braibant/ppx_deriving/issues{/number}","pulls_url":"https://api.github.com/repos/braibant/ppx_deriving/pulls{/number}","milestones_url":"https://api.github.com/repos/braibant/ppx_deriving/milestones{/number}","notifications_url":"https://api.github.com/repos/braibant/ppx_deriving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/braibant/ppx_deriving/labels{/name}","releases_url":"https://api.github.com/repos/braibant/ppx_deriving/releases{/id}","created_at":"2015-04-30T09:42:59Z","updated_at":"2015-04-30T09:42:59Z","pushed_at":"2015-04-30T09:49:25Z","git_url":"git://github.com/braibant/ppx_deriving.git","ssh_url":"git@github.com:braibant/ppx_deriving.git","clone_url":"https://github.com/braibant/ppx_deriving.git","svn_url":"https://github.com/braibant/ppx_deriving","homepage":"","size":377,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whitequark:master","ref":"master","sha":"5317e92ea2cb1dba9a9ed73a3e3e8ab9d8ebc19b","user":{"login":"whitequark","id":54771,"avatar_url":"https://avatars.githubusercontent.com/u/54771?v=3","gravatar_id":"","url":"https://api.github.com/users/whitequark","html_url":"https://github.com/whitequark","followers_url":"https://api.github.com/users/whitequark/followers","following_url":"https://api.github.com/users/whitequark/following{/other_user}","gists_url":"https://api.github.com/users/whitequark/gists{/gist_id}","starred_url":"https://api.github.com/users/whitequark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitequark/subscriptions","organizations_url":"https://api.github.com/users/whitequark/orgs","repos_url":"https://api.github.com/users/whitequark/repos","events_url":"https://api.github.com/users/whitequark/events{/privacy}","received_events_url":"https://api.github.com/users/whitequark/received_events","type":"User","site_admin":false},"repo":{"id":21903854,"name":"ppx_deriving","full_name":"whitequark/ppx_deriving","owner":{"login":"whitequark","id":54771,"avatar_url":"https://avatars.githubusercontent.com/u/54771?v=3","gravatar_id":"","url":"https://api.github.com/users/whitequark","html_url":"https://github.com/whitequark","followers_url":"https://api.github.com/users/whitequark/followers","following_url":"https://api.github.com/users/whitequark/following{/other_user}","gists_url":"https://api.github.com/users/whitequark/gists{/gist_id}","starred_url":"https://api.github.com/users/whitequark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitequark/subscriptions","organizations_url":"https://api.github.com/users/whitequark/orgs","repos_url":"https://api.github.com/users/whitequark/repos","events_url":"https://api.github.com/users/whitequark/events{/privacy}","received_events_url":"https://api.github.com/users/whitequark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whitequark/ppx_deriving","description":"Type-driven code generation for OCaml >=4.02","fork":false,"url":"https://api.github.com/repos/whitequark/ppx_deriving","forks_url":"https://api.github.com/repos/whitequark/ppx_deriving/forks","keys_url":"https://api.github.com/repos/whitequark/ppx_deriving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whitequark/ppx_deriving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whitequark/ppx_deriving/teams","hooks_url":"https://api.github.com/repos/whitequark/ppx_deriving/hooks","issue_events_url":"https://api.github.com/repos/whitequark/ppx_deriving/issues/events{/number}","events_url":"https://api.github.com/repos/whitequark/ppx_deriving/events","assignees_url":"https://api.github.com/repos/whitequark/ppx_deriving/assignees{/user}","branches_url":"https://api.github.com/repos/whitequark/ppx_deriving/branches{/branch}","tags_url":"https://api.github.com/repos/whitequark/ppx_deriving/tags","blobs_url":"https://api.github.com/repos/whitequark/ppx_deriving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whitequark/ppx_deriving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whitequark/ppx_deriving/git/refs{/sha}","trees_url":"https://api.github.com/repos/whitequark/ppx_deriving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whitequark/ppx_deriving/statuses/{sha}","languages_url":"https://api.github.com/repos/whitequark/ppx_deriving/languages","stargazers_url":"https://api.github.com/repos/whitequark/ppx_deriving/stargazers","contributors_url":"https://api.github.com/repos/whitequark/ppx_deriving/contributors","subscribers_url":"https://api.github.com/repos/whitequark/ppx_deriving/subscribers","subscription_url":"https://api.github.com/repos/whitequark/ppx_deriving/subscription","commits_url":"https://api.github.com/repos/whitequark/ppx_deriving/commits{/sha}","git_commits_url":"https://api.github.com/repos/whitequark/ppx_deriving/git/commits{/sha}","comments_url":"https://api.github.com/repos/whitequark/ppx_deriving/comments{/number}","issue_comment_url":"https://api.github.com/repos/whitequark/ppx_deriving/issues/comments{/number}","contents_url":"https://api.github.com/repos/whitequark/ppx_deriving/contents/{+path}","compare_url":"https://api.github.com/repos/whitequark/ppx_deriving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whitequark/ppx_deriving/merges","archive_url":"https://api.github.com/repos/whitequark/ppx_deriving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whitequark/ppx_deriving/downloads","issues_url":"https://api.github.com/repos/whitequark/ppx_deriving/issues{/number}","pulls_url":"https://api.github.com/repos/whitequark/ppx_deriving/pulls{/number}","milestones_url":"https://api.github.com/repos/whitequark/ppx_deriving/milestones{/number}","notifications_url":"https://api.github.com/repos/whitequark/ppx_deriving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whitequark/ppx_deriving/labels{/name}","releases_url":"https://api.github.com/repos/whitequark/ppx_deriving/releases{/id}","created_at":"2014-07-16T14:23:15Z","updated_at":"2015-04-22T21:34:14Z","pushed_at":"2015-04-30T09:56:55Z","git_url":"git://github.com/whitequark/ppx_deriving.git","ssh_url":"git@github.com:whitequark/ppx_deriving.git","clone_url":"https://github.com/whitequark/ppx_deriving.git","svn_url":"https://github.com/whitequark/ppx_deriving","homepage":"","size":1035,"stargazers_count":45,"watchers_count":45,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":13,"forks":12,"open_issues":13,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35"},"html":{"href":"https://github.com/whitequark/ppx_deriving/pull/35"},"issue":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/issues/35"},"comments":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/whitequark/ppx_deriving/statuses/f4de2c532a4daafa6feb6b268e4d248e6da0f241"}}}}