{"action":"created","comment":{"url":"https://api.github.com/repos/HazyResearch/deepdive/pulls/comments/37062429","id":37062429,"diff_hunk":"@@ -1,253 +1,536 @@\n package org.deepdive.settings","path":"src/main/scala/org/deepdive/settings/SettingsParser.scala","position":1,"original_position":1,"commit_id":"243899588acf15fce921ff85bb7481708a1e73d3","original_commit_id":"243899588acf15fce921ff85bb7481708a1e73d3","user":{"login":"feiranwang","id":5935656,"avatar_url":"https://avatars.githubusercontent.com/u/5935656?v=3","gravatar_id":"","url":"https://api.github.com/users/feiranwang","html_url":"https://github.com/feiranwang","followers_url":"https://api.github.com/users/feiranwang/followers","following_url":"https://api.github.com/users/feiranwang/following{/other_user}","gists_url":"https://api.github.com/users/feiranwang/gists{/gist_id}","starred_url":"https://api.github.com/users/feiranwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiranwang/subscriptions","organizations_url":"https://api.github.com/users/feiranwang/orgs","repos_url":"https://api.github.com/users/feiranwang/repos","events_url":"https://api.github.com/users/feiranwang/events{/privacy}","received_events_url":"https://api.github.com/users/feiranwang/received_events","type":"User","site_admin":false},"body":"Is it better to combine the settings in one file or in separate files? It seems after combining, this file is getting big and comprehensive.","created_at":"2015-08-14T09:39:15Z","updated_at":"2015-08-14T09:39:15Z","html_url":"https://github.com/HazyResearch/deepdive/pull/353#discussion_r37062429","pull_request_url":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/HazyResearch/deepdive/pulls/comments/37062429"},"html":{"href":"https://github.com/HazyResearch/deepdive/pull/353#discussion_r37062429"},"pull_request":{"href":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353","id":42215571,"html_url":"https://github.com/HazyResearch/deepdive/pull/353","diff_url":"https://github.com/HazyResearch/deepdive/pull/353.diff","patch_url":"https://github.com/HazyResearch/deepdive/pull/353.patch","issue_url":"https://api.github.com/repos/HazyResearch/deepdive/issues/353","number":353,"state":"open","locked":false,"title":"Refactored Scala code for settings","user":{"login":"netj","id":53634,"avatar_url":"https://avatars.githubusercontent.com/u/53634?v=3","gravatar_id":"","url":"https://api.github.com/users/netj","html_url":"https://github.com/netj","followers_url":"https://api.github.com/users/netj/followers","following_url":"https://api.github.com/users/netj/following{/other_user}","gists_url":"https://api.github.com/users/netj/gists{/gist_id}","starred_url":"https://api.github.com/users/netj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netj/subscriptions","organizations_url":"https://api.github.com/users/netj/orgs","repos_url":"https://api.github.com/users/netj/repos","events_url":"https://api.github.com/users/netj/events{/privacy}","received_events_url":"https://api.github.com/users/netj/received_events","type":"User","site_admin":false},"body":"- Uses named arguments syntax in constructors.\r\n- Uses `.copy()` with named arguments when possible.\r\n- Splits unit tests into individual .bats files, so each can be run/excluded selectively.\r\n\r\n(Part of #329) ","created_at":"2015-08-12T08:31:23Z","updated_at":"2015-08-14T09:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a23df87a587ac6f22268972974734a903e3bc84b","assignee":{"login":"feiranwang","id":5935656,"avatar_url":"https://avatars.githubusercontent.com/u/5935656?v=3","gravatar_id":"","url":"https://api.github.com/users/feiranwang","html_url":"https://github.com/feiranwang","followers_url":"https://api.github.com/users/feiranwang/followers","following_url":"https://api.github.com/users/feiranwang/following{/other_user}","gists_url":"https://api.github.com/users/feiranwang/gists{/gist_id}","starred_url":"https://api.github.com/users/feiranwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiranwang/subscriptions","organizations_url":"https://api.github.com/users/feiranwang/orgs","repos_url":"https://api.github.com/users/feiranwang/repos","events_url":"https://api.github.com/users/feiranwang/events{/privacy}","received_events_url":"https://api.github.com/users/feiranwang/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353/commits","review_comments_url":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353/comments","review_comment_url":"https://api.github.com/repos/HazyResearch/deepdive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HazyResearch/deepdive/issues/353/comments","statuses_url":"https://api.github.com/repos/HazyResearch/deepdive/statuses/243899588acf15fce921ff85bb7481708a1e73d3","head":{"label":"HazyResearch:simplify-settings","ref":"simplify-settings","sha":"243899588acf15fce921ff85bb7481708a1e73d3","user":{"login":"HazyResearch","id":2165246,"avatar_url":"https://avatars.githubusercontent.com/u/2165246?v=3","gravatar_id":"","url":"https://api.github.com/users/HazyResearch","html_url":"https://github.com/HazyResearch","followers_url":"https://api.github.com/users/HazyResearch/followers","following_url":"https://api.github.com/users/HazyResearch/following{/other_user}","gists_url":"https://api.github.com/users/HazyResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/HazyResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HazyResearch/subscriptions","organizations_url":"https://api.github.com/users/HazyResearch/orgs","repos_url":"https://api.github.com/users/HazyResearch/repos","events_url":"https://api.github.com/users/HazyResearch/events{/privacy}","received_events_url":"https://api.github.com/users/HazyResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":17907002,"name":"deepdive","full_name":"HazyResearch/deepdive","owner":{"login":"HazyResearch","id":2165246,"avatar_url":"https://avatars.githubusercontent.com/u/2165246?v=3","gravatar_id":"","url":"https://api.github.com/users/HazyResearch","html_url":"https://github.com/HazyResearch","followers_url":"https://api.github.com/users/HazyResearch/followers","following_url":"https://api.github.com/users/HazyResearch/following{/other_user}","gists_url":"https://api.github.com/users/HazyResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/HazyResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HazyResearch/subscriptions","organizations_url":"https://api.github.com/users/HazyResearch/orgs","repos_url":"https://api.github.com/users/HazyResearch/repos","events_url":"https://api.github.com/users/HazyResearch/events{/privacy}","received_events_url":"https://api.github.com/users/HazyResearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HazyResearch/deepdive","description":"DeepDive","fork":false,"url":"https://api.github.com/repos/HazyResearch/deepdive","forks_url":"https://api.github.com/repos/HazyResearch/deepdive/forks","keys_url":"https://api.github.com/repos/HazyResearch/deepdive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HazyResearch/deepdive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HazyResearch/deepdive/teams","hooks_url":"https://api.github.com/repos/HazyResearch/deepdive/hooks","issue_events_url":"https://api.github.com/repos/HazyResearch/deepdive/issues/events{/number}","events_url":"https://api.github.com/repos/HazyResearch/deepdive/events","assignees_url":"https://api.github.com/repos/HazyResearch/deepdive/assignees{/user}","branches_url":"https://api.github.com/repos/HazyResearch/deepdive/branches{/branch}","tags_url":"https://api.github.com/repos/HazyResearch/deepdive/tags","blobs_url":"https://api.github.com/repos/HazyResearch/deepdive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HazyResearch/deepdive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HazyResearch/deepdive/git/refs{/sha}","trees_url":"https://api.github.com/repos/HazyResearch/deepdive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HazyResearch/deepdive/statuses/{sha}","languages_url":"https://api.github.com/repos/HazyResearch/deepdive/languages","stargazers_url":"https://api.github.com/repos/HazyResearch/deepdive/stargazers","contributors_url":"https://api.github.com/repos/HazyResearch/deepdive/contributors","subscribers_url":"https://api.github.com/repos/HazyResearch/deepdive/subscribers","subscription_url":"https://api.github.com/repos/HazyResearch/deepdive/subscription","commits_url":"https://api.github.com/repos/HazyResearch/deepdive/commits{/sha}","git_commits_url":"https://api.github.com/repos/HazyResearch/deepdive/git/commits{/sha}","comments_url":"https://api.github.com/repos/HazyResearch/deepdive/comments{/number}","issue_comment_url":"https://api.github.com/repos/HazyResearch/deepdive/issues/comments{/number}","contents_url":"https://api.github.com/repos/HazyResearch/deepdive/contents/{+path}","compare_url":"https://api.github.com/repos/HazyResearch/deepdive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HazyResearch/deepdive/merges","archive_url":"https://api.github.com/repos/HazyResearch/deepdive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HazyResearch/deepdive/downloads","issues_url":"https://api.github.com/repos/HazyResearch/deepdive/issues{/number}","pulls_url":"https://api.github.com/repos/HazyResearch/deepdive/pulls{/number}","milestones_url":"https://api.github.com/repos/HazyResearch/deepdive/milestones{/number}","notifications_url":"https://api.github.com/repos/HazyResearch/deepdive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HazyResearch/deepdive/labels{/name}","releases_url":"https://api.github.com/repos/HazyResearch/deepdive/releases{/id}","created_at":"2014-03-19T14:23:50Z","updated_at":"2015-08-12T14:37:54Z","pushed_at":"2015-08-14T09:23:18Z","git_url":"git://github.com/HazyResearch/deepdive.git","ssh_url":"git@github.com:HazyResearch/deepdive.git","clone_url":"https://github.com/HazyResearch/deepdive.git","svn_url":"https://github.com/HazyResearch/deepdive","homepage":"deepdive.stanford.edu","size":403852,"stargazers_count":552,"watchers_count":552,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":42,"forks":139,"open_issues":42,"watchers":552,"default_branch":"master"}},"base":{"label":"HazyResearch:master","ref":"master","sha":"05dc067a5f29cfdf77d7530fa09e93bea94579c2","user":{"login":"HazyResearch","id":2165246,"avatar_url":"https://avatars.githubusercontent.com/u/2165246?v=3","gravatar_id":"","url":"https://api.github.com/users/HazyResearch","html_url":"https://github.com/HazyResearch","followers_url":"https://api.github.com/users/HazyResearch/followers","following_url":"https://api.github.com/users/HazyResearch/following{/other_user}","gists_url":"https://api.github.com/users/HazyResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/HazyResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HazyResearch/subscriptions","organizations_url":"https://api.github.com/users/HazyResearch/orgs","repos_url":"https://api.github.com/users/HazyResearch/repos","events_url":"https://api.github.com/users/HazyResearch/events{/privacy}","received_events_url":"https://api.github.com/users/HazyResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":17907002,"name":"deepdive","full_name":"HazyResearch/deepdive","owner":{"login":"HazyResearch","id":2165246,"avatar_url":"https://avatars.githubusercontent.com/u/2165246?v=3","gravatar_id":"","url":"https://api.github.com/users/HazyResearch","html_url":"https://github.com/HazyResearch","followers_url":"https://api.github.com/users/HazyResearch/followers","following_url":"https://api.github.com/users/HazyResearch/following{/other_user}","gists_url":"https://api.github.com/users/HazyResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/HazyResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HazyResearch/subscriptions","organizations_url":"https://api.github.com/users/HazyResearch/orgs","repos_url":"https://api.github.com/users/HazyResearch/repos","events_url":"https://api.github.com/users/HazyResearch/events{/privacy}","received_events_url":"https://api.github.com/users/HazyResearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HazyResearch/deepdive","description":"DeepDive","fork":false,"url":"https://api.github.com/repos/HazyResearch/deepdive","forks_url":"https://api.github.com/repos/HazyResearch/deepdive/forks","keys_url":"https://api.github.com/repos/HazyResearch/deepdive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HazyResearch/deepdive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HazyResearch/deepdive/teams","hooks_url":"https://api.github.com/repos/HazyResearch/deepdive/hooks","issue_events_url":"https://api.github.com/repos/HazyResearch/deepdive/issues/events{/number}","events_url":"https://api.github.com/repos/HazyResearch/deepdive/events","assignees_url":"https://api.github.com/repos/HazyResearch/deepdive/assignees{/user}","branches_url":"https://api.github.com/repos/HazyResearch/deepdive/branches{/branch}","tags_url":"https://api.github.com/repos/HazyResearch/deepdive/tags","blobs_url":"https://api.github.com/repos/HazyResearch/deepdive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HazyResearch/deepdive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HazyResearch/deepdive/git/refs{/sha}","trees_url":"https://api.github.com/repos/HazyResearch/deepdive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HazyResearch/deepdive/statuses/{sha}","languages_url":"https://api.github.com/repos/HazyResearch/deepdive/languages","stargazers_url":"https://api.github.com/repos/HazyResearch/deepdive/stargazers","contributors_url":"https://api.github.com/repos/HazyResearch/deepdive/contributors","subscribers_url":"https://api.github.com/repos/HazyResearch/deepdive/subscribers","subscription_url":"https://api.github.com/repos/HazyResearch/deepdive/subscription","commits_url":"https://api.github.com/repos/HazyResearch/deepdive/commits{/sha}","git_commits_url":"https://api.github.com/repos/HazyResearch/deepdive/git/commits{/sha}","comments_url":"https://api.github.com/repos/HazyResearch/deepdive/comments{/number}","issue_comment_url":"https://api.github.com/repos/HazyResearch/deepdive/issues/comments{/number}","contents_url":"https://api.github.com/repos/HazyResearch/deepdive/contents/{+path}","compare_url":"https://api.github.com/repos/HazyResearch/deepdive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HazyResearch/deepdive/merges","archive_url":"https://api.github.com/repos/HazyResearch/deepdive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HazyResearch/deepdive/downloads","issues_url":"https://api.github.com/repos/HazyResearch/deepdive/issues{/number}","pulls_url":"https://api.github.com/repos/HazyResearch/deepdive/pulls{/number}","milestones_url":"https://api.github.com/repos/HazyResearch/deepdive/milestones{/number}","notifications_url":"https://api.github.com/repos/HazyResearch/deepdive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HazyResearch/deepdive/labels{/name}","releases_url":"https://api.github.com/repos/HazyResearch/deepdive/releases{/id}","created_at":"2014-03-19T14:23:50Z","updated_at":"2015-08-12T14:37:54Z","pushed_at":"2015-08-14T09:23:18Z","git_url":"git://github.com/HazyResearch/deepdive.git","ssh_url":"git@github.com:HazyResearch/deepdive.git","clone_url":"https://github.com/HazyResearch/deepdive.git","svn_url":"https://github.com/HazyResearch/deepdive","homepage":"deepdive.stanford.edu","size":403852,"stargazers_count":552,"watchers_count":552,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":42,"forks":139,"open_issues":42,"watchers":552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353"},"html":{"href":"https://github.com/HazyResearch/deepdive/pull/353"},"issue":{"href":"https://api.github.com/repos/HazyResearch/deepdive/issues/353"},"comments":{"href":"https://api.github.com/repos/HazyResearch/deepdive/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/HazyResearch/deepdive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HazyResearch/deepdive/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/HazyResearch/deepdive/statuses/243899588acf15fce921ff85bb7481708a1e73d3"}}}}