{"action":"reopened","number":5323,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5323","id":52221618,"html_url":"https://github.com/playframework/playframework/pull/5323","diff_url":"https://github.com/playframework/playframework/pull/5323.diff","patch_url":"https://github.com/playframework/playframework/pull/5323.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5323","number":5323,"state":"open","locked":false,"title":"Remove code deprecated in 2.4 (Fixes #5309)","user":{"login":"gsmaverick","id":59155,"avatar_url":"https://avatars.githubusercontent.com/u/59155?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmaverick","html_url":"https://github.com/gsmaverick","followers_url":"https://api.github.com/users/gsmaverick/followers","following_url":"https://api.github.com/users/gsmaverick/following{/other_user}","gists_url":"https://api.github.com/users/gsmaverick/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmaverick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmaverick/subscriptions","organizations_url":"https://api.github.com/users/gsmaverick/orgs","repos_url":"https://api.github.com/users/gsmaverick/repos","events_url":"https://api.github.com/users/gsmaverick/events{/privacy}","received_events_url":"https://api.github.com/users/gsmaverick/received_events","type":"User","site_admin":false},"body":"Removed all the 2.4 deprecated pieces that didn't require much code to be reworked/could be easily removed. The few remaining pieces are somewhat more challenging specifically [Application#routes](https://github.com/playframework/playframework/blob/master/framework/src/play/src/main/scala/play/api/Application.scala#L115) and [Plugins](https://github.com/playframework/playframework/blob/master/framework/src/play/src/main/scala/play/api/Plugins.scala) are still used in non-trivial ways by other parts of the system. I'd be open to any advice about what to do with those.","created_at":"2015-12-01T06:40:49Z","updated_at":"2015-12-10T00:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab7ebafc3380132af2bb8246523de75e9f998889","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/5323/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/5323/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5323/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/74ef0c40613bdc22e3af190999b17ac78b56c5c5","head":{"label":"gsmaverick:remove-2-4-deprecated-code","ref":"remove-2-4-deprecated-code","sha":"74ef0c40613bdc22e3af190999b17ac78b56c5c5","user":{"login":"gsmaverick","id":59155,"avatar_url":"https://avatars.githubusercontent.com/u/59155?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmaverick","html_url":"https://github.com/gsmaverick","followers_url":"https://api.github.com/users/gsmaverick/followers","following_url":"https://api.github.com/users/gsmaverick/following{/other_user}","gists_url":"https://api.github.com/users/gsmaverick/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmaverick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmaverick/subscriptions","organizations_url":"https://api.github.com/users/gsmaverick/orgs","repos_url":"https://api.github.com/users/gsmaverick/repos","events_url":"https://api.github.com/users/gsmaverick/events{/privacy}","received_events_url":"https://api.github.com/users/gsmaverick/received_events","type":"User","site_admin":false},"repo":{"id":46337130,"name":"playframework","full_name":"gsmaverick/playframework","owner":{"login":"gsmaverick","id":59155,"avatar_url":"https://avatars.githubusercontent.com/u/59155?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmaverick","html_url":"https://github.com/gsmaverick","followers_url":"https://api.github.com/users/gsmaverick/followers","following_url":"https://api.github.com/users/gsmaverick/following{/other_user}","gists_url":"https://api.github.com/users/gsmaverick/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmaverick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmaverick/subscriptions","organizations_url":"https://api.github.com/users/gsmaverick/orgs","repos_url":"https://api.github.com/users/gsmaverick/repos","events_url":"https://api.github.com/users/gsmaverick/events{/privacy}","received_events_url":"https://api.github.com/users/gsmaverick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsmaverick/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/gsmaverick/playframework","forks_url":"https://api.github.com/repos/gsmaverick/playframework/forks","keys_url":"https://api.github.com/repos/gsmaverick/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsmaverick/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsmaverick/playframework/teams","hooks_url":"https://api.github.com/repos/gsmaverick/playframework/hooks","issue_events_url":"https://api.github.com/repos/gsmaverick/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/gsmaverick/playframework/events","assignees_url":"https://api.github.com/repos/gsmaverick/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/gsmaverick/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/gsmaverick/playframework/tags","blobs_url":"https://api.github.com/repos/gsmaverick/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsmaverick/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsmaverick/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsmaverick/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsmaverick/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/gsmaverick/playframework/languages","stargazers_url":"https://api.github.com/repos/gsmaverick/playframework/stargazers","contributors_url":"https://api.github.com/repos/gsmaverick/playframework/contributors","subscribers_url":"https://api.github.com/repos/gsmaverick/playframework/subscribers","subscription_url":"https://api.github.com/repos/gsmaverick/playframework/subscription","commits_url":"https://api.github.com/repos/gsmaverick/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsmaverick/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsmaverick/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsmaverick/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsmaverick/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/gsmaverick/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsmaverick/playframework/merges","archive_url":"https://api.github.com/repos/gsmaverick/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsmaverick/playframework/downloads","issues_url":"https://api.github.com/repos/gsmaverick/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/gsmaverick/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/gsmaverick/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/gsmaverick/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsmaverick/playframework/labels{/name}","releases_url":"https://api.github.com/repos/gsmaverick/playframework/releases{/id}","created_at":"2015-11-17T09:36:09Z","updated_at":"2015-11-17T09:36:17Z","pushed_at":"2015-12-09T06:43:12Z","git_url":"git://github.com/gsmaverick/playframework.git","ssh_url":"git@github.com:gsmaverick/playframework.git","clone_url":"https://github.com/gsmaverick/playframework.git","svn_url":"https://github.com/gsmaverick/playframework","homepage":"http://www.playframework.com/","size":77450,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"d9ace62e5e914a754c8e95523bd45a2d88143a1d","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-12-09T19:18:44Z","pushed_at":"2015-12-10T00:42:11Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":83820,"stargazers_count":7161,"watchers_count":7161,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2531,"mirror_url":null,"open_issues_count":316,"forks":2531,"open_issues":316,"watchers":7161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5323"},"html":{"href":"https://github.com/playframework/playframework/pull/5323"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/5323"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/5323/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5323/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5323/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/74ef0c40613bdc22e3af190999b17ac78b56c5c5"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":6,"commits":1,"additions":9,"deletions":135,"changed_files":16}}