{"action":"created","comment":{"url":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments/30055498","id":30055498,"diff_hunk":"@@ -2092,11 +2092,13 @@\n                 var record = this.get(changes[c].recid);\n                 for (var s in changes[c]) {\n                     if (s == 'recid') continue; // do not allow to change recid\n-                    var key = \".\" + s;\n-                    if (w2utils.isFloat(s)) key = \"['\" + s + \"']\";\n-                    if (String(s).indexOf(\"'\") != -1) key = \"['\" + s.replace(/'/g, \"\\\\'\") + \"']\";\n+                    if(typeof changes[c][s] === \"object\") changes[c][s] = changes[c][s].text;","path":"src/w2grid.js","position":7,"original_position":7,"commit_id":"0ee5e54217e8cfd2603eae3cda1275834750e3c7","original_commit_id":"0ee5e54217e8cfd2603eae3cda1275834750e3c7","user":{"login":"vitmalina","id":561995,"avatar_url":"https://avatars.githubusercontent.com/u/561995?v=3","gravatar_id":"","url":"https://api.github.com/users/vitmalina","html_url":"https://github.com/vitmalina","followers_url":"https://api.github.com/users/vitmalina/followers","following_url":"https://api.github.com/users/vitmalina/following{/other_user}","gists_url":"https://api.github.com/users/vitmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/vitmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitmalina/subscriptions","organizations_url":"https://api.github.com/users/vitmalina/orgs","repos_url":"https://api.github.com/users/vitmalina/repos","events_url":"https://api.github.com/users/vitmalina/events{/privacy}","received_events_url":"https://api.github.com/users/vitmalina/received_events","type":"User","site_admin":false},"body":"need space after if and before (. See https://github.com/vitmalina/w2ui/wiki/Contribution-Requirement","created_at":"2015-05-11T16:30:11Z","updated_at":"2015-05-11T16:30:11Z","html_url":"https://github.com/vitmalina/w2ui/pull/884#discussion_r30055498","pull_request_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/884","_links":{"self":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments/30055498"},"html":{"href":"https://github.com/vitmalina/w2ui/pull/884#discussion_r30055498"},"pull_request":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/884"}}},"pull_request":{"url":"https://api.github.com/repos/vitmalina/w2ui/pulls/884","id":34718154,"html_url":"https://github.com/vitmalina/w2ui/pull/884","diff_url":"https://github.com/vitmalina/w2ui/pull/884.diff","patch_url":"https://github.com/vitmalina/w2ui/pull/884.patch","issue_url":"https://api.github.com/repos/vitmalina/w2ui/issues/884","number":884,"state":"open","locked":false,"title":"mergeChanges update","user":{"login":"githabas","id":8754259,"avatar_url":"https://avatars.githubusercontent.com/u/8754259?v=3","gravatar_id":"","url":"https://api.github.com/users/githabas","html_url":"https://github.com/githabas","followers_url":"https://api.github.com/users/githabas/followers","following_url":"https://api.github.com/users/githabas/following{/other_user}","gists_url":"https://api.github.com/users/githabas/gists{/gist_id}","starred_url":"https://api.github.com/users/githabas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/githabas/subscriptions","organizations_url":"https://api.github.com/users/githabas/orgs","repos_url":"https://api.github.com/users/githabas/repos","events_url":"https://api.github.com/users/githabas/events{/privacy}","received_events_url":"https://api.github.com/users/githabas/received_events","type":"User","site_admin":false},"body":"It fixes two issues described in https://github.com/vitmalina/w2ui/issues/879","created_at":"2015-05-05T12:12:42Z","updated_at":"2015-05-11T16:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd123a3a64c1d63ffedd8ef0632dd5dc58f61a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/884/commits","review_comments_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/884/comments","review_comment_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitmalina/w2ui/issues/884/comments","statuses_url":"https://api.github.com/repos/vitmalina/w2ui/statuses/0ee5e54217e8cfd2603eae3cda1275834750e3c7","head":{"label":"githabas:master","ref":"master","sha":"0ee5e54217e8cfd2603eae3cda1275834750e3c7","user":{"login":"githabas","id":8754259,"avatar_url":"https://avatars.githubusercontent.com/u/8754259?v=3","gravatar_id":"","url":"https://api.github.com/users/githabas","html_url":"https://github.com/githabas","followers_url":"https://api.github.com/users/githabas/followers","following_url":"https://api.github.com/users/githabas/following{/other_user}","gists_url":"https://api.github.com/users/githabas/gists{/gist_id}","starred_url":"https://api.github.com/users/githabas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/githabas/subscriptions","organizations_url":"https://api.github.com/users/githabas/orgs","repos_url":"https://api.github.com/users/githabas/repos","events_url":"https://api.github.com/users/githabas/events{/privacy}","received_events_url":"https://api.github.com/users/githabas/received_events","type":"User","site_admin":false},"repo":{"id":35096133,"name":"w2ui","full_name":"githabas/w2ui","owner":{"login":"githabas","id":8754259,"avatar_url":"https://avatars.githubusercontent.com/u/8754259?v=3","gravatar_id":"","url":"https://api.github.com/users/githabas","html_url":"https://github.com/githabas","followers_url":"https://api.github.com/users/githabas/followers","following_url":"https://api.github.com/users/githabas/following{/other_user}","gists_url":"https://api.github.com/users/githabas/gists{/gist_id}","starred_url":"https://api.github.com/users/githabas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/githabas/subscriptions","organizations_url":"https://api.github.com/users/githabas/orgs","repos_url":"https://api.github.com/users/githabas/repos","events_url":"https://api.github.com/users/githabas/events{/privacy}","received_events_url":"https://api.github.com/users/githabas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/githabas/w2ui","description":"JavaScript UI library for data-driven web applications","fork":true,"url":"https://api.github.com/repos/githabas/w2ui","forks_url":"https://api.github.com/repos/githabas/w2ui/forks","keys_url":"https://api.github.com/repos/githabas/w2ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/githabas/w2ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/githabas/w2ui/teams","hooks_url":"https://api.github.com/repos/githabas/w2ui/hooks","issue_events_url":"https://api.github.com/repos/githabas/w2ui/issues/events{/number}","events_url":"https://api.github.com/repos/githabas/w2ui/events","assignees_url":"https://api.github.com/repos/githabas/w2ui/assignees{/user}","branches_url":"https://api.github.com/repos/githabas/w2ui/branches{/branch}","tags_url":"https://api.github.com/repos/githabas/w2ui/tags","blobs_url":"https://api.github.com/repos/githabas/w2ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/githabas/w2ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/githabas/w2ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/githabas/w2ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/githabas/w2ui/statuses/{sha}","languages_url":"https://api.github.com/repos/githabas/w2ui/languages","stargazers_url":"https://api.github.com/repos/githabas/w2ui/stargazers","contributors_url":"https://api.github.com/repos/githabas/w2ui/contributors","subscribers_url":"https://api.github.com/repos/githabas/w2ui/subscribers","subscription_url":"https://api.github.com/repos/githabas/w2ui/subscription","commits_url":"https://api.github.com/repos/githabas/w2ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/githabas/w2ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/githabas/w2ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/githabas/w2ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/githabas/w2ui/contents/{+path}","compare_url":"https://api.github.com/repos/githabas/w2ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/githabas/w2ui/merges","archive_url":"https://api.github.com/repos/githabas/w2ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/githabas/w2ui/downloads","issues_url":"https://api.github.com/repos/githabas/w2ui/issues{/number}","pulls_url":"https://api.github.com/repos/githabas/w2ui/pulls{/number}","milestones_url":"https://api.github.com/repos/githabas/w2ui/milestones{/number}","notifications_url":"https://api.github.com/repos/githabas/w2ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/githabas/w2ui/labels{/name}","releases_url":"https://api.github.com/repos/githabas/w2ui/releases{/id}","created_at":"2015-05-05T11:49:34Z","updated_at":"2015-05-05T12:06:02Z","pushed_at":"2015-05-05T12:06:02Z","git_url":"git://github.com/githabas/w2ui.git","ssh_url":"git@github.com:githabas/w2ui.git","clone_url":"https://github.com/githabas/w2ui.git","svn_url":"https://github.com/githabas/w2ui","homepage":"http://w2ui.com","size":17837,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vitmalina:master","ref":"master","sha":"38b0ce88831f4135007e11dbefde72b86c464df8","user":{"login":"vitmalina","id":561995,"avatar_url":"https://avatars.githubusercontent.com/u/561995?v=3","gravatar_id":"","url":"https://api.github.com/users/vitmalina","html_url":"https://github.com/vitmalina","followers_url":"https://api.github.com/users/vitmalina/followers","following_url":"https://api.github.com/users/vitmalina/following{/other_user}","gists_url":"https://api.github.com/users/vitmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/vitmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitmalina/subscriptions","organizations_url":"https://api.github.com/users/vitmalina/orgs","repos_url":"https://api.github.com/users/vitmalina/repos","events_url":"https://api.github.com/users/vitmalina/events{/privacy}","received_events_url":"https://api.github.com/users/vitmalina/received_events","type":"User","site_admin":false},"repo":{"id":1604375,"name":"w2ui","full_name":"vitmalina/w2ui","owner":{"login":"vitmalina","id":561995,"avatar_url":"https://avatars.githubusercontent.com/u/561995?v=3","gravatar_id":"","url":"https://api.github.com/users/vitmalina","html_url":"https://github.com/vitmalina","followers_url":"https://api.github.com/users/vitmalina/followers","following_url":"https://api.github.com/users/vitmalina/following{/other_user}","gists_url":"https://api.github.com/users/vitmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/vitmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitmalina/subscriptions","organizations_url":"https://api.github.com/users/vitmalina/orgs","repos_url":"https://api.github.com/users/vitmalina/repos","events_url":"https://api.github.com/users/vitmalina/events{/privacy}","received_events_url":"https://api.github.com/users/vitmalina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitmalina/w2ui","description":"JavaScript UI library for data-driven web applications","fork":false,"url":"https://api.github.com/repos/vitmalina/w2ui","forks_url":"https://api.github.com/repos/vitmalina/w2ui/forks","keys_url":"https://api.github.com/repos/vitmalina/w2ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitmalina/w2ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitmalina/w2ui/teams","hooks_url":"https://api.github.com/repos/vitmalina/w2ui/hooks","issue_events_url":"https://api.github.com/repos/vitmalina/w2ui/issues/events{/number}","events_url":"https://api.github.com/repos/vitmalina/w2ui/events","assignees_url":"https://api.github.com/repos/vitmalina/w2ui/assignees{/user}","branches_url":"https://api.github.com/repos/vitmalina/w2ui/branches{/branch}","tags_url":"https://api.github.com/repos/vitmalina/w2ui/tags","blobs_url":"https://api.github.com/repos/vitmalina/w2ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitmalina/w2ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitmalina/w2ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitmalina/w2ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitmalina/w2ui/statuses/{sha}","languages_url":"https://api.github.com/repos/vitmalina/w2ui/languages","stargazers_url":"https://api.github.com/repos/vitmalina/w2ui/stargazers","contributors_url":"https://api.github.com/repos/vitmalina/w2ui/contributors","subscribers_url":"https://api.github.com/repos/vitmalina/w2ui/subscribers","subscription_url":"https://api.github.com/repos/vitmalina/w2ui/subscription","commits_url":"https://api.github.com/repos/vitmalina/w2ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitmalina/w2ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitmalina/w2ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitmalina/w2ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitmalina/w2ui/contents/{+path}","compare_url":"https://api.github.com/repos/vitmalina/w2ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitmalina/w2ui/merges","archive_url":"https://api.github.com/repos/vitmalina/w2ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitmalina/w2ui/downloads","issues_url":"https://api.github.com/repos/vitmalina/w2ui/issues{/number}","pulls_url":"https://api.github.com/repos/vitmalina/w2ui/pulls{/number}","milestones_url":"https://api.github.com/repos/vitmalina/w2ui/milestones{/number}","notifications_url":"https://api.github.com/repos/vitmalina/w2ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitmalina/w2ui/labels{/name}","releases_url":"https://api.github.com/repos/vitmalina/w2ui/releases{/id}","created_at":"2011-04-12T14:26:20Z","updated_at":"2015-05-10T15:49:20Z","pushed_at":"2015-05-11T15:53:53Z","git_url":"git://github.com/vitmalina/w2ui.git","ssh_url":"git@github.com:vitmalina/w2ui.git","clone_url":"https://github.com/vitmalina/w2ui.git","svn_url":"https://github.com/vitmalina/w2ui","homepage":"http://w2ui.com","size":22722,"stargazers_count":916,"watchers_count":916,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":106,"forks":283,"open_issues":106,"watchers":916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/884"},"html":{"href":"https://github.com/vitmalina/w2ui/pull/884"},"issue":{"href":"https://api.github.com/repos/vitmalina/w2ui/issues/884"},"comments":{"href":"https://api.github.com/repos/vitmalina/w2ui/issues/884/comments"},"review_comments":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/884/comments"},"review_comment":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/884/commits"},"statuses":{"href":"https://api.github.com/repos/vitmalina/w2ui/statuses/0ee5e54217e8cfd2603eae3cda1275834750e3c7"}}}}