{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/1169","labels_url":"https://api.github.com/repos/uProxy/uproxy/issues/1169/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/1169/comments","events_url":"https://api.github.com/repos/uProxy/uproxy/issues/1169/events","html_url":"https://github.com/uProxy/uproxy/pull/1169","id":64797724,"number":1169,"title":"Fix bugs with settings panel.","user":{"login":"lucyhe","id":8723127,"avatar_url":"https://avatars.githubusercontent.com/u/8723127?v=3","gravatar_id":"","url":"https://api.github.com/users/lucyhe","html_url":"https://github.com/lucyhe","followers_url":"https://api.github.com/users/lucyhe/followers","following_url":"https://api.github.com/users/lucyhe/following{/other_user}","gists_url":"https://api.github.com/users/lucyhe/gists{/gist_id}","starred_url":"https://api.github.com/users/lucyhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucyhe/subscriptions","organizations_url":"https://api.github.com/users/lucyhe/orgs","repos_url":"https://api.github.com/users/lucyhe/repos","events_url":"https://api.github.com/users/lucyhe/events{/privacy}","received_events_url":"https://api.github.com/users/lucyhe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-03-27T16:27:25Z","updated_at":"2015-03-28T11:24:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/1169","html_url":"https://github.com/uProxy/uproxy/pull/1169","diff_url":"https://github.com/uProxy/uproxy/pull/1169.diff","patch_url":"https://github.com/uProxy/uproxy/pull/1169.patch"},"body":"Tested manually and grunt test.\r\n\r\n- Resolve this issue: https://github.com/uProxy/uproxy/issues/1150\r\n- Before, if the window is too narrow, you can't close the settings panel. Now you can close it by swiping the right edge of the panel. \r\n- Remove the SETTINGS view. Settings is now part of the roster view.\r\n- Update styling:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6871861/dfdcea68-d47b-11e4-9b94-a57bce39c6b5.png)\r\n\r\nThe only weirdness is opening the advanced settings in the default window size:\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6871927/516ae130-d47c-11e4-80b2-9c3f39bfd515.png)\r\nLog out is pretty close to the bottom :( although the panel is now scrollable so you could get this:\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6871945/69ae66c2-d47c-11e4-9820-c0d0d2e0f88f.png)\r\n@zahoriea would you prefer to shrink things so that it fits nicely? or did we want to keep an issue to move advanced settings to its own full panel, which would resolve this?\r\n\r\nA lot of this CL was fixing tabs and moving things into new divs, if someone wants to walk through the code together that might be faster than looking in reviewable to see what's changed. Let me know!\r\n\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/1169)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/87211104","html_url":"https://github.com/uProxy/uproxy/pull/1169#issuecomment-87211104","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/1169","id":87211104,"user":{"login":"zahoriea","id":945845,"avatar_url":"https://avatars.githubusercontent.com/u/945845?v=3","gravatar_id":"","url":"https://api.github.com/users/zahoriea","html_url":"https://github.com/zahoriea","followers_url":"https://api.github.com/users/zahoriea/followers","following_url":"https://api.github.com/users/zahoriea/following{/other_user}","gists_url":"https://api.github.com/users/zahoriea/gists{/gist_id}","starred_url":"https://api.github.com/users/zahoriea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zahoriea/subscriptions","organizations_url":"https://api.github.com/users/zahoriea/orgs","repos_url":"https://api.github.com/users/zahoriea/repos","events_url":"https://api.github.com/users/zahoriea/events{/privacy}","received_events_url":"https://api.github.com/users/zahoriea/received_events","type":"User","site_admin":false},"created_at":"2015-03-28T11:24:49Z","updated_at":"2015-03-28T11:24:49Z","body":"Looks great, Lucy! The only other change I might suggest is to dock the edit icon to the right-hand side a la the Material Design spec http://www.google.com/design/spec/components/lists.html#lists-content"}}