{"action":"created","comment":{"url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/comments/43545339","id":43545339,"diff_hunk":"@@ -205,6 +205,17 @@ def completions():\n         vim.command('return ' + strout)\n \n \n+@contextmanager\n+def tempfile(content):\n+    # Using this instead of the tempfile module because Windows won't read\n+    # from a file not yet written to disk","path":"jedi_vim.py","position":16,"original_position":16,"commit_id":"8a35df70d41a9e1dfd1c85dbb11778ae606237b6","original_commit_id":"8a35df70d41a9e1dfd1c85dbb11778ae606237b6","user":{"login":"wilywampa","id":4472522,"avatar_url":"https://avatars.githubusercontent.com/u/4472522?v=3","gravatar_id":"","url":"https://api.github.com/users/wilywampa","html_url":"https://github.com/wilywampa","followers_url":"https://api.github.com/users/wilywampa/followers","following_url":"https://api.github.com/users/wilywampa/following{/other_user}","gists_url":"https://api.github.com/users/wilywampa/gists{/gist_id}","starred_url":"https://api.github.com/users/wilywampa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilywampa/subscriptions","organizations_url":"https://api.github.com/users/wilywampa/orgs","repos_url":"https://api.github.com/users/wilywampa/repos","events_url":"https://api.github.com/users/wilywampa/events{/privacy}","received_events_url":"https://api.github.com/users/wilywampa/received_events","type":"User","site_admin":false},"body":"That's what we were doing before which didn't work on Windows, unless I'm misunderstanding.","created_at":"2015-10-30T19:53:55Z","updated_at":"2015-10-30T19:53:55Z","html_url":"https://github.com/davidhalter/jedi-vim/pull/489#discussion_r43545339","pull_request_url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/comments/43545339"},"html":{"href":"https://github.com/davidhalter/jedi-vim/pull/489#discussion_r43545339"},"pull_request":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489","id":49304512,"html_url":"https://github.com/davidhalter/jedi-vim/pull/489","diff_url":"https://github.com/davidhalter/jedi-vim/pull/489.diff","patch_url":"https://github.com/davidhalter/jedi-vim/pull/489.patch","issue_url":"https://api.github.com/repos/davidhalter/jedi-vim/issues/489","number":489,"state":"open","locked":false,"title":"Fix handling of temporary tags file on Windows","user":{"login":"wilywampa","id":4472522,"avatar_url":"https://avatars.githubusercontent.com/u/4472522?v=3","gravatar_id":"","url":"https://api.github.com/users/wilywampa","html_url":"https://github.com/wilywampa","followers_url":"https://api.github.com/users/wilywampa/followers","following_url":"https://api.github.com/users/wilywampa/following{/other_user}","gists_url":"https://api.github.com/users/wilywampa/gists{/gist_id}","starred_url":"https://api.github.com/users/wilywampa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilywampa/subscriptions","organizations_url":"https://api.github.com/users/wilywampa/orgs","repos_url":"https://api.github.com/users/wilywampa/repos","events_url":"https://api.github.com/users/wilywampa/events{/privacy}","received_events_url":"https://api.github.com/users/wilywampa/received_events","type":"User","site_admin":false},"body":"Using `NamedTemporaryFile` doesn't work in Windows because Windows can't read the file until the file handle is closed. Making a simple context manager to delete a temporary file after using the tag stack fixes https://github.com/davidhalter/jedi-vim/issues/482.","created_at":"2015-10-30T18:19:07Z","updated_at":"2015-10-30T19:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6370e91f095f21b1ca2c544286e4844015a4dcb4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489/commits","review_comments_url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489/comments","review_comment_url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidhalter/jedi-vim/issues/489/comments","statuses_url":"https://api.github.com/repos/davidhalter/jedi-vim/statuses/8a35df70d41a9e1dfd1c85dbb11778ae606237b6","head":{"label":"wilywampa:fix_tempfile","ref":"fix_tempfile","sha":"8a35df70d41a9e1dfd1c85dbb11778ae606237b6","user":{"login":"wilywampa","id":4472522,"avatar_url":"https://avatars.githubusercontent.com/u/4472522?v=3","gravatar_id":"","url":"https://api.github.com/users/wilywampa","html_url":"https://github.com/wilywampa","followers_url":"https://api.github.com/users/wilywampa/followers","following_url":"https://api.github.com/users/wilywampa/following{/other_user}","gists_url":"https://api.github.com/users/wilywampa/gists{/gist_id}","starred_url":"https://api.github.com/users/wilywampa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilywampa/subscriptions","organizations_url":"https://api.github.com/users/wilywampa/orgs","repos_url":"https://api.github.com/users/wilywampa/repos","events_url":"https://api.github.com/users/wilywampa/events{/privacy}","received_events_url":"https://api.github.com/users/wilywampa/received_events","type":"User","site_admin":false},"repo":{"id":25440512,"name":"jedi-vim","full_name":"wilywampa/jedi-vim","owner":{"login":"wilywampa","id":4472522,"avatar_url":"https://avatars.githubusercontent.com/u/4472522?v=3","gravatar_id":"","url":"https://api.github.com/users/wilywampa","html_url":"https://github.com/wilywampa","followers_url":"https://api.github.com/users/wilywampa/followers","following_url":"https://api.github.com/users/wilywampa/following{/other_user}","gists_url":"https://api.github.com/users/wilywampa/gists{/gist_id}","starred_url":"https://api.github.com/users/wilywampa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilywampa/subscriptions","organizations_url":"https://api.github.com/users/wilywampa/orgs","repos_url":"https://api.github.com/users/wilywampa/repos","events_url":"https://api.github.com/users/wilywampa/events{/privacy}","received_events_url":"https://api.github.com/users/wilywampa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilywampa/jedi-vim","description":"Using the jedi autocompletion library for VIM.","fork":true,"url":"https://api.github.com/repos/wilywampa/jedi-vim","forks_url":"https://api.github.com/repos/wilywampa/jedi-vim/forks","keys_url":"https://api.github.com/repos/wilywampa/jedi-vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilywampa/jedi-vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilywampa/jedi-vim/teams","hooks_url":"https://api.github.com/repos/wilywampa/jedi-vim/hooks","issue_events_url":"https://api.github.com/repos/wilywampa/jedi-vim/issues/events{/number}","events_url":"https://api.github.com/repos/wilywampa/jedi-vim/events","assignees_url":"https://api.github.com/repos/wilywampa/jedi-vim/assignees{/user}","branches_url":"https://api.github.com/repos/wilywampa/jedi-vim/branches{/branch}","tags_url":"https://api.github.com/repos/wilywampa/jedi-vim/tags","blobs_url":"https://api.github.com/repos/wilywampa/jedi-vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilywampa/jedi-vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilywampa/jedi-vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilywampa/jedi-vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilywampa/jedi-vim/statuses/{sha}","languages_url":"https://api.github.com/repos/wilywampa/jedi-vim/languages","stargazers_url":"https://api.github.com/repos/wilywampa/jedi-vim/stargazers","contributors_url":"https://api.github.com/repos/wilywampa/jedi-vim/contributors","subscribers_url":"https://api.github.com/repos/wilywampa/jedi-vim/subscribers","subscription_url":"https://api.github.com/repos/wilywampa/jedi-vim/subscription","commits_url":"https://api.github.com/repos/wilywampa/jedi-vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilywampa/jedi-vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilywampa/jedi-vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilywampa/jedi-vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilywampa/jedi-vim/contents/{+path}","compare_url":"https://api.github.com/repos/wilywampa/jedi-vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilywampa/jedi-vim/merges","archive_url":"https://api.github.com/repos/wilywampa/jedi-vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilywampa/jedi-vim/downloads","issues_url":"https://api.github.com/repos/wilywampa/jedi-vim/issues{/number}","pulls_url":"https://api.github.com/repos/wilywampa/jedi-vim/pulls{/number}","milestones_url":"https://api.github.com/repos/wilywampa/jedi-vim/milestones{/number}","notifications_url":"https://api.github.com/repos/wilywampa/jedi-vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilywampa/jedi-vim/labels{/name}","releases_url":"https://api.github.com/repos/wilywampa/jedi-vim/releases{/id}","created_at":"2014-10-19T21:17:33Z","updated_at":"2015-08-24T03:07:50Z","pushed_at":"2015-10-30T18:52:30Z","git_url":"git://github.com/wilywampa/jedi-vim.git","ssh_url":"git@github.com:wilywampa/jedi-vim.git","clone_url":"https://github.com/wilywampa/jedi-vim.git","svn_url":"https://github.com/wilywampa/jedi-vim","homepage":null,"size":800,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidhalter:master","ref":"master","sha":"9af06424fbf4adf6f48adafb25569c943d8e2e43","user":{"login":"davidhalter","id":748594,"avatar_url":"https://avatars.githubusercontent.com/u/748594?v=3","gravatar_id":"","url":"https://api.github.com/users/davidhalter","html_url":"https://github.com/davidhalter","followers_url":"https://api.github.com/users/davidhalter/followers","following_url":"https://api.github.com/users/davidhalter/following{/other_user}","gists_url":"https://api.github.com/users/davidhalter/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhalter/subscriptions","organizations_url":"https://api.github.com/users/davidhalter/orgs","repos_url":"https://api.github.com/users/davidhalter/repos","events_url":"https://api.github.com/users/davidhalter/events{/privacy}","received_events_url":"https://api.github.com/users/davidhalter/received_events","type":"User","site_admin":false},"repo":{"id":5857387,"name":"jedi-vim","full_name":"davidhalter/jedi-vim","owner":{"login":"davidhalter","id":748594,"avatar_url":"https://avatars.githubusercontent.com/u/748594?v=3","gravatar_id":"","url":"https://api.github.com/users/davidhalter","html_url":"https://github.com/davidhalter","followers_url":"https://api.github.com/users/davidhalter/followers","following_url":"https://api.github.com/users/davidhalter/following{/other_user}","gists_url":"https://api.github.com/users/davidhalter/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhalter/subscriptions","organizations_url":"https://api.github.com/users/davidhalter/orgs","repos_url":"https://api.github.com/users/davidhalter/repos","events_url":"https://api.github.com/users/davidhalter/events{/privacy}","received_events_url":"https://api.github.com/users/davidhalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidhalter/jedi-vim","description":"Using the jedi autocompletion library for VIM.","fork":false,"url":"https://api.github.com/repos/davidhalter/jedi-vim","forks_url":"https://api.github.com/repos/davidhalter/jedi-vim/forks","keys_url":"https://api.github.com/repos/davidhalter/jedi-vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidhalter/jedi-vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidhalter/jedi-vim/teams","hooks_url":"https://api.github.com/repos/davidhalter/jedi-vim/hooks","issue_events_url":"https://api.github.com/repos/davidhalter/jedi-vim/issues/events{/number}","events_url":"https://api.github.com/repos/davidhalter/jedi-vim/events","assignees_url":"https://api.github.com/repos/davidhalter/jedi-vim/assignees{/user}","branches_url":"https://api.github.com/repos/davidhalter/jedi-vim/branches{/branch}","tags_url":"https://api.github.com/repos/davidhalter/jedi-vim/tags","blobs_url":"https://api.github.com/repos/davidhalter/jedi-vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidhalter/jedi-vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidhalter/jedi-vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidhalter/jedi-vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidhalter/jedi-vim/statuses/{sha}","languages_url":"https://api.github.com/repos/davidhalter/jedi-vim/languages","stargazers_url":"https://api.github.com/repos/davidhalter/jedi-vim/stargazers","contributors_url":"https://api.github.com/repos/davidhalter/jedi-vim/contributors","subscribers_url":"https://api.github.com/repos/davidhalter/jedi-vim/subscribers","subscription_url":"https://api.github.com/repos/davidhalter/jedi-vim/subscription","commits_url":"https://api.github.com/repos/davidhalter/jedi-vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidhalter/jedi-vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidhalter/jedi-vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidhalter/jedi-vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidhalter/jedi-vim/contents/{+path}","compare_url":"https://api.github.com/repos/davidhalter/jedi-vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidhalter/jedi-vim/merges","archive_url":"https://api.github.com/repos/davidhalter/jedi-vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidhalter/jedi-vim/downloads","issues_url":"https://api.github.com/repos/davidhalter/jedi-vim/issues{/number}","pulls_url":"https://api.github.com/repos/davidhalter/jedi-vim/pulls{/number}","milestones_url":"https://api.github.com/repos/davidhalter/jedi-vim/milestones{/number}","notifications_url":"https://api.github.com/repos/davidhalter/jedi-vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidhalter/jedi-vim/labels{/name}","releases_url":"https://api.github.com/repos/davidhalter/jedi-vim/releases{/id}","created_at":"2012-09-18T14:14:29Z","updated_at":"2015-10-30T15:21:51Z","pushed_at":"2015-10-30T18:52:30Z","git_url":"git://github.com/davidhalter/jedi-vim.git","ssh_url":"git@github.com:davidhalter/jedi-vim.git","clone_url":"https://github.com/davidhalter/jedi-vim.git","svn_url":"https://github.com/davidhalter/jedi-vim","homepage":null,"size":1607,"stargazers_count":2001,"watchers_count":2001,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":66,"forks":168,"open_issues":66,"watchers":2001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489"},"html":{"href":"https://github.com/davidhalter/jedi-vim/pull/489"},"issue":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/issues/489"},"comments":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/davidhalter/jedi-vim/statuses/8a35df70d41a9e1dfd1c85dbb11778ae606237b6"}}}}