{"action":"created","issue":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/724","labels_url":"https://api.github.com/repos/ratpack/ratpack/issues/724/labels{/name}","comments_url":"https://api.github.com/repos/ratpack/ratpack/issues/724/comments","events_url":"https://api.github.com/repos/ratpack/ratpack/issues/724/events","html_url":"https://github.com/ratpack/ratpack/pull/724","id":94262419,"number":724,"title":"Graphite codahale metrics reporter Support","user":{"login":"djjorjinho","id":395537,"avatar_url":"https://avatars.githubusercontent.com/u/395537?v=3","gravatar_id":"","url":"https://api.github.com/users/djjorjinho","html_url":"https://github.com/djjorjinho","followers_url":"https://api.github.com/users/djjorjinho/followers","following_url":"https://api.github.com/users/djjorjinho/following{/other_user}","gists_url":"https://api.github.com/users/djjorjinho/gists{/gist_id}","starred_url":"https://api.github.com/users/djjorjinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djjorjinho/subscriptions","organizations_url":"https://api.github.com/users/djjorjinho/orgs","repos_url":"https://api.github.com/users/djjorjinho/repos","events_url":"https://api.github.com/users/djjorjinho/events{/privacy}","received_events_url":"https://api.github.com/users/djjorjinho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rhart","id":226023,"avatar_url":"https://avatars.githubusercontent.com/u/226023?v=3","gravatar_id":"","url":"https://api.github.com/users/rhart","html_url":"https://github.com/rhart","followers_url":"https://api.github.com/users/rhart/followers","following_url":"https://api.github.com/users/rhart/following{/other_user}","gists_url":"https://api.github.com/users/rhart/gists{/gist_id}","starred_url":"https://api.github.com/users/rhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhart/subscriptions","organizations_url":"https://api.github.com/users/rhart/orgs","repos_url":"https://api.github.com/users/rhart/repos","events_url":"https://api.github.com/users/rhart/events{/privacy}","received_events_url":"https://api.github.com/users/rhart/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-07-10T09:31:17Z","updated_at":"2015-07-14T01:10:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ratpack/ratpack/pulls/724","html_url":"https://github.com/ratpack/ratpack/pull/724","diff_url":"https://github.com/ratpack/ratpack/pull/724.diff","patch_url":"https://github.com/ratpack/ratpack/pull/724.patch"},"body":"The contents of this request allows preliminary support for graphite metrics reporting, with a broad range of support for graphite senders.\r\nI did not add the RabbitMQ Sender dependency under the assumption that the end user would add the dependency in their own projects if needed.\r\n\r\nLet me know if there's anything that need changing and I'll get to it."},"comment":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/comments/121103971","html_url":"https://github.com/ratpack/ratpack/pull/724#issuecomment-121103971","issue_url":"https://api.github.com/repos/ratpack/ratpack/issues/724","id":121103971,"user":{"login":"johnrengelman","id":1012772,"avatar_url":"https://avatars.githubusercontent.com/u/1012772?v=3","gravatar_id":"","url":"https://api.github.com/users/johnrengelman","html_url":"https://github.com/johnrengelman","followers_url":"https://api.github.com/users/johnrengelman/followers","following_url":"https://api.github.com/users/johnrengelman/following{/other_user}","gists_url":"https://api.github.com/users/johnrengelman/gists{/gist_id}","starred_url":"https://api.github.com/users/johnrengelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnrengelman/subscriptions","organizations_url":"https://api.github.com/users/johnrengelman/orgs","repos_url":"https://api.github.com/users/johnrengelman/repos","events_url":"https://api.github.com/users/johnrengelman/events{/privacy}","received_events_url":"https://api.github.com/users/johnrengelman/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T01:10:40Z","updated_at":"2015-07-14T01:10:40Z","body":"Hey @djjorjinho, it seems when you rebased this PR, you may have done it in the wrong direction (i.e. you rebased the upstream master branch onto you local branch). This has caused a number of commits to be rewritten in your pull request.\r\nYou should be performing a rebase such that your local branch is rebased onto the current master branch from the ratpack repo. Assuming you have set the `upstream` remote in git to be the ratpack repo, you would do: \r\n```\r\n$ git checkout my_branch && git fetch upstream master && git rebase upstream/master\r\n```\r\nIf you don't know how to fix this locally, I can correct it manually and merge it."}}