{"action":"created","issue":{"url":"https://api.github.com/repos/webrtc/testrtc/issues/138","labels_url":"https://api.github.com/repos/webrtc/testrtc/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/webrtc/testrtc/issues/138/comments","events_url":"https://api.github.com/repos/webrtc/testrtc/issues/138/events","html_url":"https://github.com/webrtc/testrtc/pull/138","id":115292228,"number":138,"title":"Pass test object to camrestest + remove resolution loop test","user":{"login":"KaptenJansson","id":5872605,"avatar_url":"https://avatars.githubusercontent.com/u/5872605?v=3","gravatar_id":"","url":"https://api.github.com/users/KaptenJansson","html_url":"https://github.com/KaptenJansson","followers_url":"https://api.github.com/users/KaptenJansson/followers","following_url":"https://api.github.com/users/KaptenJansson/following{/other_user}","gists_url":"https://api.github.com/users/KaptenJansson/gists{/gist_id}","starred_url":"https://api.github.com/users/KaptenJansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaptenJansson/subscriptions","organizations_url":"https://api.github.com/users/KaptenJansson/orgs","repos_url":"https://api.github.com/users/KaptenJansson/repos","events_url":"https://api.github.com/users/KaptenJansson/events{/privacy}","received_events_url":"https://api.github.com/users/KaptenJansson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/webrtc/testrtc/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-05T14:17:29Z","updated_at":"2015-11-06T13:05:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webrtc/testrtc/pulls/138","html_url":"https://github.com/webrtc/testrtc/pull/138","diff_url":"https://github.com/webrtc/testrtc/pull/138.diff","patch_url":"https://github.com/webrtc/testrtc/pull/138.patch"},"body":"Test object is now passed to the tests, also I've changed the tests to be more explicit, i.e. no more looping through an array of resolutions. It just runs the explicit resolutions test and verifies that there are non black moving pixels coming from the camera.\r\n\r\n@tednakamura @samdutton @juberti Do you have anything against me removing the test that checks that gUM is successful for 14 resolutions? It actually prevents it from being run properly on Chrome on Android, it crashes Chrome on this test every time since the last 3 or 4 of milestones (since Camera API v2 was introduced I believe). In my opinion it's more of a stress test than anything else.\r\n"},"comment":{"url":"https://api.github.com/repos/webrtc/testrtc/issues/comments/154404782","html_url":"https://github.com/webrtc/testrtc/pull/138#issuecomment-154404782","issue_url":"https://api.github.com/repos/webrtc/testrtc/issues/138","id":154404782,"user":{"login":"KaptenJansson","id":5872605,"avatar_url":"https://avatars.githubusercontent.com/u/5872605?v=3","gravatar_id":"","url":"https://api.github.com/users/KaptenJansson","html_url":"https://github.com/KaptenJansson","followers_url":"https://api.github.com/users/KaptenJansson/followers","following_url":"https://api.github.com/users/KaptenJansson/following{/other_user}","gists_url":"https://api.github.com/users/KaptenJansson/gists{/gist_id}","starred_url":"https://api.github.com/users/KaptenJansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaptenJansson/subscriptions","organizations_url":"https://api.github.com/users/KaptenJansson/orgs","repos_url":"https://api.github.com/users/KaptenJansson/repos","events_url":"https://api.github.com/users/KaptenJansson/events{/privacy}","received_events_url":"https://api.github.com/users/KaptenJansson/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T13:05:27Z","updated_at":"2015-11-06T13:05:27Z","body":"I have put the resolution check tests back in but cleaned up the logic. We can discuss about remove them/detecting mobile clients etc in a separate PR."}}