{"action":"created","issue":{"url":"https://api.github.com/repos/scrapinghub/shub/issues/80","labels_url":"https://api.github.com/repos/scrapinghub/shub/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/scrapinghub/shub/issues/80/comments","events_url":"https://api.github.com/repos/scrapinghub/shub/issues/80/events","html_url":"https://github.com/scrapinghub/shub/pull/80","id":122184131,"number":80,"title":"Adding a tox target to freeze shub command line tool","user":{"login":"jsargiot","id":1591461,"avatar_url":"https://avatars.githubusercontent.com/u/1591461?v=3","gravatar_id":"","url":"https://api.github.com/users/jsargiot","html_url":"https://github.com/jsargiot","followers_url":"https://api.github.com/users/jsargiot/followers","following_url":"https://api.github.com/users/jsargiot/following{/other_user}","gists_url":"https://api.github.com/users/jsargiot/gists{/gist_id}","starred_url":"https://api.github.com/users/jsargiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsargiot/subscriptions","organizations_url":"https://api.github.com/users/jsargiot/orgs","repos_url":"https://api.github.com/users/jsargiot/repos","events_url":"https://api.github.com/users/jsargiot/events{/privacy}","received_events_url":"https://api.github.com/users/jsargiot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-15T03:16:21Z","updated_at":"2015-12-15T11:37:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scrapinghub/shub/pulls/80","html_url":"https://github.com/scrapinghub/shub/pull/80","diff_url":"https://github.com/scrapinghub/shub/pull/80.diff","patch_url":"https://github.com/scrapinghub/shub/pull/80.patch"},"body":"This new target will generate a binary of the platform on which is running (windows, linux or mac). There is a pyinstaller hook to make sure all submodules of shub are included in the binary (because are loaded on runtime). Also added a shubrunner.py script to execute the cli function of the shub.tool module because pyinstaller won't support that call."},"comment":{"url":"https://api.github.com/repos/scrapinghub/shub/issues/comments/164737752","html_url":"https://github.com/scrapinghub/shub/pull/80#issuecomment-164737752","issue_url":"https://api.github.com/repos/scrapinghub/shub/issues/80","id":164737752,"user":{"login":"josericardo","id":1643580,"avatar_url":"https://avatars.githubusercontent.com/u/1643580?v=3","gravatar_id":"","url":"https://api.github.com/users/josericardo","html_url":"https://github.com/josericardo","followers_url":"https://api.github.com/users/josericardo/followers","following_url":"https://api.github.com/users/josericardo/following{/other_user}","gists_url":"https://api.github.com/users/josericardo/gists{/gist_id}","starred_url":"https://api.github.com/users/josericardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josericardo/subscriptions","organizations_url":"https://api.github.com/users/josericardo/orgs","repos_url":"https://api.github.com/users/josericardo/repos","events_url":"https://api.github.com/users/josericardo/events{/privacy}","received_events_url":"https://api.github.com/users/josericardo/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T11:37:56Z","updated_at":"2015-12-15T11:37:56Z","body":"Hey @jsargiot :)\r\n\r\nJust checking, would it be possible to add a test for this? Something like extracting the pyinstaller command to a script, running it from a test and checking the package was successfully built?\r\n\r\nOverkill?"}}