{"action":"opened","number":1114,"pull_request":{"url":"https://api.github.com/repos/ruby/ruby/pulls/1114","id":51772203,"html_url":"https://github.com/ruby/ruby/pull/1114","diff_url":"https://github.com/ruby/ruby/pull/1114.diff","patch_url":"https://github.com/ruby/ruby/pull/1114.patch","issue_url":"https://api.github.com/repos/ruby/ruby/issues/1114","number":1114,"state":"open","locked":false,"title":"Remove TLSv1 support from DEFAULT_PARAMS","user":{"login":"brandonweeks","id":15869,"avatar_url":"https://avatars.githubusercontent.com/u/15869?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonweeks","html_url":"https://github.com/brandonweeks","followers_url":"https://api.github.com/users/brandonweeks/followers","following_url":"https://api.github.com/users/brandonweeks/following{/other_user}","gists_url":"https://api.github.com/users/brandonweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonweeks/subscriptions","organizations_url":"https://api.github.com/users/brandonweeks/orgs","repos_url":"https://api.github.com/users/brandonweeks/repos","events_url":"https://api.github.com/users/brandonweeks/events{/privacy}","received_events_url":"https://api.github.com/users/brandonweeks/received_events","type":"User","site_admin":false},"body":"Reviving #873 since I think there was some confusion in the original PR.\r\n\r\n* `:ssl_version` maps to the `SSL_METHOD` param that is passed into `SSL_CTX_new()`. \r\n  * https://www.openssl.org/docs/manmaster/ssl/SSL_CTX_new.html\r\n* The naming of `SSLv23_method` is disingenuous. It has the effect of enabling SSLv3 and *newer*.\r\n* `SSLv3_method`,  `TLSv1_method`, `TLSv1_1_method`, `TLSv1_2_method` pin the SSL/TLS to a *specific version*, which seem like a poor default.\r\n* `SSLv23_method` is being renamed to `TLS_method` in OpenSSL 1.1.0, which is a better reflection of its usage. `SSLv23_method` becomes an alias for `TLS_method` and is deprecated. Ruby should use `TLS_method` by default on OpenSSL 1.1.0 or later and retain `SSLv23_method` as the default with previous versions.\r\n\r\nIf there is consensus that we don't want to remove support for client TLSv1, I think the next step should be to break `DEFAULT_PARAMS` into separate client and server settings. Shipping a TLS server with badly configured defaults is definitely harmful. \r\n","created_at":"2015-11-25T09:51:31Z","updated_at":"2015-11-25T09:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ruby/ruby/pulls/1114/commits","review_comments_url":"https://api.github.com/repos/ruby/ruby/pulls/1114/comments","review_comment_url":"https://api.github.com/repos/ruby/ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby/ruby/issues/1114/comments","statuses_url":"https://api.github.com/repos/ruby/ruby/statuses/88235159dc9e3151c28594507c54a69bc465f72d","head":{"label":"brandonweeks:disable_TLSv1","ref":"disable_TLSv1","sha":"88235159dc9e3151c28594507c54a69bc465f72d","user":{"login":"brandonweeks","id":15869,"avatar_url":"https://avatars.githubusercontent.com/u/15869?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonweeks","html_url":"https://github.com/brandonweeks","followers_url":"https://api.github.com/users/brandonweeks/followers","following_url":"https://api.github.com/users/brandonweeks/following{/other_user}","gists_url":"https://api.github.com/users/brandonweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonweeks/subscriptions","organizations_url":"https://api.github.com/users/brandonweeks/orgs","repos_url":"https://api.github.com/users/brandonweeks/repos","events_url":"https://api.github.com/users/brandonweeks/events{/privacy}","received_events_url":"https://api.github.com/users/brandonweeks/received_events","type":"User","site_admin":false},"repo":{"id":46845181,"name":"ruby","full_name":"brandonweeks/ruby","owner":{"login":"brandonweeks","id":15869,"avatar_url":"https://avatars.githubusercontent.com/u/15869?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonweeks","html_url":"https://github.com/brandonweeks","followers_url":"https://api.github.com/users/brandonweeks/followers","following_url":"https://api.github.com/users/brandonweeks/following{/other_user}","gists_url":"https://api.github.com/users/brandonweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonweeks/subscriptions","organizations_url":"https://api.github.com/users/brandonweeks/orgs","repos_url":"https://api.github.com/users/brandonweeks/repos","events_url":"https://api.github.com/users/brandonweeks/events{/privacy}","received_events_url":"https://api.github.com/users/brandonweeks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandonweeks/ruby","description":"The Ruby Programming Language","fork":true,"url":"https://api.github.com/repos/brandonweeks/ruby","forks_url":"https://api.github.com/repos/brandonweeks/ruby/forks","keys_url":"https://api.github.com/repos/brandonweeks/ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandonweeks/ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandonweeks/ruby/teams","hooks_url":"https://api.github.com/repos/brandonweeks/ruby/hooks","issue_events_url":"https://api.github.com/repos/brandonweeks/ruby/issues/events{/number}","events_url":"https://api.github.com/repos/brandonweeks/ruby/events","assignees_url":"https://api.github.com/repos/brandonweeks/ruby/assignees{/user}","branches_url":"https://api.github.com/repos/brandonweeks/ruby/branches{/branch}","tags_url":"https://api.github.com/repos/brandonweeks/ruby/tags","blobs_url":"https://api.github.com/repos/brandonweeks/ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandonweeks/ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandonweeks/ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandonweeks/ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandonweeks/ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/brandonweeks/ruby/languages","stargazers_url":"https://api.github.com/repos/brandonweeks/ruby/stargazers","contributors_url":"https://api.github.com/repos/brandonweeks/ruby/contributors","subscribers_url":"https://api.github.com/repos/brandonweeks/ruby/subscribers","subscription_url":"https://api.github.com/repos/brandonweeks/ruby/subscription","commits_url":"https://api.github.com/repos/brandonweeks/ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandonweeks/ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandonweeks/ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandonweeks/ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandonweeks/ruby/contents/{+path}","compare_url":"https://api.github.com/repos/brandonweeks/ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandonweeks/ruby/merges","archive_url":"https://api.github.com/repos/brandonweeks/ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandonweeks/ruby/downloads","issues_url":"https://api.github.com/repos/brandonweeks/ruby/issues{/number}","pulls_url":"https://api.github.com/repos/brandonweeks/ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/brandonweeks/ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/brandonweeks/ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandonweeks/ruby/labels{/name}","releases_url":"https://api.github.com/repos/brandonweeks/ruby/releases{/id}","created_at":"2015-11-25T07:34:18Z","updated_at":"2015-11-25T07:35:47Z","pushed_at":"2015-11-25T09:33:46Z","git_url":"git://github.com/brandonweeks/ruby.git","ssh_url":"git@github.com:brandonweeks/ruby.git","clone_url":"https://github.com/brandonweeks/ruby.git","svn_url":"https://github.com/brandonweeks/ruby","homepage":"http://www.ruby-lang.org/","size":174016,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ruby:trunk","ref":"trunk","sha":"012368007f0a7fce81a0083c96aa549c21141d05","user":{"login":"ruby","id":210414,"avatar_url":"https://avatars.githubusercontent.com/u/210414?v=3","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"repo":{"id":538746,"name":"ruby","full_name":"ruby/ruby","owner":{"login":"ruby","id":210414,"avatar_url":"https://avatars.githubusercontent.com/u/210414?v=3","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby/ruby","description":"The Ruby Programming Language","fork":false,"url":"https://api.github.com/repos/ruby/ruby","forks_url":"https://api.github.com/repos/ruby/ruby/forks","keys_url":"https://api.github.com/repos/ruby/ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby/ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby/ruby/teams","hooks_url":"https://api.github.com/repos/ruby/ruby/hooks","issue_events_url":"https://api.github.com/repos/ruby/ruby/issues/events{/number}","events_url":"https://api.github.com/repos/ruby/ruby/events","assignees_url":"https://api.github.com/repos/ruby/ruby/assignees{/user}","branches_url":"https://api.github.com/repos/ruby/ruby/branches{/branch}","tags_url":"https://api.github.com/repos/ruby/ruby/tags","blobs_url":"https://api.github.com/repos/ruby/ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby/ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby/ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby/ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby/ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby/ruby/languages","stargazers_url":"https://api.github.com/repos/ruby/ruby/stargazers","contributors_url":"https://api.github.com/repos/ruby/ruby/contributors","subscribers_url":"https://api.github.com/repos/ruby/ruby/subscribers","subscription_url":"https://api.github.com/repos/ruby/ruby/subscription","commits_url":"https://api.github.com/repos/ruby/ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby/ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby/ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby/ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby/ruby/contents/{+path}","compare_url":"https://api.github.com/repos/ruby/ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby/ruby/merges","archive_url":"https://api.github.com/repos/ruby/ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby/ruby/downloads","issues_url":"https://api.github.com/repos/ruby/ruby/issues{/number}","pulls_url":"https://api.github.com/repos/ruby/ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby/ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby/ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby/ruby/labels{/name}","releases_url":"https://api.github.com/repos/ruby/ruby/releases{/id}","created_at":"2010-02-27T15:55:23Z","updated_at":"2015-11-25T09:18:47Z","pushed_at":"2015-11-25T08:02:38Z","git_url":"git://github.com/ruby/ruby.git","ssh_url":"git@github.com:ruby/ruby.git","clone_url":"https://github.com/ruby/ruby.git","svn_url":"https://github.com/ruby/ruby","homepage":"http://www.ruby-lang.org/","size":227858,"stargazers_count":8520,"watchers_count":8520,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2565,"mirror_url":null,"open_issues_count":103,"forks":2565,"open_issues":103,"watchers":8520,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby/ruby/pulls/1114"},"html":{"href":"https://github.com/ruby/ruby/pull/1114"},"issue":{"href":"https://api.github.com/repos/ruby/ruby/issues/1114"},"comments":{"href":"https://api.github.com/repos/ruby/ruby/issues/1114/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby/ruby/pulls/1114/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby/ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby/ruby/pulls/1114/commits"},"statuses":{"href":"https://api.github.com/repos/ruby/ruby/statuses/88235159dc9e3151c28594507c54a69bc465f72d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}