{"action":"created","issue":{"url":"https://api.github.com/repos/swisspol/GCDWebServer/issues/166","labels_url":"https://api.github.com/repos/swisspol/GCDWebServer/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/swisspol/GCDWebServer/issues/166/comments","events_url":"https://api.github.com/repos/swisspol/GCDWebServer/issues/166/events","html_url":"https://github.com/swisspol/GCDWebServer/pull/166","id":68992796,"number":166,"title":"Frameworks and Carthage Support","user":{"login":"sagmor","id":4744,"avatar_url":"https://avatars.githubusercontent.com/u/4744?v=3","gravatar_id":"","url":"https://api.github.com/users/sagmor","html_url":"https://github.com/sagmor","followers_url":"https://api.github.com/users/sagmor/followers","following_url":"https://api.github.com/users/sagmor/following{/other_user}","gists_url":"https://api.github.com/users/sagmor/gists{/gist_id}","starred_url":"https://api.github.com/users/sagmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagmor/subscriptions","organizations_url":"https://api.github.com/users/sagmor/orgs","repos_url":"https://api.github.com/users/sagmor/repos","events_url":"https://api.github.com/users/sagmor/events{/privacy}","received_events_url":"https://api.github.com/users/sagmor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2015-04-16T19:24:36Z","updated_at":"2015-06-15T17:18:33Z","closed_at":"2015-06-12T17:34:25Z","pull_request":{"url":"https://api.github.com/repos/swisspol/GCDWebServer/pulls/166","html_url":"https://github.com/swisspol/GCDWebServer/pull/166","diff_url":"https://github.com/swisspol/GCDWebServer/pull/166.diff","patch_url":"https://github.com/swisspol/GCDWebServer/pull/166.patch"},"body":"I just added Framework targets for both Mac and iOS.\r\n\r\nI named the Framework GCDWebServers (with an s) because Included frameworks can only `#include <>` the umbrella header, which means that you can't pick individual headers and since EVERY `#include` has to be on the umbrella header it would have bloated `GCDWebServer.h`\r\n\r\nInstead with the GCDWebServers name, it's implicit, that the framework includes all the Servers and we keep a clean `GCDWebServer.h`\r\n\r\nNow, having framework shared targets in the project, means that this library should support Carthage out of the box (which solves #136) yet for full support, it might be a good idea to provide a prebuilt framework on version releases. It's quite simple so I'll take a look at how to automate that and I'll get back on that later.\r\n\r\nI'm currently working with the Mac version on an App I'm working on, but it might need a little more testing to be sure everything works as it should.\r\n\r\nI'm leaving this as a PR so we don't duplicate efforts with #161 and to be sure you like this approach before investing more time on it :beers: "},"comment":{"url":"https://api.github.com/repos/swisspol/GCDWebServer/issues/comments/112144580","html_url":"https://github.com/swisspol/GCDWebServer/pull/166#issuecomment-112144580","issue_url":"https://api.github.com/repos/swisspol/GCDWebServer/issues/166","id":112144580,"user":{"login":"guidomb","id":390645,"avatar_url":"https://avatars.githubusercontent.com/u/390645?v=3","gravatar_id":"","url":"https://api.github.com/users/guidomb","html_url":"https://github.com/guidomb","followers_url":"https://api.github.com/users/guidomb/followers","following_url":"https://api.github.com/users/guidomb/following{/other_user}","gists_url":"https://api.github.com/users/guidomb/gists{/gist_id}","starred_url":"https://api.github.com/users/guidomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidomb/subscriptions","organizations_url":"https://api.github.com/users/guidomb/orgs","repos_url":"https://api.github.com/users/guidomb/repos","events_url":"https://api.github.com/users/guidomb/events{/privacy}","received_events_url":"https://api.github.com/users/guidomb/received_events","type":"User","site_admin":false},"created_at":"2015-06-15T17:18:33Z","updated_at":"2015-06-15T17:18:33Z","body":"That would is valid after you make a release in github if not people would have to add\r\n\r\n```\r\ngithub \"swisspol/GCDWebServer\" \"master\"\r\n```"}}