{"action":"closed","number":256,"pull_request":{"url":"https://api.github.com/repos/behdad/fonttools/pulls/256","id":34603267,"html_url":"https://github.com/behdad/fonttools/pull/256","diff_url":"https://github.com/behdad/fonttools/pull/256.diff","patch_url":"https://github.com/behdad/fonttools/pull/256.patch","issue_url":"https://api.github.com/repos/behdad/fonttools/issues/256","number":256,"state":"closed","locked":false,"title":"[OS/2] update fsFirstCharIndex and fsLastCharIndex upon compile","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"this addresses a [request](https://github.com/behdad/fonttools/issues/255) by @lemzwerg to recalculate the `fsFirstCharIndex` and `fsLastCharIndex` of OS/2 table while reassembling a font.\r\n\r\nI added a method to the OS/2 table class, which is called upon compiling that table. It simply gathers all codes specified in cmap subtables (3, 0) or (3, 1) and takes the min/max among these.\r\n\r\nShould this be the default behaviour when compiling the OS/2 table (like in the current patch), or it should be controlled through some sort of option?\r\n\r\n","created_at":"2015-05-03T16:02:03Z","updated_at":"2015-05-09T18:12:47Z","closed_at":"2015-05-09T18:12:47Z","merged_at":"2015-05-09T18:12:47Z","merge_commit_sha":"502636e074faf8a770316006956310fb201441da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/behdad/fonttools/pulls/256/commits","review_comments_url":"https://api.github.com/repos/behdad/fonttools/pulls/256/comments","review_comment_url":"https://api.github.com/repos/behdad/fonttools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/behdad/fonttools/issues/256/comments","statuses_url":"https://api.github.com/repos/behdad/fonttools/statuses/1fbdbca41a95f4efde9b00be511ebdd1f93dc45a","head":{"label":"anthrotype:os2_char_index","ref":"os2_char_index","sha":"1fbdbca41a95f4efde9b00be511ebdd1f93dc45a","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"repo":{"id":20835031,"name":"fonttools","full_name":"anthrotype/fonttools","owner":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthrotype/fonttools","description":"Fork of fonttools project from Sourceforge, with new features and bugfixes","fork":true,"url":"https://api.github.com/repos/anthrotype/fonttools","forks_url":"https://api.github.com/repos/anthrotype/fonttools/forks","keys_url":"https://api.github.com/repos/anthrotype/fonttools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthrotype/fonttools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthrotype/fonttools/teams","hooks_url":"https://api.github.com/repos/anthrotype/fonttools/hooks","issue_events_url":"https://api.github.com/repos/anthrotype/fonttools/issues/events{/number}","events_url":"https://api.github.com/repos/anthrotype/fonttools/events","assignees_url":"https://api.github.com/repos/anthrotype/fonttools/assignees{/user}","branches_url":"https://api.github.com/repos/anthrotype/fonttools/branches{/branch}","tags_url":"https://api.github.com/repos/anthrotype/fonttools/tags","blobs_url":"https://api.github.com/repos/anthrotype/fonttools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthrotype/fonttools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthrotype/fonttools/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthrotype/fonttools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthrotype/fonttools/statuses/{sha}","languages_url":"https://api.github.com/repos/anthrotype/fonttools/languages","stargazers_url":"https://api.github.com/repos/anthrotype/fonttools/stargazers","contributors_url":"https://api.github.com/repos/anthrotype/fonttools/contributors","subscribers_url":"https://api.github.com/repos/anthrotype/fonttools/subscribers","subscription_url":"https://api.github.com/repos/anthrotype/fonttools/subscription","commits_url":"https://api.github.com/repos/anthrotype/fonttools/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthrotype/fonttools/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthrotype/fonttools/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthrotype/fonttools/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthrotype/fonttools/contents/{+path}","compare_url":"https://api.github.com/repos/anthrotype/fonttools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthrotype/fonttools/merges","archive_url":"https://api.github.com/repos/anthrotype/fonttools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthrotype/fonttools/downloads","issues_url":"https://api.github.com/repos/anthrotype/fonttools/issues{/number}","pulls_url":"https://api.github.com/repos/anthrotype/fonttools/pulls{/number}","milestones_url":"https://api.github.com/repos/anthrotype/fonttools/milestones{/number}","notifications_url":"https://api.github.com/repos/anthrotype/fonttools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthrotype/fonttools/labels{/name}","releases_url":"https://api.github.com/repos/anthrotype/fonttools/releases{/id}","created_at":"2014-06-14T15:31:05Z","updated_at":"2015-05-08T08:39:40Z","pushed_at":"2015-05-09T09:59:47Z","git_url":"git://github.com/anthrotype/fonttools.git","ssh_url":"git@github.com:anthrotype/fonttools.git","clone_url":"https://github.com/anthrotype/fonttools.git","svn_url":"https://github.com/anthrotype/fonttools","homepage":"https://groups.google.com/d/forum/fonttools","size":4438,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"behdad:master","ref":"master","sha":"a9f88538353f2fe8fb308a51e98e67d72a4f2013","user":{"login":"behdad","id":142891,"avatar_url":"https://avatars.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"repo":{"id":11639637,"name":"fonttools","full_name":"behdad/fonttools","owner":{"login":"behdad","id":142891,"avatar_url":"https://avatars.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behdad/fonttools","description":"Fork of fonttools project from Sourceforge, with new features and bugfixes","fork":false,"url":"https://api.github.com/repos/behdad/fonttools","forks_url":"https://api.github.com/repos/behdad/fonttools/forks","keys_url":"https://api.github.com/repos/behdad/fonttools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behdad/fonttools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behdad/fonttools/teams","hooks_url":"https://api.github.com/repos/behdad/fonttools/hooks","issue_events_url":"https://api.github.com/repos/behdad/fonttools/issues/events{/number}","events_url":"https://api.github.com/repos/behdad/fonttools/events","assignees_url":"https://api.github.com/repos/behdad/fonttools/assignees{/user}","branches_url":"https://api.github.com/repos/behdad/fonttools/branches{/branch}","tags_url":"https://api.github.com/repos/behdad/fonttools/tags","blobs_url":"https://api.github.com/repos/behdad/fonttools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behdad/fonttools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behdad/fonttools/git/refs{/sha}","trees_url":"https://api.github.com/repos/behdad/fonttools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behdad/fonttools/statuses/{sha}","languages_url":"https://api.github.com/repos/behdad/fonttools/languages","stargazers_url":"https://api.github.com/repos/behdad/fonttools/stargazers","contributors_url":"https://api.github.com/repos/behdad/fonttools/contributors","subscribers_url":"https://api.github.com/repos/behdad/fonttools/subscribers","subscription_url":"https://api.github.com/repos/behdad/fonttools/subscription","commits_url":"https://api.github.com/repos/behdad/fonttools/commits{/sha}","git_commits_url":"https://api.github.com/repos/behdad/fonttools/git/commits{/sha}","comments_url":"https://api.github.com/repos/behdad/fonttools/comments{/number}","issue_comment_url":"https://api.github.com/repos/behdad/fonttools/issues/comments{/number}","contents_url":"https://api.github.com/repos/behdad/fonttools/contents/{+path}","compare_url":"https://api.github.com/repos/behdad/fonttools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behdad/fonttools/merges","archive_url":"https://api.github.com/repos/behdad/fonttools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behdad/fonttools/downloads","issues_url":"https://api.github.com/repos/behdad/fonttools/issues{/number}","pulls_url":"https://api.github.com/repos/behdad/fonttools/pulls{/number}","milestones_url":"https://api.github.com/repos/behdad/fonttools/milestones{/number}","notifications_url":"https://api.github.com/repos/behdad/fonttools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behdad/fonttools/labels{/name}","releases_url":"https://api.github.com/repos/behdad/fonttools/releases{/id}","created_at":"2013-07-24T16:28:35Z","updated_at":"2015-05-09T13:17:45Z","pushed_at":"2015-05-09T18:12:47Z","git_url":"git://github.com/behdad/fonttools.git","ssh_url":"git@github.com:behdad/fonttools.git","clone_url":"https://github.com/behdad/fonttools.git","svn_url":"https://github.com/behdad/fonttools","homepage":"https://groups.google.com/d/forum/fonttools","size":6292,"stargazers_count":191,"watchers_count":191,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":93,"forks":59,"open_issues":93,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/256"},"html":{"href":"https://github.com/behdad/fonttools/pull/256"},"issue":{"href":"https://api.github.com/repos/behdad/fonttools/issues/256"},"comments":{"href":"https://api.github.com/repos/behdad/fonttools/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/behdad/fonttools/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/behdad/fonttools/statuses/1fbdbca41a95f4efde9b00be511ebdd1f93dc45a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"behdad","id":142891,"avatar_url":"https://avatars.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":1,"additions":17,"deletions":0,"changed_files":1}}