{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/signing-clients/pulls/comments/27999585","id":27999585,"diff_hunk":"@@ -302,19 +317,26 @@ def make_signed(self, signature, outpath=None):\n         if os.path.exists(outpath):\n             raise IOError(\"File already exists: %s\" % outpath)\n \n+        sigpath = sigpath  or signature.filename","path":"signing_clients/apps.py","position":98,"original_position":98,"commit_id":"b52adcdc250755850ab4e448234049204c98efd9","original_commit_id":"b52adcdc250755850ab4e448234049204c98efd9","user":{"login":"andymckay","id":74699,"avatar_url":"https://avatars.githubusercontent.com/u/74699?v=3","gravatar_id":"","url":"https://api.github.com/users/andymckay","html_url":"https://github.com/andymckay","followers_url":"https://api.github.com/users/andymckay/followers","following_url":"https://api.github.com/users/andymckay/following{/other_user}","gists_url":"https://api.github.com/users/andymckay/gists{/gist_id}","starred_url":"https://api.github.com/users/andymckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymckay/subscriptions","organizations_url":"https://api.github.com/users/andymckay/orgs","repos_url":"https://api.github.com/users/andymckay/repos","events_url":"https://api.github.com/users/andymckay/events{/privacy}","received_events_url":"https://api.github.com/users/andymckay/received_events","type":"User","site_admin":false},"body":"`filename` on the signature defaults to `None` (i think), do you need to worry about `signature.filename` ever being `None`?","created_at":"2015-04-08T18:36:59Z","updated_at":"2015-04-08T18:36:59Z","html_url":"https://github.com/mozilla/signing-clients/pull/15#discussion_r27999585","pull_request_url":"https://api.github.com/repos/mozilla/signing-clients/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/mozilla/signing-clients/pulls/comments/27999585"},"html":{"href":"https://github.com/mozilla/signing-clients/pull/15#discussion_r27999585"},"pull_request":{"href":"https://api.github.com/repos/mozilla/signing-clients/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/signing-clients/pulls/15","id":32887584,"html_url":"https://github.com/mozilla/signing-clients/pull/15","diff_url":"https://github.com/mozilla/signing-clients/pull/15.diff","patch_url":"https://github.com/mozilla/signing-clients/pull/15.patch","issue_url":"https://api.github.com/repos/mozilla/signing-clients/issues/15","number":15,"state":"open","locked":false,"title":"No hardcoded filenames for signatures","user":{"login":"rtilder","id":250074,"avatar_url":"https://avatars.githubusercontent.com/u/250074?v=3","gravatar_id":"","url":"https://api.github.com/users/rtilder","html_url":"https://github.com/rtilder","followers_url":"https://api.github.com/users/rtilder/followers","following_url":"https://api.github.com/users/rtilder/following{/other_user}","gists_url":"https://api.github.com/users/rtilder/gists{/gist_id}","starred_url":"https://api.github.com/users/rtilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtilder/subscriptions","organizations_url":"https://api.github.com/users/rtilder/orgs","repos_url":"https://api.github.com/users/rtilder/repos","events_url":"https://api.github.com/users/rtilder/events{/privacy}","received_events_url":"https://api.github.com/users/rtilder/received_events","type":"User","site_admin":false},"body":"Stop using the hardcoded filename \"zigbert\" for all signatures.  Default to it but allow it to be overridden.","created_at":"2015-04-08T18:23:07Z","updated_at":"2015-04-08T18:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b2423b6238dd30c3291741a640deaa301bf3488","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/signing-clients/pulls/15/commits","review_comments_url":"https://api.github.com/repos/mozilla/signing-clients/pulls/15/comments","review_comment_url":"https://api.github.com/repos/mozilla/signing-clients/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/signing-clients/issues/15/comments","statuses_url":"https://api.github.com/repos/mozilla/signing-clients/statuses/b52adcdc250755850ab4e448234049204c98efd9","head":{"label":"rtilder:rtilder/signature-filename-agnostic","ref":"rtilder/signature-filename-agnostic","sha":"b52adcdc250755850ab4e448234049204c98efd9","user":{"login":"rtilder","id":250074,"avatar_url":"https://avatars.githubusercontent.com/u/250074?v=3","gravatar_id":"","url":"https://api.github.com/users/rtilder","html_url":"https://github.com/rtilder","followers_url":"https://api.github.com/users/rtilder/followers","following_url":"https://api.github.com/users/rtilder/following{/other_user}","gists_url":"https://api.github.com/users/rtilder/gists{/gist_id}","starred_url":"https://api.github.com/users/rtilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtilder/subscriptions","organizations_url":"https://api.github.com/users/rtilder/orgs","repos_url":"https://api.github.com/users/rtilder/repos","events_url":"https://api.github.com/users/rtilder/events{/privacy}","received_events_url":"https://api.github.com/users/rtilder/received_events","type":"User","site_admin":false},"repo":{"id":31324102,"name":"signing-clients","full_name":"rtilder/signing-clients","owner":{"login":"rtilder","id":250074,"avatar_url":"https://avatars.githubusercontent.com/u/250074?v=3","gravatar_id":"","url":"https://api.github.com/users/rtilder","html_url":"https://github.com/rtilder","followers_url":"https://api.github.com/users/rtilder/followers","following_url":"https://api.github.com/users/rtilder/following{/other_user}","gists_url":"https://api.github.com/users/rtilder/gists{/gist_id}","starred_url":"https://api.github.com/users/rtilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtilder/subscriptions","organizations_url":"https://api.github.com/users/rtilder/orgs","repos_url":"https://api.github.com/users/rtilder/repos","events_url":"https://api.github.com/users/rtilder/events{/privacy}","received_events_url":"https://api.github.com/users/rtilder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtilder/signing-clients","description":"Client libs for receipt and app signing","fork":true,"url":"https://api.github.com/repos/rtilder/signing-clients","forks_url":"https://api.github.com/repos/rtilder/signing-clients/forks","keys_url":"https://api.github.com/repos/rtilder/signing-clients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtilder/signing-clients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtilder/signing-clients/teams","hooks_url":"https://api.github.com/repos/rtilder/signing-clients/hooks","issue_events_url":"https://api.github.com/repos/rtilder/signing-clients/issues/events{/number}","events_url":"https://api.github.com/repos/rtilder/signing-clients/events","assignees_url":"https://api.github.com/repos/rtilder/signing-clients/assignees{/user}","branches_url":"https://api.github.com/repos/rtilder/signing-clients/branches{/branch}","tags_url":"https://api.github.com/repos/rtilder/signing-clients/tags","blobs_url":"https://api.github.com/repos/rtilder/signing-clients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtilder/signing-clients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtilder/signing-clients/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtilder/signing-clients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtilder/signing-clients/statuses/{sha}","languages_url":"https://api.github.com/repos/rtilder/signing-clients/languages","stargazers_url":"https://api.github.com/repos/rtilder/signing-clients/stargazers","contributors_url":"https://api.github.com/repos/rtilder/signing-clients/contributors","subscribers_url":"https://api.github.com/repos/rtilder/signing-clients/subscribers","subscription_url":"https://api.github.com/repos/rtilder/signing-clients/subscription","commits_url":"https://api.github.com/repos/rtilder/signing-clients/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtilder/signing-clients/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtilder/signing-clients/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtilder/signing-clients/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtilder/signing-clients/contents/{+path}","compare_url":"https://api.github.com/repos/rtilder/signing-clients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtilder/signing-clients/merges","archive_url":"https://api.github.com/repos/rtilder/signing-clients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtilder/signing-clients/downloads","issues_url":"https://api.github.com/repos/rtilder/signing-clients/issues{/number}","pulls_url":"https://api.github.com/repos/rtilder/signing-clients/pulls{/number}","milestones_url":"https://api.github.com/repos/rtilder/signing-clients/milestones{/number}","notifications_url":"https://api.github.com/repos/rtilder/signing-clients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtilder/signing-clients/labels{/name}","releases_url":"https://api.github.com/repos/rtilder/signing-clients/releases{/id}","created_at":"2015-02-25T16:45:39Z","updated_at":"2015-02-26T21:03:35Z","pushed_at":"2015-04-08T18:20:26Z","git_url":"git://github.com/rtilder/signing-clients.git","ssh_url":"git@github.com:rtilder/signing-clients.git","clone_url":"https://github.com/rtilder/signing-clients.git","svn_url":"https://github.com/rtilder/signing-clients","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"7ea2859c4de759a36ce62e55b65d09ff1bae4bbc","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":6675167,"name":"signing-clients","full_name":"mozilla/signing-clients","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/signing-clients","description":"Client libs for receipt and app signing","fork":false,"url":"https://api.github.com/repos/mozilla/signing-clients","forks_url":"https://api.github.com/repos/mozilla/signing-clients/forks","keys_url":"https://api.github.com/repos/mozilla/signing-clients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/signing-clients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/signing-clients/teams","hooks_url":"https://api.github.com/repos/mozilla/signing-clients/hooks","issue_events_url":"https://api.github.com/repos/mozilla/signing-clients/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/signing-clients/events","assignees_url":"https://api.github.com/repos/mozilla/signing-clients/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/signing-clients/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/signing-clients/tags","blobs_url":"https://api.github.com/repos/mozilla/signing-clients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/signing-clients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/signing-clients/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/signing-clients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/signing-clients/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/signing-clients/languages","stargazers_url":"https://api.github.com/repos/mozilla/signing-clients/stargazers","contributors_url":"https://api.github.com/repos/mozilla/signing-clients/contributors","subscribers_url":"https://api.github.com/repos/mozilla/signing-clients/subscribers","subscription_url":"https://api.github.com/repos/mozilla/signing-clients/subscription","commits_url":"https://api.github.com/repos/mozilla/signing-clients/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/signing-clients/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/signing-clients/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/signing-clients/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/signing-clients/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/signing-clients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/signing-clients/merges","archive_url":"https://api.github.com/repos/mozilla/signing-clients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/signing-clients/downloads","issues_url":"https://api.github.com/repos/mozilla/signing-clients/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/signing-clients/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/signing-clients/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/signing-clients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/signing-clients/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/signing-clients/releases{/id}","created_at":"2012-11-13T18:05:55Z","updated_at":"2015-02-26T21:03:09Z","pushed_at":"2015-04-08T18:23:07Z","git_url":"git://github.com/mozilla/signing-clients.git","ssh_url":"git@github.com:mozilla/signing-clients.git","clone_url":"https://github.com/mozilla/signing-clients.git","svn_url":"https://github.com/mozilla/signing-clients","homepage":null,"size":344,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/signing-clients/pulls/15"},"html":{"href":"https://github.com/mozilla/signing-clients/pull/15"},"issue":{"href":"https://api.github.com/repos/mozilla/signing-clients/issues/15"},"comments":{"href":"https://api.github.com/repos/mozilla/signing-clients/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/signing-clients/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/signing-clients/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/signing-clients/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/signing-clients/statuses/b52adcdc250755850ab4e448234049204c98efd9"}}}}