{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/34901835","id":34901835,"diff_hunk":"@@ -13,45 +13,49 @@ Linked vertex stage:\n                               EntryPoint Vertex 4\r\n                               Name 4  \"main\"\r\n                               Name 9  \"i\"\r\n-                              Name 24  \"gl_VertexID\"\r\n-                              Name 25  \"gl_InstanceID\"\r\n+                              Name 27  \"gl_VertexID\"\r\n+                              Name 28  \"gl_InstanceID\"\r\n                               Decorate 9(i) PrecisionHigh \r\n-                              Decorate 24(gl_VertexID) PrecisionHigh \r\n-                              Decorate 24(gl_VertexID) BuiltIn VertexId\r\n-                              Decorate 24(gl_VertexID) NoStaticUse \r\n-                              Decorate 25(gl_InstanceID) PrecisionHigh \r\n-                              Decorate 25(gl_InstanceID) BuiltIn InstanceId\r\n-                              Decorate 25(gl_InstanceID) NoStaticUse \r\n+                              Decorate 27(gl_VertexID) PrecisionHigh \r\n+                              Decorate 27(gl_VertexID) BuiltIn VertexId\r\n+                              Decorate 27(gl_VertexID) NoStaticUse \r\n+                              Decorate 28(gl_InstanceID) PrecisionHigh \r\n+                              Decorate 28(gl_InstanceID) BuiltIn InstanceId\r\n+                              Decorate 28(gl_InstanceID) NoStaticUse \r\n                2:             TypeVoid\r\n                3:             TypeFunction 2 \r\n                7:             TypeInt 32 1\r\n                8:             TypePointer Function 7(int)\r\n               10:      7(int) Constant 0\r\n-              16:      7(int) Constant 1\r\n-              19:      7(int) Constant 10\r\n-              20:             TypeBool\r\n-              23:             TypePointer Input 7(int)\r\n- 24(gl_VertexID):     23(ptr) Variable Input \r\n-25(gl_InstanceID):     23(ptr) Variable Input \r\n+              14:             TypeBool\r\n+              15:    14(bool) ConstantTrue\r\n+              20:      7(int) Constant 10\r\n+              23:      7(int) Constant 1\r\n+              25:    14(bool) ConstantFalse\r\n+              26:             TypePointer Input 7(int)\r\n+ 27(gl_VertexID):     26(ptr) Variable Input \r\n+28(gl_InstanceID):     26(ptr) Variable Input \r\n          4(main):           2 Function None 3\r\n                5:             Label\r\n             9(i):      8(ptr) Variable Function \r\n                               Store 9(i) 10 \r\n                               Branch 11\r\n               11:             Label\r\n+              13:    14(bool) Phi 15 5 25 17\r\n                               LoopMerge 12 None\r\n-                              Branch 13\r\n-              13:             Label\r\n-              15:      7(int) Load 9(i) \r\n-              17:      7(int) IAdd 15 16\r\n-                              Store 9(i) 17 \r\n-                              Branch 14\r\n-              14:             Label\r\n-              18:      7(int) Load 9(i) \r\n-              21:    20(bool) SLessThan 18 19\r\n-                              BranchConditional 21 22 12 \r\n-              22:               Label\r\n-                                Branch 11\r\n+                              Branch 16\r\n+              16:             Label\r\n+                              SelectionMerge 17 None\r\n+                              BranchConditional 13 17 18 \r\n+              18:               Label\r\n+              19:      7(int)   Load 9(i) \r\n+              21:    14(bool)   SLessThan 19 20\r\n+                                BranchConditional 21 17 12 \r","path":"Test/baseResults/spv.do-simple.vert.out","position":76,"original_position":76,"commit_id":"31945a35c20ca7ec0c1c4fc9192b91a57878b84b","original_commit_id":"31945a35c20ca7ec0c1c4fc9192b91a57878b84b","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"Does this conditional branch require a SelectionMerge before it?  If it does, it would target block 12 as the merge point, I think. \r\nIf that fix is required, I could provide it in another pull request","created_at":"2015-07-17T15:44:17Z","updated_at":"2015-07-17T15:44:17Z","html_url":"https://github.com/KhronosGroup/glslang/pull/19#discussion_r34901835","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/34901835"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/19#discussion_r34901835"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19","id":40161849,"html_url":"https://github.com/KhronosGroup/glslang/pull/19","diff_url":"https://github.com/KhronosGroup/glslang/pull/19.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/19.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/19","number":19,"state":"open","locked":false,"title":"Generate correctly structured do-while loops.","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"The loop test is always emitted before the loop body.\r\n\r\nFor do-while loops, use a phi node to track whether we're\r\non the first loop iteration, and only check the loop test\r\non the second and subsequent iterations.","created_at":"2015-07-16T18:43:44Z","updated_at":"2015-07-17T15:44:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31df87eee8a2c109ec94f9e473152df1d7c2f348","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/19/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/31945a35c20ca7ec0c1c4fc9192b91a57878b84b","head":{"label":"google:structured-do-while","ref":"structured-do-while","sha":"31945a35c20ca7ec0c1c4fc9192b91a57878b84b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":39026232,"name":"glslang","full_name":"google/glslang","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":true,"url":"https://api.github.com/repos/google/glslang","forks_url":"https://api.github.com/repos/google/glslang/forks","keys_url":"https://api.github.com/repos/google/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/glslang/teams","hooks_url":"https://api.github.com/repos/google/glslang/hooks","issue_events_url":"https://api.github.com/repos/google/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/google/glslang/events","assignees_url":"https://api.github.com/repos/google/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/google/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/google/glslang/tags","blobs_url":"https://api.github.com/repos/google/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/google/glslang/languages","stargazers_url":"https://api.github.com/repos/google/glslang/stargazers","contributors_url":"https://api.github.com/repos/google/glslang/contributors","subscribers_url":"https://api.github.com/repos/google/glslang/subscribers","subscription_url":"https://api.github.com/repos/google/glslang/subscription","commits_url":"https://api.github.com/repos/google/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/google/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/glslang/merges","archive_url":"https://api.github.com/repos/google/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/glslang/downloads","issues_url":"https://api.github.com/repos/google/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/google/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/google/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/google/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/glslang/labels{/name}","releases_url":"https://api.github.com/repos/google/glslang/releases{/id}","created_at":"2015-07-13T17:15:02Z","updated_at":"2015-07-17T02:17:28Z","pushed_at":"2015-07-16T18:37:38Z","git_url":"git://github.com/google/glslang.git","ssh_url":"git@github.com:google/glslang.git","clone_url":"https://github.com/google/glslang.git","svn_url":"https://github.com/google/glslang","homepage":null,"size":22038,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"e3933d684d1ba9ace006fe4693a5688e90cec804","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"name":"glslang","full_name":"KhronosGroup/glslang","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","created_at":"2015-06-25T17:54:39Z","updated_at":"2015-07-15T15:48:46Z","pushed_at":"2015-07-16T18:43:44Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":null,"size":22388,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/19"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/19"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/31945a35c20ca7ec0c1c4fc9192b91a57878b84b"}}}}