{"action":"created","comment":{"url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/comments/36648785","id":36648785,"diff_hunk":"@@ -161,9 +168,15 @@ public function embed($urls, $name, $width, $height, $options) {\n             if (isset($options['subtitles'])) {\n                 $tracks = array();\n                 foreach ($options['subtitles'] as $label => $subtitlefileurl) {\n-                    $tracks[] = array(\n-                        'file' => $subtitlefileurl->out(),\n-                        'label' => $label);\n+                    if ($label == 'chapters' || $label == 'thumbnails') {\n+                        $tracks[] = array(\n+                            'file' => $subtitlefileurl->out(),\n+                            'kind' => $label);\n+                    } else {\n+                        $tracks[] = array(\n+                            'file' => $subtitlefileurl->out(),","path":"lib.php","position":32,"original_position":32,"commit_id":"a0d8aff5472b98382dea18e3bfd35d5be1a396cc","original_commit_id":"a0d8aff5472b98382dea18e3bfd35d5be1a396cc","user":{"login":"owenbarritt","id":12510212,"avatar_url":"https://avatars.githubusercontent.com/u/12510212?v=3","gravatar_id":"","url":"https://api.github.com/users/owenbarritt","html_url":"https://github.com/owenbarritt","followers_url":"https://api.github.com/users/owenbarritt/followers","following_url":"https://api.github.com/users/owenbarritt/following{/other_user}","gists_url":"https://api.github.com/users/owenbarritt/gists{/gist_id}","starred_url":"https://api.github.com/users/owenbarritt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owenbarritt/subscriptions","organizations_url":"https://api.github.com/users/owenbarritt/orgs","repos_url":"https://api.github.com/users/owenbarritt/repos","events_url":"https://api.github.com/users/owenbarritt/events{/privacy}","received_events_url":"https://api.github.com/users/owenbarritt/received_events","type":"User","site_admin":false},"body":"Likewise would be better as \"->out(false)\"","created_at":"2015-08-10T16:04:22Z","updated_at":"2015-08-10T16:04:22Z","html_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/17#discussion_r36648785","pull_request_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/comments/36648785"},"html":{"href":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/17#discussion_r36648785"},"pull_request":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17","id":34995806,"html_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/17","diff_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/17.diff","patch_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/17.patch","issue_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/17","number":17,"state":"open","locked":false,"title":"chapters/thumbnails support added to subtitle feature","user":{"login":"jojoob","id":4180675,"avatar_url":"https://avatars.githubusercontent.com/u/4180675?v=3","gravatar_id":"","url":"https://api.github.com/users/jojoob","html_url":"https://github.com/jojoob","followers_url":"https://api.github.com/users/jojoob/followers","following_url":"https://api.github.com/users/jojoob/following{/other_user}","gists_url":"https://api.github.com/users/jojoob/gists{/gist_id}","starred_url":"https://api.github.com/users/jojoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojoob/subscriptions","organizations_url":"https://api.github.com/users/jojoob/orgs","repos_url":"https://api.github.com/users/jojoob/repos","events_url":"https://api.github.com/users/jojoob/events{/privacy}","received_events_url":"https://api.github.com/users/jojoob/received_events","type":"User","site_admin":false},"body":"Added support for chapters and thumbnail tracks within the subtitle feature.\r\n\r\njwplayer chapters and thumbnails feature:\r\n* http://support.jwplayer.com/customer/portal/articles/1407454-adding-chapter-markers\r\n* http://support.jwplayer.com/customer/portal/articles/1407439-adding-preview-thumbnails\r\n\r\nI will rebase the commits if everything else is ready to merge.","created_at":"2015-05-08T10:07:44Z","updated_at":"2015-08-10T16:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"792bedcdae0390f24323ba631a55366b97401610","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17/commits","review_comments_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17/comments","review_comment_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/17/comments","statuses_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/statuses/a0d8aff5472b98382dea18e3bfd35d5be1a396cc","head":{"label":"sudile:dev-tracks","ref":"dev-tracks","sha":"a0d8aff5472b98382dea18e3bfd35d5be1a396cc","user":{"login":"sudile","id":11869278,"avatar_url":"https://avatars.githubusercontent.com/u/11869278?v=3","gravatar_id":"","url":"https://api.github.com/users/sudile","html_url":"https://github.com/sudile","followers_url":"https://api.github.com/users/sudile/followers","following_url":"https://api.github.com/users/sudile/following{/other_user}","gists_url":"https://api.github.com/users/sudile/gists{/gist_id}","starred_url":"https://api.github.com/users/sudile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudile/subscriptions","organizations_url":"https://api.github.com/users/sudile/orgs","repos_url":"https://api.github.com/users/sudile/repos","events_url":"https://api.github.com/users/sudile/events{/privacy}","received_events_url":"https://api.github.com/users/sudile/received_events","type":"Organization","site_admin":false},"repo":{"id":26533207,"name":"moodle-filter_jwplayer","full_name":"sudile/moodle-filter_jwplayer","owner":{"login":"sudile","id":11869278,"avatar_url":"https://avatars.githubusercontent.com/u/11869278?v=3","gravatar_id":"","url":"https://api.github.com/users/sudile","html_url":"https://github.com/sudile","followers_url":"https://api.github.com/users/sudile/followers","following_url":"https://api.github.com/users/sudile/following{/other_user}","gists_url":"https://api.github.com/users/sudile/gists{/gist_id}","starred_url":"https://api.github.com/users/sudile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudile/subscriptions","organizations_url":"https://api.github.com/users/sudile/orgs","repos_url":"https://api.github.com/users/sudile/repos","events_url":"https://api.github.com/users/sudile/events{/privacy}","received_events_url":"https://api.github.com/users/sudile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sudile/moodle-filter_jwplayer","description":"Moodle filter that allows using JW Player for playing HTML5 and flash content.","fork":true,"url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer","forks_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/forks","keys_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/teams","hooks_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/hooks","issue_events_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/events","assignees_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/tags","blobs_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/languages","stargazers_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/stargazers","contributors_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/contributors","subscribers_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/subscribers","subscription_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/subscription","commits_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/merges","archive_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/downloads","issues_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/sudile/moodle-filter_jwplayer/releases{/id}","created_at":"2014-11-12T11:38:21Z","updated_at":"2015-07-15T08:40:55Z","pushed_at":"2015-07-10T07:22:43Z","git_url":"git://github.com/sudile/moodle-filter_jwplayer.git","ssh_url":"git@github.com:sudile/moodle-filter_jwplayer.git","clone_url":"https://github.com/sudile/moodle-filter_jwplayer.git","svn_url":"https://github.com/sudile/moodle-filter_jwplayer","homepage":"","size":277,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"fork/master"}},"base":{"label":"lucisgit:master","ref":"master","sha":"f4c8098ba964b74e1eb958cb9227c64e6c807311","user":{"login":"lucisgit","id":2512060,"avatar_url":"https://avatars.githubusercontent.com/u/2512060?v=3","gravatar_id":"","url":"https://api.github.com/users/lucisgit","html_url":"https://github.com/lucisgit","followers_url":"https://api.github.com/users/lucisgit/followers","following_url":"https://api.github.com/users/lucisgit/following{/other_user}","gists_url":"https://api.github.com/users/lucisgit/gists{/gist_id}","starred_url":"https://api.github.com/users/lucisgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucisgit/subscriptions","organizations_url":"https://api.github.com/users/lucisgit/orgs","repos_url":"https://api.github.com/users/lucisgit/repos","events_url":"https://api.github.com/users/lucisgit/events{/privacy}","received_events_url":"https://api.github.com/users/lucisgit/received_events","type":"Organization","site_admin":false},"repo":{"id":18805234,"name":"moodle-filter_jwplayer","full_name":"lucisgit/moodle-filter_jwplayer","owner":{"login":"lucisgit","id":2512060,"avatar_url":"https://avatars.githubusercontent.com/u/2512060?v=3","gravatar_id":"","url":"https://api.github.com/users/lucisgit","html_url":"https://github.com/lucisgit","followers_url":"https://api.github.com/users/lucisgit/followers","following_url":"https://api.github.com/users/lucisgit/following{/other_user}","gists_url":"https://api.github.com/users/lucisgit/gists{/gist_id}","starred_url":"https://api.github.com/users/lucisgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucisgit/subscriptions","organizations_url":"https://api.github.com/users/lucisgit/orgs","repos_url":"https://api.github.com/users/lucisgit/repos","events_url":"https://api.github.com/users/lucisgit/events{/privacy}","received_events_url":"https://api.github.com/users/lucisgit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lucisgit/moodle-filter_jwplayer","description":"Moodle filter that allows using JW Player for playing HTML5 and flash content.","fork":false,"url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer","forks_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/forks","keys_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/teams","hooks_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/hooks","issue_events_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/events","assignees_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/tags","blobs_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/languages","stargazers_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/stargazers","contributors_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/contributors","subscribers_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/subscribers","subscription_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/subscription","commits_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/merges","archive_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/downloads","issues_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/releases{/id}","created_at":"2014-04-15T15:29:30Z","updated_at":"2015-05-13T15:17:42Z","pushed_at":"2015-08-10T11:46:31Z","git_url":"git://github.com/lucisgit/moodle-filter_jwplayer.git","ssh_url":"git@github.com:lucisgit/moodle-filter_jwplayer.git","clone_url":"https://github.com/lucisgit/moodle-filter_jwplayer.git","svn_url":"https://github.com/lucisgit/moodle-filter_jwplayer","homepage":"https://moodle.org/plugins/view/filter_jwplayer","size":408,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":5,"default_branch":"JW7"}},"_links":{"self":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17"},"html":{"href":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/17"},"issue":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/17"},"comments":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/statuses/a0d8aff5472b98382dea18e3bfd35d5be1a396cc"}}}}