{"action":"created","issue":{"url":"https://api.github.com/repos/opnsense/core/issues/506","labels_url":"https://api.github.com/repos/opnsense/core/issues/506/labels{/name}","comments_url":"https://api.github.com/repos/opnsense/core/issues/506/comments","events_url":"https://api.github.com/repos/opnsense/core/issues/506/events","html_url":"https://github.com/opnsense/core/pull/506","id":120712463,"number":506,"title":"firewall: show warning banner if firewall disabled","user":{"login":"8191","id":5854959,"avatar_url":"https://avatars.githubusercontent.com/u/5854959?v=3","gravatar_id":"","url":"https://api.github.com/users/8191","html_url":"https://github.com/8191","followers_url":"https://api.github.com/users/8191/followers","following_url":"https://api.github.com/users/8191/following{/other_user}","gists_url":"https://api.github.com/users/8191/gists{/gist_id}","starred_url":"https://api.github.com/users/8191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/8191/subscriptions","organizations_url":"https://api.github.com/users/8191/orgs","repos_url":"https://api.github.com/users/8191/repos","events_url":"https://api.github.com/users/8191/events{/privacy}","received_events_url":"https://api.github.com/users/8191/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-07T06:59:53Z","updated_at":"2015-12-10T17:48:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opnsense/core/pulls/506","html_url":"https://github.com/opnsense/core/pull/506","diff_url":"https://github.com/opnsense/core/pull/506.diff","patch_url":"https://github.com/opnsense/core/pull/506.patch"},"body":"If firewall is globally disabled, show a warning banner in all relevant\r\nfirewall configuration and diagnostic screens (filter and NAT)."},"comment":{"url":"https://api.github.com/repos/opnsense/core/issues/comments/163700738","html_url":"https://github.com/opnsense/core/pull/506#issuecomment-163700738","issue_url":"https://api.github.com/repos/opnsense/core/issues/506","id":163700738,"user":{"login":"fichtner","id":1915288,"avatar_url":"https://avatars.githubusercontent.com/u/1915288?v=3","gravatar_id":"","url":"https://api.github.com/users/fichtner","html_url":"https://github.com/fichtner","followers_url":"https://api.github.com/users/fichtner/followers","following_url":"https://api.github.com/users/fichtner/following{/other_user}","gists_url":"https://api.github.com/users/fichtner/gists{/gist_id}","starred_url":"https://api.github.com/users/fichtner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fichtner/subscriptions","organizations_url":"https://api.github.com/users/fichtner/orgs","repos_url":"https://api.github.com/users/fichtner/repos","events_url":"https://api.github.com/users/fichtner/events{/privacy}","received_events_url":"https://api.github.com/users/fichtner/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T17:48:54Z","updated_at":"2015-12-10T17:48:54Z","body":"We can merge this conceptually, but we need to minimise the impact for each page, e.g. no duplication of strings or print_warning_box (print_info_box). The easiest way would be a src/www/firewall.inc which can handle this message and is included on each page where the code now resides. That way we also don't pollute guiconfig.inc any further.\r\n\r\nThe warnings are good and should probably be there for administrative pages (not diagnostics, logs, status). It should probably point to the respective settings page though...\r\n\r\nUnbound/Dnsmasq and other services are different, because these services are triggered from their respective menu entry. We talk about global settings that affect the behaviour of other pages.\r\n\r\nAnother idea would be to move system Firewall/NAT settings to firewall settings, making it clearer that the firewall can be disabled in the firewall section where it belongs. When the firewall is disabled, and all pages except settings are missing it's 100% clear where to enable it... that's the theory, but then again one could argue that the firewall section should be completely gone."}}