{"action":"created","issue":{"url":"https://api.github.com/repos/quodlibet/quodlibet/issues/1556","labels_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/1556/labels{/name}","comments_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/1556/comments","events_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/1556/events","html_url":"https://github.com/quodlibet/quodlibet/issues/1556","id":61725010,"number":1556,"title":"Add close escape accel for tagedit/info window","user":{"login":"lazka","id":991986,"avatar_url":"https://avatars.githubusercontent.com/u/991986?v=3","gravatar_id":"","url":"https://api.github.com/users/lazka","html_url":"https://github.com/lazka","followers_url":"https://api.github.com/users/lazka/followers","following_url":"https://api.github.com/users/lazka/following{/other_user}","gists_url":"https://api.github.com/users/lazka/gists{/gist_id}","starred_url":"https://api.github.com/users/lazka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazka/subscriptions","organizations_url":"https://api.github.com/users/lazka/orgs","repos_url":"https://api.github.com/users/lazka/repos","events_url":"https://api.github.com/users/lazka/events{/privacy}","received_events_url":"https://api.github.com/users/lazka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/quodlibet/quodlibet/labels/confirmed","name":"confirmed","color":"009800"},{"url":"https://api.github.com/repos/quodlibet/quodlibet/labels/enhancement","name":"enhancement","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-15T01:13:06Z","updated_at":"2015-03-23T16:27:32Z","closed_at":null,"body":"Original [issue 1556](https://code.google.com/p/quodlibet/issues/detail?id=1556) created by reiter.christoph on 2015-03-12T13:20:14.000Z:\n\nThis has come up multiple times. The initial reason it doesn't have them was (IIRC) that the HIG only specified it for dialogs and it could close the window when canceling a cellrenderer in the tag editor while changing text.\r\n\r\nTODO:\r\n\r\n1) Add a dialog for when there are unsaved changes (&quot;Close Window&quot;, &quot;Continue Editing&quot;)\r\n2) Enable esc accel"},"comment":{"url":"https://api.github.com/repos/quodlibet/quodlibet/issues/comments/85077126","html_url":"https://github.com/quodlibet/quodlibet/issues/1556#issuecomment-85077126","issue_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/1556","id":85077126,"user":{"login":"lazka","id":991986,"avatar_url":"https://avatars.githubusercontent.com/u/991986?v=3","gravatar_id":"","url":"https://api.github.com/users/lazka","html_url":"https://github.com/lazka","followers_url":"https://api.github.com/users/lazka/followers","following_url":"https://api.github.com/users/lazka/following{/other_user}","gists_url":"https://api.github.com/users/lazka/gists{/gist_id}","starred_url":"https://api.github.com/users/lazka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazka/subscriptions","organizations_url":"https://api.github.com/users/lazka/orgs","repos_url":"https://api.github.com/users/lazka/repos","events_url":"https://api.github.com/users/lazka/events{/privacy}","received_events_url":"https://api.github.com/users/lazka/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T16:27:32Z","updated_at":"2015-03-23T16:27:32Z","body":"Thanks for writing this up, sounds reasonable.\r\n\r\nThere are a few things where this collides with how GTK+ and QL currently \r\nhandles things:\r\n\r\n1. GTK+ doesn't handle ctrl+w for any dialog. This includes message dialogs\r\n   and things like \"open file\", \"about\", ... escape works on the other hand.\r\n2. QL has a few preference dialogs (global, plugins, per browser) which are\r\n   partly just beefed up menus, sometimes there are more complex widgets where\r\n   escape might clash. Currently only escape works there.\r\n\r\nIgnoring how things are, would you say that for all those windows, ctrl+w \r\nshould work and escape should not?\r\n\r\n(Looking at OS X, Xcode preferences are ctrl+w only, itunes preferences are \r\nescape only, the about dialogs allows both, the open file dialog escape \r\nonly...)\r\n"}}