{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/30441978","id":30441978,"diff_hunk":"@@ -1484,14 +1484,10 @@ private static NamedTypeSymbol GetNonDisplayClassContainer(NamedTypeSymbol type)\n                 var desiredTypeParameters = candidateSubstitutedSourceType.OriginalDefinition.TypeParameters;\n \n                 // We need to use a ThreeState, rather than a bool, because we can't distinguish between\n-                // a roslyn lambda that only captures \"this\" and a dev12 lambda that captures nothing\n-                // (neither introduces a display class).  This is unnecessary in the state machine case,\n-                // because then \"this\" is hoisted unconditionally.\n-                var isDesiredMethodStatic = hasDisplayClassThis\n-                    ? ThreeState.False\n-                    : (GeneratedNames.GetKind(candidateSubstitutedSourceType.Name) == GeneratedNameKind.StateMachineType)\n-                        ? ThreeState.True\n-                        : ThreeState.Unknown;\n+                // a Roslyn lambda that only captures \"this\" and a Dev12 lambda that captures nothing\n+                // (neither introduces a display class).  Also, \"this\" may be optimized away in async\n+                // or iterator state machines.\n+                var isDesiredMethodStatic = hasDisplayClassThis ? ThreeState.False : ThreeState.Unknown;","path":"src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/CompilationContext.cs","position":15,"original_position":15,"commit_id":"5c3097b1bc91761c75d1fdbb33135902b94a6640","original_commit_id":"5c3097b1bc91761c75d1fdbb33135902b94a6640","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"body":"Yeah, I considered whether to make it a bool, but decided that using \"ThreeState.Unknown\" expressed the intent more clearly.  I could certainly remove \"need to\" from the comment though.","created_at":"2015-05-15T20:12:41Z","updated_at":"2015-05-15T20:12:41Z","html_url":"https://github.com/dotnet/roslyn/pull/2799#discussion_r30441978","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2799","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/30441978"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2799#discussion_r30441978"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2799"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2799","id":35543114,"html_url":"https://github.com/dotnet/roslyn/pull/2799","diff_url":"https://github.com/dotnet/roslyn/pull/2799.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2799.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2799","number":2799,"state":"open","locked":false,"title":"Fix issue with locating source method in optimized code...","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"body":"We were previously assuming that \"this\" was always hoisted in async/iterator state machines.  This is not true in optimized code.\r\n\r\n(fixes #2406)","created_at":"2015-05-15T19:26:35Z","updated_at":"2015-05-15T20:12:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"655594bdeed8d70292e7e7bcddde6b0ef902bf4b","assignee":null,"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/1","html_url":"https://github.com/dotnet/roslyn/milestones/1.0%20(stable)","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/1/labels","id":937397,"number":1,"title":"1.0 (stable)","description":"This is our 1.0 Milestone. ","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":123,"closed_issues":387,"state":"open","created_at":"2015-01-15T20:45:24Z","updated_at":"2015-05-15T19:38:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2799/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2799/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2799/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/5c3097b1bc91761c75d1fdbb33135902b94a6640","head":{"label":"KevinH-MS:master","ref":"master","sha":"5c3097b1bc91761c75d1fdbb33135902b94a6640","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"repo":{"id":30554696,"name":"roslyn","full_name":"KevinH-MS/roslyn","owner":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinH-MS/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/KevinH-MS/roslyn","forks_url":"https://api.github.com/repos/KevinH-MS/roslyn/forks","keys_url":"https://api.github.com/repos/KevinH-MS/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinH-MS/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinH-MS/roslyn/teams","hooks_url":"https://api.github.com/repos/KevinH-MS/roslyn/hooks","issue_events_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/KevinH-MS/roslyn/events","assignees_url":"https://api.github.com/repos/KevinH-MS/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/KevinH-MS/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/tags","blobs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinH-MS/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinH-MS/roslyn/languages","stargazers_url":"https://api.github.com/repos/KevinH-MS/roslyn/stargazers","contributors_url":"https://api.github.com/repos/KevinH-MS/roslyn/contributors","subscribers_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscribers","subscription_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscription","commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinH-MS/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinH-MS/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/KevinH-MS/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinH-MS/roslyn/merges","archive_url":"https://api.github.com/repos/KevinH-MS/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinH-MS/roslyn/downloads","issues_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/KevinH-MS/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinH-MS/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinH-MS/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinH-MS/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/KevinH-MS/roslyn/releases{/id}","created_at":"2015-02-09T19:43:41Z","updated_at":"2015-05-04T16:17:24Z","pushed_at":"2015-05-15T19:25:43Z","git_url":"git://github.com/KevinH-MS/roslyn.git","ssh_url":"git@github.com:KevinH-MS/roslyn.git","clone_url":"https://github.com/KevinH-MS/roslyn.git","svn_url":"https://github.com/KevinH-MS/roslyn","homepage":"","size":73949,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"35af2d3b353c2a33698ef3474abb053e2edaf69e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-15T15:54:48Z","pushed_at":"2015-05-15T20:10:19Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":131838,"stargazers_count":2301,"watchers_count":2301,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":488,"mirror_url":null,"open_issues_count":837,"forks":488,"open_issues":837,"watchers":2301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2799"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2799"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2799"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2799/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2799/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2799/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/5c3097b1bc91761c75d1fdbb33135902b94a6640"}}}}