{"action":"created","comment":{"url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/comments/34667786","id":34667786,"diff_hunk":"@@ -15,17 +15,20 @@\n class caption_field implements cache_cacheableInterface\n {\n     /**\n+     *\n      * @var databox_field\n      */\n     protected $databox_field;\n \n     /**\n-     * @var string\n+     *\n+     * @var caption_Field_Value[]\n      */\n     protected $values;\n \n     /**\n-     * @var record_adapter\n+     *","path":"lib/classes/caption/field.php","position":18,"original_position":18,"commit_id":"6b21f39d9798fdbf944aa60033a7a9b952bcc43b","original_commit_id":"6b21f39d9798fdbf944aa60033a7a9b952bcc43b","user":{"login":"bburnichon","id":2437286,"avatar_url":"https://avatars.githubusercontent.com/u/2437286?v=3","gravatar_id":"","url":"https://api.github.com/users/bburnichon","html_url":"https://github.com/bburnichon","followers_url":"https://api.github.com/users/bburnichon/followers","following_url":"https://api.github.com/users/bburnichon/following{/other_user}","gists_url":"https://api.github.com/users/bburnichon/gists{/gist_id}","starred_url":"https://api.github.com/users/bburnichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bburnichon/subscriptions","organizations_url":"https://api.github.com/users/bburnichon/orgs","repos_url":"https://api.github.com/users/bburnichon/repos","events_url":"https://api.github.com/users/bburnichon/events{/privacy}","received_events_url":"https://api.github.com/users/bburnichon/received_events","type":"User","site_admin":false},"body":"useless line","created_at":"2015-07-15T11:06:07Z","updated_at":"2015-07-15T11:06:07Z","html_url":"https://github.com/alchemy-fr/Phraseanet/pull/1432#discussion_r34667786","pull_request_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432","_links":{"self":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/comments/34667786"},"html":{"href":"https://github.com/alchemy-fr/Phraseanet/pull/1432#discussion_r34667786"},"pull_request":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432"}}},"pull_request":{"url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432","id":39822138,"html_url":"https://github.com/alchemy-fr/Phraseanet/pull/1432","diff_url":"https://github.com/alchemy-fr/Phraseanet/pull/1432.diff","patch_url":"https://github.com/alchemy-fr/Phraseanet/pull/1432.patch","issue_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues/1432","number":1432,"state":"open","locked":false,"title":"PHRAS-504 #time 8h","user":{"login":"jygaulier","id":1247618,"avatar_url":"https://avatars.githubusercontent.com/u/1247618?v=3","gravatar_id":"","url":"https://api.github.com/users/jygaulier","html_url":"https://github.com/jygaulier","followers_url":"https://api.github.com/users/jygaulier/followers","following_url":"https://api.github.com/users/jygaulier/following{/other_user}","gists_url":"https://api.github.com/users/jygaulier/gists{/gist_id}","starred_url":"https://api.github.com/users/jygaulier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jygaulier/subscriptions","organizations_url":"https://api.github.com/users/jygaulier/orgs","repos_url":"https://api.github.com/users/jygaulier/repos","events_url":"https://api.github.com/users/jygaulier/events{/privacy}","received_events_url":"https://api.github.com/users/jygaulier/received_events","type":"User","site_admin":false},"body":"fix: prod / cr-lf in metadata is ok for aggregate  filter\r\ncr,lf,crlf are normalized\r\n- getting field values from recordadapter\r\n- during es indexation (direct sql read in metadata...)\r\n- before querying","created_at":"2015-07-13T15:11:07Z","updated_at":"2015-07-15T11:06:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"339a16c595334a27439c9d7ef285e15f356d39c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432/commits","review_comments_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432/comments","review_comment_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues/1432/comments","statuses_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/statuses/6b21f39d9798fdbf944aa60033a7a9b952bcc43b","head":{"label":"jygaulier:PHRAS-504_CRLF-in-proposals","ref":"PHRAS-504_CRLF-in-proposals","sha":"6b21f39d9798fdbf944aa60033a7a9b952bcc43b","user":{"login":"jygaulier","id":1247618,"avatar_url":"https://avatars.githubusercontent.com/u/1247618?v=3","gravatar_id":"","url":"https://api.github.com/users/jygaulier","html_url":"https://github.com/jygaulier","followers_url":"https://api.github.com/users/jygaulier/followers","following_url":"https://api.github.com/users/jygaulier/following{/other_user}","gists_url":"https://api.github.com/users/jygaulier/gists{/gist_id}","starred_url":"https://api.github.com/users/jygaulier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jygaulier/subscriptions","organizations_url":"https://api.github.com/users/jygaulier/orgs","repos_url":"https://api.github.com/users/jygaulier/repos","events_url":"https://api.github.com/users/jygaulier/events{/privacy}","received_events_url":"https://api.github.com/users/jygaulier/received_events","type":"User","site_admin":false},"repo":{"id":4204287,"name":"Phraseanet","full_name":"jygaulier/Phraseanet","owner":{"login":"jygaulier","id":1247618,"avatar_url":"https://avatars.githubusercontent.com/u/1247618?v=3","gravatar_id":"","url":"https://api.github.com/users/jygaulier","html_url":"https://github.com/jygaulier","followers_url":"https://api.github.com/users/jygaulier/followers","following_url":"https://api.github.com/users/jygaulier/following{/other_user}","gists_url":"https://api.github.com/users/jygaulier/gists{/gist_id}","starred_url":"https://api.github.com/users/jygaulier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jygaulier/subscriptions","organizations_url":"https://api.github.com/users/jygaulier/orgs","repos_url":"https://api.github.com/users/jygaulier/repos","events_url":"https://api.github.com/users/jygaulier/events{/privacy}","received_events_url":"https://api.github.com/users/jygaulier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jygaulier/Phraseanet","description":"Digital Asset Management PHP app","fork":true,"url":"https://api.github.com/repos/jygaulier/Phraseanet","forks_url":"https://api.github.com/repos/jygaulier/Phraseanet/forks","keys_url":"https://api.github.com/repos/jygaulier/Phraseanet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jygaulier/Phraseanet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jygaulier/Phraseanet/teams","hooks_url":"https://api.github.com/repos/jygaulier/Phraseanet/hooks","issue_events_url":"https://api.github.com/repos/jygaulier/Phraseanet/issues/events{/number}","events_url":"https://api.github.com/repos/jygaulier/Phraseanet/events","assignees_url":"https://api.github.com/repos/jygaulier/Phraseanet/assignees{/user}","branches_url":"https://api.github.com/repos/jygaulier/Phraseanet/branches{/branch}","tags_url":"https://api.github.com/repos/jygaulier/Phraseanet/tags","blobs_url":"https://api.github.com/repos/jygaulier/Phraseanet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jygaulier/Phraseanet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jygaulier/Phraseanet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jygaulier/Phraseanet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jygaulier/Phraseanet/statuses/{sha}","languages_url":"https://api.github.com/repos/jygaulier/Phraseanet/languages","stargazers_url":"https://api.github.com/repos/jygaulier/Phraseanet/stargazers","contributors_url":"https://api.github.com/repos/jygaulier/Phraseanet/contributors","subscribers_url":"https://api.github.com/repos/jygaulier/Phraseanet/subscribers","subscription_url":"https://api.github.com/repos/jygaulier/Phraseanet/subscription","commits_url":"https://api.github.com/repos/jygaulier/Phraseanet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jygaulier/Phraseanet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jygaulier/Phraseanet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jygaulier/Phraseanet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jygaulier/Phraseanet/contents/{+path}","compare_url":"https://api.github.com/repos/jygaulier/Phraseanet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jygaulier/Phraseanet/merges","archive_url":"https://api.github.com/repos/jygaulier/Phraseanet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jygaulier/Phraseanet/downloads","issues_url":"https://api.github.com/repos/jygaulier/Phraseanet/issues{/number}","pulls_url":"https://api.github.com/repos/jygaulier/Phraseanet/pulls{/number}","milestones_url":"https://api.github.com/repos/jygaulier/Phraseanet/milestones{/number}","notifications_url":"https://api.github.com/repos/jygaulier/Phraseanet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jygaulier/Phraseanet/labels{/name}","releases_url":"https://api.github.com/repos/jygaulier/Phraseanet/releases{/id}","created_at":"2012-05-02T15:13:15Z","updated_at":"2014-06-17T17:24:09Z","pushed_at":"2015-07-15T10:14:42Z","git_url":"git://github.com/jygaulier/Phraseanet.git","ssh_url":"git@github.com:jygaulier/Phraseanet.git","clone_url":"https://github.com/jygaulier/Phraseanet.git","svn_url":"https://github.com/jygaulier/Phraseanet","homepage":"http://www.phraseanet.com","size":230122,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"Dev"}},"base":{"label":"alchemy-fr:master","ref":"master","sha":"85283c1b90a738c2589fffbf5d1736649173c529","user":{"login":"alchemy-fr","id":621336,"avatar_url":"https://avatars.githubusercontent.com/u/621336?v=3","gravatar_id":"","url":"https://api.github.com/users/alchemy-fr","html_url":"https://github.com/alchemy-fr","followers_url":"https://api.github.com/users/alchemy-fr/followers","following_url":"https://api.github.com/users/alchemy-fr/following{/other_user}","gists_url":"https://api.github.com/users/alchemy-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/alchemy-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alchemy-fr/subscriptions","organizations_url":"https://api.github.com/users/alchemy-fr/orgs","repos_url":"https://api.github.com/users/alchemy-fr/repos","events_url":"https://api.github.com/users/alchemy-fr/events{/privacy}","received_events_url":"https://api.github.com/users/alchemy-fr/received_events","type":"Organization","site_admin":false},"repo":{"id":1374101,"name":"Phraseanet","full_name":"alchemy-fr/Phraseanet","owner":{"login":"alchemy-fr","id":621336,"avatar_url":"https://avatars.githubusercontent.com/u/621336?v=3","gravatar_id":"","url":"https://api.github.com/users/alchemy-fr","html_url":"https://github.com/alchemy-fr","followers_url":"https://api.github.com/users/alchemy-fr/followers","following_url":"https://api.github.com/users/alchemy-fr/following{/other_user}","gists_url":"https://api.github.com/users/alchemy-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/alchemy-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alchemy-fr/subscriptions","organizations_url":"https://api.github.com/users/alchemy-fr/orgs","repos_url":"https://api.github.com/users/alchemy-fr/repos","events_url":"https://api.github.com/users/alchemy-fr/events{/privacy}","received_events_url":"https://api.github.com/users/alchemy-fr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alchemy-fr/Phraseanet","description":"Digital Asset Management PHP app","fork":false,"url":"https://api.github.com/repos/alchemy-fr/Phraseanet","forks_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/forks","keys_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/teams","hooks_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/hooks","issue_events_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues/events{/number}","events_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/events","assignees_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/assignees{/user}","branches_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/branches{/branch}","tags_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/tags","blobs_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/statuses/{sha}","languages_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/languages","stargazers_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/stargazers","contributors_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/contributors","subscribers_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/subscribers","subscription_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/subscription","commits_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/contents/{+path}","compare_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/merges","archive_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/downloads","issues_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues{/number}","pulls_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls{/number}","milestones_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/milestones{/number}","notifications_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/labels{/name}","releases_url":"https://api.github.com/repos/alchemy-fr/Phraseanet/releases{/id}","created_at":"2011-02-16T14:55:31Z","updated_at":"2015-06-22T18:25:24Z","pushed_at":"2015-07-15T11:00:01Z","git_url":"git://github.com/alchemy-fr/Phraseanet.git","ssh_url":"git@github.com:alchemy-fr/Phraseanet.git","clone_url":"https://github.com/alchemy-fr/Phraseanet.git","svn_url":"https://github.com/alchemy-fr/Phraseanet","homepage":"http://www.phraseanet.com","size":238901,"stargazers_count":61,"watchers_count":61,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":8,"forks":27,"open_issues":8,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432"},"html":{"href":"https://github.com/alchemy-fr/Phraseanet/pull/1432"},"issue":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues/1432"},"comments":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/issues/1432/comments"},"review_comments":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432/comments"},"review_comment":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/pulls/1432/commits"},"statuses":{"href":"https://api.github.com/repos/alchemy-fr/Phraseanet/statuses/6b21f39d9798fdbf944aa60033a7a9b952bcc43b"}}}}