{"action":"created","comment":{"url":"https://api.github.com/repos/bonobos/spree/pulls/comments/31463317","id":31463317,"diff_hunk":"@@ -459,24 +477,35 @@\n     end\n   end\n \n+  describe \"#part_of_exchange?\" do\n+    context \"exchange variant exists\" do\n+      before { allow(subject).to receive(:exchange_variant).and_return(mock_model(Spree::Variant)) }\n+      it { expect(subject.part_of_exchange?).to eq true }\n+    end\n+    context \"it's the exchange itself being returned\" do\n+      before { expect(subject).to receive(:sibling_intended_for_exchange).with('unexchanged').and_return(true) }\n+      it { expect(subject.part_of_exchange?).to eq true }\n+    end","path":"core/spec/models/spree/return_item_spec.rb","position":132,"original_position":132,"commit_id":"6544fd2b162e130f040b424bd377910028eadae2","original_commit_id":"6544fd2b162e130f040b424bd377910028eadae2","user":{"login":"gmacdougall","id":764390,"avatar_url":"https://avatars.githubusercontent.com/u/764390?v=3","gravatar_id":"","url":"https://api.github.com/users/gmacdougall","html_url":"https://github.com/gmacdougall","followers_url":"https://api.github.com/users/gmacdougall/followers","following_url":"https://api.github.com/users/gmacdougall/following{/other_user}","gists_url":"https://api.github.com/users/gmacdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/gmacdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmacdougall/subscriptions","organizations_url":"https://api.github.com/users/gmacdougall/orgs","repos_url":"https://api.github.com/users/gmacdougall/repos","events_url":"https://api.github.com/users/gmacdougall/events{/privacy}","received_events_url":"https://api.github.com/users/gmacdougall/received_events","type":"User","site_admin":false},"body":"What would cause part_of_exchange? to be false?","created_at":"2015-06-01T19:55:37Z","updated_at":"2015-06-01T19:55:37Z","html_url":"https://github.com/bonobos/spree/pull/378#discussion_r31463317","pull_request_url":"https://api.github.com/repos/bonobos/spree/pulls/378","_links":{"self":{"href":"https://api.github.com/repos/bonobos/spree/pulls/comments/31463317"},"html":{"href":"https://github.com/bonobos/spree/pull/378#discussion_r31463317"},"pull_request":{"href":"https://api.github.com/repos/bonobos/spree/pulls/378"}}},"pull_request":{"url":"https://api.github.com/repos/bonobos/spree/pulls/378","id":35972363,"html_url":"https://github.com/bonobos/spree/pull/378","diff_url":"https://github.com/bonobos/spree/pull/378.diff","patch_url":"https://github.com/bonobos/spree/pull/378.patch","issue_url":"https://api.github.com/repos/bonobos/spree/issues/378","number":378,"state":"open","locked":false,"title":"Returned exchange item should cancel charge of unreturned original item","user":{"login":"gvaughn","id":10173,"avatar_url":"https://avatars.githubusercontent.com/u/10173?v=3","gravatar_id":"","url":"https://api.github.com/users/gvaughn","html_url":"https://github.com/gvaughn","followers_url":"https://api.github.com/users/gvaughn/followers","following_url":"https://api.github.com/users/gvaughn/following{/other_user}","gists_url":"https://api.github.com/users/gvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/gvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvaughn/subscriptions","organizations_url":"https://api.github.com/users/gvaughn/orgs","repos_url":"https://api.github.com/users/gvaughn/repos","events_url":"https://api.github.com/users/gvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/gvaughn/received_events","type":"User","site_admin":false},"body":"I'm going with a new 'unexchanged' status of the original ReturnItem.\r\nI've added :unexchanged as a COMPLETED_RECEPTION_STATUSES so it won't get picked up with exchanges.rake. No tests fail, and it seems reasonable to be treated like :received, but still needs more brainpower devoted to it.\r\n","created_at":"2015-05-21T20:10:25Z","updated_at":"2015-06-01T19:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ad6b0087d16d66e90e8e0f539185adb5984ff8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bonobos/spree/pulls/378/commits","review_comments_url":"https://api.github.com/repos/bonobos/spree/pulls/378/comments","review_comment_url":"https://api.github.com/repos/bonobos/spree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bonobos/spree/issues/378/comments","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/6544fd2b162e130f040b424bd377910028eadae2","head":{"label":"bonobos:exchange-haha-only-kidding","ref":"exchange-haha-only-kidding","sha":"6544fd2b162e130f040b424bd377910028eadae2","user":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"repo":{"id":12625383,"name":"spree","full_name":"bonobos/spree","owner":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonobos/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/bonobos/spree","forks_url":"https://api.github.com/repos/bonobos/spree/forks","keys_url":"https://api.github.com/repos/bonobos/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonobos/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonobos/spree/teams","hooks_url":"https://api.github.com/repos/bonobos/spree/hooks","issue_events_url":"https://api.github.com/repos/bonobos/spree/issues/events{/number}","events_url":"https://api.github.com/repos/bonobos/spree/events","assignees_url":"https://api.github.com/repos/bonobos/spree/assignees{/user}","branches_url":"https://api.github.com/repos/bonobos/spree/branches{/branch}","tags_url":"https://api.github.com/repos/bonobos/spree/tags","blobs_url":"https://api.github.com/repos/bonobos/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonobos/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonobos/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonobos/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/bonobos/spree/languages","stargazers_url":"https://api.github.com/repos/bonobos/spree/stargazers","contributors_url":"https://api.github.com/repos/bonobos/spree/contributors","subscribers_url":"https://api.github.com/repos/bonobos/spree/subscribers","subscription_url":"https://api.github.com/repos/bonobos/spree/subscription","commits_url":"https://api.github.com/repos/bonobos/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonobos/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonobos/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonobos/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonobos/spree/contents/{+path}","compare_url":"https://api.github.com/repos/bonobos/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonobos/spree/merges","archive_url":"https://api.github.com/repos/bonobos/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonobos/spree/downloads","issues_url":"https://api.github.com/repos/bonobos/spree/issues{/number}","pulls_url":"https://api.github.com/repos/bonobos/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/bonobos/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/bonobos/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonobos/spree/labels{/name}","releases_url":"https://api.github.com/repos/bonobos/spree/releases{/id}","created_at":"2013-09-05T18:28:25Z","updated_at":"2015-05-07T18:58:45Z","pushed_at":"2015-06-01T19:41:29Z","git_url":"git://github.com/bonobos/spree.git","ssh_url":"git@github.com:bonobos/spree.git","clone_url":"https://github.com/bonobos/spree.git","svn_url":"https://github.com/bonobos/spree","homepage":"http://spreecommerce.com","size":82791,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":1,"default_branch":"2-2-dev"}},"base":{"label":"bonobos:2-2-dev","ref":"2-2-dev","sha":"1ee0488186d1c232d872016d98f7665f93db9eb4","user":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"repo":{"id":12625383,"name":"spree","full_name":"bonobos/spree","owner":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonobos/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/bonobos/spree","forks_url":"https://api.github.com/repos/bonobos/spree/forks","keys_url":"https://api.github.com/repos/bonobos/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonobos/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonobos/spree/teams","hooks_url":"https://api.github.com/repos/bonobos/spree/hooks","issue_events_url":"https://api.github.com/repos/bonobos/spree/issues/events{/number}","events_url":"https://api.github.com/repos/bonobos/spree/events","assignees_url":"https://api.github.com/repos/bonobos/spree/assignees{/user}","branches_url":"https://api.github.com/repos/bonobos/spree/branches{/branch}","tags_url":"https://api.github.com/repos/bonobos/spree/tags","blobs_url":"https://api.github.com/repos/bonobos/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonobos/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonobos/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonobos/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/bonobos/spree/languages","stargazers_url":"https://api.github.com/repos/bonobos/spree/stargazers","contributors_url":"https://api.github.com/repos/bonobos/spree/contributors","subscribers_url":"https://api.github.com/repos/bonobos/spree/subscribers","subscription_url":"https://api.github.com/repos/bonobos/spree/subscription","commits_url":"https://api.github.com/repos/bonobos/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonobos/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonobos/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonobos/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonobos/spree/contents/{+path}","compare_url":"https://api.github.com/repos/bonobos/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonobos/spree/merges","archive_url":"https://api.github.com/repos/bonobos/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonobos/spree/downloads","issues_url":"https://api.github.com/repos/bonobos/spree/issues{/number}","pulls_url":"https://api.github.com/repos/bonobos/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/bonobos/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/bonobos/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonobos/spree/labels{/name}","releases_url":"https://api.github.com/repos/bonobos/spree/releases{/id}","created_at":"2013-09-05T18:28:25Z","updated_at":"2015-05-07T18:58:45Z","pushed_at":"2015-06-01T19:41:29Z","git_url":"git://github.com/bonobos/spree.git","ssh_url":"git@github.com:bonobos/spree.git","clone_url":"https://github.com/bonobos/spree.git","svn_url":"https://github.com/bonobos/spree","homepage":"http://spreecommerce.com","size":82791,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":1,"default_branch":"2-2-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bonobos/spree/pulls/378"},"html":{"href":"https://github.com/bonobos/spree/pull/378"},"issue":{"href":"https://api.github.com/repos/bonobos/spree/issues/378"},"comments":{"href":"https://api.github.com/repos/bonobos/spree/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/bonobos/spree/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/bonobos/spree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bonobos/spree/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/bonobos/spree/statuses/6544fd2b162e130f040b424bd377910028eadae2"}}}}