{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/18665","labels_url":"https://api.github.com/repos/rails/rails/issues/18665/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/18665/comments","events_url":"https://api.github.com/repos/rails/rails/issues/18665/events","html_url":"https://github.com/rails/rails/pull/18665","id":55344428,"number":18665,"title":"Allow `method: \"all\"` as a valid routing test option","user":{"login":"sgrif","id":1529387,"avatar_url":"https://avatars.githubusercontent.com/u/1529387?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-23T23:02:28Z","updated_at":"2015-02-20T16:42:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/18665","html_url":"https://github.com/rails/rails/pull/18665","diff_url":"https://github.com/rails/rails/pull/18665.diff","patch_url":"https://github.com/rails/rails/pull/18665.patch"},"body":"This allows the test to mirror the production code, since `via: :all` is\r\na valid option. The behavior in 4.1 did not actually test that it\r\nmatched all verbs, but instead defaulted to testing for \"GET\". This\r\nimplementation aims to better handle the intention of passing \"all\".\r\n\r\nWhat will actually be asserted doesn't quite match up with the generated\r\nroute, since it appears to just not create a constraint on the method.\r\nHowever, I don't think that we can easily test the lack of that\r\nconstraint. Testing each of the main 4 HTTP verbs seems to be a\r\nreasonably close approximation, which should be sufficient for our\r\nneeds.\r\n\r\nFixes #18511."},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/75269932","html_url":"https://github.com/rails/rails/pull/18665#issuecomment-75269932","issue_url":"https://api.github.com/repos/rails/rails/issues/18665","id":75269932,"user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T16:42:25Z","updated_at":"2015-02-20T16:42:25Z","body":"Seems good to me. :shipit: "}}