{"action":"closed","number":28994,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/28994","id":51052584,"html_url":"https://github.com/saltstack/salt/pull/28994","diff_url":"https://github.com/saltstack/salt/pull/28994.diff","patch_url":"https://github.com/saltstack/salt/pull/28994.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/28994","number":28994,"state":"closed","locked":false,"title":"add support to s3 for aws role assumption","user":{"login":"timcharper","id":183,"avatar_url":"https://avatars.githubusercontent.com/u/183?v=3","gravatar_id":"","url":"https://api.github.com/users/timcharper","html_url":"https://github.com/timcharper","followers_url":"https://api.github.com/users/timcharper/followers","following_url":"https://api.github.com/users/timcharper/following{/other_user}","gists_url":"https://api.github.com/users/timcharper/gists{/gist_id}","starred_url":"https://api.github.com/users/timcharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcharper/subscriptions","organizations_url":"https://api.github.com/users/timcharper/orgs","repos_url":"https://api.github.com/users/timcharper/repos","events_url":"https://api.github.com/users/timcharper/events{/privacy}","received_events_url":"https://api.github.com/users/timcharper/received_events","type":"User","site_admin":false},"body":"Addresses #28991\r\n\r\nThis patch adds support for role assumption to s3; it adds the configuration option `s3.role_arn` to the config options for s3, then enables support in the corresponding modules.\r\n\r\nIf `role_arn` is passed in to sig4, then an API call to http://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html is made, and the session `keyid`, `key`, and `token` are returned and used, instead.\r\n\r\nI made a guess and figured that my changes would break the test, but actually am not able to run them (i get the following output):\r\n\r\n```\r\n*** unit.modules.s3_test Tests  **********************************************************************************************************************************************************\r\n --------  Skipped Tests  ----------------------------------------------------------------------------------------------------------------------------------------------------------------\r\n   -> unit.modules.s3_test.S3TestCase.test_delete  ->  mock python module is unavailable\r\n   -> unit.modules.s3_test.S3TestCase.test_get     ->  mock python module is unavailable\r\n   -> unit.modules.s3_test.S3TestCase.test_head    ->  mock python module is unavailable\r\n   -> unit.modules.s3_test.S3TestCase.test_put     ->  mock python module is unavailable\r\n```\r\n\r\nThank you for saltstack.","created_at":"2015-11-18T07:53:33Z","updated_at":"2015-11-30T20:52:18Z","closed_at":"2015-11-30T20:52:18Z","merged_at":"2015-11-30T20:52:18Z","merge_commit_sha":"7902c0c816d3a2ded994fa8ec2e9b4f5949d67be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/28994/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/28994/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/28994/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/e0609868286a684870048e43790007b3ba1bf86d","head":{"label":"timcharper:2015.8.1-dev","ref":"2015.8.1-dev","sha":"e0609868286a684870048e43790007b3ba1bf86d","user":{"login":"timcharper","id":183,"avatar_url":"https://avatars.githubusercontent.com/u/183?v=3","gravatar_id":"","url":"https://api.github.com/users/timcharper","html_url":"https://github.com/timcharper","followers_url":"https://api.github.com/users/timcharper/followers","following_url":"https://api.github.com/users/timcharper/following{/other_user}","gists_url":"https://api.github.com/users/timcharper/gists{/gist_id}","starred_url":"https://api.github.com/users/timcharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcharper/subscriptions","organizations_url":"https://api.github.com/users/timcharper/orgs","repos_url":"https://api.github.com/users/timcharper/repos","events_url":"https://api.github.com/users/timcharper/events{/privacy}","received_events_url":"https://api.github.com/users/timcharper/received_events","type":"User","site_admin":false},"repo":{"id":46021756,"name":"salt","full_name":"timcharper/salt","owner":{"login":"timcharper","id":183,"avatar_url":"https://avatars.githubusercontent.com/u/183?v=3","gravatar_id":"","url":"https://api.github.com/users/timcharper","html_url":"https://github.com/timcharper","followers_url":"https://api.github.com/users/timcharper/followers","following_url":"https://api.github.com/users/timcharper/following{/other_user}","gists_url":"https://api.github.com/users/timcharper/gists{/gist_id}","starred_url":"https://api.github.com/users/timcharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcharper/subscriptions","organizations_url":"https://api.github.com/users/timcharper/orgs","repos_url":"https://api.github.com/users/timcharper/repos","events_url":"https://api.github.com/users/timcharper/events{/privacy}","received_events_url":"https://api.github.com/users/timcharper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timcharper/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/timcharper/salt","forks_url":"https://api.github.com/repos/timcharper/salt/forks","keys_url":"https://api.github.com/repos/timcharper/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timcharper/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timcharper/salt/teams","hooks_url":"https://api.github.com/repos/timcharper/salt/hooks","issue_events_url":"https://api.github.com/repos/timcharper/salt/issues/events{/number}","events_url":"https://api.github.com/repos/timcharper/salt/events","assignees_url":"https://api.github.com/repos/timcharper/salt/assignees{/user}","branches_url":"https://api.github.com/repos/timcharper/salt/branches{/branch}","tags_url":"https://api.github.com/repos/timcharper/salt/tags","blobs_url":"https://api.github.com/repos/timcharper/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timcharper/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timcharper/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/timcharper/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timcharper/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/timcharper/salt/languages","stargazers_url":"https://api.github.com/repos/timcharper/salt/stargazers","contributors_url":"https://api.github.com/repos/timcharper/salt/contributors","subscribers_url":"https://api.github.com/repos/timcharper/salt/subscribers","subscription_url":"https://api.github.com/repos/timcharper/salt/subscription","commits_url":"https://api.github.com/repos/timcharper/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/timcharper/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/timcharper/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/timcharper/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/timcharper/salt/contents/{+path}","compare_url":"https://api.github.com/repos/timcharper/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timcharper/salt/merges","archive_url":"https://api.github.com/repos/timcharper/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timcharper/salt/downloads","issues_url":"https://api.github.com/repos/timcharper/salt/issues{/number}","pulls_url":"https://api.github.com/repos/timcharper/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/timcharper/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/timcharper/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timcharper/salt/labels{/name}","releases_url":"https://api.github.com/repos/timcharper/salt/releases{/id}","created_at":"2015-11-12T01:39:07Z","updated_at":"2015-11-12T01:39:30Z","pushed_at":"2015-11-28T07:58:19Z","git_url":"git://github.com/timcharper/salt.git","ssh_url":"git@github.com:timcharper/salt.git","clone_url":"https://github.com/timcharper/salt.git","svn_url":"https://github.com/timcharper/salt","homepage":"saltstack.com","size":128279,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2015.8","ref":"2015.8","sha":"b225263279f2b8ac68358c3c514101e00dfc5075","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-11-30T20:02:13Z","pushed_at":"2015-11-30T20:52:17Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":143030,"stargazers_count":5940,"watchers_count":5940,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2559,"mirror_url":null,"open_issues_count":3217,"forks":2559,"open_issues":3217,"watchers":5940,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28994"},"html":{"href":"https://github.com/saltstack/salt/pull/28994"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/28994"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/28994/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28994/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28994/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/e0609868286a684870048e43790007b3ba1bf86d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"comments":15,"review_comments":1,"commits":1,"additions":97,"deletions":29,"changed_files":4}}