{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/22691528","id":22691528,"diff_hunk":"@@ -142,12 +142,12 @@ class Address\n     template <class Hasher>\n     friend\n     void\n-    hash_append(Hasher& h, Address const& addr)\n+    hash_append(Hasher& h, Address const& addr) noexcept\n     {\n         using beast::hash_append;\n         if (addr.is_v4 ())\n             hash_append(h, addr.to_v4 ());\n-        else\n+        else if (addr.is_v6 ())\n             hash_append(h, addr.to_v6 ());","path":"src/beast/beast/net/IPAddress.h","position":45,"original_position":45,"commit_id":"93d4c8d10a2f95846b63bf6c382b3142be1d0e3b","original_commit_id":"93d4c8d10a2f95846b63bf6c382b3142be1d0e3b","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"What if it's neither? When the proverbial IP v7 does come along, I'd hate for this function to potentially get missed and become a NOOP.","created_at":"2015-01-08T23:26:05Z","updated_at":"2015-01-08T23:26:05Z","html_url":"https://github.com/ripple/rippled/pull/789#discussion_r22691528","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/789","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/22691528"},"html":{"href":"https://github.com/ripple/rippled/pull/789#discussion_r22691528"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/789"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/789","id":26965558,"html_url":"https://github.com/ripple/rippled/pull/789","diff_url":"https://github.com/ripple/rippled/pull/789.diff","patch_url":"https://github.com/ripple/rippled/pull/789.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/789","number":789,"state":"open","locked":false,"title":"Ensure that hash_append will never throw","user":{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"body":"Reviewers: @HowardHinnant, @ximinez","created_at":"2015-01-07T15:50:29Z","updated_at":"2015-01-08T23:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"325be5ced559f10d5c3664fba5eae19b889ac59e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/789/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/789/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/789/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/93d4c8d10a2f95846b63bf6c382b3142be1d0e3b","head":{"label":"nbougalis:hashex","ref":"hashex","sha":"93d4c8d10a2f95846b63bf6c382b3142be1d0e3b","user":{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"repo":{"id":12092814,"name":"rippled","full_name":"nbougalis/rippled","owner":{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nbougalis/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/nbougalis/rippled","forks_url":"https://api.github.com/repos/nbougalis/rippled/forks","keys_url":"https://api.github.com/repos/nbougalis/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbougalis/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbougalis/rippled/teams","hooks_url":"https://api.github.com/repos/nbougalis/rippled/hooks","issue_events_url":"https://api.github.com/repos/nbougalis/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/nbougalis/rippled/events","assignees_url":"https://api.github.com/repos/nbougalis/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/nbougalis/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/nbougalis/rippled/tags","blobs_url":"https://api.github.com/repos/nbougalis/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbougalis/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbougalis/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbougalis/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbougalis/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/nbougalis/rippled/languages","stargazers_url":"https://api.github.com/repos/nbougalis/rippled/stargazers","contributors_url":"https://api.github.com/repos/nbougalis/rippled/contributors","subscribers_url":"https://api.github.com/repos/nbougalis/rippled/subscribers","subscription_url":"https://api.github.com/repos/nbougalis/rippled/subscription","commits_url":"https://api.github.com/repos/nbougalis/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbougalis/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbougalis/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbougalis/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/nbougalis/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/nbougalis/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbougalis/rippled/merges","archive_url":"https://api.github.com/repos/nbougalis/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbougalis/rippled/downloads","issues_url":"https://api.github.com/repos/nbougalis/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/nbougalis/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/nbougalis/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/nbougalis/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbougalis/rippled/labels{/name}","releases_url":"https://api.github.com/repos/nbougalis/rippled/releases{/id}","created_at":"2013-08-13T20:58:04Z","updated_at":"2014-12-31T09:58:36Z","pushed_at":"2015-01-08T12:26:38Z","git_url":"git://github.com/nbougalis/rippled.git","ssh_url":"git@github.com:nbougalis/rippled.git","clone_url":"https://github.com/nbougalis/rippled.git","svn_url":"https://github.com/nbougalis/rippled","homepage":"https://ripple.com","size":49016,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop-next"}},"base":{"label":"ripple:develop","ref":"develop","sha":"df966a9ac6dd986585ecccb206aff24452e41a30","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2015-01-08T07:18:20Z","pushed_at":"2015-01-06T03:05:00Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":97101,"stargazers_count":898,"watchers_count":898,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":143,"forks":246,"open_issues":143,"watchers":898,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/789"},"html":{"href":"https://github.com/ripple/rippled/pull/789"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/789"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/789/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/789/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/789/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/93d4c8d10a2f95846b63bf6c382b3142be1d0e3b"}}}}