{"action":"created","issue":{"url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/issues/395","labels_url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/issues/395/comments","events_url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/issues/395/events","html_url":"https://github.com/PixarAnimationStudios/OpenSubdiv/issues/395","id":57370822,"number":395,"title":"maximum valence for a triangle face is incorrect","user":{"login":"shengfuintel","id":3935335,"avatar_url":"https://avatars.githubusercontent.com/u/3935335?v=3","gravatar_id":"","url":"https://api.github.com/users/shengfuintel","html_url":"https://github.com/shengfuintel","followers_url":"https://api.github.com/users/shengfuintel/followers","following_url":"https://api.github.com/users/shengfuintel/following{/other_user}","gists_url":"https://api.github.com/users/shengfuintel/gists{/gist_id}","starred_url":"https://api.github.com/users/shengfuintel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengfuintel/subscriptions","organizations_url":"https://api.github.com/users/shengfuintel/orgs","repos_url":"https://api.github.com/users/shengfuintel/repos","events_url":"https://api.github.com/users/shengfuintel/events{/privacy}","received_events_url":"https://api.github.com/users/shengfuintel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/labels/bug","name":"bug","color":"FF9933"},{"url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/labels/far","name":"far","color":"336699"}],"state":"open","locked":false,"assignee":{"login":"manuelk","id":1672752,"avatar_url":"https://avatars.githubusercontent.com/u/1672752?v=3","gravatar_id":"","url":"https://api.github.com/users/manuelk","html_url":"https://github.com/manuelk","followers_url":"https://api.github.com/users/manuelk/followers","following_url":"https://api.github.com/users/manuelk/following{/other_user}","gists_url":"https://api.github.com/users/manuelk/gists{/gist_id}","starred_url":"https://api.github.com/users/manuelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuelk/subscriptions","organizations_url":"https://api.github.com/users/manuelk/orgs","repos_url":"https://api.github.com/users/manuelk/repos","events_url":"https://api.github.com/users/manuelk/events{/privacy}","received_events_url":"https://api.github.com/users/manuelk/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-02-11T20:15:30Z","updated_at":"2015-02-11T20:55:30Z","closed_at":null,"body":"In OSD3, the maximum valence for a triangle face (a whole mesh only has one triangle, no other faces) is 3. It should be 4 if it subdivided twice. The code in PatchTablesFactory::createAdaptive and createUniform only looks into the maximum valence in level 0. I think it is safe to set maximum valence to 4 as minimum value."},"comment":{"url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/issues/comments/73962863","html_url":"https://github.com/PixarAnimationStudios/OpenSubdiv/issues/395#issuecomment-73962863","issue_url":"https://api.github.com/repos/PixarAnimationStudios/OpenSubdiv/issues/395","id":73962863,"user":{"login":"manuelk","id":1672752,"avatar_url":"https://avatars.githubusercontent.com/u/1672752?v=3","gravatar_id":"","url":"https://api.github.com/users/manuelk","html_url":"https://github.com/manuelk","followers_url":"https://api.github.com/users/manuelk/followers","following_url":"https://api.github.com/users/manuelk/following{/other_user}","gists_url":"https://api.github.com/users/manuelk/gists{/gist_id}","starred_url":"https://api.github.com/users/manuelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuelk/subscriptions","organizations_url":"https://api.github.com/users/manuelk/orgs","repos_url":"https://api.github.com/users/manuelk/repos","events_url":"https://api.github.com/users/manuelk/events{/privacy}","received_events_url":"https://api.github.com/users/manuelk/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T20:55:30Z","updated_at":"2015-02-11T20:55:30Z","body":"I vaguely remember already fixing this very problem in the 2.x PatchTables /sigh\r\n\r\nPlease go ahead and submit a pull request (dev branch) for a fix if you have one.\r\n"}}