{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/32934537","id":32934537,"diff_hunk":"@@ -1103,6 +1113,12 @@ xfClipboard* xf_clipboard_new(xfContext* xfc)\n \tclipboard->clientFormats[n].atom = XInternAtom(xfc->display, \"text/html\", False);\n \tclipboard->clientFormats[n].formatId = CB_FORMAT_HTML;\n \tclipboard->clientFormats[n].formatName = _strdup(\"HTML Format\");\n+\tif (!clipboard->clientFormats[n].formatName)\n+\t{\n+\t\tClipboardDestroy(clipboard->system);\n+\t\tfree(clipboard);","path":"client/X11/xf_cliprdr.c","position":24,"original_position":24,"commit_id":"1b006a577de7841c036152927fb9e28228c30658","original_commit_id":"1ba8e833571ecc98386407d851e0e1c20aa471a0","user":{"login":"nfedera","id":670606,"avatar_url":"https://avatars.githubusercontent.com/u/670606?v=3","gravatar_id":"","url":"https://api.github.com/users/nfedera","html_url":"https://github.com/nfedera","followers_url":"https://api.github.com/users/nfedera/followers","following_url":"https://api.github.com/users/nfedera/following{/other_user}","gists_url":"https://api.github.com/users/nfedera/gists{/gist_id}","starred_url":"https://api.github.com/users/nfedera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfedera/subscriptions","organizations_url":"https://api.github.com/users/nfedera/orgs","repos_url":"https://api.github.com/users/nfedera/repos","events_url":"https://api.github.com/users/nfedera/events{/privacy}","received_events_url":"https://api.github.com/users/nfedera/received_events","type":"User","site_admin":false},"body":"Not it is not. Must be freed here","created_at":"2015-06-22T13:41:20Z","updated_at":"2015-06-22T13:41:20Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2708#discussion_r32934537","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/32934537"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2708#discussion_r32934537"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708","id":38001607,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/2708","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/2708.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/2708.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2708","number":2708,"state":"open","locked":false,"title":"alloc and strdup checks","user":{"login":"bmiklautz","id":195793,"avatar_url":"https://avatars.githubusercontent.com/u/195793?v=3","gravatar_id":"","url":"https://api.github.com/users/bmiklautz","html_url":"https://github.com/bmiklautz","followers_url":"https://api.github.com/users/bmiklautz/followers","following_url":"https://api.github.com/users/bmiklautz/following{/other_user}","gists_url":"https://api.github.com/users/bmiklautz/gists{/gist_id}","starred_url":"https://api.github.com/users/bmiklautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmiklautz/subscriptions","organizations_url":"https://api.github.com/users/bmiklautz/orgs","repos_url":"https://api.github.com/users/bmiklautz/repos","events_url":"https://api.github.com/users/bmiklautz/events{/privacy}","received_events_url":"https://api.github.com/users/bmiklautz/received_events","type":"User","site_admin":false},"body":"* handle unchecked occurrences of strdup\r\n* add checks for *alloc\r\n* fix some compiler warnings on android\r\n* fix and update android build\r\n * SDK 14 is required now\r\n * update function return values and the jni/JAVA classes accordingly\r\n\r\n@hardening did a second round on malloc checks in winpr and\r\nadded, along a lot of other things, *alloc checks where missing.","created_at":"2015-06-18T12:37:18Z","updated_at":"2015-06-22T13:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"208c42132fb81ddb9f81b9bc333b1633723b1ac9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2708/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/1b006a577de7841c036152927fb9e28228c30658","head":{"label":"bmiklautz:dupdup","ref":"dupdup","sha":"1b006a577de7841c036152927fb9e28228c30658","user":{"login":"bmiklautz","id":195793,"avatar_url":"https://avatars.githubusercontent.com/u/195793?v=3","gravatar_id":"","url":"https://api.github.com/users/bmiklautz","html_url":"https://github.com/bmiklautz","followers_url":"https://api.github.com/users/bmiklautz/followers","following_url":"https://api.github.com/users/bmiklautz/following{/other_user}","gists_url":"https://api.github.com/users/bmiklautz/gists{/gist_id}","starred_url":"https://api.github.com/users/bmiklautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmiklautz/subscriptions","organizations_url":"https://api.github.com/users/bmiklautz/orgs","repos_url":"https://api.github.com/users/bmiklautz/repos","events_url":"https://api.github.com/users/bmiklautz/events{/privacy}","received_events_url":"https://api.github.com/users/bmiklautz/received_events","type":"User","site_admin":false},"repo":{"id":1999019,"name":"FreeRDP","full_name":"bmiklautz/FreeRDP","owner":{"login":"bmiklautz","id":195793,"avatar_url":"https://avatars.githubusercontent.com/u/195793?v=3","gravatar_id":"","url":"https://api.github.com/users/bmiklautz","html_url":"https://github.com/bmiklautz","followers_url":"https://api.github.com/users/bmiklautz/followers","following_url":"https://api.github.com/users/bmiklautz/following{/other_user}","gists_url":"https://api.github.com/users/bmiklautz/gists{/gist_id}","starred_url":"https://api.github.com/users/bmiklautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmiklautz/subscriptions","organizations_url":"https://api.github.com/users/bmiklautz/orgs","repos_url":"https://api.github.com/users/bmiklautz/repos","events_url":"https://api.github.com/users/bmiklautz/events{/privacy}","received_events_url":"https://api.github.com/users/bmiklautz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmiklautz/FreeRDP","description":"FreeRDP 1.0","fork":true,"url":"https://api.github.com/repos/bmiklautz/FreeRDP","forks_url":"https://api.github.com/repos/bmiklautz/FreeRDP/forks","keys_url":"https://api.github.com/repos/bmiklautz/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmiklautz/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmiklautz/FreeRDP/teams","hooks_url":"https://api.github.com/repos/bmiklautz/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/bmiklautz/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/bmiklautz/FreeRDP/events","assignees_url":"https://api.github.com/repos/bmiklautz/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/bmiklautz/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/bmiklautz/FreeRDP/tags","blobs_url":"https://api.github.com/repos/bmiklautz/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmiklautz/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmiklautz/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmiklautz/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmiklautz/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/bmiklautz/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/bmiklautz/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/bmiklautz/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/bmiklautz/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/bmiklautz/FreeRDP/subscription","commits_url":"https://api.github.com/repos/bmiklautz/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmiklautz/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmiklautz/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmiklautz/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmiklautz/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/bmiklautz/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmiklautz/FreeRDP/merges","archive_url":"https://api.github.com/repos/bmiklautz/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmiklautz/FreeRDP/downloads","issues_url":"https://api.github.com/repos/bmiklautz/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/bmiklautz/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/bmiklautz/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/bmiklautz/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmiklautz/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/bmiklautz/FreeRDP/releases{/id}","created_at":"2011-07-05T06:49:14Z","updated_at":"2015-04-08T07:53:33Z","pushed_at":"2015-06-22T12:55:41Z","git_url":"git://github.com/bmiklautz/FreeRDP.git","ssh_url":"git@github.com:bmiklautz/FreeRDP.git","clone_url":"https://github.com/bmiklautz/FreeRDP.git","svn_url":"https://github.com/bmiklautz/FreeRDP","homepage":"http://www.freerdp.com/","size":31129,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"c8731eaa2c9c5e58457500ebe0c9f89d7e0c461f","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","created_at":"2011-06-30T19:14:15Z","updated_at":"2015-06-21T01:49:51Z","pushed_at":"2015-06-22T13:39:18Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":119452,"stargazers_count":987,"watchers_count":987,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"open_issues_count":552,"forks":642,"open_issues":552,"watchers":987,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2708"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2708"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2708/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2708/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/1b006a577de7841c036152927fb9e28228c30658"}}}}