{"action":"opened","number":378,"pull_request":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/378","id":43223794,"html_url":"https://github.com/alliedmodders/sourcemod/pull/378","diff_url":"https://github.com/alliedmodders/sourcemod/pull/378.diff","patch_url":"https://github.com/alliedmodders/sourcemod/pull/378.patch","issue_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/378","number":378,"state":"open","locked":false,"title":"Fix ConVar .IntValue, .BoolValue, and .FloatValue assignments (Bug 6405)","user":{"login":"powerlord","id":2437606,"avatar_url":"https://avatars.githubusercontent.com/u/2437606?v=3","gravatar_id":"","url":"https://api.github.com/users/powerlord","html_url":"https://github.com/powerlord","followers_url":"https://api.github.com/users/powerlord/followers","following_url":"https://api.github.com/users/powerlord/following{/other_user}","gists_url":"https://api.github.com/users/powerlord/gists{/gist_id}","starred_url":"https://api.github.com/users/powerlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerlord/subscriptions","organizations_url":"https://api.github.com/users/powerlord/orgs","repos_url":"https://api.github.com/users/powerlord/repos","events_url":"https://api.github.com/users/powerlord/events{/privacy}","received_events_url":"https://api.github.com/users/powerlord/received_events","type":"User","site_admin":false},"body":"This is a fix for [Bug 6405](https://bugs.alliedmods.net/show_bug.cgi?id=6405)\r\n\r\nSimply put, this patch gets rid of ConVar_BoolValue_set, ConVar_FloatValue_set, and ConVar_IntValue_set.\r\n\r\nInstead, it uses sm_SetConVarNum and sm_SetConVarFloat directly.\r\n\r\nHowever, so we don't cause issues with pre-OrangeBox games,  the above two functions and sm_SetConVarString now check if params[0] (the parameter count) is >= the parameter number before using params 3 (replicate) and 4 (notify).","created_at":"2015-08-24T21:25:14Z","updated_at":"2015-08-24T21:25:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/378/commits","review_comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/378/comments","review_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/378/comments","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/569a53182ca78af957aca8c6f07cd0e3170f8126","head":{"label":"powerlord:fix-convar","ref":"fix-convar","sha":"569a53182ca78af957aca8c6f07cd0e3170f8126","user":{"login":"powerlord","id":2437606,"avatar_url":"https://avatars.githubusercontent.com/u/2437606?v=3","gravatar_id":"","url":"https://api.github.com/users/powerlord","html_url":"https://github.com/powerlord","followers_url":"https://api.github.com/users/powerlord/followers","following_url":"https://api.github.com/users/powerlord/following{/other_user}","gists_url":"https://api.github.com/users/powerlord/gists{/gist_id}","starred_url":"https://api.github.com/users/powerlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerlord/subscriptions","organizations_url":"https://api.github.com/users/powerlord/orgs","repos_url":"https://api.github.com/users/powerlord/repos","events_url":"https://api.github.com/users/powerlord/events{/privacy}","received_events_url":"https://api.github.com/users/powerlord/received_events","type":"User","site_admin":false},"repo":{"id":23467933,"name":"sourcemod","full_name":"powerlord/sourcemod","owner":{"login":"powerlord","id":2437606,"avatar_url":"https://avatars.githubusercontent.com/u/2437606?v=3","gravatar_id":"","url":"https://api.github.com/users/powerlord","html_url":"https://github.com/powerlord","followers_url":"https://api.github.com/users/powerlord/followers","following_url":"https://api.github.com/users/powerlord/following{/other_user}","gists_url":"https://api.github.com/users/powerlord/gists{/gist_id}","starred_url":"https://api.github.com/users/powerlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerlord/subscriptions","organizations_url":"https://api.github.com/users/powerlord/orgs","repos_url":"https://api.github.com/users/powerlord/repos","events_url":"https://api.github.com/users/powerlord/events{/privacy}","received_events_url":"https://api.github.com/users/powerlord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/powerlord/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":true,"url":"https://api.github.com/repos/powerlord/sourcemod","forks_url":"https://api.github.com/repos/powerlord/sourcemod/forks","keys_url":"https://api.github.com/repos/powerlord/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/powerlord/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/powerlord/sourcemod/teams","hooks_url":"https://api.github.com/repos/powerlord/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/powerlord/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/powerlord/sourcemod/events","assignees_url":"https://api.github.com/repos/powerlord/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/powerlord/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/powerlord/sourcemod/tags","blobs_url":"https://api.github.com/repos/powerlord/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/powerlord/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/powerlord/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/powerlord/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/powerlord/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/powerlord/sourcemod/languages","stargazers_url":"https://api.github.com/repos/powerlord/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/powerlord/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/powerlord/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/powerlord/sourcemod/subscription","commits_url":"https://api.github.com/repos/powerlord/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/powerlord/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/powerlord/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/powerlord/sourcemod/issues/comments{/number}","contents_url":"https://api.github.com/repos/powerlord/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/powerlord/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/powerlord/sourcemod/merges","archive_url":"https://api.github.com/repos/powerlord/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/powerlord/sourcemod/downloads","issues_url":"https://api.github.com/repos/powerlord/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/powerlord/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/powerlord/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/powerlord/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/powerlord/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/powerlord/sourcemod/releases{/id}","created_at":"2014-08-29T15:12:32Z","updated_at":"2015-03-30T21:12:34Z","pushed_at":"2015-08-24T21:04:12Z","git_url":"git://github.com/powerlord/sourcemod.git","ssh_url":"git@github.com:powerlord/sourcemod.git","clone_url":"https://github.com/powerlord/sourcemod.git","svn_url":"https://github.com/powerlord/sourcemod","homepage":"http://www.sourcemod.net/","size":34533,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alliedmodders:master","ref":"master","sha":"ee2a408d4469f65761d241955f63bef007536e0c","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","created_at":"2014-05-25T02:58:39Z","updated_at":"2015-08-16T12:50:37Z","pushed_at":"2015-08-20T18:03:39Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":52568,"stargazers_count":134,"watchers_count":134,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":20,"forks":61,"open_issues":20,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/378"},"html":{"href":"https://github.com/alliedmodders/sourcemod/pull/378"},"issue":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/378"},"comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/569a53182ca78af957aca8c6f07cd0e3170f8126"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":48,"changed_files":1}}