{"action":"created","comment":{"url":"https://api.github.com/repos/aurelia/history-browser/pulls/comments/46097229","id":46097229,"diff_hunk":"@@ -82,10 +82,10 @@ export class DefaultLinkHandler extends LinkHandler {\n     info.anchor = target;\n     info.href = href;\n \n-    let hasModifierKey = (event.altKey || event.ctrlKey || event.metaKey || event.shiftKey);\n+    let leftButtonClicked = event.which ? event.which === 1 : event.button & 1;","path":"src/link-handler.js","position":5,"original_position":5,"commit_id":"81847199987e1ffdf3f52b6390f3c00b90f4b113","original_commit_id":"81847199987e1ffdf3f52b6390f3c00b90f4b113","user":{"login":"aksyonov","id":2206553,"avatar_url":"https://avatars.githubusercontent.com/u/2206553?v=3","gravatar_id":"","url":"https://api.github.com/users/aksyonov","html_url":"https://github.com/aksyonov","followers_url":"https://api.github.com/users/aksyonov/followers","following_url":"https://api.github.com/users/aksyonov/following{/other_user}","gists_url":"https://api.github.com/users/aksyonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksyonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksyonov/subscriptions","organizations_url":"https://api.github.com/users/aksyonov/orgs","repos_url":"https://api.github.com/users/aksyonov/repos","events_url":"https://api.github.com/users/aksyonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksyonov/received_events","type":"User","site_admin":false},"body":"Got it, we can check here only for `event.which` which is supported by IE9+ and other browsers and will be equal to `1` for the main mouse button.\r\n\r\nAbout checks for meta keys - there is the same check on [this line](https://github.com/aurelia/history-browser/blob/1a67ae11885db085d6921f78e0ca69afb616c883/src/link-handler.js#L77) and after that `hasModifierKey` will always be `false`. What do you think about it?","created_at":"2015-11-29T20:10:13Z","updated_at":"2015-11-29T20:10:13Z","html_url":"https://github.com/aurelia/history-browser/pull/20#discussion_r46097229","pull_request_url":"https://api.github.com/repos/aurelia/history-browser/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/aurelia/history-browser/pulls/comments/46097229"},"html":{"href":"https://github.com/aurelia/history-browser/pull/20#discussion_r46097229"},"pull_request":{"href":"https://api.github.com/repos/aurelia/history-browser/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/aurelia/history-browser/pulls/20","id":52022934,"html_url":"https://github.com/aurelia/history-browser/pull/20","diff_url":"https://github.com/aurelia/history-browser/pull/20.diff","patch_url":"https://github.com/aurelia/history-browser/pull/20.patch","issue_url":"https://api.github.com/repos/aurelia/history-browser/issues/20","number":20,"state":"open","locked":false,"title":"fix(history-browser): open link in new tab when it clicked with middle button","user":{"login":"aksyonov","id":2206553,"avatar_url":"https://avatars.githubusercontent.com/u/2206553?v=3","gravatar_id":"","url":"https://api.github.com/users/aksyonov","html_url":"https://github.com/aksyonov","followers_url":"https://api.github.com/users/aksyonov/followers","following_url":"https://api.github.com/users/aksyonov/following{/other_user}","gists_url":"https://api.github.com/users/aksyonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksyonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksyonov/subscriptions","organizations_url":"https://api.github.com/users/aksyonov/orgs","repos_url":"https://api.github.com/users/aksyonov/repos","events_url":"https://api.github.com/users/aksyonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksyonov/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-27T20:29:56Z","updated_at":"2015-11-29T20:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae8f86175a2221fa7d9c52a5fb6b65b77f91a81f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/history-browser/pulls/20/commits","review_comments_url":"https://api.github.com/repos/aurelia/history-browser/pulls/20/comments","review_comment_url":"https://api.github.com/repos/aurelia/history-browser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/history-browser/issues/20/comments","statuses_url":"https://api.github.com/repos/aurelia/history-browser/statuses/81847199987e1ffdf3f52b6390f3c00b90f4b113","head":{"label":"aksyonov:master","ref":"master","sha":"81847199987e1ffdf3f52b6390f3c00b90f4b113","user":{"login":"aksyonov","id":2206553,"avatar_url":"https://avatars.githubusercontent.com/u/2206553?v=3","gravatar_id":"","url":"https://api.github.com/users/aksyonov","html_url":"https://github.com/aksyonov","followers_url":"https://api.github.com/users/aksyonov/followers","following_url":"https://api.github.com/users/aksyonov/following{/other_user}","gists_url":"https://api.github.com/users/aksyonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksyonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksyonov/subscriptions","organizations_url":"https://api.github.com/users/aksyonov/orgs","repos_url":"https://api.github.com/users/aksyonov/repos","events_url":"https://api.github.com/users/aksyonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksyonov/received_events","type":"User","site_admin":false},"repo":{"id":46997923,"name":"history-browser","full_name":"aksyonov/history-browser","owner":{"login":"aksyonov","id":2206553,"avatar_url":"https://avatars.githubusercontent.com/u/2206553?v=3","gravatar_id":"","url":"https://api.github.com/users/aksyonov","html_url":"https://github.com/aksyonov","followers_url":"https://api.github.com/users/aksyonov/followers","following_url":"https://api.github.com/users/aksyonov/following{/other_user}","gists_url":"https://api.github.com/users/aksyonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksyonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksyonov/subscriptions","organizations_url":"https://api.github.com/users/aksyonov/orgs","repos_url":"https://api.github.com/users/aksyonov/repos","events_url":"https://api.github.com/users/aksyonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksyonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aksyonov/history-browser","description":"An implementation of the history interface based on standard browser hash change and push state mechanisms.","fork":true,"url":"https://api.github.com/repos/aksyonov/history-browser","forks_url":"https://api.github.com/repos/aksyonov/history-browser/forks","keys_url":"https://api.github.com/repos/aksyonov/history-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aksyonov/history-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aksyonov/history-browser/teams","hooks_url":"https://api.github.com/repos/aksyonov/history-browser/hooks","issue_events_url":"https://api.github.com/repos/aksyonov/history-browser/issues/events{/number}","events_url":"https://api.github.com/repos/aksyonov/history-browser/events","assignees_url":"https://api.github.com/repos/aksyonov/history-browser/assignees{/user}","branches_url":"https://api.github.com/repos/aksyonov/history-browser/branches{/branch}","tags_url":"https://api.github.com/repos/aksyonov/history-browser/tags","blobs_url":"https://api.github.com/repos/aksyonov/history-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aksyonov/history-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aksyonov/history-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/aksyonov/history-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aksyonov/history-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/aksyonov/history-browser/languages","stargazers_url":"https://api.github.com/repos/aksyonov/history-browser/stargazers","contributors_url":"https://api.github.com/repos/aksyonov/history-browser/contributors","subscribers_url":"https://api.github.com/repos/aksyonov/history-browser/subscribers","subscription_url":"https://api.github.com/repos/aksyonov/history-browser/subscription","commits_url":"https://api.github.com/repos/aksyonov/history-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/aksyonov/history-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/aksyonov/history-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/aksyonov/history-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/aksyonov/history-browser/contents/{+path}","compare_url":"https://api.github.com/repos/aksyonov/history-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aksyonov/history-browser/merges","archive_url":"https://api.github.com/repos/aksyonov/history-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aksyonov/history-browser/downloads","issues_url":"https://api.github.com/repos/aksyonov/history-browser/issues{/number}","pulls_url":"https://api.github.com/repos/aksyonov/history-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/aksyonov/history-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/aksyonov/history-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aksyonov/history-browser/labels{/name}","releases_url":"https://api.github.com/repos/aksyonov/history-browser/releases{/id}","created_at":"2015-11-27T20:19:44Z","updated_at":"2015-11-27T20:19:45Z","pushed_at":"2015-11-27T20:27:32Z","git_url":"git://github.com/aksyonov/history-browser.git","ssh_url":"git@github.com:aksyonov/history-browser.git","clone_url":"https://github.com/aksyonov/history-browser.git","svn_url":"https://github.com/aksyonov/history-browser","homepage":null,"size":161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"1a67ae11885db085d6921f78e0ca69afb616c883","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27783162,"name":"history-browser","full_name":"aurelia/history-browser","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/history-browser","description":"An implementation of the history interface based on standard browser hash change and push state mechanisms.","fork":false,"url":"https://api.github.com/repos/aurelia/history-browser","forks_url":"https://api.github.com/repos/aurelia/history-browser/forks","keys_url":"https://api.github.com/repos/aurelia/history-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/history-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/history-browser/teams","hooks_url":"https://api.github.com/repos/aurelia/history-browser/hooks","issue_events_url":"https://api.github.com/repos/aurelia/history-browser/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/history-browser/events","assignees_url":"https://api.github.com/repos/aurelia/history-browser/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/history-browser/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/history-browser/tags","blobs_url":"https://api.github.com/repos/aurelia/history-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/history-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/history-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/history-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/history-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/history-browser/languages","stargazers_url":"https://api.github.com/repos/aurelia/history-browser/stargazers","contributors_url":"https://api.github.com/repos/aurelia/history-browser/contributors","subscribers_url":"https://api.github.com/repos/aurelia/history-browser/subscribers","subscription_url":"https://api.github.com/repos/aurelia/history-browser/subscription","commits_url":"https://api.github.com/repos/aurelia/history-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/history-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/history-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/history-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/history-browser/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/history-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/history-browser/merges","archive_url":"https://api.github.com/repos/aurelia/history-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/history-browser/downloads","issues_url":"https://api.github.com/repos/aurelia/history-browser/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/history-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/history-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/history-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/history-browser/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/history-browser/releases{/id}","created_at":"2014-12-09T19:30:21Z","updated_at":"2015-09-08T13:52:32Z","pushed_at":"2015-11-27T20:29:57Z","git_url":"git://github.com/aurelia/history-browser.git","ssh_url":"git@github.com:aurelia/history-browser.git","clone_url":"https://github.com/aurelia/history-browser.git","svn_url":"https://github.com/aurelia/history-browser","homepage":null,"size":163,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/history-browser/pulls/20"},"html":{"href":"https://github.com/aurelia/history-browser/pull/20"},"issue":{"href":"https://api.github.com/repos/aurelia/history-browser/issues/20"},"comments":{"href":"https://api.github.com/repos/aurelia/history-browser/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/history-browser/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/history-browser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/history-browser/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/history-browser/statuses/81847199987e1ffdf3f52b6390f3c00b90f4b113"}}}}