{"action":"created","comment":{"url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/comments/33397972","id":33397972,"diff_hunk":"@@ -18,7 +19,7 @@ module.exports =\n       configureMathJax()\n     script.type   = \"text/javascript\";\n     try\n-      # atom.packages.resolvePackagePath('mathjax-wrapper') doesnt work but\n+      # atom.packages.resolvePackagePath('mathjax-wrapper') doesn't work but","path":"lib/mathjax-helper.coffee","position":17,"original_position":17,"commit_id":"de523a8ffdd11e86d19a6c1df216a8c236998f43","original_commit_id":"de523a8ffdd11e86d19a6c1df216a8c236998f43","user":{"login":"Galadirith","id":1201875,"avatar_url":"https://avatars.githubusercontent.com/u/1201875?v=3","gravatar_id":"","url":"https://api.github.com/users/Galadirith","html_url":"https://github.com/Galadirith","followers_url":"https://api.github.com/users/Galadirith/followers","following_url":"https://api.github.com/users/Galadirith/following{/other_user}","gists_url":"https://api.github.com/users/Galadirith/gists{/gist_id}","starred_url":"https://api.github.com/users/Galadirith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Galadirith/subscriptions","organizations_url":"https://api.github.com/users/Galadirith/orgs","repos_url":"https://api.github.com/users/Galadirith/repos","events_url":"https://api.github.com/users/Galadirith/events{/privacy}","received_events_url":"https://api.github.com/users/Galadirith/received_events","type":"User","site_admin":false},"body":"Thanks for all the grammar and spelling corrections, I am not good at English :D","created_at":"2015-06-26T21:32:01Z","updated_at":"2015-06-26T21:32:01Z","html_url":"https://github.com/Galadirith/markdown-preview-plus/pull/14#discussion_r33397972","pull_request_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/comments/33397972"},"html":{"href":"https://github.com/Galadirith/markdown-preview-plus/pull/14#discussion_r33397972"},"pull_request":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14","id":27455492,"html_url":"https://github.com/Galadirith/markdown-preview-plus/pull/14","diff_url":"https://github.com/Galadirith/markdown-preview-plus/pull/14.diff","patch_url":"https://github.com/Galadirith/markdown-preview-plus/pull/14.patch","issue_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues/14","number":14,"state":"open","locked":false,"title":"first go at adding macro support","user":{"login":"KCErb","id":4992244,"avatar_url":"https://avatars.githubusercontent.com/u/4992244?v=3","gravatar_id":"","url":"https://api.github.com/users/KCErb","html_url":"https://github.com/KCErb","followers_url":"https://api.github.com/users/KCErb/followers","following_url":"https://api.github.com/users/KCErb/following{/other_user}","gists_url":"https://api.github.com/users/KCErb/gists{/gist_id}","starred_url":"https://api.github.com/users/KCErb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KCErb/subscriptions","organizations_url":"https://api.github.com/users/KCErb/orgs","repos_url":"https://api.github.com/users/KCErb/repos","events_url":"https://api.github.com/users/KCErb/events{/privacy}","received_events_url":"https://api.github.com/users/KCErb/received_events","type":"User","site_admin":false},"body":"Hi @Galadirith! \r\n\r\nI was playing around with how defining macros works and got this working locally (though I don't know how to really test it out, I just edited my .atom version of the package until I liked it and hand-copied the changes over to this fork :grin:).\r\n\r\nThe idea is that we create a local folder that we can put stuff like this into. After that Ajax just needs to know where the config file is and you're all set.\r\n\r\nI relied on\r\nhttp://docs.mathjax.org/en/latest/options/ThirdParty.html\r\n\r\nand \r\n\r\nhttp://docs.mathjax.org/en/latest/tex.html#defining-tex-macros\r\n\r\npretty heavily to figure this out.\r\n\r\nA couple of questions:\r\n\r\n1. How can we ship out a template `macros.js` but not overwrite it on update?\r\n2. Do we want to do something with `main.cofee`'s config? Such as \r\n  * Letting them specify their own config path (I played around with that for a while and kinda liked it).\r\n  * Could a user put macro's in there? Sorta like the keymap? That would be cool!\r\n\r\nAnyways, feel free to reject or give this harsh criticism, I won't be offended :)","created_at":"2015-01-15T19:35:58Z","updated_at":"2015-06-26T21:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a22fae631024616e9844c22e41a42475b4ca83a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues/14/comments","statuses_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/statuses/de523a8ffdd11e86d19a6c1df216a8c236998f43","head":{"label":"KCErb:add_macros","ref":"add_macros","sha":"de523a8ffdd11e86d19a6c1df216a8c236998f43","user":{"login":"KCErb","id":4992244,"avatar_url":"https://avatars.githubusercontent.com/u/4992244?v=3","gravatar_id":"","url":"https://api.github.com/users/KCErb","html_url":"https://github.com/KCErb","followers_url":"https://api.github.com/users/KCErb/followers","following_url":"https://api.github.com/users/KCErb/following{/other_user}","gists_url":"https://api.github.com/users/KCErb/gists{/gist_id}","starred_url":"https://api.github.com/users/KCErb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KCErb/subscriptions","organizations_url":"https://api.github.com/users/KCErb/orgs","repos_url":"https://api.github.com/users/KCErb/repos","events_url":"https://api.github.com/users/KCErb/events{/privacy}","received_events_url":"https://api.github.com/users/KCErb/received_events","type":"User","site_admin":false},"repo":{"id":29311885,"name":"markdown-preview-plus","full_name":"KCErb/markdown-preview-plus","owner":{"login":"KCErb","id":4992244,"avatar_url":"https://avatars.githubusercontent.com/u/4992244?v=3","gravatar_id":"","url":"https://api.github.com/users/KCErb","html_url":"https://github.com/KCErb","followers_url":"https://api.github.com/users/KCErb/followers","following_url":"https://api.github.com/users/KCErb/following{/other_user}","gists_url":"https://api.github.com/users/KCErb/gists{/gist_id}","starred_url":"https://api.github.com/users/KCErb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KCErb/subscriptions","organizations_url":"https://api.github.com/users/KCErb/orgs","repos_url":"https://api.github.com/users/KCErb/repos","events_url":"https://api.github.com/users/KCErb/events{/privacy}","received_events_url":"https://api.github.com/users/KCErb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KCErb/markdown-preview-plus","description":"Markdown + LaTeX preview in Atom","fork":true,"url":"https://api.github.com/repos/KCErb/markdown-preview-plus","forks_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/forks","keys_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/teams","hooks_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/hooks","issue_events_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/issues/events{/number}","events_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/events","assignees_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/assignees{/user}","branches_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/branches{/branch}","tags_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/tags","blobs_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/languages","stargazers_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/stargazers","contributors_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/contributors","subscribers_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/subscribers","subscription_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/subscription","commits_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/contents/{+path}","compare_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/merges","archive_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/downloads","issues_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/issues{/number}","pulls_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/labels{/name}","releases_url":"https://api.github.com/repos/KCErb/markdown-preview-plus/releases{/id}","created_at":"2015-01-15T18:35:23Z","updated_at":"2015-02-10T16:38:05Z","pushed_at":"2015-02-17T20:54:01Z","git_url":"git://github.com/KCErb/markdown-preview-plus.git","ssh_url":"git@github.com:KCErb/markdown-preview-plus.git","clone_url":"https://github.com/KCErb/markdown-preview-plus.git","svn_url":"https://github.com/KCErb/markdown-preview-plus","homepage":"","size":760,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Galadirith:master","ref":"master","sha":"4377a23c59b95463053cb9146d02bdf0b2c906cd","user":{"login":"Galadirith","id":1201875,"avatar_url":"https://avatars.githubusercontent.com/u/1201875?v=3","gravatar_id":"","url":"https://api.github.com/users/Galadirith","html_url":"https://github.com/Galadirith","followers_url":"https://api.github.com/users/Galadirith/followers","following_url":"https://api.github.com/users/Galadirith/following{/other_user}","gists_url":"https://api.github.com/users/Galadirith/gists{/gist_id}","starred_url":"https://api.github.com/users/Galadirith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Galadirith/subscriptions","organizations_url":"https://api.github.com/users/Galadirith/orgs","repos_url":"https://api.github.com/users/Galadirith/repos","events_url":"https://api.github.com/users/Galadirith/events{/privacy}","received_events_url":"https://api.github.com/users/Galadirith/received_events","type":"User","site_admin":false},"repo":{"id":26962536,"name":"markdown-preview-plus","full_name":"Galadirith/markdown-preview-plus","owner":{"login":"Galadirith","id":1201875,"avatar_url":"https://avatars.githubusercontent.com/u/1201875?v=3","gravatar_id":"","url":"https://api.github.com/users/Galadirith","html_url":"https://github.com/Galadirith","followers_url":"https://api.github.com/users/Galadirith/followers","following_url":"https://api.github.com/users/Galadirith/following{/other_user}","gists_url":"https://api.github.com/users/Galadirith/gists{/gist_id}","starred_url":"https://api.github.com/users/Galadirith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Galadirith/subscriptions","organizations_url":"https://api.github.com/users/Galadirith/orgs","repos_url":"https://api.github.com/users/Galadirith/repos","events_url":"https://api.github.com/users/Galadirith/events{/privacy}","received_events_url":"https://api.github.com/users/Galadirith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Galadirith/markdown-preview-plus","description":"Markdown + Maths preview in Atom","fork":false,"url":"https://api.github.com/repos/Galadirith/markdown-preview-plus","forks_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/forks","keys_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/teams","hooks_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/hooks","issue_events_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues/events{/number}","events_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/events","assignees_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/assignees{/user}","branches_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/branches{/branch}","tags_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/tags","blobs_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/languages","stargazers_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/stargazers","contributors_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/contributors","subscribers_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/subscribers","subscription_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/subscription","commits_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/contents/{+path}","compare_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/merges","archive_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/downloads","issues_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues{/number}","pulls_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/labels{/name}","releases_url":"https://api.github.com/repos/Galadirith/markdown-preview-plus/releases{/id}","created_at":"2014-11-21T14:12:04Z","updated_at":"2015-06-24T05:41:09Z","pushed_at":"2015-06-11T12:45:14Z","git_url":"git://github.com/Galadirith/markdown-preview-plus.git","ssh_url":"git@github.com:Galadirith/markdown-preview-plus.git","clone_url":"https://github.com/Galadirith/markdown-preview-plus.git","svn_url":"https://github.com/Galadirith/markdown-preview-plus","homepage":"","size":996,"stargazers_count":25,"watchers_count":25,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":23,"forks":3,"open_issues":23,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14"},"html":{"href":"https://github.com/Galadirith/markdown-preview-plus/pull/14"},"issue":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues/14"},"comments":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Galadirith/markdown-preview-plus/statuses/de523a8ffdd11e86d19a6c1df216a8c236998f43"}}}}