{"action":"closed","issue":{"url":"https://api.github.com/repos/andrewrk/mineflayer/issues/174","labels_url":"https://api.github.com/repos/andrewrk/mineflayer/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/andrewrk/mineflayer/issues/174/comments","events_url":"https://api.github.com/repos/andrewrk/mineflayer/issues/174/events","html_url":"https://github.com/andrewrk/mineflayer/issues/174","id":31877844,"number":174,"title":"Physics Engine and Minecraft Engine differ in interpreting y axis","user":{"login":"nevercast","id":834342,"avatar_url":"https://avatars.githubusercontent.com/u/834342?v=3","gravatar_id":"","url":"https://api.github.com/users/nevercast","html_url":"https://github.com/nevercast","followers_url":"https://api.github.com/users/nevercast/followers","following_url":"https://api.github.com/users/nevercast/following{/other_user}","gists_url":"https://api.github.com/users/nevercast/gists{/gist_id}","starred_url":"https://api.github.com/users/nevercast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevercast/subscriptions","organizations_url":"https://api.github.com/users/nevercast/orgs","repos_url":"https://api.github.com/users/nevercast/repos","events_url":"https://api.github.com/users/nevercast/events{/privacy}","received_events_url":"https://api.github.com/users/nevercast/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/andrewrk/mineflayer/milestones/1","html_url":"https://github.com/andrewrk/mineflayer/milestones/Stable%202.0.0","labels_url":"https://api.github.com/repos/andrewrk/mineflayer/milestones/1/labels","id":636181,"number":1,"title":"Stable 2.0.0","description":"Minecraft 1.7.x compliant bot\r\nAll examples should work and code thoroughly checked\r\nThe API might chang slightly but the biggest change is that 1.7 is not backwards compatible with 1.6 (From a network protocol standpoint) So following [semver](http://semver.org/) the release will be 2.0.0","creator":{"login":"nevercast","id":834342,"avatar_url":"https://avatars.githubusercontent.com/u/834342?v=3","gravatar_id":"","url":"https://api.github.com/users/nevercast","html_url":"https://github.com/nevercast","followers_url":"https://api.github.com/users/nevercast/followers","following_url":"https://api.github.com/users/nevercast/following{/other_user}","gists_url":"https://api.github.com/users/nevercast/gists{/gist_id}","starred_url":"https://api.github.com/users/nevercast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevercast/subscriptions","organizations_url":"https://api.github.com/users/nevercast/orgs","repos_url":"https://api.github.com/users/nevercast/repos","events_url":"https://api.github.com/users/nevercast/events{/privacy}","received_events_url":"https://api.github.com/users/nevercast/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2014-04-21T22:45:16Z","updated_at":"2015-03-17T10:01:32Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2014-04-21T02:46:55Z","updated_at":"2015-03-17T10:01:32Z","closed_at":"2015-03-17T10:01:32Z","body":"The y axis components in position packets in MC are of the Eye height, but because the physics engine just sends the y position, it is sending the foot position. This causes an illegal stance if you're successfully connected, or prevents you from successfully connecting if you don't send a correct packet to begin with.\r\n\r\nThe reason that the 1.7 bot was unable to navigate was because of this check on the server:\r\nhttps://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/PlayerConnection.java#L94-L99\r\n\r\nBecause the stance was not correct the y axis didn't match what the server told us, so the server was never marking us as 'ready'\r\n(Still at loading screen state is assumed when CheckPosition is false)\r\n\r\nCurrently navigation is working in the 1.7 feature branch on my repo, which is currently PR'd to @roblabla (https://github.com/roblabla/mineflayer/pull/2) so that it can be part of the PR to this repo. (https://github.com/andrewrk/mineflayer/pull/173)\r\n\r\nThe only reason I put this issue here is to bring attention to this issue and open discussion about how we should fix it.\r\n\r\nLines of concern regarding the current fix are here: https://github.com/nevercast/mineflayer/blob/feature-1.7/lib/plugins/physics.js#L328-L339"}}