{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26722341","id":26722341,"diff_hunk":"@@ -534,19 +533,29 @@ var (\n \tErrContainerCannotRun = errors.New(\"Container cannot run\")\n )\n \n-func inspectContainer(client DockerInterface, dockerID, containerName, tPath string) (*api.ContainerStatus, error) {\n+// Internal information kept for containers from inspection\n+type containerStatusResult struct {\n+\tstatus api.ContainerStatus\n+\tpodIP  string\n+\terr    error\n+}\n+\n+func inspectContainer(client DockerInterface, dockerID, containerName, tPath string) *containerStatusResult {","path":"pkg/kubelet/dockertools/docker.go","position":20,"original_position":20,"commit_id":"9c371eed060f1523e6086b7454686c9d49152cfa","original_commit_id":"9c371eed060f1523e6086b7454686c9d49152cfa","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"What about returning 3 values rather than the struct?","created_at":"2015-03-19T00:54:48Z","updated_at":"2015-03-19T00:54:48Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5631#discussion_r26722341","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26722341"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5631#discussion_r26722341"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631","id":31486025,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5631","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5631.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5631.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5631","number":5631,"state":"open","locked":false,"title":"Remove PodIP from ContainerStatus","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"body":"Fix #5524","created_at":"2015-03-19T00:31:47Z","updated_at":"2015-03-19T00:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5631/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/9c371eed060f1523e6086b7454686c9d49152cfa","head":{"label":"dchen1107:podstatus","ref":"podstatus","sha":"9c371eed060f1523e6086b7454686c9d49152cfa","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"repo":{"id":21153738,"name":"kubernetes-1","full_name":"dchen1107/kubernetes-1","owner":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchen1107/kubernetes-1","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/dchen1107/kubernetes-1","forks_url":"https://api.github.com/repos/dchen1107/kubernetes-1/forks","keys_url":"https://api.github.com/repos/dchen1107/kubernetes-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchen1107/kubernetes-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchen1107/kubernetes-1/teams","hooks_url":"https://api.github.com/repos/dchen1107/kubernetes-1/hooks","issue_events_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues/events{/number}","events_url":"https://api.github.com/repos/dchen1107/kubernetes-1/events","assignees_url":"https://api.github.com/repos/dchen1107/kubernetes-1/assignees{/user}","branches_url":"https://api.github.com/repos/dchen1107/kubernetes-1/branches{/branch}","tags_url":"https://api.github.com/repos/dchen1107/kubernetes-1/tags","blobs_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchen1107/kubernetes-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dchen1107/kubernetes-1/languages","stargazers_url":"https://api.github.com/repos/dchen1107/kubernetes-1/stargazers","contributors_url":"https://api.github.com/repos/dchen1107/kubernetes-1/contributors","subscribers_url":"https://api.github.com/repos/dchen1107/kubernetes-1/subscribers","subscription_url":"https://api.github.com/repos/dchen1107/kubernetes-1/subscription","commits_url":"https://api.github.com/repos/dchen1107/kubernetes-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchen1107/kubernetes-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchen1107/kubernetes-1/contents/{+path}","compare_url":"https://api.github.com/repos/dchen1107/kubernetes-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchen1107/kubernetes-1/merges","archive_url":"https://api.github.com/repos/dchen1107/kubernetes-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchen1107/kubernetes-1/downloads","issues_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues{/number}","pulls_url":"https://api.github.com/repos/dchen1107/kubernetes-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dchen1107/kubernetes-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dchen1107/kubernetes-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchen1107/kubernetes-1/labels{/name}","releases_url":"https://api.github.com/repos/dchen1107/kubernetes-1/releases{/id}","created_at":"2014-06-24T05:53:16Z","updated_at":"2015-03-17T20:07:22Z","pushed_at":"2015-03-19T00:30:54Z","git_url":"git://github.com/dchen1107/kubernetes-1.git","ssh_url":"git@github.com:dchen1107/kubernetes-1.git","clone_url":"https://github.com/dchen1107/kubernetes-1.git","svn_url":"https://github.com/dchen1107/kubernetes-1","homepage":null,"size":37478,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"52e1ee9d5b96c878d0bb9beb698dd3f5b7318110","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-19T00:26:03Z","pushed_at":"2015-03-19T00:26:02Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":106370,"stargazers_count":6641,"watchers_count":6641,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1235,"mirror_url":null,"open_issues_count":769,"forks":1235,"open_issues":769,"watchers":6641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5631"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5631"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5631/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5631/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/9c371eed060f1523e6086b7454686c9d49152cfa"}}}}