{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/1703","labels_url":"https://api.github.com/repos/rackerlabs/otter/issues/1703/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/otter/issues/1703/comments","events_url":"https://api.github.com/repos/rackerlabs/otter/issues/1703/events","html_url":"https://github.com/rackerlabs/otter/pull/1703","id":104626024,"number":1703,"title":"Two tests for moving servers between CLBs","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"manishtomar","id":758529,"avatar_url":"https://avatars.githubusercontent.com/u/758529?v=3","gravatar_id":"","url":"https://api.github.com/users/manishtomar","html_url":"https://github.com/manishtomar","followers_url":"https://api.github.com/users/manishtomar/followers","following_url":"https://api.github.com/users/manishtomar/following{/other_user}","gists_url":"https://api.github.com/users/manishtomar/gists{/gist_id}","starred_url":"https://api.github.com/users/manishtomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishtomar/subscriptions","organizations_url":"https://api.github.com/users/manishtomar/orgs","repos_url":"https://api.github.com/users/manishtomar/repos","events_url":"https://api.github.com/users/manishtomar/events{/privacy}","received_events_url":"https://api.github.com/users/manishtomar/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-09-03T05:42:48Z","updated_at":"2015-09-04T05:18:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/1703","html_url":"https://github.com/rackerlabs/otter/pull/1703","diff_url":"https://github.com/rackerlabs/otter/pull/1703.diff","patch_url":"https://github.com/rackerlabs/otter/pull/1703.patch"},"body":"Tests that ensure that autoscale will self-heal a server on a CLB, but won't touch other autoscale servers on the same CLB.\r\n\r\nFixes #1488.\r\nFixes #1489.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/rackerlabs/otter/1703)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/comments/137650717","html_url":"https://github.com/rackerlabs/otter/pull/1703#issuecomment-137650717","issue_url":"https://api.github.com/repos/rackerlabs/otter/issues/1703","id":137650717,"user":{"login":"manishtomar","id":758529,"avatar_url":"https://avatars.githubusercontent.com/u/758529?v=3","gravatar_id":"","url":"https://api.github.com/users/manishtomar","html_url":"https://github.com/manishtomar","followers_url":"https://api.github.com/users/manishtomar/followers","following_url":"https://api.github.com/users/manishtomar/following{/other_user}","gists_url":"https://api.github.com/users/manishtomar/gists{/gist_id}","starred_url":"https://api.github.com/users/manishtomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishtomar/subscriptions","organizations_url":"https://api.github.com/users/manishtomar/orgs","repos_url":"https://api.github.com/users/manishtomar/repos","events_url":"https://api.github.com/users/manishtomar/events{/privacy}","received_events_url":"https://api.github.com/users/manishtomar/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T05:18:24Z","updated_at":"2015-09-04T05:18:24Z","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n<sup>**[otter/integration/tests/test_lbsh.py, line 334 \\[r1\\]](https://reviewable.io:443/reviews/rackerlabs/otter/1703#-JyKSoXp0ccdgYxW_qmx)** ([raw file](https://github.com/rackerlabs/otter/blob/7c457120c35911768c675d081f45a4ec3a75ab89/otter/integration/tests/test_lbsh.py#L334)):</sup>\n> converging autoscale groups don't interfere with converging other autoscale groups on the same CLB\n\nThats a valid point\n\n> On the other hand, maybe initializing both groups simultaneously already tests that?\n\nThat is also true.\n\n>  So up to you. :)\n\nI guess I'll leave it as it is :)\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/rackerlabs/otter/1703)\n<!-- Sent from Reviewable.io -->\n"}}