{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/31571861","id":31571861,"diff_hunk":"@@ -406,30 +399,39 @@ class ContextifyContext {\n         Unwrap<ContextifyContext>(args.Data().As<Object>());\n \n     Local<Object> sandbox = PersistentToLocal(isolate, ctx->sandbox_);\n-    Local<Object> proxy_global = PersistentToLocal(isolate,\n-                                                   ctx->proxy_global_);\n-\n-    bool in_sandbox = sandbox->GetRealNamedProperty(property).IsEmpty();\n-    bool in_proxy_global =\n-        proxy_global->GetRealNamedProperty(property).IsEmpty();\n-    if (!in_sandbox || !in_proxy_global) {\n-      args.GetReturnValue().Set(None);\n+    Maybe<PropertyAttribute> maybe_prop_attr =\n+        sandbox->GetRealNamedPropertyAttributes(ctx->context(), property);\n+\n+    if (maybe_prop_attr.IsNothing()) {\n+      Local<Object> proxy_global = PersistentToLocal(isolate,\n+          ctx->proxy_global_);\n+\n+      maybe_prop_attr =\n+          proxy_global->GetRealNamedPropertyAttributes(ctx->context(),\n+              property);\n+    }\n+\n+    if (maybe_prop_attr.IsJust()) {\n+      PropertyAttribute prop_attr = maybe_prop_attr.FromJust();\n+      args.GetReturnValue().Set(prop_attr);\n     }\n   }\n \n \n   static void GlobalPropertyDeleterCallback(\n-      Local<String> property,\n+      Local<Name> property,\n       const PropertyCallbackInfo<Boolean>& args) {\n     Isolate* isolate = args.GetIsolate();\n     HandleScope scope(isolate);\n \n     ContextifyContext* ctx =\n         Unwrap<ContextifyContext>(args.Data().As<Object>());\n+    Local<Object> sandbox = PersistentToLocal(isolate, ctx->sandbox_);\n+\n+    Maybe<bool> success = sandbox->Delete(ctx->context(), property);\n \n-    bool success = PersistentToLocal(isolate,\n-                                     ctx->sandbox_)->Delete(property);\n-    args.GetReturnValue().Set(success);\n+    if (success.IsJust())\n+      args.GetReturnValue().Set(success.FromJust());","path":"src/node_contextify.cc","position":152,"original_position":152,"commit_id":"5f69cda3065f5cea0438cfbe17ab3ab5721a5171","original_commit_id":"5f69cda3065f5cea0438cfbe17ab3ab5721a5171","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"could this also be:\r\n```cpp\r\nargs.GetReturnValue().Set(success.FromMaybe(false));\r\n```","created_at":"2015-06-02T21:13:22Z","updated_at":"2015-06-02T21:13:22Z","html_url":"https://github.com/nodejs/io.js/pull/1773#discussion_r31571861","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/1773","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/31571861"},"html":{"href":"https://github.com/nodejs/io.js/pull/1773#discussion_r31571861"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1773"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/1773","id":36077267,"html_url":"https://github.com/nodejs/io.js/pull/1773","diff_url":"https://github.com/nodejs/io.js/pull/1773.diff","patch_url":"https://github.com/nodejs/io.js/pull/1773.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/1773","number":1773,"state":"open","locked":false,"title":"vm: fix a variety of bugs, using V8 4.3 APIs","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"body":"See individual commits for details.","created_at":"2015-05-22T23:43:16Z","updated_at":"2015-06-02T21:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ea280dcf420f2d49f22e6b6fe0ae8ee2c059e7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/1773/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/1773/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/1773/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/5f69cda3065f5cea0438cfbe17ab3ab5721a5171","head":{"label":"domenic:fix-vm-propdescs","ref":"fix-vm-propdescs","sha":"5f69cda3065f5cea0438cfbe17ab3ab5721a5171","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"repo":{"id":30843579,"name":"io.js","full_name":"domenic/io.js","owner":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domenic/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/domenic/io.js","forks_url":"https://api.github.com/repos/domenic/io.js/forks","keys_url":"https://api.github.com/repos/domenic/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domenic/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domenic/io.js/teams","hooks_url":"https://api.github.com/repos/domenic/io.js/hooks","issue_events_url":"https://api.github.com/repos/domenic/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/domenic/io.js/events","assignees_url":"https://api.github.com/repos/domenic/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/domenic/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/domenic/io.js/tags","blobs_url":"https://api.github.com/repos/domenic/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domenic/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domenic/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/domenic/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domenic/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/domenic/io.js/languages","stargazers_url":"https://api.github.com/repos/domenic/io.js/stargazers","contributors_url":"https://api.github.com/repos/domenic/io.js/contributors","subscribers_url":"https://api.github.com/repos/domenic/io.js/subscribers","subscription_url":"https://api.github.com/repos/domenic/io.js/subscription","commits_url":"https://api.github.com/repos/domenic/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/domenic/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/domenic/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/domenic/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/domenic/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/domenic/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domenic/io.js/merges","archive_url":"https://api.github.com/repos/domenic/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domenic/io.js/downloads","issues_url":"https://api.github.com/repos/domenic/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/domenic/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/domenic/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/domenic/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domenic/io.js/labels{/name}","releases_url":"https://api.github.com/repos/domenic/io.js/releases{/id}","created_at":"2015-02-15T21:50:44Z","updated_at":"2015-02-15T21:50:50Z","pushed_at":"2015-06-01T16:22:37Z","git_url":"git://github.com/domenic/io.js.git","ssh_url":"git@github.com:domenic/io.js.git","clone_url":"https://github.com/domenic/io.js.git","svn_url":"https://github.com/domenic/io.js","homepage":"https://iojs.org","size":131473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"nodejs:next","ref":"next","sha":"70716fdd930e2b02b95c046f932cf63421bc065f","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Node.js, but with bigger and faster version numbers","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-06-02T21:00:29Z","pushed_at":"2015-06-02T21:09:29Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":187148,"stargazers_count":12565,"watchers_count":12565,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":954,"mirror_url":null,"open_issues_count":284,"forks":954,"open_issues":284,"watchers":12565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1773"},"html":{"href":"https://github.com/nodejs/io.js/pull/1773"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1773"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1773/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1773/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1773/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/5f69cda3065f5cea0438cfbe17ab3ab5721a5171"}}}}