{"action":"created","comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/24520047","id":24520047,"diff_hunk":"@@ -84,76 +85,76 @@ private void UpdateAllControlsList(Control control, string value)\n \t\t{\n \t\t\tif (String.IsNullOrEmpty(value))\n \t\t\t{\n-\t\t\t\tif (m_allControlsHavingToolTips.Contains(control))\n-\t\t\t\t\tm_allControlsHavingToolTips.Remove(control);\n+\t\t\t\tif (_allControlsHavingToolTips.Contains(control))\n+\t\t\t\t\t_allControlsHavingToolTips.Remove(control);\n \t\t\t}\n \t\t\telse\n \t\t\t{\n-\t\t\t\tif (!m_allControlsHavingToolTips.Contains(control))\n-\t\t\t\t\tm_allControlsHavingToolTips.Add(control);\n+\t\t\t\tif (!_allControlsHavingToolTips.Contains(control))\n+\t\t\t\t\t_allControlsHavingToolTips.Add(control);\n \t\t\t}\n \t\t}\n \n-\t\tpublic void SetToolTipWhenDisabled(Control p_control, string value)\n+\t\tpublic void SetToolTipWhenDisabled(Control control, string value)\n \t\t{\n-\t\t\tif (p_control == null)\n+\t\t\tif (control == null)\n \t\t\t{\n \t\t\t\tthrow new ArgumentNullException(\"control\");\n \t\t\t}\n \n-\t\t\tUpdateAllControlsList(p_control, value);\n+\t\t\tUpdateAllControlsList(control, value);\n \n \t\t\tif (!String.IsNullOrEmpty(value))\n \t\t\t{\n-\t\t\t\tthis.m_ToolTipWhenDisabled[p_control] = value;\n-\t\t\t\tif (!p_control.Enabled)\n+\t\t\t\t_toolTipWhenDisabled[control] = value;\n+\t\t\t\tif (!control.Enabled)\n \t\t\t\t{\n \t\t\t\t\t// When the control is disabled at design time, the EnabledChanged\n \t\t\t\t\t// event won't fire. So, on the first Paint event, we should call\n \t\t\t\t\t// PutOnBetterTooltipTransparentOverlay().\n-\t\t\t\t\tm_EvtControlPaint.Add(p_control, new PaintEventHandler(control_Paint));\n-\t\t\t\t\tp_control.Paint += m_EvtControlPaint[p_control];\n+\t\t\t\t\t_paintEventHandlers.Add(control, new PaintEventHandler(control_Paint));\n+\t\t\t\t\tcontrol.Paint += _paintEventHandlers[control];\n \t\t\t\t}\n-\t\t\t\tm_EvtControlEnabledChanged.Add(p_control, new EventHandler(control_EnabledChanged));\n-\t\t\t\tp_control.EnabledChanged += m_EvtControlEnabledChanged[p_control];\n+\t\t\t\t_controlEnabledChangedHandlers.Add(control, new EventHandler(control_EnabledChanged));\n+\t\t\t\tcontrol.EnabledChanged += _controlEnabledChangedHandlers[control];\n \t\t\t}\n \t\t\telse\n \t\t\t{\n-\t\t\t\tm_ToolTipWhenDisabled.Remove(p_control);\n-\t\t\t\tif (m_EvtControlEnabledChanged != null)\n+\t\t\t\t_toolTipWhenDisabled.Remove(control);\n+\t\t\t\tif (_controlEnabledChangedHandlers != null)","path":"src/BloomExe/ToPalaso/BetterToolTip.cs","position":121,"original_position":121,"commit_id":"d03ed43172f1e4d0546548afb6a6b68222a0119f","original_commit_id":"d03ed43172f1e4d0546548afb6a6b68222a0119f","user":{"login":"JohnThomson","id":1360521,"avatar_url":"https://avatars.githubusercontent.com/u/1360521?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnThomson","html_url":"https://github.com/JohnThomson","followers_url":"https://api.github.com/users/JohnThomson/followers","following_url":"https://api.github.com/users/JohnThomson/following{/other_user}","gists_url":"https://api.github.com/users/JohnThomson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnThomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnThomson/subscriptions","organizations_url":"https://api.github.com/users/JohnThomson/orgs","repos_url":"https://api.github.com/users/JohnThomson/repos","events_url":"https://api.github.com/users/JohnThomson/events{/privacy}","received_events_url":"https://api.github.com/users/JohnThomson/received_events","type":"User","site_admin":false},"body":"I'm curious that this branch has to check for null and the other does not","created_at":"2015-02-11T18:36:00Z","updated_at":"2015-02-11T18:36:00Z","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/284#discussion_r24520047","pull_request_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/24520047"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/284#discussion_r24520047"},"pull_request":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284","id":29114056,"html_url":"https://github.com/BloomBooks/BloomDesktop/pull/284","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/284.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/284.patch","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/284","number":284,"state":"open","locked":false,"title":"Improve better tooltip","user":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?v=3","gravatar_id":"","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"body":"The copy/paste etc buttons used to have different colors on Linux, depending on whether they had a tooltip or not. This made it hard to distinguish enabled from disabled state.\r\n\r\nThis change fixes the appearance as well as the BetterTooltip class to properly paint transparency. It also\r\nadds some missing tooltips.\r\n\r\nThis removes the workaround for BL-348 because it is no longer needed with this proper fix.","created_at":"2015-02-11T18:07:57Z","updated_at":"2015-02-11T18:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1ec4e19bd2f74f4833c5f79547bfa5c1c56ad8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284/commits","review_comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284/comments","review_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/284/comments","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/d03ed43172f1e4d0546548afb6a6b68222a0119f","head":{"label":"ermshiperete:ImproveBetterTooltip","ref":"ImproveBetterTooltip","sha":"d03ed43172f1e4d0546548afb6a6b68222a0119f","user":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?v=3","gravatar_id":"","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"repo":{"id":24838683,"name":"BloomDesktop","full_name":"ermshiperete/BloomDesktop","owner":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?v=3","gravatar_id":"","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ermshiperete/BloomDesktop","description":"My contributions to BloomDesktop","fork":true,"url":"https://api.github.com/repos/ermshiperete/BloomDesktop","forks_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/forks","keys_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/events","assignees_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/issues/comments/{number}","contents_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/merges","archive_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/ermshiperete/BloomDesktop/releases{/id}","created_at":"2014-10-06T08:29:31Z","updated_at":"2014-12-17T08:26:52Z","pushed_at":"2015-02-11T18:03:49Z","git_url":"git://github.com/ermshiperete/BloomDesktop.git","ssh_url":"git@github.com:ermshiperete/BloomDesktop.git","clone_url":"https://github.com/ermshiperete/BloomDesktop.git","svn_url":"https://github.com/ermshiperete/BloomDesktop","homepage":"","size":40011,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BloomBooks:master","ref":"master","sha":"cba8444a635c47cd5e647b4d65c21ca7c9e7209e","user":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"repo":{"id":14133680,"name":"BloomDesktop","full_name":"BloomBooks/BloomDesktop","owner":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BloomBooks/BloomDesktop","description":"Bloom Desktop is a hybrid c#/javascript/html/css Windows application that dramatically \"lowers the bar\" for language communities who want books in their own languages. Bloom delivers a low-training, high-output system where mother tongue speakers and their advocates work together to foster both community authorship and access to external material in the vernacular.","fork":false,"url":"https://api.github.com/repos/BloomBooks/BloomDesktop","forks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/forks","keys_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/events","assignees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments/{number}","contents_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/merges","archive_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/releases{/id}","created_at":"2013-11-05T06:12:57Z","updated_at":"2015-02-11T18:19:50Z","pushed_at":"2015-02-11T18:19:50Z","git_url":"git://github.com/BloomBooks/BloomDesktop.git","ssh_url":"git@github.com:BloomBooks/BloomDesktop.git","clone_url":"https://github.com/BloomBooks/BloomDesktop.git","svn_url":"https://github.com/BloomBooks/BloomDesktop","homepage":"http://bloomlibrary.org/","size":54456,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/284"},"issue":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/284"},"comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/d03ed43172f1e4d0546548afb6a6b68222a0119f"}}}}