{"action":"created","comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/23127261","id":23127261,"diff_hunk":"@@ -281,6 +281,9 @@ define({\n     \"STATUSBAR_CODE_INSPECTION_TOOLTIP\"     : \"{0}. Click to toggle report panel.\",\n     \"STATUSBAR_DEFAULT_LANG\"                : \"(default)\",\n     \"STATUSBAR_SET_DEFAULT_LANG\"            : \"Set as Default for .{0} Files\",\n+    \"STATUSBAR_LINE_ENDINGS_CRLF\"           : \"CRLF\",\n+    \"STATUSBAR_LINE_ENDINGS_LF\"             : \"LF\",\n+    \"STATUSBAR_LINE_ENDINGS_TOOLTIP\"        : \"Click to toggle between CRLF(Windows) and LF(Linux and Mac) line endings\",","path":"src/nls/root/strings.js","position":6,"original_position":6,"commit_id":"fec72671ddf6ab6870db81295a8d2ec66494a501","original_commit_id":"fec72671ddf6ab6870db81295a8d2ec66494a501","user":{"login":"peterflynn","id":1197510,"avatar_url":"https://avatars.githubusercontent.com/u/1197510?v=3","gravatar_id":"","url":"https://api.github.com/users/peterflynn","html_url":"https://github.com/peterflynn","followers_url":"https://api.github.com/users/peterflynn/followers","following_url":"https://api.github.com/users/peterflynn/following{/other_user}","gists_url":"https://api.github.com/users/peterflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/peterflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterflynn/subscriptions","organizations_url":"https://api.github.com/users/peterflynn/orgs","repos_url":"https://api.github.com/users/peterflynn/repos","events_url":"https://api.github.com/users/peterflynn/events{/privacy}","received_events_url":"https://api.github.com/users/peterflynn/received_events","type":"User","site_admin":false},"body":"There should be a space before each \"(\".  But we may also want to consider simplifying this -- something shorter like \"Click to toggle line endings\" may be fine.","created_at":"2015-01-17T18:19:57Z","updated_at":"2015-01-17T18:19:57Z","html_url":"https://github.com/adobe/brackets/pull/10346#discussion_r23127261","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/10346","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/23127261"},"html":{"href":"https://github.com/adobe/brackets/pull/10346#discussion_r23127261"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/10346"}}},"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/10346","id":27160763,"html_url":"https://github.com/adobe/brackets/pull/10346","diff_url":"https://github.com/adobe/brackets/pull/10346.diff","patch_url":"https://github.com/adobe/brackets/pull/10346.patch","issue_url":"https://api.github.com/repos/adobe/brackets/issues/10346","number":10346,"state":"open","locked":false,"title":"adding lineEndings UI in statusbar for documents","user":{"login":"sriram-dev","id":1911375,"avatar_url":"https://avatars.githubusercontent.com/u/1911375?v=3","gravatar_id":"","url":"https://api.github.com/users/sriram-dev","html_url":"https://github.com/sriram-dev","followers_url":"https://api.github.com/users/sriram-dev/followers","following_url":"https://api.github.com/users/sriram-dev/following{/other_user}","gists_url":"https://api.github.com/users/sriram-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sriram-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriram-dev/subscriptions","organizations_url":"https://api.github.com/users/sriram-dev/orgs","repos_url":"https://api.github.com/users/sriram-dev/repos","events_url":"https://api.github.com/users/sriram-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sriram-dev/received_events","type":"User","site_admin":false},"body":"Fix for #10106 \r\nTests Done\r\n1) All tests under Brackets->Run Tests\r\n2) jshint tests run from grunt jshint\r\n3) Open a file, modify the Line ending option from existing(say CRLF) to other(say LF), save file. Close the file and reopen to notice that modified LineEnding is preserved. \r\nLet me know if any unit tests needs to be added for the change. I couldn't find any added for other status bar options available. ","created_at":"2015-01-11T09:42:26Z","updated_at":"2015-01-17T18:19:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8d3e0e06a2fa233cc9fb9e58063ae44c329b7ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adobe/brackets/pulls/10346/commits","review_comments_url":"https://api.github.com/repos/adobe/brackets/pulls/10346/comments","review_comment_url":"https://api.github.com/repos/adobe/brackets/pulls/comments/{number}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/10346/comments","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/fec72671ddf6ab6870db81295a8d2ec66494a501","head":{"label":"sriram-dev:10106-lineEndings","ref":"10106-lineEndings","sha":"fec72671ddf6ab6870db81295a8d2ec66494a501","user":{"login":"sriram-dev","id":1911375,"avatar_url":"https://avatars.githubusercontent.com/u/1911375?v=3","gravatar_id":"","url":"https://api.github.com/users/sriram-dev","html_url":"https://github.com/sriram-dev","followers_url":"https://api.github.com/users/sriram-dev/followers","following_url":"https://api.github.com/users/sriram-dev/following{/other_user}","gists_url":"https://api.github.com/users/sriram-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sriram-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriram-dev/subscriptions","organizations_url":"https://api.github.com/users/sriram-dev/orgs","repos_url":"https://api.github.com/users/sriram-dev/repos","events_url":"https://api.github.com/users/sriram-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sriram-dev/received_events","type":"User","site_admin":false},"repo":{"id":15548490,"name":"brackets","full_name":"sriram-dev/brackets","owner":{"login":"sriram-dev","id":1911375,"avatar_url":"https://avatars.githubusercontent.com/u/1911375?v=3","gravatar_id":"","url":"https://api.github.com/users/sriram-dev","html_url":"https://github.com/sriram-dev","followers_url":"https://api.github.com/users/sriram-dev/followers","following_url":"https://api.github.com/users/sriram-dev/following{/other_user}","gists_url":"https://api.github.com/users/sriram-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sriram-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriram-dev/subscriptions","organizations_url":"https://api.github.com/users/sriram-dev/orgs","repos_url":"https://api.github.com/users/sriram-dev/repos","events_url":"https://api.github.com/users/sriram-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sriram-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sriram-dev/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":true,"url":"https://api.github.com/repos/sriram-dev/brackets","forks_url":"https://api.github.com/repos/sriram-dev/brackets/forks","keys_url":"https://api.github.com/repos/sriram-dev/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sriram-dev/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sriram-dev/brackets/teams","hooks_url":"https://api.github.com/repos/sriram-dev/brackets/hooks","issue_events_url":"https://api.github.com/repos/sriram-dev/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/sriram-dev/brackets/events","assignees_url":"https://api.github.com/repos/sriram-dev/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/sriram-dev/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/sriram-dev/brackets/tags","blobs_url":"https://api.github.com/repos/sriram-dev/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sriram-dev/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sriram-dev/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sriram-dev/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sriram-dev/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/sriram-dev/brackets/languages","stargazers_url":"https://api.github.com/repos/sriram-dev/brackets/stargazers","contributors_url":"https://api.github.com/repos/sriram-dev/brackets/contributors","subscribers_url":"https://api.github.com/repos/sriram-dev/brackets/subscribers","subscription_url":"https://api.github.com/repos/sriram-dev/brackets/subscription","commits_url":"https://api.github.com/repos/sriram-dev/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sriram-dev/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sriram-dev/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sriram-dev/brackets/issues/comments/{number}","contents_url":"https://api.github.com/repos/sriram-dev/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/sriram-dev/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sriram-dev/brackets/merges","archive_url":"https://api.github.com/repos/sriram-dev/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sriram-dev/brackets/downloads","issues_url":"https://api.github.com/repos/sriram-dev/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/sriram-dev/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/sriram-dev/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/sriram-dev/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sriram-dev/brackets/labels{/name}","releases_url":"https://api.github.com/repos/sriram-dev/brackets/releases{/id}","created_at":"2013-12-31T10:59:10Z","updated_at":"2015-01-15T17:26:06Z","pushed_at":"2015-01-15T17:26:02Z","git_url":"git://github.com/sriram-dev/brackets.git","ssh_url":"git@github.com:sriram-dev/brackets.git","clone_url":"https://github.com/sriram-dev/brackets.git","svn_url":"https://github.com/sriram-dev/brackets","homepage":"http://brackets.io","size":73613,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"47293e9af276179dbd93cfe13e9edef6bed97c52","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars.githubusercontent.com/u/476009?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":2935735,"name":"brackets","full_name":"adobe/brackets","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars.githubusercontent.com/u/476009?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":false,"url":"https://api.github.com/repos/adobe/brackets","forks_url":"https://api.github.com/repos/adobe/brackets/forks","keys_url":"https://api.github.com/repos/adobe/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/brackets/teams","hooks_url":"https://api.github.com/repos/adobe/brackets/hooks","issue_events_url":"https://api.github.com/repos/adobe/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/brackets/events","assignees_url":"https://api.github.com/repos/adobe/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/brackets/tags","blobs_url":"https://api.github.com/repos/adobe/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/brackets/languages","stargazers_url":"https://api.github.com/repos/adobe/brackets/stargazers","contributors_url":"https://api.github.com/repos/adobe/brackets/contributors","subscribers_url":"https://api.github.com/repos/adobe/brackets/subscribers","subscription_url":"https://api.github.com/repos/adobe/brackets/subscription","commits_url":"https://api.github.com/repos/adobe/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/brackets/issues/comments/{number}","contents_url":"https://api.github.com/repos/adobe/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/brackets/merges","archive_url":"https://api.github.com/repos/adobe/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/brackets/downloads","issues_url":"https://api.github.com/repos/adobe/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/brackets/labels{/name}","releases_url":"https://api.github.com/repos/adobe/brackets/releases{/id}","created_at":"2011-12-07T21:14:40Z","updated_at":"2015-01-17T16:30:55Z","pushed_at":"2015-01-16T19:49:26Z","git_url":"git://github.com/adobe/brackets.git","ssh_url":"git@github.com:adobe/brackets.git","clone_url":"https://github.com/adobe/brackets.git","svn_url":"https://github.com/adobe/brackets","homepage":"http://brackets.io","size":304638,"stargazers_count":20602,"watchers_count":20602,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4281,"mirror_url":null,"open_issues_count":1128,"forks":4281,"open_issues":1128,"watchers":20602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/10346"},"html":{"href":"https://github.com/adobe/brackets/pull/10346"},"issue":{"href":"https://api.github.com/repos/adobe/brackets/issues/10346"},"comments":{"href":"https://api.github.com/repos/adobe/brackets/issues/10346/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/brackets/pulls/10346/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/adobe/brackets/pulls/10346/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/brackets/statuses/fec72671ddf6ab6870db81295a8d2ec66494a501"}}}}