{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2462","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2462/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2462/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2462/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/2462","id":49340200,"number":2462,"title":"node.Name/minion.Name should not be used as an address","user":{"login":"anguslees","id":224224,"avatar_url":"https://avatars.githubusercontent.com/u/224224?v=3","gravatar_id":"","url":"https://api.github.com/users/anguslees","html_url":"https://github.com/anguslees","followers_url":"https://api.github.com/users/anguslees/followers","following_url":"https://api.github.com/users/anguslees/following{/other_user}","gists_url":"https://api.github.com/users/anguslees/gists{/gist_id}","starred_url":"https://api.github.com/users/anguslees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anguslees/subscriptions","organizations_url":"https://api.github.com/users/anguslees/orgs","repos_url":"https://api.github.com/users/anguslees/repos","events_url":"https://api.github.com/users/anguslees/events{/privacy}","received_events_url":"https://api.github.com/users/anguslees/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/component/nodecontroller","name":"component/nodecontroller","color":"0052cc"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/team/cluster-lifecycle","name":"team/cluster-lifecycle","color":"d2b48c"}],"state":"closed","locked":false,"assignee":{"login":"cjcullen","id":7154008,"avatar_url":"https://avatars.githubusercontent.com/u/7154008?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcullen","html_url":"https://github.com/cjcullen","followers_url":"https://api.github.com/users/cjcullen/followers","following_url":"https://api.github.com/users/cjcullen/following{/other_user}","gists_url":"https://api.github.com/users/cjcullen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcullen/subscriptions","organizations_url":"https://api.github.com/users/cjcullen/orgs","repos_url":"https://api.github.com/users/cjcullen/repos","events_url":"https://api.github.com/users/cjcullen/events{/privacy}","received_events_url":"https://api.github.com/users/cjcullen/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones/6","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/milestones/v1.0","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones/6/labels","id":969317,"number":6,"title":"v1.0","description":"Issues that need to be resolved for v1.0 of Kubernetes.","creator":{"login":"goltermann","id":9358478,"avatar_url":"https://avatars.githubusercontent.com/u/9358478?v=3","gravatar_id":"","url":"https://api.github.com/users/goltermann","html_url":"https://github.com/goltermann","followers_url":"https://api.github.com/users/goltermann/followers","following_url":"https://api.github.com/users/goltermann/following{/other_user}","gists_url":"https://api.github.com/users/goltermann/gists{/gist_id}","starred_url":"https://api.github.com/users/goltermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goltermann/subscriptions","organizations_url":"https://api.github.com/users/goltermann/orgs","repos_url":"https://api.github.com/users/goltermann/repos","events_url":"https://api.github.com/users/goltermann/events{/privacy}","received_events_url":"https://api.github.com/users/goltermann/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":363,"state":"open","created_at":"2015-02-06T20:27:16Z","updated_at":"2015-06-10T16:54:43Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2014-11-19T07:02:30Z","updated_at":"2015-06-10T16:54:43Z","closed_at":"2015-06-10T16:54:43Z","body":"According to my git grepping, the cloudprovider.Instances().IPAddress() function is only used when finding *pod* hosts (ie: pod.getInstanceIP()), not when finding *minion* addresses (ie: minion.ResourceLocation()) for healthchecking, etc.\r\n\r\nThe result is that my (openstack) cloudprovider is called to find minions and returns a list of \"names\".  These names are neither literal IPs nor DNS names, so minion.ResourceLocation turns them into URLs that later fail to resolve, and the new minions never pass health checks.\r\n\r\nI suggest minion.ResourceLocation should use code very much like pod.getInstanceIP to do name->address mapping via the cloudprovider plugin.  This would presumably involve moving getInstanceIP out into a common library/singleton somewhere so both callers can benefit from a shared cache (see getInstanceIP)."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/110832383","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/2462#issuecomment-110832383","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2462","id":110832383,"user":{"login":"alex-mohr","id":8729097,"avatar_url":"https://avatars.githubusercontent.com/u/8729097?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mohr","html_url":"https://github.com/alex-mohr","followers_url":"https://api.github.com/users/alex-mohr/followers","following_url":"https://api.github.com/users/alex-mohr/following{/other_user}","gists_url":"https://api.github.com/users/alex-mohr/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mohr/subscriptions","organizations_url":"https://api.github.com/users/alex-mohr/orgs","repos_url":"https://api.github.com/users/alex-mohr/repos","events_url":"https://api.github.com/users/alex-mohr/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mohr/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T16:54:43Z","updated_at":"2015-06-10T16:54:43Z","body":"Closing #2462 via #9451"}}