{"action":"created","issue":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/2101","labels_url":"https://api.github.com/repos/kangax/fabric.js/issues/2101/labels{/name}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/2101/comments","events_url":"https://api.github.com/repos/kangax/fabric.js/issues/2101/events","html_url":"https://github.com/kangax/fabric.js/pull/2101","id":67289916,"number":2101,"title":"Fix group initialization","user":{"login":"sapics","id":11169954,"avatar_url":"https://avatars.githubusercontent.com/u/11169954?v=3","gravatar_id":"","url":"https://api.github.com/users/sapics","html_url":"https://github.com/sapics","followers_url":"https://api.github.com/users/sapics/followers","following_url":"https://api.github.com/users/sapics/following{/other_user}","gists_url":"https://api.github.com/users/sapics/gists{/gist_id}","starred_url":"https://api.github.com/users/sapics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapics/subscriptions","organizations_url":"https://api.github.com/users/sapics/orgs","repos_url":"https://api.github.com/users/sapics/repos","events_url":"https://api.github.com/users/sapics/events{/privacy}","received_events_url":"https://api.github.com/users/sapics/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-04-09T06:20:12Z","updated_at":"2015-04-23T10:19:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/2101","html_url":"https://github.com/kangax/fabric.js/pull/2101","diff_url":"https://github.com/kangax/fabric.js/pull/2101.diff","patch_url":"https://github.com/kangax/fabric.js/pull/2101.patch"},"body":"#2095 @chrisrickard reported a problem of `group.toObject`. This PR would fix it.\r\nThere are two fixed points.\r\n\r\n1. If toObject copied delegatedProperties, it affects to grouped objects at initialization (https://github.com/kangax/fabric.js/blob/master/src/shapes/group.class.js#L72).\r\nI removed delegatedProperties at toObject function, but it is also possible to fix by changing group initialization code. I felt that fix at toObject will be better for consistency.\r\n\r\n~~2. At toObject, _objects copied normally. However, at initialization, _objects coordinates are updated (https://github.com/kangax/fabric.js/blob/master/src/shapes/group.class.js#L70).\r\nIt makes change position of grouped objects.\r\nTo fix it, I use _restoreObjectsState, before copying _objects.~~"},"comment":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/comments/95525205","html_url":"https://github.com/kangax/fabric.js/pull/2101#issuecomment-95525205","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/2101","id":95525205,"user":{"login":"sapics","id":11169954,"avatar_url":"https://avatars.githubusercontent.com/u/11169954?v=3","gravatar_id":"","url":"https://api.github.com/users/sapics","html_url":"https://github.com/sapics","followers_url":"https://api.github.com/users/sapics/followers","following_url":"https://api.github.com/users/sapics/following{/other_user}","gists_url":"https://api.github.com/users/sapics/gists{/gist_id}","starred_url":"https://api.github.com/users/sapics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapics/subscriptions","organizations_url":"https://api.github.com/users/sapics/orgs","repos_url":"https://api.github.com/users/sapics/repos","events_url":"https://api.github.com/users/sapics/events{/privacy}","received_events_url":"https://api.github.com/users/sapics/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T10:19:33Z","updated_at":"2015-04-23T10:19:33Z","body":"Thank you for analizing!\r\n\r\nThank you for your kindness! I know new feature of git! git is really difficult, but much fun!\r\nNow, I am in google..., it looks difficult... (`git rebase -i`, and set `squash` to later commit?)\r\nI would use `git rebase -i` after the fix is done!\r\n\r\nSorry, I am rookie in git and github... Thank you very much for many helps!!"}}