{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/2257","labels_url":"https://api.github.com/repos/nodejs/node/issues/2257/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2257/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/2257/events","html_url":"https://github.com/nodejs/node/pull/2257","id":97583833,"number":2257,"title":"test: move timeout test from internet to parallel","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-28T00:13:40Z","updated_at":"2015-08-21T20:19:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2257","html_url":"https://github.com/nodejs/node/pull/2257","diff_url":"https://github.com/nodejs/node/pull/2257.diff","patch_url":"https://github.com/nodejs/node/pull/2257.patch"},"body":"test-net-connect-timeout.js does not use internet anymore\r\nso it can and should be moved to the parallel tests directory.\r\n\r\nCI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/205/"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/133549487","html_url":"https://github.com/nodejs/node/pull/2257#issuecomment-133549487","issue_url":"https://api.github.com/repos/nodejs/node/issues/2257","id":133549487,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T20:19:12Z","updated_at":"2015-08-21T20:19:12Z","body":"LGTM in principle but the commit log should mention that you updated the test to use a different address.\r\n\r\nAn argument for keeping the test in test/internet: it's going to behave erratically when the egress firewall rules reject packets to 192.0.2.0/24.  I don't know how common that is but there is probably someone somewhere doing it."}}