{"action":"created","comment":{"url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/comments/36389494","id":36389494,"diff_hunk":"@@ -29,430 +29,366 @@\n #include <algorithm>\n \n #include <ros/ros.h>\n-#include \"ros/package.h\"\n #include <std_srvs/Empty.h>\n #include <cob_srvs/SetString.h>\n-#include <kdl_conversions/kdl_msg.h>\n \n #include <cob_cartesian_controller/cartesian_controller.h>\n-#include <cob_cartesian_controller/trajectory_interpolator/trajectory_interpolator.h>\n \n bool CartesianController::initialize()\n {\n     ros::NodeHandle nh_private(\"~\");\n \n-    ///get params articulation Nodehandle\n-    if(!nh_private.getParam(\"reference_frame\", reference_frame_))\n+    if (!nh_.getParam(\"chain_tip_link\", chain_tip_link_))\n     {\n-        ROS_ERROR(\"Parameter 'reference_frame' not set\");\n+        ROS_ERROR(\"Parameter 'chain_tip_link' not set\");\n         return false;\n     }\n-\n-    if(!nh_private.getParam(\"target_frame\", target_frame_))\n+    \n+    if(!nh_.getParam(\"root_frame\", root_frame_))\n     {\n-        ROS_ERROR(\"Parameter 'target_frame' not set\");\n+        ROS_ERROR(\"Parameter 'reference_frame' not set\");\n         return false;\n     }\n \n-    if (nh_private.hasParam(\"update_rate\"))\n-    {    nh_private.getParam(\"update_rate\", update_rate_);    }\n-    else\n-    {    update_rate_ = 68.0;    }    //hz\n-\n+    if(!nh_.getParam(\"update_rate\", update_rate_))\n+    {\n+        update_rate_ = 50.0;    //hz\n+    }\n \n-    /// Cartesian Nodehandle\n-    if (!nh_.getParam(\"chain_tip_link\", chain_tip_link_))\n+    /// Private Nodehandle\n+    if(!nh_private.getParam(\"target_frame\", target_frame_))\n     {\n-        ROS_ERROR(\"Parameter 'chain_tip_link' not set\");\n-        return false;\n+        ROS_WARN(\"Parameter 'target_frame' not set. Using default 'cartesian_target'\");\n+        target_frame_ = \"cartesian_target\";","path":"cob_cartesian_controller/src/cartesian_controller.cpp","position":52,"original_position":52,"commit_id":"f2a5393beaee71babbc39f056c70b3ac5c6e0e39","original_commit_id":"f2a5393beaee71babbc39f056c70b3ac5c6e0e39","user":{"login":"ipa-fxm","id":508006,"avatar_url":"https://avatars.githubusercontent.com/u/508006?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm","html_url":"https://github.com/ipa-fxm","followers_url":"https://api.github.com/users/ipa-fxm/followers","following_url":"https://api.github.com/users/ipa-fxm/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm/orgs","repos_url":"https://api.github.com/users/ipa-fxm/repos","events_url":"https://api.github.com/users/ipa-fxm/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-08-06T07:59:54Z","updated_at":"2015-08-06T07:59:54Z","html_url":"https://github.com/ipa-fxm-mb/cob_control/pull/4#discussion_r36389494","pull_request_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/comments/36389494"},"html":{"href":"https://github.com/ipa-fxm-mb/cob_control/pull/4#discussion_r36389494"},"pull_request":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4","id":40875299,"html_url":"https://github.com/ipa-fxm-mb/cob_control/pull/4","diff_url":"https://github.com/ipa-fxm-mb/cob_control/pull/4.diff","patch_url":"https://github.com/ipa-fxm-mb/cob_control/pull/4.patch","issue_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues/4","number":4,"state":"closed","locked":false,"title":"Test of feature","user":{"login":"ipa-fxm-mb","id":11269199,"avatar_url":"https://avatars.githubusercontent.com/u/11269199?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm-mb","html_url":"https://github.com/ipa-fxm-mb","followers_url":"https://api.github.com/users/ipa-fxm-mb/followers","following_url":"https://api.github.com/users/ipa-fxm-mb/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm-mb/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm-mb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm-mb/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm-mb/orgs","repos_url":"https://api.github.com/users/ipa-fxm-mb/repos","events_url":"https://api.github.com/users/ipa-fxm-mb/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm-mb/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-27T07:04:58Z","updated_at":"2015-08-06T07:59:54Z","closed_at":"2015-07-29T12:56:24Z","merged_at":"2015-07-29T12:56:24Z","merge_commit_sha":"43fba62b5341997a92138b5210ee85b2e0ab8efc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues/4/comments","statuses_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/statuses/f2a5393beaee71babbc39f056c70b3ac5c6e0e39","head":{"label":"ipa-fxm:test_of_feature","ref":"test_of_feature","sha":"f2a5393beaee71babbc39f056c70b3ac5c6e0e39","user":{"login":"ipa-fxm","id":508006,"avatar_url":"https://avatars.githubusercontent.com/u/508006?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm","html_url":"https://github.com/ipa-fxm","followers_url":"https://api.github.com/users/ipa-fxm/followers","following_url":"https://api.github.com/users/ipa-fxm/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm/orgs","repos_url":"https://api.github.com/users/ipa-fxm/repos","events_url":"https://api.github.com/users/ipa-fxm/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm/received_events","type":"User","site_admin":false},"repo":{"id":20218732,"name":"cob_control","full_name":"ipa-fxm/cob_control","owner":{"login":"ipa-fxm","id":508006,"avatar_url":"https://avatars.githubusercontent.com/u/508006?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm","html_url":"https://github.com/ipa-fxm","followers_url":"https://api.github.com/users/ipa-fxm/followers","following_url":"https://api.github.com/users/ipa-fxm/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm/orgs","repos_url":"https://api.github.com/users/ipa-fxm/repos","events_url":"https://api.github.com/users/ipa-fxm/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ipa-fxm/cob_control","description":"The cob_control stack includes packages that are used to do low level control tasks with Care-O-bot hardware over ROS.","fork":true,"url":"https://api.github.com/repos/ipa-fxm/cob_control","forks_url":"https://api.github.com/repos/ipa-fxm/cob_control/forks","keys_url":"https://api.github.com/repos/ipa-fxm/cob_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipa-fxm/cob_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipa-fxm/cob_control/teams","hooks_url":"https://api.github.com/repos/ipa-fxm/cob_control/hooks","issue_events_url":"https://api.github.com/repos/ipa-fxm/cob_control/issues/events{/number}","events_url":"https://api.github.com/repos/ipa-fxm/cob_control/events","assignees_url":"https://api.github.com/repos/ipa-fxm/cob_control/assignees{/user}","branches_url":"https://api.github.com/repos/ipa-fxm/cob_control/branches{/branch}","tags_url":"https://api.github.com/repos/ipa-fxm/cob_control/tags","blobs_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipa-fxm/cob_control/statuses/{sha}","languages_url":"https://api.github.com/repos/ipa-fxm/cob_control/languages","stargazers_url":"https://api.github.com/repos/ipa-fxm/cob_control/stargazers","contributors_url":"https://api.github.com/repos/ipa-fxm/cob_control/contributors","subscribers_url":"https://api.github.com/repos/ipa-fxm/cob_control/subscribers","subscription_url":"https://api.github.com/repos/ipa-fxm/cob_control/subscription","commits_url":"https://api.github.com/repos/ipa-fxm/cob_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipa-fxm/cob_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipa-fxm/cob_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipa-fxm/cob_control/contents/{+path}","compare_url":"https://api.github.com/repos/ipa-fxm/cob_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipa-fxm/cob_control/merges","archive_url":"https://api.github.com/repos/ipa-fxm/cob_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipa-fxm/cob_control/downloads","issues_url":"https://api.github.com/repos/ipa-fxm/cob_control/issues{/number}","pulls_url":"https://api.github.com/repos/ipa-fxm/cob_control/pulls{/number}","milestones_url":"https://api.github.com/repos/ipa-fxm/cob_control/milestones{/number}","notifications_url":"https://api.github.com/repos/ipa-fxm/cob_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipa-fxm/cob_control/labels{/name}","releases_url":"https://api.github.com/repos/ipa-fxm/cob_control/releases{/id}","created_at":"2014-05-27T12:11:10Z","updated_at":"2015-05-04T12:25:06Z","pushed_at":"2015-08-06T06:40:27Z","git_url":"git://github.com/ipa-fxm/cob_control.git","ssh_url":"git@github.com:ipa-fxm/cob_control.git","clone_url":"https://github.com/ipa-fxm/cob_control.git","svn_url":"https://github.com/ipa-fxm/cob_control","homepage":"www.care-o-bot.org","size":5259,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"indigo_dev"}},"base":{"label":"ipa-fxm-mb:test_of_feature","ref":"test_of_feature","sha":"f3564166bb46f5737490c0eab74a413163e6bae9","user":{"login":"ipa-fxm-mb","id":11269199,"avatar_url":"https://avatars.githubusercontent.com/u/11269199?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm-mb","html_url":"https://github.com/ipa-fxm-mb","followers_url":"https://api.github.com/users/ipa-fxm-mb/followers","following_url":"https://api.github.com/users/ipa-fxm-mb/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm-mb/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm-mb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm-mb/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm-mb/orgs","repos_url":"https://api.github.com/users/ipa-fxm-mb/repos","events_url":"https://api.github.com/users/ipa-fxm-mb/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm-mb/received_events","type":"User","site_admin":false},"repo":{"id":32982325,"name":"cob_control","full_name":"ipa-fxm-mb/cob_control","owner":{"login":"ipa-fxm-mb","id":11269199,"avatar_url":"https://avatars.githubusercontent.com/u/11269199?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm-mb","html_url":"https://github.com/ipa-fxm-mb","followers_url":"https://api.github.com/users/ipa-fxm-mb/followers","following_url":"https://api.github.com/users/ipa-fxm-mb/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm-mb/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm-mb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm-mb/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm-mb/orgs","repos_url":"https://api.github.com/users/ipa-fxm-mb/repos","events_url":"https://api.github.com/users/ipa-fxm-mb/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm-mb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ipa-fxm-mb/cob_control","description":"The cob_control stack includes packages that are used to do low level control tasks with Care-O-bot hardware over ROS.","fork":true,"url":"https://api.github.com/repos/ipa-fxm-mb/cob_control","forks_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/forks","keys_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/teams","hooks_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/hooks","issue_events_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues/events{/number}","events_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/events","assignees_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/assignees{/user}","branches_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/branches{/branch}","tags_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/tags","blobs_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/statuses/{sha}","languages_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/languages","stargazers_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/stargazers","contributors_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/contributors","subscribers_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/subscribers","subscription_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/subscription","commits_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/contents/{+path}","compare_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/merges","archive_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/downloads","issues_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues{/number}","pulls_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls{/number}","milestones_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/milestones{/number}","notifications_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/labels{/name}","releases_url":"https://api.github.com/repos/ipa-fxm-mb/cob_control/releases{/id}","created_at":"2015-03-27T11:24:17Z","updated_at":"2015-05-04T13:46:30Z","pushed_at":"2015-08-05T17:10:58Z","git_url":"git://github.com/ipa-fxm-mb/cob_control.git","ssh_url":"git@github.com:ipa-fxm-mb/cob_control.git","clone_url":"https://github.com/ipa-fxm-mb/cob_control.git","svn_url":"https://github.com/ipa-fxm-mb/cob_control","homepage":"www.care-o-bot.org","size":4961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"indigo_dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4"},"html":{"href":"https://github.com/ipa-fxm-mb/cob_control/pull/4"},"issue":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues/4"},"comments":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ipa-fxm-mb/cob_control/statuses/f2a5393beaee71babbc39f056c70b3ac5c6e0e39"}}}}