{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/comments/46294316","id":46294316,"diff_hunk":"@@ -0,0 +1,47 @@\n+# This Source Code Form is subject to the terms of the Mozilla Public\n+# License, v. 2.0. If a copy of the MPL was not distributed with this file,\n+# You can obtain one at http://mozilla.org/MPL/2.0/.\n+\n+from marionette_driver import By\n+\n+from firefox_puppeteer.ui_base_lib import UIBaseLib\n+\n+\n+class BaseDeck(UIBaseLib):\n+\n+    def _create_panel_for_id(self, panel_id):\n+        \"\"\"Creates an instance of :class:`Panel` for the specified panel id.\n+\n+        :param panel_id: The ID of the panel to create an instance of.\n+\n+        :returns: :class:`Panel` instance\n+        \"\"\"\n+        mapping = {'apply': ApplyPanel,\n+                   'applyBillboard': ApplyBillboardPanel,\n+                   'checkForUpdates': CheckForUpdatesPanel,\n+                   'checkingForUpdates': CheckingForUpdatesPanel,\n+                   'downloadAndInstall': DownloadAndInstallPanel,\n+                   'downloadFailed': DownloadFailedPanel,\n+                   'downloading': DownloadingPanel,\n+                   'feedPanel': FeedPanel,\n+                   'generalPanel': GeneralPanel,\n+                   'mediaPanel': MediaPanel,\n+                   'noUpdatesFound': NoUpdatesFoundPanel,\n+                   'permPanel': PermissionsPanel,\n+                   'securityPanel': SecurityPanel","path":"firefox_puppeteer/ui/deck.py","position":31,"original_position":31,"commit_id":"7f639d781cc335a3b7295af2ff2d1e1bb04f1cb0","original_commit_id":"7f639d781cc335a3b7295af2ff2d1e1bb04f1cb0","user":{"login":"whimboo","id":129603,"avatar_url":"https://avatars.githubusercontent.com/u/129603?v=3","gravatar_id":"","url":"https://api.github.com/users/whimboo","html_url":"https://github.com/whimboo","followers_url":"https://api.github.com/users/whimboo/followers","following_url":"https://api.github.com/users/whimboo/following{/other_user}","gists_url":"https://api.github.com/users/whimboo/gists{/gist_id}","starred_url":"https://api.github.com/users/whimboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whimboo/subscriptions","organizations_url":"https://api.github.com/users/whimboo/orgs","repos_url":"https://api.github.com/users/whimboo/repos","events_url":"https://api.github.com/users/whimboo/events{/privacy}","received_events_url":"https://api.github.com/users/whimboo/received_events","type":"User","site_admin":false},"body":"All those panels are specific classes for the update deck in the about window. So they have to stay as part of the subclass in the other file. As of now the class references cannot be found.","created_at":"2015-12-01T15:47:26Z","updated_at":"2015-12-01T15:47:26Z","html_url":"https://github.com/mozilla/firefox-ui-tests/pull/289#discussion_r46294316","pull_request_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/comments/46294316"},"html":{"href":"https://github.com/mozilla/firefox-ui-tests/pull/289#discussion_r46294316"},"pull_request":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289","id":51328893,"html_url":"https://github.com/mozilla/firefox-ui-tests/pull/289","diff_url":"https://github.com/mozilla/firefox-ui-tests/pull/289.diff","patch_url":"https://github.com/mozilla/firefox-ui-tests/pull/289.patch","issue_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues/289","number":289,"state":"open","locked":false,"title":"Bug 1143928 - Refactor Deck and Panel classes to reduce code duplicat…","user":{"login":"utvar","id":11558724,"avatar_url":"https://avatars.githubusercontent.com/u/11558724?v=3","gravatar_id":"","url":"https://api.github.com/users/utvar","html_url":"https://github.com/utvar","followers_url":"https://api.github.com/users/utvar/followers","following_url":"https://api.github.com/users/utvar/following{/other_user}","gists_url":"https://api.github.com/users/utvar/gists{/gist_id}","starred_url":"https://api.github.com/users/utvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utvar/subscriptions","organizations_url":"https://api.github.com/users/utvar/orgs","repos_url":"https://api.github.com/users/utvar/repos","events_url":"https://api.github.com/users/utvar/events{/privacy}","received_events_url":"https://api.github.com/users/utvar/received_events","type":"User","site_admin":false},"body":"…ion. r=whimboo","created_at":"2015-11-20T08:21:29Z","updated_at":"2015-12-01T15:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4102f1db451710ed4bcf0478e3c84e24dc2b9a25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289/commits","review_comments_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289/comments","review_comment_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues/289/comments","statuses_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/statuses/7f639d781cc335a3b7295af2ff2d1e1bb04f1cb0","head":{"label":"utvar:refactor-deck-panel","ref":"refactor-deck-panel","sha":"7f639d781cc335a3b7295af2ff2d1e1bb04f1cb0","user":{"login":"utvar","id":11558724,"avatar_url":"https://avatars.githubusercontent.com/u/11558724?v=3","gravatar_id":"","url":"https://api.github.com/users/utvar","html_url":"https://github.com/utvar","followers_url":"https://api.github.com/users/utvar/followers","following_url":"https://api.github.com/users/utvar/following{/other_user}","gists_url":"https://api.github.com/users/utvar/gists{/gist_id}","starred_url":"https://api.github.com/users/utvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utvar/subscriptions","organizations_url":"https://api.github.com/users/utvar/orgs","repos_url":"https://api.github.com/users/utvar/repos","events_url":"https://api.github.com/users/utvar/events{/privacy}","received_events_url":"https://api.github.com/users/utvar/received_events","type":"User","site_admin":false},"repo":{"id":34583724,"name":"firefox-ui-tests","full_name":"utvar/firefox-ui-tests","owner":{"login":"utvar","id":11558724,"avatar_url":"https://avatars.githubusercontent.com/u/11558724?v=3","gravatar_id":"","url":"https://api.github.com/users/utvar","html_url":"https://github.com/utvar","followers_url":"https://api.github.com/users/utvar/followers","following_url":"https://api.github.com/users/utvar/following{/other_user}","gists_url":"https://api.github.com/users/utvar/gists{/gist_id}","starred_url":"https://api.github.com/users/utvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utvar/subscriptions","organizations_url":"https://api.github.com/users/utvar/orgs","repos_url":"https://api.github.com/users/utvar/repos","events_url":"https://api.github.com/users/utvar/events{/privacy}","received_events_url":"https://api.github.com/users/utvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/utvar/firefox-ui-tests","description":"","fork":true,"url":"https://api.github.com/repos/utvar/firefox-ui-tests","forks_url":"https://api.github.com/repos/utvar/firefox-ui-tests/forks","keys_url":"https://api.github.com/repos/utvar/firefox-ui-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utvar/firefox-ui-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utvar/firefox-ui-tests/teams","hooks_url":"https://api.github.com/repos/utvar/firefox-ui-tests/hooks","issue_events_url":"https://api.github.com/repos/utvar/firefox-ui-tests/issues/events{/number}","events_url":"https://api.github.com/repos/utvar/firefox-ui-tests/events","assignees_url":"https://api.github.com/repos/utvar/firefox-ui-tests/assignees{/user}","branches_url":"https://api.github.com/repos/utvar/firefox-ui-tests/branches{/branch}","tags_url":"https://api.github.com/repos/utvar/firefox-ui-tests/tags","blobs_url":"https://api.github.com/repos/utvar/firefox-ui-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utvar/firefox-ui-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utvar/firefox-ui-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/utvar/firefox-ui-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utvar/firefox-ui-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/utvar/firefox-ui-tests/languages","stargazers_url":"https://api.github.com/repos/utvar/firefox-ui-tests/stargazers","contributors_url":"https://api.github.com/repos/utvar/firefox-ui-tests/contributors","subscribers_url":"https://api.github.com/repos/utvar/firefox-ui-tests/subscribers","subscription_url":"https://api.github.com/repos/utvar/firefox-ui-tests/subscription","commits_url":"https://api.github.com/repos/utvar/firefox-ui-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/utvar/firefox-ui-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/utvar/firefox-ui-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/utvar/firefox-ui-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/utvar/firefox-ui-tests/contents/{+path}","compare_url":"https://api.github.com/repos/utvar/firefox-ui-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utvar/firefox-ui-tests/merges","archive_url":"https://api.github.com/repos/utvar/firefox-ui-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utvar/firefox-ui-tests/downloads","issues_url":"https://api.github.com/repos/utvar/firefox-ui-tests/issues{/number}","pulls_url":"https://api.github.com/repos/utvar/firefox-ui-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/utvar/firefox-ui-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/utvar/firefox-ui-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utvar/firefox-ui-tests/labels{/name}","releases_url":"https://api.github.com/repos/utvar/firefox-ui-tests/releases{/id}","created_at":"2015-04-25T19:54:35Z","updated_at":"2015-04-25T19:54:36Z","pushed_at":"2015-12-01T14:51:45Z","git_url":"git://github.com/utvar/firefox-ui-tests.git","ssh_url":"git@github.com:utvar/firefox-ui-tests.git","clone_url":"https://github.com/utvar/firefox-ui-tests.git","svn_url":"https://github.com/utvar/firefox-ui-tests","homepage":null,"size":534,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mozilla-central"}},"base":{"label":"mozilla:mozilla-central","ref":"mozilla-central","sha":"027f0d62405f074bf937913cba31cc6cd5dc2552","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":25004372,"name":"firefox-ui-tests","full_name":"mozilla/firefox-ui-tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ui-tests","description":"","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ui-tests","forks_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ui-tests/releases{/id}","created_at":"2014-10-09T19:09:05Z","updated_at":"2015-11-09T08:30:44Z","pushed_at":"2015-12-01T14:51:45Z","git_url":"git://github.com/mozilla/firefox-ui-tests.git","ssh_url":"git@github.com:mozilla/firefox-ui-tests.git","clone_url":"https://github.com/mozilla/firefox-ui-tests.git","svn_url":"https://github.com/mozilla/firefox-ui-tests","homepage":null,"size":1130,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":7,"forks":38,"open_issues":7,"watchers":14,"default_branch":"mozilla-central"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289"},"html":{"href":"https://github.com/mozilla/firefox-ui-tests/pull/289"},"issue":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues/289"},"comments":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/firefox-ui-tests/statuses/7f639d781cc335a3b7295af2ff2d1e1bb04f1cb0"}}}}