{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/27212356","id":27212356,"diff_hunk":"@@ -158,100 +125,88 @@ def get_error_messages(self, cr, uid, ids, context=None):\n                 \"- Grant access only to contacts with unique emails\"))\n         return error_msg\n \n-    def action_apply(self, cr, uid, ids, context=None):\n-        error_msg = self.get_error_messages(cr, uid, ids, context=context)\n+    @api.multi\n+    def action_apply(self):\n+        error_msg = self.get_error_messages()\n         if error_msg:\n             raise UserError( \"\\n\\n\".join(error_msg))\n \n-        for wizard_user in self.browse(cr, SUPERUSER_ID, ids, context):\n-            portal = wizard_user.wizard_id.portal_id\n-            user = self._retrieve_user(cr, SUPERUSER_ID, wizard_user, context)\n-            if wizard_user.partner_id.email != wizard_user.email:\n-                wizard_user.partner_id.write({'email': wizard_user.email})\n-            if wizard_user.in_portal:\n-                # create a user if necessary, and make sure it is in the portal group\n-                if not user:\n-                    user = self._create_user(cr, SUPERUSER_ID, wizard_user, context)\n-                if (not user.active) or (portal not in user.groups_id):\n-                    user.write({'active': True, 'groups_id': [(4, portal.id)]})\n-                    # prepare for the signup process\n-                    user.partner_id.signup_prepare()\n-                wizard_user.refresh()\n-                self._send_email(cr, uid, wizard_user, context)\n-            else:\n-                # remove the user (if it exists) from the portal group\n-                if user and (portal in user.groups_id):\n-                    # if user belongs to portal only, deactivate it\n-                    if len(user.groups_id) <= 1:\n-                        user.write({'groups_id': [(3, portal.id)], 'active': False})\n-                    else:\n-                        user.write({'groups_id': [(3, portal.id)]})\n-\n-    def _retrieve_user(self, cr, uid, wizard_user, context=None):\n+        portal = self.wizard_id.portal_id\n+        user = self.sudo()._retrieve_user()\n+        if self.partner_id.email != self.email:\n+            self.partner_id.write({'email': wizard_user.email})\n+        if self.in_portal:\n+            # create a user if necessary, and make sure it is in the portal group\n+            if not user:\n+                user = self.sudo()._create_user()\n+            if (not user.active) or (portal not in user.groups_id):\n+                user.write({'active': True, 'groups_id': [(4, portal.id)]})\n+                # prepare for the signup process\n+                user.partner_id.signup_prepare()\n+            self.refresh()\n+            self._send_email()\n+        else:\n+            # remove the user (if it exists) from the portal group\n+            if user and (portal in user.groups_id):\n+                # if user belongs to portal only, deactivate it\n+                if len(user.groups_id) <= 1:\n+                    user.write({'groups_id': [(3, portal.id)], 'active': False})\n+                else:\n+                    user.write({'groups_id': [(3, portal.id)]})\n+\n+    def _retrieve_user(self):\n         \"\"\" retrieve the (possibly inactive) user corresponding to wizard_user.partner_id\n             @param wizard_user: browse record of model portal.wizard.user\n             @return: browse record of model res.users\n         \"\"\"\n-        context = dict(context or {}, active_test=False)\n-        res_users = self.pool.get('res.users')\n-        domain = [('partner_id', '=', wizard_user.partner_id.id)]\n-        user_ids = res_users.search(cr, uid, domain, context=context)\n-        return user_ids and res_users.browse(cr, uid, user_ids[0], context=context) or False\n+        domain = [('partner_id', '=', self.partner_id.id)]\n+        return self.env['res.users'].with_context(active_test=False).search(domain, limit=1) or False","path":"addons/portal/wizard/portal_wizard.py","position":228,"original_position":228,"commit_id":"2c557ad50773d8ec504b8e33b504c0c46b7a2a5f","original_commit_id":"2c557ad50773d8ec504b8e33b504c0c46b7a2a5f","user":{"login":"atp-odoo","id":7599410,"avatar_url":"https://avatars.githubusercontent.com/u/7599410?v=3","gravatar_id":"","url":"https://api.github.com/users/atp-odoo","html_url":"https://github.com/atp-odoo","followers_url":"https://api.github.com/users/atp-odoo/followers","following_url":"https://api.github.com/users/atp-odoo/following{/other_user}","gists_url":"https://api.github.com/users/atp-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/atp-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atp-odoo/subscriptions","organizations_url":"https://api.github.com/users/atp-odoo/orgs","repos_url":"https://api.github.com/users/atp-odoo/repos","events_url":"https://api.github.com/users/atp-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/atp-odoo/received_events","type":"User","site_admin":false},"body":"or False not required","created_at":"2015-03-26T13:36:57Z","updated_at":"2015-03-26T13:36:57Z","html_url":"https://github.com/odoo/odoo/pull/5902#discussion_r27212356","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/5902","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/27212356"},"html":{"href":"https://github.com/odoo/odoo/pull/5902#discussion_r27212356"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/5902"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/5902","id":31798227,"html_url":"https://github.com/odoo/odoo/pull/5902","diff_url":"https://github.com/odoo/odoo/pull/5902.diff","patch_url":"https://github.com/odoo/odoo/pull/5902.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/5902","number":5902,"state":"open","locked":false,"title":"[MIG]Portal: Migrate to new api","user":{"login":"atp-odoo","id":7599410,"avatar_url":"https://avatars.githubusercontent.com/u/7599410?v=3","gravatar_id":"","url":"https://api.github.com/users/atp-odoo","html_url":"https://github.com/atp-odoo","followers_url":"https://api.github.com/users/atp-odoo/followers","following_url":"https://api.github.com/users/atp-odoo/following{/other_user}","gists_url":"https://api.github.com/users/atp-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/atp-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atp-odoo/subscriptions","organizations_url":"https://api.github.com/users/atp-odoo/orgs","repos_url":"https://api.github.com/users/atp-odoo/repos","events_url":"https://api.github.com/users/atp-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/atp-odoo/received_events","type":"User","site_admin":false},"body":"Task: https://www.odoo.com/web#id=12003&view_type=form&model=res.partner\r\nPad: https://pad.odoo.com/p/r.q9wZCSb3Xk2xmg5n","created_at":"2015-03-24T05:23:43Z","updated_at":"2015-03-26T13:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22f8a5116536a89de153d33f0e3f906c0f46053f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/5902/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/5902/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/5902/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/2c557ad50773d8ec504b8e33b504c0c46b7a2a5f","head":{"label":"odoo-dev:master-migrate-new_api-portal-fka","ref":"master-migrate-new_api-portal-fka","sha":"2c557ad50773d8ec504b8e33b504c0c46b7a2a5f","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2015-03-17T10:53:55Z","pushed_at":"2015-03-26T13:36:00Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1090713,"stargazers_count":45,"watchers_count":45,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":10,"forks":18,"open_issues":10,"watchers":45,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"fc814515ac84599c24d45163820923fe1e21518c","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-03-26T13:29:25Z","pushed_at":"2015-03-26T13:35:54Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1125836,"stargazers_count":2330,"watchers_count":2330,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1798,"mirror_url":null,"open_issues_count":2124,"forks":1798,"open_issues":2124,"watchers":2330,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/5902"},"html":{"href":"https://github.com/odoo/odoo/pull/5902"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/5902"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/5902/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/5902/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/5902/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/2c557ad50773d8ec504b8e33b504c0c46b7a2a5f"}}}}