{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/1","id":30838521,"html_url":"https://github.com/holidayextras/plugin-jsonapi/pull/1","diff_url":"https://github.com/holidayextras/plugin-jsonapi/pull/1.diff","patch_url":"https://github.com/holidayextras/plugin-jsonapi/pull/1.patch","issue_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/1","number":1,"state":"closed","locked":false,"title":"Web4542 add make-up","user":{"login":"lukefrake","id":4060386,"avatar_url":"https://avatars.githubusercontent.com/u/4060386?v=3","gravatar_id":"","url":"https://api.github.com/users/lukefrake","html_url":"https://github.com/lukefrake","followers_url":"https://api.github.com/users/lukefrake/followers","following_url":"https://api.github.com/users/lukefrake/following{/other_user}","gists_url":"https://api.github.com/users/lukefrake/gists{/gist_id}","starred_url":"https://api.github.com/users/lukefrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukefrake/subscriptions","organizations_url":"https://api.github.com/users/lukefrake/orgs","repos_url":"https://api.github.com/users/lukefrake/repos","events_url":"https://api.github.com/users/lukefrake/events{/privacy}","received_events_url":"https://api.github.com/users/lukefrake/received_events","type":"User","site_admin":false},"body":"#### What are the links to relevant tickets?\r\nWEB-4542\r\n#### What does this PR do?\r\nAdd make-up\r\nMake pass hinting linting etc\r\n#### What unit tests does this PR have?\r\nN/A\r\n#### How should a developer review this?\r\nPull down & run tests / see travis run\r\n#### Any background context you want to provide?\r\nPart of something bigger\r\n#### Screenshots (if appropriate)\r\n---\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [x] I've checked there is appropriate unit test coverage.\r\n- [x] I've updated documentation with any changes to procedures.\r\n- [x] I've tested this cross browser for any visual changes.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I am ready for this to be code reviewed, merged and tested.\r\n\r\n#### Reviewer 1\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [x] I’ve witnessed the work behaving as expected.\r\n- [x] I’ve witnessed the tests running successfully.\r\n- [x] I’ve checked for appropriate test coverage.\r\n- [x] I’ve checked for coding anti-patterns.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I don’t believe this work introduces unnecessary technical debt.\r\n- [x] +1 from me!\r\n\r\n#### Reviewer 2\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [x] I’ve witnessed the work behaving as expected.\r\n- [x] I’ve witnessed the tests running successfully.\r\n- [x] I’ve checked for appropriate test coverage.\r\n- [x] I’ve checked for coding anti-patterns.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I don’t believe this work introduces unnecessary technical debt.\r\n- [x] +1 from me!","created_at":"2015-03-10T10:36:38Z","updated_at":"2015-03-10T15:52:26Z","closed_at":"2015-03-10T15:52:26Z","merged_at":"2015-03-10T15:52:26Z","merge_commit_sha":"105e8b76d55cb34174b127d16bc265262fa33f0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/1/commits","review_comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/1/comments","review_comment_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/1/comments","statuses_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/6985bb777b5ccc4cdb83a9f5d4656765c4780e3e","head":{"label":"holidayextras:web4542_addTravisSupport","ref":"web4542_addTravisSupport","sha":"6985bb777b5ccc4cdb83a9f5d4656765c4780e3e","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":31768896,"name":"plugin-jsonapi","full_name":"holidayextras/plugin-jsonapi","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/plugin-jsonapi","description":"A hapijs plugin for a jsonapi style output to all requests. ","fork":false,"url":"https://api.github.com/repos/holidayextras/plugin-jsonapi","forks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/forks","keys_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/teams","hooks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/events","assignees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/tags","blobs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/languages","stargazers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscription","commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/merges","archive_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/downloads","issues_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/releases{/id}","created_at":"2015-03-06T12:45:26Z","updated_at":"2015-03-09T10:10:41Z","pushed_at":"2015-03-10T15:52:26Z","git_url":"git://github.com/holidayextras/plugin-jsonapi.git","ssh_url":"git@github.com:holidayextras/plugin-jsonapi.git","clone_url":"https://github.com/holidayextras/plugin-jsonapi.git","svn_url":"https://github.com/holidayextras/plugin-jsonapi","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"holidayextras:master","ref":"master","sha":"0b88c1d079e49068082d27536346827fafd92551","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":31768896,"name":"plugin-jsonapi","full_name":"holidayextras/plugin-jsonapi","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/plugin-jsonapi","description":"A hapijs plugin for a jsonapi style output to all requests. ","fork":false,"url":"https://api.github.com/repos/holidayextras/plugin-jsonapi","forks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/forks","keys_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/teams","hooks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/events","assignees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/tags","blobs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/languages","stargazers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscription","commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/merges","archive_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/downloads","issues_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/releases{/id}","created_at":"2015-03-06T12:45:26Z","updated_at":"2015-03-09T10:10:41Z","pushed_at":"2015-03-10T15:52:26Z","git_url":"git://github.com/holidayextras/plugin-jsonapi.git","ssh_url":"git@github.com:holidayextras/plugin-jsonapi.git","clone_url":"https://github.com/holidayextras/plugin-jsonapi.git","svn_url":"https://github.com/holidayextras/plugin-jsonapi","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/1"},"html":{"href":"https://github.com/holidayextras/plugin-jsonapi/pull/1"},"issue":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/1"},"comments":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/6985bb777b5ccc4cdb83a9f5d4656765c4780e3e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lukefrake","id":4060386,"avatar_url":"https://avatars.githubusercontent.com/u/4060386?v=3","gravatar_id":"","url":"https://api.github.com/users/lukefrake","html_url":"https://github.com/lukefrake","followers_url":"https://api.github.com/users/lukefrake/followers","following_url":"https://api.github.com/users/lukefrake/following{/other_user}","gists_url":"https://api.github.com/users/lukefrake/gists{/gist_id}","starred_url":"https://api.github.com/users/lukefrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukefrake/subscriptions","organizations_url":"https://api.github.com/users/lukefrake/orgs","repos_url":"https://api.github.com/users/lukefrake/repos","events_url":"https://api.github.com/users/lukefrake/events{/privacy}","received_events_url":"https://api.github.com/users/lukefrake/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":11,"additions":234,"deletions":274,"changed_files":8}}