{"action":"created","issue":{"url":"https://api.github.com/repos/git/git-scm.com/issues/571","labels_url":"https://api.github.com/repos/git/git-scm.com/issues/571/labels{/name}","comments_url":"https://api.github.com/repos/git/git-scm.com/issues/571/comments","events_url":"https://api.github.com/repos/git/git-scm.com/issues/571/events","html_url":"https://github.com/git/git-scm.com/pull/571","id":101663852,"number":571,"title":"downloads: support 32-bit/64-bit windows links","user":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-08-18T14:05:26Z","updated_at":"2015-08-18T15:01:51Z","closed_at":"2015-08-18T14:44:54Z","pull_request":{"url":"https://api.github.com/repos/git/git-scm.com/pulls/571","html_url":"https://github.com/git/git-scm.com/pull/571","diff_url":"https://github.com/git/git-scm.com/pull/571.diff","patch_url":"https://github.com/git/git-scm.com/pull/571.patch"},"body":"With the switch to the *MSYS2* backend for the *Git for Windows* project\r\nthe opportunity arose to support both `32-bit` and `64-bit` builds. In\r\nadditon to those `32-bit` and `64-bit` builds *Git for Windows* now ships\r\nwith portable releases as well. So it makes sense to display all those\r\nlinks on the download page. Since this behavior differs from the `mac`\r\nplatform would be best to introduce a new download page for the `windows`\r\nplatform.\r\n\r\nThe naming convention for *Git for Windows* builds changed too, so the\r\n`rake downloads` task had to be adapted. It now parses the *Git for\r\nWindows* release file properly and also extracts the `bitness` and the\r\nportable information of the release file. That `bitness` and the portable\r\ninformation is then appended to the platform when storing the release\r\ninformation in the database.\r\n\r\nTo provide an automatic download for the latest *Git for Windows* release\r\nin the correct `bitness` parsing of the user agent in the download\r\ncontroller was added. The view was updated to show the current download\r\nand then list the other options as well.\r\n\r\nTo associate the latest Windows release (which might have 4 digits) to the\r\ncorresponding Git version, we look only at the first 3 digits (which match\r\nthe Git version). Thanks to the order in which the GitHub API delivers the\r\nreleases, this means that the last one wins, as it should be. Example: if\r\n2.5.0 was uploaded, and later 2.5.0.2 was uploaded, then 2.5.0.2 is added\r\nas a `Download` *later* than 2.5.0, and associated with the Git version\r\n2.5.0. So even if it might not be completely obvious from a quick glance,\r\nthe logic is sound.\r\n\r\n[jes: rebased to current upstream; accounted for 3-digit versions,\r\ncommented on the 4 -> 3 digits reduction to match up Git for Windows to\r\nGit versions]\r\n\r\nSigned-off-by: 마누엘 <nalla@hamal.uberspace.de>\r\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>"},"comment":{"url":"https://api.github.com/repos/git/git-scm.com/issues/comments/132240947","html_url":"https://github.com/git/git-scm.com/pull/571#issuecomment-132240947","issue_url":"https://api.github.com/repos/git/git-scm.com/issues/571","id":132240947,"user":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T15:01:51Z","updated_at":"2015-08-18T15:01:51Z","body":"![i-dont-usually-do-github-prs](https://cloud.githubusercontent.com/assets/127790/9333573/c86f699e-45ca-11e5-8926-004989a55c8f.jpg)\r\n"}}