{"action":"created","issue":{"url":"https://api.github.com/repos/Marzogh/SPIFlash/issues/8","labels_url":"https://api.github.com/repos/Marzogh/SPIFlash/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/Marzogh/SPIFlash/issues/8/comments","events_url":"https://api.github.com/repos/Marzogh/SPIFlash/issues/8/events","html_url":"https://github.com/Marzogh/SPIFlash/issues/8","id":103080274,"number":8,"title":"readByte does not work","user":{"login":"mtamassia","id":3932010,"avatar_url":"https://avatars.githubusercontent.com/u/3932010?v=3","gravatar_id":"","url":"https://api.github.com/users/mtamassia","html_url":"https://github.com/mtamassia","followers_url":"https://api.github.com/users/mtamassia/followers","following_url":"https://api.github.com/users/mtamassia/following{/other_user}","gists_url":"https://api.github.com/users/mtamassia/gists{/gist_id}","starred_url":"https://api.github.com/users/mtamassia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtamassia/subscriptions","organizations_url":"https://api.github.com/users/mtamassia/orgs","repos_url":"https://api.github.com/users/mtamassia/repos","events_url":"https://api.github.com/users/mtamassia/events{/privacy}","received_events_url":"https://api.github.com/users/mtamassia/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Marzogh/SPIFlash/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"Marzogh","id":7234422,"avatar_url":"https://avatars.githubusercontent.com/u/7234422?v=3","gravatar_id":"","url":"https://api.github.com/users/Marzogh","html_url":"https://github.com/Marzogh","followers_url":"https://api.github.com/users/Marzogh/followers","following_url":"https://api.github.com/users/Marzogh/following{/other_user}","gists_url":"https://api.github.com/users/Marzogh/gists{/gist_id}","starred_url":"https://api.github.com/users/Marzogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marzogh/subscriptions","organizations_url":"https://api.github.com/users/Marzogh/orgs","repos_url":"https://api.github.com/users/Marzogh/repos","events_url":"https://api.github.com/users/Marzogh/events{/privacy}","received_events_url":"https://api.github.com/users/Marzogh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Marzogh/SPIFlash/milestones/3","html_url":"https://github.com/Marzogh/SPIFlash/milestones/v1.2.2","labels_url":"https://api.github.com/repos/Marzogh/SPIFlash/milestones/3/labels","id":1272797,"number":3,"title":"v1.2.2","description":null,"creator":{"login":"Marzogh","id":7234422,"avatar_url":"https://avatars.githubusercontent.com/u/7234422?v=3","gravatar_id":"","url":"https://api.github.com/users/Marzogh","html_url":"https://github.com/Marzogh","followers_url":"https://api.github.com/users/Marzogh/followers","following_url":"https://api.github.com/users/Marzogh/following{/other_user}","gists_url":"https://api.github.com/users/Marzogh/gists{/gist_id}","starred_url":"https://api.github.com/users/Marzogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marzogh/subscriptions","organizations_url":"https://api.github.com/users/Marzogh/orgs","repos_url":"https://api.github.com/users/Marzogh/repos","events_url":"https://api.github.com/users/Marzogh/events{/privacy}","received_events_url":"https://api.github.com/users/Marzogh/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2015-08-26T05:22:54Z","updated_at":"2015-08-26T07:29:38Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-08-25T17:47:07Z","updated_at":"2015-08-26T10:23:46Z","closed_at":"2015-08-26T07:29:38Z","body":"The very first line of the readByte function should not have the braces and should return false.\r\n\r\nThe first line is the check for busy, out of range page/offset and should return false right after it.\r\n\r\nIf you compare the first two lines of the readByte and readBytes you will see the bug.\r\n\r\nAs it is today, the readByte functon only runs if the chip is busy or if you pass in an out of range page/offset."},"comment":{"url":"https://api.github.com/repos/Marzogh/SPIFlash/issues/comments/134935718","html_url":"https://github.com/Marzogh/SPIFlash/issues/8#issuecomment-134935718","issue_url":"https://api.github.com/repos/Marzogh/SPIFlash/issues/8","id":134935718,"user":{"login":"Marzogh","id":7234422,"avatar_url":"https://avatars.githubusercontent.com/u/7234422?v=3","gravatar_id":"","url":"https://api.github.com/users/Marzogh","html_url":"https://github.com/Marzogh","followers_url":"https://api.github.com/users/Marzogh/followers","following_url":"https://api.github.com/users/Marzogh/following{/other_user}","gists_url":"https://api.github.com/users/Marzogh/gists{/gist_id}","starred_url":"https://api.github.com/users/Marzogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marzogh/subscriptions","organizations_url":"https://api.github.com/users/Marzogh/orgs","repos_url":"https://api.github.com/users/Marzogh/repos","events_url":"https://api.github.com/users/Marzogh/events{/privacy}","received_events_url":"https://api.github.com/users/Marzogh/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T10:23:46Z","updated_at":"2015-08-26T10:23:46Z","body":"Thanks for that! Would you like to fork the 1.3.0w.i.p branch and add them and create a pull request? I'd be happy to have you on as a fellow contributor to the project and attribute the improvements you make to you. :)"}}