{"action":"created","issue":{"url":"https://api.github.com/repos/shared-secret/proteus/issues/9","labels_url":"https://api.github.com/repos/shared-secret/proteus/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/shared-secret/proteus/issues/9/comments","events_url":"https://api.github.com/repos/shared-secret/proteus/issues/9/events","html_url":"https://github.com/shared-secret/proteus/pull/9","id":118602422,"number":9,"title":"Unify Curve25519 key material","user":{"login":"limeburst","id":1113499,"avatar_url":"https://avatars.githubusercontent.com/u/1113499?v=3","gravatar_id":"","url":"https://api.github.com/users/limeburst","html_url":"https://github.com/limeburst","followers_url":"https://api.github.com/users/limeburst/followers","following_url":"https://api.github.com/users/limeburst/following{/other_user}","gists_url":"https://api.github.com/users/limeburst/gists{/gist_id}","starred_url":"https://api.github.com/users/limeburst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limeburst/subscriptions","organizations_url":"https://api.github.com/users/limeburst/orgs","repos_url":"https://api.github.com/users/limeburst/repos","events_url":"https://api.github.com/users/limeburst/events{/privacy}","received_events_url":"https://api.github.com/users/limeburst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-24T12:52:03Z","updated_at":"2015-11-25T02:49:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shared-secret/proteus/pulls/9","html_url":"https://github.com/shared-secret/proteus/pull/9","diff_url":"https://github.com/shared-secret/proteus/pull/9.diff","patch_url":"https://github.com/shared-secret/proteus/pull/9.patch"},"body":"Since we are using the same key material for signing and key exchange, unifying them makes sense.\r\n\r\nThis change introduces dependency to lumi-im/elliptic."},"comment":{"url":"https://api.github.com/repos/shared-secret/proteus/issues/comments/159471467","html_url":"https://github.com/shared-secret/proteus/pull/9#issuecomment-159471467","issue_url":"https://api.github.com/repos/shared-secret/proteus/issues/9","id":159471467,"user":{"login":"limeburst","id":1113499,"avatar_url":"https://avatars.githubusercontent.com/u/1113499?v=3","gravatar_id":"","url":"https://api.github.com/users/limeburst","html_url":"https://github.com/limeburst","followers_url":"https://api.github.com/users/limeburst/followers","following_url":"https://api.github.com/users/limeburst/following{/other_user}","gists_url":"https://api.github.com/users/limeburst/gists{/gist_id}","starred_url":"https://api.github.com/users/limeburst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limeburst/subscriptions","organizations_url":"https://api.github.com/users/limeburst/orgs","repos_url":"https://api.github.com/users/limeburst/repos","events_url":"https://api.github.com/users/limeburst/events{/privacy}","received_events_url":"https://api.github.com/users/limeburst/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T02:49:17Z","updated_at":"2015-11-25T02:49:17Z","body":"Thank you for reviewing my pull request!\r\n\r\nRegarding `SecretKey::sign` calling `rand_bytes` and costing a system call, I think this can be relieved by using secret-prefix SHA-512 as our PRF(conjectured to have no loss of security in the [Ed25519 paper](http://ed25519.cr.yp.to/ed25519-20110926.pdf)). This can be done inside elliptic.\r\n\r\nAlthough this change introduces another dependency, I did it in hopes that it would make proteus' codebase easier to comprehend, and reduce some possible source of confusion. I am actually planning to relicense elliptic to a more permissive license, or release it into the public domain."}}