{"action":"created","comment":{"url":"https://api.github.com/repos/quelpa/quelpa/pulls/comments/40344144","id":40344144,"diff_hunk":"@@ -263,6 +268,39 @@ and return NEW-STAMP-INFO, otherwise return OLD-STAMP-INFO.\"\n           new-stamp-info)\n       old-stamp-info)))\n \n+(defun quelpa-check-dir-hash (name config dir build-dir)\n+  \"Check if hash of DIR contents is different as in STAMP-FILE.\n+If it is different save the new hash and timestamp to STAMP-FILE\n+and return TIME-STAMP, otherwise return OLD-TIME-STAMP.\"\n+  (let* ((hashes)","path":"quelpa.el","position":20,"original_position":20,"commit_id":"746c7518f81b57c1de675360adc04b50dc231608","original_commit_id":"746c7518f81b57c1de675360adc04b50dc231608","user":{"login":"wasamasa","id":3588994,"avatar_url":"https://avatars.githubusercontent.com/u/3588994?v=3","gravatar_id":"","url":"https://api.github.com/users/wasamasa","html_url":"https://github.com/wasamasa","followers_url":"https://api.github.com/users/wasamasa/followers","following_url":"https://api.github.com/users/wasamasa/following{/other_user}","gists_url":"https://api.github.com/users/wasamasa/gists{/gist_id}","starred_url":"https://api.github.com/users/wasamasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasamasa/subscriptions","organizations_url":"https://api.github.com/users/wasamasa/orgs","repos_url":"https://api.github.com/users/wasamasa/repos","events_url":"https://api.github.com/users/wasamasa/events{/privacy}","received_events_url":"https://api.github.com/users/wasamasa/received_events","type":"User","site_admin":false},"body":"You can use an even shorter form for values bound to `nil`, `(let (foo bar baz) ...)`.  Just drop the parentheses around them.","created_at":"2015-09-24T17:04:42Z","updated_at":"2015-09-24T17:04:42Z","html_url":"https://github.com/quelpa/quelpa/pull/91#discussion_r40344144","pull_request_url":"https://api.github.com/repos/quelpa/quelpa/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/quelpa/quelpa/pulls/comments/40344144"},"html":{"href":"https://github.com/quelpa/quelpa/pull/91#discussion_r40344144"},"pull_request":{"href":"https://api.github.com/repos/quelpa/quelpa/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/quelpa/quelpa/pulls/91","id":45279362,"html_url":"https://github.com/quelpa/quelpa/pull/91","diff_url":"https://github.com/quelpa/quelpa/pull/91.diff","patch_url":"https://github.com/quelpa/quelpa/pull/91.patch","issue_url":"https://api.github.com/repos/quelpa/quelpa/issues/91","number":91,"state":"open","locked":false,"title":"[WIP] fetch local directory as a package for url fetcher","user":{"login":"vyp","id":3889405,"avatar_url":"https://avatars.githubusercontent.com/u/3889405?v=3","gravatar_id":"","url":"https://api.github.com/users/vyp","html_url":"https://github.com/vyp","followers_url":"https://api.github.com/users/vyp/followers","following_url":"https://api.github.com/users/vyp/following{/other_user}","gists_url":"https://api.github.com/users/vyp/gists{/gist_id}","starred_url":"https://api.github.com/users/vyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyp/subscriptions","organizations_url":"https://api.github.com/users/vyp/orgs","repos_url":"https://api.github.com/users/vyp/repos","events_url":"https://api.github.com/users/vyp/events{/privacy}","received_events_url":"https://api.github.com/users/vyp/received_events","type":"User","site_admin":false},"body":"Work in progress, obviously don't merge.\r\n\r\nSo a few disclaimers:\r\n\r\n- primarily opened for discussion, as someone new to emacs, lisp and elisp, I have no idea what I'm doing, so I don't really expect this to work.\r\n\r\n- if eventually good enough to merge, the commits will all be squashed into one with an appropriate commit message. these commit messages are just temporary.\r\n\r\nSo regarding the hashes. I'm thinking just have a hash of the concatenated hashes of all the relevant files (using `quelpa-check-file-hash`)? Where \"relevant files\" are by default all the .el files (recursively)? (Or otherwise can be changed with the `:files` in the recipe.)\r\n\r\nI guess the hardest part is getting the version number to prepend to the hash? Possible to just check each relevant file for a `;; Version:` header, and settle on the first one found? And if none found, use the current local system date and time like package-build (melpa) does? But then if the datetime is used, it will *always* result in a new package being built, even if no change has been made, correct? So that would be a problem.\r\n\r\ncc @steckerhalter @wasamasa","created_at":"2015-09-17T11:28:27Z","updated_at":"2015-09-24T17:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3799aeaf4e53c0131901f83ec012c56d40028c76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quelpa/quelpa/pulls/91/commits","review_comments_url":"https://api.github.com/repos/quelpa/quelpa/pulls/91/comments","review_comment_url":"https://api.github.com/repos/quelpa/quelpa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quelpa/quelpa/issues/91/comments","statuses_url":"https://api.github.com/repos/quelpa/quelpa/statuses/746c7518f81b57c1de675360adc04b50dc231608","head":{"label":"vyp:local-dir-for-url-fetcher","ref":"local-dir-for-url-fetcher","sha":"746c7518f81b57c1de675360adc04b50dc231608","user":{"login":"vyp","id":3889405,"avatar_url":"https://avatars.githubusercontent.com/u/3889405?v=3","gravatar_id":"","url":"https://api.github.com/users/vyp","html_url":"https://github.com/vyp","followers_url":"https://api.github.com/users/vyp/followers","following_url":"https://api.github.com/users/vyp/following{/other_user}","gists_url":"https://api.github.com/users/vyp/gists{/gist_id}","starred_url":"https://api.github.com/users/vyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyp/subscriptions","organizations_url":"https://api.github.com/users/vyp/orgs","repos_url":"https://api.github.com/users/vyp/repos","events_url":"https://api.github.com/users/vyp/events{/privacy}","received_events_url":"https://api.github.com/users/vyp/received_events","type":"User","site_admin":false},"repo":{"id":42651137,"name":"quelpa","full_name":"vyp/quelpa","owner":{"login":"vyp","id":3889405,"avatar_url":"https://avatars.githubusercontent.com/u/3889405?v=3","gravatar_id":"","url":"https://api.github.com/users/vyp","html_url":"https://github.com/vyp","followers_url":"https://api.github.com/users/vyp/followers","following_url":"https://api.github.com/users/vyp/following{/other_user}","gists_url":"https://api.github.com/users/vyp/gists{/gist_id}","starred_url":"https://api.github.com/users/vyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyp/subscriptions","organizations_url":"https://api.github.com/users/vyp/orgs","repos_url":"https://api.github.com/users/vyp/repos","events_url":"https://api.github.com/users/vyp/events{/privacy}","received_events_url":"https://api.github.com/users/vyp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vyp/quelpa","description":"Build and install your Emacs Lisp packages on-the-fly directly from source","fork":true,"url":"https://api.github.com/repos/vyp/quelpa","forks_url":"https://api.github.com/repos/vyp/quelpa/forks","keys_url":"https://api.github.com/repos/vyp/quelpa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vyp/quelpa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vyp/quelpa/teams","hooks_url":"https://api.github.com/repos/vyp/quelpa/hooks","issue_events_url":"https://api.github.com/repos/vyp/quelpa/issues/events{/number}","events_url":"https://api.github.com/repos/vyp/quelpa/events","assignees_url":"https://api.github.com/repos/vyp/quelpa/assignees{/user}","branches_url":"https://api.github.com/repos/vyp/quelpa/branches{/branch}","tags_url":"https://api.github.com/repos/vyp/quelpa/tags","blobs_url":"https://api.github.com/repos/vyp/quelpa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vyp/quelpa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vyp/quelpa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vyp/quelpa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vyp/quelpa/statuses/{sha}","languages_url":"https://api.github.com/repos/vyp/quelpa/languages","stargazers_url":"https://api.github.com/repos/vyp/quelpa/stargazers","contributors_url":"https://api.github.com/repos/vyp/quelpa/contributors","subscribers_url":"https://api.github.com/repos/vyp/quelpa/subscribers","subscription_url":"https://api.github.com/repos/vyp/quelpa/subscription","commits_url":"https://api.github.com/repos/vyp/quelpa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vyp/quelpa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vyp/quelpa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vyp/quelpa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vyp/quelpa/contents/{+path}","compare_url":"https://api.github.com/repos/vyp/quelpa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vyp/quelpa/merges","archive_url":"https://api.github.com/repos/vyp/quelpa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vyp/quelpa/downloads","issues_url":"https://api.github.com/repos/vyp/quelpa/issues{/number}","pulls_url":"https://api.github.com/repos/vyp/quelpa/pulls{/number}","milestones_url":"https://api.github.com/repos/vyp/quelpa/milestones{/number}","notifications_url":"https://api.github.com/repos/vyp/quelpa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vyp/quelpa/labels{/name}","releases_url":"https://api.github.com/repos/vyp/quelpa/releases{/id}","created_at":"2015-09-17T10:57:13Z","updated_at":"2015-09-17T10:57:13Z","pushed_at":"2015-09-24T08:27:33Z","git_url":"git://github.com/vyp/quelpa.git","ssh_url":"git@github.com:vyp/quelpa.git","clone_url":"https://github.com/vyp/quelpa.git","svn_url":"https://github.com/vyp/quelpa","homepage":"","size":288,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quelpa:master","ref":"master","sha":"8d938d995e83c1b3bcdce376a7f8dd50dbea5fe2","user":{"login":"quelpa","id":6677657,"avatar_url":"https://avatars.githubusercontent.com/u/6677657?v=3","gravatar_id":"","url":"https://api.github.com/users/quelpa","html_url":"https://github.com/quelpa","followers_url":"https://api.github.com/users/quelpa/followers","following_url":"https://api.github.com/users/quelpa/following{/other_user}","gists_url":"https://api.github.com/users/quelpa/gists{/gist_id}","starred_url":"https://api.github.com/users/quelpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quelpa/subscriptions","organizations_url":"https://api.github.com/users/quelpa/orgs","repos_url":"https://api.github.com/users/quelpa/repos","events_url":"https://api.github.com/users/quelpa/events{/privacy}","received_events_url":"https://api.github.com/users/quelpa/received_events","type":"Organization","site_admin":false},"repo":{"id":16803250,"name":"quelpa","full_name":"quelpa/quelpa","owner":{"login":"quelpa","id":6677657,"avatar_url":"https://avatars.githubusercontent.com/u/6677657?v=3","gravatar_id":"","url":"https://api.github.com/users/quelpa","html_url":"https://github.com/quelpa","followers_url":"https://api.github.com/users/quelpa/followers","following_url":"https://api.github.com/users/quelpa/following{/other_user}","gists_url":"https://api.github.com/users/quelpa/gists{/gist_id}","starred_url":"https://api.github.com/users/quelpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quelpa/subscriptions","organizations_url":"https://api.github.com/users/quelpa/orgs","repos_url":"https://api.github.com/users/quelpa/repos","events_url":"https://api.github.com/users/quelpa/events{/privacy}","received_events_url":"https://api.github.com/users/quelpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quelpa/quelpa","description":"Build and install your Emacs Lisp packages on-the-fly directly from source","fork":false,"url":"https://api.github.com/repos/quelpa/quelpa","forks_url":"https://api.github.com/repos/quelpa/quelpa/forks","keys_url":"https://api.github.com/repos/quelpa/quelpa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quelpa/quelpa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quelpa/quelpa/teams","hooks_url":"https://api.github.com/repos/quelpa/quelpa/hooks","issue_events_url":"https://api.github.com/repos/quelpa/quelpa/issues/events{/number}","events_url":"https://api.github.com/repos/quelpa/quelpa/events","assignees_url":"https://api.github.com/repos/quelpa/quelpa/assignees{/user}","branches_url":"https://api.github.com/repos/quelpa/quelpa/branches{/branch}","tags_url":"https://api.github.com/repos/quelpa/quelpa/tags","blobs_url":"https://api.github.com/repos/quelpa/quelpa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quelpa/quelpa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quelpa/quelpa/git/refs{/sha}","trees_url":"https://api.github.com/repos/quelpa/quelpa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quelpa/quelpa/statuses/{sha}","languages_url":"https://api.github.com/repos/quelpa/quelpa/languages","stargazers_url":"https://api.github.com/repos/quelpa/quelpa/stargazers","contributors_url":"https://api.github.com/repos/quelpa/quelpa/contributors","subscribers_url":"https://api.github.com/repos/quelpa/quelpa/subscribers","subscription_url":"https://api.github.com/repos/quelpa/quelpa/subscription","commits_url":"https://api.github.com/repos/quelpa/quelpa/commits{/sha}","git_commits_url":"https://api.github.com/repos/quelpa/quelpa/git/commits{/sha}","comments_url":"https://api.github.com/repos/quelpa/quelpa/comments{/number}","issue_comment_url":"https://api.github.com/repos/quelpa/quelpa/issues/comments{/number}","contents_url":"https://api.github.com/repos/quelpa/quelpa/contents/{+path}","compare_url":"https://api.github.com/repos/quelpa/quelpa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quelpa/quelpa/merges","archive_url":"https://api.github.com/repos/quelpa/quelpa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quelpa/quelpa/downloads","issues_url":"https://api.github.com/repos/quelpa/quelpa/issues{/number}","pulls_url":"https://api.github.com/repos/quelpa/quelpa/pulls{/number}","milestones_url":"https://api.github.com/repos/quelpa/quelpa/milestones{/number}","notifications_url":"https://api.github.com/repos/quelpa/quelpa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quelpa/quelpa/labels{/name}","releases_url":"https://api.github.com/repos/quelpa/quelpa/releases{/id}","created_at":"2014-02-13T13:13:05Z","updated_at":"2015-09-23T16:27:03Z","pushed_at":"2015-09-24T08:27:33Z","git_url":"git://github.com/quelpa/quelpa.git","ssh_url":"git@github.com:quelpa/quelpa.git","clone_url":"https://github.com/quelpa/quelpa.git","svn_url":"https://github.com/quelpa/quelpa","homepage":"","size":1072,"stargazers_count":132,"watchers_count":132,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quelpa/quelpa/pulls/91"},"html":{"href":"https://github.com/quelpa/quelpa/pull/91"},"issue":{"href":"https://api.github.com/repos/quelpa/quelpa/issues/91"},"comments":{"href":"https://api.github.com/repos/quelpa/quelpa/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/quelpa/quelpa/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/quelpa/quelpa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quelpa/quelpa/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/quelpa/quelpa/statuses/746c7518f81b57c1de675360adc04b50dc231608"}}}}