{"action":"created","comment":{"url":"https://api.github.com/repos/LearnBoost/mongoose/pulls/comments/23716098","id":23716098,"diff_hunk":"@@ -1258,6 +1258,29 @@ Document.prototype.$__registerHooks = function () {\n \n   DocumentArray || (DocumentArray = require('./types/documentarray'));\n \n+  function emitErrorOnModel(err) {","path":"lib/document.js","position":28,"original_position":28,"commit_id":"3af088682c49ef8b6af7aef21f37bda7c7ad821a","original_commit_id":"3af088682c49ef8b6af7aef21f37bda7c7ad821a","user":{"login":"vkarpov15","id":1620265,"avatar_url":"https://avatars.githubusercontent.com/u/1620265?v=3","gravatar_id":"","url":"https://api.github.com/users/vkarpov15","html_url":"https://github.com/vkarpov15","followers_url":"https://api.github.com/users/vkarpov15/followers","following_url":"https://api.github.com/users/vkarpov15/following{/other_user}","gists_url":"https://api.github.com/users/vkarpov15/gists{/gist_id}","starred_url":"https://api.github.com/users/vkarpov15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkarpov15/subscriptions","organizations_url":"https://api.github.com/users/vkarpov15/orgs","repos_url":"https://api.github.com/users/vkarpov15/repos","events_url":"https://api.github.com/users/vkarpov15/events{/privacy}","received_events_url":"https://api.github.com/users/vkarpov15/received_events","type":"User","site_admin":false},"body":"use `var emitErrorOnModel = function(err)` instead","created_at":"2015-01-28T19:40:34Z","updated_at":"2015-01-28T19:40:34Z","html_url":"https://github.com/LearnBoost/mongoose/pull/2625#discussion_r23716098","pull_request_url":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625","_links":{"self":{"href":"https://api.github.com/repos/LearnBoost/mongoose/pulls/comments/23716098"},"html":{"href":"https://github.com/LearnBoost/mongoose/pull/2625#discussion_r23716098"},"pull_request":{"href":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625"}}},"pull_request":{"url":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625","id":28145403,"html_url":"https://github.com/LearnBoost/mongoose/pull/2625","diff_url":"https://github.com/LearnBoost/mongoose/pull/2625.diff","patch_url":"https://github.com/LearnBoost/mongoose/pull/2625.patch","issue_url":"https://api.github.com/repos/LearnBoost/mongoose/issues/2625","number":2625,"state":"open","locked":false,"title":"dont run validators more than once on nested subdocs","user":{"login":"ashaffer","id":1871136,"avatar_url":"https://avatars.githubusercontent.com/u/1871136?v=3","gravatar_id":"","url":"https://api.github.com/users/ashaffer","html_url":"https://github.com/ashaffer","followers_url":"https://api.github.com/users/ashaffer/followers","following_url":"https://api.github.com/users/ashaffer/following{/other_user}","gists_url":"https://api.github.com/users/ashaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashaffer/subscriptions","organizations_url":"https://api.github.com/users/ashaffer/orgs","repos_url":"https://api.github.com/users/ashaffer/repos","events_url":"https://api.github.com/users/ashaffer/events{/privacy}","received_events_url":"https://api.github.com/users/ashaffer/received_events","type":"User","site_admin":false},"body":"Fix for #2617.  I had to change the 'nested subdocuments' test a little bit, because it was asserting that mongoose not return all of the errors that were actually wrong with the document, which didn't seem like the right behavior to me, but it is possibly a breaking change for code that depends on that behavior.  Not sure if it was actually intended to work that way though.","created_at":"2015-01-27T21:21:06Z","updated_at":"2015-01-28T19:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66efeeabab0d01efc89322fd79422f6c582b7bad","assignee":null,"milestone":{"url":"https://api.github.com/repos/LearnBoost/mongoose/milestones/24","labels_url":"https://api.github.com/repos/LearnBoost/mongoose/milestones/24/labels","id":949979,"number":24,"title":"3.8.23","description":"","creator":{"login":"vkarpov15","id":1620265,"avatar_url":"https://avatars.githubusercontent.com/u/1620265?v=3","gravatar_id":"","url":"https://api.github.com/users/vkarpov15","html_url":"https://github.com/vkarpov15","followers_url":"https://api.github.com/users/vkarpov15/followers","following_url":"https://api.github.com/users/vkarpov15/following{/other_user}","gists_url":"https://api.github.com/users/vkarpov15/gists{/gist_id}","starred_url":"https://api.github.com/users/vkarpov15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkarpov15/subscriptions","organizations_url":"https://api.github.com/users/vkarpov15/orgs","repos_url":"https://api.github.com/users/vkarpov15/repos","events_url":"https://api.github.com/users/vkarpov15/events{/privacy}","received_events_url":"https://api.github.com/users/vkarpov15/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":0,"state":"open","created_at":"2015-01-24T23:14:27Z","updated_at":"2015-01-28T19:34:07Z","due_on":"2015-02-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625/commits","review_comments_url":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625/comments","review_comment_url":"https://api.github.com/repos/LearnBoost/mongoose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LearnBoost/mongoose/issues/2625/comments","statuses_url":"https://api.github.com/repos/LearnBoost/mongoose/statuses/3af088682c49ef8b6af7aef21f37bda7c7ad821a","head":{"label":"ashaffer:nested-subdoc-patch","ref":"nested-subdoc-patch","sha":"3af088682c49ef8b6af7aef21f37bda7c7ad821a","user":{"login":"ashaffer","id":1871136,"avatar_url":"https://avatars.githubusercontent.com/u/1871136?v=3","gravatar_id":"","url":"https://api.github.com/users/ashaffer","html_url":"https://github.com/ashaffer","followers_url":"https://api.github.com/users/ashaffer/followers","following_url":"https://api.github.com/users/ashaffer/following{/other_user}","gists_url":"https://api.github.com/users/ashaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashaffer/subscriptions","organizations_url":"https://api.github.com/users/ashaffer/orgs","repos_url":"https://api.github.com/users/ashaffer/repos","events_url":"https://api.github.com/users/ashaffer/events{/privacy}","received_events_url":"https://api.github.com/users/ashaffer/received_events","type":"User","site_admin":false},"repo":{"id":29931471,"name":"mongoose","full_name":"ashaffer/mongoose","owner":{"login":"ashaffer","id":1871136,"avatar_url":"https://avatars.githubusercontent.com/u/1871136?v=3","gravatar_id":"","url":"https://api.github.com/users/ashaffer","html_url":"https://github.com/ashaffer","followers_url":"https://api.github.com/users/ashaffer/followers","following_url":"https://api.github.com/users/ashaffer/following{/other_user}","gists_url":"https://api.github.com/users/ashaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashaffer/subscriptions","organizations_url":"https://api.github.com/users/ashaffer/orgs","repos_url":"https://api.github.com/users/ashaffer/repos","events_url":"https://api.github.com/users/ashaffer/events{/privacy}","received_events_url":"https://api.github.com/users/ashaffer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashaffer/mongoose","description":"MongoDB object modeling designed to work in an asynchronous environment.","fork":true,"url":"https://api.github.com/repos/ashaffer/mongoose","forks_url":"https://api.github.com/repos/ashaffer/mongoose/forks","keys_url":"https://api.github.com/repos/ashaffer/mongoose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashaffer/mongoose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashaffer/mongoose/teams","hooks_url":"https://api.github.com/repos/ashaffer/mongoose/hooks","issue_events_url":"https://api.github.com/repos/ashaffer/mongoose/issues/events{/number}","events_url":"https://api.github.com/repos/ashaffer/mongoose/events","assignees_url":"https://api.github.com/repos/ashaffer/mongoose/assignees{/user}","branches_url":"https://api.github.com/repos/ashaffer/mongoose/branches{/branch}","tags_url":"https://api.github.com/repos/ashaffer/mongoose/tags","blobs_url":"https://api.github.com/repos/ashaffer/mongoose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashaffer/mongoose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashaffer/mongoose/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashaffer/mongoose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashaffer/mongoose/statuses/{sha}","languages_url":"https://api.github.com/repos/ashaffer/mongoose/languages","stargazers_url":"https://api.github.com/repos/ashaffer/mongoose/stargazers","contributors_url":"https://api.github.com/repos/ashaffer/mongoose/contributors","subscribers_url":"https://api.github.com/repos/ashaffer/mongoose/subscribers","subscription_url":"https://api.github.com/repos/ashaffer/mongoose/subscription","commits_url":"https://api.github.com/repos/ashaffer/mongoose/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashaffer/mongoose/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashaffer/mongoose/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashaffer/mongoose/issues/comments/{number}","contents_url":"https://api.github.com/repos/ashaffer/mongoose/contents/{+path}","compare_url":"https://api.github.com/repos/ashaffer/mongoose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashaffer/mongoose/merges","archive_url":"https://api.github.com/repos/ashaffer/mongoose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashaffer/mongoose/downloads","issues_url":"https://api.github.com/repos/ashaffer/mongoose/issues{/number}","pulls_url":"https://api.github.com/repos/ashaffer/mongoose/pulls{/number}","milestones_url":"https://api.github.com/repos/ashaffer/mongoose/milestones{/number}","notifications_url":"https://api.github.com/repos/ashaffer/mongoose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashaffer/mongoose/labels{/name}","releases_url":"https://api.github.com/repos/ashaffer/mongoose/releases{/id}","created_at":"2015-01-27T19:42:52Z","updated_at":"2015-01-27T19:42:57Z","pushed_at":"2015-01-27T22:22:42Z","git_url":"git://github.com/ashaffer/mongoose.git","ssh_url":"git@github.com:ashaffer/mongoose.git","clone_url":"https://github.com/ashaffer/mongoose.git","svn_url":"https://github.com/ashaffer/mongoose","homepage":"http://mongoosejs.com","size":34464,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LearnBoost:3.8.x","ref":"3.8.x","sha":"066fc6ad8e0ad1edbe47559532fc5f528230d0fe","user":{"login":"LearnBoost","id":204174,"avatar_url":"https://avatars.githubusercontent.com/u/204174?v=3","gravatar_id":"","url":"https://api.github.com/users/LearnBoost","html_url":"https://github.com/LearnBoost","followers_url":"https://api.github.com/users/LearnBoost/followers","following_url":"https://api.github.com/users/LearnBoost/following{/other_user}","gists_url":"https://api.github.com/users/LearnBoost/gists{/gist_id}","starred_url":"https://api.github.com/users/LearnBoost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LearnBoost/subscriptions","organizations_url":"https://api.github.com/users/LearnBoost/orgs","repos_url":"https://api.github.com/users/LearnBoost/repos","events_url":"https://api.github.com/users/LearnBoost/events{/privacy}","received_events_url":"https://api.github.com/users/LearnBoost/received_events","type":"Organization","site_admin":false},"repo":{"id":597879,"name":"mongoose","full_name":"LearnBoost/mongoose","owner":{"login":"LearnBoost","id":204174,"avatar_url":"https://avatars.githubusercontent.com/u/204174?v=3","gravatar_id":"","url":"https://api.github.com/users/LearnBoost","html_url":"https://github.com/LearnBoost","followers_url":"https://api.github.com/users/LearnBoost/followers","following_url":"https://api.github.com/users/LearnBoost/following{/other_user}","gists_url":"https://api.github.com/users/LearnBoost/gists{/gist_id}","starred_url":"https://api.github.com/users/LearnBoost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LearnBoost/subscriptions","organizations_url":"https://api.github.com/users/LearnBoost/orgs","repos_url":"https://api.github.com/users/LearnBoost/repos","events_url":"https://api.github.com/users/LearnBoost/events{/privacy}","received_events_url":"https://api.github.com/users/LearnBoost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LearnBoost/mongoose","description":"MongoDB object modeling designed to work in an asynchronous environment.","fork":false,"url":"https://api.github.com/repos/LearnBoost/mongoose","forks_url":"https://api.github.com/repos/LearnBoost/mongoose/forks","keys_url":"https://api.github.com/repos/LearnBoost/mongoose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LearnBoost/mongoose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LearnBoost/mongoose/teams","hooks_url":"https://api.github.com/repos/LearnBoost/mongoose/hooks","issue_events_url":"https://api.github.com/repos/LearnBoost/mongoose/issues/events{/number}","events_url":"https://api.github.com/repos/LearnBoost/mongoose/events","assignees_url":"https://api.github.com/repos/LearnBoost/mongoose/assignees{/user}","branches_url":"https://api.github.com/repos/LearnBoost/mongoose/branches{/branch}","tags_url":"https://api.github.com/repos/LearnBoost/mongoose/tags","blobs_url":"https://api.github.com/repos/LearnBoost/mongoose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LearnBoost/mongoose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LearnBoost/mongoose/git/refs{/sha}","trees_url":"https://api.github.com/repos/LearnBoost/mongoose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LearnBoost/mongoose/statuses/{sha}","languages_url":"https://api.github.com/repos/LearnBoost/mongoose/languages","stargazers_url":"https://api.github.com/repos/LearnBoost/mongoose/stargazers","contributors_url":"https://api.github.com/repos/LearnBoost/mongoose/contributors","subscribers_url":"https://api.github.com/repos/LearnBoost/mongoose/subscribers","subscription_url":"https://api.github.com/repos/LearnBoost/mongoose/subscription","commits_url":"https://api.github.com/repos/LearnBoost/mongoose/commits{/sha}","git_commits_url":"https://api.github.com/repos/LearnBoost/mongoose/git/commits{/sha}","comments_url":"https://api.github.com/repos/LearnBoost/mongoose/comments{/number}","issue_comment_url":"https://api.github.com/repos/LearnBoost/mongoose/issues/comments/{number}","contents_url":"https://api.github.com/repos/LearnBoost/mongoose/contents/{+path}","compare_url":"https://api.github.com/repos/LearnBoost/mongoose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LearnBoost/mongoose/merges","archive_url":"https://api.github.com/repos/LearnBoost/mongoose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LearnBoost/mongoose/downloads","issues_url":"https://api.github.com/repos/LearnBoost/mongoose/issues{/number}","pulls_url":"https://api.github.com/repos/LearnBoost/mongoose/pulls{/number}","milestones_url":"https://api.github.com/repos/LearnBoost/mongoose/milestones{/number}","notifications_url":"https://api.github.com/repos/LearnBoost/mongoose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LearnBoost/mongoose/labels{/name}","releases_url":"https://api.github.com/repos/LearnBoost/mongoose/releases{/id}","created_at":"2010-04-06T21:39:05Z","updated_at":"2015-01-28T18:09:17Z","pushed_at":"2015-01-27T22:34:39Z","git_url":"git://github.com/LearnBoost/mongoose.git","ssh_url":"git@github.com:LearnBoost/mongoose.git","clone_url":"https://github.com/LearnBoost/mongoose.git","svn_url":"https://github.com/LearnBoost/mongoose","homepage":"http://mongoosejs.com","size":34464,"stargazers_count":6163,"watchers_count":6163,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":905,"mirror_url":null,"open_issues_count":426,"forks":905,"open_issues":426,"watchers":6163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625"},"html":{"href":"https://github.com/LearnBoost/mongoose/pull/2625"},"issue":{"href":"https://api.github.com/repos/LearnBoost/mongoose/issues/2625"},"comments":{"href":"https://api.github.com/repos/LearnBoost/mongoose/issues/2625/comments"},"review_comments":{"href":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625/comments"},"review_comment":{"href":"https://api.github.com/repos/LearnBoost/mongoose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LearnBoost/mongoose/pulls/2625/commits"},"statuses":{"href":"https://api.github.com/repos/LearnBoost/mongoose/statuses/3af088682c49ef8b6af7aef21f37bda7c7ad821a"}}}}