{"action":"created","issue":{"url":"https://api.github.com/repos/Crunch-io/pycrunch/issues/6","labels_url":"https://api.github.com/repos/Crunch-io/pycrunch/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/Crunch-io/pycrunch/issues/6/comments","events_url":"https://api.github.com/repos/Crunch-io/pycrunch/issues/6/events","html_url":"https://github.com/Crunch-io/pycrunch/pull/6","id":63848275,"number":6,"title":"None as no data always","user":{"login":"jaraco","id":308610,"avatar_url":"https://avatars.githubusercontent.com/u/308610?v=3","gravatar_id":"","url":"https://api.github.com/users/jaraco","html_url":"https://github.com/jaraco","followers_url":"https://api.github.com/users/jaraco/followers","following_url":"https://api.github.com/users/jaraco/following{/other_user}","gists_url":"https://api.github.com/users/jaraco/gists{/gist_id}","starred_url":"https://api.github.com/users/jaraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaraco/subscriptions","organizations_url":"https://api.github.com/users/jaraco/orgs","repos_url":"https://api.github.com/users/jaraco/repos","events_url":"https://api.github.com/users/jaraco/events{/privacy}","received_events_url":"https://api.github.com/users/jaraco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-23T22:25:43Z","updated_at":"2015-03-24T23:46:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Crunch-io/pycrunch/pulls/6","html_url":"https://github.com/Crunch-io/pycrunch/pull/6","diff_url":"https://github.com/Crunch-io/pycrunch/pull/6.diff","patch_url":"https://github.com/Crunch-io/pycrunch/pull/6.patch"},"body":"May I suggest removing the parameter from rows_as_csv_file? In my proposed implementation, I had separated the behavior that allowed None to be rendered as the empty string only to keep encapsulated the Crunch-specific behavior from the incremental writing behavior. Since that encapsulation had unacceptable performance degradation and because the current implementation doesn't keep that behavior separate, the usage that generates Crunch-incompatible CSV isn't of any value to us, so I recommend dropping it for simplicity."},"comment":{"url":"https://api.github.com/repos/Crunch-io/pycrunch/issues/comments/85742194","html_url":"https://github.com/Crunch-io/pycrunch/pull/6#issuecomment-85742194","issue_url":"https://api.github.com/repos/Crunch-io/pycrunch/issues/6","id":85742194,"user":{"login":"aminusfu","id":1322265,"avatar_url":"https://avatars.githubusercontent.com/u/1322265?v=3","gravatar_id":"","url":"https://api.github.com/users/aminusfu","html_url":"https://github.com/aminusfu","followers_url":"https://api.github.com/users/aminusfu/followers","following_url":"https://api.github.com/users/aminusfu/following{/other_user}","gists_url":"https://api.github.com/users/aminusfu/gists{/gist_id}","starred_url":"https://api.github.com/users/aminusfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aminusfu/subscriptions","organizations_url":"https://api.github.com/users/aminusfu/orgs","repos_url":"https://api.github.com/users/aminusfu/repos","events_url":"https://api.github.com/users/aminusfu/events{/privacy}","received_events_url":"https://api.github.com/users/aminusfu/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T23:46:18Z","updated_at":"2015-03-24T23:46:18Z","body":"I added that arg so that, if you knew you weren't sending any None values ever, you could get a speed boost. Is it harmful if the default is True?"}}