{"action":"closed","number":5941,"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/5941","id":27928443,"html_url":"https://github.com/spree/spree/pull/5941","diff_url":"https://github.com/spree/spree/pull/5941.diff","patch_url":"https://github.com/spree/spree/pull/5941.patch","issue_url":"https://api.github.com/repos/spree/spree/issues/5941","number":5941,"state":"closed","locked":false,"title":"Remove OrderPopulator class","user":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"body":"Help consolidate order update logic by removing an extraneous service object.\r\n\r\nNearly all the logic in OrderPopulator has been moved to OrderContents over time\r\nand there isn't much left that OrderPopulator does except to introduce extra\r\nindirection for the one frontend controller endpoint that uses it.\r\n\r\nThe \"options\" hash has also now been added to OrderContents which helps provide\r\nsome of the customization that OrderPopulator could theoretically have been used\r\nfor.","created_at":"2015-01-23T14:50:13Z","updated_at":"2015-01-23T16:33:47Z","closed_at":"2015-01-23T16:33:47Z","merged_at":null,"merge_commit_sha":"2679a8241742ae4574b235ff8055818f8a874ac7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spree/spree/pulls/5941/commits","review_comments_url":"https://api.github.com/repos/spree/spree/pulls/5941/comments","review_comment_url":"https://api.github.com/repos/spree/spree/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spree/spree/issues/5941/comments","statuses_url":"https://api.github.com/repos/spree/spree/statuses/0a57049690a6db7e60739254225bf3ad956daa97","head":{"label":"jordan-brough:remove-order-populator","ref":"remove-order-populator","sha":"0a57049690a6db7e60739254225bf3ad956daa97","user":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"repo":{"id":18685104,"name":"spree","full_name":"jordan-brough/spree","owner":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordan-brough/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/jordan-brough/spree","forks_url":"https://api.github.com/repos/jordan-brough/spree/forks","keys_url":"https://api.github.com/repos/jordan-brough/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordan-brough/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordan-brough/spree/teams","hooks_url":"https://api.github.com/repos/jordan-brough/spree/hooks","issue_events_url":"https://api.github.com/repos/jordan-brough/spree/issues/events{/number}","events_url":"https://api.github.com/repos/jordan-brough/spree/events","assignees_url":"https://api.github.com/repos/jordan-brough/spree/assignees{/user}","branches_url":"https://api.github.com/repos/jordan-brough/spree/branches{/branch}","tags_url":"https://api.github.com/repos/jordan-brough/spree/tags","blobs_url":"https://api.github.com/repos/jordan-brough/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordan-brough/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordan-brough/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordan-brough/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordan-brough/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/jordan-brough/spree/languages","stargazers_url":"https://api.github.com/repos/jordan-brough/spree/stargazers","contributors_url":"https://api.github.com/repos/jordan-brough/spree/contributors","subscribers_url":"https://api.github.com/repos/jordan-brough/spree/subscribers","subscription_url":"https://api.github.com/repos/jordan-brough/spree/subscription","commits_url":"https://api.github.com/repos/jordan-brough/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordan-brough/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordan-brough/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordan-brough/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/jordan-brough/spree/contents/{+path}","compare_url":"https://api.github.com/repos/jordan-brough/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordan-brough/spree/merges","archive_url":"https://api.github.com/repos/jordan-brough/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordan-brough/spree/downloads","issues_url":"https://api.github.com/repos/jordan-brough/spree/issues{/number}","pulls_url":"https://api.github.com/repos/jordan-brough/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/jordan-brough/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/jordan-brough/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordan-brough/spree/labels{/name}","releases_url":"https://api.github.com/repos/jordan-brough/spree/releases{/id}","created_at":"2014-04-11T18:53:35Z","updated_at":"2014-06-18T02:19:13Z","pushed_at":"2015-01-23T14:55:25Z","git_url":"git://github.com/jordan-brough/spree.git","ssh_url":"git@github.com:jordan-brough/spree.git","clone_url":"https://github.com/jordan-brough/spree.git","svn_url":"https://github.com/jordan-brough/spree","homepage":"http://spreecommerce.com","size":71534,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spree:master","ref":"master","sha":"6880c4d80e5797d205a76293d8811861baedc7e5","user":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"repo":{"id":3314,"name":"spree","full_name":"spree/spree","owner":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spree/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/spree/spree","forks_url":"https://api.github.com/repos/spree/spree/forks","keys_url":"https://api.github.com/repos/spree/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spree/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spree/spree/teams","hooks_url":"https://api.github.com/repos/spree/spree/hooks","issue_events_url":"https://api.github.com/repos/spree/spree/issues/events{/number}","events_url":"https://api.github.com/repos/spree/spree/events","assignees_url":"https://api.github.com/repos/spree/spree/assignees{/user}","branches_url":"https://api.github.com/repos/spree/spree/branches{/branch}","tags_url":"https://api.github.com/repos/spree/spree/tags","blobs_url":"https://api.github.com/repos/spree/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spree/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spree/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spree/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spree/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/spree/spree/languages","stargazers_url":"https://api.github.com/repos/spree/spree/stargazers","contributors_url":"https://api.github.com/repos/spree/spree/contributors","subscribers_url":"https://api.github.com/repos/spree/spree/subscribers","subscription_url":"https://api.github.com/repos/spree/spree/subscription","commits_url":"https://api.github.com/repos/spree/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spree/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spree/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spree/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/spree/spree/contents/{+path}","compare_url":"https://api.github.com/repos/spree/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spree/spree/merges","archive_url":"https://api.github.com/repos/spree/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spree/spree/downloads","issues_url":"https://api.github.com/repos/spree/spree/issues{/number}","pulls_url":"https://api.github.com/repos/spree/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/spree/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/spree/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spree/spree/labels{/name}","releases_url":"https://api.github.com/repos/spree/spree/releases{/id}","created_at":"2008-03-10T14:45:35Z","updated_at":"2015-01-23T16:33:45Z","pushed_at":"2015-01-23T16:33:45Z","git_url":"git://github.com/spree/spree.git","ssh_url":"git@github.com:spree/spree.git","clone_url":"https://github.com/spree/spree.git","svn_url":"https://github.com/spree/spree","homepage":"http://spreecommerce.com","size":127150,"stargazers_count":5870,"watchers_count":5870,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2738,"mirror_url":null,"open_issues_count":86,"forks":2738,"open_issues":86,"watchers":5870,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/5941"},"html":{"href":"https://github.com/spree/spree/pull/5941"},"issue":{"href":"https://api.github.com/repos/spree/spree/issues/5941"},"comments":{"href":"https://api.github.com/repos/spree/spree/issues/5941/comments"},"review_comments":{"href":"https://api.github.com/repos/spree/spree/pulls/5941/comments"},"review_comment":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spree/spree/pulls/5941/commits"},"statuses":{"href":"https://api.github.com/repos/spree/spree/statuses/0a57049690a6db7e60739254225bf3ad956daa97"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":4,"commits":2,"additions":60,"deletions":93,"changed_files":7}}