{"action":"created","issue":{"url":"https://api.github.com/repos/modelica-compliance/compliance/issues/11","labels_url":"https://api.github.com/repos/modelica-compliance/compliance/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/modelica-compliance/compliance/issues/11/comments","events_url":"https://api.github.com/repos/modelica-compliance/compliance/issues/11/events","html_url":"https://github.com/modelica-compliance/compliance/pull/11","id":111342000,"number":11,"title":"Must not assume that external functions are pure","user":{"login":"tbeu","id":5444067,"avatar_url":"https://avatars.githubusercontent.com/u/5444067?v=3","gravatar_id":"","url":"https://api.github.com/users/tbeu","html_url":"https://github.com/tbeu","followers_url":"https://api.github.com/users/tbeu/followers","following_url":"https://api.github.com/users/tbeu/following{/other_user}","gists_url":"https://api.github.com/users/tbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbeu/subscriptions","organizations_url":"https://api.github.com/users/tbeu/orgs","repos_url":"https://api.github.com/users/tbeu/repos","events_url":"https://api.github.com/users/tbeu/events{/privacy}","received_events_url":"https://api.github.com/users/tbeu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-14T07:40:17Z","updated_at":"2015-10-14T08:01:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/modelica-compliance/compliance/pulls/11","html_url":"https://github.com/modelica-compliance/compliance/pull/11","diff_url":"https://github.com/modelica-compliance/compliance/pull/11.diff","patch_url":"https://github.com/modelica-compliance/compliance/pull/11.patch"},"body":"It is nowhere said in the MLS that external functions have to be pure and thus can be assigned to a (constant) parameter. Assume that the external function is impure (e.g., a random number generator) then the assignment to a parameter would be invalid.\r\n\r\nSince the goal of these models is to test the external \"C\" support according to MLS 12.9 the parameter keyword should be removed here.\r\n\r\n@HansOlsson @sjoelund @perost FYI"},"comment":{"url":"https://api.github.com/repos/modelica-compliance/compliance/issues/comments/147967309","html_url":"https://github.com/modelica-compliance/compliance/pull/11#issuecomment-147967309","issue_url":"https://api.github.com/repos/modelica-compliance/compliance/issues/11","id":147967309,"user":{"login":"tbeu","id":5444067,"avatar_url":"https://avatars.githubusercontent.com/u/5444067?v=3","gravatar_id":"","url":"https://api.github.com/users/tbeu","html_url":"https://github.com/tbeu","followers_url":"https://api.github.com/users/tbeu/followers","following_url":"https://api.github.com/users/tbeu/following{/other_user}","gists_url":"https://api.github.com/users/tbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbeu/subscriptions","organizations_url":"https://api.github.com/users/tbeu/orgs","repos_url":"https://api.github.com/users/tbeu/repos","events_url":"https://api.github.com/users/tbeu/events{/privacy}","received_events_url":"https://api.github.com/users/tbeu/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T08:01:26Z","updated_at":"2015-10-14T08:01:26Z","body":"Thanks for clarification on the generous tool interpretation.\r\n\r\nSince the ModelicaCompliance.Functions.External models are designed to test for MLS 12.9 I still would prefer to remove the `parameter` keyword here and add one new test model for this generous interpretation in MLS 3.2 that external functions are assumed to be pure if evaluated during initialization."}}