{"action":"created","comment":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/comments/28764740","id":28764740,"diff_hunk":"@@ -85,16 +73,8 @@ public function supports($resource, $type = null)\n      */\n     private function addFrontendRoute(RouteCollection $routes, array $defaults)\n     {\n-        $pattern = '/{alias}';\n-        $require = ['alias' => '.*'];\n-\n-        // URL suffix\n-        if ($this->format) {\n-            $pattern .= '.{_format}';\n-\n-            $defaults['_format'] = $this->format;\n-            $require['_format']  = $this->format;\n-        }\n+        $pattern = '/{alias}%contao.url_suffix%';\n+        $require = ['alias' => '.+'];","path":"src/Routing/FrontendLoader.php","position":46,"original_position":46,"commit_id":"2135282fc5f731d3033344ad2f000f77761ca6e6","original_commit_id":"2135282fc5f731d3033344ad2f000f77761ca6e6","user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"body":"That's correct, otherwise the URL would be `de/.html` if you provide no alias with a german locale.","created_at":"2015-04-21T10:02:48Z","updated_at":"2015-04-21T10:02:48Z","html_url":"https://github.com/contao/core-bundle/pull/227#discussion_r28764740","pull_request_url":"https://api.github.com/repos/contao/core-bundle/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments/28764740"},"html":{"href":"https://github.com/contao/core-bundle/pull/227#discussion_r28764740"},"pull_request":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/227","id":33622818,"html_url":"https://github.com/contao/core-bundle/pull/227","diff_url":"https://github.com/contao/core-bundle/pull/227.diff","patch_url":"https://github.com/contao/core-bundle/pull/227.patch","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/227","number":227,"state":"open","locked":false,"title":"[RFC] The URL suffix is not the format","user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"body":"While working on the locale listener (see #190), I noticed that it's possible to have container parameter in routes. After playing around with it, I realized that our current approach is wrong. The URL suffix is only the format in the default configuration. But allowing people to set it to *empty* or */* would make the `_format` property useless.\r\n\r\nTherefore I propose to make it static.\r\n\r\nBe aware that this means URLs like `/en/` (language root) would be routed by the `catch_all` route, but I think that's fine.","created_at":"2015-04-19T17:58:45Z","updated_at":"2015-04-21T10:02:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cccac9f60df94a40a1ad05fe46f1d5b34a81db8d","assignee":{"login":"leofeyer","id":1192057,"avatar_url":"https://avatars.githubusercontent.com/u/1192057?v=3","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/contao/core-bundle/milestones/1","html_url":"https://github.com/contao/core-bundle/milestones/4.0.0","labels_url":"https://api.github.com/repos/contao/core-bundle/milestones/1/labels","id":748885,"number":1,"title":"4.0.0","description":"Contao 4.0.0 (major release)","creator":{"login":"leofeyer","id":1192057,"avatar_url":"https://avatars.githubusercontent.com/u/1192057?v=3","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":151,"state":"open","created_at":"2014-08-10T18:11:38Z","updated_at":"2015-04-21T09:14:17Z","due_on":"2015-05-25T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/contao/core-bundle/pulls/227/commits","review_comments_url":"https://api.github.com/repos/contao/core-bundle/pulls/227/comments","review_comment_url":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/227/comments","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/2135282fc5f731d3033344ad2f000f77761ca6e6","head":{"label":"aschempp:static-url-suffix","ref":"static-url-suffix","sha":"2135282fc5f731d3033344ad2f000f77761ca6e6","user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"repo":{"id":25865654,"name":"contao-core-bundle","full_name":"aschempp/contao-core-bundle","owner":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aschempp/contao-core-bundle","description":"Contao 4 core module","fork":true,"url":"https://api.github.com/repos/aschempp/contao-core-bundle","forks_url":"https://api.github.com/repos/aschempp/contao-core-bundle/forks","keys_url":"https://api.github.com/repos/aschempp/contao-core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschempp/contao-core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschempp/contao-core-bundle/teams","hooks_url":"https://api.github.com/repos/aschempp/contao-core-bundle/hooks","issue_events_url":"https://api.github.com/repos/aschempp/contao-core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/aschempp/contao-core-bundle/events","assignees_url":"https://api.github.com/repos/aschempp/contao-core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/aschempp/contao-core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/aschempp/contao-core-bundle/tags","blobs_url":"https://api.github.com/repos/aschempp/contao-core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschempp/contao-core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschempp/contao-core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschempp/contao-core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschempp/contao-core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/aschempp/contao-core-bundle/languages","stargazers_url":"https://api.github.com/repos/aschempp/contao-core-bundle/stargazers","contributors_url":"https://api.github.com/repos/aschempp/contao-core-bundle/contributors","subscribers_url":"https://api.github.com/repos/aschempp/contao-core-bundle/subscribers","subscription_url":"https://api.github.com/repos/aschempp/contao-core-bundle/subscription","commits_url":"https://api.github.com/repos/aschempp/contao-core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschempp/contao-core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschempp/contao-core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschempp/contao-core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschempp/contao-core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/aschempp/contao-core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschempp/contao-core-bundle/merges","archive_url":"https://api.github.com/repos/aschempp/contao-core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschempp/contao-core-bundle/downloads","issues_url":"https://api.github.com/repos/aschempp/contao-core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/aschempp/contao-core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/aschempp/contao-core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/aschempp/contao-core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschempp/contao-core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/aschempp/contao-core-bundle/releases{/id}","created_at":"2014-10-28T11:13:47Z","updated_at":"2014-11-27T09:50:18Z","pushed_at":"2015-04-21T08:36:44Z","git_url":"git://github.com/aschempp/contao-core-bundle.git","ssh_url":"git@github.com:aschempp/contao-core-bundle.git","clone_url":"https://github.com/aschempp/contao-core-bundle.git","svn_url":"https://github.com/aschempp/contao-core-bundle","homepage":null,"size":21541,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contao:develop","ref":"develop","sha":"2cecec3c2ca1931d93f7d0ece23477113c493d36","user":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":20519851,"name":"core-bundle","full_name":"contao/core-bundle","owner":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contao/core-bundle","description":"Contao 4 core bundle","fork":false,"url":"https://api.github.com/repos/contao/core-bundle","forks_url":"https://api.github.com/repos/contao/core-bundle/forks","keys_url":"https://api.github.com/repos/contao/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/core-bundle/teams","hooks_url":"https://api.github.com/repos/contao/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/contao/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/contao/core-bundle/events","assignees_url":"https://api.github.com/repos/contao/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/contao/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/contao/core-bundle/tags","blobs_url":"https://api.github.com/repos/contao/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/core-bundle/languages","stargazers_url":"https://api.github.com/repos/contao/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/contao/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/contao/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/contao/core-bundle/subscription","commits_url":"https://api.github.com/repos/contao/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/contao/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/core-bundle/merges","archive_url":"https://api.github.com/repos/contao/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/core-bundle/downloads","issues_url":"https://api.github.com/repos/contao/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/contao/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/contao/core-bundle/releases{/id}","created_at":"2014-06-05T09:45:55Z","updated_at":"2015-04-20T14:45:59Z","pushed_at":"2015-04-21T09:14:10Z","git_url":"git://github.com/contao/core-bundle.git","ssh_url":"git@github.com:contao/core-bundle.git","clone_url":"https://github.com/contao/core-bundle.git","svn_url":"https://github.com/contao/core-bundle","homepage":"","size":27245,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":20,"forks":10,"open_issues":20,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/227"},"html":{"href":"https://github.com/contao/core-bundle/pull/227"},"issue":{"href":"https://api.github.com/repos/contao/core-bundle/issues/227"},"comments":{"href":"https://api.github.com/repos/contao/core-bundle/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/contao/core-bundle/statuses/2135282fc5f731d3033344ad2f000f77761ca6e6"}}}}