{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7457","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7457/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7457/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7457/events","html_url":"https://github.com/civicrm/civicrm-core/pull/7457","id":122585648,"number":7457,"title":"CRM-17718 update repeattransaction & IPNs to prefer contribution recur data","user":{"login":"eileenmcnaughton","id":336308,"avatar_url":"https://avatars.githubusercontent.com/u/336308?v=3","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-16T19:39:37Z","updated_at":"2015-12-22T00:33:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7457","html_url":"https://github.com/civicrm/civicrm-core/pull/7457","diff_url":"https://github.com/civicrm/civicrm-core/pull/7457.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/7457.patch"},"body":"This isn't nearly as scary as it looks. The main changes are\r\n\r\n1) changes to the edit recurring contribution form to allow campaign id & financial type to be edited - with some limitations\r\n\r\n2) getting the calls to repeat recurring transactions to 'prefer' those values over the original contribution\r\n\r\n3) a bit of tidy up\r\n\r\n4) tests\r\n\r\nNote that 2, 3 & 4 are pretty heavily tested so the main QA focus is the form change. I used existing functions to conditionally add campaign (if it's enabled, if there are some etc) and added the following checks for conditionally adding financial type\r\n1) ACLs are not enabled for financial types - out of scope. I used an existing function\r\n2) the 'template contribution' only has one line item. Too complicated otherwise\r\n\r\n---\r\n https://issues.civicrm.org/jira/browse/CRM-17718"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/166466773","html_url":"https://github.com/civicrm/civicrm-core/pull/7457#issuecomment-166466773","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7457","id":166466773,"user":{"login":"davecivicrm","id":1545885,"avatar_url":"https://avatars.githubusercontent.com/u/1545885?v=3","gravatar_id":"","url":"https://api.github.com/users/davecivicrm","html_url":"https://github.com/davecivicrm","followers_url":"https://api.github.com/users/davecivicrm/followers","following_url":"https://api.github.com/users/davecivicrm/following{/other_user}","gists_url":"https://api.github.com/users/davecivicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/davecivicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecivicrm/subscriptions","organizations_url":"https://api.github.com/users/davecivicrm/orgs","repos_url":"https://api.github.com/users/davecivicrm/repos","events_url":"https://api.github.com/users/davecivicrm/events{/privacy}","received_events_url":"https://api.github.com/users/davecivicrm/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T00:33:34Z","updated_at":"2015-12-22T00:33:34Z","body":"@eileenmcnaughton I'm wondering if these test regressions are related to this PR:\r\nhttps://test.civicrm.org/job/CiviCRM-Core-PR/7150/\r\n\r\nI don't recall seeing them previously. I'll try asking Jenkins to re-run the test to see if that changes things."}}