{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/Tropos/issues/126","labels_url":"https://api.github.com/repos/thoughtbot/Tropos/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/Tropos/issues/126/comments","events_url":"https://api.github.com/repos/thoughtbot/Tropos/issues/126/events","html_url":"https://github.com/thoughtbot/Tropos/pull/126","id":90206534,"number":126,"title":"Move to CocoaPods-Keys","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-22T20:36:55Z","updated_at":"2015-06-26T23:27:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/Tropos/pulls/126","html_url":"https://github.com/thoughtbot/Tropos/pull/126","diff_url":"https://github.com/thoughtbot/Tropos/pull/126.diff","patch_url":"https://github.com/thoughtbot/Tropos/pull/126.patch"},"body":"Previously, API keys were stored in `Secrets.h`, a file not checked into git. This pull requests moves to [CocoaPods-Keys](https://github.com/orta/cocoapods-keys), a CocoaPods plugin designs specifically for this use case. \r\n\r\nThis pull requests:\r\n\r\n- Updates CocoaPods for use with the new plugin architecture.\r\n- Installs CocoaPods-Keys gem.\r\n- Updates `setup` script to stub Mixpanel and Hockey keys.\r\n- Switches to new keys.\r\n- Migrates CI instructions to use new keys plugin.\r\n- Updates installation instructions.\r\n\r\nI've kept `Secrets.h` in `.gitignore` to prevent a developer accidentally checking in this file and leaking secrets. \r\n\r\nFixes #125."},"comment":{"url":"https://api.github.com/repos/thoughtbot/Tropos/issues/comments/115917058","html_url":"https://github.com/thoughtbot/Tropos/pull/126#issuecomment-115917058","issue_url":"https://api.github.com/repos/thoughtbot/Tropos/issues/126","id":115917058,"user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T23:27:03Z","updated_at":"2015-06-26T23:27:03Z","body":"As you like. Key storage isn't a critical part of our toolchain; if CocoaPods disappeared tomorrow, Artsy would be fine and we would probably do something like this missing file approach. \r\n\r\nIf you feel this is a better direction for your team, sounds good 👍 You know what's best for your project. "}}