{"action":"created","comment":{"url":"https://api.github.com/repos/birarda/hifi/pulls/comments/34602876","id":34602876,"diff_hunk":"@@ -911,8 +910,8 @@ QByteArray AvatarData::identityByteArray() {\n     return identityData;\n }\n \n-bool AvatarData::hasBillboardChangedAfterParsing(const QByteArray& packet) {\n-    QByteArray newBillboard = packet.mid(numBytesForPacketHeader(packet));\n+bool AvatarData::hasBillboardChangedAfterParsing(NLPacket& packet) {\n+    QByteArray newBillboard = QByteArray(packet.getPayload());","path":"libraries/avatars/src/AvatarData.cpp","position":46,"original_position":46,"commit_id":"0edc909818419c0a4b3a83f2704e4a3c9055fc43","original_commit_id":"0edc909818419c0a4b3a83f2704e4a3c9055fc43","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"THis should be QByteArray::fromRawData(packet.getPayload())","created_at":"2015-07-14T18:35:35Z","updated_at":"2015-07-14T18:35:35Z","html_url":"https://github.com/birarda/hifi/pull/5#discussion_r34602876","pull_request_url":"https://api.github.com/repos/birarda/hifi/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/birarda/hifi/pulls/comments/34602876"},"html":{"href":"https://github.com/birarda/hifi/pull/5#discussion_r34602876"},"pull_request":{"href":"https://api.github.com/repos/birarda/hifi/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/birarda/hifi/pulls/5","id":39636334,"html_url":"https://github.com/birarda/hifi/pull/5","diff_url":"https://github.com/birarda/hifi/pull/5.diff","patch_url":"https://github.com/birarda/hifi/pull/5.patch","issue_url":"https://api.github.com/repos/birarda/hifi/issues/5","number":5,"state":"open","locked":false,"title":"Receive packets","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-09T22:42:31Z","updated_at":"2015-07-14T18:35:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2549f31fb628c7a5f72eb0e6c881347cd61dc375","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/birarda/hifi/pulls/5/commits","review_comments_url":"https://api.github.com/repos/birarda/hifi/pulls/5/comments","review_comment_url":"https://api.github.com/repos/birarda/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/birarda/hifi/issues/5/comments","statuses_url":"https://api.github.com/repos/birarda/hifi/statuses/0edc909818419c0a4b3a83f2704e4a3c9055fc43","head":{"label":"huffman:receive_packets","ref":"receive_packets","sha":"0edc909818419c0a4b3a83f2704e4a3c9055fc43","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"repo":{"id":16237479,"name":"hifi","full_name":"huffman/hifi","owner":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huffman/hifi","description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  You can also contribute by doing jobs listed at http://worklist.net/worklist.php","fork":true,"url":"https://api.github.com/repos/huffman/hifi","forks_url":"https://api.github.com/repos/huffman/hifi/forks","keys_url":"https://api.github.com/repos/huffman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huffman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huffman/hifi/teams","hooks_url":"https://api.github.com/repos/huffman/hifi/hooks","issue_events_url":"https://api.github.com/repos/huffman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/huffman/hifi/events","assignees_url":"https://api.github.com/repos/huffman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/huffman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/huffman/hifi/tags","blobs_url":"https://api.github.com/repos/huffman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huffman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huffman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/huffman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huffman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/huffman/hifi/languages","stargazers_url":"https://api.github.com/repos/huffman/hifi/stargazers","contributors_url":"https://api.github.com/repos/huffman/hifi/contributors","subscribers_url":"https://api.github.com/repos/huffman/hifi/subscribers","subscription_url":"https://api.github.com/repos/huffman/hifi/subscription","commits_url":"https://api.github.com/repos/huffman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/huffman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/huffman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/huffman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/huffman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/huffman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huffman/hifi/merges","archive_url":"https://api.github.com/repos/huffman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huffman/hifi/downloads","issues_url":"https://api.github.com/repos/huffman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/huffman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/huffman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/huffman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huffman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/huffman/hifi/releases{/id}","created_at":"2014-01-25T18:54:32Z","updated_at":"2015-03-25T17:45:58Z","pushed_at":"2015-07-14T17:22:36Z","git_url":"git://github.com/huffman/hifi.git","ssh_url":"git@github.com:huffman/hifi.git","clone_url":"https://github.com/huffman/hifi.git","svn_url":"https://github.com/huffman/hifi","homepage":"http://highfidelity.io","size":164164,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"birarda:protocol","ref":"protocol","sha":"821c16cbc4bbcd32ad7b7a232207cd144e89147c","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"repo":{"id":9376753,"name":"hifi","full_name":"birarda/hifi","owner":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/birarda/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/birarda/hifi","forks_url":"https://api.github.com/repos/birarda/hifi/forks","keys_url":"https://api.github.com/repos/birarda/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/birarda/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/birarda/hifi/teams","hooks_url":"https://api.github.com/repos/birarda/hifi/hooks","issue_events_url":"https://api.github.com/repos/birarda/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/birarda/hifi/events","assignees_url":"https://api.github.com/repos/birarda/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/birarda/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/birarda/hifi/tags","blobs_url":"https://api.github.com/repos/birarda/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/birarda/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/birarda/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/birarda/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/birarda/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/birarda/hifi/languages","stargazers_url":"https://api.github.com/repos/birarda/hifi/stargazers","contributors_url":"https://api.github.com/repos/birarda/hifi/contributors","subscribers_url":"https://api.github.com/repos/birarda/hifi/subscribers","subscription_url":"https://api.github.com/repos/birarda/hifi/subscription","commits_url":"https://api.github.com/repos/birarda/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/birarda/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/birarda/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/birarda/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/birarda/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/birarda/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/birarda/hifi/merges","archive_url":"https://api.github.com/repos/birarda/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/birarda/hifi/downloads","issues_url":"https://api.github.com/repos/birarda/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/birarda/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/birarda/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/birarda/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/birarda/hifi/labels{/name}","releases_url":"https://api.github.com/repos/birarda/hifi/releases{/id}","created_at":"2013-04-11T17:58:46Z","updated_at":"2015-05-08T19:10:20Z","pushed_at":"2015-07-14T18:21:05Z","git_url":"git://github.com/birarda/hifi.git","ssh_url":"git@github.com:birarda/hifi.git","clone_url":"https://github.com/birarda/hifi.git","svn_url":"https://github.com/birarda/hifi","homepage":null,"size":169471,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/birarda/hifi/pulls/5"},"html":{"href":"https://github.com/birarda/hifi/pull/5"},"issue":{"href":"https://api.github.com/repos/birarda/hifi/issues/5"},"comments":{"href":"https://api.github.com/repos/birarda/hifi/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/birarda/hifi/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/birarda/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/birarda/hifi/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/birarda/hifi/statuses/0edc909818419c0a4b3a83f2704e4a3c9055fc43"}}}}