{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42632345","id":42632345,"diff_hunk":"@@ -26,6 +26,12 @@ if (OPENSSL_TLSV12)\n     add_definitions(-DHAVE_TLS_V1_2=1)\n endif()\n \n+include(CheckStructHasMember)\n+check_struct_has_member (\"SSL_CIPHER\" algorithms openssl/ssl.h SSL_CIPHER_ALGORITHMS)\n+if (SSL_CIPHER_ALGORITHMS)\n+    add_definitions(-DHAVE_SSL_CIPHER_ALGORITHMS=1)","path":"src/Native/System.Security.Cryptography.Native/CMakeLists.txt","position":7,"original_position":7,"commit_id":"96e2b639b6e8975334da253e63f28aa8cd946f83","original_commit_id":"96e2b639b6e8975334da253e63f28aa8cd946f83","user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"body":"I feel like other tests are checking for newer features, this one checks for an older one.","created_at":"2015-10-21T14:43:33Z","updated_at":"2015-10-21T14:43:33Z","html_url":"https://github.com/dotnet/corefx/pull/4026#discussion_r42632345","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/4026","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42632345"},"html":{"href":"https://github.com/dotnet/corefx/pull/4026#discussion_r42632345"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4026"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/4026","id":48290767,"html_url":"https://github.com/dotnet/corefx/pull/4026","diff_url":"https://github.com/dotnet/corefx/pull/4026.diff","patch_url":"https://github.com/dotnet/corefx/pull/4026.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/4026","number":4026,"state":"open","locked":false,"title":"Round #2 of LibSsl shim work","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"Add shims for the next set of SSL interop methods.\r\nI also moved the SSL SafeHandle classes out of the Interop class to be\r\nbetter aligned with the rest of the SafeHandles.\r\n\r\nInstead of having managed code duplicate the SSL_CIPHER struct, moving all the code that uses the cipher struct into a native shim method.\r\n\r\nThat also pulled a lot of algorithm constants to be defined in native instead of managed.\r\n\r\n@bartonjs @stephentoub @vijaykota @rajansingh10 @shrutigarg @nguerrera ","created_at":"2015-10-21T05:52:40Z","updated_at":"2015-10-21T14:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30d25c9002426cab9c50e6291bad8ed2e0975863","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/4026/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/4026/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/4026/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/96e2b639b6e8975334da253e63f28aa8cd946f83","head":{"label":"eerhardt:MoreLibSsl","ref":"MoreLibSsl","sha":"96e2b639b6e8975334da253e63f28aa8cd946f83","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"repo":{"id":38781378,"name":"corefx","full_name":"eerhardt/corefx","owner":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eerhardt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/eerhardt/corefx","forks_url":"https://api.github.com/repos/eerhardt/corefx/forks","keys_url":"https://api.github.com/repos/eerhardt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eerhardt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eerhardt/corefx/teams","hooks_url":"https://api.github.com/repos/eerhardt/corefx/hooks","issue_events_url":"https://api.github.com/repos/eerhardt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/eerhardt/corefx/events","assignees_url":"https://api.github.com/repos/eerhardt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/eerhardt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/eerhardt/corefx/tags","blobs_url":"https://api.github.com/repos/eerhardt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eerhardt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eerhardt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/eerhardt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eerhardt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/eerhardt/corefx/languages","stargazers_url":"https://api.github.com/repos/eerhardt/corefx/stargazers","contributors_url":"https://api.github.com/repos/eerhardt/corefx/contributors","subscribers_url":"https://api.github.com/repos/eerhardt/corefx/subscribers","subscription_url":"https://api.github.com/repos/eerhardt/corefx/subscription","commits_url":"https://api.github.com/repos/eerhardt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/eerhardt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/eerhardt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/eerhardt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/eerhardt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/eerhardt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eerhardt/corefx/merges","archive_url":"https://api.github.com/repos/eerhardt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eerhardt/corefx/downloads","issues_url":"https://api.github.com/repos/eerhardt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/eerhardt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/eerhardt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/eerhardt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eerhardt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/eerhardt/corefx/releases{/id}","created_at":"2015-07-08T21:38:15Z","updated_at":"2015-07-08T21:38:34Z","pushed_at":"2015-10-21T05:45:56Z","git_url":"git://github.com/eerhardt/corefx.git","ssh_url":"git@github.com:eerhardt/corefx.git","clone_url":"https://github.com/eerhardt/corefx.git","svn_url":"https://github.com/eerhardt/corefx","homepage":"http://dotnet.github.io/core/","size":36657,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"bdc6c8ff8e32890d5f6a9e95f92e6b4427fdc6d7","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-10-21T07:01:23Z","pushed_at":"2015-10-21T14:14:38Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":83861,"stargazers_count":8470,"watchers_count":8470,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1853,"mirror_url":null,"open_issues_count":667,"forks":1853,"open_issues":667,"watchers":8470,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4026"},"html":{"href":"https://github.com/dotnet/corefx/pull/4026"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4026"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4026/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4026/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4026/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/96e2b639b6e8975334da253e63f28aa8cd946f83"}}}}