{"action":"created","comment":{"url":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments/37288899","id":37288899,"diff_hunk":"@@ -168,11 +168,13 @@ export default Ember.Mixin.create({\n         this.set('_currentPage', startingPage);\n         this.set('_totalPages', totalPages);\n         infinityModel.set('reachedInfinity', !this.get('_canLoadMore'));\n-        Ember.run.scheduleOnce('afterRender', this, 'infinityModelUpdated', {\n-          lastPageLoaded: startingPage,\n-          totalPages: totalPages,\n-          newObjects: infinityModel\n-        });\n+        if(this.infinityModelUpdated) {","path":"addon/mixins/route.js","position":18,"original_position":18,"commit_id":"866832cde515c22008c9d32d1b34a222c4190180","original_commit_id":"866832cde515c22008c9d32d1b34a222c4190180","user":{"login":"mkorfmann","id":3209250,"avatar_url":"https://avatars.githubusercontent.com/u/3209250?v=3","gravatar_id":"","url":"https://api.github.com/users/mkorfmann","html_url":"https://github.com/mkorfmann","followers_url":"https://api.github.com/users/mkorfmann/followers","following_url":"https://api.github.com/users/mkorfmann/following{/other_user}","gists_url":"https://api.github.com/users/mkorfmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mkorfmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkorfmann/subscriptions","organizations_url":"https://api.github.com/users/mkorfmann/orgs","repos_url":"https://api.github.com/users/mkorfmann/repos","events_url":"https://api.github.com/users/mkorfmann/events{/privacy}","received_events_url":"https://api.github.com/users/mkorfmann/received_events","type":"User","site_admin":false},"body":"I ran into occassions, where the infinityModelUpdated and infinityModelLoaded hooks weren't defined, so ember was complaining about running a callback with an undefined method.\r\n\r\nMaybe before ember 2.0.0, thse things we're possible or these issues are independent of the update.","created_at":"2015-08-18T11:42:30Z","updated_at":"2015-08-18T11:42:30Z","html_url":"https://github.com/hhff/ember-infinity/pull/75#discussion_r37288899","pull_request_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments/37288899"},"html":{"href":"https://github.com/hhff/ember-infinity/pull/75#discussion_r37288899"},"pull_request":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/hhff/ember-infinity/pulls/75","id":42661973,"html_url":"https://github.com/hhff/ember-infinity/pull/75","diff_url":"https://github.com/hhff/ember-infinity/pull/75.diff","patch_url":"https://github.com/hhff/ember-infinity/pull/75.patch","issue_url":"https://api.github.com/repos/hhff/ember-infinity/issues/75","number":75,"state":"open","locked":false,"title":"bare minimum update work for ember 2","user":{"login":"mkorfmann","id":3209250,"avatar_url":"https://avatars.githubusercontent.com/u/3209250?v=3","gravatar_id":"","url":"https://api.github.com/users/mkorfmann","html_url":"https://github.com/mkorfmann","followers_url":"https://api.github.com/users/mkorfmann/followers","following_url":"https://api.github.com/users/mkorfmann/following{/other_user}","gists_url":"https://api.github.com/users/mkorfmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mkorfmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkorfmann/subscriptions","organizations_url":"https://api.github.com/users/mkorfmann/orgs","repos_url":"https://api.github.com/users/mkorfmann/repos","events_url":"https://api.github.com/users/mkorfmann/events{/privacy}","received_events_url":"https://api.github.com/users/mkorfmann/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-18T05:13:57Z","updated_at":"2015-08-18T11:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3cc12bb0a4f5ba43d45356de411cbe6a97c7ce8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/75/commits","review_comments_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/75/comments","review_comment_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhff/ember-infinity/issues/75/comments","statuses_url":"https://api.github.com/repos/hhff/ember-infinity/statuses/866832cde515c22008c9d32d1b34a222c4190180","head":{"label":"mkorfmann:fix/update-for-ember-data-1-13-x","ref":"fix/update-for-ember-data-1-13-x","sha":"866832cde515c22008c9d32d1b34a222c4190180","user":{"login":"mkorfmann","id":3209250,"avatar_url":"https://avatars.githubusercontent.com/u/3209250?v=3","gravatar_id":"","url":"https://api.github.com/users/mkorfmann","html_url":"https://github.com/mkorfmann","followers_url":"https://api.github.com/users/mkorfmann/followers","following_url":"https://api.github.com/users/mkorfmann/following{/other_user}","gists_url":"https://api.github.com/users/mkorfmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mkorfmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkorfmann/subscriptions","organizations_url":"https://api.github.com/users/mkorfmann/orgs","repos_url":"https://api.github.com/users/mkorfmann/repos","events_url":"https://api.github.com/users/mkorfmann/events{/privacy}","received_events_url":"https://api.github.com/users/mkorfmann/received_events","type":"User","site_admin":false},"repo":{"id":39992884,"name":"ember-infinity","full_name":"mkorfmann/ember-infinity","owner":{"login":"mkorfmann","id":3209250,"avatar_url":"https://avatars.githubusercontent.com/u/3209250?v=3","gravatar_id":"","url":"https://api.github.com/users/mkorfmann","html_url":"https://github.com/mkorfmann","followers_url":"https://api.github.com/users/mkorfmann/followers","following_url":"https://api.github.com/users/mkorfmann/following{/other_user}","gists_url":"https://api.github.com/users/mkorfmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mkorfmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkorfmann/subscriptions","organizations_url":"https://api.github.com/users/mkorfmann/orgs","repos_url":"https://api.github.com/users/mkorfmann/repos","events_url":"https://api.github.com/users/mkorfmann/events{/privacy}","received_events_url":"https://api.github.com/users/mkorfmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkorfmann/ember-infinity","description":"Simple, flexible Infinite Scroll for Ember CLI Apps.","fork":true,"url":"https://api.github.com/repos/mkorfmann/ember-infinity","forks_url":"https://api.github.com/repos/mkorfmann/ember-infinity/forks","keys_url":"https://api.github.com/repos/mkorfmann/ember-infinity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkorfmann/ember-infinity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkorfmann/ember-infinity/teams","hooks_url":"https://api.github.com/repos/mkorfmann/ember-infinity/hooks","issue_events_url":"https://api.github.com/repos/mkorfmann/ember-infinity/issues/events{/number}","events_url":"https://api.github.com/repos/mkorfmann/ember-infinity/events","assignees_url":"https://api.github.com/repos/mkorfmann/ember-infinity/assignees{/user}","branches_url":"https://api.github.com/repos/mkorfmann/ember-infinity/branches{/branch}","tags_url":"https://api.github.com/repos/mkorfmann/ember-infinity/tags","blobs_url":"https://api.github.com/repos/mkorfmann/ember-infinity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkorfmann/ember-infinity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkorfmann/ember-infinity/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkorfmann/ember-infinity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkorfmann/ember-infinity/statuses/{sha}","languages_url":"https://api.github.com/repos/mkorfmann/ember-infinity/languages","stargazers_url":"https://api.github.com/repos/mkorfmann/ember-infinity/stargazers","contributors_url":"https://api.github.com/repos/mkorfmann/ember-infinity/contributors","subscribers_url":"https://api.github.com/repos/mkorfmann/ember-infinity/subscribers","subscription_url":"https://api.github.com/repos/mkorfmann/ember-infinity/subscription","commits_url":"https://api.github.com/repos/mkorfmann/ember-infinity/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkorfmann/ember-infinity/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkorfmann/ember-infinity/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkorfmann/ember-infinity/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkorfmann/ember-infinity/contents/{+path}","compare_url":"https://api.github.com/repos/mkorfmann/ember-infinity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkorfmann/ember-infinity/merges","archive_url":"https://api.github.com/repos/mkorfmann/ember-infinity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkorfmann/ember-infinity/downloads","issues_url":"https://api.github.com/repos/mkorfmann/ember-infinity/issues{/number}","pulls_url":"https://api.github.com/repos/mkorfmann/ember-infinity/pulls{/number}","milestones_url":"https://api.github.com/repos/mkorfmann/ember-infinity/milestones{/number}","notifications_url":"https://api.github.com/repos/mkorfmann/ember-infinity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkorfmann/ember-infinity/labels{/name}","releases_url":"https://api.github.com/repos/mkorfmann/ember-infinity/releases{/id}","created_at":"2015-07-31T07:33:49Z","updated_at":"2015-07-31T07:33:50Z","pushed_at":"2015-08-18T05:38:37Z","git_url":"git://github.com/mkorfmann/ember-infinity.git","ssh_url":"git@github.com:mkorfmann/ember-infinity.git","clone_url":"https://github.com/mkorfmann/ember-infinity.git","svn_url":"https://github.com/mkorfmann/ember-infinity","homepage":"http://hhff.github.io/ember-infinity/","size":20189,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hhff:fix/update-for-ember-data-1-13-x","ref":"fix/update-for-ember-data-1-13-x","sha":"a8e70d733fbef83b58beb873e701d80ab2cdb3eb","user":{"login":"hhff","id":2865404,"avatar_url":"https://avatars.githubusercontent.com/u/2865404?v=3","gravatar_id":"","url":"https://api.github.com/users/hhff","html_url":"https://github.com/hhff","followers_url":"https://api.github.com/users/hhff/followers","following_url":"https://api.github.com/users/hhff/following{/other_user}","gists_url":"https://api.github.com/users/hhff/gists{/gist_id}","starred_url":"https://api.github.com/users/hhff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhff/subscriptions","organizations_url":"https://api.github.com/users/hhff/orgs","repos_url":"https://api.github.com/users/hhff/repos","events_url":"https://api.github.com/users/hhff/events{/privacy}","received_events_url":"https://api.github.com/users/hhff/received_events","type":"User","site_admin":false},"repo":{"id":32656538,"name":"ember-infinity","full_name":"hhff/ember-infinity","owner":{"login":"hhff","id":2865404,"avatar_url":"https://avatars.githubusercontent.com/u/2865404?v=3","gravatar_id":"","url":"https://api.github.com/users/hhff","html_url":"https://github.com/hhff","followers_url":"https://api.github.com/users/hhff/followers","following_url":"https://api.github.com/users/hhff/following{/other_user}","gists_url":"https://api.github.com/users/hhff/gists{/gist_id}","starred_url":"https://api.github.com/users/hhff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhff/subscriptions","organizations_url":"https://api.github.com/users/hhff/orgs","repos_url":"https://api.github.com/users/hhff/repos","events_url":"https://api.github.com/users/hhff/events{/privacy}","received_events_url":"https://api.github.com/users/hhff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhff/ember-infinity","description":"Simple, flexible Infinite Scroll for Ember CLI Apps.","fork":false,"url":"https://api.github.com/repos/hhff/ember-infinity","forks_url":"https://api.github.com/repos/hhff/ember-infinity/forks","keys_url":"https://api.github.com/repos/hhff/ember-infinity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhff/ember-infinity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhff/ember-infinity/teams","hooks_url":"https://api.github.com/repos/hhff/ember-infinity/hooks","issue_events_url":"https://api.github.com/repos/hhff/ember-infinity/issues/events{/number}","events_url":"https://api.github.com/repos/hhff/ember-infinity/events","assignees_url":"https://api.github.com/repos/hhff/ember-infinity/assignees{/user}","branches_url":"https://api.github.com/repos/hhff/ember-infinity/branches{/branch}","tags_url":"https://api.github.com/repos/hhff/ember-infinity/tags","blobs_url":"https://api.github.com/repos/hhff/ember-infinity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhff/ember-infinity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhff/ember-infinity/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhff/ember-infinity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhff/ember-infinity/statuses/{sha}","languages_url":"https://api.github.com/repos/hhff/ember-infinity/languages","stargazers_url":"https://api.github.com/repos/hhff/ember-infinity/stargazers","contributors_url":"https://api.github.com/repos/hhff/ember-infinity/contributors","subscribers_url":"https://api.github.com/repos/hhff/ember-infinity/subscribers","subscription_url":"https://api.github.com/repos/hhff/ember-infinity/subscription","commits_url":"https://api.github.com/repos/hhff/ember-infinity/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhff/ember-infinity/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhff/ember-infinity/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhff/ember-infinity/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhff/ember-infinity/contents/{+path}","compare_url":"https://api.github.com/repos/hhff/ember-infinity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhff/ember-infinity/merges","archive_url":"https://api.github.com/repos/hhff/ember-infinity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhff/ember-infinity/downloads","issues_url":"https://api.github.com/repos/hhff/ember-infinity/issues{/number}","pulls_url":"https://api.github.com/repos/hhff/ember-infinity/pulls{/number}","milestones_url":"https://api.github.com/repos/hhff/ember-infinity/milestones{/number}","notifications_url":"https://api.github.com/repos/hhff/ember-infinity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhff/ember-infinity/labels{/name}","releases_url":"https://api.github.com/repos/hhff/ember-infinity/releases{/id}","created_at":"2015-03-22T01:00:39Z","updated_at":"2015-08-16T12:18:01Z","pushed_at":"2015-08-18T05:38:38Z","git_url":"git://github.com/hhff/ember-infinity.git","ssh_url":"git@github.com:hhff/ember-infinity.git","clone_url":"https://github.com/hhff/ember-infinity.git","svn_url":"https://github.com/hhff/ember-infinity","homepage":"http://hhff.github.io/ember-infinity/","size":20811,"stargazers_count":91,"watchers_count":91,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":14,"forks":36,"open_issues":14,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/75"},"html":{"href":"https://github.com/hhff/ember-infinity/pull/75"},"issue":{"href":"https://api.github.com/repos/hhff/ember-infinity/issues/75"},"comments":{"href":"https://api.github.com/repos/hhff/ember-infinity/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/hhff/ember-infinity/statuses/866832cde515c22008c9d32d1b34a222c4190180"}}}}