{"action":"closed","number":255,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/255","id":47058971,"html_url":"https://github.com/ocaml/ocaml/pull/255","diff_url":"https://github.com/ocaml/ocaml/pull/255.diff","patch_url":"https://github.com/ocaml/ocaml/pull/255.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/255","number":255,"state":"closed","locked":false,"title":"fix undefined left shift of negative value.","user":{"login":"bryant","id":670831,"avatar_url":"https://avatars.githubusercontent.com/u/670831?v=3","gravatar_id":"","url":"https://api.github.com/users/bryant","html_url":"https://github.com/bryant","followers_url":"https://api.github.com/users/bryant/followers","following_url":"https://api.github.com/users/bryant/following{/other_user}","gists_url":"https://api.github.com/users/bryant/gists{/gist_id}","starred_url":"https://api.github.com/users/bryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryant/subscriptions","organizations_url":"https://api.github.com/users/bryant/orgs","repos_url":"https://api.github.com/users/bryant/repos","events_url":"https://api.github.com/users/bryant/events{/privacy}","received_events_url":"https://api.github.com/users/bryant/received_events","type":"User","site_admin":false},"body":"Left-shifting signed negative values is undefined behavior. From 6.5.7 of http://open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf:\r\n\r\n```\r\nIf E1 has a signed type and nonnegative value,\r\nand E1 × 2 E2 is representable in the result type,\r\nthen that is the resulting value; otherwise, the\r\nbehavior is undefined.\r\n```\r\n\r\nThis patch also has the pleasant side effect of permitting build with clang.","created_at":"2015-10-07T17:46:24Z","updated_at":"2015-10-17T14:24:25Z","closed_at":"2015-10-17T14:24:25Z","merged_at":null,"merge_commit_sha":"1d96c84d925c07ef2ca51ddeebd23ed1005c2457","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/255/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/255/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/255/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/749045d74ec9617e651901fbfe98d135061ec7e5","head":{"label":"bryant:fix-undefined-shift","ref":"fix-undefined-shift","sha":"749045d74ec9617e651901fbfe98d135061ec7e5","user":{"login":"bryant","id":670831,"avatar_url":"https://avatars.githubusercontent.com/u/670831?v=3","gravatar_id":"","url":"https://api.github.com/users/bryant","html_url":"https://github.com/bryant","followers_url":"https://api.github.com/users/bryant/followers","following_url":"https://api.github.com/users/bryant/following{/other_user}","gists_url":"https://api.github.com/users/bryant/gists{/gist_id}","starred_url":"https://api.github.com/users/bryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryant/subscriptions","organizations_url":"https://api.github.com/users/bryant/orgs","repos_url":"https://api.github.com/users/bryant/repos","events_url":"https://api.github.com/users/bryant/events{/privacy}","received_events_url":"https://api.github.com/users/bryant/received_events","type":"User","site_admin":false},"repo":{"id":43833659,"name":"ocaml","full_name":"bryant/ocaml","owner":{"login":"bryant","id":670831,"avatar_url":"https://avatars.githubusercontent.com/u/670831?v=3","gravatar_id":"","url":"https://api.github.com/users/bryant","html_url":"https://github.com/bryant","followers_url":"https://api.github.com/users/bryant/followers","following_url":"https://api.github.com/users/bryant/following{/other_user}","gists_url":"https://api.github.com/users/bryant/gists{/gist_id}","starred_url":"https://api.github.com/users/bryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryant/subscriptions","organizations_url":"https://api.github.com/users/bryant/orgs","repos_url":"https://api.github.com/users/bryant/repos","events_url":"https://api.github.com/users/bryant/events{/privacy}","received_events_url":"https://api.github.com/users/bryant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryant/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/bryant/ocaml","forks_url":"https://api.github.com/repos/bryant/ocaml/forks","keys_url":"https://api.github.com/repos/bryant/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryant/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryant/ocaml/teams","hooks_url":"https://api.github.com/repos/bryant/ocaml/hooks","issue_events_url":"https://api.github.com/repos/bryant/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/bryant/ocaml/events","assignees_url":"https://api.github.com/repos/bryant/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/bryant/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/bryant/ocaml/tags","blobs_url":"https://api.github.com/repos/bryant/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryant/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryant/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryant/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryant/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/bryant/ocaml/languages","stargazers_url":"https://api.github.com/repos/bryant/ocaml/stargazers","contributors_url":"https://api.github.com/repos/bryant/ocaml/contributors","subscribers_url":"https://api.github.com/repos/bryant/ocaml/subscribers","subscription_url":"https://api.github.com/repos/bryant/ocaml/subscription","commits_url":"https://api.github.com/repos/bryant/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryant/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryant/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryant/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryant/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/bryant/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryant/ocaml/merges","archive_url":"https://api.github.com/repos/bryant/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryant/ocaml/downloads","issues_url":"https://api.github.com/repos/bryant/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/bryant/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/bryant/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/bryant/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryant/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/bryant/ocaml/releases{/id}","created_at":"2015-10-07T17:42:43Z","updated_at":"2015-10-07T17:43:04Z","pushed_at":"2015-10-07T17:43:57Z","git_url":"git://github.com/bryant/ocaml.git","ssh_url":"git@github.com:bryant/ocaml.git","clone_url":"https://github.com/bryant/ocaml.git","svn_url":"https://github.com/bryant/ocaml","homepage":null,"size":115226,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"54ace9943baf35970e1525bf67c37259694dbe0a","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"Read-only mirror of INRIA SVN","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","created_at":"2012-11-20T22:18:22Z","updated_at":"2015-10-17T04:40:55Z","pushed_at":"2015-10-17T14:22:17Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":null,"size":183096,"stargazers_count":454,"watchers_count":454,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":71,"forks":177,"open_issues":71,"watchers":454,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/255"},"html":{"href":"https://github.com/ocaml/ocaml/pull/255"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/255"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/749045d74ec9617e651901fbfe98d135061ec7e5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":11,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}