{"push_id":651097588,"size":20,"distinct_size":18,"ref":"refs/heads/master","head":"9f724f20c8d33c01f16469f0bc233a63028c6005","before":"db923a4b6ac82ec2fec7a83121ff96db41480d33","commits":[{"sha":"426500d7314a544cf4827bec239e942f86fc4cf8","author":{"email":"71f7040c7ba56256ea94200e583956e68e3f4129@gmail.com","name":"Chris Arnold"},"message":"Add visibility field to a ReviewRequestVisit\n\nThis adds a visibility field to the ReviewRequestVisit with three states:\nvisible (V), archived (A), and muted (M). A database evolution,\nreviewrequestvisit_visibility, is also added.\n\nTesting done:\n- Added to reviewboard.accounts.tests to test if VISIBLE was the default state\n  of a newly created ReviewRequestVisit, all tests passed.\n- Checked database entries in the admin interface.\n\nReviewed at https://reviews.reviewboard.org/r/7085/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/426500d7314a544cf4827bec239e942f86fc4cf8"},{"sha":"9b7605f7cca1a0f7a85cde73b3f50edf9cc3ca19","author":{"email":"71f7040c7ba56256ea94200e583956e68e3f4129@gmail.com","name":"Chris Arnold"},"message":"Add a Dashboard toggle to show or hide archived review requests\n\nThis adds a toggle on the Dashboard datagrid to show or hide archived review\nrequests, similar to that of the All Review Requests datagrid for showing and\nhiding closed review requests.\n\n- A new template block is loaded in the dashboard to expose the toggle button.\n- When the toggle is clicked, a show-archived query is appended to the\n  existing URL query.\n- show-archived=0 filters the archived review requests (those that are archived\n  or muted).\n- show-archived=1 includes all review requests, regardless of their state of\n  visibility\n\nNB: When show-archived is not specified, its default value of is 0.\n\nTesting done:\nManual tests: Archived and muted several review requests. In the dashboard,\nthey disappeared when setting show-archived=0 and reappeared when setting\nshow-archived=1\n\nUnit tests: Added to reviewboard.datagrids.tests to test if archived review\nrequests would appear in the datagrid for a particular user for show-archived=0\nand show-archived=1. Also tested for a different user who had not archived any\nof the same review requests. All tests passed.\n\nReviewed at https://reviews.reviewboard.org/r/7109/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/9b7605f7cca1a0f7a85cde73b3f50edf9cc3ca19"},{"sha":"08266e0d48136b43fc3c7a9600cc36d503315d25","author":{"email":"71f7040c7ba56256ea94200e583956e68e3f4129@gmail.com","name":"Chris Arnold"},"message":"Add webAPI resources for archived and muted review requests\n\nThis adds webAPI resources for the creation and deletion of archived and muted\nreview requests.\n\nEach resource is a child of the User resource and inherits from a base archived\nresource. Resources accept POST and DELETE requests, both of which modify\nReviewRequestVisit database entries accordingly.\n\nTesting Done:\nAdded standard POST and DELETE tests to reviewboard.webapi.tests. All tests\npassed.\n\nReviewed at https://reviews.reviewboard.org/r/7087/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/08266e0d48136b43fc3c7a9600cc36d503315d25"},{"sha":"029d534cfe168d0005d68329485c56af5c3015ef","author":{"email":"71f7040c7ba56256ea94200e583956e68e3f4129@gmail.com","name":"Chris Arnold"},"message":"Add UI to archive and mute review requests.\n\nThis adds the following UI:\n\n- Archive and mute buttons in a Hide dropdown menu in a review request view.\n- A banner that indicates that review request is archived with an unarchive\n  button.\n- A banner that indicates that review request is muted with an unmute button.\n\nReview request visibility is now passed as context data to templates. If\nvisibility is VISIBLE, the Hide dropdown menu becomes visibile. If visibility\nis ARCHIVED or MUTED, the Hide dropdown menu is hidden and the appropriate\narchive or mute banner appears. When visibility is changed, a page refresh is\ntriggered.\n\nThis also augments the UserSession WatchedItem (renamed StoredItem) to also\ninclude archivedReviewRequests and mutedReviewRequests. The only difference\nthese objects are their URL and their error messages (addError and removeError\nmethods were added in order to set different errors).\n\nTesting done:\nArchived and mute banner tests were added to reviewRequestEditorViewTests.js,\nall tests passed.\n\nReviewed at https://reviews.reviewboard.org/r/7086/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/029d534cfe168d0005d68329485c56af5c3015ef"},{"sha":"13a13a957526e4167d541500317a9d0abc6da80e","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Redesign the look and feel of the review requests page.\n\nThe review request page was, in many ways, largely unchanged from the\n1.0 days. We've had tweaks here and there, and some layout changes, but\nthe actual review portion has hardly been touched in years.\n\nThis is the first big redesign of this page we've had. It substantially\nchanges the look and feel, removing a lot of the boxes, toning down\ngradients, tightening some spacing and expanding others, and bringing a\nmore modern look to the page. There are also usability enhancements over\nwhat we had in the past.\n\nIn terms of style polish, the big highlights are that there's more\nbreathing room between reviews, between comments, and between the\ncontent and the browser's boundaries. There are no longer an extra set\nof borders within each review for the content, but rather the body of the\nreview is flat white, providing a cleaner feel. The action bar at the\ntop no longer has borders separating each action, opting instead to have\nappropriate spacing between the items.\n\nThere are a few other major changes added on to this as well.\n\nFirst, the actions on the page no longer include the page views (View\nDiff, View Reviews, etc.). Those have been moved just to the right of\nthe action bar, as a set of tabs. The current page always has an entry\nnow, making it clear where you are and where you can go.\n\nThere are now gravatars shown to the left of the reviews, and to the\nleft of any comments. The ones on the reviews also contain the\n\"Ship it!\" label, rather than having that appear on reviews. If there\nare any issues opened, a \"Fix it!\" label will show instead. If it's in a\n\"Fix it, then ship it!\" stage, we show a \"Fix it!\" label sitting on top\nof a \"Ship it!\" label. Any changes to these labels (as the result of\nclosing/reopening issues) animates the label state, providing a clean,\ncute transition.\n\nThe border around the gravatars are faintly dotted, with the color\nmatching the Ship It or Fix It state. This also transitions when the\nlabels do.\n\nThe green reply draft banners now extend up to the top of the review\nbox. This is quite nice when looking at a collapsed or expanded box.\n\nThe timestamps in the page now show only the relative times, as hovering\nover them already shows the absolute times. That removes a lot of visual\nnoise from the page.\n\nThe \"Add Comment\" links on the right have been replaced with \"Reply\" or\n\"Comment\" buttons on the left. The difference in text depends on whether\nthere's existing content being replied to.\n\nThe \"Expand All\"/\"Collapse All\" links (and equivalent links in the diff\nviewer) no longer sit in the bottom-right of the review request box, but\nrather are prominent btutons separating the review request and reviews.\nLikewise, for the diff viewer, they separate the box and the diffs.\n\nTesting Done:\nTested all the functionality and browsed through all affected pages in\nChrome and Firefox. My IE VM has been nuked, so I'll be testing that once\nI get that going again.\n\nThis functionality included:\n\n* Expanding/collapsing reviews.\n* Replying to comments.\n* Toggling issue states and watching what the labels did (in both the \"Fix It\" and\n  the \"Fix it, then ship it\" states.\n* Invoking actions from the action bar.\n* Navigating between tabs for review requests, diffs, and file attachments.\n* The floating reply draft banners.\n* The Expand All/Collapse All buttons.\n* The various view buttons for diffs (Show Whitespace Changes, etc.).\n* Expanding diffs in the review comments.\n\n(Note that the animation image attached has some color palette goofiness, due\nto being a gif, so ignore that aspect of it.)\n\nReviewed at https://reviews.reviewboard.org/r/7240/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/13a13a957526e4167d541500317a9d0abc6da80e"},{"sha":"96ba0654a55fdaefcfc66635dec465f1472840be","author":{"email":"c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","name":"David Trowbridge"},"message":"Rework archive/mute UI.\n\nThe UI for archive and mute within a review request was a little bit intrusive,\nand given how complicated this page already is, was too cluttered. In\nparticular, the addition of new banners at the top of the page (which\ninadvertantly hid existing banners like the draft banner or closed banner) were\njust far too much UI for this.\n\nI've replaced the \"Hide\" menu and the banners with a new menu on the left-hand\nside of the review request box, just next to the star icon. This uses a new\n\"inbox\" icon in the same style as the star icon, which highlights when the\nreview request is archived or muted.\n\nAs part of this, archiving/muting/unarchiving/unmuting no longer reloads the\npage. Instead, the code in the ReviewRequestEditorView will update the\nvisibility of the relevant menu items after the state is saved to the server.\nOnce we have a better icon, I intend to also have it change the state of the\nicon.\n\nTesting done:\n- Archived, unarchived, muted, and unmuted review requests.\n- Checked that the state was always tracked correctly.\n- Ran unit tests.\n- Ran js-tests.","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/96ba0654a55fdaefcfc66635dec465f1472840be"},{"sha":"98205e5b175f4daddaf3ce02fdd9e2bef4dd270c","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Refine the responsive UI support.\n\nIn 2.5, we gained the beginnings of response UI support, featuring a\nmobile-friendly page header, a pop-down search, and a slide-out sidebar\nfor basic navigation.\n\nThis builds upon that work to provide a more standardized UI for mobile\ndevices and to make it easier to integrate with the slide-out sidebar\nfor navigation.\n\nThe page header now has a standard \"hamburger menu\" icon (the three\nstacked lines), which pulls out the sidebar. The sidebar appears\nrecessed from the page's point of view, with a small shadow covering\npart of it. The page itself is \"pushed\" to the right, rather than the\nsidebar overlapping the page. While visible, the page cannot be\nscrolled. This uses CSS3 transitions to animate, improving the\nperformance on mobile devices over jQuery animation.\n\nThis sidebar contains links at the top for logging in/out, registering,\nand viewing account settings. Below that is the general page navigation\n(New review request, dashboard, etc.). Below that is any page-specific\nnavigation (such as the dashboard sidebar). Docked to the bottom of the\nmenu are a set of links for Docs, Support, and the Administration UI (if\nlogged in as an administrator).\n\nThe page header now always shows the search bar, instead of requiring\nanother tap to show search. That makes it easier to start a search\n(useful on mobile devices) and frees up room in the top-right for future\nexpansion.\n\nSearch results appear much like they do on other mobile apps, taking up\nthe full page content and giving enough room to easily tap to navigate.\nThis is an improvement over the default implementation, which simply\ndrops down a small list of results.\n\nThe result of the change is a friendlier UI that we'll be able to build\nupon for all future responsive UI support.\n\nTesting Done:\nTested on Chrome, Firefox, iPhone 6, and Nexus 7 (Chrome) in both mobile\nand non-mobile modes.\n\nI tested:\n\n* Pages with and without custom content in the sidebar.\n* Opening the sidebar and navigating to all the different links.\n* Closing the sidebar by tapping on the page content (and ensuring that doesn't trigger links there)\n* Searching and tapping results.\n* Going in and out of responsive mode on browsers.\n* Landscape mode on the iPhone and Nexus 7.\n* Sidebar content when logged in/out.\n\nReviewed at https://reviews.reviewboard.org/r/7257/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/98205e5b175f4daddaf3ce02fdd9e2bef4dd270c"},{"sha":"10a1734d8f225f497d80c8910bc8178b3dddc20a","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Make some of the datagrid classes more generically useful.\n\nThe recent dashboard class revamp renamed much of the dashboard-specific\nclasses to datagrid-specific classes, so we could use them on more\npages. This change goes a step further, taking many of those classes and\nmaking them useful outside of datagrids.\n\nThere are now a couple of top-level classes for `<body>` that define\nwhether the page has a sidebar or whether the content will be taking up\nthe full visible height of the page.\n\nSome of the datagrid page IDs (`#datagrid_page_container` and\n`#datagrid_page_content`) have been removed, instead making of use of\n`#page-container`, `#content_container`, and `#content`. That's two layers of\nelements and styles that are removed and made generic.\n\nThe sidebar classes are also now generic, no longer tied to datagrids.\nThis will allow us to reuse it for the New Review Request page, and\nothers.\n\nTesting Done:\nTested all the datagrid pages in desktop and mobile modes. Made sure\nfit-to-viewport, scrolling, and resizing all worked as expected.\n\nTested the review request, diff viewer, and admin pages.\n\nReviewed at https://reviews.reviewboard.org/r/7260/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/10a1734d8f225f497d80c8910bc8178b3dddc20a"},{"sha":"15e55014307e64dcc3b15fd114873d8c172c44c7","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Bump our less.js requirement to a pre-2.5.1 release.\n\nSome of the new CSS work requires features in LessCSS 2.0+, and fixes in\nthe upcoming (but not yet released) 2.5.1 release. This bumps our\ndependency to a build from today's snapshot of the Git repository.","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/15e55014307e64dcc3b15fd114873d8c172c44c7"},{"sha":"7fec0e2776ff24e0740469032b21213a5d31a082","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Include the file and interdiff information in diff fragment ETags.\n\nThe diff fragments were only considering diff revision numbers (by way\nof the URL) for the ETag, and not the IDs of the objects in the\ndatabase. This resulted in stale caches if trying to upload another\ndraft of a diff with the same revision.\n\nWe now include both the filediff ID and the interdiffset ID (if any).\n\nTesting Done:\nManually tested, and saw that subsequent uploads of a diff were rendering without\nhaving to clear cache.\n\nUnit tests pass.\n\nReviewed at https://reviews.reviewboard.org/r/7273/","distinct":false,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/7fec0e2776ff24e0740469032b21213a5d31a082"},{"sha":"a45b0b9d04a6fc207696385d4bb2343c1b318e8f","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Fix the interdiff URL changing after load in the diff viewer.\n\nWhen viewing an interdiff, the revision range in the URL would change,\nstripping away the interdiff information. This was due to the\n`Backbone.history.start` call's URL failing to account for the interdiff.\nWe now build this correctly to factor this information in.\n\nTesting Done:\nNavigated to various interdiff ranges, and never saw the URL strip the\ninformation away.\n\nReviewed at https://reviews.reviewboard.org/r/7274/","distinct":false,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/a45b0b9d04a6fc207696385d4bb2343c1b318e8f"},{"sha":"d7ef256d1cafc20118f6cf0f1141c3d53012612c","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Merge branch 'release-2.0.x' into release-2.5.x","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/d7ef256d1cafc20118f6cf0f1141c3d53012612c"},{"sha":"a8168fdfb95cc358f67f0d28d77f6cdfb26222d8","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Redesign the look and feel of the review requests page.\n\nThe review request page was, in many ways, largely unchanged from the\n1.0 days. We've had tweaks here and there, and some layout changes, but\nthe actual review portion has hardly been touched in years.\n\nThis is the first big redesign of this page we've had. It substantially\nchanges the look and feel, removing a lot of the boxes, toning down\ngradients, tightening some spacing and expanding others, and bringing a\nmore modern look to the page. There are also usability enhancements over\nwhat we had in the past.\n\nIn terms of style polish, the big highlights are that there's more\nbreathing room between reviews, between comments, and between the\ncontent and the browser's boundaries. There are no longer an extra set\nof borders within each review for the content, but rather the body of the\nreview is flat white, providing a cleaner feel. The action bar at the\ntop no longer has borders separating each action, opting instead to have\nappropriate spacing between the items.\n\nThere are a few other major changes added on to this as well.\n\nFirst, the actions on the page no longer include the page views (View\nDiff, View Reviews, etc.). Those have been moved just to the right of\nthe action bar, as a set of tabs. The current page always has an entry\nnow, making it clear where you are and where you can go.\n\nThere are now gravatars shown to the left of the reviews, and to the\nleft of any comments. The ones on the reviews also contain the\n\"Ship it!\" label, rather than having that appear on reviews. If there\nare any issues opened, a \"Fix it!\" label will show instead. If it's in a\n\"Fix it, then ship it!\" stage, we show a \"Fix it!\" label sitting on top\nof a \"Ship it!\" label. Any changes to these labels (as the result of\nclosing/reopening issues) animates the label state, providing a clean,\ncute transition.\n\nThe border around the gravatars are faintly dotted, with the color\nmatching the Ship It or Fix It state. This also transitions when the\nlabels do.\n\nThe green reply draft banners now extend up to the top of the review\nbox. This is quite nice when looking at a collapsed or expanded box.\n\nThe timestamps in the page now show only the relative times, as hovering\nover them already shows the absolute times. That removes a lot of visual\nnoise from the page.\n\nThe \"Add Comment\" links on the right have been replaced with \"Reply\" or\n\"Comment\" buttons on the left. The difference in text depends on whether\nthere's existing content being replied to.\n\nThe \"Expand All\"/\"Collapse All\" links (and equivalent links in the diff\nviewer) no longer sit in the bottom-right of the review request box, but\nrather are prominent btutons separating the review request and reviews.\nLikewise, for the diff viewer, they separate the box and the diffs.\n\nTesting Done:\nTested all the functionality and browsed through all affected pages in\nChrome and Firefox. My IE VM has been nuked, so I'll be testing that once\nI get that going again.\n\nThis functionality included:\n\n* Expanding/collapsing reviews.\n* Replying to comments.\n* Toggling issue states and watching what the labels did (in both the \"Fix It\" and\n  the \"Fix it, then ship it\" states.\n* Invoking actions from the action bar.\n* Navigating between tabs for review requests, diffs, and file attachments.\n* The floating reply draft banners.\n* The Expand All/Collapse All buttons.\n* The various view buttons for diffs (Show Whitespace Changes, etc.).\n* Expanding diffs in the review comments.\n\n(Note that the animation image attached has some color palette goofiness, due\nto being a gif, so ignore that aspect of it.)\n\nReviewed at https://reviews.reviewboard.org/r/7240/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/a8168fdfb95cc358f67f0d28d77f6cdfb26222d8"},{"sha":"e53a7b5ff807db37caa52ff1759a7f19d02ec797","author":{"email":"c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","name":"David Trowbridge"},"message":"Merge branch 'release-2.5.x' into ucosp/cristocrat/archive-and-mute","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/e53a7b5ff807db37caa52ff1759a7f19d02ec797"},{"sha":"5ac86d4415c628b98d74c560abb9f26e584f2c20","author":{"email":"c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","name":"David Trowbridge"},"message":"Improve some more spinners.\n\nThis change converts the spinner used in the side-by-side diff views to the new\nfont-awesome based one, and fixes the font size for the one in the review\ndialog (which is shown while loading comments).\n\nTesting done:\nLooked at both places and saw good-looking spinners.\n\nReviewed at https://reviews.reviewboard.org/r/7271/","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/5ac86d4415c628b98d74c560abb9f26e584f2c20"},{"sha":"8fa0688f8f4aaa180f8319e9956f65aa06c44a96","author":{"email":"c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","name":"David Trowbridge"},"message":"Merge branch 'release-2.5.x'","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/8fa0688f8f4aaa180f8319e9956f65aa06c44a96"},{"sha":"3f848f8715b052a7b63ea080c9fdd5ebcd98b214","author":{"email":"c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","name":"David Trowbridge"},"message":"Fix spacing on the new archive icon.\n\nMerges of different changes made it so the review request header was broken.\nThis trivial change fixes it.","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/3f848f8715b052a7b63ea080c9fdd5ebcd98b214"},{"sha":"b8da0cf1dadb522b6c71bd246621c440fb9dd373","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Fixed the display of the administration UI.\n\nA recent element ID rename broke the administration UI. This fixes the\nadmin.less stylesheet for the new ID.","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/b8da0cf1dadb522b6c71bd246621c440fb9dd373"},{"sha":"2d4675ebd1516870bb577a1de24b88151e44295d","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Fixed the display of the administration UI.\n\nA recent element ID rename broke the administration UI. This fixes the\nadmin.less stylesheet for the new ID.","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/2d4675ebd1516870bb577a1de24b88151e44295d"},{"sha":"9f724f20c8d33c01f16469f0bc233a63028c6005","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Merge branch 'release-2.5.x'","distinct":true,"url":"https://api.github.com/repos/chipx86/reviewboard/commits/9f724f20c8d33c01f16469f0bc233a63028c6005"}]}