{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments/26032677","id":26032677,"diff_hunk":"@@ -12,6 +12,28 @@\n     public static final Key<URI> URL = new Key<>(URI.create(\"http://localhost:8000\"));\n     public static final Key<String> TOKEN = new Key<>();\n \n+    /**\n+     * Timeout in milliseconds until a connection is established.\n+     * A timeout of zero is interpreted as an infinite timeout.\n+     * A negative value is interpreted as undefined (system default).\n+     * Default value is 10000ms (10s)\n+     * \n+     * @see HttpClientConnection.request(String)\n+     * @see JDKConnection.request(String, String)\n+     */\n+    public static final Key<Integer> CONNECT_TIMEOUT = new Key<>(10000);","path":"src/main/java/com/suse/saltstack/netapi/config/ClientConfig.java","position":13,"original_position":13,"commit_id":"990f2f8d3eec7742801cd3da3ceef97ae29ca5a1","original_commit_id":"05735ca0aa6fe7d9898cf52bd92a845d1ef6f1c2","user":{"login":"xavierfacq","id":3774556,"avatar_url":"https://avatars.githubusercontent.com/u/3774556?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierfacq","html_url":"https://github.com/xavierfacq","followers_url":"https://api.github.com/users/xavierfacq/followers","following_url":"https://api.github.com/users/xavierfacq/following{/other_user}","gists_url":"https://api.github.com/users/xavierfacq/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierfacq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierfacq/subscriptions","organizations_url":"https://api.github.com/users/xavierfacq/orgs","repos_url":"https://api.github.com/users/xavierfacq/repos","events_url":"https://api.github.com/users/xavierfacq/events{/privacy}","received_events_url":"https://api.github.com/users/xavierfacq/received_events","type":"User","site_admin":false},"body":"Is it ok for you if I add a `private static final int DEFAULT_TIMEOUT = 10000;` used to initialize `CONNECT_TIMEOUT` and `SOCKET_TIMEOUT` ?","created_at":"2015-03-09T12:54:21Z","updated_at":"2015-03-09T12:54:21Z","html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/46#discussion_r26032677","pull_request_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments/26032677"},"html":{"href":"https://github.com/SUSE/saltstack-netapi-client-java/pull/46#discussion_r26032677"},"pull_request":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46","id":30644103,"html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/46","diff_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/46.diff","patch_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/46.patch","issue_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/46","number":46,"state":"open","locked":false,"title":"Add a config parameter CONNECTION_TIMEOUT","user":{"login":"xavierfacq","id":3774556,"avatar_url":"https://avatars.githubusercontent.com/u/3774556?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierfacq","html_url":"https://github.com/xavierfacq","followers_url":"https://api.github.com/users/xavierfacq/followers","following_url":"https://api.github.com/users/xavierfacq/following{/other_user}","gists_url":"https://api.github.com/users/xavierfacq/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierfacq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierfacq/subscriptions","organizations_url":"https://api.github.com/users/xavierfacq/orgs","repos_url":"https://api.github.com/users/xavierfacq/repos","events_url":"https://api.github.com/users/xavierfacq/events{/privacy}","received_events_url":"https://api.github.com/users/xavierfacq/received_events","type":"User","site_admin":false},"body":"Add a config parameter CONNECTION_TIMEOUT to set the maximum connection timeout when performing HTTP requests.","created_at":"2015-03-06T13:24:11Z","updated_at":"2015-03-09T12:54:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc157bbec480cd8855285ac255b97eb2d410d6e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46/commits","review_comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46/comments","review_comment_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/46/comments","statuses_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/990f2f8d3eec7742801cd3da3ceef97ae29ca5a1","head":{"label":"xavierfacq:config_with_timeout","ref":"config_with_timeout","sha":"990f2f8d3eec7742801cd3da3ceef97ae29ca5a1","user":{"login":"xavierfacq","id":3774556,"avatar_url":"https://avatars.githubusercontent.com/u/3774556?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierfacq","html_url":"https://github.com/xavierfacq","followers_url":"https://api.github.com/users/xavierfacq/followers","following_url":"https://api.github.com/users/xavierfacq/following{/other_user}","gists_url":"https://api.github.com/users/xavierfacq/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierfacq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierfacq/subscriptions","organizations_url":"https://api.github.com/users/xavierfacq/orgs","repos_url":"https://api.github.com/users/xavierfacq/repos","events_url":"https://api.github.com/users/xavierfacq/events{/privacy}","received_events_url":"https://api.github.com/users/xavierfacq/received_events","type":"User","site_admin":false},"repo":{"id":31766605,"name":"saltstack-netapi-client-java","full_name":"xavierfacq/saltstack-netapi-client-java","owner":{"login":"xavierfacq","id":3774556,"avatar_url":"https://avatars.githubusercontent.com/u/3774556?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierfacq","html_url":"https://github.com/xavierfacq","followers_url":"https://api.github.com/users/xavierfacq/followers","following_url":"https://api.github.com/users/xavierfacq/following{/other_user}","gists_url":"https://api.github.com/users/xavierfacq/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierfacq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierfacq/subscriptions","organizations_url":"https://api.github.com/users/xavierfacq/orgs","repos_url":"https://api.github.com/users/xavierfacq/repos","events_url":"https://api.github.com/users/xavierfacq/events{/privacy}","received_events_url":"https://api.github.com/users/xavierfacq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xavierfacq/saltstack-netapi-client-java","description":"Java client to access the SaltStack net-api","fork":true,"url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java","forks_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/forks","keys_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/teams","hooks_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/hooks","issue_events_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/events","assignees_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/tags","blobs_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/languages","stargazers_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/stargazers","contributors_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/contributors","subscribers_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/subscribers","subscription_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/subscription","commits_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/merges","archive_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/downloads","issues_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/xavierfacq/saltstack-netapi-client-java/releases{/id}","created_at":"2015-03-06T11:33:05Z","updated_at":"2015-03-06T11:33:06Z","pushed_at":"2015-03-09T12:51:08Z","git_url":"git://github.com/xavierfacq/saltstack-netapi-client-java.git","ssh_url":"git@github.com:xavierfacq/saltstack-netapi-client-java.git","clone_url":"https://github.com/xavierfacq/saltstack-netapi-client-java.git","svn_url":"https://github.com/xavierfacq/saltstack-netapi-client-java","homepage":null,"size":21216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"02accaa9e7b3e13d4a3fd2cb79ca1851567fc899","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":25811020,"name":"saltstack-netapi-client-java","full_name":"SUSE/saltstack-netapi-client-java","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/saltstack-netapi-client-java","description":"Java client to access the SaltStack net-api","fork":false,"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java","forks_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/forks","keys_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/teams","hooks_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/hooks","issue_events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/events","assignees_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/tags","blobs_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/languages","stargazers_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/stargazers","contributors_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/contributors","subscribers_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/subscribers","subscription_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/subscription","commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/merges","archive_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/downloads","issues_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/releases{/id}","created_at":"2014-10-27T09:06:51Z","updated_at":"2015-03-03T09:39:22Z","pushed_at":"2015-03-03T09:39:21Z","git_url":"git://github.com/SUSE/saltstack-netapi-client-java.git","ssh_url":"git@github.com:SUSE/saltstack-netapi-client-java.git","clone_url":"https://github.com/SUSE/saltstack-netapi-client-java.git","svn_url":"https://github.com/SUSE/saltstack-netapi-client-java","homepage":null,"size":21216,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46"},"html":{"href":"https://github.com/SUSE/saltstack-netapi-client-java/pull/46"},"issue":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/46"},"comments":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/990f2f8d3eec7742801cd3da3ceef97ae29ca5a1"}}}}