{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/743","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/743/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/743/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/743/events","html_url":"https://github.com/minetest/minetest_game/pull/743","id":122208912,"number":743,"title":"Create API for fence.register, and use it.","user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-15T07:16:31Z","updated_at":"2015-12-16T02:35:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/743","html_url":"https://github.com/minetest/minetest_game/pull/743","diff_url":"https://github.com/minetest/minetest_game/pull/743.diff","patch_url":"https://github.com/minetest/minetest_game/pull/743.patch"},"body":"This converts the call to minetest.register() for the default\r\nfence node, so it can be called by other mods to quickly\r\nsetup other fences.\r\n\r\nSince this creates an API, insert it into the game_api.txt.\r\n\r\nThe api looks like minetest.register(name, {def}), and has two\r\nuncommon fields: \"texture\" and \"material\".\r\n\r\nI'm not modifying the default fence recipe. Instead, this version\r\nadds acacia sticks, pine sticks, junglewood sticks. This simplifies\r\nthe API and simplifies crafting, and is easier to remember, and\r\ndoesn't invent a new craft recipe that is hard to guess.\r\n\r\nLastly, adds pine, junglewood and acacia fences.\r\n\r\nTextures for the new sticks. I verified all of minetest_game only\r\never looks at group:stick for other material, so this prevents no\r\nsurprise to any player.\r\n\r\nThis is a from-scratch implementation, written by heart but inspired\r\nby (#665 - Add many wooden fences).\r\n\r\nThe visual that fences connect strangely needs to be fixed in\r\ncontent_mapblock.cpp, something that can easily be done."},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/164967584","html_url":"https://github.com/minetest/minetest_game/pull/743#issuecomment-164967584","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/743","id":164967584,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T02:35:17Z","updated_at":"2015-12-16T02:35:17Z","body":":+1: But i think for consistency the names should be:\r\ndefault:stick_acacia_wood\r\ndefault:stick_pine_wood\r\nSince 'stick' should come first.\r\n\r\ndefault:fence_acacia_wood\r\ndefault:fence_pine_wood\r\nSince we already have fence_wood and you are adding fence_junglewood."}}