{"action":"created","issue":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/668","labels_url":"https://api.github.com/repos/ratpack/ratpack/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/ratpack/ratpack/issues/668/comments","events_url":"https://api.github.com/repos/ratpack/ratpack/issues/668/events","html_url":"https://github.com/ratpack/ratpack/issues/668","id":73294729,"number":668,"title":"Pac4j documentation","user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ratpack/ratpack/milestones/20","html_url":"https://github.com/ratpack/ratpack/milestones/pre-1.0","labels_url":"https://api.github.com/repos/ratpack/ratpack/milestones/20/labels","id":1139556,"number":20,"title":"pre-1.0","description":"","creator":{"login":"alkemist","id":17825,"avatar_url":"https://avatars.githubusercontent.com/u/17825?v=3","gravatar_id":"","url":"https://api.github.com/users/alkemist","html_url":"https://github.com/alkemist","followers_url":"https://api.github.com/users/alkemist/followers","following_url":"https://api.github.com/users/alkemist/following{/other_user}","gists_url":"https://api.github.com/users/alkemist/gists{/gist_id}","starred_url":"https://api.github.com/users/alkemist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alkemist/subscriptions","organizations_url":"https://api.github.com/users/alkemist/orgs","repos_url":"https://api.github.com/users/alkemist/repos","events_url":"https://api.github.com/users/alkemist/events{/privacy}","received_events_url":"https://api.github.com/users/alkemist/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":0,"state":"open","created_at":"2015-05-29T09:01:57Z","updated_at":"2015-06-02T00:40:14Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2015-05-05T11:50:23Z","updated_at":"2015-06-02T11:37:13Z","closed_at":null,"body":"Hi,\r\n\r\n`ratpack-pac4j` is a module which handles authentication on various providers: it deserves a documentation.\r\nWhere do you want me to put the chapter on this topic? As chapter 18 or 36?\r\nThanks.\r\nBest regards,\r\nJérôme\r\n"},"comment":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/comments/107924182","html_url":"https://github.com/ratpack/ratpack/issues/668#issuecomment-107924182","issue_url":"https://api.github.com/repos/ratpack/ratpack/issues/668","id":107924182,"user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T11:37:13Z","updated_at":"2015-06-02T11:37:13Z","body":"In fact, you already use the `Clients` class internally: https://github.com/ratpack/ratpack/blob/master/ratpack-pac4j/src/main/java/ratpack/pac4j/internal/Pac4jCallbackHandler.java#L59\r\n\r\nGenerally, libraries let users create explicitely the `Clients` configuration.\r\n\r\nThe `Clients` are retrieved from the context (https://github.com/ratpack/ratpack/blob/master/ratpack-pac4j/src/main/java/ratpack/pac4j/internal/Pac4jAuthenticationHandler.java#L60, I'm not sure how they are stored in it), so in case of two callback endpoints (CAS proxies for example), I fear that it won't work because one `Clients` will erase the other `Clients`..."}}