{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/2919","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/2919/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2919/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/2919/events","html_url":"https://github.com/dotnet/roslyn/pull/2919","id":78238871,"number":2919,"title":"remove disposal logic from recoverable tree and text","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-19T20:26:50Z","updated_at":"2015-05-19T22:57:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2919","html_url":"https://github.com/dotnet/roslyn/pull/2919","diff_url":"https://github.com/dotnet/roslyn/pull/2919.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2919.patch"},"body":"Fixes #2832 \r\n\r\nThis change removed the code that was added to ensure that temporary storage gets explicitly disposed. The original change assumed that recoverable text and trees are only ever recovered once, but the truth is that they can be (and are intended to be) recovered multiple times, as once the recoverable item is stored in temporary storage, the lifetime of the data it owns is governed by the cache system and the runtime GC (via weak reference), so it can get recovered after GC more than once.\r\n\r\n@pharring @mavasani @Pilchie @jasonmalinowski please review."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/103691273","html_url":"https://github.com/dotnet/roslyn/pull/2919#issuecomment-103691273","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2919","id":103691273,"user":{"login":"pharring","id":9952654,"avatar_url":"https://avatars.githubusercontent.com/u/9952654?v=3","gravatar_id":"","url":"https://api.github.com/users/pharring","html_url":"https://github.com/pharring","followers_url":"https://api.github.com/users/pharring/followers","following_url":"https://api.github.com/users/pharring/following{/other_user}","gists_url":"https://api.github.com/users/pharring/gists{/gist_id}","starred_url":"https://api.github.com/users/pharring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharring/subscriptions","organizations_url":"https://api.github.com/users/pharring/orgs","repos_url":"https://api.github.com/users/pharring/repos","events_url":"https://api.github.com/users/pharring/events{/privacy}","received_events_url":"https://api.github.com/users/pharring/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T22:57:12Z","updated_at":"2015-05-19T22:57:12Z","body":":+1:\r\n(Needs to be ported to the stable branch)"}}