{"action":"opened","number":50,"pull_request":{"url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/50","id":47049255,"html_url":"https://github.com/mudassir0909/jsonresume-theme-elegant/pull/50","diff_url":"https://github.com/mudassir0909/jsonresume-theme-elegant/pull/50.diff","patch_url":"https://github.com/mudassir0909/jsonresume-theme-elegant/pull/50.patch","issue_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues/50","number":50,"state":"open","locked":false,"title":"Remove floating-nav items for existing but empty objects","user":{"login":"melo0187","id":2528018,"avatar_url":"https://avatars.githubusercontent.com/u/2528018?v=3","gravatar_id":"","url":"https://api.github.com/users/melo0187","html_url":"https://github.com/melo0187","followers_url":"https://api.github.com/users/melo0187/followers","following_url":"https://api.github.com/users/melo0187/following{/other_user}","gists_url":"https://api.github.com/users/melo0187/gists{/gist_id}","starred_url":"https://api.github.com/users/melo0187/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melo0187/subscriptions","organizations_url":"https://api.github.com/users/melo0187/orgs","repos_url":"https://api.github.com/users/melo0187/repos","events_url":"https://api.github.com/users/melo0187/events{/privacy}","received_events_url":"https://api.github.com/users/melo0187/received_events","type":"User","site_admin":false},"body":"As I wrote in #49 the floating-nav can contain items for sections that are not rendered because in fact the properties are just there in the json file but without any content.\r\n\r\nMaybe adding the isEmpty check is a good idea because it is more flexible? \r\nIn the end it does remove floating-nav items in both cases (property non existing or property is there but empty, like `\"awards\": []`) so that the floating-nav will always match the actual document.","created_at":"2015-10-07T16:21:17Z","updated_at":"2015-10-07T16:21:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/50/commits","review_comments_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/50/comments","review_comment_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues/50/comments","statuses_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/statuses/3396038e82b6e599de8d072901c8ce30cfc84824","head":{"label":"melo0187:enhance/floating-nav","ref":"enhance/floating-nav","sha":"3396038e82b6e599de8d072901c8ce30cfc84824","user":{"login":"melo0187","id":2528018,"avatar_url":"https://avatars.githubusercontent.com/u/2528018?v=3","gravatar_id":"","url":"https://api.github.com/users/melo0187","html_url":"https://github.com/melo0187","followers_url":"https://api.github.com/users/melo0187/followers","following_url":"https://api.github.com/users/melo0187/following{/other_user}","gists_url":"https://api.github.com/users/melo0187/gists{/gist_id}","starred_url":"https://api.github.com/users/melo0187/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melo0187/subscriptions","organizations_url":"https://api.github.com/users/melo0187/orgs","repos_url":"https://api.github.com/users/melo0187/repos","events_url":"https://api.github.com/users/melo0187/events{/privacy}","received_events_url":"https://api.github.com/users/melo0187/received_events","type":"User","site_admin":false},"repo":{"id":43810429,"name":"jsonresume-theme-elegant","full_name":"melo0187/jsonresume-theme-elegant","owner":{"login":"melo0187","id":2528018,"avatar_url":"https://avatars.githubusercontent.com/u/2528018?v=3","gravatar_id":"","url":"https://api.github.com/users/melo0187","html_url":"https://github.com/melo0187","followers_url":"https://api.github.com/users/melo0187/followers","following_url":"https://api.github.com/users/melo0187/following{/other_user}","gists_url":"https://api.github.com/users/melo0187/gists{/gist_id}","starred_url":"https://api.github.com/users/melo0187/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melo0187/subscriptions","organizations_url":"https://api.github.com/users/melo0187/orgs","repos_url":"https://api.github.com/users/melo0187/repos","events_url":"https://api.github.com/users/melo0187/events{/privacy}","received_events_url":"https://api.github.com/users/melo0187/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melo0187/jsonresume-theme-elegant","description":"Elegant theme for jsonresume","fork":true,"url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant","forks_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/forks","keys_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/teams","hooks_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/hooks","issue_events_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/issues/events{/number}","events_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/events","assignees_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/assignees{/user}","branches_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/branches{/branch}","tags_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/tags","blobs_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/git/refs{/sha}","trees_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/statuses/{sha}","languages_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/languages","stargazers_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/stargazers","contributors_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/contributors","subscribers_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/subscribers","subscription_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/subscription","commits_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/commits{/sha}","git_commits_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/git/commits{/sha}","comments_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/comments{/number}","issue_comment_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/issues/comments{/number}","contents_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/contents/{+path}","compare_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/merges","archive_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/downloads","issues_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/issues{/number}","pulls_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/pulls{/number}","milestones_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/milestones{/number}","notifications_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/labels{/name}","releases_url":"https://api.github.com/repos/melo0187/jsonresume-theme-elegant/releases{/id}","created_at":"2015-10-07T11:11:17Z","updated_at":"2015-10-07T11:11:18Z","pushed_at":"2015-10-07T16:14:59Z","git_url":"git://github.com/melo0187/jsonresume-theme-elegant.git","ssh_url":"git@github.com:melo0187/jsonresume-theme-elegant.git","clone_url":"https://github.com/melo0187/jsonresume-theme-elegant.git","svn_url":"https://github.com/melo0187/jsonresume-theme-elegant","homepage":"","size":1849,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mudassir0909:master","ref":"master","sha":"72fbb3fa37b0f4573f102ec469815c0dddd9965c","user":{"login":"mudassir0909","id":1861842,"avatar_url":"https://avatars.githubusercontent.com/u/1861842?v=3","gravatar_id":"","url":"https://api.github.com/users/mudassir0909","html_url":"https://github.com/mudassir0909","followers_url":"https://api.github.com/users/mudassir0909/followers","following_url":"https://api.github.com/users/mudassir0909/following{/other_user}","gists_url":"https://api.github.com/users/mudassir0909/gists{/gist_id}","starred_url":"https://api.github.com/users/mudassir0909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mudassir0909/subscriptions","organizations_url":"https://api.github.com/users/mudassir0909/orgs","repos_url":"https://api.github.com/users/mudassir0909/repos","events_url":"https://api.github.com/users/mudassir0909/events{/privacy}","received_events_url":"https://api.github.com/users/mudassir0909/received_events","type":"User","site_admin":false},"repo":{"id":21661815,"name":"jsonresume-theme-elegant","full_name":"mudassir0909/jsonresume-theme-elegant","owner":{"login":"mudassir0909","id":1861842,"avatar_url":"https://avatars.githubusercontent.com/u/1861842?v=3","gravatar_id":"","url":"https://api.github.com/users/mudassir0909","html_url":"https://github.com/mudassir0909","followers_url":"https://api.github.com/users/mudassir0909/followers","following_url":"https://api.github.com/users/mudassir0909/following{/other_user}","gists_url":"https://api.github.com/users/mudassir0909/gists{/gist_id}","starred_url":"https://api.github.com/users/mudassir0909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mudassir0909/subscriptions","organizations_url":"https://api.github.com/users/mudassir0909/orgs","repos_url":"https://api.github.com/users/mudassir0909/repos","events_url":"https://api.github.com/users/mudassir0909/events{/privacy}","received_events_url":"https://api.github.com/users/mudassir0909/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mudassir0909/jsonresume-theme-elegant","description":"Elegant theme for jsonresume","fork":false,"url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant","forks_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/forks","keys_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/teams","hooks_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/hooks","issue_events_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues/events{/number}","events_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/events","assignees_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/assignees{/user}","branches_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/branches{/branch}","tags_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/tags","blobs_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/git/refs{/sha}","trees_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/statuses/{sha}","languages_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/languages","stargazers_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/stargazers","contributors_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/contributors","subscribers_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/subscribers","subscription_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/subscription","commits_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/commits{/sha}","git_commits_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/git/commits{/sha}","comments_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/comments{/number}","issue_comment_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues/comments{/number}","contents_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/contents/{+path}","compare_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/merges","archive_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/downloads","issues_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues{/number}","pulls_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls{/number}","milestones_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/milestones{/number}","notifications_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/labels{/name}","releases_url":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/releases{/id}","created_at":"2014-07-09T17:27:54Z","updated_at":"2015-10-07T04:54:11Z","pushed_at":"2015-10-07T15:08:19Z","git_url":"git://github.com/mudassir0909/jsonresume-theme-elegant.git","ssh_url":"git@github.com:mudassir0909/jsonresume-theme-elegant.git","clone_url":"https://github.com/mudassir0909/jsonresume-theme-elegant.git","svn_url":"https://github.com/mudassir0909/jsonresume-theme-elegant","homepage":"","size":1849,"stargazers_count":28,"watchers_count":28,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":6,"forks":42,"open_issues":6,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/50"},"html":{"href":"https://github.com/mudassir0909/jsonresume-theme-elegant/pull/50"},"issue":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues/50"},"comments":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/mudassir0909/jsonresume-theme-elegant/statuses/3396038e82b6e599de8d072901c8ce30cfc84824"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}