{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/42359251","id":42359251,"diff_hunk":"@@ -0,0 +1,136 @@\n+# Secure Storage In OP-TEE\n+\n+## Background\n+\n+Secure Storage (SST) in OP-TEE is implemented according to what has been defined\n+in GloblaPlatform’s TEE Internal API specification (here called Trusted\n+Storage). This specification mandates that it should be possible to store\n+general-purpose data and key material that guarantees confidentiality and\n+integrity of the data stored and the atomicity of the operations that modifies\n+the storage (atomicity here means that either the entire operation completes\n+successfully or no write is done).\n+\n+## Overview\n+\n+![Secure Storage System Architecture](images/secure_storage/secure_storage_system_architecture.png","path":"documentation/secure_storage.md","position":15,"original_position":15,"commit_id":"d0802197672fd8ccf4036564c2e627b264a16ff2","original_commit_id":"d0802197672fd8ccf4036564c2e627b264a16ff2","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"body":"@jamescfkung yes, well, if we have a consensus on keeping the .png, then please add the .odg too.","created_at":"2015-10-19T11:12:29Z","updated_at":"2015-10-19T11:12:29Z","html_url":"https://github.com/OP-TEE/optee_os/pull/490#discussion_r42359251","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/42359251"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/490#discussion_r42359251"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490","id":47140773,"html_url":"https://github.com/OP-TEE/optee_os/pull/490","diff_url":"https://github.com/OP-TEE/optee_os/pull/490.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/490.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/490","number":490,"state":"open","locked":false,"title":"docs: Secure Storage Documentation","user":{"login":"jamescfkung","id":10397509,"avatar_url":"https://avatars.githubusercontent.com/u/10397509?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescfkung","html_url":"https://github.com/jamescfkung","followers_url":"https://api.github.com/users/jamescfkung/followers","following_url":"https://api.github.com/users/jamescfkung/following{/other_user}","gists_url":"https://api.github.com/users/jamescfkung/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescfkung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescfkung/subscriptions","organizations_url":"https://api.github.com/users/jamescfkung/orgs","repos_url":"https://api.github.com/users/jamescfkung/repos","events_url":"https://api.github.com/users/jamescfkung/events{/privacy}","received_events_url":"https://api.github.com/users/jamescfkung/received_events","type":"User","site_admin":false},"body":"Signed-off-by: James Kung <james.kung@linaro.org>","created_at":"2015-10-08T11:26:21Z","updated_at":"2015-10-19T11:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d799f7cdc178886603148726622c450e0458ebbf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/490/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/d0802197672fd8ccf4036564c2e627b264a16ff2","head":{"label":"jamescfkung:ss_doc","ref":"ss_doc","sha":"d0802197672fd8ccf4036564c2e627b264a16ff2","user":{"login":"jamescfkung","id":10397509,"avatar_url":"https://avatars.githubusercontent.com/u/10397509?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescfkung","html_url":"https://github.com/jamescfkung","followers_url":"https://api.github.com/users/jamescfkung/followers","following_url":"https://api.github.com/users/jamescfkung/following{/other_user}","gists_url":"https://api.github.com/users/jamescfkung/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescfkung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescfkung/subscriptions","organizations_url":"https://api.github.com/users/jamescfkung/orgs","repos_url":"https://api.github.com/users/jamescfkung/repos","events_url":"https://api.github.com/users/jamescfkung/events{/privacy}","received_events_url":"https://api.github.com/users/jamescfkung/received_events","type":"User","site_admin":false},"repo":{"id":31949420,"name":"optee_os","full_name":"jamescfkung/optee_os","owner":{"login":"jamescfkung","id":10397509,"avatar_url":"https://avatars.githubusercontent.com/u/10397509?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescfkung","html_url":"https://github.com/jamescfkung","followers_url":"https://api.github.com/users/jamescfkung/followers","following_url":"https://api.github.com/users/jamescfkung/following{/other_user}","gists_url":"https://api.github.com/users/jamescfkung/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescfkung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescfkung/subscriptions","organizations_url":"https://api.github.com/users/jamescfkung/orgs","repos_url":"https://api.github.com/users/jamescfkung/repos","events_url":"https://api.github.com/users/jamescfkung/events{/privacy}","received_events_url":"https://api.github.com/users/jamescfkung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamescfkung/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/jamescfkung/optee_os","forks_url":"https://api.github.com/repos/jamescfkung/optee_os/forks","keys_url":"https://api.github.com/repos/jamescfkung/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamescfkung/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamescfkung/optee_os/teams","hooks_url":"https://api.github.com/repos/jamescfkung/optee_os/hooks","issue_events_url":"https://api.github.com/repos/jamescfkung/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/jamescfkung/optee_os/events","assignees_url":"https://api.github.com/repos/jamescfkung/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/jamescfkung/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/jamescfkung/optee_os/tags","blobs_url":"https://api.github.com/repos/jamescfkung/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamescfkung/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamescfkung/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamescfkung/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamescfkung/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/jamescfkung/optee_os/languages","stargazers_url":"https://api.github.com/repos/jamescfkung/optee_os/stargazers","contributors_url":"https://api.github.com/repos/jamescfkung/optee_os/contributors","subscribers_url":"https://api.github.com/repos/jamescfkung/optee_os/subscribers","subscription_url":"https://api.github.com/repos/jamescfkung/optee_os/subscription","commits_url":"https://api.github.com/repos/jamescfkung/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamescfkung/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamescfkung/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamescfkung/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamescfkung/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/jamescfkung/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamescfkung/optee_os/merges","archive_url":"https://api.github.com/repos/jamescfkung/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamescfkung/optee_os/downloads","issues_url":"https://api.github.com/repos/jamescfkung/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/jamescfkung/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/jamescfkung/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/jamescfkung/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamescfkung/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/jamescfkung/optee_os/releases{/id}","created_at":"2015-03-10T09:42:01Z","updated_at":"2015-04-16T03:06:45Z","pushed_at":"2015-10-12T02:34:10Z","git_url":"git://github.com/jamescfkung/optee_os.git","ssh_url":"git@github.com:jamescfkung/optee_os.git","clone_url":"https://github.com/jamescfkung/optee_os.git","svn_url":"https://github.com/jamescfkung/optee_os","homepage":null,"size":6469,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"9542214673e9d48f34c0ae21951143005fca08b7","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-10-15T13:18:18Z","pushed_at":"2015-10-19T09:38:55Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":10635,"stargazers_count":68,"watchers_count":68,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":16,"forks":66,"open_issues":16,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/490"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/490"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/d0802197672fd8ccf4036564c2e627b264a16ff2"}}}}