{"action":"created","comment":{"url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/comments/28174835","id":28174835,"diff_hunk":"@@ -13,13 +13,23 @@ KEYMASTER=\"docker run --volume ${ROOT}/certificates:/certificates --rm cloudpipe\n if [ ! -f \"${ROOT}/certificates/password\" ]; then\n   echo \">> creating a random password in ${ROOT}/certificates/password.\"\n   touch ${ROOT}/certificates/password\n-  chmod 600 ${ROOT}/certificates/password\n+  chmod 640 ${ROOT}/certificates/password\n   # \"If the same pathname argument is supplied to -passin and -passout arguments then the first\n   # line will be used for the input password and the next line for the output password.\"\n-  cat /dev/random | head -c 128 | base64 > ${ROOT}/certificates/password\n+  cat /dev/urandom | head -c 128 | base64 > ${ROOT}/certificates/password","path":"script/genkeys","position":9,"original_position":9,"commit_id":"d2527a5f2d698ded16b474cc0245a3436bda80cb","original_commit_id":"d2527a5f2d698ded16b474cc0245a3436bda80cb","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"body":"> You do realize that's the same document I referenced in my commit message? :)\r\n\r\nWow, that's rich. I did not look at your full commit message. :D We're in tune there then.\r\n\r\nThe reason I err on the side of `/dev/random` is the fear that people are going to launch it directly with the dev setup and leave it running anyway.\r\n\r\nWith all that being said, I agree with your sentiments and will definitely merge this as is.\r\n\r\nThank you again.","created_at":"2015-04-10T19:50:33Z","updated_at":"2015-04-10T19:50:33Z","html_url":"https://github.com/cloudpipe/cloudpipe/pull/72#discussion_r28174835","pull_request_url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/comments/28174835"},"html":{"href":"https://github.com/cloudpipe/cloudpipe/pull/72#discussion_r28174835"},"pull_request":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72","id":32980762,"html_url":"https://github.com/cloudpipe/cloudpipe/pull/72","diff_url":"https://github.com/cloudpipe/cloudpipe/pull/72.diff","patch_url":"https://github.com/cloudpipe/cloudpipe/pull/72.patch","issue_url":"https://api.github.com/repos/cloudpipe/cloudpipe/issues/72","number":72,"state":"open","locked":false,"title":"Fix UID agreement with cloudpipe/keymaster.","user":{"login":"kainz","id":214291,"avatar_url":"https://avatars.githubusercontent.com/u/214291?v=3","gravatar_id":"","url":"https://api.github.com/users/kainz","html_url":"https://github.com/kainz","followers_url":"https://api.github.com/users/kainz/followers","following_url":"https://api.github.com/users/kainz/following{/other_user}","gists_url":"https://api.github.com/users/kainz/gists{/gist_id}","starred_url":"https://api.github.com/users/kainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kainz/subscriptions","organizations_url":"https://api.github.com/users/kainz/orgs","repos_url":"https://api.github.com/users/kainz/repos","events_url":"https://api.github.com/users/kainz/events{/privacy}","received_events_url":"https://api.github.com/users/kainz/received_events","type":"User","site_admin":false},"body":"Fixup genkeys so it works if you are not using UID=$uid_of_keymaster_images_user on your local machine.","created_at":"2015-04-09T18:06:23Z","updated_at":"2015-04-10T19:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c08f7ace02b2c937502e11d22f24074ed00edf1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72/commits","review_comments_url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72/comments","review_comment_url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudpipe/cloudpipe/issues/72/comments","statuses_url":"https://api.github.com/repos/cloudpipe/cloudpipe/statuses/d2527a5f2d698ded16b474cc0245a3436bda80cb","head":{"label":"kainz:master","ref":"master","sha":"d2527a5f2d698ded16b474cc0245a3436bda80cb","user":{"login":"kainz","id":214291,"avatar_url":"https://avatars.githubusercontent.com/u/214291?v=3","gravatar_id":"","url":"https://api.github.com/users/kainz","html_url":"https://github.com/kainz","followers_url":"https://api.github.com/users/kainz/followers","following_url":"https://api.github.com/users/kainz/following{/other_user}","gists_url":"https://api.github.com/users/kainz/gists{/gist_id}","starred_url":"https://api.github.com/users/kainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kainz/subscriptions","organizations_url":"https://api.github.com/users/kainz/orgs","repos_url":"https://api.github.com/users/kainz/repos","events_url":"https://api.github.com/users/kainz/events{/privacy}","received_events_url":"https://api.github.com/users/kainz/received_events","type":"User","site_admin":false},"repo":{"id":33683323,"name":"cloudpipe","full_name":"kainz/cloudpipe","owner":{"login":"kainz","id":214291,"avatar_url":"https://avatars.githubusercontent.com/u/214291?v=3","gravatar_id":"","url":"https://api.github.com/users/kainz","html_url":"https://github.com/kainz","followers_url":"https://api.github.com/users/kainz/followers","following_url":"https://api.github.com/users/kainz/following{/other_user}","gists_url":"https://api.github.com/users/kainz/gists{/gist_id}","starred_url":"https://api.github.com/users/kainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kainz/subscriptions","organizations_url":"https://api.github.com/users/kainz/orgs","repos_url":"https://api.github.com/users/kainz/repos","events_url":"https://api.github.com/users/kainz/events{/privacy}","received_events_url":"https://api.github.com/users/kainz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kainz/cloudpipe","description":":wrench: Compute on demand in Docker containers","fork":true,"url":"https://api.github.com/repos/kainz/cloudpipe","forks_url":"https://api.github.com/repos/kainz/cloudpipe/forks","keys_url":"https://api.github.com/repos/kainz/cloudpipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kainz/cloudpipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kainz/cloudpipe/teams","hooks_url":"https://api.github.com/repos/kainz/cloudpipe/hooks","issue_events_url":"https://api.github.com/repos/kainz/cloudpipe/issues/events{/number}","events_url":"https://api.github.com/repos/kainz/cloudpipe/events","assignees_url":"https://api.github.com/repos/kainz/cloudpipe/assignees{/user}","branches_url":"https://api.github.com/repos/kainz/cloudpipe/branches{/branch}","tags_url":"https://api.github.com/repos/kainz/cloudpipe/tags","blobs_url":"https://api.github.com/repos/kainz/cloudpipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kainz/cloudpipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kainz/cloudpipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/kainz/cloudpipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kainz/cloudpipe/statuses/{sha}","languages_url":"https://api.github.com/repos/kainz/cloudpipe/languages","stargazers_url":"https://api.github.com/repos/kainz/cloudpipe/stargazers","contributors_url":"https://api.github.com/repos/kainz/cloudpipe/contributors","subscribers_url":"https://api.github.com/repos/kainz/cloudpipe/subscribers","subscription_url":"https://api.github.com/repos/kainz/cloudpipe/subscription","commits_url":"https://api.github.com/repos/kainz/cloudpipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/kainz/cloudpipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/kainz/cloudpipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/kainz/cloudpipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/kainz/cloudpipe/contents/{+path}","compare_url":"https://api.github.com/repos/kainz/cloudpipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kainz/cloudpipe/merges","archive_url":"https://api.github.com/repos/kainz/cloudpipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kainz/cloudpipe/downloads","issues_url":"https://api.github.com/repos/kainz/cloudpipe/issues{/number}","pulls_url":"https://api.github.com/repos/kainz/cloudpipe/pulls{/number}","milestones_url":"https://api.github.com/repos/kainz/cloudpipe/milestones{/number}","notifications_url":"https://api.github.com/repos/kainz/cloudpipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kainz/cloudpipe/labels{/name}","releases_url":"https://api.github.com/repos/kainz/cloudpipe/releases{/id}","created_at":"2015-04-09T17:42:46Z","updated_at":"2015-04-09T18:05:12Z","pushed_at":"2015-04-09T18:05:11Z","git_url":"git://github.com/kainz/cloudpipe.git","ssh_url":"git@github.com:kainz/cloudpipe.git","clone_url":"https://github.com/kainz/cloudpipe.git","svn_url":"https://github.com/kainz/cloudpipe","homepage":"","size":1457,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudpipe:master","ref":"master","sha":"4b365c171e23ad84bd2d7f3deb51c638677708a4","user":{"login":"cloudpipe","id":10352495,"avatar_url":"https://avatars.githubusercontent.com/u/10352495?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudpipe","html_url":"https://github.com/cloudpipe","followers_url":"https://api.github.com/users/cloudpipe/followers","following_url":"https://api.github.com/users/cloudpipe/following{/other_user}","gists_url":"https://api.github.com/users/cloudpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudpipe/subscriptions","organizations_url":"https://api.github.com/users/cloudpipe/orgs","repos_url":"https://api.github.com/users/cloudpipe/repos","events_url":"https://api.github.com/users/cloudpipe/events{/privacy}","received_events_url":"https://api.github.com/users/cloudpipe/received_events","type":"Organization","site_admin":false},"repo":{"id":27835647,"name":"cloudpipe","full_name":"cloudpipe/cloudpipe","owner":{"login":"cloudpipe","id":10352495,"avatar_url":"https://avatars.githubusercontent.com/u/10352495?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudpipe","html_url":"https://github.com/cloudpipe","followers_url":"https://api.github.com/users/cloudpipe/followers","following_url":"https://api.github.com/users/cloudpipe/following{/other_user}","gists_url":"https://api.github.com/users/cloudpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudpipe/subscriptions","organizations_url":"https://api.github.com/users/cloudpipe/orgs","repos_url":"https://api.github.com/users/cloudpipe/repos","events_url":"https://api.github.com/users/cloudpipe/events{/privacy}","received_events_url":"https://api.github.com/users/cloudpipe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudpipe/cloudpipe","description":":wrench: Compute on demand in Docker containers","fork":false,"url":"https://api.github.com/repos/cloudpipe/cloudpipe","forks_url":"https://api.github.com/repos/cloudpipe/cloudpipe/forks","keys_url":"https://api.github.com/repos/cloudpipe/cloudpipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudpipe/cloudpipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudpipe/cloudpipe/teams","hooks_url":"https://api.github.com/repos/cloudpipe/cloudpipe/hooks","issue_events_url":"https://api.github.com/repos/cloudpipe/cloudpipe/issues/events{/number}","events_url":"https://api.github.com/repos/cloudpipe/cloudpipe/events","assignees_url":"https://api.github.com/repos/cloudpipe/cloudpipe/assignees{/user}","branches_url":"https://api.github.com/repos/cloudpipe/cloudpipe/branches{/branch}","tags_url":"https://api.github.com/repos/cloudpipe/cloudpipe/tags","blobs_url":"https://api.github.com/repos/cloudpipe/cloudpipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudpipe/cloudpipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudpipe/cloudpipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudpipe/cloudpipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudpipe/cloudpipe/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudpipe/cloudpipe/languages","stargazers_url":"https://api.github.com/repos/cloudpipe/cloudpipe/stargazers","contributors_url":"https://api.github.com/repos/cloudpipe/cloudpipe/contributors","subscribers_url":"https://api.github.com/repos/cloudpipe/cloudpipe/subscribers","subscription_url":"https://api.github.com/repos/cloudpipe/cloudpipe/subscription","commits_url":"https://api.github.com/repos/cloudpipe/cloudpipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudpipe/cloudpipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudpipe/cloudpipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudpipe/cloudpipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudpipe/cloudpipe/contents/{+path}","compare_url":"https://api.github.com/repos/cloudpipe/cloudpipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudpipe/cloudpipe/merges","archive_url":"https://api.github.com/repos/cloudpipe/cloudpipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudpipe/cloudpipe/downloads","issues_url":"https://api.github.com/repos/cloudpipe/cloudpipe/issues{/number}","pulls_url":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudpipe/cloudpipe/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudpipe/cloudpipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudpipe/cloudpipe/labels{/name}","releases_url":"https://api.github.com/repos/cloudpipe/cloudpipe/releases{/id}","created_at":"2014-12-10T19:22:42Z","updated_at":"2015-04-09T15:54:47Z","pushed_at":"2015-04-09T18:06:24Z","git_url":"git://github.com/cloudpipe/cloudpipe.git","ssh_url":"git@github.com:cloudpipe/cloudpipe.git","clone_url":"https://github.com/cloudpipe/cloudpipe.git","svn_url":"https://github.com/cloudpipe/cloudpipe","homepage":"","size":1457,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":23,"forks":8,"open_issues":23,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72"},"html":{"href":"https://github.com/cloudpipe/cloudpipe/pull/72"},"issue":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/issues/72"},"comments":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/cloudpipe/cloudpipe/statuses/d2527a5f2d698ded16b474cc0245a3436bda80cb"}}}}