{"action":"created","issue":{"url":"https://api.github.com/repos/cms-dev/cms/issues/506","labels_url":"https://api.github.com/repos/cms-dev/cms/issues/506/labels{/name}","comments_url":"https://api.github.com/repos/cms-dev/cms/issues/506/comments","events_url":"https://api.github.com/repos/cms-dev/cms/issues/506/events","html_url":"https://github.com/cms-dev/cms/pull/506","id":121890752,"number":506,"title":"Quick fix to support changing what version of python to use","user":{"login":"wil93","id":1285361,"avatar_url":"https://avatars.githubusercontent.com/u/1285361?v=3","gravatar_id":"","url":"https://api.github.com/users/wil93","html_url":"https://github.com/wil93","followers_url":"https://api.github.com/users/wil93/followers","following_url":"https://api.github.com/users/wil93/following{/other_user}","gists_url":"https://api.github.com/users/wil93/gists{/gist_id}","starred_url":"https://api.github.com/users/wil93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wil93/subscriptions","organizations_url":"https://api.github.com/users/wil93/orgs","repos_url":"https://api.github.com/users/wil93/repos","events_url":"https://api.github.com/users/wil93/events{/privacy}","received_events_url":"https://api.github.com/users/wil93/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-13T01:11:50Z","updated_at":"2015-12-15T10:59:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-dev/cms/pulls/506","html_url":"https://github.com/cms-dev/cms/pull/506","diff_url":"https://github.com/cms-dev/cms/pull/506.diff","patch_url":"https://github.com/cms-dev/cms/pull/506.patch"},"body":"I know that we should look into making compilers \"separate\" from CMS (with a plugin system). In the meantime, though, I think it's good to have a simple way to switch the python version used when evaluating python submissions.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cms-dev/cms/506)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cms-dev/cms/issues/comments/164727996","html_url":"https://github.com/cms-dev/cms/pull/506#issuecomment-164727996","issue_url":"https://api.github.com/repos/cms-dev/cms/issues/506","id":164727996,"user":{"login":"stefano-maggiolo","id":485490,"avatar_url":"https://avatars.githubusercontent.com/u/485490?v=3","gravatar_id":"","url":"https://api.github.com/users/stefano-maggiolo","html_url":"https://github.com/stefano-maggiolo","followers_url":"https://api.github.com/users/stefano-maggiolo/followers","following_url":"https://api.github.com/users/stefano-maggiolo/following{/other_user}","gists_url":"https://api.github.com/users/stefano-maggiolo/gists{/gist_id}","starred_url":"https://api.github.com/users/stefano-maggiolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefano-maggiolo/subscriptions","organizations_url":"https://api.github.com/users/stefano-maggiolo/orgs","repos_url":"https://api.github.com/users/stefano-maggiolo/repos","events_url":"https://api.github.com/users/stefano-maggiolo/events{/privacy}","received_events_url":"https://api.github.com/users/stefano-maggiolo/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T10:59:12Z","updated_at":"2015-12-15T10:59:12Z","body":"Thanks for doing this, indeed I don't think we'll get around to change to a plugin system before 1.3. Do you see a good place where to document this new feature?\n\n---\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[cms/grading/__init__.py, line 250 \\[r1\\]](https://reviewable.io:443/reviews/cms-dev/cms/506#-K5_Gi4cHrjavaCxDmnP:-K5_Gi4cHrjavaCxDmnQ:-116978710) ([raw file](https://github.com/cms-dev/cms/blob/6cc94e21572ed61560eec2c8e68122853a517e7f/cms/grading/__init__.py#L250)):*\nCan we not depend on the specific string \"cpython-34\", which I assume means python 3.4? https://www.python.org/dev/peps/pep-3147/#proposal suggests that that string identifies the version and I think it can be treated as an opaque id.\n\n---\n\n*[cms/grading/__init__.py, line 254 \\[r1\\]](https://reviewable.io:443/reviews/cms-dev/cms/506#-K5_GaelXB13xvjCe9o6:-K5_GaelXB13xvjCe9o7:369948937) ([raw file](https://github.com/cms-dev/cms/blob/6cc94e21572ed61560eec2c8e68122853a517e7f/cms/grading/__init__.py#L254)):*\nIt would be cleaner to extract the basename and apply it immediately to both pyc_name\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cms-dev/cms/506#-:-K5_HYlI6vJ-MziQjszU:-323640886)*\n<!-- Sent from Reviewable.io -->\n"}}