{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments/22778895","id":22778895,"diff_hunk":"@@ -41,7 +41,7 @@\n   foreman_proxy::settings_file { 'tftp': }\n   foreman_proxy::settings_file { 'realm': }\n \n-  if $foreman_proxy::puppetca or $foreman_proxy::puppetrun {\n+  if $foreman_proxy::puppetca or $foreman_proxy::puppetrun or tagged('foreman_proxy::plugin::salt') {","path":"manifests/config.pp","position":5,"original_position":5,"commit_id":"dbc217df32d8902656a0f089bf54729469b3db4f","original_commit_id":"dbc217df32d8902656a0f089bf54729469b3db4f","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"That's only going to work if the salt class was parsed before this one, it's not reliable.","created_at":"2015-01-12T08:43:34Z","updated_at":"2015-01-12T08:43:34Z","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/135#discussion_r22778895","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments/22778895"},"html":{"href":"https://github.com/theforeman/puppet-foreman_proxy/pull/135#discussion_r22778895"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135","id":27042380,"html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/135","diff_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/135.diff","patch_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/135.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/135","number":135,"state":"open","locked":false,"title":"fixes #8875- support installation/configuration of smart_proxy_salt","user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"body":"Configures the Smart Proxy plugin.  If https://github.com/theforeman/puppet-foreman_proxy/pull/122 will be merged soon, I'd like to include the sudo rules for salt here as well.","created_at":"2015-01-08T16:58:49Z","updated_at":"2015-01-12T08:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"916c0b1594908a23275bf9f9d6a700c3ff12eb20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/135/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/statuses/dbc217df32d8902656a0f089bf54729469b3db4f","head":{"label":"stbenjam:salt","ref":"salt","sha":"dbc217df32d8902656a0f089bf54729469b3db4f","user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"repo":{"id":28974991,"name":"puppet-foreman_proxy","full_name":"stbenjam/puppet-foreman_proxy","owner":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stbenjam/puppet-foreman_proxy","description":"Puppet module for Foreman Smart Proxy","fork":true,"url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy","forks_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/forks","keys_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/teams","hooks_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/hooks","issue_events_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/events","assignees_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/tags","blobs_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/languages","stargazers_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/stargazers","contributors_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/contributors","subscribers_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/subscribers","subscription_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/subscription","commits_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/merges","archive_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/downloads","issues_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/labels{/name}","releases_url":"https://api.github.com/repos/stbenjam/puppet-foreman_proxy/releases{/id}","created_at":"2015-01-08T16:35:38Z","updated_at":"2015-01-08T16:35:39Z","pushed_at":"2015-01-10T11:38:05Z","git_url":"git://github.com/stbenjam/puppet-foreman_proxy.git","ssh_url":"git@github.com:stbenjam/puppet-foreman_proxy.git","clone_url":"https://github.com/stbenjam/puppet-foreman_proxy.git","svn_url":"https://github.com/stbenjam/puppet-foreman_proxy","homepage":"","size":330,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"f1466bda81985a834a50b1acd7473b481d14b4e7","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449602,"name":"puppet-foreman_proxy","full_name":"theforeman/puppet-foreman_proxy","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-foreman_proxy","description":"Puppet module for Foreman Smart Proxy","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy","forks_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/releases{/id}","created_at":"2012-02-15T13:21:09Z","updated_at":"2015-01-09T08:52:37Z","pushed_at":"2015-01-09T08:52:36Z","git_url":"git://github.com/theforeman/puppet-foreman_proxy.git","ssh_url":"git@github.com:theforeman/puppet-foreman_proxy.git","clone_url":"https://github.com/theforeman/puppet-foreman_proxy.git","svn_url":"https://github.com/theforeman/puppet-foreman_proxy","homepage":"","size":1144,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":11,"forks":51,"open_issues":11,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135"},"html":{"href":"https://github.com/theforeman/puppet-foreman_proxy/pull/135"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/135"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/statuses/dbc217df32d8902656a0f089bf54729469b3db4f"}}}}