{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/26","id":41703221,"html_url":"https://github.com/puppetlabs/puppetlabs-mrepo/pull/26","diff_url":"https://github.com/puppetlabs/puppetlabs-mrepo/pull/26.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-mrepo/pull/26.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues/26","number":26,"state":"open","locked":false,"title":"only include the `ip` parameter in the apache vhost if $ip_based is true","user":{"login":"jearls","id":9756898,"avatar_url":"https://avatars.githubusercontent.com/u/9756898?v=3","gravatar_id":"","url":"https://api.github.com/users/jearls","html_url":"https://github.com/jearls","followers_url":"https://api.github.com/users/jearls/followers","following_url":"https://api.github.com/users/jearls/following{/other_user}","gists_url":"https://api.github.com/users/jearls/gists{/gist_id}","starred_url":"https://api.github.com/users/jearls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jearls/subscriptions","organizations_url":"https://api.github.com/users/jearls/orgs","repos_url":"https://api.github.com/users/jearls/repos","events_url":"https://api.github.com/users/jearls/events{/privacy}","received_events_url":"https://api.github.com/users/jearls/received_events","type":"User","site_admin":false},"body":"Assigning the `ip` parameter in the apache vhost resource when using the default apache configuration will fail, even if `ip_based` is false, because the apache module just looks at whether or not `ip` is assigned.  This PR makes it so the `ip` parameter only gets assigned when `ip_based` is true.","created_at":"2015-08-05T17:16:27Z","updated_at":"2015-08-05T17:16:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/26/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/26/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues/26/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/statuses/a8c9b391a00b804e6c9e87ca478631083a25b243","head":{"label":"jearls:only-assign-vhost-ip-if-ipbased-is-true","ref":"only-assign-vhost-ip-if-ipbased-is-true","sha":"a8c9b391a00b804e6c9e87ca478631083a25b243","user":{"login":"jearls","id":9756898,"avatar_url":"https://avatars.githubusercontent.com/u/9756898?v=3","gravatar_id":"","url":"https://api.github.com/users/jearls","html_url":"https://github.com/jearls","followers_url":"https://api.github.com/users/jearls/followers","following_url":"https://api.github.com/users/jearls/following{/other_user}","gists_url":"https://api.github.com/users/jearls/gists{/gist_id}","starred_url":"https://api.github.com/users/jearls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jearls/subscriptions","organizations_url":"https://api.github.com/users/jearls/orgs","repos_url":"https://api.github.com/users/jearls/repos","events_url":"https://api.github.com/users/jearls/events{/privacy}","received_events_url":"https://api.github.com/users/jearls/received_events","type":"User","site_admin":false},"repo":{"id":40258286,"name":"puppetlabs-mrepo","full_name":"jearls/puppetlabs-mrepo","owner":{"login":"jearls","id":9756898,"avatar_url":"https://avatars.githubusercontent.com/u/9756898?v=3","gravatar_id":"","url":"https://api.github.com/users/jearls","html_url":"https://github.com/jearls","followers_url":"https://api.github.com/users/jearls/followers","following_url":"https://api.github.com/users/jearls/following{/other_user}","gists_url":"https://api.github.com/users/jearls/gists{/gist_id}","starred_url":"https://api.github.com/users/jearls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jearls/subscriptions","organizations_url":"https://api.github.com/users/jearls/orgs","repos_url":"https://api.github.com/users/jearls/repos","events_url":"https://api.github.com/users/jearls/events{/privacy}","received_events_url":"https://api.github.com/users/jearls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jearls/puppetlabs-mrepo","description":"Puppet module for creating and managing RPM based repository mirrors.","fork":true,"url":"https://api.github.com/repos/jearls/puppetlabs-mrepo","forks_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/forks","keys_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/teams","hooks_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/hooks","issue_events_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/issues/events{/number}","events_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/events","assignees_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/assignees{/user}","branches_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/branches{/branch}","tags_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/tags","blobs_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/statuses/{sha}","languages_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/languages","stargazers_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/stargazers","contributors_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/contributors","subscribers_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/subscribers","subscription_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/subscription","commits_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/contents/{+path}","compare_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/merges","archive_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/downloads","issues_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/issues{/number}","pulls_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/pulls{/number}","milestones_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/milestones{/number}","notifications_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/labels{/name}","releases_url":"https://api.github.com/repos/jearls/puppetlabs-mrepo/releases{/id}","created_at":"2015-08-05T17:10:58Z","updated_at":"2015-08-05T17:10:59Z","pushed_at":"2015-08-05T17:12:45Z","git_url":"git://github.com/jearls/puppetlabs-mrepo.git","ssh_url":"git@github.com:jearls/puppetlabs-mrepo.git","clone_url":"https://github.com/jearls/puppetlabs-mrepo.git","svn_url":"https://github.com/jearls/puppetlabs-mrepo","homepage":"https://forge.puppetlabs.com/puppetlabs/mrepo","size":160,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"292bacd74001475ee9dccd431a9794deaa18bc30","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1969393,"name":"puppetlabs-mrepo","full_name":"puppetlabs/puppetlabs-mrepo","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-mrepo","description":"Puppet module for creating and managing RPM based repository mirrors.","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/releases{/id}","created_at":"2011-06-28T22:51:34Z","updated_at":"2015-04-21T09:22:01Z","pushed_at":"2015-07-20T11:12:05Z","git_url":"git://github.com/puppetlabs/puppetlabs-mrepo.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-mrepo.git","clone_url":"https://github.com/puppetlabs/puppetlabs-mrepo.git","svn_url":"https://github.com/puppetlabs/puppetlabs-mrepo","homepage":"https://forge.puppetlabs.com/puppetlabs/mrepo","size":305,"stargazers_count":19,"watchers_count":19,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":2,"forks":30,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/26"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-mrepo/pull/26"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues/26"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mrepo/statuses/a8c9b391a00b804e6c9e87ca478631083a25b243"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}