{"action":"created","comment":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/41884499","id":41884499,"diff_hunk":"@@ -79,6 +79,12 @@ class CParameterAccessContext : public CErrorContext\n     void setBaseOffset(size_t baseOffset);\n     size_t getBaseOffset() const;\n \n+protected:\n+    CParameterAccessContext(const utility::ErrorContext &other)\n+        : utility::ErrorContext(other)","path":"parameter/ParameterAccessContext.h","position":21,"original_position":21,"commit_id":"c813e916d9fc7256c745c20a46230b967e7f09ef","original_commit_id":"c813e916d9fc7256c745c20a46230b967e7f09ef","user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"body":"CParameterAccessContext(const utility::ErrorContext &other)\r\n     : utility::ErrorContext(other) {}","created_at":"2015-10-13T15:45:55Z","updated_at":"2015-10-13T15:45:55Z","html_url":"https://github.com/01org/parameter-framework/pull/278#discussion_r41884499","pull_request_url":"https://api.github.com/repos/01org/parameter-framework/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/41884499"},"html":{"href":"https://github.com/01org/parameter-framework/pull/278#discussion_r41884499"},"pull_request":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/278","id":47437731,"html_url":"https://github.com/01org/parameter-framework/pull/278","diff_url":"https://github.com/01org/parameter-framework/pull/278.diff","patch_url":"https://github.com/01org/parameter-framework/pull/278.patch","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/278","number":278,"state":"open","locked":false,"title":"Unify access contexts","user":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"body":"Various reworks that suppress some static_casts and const_casts.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/278%23issuecomment-147449369%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/278%23discussion_r41884079%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/278%23issuecomment-147449369%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40krocard%20and%20%40tcahuzax%20Please%20review%22%2C%20%22created_at%22%3A%20%222015-10-12T16%3A14%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20c813e916d9fc7256c745c20a46230b967e7f09ef%20parameter/Element.cpp%2025%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/278%23discussion_r41884079%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22why%20is%20it%20empty%20%3F%22%2C%20%22created_at%22%3A%20%222015-10-13T15%3A42%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/Element.cpp%3AL133-140%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/278#issuecomment-147449369'>General Comment</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> @krocard and @tcahuzax Please review\n- [ ] <a href='#crh-comment-Pull c813e916d9fc7256c745c20a46230b967e7f09ef parameter/Element.cpp 25'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/278#discussion_r41884079'>File: parameter/Element.cpp:L133-140</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> why is it empty ?\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/278?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/278?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/278'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-10-12T16:14:42Z","updated_at":"2015-10-13T15:45:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aecc32fad1f8d0234f3eba976c9735c271f23cd","assignee":null,"milestone":{"url":"https://api.github.com/repos/01org/parameter-framework/milestones/1","html_url":"https://github.com/01org/parameter-framework/milestones/Version%203","labels_url":"https://api.github.com/repos/01org/parameter-framework/milestones/1/labels","id":1143161,"number":1,"title":"Version 3","description":"Next major version. This will include C++11 support, logging rework and criterion rework.","creator":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":22,"state":"open","created_at":"2015-06-01T15:23:35Z","updated_at":"2015-10-13T15:33:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/01org/parameter-framework/pulls/278/commits","review_comments_url":"https://api.github.com/repos/01org/parameter-framework/pulls/278/comments","review_comment_url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/278/comments","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/c813e916d9fc7256c745c20a46230b967e7f09ef","head":{"label":"dawagner:unify-access-contexts","ref":"unify-access-contexts","sha":"c813e916d9fc7256c745c20a46230b967e7f09ef","user":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"repo":{"id":29674215,"name":"parameter-framework","full_name":"dawagner/parameter-framework","owner":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dawagner/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":true,"url":"https://api.github.com/repos/dawagner/parameter-framework","forks_url":"https://api.github.com/repos/dawagner/parameter-framework/forks","keys_url":"https://api.github.com/repos/dawagner/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dawagner/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dawagner/parameter-framework/teams","hooks_url":"https://api.github.com/repos/dawagner/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/dawagner/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/dawagner/parameter-framework/events","assignees_url":"https://api.github.com/repos/dawagner/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/dawagner/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/dawagner/parameter-framework/tags","blobs_url":"https://api.github.com/repos/dawagner/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dawagner/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dawagner/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dawagner/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dawagner/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/dawagner/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/dawagner/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/dawagner/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/dawagner/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/dawagner/parameter-framework/subscription","commits_url":"https://api.github.com/repos/dawagner/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dawagner/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dawagner/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dawagner/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dawagner/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/dawagner/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dawagner/parameter-framework/merges","archive_url":"https://api.github.com/repos/dawagner/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dawagner/parameter-framework/downloads","issues_url":"https://api.github.com/repos/dawagner/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/dawagner/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/dawagner/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/dawagner/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dawagner/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/dawagner/parameter-framework/releases{/id}","created_at":"2015-01-22T10:54:57Z","updated_at":"2015-04-24T08:50:14Z","pushed_at":"2015-10-13T15:33:12Z","git_url":"git://github.com/dawagner/parameter-framework.git","ssh_url":"git@github.com:dawagner/parameter-framework.git","clone_url":"https://github.com/dawagner/parameter-framework.git","svn_url":"https://github.com/dawagner/parameter-framework","homepage":"","size":37310,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"e4963cf0de796e743c8f47c8f3cf54747018a927","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16009363,"name":"parameter-framework","full_name":"01org/parameter-framework","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":false,"url":"https://api.github.com/repos/01org/parameter-framework","forks_url":"https://api.github.com/repos/01org/parameter-framework/forks","keys_url":"https://api.github.com/repos/01org/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/parameter-framework/teams","hooks_url":"https://api.github.com/repos/01org/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/01org/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/01org/parameter-framework/events","assignees_url":"https://api.github.com/repos/01org/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/01org/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/01org/parameter-framework/tags","blobs_url":"https://api.github.com/repos/01org/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/01org/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/01org/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/01org/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/01org/parameter-framework/subscription","commits_url":"https://api.github.com/repos/01org/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/01org/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/parameter-framework/merges","archive_url":"https://api.github.com/repos/01org/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/parameter-framework/downloads","issues_url":"https://api.github.com/repos/01org/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/01org/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/01org/parameter-framework/releases{/id}","created_at":"2014-01-17T19:24:01Z","updated_at":"2015-10-04T21:13:40Z","pushed_at":"2015-10-13T15:33:51Z","git_url":"git://github.com/01org/parameter-framework.git","ssh_url":"git@github.com:01org/parameter-framework.git","clone_url":"https://github.com/01org/parameter-framework.git","svn_url":"https://github.com/01org/parameter-framework","homepage":"","size":50059,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":32,"forks":23,"open_issues":32,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/278"},"html":{"href":"https://github.com/01org/parameter-framework/pull/278"},"issue":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/278"},"comments":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/01org/parameter-framework/statuses/c813e916d9fc7256c745c20a46230b967e7f09ef"}}}}