{"action":"created","issue":{"url":"https://api.github.com/repos/code-cracker/code-cracker/issues/337","labels_url":"https://api.github.com/repos/code-cracker/code-cracker/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/code-cracker/code-cracker/issues/337/comments","events_url":"https://api.github.com/repos/code-cracker/code-cracker/issues/337/events","html_url":"https://github.com/code-cracker/code-cracker/pull/337","id":75410994,"number":337,"title":"CC0056 Identify invalid format strings","user":{"login":"thorgeirk11","id":2693474,"avatar_url":"https://avatars.githubusercontent.com/u/2693474?v=3","gravatar_id":"","url":"https://api.github.com/users/thorgeirk11","html_url":"https://github.com/thorgeirk11","followers_url":"https://api.github.com/users/thorgeirk11/followers","following_url":"https://api.github.com/users/thorgeirk11/following{/other_user}","gists_url":"https://api.github.com/users/thorgeirk11/gists{/gist_id}","starred_url":"https://api.github.com/users/thorgeirk11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorgeirk11/subscriptions","organizations_url":"https://api.github.com/users/thorgeirk11/orgs","repos_url":"https://api.github.com/users/thorgeirk11/repos","events_url":"https://api.github.com/users/thorgeirk11/events{/privacy}","received_events_url":"https://api.github.com/users/thorgeirk11/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/code-cracker/code-cracker/labels/3%20-%20Done","name":"3 - Done","color":"CCCCCC"},{"url":"https://api.github.com/repos/code-cracker/code-cracker/labels/needs%20discussion","name":"needs discussion","color":"fbca04"}],"state":"closed","locked":false,"assignee":{"login":"giggio","id":334958,"avatar_url":"https://avatars.githubusercontent.com/u/334958?v=3","gravatar_id":"","url":"https://api.github.com/users/giggio","html_url":"https://github.com/giggio","followers_url":"https://api.github.com/users/giggio/followers","following_url":"https://api.github.com/users/giggio/following{/other_user}","gists_url":"https://api.github.com/users/giggio/gists{/gist_id}","starred_url":"https://api.github.com/users/giggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giggio/subscriptions","organizations_url":"https://api.github.com/users/giggio/orgs","repos_url":"https://api.github.com/users/giggio/repos","events_url":"https://api.github.com/users/giggio/events{/privacy}","received_events_url":"https://api.github.com/users/giggio/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-05-12T00:58:25Z","updated_at":"2015-05-12T20:13:31Z","closed_at":"2015-05-12T20:08:48Z","pull_request":{"url":"https://api.github.com/repos/code-cracker/code-cracker/pulls/337","html_url":"https://github.com/code-cracker/code-cracker/pull/337","diff_url":"https://github.com/code-cracker/code-cracker/pull/337.diff","patch_url":"https://github.com/code-cracker/code-cracker/pull/337.patch"},"body":"Discussed in #335, I have extended the StringFormatArgsAnalyzer to also identify invalid format strings."},"comment":{"url":"https://api.github.com/repos/code-cracker/code-cracker/issues/comments/101407112","html_url":"https://github.com/code-cracker/code-cracker/pull/337#issuecomment-101407112","issue_url":"https://api.github.com/repos/code-cracker/code-cracker/issues/337","id":101407112,"user":{"login":"giggio","id":334958,"avatar_url":"https://avatars.githubusercontent.com/u/334958?v=3","gravatar_id":"","url":"https://api.github.com/users/giggio","html_url":"https://github.com/giggio","followers_url":"https://api.github.com/users/giggio/followers","following_url":"https://api.github.com/users/giggio/following{/other_user}","gists_url":"https://api.github.com/users/giggio/gists{/gist_id}","starred_url":"https://api.github.com/users/giggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giggio/subscriptions","organizations_url":"https://api.github.com/users/giggio/orgs","repos_url":"https://api.github.com/users/giggio/repos","events_url":"https://api.github.com/users/giggio/events{/privacy}","received_events_url":"https://api.github.com/users/giggio/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T20:13:31Z","updated_at":"2015-05-12T20:13:31Z","body":"I have merged it but as the update works perfectly. I am just not sure that we should be using 2 different messages with the same diagnostic id. I am thinking we should use a different id.\r\n@code-cracker/owners please see that we have two rules with the same diagnostic id and different messages:\r\nhttps://github.com/code-cracker/code-cracker/blob/master/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs#L20-L38\r\n**Note:** Do you think that is ok or should we create a new id? I am leaning towards creating a new one.\r\nThere is no fix for the diagnostic generated by `StringFormatArgsAnalyzer`, so the impact would be minimal."}}