{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/37254366","id":37254366,"diff_hunk":"@@ -0,0 +1,185 @@\n+/*\n+ * Licensed to the University of California, Berkeley under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package tachyon.master.next.filesystem.meta;\n+\n+import org.junit.Assert;\n+import org.junit.Test;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import tachyon.Constants;\n+import tachyon.master.block.BlockId;\n+\n+/**\n+ * Unit tests for tachyon.InodeDirectory\n+ */\n+public final class InodeDirectoryTests {\n+  private static final Logger LOG = LoggerFactory.getLogger(Constants.LOGGER_TYPE);\n+\n+  @Test\n+  public void addChildrenTest() {\n+    InodeDirectory inodeDirectory = createInodeDirectory();\n+    InodeFile inodeFile1 = createInodeFile(2);\n+    InodeFile inodeFile2 = createInodeFile(3);\n+    inodeDirectory.addChild(inodeFile1);\n+    inodeDirectory.addChild(inodeFile2);\n+    Assert.assertEquals(createBlockId(2), (long) inodeDirectory.getChildrenIds().get(0));\n+    Assert.assertEquals(createBlockId(3), (long) inodeDirectory.getChildrenIds().get(1));\n+  }\n+\n+  @Test\n+  public void batchRemoveChildTest() {\n+    InodeDirectory inodeDirectory = createInodeDirectory();\n+    InodeFile inodeFile1 = createInodeFile(1);\n+    InodeFile inodeFile2 = createInodeFile(2);\n+    InodeFile inodeFile3 = createInodeFile(3);\n+    inodeDirectory.addChild(inodeFile1);\n+    inodeDirectory.addChild(inodeFile2);\n+    inodeDirectory.addChild(inodeFile3);\n+    Assert.assertEquals(3, inodeDirectory.getNumberOfChildren());\n+    inodeDirectory.removeChild(\"testFile1\");\n+    Assert.assertEquals(2, inodeDirectory.getNumberOfChildren());\n+    Assert.assertFalse(inodeDirectory.getChildrenIds().contains(createBlockId(1)));\n+  }\n+\n+  @Test\n+  public void equalsTest() {\n+    InodeDirectory inode1 = new InodeDirectory(\"test1\", 1, 0, System.currentTimeMillis());\n+    InodeDirectory inode2 = new InodeDirectory(\"test2\", 1, 0, System.currentTimeMillis());\n+    Assert.assertTrue(inode1.equals(inode2));","path":"servers/src/test/java/tachyon/master/next/filesystem/meta/InodeDirectoryTests.java","position":62,"original_position":62,"commit_id":"3ccdfca99140546a0de34a7f68c94eedfe988241","original_commit_id":"3ccdfca99140546a0de34a7f68c94eedfe988241","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"body":"(1) Why they are equal even one is test1 and another is test2?\r\n(2) can you also test the case of two non-equal inodes?\r\n(3) can you also test that an inode equals itself?","created_at":"2015-08-18T00:48:52Z","updated_at":"2015-08-18T00:48:52Z","html_url":"https://github.com/amplab/tachyon/pull/1313#discussion_r37254366","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1313","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/37254366"},"html":{"href":"https://github.com/amplab/tachyon/pull/1313#discussion_r37254366"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1313"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1313","id":42639410,"html_url":"https://github.com/amplab/tachyon/pull/1313","diff_url":"https://github.com/amplab/tachyon/pull/1313.diff","patch_url":"https://github.com/amplab/tachyon/pull/1313.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1313","number":1313,"state":"open","locked":false,"title":"[TACHYON-794] Added test coverage for Master","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-794\r\nAdded test coverage for InodeDirectory","created_at":"2015-08-17T21:58:44Z","updated_at":"2015-08-18T00:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38218b802582fb37e240e2909b8b252cb8fd2673","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1313/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1313/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1313/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/3ccdfca99140546a0de34a7f68c94eedfe988241","head":{"label":"yupeng9:addInodeTest","ref":"addInodeTest","sha":"3ccdfca99140546a0de34a7f68c94eedfe988241","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"repo":{"id":39411244,"name":"tachyon","full_name":"yupeng9/tachyon","owner":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yupeng9/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/yupeng9/tachyon","forks_url":"https://api.github.com/repos/yupeng9/tachyon/forks","keys_url":"https://api.github.com/repos/yupeng9/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yupeng9/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yupeng9/tachyon/teams","hooks_url":"https://api.github.com/repos/yupeng9/tachyon/hooks","issue_events_url":"https://api.github.com/repos/yupeng9/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/yupeng9/tachyon/events","assignees_url":"https://api.github.com/repos/yupeng9/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/yupeng9/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/yupeng9/tachyon/tags","blobs_url":"https://api.github.com/repos/yupeng9/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yupeng9/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yupeng9/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/yupeng9/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yupeng9/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/yupeng9/tachyon/languages","stargazers_url":"https://api.github.com/repos/yupeng9/tachyon/stargazers","contributors_url":"https://api.github.com/repos/yupeng9/tachyon/contributors","subscribers_url":"https://api.github.com/repos/yupeng9/tachyon/subscribers","subscription_url":"https://api.github.com/repos/yupeng9/tachyon/subscription","commits_url":"https://api.github.com/repos/yupeng9/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/yupeng9/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/yupeng9/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/yupeng9/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/yupeng9/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/yupeng9/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yupeng9/tachyon/merges","archive_url":"https://api.github.com/repos/yupeng9/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yupeng9/tachyon/downloads","issues_url":"https://api.github.com/repos/yupeng9/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/yupeng9/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/yupeng9/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/yupeng9/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yupeng9/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/yupeng9/tachyon/releases{/id}","created_at":"2015-07-20T22:20:20Z","updated_at":"2015-07-20T22:20:22Z","pushed_at":"2015-08-18T00:11:17Z","git_url":"git://github.com/yupeng9/tachyon.git","ssh_url":"git@github.com:yupeng9/tachyon.git","clone_url":"https://github.com/yupeng9/tachyon.git","svn_url":"https://github.com/yupeng9/tachyon","homepage":"http://tachyon-project.org","size":16230,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:wip_master_client","ref":"wip_master_client","sha":"ed687849d12f115d8134e6cf55de4eb8177e0ad5","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-08-14T19:04:01Z","pushed_at":"2015-08-18T00:43:13Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":39884,"stargazers_count":1502,"watchers_count":1502,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":579,"mirror_url":null,"open_issues_count":28,"forks":579,"open_issues":28,"watchers":1502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1313"},"html":{"href":"https://github.com/amplab/tachyon/pull/1313"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1313"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1313/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1313/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1313/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/3ccdfca99140546a0de34a7f68c94eedfe988241"}}}}