{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/22918025","id":22918025,"diff_hunk":"@@ -2,10 +2,12 @@\n // Use of this source code is governed by a BSD-style license that can be\n // found in the LICENSE file.\n \n-#include \"system_info/system_info_network.h\"\n+#include \"system_info/system_info_network_desktop.h\"\n \n #include <NetworkManager.h>\n \n+const std::string SysInfoNetwork::name_ = \"NETWORK\";","path":"src/system_info/system_info_network_desktop.cc","position":9,"original_position":9,"commit_id":"249c818ac423b800a533b8352c0a91c49b3b4294","original_commit_id":"249c818ac423b800a533b8352c0a91c49b3b4294","user":{"login":"liyingzh","id":9691351,"avatar_url":"https://avatars.githubusercontent.com/u/9691351?v=3","gravatar_id":"","url":"https://api.github.com/users/liyingzh","html_url":"https://github.com/liyingzh","followers_url":"https://api.github.com/users/liyingzh/followers","following_url":"https://api.github.com/users/liyingzh/following{/other_user}","gists_url":"https://api.github.com/users/liyingzh/gists{/gist_id}","starred_url":"https://api.github.com/users/liyingzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyingzh/subscriptions","organizations_url":"https://api.github.com/users/liyingzh/orgs","repos_url":"https://api.github.com/users/liyingzh/repos","events_url":"https://api.github.com/users/liyingzh/events{/privacy}","received_events_url":"https://api.github.com/users/liyingzh/received_events","type":"User","site_admin":false},"body":"@qjia7 It doesn't work\r\n````\r\n[   18s] ../../src/system_info/system_info_instance.cc: In instantiation of 'static void SystemInfoInstance::RegisterClass() [with T = SysInfoNetworkTizen]':\r\n[   18s] ../../src/system_info/system_info_instance.cc:77:38:   required from here\r\n[   18s] ../../src/system_info/system_info_instance.cc:55:64: error: 'name_' is not a member of 'SysInfoNetworkTizen'\r\n[   18s]    classes_.insert(SysInfoClassPair(T::name_ , T::GetInstance()));\r\n[   18s]                                                                 ^\r\n````","created_at":"2015-01-14T05:51:20Z","updated_at":"2015-01-14T05:51:20Z","html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/421#discussion_r22918025","pull_request_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/22918025"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/421#discussion_r22918025"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421","id":26284111,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/421","diff_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/421.diff","patch_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/421.patch","issue_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/421","number":421,"state":"open","locked":false,"title":"[SystemInfo] add system_info_network_ivi.cc to fit tizen ivi/common.","user":{"login":"liyingzh","id":9691351,"avatar_url":"https://avatars.githubusercontent.com/u/9691351?v=3","gravatar_id":"","url":"https://api.github.com/users/liyingzh","html_url":"https://github.com/liyingzh","followers_url":"https://api.github.com/users/liyingzh/followers","following_url":"https://api.github.com/users/liyingzh/following{/other_user}","gists_url":"https://api.github.com/users/liyingzh/gists{/gist_id}","starred_url":"https://api.github.com/users/liyingzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyingzh/subscriptions","organizations_url":"https://api.github.com/users/liyingzh/orgs","repos_url":"https://api.github.com/users/liyingzh/repos","events_url":"https://api.github.com/users/liyingzh/events{/privacy}","received_events_url":"https://api.github.com/users/liyingzh/received_events","type":"User","site_admin":false},"body":"Follow system_info_sim_ivi.cc(#369), add system_info_network_ivi.cc to fit ivi/common system.\r\n\r\nBUG=XWALK-2361","created_at":"2014-12-18T08:27:09Z","updated_at":"2015-01-14T05:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8429916f52411716e38149fef260a4f0718ade68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/421/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/249c818ac423b800a533b8352c0a91c49b3b4294","head":{"label":"liyingzh:Network","ref":"Network","sha":"249c818ac423b800a533b8352c0a91c49b3b4294","user":{"login":"liyingzh","id":9691351,"avatar_url":"https://avatars.githubusercontent.com/u/9691351?v=3","gravatar_id":"","url":"https://api.github.com/users/liyingzh","html_url":"https://github.com/liyingzh","followers_url":"https://api.github.com/users/liyingzh/followers","following_url":"https://api.github.com/users/liyingzh/following{/other_user}","gists_url":"https://api.github.com/users/liyingzh/gists{/gist_id}","starred_url":"https://api.github.com/users/liyingzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyingzh/subscriptions","organizations_url":"https://api.github.com/users/liyingzh/orgs","repos_url":"https://api.github.com/users/liyingzh/repos","events_url":"https://api.github.com/users/liyingzh/events{/privacy}","received_events_url":"https://api.github.com/users/liyingzh/received_events","type":"User","site_admin":false},"repo":{"id":26890008,"name":"tizen-extensions-crosswalk","full_name":"liyingzh/tizen-extensions-crosswalk","owner":{"login":"liyingzh","id":9691351,"avatar_url":"https://avatars.githubusercontent.com/u/9691351?v=3","gravatar_id":"","url":"https://api.github.com/users/liyingzh","html_url":"https://github.com/liyingzh","followers_url":"https://api.github.com/users/liyingzh/followers","following_url":"https://api.github.com/users/liyingzh/following{/other_user}","gists_url":"https://api.github.com/users/liyingzh/gists{/gist_id}","starred_url":"https://api.github.com/users/liyingzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyingzh/subscriptions","organizations_url":"https://api.github.com/users/liyingzh/orgs","repos_url":"https://api.github.com/users/liyingzh/repos","events_url":"https://api.github.com/users/liyingzh/events{/privacy}","received_events_url":"https://api.github.com/users/liyingzh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liyingzh/tizen-extensions-crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/liyingzh/tizen-extensions-crosswalk/releases{/id}","created_at":"2014-11-20T01:26:40Z","updated_at":"2014-12-29T06:42:04Z","pushed_at":"2015-01-14T04:57:36Z","git_url":"git://github.com/liyingzh/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:liyingzh/tizen-extensions-crosswalk.git","clone_url":"https://github.com/liyingzh/tizen-extensions-crosswalk.git","svn_url":"https://github.com/liyingzh/tizen-extensions-crosswalk","homepage":null,"size":2809,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"b7853fd49fcd807f2ba1eeb3a968e6ae22390d44","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11259856,"name":"tizen-extensions-crosswalk","full_name":"crosswalk-project/tizen-extensions-crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/releases{/id}","created_at":"2013-07-08T16:54:26Z","updated_at":"2015-01-13T15:19:42Z","pushed_at":"2015-01-13T15:19:42Z","git_url":"git://github.com/crosswalk-project/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:crosswalk-project/tizen-extensions-crosswalk.git","clone_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk.git","svn_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","homepage":null,"size":6142,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":2,"forks":69,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/421"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/421"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/249c818ac423b800a533b8352c0a91c49b3b4294"}}}}