{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/39","id":39307194,"html_url":"https://github.com/jenkinsci/github-oauth-plugin/pull/39","diff_url":"https://github.com/jenkinsci/github-oauth-plugin/pull/39.diff","patch_url":"https://github.com/jenkinsci/github-oauth-plugin/pull/39.patch","issue_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues/39","number":39,"state":"closed","locked":false,"title":"Restrict default OAuthScope to \"read:org\"","user":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"body":"The default scope for OAuth should arguably be as restricted as possible. The older default of \"repo,read:org\" requested push access to all of a user's repositories. For many users of the plugin, this was considered a deal-breaker before configurable OAuth Scopes, so there's no reason to assume that most users would want this moving forward.\r\n\r\nFor admins who prefer setting these values through the web UI, it's better to start with a more restricted scope, as it means that the admin doesn't need to share push privileges with Jenkins at any point during server configuration. This is also a better default for novice users who are not familiar with the GitHub OAuth docs and OAuth scoping.\r\n\r\nThis is, of course, a follow-up to discussions that we had with #35","created_at":"2015-07-06T20:27:58Z","updated_at":"2015-07-11T15:00:10Z","closed_at":"2015-07-11T15:00:10Z","merged_at":"2015-07-11T15:00:10Z","merge_commit_sha":"42c7cb9c504a23e7bc48a46bc6c1bfca156f9601","assignee":{"login":"samrocketman","id":875669,"avatar_url":"https://avatars.githubusercontent.com/u/875669?v=3","gravatar_id":"","url":"https://api.github.com/users/samrocketman","html_url":"https://github.com/samrocketman","followers_url":"https://api.github.com/users/samrocketman/followers","following_url":"https://api.github.com/users/samrocketman/following{/other_user}","gists_url":"https://api.github.com/users/samrocketman/gists{/gist_id}","starred_url":"https://api.github.com/users/samrocketman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samrocketman/subscriptions","organizations_url":"https://api.github.com/users/samrocketman/orgs","repos_url":"https://api.github.com/users/samrocketman/repos","events_url":"https://api.github.com/users/samrocketman/events{/privacy}","received_events_url":"https://api.github.com/users/samrocketman/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/39/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/39/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues/39/comments","statuses_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/statuses/3594a7ca9a2847eae092f5cb642da92d6a197c08","head":{"label":"sirosen:master","ref":"master","sha":"3594a7ca9a2847eae092f5cb642da92d6a197c08","user":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"repo":{"id":38643631,"name":"github-oauth-plugin","full_name":"sirosen/github-oauth-plugin","owner":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sirosen/github-oauth-plugin","description":"jenkins authentication plugin using github oauth as source","fork":true,"url":"https://api.github.com/repos/sirosen/github-oauth-plugin","forks_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/forks","keys_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/teams","hooks_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/hooks","issue_events_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/events","assignees_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/tags","blobs_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/languages","stargazers_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/stargazers","contributors_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/contributors","subscribers_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/subscribers","subscription_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/subscription","commits_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/merges","archive_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/downloads","issues_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/labels{/name}","releases_url":"https://api.github.com/repos/sirosen/github-oauth-plugin/releases{/id}","created_at":"2015-07-06T20:18:29Z","updated_at":"2015-07-06T20:18:30Z","pushed_at":"2015-07-10T22:08:10Z","git_url":"git://github.com/sirosen/github-oauth-plugin.git","ssh_url":"git@github.com:sirosen/github-oauth-plugin.git","clone_url":"https://github.com/sirosen/github-oauth-plugin.git","svn_url":"https://github.com/sirosen/github-oauth-plugin","homepage":"","size":341,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"24a3f6ff02ce373999850a6e2711af18824a9564","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":2027943,"name":"github-oauth-plugin","full_name":"jenkinsci/github-oauth-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/github-oauth-plugin","description":"jenkins authentication plugin using github oauth as source","fork":true,"url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin","forks_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/releases{/id}","created_at":"2011-07-11T00:49:27Z","updated_at":"2015-07-02T17:05:33Z","pushed_at":"2015-07-11T15:00:10Z","git_url":"git://github.com/jenkinsci/github-oauth-plugin.git","ssh_url":"git@github.com:jenkinsci/github-oauth-plugin.git","clone_url":"https://github.com/jenkinsci/github-oauth-plugin.git","svn_url":"https://github.com/jenkinsci/github-oauth-plugin","homepage":"","size":1106,"stargazers_count":37,"watchers_count":37,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":5,"forks":66,"open_issues":5,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/39"},"html":{"href":"https://github.com/jenkinsci/github-oauth-plugin/pull/39"},"issue":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues/39"},"comments":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/github-oauth-plugin/statuses/3594a7ca9a2847eae092f5cb642da92d6a197c08"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"samrocketman","id":875669,"avatar_url":"https://avatars.githubusercontent.com/u/875669?v=3","gravatar_id":"","url":"https://api.github.com/users/samrocketman","html_url":"https://github.com/samrocketman","followers_url":"https://api.github.com/users/samrocketman/followers","following_url":"https://api.github.com/users/samrocketman/following{/other_user}","gists_url":"https://api.github.com/users/samrocketman/gists{/gist_id}","starred_url":"https://api.github.com/users/samrocketman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samrocketman/subscriptions","organizations_url":"https://api.github.com/users/samrocketman/orgs","repos_url":"https://api.github.com/users/samrocketman/repos","events_url":"https://api.github.com/users/samrocketman/events{/privacy}","received_events_url":"https://api.github.com/users/samrocketman/received_events","type":"User","site_admin":false},"comments":23,"review_comments":0,"commits":2,"additions":4,"deletions":2,"changed_files":2}}