{"action":"created","issue":{"url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/issues/177","labels_url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/issues/177/comments","events_url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/issues/177/events","html_url":"https://github.com/pyqtgraph/pyqtgraph/pull/177","id":90088981,"number":177,"title":"Fix clickRadius feature","user":{"login":"vallsv","id":7579321,"avatar_url":"https://avatars.githubusercontent.com/u/7579321?v=3","gravatar_id":"","url":"https://api.github.com/users/vallsv","html_url":"https://github.com/vallsv","followers_url":"https://api.github.com/users/vallsv/followers","following_url":"https://api.github.com/users/vallsv/following{/other_user}","gists_url":"https://api.github.com/users/vallsv/gists{/gist_id}","starred_url":"https://api.github.com/users/vallsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vallsv/subscriptions","organizations_url":"https://api.github.com/users/vallsv/orgs","repos_url":"https://api.github.com/users/vallsv/repos","events_url":"https://api.github.com/users/vallsv/events{/privacy}","received_events_url":"https://api.github.com/users/vallsv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-22T12:47:08Z","updated_at":"2015-07-12T19:54:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/pulls/177","html_url":"https://github.com/pyqtgraph/pyqtgraph/pull/177","diff_url":"https://github.com/pyqtgraph/pyqtgraph/pull/177.diff","patch_url":"https://github.com/pyqtgraph/pyqtgraph/pull/177.patch"},"body":"Hi. The current version of PyQtGraph do not support anymore the setClickRadius feature. The code was broken somewhen.\r\n\r\nTo support again the clickRadius feature (which allow to select an item anyway the mouse is over it or not):\r\n- `items` list must come from the `rgn` shape (computed from `_clickRadius`)\r\n- `shape contains point` must be removed cause that's especially what must allow the clickRadius feature.\r\n\r\nThis patch does that.\r\n\r\nThanks a lot."},"comment":{"url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/issues/comments/120756765","html_url":"https://github.com/pyqtgraph/pyqtgraph/pull/177#issuecomment-120756765","issue_url":"https://api.github.com/repos/pyqtgraph/pyqtgraph/issues/177","id":120756765,"user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"created_at":"2015-07-12T19:54:10Z","updated_at":"2015-07-12T19:54:10Z","body":"This one is tricky--long ago had to switch away from `QGraphicsScene.items(region, ...)` because it was failing to detect some items. The alternative has been to ensure that thin objects expand their `shape()` to be more permissive in catching clicks. This has the added benefit that individual items can customize the way they interact with the mouse. \r\n\r\nHowever I *would* like to have `clickRadius` working again; it will just take a lot of testing to be sure everything works as expected. It might be possible to make this change safer, though, by setting the default clickRadius to 0, and using  `QGraphicsScene.items(point, ...)` only if the user has not explicitly changed the clickRadius."}}