{"action":"created","issue":{"url":"https://api.github.com/repos/appium/java-client/issues/186","labels_url":"https://api.github.com/repos/appium/java-client/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/appium/java-client/issues/186/comments","events_url":"https://api.github.com/repos/appium/java-client/issues/186/events","html_url":"https://github.com/appium/java-client/pull/186","id":68904556,"number":186,"title":"make sure that finalize calls on annotated fields in page objects don't send findElement calls","user":{"login":"aluedeke","id":311702,"avatar_url":"https://avatars.githubusercontent.com/u/311702?v=3","gravatar_id":"","url":"https://api.github.com/users/aluedeke","html_url":"https://github.com/aluedeke","followers_url":"https://api.github.com/users/aluedeke/followers","following_url":"https://api.github.com/users/aluedeke/following{/other_user}","gists_url":"https://api.github.com/users/aluedeke/gists{/gist_id}","starred_url":"https://api.github.com/users/aluedeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluedeke/subscriptions","organizations_url":"https://api.github.com/users/aluedeke/orgs","repos_url":"https://api.github.com/users/aluedeke/repos","events_url":"https://api.github.com/users/aluedeke/events{/privacy}","received_events_url":"https://api.github.com/users/aluedeke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-16T11:31:17Z","updated_at":"2015-04-16T18:49:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/appium/java-client/pulls/186","html_url":"https://github.com/appium/java-client/pull/186","diff_url":"https://github.com/appium/java-client/pull/186.diff","patch_url":"https://github.com/appium/java-client/pull/186.patch"},"body":"page objects do tons of findElement(s) calls to appium server because they also forward finalize method invocations."},"comment":{"url":"https://api.github.com/repos/appium/java-client/issues/comments/93813214","html_url":"https://github.com/appium/java-client/pull/186#issuecomment-93813214","issue_url":"https://api.github.com/repos/appium/java-client/issues/186","id":93813214,"user":{"login":"aluedeke","id":311702,"avatar_url":"https://avatars.githubusercontent.com/u/311702?v=3","gravatar_id":"","url":"https://api.github.com/users/aluedeke","html_url":"https://github.com/aluedeke","followers_url":"https://api.github.com/users/aluedeke/followers","following_url":"https://api.github.com/users/aluedeke/following{/other_user}","gists_url":"https://api.github.com/users/aluedeke/gists{/gist_id}","starred_url":"https://api.github.com/users/aluedeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluedeke/subscriptions","organizations_url":"https://api.github.com/users/aluedeke/orgs","repos_url":"https://api.github.com/users/aluedeke/repos","events_url":"https://api.github.com/users/aluedeke/events{/privacy}","received_events_url":"https://api.github.com/users/aluedeke/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T18:49:38Z","updated_at":"2015-04-16T18:49:38Z","body":"@TikhomirovSergey yes improved it a lot. Had PageObjects with 20+ annotated fields and every finalize call created a findElement call (so 20+). Now i have zero. So its much better/cleaner.\r\n\r\nHope no one will ever put this stuff into hashmaps so that equals, hashcode or toString are frequently called."}}