{"action":"created","comment":{"url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/comments/28178469","id":28178469,"diff_hunk":"@@ -99,4 +96,33 @@ private void tryWaitFor() {\n     public List<Integer> ports() {\n         return Arrays.asList(port);\n     }\n+\n+    private static class PrintReaderRunnable implements Runnable {\n+        private final BufferedReader reader;\n+\n+        private PrintReaderRunnable(BufferedReader reader) {\n+            this.reader = reader;\n+        }\n+\n+        public void run() {\n+            try {\n+                readLines();\n+            } catch(IOException e) {\n+                throw new RuntimeException(\"Failed to determine if Redis Server started\", e);\n+            } finally {\n+                IOUtils.closeQuietly(reader);\n+            }\n+        }\n+\n+        public void readLines() throws IOException {","path":"src/main/java/redis/embedded/AbstractRedisInstance.java","position":null,"original_position":67,"commit_id":"79bf5639b45d187a56e6236c8af676a26e801ff5","original_commit_id":"964f1da109bf779aec11f4aa50bde1ac929b10b6","user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"body":"Good catch! I have [updated the PR](https://github.com/kstyrc/embedded-redis/pull/39/files#diff-ace388731a732c3b434c9f80f9f875faR100)","created_at":"2015-04-10T20:38:38Z","updated_at":"2015-04-10T20:38:38Z","html_url":"https://github.com/kstyrc/embedded-redis/pull/39#discussion_r28178469","pull_request_url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/comments/28178469"},"html":{"href":"https://github.com/kstyrc/embedded-redis/pull/39#discussion_r28178469"},"pull_request":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39","id":33061365,"html_url":"https://github.com/kstyrc/embedded-redis/pull/39","diff_url":"https://github.com/kstyrc/embedded-redis/pull/39.diff","patch_url":"https://github.com/kstyrc/embedded-redis/pull/39.patch","issue_url":"https://api.github.com/repos/kstyrc/embedded-redis/issues/39","number":39,"state":"open","locked":false,"title":"Support JDK 6","user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"body":"Previously JDK 8 features were used which limitted the project to those\r\nsupporting JDK 8. While some of the features being used are convenient,\r\nnone of the features were necessary.\r\n\r\nNow the project supports JDK 6+ for those that are using older JDKs.\r\n\r\nFixes gh-38","created_at":"2015-04-10T16:21:26Z","updated_at":"2015-04-10T20:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3f48bb25ba78cf7bc5284442baac6dd409fd8b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39/commits","review_comments_url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39/comments","review_comment_url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kstyrc/embedded-redis/issues/39/comments","statuses_url":"https://api.github.com/repos/kstyrc/embedded-redis/statuses/79bf5639b45d187a56e6236c8af676a26e801ff5","head":{"label":"rwinch:jdk6","ref":"jdk6","sha":"79bf5639b45d187a56e6236c8af676a26e801ff5","user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"repo":{"id":33738123,"name":"embedded-redis","full_name":"rwinch/embedded-redis","owner":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwinch/embedded-redis","description":"Redis embedded server for Java integration testing","fork":true,"url":"https://api.github.com/repos/rwinch/embedded-redis","forks_url":"https://api.github.com/repos/rwinch/embedded-redis/forks","keys_url":"https://api.github.com/repos/rwinch/embedded-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwinch/embedded-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwinch/embedded-redis/teams","hooks_url":"https://api.github.com/repos/rwinch/embedded-redis/hooks","issue_events_url":"https://api.github.com/repos/rwinch/embedded-redis/issues/events{/number}","events_url":"https://api.github.com/repos/rwinch/embedded-redis/events","assignees_url":"https://api.github.com/repos/rwinch/embedded-redis/assignees{/user}","branches_url":"https://api.github.com/repos/rwinch/embedded-redis/branches{/branch}","tags_url":"https://api.github.com/repos/rwinch/embedded-redis/tags","blobs_url":"https://api.github.com/repos/rwinch/embedded-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwinch/embedded-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwinch/embedded-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwinch/embedded-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwinch/embedded-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/rwinch/embedded-redis/languages","stargazers_url":"https://api.github.com/repos/rwinch/embedded-redis/stargazers","contributors_url":"https://api.github.com/repos/rwinch/embedded-redis/contributors","subscribers_url":"https://api.github.com/repos/rwinch/embedded-redis/subscribers","subscription_url":"https://api.github.com/repos/rwinch/embedded-redis/subscription","commits_url":"https://api.github.com/repos/rwinch/embedded-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwinch/embedded-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwinch/embedded-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwinch/embedded-redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwinch/embedded-redis/contents/{+path}","compare_url":"https://api.github.com/repos/rwinch/embedded-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwinch/embedded-redis/merges","archive_url":"https://api.github.com/repos/rwinch/embedded-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwinch/embedded-redis/downloads","issues_url":"https://api.github.com/repos/rwinch/embedded-redis/issues{/number}","pulls_url":"https://api.github.com/repos/rwinch/embedded-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/rwinch/embedded-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/rwinch/embedded-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwinch/embedded-redis/labels{/name}","releases_url":"https://api.github.com/repos/rwinch/embedded-redis/releases{/id}","created_at":"2015-04-10T16:14:32Z","updated_at":"2015-04-10T16:14:32Z","pushed_at":"2015-04-10T20:37:26Z","git_url":"git://github.com/rwinch/embedded-redis.git","ssh_url":"git@github.com:rwinch/embedded-redis.git","clone_url":"https://github.com/rwinch/embedded-redis.git","svn_url":"https://github.com/rwinch/embedded-redis","homepage":null,"size":6257,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kstyrc:master","ref":"master","sha":"48f34563da2dd5aa2ad28d986dbcc08b5386983d","user":{"login":"kstyrc","id":336818,"avatar_url":"https://avatars.githubusercontent.com/u/336818?v=3","gravatar_id":"","url":"https://api.github.com/users/kstyrc","html_url":"https://github.com/kstyrc","followers_url":"https://api.github.com/users/kstyrc/followers","following_url":"https://api.github.com/users/kstyrc/following{/other_user}","gists_url":"https://api.github.com/users/kstyrc/gists{/gist_id}","starred_url":"https://api.github.com/users/kstyrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kstyrc/subscriptions","organizations_url":"https://api.github.com/users/kstyrc/orgs","repos_url":"https://api.github.com/users/kstyrc/repos","events_url":"https://api.github.com/users/kstyrc/events{/privacy}","received_events_url":"https://api.github.com/users/kstyrc/received_events","type":"User","site_admin":false},"repo":{"id":12059583,"name":"embedded-redis","full_name":"kstyrc/embedded-redis","owner":{"login":"kstyrc","id":336818,"avatar_url":"https://avatars.githubusercontent.com/u/336818?v=3","gravatar_id":"","url":"https://api.github.com/users/kstyrc","html_url":"https://github.com/kstyrc","followers_url":"https://api.github.com/users/kstyrc/followers","following_url":"https://api.github.com/users/kstyrc/following{/other_user}","gists_url":"https://api.github.com/users/kstyrc/gists{/gist_id}","starred_url":"https://api.github.com/users/kstyrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kstyrc/subscriptions","organizations_url":"https://api.github.com/users/kstyrc/orgs","repos_url":"https://api.github.com/users/kstyrc/repos","events_url":"https://api.github.com/users/kstyrc/events{/privacy}","received_events_url":"https://api.github.com/users/kstyrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kstyrc/embedded-redis","description":"Redis embedded server for Java integration testing","fork":false,"url":"https://api.github.com/repos/kstyrc/embedded-redis","forks_url":"https://api.github.com/repos/kstyrc/embedded-redis/forks","keys_url":"https://api.github.com/repos/kstyrc/embedded-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kstyrc/embedded-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kstyrc/embedded-redis/teams","hooks_url":"https://api.github.com/repos/kstyrc/embedded-redis/hooks","issue_events_url":"https://api.github.com/repos/kstyrc/embedded-redis/issues/events{/number}","events_url":"https://api.github.com/repos/kstyrc/embedded-redis/events","assignees_url":"https://api.github.com/repos/kstyrc/embedded-redis/assignees{/user}","branches_url":"https://api.github.com/repos/kstyrc/embedded-redis/branches{/branch}","tags_url":"https://api.github.com/repos/kstyrc/embedded-redis/tags","blobs_url":"https://api.github.com/repos/kstyrc/embedded-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kstyrc/embedded-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kstyrc/embedded-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/kstyrc/embedded-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kstyrc/embedded-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/kstyrc/embedded-redis/languages","stargazers_url":"https://api.github.com/repos/kstyrc/embedded-redis/stargazers","contributors_url":"https://api.github.com/repos/kstyrc/embedded-redis/contributors","subscribers_url":"https://api.github.com/repos/kstyrc/embedded-redis/subscribers","subscription_url":"https://api.github.com/repos/kstyrc/embedded-redis/subscription","commits_url":"https://api.github.com/repos/kstyrc/embedded-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/kstyrc/embedded-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/kstyrc/embedded-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/kstyrc/embedded-redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/kstyrc/embedded-redis/contents/{+path}","compare_url":"https://api.github.com/repos/kstyrc/embedded-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kstyrc/embedded-redis/merges","archive_url":"https://api.github.com/repos/kstyrc/embedded-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kstyrc/embedded-redis/downloads","issues_url":"https://api.github.com/repos/kstyrc/embedded-redis/issues{/number}","pulls_url":"https://api.github.com/repos/kstyrc/embedded-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/kstyrc/embedded-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/kstyrc/embedded-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kstyrc/embedded-redis/labels{/name}","releases_url":"https://api.github.com/repos/kstyrc/embedded-redis/releases{/id}","created_at":"2013-08-12T15:41:48Z","updated_at":"2015-04-09T06:22:40Z","pushed_at":"2015-04-10T20:37:26Z","git_url":"git://github.com/kstyrc/embedded-redis.git","ssh_url":"git@github.com:kstyrc/embedded-redis.git","clone_url":"https://github.com/kstyrc/embedded-redis.git","svn_url":"https://github.com/kstyrc/embedded-redis","homepage":null,"size":6257,"stargazers_count":83,"watchers_count":83,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":6,"forks":29,"open_issues":6,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39"},"html":{"href":"https://github.com/kstyrc/embedded-redis/pull/39"},"issue":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/issues/39"},"comments":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/kstyrc/embedded-redis/statuses/79bf5639b45d187a56e6236c8af676a26e801ff5"}}}}