{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/36450690","id":36450690,"diff_hunk":"@@ -1,3 +1,4 @@\n+/// <reference path=\"../angular2/typings/es6-promise/es6-promise.d.ts\"/>","path":"modules/angular2/traceur-runtime.d.ts","position":1,"original_position":1,"commit_id":"2db109b880e2978b6b925fe514fe4d65c8a62f55","original_commit_id":"2db109b880e2978b6b925fe514fe4d65c8a62f55","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2015-08-06T18:47:38Z","updated_at":"2015-08-06T18:47:38Z","html_url":"https://github.com/angular/angular/pull/3508#discussion_r36450690","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/3508","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/36450690"},"html":{"href":"https://github.com/angular/angular/pull/3508#discussion_r36450690"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/3508"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/3508","id":41814482,"html_url":"https://github.com/angular/angular/pull/3508","diff_url":"https://github.com/angular/angular/pull/3508.diff","patch_url":"https://github.com/angular/angular/pull/3508.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/3508","number":3508,"state":"open","locked":false,"title":"chore(build): enable type-checking for TypeScript ES6 emit.","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"body":"This requires delicate handling of type definitions which collide, because\r\nwe use TypeScript-provided lib.d.ts for --target=es5 and lib.es6.d.ts for\r\n--target=es6.\r\nWe need to include our polyfill typings only in the --target=es5 case,\r\nand the usages have to be consistent with lib.es6.d.ts.\r\nAlso starting with this change we now typecheck additional modules,\r\nso this fixes a bunch of wrong typings which were never checked before.\r\n\r\nFixes #3178","created_at":"2015-08-06T17:44:03Z","updated_at":"2015-08-06T18:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88c8d0344c00f93805bdde29841d4e5f76a47cfb","assignee":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=3","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/3508/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/3508/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/3508/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/2db109b880e2978b6b925fe514fe4d65c8a62f55","head":{"label":"alexeagle:type_check_es6_harder","ref":"type_check_es6_harder","sha":"2db109b880e2978b6b925fe514fe4d65c8a62f55","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"repo":{"id":30215210,"name":"angular","full_name":"alexeagle/angular","owner":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexeagle/angular","description":"","fork":true,"url":"https://api.github.com/repos/alexeagle/angular","forks_url":"https://api.github.com/repos/alexeagle/angular/forks","keys_url":"https://api.github.com/repos/alexeagle/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexeagle/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexeagle/angular/teams","hooks_url":"https://api.github.com/repos/alexeagle/angular/hooks","issue_events_url":"https://api.github.com/repos/alexeagle/angular/issues/events{/number}","events_url":"https://api.github.com/repos/alexeagle/angular/events","assignees_url":"https://api.github.com/repos/alexeagle/angular/assignees{/user}","branches_url":"https://api.github.com/repos/alexeagle/angular/branches{/branch}","tags_url":"https://api.github.com/repos/alexeagle/angular/tags","blobs_url":"https://api.github.com/repos/alexeagle/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexeagle/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexeagle/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexeagle/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexeagle/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/alexeagle/angular/languages","stargazers_url":"https://api.github.com/repos/alexeagle/angular/stargazers","contributors_url":"https://api.github.com/repos/alexeagle/angular/contributors","subscribers_url":"https://api.github.com/repos/alexeagle/angular/subscribers","subscription_url":"https://api.github.com/repos/alexeagle/angular/subscription","commits_url":"https://api.github.com/repos/alexeagle/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexeagle/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexeagle/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexeagle/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexeagle/angular/contents/{+path}","compare_url":"https://api.github.com/repos/alexeagle/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexeagle/angular/merges","archive_url":"https://api.github.com/repos/alexeagle/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexeagle/angular/downloads","issues_url":"https://api.github.com/repos/alexeagle/angular/issues{/number}","pulls_url":"https://api.github.com/repos/alexeagle/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/alexeagle/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/alexeagle/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexeagle/angular/labels{/name}","releases_url":"https://api.github.com/repos/alexeagle/angular/releases{/id}","created_at":"2015-02-02T23:49:55Z","updated_at":"2015-07-08T20:03:24Z","pushed_at":"2015-08-06T17:42:34Z","git_url":"git://github.com/alexeagle/angular.git","ssh_url":"git@github.com:alexeagle/angular.git","clone_url":"https://github.com/alexeagle/angular.git","svn_url":"https://github.com/alexeagle/angular","homepage":null,"size":12365,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f11f4e0b4535156902c83e8782395607a8d418cf","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-08-06T17:18:46Z","pushed_at":"2015-08-06T17:45:26Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":38277,"stargazers_count":4597,"watchers_count":4597,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1210,"mirror_url":null,"open_issues_count":434,"forks":1210,"open_issues":434,"watchers":4597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/3508"},"html":{"href":"https://github.com/angular/angular/pull/3508"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/3508"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/3508/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/3508/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/3508/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/2db109b880e2978b6b925fe514fe4d65c8a62f55"}}}}