{"action":"created","comment":{"url":"https://api.github.com/repos/Textalk/queuepusherl/pulls/comments/46553781","id":46553781,"diff_hunk":"@@ -41,8 +41,8 @@\n \n -record(smtp_event, {\n           mail  :: mail(),\n-          smtp  :: smtp(),\n-          error :: mailerror()}).\n+          smtps :: [smtp()],\n+          error :: mailerror() | 'undefined'}).","path":"src/smtp/qpusherl_smtp_event.erl","position":7,"original_position":7,"commit_id":"6ac6fe64f34eca95f68efe1e53aaee469dc8469d","original_commit_id":"6ac6fe64f34eca95f68efe1e53aaee469dc8469d","user":{"login":"RaoH","id":738935,"avatar_url":"https://avatars.githubusercontent.com/u/738935?v=3","gravatar_id":"","url":"https://api.github.com/users/RaoH","html_url":"https://github.com/RaoH","followers_url":"https://api.github.com/users/RaoH/followers","following_url":"https://api.github.com/users/RaoH/following{/other_user}","gists_url":"https://api.github.com/users/RaoH/gists{/gist_id}","starred_url":"https://api.github.com/users/RaoH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaoH/subscriptions","organizations_url":"https://api.github.com/users/RaoH/orgs","repos_url":"https://api.github.com/users/RaoH/repos","events_url":"https://api.github.com/users/RaoH/events{/privacy}","received_events_url":"https://api.github.com/users/RaoH/received_events","type":"User","site_admin":false},"body":"| ```'undefined'``` why not undefined directly?","created_at":"2015-12-03T14:03:07Z","updated_at":"2015-12-03T14:03:07Z","html_url":"https://github.com/Textalk/queuepusherl/pull/5#discussion_r46553781","pull_request_url":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Textalk/queuepusherl/pulls/comments/46553781"},"html":{"href":"https://github.com/Textalk/queuepusherl/pull/5#discussion_r46553781"},"pull_request":{"href":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5","id":52258828,"html_url":"https://github.com/Textalk/queuepusherl/pull/5","diff_url":"https://github.com/Textalk/queuepusherl/pull/5.diff","patch_url":"https://github.com/Textalk/queuepusherl/pull/5.patch","issue_url":"https://api.github.com/repos/Textalk/queuepusherl/issues/5","number":5,"state":"open","locked":false,"title":"Add support for fallback SMTP","user":{"login":"KoFish","id":63751,"avatar_url":"https://avatars.githubusercontent.com/u/63751?v=3","gravatar_id":"","url":"https://api.github.com/users/KoFish","html_url":"https://github.com/KoFish","followers_url":"https://api.github.com/users/KoFish/followers","following_url":"https://api.github.com/users/KoFish/following{/other_user}","gists_url":"https://api.github.com/users/KoFish/gists{/gist_id}","starred_url":"https://api.github.com/users/KoFish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoFish/subscriptions","organizations_url":"https://api.github.com/users/KoFish/orgs","repos_url":"https://api.github.com/users/KoFish/repos","events_url":"https://api.github.com/users/KoFish/events{/privacy}","received_events_url":"https://api.github.com/users/KoFish/received_events","type":"User","site_admin":false},"body":"This change also makes the `error` section of SMTP events optional and added changed how the internal error reporting works. This also leads to the errors being returned in the headers on the response queue will look different.","created_at":"2015-12-01T13:41:53Z","updated_at":"2015-12-03T14:03:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"837a2b8021699d7f616abb6ba78fa349efb367a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Textalk/queuepusherl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Textalk/queuepusherl/issues/5/comments","statuses_url":"https://api.github.com/repos/Textalk/queuepusherl/statuses/6ac6fe64f34eca95f68efe1e53aaee469dc8469d","head":{"label":"Textalk:dev-fallback-smtps","ref":"dev-fallback-smtps","sha":"6ac6fe64f34eca95f68efe1e53aaee469dc8469d","user":{"login":"Textalk","id":1212324,"avatar_url":"https://avatars.githubusercontent.com/u/1212324?v=3","gravatar_id":"","url":"https://api.github.com/users/Textalk","html_url":"https://github.com/Textalk","followers_url":"https://api.github.com/users/Textalk/followers","following_url":"https://api.github.com/users/Textalk/following{/other_user}","gists_url":"https://api.github.com/users/Textalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Textalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Textalk/subscriptions","organizations_url":"https://api.github.com/users/Textalk/orgs","repos_url":"https://api.github.com/users/Textalk/repos","events_url":"https://api.github.com/users/Textalk/events{/privacy}","received_events_url":"https://api.github.com/users/Textalk/received_events","type":"Organization","site_admin":false},"repo":{"id":38874028,"name":"queuepusherl","full_name":"Textalk/queuepusherl","owner":{"login":"Textalk","id":1212324,"avatar_url":"https://avatars.githubusercontent.com/u/1212324?v=3","gravatar_id":"","url":"https://api.github.com/users/Textalk","html_url":"https://github.com/Textalk","followers_url":"https://api.github.com/users/Textalk/followers","following_url":"https://api.github.com/users/Textalk/following{/other_user}","gists_url":"https://api.github.com/users/Textalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Textalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Textalk/subscriptions","organizations_url":"https://api.github.com/users/Textalk/orgs","repos_url":"https://api.github.com/users/Textalk/repos","events_url":"https://api.github.com/users/Textalk/events{/privacy}","received_events_url":"https://api.github.com/users/Textalk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Textalk/queuepusherl","description":"Improvement on queuemailer with support for pushing updates to HTTP servers.","fork":false,"url":"https://api.github.com/repos/Textalk/queuepusherl","forks_url":"https://api.github.com/repos/Textalk/queuepusherl/forks","keys_url":"https://api.github.com/repos/Textalk/queuepusherl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Textalk/queuepusherl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Textalk/queuepusherl/teams","hooks_url":"https://api.github.com/repos/Textalk/queuepusherl/hooks","issue_events_url":"https://api.github.com/repos/Textalk/queuepusherl/issues/events{/number}","events_url":"https://api.github.com/repos/Textalk/queuepusherl/events","assignees_url":"https://api.github.com/repos/Textalk/queuepusherl/assignees{/user}","branches_url":"https://api.github.com/repos/Textalk/queuepusherl/branches{/branch}","tags_url":"https://api.github.com/repos/Textalk/queuepusherl/tags","blobs_url":"https://api.github.com/repos/Textalk/queuepusherl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Textalk/queuepusherl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Textalk/queuepusherl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Textalk/queuepusherl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Textalk/queuepusherl/statuses/{sha}","languages_url":"https://api.github.com/repos/Textalk/queuepusherl/languages","stargazers_url":"https://api.github.com/repos/Textalk/queuepusherl/stargazers","contributors_url":"https://api.github.com/repos/Textalk/queuepusherl/contributors","subscribers_url":"https://api.github.com/repos/Textalk/queuepusherl/subscribers","subscription_url":"https://api.github.com/repos/Textalk/queuepusherl/subscription","commits_url":"https://api.github.com/repos/Textalk/queuepusherl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Textalk/queuepusherl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Textalk/queuepusherl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Textalk/queuepusherl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Textalk/queuepusherl/contents/{+path}","compare_url":"https://api.github.com/repos/Textalk/queuepusherl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Textalk/queuepusherl/merges","archive_url":"https://api.github.com/repos/Textalk/queuepusherl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Textalk/queuepusherl/downloads","issues_url":"https://api.github.com/repos/Textalk/queuepusherl/issues{/number}","pulls_url":"https://api.github.com/repos/Textalk/queuepusherl/pulls{/number}","milestones_url":"https://api.github.com/repos/Textalk/queuepusherl/milestones{/number}","notifications_url":"https://api.github.com/repos/Textalk/queuepusherl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Textalk/queuepusherl/labels{/name}","releases_url":"https://api.github.com/repos/Textalk/queuepusherl/releases{/id}","created_at":"2015-07-10T10:01:53Z","updated_at":"2015-12-02T21:54:15Z","pushed_at":"2015-12-01T13:41:54Z","git_url":"git://github.com/Textalk/queuepusherl.git","ssh_url":"git@github.com:Textalk/queuepusherl.git","clone_url":"https://github.com/Textalk/queuepusherl.git","svn_url":"https://github.com/Textalk/queuepusherl","homepage":null,"size":89,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"Textalk:master","ref":"master","sha":"4c77678afa8f401a0d714420fed23326eb84d0f7","user":{"login":"Textalk","id":1212324,"avatar_url":"https://avatars.githubusercontent.com/u/1212324?v=3","gravatar_id":"","url":"https://api.github.com/users/Textalk","html_url":"https://github.com/Textalk","followers_url":"https://api.github.com/users/Textalk/followers","following_url":"https://api.github.com/users/Textalk/following{/other_user}","gists_url":"https://api.github.com/users/Textalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Textalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Textalk/subscriptions","organizations_url":"https://api.github.com/users/Textalk/orgs","repos_url":"https://api.github.com/users/Textalk/repos","events_url":"https://api.github.com/users/Textalk/events{/privacy}","received_events_url":"https://api.github.com/users/Textalk/received_events","type":"Organization","site_admin":false},"repo":{"id":38874028,"name":"queuepusherl","full_name":"Textalk/queuepusherl","owner":{"login":"Textalk","id":1212324,"avatar_url":"https://avatars.githubusercontent.com/u/1212324?v=3","gravatar_id":"","url":"https://api.github.com/users/Textalk","html_url":"https://github.com/Textalk","followers_url":"https://api.github.com/users/Textalk/followers","following_url":"https://api.github.com/users/Textalk/following{/other_user}","gists_url":"https://api.github.com/users/Textalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Textalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Textalk/subscriptions","organizations_url":"https://api.github.com/users/Textalk/orgs","repos_url":"https://api.github.com/users/Textalk/repos","events_url":"https://api.github.com/users/Textalk/events{/privacy}","received_events_url":"https://api.github.com/users/Textalk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Textalk/queuepusherl","description":"Improvement on queuemailer with support for pushing updates to HTTP servers.","fork":false,"url":"https://api.github.com/repos/Textalk/queuepusherl","forks_url":"https://api.github.com/repos/Textalk/queuepusherl/forks","keys_url":"https://api.github.com/repos/Textalk/queuepusherl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Textalk/queuepusherl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Textalk/queuepusherl/teams","hooks_url":"https://api.github.com/repos/Textalk/queuepusherl/hooks","issue_events_url":"https://api.github.com/repos/Textalk/queuepusherl/issues/events{/number}","events_url":"https://api.github.com/repos/Textalk/queuepusherl/events","assignees_url":"https://api.github.com/repos/Textalk/queuepusherl/assignees{/user}","branches_url":"https://api.github.com/repos/Textalk/queuepusherl/branches{/branch}","tags_url":"https://api.github.com/repos/Textalk/queuepusherl/tags","blobs_url":"https://api.github.com/repos/Textalk/queuepusherl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Textalk/queuepusherl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Textalk/queuepusherl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Textalk/queuepusherl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Textalk/queuepusherl/statuses/{sha}","languages_url":"https://api.github.com/repos/Textalk/queuepusherl/languages","stargazers_url":"https://api.github.com/repos/Textalk/queuepusherl/stargazers","contributors_url":"https://api.github.com/repos/Textalk/queuepusherl/contributors","subscribers_url":"https://api.github.com/repos/Textalk/queuepusherl/subscribers","subscription_url":"https://api.github.com/repos/Textalk/queuepusherl/subscription","commits_url":"https://api.github.com/repos/Textalk/queuepusherl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Textalk/queuepusherl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Textalk/queuepusherl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Textalk/queuepusherl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Textalk/queuepusherl/contents/{+path}","compare_url":"https://api.github.com/repos/Textalk/queuepusherl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Textalk/queuepusherl/merges","archive_url":"https://api.github.com/repos/Textalk/queuepusherl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Textalk/queuepusherl/downloads","issues_url":"https://api.github.com/repos/Textalk/queuepusherl/issues{/number}","pulls_url":"https://api.github.com/repos/Textalk/queuepusherl/pulls{/number}","milestones_url":"https://api.github.com/repos/Textalk/queuepusherl/milestones{/number}","notifications_url":"https://api.github.com/repos/Textalk/queuepusherl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Textalk/queuepusherl/labels{/name}","releases_url":"https://api.github.com/repos/Textalk/queuepusherl/releases{/id}","created_at":"2015-07-10T10:01:53Z","updated_at":"2015-12-02T21:54:15Z","pushed_at":"2015-12-01T13:41:54Z","git_url":"git://github.com/Textalk/queuepusherl.git","ssh_url":"git@github.com:Textalk/queuepusherl.git","clone_url":"https://github.com/Textalk/queuepusherl.git","svn_url":"https://github.com/Textalk/queuepusherl","homepage":null,"size":89,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5"},"html":{"href":"https://github.com/Textalk/queuepusherl/pull/5"},"issue":{"href":"https://api.github.com/repos/Textalk/queuepusherl/issues/5"},"comments":{"href":"https://api.github.com/repos/Textalk/queuepusherl/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Textalk/queuepusherl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Textalk/queuepusherl/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Textalk/queuepusherl/statuses/6ac6fe64f34eca95f68efe1e53aaee469dc8469d"}}}}