{"push_id":817449187,"size":18,"distinct_size":2,"ref":"refs/heads/eslint-require-common","head":"34fc281d7ee407e3a4cc66af49b72902bdb0e7e1","before":"db8430536087bfff3a53e7ac524e51f9af3234cd","commits":[{"sha":"6fff47ffacfe663efeb0d31ebd700a65bf5521ba","author":{"email":"0aae46e22085b8114be801f98c6281c5fc13b487@google.com","name":"Ali Ijaz Sheikh"},"message":"deps: backport 03ef3cd from V8 upstream\n\nReduces likelihood of the filename being truncated in /tmp/perf-*.map when\nprofiling with --perf_basic_prof.\n\nPR-URL: https://github.com/nodejs/node/pull/3165\nReviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>\n\nhttps://github.com/v8/v8/commit/03ef3cd004c2fd31ae7e48772f106df67b8c2feb\n\nOriginal commit message:\n  improve perf_basic_prof filename reporting\n\n  The buffer used for appending filenames to the string printed to the\n  perf_basic_prof log was unnecessarily too small. Bump it up to be at least\n  kUtf8BufferSize.\n\n  Truncation of filenames makes it really hard to work with profiles gathered on\n  Node.js. Because of the way Node.js works, you can have node module dependencies\n  in deeply nested directories. The last thing you want when investigating a\n  performance problem is to have script names be truncated.\n\n  This patch is a stop-gap. Ideally, I want no truncation of the filename at all\n  and use a dynamically growing buffer. That would be a larger change, and I\n  wanted to have a quick fix available that can be back-ported to Node.js LTS\n  release.\n\n  R=yangguo@chromium.org,yurys@chromium.org\n  BUG=\n\n  Review URL: https://codereview.chromium.org/1388543002\n\n  Cr-Commit-Position: refs/heads/master@{#31092}","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/6fff47ffacfe663efeb0d31ebd700a65bf5521ba"},{"sha":"342c3a1bbba78d50b3e8d6df662fceb8b72782c3","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@silverwind.io","name":"Roman Reiss"},"message":"test: remove arguments.callee usage\n\narguments.callee is forbidden in strict mode and the fact that it's\nbeing used masked a possible error in this test.\n\nPR-URL: https://github.com/nodejs/node/pull/3167\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Michaël Zasso <mic.besace@gmail.com>\nReviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/342c3a1bbba78d50b3e8d6df662fceb8b72782c3"},{"sha":"05040664c2035b8abffb7bd7bb3243af35895130","author":{"email":"e39d94bae70283f13d24c278e04952d6dad9384b@indutny.com","name":"Fedor Indutny"},"message":"http: fix out-of-order 'finish' bug in pipelining\n\nChanges to `stream_base.cc` are required to support empty writes.\nFixes CVE-2015-7384, https://github.com/nodejs/node/issues/3138\n\nFix: https://github.com/nodejs/node/issues/2639\nPR-URL: https://github.com/nodejs/node/pull/3128","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/05040664c2035b8abffb7bd7bb3243af35895130"},{"sha":"b3d96782d47fbc7d7ac8f2b316b1a6ee67e2e015","author":{"email":"e39d94bae70283f13d24c278e04952d6dad9384b@indutny.com","name":"Fedor Indutny"},"message":"http_server: pause socket properly\n\nAccount pending response data to decide whether pause the socket or\nnot. Writable stream state is a not reliable measure, because it just\nsays how much data is pending on a **current** request, thus not helping\nmuch with problem we are trying to solve here.\n\nPR-URL: https://github.com/nodejs/node/pull/3128","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/b3d96782d47fbc7d7ac8f2b316b1a6ee67e2e015"},{"sha":"a4fa51cd02a7490366788041038747ae7499d7b8","author":{"email":"e39d94bae70283f13d24c278e04952d6dad9384b@indutny.com","name":"Fedor Indutny"},"message":"stream_wrap: support empty `TryWrite`s\n\nDecrement `vcount` in `DoTryWrite` even if some of the buffers are\nempty.\n\nPR-URL: https://github.com/nodejs/node/pull/3128","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/a4fa51cd02a7490366788041038747ae7499d7b8"},{"sha":"820735d96743717d4d037caa96e56ff5886c73df","author":{"email":"f9f03903429036ef609ed7ca822fddfa76155c29@vagg.org","name":"Rod Vagg"},"message":"2015-10-05, Version 4.1.2 (Stable) Release\n\nNotable changes\n\n* http:\n  - Fix out-of-order 'finish' event bug in pipelining that can abort\n    execution, fixes DoS vulnerability CVE-2015-7384\n    (Fedor Indutny) #3128\n  - Account for pending response data instead of just the data on the\n    current request to decide whether pause the socket or not\n    (Fedor Indutny) #3128\n* libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details\n  (Saúl Ibarra Corretgé) #3010\n  - A better rwlock implementation for all Windows versions\n  - Improved AIX support\n* v8:\n  - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) #3117\n  - Backported f782159 from v8's upstream to help speed up Promise\n    introspection (Ben Noordhuis) #3130\n  - Backported c281c15 from v8's upstream to add JSTypedArray length\n    in post-mortem metadata (Julien Gilli) #3031\n\nPR-URL: https://github.com/nodejs/node/pull/3128","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/820735d96743717d4d037caa96e56ff5886c73df"},{"sha":"59cb05339412893d8245a0cd2f83cf5487d13030","author":{"email":"e39d94bae70283f13d24c278e04952d6dad9384b@indutny.com","name":"Fedor Indutny"},"message":"http: add comment about `outputSize` in res/server\n\nPR-URL: https://github.com/nodejs/node/pull/3128","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/59cb05339412893d8245a0cd2f83cf5487d13030"},{"sha":"8593b3e8ebcb89b75d25ba0cb13a63d85b6f41b4","author":{"email":"0ce7911e6479995d6c346d6f03eb723b5135309e@evolvelabs.com","name":"Justin Chase"},"message":"module: use UNC paths when loading native addons\n\nWhen using require to load a native addon the path must be converted\ninto a long path, otherwise the addon will fail to be loaded on\nwindows if the path is longer than 260 characters.\n\nPR-URL: https://github.com/nodejs/node/pull/2965\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Benjamin Gruenbaum <inglor@gmail.com>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/8593b3e8ebcb89b75d25ba0cb13a63d85b6f41b4"},{"sha":"49dec1afd8c310d6995a62893d59b171e2f021cc","author":{"email":"86afcc11905a16fc7f55f47e39f4f6f84944afea@joyent.com","name":"Julien Gilli"},"message":"deps: backport 1ee712a from V8 upstream\n\nBackport 1ee712ab8687e5f4dec93d45da068d37d28feb8b from V8 upstream.\n\nOriginal commit message:\n\n  Add SetAbortOnUncaughtExceptionCallback API\n\n  The --abort-on-uncaught-exception command line switch makes\n  Isolate::Throw abort if the error being thrown cannot be caught by a\n  try/catch block.\n\n  Embedders may want to use other mechanisms than try/catch blocks to\n  handle uncaught exceptions. For instance, Node.js has \"domain\" objects\n  that have error handlers that can handle uncaught exception like\n  following:\n\n  var d = domain.create();\n\n  d.on('error', function onError(err) {\n    console.log('Handling error');\n  });\n\n  d.run(function() {\n    throw new Error(\"boom\");\n  });\n\n  These error handlers are called by isolates' message listeners.\n\n  If --abort-on-uncaught-exception is *not* used, the isolate's\n  message listener will be called, which will in turn call the domain's\n  error handler. The process will output 'Handling error' and will exit\n  successfully (not due to an uncaught exception). This is the behavior\n  that Node.js users expect.\n\n  However, if --abort-on-uncaught-exception is used and when throwing an\n  error within a domain that has an error handler, the process will abort\n  and the domain's error handler will not be called. This is not the\n  behavior that Node.js users expect.\n\n  Having a SetAbortOnUncaughtExceptionCallback API allows embedders to\n  determine when it's not appropriate to abort and instead handle the\n  exception via the isolate's message listener.\n\n  In the example above, Node.js would set a custom callback with\n  SetAbortOnUncaughtExceptionCallback that would be implemented as\n  following (the sample code has been simplified to remove what's not\n  relevant to this change):\n\n  bool ShouldAbortOnUncaughtException(Isolate* isolate) {\n    return !IsDomainActive();\n  }\n\n  Now when --abort-on-uncaught-exception is used, Isolate::Throw would\n  call that callback and determine that it should not abort if a domain\n  with an error handler is active. Instead, the isolate's message listener\n  would be called and the error would be handled by the domain's error\n  handler.\n\n  I believe this can also be useful for other embedders.\n\n  BUG=\n\n  R=bmeurer@chromium.org\n\n  Review URL: https://codereview.chromium.org/1375933003\n\n  Cr-Commit-Position: refs/heads/master@{#31111}\n\nPR: #3036\nPR-URL: https://github.com/nodejs/node/pull/3036\nReviewed-By: Ben Noordhuis <ben@strongloop.com>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/49dec1afd8c310d6995a62893d59b171e2f021cc"},{"sha":"77a10ed05f1e413818d29f07cbb268108b1f08fa","author":{"email":"c4ad3b66534c808c7ef6e533500d33268f829a51@apache.org","name":"Jeremy Whitlock"},"message":"src: fix --abort-on-uncaught-exception\n\nRevert 0af4c9ea7434e4f505dbe071357e4bc3b4ab2a8a, parts of\n921f2de6cf999b5a4663615e37967b4269d755fe and port\nhttps://github.com/nodejs/node-v0.x-archive/pull/25835 from v0.12 to\nmaster so that node aborts at the right time when an error is thrown\nand --abort-on-uncaught-exception is used.\n\nFixes #3035.\n\nPR: #3036\nPR-URL: https://github.com/nodejs/node/pull/3036\nReviewed-By: Ben Noordhuis <ben@strongloop.com>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/77a10ed05f1e413818d29f07cbb268108b1f08fa"},{"sha":"089d6886178864b56fdd5dc2bcfc8f207aa4326c","author":{"email":"ad0310dc5270cefb6ee6879263270aed9b1e9982@me.com","name":"Evan Lucas"},"message":"util: fix check for Array constructor\n\nIn the event an Array is created in a Debug context, the constructor\nwill be Array, but !== Array. This adds a check\nconstructor.name === 'Array' to handle edge cases like that.\n\nPR-URL: https://github.com/nodejs/node/pull/3119\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/089d6886178864b56fdd5dc2bcfc8f207aa4326c"},{"sha":"88533881dd296236a44ad36aa7afb8336298540f","author":{"email":"ad0310dc5270cefb6ee6879263270aed9b1e9982@me.com","name":"Evan Lucas"},"message":"util: correctly inspect Map/Set Iterators\n\nPreviously, a MapIterator or SetIterator would\nnot be inspected properly. This change makes it possible\nto inspect them by creating a Debug Mirror and previewing\nthe iterators to not consume the actual iterator that\nwe are trying to inspect.\n\nThis change also adds a node_util binding that uses\nv8's Value::IsSetIterator and Value::IsMapIterator\nto verify that the values passed in are actual iterators.\n\nFixes: https://github.com/nodejs/node/issues/3107\nPR-URL: https://github.com/nodejs/node/pull/3119\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/88533881dd296236a44ad36aa7afb8336298540f"},{"sha":"6ad458b752e2c2818244714e499e560f6e668c87","author":{"email":"b84950071fc99921a72f4fa56f6cad2496b3223c@gmail.com","name":"Sakthipriyan Vairamani"},"message":"module: remove unnecessary property and method\n\n`require.paths` property and `require.registerExtension` function have\nbeen throwing errors when used. They both are like this for years now.\nThis patch removes them from the system.\n\nPR-URL: https://github.com/nodejs/node/pull/2922\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/6ad458b752e2c2818244714e499e560f6e668c87"},{"sha":"070aac4a87a04380463da4f3730568c3bf5bf729","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"lib: remove redundant code, add tests in timers.js\n\ninsert() is only called from one place where there is already a check\nthat msecs is greater than or equal to zero, so do not repeat the check\ninside insert().\n\ntimers.active() is not documented and should not be exposed, but since\nit is exposed for now, let's test it.\n\nPR-URL: https://github.com/nodejs/node/pull/3143\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/070aac4a87a04380463da4f3730568c3bf5bf729"},{"sha":"81e98e9363c918899f964a6e054a41a82c04dc1b","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@silverwind.io","name":"Roman Reiss"},"message":"test: use normalize() for unicode paths\n\nOS X 10.11 changed the unicode normalization form of certain code points\nreturned by system calls like getcwd() from NFC to NFD which made\nresults in this test failing.\n\nThe consensus of https://github.com/nodejs/node/issues/2165 is to delegate\nthe task of unicode normalization to the user, and work will continue to\ndocument how to handle unicode in a form-sensitive file system.\n\nPR-URL: https://github.com/nodejs/node/pull/3007\nFixes: https://github.com/nodejs/node/issues/2165\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/81e98e9363c918899f964a6e054a41a82c04dc1b"},{"sha":"7d66749eca48eea7cbc3b0cd4b0ddf968224d2fb","author":{"email":"ad0310dc5270cefb6ee6879263270aed9b1e9982@me.com","name":"Evan Lucas"},"message":"test: speed up stringbytes-external test\n\ntest-stringbytes-external tends to take quite a while on slower\nhardware. A lot of the time is taken by creating a new buffer that is\nvery large. The improvements come from reusing the same buffer.\n\nPR-URL: https://github.com/nodejs/node/pull/3005\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Trevor Norris <trev.norris@gmail.com>\nReviewed-By: Roman Reiss <me@silverwind.io>","distinct":false,"url":"https://api.github.com/repos/Trott/io.js/commits/7d66749eca48eea7cbc3b0cd4b0ddf968224d2fb"},{"sha":"c2c0721be33251573cfa0ee7e17b11ca6260ea5c","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: load common.js in all tests\n\ncommon.js contains code that detects leaked variables.\n\nIn preparation for an eslint rule that will enforce loading common.js in\ntest files, load it everywhere it can be loaded and use an\n`eslint-disable` comment for files that intentionally leak.","distinct":true,"url":"https://api.github.com/repos/Trott/io.js/commits/c2c0721be33251573cfa0ee7e17b11ca6260ea5c"},{"sha":"34fc281d7ee407e3a4cc66af49b72902bdb0e7e1","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: make common.js mandatory via linting rule\n\ntest/common.js contains code that detects global variable leaks.\n\nThis eslint rule checks that a module named `common` is loaded. It is\nonly applicable to files in the test directory. Tests that intentionally\nleak variables can opt out with an eslint-disable comment.","distinct":true,"url":"https://api.github.com/repos/Trott/io.js/commits/34fc281d7ee407e3a4cc66af49b72902bdb0e7e1"}]}