{"action":"created","comment":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/33136680","id":33136680,"diff_hunk":"@@ -71,3 +71,16 @@ def get_project_settings():\n         settings.setdict(env_overrides, priority='project')\n \n     return settings\n+\n+def get_project_path():\n+    \"\"\"Return the Python path of the current project\"\"\"\n+    # XXX: This is far from optimal. It fails when the settings module lives\n+    #      outside of the project package, and when the project package lives\n+    #      within another package.\n+    if not inside_project():\n+        raise NotConfigured(\"Not inside a project\")\n+    settings_module_path = os.environ.get(ENVVAR)\n+    if not settings_module_path:\n+        raise NotConfigured(\"Unable to locate project's python path\")\n+    return settings_module_path.split('.')[0]","path":"scrapy/utils/project.py","position":15,"original_position":15,"commit_id":"4172df9f4f1bd86eb21b5a1a8408448b3cbe3f41","original_commit_id":"4172df9f4f1bd86eb21b5a1a8408448b3cbe3f41","user":{"login":"jdemaeyer","id":10531844,"avatar_url":"https://avatars.githubusercontent.com/u/10531844?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemaeyer","html_url":"https://github.com/jdemaeyer","followers_url":"https://api.github.com/users/jdemaeyer/followers","following_url":"https://api.github.com/users/jdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemaeyer/orgs","repos_url":"https://api.github.com/users/jdemaeyer/repos","events_url":"https://api.github.com/users/jdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemaeyer/received_events","type":"User","site_admin":false},"body":"Really unsure about this :/","created_at":"2015-06-24T10:53:09Z","updated_at":"2015-06-24T10:53:09Z","html_url":"https://github.com/scrapy/scrapy/pull/1272#discussion_r33136680","pull_request_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1272","_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/33136680"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1272#discussion_r33136680"},"pull_request":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1272"}}},"pull_request":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/1272","id":36641741,"html_url":"https://github.com/scrapy/scrapy/pull/1272","diff_url":"https://github.com/scrapy/scrapy/pull/1272.diff","patch_url":"https://github.com/scrapy/scrapy/pull/1272.patch","issue_url":"https://api.github.com/repos/scrapy/scrapy/issues/1272","number":1272,"state":"open","locked":false,"title":"[WIP] Add-ons","user":{"login":"jdemaeyer","id":10531844,"avatar_url":"https://avatars.githubusercontent.com/u/10531844?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemaeyer","html_url":"https://github.com/jdemaeyer","followers_url":"https://api.github.com/users/jdemaeyer/followers","following_url":"https://api.github.com/users/jdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemaeyer/orgs","repos_url":"https://api.github.com/users/jdemaeyer/repos","events_url":"https://api.github.com/users/jdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemaeyer/received_events","type":"User","site_admin":false},"body":"I will be working on an implementation of #591 in this PR. This is my GSoC project :)\r\n\r\nAs of now, I did a large redraft of the SEP following the discussion in #591 and [my proposal](https://gist.github.com/jdemaeyer/7802befad56fa59fcfe1). It contains my current plan for the implementation, but there are many open issues (see #591) and I would love some feedback. /cc @Curita @nyov @pablohoffman ","created_at":"2015-06-01T15:44:52Z","updated_at":"2015-06-24T10:53:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"112bc3e8b1c8f2b97a2ee4bc11879b5308b337fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1272/commits","review_comments_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1272/comments","review_comment_url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapy/scrapy/issues/1272/comments","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/4172df9f4f1bd86eb21b5a1a8408448b3cbe3f41","head":{"label":"jdemaeyer:enhancement/addons","ref":"enhancement/addons","sha":"4172df9f4f1bd86eb21b5a1a8408448b3cbe3f41","user":{"login":"jdemaeyer","id":10531844,"avatar_url":"https://avatars.githubusercontent.com/u/10531844?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemaeyer","html_url":"https://github.com/jdemaeyer","followers_url":"https://api.github.com/users/jdemaeyer/followers","following_url":"https://api.github.com/users/jdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemaeyer/orgs","repos_url":"https://api.github.com/users/jdemaeyer/repos","events_url":"https://api.github.com/users/jdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemaeyer/received_events","type":"User","site_admin":false},"repo":{"id":32859911,"name":"scrapy","full_name":"jdemaeyer/scrapy","owner":{"login":"jdemaeyer","id":10531844,"avatar_url":"https://avatars.githubusercontent.com/u/10531844?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemaeyer","html_url":"https://github.com/jdemaeyer","followers_url":"https://api.github.com/users/jdemaeyer/followers","following_url":"https://api.github.com/users/jdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemaeyer/orgs","repos_url":"https://api.github.com/users/jdemaeyer/repos","events_url":"https://api.github.com/users/jdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemaeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdemaeyer/scrapy","description":"Scrapy, a fast high-level web crawling and screen scraping framework for Python.","fork":true,"url":"https://api.github.com/repos/jdemaeyer/scrapy","forks_url":"https://api.github.com/repos/jdemaeyer/scrapy/forks","keys_url":"https://api.github.com/repos/jdemaeyer/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdemaeyer/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdemaeyer/scrapy/teams","hooks_url":"https://api.github.com/repos/jdemaeyer/scrapy/hooks","issue_events_url":"https://api.github.com/repos/jdemaeyer/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/jdemaeyer/scrapy/events","assignees_url":"https://api.github.com/repos/jdemaeyer/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/jdemaeyer/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/jdemaeyer/scrapy/tags","blobs_url":"https://api.github.com/repos/jdemaeyer/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdemaeyer/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdemaeyer/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdemaeyer/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdemaeyer/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/jdemaeyer/scrapy/languages","stargazers_url":"https://api.github.com/repos/jdemaeyer/scrapy/stargazers","contributors_url":"https://api.github.com/repos/jdemaeyer/scrapy/contributors","subscribers_url":"https://api.github.com/repos/jdemaeyer/scrapy/subscribers","subscription_url":"https://api.github.com/repos/jdemaeyer/scrapy/subscription","commits_url":"https://api.github.com/repos/jdemaeyer/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdemaeyer/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdemaeyer/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdemaeyer/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdemaeyer/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/jdemaeyer/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdemaeyer/scrapy/merges","archive_url":"https://api.github.com/repos/jdemaeyer/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdemaeyer/scrapy/downloads","issues_url":"https://api.github.com/repos/jdemaeyer/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/jdemaeyer/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/jdemaeyer/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/jdemaeyer/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdemaeyer/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/jdemaeyer/scrapy/releases{/id}","created_at":"2015-03-25T11:16:59Z","updated_at":"2015-03-25T11:17:02Z","pushed_at":"2015-06-24T10:35:28Z","git_url":"git://github.com/jdemaeyer/scrapy.git","ssh_url":"git@github.com:jdemaeyer/scrapy.git","clone_url":"https://github.com/jdemaeyer/scrapy.git","svn_url":"https://github.com/jdemaeyer/scrapy","homepage":"http://scrapy.org","size":14331,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scrapy:master","ref":"master","sha":"87293965db68e0ef1fa186a5d729ea82482c2f27","user":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"repo":{"id":529502,"name":"scrapy","full_name":"scrapy/scrapy","owner":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapy/scrapy","description":"Scrapy, a fast high-level web crawling & scraping framework for Python.","fork":false,"url":"https://api.github.com/repos/scrapy/scrapy","forks_url":"https://api.github.com/repos/scrapy/scrapy/forks","keys_url":"https://api.github.com/repos/scrapy/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapy/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapy/scrapy/teams","hooks_url":"https://api.github.com/repos/scrapy/scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapy/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapy/scrapy/events","assignees_url":"https://api.github.com/repos/scrapy/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapy/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapy/scrapy/tags","blobs_url":"https://api.github.com/repos/scrapy/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapy/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapy/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapy/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapy/scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapy/scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapy/scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapy/scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapy/scrapy/subscription","commits_url":"https://api.github.com/repos/scrapy/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapy/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapy/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapy/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapy/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapy/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapy/scrapy/merges","archive_url":"https://api.github.com/repos/scrapy/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapy/scrapy/downloads","issues_url":"https://api.github.com/repos/scrapy/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapy/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapy/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapy/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapy/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapy/scrapy/releases{/id}","created_at":"2010-02-22T02:01:14Z","updated_at":"2015-06-24T09:51:34Z","pushed_at":"2015-06-24T10:35:35Z","git_url":"git://github.com/scrapy/scrapy.git","ssh_url":"git@github.com:scrapy/scrapy.git","clone_url":"https://github.com/scrapy/scrapy.git","svn_url":"https://github.com/scrapy/scrapy","homepage":"http://scrapy.org","size":26517,"stargazers_count":9102,"watchers_count":9102,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2607,"mirror_url":null,"open_issues_count":259,"forks":2607,"open_issues":259,"watchers":9102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1272"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1272"},"issue":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1272"},"comments":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1272/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1272/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1272/commits"},"statuses":{"href":"https://api.github.com/repos/scrapy/scrapy/statuses/4172df9f4f1bd86eb21b5a1a8408448b3cbe3f41"}}}}