{"action":"created","issue":{"url":"https://api.github.com/repos/YafaRay/Core/issues/88","labels_url":"https://api.github.com/repos/YafaRay/Core/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/YafaRay/Core/issues/88/comments","events_url":"https://api.github.com/repos/YafaRay/Core/issues/88/events","html_url":"https://github.com/YafaRay/Core/pull/88","id":95518679,"number":88,"title":"Fix for white dots in path tracing and transparent texture","user":{"login":"DavidBluecame","id":3886025,"avatar_url":"https://avatars.githubusercontent.com/u/3886025?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidBluecame","html_url":"https://github.com/DavidBluecame","followers_url":"https://api.github.com/users/DavidBluecame/followers","following_url":"https://api.github.com/users/DavidBluecame/following{/other_user}","gists_url":"https://api.github.com/users/DavidBluecame/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBluecame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBluecame/subscriptions","organizations_url":"https://api.github.com/users/DavidBluecame/orgs","repos_url":"https://api.github.com/users/DavidBluecame/repos","events_url":"https://api.github.com/users/DavidBluecame/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBluecame/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-16T20:19:11Z","updated_at":"2015-09-23T19:57:19Z","closed_at":"2015-09-23T19:56:32Z","pull_request":{"url":"https://api.github.com/repos/YafaRay/Core/pulls/88","html_url":"https://github.com/YafaRay/Core/pull/88","diff_url":"https://github.com/YafaRay/Core/pull/88.diff","patch_url":"https://github.com/YafaRay/Core/pull/88.patch"},"body":"This change tries to fix the white dots in path tracing with shiny diffuse with transparent PNG texture and transparent shadows, especially in Win32, (maybe a precision problem?).\r\n\r\nFor examples and images see:\r\nhttp://www.yafaray.org/node/662\r\n\r\nIt's not yet clear why this happens, but sometimes the first sampling does not take place and pRay.dir is not initialized, so before this change when that happened pwo = -pRay.dir was getting a random non-initialized value! This fix makes that, if the first sample fails for some reason, pwo is not modified and the rest of the sampling continues with the same pwo value.\r\n\r\nHowever, several questions remain:\r\n* Why is this happening?? I have seen it happening in Linux 64 in smaller scale, but much worse in Windows 32 bit.\r\n* If the first sample fails, should we continue as now or should we exit the loop with the \"continue\" command?\r\n\r\n Changes to be committed:\r\n\tmodified:   src/integrators/pathtracer.cc"},"comment":{"url":"https://api.github.com/repos/YafaRay/Core/issues/comments/142711250","html_url":"https://github.com/YafaRay/Core/pull/88#issuecomment-142711250","issue_url":"https://api.github.com/repos/YafaRay/Core/issues/88","id":142711250,"user":{"login":"DarkTide","id":254560,"avatar_url":"https://avatars.githubusercontent.com/u/254560?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkTide","html_url":"https://github.com/DarkTide","followers_url":"https://api.github.com/users/DarkTide/followers","following_url":"https://api.github.com/users/DarkTide/following{/other_user}","gists_url":"https://api.github.com/users/DarkTide/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkTide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkTide/subscriptions","organizations_url":"https://api.github.com/users/DarkTide/orgs","repos_url":"https://api.github.com/users/DarkTide/repos","events_url":"https://api.github.com/users/DarkTide/events{/privacy}","received_events_url":"https://api.github.com/users/DarkTide/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T19:57:19Z","updated_at":"2015-09-23T19:57:19Z","body":"We should trace the source of this uninitialized sample, not sure how though... i'll think of something and keep you posted"}}