{"action":"closed","issue":{"url":"https://api.github.com/repos/OrchardCMS/Brochard/issues/11","labels_url":"https://api.github.com/repos/OrchardCMS/Brochard/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/Brochard/issues/11/comments","events_url":"https://api.github.com/repos/OrchardCMS/Brochard/issues/11/events","html_url":"https://github.com/OrchardCMS/Brochard/issues/11","id":56076651,"number":11,"title":"Extra overloading Fetch methods using AsNoTracking() ","user":{"login":"jersiovic","id":4950766,"avatar_url":"https://avatars.githubusercontent.com/u/4950766?v=3","gravatar_id":"","url":"https://api.github.com/users/jersiovic","html_url":"https://github.com/jersiovic","followers_url":"https://api.github.com/users/jersiovic/followers","following_url":"https://api.github.com/users/jersiovic/following{/other_user}","gists_url":"https://api.github.com/users/jersiovic/gists{/gist_id}","starred_url":"https://api.github.com/users/jersiovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jersiovic/subscriptions","organizations_url":"https://api.github.com/users/jersiovic/orgs","repos_url":"https://api.github.com/users/jersiovic/repos","events_url":"https://api.github.com/users/jersiovic/events{/privacy}","received_events_url":"https://api.github.com/users/jersiovic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OrchardCMS/Brochard/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"Jetski5822","id":619530,"avatar_url":"https://avatars.githubusercontent.com/u/619530?v=3","gravatar_id":"","url":"https://api.github.com/users/Jetski5822","html_url":"https://github.com/Jetski5822","followers_url":"https://api.github.com/users/Jetski5822/followers","following_url":"https://api.github.com/users/Jetski5822/following{/other_user}","gists_url":"https://api.github.com/users/Jetski5822/gists{/gist_id}","starred_url":"https://api.github.com/users/Jetski5822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jetski5822/subscriptions","organizations_url":"https://api.github.com/users/Jetski5822/orgs","repos_url":"https://api.github.com/users/Jetski5822/repos","events_url":"https://api.github.com/users/Jetski5822/events{/privacy}","received_events_url":"https://api.github.com/users/Jetski5822/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/OrchardCMS/Brochard/milestones/1","html_url":"https://github.com/OrchardCMS/Brochard/milestones/Data%20layer","labels_url":"https://api.github.com/repos/OrchardCMS/Brochard/milestones/1/labels","id":961211,"number":1,"title":"Data layer","description":"","creator":{"login":"Jetski5822","id":619530,"avatar_url":"https://avatars.githubusercontent.com/u/619530?v=3","gravatar_id":"","url":"https://api.github.com/users/Jetski5822","html_url":"https://github.com/Jetski5822","followers_url":"https://api.github.com/users/Jetski5822/followers","following_url":"https://api.github.com/users/Jetski5822/following{/other_user}","gists_url":"https://api.github.com/users/Jetski5822/gists{/gist_id}","starred_url":"https://api.github.com/users/Jetski5822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jetski5822/subscriptions","organizations_url":"https://api.github.com/users/Jetski5822/orgs","repos_url":"https://api.github.com/users/Jetski5822/repos","events_url":"https://api.github.com/users/Jetski5822/events{/privacy}","received_events_url":"https://api.github.com/users/Jetski5822/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2015-02-02T10:59:44Z","updated_at":"2015-06-29T12:42:13Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-01-30T19:50:42Z","updated_at":"2015-06-29T12:42:13Z","closed_at":"2015-06-29T12:42:13Z","body":"What do you think of offering extra overloads for Fetch methods that use AsNoTracking in order to improve performance?\r\n\r\n        public virtual IQueryable<T> FetchWithNoTracking(Expression<Func<T, bool>> predicate)\r\n        {\r\n            return Table.AsNoTracking().Where(predicate);\r\n        }\r\n\r\nIndeed in order to help devs to don't forget to use the most most optimal one I would use:\r\n```\r\npublic virtual IQueryable<T> Fetch(Expression<Func<T, bool>> predicate)\r\n        {\r\n            return Table.AsNoTracking().Where(predicate);\r\n        }\r\n\r\npublic virtual IQueryable<T> FetchWithTracking(Expression<Func<T, bool>> predicate) {\r\n            return Table.Where(predicate);\r\n        }\r\n```\r\nProblem is it is a breaking change, so to avoid unnoticed bad uses of the Fech method maybe it will be better to remove Fech method and only have FetchWithTracking and FetchWithNoTracking methods.\r\n\r\nWhat do you think?\r\n"}}