{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/31932230","id":31932230,"diff_hunk":"@@ -246,6 +247,11 @@ def get_response(self, request):\n \n         response._closable_objects.append(request)\n \n+        # If the exception handler is a CBV, then force template to render.\n+        if rendered is False:","path":"django/core/handlers/base.py","position":13,"original_position":13,"commit_id":"84f4dedc3bdeace4b5c281528f6e0aed3fadcad9","original_commit_id":"84f4dedc3bdeace4b5c281528f6e0aed3fadcad9","user":{"login":"MarkusH","id":475613,"avatar_url":"https://avatars.githubusercontent.com/u/475613?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusH","html_url":"https://github.com/MarkusH","followers_url":"https://api.github.com/users/MarkusH/followers","following_url":"https://api.github.com/users/MarkusH/following{/other_user}","gists_url":"https://api.github.com/users/MarkusH/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusH/subscriptions","organizations_url":"https://api.github.com/users/MarkusH/orgs","repos_url":"https://api.github.com/users/MarkusH/repos","events_url":"https://api.github.com/users/MarkusH/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusH/received_events","type":"User","site_admin":false},"body":"`if not rendered` is fine :)","created_at":"2015-06-08T16:24:05Z","updated_at":"2015-06-08T16:24:05Z","html_url":"https://github.com/django/django/pull/4777#discussion_r31932230","pull_request_url":"https://api.github.com/repos/django/django/pulls/4777","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/31932230"},"html":{"href":"https://github.com/django/django/pull/4777#discussion_r31932230"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/4777"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/4777","id":36953647,"html_url":"https://github.com/django/django/pull/4777","diff_url":"https://github.com/django/django/pull/4777.diff","patch_url":"https://github.com/django/django/pull/4777.patch","issue_url":"https://api.github.com/repos/django/django/issues/4777","number":4777,"state":"open","locked":false,"title":"Fixed #24829 -- Allowed usage of TemplateResponse in error handlers","user":{"login":"ana-balica","id":2039122,"avatar_url":"https://avatars.githubusercontent.com/u/2039122?v=3","gravatar_id":"","url":"https://api.github.com/users/ana-balica","html_url":"https://github.com/ana-balica","followers_url":"https://api.github.com/users/ana-balica/followers","following_url":"https://api.github.com/users/ana-balica/following{/other_user}","gists_url":"https://api.github.com/users/ana-balica/gists{/gist_id}","starred_url":"https://api.github.com/users/ana-balica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ana-balica/subscriptions","organizations_url":"https://api.github.com/users/ana-balica/orgs","repos_url":"https://api.github.com/users/ana-balica/repos","events_url":"https://api.github.com/users/ana-balica/events{/privacy}","received_events_url":"https://api.github.com/users/ana-balica/received_events","type":"User","site_admin":false},"body":"https://code.djangoproject.com/ticket/24829\r\n\r\nIf a class based generic view is specified as an error handler, the template is\r\nsupposed to be rendered in advance, otherwise it raises\r\nContentNotRenderedError.","created_at":"2015-06-04T16:39:29Z","updated_at":"2015-06-08T16:24:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98868b3ab189e04b7c81fdf2af6b1235578b9ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/4777/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/4777/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/4777/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/84f4dedc3bdeace4b5c281528f6e0aed3fadcad9","head":{"label":"ana-balica:ticket_24829","ref":"ticket_24829","sha":"84f4dedc3bdeace4b5c281528f6e0aed3fadcad9","user":{"login":"ana-balica","id":2039122,"avatar_url":"https://avatars.githubusercontent.com/u/2039122?v=3","gravatar_id":"","url":"https://api.github.com/users/ana-balica","html_url":"https://github.com/ana-balica","followers_url":"https://api.github.com/users/ana-balica/followers","following_url":"https://api.github.com/users/ana-balica/following{/other_user}","gists_url":"https://api.github.com/users/ana-balica/gists{/gist_id}","starred_url":"https://api.github.com/users/ana-balica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ana-balica/subscriptions","organizations_url":"https://api.github.com/users/ana-balica/orgs","repos_url":"https://api.github.com/users/ana-balica/repos","events_url":"https://api.github.com/users/ana-balica/events{/privacy}","received_events_url":"https://api.github.com/users/ana-balica/received_events","type":"User","site_admin":false},"repo":{"id":36858362,"name":"django","full_name":"ana-balica/django","owner":{"login":"ana-balica","id":2039122,"avatar_url":"https://avatars.githubusercontent.com/u/2039122?v=3","gravatar_id":"","url":"https://api.github.com/users/ana-balica","html_url":"https://github.com/ana-balica","followers_url":"https://api.github.com/users/ana-balica/followers","following_url":"https://api.github.com/users/ana-balica/following{/other_user}","gists_url":"https://api.github.com/users/ana-balica/gists{/gist_id}","starred_url":"https://api.github.com/users/ana-balica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ana-balica/subscriptions","organizations_url":"https://api.github.com/users/ana-balica/orgs","repos_url":"https://api.github.com/users/ana-balica/repos","events_url":"https://api.github.com/users/ana-balica/events{/privacy}","received_events_url":"https://api.github.com/users/ana-balica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ana-balica/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/ana-balica/django","forks_url":"https://api.github.com/repos/ana-balica/django/forks","keys_url":"https://api.github.com/repos/ana-balica/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ana-balica/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ana-balica/django/teams","hooks_url":"https://api.github.com/repos/ana-balica/django/hooks","issue_events_url":"https://api.github.com/repos/ana-balica/django/issues/events{/number}","events_url":"https://api.github.com/repos/ana-balica/django/events","assignees_url":"https://api.github.com/repos/ana-balica/django/assignees{/user}","branches_url":"https://api.github.com/repos/ana-balica/django/branches{/branch}","tags_url":"https://api.github.com/repos/ana-balica/django/tags","blobs_url":"https://api.github.com/repos/ana-balica/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ana-balica/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ana-balica/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/ana-balica/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ana-balica/django/statuses/{sha}","languages_url":"https://api.github.com/repos/ana-balica/django/languages","stargazers_url":"https://api.github.com/repos/ana-balica/django/stargazers","contributors_url":"https://api.github.com/repos/ana-balica/django/contributors","subscribers_url":"https://api.github.com/repos/ana-balica/django/subscribers","subscription_url":"https://api.github.com/repos/ana-balica/django/subscription","commits_url":"https://api.github.com/repos/ana-balica/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/ana-balica/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/ana-balica/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/ana-balica/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/ana-balica/django/contents/{+path}","compare_url":"https://api.github.com/repos/ana-balica/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ana-balica/django/merges","archive_url":"https://api.github.com/repos/ana-balica/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ana-balica/django/downloads","issues_url":"https://api.github.com/repos/ana-balica/django/issues{/number}","pulls_url":"https://api.github.com/repos/ana-balica/django/pulls{/number}","milestones_url":"https://api.github.com/repos/ana-balica/django/milestones{/number}","notifications_url":"https://api.github.com/repos/ana-balica/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ana-balica/django/labels{/name}","releases_url":"https://api.github.com/repos/ana-balica/django/releases{/id}","created_at":"2015-06-04T08:35:41Z","updated_at":"2015-06-04T08:35:56Z","pushed_at":"2015-06-08T15:57:31Z","git_url":"git://github.com/ana-balica/django.git","ssh_url":"git@github.com:ana-balica/django.git","clone_url":"https://github.com/ana-balica/django.git","svn_url":"https://github.com/ana-balica/django","homepage":"https://www.djangoproject.com/","size":140451,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"167a3203b645341a3b00b878594bfd8d4dd6b040","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-06-08T14:40:16Z","pushed_at":"2015-06-08T15:57:35Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":296340,"stargazers_count":14548,"watchers_count":14548,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5812,"mirror_url":null,"open_issues_count":91,"forks":5812,"open_issues":91,"watchers":14548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/4777"},"html":{"href":"https://github.com/django/django/pull/4777"},"issue":{"href":"https://api.github.com/repos/django/django/issues/4777"},"comments":{"href":"https://api.github.com/repos/django/django/issues/4777/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/4777/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/4777/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/84f4dedc3bdeace4b5c281528f6e0aed3fadcad9"}}}}