{"action":"created","comment":{"url":"https://api.github.com/repos/krb5/krb5/pulls/comments/48462657","id":48462657,"diff_hunk":"@@ -108,6 +108,15 @@ struct setkey3_arg {\n };\n typedef struct setkey3_arg setkey3_arg;\n \n+struct setkey4_arg {\n+\tkrb5_ui_4 api_version;\n+\tkrb5_principal princ;\n+\tkrb5_boolean keepold;\n+\tkadm5_key_data *key_data;\n+\tint n_key_data;\n+};","path":"src/lib/kadm5/kadm_rpc.h","position":10,"original_position":10,"commit_id":"b966f2bce6a1971b2855dae4be56e3dfc7b88d07","original_commit_id":"b966f2bce6a1971b2855dae4be56e3dfc7b88d07","user":{"login":"nicowilliams","id":604851,"avatar_url":"https://avatars.githubusercontent.com/u/604851?v=3","gravatar_id":"","url":"https://api.github.com/users/nicowilliams","html_url":"https://github.com/nicowilliams","followers_url":"https://api.github.com/users/nicowilliams/followers","following_url":"https://api.github.com/users/nicowilliams/following{/other_user}","gists_url":"https://api.github.com/users/nicowilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/nicowilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicowilliams/subscriptions","organizations_url":"https://api.github.com/users/nicowilliams/orgs","repos_url":"https://api.github.com/users/nicowilliams/repos","events_url":"https://api.github.com/users/nicowilliams/events{/privacy}","received_events_url":"https://api.github.com/users/nicowilliams/received_events","type":"User","site_admin":false},"body":"I strongly encourage you to add that one argument (do/don't change the principal's current kvno).\r\n\r\nAlso, will it be the case that the `key_data` argument can contain keys of unspecified kvno to mean \"add this as the next kvno\"?","created_at":"2015-12-28T04:19:27Z","updated_at":"2015-12-28T04:19:27Z","html_url":"https://github.com/krb5/krb5/pull/375#discussion_r48462657","pull_request_url":"https://api.github.com/repos/krb5/krb5/pulls/375","_links":{"self":{"href":"https://api.github.com/repos/krb5/krb5/pulls/comments/48462657"},"html":{"href":"https://github.com/krb5/krb5/pull/375#discussion_r48462657"},"pull_request":{"href":"https://api.github.com/repos/krb5/krb5/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/krb5/krb5/pulls/375","id":54169292,"html_url":"https://github.com/krb5/krb5/pull/375","diff_url":"https://github.com/krb5/krb5/pull/375.diff","patch_url":"https://github.com/krb5/krb5/pull/375.patch","issue_url":"https://api.github.com/repos/krb5/krb5/issues/375","number":375,"state":"open","locked":false,"title":"Kadmin set and extract keys with lockdown","user":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"body":"This patchset adds a number of features around key material in kdamin.\r\n1. A new setkey operation that allows to properly store salts.\r\n2. A new get_principal_keys operation protected by a new ACL_EXTRACT acl to retrieve stored keys\r\n3. A new principal attribute named KRB5_KDB_LOCKDOWN_KEYS that loks down keys and prevent\r\nany change or operation that would allow an admin to retrieve keys or set arbitrary keys including delete or renaming of a principal.\r\n\r\nAdditionally some tests have been added/modified to check these operations. ","created_at":"2015-12-19T02:40:17Z","updated_at":"2015-12-28T04:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adf502925d0a385e5eb45a43d3eacc2240efc08b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krb5/krb5/pulls/375/commits","review_comments_url":"https://api.github.com/repos/krb5/krb5/pulls/375/comments","review_comment_url":"https://api.github.com/repos/krb5/krb5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krb5/krb5/issues/375/comments","statuses_url":"https://api.github.com/repos/krb5/krb5/statuses/b966f2bce6a1971b2855dae4be56e3dfc7b88d07","head":{"label":"simo5:kadmin_keydata","ref":"kadmin_keydata","sha":"b966f2bce6a1971b2855dae4be56e3dfc7b88d07","user":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"repo":{"id":36983242,"name":"krb5","full_name":"simo5/krb5","owner":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simo5/krb5","description":"mirror of MIT krb5 repository","fork":true,"url":"https://api.github.com/repos/simo5/krb5","forks_url":"https://api.github.com/repos/simo5/krb5/forks","keys_url":"https://api.github.com/repos/simo5/krb5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simo5/krb5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simo5/krb5/teams","hooks_url":"https://api.github.com/repos/simo5/krb5/hooks","issue_events_url":"https://api.github.com/repos/simo5/krb5/issues/events{/number}","events_url":"https://api.github.com/repos/simo5/krb5/events","assignees_url":"https://api.github.com/repos/simo5/krb5/assignees{/user}","branches_url":"https://api.github.com/repos/simo5/krb5/branches{/branch}","tags_url":"https://api.github.com/repos/simo5/krb5/tags","blobs_url":"https://api.github.com/repos/simo5/krb5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simo5/krb5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simo5/krb5/git/refs{/sha}","trees_url":"https://api.github.com/repos/simo5/krb5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simo5/krb5/statuses/{sha}","languages_url":"https://api.github.com/repos/simo5/krb5/languages","stargazers_url":"https://api.github.com/repos/simo5/krb5/stargazers","contributors_url":"https://api.github.com/repos/simo5/krb5/contributors","subscribers_url":"https://api.github.com/repos/simo5/krb5/subscribers","subscription_url":"https://api.github.com/repos/simo5/krb5/subscription","commits_url":"https://api.github.com/repos/simo5/krb5/commits{/sha}","git_commits_url":"https://api.github.com/repos/simo5/krb5/git/commits{/sha}","comments_url":"https://api.github.com/repos/simo5/krb5/comments{/number}","issue_comment_url":"https://api.github.com/repos/simo5/krb5/issues/comments{/number}","contents_url":"https://api.github.com/repos/simo5/krb5/contents/{+path}","compare_url":"https://api.github.com/repos/simo5/krb5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simo5/krb5/merges","archive_url":"https://api.github.com/repos/simo5/krb5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simo5/krb5/downloads","issues_url":"https://api.github.com/repos/simo5/krb5/issues{/number}","pulls_url":"https://api.github.com/repos/simo5/krb5/pulls{/number}","milestones_url":"https://api.github.com/repos/simo5/krb5/milestones{/number}","notifications_url":"https://api.github.com/repos/simo5/krb5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simo5/krb5/labels{/name}","releases_url":"https://api.github.com/repos/simo5/krb5/releases{/id}","created_at":"2015-06-06T14:37:41Z","updated_at":"2015-06-06T14:37:51Z","pushed_at":"2015-12-21T05:48:00Z","git_url":"git://github.com/simo5/krb5.git","ssh_url":"git@github.com:simo5/krb5.git","clone_url":"https://github.com/simo5/krb5.git","svn_url":"https://github.com/simo5/krb5","homepage":null,"size":65822,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krb5:master","ref":"master","sha":"29255471d67077ac6f4ff8f06391e851e6451db7","user":{"login":"krb5","id":523797,"avatar_url":"https://avatars.githubusercontent.com/u/523797?v=3","gravatar_id":"","url":"https://api.github.com/users/krb5","html_url":"https://github.com/krb5","followers_url":"https://api.github.com/users/krb5/followers","following_url":"https://api.github.com/users/krb5/following{/other_user}","gists_url":"https://api.github.com/users/krb5/gists{/gist_id}","starred_url":"https://api.github.com/users/krb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krb5/subscriptions","organizations_url":"https://api.github.com/users/krb5/orgs","repos_url":"https://api.github.com/users/krb5/repos","events_url":"https://api.github.com/users/krb5/events{/privacy}","received_events_url":"https://api.github.com/users/krb5/received_events","type":"Organization","site_admin":false},"repo":{"id":4307702,"name":"krb5","full_name":"krb5/krb5","owner":{"login":"krb5","id":523797,"avatar_url":"https://avatars.githubusercontent.com/u/523797?v=3","gravatar_id":"","url":"https://api.github.com/users/krb5","html_url":"https://github.com/krb5","followers_url":"https://api.github.com/users/krb5/followers","following_url":"https://api.github.com/users/krb5/following{/other_user}","gists_url":"https://api.github.com/users/krb5/gists{/gist_id}","starred_url":"https://api.github.com/users/krb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krb5/subscriptions","organizations_url":"https://api.github.com/users/krb5/orgs","repos_url":"https://api.github.com/users/krb5/repos","events_url":"https://api.github.com/users/krb5/events{/privacy}","received_events_url":"https://api.github.com/users/krb5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krb5/krb5","description":"mirror of MIT krb5 repository","fork":false,"url":"https://api.github.com/repos/krb5/krb5","forks_url":"https://api.github.com/repos/krb5/krb5/forks","keys_url":"https://api.github.com/repos/krb5/krb5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krb5/krb5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krb5/krb5/teams","hooks_url":"https://api.github.com/repos/krb5/krb5/hooks","issue_events_url":"https://api.github.com/repos/krb5/krb5/issues/events{/number}","events_url":"https://api.github.com/repos/krb5/krb5/events","assignees_url":"https://api.github.com/repos/krb5/krb5/assignees{/user}","branches_url":"https://api.github.com/repos/krb5/krb5/branches{/branch}","tags_url":"https://api.github.com/repos/krb5/krb5/tags","blobs_url":"https://api.github.com/repos/krb5/krb5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krb5/krb5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krb5/krb5/git/refs{/sha}","trees_url":"https://api.github.com/repos/krb5/krb5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krb5/krb5/statuses/{sha}","languages_url":"https://api.github.com/repos/krb5/krb5/languages","stargazers_url":"https://api.github.com/repos/krb5/krb5/stargazers","contributors_url":"https://api.github.com/repos/krb5/krb5/contributors","subscribers_url":"https://api.github.com/repos/krb5/krb5/subscribers","subscription_url":"https://api.github.com/repos/krb5/krb5/subscription","commits_url":"https://api.github.com/repos/krb5/krb5/commits{/sha}","git_commits_url":"https://api.github.com/repos/krb5/krb5/git/commits{/sha}","comments_url":"https://api.github.com/repos/krb5/krb5/comments{/number}","issue_comment_url":"https://api.github.com/repos/krb5/krb5/issues/comments{/number}","contents_url":"https://api.github.com/repos/krb5/krb5/contents/{+path}","compare_url":"https://api.github.com/repos/krb5/krb5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krb5/krb5/merges","archive_url":"https://api.github.com/repos/krb5/krb5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krb5/krb5/downloads","issues_url":"https://api.github.com/repos/krb5/krb5/issues{/number}","pulls_url":"https://api.github.com/repos/krb5/krb5/pulls{/number}","milestones_url":"https://api.github.com/repos/krb5/krb5/milestones{/number}","notifications_url":"https://api.github.com/repos/krb5/krb5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krb5/krb5/labels{/name}","releases_url":"https://api.github.com/repos/krb5/krb5/releases{/id}","created_at":"2012-05-12T16:01:32Z","updated_at":"2015-12-16T03:46:25Z","pushed_at":"2015-12-28T03:50:28Z","git_url":"git://github.com/krb5/krb5.git","ssh_url":"git@github.com:krb5/krb5.git","clone_url":"https://github.com/krb5/krb5.git","svn_url":"https://github.com/krb5/krb5","homepage":null,"size":66806,"stargazers_count":82,"watchers_count":82,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":20,"forks":103,"open_issues":20,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krb5/krb5/pulls/375"},"html":{"href":"https://github.com/krb5/krb5/pull/375"},"issue":{"href":"https://api.github.com/repos/krb5/krb5/issues/375"},"comments":{"href":"https://api.github.com/repos/krb5/krb5/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/krb5/krb5/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/krb5/krb5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krb5/krb5/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/krb5/krb5/statuses/b966f2bce6a1971b2855dae4be56e3dfc7b88d07"}}}}