{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/mcuadros/go-syslog/pulls/17","id":39110258,"html_url":"https://github.com/mcuadros/go-syslog/pull/17","diff_url":"https://github.com/mcuadros/go-syslog/pull/17.diff","patch_url":"https://github.com/mcuadros/go-syslog/pull/17.patch","issue_url":"https://api.github.com/repos/mcuadros/go-syslog/issues/17","number":17,"state":"closed","locked":false,"title":"Do not use scanner to process datagrams; implement datagram channel","user":{"login":"abligh","id":1240226,"avatar_url":"https://avatars.githubusercontent.com/u/1240226?v=3","gravatar_id":"","url":"https://api.github.com/users/abligh","html_url":"https://github.com/abligh","followers_url":"https://api.github.com/users/abligh/followers","following_url":"https://api.github.com/users/abligh/following{/other_user}","gists_url":"https://api.github.com/users/abligh/gists{/gist_id}","starred_url":"https://api.github.com/users/abligh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abligh/subscriptions","organizations_url":"https://api.github.com/users/abligh/orgs","repos_url":"https://api.github.com/users/abligh/repos","events_url":"https://api.github.com/users/abligh/events{/privacy}","received_events_url":"https://api.github.com/users/abligh/received_events","type":"User","site_admin":false},"body":"Don't use a scanner to process datagrams received from syslog, because\r\na) datagrams are not meant to end with \\n (or contain control\r\n   characters at all), but they often do; previously relied on\r\n   them doing so\r\nb) spurious \\0 (also often sent after \\n) caused issues\r\nc) junk from one datagram could affect subsequent datagrams by\r\n   leaving the junk within the text field\r\n\r\nPass UDP syslog source onwards towards the parser (parser does\r\nnot yet handle it)\r\n\r\nResolves (hopefully) issue #10 and issue #15","created_at":"2015-07-02T18:09:23Z","updated_at":"2015-07-03T15:32:47Z","closed_at":"2015-07-03T15:32:47Z","merged_at":null,"merge_commit_sha":"9cc153ebe75b4c5718cc066ef3d88a8defc00bd7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mcuadros/go-syslog/pulls/17/commits","review_comments_url":"https://api.github.com/repos/mcuadros/go-syslog/pulls/17/comments","review_comment_url":"https://api.github.com/repos/mcuadros/go-syslog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mcuadros/go-syslog/issues/17/comments","statuses_url":"https://api.github.com/repos/mcuadros/go-syslog/statuses/52525dbe79d6254785193572c108f7354ef9ce57","head":{"label":"abligh:master","ref":"master","sha":"52525dbe79d6254785193572c108f7354ef9ce57","user":{"login":"abligh","id":1240226,"avatar_url":"https://avatars.githubusercontent.com/u/1240226?v=3","gravatar_id":"","url":"https://api.github.com/users/abligh","html_url":"https://github.com/abligh","followers_url":"https://api.github.com/users/abligh/followers","following_url":"https://api.github.com/users/abligh/following{/other_user}","gists_url":"https://api.github.com/users/abligh/gists{/gist_id}","starred_url":"https://api.github.com/users/abligh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abligh/subscriptions","organizations_url":"https://api.github.com/users/abligh/orgs","repos_url":"https://api.github.com/users/abligh/repos","events_url":"https://api.github.com/users/abligh/events{/privacy}","received_events_url":"https://api.github.com/users/abligh/received_events","type":"User","site_admin":false},"repo":{"id":38448501,"name":"go-syslog","full_name":"abligh/go-syslog","owner":{"login":"abligh","id":1240226,"avatar_url":"https://avatars.githubusercontent.com/u/1240226?v=3","gravatar_id":"","url":"https://api.github.com/users/abligh","html_url":"https://github.com/abligh","followers_url":"https://api.github.com/users/abligh/followers","following_url":"https://api.github.com/users/abligh/following{/other_user}","gists_url":"https://api.github.com/users/abligh/gists{/gist_id}","starred_url":"https://api.github.com/users/abligh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abligh/subscriptions","organizations_url":"https://api.github.com/users/abligh/orgs","repos_url":"https://api.github.com/users/abligh/repos","events_url":"https://api.github.com/users/abligh/events{/privacy}","received_events_url":"https://api.github.com/users/abligh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abligh/go-syslog","description":"Syslog server library for go.","fork":true,"url":"https://api.github.com/repos/abligh/go-syslog","forks_url":"https://api.github.com/repos/abligh/go-syslog/forks","keys_url":"https://api.github.com/repos/abligh/go-syslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abligh/go-syslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abligh/go-syslog/teams","hooks_url":"https://api.github.com/repos/abligh/go-syslog/hooks","issue_events_url":"https://api.github.com/repos/abligh/go-syslog/issues/events{/number}","events_url":"https://api.github.com/repos/abligh/go-syslog/events","assignees_url":"https://api.github.com/repos/abligh/go-syslog/assignees{/user}","branches_url":"https://api.github.com/repos/abligh/go-syslog/branches{/branch}","tags_url":"https://api.github.com/repos/abligh/go-syslog/tags","blobs_url":"https://api.github.com/repos/abligh/go-syslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abligh/go-syslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abligh/go-syslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/abligh/go-syslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abligh/go-syslog/statuses/{sha}","languages_url":"https://api.github.com/repos/abligh/go-syslog/languages","stargazers_url":"https://api.github.com/repos/abligh/go-syslog/stargazers","contributors_url":"https://api.github.com/repos/abligh/go-syslog/contributors","subscribers_url":"https://api.github.com/repos/abligh/go-syslog/subscribers","subscription_url":"https://api.github.com/repos/abligh/go-syslog/subscription","commits_url":"https://api.github.com/repos/abligh/go-syslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/abligh/go-syslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/abligh/go-syslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/abligh/go-syslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/abligh/go-syslog/contents/{+path}","compare_url":"https://api.github.com/repos/abligh/go-syslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abligh/go-syslog/merges","archive_url":"https://api.github.com/repos/abligh/go-syslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abligh/go-syslog/downloads","issues_url":"https://api.github.com/repos/abligh/go-syslog/issues{/number}","pulls_url":"https://api.github.com/repos/abligh/go-syslog/pulls{/number}","milestones_url":"https://api.github.com/repos/abligh/go-syslog/milestones{/number}","notifications_url":"https://api.github.com/repos/abligh/go-syslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abligh/go-syslog/labels{/name}","releases_url":"https://api.github.com/repos/abligh/go-syslog/releases{/id}","created_at":"2015-07-02T18:02:10Z","updated_at":"2015-07-02T18:02:11Z","pushed_at":"2015-07-03T15:30:42Z","git_url":"git://github.com/abligh/go-syslog.git","ssh_url":"git@github.com:abligh/go-syslog.git","clone_url":"https://github.com/abligh/go-syslog.git","svn_url":"https://github.com/abligh/go-syslog","homepage":"http://godoc.org/github.com/mcuadros/go-syslog","size":344,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mcuadros:master","ref":"master","sha":"0c7b4a44c4f61cbe0f51b3d983164b0b0bfdb2cb","user":{"login":"mcuadros","id":1573114,"avatar_url":"https://avatars.githubusercontent.com/u/1573114?v=3","gravatar_id":"","url":"https://api.github.com/users/mcuadros","html_url":"https://github.com/mcuadros","followers_url":"https://api.github.com/users/mcuadros/followers","following_url":"https://api.github.com/users/mcuadros/following{/other_user}","gists_url":"https://api.github.com/users/mcuadros/gists{/gist_id}","starred_url":"https://api.github.com/users/mcuadros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcuadros/subscriptions","organizations_url":"https://api.github.com/users/mcuadros/orgs","repos_url":"https://api.github.com/users/mcuadros/repos","events_url":"https://api.github.com/users/mcuadros/events{/privacy}","received_events_url":"https://api.github.com/users/mcuadros/received_events","type":"User","site_admin":false},"repo":{"id":15427682,"name":"go-syslog","full_name":"mcuadros/go-syslog","owner":{"login":"mcuadros","id":1573114,"avatar_url":"https://avatars.githubusercontent.com/u/1573114?v=3","gravatar_id":"","url":"https://api.github.com/users/mcuadros","html_url":"https://github.com/mcuadros","followers_url":"https://api.github.com/users/mcuadros/followers","following_url":"https://api.github.com/users/mcuadros/following{/other_user}","gists_url":"https://api.github.com/users/mcuadros/gists{/gist_id}","starred_url":"https://api.github.com/users/mcuadros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcuadros/subscriptions","organizations_url":"https://api.github.com/users/mcuadros/orgs","repos_url":"https://api.github.com/users/mcuadros/repos","events_url":"https://api.github.com/users/mcuadros/events{/privacy}","received_events_url":"https://api.github.com/users/mcuadros/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcuadros/go-syslog","description":"Syslog server library for go.","fork":false,"url":"https://api.github.com/repos/mcuadros/go-syslog","forks_url":"https://api.github.com/repos/mcuadros/go-syslog/forks","keys_url":"https://api.github.com/repos/mcuadros/go-syslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcuadros/go-syslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcuadros/go-syslog/teams","hooks_url":"https://api.github.com/repos/mcuadros/go-syslog/hooks","issue_events_url":"https://api.github.com/repos/mcuadros/go-syslog/issues/events{/number}","events_url":"https://api.github.com/repos/mcuadros/go-syslog/events","assignees_url":"https://api.github.com/repos/mcuadros/go-syslog/assignees{/user}","branches_url":"https://api.github.com/repos/mcuadros/go-syslog/branches{/branch}","tags_url":"https://api.github.com/repos/mcuadros/go-syslog/tags","blobs_url":"https://api.github.com/repos/mcuadros/go-syslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcuadros/go-syslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcuadros/go-syslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcuadros/go-syslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcuadros/go-syslog/statuses/{sha}","languages_url":"https://api.github.com/repos/mcuadros/go-syslog/languages","stargazers_url":"https://api.github.com/repos/mcuadros/go-syslog/stargazers","contributors_url":"https://api.github.com/repos/mcuadros/go-syslog/contributors","subscribers_url":"https://api.github.com/repos/mcuadros/go-syslog/subscribers","subscription_url":"https://api.github.com/repos/mcuadros/go-syslog/subscription","commits_url":"https://api.github.com/repos/mcuadros/go-syslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcuadros/go-syslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcuadros/go-syslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcuadros/go-syslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcuadros/go-syslog/contents/{+path}","compare_url":"https://api.github.com/repos/mcuadros/go-syslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcuadros/go-syslog/merges","archive_url":"https://api.github.com/repos/mcuadros/go-syslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcuadros/go-syslog/downloads","issues_url":"https://api.github.com/repos/mcuadros/go-syslog/issues{/number}","pulls_url":"https://api.github.com/repos/mcuadros/go-syslog/pulls{/number}","milestones_url":"https://api.github.com/repos/mcuadros/go-syslog/milestones{/number}","notifications_url":"https://api.github.com/repos/mcuadros/go-syslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcuadros/go-syslog/labels{/name}","releases_url":"https://api.github.com/repos/mcuadros/go-syslog/releases{/id}","created_at":"2013-12-25T01:32:21Z","updated_at":"2015-07-03T11:46:45Z","pushed_at":"2015-07-03T15:30:42Z","git_url":"git://github.com/mcuadros/go-syslog.git","ssh_url":"git@github.com:mcuadros/go-syslog.git","clone_url":"https://github.com/mcuadros/go-syslog.git","svn_url":"https://github.com/mcuadros/go-syslog","homepage":"http://godoc.org/github.com/mcuadros/go-syslog","size":344,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mcuadros/go-syslog/pulls/17"},"html":{"href":"https://github.com/mcuadros/go-syslog/pull/17"},"issue":{"href":"https://api.github.com/repos/mcuadros/go-syslog/issues/17"},"comments":{"href":"https://api.github.com/repos/mcuadros/go-syslog/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/mcuadros/go-syslog/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/mcuadros/go-syslog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mcuadros/go-syslog/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/mcuadros/go-syslog/statuses/52525dbe79d6254785193572c108f7354ef9ce57"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":125,"deletions":55,"changed_files":2}}