{"action":"created","comment":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/25719845","id":25719845,"diff_hunk":"@@ -153,10 +152,25 @@ public void onClick(DialogInterface dialog, int which) {\n     }\n   }\n \n-  public static CharSequence getSummary(Context context) {\n-    final int onCapsResId  = R.string.ApplicationPreferencesActivity_On;\n-    final int offCapsResId = R.string.ApplicationPreferencesActivity_Off;\n+  private static CharSequence getPassphraseSummary(Context context) {\n+    final int passphraseResId = R.string.preferences__passphrase;","path":"src/org/thoughtcrime/securesms/preferences/AppProtectionPreferenceFragment.java","position":16,"original_position":16,"commit_id":"f6543c80bd28beca83e9e7a627ec14725700d6ed","original_commit_id":"f6543c80bd28beca83e9e7a627ec14725700d6ed","user":{"login":"mcginty","id":373823,"avatar_url":"https://avatars.githubusercontent.com/u/373823?v=3","gravatar_id":"","url":"https://api.github.com/users/mcginty","html_url":"https://github.com/mcginty","followers_url":"https://api.github.com/users/mcginty/followers","following_url":"https://api.github.com/users/mcginty/following{/other_user}","gists_url":"https://api.github.com/users/mcginty/gists{/gist_id}","starred_url":"https://api.github.com/users/mcginty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcginty/subscriptions","organizations_url":"https://api.github.com/users/mcginty/orgs","repos_url":"https://api.github.com/users/mcginty/repos","events_url":"https://api.github.com/users/mcginty/events{/privacy}","received_events_url":"https://api.github.com/users/mcginty/received_events","type":"User","site_admin":false},"body":"we probably don't need a variable for this one - with Android Studio now \"autocompleting\" string resources it's actually more readable to directly reference R.string vars.","created_at":"2015-03-03T19:49:41Z","updated_at":"2015-03-03T19:49:41Z","html_url":"https://github.com/WhisperSystems/TextSecure/pull/2568#discussion_r25719845","pull_request_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/25719845"},"html":{"href":"https://github.com/WhisperSystems/TextSecure/pull/2568#discussion_r25719845"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568"}}},"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568","id":30402728,"html_url":"https://github.com/WhisperSystems/TextSecure/pull/2568","diff_url":"https://github.com/WhisperSystems/TextSecure/pull/2568.diff","patch_url":"https://github.com/WhisperSystems/TextSecure/pull/2568.patch","issue_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2568","number":2568,"state":"open","locked":false,"title":"settings preference group summaries","user":{"login":"rhodey","id":3441581,"avatar_url":"https://avatars.githubusercontent.com/u/3441581?v=3","gravatar_id":"","url":"https://api.github.com/users/rhodey","html_url":"https://github.com/rhodey","followers_url":"https://api.github.com/users/rhodey/followers","following_url":"https://api.github.com/users/rhodey/following{/other_user}","gists_url":"https://api.github.com/users/rhodey/gists{/gist_id}","starred_url":"https://api.github.com/users/rhodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhodey/subscriptions","organizations_url":"https://api.github.com/users/rhodey/orgs","repos_url":"https://api.github.com/users/rhodey/repos","events_url":"https://api.github.com/users/rhodey/events{/privacy}","received_events_url":"https://api.github.com/users/rhodey/received_events","type":"User","site_admin":false},"body":"1) created a new string constant for *Passphrase*.\r\n2) modified *App protection* preference group summary to be more verbose.\r\n3) dropped the colons from *Appearance* preference group summary.\r\n4) dropped the colons from and *SMS and MMS* preference group summary.\r\n\r\nturns out we didn't have a *Passphrase* string in `strings.xml`, the closest match I found was *Enable passphrase* but the *App protection* preferences group summary doesn't read as nicely, eg...\r\n\r\n*Enable passphrase on, Screen security on*\r\nvs\r\n*Passphrase on, Screen security on*\r\n\r\nCould revert to using the existing *Enable passphrase* string constant if we really wanna avoid adding a new one, lemme know.\r\n\r\nFixes #2395 ","created_at":"2015-03-03T19:09:57Z","updated_at":"2015-03-03T19:49:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a710a7b20959da1336c5d41b3737cf35e6d6f931","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2568/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/TextSecure/statuses/f6543c80bd28beca83e9e7a627ec14725700d6ed","head":{"label":"rhodey:issue-2395","ref":"issue-2395","sha":"f6543c80bd28beca83e9e7a627ec14725700d6ed","user":{"login":"rhodey","id":3441581,"avatar_url":"https://avatars.githubusercontent.com/u/3441581?v=3","gravatar_id":"","url":"https://api.github.com/users/rhodey","html_url":"https://github.com/rhodey","followers_url":"https://api.github.com/users/rhodey/followers","following_url":"https://api.github.com/users/rhodey/following{/other_user}","gists_url":"https://api.github.com/users/rhodey/gists{/gist_id}","starred_url":"https://api.github.com/users/rhodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhodey/subscriptions","organizations_url":"https://api.github.com/users/rhodey/orgs","repos_url":"https://api.github.com/users/rhodey/repos","events_url":"https://api.github.com/users/rhodey/events{/privacy}","received_events_url":"https://api.github.com/users/rhodey/received_events","type":"User","site_admin":false},"repo":{"id":31562260,"name":"TextSecure","full_name":"rhodey/TextSecure","owner":{"login":"rhodey","id":3441581,"avatar_url":"https://avatars.githubusercontent.com/u/3441581?v=3","gravatar_id":"","url":"https://api.github.com/users/rhodey","html_url":"https://github.com/rhodey","followers_url":"https://api.github.com/users/rhodey/followers","following_url":"https://api.github.com/users/rhodey/following{/other_user}","gists_url":"https://api.github.com/users/rhodey/gists{/gist_id}","starred_url":"https://api.github.com/users/rhodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhodey/subscriptions","organizations_url":"https://api.github.com/users/rhodey/orgs","repos_url":"https://api.github.com/users/rhodey/repos","events_url":"https://api.github.com/users/rhodey/events{/privacy}","received_events_url":"https://api.github.com/users/rhodey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhodey/TextSecure","description":"A secure text messaging application for Android.","fork":true,"url":"https://api.github.com/repos/rhodey/TextSecure","forks_url":"https://api.github.com/repos/rhodey/TextSecure/forks","keys_url":"https://api.github.com/repos/rhodey/TextSecure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhodey/TextSecure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhodey/TextSecure/teams","hooks_url":"https://api.github.com/repos/rhodey/TextSecure/hooks","issue_events_url":"https://api.github.com/repos/rhodey/TextSecure/issues/events{/number}","events_url":"https://api.github.com/repos/rhodey/TextSecure/events","assignees_url":"https://api.github.com/repos/rhodey/TextSecure/assignees{/user}","branches_url":"https://api.github.com/repos/rhodey/TextSecure/branches{/branch}","tags_url":"https://api.github.com/repos/rhodey/TextSecure/tags","blobs_url":"https://api.github.com/repos/rhodey/TextSecure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhodey/TextSecure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhodey/TextSecure/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhodey/TextSecure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhodey/TextSecure/statuses/{sha}","languages_url":"https://api.github.com/repos/rhodey/TextSecure/languages","stargazers_url":"https://api.github.com/repos/rhodey/TextSecure/stargazers","contributors_url":"https://api.github.com/repos/rhodey/TextSecure/contributors","subscribers_url":"https://api.github.com/repos/rhodey/TextSecure/subscribers","subscription_url":"https://api.github.com/repos/rhodey/TextSecure/subscription","commits_url":"https://api.github.com/repos/rhodey/TextSecure/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhodey/TextSecure/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhodey/TextSecure/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhodey/TextSecure/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhodey/TextSecure/contents/{+path}","compare_url":"https://api.github.com/repos/rhodey/TextSecure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhodey/TextSecure/merges","archive_url":"https://api.github.com/repos/rhodey/TextSecure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhodey/TextSecure/downloads","issues_url":"https://api.github.com/repos/rhodey/TextSecure/issues{/number}","pulls_url":"https://api.github.com/repos/rhodey/TextSecure/pulls{/number}","milestones_url":"https://api.github.com/repos/rhodey/TextSecure/milestones{/number}","notifications_url":"https://api.github.com/repos/rhodey/TextSecure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhodey/TextSecure/labels{/name}","releases_url":"https://api.github.com/repos/rhodey/TextSecure/releases{/id}","created_at":"2015-03-02T20:46:02Z","updated_at":"2015-03-02T20:46:05Z","pushed_at":"2015-03-03T19:04:23Z","git_url":"git://github.com/rhodey/TextSecure.git","ssh_url":"git@github.com:rhodey/TextSecure.git","clone_url":"https://github.com/rhodey/TextSecure.git","svn_url":"https://github.com/rhodey/TextSecure","homepage":"","size":60422,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WhisperSystems:master","ref":"master","sha":"ed5b3f867997ec2778e032d8753c3a54a5e23c93","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":2990192,"name":"TextSecure","full_name":"WhisperSystems/TextSecure","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/TextSecure","description":"A secure text messaging application for Android.","fork":false,"url":"https://api.github.com/repos/WhisperSystems/TextSecure","forks_url":"https://api.github.com/repos/WhisperSystems/TextSecure/forks","keys_url":"https://api.github.com/repos/WhisperSystems/TextSecure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/TextSecure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/TextSecure/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/TextSecure/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/TextSecure/events","assignees_url":"https://api.github.com/repos/WhisperSystems/TextSecure/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/TextSecure/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/TextSecure/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/TextSecure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/TextSecure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/TextSecure/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/TextSecure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/TextSecure/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/TextSecure/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/TextSecure/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/TextSecure/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/TextSecure/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/TextSecure/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/TextSecure/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/TextSecure/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/TextSecure/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/TextSecure/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/TextSecure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/TextSecure/merges","archive_url":"https://api.github.com/repos/WhisperSystems/TextSecure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/TextSecure/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/TextSecure/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/TextSecure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/TextSecure/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/TextSecure/releases{/id}","created_at":"2011-12-15T20:01:12Z","updated_at":"2015-03-03T18:51:29Z","pushed_at":"2015-03-03T19:46:11Z","git_url":"git://github.com/WhisperSystems/TextSecure.git","ssh_url":"git@github.com:WhisperSystems/TextSecure.git","clone_url":"https://github.com/WhisperSystems/TextSecure.git","svn_url":"https://github.com/WhisperSystems/TextSecure","homepage":"","size":60422,"stargazers_count":3610,"watchers_count":3610,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1017,"mirror_url":null,"open_issues_count":501,"forks":1017,"open_issues":501,"watchers":3610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568"},"html":{"href":"https://github.com/WhisperSystems/TextSecure/pull/2568"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2568"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2568/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2568/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/statuses/f6543c80bd28beca83e9e7a627ec14725700d6ed"}}}}