{"action":"created","issue":{"url":"https://api.github.com/repos/ga-dc/fellowship/issues/2","labels_url":"https://api.github.com/repos/ga-dc/fellowship/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ga-dc/fellowship/issues/2/comments","events_url":"https://api.github.com/repos/ga-dc/fellowship/issues/2/events","html_url":"https://github.com/ga-dc/fellowship/pull/2","id":111888642,"number":2,"title":"Thomas S-fellowship DOM homework","user":{"login":"solowt","id":10148145,"avatar_url":"https://avatars.githubusercontent.com/u/10148145?v=3","gravatar_id":"","url":"https://api.github.com/users/solowt","html_url":"https://github.com/solowt","followers_url":"https://api.github.com/users/solowt/followers","following_url":"https://api.github.com/users/solowt/following{/other_user}","gists_url":"https://api.github.com/users/solowt/gists{/gist_id}","starred_url":"https://api.github.com/users/solowt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solowt/subscriptions","organizations_url":"https://api.github.com/users/solowt/orgs","repos_url":"https://api.github.com/users/solowt/repos","events_url":"https://api.github.com/users/solowt/events{/privacy}","received_events_url":"https://api.github.com/users/solowt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-16T18:42:29Z","updated_at":"2015-10-20T21:28:15Z","closed_at":"2015-10-20T21:28:15Z","pull_request":{"url":"https://api.github.com/repos/ga-dc/fellowship/pulls/2","html_url":"https://github.com/ga-dc/fellowship/pull/2","diff_url":"https://github.com/ga-dc/fellowship/pull/2.diff","patch_url":"https://github.com/ga-dc/fellowship/pull/2.patch"},"body":"comfort: 4\r\ncompleteness: 5\r\n\r\nincluded a main() function for testing.  you can run main() in the js console and then input c to execute each function one by one.\r\n\r\nI think I could have referred to various elements much more efficiently, I tended to add an id to everything and some of the code I used to pick out certain elements is a mess.\r\n\r\nalso, I deleted one tag in the html file that I believe wasn't supposed to be there."},"comment":{"url":"https://api.github.com/repos/ga-dc/fellowship/issues/comments/149708630","html_url":"https://github.com/ga-dc/fellowship/pull/2#issuecomment-149708630","issue_url":"https://api.github.com/repos/ga-dc/fellowship/issues/2","id":149708630,"user":{"login":"nolds9","id":10698044,"avatar_url":"https://avatars.githubusercontent.com/u/10698044?v=3","gravatar_id":"","url":"https://api.github.com/users/nolds9","html_url":"https://github.com/nolds9","followers_url":"https://api.github.com/users/nolds9/followers","following_url":"https://api.github.com/users/nolds9/following{/other_user}","gists_url":"https://api.github.com/users/nolds9/gists{/gist_id}","starred_url":"https://api.github.com/users/nolds9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolds9/subscriptions","organizations_url":"https://api.github.com/users/nolds9/orgs","repos_url":"https://api.github.com/users/nolds9/repos","events_url":"https://api.github.com/users/nolds9/events{/privacy}","received_events_url":"https://api.github.com/users/nolds9/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T21:28:15Z","updated_at":"2015-10-20T21:28:15Z","body":":+1: Great job on this - really liked your solution, especially the main function implementation. \r\n\r\nIf you are looking for other ways of achieving this functionality, without stepping through each function manually - I would recommend researching the concept of a promise in javascript.  \r\n\r\nThis is something we will go in depth more in the second half of the class, but it is useful for dealing with asynchronous actions - or more plainly have some block of code execute only after the completion of another block of code.\r\n\r\n I think you are onto the only small changes I would suggest-there are some places where I think you are assigning id's where it might not be necessary for example. "}}