{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/rkt/issues/908","labels_url":"https://api.github.com/repos/coreos/rkt/issues/908/labels{/name}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/908/comments","events_url":"https://api.github.com/repos/coreos/rkt/issues/908/events","html_url":"https://github.com/coreos/rkt/pull/908","id":76921917,"number":908,"title":"stage0,stage1: autoconf-based build and dbus","user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-16T02:19:02Z","updated_at":"2015-05-22T16:18:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/908","html_url":"https://github.com/coreos/rkt/pull/908","diff_url":"https://github.com/coreos/rkt/pull/908.diff","patch_url":"https://github.com/coreos/rkt/pull/908.patch"},"body":"This commit migrates rkt build process to autoconf and make toolchain\r\nto provide the following features:\r\n\r\n* checking for prerequisites in before the build instead of build time\r\n* adds the following explicit configuration flags:\r\n\r\n```\r\n  --with-stage1=type      type of stage1 build one of 'src', 'coreos', 'none'\r\n  --with-stage1-systemd-src=git-path\r\n                          address to git repository of systemd, used in 'src'\r\n                          build mode\r\n  --with-stage1-systemd-version=version\r\n                          systemd version to build\r\n  --with-stage1-image-path\r\n                          custom stage1 image path\r\n  --with-stage1-dbus=no   turn of d-bus or not, 'yes' turns it on, 'no' turns\r\n                          it off\r\n  --with-stage1-dbus-src=git-path\r\n                          address to git repository of systemd, used in 'src'\r\n                          build mode\r\n  --with-stage1-dbus-version=version\r\n                          d-bus version to build\r\n```\r\n\r\n* adds explicit `BUILDDIR` make variable to build outside of the source tree\r\n* adds explicit `make stage0` and `make stage1` targets\r\n* adds configuration-time support for D-Bus runnning as `messagebus` user\r\n* adds makefile macros library `makelib/lib.mk` for common build operations\r\n\r\nBuild changes\r\n-------------\r\n\r\nThe build is now changed from the `./build` to 3 phase step:\r\n\r\n1. `./autogen.sh` step to regenerate configure script\r\n2. `./configure` build step to generate Makefile\r\n3. `make` build step\r\n\r\nOther changes\r\n-------------\r\n\r\n1. remove `aggregate` directory in favor of `BUILDDIR` external directory\r\n2. split `aggregate` contents into individual modules in stage1 directory"},"comment":{"url":"https://api.github.com/repos/coreos/rkt/issues/comments/104702652","html_url":"https://github.com/coreos/rkt/pull/908#issuecomment-104702652","issue_url":"https://api.github.com/repos/coreos/rkt/issues/908","id":104702652,"user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T16:18:13Z","updated_at":"2015-05-22T16:18:13Z","body":"@alban I was actually thinking of recovering the ./build back to be as simple as \r\n\r\n```bash\r\n#!/bin/bash -e\r\n./configure\r\nmake\r\n```\r\n\r\nfor a while to make a smoother transition and make sure tests are passing. It can be later deleted. \r\n\r\nWhat do you think? \r\n\r\nJFYI I plan to apply the code review comments this weekend and clean up this PR for the next round of review  / testing\r\n"}}