{"action":"opened","issue":{"url":"https://api.github.com/repos/pyserial/pyserial/issues/5","labels_url":"https://api.github.com/repos/pyserial/pyserial/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/pyserial/pyserial/issues/5/comments","events_url":"https://api.github.com/repos/pyserial/pyserial/issues/5/events","html_url":"https://github.com/pyserial/pyserial/issues/5","id":99850032,"number":5,"title":"[miniterm] My reworking with additional features diverged from your recent changes.","user":{"login":"hardkrash","id":104305,"avatar_url":"https://avatars.githubusercontent.com/u/104305?v=3","gravatar_id":"","url":"https://api.github.com/users/hardkrash","html_url":"https://github.com/hardkrash","followers_url":"https://api.github.com/users/hardkrash/followers","following_url":"https://api.github.com/users/hardkrash/following{/other_user}","gists_url":"https://api.github.com/users/hardkrash/gists{/gist_id}","starred_url":"https://api.github.com/users/hardkrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardkrash/subscriptions","organizations_url":"https://api.github.com/users/hardkrash/orgs","repos_url":"https://api.github.com/users/hardkrash/repos","events_url":"https://api.github.com/users/hardkrash/events{/privacy}","received_events_url":"https://api.github.com/users/hardkrash/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-09T01:18:51Z","updated_at":"2015-08-09T01:18:51Z","closed_at":null,"body":"I just finished a few features for miniterm on my fork and discovered that you also were reworking miniterm.  \r\n\r\nWhile I agree with the bulk of the changes, switching the reader and writer to bytes from str I believe is too high in the stack.  My rework involved splitting out the representation engine to functions and applying them to both the input from the serial port and to the local echo function.  These operations are in the unicode world.  When leaving the console world then the conversion to bytes is appropriate.\r\n\r\nPlease see  https://github.com/hardkrash/pyserial/commits/feature/miniterm_features\r\nFeatures include:\r\n- Pretty printing of ASCII C) codes.\r\n- Color mapping of local and remote text. (Should be turned into a runtime option, default off)\r\n- File input bugfixes.\r\n\r\nOn a side note:\r\nIt would be interesting to take the local echo concept from Mosh. https://mosh.mit.edu\r\nWhere the text is locally echoed and highlighted until the remote echos the text.\r\n"}}