{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/40082288","id":40082288,"diff_hunk":"@@ -46,16 +47,17 @@ def remove_bdist_rpm_source_file():\n shared_setup.remove_extra_bdist_rpm_files = remove_bdist_rpm_source_file\n shared_setup.SHARED_TARGET.update({\n     'url': 'https://github.com/hpcugent/vsc-base',\n-    'download_url': 'https://github.com/hpcugent/vsc-base'\n+    'download_url': 'https://github.com/hpcugent/vsc-base',\n+    'zip_safe': True,\n })\n \n \n PACKAGE = {\n     'name': 'vsc-base',\n-    'version': '2.2.6',\n+    'version': '2.3.0',","path":"setup.py","position":21,"original_position":21,"commit_id":"0a5c82d2a48ce4e157cfef6ea663fcbc33b9b20e","original_commit_id":"0a5c82d2a48ce4e157cfef6ea663fcbc33b9b20e","user":{"login":"JensTimmerman","id":281523,"avatar_url":"https://avatars.githubusercontent.com/u/281523?v=3","gravatar_id":"","url":"https://api.github.com/users/JensTimmerman","html_url":"https://github.com/JensTimmerman","followers_url":"https://api.github.com/users/JensTimmerman/followers","following_url":"https://api.github.com/users/JensTimmerman/following{/other_user}","gists_url":"https://api.github.com/users/JensTimmerman/gists{/gist_id}","starred_url":"https://api.github.com/users/JensTimmerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensTimmerman/subscriptions","organizations_url":"https://api.github.com/users/JensTimmerman/orgs","repos_url":"https://api.github.com/users/JensTimmerman/repos","events_url":"https://api.github.com/users/JensTimmerman/events{/privacy}","received_events_url":"https://api.github.com/users/JensTimmerman/received_events","type":"User","site_admin":false},"body":"no, that doesn't work in rpm's, 2.2.7 is what I mean. \r\nIt's fine for now, until we have an official version numbering policy I guess.\r\n","created_at":"2015-09-22T13:01:58Z","updated_at":"2015-09-22T13:01:58Z","html_url":"https://github.com/hpcugent/vsc-base/pull/191#discussion_r40082288","pull_request_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/40082288"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/191#discussion_r40082288"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191","id":45567992,"html_url":"https://github.com/hpcugent/vsc-base/pull/191","diff_url":"https://github.com/hpcugent/vsc-base/pull/191.diff","patch_url":"https://github.com/hpcugent/vsc-base/pull/191.patch","issue_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/191","number":191,"state":"open","locked":false,"title":"enable zip_safe, and fix broken tests","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"With some minor changes in the tests, vsc-base is zip-safe.\r\n\r\nold description:\r\n```\r\nThe biggest change here is moving the tests to the `vsc.test.vsc_base` package, such that:\r\n\r\ni) the tests become part of the installation, which sort of required to run the tests on an installed egg\r\nii) clashes with other `test` namespaces (like the one in the Python stdlib) are avoided\r\n\r\nSo, Jenkins will have to be updated accordingly, to run the tests with `python -m vsc.test.vsc_base.suite`, *after* installing `vsc-base` as a zipped eggs in a temporary location.\r\nOf course, the tests should still work when being run as `python lib/vsc/test/vsc_base/suite.py` too, so Jenkins should check both?\r\n\r\nOverview of tests that ~~will need~~ needed to be fixed (probably because they rely on using `__file__` somehow) is available at ~~#190~~.~~\r\n```","created_at":"2015-09-21T16:11:33Z","updated_at":"2015-09-22T13:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8078e12836ca47de9533169313775e95cb5ed233","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191/commits","review_comments_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191/comments","review_comment_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/191/comments","statuses_url":"https://api.github.com/repos/hpcugent/vsc-base/statuses/0a5c82d2a48ce4e157cfef6ea663fcbc33b9b20e","head":{"label":"boegel:zip_safe_tests","ref":"zip_safe_tests","sha":"0a5c82d2a48ce4e157cfef6ea663fcbc33b9b20e","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"repo":{"id":8048836,"name":"vsc-base","full_name":"boegel/vsc-base","owner":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boegel/vsc-base","description":"Basic Python libraries used by UGent's HPC group","fork":true,"url":"https://api.github.com/repos/boegel/vsc-base","forks_url":"https://api.github.com/repos/boegel/vsc-base/forks","keys_url":"https://api.github.com/repos/boegel/vsc-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boegel/vsc-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boegel/vsc-base/teams","hooks_url":"https://api.github.com/repos/boegel/vsc-base/hooks","issue_events_url":"https://api.github.com/repos/boegel/vsc-base/issues/events{/number}","events_url":"https://api.github.com/repos/boegel/vsc-base/events","assignees_url":"https://api.github.com/repos/boegel/vsc-base/assignees{/user}","branches_url":"https://api.github.com/repos/boegel/vsc-base/branches{/branch}","tags_url":"https://api.github.com/repos/boegel/vsc-base/tags","blobs_url":"https://api.github.com/repos/boegel/vsc-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boegel/vsc-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boegel/vsc-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/boegel/vsc-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boegel/vsc-base/statuses/{sha}","languages_url":"https://api.github.com/repos/boegel/vsc-base/languages","stargazers_url":"https://api.github.com/repos/boegel/vsc-base/stargazers","contributors_url":"https://api.github.com/repos/boegel/vsc-base/contributors","subscribers_url":"https://api.github.com/repos/boegel/vsc-base/subscribers","subscription_url":"https://api.github.com/repos/boegel/vsc-base/subscription","commits_url":"https://api.github.com/repos/boegel/vsc-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/boegel/vsc-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/boegel/vsc-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/boegel/vsc-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/boegel/vsc-base/contents/{+path}","compare_url":"https://api.github.com/repos/boegel/vsc-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boegel/vsc-base/merges","archive_url":"https://api.github.com/repos/boegel/vsc-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boegel/vsc-base/downloads","issues_url":"https://api.github.com/repos/boegel/vsc-base/issues{/number}","pulls_url":"https://api.github.com/repos/boegel/vsc-base/pulls{/number}","milestones_url":"https://api.github.com/repos/boegel/vsc-base/milestones{/number}","notifications_url":"https://api.github.com/repos/boegel/vsc-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boegel/vsc-base/labels{/name}","releases_url":"https://api.github.com/repos/boegel/vsc-base/releases{/id}","created_at":"2013-02-06T10:07:56Z","updated_at":"2015-03-02T13:06:17Z","pushed_at":"2015-09-21T17:26:37Z","git_url":"git://github.com/boegel/vsc-base.git","ssh_url":"git@github.com:boegel/vsc-base.git","clone_url":"https://github.com/boegel/vsc-base.git","svn_url":"https://github.com/boegel/vsc-base","homepage":null,"size":1595,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:master","ref":"master","sha":"0a65f3e600e542cca88d1fb63d70bdf56c355c8e","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":7765704,"name":"vsc-base","full_name":"hpcugent/vsc-base","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/vsc-base","description":"Basic Python libraries used by UGent's HPC group","fork":false,"url":"https://api.github.com/repos/hpcugent/vsc-base","forks_url":"https://api.github.com/repos/hpcugent/vsc-base/forks","keys_url":"https://api.github.com/repos/hpcugent/vsc-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/vsc-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/vsc-base/teams","hooks_url":"https://api.github.com/repos/hpcugent/vsc-base/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/vsc-base/events","assignees_url":"https://api.github.com/repos/hpcugent/vsc-base/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/vsc-base/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/vsc-base/tags","blobs_url":"https://api.github.com/repos/hpcugent/vsc-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/vsc-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/vsc-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/vsc-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/vsc-base/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/vsc-base/languages","stargazers_url":"https://api.github.com/repos/hpcugent/vsc-base/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/vsc-base/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/vsc-base/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/vsc-base/subscription","commits_url":"https://api.github.com/repos/hpcugent/vsc-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/vsc-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/vsc-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/vsc-base/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/vsc-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/vsc-base/merges","archive_url":"https://api.github.com/repos/hpcugent/vsc-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/vsc-base/downloads","issues_url":"https://api.github.com/repos/hpcugent/vsc-base/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/vsc-base/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/vsc-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/vsc-base/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/vsc-base/releases{/id}","created_at":"2013-01-23T01:51:31Z","updated_at":"2015-08-17T21:34:39Z","pushed_at":"2015-09-21T17:26:38Z","git_url":"git://github.com/hpcugent/vsc-base.git","ssh_url":"git@github.com:hpcugent/vsc-base.git","clone_url":"https://github.com/hpcugent/vsc-base.git","svn_url":"https://github.com/hpcugent/vsc-base","homepage":null,"size":2065,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":21,"forks":23,"open_issues":21,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/191"},"issue":{"href":"https://api.github.com/repos/hpcugent/vsc-base/issues/191"},"comments":{"href":"https://api.github.com/repos/hpcugent/vsc-base/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/vsc-base/statuses/0a5c82d2a48ce4e157cfef6ea663fcbc33b9b20e"}}}}