{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/selenium-tests/issues/808","labels_url":"https://api.github.com/repos/Wikia/selenium-tests/issues/808/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/selenium-tests/issues/808/comments","events_url":"https://api.github.com/repos/Wikia/selenium-tests/issues/808/events","html_url":"https://github.com/Wikia/selenium-tests/pull/808","id":100659026,"number":808,"title":"ADEN Refactor SignupTests","user":{"login":"drets","id":6199462,"avatar_url":"https://avatars.githubusercontent.com/u/6199462?v=3","gravatar_id":"","url":"https://api.github.com/users/drets","html_url":"https://github.com/drets","followers_url":"https://api.github.com/users/drets/followers","following_url":"https://api.github.com/users/drets/following{/other_user}","gists_url":"https://api.github.com/users/drets/gists{/gist_id}","starred_url":"https://api.github.com/users/drets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drets/subscriptions","organizations_url":"https://api.github.com/users/drets/orgs","repos_url":"https://api.github.com/users/drets/repos","events_url":"https://api.github.com/users/drets/events{/privacy}","received_events_url":"https://api.github.com/users/drets/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tomasznapieralski","id":10118538,"avatar_url":"https://avatars.githubusercontent.com/u/10118538?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasznapieralski","html_url":"https://github.com/tomasznapieralski","followers_url":"https://api.github.com/users/tomasznapieralski/followers","following_url":"https://api.github.com/users/tomasznapieralski/following{/other_user}","gists_url":"https://api.github.com/users/tomasznapieralski/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasznapieralski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasznapieralski/subscriptions","organizations_url":"https://api.github.com/users/tomasznapieralski/orgs","repos_url":"https://api.github.com/users/tomasznapieralski/repos","events_url":"https://api.github.com/users/tomasznapieralski/events{/privacy}","received_events_url":"https://api.github.com/users/tomasznapieralski/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-08-12T23:42:06Z","updated_at":"2015-08-13T09:15:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wikia/selenium-tests/pulls/808","html_url":"https://github.com/Wikia/selenium-tests/pull/808","diff_url":"https://github.com/Wikia/selenium-tests/pull/808.diff","patch_url":"https://github.com/Wikia/selenium-tests/pull/808.patch"},"body":"@tomasznapieralski what do you think this refactoring makes the tests more readable?\r\nIf Java would support the named arguments we could do more fancy stuff like:\r\n```java\r\n public void MercurySignupTest_004_signupErrorBadPassword() {\r\n   signUp(password: INCORRECT_PASSWORD)\r\n       .verifyPasswordError();\r\n }\r\n\r\npublic void MercurySignupTest_003_signupErrorUsernameTaken() {\r\n  signUp(userName: TAKEN_USERNAME)\r\n      .verifyUsernameTakenError();\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/Wikia/selenium-tests/issues/comments/130587527","html_url":"https://github.com/Wikia/selenium-tests/pull/808#issuecomment-130587527","issue_url":"https://api.github.com/repos/Wikia/selenium-tests/issues/808","id":130587527,"user":{"login":"ludwikkazmierczak","id":7136408,"avatar_url":"https://avatars.githubusercontent.com/u/7136408?v=3","gravatar_id":"","url":"https://api.github.com/users/ludwikkazmierczak","html_url":"https://github.com/ludwikkazmierczak","followers_url":"https://api.github.com/users/ludwikkazmierczak/followers","following_url":"https://api.github.com/users/ludwikkazmierczak/following{/other_user}","gists_url":"https://api.github.com/users/ludwikkazmierczak/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwikkazmierczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwikkazmierczak/subscriptions","organizations_url":"https://api.github.com/users/ludwikkazmierczak/orgs","repos_url":"https://api.github.com/users/ludwikkazmierczak/repos","events_url":"https://api.github.com/users/ludwikkazmierczak/events{/privacy}","received_events_url":"https://api.github.com/users/ludwikkazmierczak/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T09:15:01Z","updated_at":"2015-08-13T09:15:01Z","body":"@drets functionality you are talking about is easy to implement with builder pattern, It would look like this:\r\n```\r\nsignUp(CreateUser().withPassword(WRONG_PASS).create())\r\n                      .verifyEmailInUseError();\r\n\r\nsignUp(CreateUser(),withName(NAME_TAKEN).create())\r\n                     .verifyEmailInUseError();\r\n```"}}