{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/comments/22511070","id":22511070,"diff_hunk":"@@ -41,7 +41,7 @@\n                   <div class=\"form-group\" >\n                     <label for=\"patient-dob\" class=\"col-xs-3 control-label\">{{ \"PATIENT_REG.DOB\" | translate }}</label>\n                     <div class=\"col-xs-9\">\n-                      <input required id=\"patient-dob\" type=\"date\" class=\"form-bhima\" ng-model=\"patient.dob\" min=\"1900-01-01\" max=\"{{ getMaxDate() }}\">\n+                      <input required id=\"patient-dob\" type=\"date\" class=\"form-bhima\" ng-model=\"patient.dob\" min=\"{{ getMinDate() }}\" max=\"{{ getMaxDate() }}\">","path":"client/src/partials/patient_edit/edit_patient.html","position":12,"original_position":12,"commit_id":"eba1a6d40070c6ab7fedf89d55ec5c3ddb87f921","original_commit_id":"bfade84dfceb6b512d791dca4418b6fe4be086db","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"body":"Would it be possible to cache both of these in a scope variable, rather than in a function?  Angular will call `getMinDate()` and `getMaxDate()` (which doesn't change after module load) repeatedly when redrawing the view.  Something like `session.minHtmlDate` and `session.maxHtmlDate` could be calculated and exposed to the view on module load.  I'm pretty sure this is a lighter weight solution.","created_at":"2015-01-06T07:08:48Z","updated_at":"2015-01-06T07:08:48Z","html_url":"https://github.com/IMA-WorldHealth/bhima/pull/256#discussion_r22511070","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/comments/22511070"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima/pull/256#discussion_r22511070"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256","id":26835914,"html_url":"https://github.com/IMA-WorldHealth/bhima/pull/256","diff_url":"https://github.com/IMA-WorldHealth/bhima/pull/256.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima/pull/256.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/256","number":256,"state":"open","locked":false,"title":"Feature/edit patient cleanup","user":{"login":"jmcameron","id":62145,"avatar_url":"https://avatars.githubusercontent.com/u/62145?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"body":"Implemented several updates to the edit patient form, including modifying/adding patient database columns.  See the commmits for details.","created_at":"2015-01-05T16:59:05Z","updated_at":"2015-01-06T07:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78b5d1a67d66a5c320c1fa4ee1d4218bf69820d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/comments/{number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/256/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/statuses/eba1a6d40070c6ab7fedf89d55ec5c3ddb87f921","head":{"label":"jmcameron:feature/edit_patient_cleanup","ref":"feature/edit_patient_cleanup","sha":"eba1a6d40070c6ab7fedf89d55ec5c3ddb87f921","user":{"login":"jmcameron","id":62145,"avatar_url":"https://avatars.githubusercontent.com/u/62145?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"repo":{"id":27850250,"name":"bhima","full_name":"jmcameron/bhima","owner":{"login":"jmcameron","id":62145,"avatar_url":"https://avatars.githubusercontent.com/u/62145?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmcameron/bhima","description":"A full-featured hospital information system for developing countries.","fork":true,"url":"https://api.github.com/repos/jmcameron/bhima","forks_url":"https://api.github.com/repos/jmcameron/bhima/forks","keys_url":"https://api.github.com/repos/jmcameron/bhima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcameron/bhima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcameron/bhima/teams","hooks_url":"https://api.github.com/repos/jmcameron/bhima/hooks","issue_events_url":"https://api.github.com/repos/jmcameron/bhima/issues/events{/number}","events_url":"https://api.github.com/repos/jmcameron/bhima/events","assignees_url":"https://api.github.com/repos/jmcameron/bhima/assignees{/user}","branches_url":"https://api.github.com/repos/jmcameron/bhima/branches{/branch}","tags_url":"https://api.github.com/repos/jmcameron/bhima/tags","blobs_url":"https://api.github.com/repos/jmcameron/bhima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcameron/bhima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcameron/bhima/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcameron/bhima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcameron/bhima/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcameron/bhima/languages","stargazers_url":"https://api.github.com/repos/jmcameron/bhima/stargazers","contributors_url":"https://api.github.com/repos/jmcameron/bhima/contributors","subscribers_url":"https://api.github.com/repos/jmcameron/bhima/subscribers","subscription_url":"https://api.github.com/repos/jmcameron/bhima/subscription","commits_url":"https://api.github.com/repos/jmcameron/bhima/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcameron/bhima/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcameron/bhima/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcameron/bhima/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmcameron/bhima/contents/{+path}","compare_url":"https://api.github.com/repos/jmcameron/bhima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcameron/bhima/merges","archive_url":"https://api.github.com/repos/jmcameron/bhima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcameron/bhima/downloads","issues_url":"https://api.github.com/repos/jmcameron/bhima/issues{/number}","pulls_url":"https://api.github.com/repos/jmcameron/bhima/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcameron/bhima/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcameron/bhima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcameron/bhima/labels{/name}","releases_url":"https://api.github.com/repos/jmcameron/bhima/releases{/id}","created_at":"2014-12-11T02:27:01Z","updated_at":"2014-12-11T02:27:03Z","pushed_at":"2015-01-06T07:07:23Z","git_url":"git://github.com/jmcameron/bhima.git","ssh_url":"git@github.com:jmcameron/bhima.git","clone_url":"https://github.com/jmcameron/bhima.git","svn_url":"https://github.com/jmcameron/bhima","homepage":"","size":29196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:development","ref":"development","sha":"31d01225836d02fe19a138d0766c09edf7904d96","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":15043926,"name":"bhima","full_name":"IMA-WorldHealth/bhima","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima","description":"A full-featured hospital information system for developing countries.","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/comments/{number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/releases{/id}","created_at":"2013-12-09T10:07:16Z","updated_at":"2014-11-18T12:21:56Z","pushed_at":"2015-01-05T13:17:03Z","git_url":"git://github.com/IMA-WorldHealth/bhima.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima.git","clone_url":"https://github.com/IMA-WorldHealth/bhima.git","svn_url":"https://github.com/IMA-WorldHealth/bhima","homepage":"","size":30682,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":20,"forks":7,"open_issues":20,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima/pull/256"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/256"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima/statuses/eba1a6d40070c6ab7fedf89d55ec5c3ddb87f921"}}}}