{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/ndt/issues/37","labels_url":"https://api.github.com/repos/m-lab/ndt/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/ndt/issues/37/comments","events_url":"https://api.github.com/repos/m-lab/ndt/issues/37/events","html_url":"https://github.com/m-lab/ndt/pull/37","id":123167113,"number":37,"title":"Extend c2s server read loop by 1 second.","user":{"login":"stephen-soltesz","id":1085316,"avatar_url":"https://avatars.githubusercontent.com/u/1085316?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-soltesz","html_url":"https://github.com/stephen-soltesz","followers_url":"https://api.github.com/users/stephen-soltesz/followers","following_url":"https://api.github.com/users/stephen-soltesz/following{/other_user}","gists_url":"https://api.github.com/users/stephen-soltesz/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-soltesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-soltesz/subscriptions","organizations_url":"https://api.github.com/users/stephen-soltesz/orgs","repos_url":"https://api.github.com/users/stephen-soltesz/repos","events_url":"https://api.github.com/users/stephen-soltesz/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-soltesz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pboothe","id":143798,"avatar_url":"https://avatars.githubusercontent.com/u/143798?v=3","gravatar_id":"","url":"https://api.github.com/users/pboothe","html_url":"https://github.com/pboothe","followers_url":"https://api.github.com/users/pboothe/followers","following_url":"https://api.github.com/users/pboothe/following{/other_user}","gists_url":"https://api.github.com/users/pboothe/gists{/gist_id}","starred_url":"https://api.github.com/users/pboothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboothe/subscriptions","organizations_url":"https://api.github.com/users/pboothe/orgs","repos_url":"https://api.github.com/users/pboothe/repos","events_url":"https://api.github.com/users/pboothe/events{/privacy}","received_events_url":"https://api.github.com/users/pboothe/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-12-20T15:27:25Z","updated_at":"2015-12-21T03:02:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/m-lab/ndt/pulls/37","html_url":"https://github.com/m-lab/ndt/pull/37","diff_url":"https://github.com/m-lab/ndt/pull/37.diff","patch_url":"https://github.com/m-lab/ndt/pull/37.patch"},"body":"This change addresses a regression observed for web100clt during the c2s test.\r\nIn particular, before this change, web100clt can block while writing after the\r\nc2s server stopped reading. This causes the rest of the test to fail.\r\n\r\nThe server implementation in NDT 3.7.0 attempted to read longer than the client\r\nwrote. The change in NDT 4.0.0 made the c2s read loop strictly conditional on\r\ntestDuration. This resulted in a race condition with the client."},"comment":{"url":"https://api.github.com/repos/m-lab/ndt/issues/comments/166184801","html_url":"https://github.com/m-lab/ndt/pull/37#issuecomment-166184801","issue_url":"https://api.github.com/repos/m-lab/ndt/issues/37","id":166184801,"user":{"login":"pboothe","id":143798,"avatar_url":"https://avatars.githubusercontent.com/u/143798?v=3","gravatar_id":"","url":"https://api.github.com/users/pboothe","html_url":"https://github.com/pboothe","followers_url":"https://api.github.com/users/pboothe/followers","following_url":"https://api.github.com/users/pboothe/following{/other_user}","gists_url":"https://api.github.com/users/pboothe/gists{/gist_id}","starred_url":"https://api.github.com/users/pboothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboothe/subscriptions","organizations_url":"https://api.github.com/users/pboothe/orgs","repos_url":"https://api.github.com/users/pboothe/repos","events_url":"https://api.github.com/users/pboothe/events{/privacy}","received_events_url":"https://api.github.com/users/pboothe/received_events","type":"User","site_admin":false},"created_at":"2015-12-21T03:02:39Z","updated_at":"2015-12-21T03:02:39Z","body":"LGTM."}}