{"action":"created","comment":{"url":"https://api.github.com/repos/oe-lite/core/pulls/comments/42231678","id":42231678,"diff_hunk":"@@ -64,6 +64,12 @@ CFLAGS_OPT_SPEED\t?= \"-O2 \\\n CFLAGS_OPT_SIZE\t\t?= \"-Os\"\n CFLAGS_OPT_DEBUG\t?= \"-O1 -g -fno-omit-frame-pointer\"\n \n+# Enable -fPIC for powerpc architectures to support address\n+# space larger than 24 bits\n+CFLAGS_OPT_SPEED:>TARGET_CPU_powerpc += \" -fPIC\"\n+CFLAGS_OPT_SIZE:>TARGET_CPU_powerpc += \" -fPIC\"\n+CFLAGS_OPT_DEBUG:>TARGET_CPU_powerpc += \" -fPIC\"","path":"classes/c.oeclass","position":8,"original_position":8,"commit_id":"51ce4ecdd15466189b785ab8bc6ba763c6e743e4","original_commit_id":"51ce4ecdd15466189b785ab8bc6ba763c6e743e4","user":{"login":"esben","id":122934,"avatar_url":"https://avatars.githubusercontent.com/u/122934?v=3","gravatar_id":"","url":"https://api.github.com/users/esben","html_url":"https://github.com/esben","followers_url":"https://api.github.com/users/esben/followers","following_url":"https://api.github.com/users/esben/following{/other_user}","gists_url":"https://api.github.com/users/esben/gists{/gist_id}","starred_url":"https://api.github.com/users/esben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esben/subscriptions","organizations_url":"https://api.github.com/users/esben/orgs","repos_url":"https://api.github.com/users/esben/repos","events_url":"https://api.github.com/users/esben/events{/privacy}","received_events_url":"https://api.github.com/users/esben/received_events","type":"User","site_admin":false},"body":"I don't think we should be adding it to these CFLAGS_OPT_* variables.\r\n\r\n1. They are used for both build, host and target CFLAGS.  So you will be adding -fPIC to HOST_CFLAGS for both cross and sdk-cross, which I don't think was the idea.\r\n\r\n2. Users/developers are supposed to be overriding CFLAGS_OPT_SPEED, so it probably best to not piggy-back stuff to them.\r\n\r\nMaybe do\r\n\r\n    HOST_CFLAGS:>HOST_CPU_powerpc += \" -fPIC\"\r\n    TARGET_CFLAGS:>TARGET_CPU_powerpc += \" -fPIC\"\r\n\r\ninstead.  I haven't tried it, so some amount of testing is clearly a good idea ;)","created_at":"2015-10-16T11:13:12Z","updated_at":"2015-10-16T11:13:12Z","html_url":"https://github.com/oe-lite/core/pull/58#discussion_r42231678","pull_request_url":"https://api.github.com/repos/oe-lite/core/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/oe-lite/core/pulls/comments/42231678"},"html":{"href":"https://github.com/oe-lite/core/pull/58#discussion_r42231678"},"pull_request":{"href":"https://api.github.com/repos/oe-lite/core/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/oe-lite/core/pulls/58","id":47658269,"html_url":"https://github.com/oe-lite/core/pull/58","diff_url":"https://github.com/oe-lite/core/pull/58.diff","patch_url":"https://github.com/oe-lite/core/pull/58.patch","issue_url":"https://api.github.com/repos/oe-lite/core/issues/58","number":58,"state":"open","locked":false,"title":"Support address space beyond 24 bit on powerpc32","user":{"login":"ksorensen","id":15121860,"avatar_url":"https://avatars.githubusercontent.com/u/15121860?v=3","gravatar_id":"","url":"https://api.github.com/users/ksorensen","html_url":"https://github.com/ksorensen","followers_url":"https://api.github.com/users/ksorensen/followers","following_url":"https://api.github.com/users/ksorensen/following{/other_user}","gists_url":"https://api.github.com/users/ksorensen/gists{/gist_id}","starred_url":"https://api.github.com/users/ksorensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksorensen/subscriptions","organizations_url":"https://api.github.com/users/ksorensen/orgs","repos_url":"https://api.github.com/users/ksorensen/repos","events_url":"https://api.github.com/users/ksorensen/events{/privacy}","received_events_url":"https://api.github.com/users/ksorensen/received_events","type":"User","site_admin":false},"body":"Enable support for larger address space on powerpc32.\r\n\r\nInternal references will be resolved with 24 bit addressing if\r\npossible, but external references will cause 32 bit addressing\r\nto be used.\r\n\r\nThere is some performance impact, but this is necessary to\r\nsupport large libraries like e.g. qt.\r\n\r\nSigned-off-by: Klaus Henning Sorensen <klaus.sorensen@prevas.dk>","created_at":"2015-10-14T13:25:08Z","updated_at":"2015-10-16T11:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83521ef09d30b8c04e55901b3becf409a5ab33d2","assignee":null,"milestone":{"url":"https://api.github.com/repos/oe-lite/core/milestones/3","html_url":"https://github.com/oe-lite/core/milestones/4.0.1","labels_url":"https://api.github.com/repos/oe-lite/core/milestones/3/labels","id":1161654,"number":3,"title":"4.0.1","description":"Bugfixes to 4.0.0, including upgrade to GCC 4.8.5.","creator":{"login":"esben","id":122934,"avatar_url":"https://avatars.githubusercontent.com/u/122934?v=3","gravatar_id":"","url":"https://api.github.com/users/esben","html_url":"https://github.com/esben","followers_url":"https://api.github.com/users/esben/followers","following_url":"https://api.github.com/users/esben/following{/other_user}","gists_url":"https://api.github.com/users/esben/gists{/gist_id}","starred_url":"https://api.github.com/users/esben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esben/subscriptions","organizations_url":"https://api.github.com/users/esben/orgs","repos_url":"https://api.github.com/users/esben/repos","events_url":"https://api.github.com/users/esben/events{/privacy}","received_events_url":"https://api.github.com/users/esben/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2015-06-12T08:51:18Z","updated_at":"2015-10-15T08:55:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/oe-lite/core/pulls/58/commits","review_comments_url":"https://api.github.com/repos/oe-lite/core/pulls/58/comments","review_comment_url":"https://api.github.com/repos/oe-lite/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oe-lite/core/issues/58/comments","statuses_url":"https://api.github.com/repos/oe-lite/core/statuses/51ce4ecdd15466189b785ab8bc6ba763c6e743e4","head":{"label":"ksorensen:4.0_powerpc32_32bit_addressing","ref":"4.0_powerpc32_32bit_addressing","sha":"51ce4ecdd15466189b785ab8bc6ba763c6e743e4","user":{"login":"ksorensen","id":15121860,"avatar_url":"https://avatars.githubusercontent.com/u/15121860?v=3","gravatar_id":"","url":"https://api.github.com/users/ksorensen","html_url":"https://github.com/ksorensen","followers_url":"https://api.github.com/users/ksorensen/followers","following_url":"https://api.github.com/users/ksorensen/following{/other_user}","gists_url":"https://api.github.com/users/ksorensen/gists{/gist_id}","starred_url":"https://api.github.com/users/ksorensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksorensen/subscriptions","organizations_url":"https://api.github.com/users/ksorensen/orgs","repos_url":"https://api.github.com/users/ksorensen/repos","events_url":"https://api.github.com/users/ksorensen/events{/privacy}","received_events_url":"https://api.github.com/users/ksorensen/received_events","type":"User","site_admin":false},"repo":{"id":44237163,"name":"core","full_name":"ksorensen/core","owner":{"login":"ksorensen","id":15121860,"avatar_url":"https://avatars.githubusercontent.com/u/15121860?v=3","gravatar_id":"","url":"https://api.github.com/users/ksorensen","html_url":"https://github.com/ksorensen","followers_url":"https://api.github.com/users/ksorensen/followers","following_url":"https://api.github.com/users/ksorensen/following{/other_user}","gists_url":"https://api.github.com/users/ksorensen/gists{/gist_id}","starred_url":"https://api.github.com/users/ksorensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksorensen/subscriptions","organizations_url":"https://api.github.com/users/ksorensen/orgs","repos_url":"https://api.github.com/users/ksorensen/repos","events_url":"https://api.github.com/users/ksorensen/events{/privacy}","received_events_url":"https://api.github.com/users/ksorensen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksorensen/core","description":"official meta/core repository","fork":true,"url":"https://api.github.com/repos/ksorensen/core","forks_url":"https://api.github.com/repos/ksorensen/core/forks","keys_url":"https://api.github.com/repos/ksorensen/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksorensen/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksorensen/core/teams","hooks_url":"https://api.github.com/repos/ksorensen/core/hooks","issue_events_url":"https://api.github.com/repos/ksorensen/core/issues/events{/number}","events_url":"https://api.github.com/repos/ksorensen/core/events","assignees_url":"https://api.github.com/repos/ksorensen/core/assignees{/user}","branches_url":"https://api.github.com/repos/ksorensen/core/branches{/branch}","tags_url":"https://api.github.com/repos/ksorensen/core/tags","blobs_url":"https://api.github.com/repos/ksorensen/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksorensen/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksorensen/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksorensen/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksorensen/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ksorensen/core/languages","stargazers_url":"https://api.github.com/repos/ksorensen/core/stargazers","contributors_url":"https://api.github.com/repos/ksorensen/core/contributors","subscribers_url":"https://api.github.com/repos/ksorensen/core/subscribers","subscription_url":"https://api.github.com/repos/ksorensen/core/subscription","commits_url":"https://api.github.com/repos/ksorensen/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksorensen/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksorensen/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksorensen/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ksorensen/core/contents/{+path}","compare_url":"https://api.github.com/repos/ksorensen/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksorensen/core/merges","archive_url":"https://api.github.com/repos/ksorensen/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksorensen/core/downloads","issues_url":"https://api.github.com/repos/ksorensen/core/issues{/number}","pulls_url":"https://api.github.com/repos/ksorensen/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ksorensen/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ksorensen/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksorensen/core/labels{/name}","releases_url":"https://api.github.com/repos/ksorensen/core/releases{/id}","created_at":"2015-10-14T09:19:30Z","updated_at":"2015-10-14T09:19:31Z","pushed_at":"2015-10-14T13:23:13Z","git_url":"git://github.com/ksorensen/core.git","ssh_url":"git@github.com:ksorensen/core.git","clone_url":"https://github.com/ksorensen/core.git","svn_url":"https://github.com/ksorensen/core","homepage":null,"size":4699,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oe-lite:4.0","ref":"4.0","sha":"5640caefe857067f6b227c7e0a60be46af660c14","user":{"login":"oe-lite","id":7683915,"avatar_url":"https://avatars.githubusercontent.com/u/7683915?v=3","gravatar_id":"","url":"https://api.github.com/users/oe-lite","html_url":"https://github.com/oe-lite","followers_url":"https://api.github.com/users/oe-lite/followers","following_url":"https://api.github.com/users/oe-lite/following{/other_user}","gists_url":"https://api.github.com/users/oe-lite/gists{/gist_id}","starred_url":"https://api.github.com/users/oe-lite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oe-lite/subscriptions","organizations_url":"https://api.github.com/users/oe-lite/orgs","repos_url":"https://api.github.com/users/oe-lite/repos","events_url":"https://api.github.com/users/oe-lite/events{/privacy}","received_events_url":"https://api.github.com/users/oe-lite/received_events","type":"Organization","site_admin":false},"repo":{"id":26163604,"name":"core","full_name":"oe-lite/core","owner":{"login":"oe-lite","id":7683915,"avatar_url":"https://avatars.githubusercontent.com/u/7683915?v=3","gravatar_id":"","url":"https://api.github.com/users/oe-lite","html_url":"https://github.com/oe-lite","followers_url":"https://api.github.com/users/oe-lite/followers","following_url":"https://api.github.com/users/oe-lite/following{/other_user}","gists_url":"https://api.github.com/users/oe-lite/gists{/gist_id}","starred_url":"https://api.github.com/users/oe-lite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oe-lite/subscriptions","organizations_url":"https://api.github.com/users/oe-lite/orgs","repos_url":"https://api.github.com/users/oe-lite/repos","events_url":"https://api.github.com/users/oe-lite/events{/privacy}","received_events_url":"https://api.github.com/users/oe-lite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oe-lite/core","description":"official meta/core repository","fork":false,"url":"https://api.github.com/repos/oe-lite/core","forks_url":"https://api.github.com/repos/oe-lite/core/forks","keys_url":"https://api.github.com/repos/oe-lite/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oe-lite/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oe-lite/core/teams","hooks_url":"https://api.github.com/repos/oe-lite/core/hooks","issue_events_url":"https://api.github.com/repos/oe-lite/core/issues/events{/number}","events_url":"https://api.github.com/repos/oe-lite/core/events","assignees_url":"https://api.github.com/repos/oe-lite/core/assignees{/user}","branches_url":"https://api.github.com/repos/oe-lite/core/branches{/branch}","tags_url":"https://api.github.com/repos/oe-lite/core/tags","blobs_url":"https://api.github.com/repos/oe-lite/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oe-lite/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oe-lite/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/oe-lite/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oe-lite/core/statuses/{sha}","languages_url":"https://api.github.com/repos/oe-lite/core/languages","stargazers_url":"https://api.github.com/repos/oe-lite/core/stargazers","contributors_url":"https://api.github.com/repos/oe-lite/core/contributors","subscribers_url":"https://api.github.com/repos/oe-lite/core/subscribers","subscription_url":"https://api.github.com/repos/oe-lite/core/subscription","commits_url":"https://api.github.com/repos/oe-lite/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/oe-lite/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/oe-lite/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/oe-lite/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/oe-lite/core/contents/{+path}","compare_url":"https://api.github.com/repos/oe-lite/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oe-lite/core/merges","archive_url":"https://api.github.com/repos/oe-lite/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oe-lite/core/downloads","issues_url":"https://api.github.com/repos/oe-lite/core/issues{/number}","pulls_url":"https://api.github.com/repos/oe-lite/core/pulls{/number}","milestones_url":"https://api.github.com/repos/oe-lite/core/milestones{/number}","notifications_url":"https://api.github.com/repos/oe-lite/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oe-lite/core/labels{/name}","releases_url":"https://api.github.com/repos/oe-lite/core/releases{/id}","created_at":"2014-11-04T10:14:38Z","updated_at":"2015-10-04T18:44:25Z","pushed_at":"2015-10-15T08:55:38Z","git_url":"git://github.com/oe-lite/core.git","ssh_url":"git@github.com:oe-lite/core.git","clone_url":"https://github.com/oe-lite/core.git","svn_url":"https://github.com/oe-lite/core","homepage":null,"size":5283,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oe-lite/core/pulls/58"},"html":{"href":"https://github.com/oe-lite/core/pull/58"},"issue":{"href":"https://api.github.com/repos/oe-lite/core/issues/58"},"comments":{"href":"https://api.github.com/repos/oe-lite/core/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/oe-lite/core/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/oe-lite/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oe-lite/core/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/oe-lite/core/statuses/51ce4ecdd15466189b785ab8bc6ba763c6e743e4"}}}}