{"action":"created","issue":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/6291","labels_url":"https://api.github.com/repos/dmwm/WMCore/issues/6291/labels{/name}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/6291/comments","events_url":"https://api.github.com/repos/dmwm/WMCore/issues/6291/events","html_url":"https://github.com/dmwm/WMCore/pull/6291","id":108661409,"number":6291,"title":"Fix stage out deleting unwanted files","user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2015-09-28T13:47:17Z","updated_at":"2015-09-30T18:49:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/6291","html_url":"https://github.com/dmwm/WMCore/pull/6291","diff_url":"https://github.com/dmwm/WMCore/pull/6291.diff","patch_url":"https://github.com/dmwm/WMCore/pull/6291.patch"},"body":"Attempt to fix (or mitigate) #6273 \r\n\r\nI could not find any flaw in the code, then as discussed with Seangchan, I'm removing as much as possible file deletion commands. In summary:\r\n * files cleanup (when failures happen) will be done mainly at top level (cleanSuccessfulStageOuts call)\r\n * since other stage out implementation don't care for file size and checksum, I also removed it from LCGImp such that we rely solely on the exit status of lcg-cp command.\r\n * removed deferDirectoryCreation since it was always returning False\r\n * trying to place all wmagent exit codes in a single place\r\n\r\nI discussed this with @hufnagel today and he does not like the removal of additional checks. However there is not much we can do here since logs are not available after the workflow is archived. Moreover, I don't expect lcg-cp returning exit status 0 when transfer faces problems (!= file size or checksum).\r\n\r\nPylint cleanup (and my ALAN logs) were left for a bit later. For now only sharing this code for comments/review. "},"comment":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/comments/144505062","html_url":"https://github.com/dmwm/WMCore/pull/6291#issuecomment-144505062","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/6291","id":144505062,"user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T18:49:38Z","updated_at":"2015-09-30T18:49:38Z","body":"@ticoann do not merge please. It still has my loggings and I'd prefer discussing it in tomorrow's meeting."}}