{"action":"created","issue":{"url":"https://api.github.com/repos/Nycto/PicoModal/issues/18","labels_url":"https://api.github.com/repos/Nycto/PicoModal/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/Nycto/PicoModal/issues/18/comments","events_url":"https://api.github.com/repos/Nycto/PicoModal/issues/18/events","html_url":"https://github.com/Nycto/PicoModal/pull/18","id":123639157,"number":18,"title":"Able to select an alternative parent for the modal dialog box","user":{"login":"enedellec","id":9979170,"avatar_url":"https://avatars.githubusercontent.com/u/9979170?v=3","gravatar_id":"","url":"https://api.github.com/users/enedellec","html_url":"https://github.com/enedellec","followers_url":"https://api.github.com/users/enedellec/followers","following_url":"https://api.github.com/users/enedellec/following{/other_user}","gists_url":"https://api.github.com/users/enedellec/gists{/gist_id}","starred_url":"https://api.github.com/users/enedellec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enedellec/subscriptions","organizations_url":"https://api.github.com/users/enedellec/orgs","repos_url":"https://api.github.com/users/enedellec/repos","events_url":"https://api.github.com/users/enedellec/events{/privacy}","received_events_url":"https://api.github.com/users/enedellec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-23T10:55:35Z","updated_at":"2015-12-24T08:49:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Nycto/PicoModal/pulls/18","html_url":"https://github.com/Nycto/PicoModal/pull/18","diff_url":"https://github.com/Nycto/PicoModal/pull/18.diff","patch_url":"https://github.com/Nycto/PicoModal/pull/18.patch"},"body":"Hi, \r\n\r\nFirst of all, thank you for your project, and for the quality of your source code.\r\n\r\nI am proposing an enhancement to your project, because I faced an issue for displaying the modal dialog box on top of a video in full screen mode.\r\n\r\nRendering a video in full screen mode has always impacts, as you can see in that article for example : https://css-tricks.com/custom-controls-in-html5-video-full-screen/\r\n\r\nUsing your modal dialog box as it is today, won't work, because the traditional way to display elements on top of the video player is to set the z-index with the 2147483647 value (cf. the previous article).\r\n\r\nIn your case, you must have two layers, one for the overlay, and another one for the modal dialog box, so the usual trick with the 2147483647 value does not work, because if you set the overlay layer to a lower value (let's say 2147483646) it will be displayed under the player, and you can not specify a value greater than 2147483647, because it is the maximum value.\r\n\r\nAs I wanted to keep the overlay layer, I managed to make it, by attaching the overlay, and the modal dialog box elements to the video container, and not to the body element.\r\n\r\nSo, that's why I am proposing an enhancement in your source code, to be able to select an alternative parent (and not always attaching the modal dialog box to the body).\r\n\r\nI tried to respect the spirit of your source code, and to stay generic, and not only focused on my problem.\r\n\r\nI hope it helps\r\n\r\nBest regards\r\n\r\nErwan\r\n\r\nPS : In my source code, there is also the fix from my other pull request available on https://github.com/Nycto/PicoModal/pull/17\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/Nycto/PicoModal/issues/comments/167070375","html_url":"https://github.com/Nycto/PicoModal/pull/18#issuecomment-167070375","issue_url":"https://api.github.com/repos/Nycto/PicoModal/issues/18","id":167070375,"user":{"login":"enedellec","id":9979170,"avatar_url":"https://avatars.githubusercontent.com/u/9979170?v=3","gravatar_id":"","url":"https://api.github.com/users/enedellec","html_url":"https://github.com/enedellec","followers_url":"https://api.github.com/users/enedellec/followers","following_url":"https://api.github.com/users/enedellec/following{/other_user}","gists_url":"https://api.github.com/users/enedellec/gists{/gist_id}","starred_url":"https://api.github.com/users/enedellec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enedellec/subscriptions","organizations_url":"https://api.github.com/users/enedellec/orgs","repos_url":"https://api.github.com/users/enedellec/repos","events_url":"https://api.github.com/users/enedellec/events{/privacy}","received_events_url":"https://api.github.com/users/enedellec/received_events","type":"User","site_admin":false},"created_at":"2015-12-24T08:49:25Z","updated_at":"2015-12-24T08:49:25Z","body":"I double checked on my side, and I confirm that's working, and fits my needs.\r\n\r\nThank you again for your micro-library."}}