{"push_id":671776794,"size":38,"distinct_size":1,"ref":"refs/heads/for-packaging","head":"efb066d4d8f716e4862273ad5eb6589e82cfbc5b","before":"8c48bc20fef91b5481932bf2fb9dcc6b2e9e3a23","commits":[{"sha":"f4ab8203bab58b3c4ae53a99535719a747d05332","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"cmd/internal/gc: separate Node param fields\n\nParam will be converted from an anonymous to a\nnamed field in a subsequent, automated CL.\n\nReduces Node size from 368 to 328.\nReduces inuse_space on the rotate tests by about 3%.\n\nNo functional changes. Passes toolstash -cmp.\n\nUpdates #9933.\n\nChange-Id: I5867b00328abf17ee24aea6ca58876bae9d8bfed\nReviewed-on: https://go-review.googlesource.com/10210\nReviewed-by: Russ Cox <rsc@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/f4ab8203bab58b3c4ae53a99535719a747d05332"},{"sha":"82833b313e5e23f67d5ed1141d9a2464bf78f277","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"cmd/internal/gc: rearrange Node fields\n\nRearrange Node fields to enable better struct packing.\nThis reduces readability in favor of shrinking\nthe size of Nodes.\n\nThis reduces the size of Node from 328 to 312.\nThis reduces the memory usage to compile the\nrotate tests by about 4.4%.\n\nNo functional changes. Passes toolstash -cmp.\n\nUpdates #9933.\n\nChange-Id: I2764c5847fb1635ddc898e2ee385d007d67f03c5\nReviewed-on: https://go-review.googlesource.com/10141\nReviewed-by: Russ Cox <rsc@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/82833b313e5e23f67d5ed1141d9a2464bf78f277"},{"sha":"b21ff39679486c03648b1abda7ce206fcf09bc36","author":{"email":"68841e62bd2061843a4f4a0261e80b673d56389c@google.com","name":"Aaron Jacobs"},"message":"flag: Fix up a package comment a bit.\n\nI think \"the flag\" was a typo, and the word \"after\" was repetitive.\n\nChange-Id: I81c034ca11a3a778ff1eb4b3af5b96bc525ab985\nReviewed-on: https://go-review.googlesource.com/10195\nReviewed-by: Rob Pike <r@golang.org>\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/b21ff39679486c03648b1abda7ce206fcf09bc36"},{"sha":"f3fc8b024530c6b67367667455748d9b1f19eafe","author":{"email":"72d850dbd8858b791995463d8539b5a379577f28@golang.org","name":"Shenghou Ma"},"message":"time: document that not all Unix time can be represented\n\nFixes #10906.\n\nChange-Id: I7ae25a500df493c1e78183d69d89b3e2a64a0d1a\nReviewed-on: https://go-review.googlesource.com/10223\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/f3fc8b024530c6b67367667455748d9b1f19eafe"},{"sha":"366ba526e88f5b523298d3ad5014e04a495add82","author":{"email":"5ad239cb8a44f659eaaee0aa1ea5b94947abe557@golang.org","name":"Russ Cox"},"message":"cmd/internal/gc: add missing write barrier in append(x, BigStructWithPointers)\n\nFixes #10897.\n\nChange-Id: I5c2d1f9d26333e2b2a0613ebf496daa465e07c24\nReviewed-on: https://go-review.googlesource.com/10221\nReviewed-by: Austin Clements <austin@google.com>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/366ba526e88f5b523298d3ad5014e04a495add82"},{"sha":"8903b3db0e889f08587a09566927d6252c9f9ebc","author":{"email":"5ad239cb8a44f659eaaee0aa1ea5b94947abe557@golang.org","name":"Russ Cox"},"message":"runtime: add fast check for self-loop pointer in scanobject\n\nAddresses a problem reported on the mailing list.\n\nThis will come up mainly in programs custom allocators that batch allocations,\nbut it still helps in our programs, which mainly do not have such allocations.\n\nname                   old mean              new mean              delta\nBinaryTree17            5.95s × (0.97,1.03)   5.93s × (0.97,1.04)    ~    (p=0.613)\nFannkuch11              4.46s × (0.98,1.04)   4.33s × (0.99,1.01)  -2.93% (p=0.000)\nFmtFprintfEmpty        86.6ns × (0.98,1.03)  86.8ns × (0.98,1.02)    ~    (p=0.523)\nFmtFprintfString        290ns × (0.98,1.05)   287ns × (0.98,1.03)    ~    (p=0.061)\nFmtFprintfInt           271ns × (0.98,1.04)   286ns × (0.99,1.01)  +5.54% (p=0.000)\nFmtFprintfIntInt        495ns × (0.98,1.04)   489ns × (0.99,1.01)  -1.24% (p=0.015)\nFmtFprintfPrefixedInt   391ns × (0.99,1.02)   407ns × (0.99,1.01)  +4.00% (p=0.000)\nFmtFprintfFloat         578ns × (0.99,1.01)   559ns × (0.99,1.01)  -3.35% (p=0.000)\nFmtManyArgs            1.96µs × (0.98,1.05)  1.94µs × (0.99,1.01)  -1.33% (p=0.030)\nGobDecode              15.9ms × (0.97,1.05)  15.7ms × (0.99,1.01)  -1.35% (p=0.044)\nGobEncode              11.4ms × (0.97,1.05)  11.3ms × (0.98,1.03)    ~    (p=0.141)\nGzip                    658ms × (0.98,1.05)   648ms × (0.99,1.01)  -1.59% (p=0.009)\nGunzip                  144ms × (0.99,1.03)   144ms × (0.99,1.01)    ~    (p=0.867)\nHTTPClientServer       92.1µs × (0.97,1.05)  90.3µs × (0.99,1.01)  -1.89% (p=0.005)\nJSONEncode             31.0ms × (0.96,1.07)  30.2ms × (0.98,1.03)  -2.66% (p=0.001)\nJSONDecode              110ms × (0.97,1.04)   107ms × (0.99,1.01)  -2.59% (p=0.000)\nMandelbrot200          6.15ms × (0.98,1.04)  6.07ms × (0.99,1.02)  -1.32% (p=0.045)\nGoParse                6.79ms × (0.97,1.04)  6.74ms × (0.97,1.04)    ~    (p=0.242)\nRegexpMatchEasy0_32     158ns × (0.98,1.05)   155ns × (0.99,1.01)  -1.64% (p=0.010)\nRegexpMatchEasy0_1K     548ns × (0.97,1.04)   540ns × (0.99,1.01)  -1.34% (p=0.042)\nRegexpMatchEasy1_32     133ns × (0.97,1.04)   132ns × (0.97,1.05)    ~    (p=0.466)\nRegexpMatchEasy1_1K     899ns × (0.96,1.05)   878ns × (0.99,1.01)  -2.32% (p=0.002)\nRegexpMatchMedium_32    250ns × (0.96,1.03)   243ns × (0.99,1.01)  -2.90% (p=0.000)\nRegexpMatchMedium_1K   73.4µs × (0.98,1.04)  73.0µs × (0.98,1.04)    ~    (p=0.411)\nRegexpMatchHard_32     3.87µs × (0.97,1.07)  3.84µs × (0.98,1.04)    ~    (p=0.273)\nRegexpMatchHard_1K      120µs × (0.97,1.08)   117µs × (0.99,1.01)  -2.06% (p=0.010)\nRevcomp                 940ms × (0.96,1.07)   924ms × (0.97,1.07)    ~    (p=0.071)\nTemplate                128ms × (0.96,1.05)   128ms × (0.99,1.01)    ~    (p=0.502)\nTimeParse               632ns × (0.96,1.07)   616ns × (0.99,1.01)  -2.58% (p=0.001)\nTimeFormat              671ns × (0.97,1.06)   657ns × (0.99,1.02)  -2.10% (p=0.002)\n\nIn contrast to the one in test/bench/go1 (above), the binarytree program on the\nshootout site uses more goroutines, batches allocations, and sets GOMAXPROCS\nto runtime.NumCPU()*2.\n\nUsing that version, before vs after:\n\nname          old mean             new mean             delta\nBinaryTree20  18.6s × (0.96,1.05)  11.3s × (0.98,1.02)  -39.46% (p=0.000)\n\nAnd Go 1.4 vs after:\n\nname          old mean             new mean             delta\nBinaryTree20  13.0s × (0.97,1.02)  11.3s × (0.98,1.02)  -13.21% (p=0.000)\n\nThere is still a scheduling problem - the raw run times are hiding the fact that\nthis chews up 2x the CPU - but we'll take care of that separately.\n\nChange-Id: I3f5da879b24ae73a0d06745381ffb88c3744948b\nReviewed-on: https://go-review.googlesource.com/10220\nReviewed-by: Austin Clements <austin@google.com>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/8903b3db0e889f08587a09566927d6252c9f9ebc"},{"sha":"f4d51eb2f567d12c8b908f9fe3f9650e8a175eb7","author":{"email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com","name":"Austin Clements"},"message":"runtime: minor clean up to heapminimum\n\nCurrently setGCPercent sets heapminimum to heapminimum*GOGC/100. The\nreal intent is to set heapminimum to a scaled multiple of a fixed\ndefault heap minimum, not to scale heapminimum based on its current\nvalue. This turns out to be okay because setGCPercent is only called\nonce and heapminimum is initially set to this default heap minimum.\nHowever, the code as written is confusing, especially since\nsetGCPercent is otherwise written so it could be called again to\nchange GOGC. Fix this by introducing a defaultHeapMinimum constant and\nusing this instead of the current value of heapminimum to compute the\nscaled heap minimum.\n\nAs part of this, this commit improves the documentation on\nheapminimum.\n\nChange-Id: I4eb82c73dc2eb44a6e5a17c780a747a2e73d7493\nReviewed-on: https://go-review.googlesource.com/10181\nReviewed-by: Russ Cox <rsc@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/f4d51eb2f567d12c8b908f9fe3f9650e8a175eb7"},{"sha":"913db7685ec80bc9c56f357b09ced127fbf09a1e","author":{"email":"838bd060584c511f21c75c69ea04b7b120d86af0@golang.org","name":"Rick Hudson"},"message":"runtime: run background mark helpers only if work is available\n\nPrior to this CL whenever the GC marking was enabled and\na P was looking for work we supplied a G to help\nthe GC do its marking tasks. Once this G finished all\nthe marking available it would release the P to find another\navailable G. In the case where there was no work the P would drop\ninto findrunnable which would execute the mark helper G which would\nimmediately return and the P would drop into findrunnable again repeating\nthe process. Since the P was always given a G to run it never blocks.\nThis CL first checks if the GC mark helper G has available work and if\nnot the P immediately falls through to its blocking logic.\n\nFixes #10901\n\nChange-Id: I94ac9646866ba64b7892af358888bc9950de23b5\nReviewed-on: https://go-review.googlesource.com/10189\nReviewed-by: Austin Clements <austin@google.com>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/913db7685ec80bc9c56f357b09ced127fbf09a1e"},{"sha":"c735064cdeb6bf4ec84a0a4b2b48a5cafc4b83dd","author":{"email":"5ad239cb8a44f659eaaee0aa1ea5b94947abe557@golang.org","name":"Russ Cox"},"message":"cmd/internal/gc: type of str[i] is byte, not uint8\n\nFixes #8745.\n\nChange-Id: Id0641e3c0f259812b41ed871e83c68740feb2b19\nReviewed-on: https://go-review.googlesource.com/10261\nReviewed-by: Austin Clements <austin@google.com>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/c735064cdeb6bf4ec84a0a4b2b48a5cafc4b83dd"},{"sha":"9c9e36b34040d33b9f9a0b6fd918ef470338aec4","author":{"email":"5ad239cb8a44f659eaaee0aa1ea5b94947abe557@golang.org","name":"Russ Cox"},"message":"cmd/internal/gc: sync nowritebarrier checks and write barrier insertion\n\nChange-Id: I348223d0336e28d95b8e68d7653aa547acc7c9c3\nReviewed-on: https://go-review.googlesource.com/10262\nReviewed-by: Austin Clements <austin@google.com>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/9c9e36b34040d33b9f9a0b6fd918ef470338aec4"},{"sha":"8b83306cf20abed54d7cb23a3f3091b7e6202056","author":{"email":"207733b9f7aedb89ed9f240066a9af8c79257814@google.com","name":"Ryan Brown"},"message":"cmd/internal/ld: output dwarf in external link mode on darwin\n\nFixes #8973\n\nChange-Id: Idd53fc6d9e6971ae31ed72a3df3cfdce0bfbc1fd\nReviewed-on: https://go-review.googlesource.com/8661\nReviewed-by: Russ Cox <rsc@golang.org>\nRun-TryBot: Russ Cox <rsc@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/8b83306cf20abed54d7cb23a3f3091b7e6202056"},{"sha":"b3241912ff62ab64ec3c61bc8c198b6e12890a77","author":{"email":"5e38708f1e59085b9a6e7a0bcc679380704f1e58@gmail.com","name":"Alexander Zolotov"},"message":"cmd/go: run gofmt from current GOROOT\n\nThe existing implementation executes `gofmt` binary from PATH\nenvironment variable on invocation `go fmt` command.\nRelying on PATH might lead to confusions for users with several Go installations.\nIt's more appropriate to run `gofmt` from GOBIN (if defined) or GOROOT.\n\nFixes #10755\n\nChange-Id: I56d42a747319c766f2911508fab3994c3a366d12\nReviewed-on: https://go-review.googlesource.com/9900\nReviewed-by: Rob Pike <r@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/b3241912ff62ab64ec3c61bc8c198b6e12890a77"},{"sha":"f763da3d3404673484bcc9d0d911c75a40e326c2","author":{"email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com","name":"Austin Clements"},"message":"cmd/internal/gc: remove incorrect \"write barrier prohibited\" error\n\nCommit 9c9e36b pushed these errors down to where the write barriers\nare actually emitted, but forgot to remove the original error that was\nbeing pushed down.\n\nChange-Id: I751752a896e78fb9e63d69f88e7fb8d1ff5d344c\nReviewed-on: https://go-review.googlesource.com/10264\nReviewed-by: Russ Cox <rsc@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/f763da3d3404673484bcc9d0d911c75a40e326c2"},{"sha":"d6bbcea22a3d4cbcf8350b4b861f0d73ab142ac2","author":{"email":"72d850dbd8858b791995463d8539b5a379577f28@golang.org","name":"Shenghou Ma"},"message":"cmd/go: fix build\n\nChange-Id: Ib6c121414c74f8a40eb87a52af8737502ce7216d\nReviewed-on: https://go-review.googlesource.com/10265\nReviewed-by: Josh Bleecher Snyder <josharian@gmail.com>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/d6bbcea22a3d4cbcf8350b4b861f0d73ab142ac2"},{"sha":"a1c1a763bc7c8d10ec30a7fa60ecf7d5f9a6f1c8","author":{"email":"39a219e50b35b2484efaaa187fda16b27b6c5abe@gmail.com","name":"Didier Spezia"},"message":"html/template: fix string iteration in replacement operations\n\nIn css, js, and html, the replacement operations are implemented\nby iterating on strings (rune by rune). The for/range\nstatement is used. The length of the rune is required\nand added to the index to properly slice the string.\n\nThis is potentially wrong because there is a discrepancy between\nthe result of utf8.RuneLen and the increment of the index\n(set by the for/range statement). For invalid strings,\nutf8.RuneLen('\\ufffd') == 3, while the index is incremented\nonly by 1 byte.\n\nhtmlReplacer triggers a panic at slicing time for some\ninvalid strings.\n\nUse a more robust iteration mechanism based on\nutf8.DecodeRuneInString, and make sure the same\npattern is used for all similar functions in this\npackage.\n\nFixes #10799\n\nChange-Id: Ibad3857b2819435d9fa564f06fc2ca8774102841\nReviewed-on: https://go-review.googlesource.com/10105\nReviewed-by: Rob Pike <r@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/a1c1a763bc7c8d10ec30a7fa60ecf7d5f9a6f1c8"},{"sha":"791bb4f5aefdf3d7ae8aea7d360dec6cb238698a","author":{"email":"72d850dbd8858b791995463d8539b5a379577f28@golang.org","name":"Shenghou Ma"},"message":"cmd/internal/gc: handle 64-bit const i/j/k in cgen_slice on ARM\n\n386 is not affected because it doesn't use ginscmp.\n\nFixes #10843.\n\nChange-Id: I1b3a133bd1e5fabc85236f15d060dbaa4c391cf3\nReviewed-on: https://go-review.googlesource.com/10116\nReviewed-by: Russ Cox <rsc@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/791bb4f5aefdf3d7ae8aea7d360dec6cb238698a"},{"sha":"c013417a45fbf950e8eb5a5e2ae37d2219c9e1d8","author":{"email":"72d850dbd8858b791995463d8539b5a379577f28@golang.org","name":"Shenghou Ma"},"message":"misc/cgo/testshared: when checking for RPATHs also look for DT_RUNPATH\n\nOn my systems, ld -rpath sets DT_RUNPATH instead of DT_RPATH.\n\nChange-Id: I5047e795fb7ef9336f5fa13ba24bb6245c0b0582\nReviewed-on: https://go-review.googlesource.com/10260\nReviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/c013417a45fbf950e8eb5a5e2ae37d2219c9e1d8"},{"sha":"7bdb4a28a87f24a6c00ae3194598934e0fa142f0","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"Revert \"cmd/internal/ld: output dwarf in external link mode on darwin\"\n\nThis reverts commit 8b83306cf20abed54d7cb23a3f3091b7e6202056.\n\nChange-Id: I3fb998bdf11eceef13e3997e336d86e7c5d47a60\nReviewed-on: https://go-review.googlesource.com/10254\nReviewed-by: Minux Ma <minux@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/7bdb4a28a87f24a6c00ae3194598934e0fa142f0"},{"sha":"17177a0daa7d08c7031fe10b9be8d070db5fe278","author":{"email":"e2f4d2eec1d9a1f781345cdd7260d7d52e6468ae@gmail.com","name":"Mikio Hara"},"message":"net: fix data race in TestSocket{Conn,PacketConn}\n\nFixes #10891.\n\nChange-Id: Ie432c9c5520ac29cea8fe6452628ec467567eea5\nReviewed-on: https://go-review.googlesource.com/10194\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/17177a0daa7d08c7031fe10b9be8d070db5fe278"},{"sha":"7eec656bfd111531f548dbb5c7f3b6d18525f4ab","author":{"email":"e2f4d2eec1d9a1f781345cdd7260d7d52e6468ae@gmail.com","name":"Mikio Hara"},"message":"net: fix the series of TestLookup and external tests\n\nOn Windows, we need to make sure that the node under test has external\nconnectivity.\n\nFixes #10795.\n\nChange-Id: I99f2336180c7b56474fa90a4a6cdd5a6c4dd3805\nReviewed-on: https://go-review.googlesource.com/10006\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":false,"url":"https://api.github.com/repos/mwhudson/go/commits/7eec656bfd111531f548dbb5c7f3b6d18525f4ab"}]}