{"action":"created","issue":{"url":"https://api.github.com/repos/pathikrit/better-files/issues/38","labels_url":"https://api.github.com/repos/pathikrit/better-files/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/pathikrit/better-files/issues/38/comments","events_url":"https://api.github.com/repos/pathikrit/better-files/issues/38/events","html_url":"https://github.com/pathikrit/better-files/pull/38","id":113636365,"number":38,"title":"Add zip options","user":{"login":"pedrorijo91","id":1999050,"avatar_url":"https://avatars.githubusercontent.com/u/1999050?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrorijo91","html_url":"https://github.com/pedrorijo91","followers_url":"https://api.github.com/users/pedrorijo91/followers","following_url":"https://api.github.com/users/pedrorijo91/following{/other_user}","gists_url":"https://api.github.com/users/pedrorijo91/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrorijo91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrorijo91/subscriptions","organizations_url":"https://api.github.com/users/pedrorijo91/orgs","repos_url":"https://api.github.com/users/pedrorijo91/repos","events_url":"https://api.github.com/users/pedrorijo91/events{/privacy}","received_events_url":"https://api.github.com/users/pedrorijo91/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-27T17:22:16Z","updated_at":"2015-10-27T19:01:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pathikrit/better-files/pulls/38","html_url":"https://github.com/pathikrit/better-files/pull/38","diff_url":"https://github.com/pathikrit/better-files/pull/38.diff","patch_url":"https://github.com/pathikrit/better-files/pull/38.patch"},"body":"Enabled the possibility of specify if a zip file is:\r\n\r\n* uncompressed\r\n* compressed\r\n* compression level\r\n\r\nProvides some of the features described in https://github.com/pathikrit/better-files/issues/16\r\n\r\n> Solution implemented based on ZipOutputStream documentantion at http://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipOutputStream.html#setLevel(int)  and http://stackoverflow.com/questions/1206970/creating-zip-using-zip-utility"},"comment":{"url":"https://api.github.com/repos/pathikrit/better-files/issues/comments/151610882","html_url":"https://github.com/pathikrit/better-files/pull/38#issuecomment-151610882","issue_url":"https://api.github.com/repos/pathikrit/better-files/issues/38","id":151610882,"user":{"login":"pedrorijo91","id":1999050,"avatar_url":"https://avatars.githubusercontent.com/u/1999050?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrorijo91","html_url":"https://github.com/pedrorijo91","followers_url":"https://api.github.com/users/pedrorijo91/followers","following_url":"https://api.github.com/users/pedrorijo91/following{/other_user}","gists_url":"https://api.github.com/users/pedrorijo91/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrorijo91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrorijo91/subscriptions","organizations_url":"https://api.github.com/users/pedrorijo91/orgs","repos_url":"https://api.github.com/users/pedrorijo91/repos","events_url":"https://api.github.com/users/pedrorijo91/events{/privacy}","received_events_url":"https://api.github.com/users/pedrorijo91/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T19:01:28Z","updated_at":"2015-10-27T19:01:28Z","body":"@pathikrit as far as I've seen it is possible to have several cases:\r\n\r\n* compression and compression level > 0 (default behaviour with level= 9)\r\n* no compression (in which we should set level = 0 as seen in stackoverflow ans)\r\n* compression and compression level = 0 (that seems to be equal to no compression, but nowhere says that the semantics is and will be the same)\r\n\r\nI see no problem, and, in fact, it would be more user friendly, to control the compression using a single parameter. "}}