{"comment":{"url":"https://api.github.com/repos/open-mpi/hwloc/comments/13188662","html_url":"https://github.com/open-mpi/hwloc/commit/86ac6a31ba32f46c8c0615a88cc2dc582e184473#commitcomment-13188662","id":13188662,"user":{"login":"sthibaul","id":5405051,"avatar_url":"https://avatars.githubusercontent.com/u/5405051?v=3","gravatar_id":"","url":"https://api.github.com/users/sthibaul","html_url":"https://github.com/sthibaul","followers_url":"https://api.github.com/users/sthibaul/followers","following_url":"https://api.github.com/users/sthibaul/following{/other_user}","gists_url":"https://api.github.com/users/sthibaul/gists{/gist_id}","starred_url":"https://api.github.com/users/sthibaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthibaul/subscriptions","organizations_url":"https://api.github.com/users/sthibaul/orgs","repos_url":"https://api.github.com/users/sthibaul/repos","events_url":"https://api.github.com/users/sthibaul/events{/privacy}","received_events_url":"https://api.github.com/users/sthibaul/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"86ac6a31ba32f46c8c0615a88cc2dc582e184473","created_at":"2015-09-11T18:06:52Z","updated_at":"2015-09-11T18:06:52Z","body":"Samuel Thibault, le Fri 11 Sep 2015 19:57:10 +0200, a écrit :\n> Samuel Thibault, le Fri 11 Sep 2015 19:51:26 +0200, a écrit :\n> > AIUI, yes, the order is supposed to be\n> > \n> > $(X_PRE_LIBS) $(X_LIBS) -lX11 $(X_EXTRA_LIBS) \n> \n> Or put another way, the right way to detect X11 is to put\n> $(X_EXTRA_LIBS) in the OTHER-LIBRARIES parameter of AC_CHECK_LIB after\n> having put X_PRE_LIBS and X_LIBS in LIBS.\n\nAh, no, not even, since $(LIBS) will be put after -lX11. What I'm\nconfident on is the final link order\n\n$(X_PRE_LIBS) $(X_LIBS) -lX11 $(X_EXTRA_LIBS) \nPerhaps we just don't need to run AC_CHECK_LIB at all since once\nAC_PATH_XTRA is used, no_x is supposed to already tell us whether libX11\nis available or not (it already does the link test), and then we can\njust do\n\nHWLOC_X11_LIBS=\"$(X_PRE_LIBS) $(X_LIBS) -lX11 $(X_EXTRA_LIBS)\"\n\naccordingly.\n\nSamuel\n"}}