{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments/44489873","id":44489873,"diff_hunk":"@@ -0,0 +1,181 @@\n+import Ember from 'ember';\n+\n+export default Ember.Mixin.create({\n+  /**\n+   * Toggle axis titles on/off\n+   * @type {Boolean}\n+   */\n+  hasAxisTitles: false,\n+\n+  /**\n+   * Title for the x axis\n+   * @type {String}\n+   */\n+  xValueDisplayName: null,\n+\n+  /**\n+   * Title for the y axis\n+   * @type {String}\n+   */\n+  yValueDisplayName: null,\n+\n+  /**\n+   * Computed title for the x axis, if the `hasAxisTitles` boolean is false\n+   * `xAxisTitleDisplayValue` should be an empty string\n+   * @type {String}\n+   */\n+  xAxisTitleDisplayValue: Ember.computed('hasAxisTitles', 'xValueDisplayName', function(){\n+    return this.get('hasAxisTitles') === true ? this.get('xValueDisplayName') : '';\n+  }),\n+\n+  /**\n+   * Computed title for the x axis, if the `hasAxisTitles` boolean is false\n+   * `yAxisTitleDisplayValue` should be an empty string\n+   * @type {String}\n+   */\n+  yAxisTitleDisplayValue: Ember.computed('hasAxisTitles', 'yValueDisplayName', function(){\n+    return this.get('hasAxisTitles') === true ? this.get('yValueDisplayName') : '';\n+  }),\n+\n+  /**\n+   * Computed left margin, if the `hasAxisTitles` is false this should be 0\n+   * @type {Number}\n+   */\n+  horizontalMarginLeft: Ember.computed('hasAxisTitles', function(){\n+    return this.get('hasAxisTitles') === true ? 20 : 0;\n+  }),\n+\n+  /**\n+   * Accessed value within d3\n+   * @alias `horizontalMarginLeft`\n+   * @type {Number}\n+   */\n+  marginLeft: Ember.computed.alias('horizontalMarginLeft'),\n+\n+  /**\n+   * Computed title height plus label padding or 0 if `hasAxisTitles` is false\n+   * @type {Number}\n+   */\n+  axisTitleHeightOffset: Ember.computed('axisTitleHeight', 'labelPadding', function() {\n+    if(this.get('hasAxisTitles') === true){\n+      return this.get('axisTitleHeight') + this.get('labelPadding');\n+    }else{\n+      return 0;\n+    }\n+  }),\n+\n+  /**\n+   * D3 reference to x axis-title","path":"addon/mixins/axis-titles.js","position":68,"original_position":68,"commit_id":"218deb11bd4bbad6ccfae9b46ef6e778836856cc","original_commit_id":"218deb11bd4bbad6ccfae9b46ef6e778836856cc","user":{"login":"embooglement","id":2358927,"avatar_url":"https://avatars.githubusercontent.com/u/2358927?v=3","gravatar_id":"","url":"https://api.github.com/users/embooglement","html_url":"https://github.com/embooglement","followers_url":"https://api.github.com/users/embooglement/followers","following_url":"https://api.github.com/users/embooglement/following{/other_user}","gists_url":"https://api.github.com/users/embooglement/gists{/gist_id}","starred_url":"https://api.github.com/users/embooglement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embooglement/subscriptions","organizations_url":"https://api.github.com/users/embooglement/orgs","repos_url":"https://api.github.com/users/embooglement/repos","events_url":"https://api.github.com/users/embooglement/events{/privacy}","received_events_url":"https://api.github.com/users/embooglement/received_events","type":"User","site_admin":false},"body":"We should be consistent about how we stylize `d3`","created_at":"2015-11-11T01:01:25Z","updated_at":"2015-11-11T01:01:25Z","html_url":"https://github.com/Addepar/ember-charts/pull/121#discussion_r44489873","pull_request_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments/44489873"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/121#discussion_r44489873"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/121","id":50178758,"html_url":"https://github.com/Addepar/ember-charts/pull/121","diff_url":"https://github.com/Addepar/ember-charts/pull/121.diff","patch_url":"https://github.com/Addepar/ember-charts/pull/121.patch","issue_url":"https://api.github.com/repos/Addepar/ember-charts/issues/121","number":121,"state":"open","locked":false,"title":"Jordan/chart labels","user":{"login":"jordansmith42","id":1065623,"avatar_url":"https://avatars.githubusercontent.com/u/1065623?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansmith42","html_url":"https://github.com/jordansmith42","followers_url":"https://api.github.com/users/jordansmith42/followers","following_url":"https://api.github.com/users/jordansmith42/following{/other_user}","gists_url":"https://api.github.com/users/jordansmith42/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansmith42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansmith42/subscriptions","organizations_url":"https://api.github.com/users/jordansmith42/orgs","repos_url":"https://api.github.com/users/jordansmith42/repos","events_url":"https://api.github.com/users/jordansmith42/events{/privacy}","received_events_url":"https://api.github.com/users/jordansmith42/received_events","type":"User","site_admin":false},"body":"Moves axis titles from scatter chart to a mixin\r\nAdds a default state of no axis titles with no margins and adds a toggle for titles","created_at":"2015-11-09T21:17:50Z","updated_at":"2015-11-11T01:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a30798a566625f648c853e3059f464b12fdbd12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/121/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/121/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/issues/121/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/218deb11bd4bbad6ccfae9b46ef6e778836856cc","head":{"label":"Addepar:jordan/chart-labels","ref":"jordan/chart-labels","sha":"218deb11bd4bbad6ccfae9b46ef6e778836856cc","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-05T10:50:31Z","pushed_at":"2015-11-11T00:19:27Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":9755,"stargazers_count":654,"watchers_count":654,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":21,"forks":98,"open_issues":21,"watchers":654,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"ccfbebcdcc316302ef34c0d963a011d6612ea61b","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-05T10:50:31Z","pushed_at":"2015-11-11T00:19:27Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":9755,"stargazers_count":654,"watchers_count":654,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":21,"forks":98,"open_issues":21,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/121"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/121"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/121"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-charts/statuses/218deb11bd4bbad6ccfae9b46ef6e778836856cc"}}}}