{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/tedium/pulls/12","id":52760664,"html_url":"https://github.com/PolymerLabs/tedium/pull/12","diff_url":"https://github.com/PolymerLabs/tedium/pull/12.diff","patch_url":"https://github.com/PolymerLabs/tedium/pull/12.patch","issue_url":"https://api.github.com/repos/PolymerLabs/tedium/issues/12","number":12,"state":"closed","locked":false,"title":"Convert tedium to Typescript","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"I think there's a pretty decent case for converting our tools repos to typescript. The tools code is doing deterministic work with very structured data in a variety of ways, which is the kind of code where a type system can help out a lot.\r\n\r\nI started with tedium because it's a fairly small and self contained repo, and it's not very community facing, so no one but us will be inconvenienced by the churn if we switch to TS and then back to JS if it doesn't work out.\r\n\r\nI'd propose that we start with tedium and kick the tires some. Try to answer questions like:\r\n * Is this code legible? \r\n * Does writing our tools code in typescript constrain us, or make it difficult for others to work with the code?\r\n * How long does it take to get comfortable making changes to this sort of code? \r\n * Are the compiler warnings helpful or are we spending too much time just appeasing it?\r\n\r\nIf we like the answers to those questions we can consider migrating another tool to typescript. I've got a version of hydrolysis that's [been migrated here](https://github.com/rictic/hydrolysis/compare/master...typescript-experiment) if you're interested in seeing what that might look like.\r\n\r\nA few notes:\r\n  * this compiles cleanly with no warnings or errors\r\n  * all configuration is in tsconfig.json, so to compile you just invoke `tsc` with no arguments, or `npm run build`, or even `npm run build:watch` to automatically rebuild as files change.\r\n  * the `atom-typescript` plugin is very awesome, I'd strongly recommend it. I believe that there's also  good plugins for vim and sublime text. On the mac there's [an Atom bug](https://github.com/atom/atom/issues/9663) that causes the plugin to be flaky. It's fixed in the Atom 1.3 beta.\r\n  * the typescript compiler doesn't do obfuscation, the output is just the ES6 that corresponds to this code\r\n\r\n/cc @garlicnation @cdata @notwaldorf & anyone else who may be interested","created_at":"2015-12-05T18:12:12Z","updated_at":"2015-12-10T19:31:51Z","closed_at":"2015-12-10T19:31:51Z","merged_at":"2015-12-10T19:31:51Z","merge_commit_sha":"85f4944b23e57d21f845f3d11557e4208b623fc1","assignee":{"login":"azakus","id":46725,"avatar_url":"https://avatars.githubusercontent.com/u/46725?v=3","gravatar_id":"","url":"https://api.github.com/users/azakus","html_url":"https://github.com/azakus","followers_url":"https://api.github.com/users/azakus/followers","following_url":"https://api.github.com/users/azakus/following{/other_user}","gists_url":"https://api.github.com/users/azakus/gists{/gist_id}","starred_url":"https://api.github.com/users/azakus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azakus/subscriptions","organizations_url":"https://api.github.com/users/azakus/orgs","repos_url":"https://api.github.com/users/azakus/repos","events_url":"https://api.github.com/users/azakus/events{/privacy}","received_events_url":"https://api.github.com/users/azakus/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/tedium/pulls/12/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/tedium/pulls/12/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/tedium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/tedium/issues/12/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/tedium/statuses/c34d7f259630b3c9e4747000ccb643ca417d2264","head":{"label":"PolymerLabs:typescript-lol","ref":"typescript-lol","sha":"c34d7f259630b3c9e4747000ccb643ca417d2264","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":45142797,"name":"tedium","full_name":"PolymerLabs/tedium","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/tedium","description":"A bot for doing mass changes to github repos for the Polymer team","fork":false,"url":"https://api.github.com/repos/PolymerLabs/tedium","forks_url":"https://api.github.com/repos/PolymerLabs/tedium/forks","keys_url":"https://api.github.com/repos/PolymerLabs/tedium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/tedium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/tedium/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/tedium/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/tedium/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/tedium/events","assignees_url":"https://api.github.com/repos/PolymerLabs/tedium/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/tedium/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/tedium/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/tedium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/tedium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/tedium/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/tedium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/tedium/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/tedium/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/tedium/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/tedium/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/tedium/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/tedium/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/tedium/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/tedium/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/tedium/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/tedium/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/tedium/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/tedium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/tedium/merges","archive_url":"https://api.github.com/repos/PolymerLabs/tedium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/tedium/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/tedium/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/tedium/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/tedium/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/tedium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/tedium/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/tedium/releases{/id}","created_at":"2015-10-28T21:25:30Z","updated_at":"2015-11-22T11:45:58Z","pushed_at":"2015-12-10T19:31:51Z","git_url":"git://github.com/PolymerLabs/tedium.git","ssh_url":"git@github.com:PolymerLabs/tedium.git","clone_url":"https://github.com/PolymerLabs/tedium.git","svn_url":"https://github.com/PolymerLabs/tedium","homepage":null,"size":107,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"bc1a6ee94ec52fce063c7f9b1b25b7eedcfe1213","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":45142797,"name":"tedium","full_name":"PolymerLabs/tedium","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/tedium","description":"A bot for doing mass changes to github repos for the Polymer team","fork":false,"url":"https://api.github.com/repos/PolymerLabs/tedium","forks_url":"https://api.github.com/repos/PolymerLabs/tedium/forks","keys_url":"https://api.github.com/repos/PolymerLabs/tedium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/tedium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/tedium/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/tedium/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/tedium/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/tedium/events","assignees_url":"https://api.github.com/repos/PolymerLabs/tedium/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/tedium/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/tedium/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/tedium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/tedium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/tedium/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/tedium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/tedium/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/tedium/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/tedium/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/tedium/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/tedium/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/tedium/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/tedium/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/tedium/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/tedium/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/tedium/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/tedium/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/tedium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/tedium/merges","archive_url":"https://api.github.com/repos/PolymerLabs/tedium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/tedium/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/tedium/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/tedium/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/tedium/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/tedium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/tedium/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/tedium/releases{/id}","created_at":"2015-10-28T21:25:30Z","updated_at":"2015-11-22T11:45:58Z","pushed_at":"2015-12-10T19:31:51Z","git_url":"git://github.com/PolymerLabs/tedium.git","ssh_url":"git@github.com:PolymerLabs/tedium.git","clone_url":"https://github.com/PolymerLabs/tedium.git","svn_url":"https://github.com/PolymerLabs/tedium","homepage":null,"size":107,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/tedium/pulls/12"},"html":{"href":"https://github.com/PolymerLabs/tedium/pull/12"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/tedium/issues/12"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/tedium/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/tedium/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/tedium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/tedium/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/tedium/statuses/c34d7f259630b3c9e4747000ccb643ca417d2264"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"comments":3,"review_comments":5,"commits":20,"additions":1547,"deletions":912,"changed_files":30}}