{"action":"created","comment":{"url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/22431320","id":22431320,"diff_hunk":"@@ -184,23 +184,13 @@ std::vector<Vessel*> PhysicsBubble::vessels() const {\n   return vessels;\n }\n \n-Displacement<Barycentric> const&\n-PhysicsBubble::displacement_from_centre_of_mass(\n-    Vessel const* const vessel) const {\n+RelativeDegreesOfFreedom<Barycentric> const&\n+PhysicsBubble::from_centre_of_mass(Vessel const* const vessel) const {\n   CHECK(!empty()) << \"Empty bubble\";\n-  CHECK(current_->displacements_from_centre_of_mass != nullptr);\n-  auto const it = current_->displacements_from_centre_of_mass->find(vessel);\n-  CHECK(it != current_->displacements_from_centre_of_mass->end());\n-  return it->second;\n-}\n-\n-Velocity<Barycentric> const&\n-PhysicsBubble::velocity_from_centre_of_mass(\n-    Vessel const* const vessel) const {\n-  CHECK(!empty()) << \"Empty bubble\";\n-  CHECK(current_->velocities_from_centre_of_mass != nullptr);\n-  auto const it = current_->velocities_from_centre_of_mass->find(vessel);\n-  CHECK(it != current_->velocities_from_centre_of_mass->end());\n+  CHECK(current_->from_centre_of_mass != nullptr);\n+  auto const it = \n+      current_->from_centre_of_mass->find(vessel);","path":"ksp_plugin/physics_bubble.cpp","position":25,"original_position":25,"commit_id":"33178c632d833c801383e2377aac43ef6fd6bb09","original_commit_id":"33178c632d833c801383e2377aac43ef6fd6bb09","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2015-01-03T12:35:36Z","updated_at":"2015-01-03T12:35:36Z","html_url":"https://github.com/mockingbirdnest/Principia/pull/365#discussion_r22431320","pull_request_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/22431320"},"html":{"href":"https://github.com/mockingbirdnest/Principia/pull/365#discussion_r22431320"},"pull_request":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365","id":26782277,"html_url":"https://github.com/mockingbirdnest/Principia/pull/365","diff_url":"https://github.com/mockingbirdnest/Principia/pull/365.diff","patch_url":"https://github.com/mockingbirdnest/Principia/pull/365.patch","issue_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/365","number":365,"state":"open","locked":false,"title":"Change the C++ code to use the new DegreesOfFreedom wherever possible","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"body":"C# not affected for now.","created_at":"2015-01-03T12:10:36Z","updated_at":"2015-01-03T12:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"113a18c2403841652cdf9a95f76225d7c4108654","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365/commits","review_comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365/comments","review_comment_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/365/comments","statuses_url":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/33178c632d833c801383e2377aac43ef6fd6bb09","head":{"label":"pleroy:UseDOF","ref":"UseDOF","sha":"33178c632d833c801383e2377aac43ef6fd6bb09","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"repo":{"id":19217274,"name":"Principia","full_name":"pleroy/Principia","owner":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pleroy/Principia","description":"N-Body Gravitation and Better Integrators for Kerbal Space Program","fork":true,"url":"https://api.github.com/repos/pleroy/Principia","forks_url":"https://api.github.com/repos/pleroy/Principia/forks","keys_url":"https://api.github.com/repos/pleroy/Principia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pleroy/Principia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pleroy/Principia/teams","hooks_url":"https://api.github.com/repos/pleroy/Principia/hooks","issue_events_url":"https://api.github.com/repos/pleroy/Principia/issues/events{/number}","events_url":"https://api.github.com/repos/pleroy/Principia/events","assignees_url":"https://api.github.com/repos/pleroy/Principia/assignees{/user}","branches_url":"https://api.github.com/repos/pleroy/Principia/branches{/branch}","tags_url":"https://api.github.com/repos/pleroy/Principia/tags","blobs_url":"https://api.github.com/repos/pleroy/Principia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pleroy/Principia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pleroy/Principia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pleroy/Principia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pleroy/Principia/statuses/{sha}","languages_url":"https://api.github.com/repos/pleroy/Principia/languages","stargazers_url":"https://api.github.com/repos/pleroy/Principia/stargazers","contributors_url":"https://api.github.com/repos/pleroy/Principia/contributors","subscribers_url":"https://api.github.com/repos/pleroy/Principia/subscribers","subscription_url":"https://api.github.com/repos/pleroy/Principia/subscription","commits_url":"https://api.github.com/repos/pleroy/Principia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pleroy/Principia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pleroy/Principia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pleroy/Principia/issues/comments/{number}","contents_url":"https://api.github.com/repos/pleroy/Principia/contents/{+path}","compare_url":"https://api.github.com/repos/pleroy/Principia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pleroy/Principia/merges","archive_url":"https://api.github.com/repos/pleroy/Principia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pleroy/Principia/downloads","issues_url":"https://api.github.com/repos/pleroy/Principia/issues{/number}","pulls_url":"https://api.github.com/repos/pleroy/Principia/pulls{/number}","milestones_url":"https://api.github.com/repos/pleroy/Principia/milestones{/number}","notifications_url":"https://api.github.com/repos/pleroy/Principia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pleroy/Principia/labels{/name}","releases_url":"https://api.github.com/repos/pleroy/Principia/releases{/id}","created_at":"2014-04-27T20:57:02Z","updated_at":"2015-01-02T19:07:47Z","pushed_at":"2015-01-03T12:10:01Z","git_url":"git://github.com/pleroy/Principia.git","ssh_url":"git@github.com:pleroy/Principia.git","clone_url":"https://github.com/pleroy/Principia.git","svn_url":"https://github.com/pleroy/Principia","homepage":"http://forum.kerbalspaceprogram.com/threads/68502-WIP-Principia-N-Body-Gravitation-and-Better-Integrators-for-Kerbal-Space-Program","size":16707,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mockingbirdnest:master","ref":"master","sha":"2cd2d137295bbc83750f54c497a127540a4d3651","user":{"login":"mockingbirdnest","id":7462691,"avatar_url":"https://avatars.githubusercontent.com/u/7462691?v=3","gravatar_id":"","url":"https://api.github.com/users/mockingbirdnest","html_url":"https://github.com/mockingbirdnest","followers_url":"https://api.github.com/users/mockingbirdnest/followers","following_url":"https://api.github.com/users/mockingbirdnest/following{/other_user}","gists_url":"https://api.github.com/users/mockingbirdnest/gists{/gist_id}","starred_url":"https://api.github.com/users/mockingbirdnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockingbirdnest/subscriptions","organizations_url":"https://api.github.com/users/mockingbirdnest/orgs","repos_url":"https://api.github.com/users/mockingbirdnest/repos","events_url":"https://api.github.com/users/mockingbirdnest/events{/privacy}","received_events_url":"https://api.github.com/users/mockingbirdnest/received_events","type":"Organization","site_admin":false},"repo":{"id":16634370,"name":"Principia","full_name":"mockingbirdnest/Principia","owner":{"login":"mockingbirdnest","id":7462691,"avatar_url":"https://avatars.githubusercontent.com/u/7462691?v=3","gravatar_id":"","url":"https://api.github.com/users/mockingbirdnest","html_url":"https://github.com/mockingbirdnest","followers_url":"https://api.github.com/users/mockingbirdnest/followers","following_url":"https://api.github.com/users/mockingbirdnest/following{/other_user}","gists_url":"https://api.github.com/users/mockingbirdnest/gists{/gist_id}","starred_url":"https://api.github.com/users/mockingbirdnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockingbirdnest/subscriptions","organizations_url":"https://api.github.com/users/mockingbirdnest/orgs","repos_url":"https://api.github.com/users/mockingbirdnest/repos","events_url":"https://api.github.com/users/mockingbirdnest/events{/privacy}","received_events_url":"https://api.github.com/users/mockingbirdnest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mockingbirdnest/Principia","description":"N-Body Gravitation and Better Integrators for Kerbal Space Program","fork":false,"url":"https://api.github.com/repos/mockingbirdnest/Principia","forks_url":"https://api.github.com/repos/mockingbirdnest/Principia/forks","keys_url":"https://api.github.com/repos/mockingbirdnest/Principia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mockingbirdnest/Principia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mockingbirdnest/Principia/teams","hooks_url":"https://api.github.com/repos/mockingbirdnest/Principia/hooks","issue_events_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/events{/number}","events_url":"https://api.github.com/repos/mockingbirdnest/Principia/events","assignees_url":"https://api.github.com/repos/mockingbirdnest/Principia/assignees{/user}","branches_url":"https://api.github.com/repos/mockingbirdnest/Principia/branches{/branch}","tags_url":"https://api.github.com/repos/mockingbirdnest/Principia/tags","blobs_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/{sha}","languages_url":"https://api.github.com/repos/mockingbirdnest/Principia/languages","stargazers_url":"https://api.github.com/repos/mockingbirdnest/Principia/stargazers","contributors_url":"https://api.github.com/repos/mockingbirdnest/Principia/contributors","subscribers_url":"https://api.github.com/repos/mockingbirdnest/Principia/subscribers","subscription_url":"https://api.github.com/repos/mockingbirdnest/Principia/subscription","commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mockingbirdnest/Principia/contents/{+path}","compare_url":"https://api.github.com/repos/mockingbirdnest/Principia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mockingbirdnest/Principia/merges","archive_url":"https://api.github.com/repos/mockingbirdnest/Principia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mockingbirdnest/Principia/downloads","issues_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues{/number}","pulls_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls{/number}","milestones_url":"https://api.github.com/repos/mockingbirdnest/Principia/milestones{/number}","notifications_url":"https://api.github.com/repos/mockingbirdnest/Principia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mockingbirdnest/Principia/labels{/name}","releases_url":"https://api.github.com/repos/mockingbirdnest/Principia/releases{/id}","created_at":"2014-02-08T02:55:32Z","updated_at":"2015-01-02T19:07:22Z","pushed_at":"2015-01-02T19:07:20Z","git_url":"git://github.com/mockingbirdnest/Principia.git","ssh_url":"git@github.com:mockingbirdnest/Principia.git","clone_url":"https://github.com/mockingbirdnest/Principia.git","svn_url":"https://github.com/mockingbirdnest/Principia","homepage":"http://forum.kerbalspaceprogram.com/threads/68502-WIP-Principia-N-Body-Gravitation-and-Better-Integrators-for-Kerbal-Space-Program","size":17410,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":20,"forks":3,"open_issues":20,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365"},"html":{"href":"https://github.com/mockingbirdnest/Principia/pull/365"},"issue":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/issues/365"},"comments":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/33178c632d833c801383e2377aac43ef6fd6bb09"}}}}