{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/27324691","id":27324691,"diff_hunk":"@@ -20,6 +20,8 @@ def test_units():\n     t = Symbol('t')\n     assert integrate(t*m/s, (t, 1*s, 5*s)) == 12*m*s\n     assert (t * m/s).integrate((t, 1*s, 5*s)) == 12*m*s\n+    \n+    assert float( (year / week).evalf(15) ) == 52.17745571428571","path":"sympy/physics/tests/test_units.py","position":5,"original_position":5,"commit_id":"45438b6db183be03559b1b5ba027aaa8502c7d7d","original_commit_id":"45438b6db183be03559b1b5ba027aaa8502c7d7d","user":{"login":"moorepants","id":276007,"avatar_url":"https://avatars.githubusercontent.com/u/276007?v=3","gravatar_id":"","url":"https://api.github.com/users/moorepants","html_url":"https://github.com/moorepants","followers_url":"https://api.github.com/users/moorepants/followers","following_url":"https://api.github.com/users/moorepants/following{/other_user}","gists_url":"https://api.github.com/users/moorepants/gists{/gist_id}","starred_url":"https://api.github.com/users/moorepants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorepants/subscriptions","organizations_url":"https://api.github.com/users/moorepants/orgs","repos_url":"https://api.github.com/users/moorepants/repos","events_url":"https://api.github.com/users/moorepants/events{/privacy}","received_events_url":"https://api.github.com/users/moorepants/received_events","type":"User","site_admin":false},"body":"If you compare Python floats you must use the `abs(act - exp) < tol`. But if you compare SymPy `Float`s, which are arbitrary precision, then you can compare all the digits: `(year / week).evalf(15) == S(52.17745571428571)`. (I think).","created_at":"2015-03-27T19:35:27Z","updated_at":"2015-03-27T19:35:27Z","html_url":"https://github.com/sympy/sympy/pull/9206#discussion_r27324691","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/9206","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/27324691"},"html":{"href":"https://github.com/sympy/sympy/pull/9206#discussion_r27324691"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9206"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/9206","id":32118435,"html_url":"https://github.com/sympy/sympy/pull/9206","diff_url":"https://github.com/sympy/sympy/pull/9206.diff","patch_url":"https://github.com/sympy/sympy/pull/9206.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/9206","number":9206,"state":"open","locked":false,"title":"Updated units.py to include \"week\"","user":{"login":"pdworz","id":11642161,"avatar_url":"https://avatars.githubusercontent.com/u/11642161?v=3","gravatar_id":"","url":"https://api.github.com/users/pdworz","html_url":"https://github.com/pdworz","followers_url":"https://api.github.com/users/pdworz/followers","following_url":"https://api.github.com/users/pdworz/following{/other_user}","gists_url":"https://api.github.com/users/pdworz/gists{/gist_id}","starred_url":"https://api.github.com/users/pdworz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdworz/subscriptions","organizations_url":"https://api.github.com/users/pdworz/orgs","repos_url":"https://api.github.com/users/pdworz/repos","events_url":"https://api.github.com/users/pdworz/events{/privacy}","received_events_url":"https://api.github.com/users/pdworz/received_events","type":"User","site_admin":false},"body":"Note: This is my first time using git pull request. Please let me know if I need any changes","created_at":"2015-03-27T15:43:24Z","updated_at":"2015-03-27T19:35:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c7b23e3edbfff2a1adee1b71e5100b210cf1cd8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/9206/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/9206/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/9206/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/45438b6db183be03559b1b5ba027aaa8502c7d7d","head":{"label":"pdworz:pdworz-patch-units-week","ref":"pdworz-patch-units-week","sha":"45438b6db183be03559b1b5ba027aaa8502c7d7d","user":{"login":"pdworz","id":11642161,"avatar_url":"https://avatars.githubusercontent.com/u/11642161?v=3","gravatar_id":"","url":"https://api.github.com/users/pdworz","html_url":"https://github.com/pdworz","followers_url":"https://api.github.com/users/pdworz/followers","following_url":"https://api.github.com/users/pdworz/following{/other_user}","gists_url":"https://api.github.com/users/pdworz/gists{/gist_id}","starred_url":"https://api.github.com/users/pdworz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdworz/subscriptions","organizations_url":"https://api.github.com/users/pdworz/orgs","repos_url":"https://api.github.com/users/pdworz/repos","events_url":"https://api.github.com/users/pdworz/events{/privacy}","received_events_url":"https://api.github.com/users/pdworz/received_events","type":"User","site_admin":false},"repo":{"id":32989038,"name":"sympy","full_name":"pdworz/sympy","owner":{"login":"pdworz","id":11642161,"avatar_url":"https://avatars.githubusercontent.com/u/11642161?v=3","gravatar_id":"","url":"https://api.github.com/users/pdworz","html_url":"https://github.com/pdworz","followers_url":"https://api.github.com/users/pdworz/followers","following_url":"https://api.github.com/users/pdworz/following{/other_user}","gists_url":"https://api.github.com/users/pdworz/gists{/gist_id}","starred_url":"https://api.github.com/users/pdworz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdworz/subscriptions","organizations_url":"https://api.github.com/users/pdworz/orgs","repos_url":"https://api.github.com/users/pdworz/repos","events_url":"https://api.github.com/users/pdworz/events{/privacy}","received_events_url":"https://api.github.com/users/pdworz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdworz/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/pdworz/sympy","forks_url":"https://api.github.com/repos/pdworz/sympy/forks","keys_url":"https://api.github.com/repos/pdworz/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdworz/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdworz/sympy/teams","hooks_url":"https://api.github.com/repos/pdworz/sympy/hooks","issue_events_url":"https://api.github.com/repos/pdworz/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/pdworz/sympy/events","assignees_url":"https://api.github.com/repos/pdworz/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/pdworz/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/pdworz/sympy/tags","blobs_url":"https://api.github.com/repos/pdworz/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdworz/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdworz/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdworz/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdworz/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/pdworz/sympy/languages","stargazers_url":"https://api.github.com/repos/pdworz/sympy/stargazers","contributors_url":"https://api.github.com/repos/pdworz/sympy/contributors","subscribers_url":"https://api.github.com/repos/pdworz/sympy/subscribers","subscription_url":"https://api.github.com/repos/pdworz/sympy/subscription","commits_url":"https://api.github.com/repos/pdworz/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdworz/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdworz/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdworz/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdworz/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/pdworz/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdworz/sympy/merges","archive_url":"https://api.github.com/repos/pdworz/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdworz/sympy/downloads","issues_url":"https://api.github.com/repos/pdworz/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/pdworz/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/pdworz/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/pdworz/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdworz/sympy/labels{/name}","releases_url":"https://api.github.com/repos/pdworz/sympy/releases{/id}","created_at":"2015-03-27T13:58:22Z","updated_at":"2015-03-27T15:40:40Z","pushed_at":"2015-03-27T19:11:59Z","git_url":"git://github.com/pdworz/sympy.git","ssh_url":"git@github.com:pdworz/sympy.git","clone_url":"https://github.com/pdworz/sympy.git","svn_url":"https://github.com/pdworz/sympy","homepage":"http://sympy.org/","size":68227,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"0e9e62c2890e480845bed8c297dee554a8defc48","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-03-27T12:55:09Z","pushed_at":"2015-03-27T19:12:00Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":146384,"stargazers_count":2032,"watchers_count":2032,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":997,"mirror_url":null,"open_issues_count":1873,"forks":997,"open_issues":1873,"watchers":2032,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9206"},"html":{"href":"https://github.com/sympy/sympy/pull/9206"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/9206"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/9206/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9206/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9206/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/45438b6db183be03559b1b5ba027aaa8502c7d7d"}}}}