{"action":"created","issue":{"url":"https://api.github.com/repos/spesmilo/electrum-server/issues/107","labels_url":"https://api.github.com/repos/spesmilo/electrum-server/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/spesmilo/electrum-server/issues/107/comments","events_url":"https://api.github.com/repos/spesmilo/electrum-server/issues/107/events","html_url":"https://github.com/spesmilo/electrum-server/pull/107","id":95506368,"number":107,"title":"fix issue #106 timeout do_handshake to protect against misbehaving cl…","user":{"login":"shsmith","id":859149,"avatar_url":"https://avatars.githubusercontent.com/u/859149?v=3","gravatar_id":"","url":"https://api.github.com/users/shsmith","html_url":"https://github.com/shsmith","followers_url":"https://api.github.com/users/shsmith/followers","following_url":"https://api.github.com/users/shsmith/following{/other_user}","gists_url":"https://api.github.com/users/shsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shsmith/subscriptions","organizations_url":"https://api.github.com/users/shsmith/orgs","repos_url":"https://api.github.com/users/shsmith/repos","events_url":"https://api.github.com/users/shsmith/events{/privacy}","received_events_url":"https://api.github.com/users/shsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-16T19:20:37Z","updated_at":"2015-07-19T07:45:35Z","closed_at":"2015-07-17T04:29:40Z","pull_request":{"url":"https://api.github.com/repos/spesmilo/electrum-server/pulls/107","html_url":"https://github.com/spesmilo/electrum-server/pull/107","diff_url":"https://github.com/spesmilo/electrum-server/pull/107.diff","patch_url":"https://github.com/spesmilo/electrum-server/pull/107.patch"},"body":"…ient\r\n\r\nA misbehaving client can block the do_handshake process, resulting in\r\nthe poller hanging. This leads to new clients timing out and existing\r\nclients not being serviced.\r\nAdded 10 second timeout in do_handshake.\r\nAdded logging of any do_handshake operation that takes over 1 second."},"comment":{"url":"https://api.github.com/repos/spesmilo/electrum-server/issues/comments/122636125","html_url":"https://github.com/spesmilo/electrum-server/pull/107#issuecomment-122636125","issue_url":"https://api.github.com/repos/spesmilo/electrum-server/issues/107","id":122636125,"user":{"login":"ecdsa","id":2343238,"avatar_url":"https://avatars.githubusercontent.com/u/2343238?v=3","gravatar_id":"","url":"https://api.github.com/users/ecdsa","html_url":"https://github.com/ecdsa","followers_url":"https://api.github.com/users/ecdsa/followers","following_url":"https://api.github.com/users/ecdsa/following{/other_user}","gists_url":"https://api.github.com/users/ecdsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ecdsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecdsa/subscriptions","organizations_url":"https://api.github.com/users/ecdsa/orgs","repos_url":"https://api.github.com/users/ecdsa/repos","events_url":"https://api.github.com/users/ecdsa/events{/privacy}","received_events_url":"https://api.github.com/users/ecdsa/received_events","type":"User","site_admin":false},"created_at":"2015-07-19T07:45:35Z","updated_at":"2015-07-19T07:45:35Z","body":"hmm, I think you are wrong; this patch seems to be doing the opposite of what it claims.\r\nthe socket was initially set as non blocking, and adding a timeout makes it blocking."}}