{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/40946542","id":40946542,"diff_hunk":"@@ -70,7 +70,8 @@ class MojoAssetBundle extends AssetBundle {\n     return _imageCache.putIfAbsent(key, () {\n       Completer<sky.Image> completer = new Completer<sky.Image>();\n       load(key).then((assetData) {\n-        new sky.ImageDecoder(assetData.handle.h, completer.complete);\n+        new sky.ImageDecoder(completer.complete)\n+               ..initWithConsumer(assetData.handle.h);","path":"sky/packages/sky/lib/src/services/asset_bundle.dart","position":6,"original_position":6,"commit_id":"3943fa1da48edf7f778dc80c9a0ce74e226ad512","original_commit_id":"3943fa1da48edf7f778dc80c9a0ce74e226ad512","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"This would become:\r\n\r\nnew sky.ImageDecoder.consume(assetData.handle.h)","created_at":"2015-10-01T18:10:22Z","updated_at":"2015-10-01T18:10:22Z","html_url":"https://github.com/flutter/engine/pull/1434#discussion_r40946542","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/1434","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/40946542"},"html":{"href":"https://github.com/flutter/engine/pull/1434#discussion_r40946542"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/1434"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/1434","id":46556578,"html_url":"https://github.com/flutter/engine/pull/1434","diff_url":"https://github.com/flutter/engine/pull/1434.diff","patch_url":"https://github.com/flutter/engine/pull/1434.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/1434","number":1434,"state":"open","locked":false,"title":"Support for decoding images in lists","user":{"login":"collinjackson","id":394889,"avatar_url":"https://avatars.githubusercontent.com/u/394889?v=3","gravatar_id":"","url":"https://api.github.com/users/collinjackson","html_url":"https://github.com/collinjackson","followers_url":"https://api.github.com/users/collinjackson/followers","following_url":"https://api.github.com/users/collinjackson/following{/other_user}","gists_url":"https://api.github.com/users/collinjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/collinjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collinjackson/subscriptions","organizations_url":"https://api.github.com/users/collinjackson/orgs","repos_url":"https://api.github.com/users/collinjackson/repos","events_url":"https://api.github.com/users/collinjackson/events{/privacy}","received_events_url":"https://api.github.com/users/collinjackson/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-10-01T18:05:32Z","updated_at":"2015-10-01T18:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"093161dce0058208b065efbb7b4964984cfeb70c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/1434/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/1434/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/1434/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/3943fa1da48edf7f778dc80c9a0ce74e226ad512","head":{"label":"collinjackson:decode_lists","ref":"decode_lists","sha":"3943fa1da48edf7f778dc80c9a0ce74e226ad512","user":{"login":"collinjackson","id":394889,"avatar_url":"https://avatars.githubusercontent.com/u/394889?v=3","gravatar_id":"","url":"https://api.github.com/users/collinjackson","html_url":"https://github.com/collinjackson","followers_url":"https://api.github.com/users/collinjackson/followers","following_url":"https://api.github.com/users/collinjackson/following{/other_user}","gists_url":"https://api.github.com/users/collinjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/collinjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collinjackson/subscriptions","organizations_url":"https://api.github.com/users/collinjackson/orgs","repos_url":"https://api.github.com/users/collinjackson/repos","events_url":"https://api.github.com/users/collinjackson/events{/privacy}","received_events_url":"https://api.github.com/users/collinjackson/received_events","type":"User","site_admin":false},"repo":{"id":39216207,"name":"sky_engine","full_name":"collinjackson/sky_engine","owner":{"login":"collinjackson","id":394889,"avatar_url":"https://avatars.githubusercontent.com/u/394889?v=3","gravatar_id":"","url":"https://api.github.com/users/collinjackson","html_url":"https://github.com/collinjackson","followers_url":"https://api.github.com/users/collinjackson/followers","following_url":"https://api.github.com/users/collinjackson/following{/other_user}","gists_url":"https://api.github.com/users/collinjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/collinjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collinjackson/subscriptions","organizations_url":"https://api.github.com/users/collinjackson/orgs","repos_url":"https://api.github.com/users/collinjackson/repos","events_url":"https://api.github.com/users/collinjackson/events{/privacy}","received_events_url":"https://api.github.com/users/collinjackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/collinjackson/sky_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/collinjackson/sky_engine","forks_url":"https://api.github.com/repos/collinjackson/sky_engine/forks","keys_url":"https://api.github.com/repos/collinjackson/sky_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collinjackson/sky_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collinjackson/sky_engine/teams","hooks_url":"https://api.github.com/repos/collinjackson/sky_engine/hooks","issue_events_url":"https://api.github.com/repos/collinjackson/sky_engine/issues/events{/number}","events_url":"https://api.github.com/repos/collinjackson/sky_engine/events","assignees_url":"https://api.github.com/repos/collinjackson/sky_engine/assignees{/user}","branches_url":"https://api.github.com/repos/collinjackson/sky_engine/branches{/branch}","tags_url":"https://api.github.com/repos/collinjackson/sky_engine/tags","blobs_url":"https://api.github.com/repos/collinjackson/sky_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collinjackson/sky_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collinjackson/sky_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/collinjackson/sky_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collinjackson/sky_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/collinjackson/sky_engine/languages","stargazers_url":"https://api.github.com/repos/collinjackson/sky_engine/stargazers","contributors_url":"https://api.github.com/repos/collinjackson/sky_engine/contributors","subscribers_url":"https://api.github.com/repos/collinjackson/sky_engine/subscribers","subscription_url":"https://api.github.com/repos/collinjackson/sky_engine/subscription","commits_url":"https://api.github.com/repos/collinjackson/sky_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/collinjackson/sky_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/collinjackson/sky_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/collinjackson/sky_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/collinjackson/sky_engine/contents/{+path}","compare_url":"https://api.github.com/repos/collinjackson/sky_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collinjackson/sky_engine/merges","archive_url":"https://api.github.com/repos/collinjackson/sky_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collinjackson/sky_engine/downloads","issues_url":"https://api.github.com/repos/collinjackson/sky_engine/issues{/number}","pulls_url":"https://api.github.com/repos/collinjackson/sky_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/collinjackson/sky_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/collinjackson/sky_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collinjackson/sky_engine/labels{/name}","releases_url":"https://api.github.com/repos/collinjackson/sky_engine/releases{/id}","created_at":"2015-07-16T19:28:24Z","updated_at":"2015-07-16T19:28:44Z","pushed_at":"2015-10-01T18:06:25Z","git_url":"git://github.com/collinjackson/sky_engine.git","ssh_url":"git@github.com:collinjackson/sky_engine.git","clone_url":"https://github.com/collinjackson/sky_engine.git","svn_url":"https://github.com/collinjackson/sky_engine","homepage":null,"size":74884,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"ca95d22d91c3835293e7a9855d7e69e75c14ff62","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","created_at":"2015-07-16T17:39:56Z","updated_at":"2015-10-01T06:46:53Z","pushed_at":"2015-10-01T18:06:26Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":88137,"stargazers_count":249,"watchers_count":249,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":239,"forks":67,"open_issues":239,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/1434"},"html":{"href":"https://github.com/flutter/engine/pull/1434"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/1434"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/1434/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/1434/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/1434/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/3943fa1da48edf7f778dc80c9a0ce74e226ad512"}}}}