{"action":"closed","number":4198,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4198","id":28777301,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4198","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4198.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4198.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4198","number":4198,"state":"closed","locked":false,"title":"Turn the hack/e2e.go commands into standalone scripts.","user":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=3","gravatar_id":"","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"body":"This gets rid of `bashWrap()` and of running bash -s passing it a script on stdin. Also get rid of most of the `runBash*()` helpers.\r\n\r\nIn particular, `go run hack/e2e.go -build` will now work when it needs to ask whether it is OK to download a large docker image, it used to fail since stdin was not available for the bash script using the `read`\r\ncommand.\r\n\r\nTested by running a full `hack/e2e-test.sh` run including the build stage without the docker image loaded, which used to fail before this change.\r\n\r\nThis should also make it easier to have Jenkins run scripts directly instead of through `hack/e2e.go`.\r\n\r\n@zmerlynn ","created_at":"2015-02-06T01:09:54Z","updated_at":"2015-02-06T20:24:48Z","closed_at":"2015-02-06T20:24:48Z","merged_at":"2015-02-06T20:24:48Z","merge_commit_sha":"424adad42654de93713a6ac28850096a55c16aed","assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4198/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4198/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4198/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/0c7dce77dd21c5a7bfafcda03efc7bd2578e1029","head":{"label":"filbranden:e2e_standalone_scripts","ref":"e2e_standalone_scripts","sha":"0c7dce77dd21c5a7bfafcda03efc7bd2578e1029","user":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=3","gravatar_id":"","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"repo":{"id":22449002,"name":"kubernetes","full_name":"filbranden/kubernetes","owner":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=3","gravatar_id":"","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filbranden/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/filbranden/kubernetes","forks_url":"https://api.github.com/repos/filbranden/kubernetes/forks","keys_url":"https://api.github.com/repos/filbranden/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filbranden/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filbranden/kubernetes/teams","hooks_url":"https://api.github.com/repos/filbranden/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/filbranden/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/filbranden/kubernetes/events","assignees_url":"https://api.github.com/repos/filbranden/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/filbranden/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/filbranden/kubernetes/tags","blobs_url":"https://api.github.com/repos/filbranden/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filbranden/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filbranden/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/filbranden/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filbranden/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/filbranden/kubernetes/languages","stargazers_url":"https://api.github.com/repos/filbranden/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/filbranden/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/filbranden/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/filbranden/kubernetes/subscription","commits_url":"https://api.github.com/repos/filbranden/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/filbranden/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/filbranden/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/filbranden/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/filbranden/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/filbranden/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filbranden/kubernetes/merges","archive_url":"https://api.github.com/repos/filbranden/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filbranden/kubernetes/downloads","issues_url":"https://api.github.com/repos/filbranden/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/filbranden/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/filbranden/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/filbranden/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filbranden/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/filbranden/kubernetes/releases{/id}","created_at":"2014-07-30T23:41:25Z","updated_at":"2015-02-04T22:40:23Z","pushed_at":"2015-02-06T19:18:30Z","git_url":"git://github.com/filbranden/kubernetes.git","ssh_url":"git@github.com:filbranden/kubernetes.git","clone_url":"https://github.com/filbranden/kubernetes.git","svn_url":"https://github.com/filbranden/kubernetes","homepage":null,"size":27933,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"94d852e8a64bf45e1895b8a04110453530a62ca3","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-02-06T20:20:18Z","pushed_at":"2015-02-06T20:24:48Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":71242,"stargazers_count":6106,"watchers_count":6106,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1043,"mirror_url":null,"open_issues_count":660,"forks":1043,"open_issues":660,"watchers":6106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4198"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4198"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4198"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4198/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4198/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4198/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/0c7dce77dd21c5a7bfafcda03efc7bd2578e1029"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":1,"additions":264,"deletions":61,"changed_files":9}}