{"action":"created","comment":{"url":"https://api.github.com/repos/cyclus/cyclus/pulls/comments/22472933","id":22472933,"diff_hunk":"@@ -56,6 +56,15 @@ TEST(RecorderTest, Manager_GetSetDumpFreq) {\n   EXPECT_EQ(m.dump_count(), cyclus::kDefaultDumpCount);\n }\n \n+TEST(RecorderTest, InjectSimId) {","path":"tests/recorder_tests.cc","position":4,"original_position":4,"commit_id":"fd5ffa0cd0b0472bdc41a769cdf287d945874c90","original_commit_id":"4b7f22da7c1406ae5db2ac27c385e3aff6677b71","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"body":"This test needs to check whether a recorded datum actually has a sim id injected or not.  Such a test would have caught the missing `set_dump_count` call in the `inject_sim_id(yourval)` function.","created_at":"2015-01-05T16:58:23Z","updated_at":"2015-01-05T16:58:23Z","html_url":"https://github.com/cyclus/cyclus/pull/1062#discussion_r22472933","pull_request_url":"https://api.github.com/repos/cyclus/cyclus/pulls/1062","_links":{"self":{"href":"https://api.github.com/repos/cyclus/cyclus/pulls/comments/22472933"},"html":{"href":"https://github.com/cyclus/cyclus/pull/1062#discussion_r22472933"},"pull_request":{"href":"https://api.github.com/repos/cyclus/cyclus/pulls/1062"}}},"pull_request":{"url":"https://api.github.com/repos/cyclus/cyclus/pulls/1062","id":26633136,"html_url":"https://github.com/cyclus/cyclus/pull/1062","diff_url":"https://github.com/cyclus/cyclus/pull/1062.diff","patch_url":"https://github.com/cyclus/cyclus/pull/1062.patch","issue_url":"https://api.github.com/repos/cyclus/cyclus/issues/1062","number":1062,"state":"open","locked":false,"title":"Raw Recorder","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"body":"This adds a subclass of recorder that does not inject the SimId and gives you raw table writing. This is needed for the more general case of writing to the database, and in particular for cymetric or any other analysis tool. In such situations SimIds are not necessarily semantically meaningful. For example, aggregation over many simulations will make any SimId field meaningless. Since folks may want to store any kind of data a raw recorder is needed. A subclass API turned out to be cleaner than adding new member functions.\r\n\r\nThis is dependent on #1061, which should be merged in first.","created_at":"2014-12-29T06:05:53Z","updated_at":"2015-01-05T16:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d5480036047b4392332571fda18a53831e5d563","assignee":null,"milestone":{"url":"https://api.github.com/repos/cyclus/cyclus/milestones/31","labels_url":"https://api.github.com/repos/cyclus/cyclus/milestones/31/labels","id":879142,"number":31,"title":"v1.3","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":6,"state":"open","created_at":"2014-11-24T23:27:16Z","updated_at":"2014-12-31T16:19:15Z","due_on":"2015-03-01T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cyclus/cyclus/pulls/1062/commits","review_comments_url":"https://api.github.com/repos/cyclus/cyclus/pulls/1062/comments","review_comment_url":"https://api.github.com/repos/cyclus/cyclus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cyclus/cyclus/issues/1062/comments","statuses_url":"https://api.github.com/repos/cyclus/cyclus/statuses/fd5ffa0cd0b0472bdc41a769cdf287d945874c90","head":{"label":"scopatz:rr","ref":"rr","sha":"fd5ffa0cd0b0472bdc41a769cdf287d945874c90","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"repo":{"id":3809841,"name":"cyclus","full_name":"scopatz/cyclus","owner":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scopatz/cyclus","description":"The core of the Cyclus nuclear fuel cycle code from the University of Wisconsin, Madison","fork":true,"url":"https://api.github.com/repos/scopatz/cyclus","forks_url":"https://api.github.com/repos/scopatz/cyclus/forks","keys_url":"https://api.github.com/repos/scopatz/cyclus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scopatz/cyclus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scopatz/cyclus/teams","hooks_url":"https://api.github.com/repos/scopatz/cyclus/hooks","issue_events_url":"https://api.github.com/repos/scopatz/cyclus/issues/events{/number}","events_url":"https://api.github.com/repos/scopatz/cyclus/events","assignees_url":"https://api.github.com/repos/scopatz/cyclus/assignees{/user}","branches_url":"https://api.github.com/repos/scopatz/cyclus/branches{/branch}","tags_url":"https://api.github.com/repos/scopatz/cyclus/tags","blobs_url":"https://api.github.com/repos/scopatz/cyclus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scopatz/cyclus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scopatz/cyclus/git/refs{/sha}","trees_url":"https://api.github.com/repos/scopatz/cyclus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scopatz/cyclus/statuses/{sha}","languages_url":"https://api.github.com/repos/scopatz/cyclus/languages","stargazers_url":"https://api.github.com/repos/scopatz/cyclus/stargazers","contributors_url":"https://api.github.com/repos/scopatz/cyclus/contributors","subscribers_url":"https://api.github.com/repos/scopatz/cyclus/subscribers","subscription_url":"https://api.github.com/repos/scopatz/cyclus/subscription","commits_url":"https://api.github.com/repos/scopatz/cyclus/commits{/sha}","git_commits_url":"https://api.github.com/repos/scopatz/cyclus/git/commits{/sha}","comments_url":"https://api.github.com/repos/scopatz/cyclus/comments{/number}","issue_comment_url":"https://api.github.com/repos/scopatz/cyclus/issues/comments/{number}","contents_url":"https://api.github.com/repos/scopatz/cyclus/contents/{+path}","compare_url":"https://api.github.com/repos/scopatz/cyclus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scopatz/cyclus/merges","archive_url":"https://api.github.com/repos/scopatz/cyclus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scopatz/cyclus/downloads","issues_url":"https://api.github.com/repos/scopatz/cyclus/issues{/number}","pulls_url":"https://api.github.com/repos/scopatz/cyclus/pulls{/number}","milestones_url":"https://api.github.com/repos/scopatz/cyclus/milestones{/number}","notifications_url":"https://api.github.com/repos/scopatz/cyclus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scopatz/cyclus/labels{/name}","releases_url":"https://api.github.com/repos/scopatz/cyclus/releases{/id}","created_at":"2012-03-23T15:44:42Z","updated_at":"2014-12-02T23:22:25Z","pushed_at":"2015-01-05T16:55:56Z","git_url":"git://github.com/scopatz/cyclus.git","ssh_url":"git@github.com:scopatz/cyclus.git","clone_url":"https://github.com/scopatz/cyclus.git","svn_url":"https://github.com/scopatz/cyclus","homepage":"cyclus.github.com","size":15459,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cyclus:develop","ref":"develop","sha":"d8157bcf9bfb06e2b0d1d7f3017ba2ceea142e60","user":{"login":"cyclus","id":1355686,"avatar_url":"https://avatars.githubusercontent.com/u/1355686?v=3","gravatar_id":"","url":"https://api.github.com/users/cyclus","html_url":"https://github.com/cyclus","followers_url":"https://api.github.com/users/cyclus/followers","following_url":"https://api.github.com/users/cyclus/following{/other_user}","gists_url":"https://api.github.com/users/cyclus/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclus/subscriptions","organizations_url":"https://api.github.com/users/cyclus/orgs","repos_url":"https://api.github.com/users/cyclus/repos","events_url":"https://api.github.com/users/cyclus/events{/privacy}","received_events_url":"https://api.github.com/users/cyclus/received_events","type":"Organization","site_admin":false},"repo":{"id":3308958,"name":"cyclus","full_name":"cyclus/cyclus","owner":{"login":"cyclus","id":1355686,"avatar_url":"https://avatars.githubusercontent.com/u/1355686?v=3","gravatar_id":"","url":"https://api.github.com/users/cyclus","html_url":"https://github.com/cyclus","followers_url":"https://api.github.com/users/cyclus/followers","following_url":"https://api.github.com/users/cyclus/following{/other_user}","gists_url":"https://api.github.com/users/cyclus/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclus/subscriptions","organizations_url":"https://api.github.com/users/cyclus/orgs","repos_url":"https://api.github.com/users/cyclus/repos","events_url":"https://api.github.com/users/cyclus/events{/privacy}","received_events_url":"https://api.github.com/users/cyclus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyclus/cyclus","description":"The Cyclus Nuclear Fuel Cycle Simulator","fork":false,"url":"https://api.github.com/repos/cyclus/cyclus","forks_url":"https://api.github.com/repos/cyclus/cyclus/forks","keys_url":"https://api.github.com/repos/cyclus/cyclus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyclus/cyclus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyclus/cyclus/teams","hooks_url":"https://api.github.com/repos/cyclus/cyclus/hooks","issue_events_url":"https://api.github.com/repos/cyclus/cyclus/issues/events{/number}","events_url":"https://api.github.com/repos/cyclus/cyclus/events","assignees_url":"https://api.github.com/repos/cyclus/cyclus/assignees{/user}","branches_url":"https://api.github.com/repos/cyclus/cyclus/branches{/branch}","tags_url":"https://api.github.com/repos/cyclus/cyclus/tags","blobs_url":"https://api.github.com/repos/cyclus/cyclus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyclus/cyclus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyclus/cyclus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyclus/cyclus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyclus/cyclus/statuses/{sha}","languages_url":"https://api.github.com/repos/cyclus/cyclus/languages","stargazers_url":"https://api.github.com/repos/cyclus/cyclus/stargazers","contributors_url":"https://api.github.com/repos/cyclus/cyclus/contributors","subscribers_url":"https://api.github.com/repos/cyclus/cyclus/subscribers","subscription_url":"https://api.github.com/repos/cyclus/cyclus/subscription","commits_url":"https://api.github.com/repos/cyclus/cyclus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyclus/cyclus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyclus/cyclus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyclus/cyclus/issues/comments/{number}","contents_url":"https://api.github.com/repos/cyclus/cyclus/contents/{+path}","compare_url":"https://api.github.com/repos/cyclus/cyclus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyclus/cyclus/merges","archive_url":"https://api.github.com/repos/cyclus/cyclus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyclus/cyclus/downloads","issues_url":"https://api.github.com/repos/cyclus/cyclus/issues{/number}","pulls_url":"https://api.github.com/repos/cyclus/cyclus/pulls{/number}","milestones_url":"https://api.github.com/repos/cyclus/cyclus/milestones{/number}","notifications_url":"https://api.github.com/repos/cyclus/cyclus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyclus/cyclus/labels{/name}","releases_url":"https://api.github.com/repos/cyclus/cyclus/releases{/id}","created_at":"2012-01-30T21:16:54Z","updated_at":"2014-12-31T16:19:15Z","pushed_at":"2015-01-05T09:20:05Z","git_url":"git://github.com/cyclus/cyclus.git","ssh_url":"git@github.com:cyclus/cyclus.git","clone_url":"https://github.com/cyclus/cyclus.git","svn_url":"https://github.com/cyclus/cyclus","homepage":"http://fuelcycle.org/","size":24090,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":44,"forks":28,"open_issues":44,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cyclus/cyclus/pulls/1062"},"html":{"href":"https://github.com/cyclus/cyclus/pull/1062"},"issue":{"href":"https://api.github.com/repos/cyclus/cyclus/issues/1062"},"comments":{"href":"https://api.github.com/repos/cyclus/cyclus/issues/1062/comments"},"review_comments":{"href":"https://api.github.com/repos/cyclus/cyclus/pulls/1062/comments"},"review_comment":{"href":"https://api.github.com/repos/cyclus/cyclus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cyclus/cyclus/pulls/1062/commits"},"statuses":{"href":"https://api.github.com/repos/cyclus/cyclus/statuses/fd5ffa0cd0b0472bdc41a769cdf287d945874c90"}}}}