{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew/issues/38479","labels_url":"https://api.github.com/repos/Homebrew/homebrew/issues/38479/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/38479/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/38479/events","html_url":"https://github.com/Homebrew/homebrew/pull/38479","id":67345808,"number":38479,"title":"sandbox test and postinstall","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=3","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-04-09T11:57:19Z","updated_at":"2015-04-13T09:49:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/38479","html_url":"https://github.com/Homebrew/homebrew/pull/38479","diff_url":"https://github.com/Homebrew/homebrew/pull/38479.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/38479.patch"},"body":"Clearly, my first implemented sandbox has some poor API design.(thankfully it's private API for now). `brew test` is a little more complex than I previously thought. \"test should probably only write to testpath\" is incorrect. For general purpose, it need to be allowed to write temp folders. And some formulae would download resource in the test, so I need to allow them to write cache. Finally `Formula.system` requires to write into log folder.\r\n\r\nAsking for comments especially on **API design**.\r\n\r\ncc @Homebrew/owners "},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/92295365","html_url":"https://github.com/Homebrew/homebrew/pull/38479#issuecomment-92295365","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/38479","id":92295365,"user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=3","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T09:49:21Z","updated_at":"2015-04-13T09:49:21Z","body":"> So will the exception get bubbled up as expected?\r\n\r\nThe exception raised by `safe_system` should be ignored. Because there would be a more specific exception inside the pipe and we will raise that one."}}