{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/26217129","id":26217129,"diff_hunk":"@@ -157,6 +157,12 @@ function palloc(that, length) {\n   var buf = sliceOnto(allocPool, that, start, end);\n   poolOffset = end;\n \n+  // Ensure aligned slices\n+  if (poolOffset & 0x7) {\n+    poolOffset |= 0x7;","path":"lib/buffer.js","position":6,"original_position":6,"commit_id":"c7111d5e874a5b5b9cdc57d74b748c68123d77a9","original_commit_id":"c7111d5e874a5b5b9cdc57d74b748c68123d77a9","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"A less convoluted way of writing that is `poolOffset = (poolOffset & ~7) + 8` :-)","created_at":"2015-03-11T14:40:11Z","updated_at":"2015-03-11T14:40:11Z","html_url":"https://github.com/iojs/io.js/pull/1126#discussion_r26217129","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/1126","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/26217129"},"html":{"href":"https://github.com/iojs/io.js/pull/1126#discussion_r26217129"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/1126","id":30947036,"html_url":"https://github.com/iojs/io.js/pull/1126","diff_url":"https://github.com/iojs/io.js/pull/1126.diff","patch_url":"https://github.com/iojs/io.js/pull/1126.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1126","number":1126,"state":"open","locked":false,"title":"buffer: align chunks on 8-byte boundary","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"When slicing global pool - ensure that the underlying buffer's data ptr\r\nis 8-byte alignment to do not ruin expectations of 3rd party C++ addons.\r\n\r\nNOTE: 0.10 node.js always returned aligned pointers and io.js should do\r\nthis to for compatibility.","created_at":"2015-03-11T14:20:36Z","updated_at":"2015-03-11T14:40:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"565949b7349245a2870fc71a5acdf19bf8ab4897","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1126/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/c7111d5e874a5b5b9cdc57d74b748c68123d77a9","head":{"label":"indutny:fix/buffer-slice-ptr-alignment","ref":"fix/buffer-slice-ptr-alignment","sha":"c7111d5e874a5b5b9cdc57d74b748c68123d77a9","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"repo":{"id":27231488,"name":"io.js","full_name":"indutny/io.js","owner":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indutny/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/indutny/io.js","forks_url":"https://api.github.com/repos/indutny/io.js/forks","keys_url":"https://api.github.com/repos/indutny/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indutny/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indutny/io.js/teams","hooks_url":"https://api.github.com/repos/indutny/io.js/hooks","issue_events_url":"https://api.github.com/repos/indutny/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/indutny/io.js/events","assignees_url":"https://api.github.com/repos/indutny/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/indutny/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/indutny/io.js/tags","blobs_url":"https://api.github.com/repos/indutny/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indutny/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indutny/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/indutny/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indutny/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/indutny/io.js/languages","stargazers_url":"https://api.github.com/repos/indutny/io.js/stargazers","contributors_url":"https://api.github.com/repos/indutny/io.js/contributors","subscribers_url":"https://api.github.com/repos/indutny/io.js/subscribers","subscription_url":"https://api.github.com/repos/indutny/io.js/subscription","commits_url":"https://api.github.com/repos/indutny/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/indutny/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/indutny/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/indutny/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/indutny/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/indutny/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indutny/io.js/merges","archive_url":"https://api.github.com/repos/indutny/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indutny/io.js/downloads","issues_url":"https://api.github.com/repos/indutny/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/indutny/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/indutny/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/indutny/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indutny/io.js/labels{/name}","releases_url":"https://api.github.com/repos/indutny/io.js/releases{/id}","created_at":"2014-11-27T15:38:33Z","updated_at":"2015-02-18T15:41:43Z","pushed_at":"2015-03-11T14:28:32Z","git_url":"git://github.com/indutny/io.js.git","ssh_url":"git@github.com:indutny/io.js.git","clone_url":"https://github.com/indutny/io.js.git","svn_url":"https://github.com/indutny/io.js","homepage":null,"size":123868,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v0.12"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"d33a647b4bdcbf596aaad0589090dcee0fbf0297","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-03-11T14:24:42Z","pushed_at":"2015-03-11T12:26:52Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":156272,"stargazers_count":10986,"watchers_count":10986,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":710,"mirror_url":null,"open_issues_count":187,"forks":710,"open_issues":187,"watchers":10986,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1126"},"html":{"href":"https://github.com/iojs/io.js/pull/1126"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/1126"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/c7111d5e874a5b5b9cdc57d74b748c68123d77a9"}}}}