{"action":"created","issue":{"url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/148","labels_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/148/comments","events_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/148/events","html_url":"https://github.com/JasonLautzenheiser/trizbort/issues/148","id":105709656,"number":148,"title":"Resize and connection ports on octagonal shape are still square.","user":{"login":"JasonLautzenheiser","id":1239981,"avatar_url":"https://avatars.githubusercontent.com/u/1239981?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLautzenheiser","html_url":"https://github.com/JasonLautzenheiser","followers_url":"https://api.github.com/users/JasonLautzenheiser/followers","following_url":"https://api.github.com/users/JasonLautzenheiser/following{/other_user}","gists_url":"https://api.github.com/users/JasonLautzenheiser/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLautzenheiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLautzenheiser/subscriptions","organizations_url":"https://api.github.com/users/JasonLautzenheiser/orgs","repos_url":"https://api.github.com/users/JasonLautzenheiser/repos","events_url":"https://api.github.com/users/JasonLautzenheiser/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLautzenheiser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-10T00:33:13Z","updated_at":"2015-09-10T01:26:27Z","closed_at":null,"body":"![image](https://cloud.githubusercontent.com/assets/1239981/9777400/f84f0b60-5731-11e5-9fa8-e1f86745f5a3.png)\r\n"},"comment":{"url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/comments/139089118","html_url":"https://github.com/JasonLautzenheiser/trizbort/issues/148#issuecomment-139089118","issue_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/148","id":139089118,"user":{"login":"andrewschultz","id":6201356,"avatar_url":"https://avatars.githubusercontent.com/u/6201356?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewschultz","html_url":"https://github.com/andrewschultz","followers_url":"https://api.github.com/users/andrewschultz/followers","following_url":"https://api.github.com/users/andrewschultz/following{/other_user}","gists_url":"https://api.github.com/users/andrewschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschultz/subscriptions","organizations_url":"https://api.github.com/users/andrewschultz/orgs","repos_url":"https://api.github.com/users/andrewschultz/repos","events_url":"https://api.github.com/users/andrewschultz/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschultz/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T01:26:27Z","updated_at":"2015-09-10T01:26:27Z","body":"Sounds good, though...looking through the code, I think we will want to re-define public Vector GetCorner in Rect.cs, since the corners will be different for ellipses, octagons and rounded rectangles. The second argument looks like it would be better as a RoomShape.\r\n\r\nEspecially since the Rounded Rectangles could use tweaking, too. I think the ports should move in (rounding * .3) in the X and Y directions.\r\n\r\nGetCorner only uses the 2nd argument once in Trizbort's code, from GetPortPosition itself. So I think this is feasible to redefine boolean isEllipse as roomShape thisRoomShape.\r\n\r\nI would assume that we can also set the default value to SquareCorners, but I don't know if there are any adverse effects. I am still a C# rookie.\r\n\r\n(Also, I added octagonal to the room shapes tab in the room properties dialog. I forgot that.)"}}