{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments/31704491","id":31704491,"diff_hunk":"@@ -34,61 +19,42 @@\n                 </p>\n \n             {% else %}\n-                {{ form_start( form ) }}\n-\n-                <div class=\"row\">\n-                    {{ form_errors( form ) }}\n-                </div>\n+                {%  form_theme form 'eZDemoBundle:forms:feedback_form.html.twig' %}\n \n-                <div class=\"control-group {% if form.firstName.vars.errors is not empty %}error{% endif %}\">\n-                    {{ form_label( form.firstName, 'First Name'|trans,  { 'attr': {'class': 'control-label'}} ) }}\n-                    <div class=\"controls\">\n-                        {{ form_widget( form.firstName, { 'attr': {'class': 'col-md-4'}} ) }}\n-                        {{ form_errors( form.firstName ) }}\n-                    </div>\n-                </div>\n-\n-                <div class=\"control-group {% if form.lastName.vars.errors is not empty %}error{% endif %}\">\n-                    {{ form_label( form.lastName, 'Last Name'|trans,  { 'attr': {'class': 'control-label'}} ) }}\n-                    <div class=\"controls\">\n-                        {{ form_widget( form.lastName, { 'attr': {'class': 'col-md-4'}} ) }}\n-                        {{ form_errors( form.lastName ) }}\n-                    </div>\n-                </div>\n-\n-                <div class=\"control-group {% if form.email.vars.errors is not empty %}error{% endif %}\">\n-                    {{ form_label( form.email, 'Email'|trans,  { 'attr': {'class': 'control-label'}} ) }}\n-                    <div class=\"controls\">\n-                        {{ form_widget( form.email, { 'attr': {'class': 'col-md-6'}} ) }}\n-                        {{ form_errors( form.email ) }}\n-                    </div>\n-                </div>\n-\n-                <div class=\"control-group {% if form.subject.vars.errors is not empty %}error{% endif %}\">\n-                    {{ form_label( form.subject, 'Subject'|trans,  { 'attr': {'class': 'control-label'}} ) }}\n-                    <div class=\"controls\">\n-                        {{ form_widget( form.subject, { 'attr': {'class': 'col-md-6'}} ) }}\n-                        {{ form_errors( form.subject ) }}\n-                    </div>\n-                </div>\n-\n-                <div class=\"control-group {% if form.country.vars.errors is not empty %}error{% endif %}\">\n-                    {{ form_label( form.country, 'Country'|trans,  { 'attr': {'class': 'control-label'}} ) }}\n-                    <div class=\"controls\">\n-                        {{ form_widget( form.country ) }}\n-                        {{ form_errors( form.country ) }}\n-                    </div>\n-                </div>\n-\n-                <div class=\"control-group {% if form.message.vars.errors is not empty %}error{% endif %}\">\n-                    {{ form_label( form.message, 'Message'|trans,  { 'attr': {'class': 'control-label'}} ) }}\n-                    <div class=\"controls\">\n-                        {{ form_widget( form.message, { 'attr': {'class': 'col-md-8', 'rows': '10'} } ) }}\n-                        {{ form_errors( form.message ) }}\n-                    </div>\n-                </div>\n+                {{ form_start( form ) }}\n \n-                {{ form_widget( form.save, { 'label': \"Send form\"|trans, 'attr': { 'class': 'btn btn-warning pull-right' } } ) }}\n+                {{ form_row( form.firstName, {\n+                    'label': 'First Name',\n+                    'label_attr': { 'class': 'control-label' },\n+                    'attr': { 'class': 'col-md-4' }\n+                } ) }}\n+\n+                {{ form_row( form.lastName, {\n+                    'label': 'Last Name',\n+                    'attr': { 'class': 'col-md-4' }\n+                } ) }}\n+\n+                {{ form_row( form.email, {\n+                    'label': 'Email',\n+                    'attr': { 'class': 'col-md-6' }\n+                } ) }}\n+\n+                {{ form_row( form.subject, {\n+                    'label': 'Subject',\n+                    'attr': { 'class': 'col-md-6' }\n+                } ) }}\n+\n+                {{ form_row( form.country, { 'label': 'Country' } ) }}\n+\n+                {{ form_row( form.message, {\n+                    'label': 'Message',\n+                    'attr': { 'class': 'col-md-8', 'rows': 10 }\n+                } ) }}\n+\n+                {{ form_row( form.save, {\n+                    'label': \"Send form\",\n+                    'attr': { 'class': 'btn btn-warning pull-right' }\n+                } ) }}\n \n                 {{ form_end( form ) }}","path":"Resources/views/full/feedback_form.html.twig","position":114,"original_position":116,"commit_id":"162b2cb4e8a93f567a825e83e7d86177867d6d12","original_commit_id":"e1e88cd44630fbc48962da0a6c7c15a8a3321caa","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?v=3","gravatar_id":"","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"body":"understood, i see your point. Anyway the html I get for csrf_token is ```<input type=\"hidden\" id=\"ezdemo_feedback_ezxform_token\" name=\"ezdemo_feedback[ezxform_token]\" value=\"Qfis-4hg1UIDPGGjiidOu2X92IBxs272tq95qOmLZ5I\" />``` it seems my form_row is not applied there. Trying to know why.  ","created_at":"2015-06-04T09:13:40Z","updated_at":"2015-06-04T09:13:40Z","html_url":"https://github.com/ezsystems/DemoBundle/pull/158#discussion_r31704491","pull_request_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments/31704491"},"html":{"href":"https://github.com/ezsystems/DemoBundle/pull/158#discussion_r31704491"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158","id":36660689,"html_url":"https://github.com/ezsystems/DemoBundle/pull/158","diff_url":"https://github.com/ezsystems/DemoBundle/pull/158.diff","patch_url":"https://github.com/ezsystems/DemoBundle/pull/158.patch","issue_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/158","number":158,"state":"open","locked":false,"title":"Use a dedicated template to theming feedback forms","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?v=3","gravatar_id":"","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"body":"Implements: https://jira.ez.no/browse/EZP-24435\r\n\r\nThe goal of this PR is to have a dedicate template for theming feedback forms. Thanks to Symfony form theming capabilities, we can add a dedicate template for every form. \r\n\r\nFurther more, as all the fields in the forms are showed in the same way, we can avoid the html we actually have inside the form and let the theming template do its jobs. \r\n\r\nThis way, if for every reason we need to change the class of the labels for these forms we will only need to do one change and no one per field. \r\n\r\nFeedback welcome\r\n\r\nping @andrerom @yannickroger @clash82 @bdunogier \r\n","created_at":"2015-06-01T19:15:13Z","updated_at":"2015-06-04T09:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf3d2553ff05ba8cf513e2ec609182d7e802043e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158/commits","review_comments_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158/comments","review_comment_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/158/comments","statuses_url":"https://api.github.com/repos/ezsystems/DemoBundle/statuses/162b2cb4e8a93f567a825e83e7d86177867d6d12","head":{"label":"crevillo:EZP-24435","ref":"EZP-24435","sha":"162b2cb4e8a93f567a825e83e7d86177867d6d12","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?v=3","gravatar_id":"","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"repo":{"id":16217430,"name":"DemoBundle","full_name":"crevillo/DemoBundle","owner":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?v=3","gravatar_id":"","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crevillo/DemoBundle","description":"DemoBundle represent a front end web site on eZ Publish 5, work in progress","fork":true,"url":"https://api.github.com/repos/crevillo/DemoBundle","forks_url":"https://api.github.com/repos/crevillo/DemoBundle/forks","keys_url":"https://api.github.com/repos/crevillo/DemoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crevillo/DemoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crevillo/DemoBundle/teams","hooks_url":"https://api.github.com/repos/crevillo/DemoBundle/hooks","issue_events_url":"https://api.github.com/repos/crevillo/DemoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/crevillo/DemoBundle/events","assignees_url":"https://api.github.com/repos/crevillo/DemoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/crevillo/DemoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/crevillo/DemoBundle/tags","blobs_url":"https://api.github.com/repos/crevillo/DemoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crevillo/DemoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crevillo/DemoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/crevillo/DemoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crevillo/DemoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/crevillo/DemoBundle/languages","stargazers_url":"https://api.github.com/repos/crevillo/DemoBundle/stargazers","contributors_url":"https://api.github.com/repos/crevillo/DemoBundle/contributors","subscribers_url":"https://api.github.com/repos/crevillo/DemoBundle/subscribers","subscription_url":"https://api.github.com/repos/crevillo/DemoBundle/subscription","commits_url":"https://api.github.com/repos/crevillo/DemoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/crevillo/DemoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/crevillo/DemoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/crevillo/DemoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/crevillo/DemoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/crevillo/DemoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crevillo/DemoBundle/merges","archive_url":"https://api.github.com/repos/crevillo/DemoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crevillo/DemoBundle/downloads","issues_url":"https://api.github.com/repos/crevillo/DemoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/crevillo/DemoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/crevillo/DemoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/crevillo/DemoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crevillo/DemoBundle/labels{/name}","releases_url":"https://api.github.com/repos/crevillo/DemoBundle/releases{/id}","created_at":"2014-01-24T21:25:59Z","updated_at":"2014-06-09T08:28:44Z","pushed_at":"2015-06-04T08:28:09Z","git_url":"git://github.com/crevillo/DemoBundle.git","ssh_url":"git@github.com:crevillo/DemoBundle.git","clone_url":"https://github.com/crevillo/DemoBundle.git","svn_url":"https://github.com/crevillo/DemoBundle","homepage":null,"size":6277,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"d7e717dbc86f2d8e2330e9cda1f221e6282b9946","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":8177076,"name":"DemoBundle","full_name":"ezsystems/DemoBundle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/DemoBundle","description":"DemoBundle represent a front end web site on eZ Publish 5, work in progress","fork":false,"url":"https://api.github.com/repos/ezsystems/DemoBundle","forks_url":"https://api.github.com/repos/ezsystems/DemoBundle/forks","keys_url":"https://api.github.com/repos/ezsystems/DemoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/DemoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/DemoBundle/teams","hooks_url":"https://api.github.com/repos/ezsystems/DemoBundle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/DemoBundle/events","assignees_url":"https://api.github.com/repos/ezsystems/DemoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/DemoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/DemoBundle/tags","blobs_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/DemoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/DemoBundle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/DemoBundle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/DemoBundle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/DemoBundle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/DemoBundle/subscription","commits_url":"https://api.github.com/repos/ezsystems/DemoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/DemoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/DemoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/DemoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/DemoBundle/merges","archive_url":"https://api.github.com/repos/ezsystems/DemoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/DemoBundle/downloads","issues_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/DemoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/DemoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/DemoBundle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/DemoBundle/releases{/id}","created_at":"2013-02-13T10:19:36Z","updated_at":"2015-05-06T17:17:50Z","pushed_at":"2015-06-04T08:19:31Z","git_url":"git://github.com/ezsystems/DemoBundle.git","ssh_url":"git@github.com:ezsystems/DemoBundle.git","clone_url":"https://github.com/ezsystems/DemoBundle.git","svn_url":"https://github.com/ezsystems/DemoBundle","homepage":null,"size":9083,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":3,"forks":24,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158"},"html":{"href":"https://github.com/ezsystems/DemoBundle/pull/158"},"issue":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/issues/158"},"comments":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/statuses/162b2cb4e8a93f567a825e83e7d86177867d6d12"}}}}