{"action":"created","comment":{"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments/45551692","id":45551692,"diff_hunk":"@@ -40,19 +46,42 @@ bool LogFileReader::readAll(const QString& fileName)\n             emit batteryDataReceived(batteryData);\n         }\n     }\n-\n     return true;\n }\n \n // File input is a csv file in the format of hh:mm:ss:zzz, voltage, current\n bool LogFileReader::parseLine(const QString& line, BatteryData& batteryData) const\n {\n+\n+\n     // TODO implement this first\n+    QStringList column = line.split(BATDATA_DELIMITER);\n+    if(column.length() != 3)\n+        {\n+           return false;\n+        }","path":"src/LogFileReader.cpp","position":57,"original_position":57,"commit_id":"01912c92e9c2311a9b3d874af41cbc50d3a9a0e5","original_commit_id":"01912c92e9c2311a9b3d874af41cbc50d3a9a0e5","user":{"login":"enochtsang","id":9893396,"avatar_url":"https://avatars.githubusercontent.com/u/9893396?v=3","gravatar_id":"","url":"https://api.github.com/users/enochtsang","html_url":"https://github.com/enochtsang","followers_url":"https://api.github.com/users/enochtsang/followers","following_url":"https://api.github.com/users/enochtsang/following{/other_user}","gists_url":"https://api.github.com/users/enochtsang/gists{/gist_id}","starred_url":"https://api.github.com/users/enochtsang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enochtsang/subscriptions","organizations_url":"https://api.github.com/users/enochtsang/orgs","repos_url":"https://api.github.com/users/enochtsang/repos","events_url":"https://api.github.com/users/enochtsang/events{/privacy}","received_events_url":"https://api.github.com/users/enochtsang/received_events","type":"User","site_admin":false},"body":"The braces should be in the same column as the if statement, like this:\r\n```\r\nif(column.length() != 3)\r\n{\r\n    return false;\r\n}\r\n```","created_at":"2015-11-21T22:26:33Z","updated_at":"2015-11-21T22:26:33Z","html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/3#discussion_r45551692","pull_request_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments/45551692"},"html":{"href":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/3#discussion_r45551692"},"pull_request":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3","id":49359843,"html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/3","diff_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/3.diff","patch_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/3.patch","issue_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/3","number":3,"state":"open","locked":false,"title":"Ben","user":{"login":"benji373","id":15066679,"avatar_url":"https://avatars.githubusercontent.com/u/15066679?v=3","gravatar_id":"","url":"https://api.github.com/users/benji373","html_url":"https://github.com/benji373","followers_url":"https://api.github.com/users/benji373/followers","following_url":"https://api.github.com/users/benji373/following{/other_user}","gists_url":"https://api.github.com/users/benji373/gists{/gist_id}","starred_url":"https://api.github.com/users/benji373/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benji373/subscriptions","organizations_url":"https://api.github.com/users/benji373/orgs","repos_url":"https://api.github.com/users/benji373/repos","events_url":"https://api.github.com/users/benji373/events{/privacy}","received_events_url":"https://api.github.com/users/benji373/received_events","type":"User","site_admin":false},"body":"Completed the assignment.  Program outputs the time until the battery is depleted or charged based on whether or not the battery is charging or depleting.","created_at":"2015-10-31T21:59:29Z","updated_at":"2015-11-21T22:26:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"427ae412e3c421ca2d0dfe668cc07111889cb1fd","assignee":{"login":"enochtsang","id":9893396,"avatar_url":"https://avatars.githubusercontent.com/u/9893396?v=3","gravatar_id":"","url":"https://api.github.com/users/enochtsang","html_url":"https://github.com/enochtsang","followers_url":"https://api.github.com/users/enochtsang/followers","following_url":"https://api.github.com/users/enochtsang/following{/other_user}","gists_url":"https://api.github.com/users/enochtsang/gists{/gist_id}","starred_url":"https://api.github.com/users/enochtsang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enochtsang/subscriptions","organizations_url":"https://api.github.com/users/enochtsang/orgs","repos_url":"https://api.github.com/users/enochtsang/repos","events_url":"https://api.github.com/users/enochtsang/events{/privacy}","received_events_url":"https://api.github.com/users/enochtsang/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3/commits","review_comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3/comments","review_comment_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/3/comments","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/01912c92e9c2311a9b3d874af41cbc50d3a9a0e5","head":{"label":"UCSolarCarTeam:Ben","ref":"Ben","sha":"01912c92e9c2311a9b3d874af41cbc50d3a9a0e5","user":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":44296946,"name":"UofCSolarRecruitTraining","full_name":"UCSolarCarTeam/UofCSolarRecruitTraining","owner":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","description":"Intro project to learn c++ and QT","fork":false,"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining","forks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/forks","keys_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/teams","hooks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/hooks","issue_events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/events{/number}","events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/events","assignees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/assignees{/user}","branches_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/branches{/branch}","tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/tags","blobs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/languages","stargazers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/stargazers","contributors_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contributors","subscribers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscribers","subscription_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscription","commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contents/{+path}","compare_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/merges","archive_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/downloads","issues_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues{/number}","pulls_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/labels{/name}","releases_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/releases{/id}","created_at":"2015-10-15T06:02:46Z","updated_at":"2015-10-18T02:26:51Z","pushed_at":"2015-11-21T22:22:13Z","git_url":"git://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","ssh_url":"git@github.com:UCSolarCarTeam/UofCSolarRecruitTraining.git","clone_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","svn_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"UCSolarCarTeam:master","ref":"master","sha":"4a05cc81f5e1b8fff3c88e43684eba61bc0f7168","user":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":44296946,"name":"UofCSolarRecruitTraining","full_name":"UCSolarCarTeam/UofCSolarRecruitTraining","owner":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars.githubusercontent.com/u/14067129?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","description":"Intro project to learn c++ and QT","fork":false,"url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining","forks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/forks","keys_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/teams","hooks_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/hooks","issue_events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/events{/number}","events_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/events","assignees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/assignees{/user}","branches_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/branches{/branch}","tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/tags","blobs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/languages","stargazers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/stargazers","contributors_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contributors","subscribers_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscribers","subscription_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/subscription","commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/contents/{+path}","compare_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/merges","archive_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/downloads","issues_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues{/number}","pulls_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/labels{/name}","releases_url":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/releases{/id}","created_at":"2015-10-15T06:02:46Z","updated_at":"2015-10-18T02:26:51Z","pushed_at":"2015-11-21T22:22:13Z","git_url":"git://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","ssh_url":"git@github.com:UCSolarCarTeam/UofCSolarRecruitTraining.git","clone_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining.git","svn_url":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3"},"html":{"href":"https://github.com/UCSolarCarTeam/UofCSolarRecruitTraining/pull/3"},"issue":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/3"},"comments":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/UCSolarCarTeam/UofCSolarRecruitTraining/statuses/01912c92e9c2311a9b3d874af41cbc50d3a9a0e5"}}}}