{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72","id":39206541,"html_url":"https://github.com/rzwitserloot/lombok/pull/72","diff_url":"https://github.com/rzwitserloot/lombok/pull/72.diff","patch_url":"https://github.com/rzwitserloot/lombok/pull/72.patch","issue_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72","number":72,"state":"closed","locked":false,"title":"JUnit: Runner should not invoke fireTestFinished if test was ignored.","user":{"login":"Fuud","id":283980,"avatar_url":"https://avatars.githubusercontent.com/u/283980?v=3","gravatar_id":"","url":"https://api.github.com/users/Fuud","html_url":"https://github.com/Fuud","followers_url":"https://api.github.com/users/Fuud/followers","following_url":"https://api.github.com/users/Fuud/following{/other_user}","gists_url":"https://api.github.com/users/Fuud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuud/subscriptions","organizations_url":"https://api.github.com/users/Fuud/orgs","repos_url":"https://api.github.com/users/Fuud/repos","events_url":"https://api.github.com/users/Fuud/events{/privacy}","received_events_url":"https://api.github.com/users/Fuud/received_events","type":"User","site_admin":false},"body":"As done in `org.junit.runners.BlockJUnit4ClassRunner.runIgnored` if test is ignored, `Runner` should not invoke `fireTestStarted` and `fireTestFinished`. \r\nThis issue leads to problems when running tests in IntelliJ Idea (see https://youtrack.jetbrains.com/issue/IDEA-142279)\r\n\r\nCorrect alghorithm:\r\n1. Read LombokTestSources\r\n2. If test should be ignored - invoke fireTestIgnored\r\n3. Otherwice: invoke fireTestStarted, run test, invoke fireTestFinished","created_at":"2015-07-04T11:24:26Z","updated_at":"2015-11-17T00:43:13Z","closed_at":"2015-11-17T00:43:13Z","merged_at":null,"merge_commit_sha":"0ffecd3cbd534b8cb0ece654e0f19c4135a1b409","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72/commits","review_comments_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72/comments","review_comment_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72/comments","statuses_url":"https://api.github.com/repos/rzwitserloot/lombok/statuses/ebe579f7dd1161cd2503213460bea25308ee1ed3","head":{"label":"Fuud:fix-runner","ref":"fix-runner","sha":"ebe579f7dd1161cd2503213460bea25308ee1ed3","user":{"login":"Fuud","id":283980,"avatar_url":"https://avatars.githubusercontent.com/u/283980?v=3","gravatar_id":"","url":"https://api.github.com/users/Fuud","html_url":"https://github.com/Fuud","followers_url":"https://api.github.com/users/Fuud/followers","following_url":"https://api.github.com/users/Fuud/following{/other_user}","gists_url":"https://api.github.com/users/Fuud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuud/subscriptions","organizations_url":"https://api.github.com/users/Fuud/orgs","repos_url":"https://api.github.com/users/Fuud/repos","events_url":"https://api.github.com/users/Fuud/events{/privacy}","received_events_url":"https://api.github.com/users/Fuud/received_events","type":"User","site_admin":false},"repo":{"id":36289338,"name":"lombok","full_name":"Fuud/lombok","owner":{"login":"Fuud","id":283980,"avatar_url":"https://avatars.githubusercontent.com/u/283980?v=3","gravatar_id":"","url":"https://api.github.com/users/Fuud","html_url":"https://github.com/Fuud","followers_url":"https://api.github.com/users/Fuud/followers","following_url":"https://api.github.com/users/Fuud/following{/other_user}","gists_url":"https://api.github.com/users/Fuud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuud/subscriptions","organizations_url":"https://api.github.com/users/Fuud/orgs","repos_url":"https://api.github.com/users/Fuud/repos","events_url":"https://api.github.com/users/Fuud/events{/privacy}","received_events_url":"https://api.github.com/users/Fuud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fuud/lombok","description":"Very spicy additions to the Java programming language.","fork":true,"url":"https://api.github.com/repos/Fuud/lombok","forks_url":"https://api.github.com/repos/Fuud/lombok/forks","keys_url":"https://api.github.com/repos/Fuud/lombok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fuud/lombok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fuud/lombok/teams","hooks_url":"https://api.github.com/repos/Fuud/lombok/hooks","issue_events_url":"https://api.github.com/repos/Fuud/lombok/issues/events{/number}","events_url":"https://api.github.com/repos/Fuud/lombok/events","assignees_url":"https://api.github.com/repos/Fuud/lombok/assignees{/user}","branches_url":"https://api.github.com/repos/Fuud/lombok/branches{/branch}","tags_url":"https://api.github.com/repos/Fuud/lombok/tags","blobs_url":"https://api.github.com/repos/Fuud/lombok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fuud/lombok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fuud/lombok/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fuud/lombok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fuud/lombok/statuses/{sha}","languages_url":"https://api.github.com/repos/Fuud/lombok/languages","stargazers_url":"https://api.github.com/repos/Fuud/lombok/stargazers","contributors_url":"https://api.github.com/repos/Fuud/lombok/contributors","subscribers_url":"https://api.github.com/repos/Fuud/lombok/subscribers","subscription_url":"https://api.github.com/repos/Fuud/lombok/subscription","commits_url":"https://api.github.com/repos/Fuud/lombok/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fuud/lombok/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fuud/lombok/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fuud/lombok/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fuud/lombok/contents/{+path}","compare_url":"https://api.github.com/repos/Fuud/lombok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fuud/lombok/merges","archive_url":"https://api.github.com/repos/Fuud/lombok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fuud/lombok/downloads","issues_url":"https://api.github.com/repos/Fuud/lombok/issues{/number}","pulls_url":"https://api.github.com/repos/Fuud/lombok/pulls{/number}","milestones_url":"https://api.github.com/repos/Fuud/lombok/milestones{/number}","notifications_url":"https://api.github.com/repos/Fuud/lombok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fuud/lombok/labels{/name}","releases_url":"https://api.github.com/repos/Fuud/lombok/releases{/id}","created_at":"2015-05-26T10:40:04Z","updated_at":"2015-05-26T10:40:07Z","pushed_at":"2015-07-04T11:19:42Z","git_url":"git://github.com/Fuud/lombok.git","ssh_url":"git@github.com:Fuud/lombok.git","clone_url":"https://github.com/Fuud/lombok.git","svn_url":"https://github.com/Fuud/lombok","homepage":"http://projectlombok.org/","size":71103,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rzwitserloot:master","ref":"master","sha":"251fd03cd78ef6996d4252450bda596a5e8b11b9","user":{"login":"rzwitserloot","id":93303,"avatar_url":"https://avatars.githubusercontent.com/u/93303?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwitserloot","html_url":"https://github.com/rzwitserloot","followers_url":"https://api.github.com/users/rzwitserloot/followers","following_url":"https://api.github.com/users/rzwitserloot/following{/other_user}","gists_url":"https://api.github.com/users/rzwitserloot/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwitserloot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwitserloot/subscriptions","organizations_url":"https://api.github.com/users/rzwitserloot/orgs","repos_url":"https://api.github.com/users/rzwitserloot/repos","events_url":"https://api.github.com/users/rzwitserloot/events{/privacy}","received_events_url":"https://api.github.com/users/rzwitserloot/received_events","type":"User","site_admin":false},"repo":{"id":221862,"name":"lombok","full_name":"rzwitserloot/lombok","owner":{"login":"rzwitserloot","id":93303,"avatar_url":"https://avatars.githubusercontent.com/u/93303?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwitserloot","html_url":"https://github.com/rzwitserloot","followers_url":"https://api.github.com/users/rzwitserloot/followers","following_url":"https://api.github.com/users/rzwitserloot/following{/other_user}","gists_url":"https://api.github.com/users/rzwitserloot/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwitserloot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwitserloot/subscriptions","organizations_url":"https://api.github.com/users/rzwitserloot/orgs","repos_url":"https://api.github.com/users/rzwitserloot/repos","events_url":"https://api.github.com/users/rzwitserloot/events{/privacy}","received_events_url":"https://api.github.com/users/rzwitserloot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rzwitserloot/lombok","description":"Very spicy additions to the Java programming language.","fork":false,"url":"https://api.github.com/repos/rzwitserloot/lombok","forks_url":"https://api.github.com/repos/rzwitserloot/lombok/forks","keys_url":"https://api.github.com/repos/rzwitserloot/lombok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rzwitserloot/lombok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rzwitserloot/lombok/teams","hooks_url":"https://api.github.com/repos/rzwitserloot/lombok/hooks","issue_events_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/events{/number}","events_url":"https://api.github.com/repos/rzwitserloot/lombok/events","assignees_url":"https://api.github.com/repos/rzwitserloot/lombok/assignees{/user}","branches_url":"https://api.github.com/repos/rzwitserloot/lombok/branches{/branch}","tags_url":"https://api.github.com/repos/rzwitserloot/lombok/tags","blobs_url":"https://api.github.com/repos/rzwitserloot/lombok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rzwitserloot/lombok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rzwitserloot/lombok/git/refs{/sha}","trees_url":"https://api.github.com/repos/rzwitserloot/lombok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rzwitserloot/lombok/statuses/{sha}","languages_url":"https://api.github.com/repos/rzwitserloot/lombok/languages","stargazers_url":"https://api.github.com/repos/rzwitserloot/lombok/stargazers","contributors_url":"https://api.github.com/repos/rzwitserloot/lombok/contributors","subscribers_url":"https://api.github.com/repos/rzwitserloot/lombok/subscribers","subscription_url":"https://api.github.com/repos/rzwitserloot/lombok/subscription","commits_url":"https://api.github.com/repos/rzwitserloot/lombok/commits{/sha}","git_commits_url":"https://api.github.com/repos/rzwitserloot/lombok/git/commits{/sha}","comments_url":"https://api.github.com/repos/rzwitserloot/lombok/comments{/number}","issue_comment_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/comments{/number}","contents_url":"https://api.github.com/repos/rzwitserloot/lombok/contents/{+path}","compare_url":"https://api.github.com/repos/rzwitserloot/lombok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rzwitserloot/lombok/merges","archive_url":"https://api.github.com/repos/rzwitserloot/lombok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rzwitserloot/lombok/downloads","issues_url":"https://api.github.com/repos/rzwitserloot/lombok/issues{/number}","pulls_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls{/number}","milestones_url":"https://api.github.com/repos/rzwitserloot/lombok/milestones{/number}","notifications_url":"https://api.github.com/repos/rzwitserloot/lombok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rzwitserloot/lombok/labels{/name}","releases_url":"https://api.github.com/repos/rzwitserloot/lombok/releases{/id}","created_at":"2009-06-08T19:46:41Z","updated_at":"2015-11-16T15:47:19Z","pushed_at":"2015-11-17T00:41:42Z","git_url":"git://github.com/rzwitserloot/lombok.git","ssh_url":"git@github.com:rzwitserloot/lombok.git","clone_url":"https://github.com/rzwitserloot/lombok.git","svn_url":"https://github.com/rzwitserloot/lombok","homepage":"http://projectlombok.org/","size":72765,"stargazers_count":1929,"watchers_count":1929,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":455,"mirror_url":null,"open_issues_count":288,"forks":455,"open_issues":288,"watchers":1929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72"},"html":{"href":"https://github.com/rzwitserloot/lombok/pull/72"},"issue":{"href":"https://api.github.com/repos/rzwitserloot/lombok/issues/72"},"comments":{"href":"https://api.github.com/repos/rzwitserloot/lombok/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/rzwitserloot/lombok/statuses/ebe579f7dd1161cd2503213460bea25308ee1ed3"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":90,"deletions":35,"changed_files":4}}