{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/24621257","id":24621257,"diff_hunk":"@@ -82,58 +121,63 @@ def create_operation_docstring(operation):\n         :type from_date: str\n         :rtype: list\n     \"\"\"\n+    print 'creating op docstring for %s' % operation.operation_id","path":"bravado/mapping/docstring.py","position":50,"original_position":50,"commit_id":"8ffee82cf6faf5e2c2f2a083d71c33bec49c22dd","original_commit_id":"8ffee82cf6faf5e2c2f2a083d71c33bec49c22dd","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"body":"It should be either a log or appended to `s`","created_at":"2015-02-12T21:19:23Z","updated_at":"2015-02-12T21:19:23Z","html_url":"https://github.com/Yelp/swagger-py/pull/104#discussion_r24621257","pull_request_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/24621257"},"html":{"href":"https://github.com/Yelp/swagger-py/pull/104#discussion_r24621257"},"pull_request":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/swagger-py/pulls/104","id":29142004,"html_url":"https://github.com/Yelp/swagger-py/pull/104","diff_url":"https://github.com/Yelp/swagger-py/pull/104.diff","patch_url":"https://github.com/Yelp/swagger-py/pull/104.patch","issue_url":"https://api.github.com/repos/Yelp/swagger-py/issues/104","number":104,"state":"open","locked":false,"title":"Refactor parameter validation + serialization","user":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"body":"Sorry for the large pull request - it kind of grew and grew.\r\n\r\nContext: Swagger has definitions, paths, parameters, responses, etc.  This review is mostly about parameters (ignore the branch name). \r\n\r\nA few notes about naming:\r\n- ```*_spec``` : dict fragments from the swagger spec (except when talking about the spec itself -- swagger_spec which is a ```bravado.mapping.spec.Spec``` class\r\n- ```*_dict```: tried to stop using this for anything related directly to the spec - only use for the request_dict atm\r\n\r\nNotes:\r\n- wrt parameters, primitive and array is implemented. Body and formData are TODOs\r\n- this contains the docstring changes for operations in ```docstring.py```. ```help(petstore.pet.getPetById)``` now works\r\n- anything that is ```$ref```able is stored under two keys for - one is the simple name and the other is the ```#/``` style absolute format. May do away with the simple name thing later.\r\n- ```marshal.py``` is new and contains validation and serialization stuff for parameters only atm\r\n- ```schema.py``` is new and contains Swagger Spec -> json schema conversion stuff so that we can delegate as much per request/response validation off to jsonsonschema\r\n- I'd like to get rid of 1.2 legacy code ```validate_and_add_params_to_request```, ```add_param_to_request```, ```SwaggerTypeCheck``` and related classes/funcs because it is just doing too much stuff and is hard to follow. None of the new parameter stuff uses them.\r\n- ```tests/petstore/*``` was a small diversion into hitting the 2.0 petstore API directly - most of the error cases don't work because of the server side impl.  Provided a good way to actually hit an API when I made changes. These tests are excluded from test discovery when doing a build\r\n- $ref resolution is still a work in progress - operation parameters that $ref to ```#/parameters``` works\r\n- I still don't like building dicts with overly verbose comprehensions, but I have a new reason not to like them -- stepping through them in the debugger is crap\r\n- You know i'm a unit test nut! I was pretty disciplined but I'm sure there are things I missed...\r\n\r\nExpect to couple follow up commits to clean things up and get flake8 passing.\r\n\r\n\r\n\r\n","created_at":"2015-02-12T00:18:47Z","updated_at":"2015-02-12T21:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ec774f14980818b51863d9c72c65ede12ec94a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/104/commits","review_comments_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/104/comments","review_comment_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/issues/104/comments","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/8ffee82cf6faf5e2c2f2a083d71c33bec49c22dd","head":{"label":"analogue:port_response","ref":"port_response","sha":"8ffee82cf6faf5e2c2f2a083d71c33bec49c22dd","user":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"repo":{"id":25488246,"name":"swagger-py","full_name":"analogue/swagger-py","owner":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/analogue/swagger-py","description":"Generic client library for Python2.6 - adopts SwaggerVersion 1.2","fork":true,"url":"https://api.github.com/repos/analogue/swagger-py","forks_url":"https://api.github.com/repos/analogue/swagger-py/forks","keys_url":"https://api.github.com/repos/analogue/swagger-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analogue/swagger-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analogue/swagger-py/teams","hooks_url":"https://api.github.com/repos/analogue/swagger-py/hooks","issue_events_url":"https://api.github.com/repos/analogue/swagger-py/issues/events{/number}","events_url":"https://api.github.com/repos/analogue/swagger-py/events","assignees_url":"https://api.github.com/repos/analogue/swagger-py/assignees{/user}","branches_url":"https://api.github.com/repos/analogue/swagger-py/branches{/branch}","tags_url":"https://api.github.com/repos/analogue/swagger-py/tags","blobs_url":"https://api.github.com/repos/analogue/swagger-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analogue/swagger-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analogue/swagger-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/analogue/swagger-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analogue/swagger-py/statuses/{sha}","languages_url":"https://api.github.com/repos/analogue/swagger-py/languages","stargazers_url":"https://api.github.com/repos/analogue/swagger-py/stargazers","contributors_url":"https://api.github.com/repos/analogue/swagger-py/contributors","subscribers_url":"https://api.github.com/repos/analogue/swagger-py/subscribers","subscription_url":"https://api.github.com/repos/analogue/swagger-py/subscription","commits_url":"https://api.github.com/repos/analogue/swagger-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/analogue/swagger-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/analogue/swagger-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/analogue/swagger-py/issues/comments/{number}","contents_url":"https://api.github.com/repos/analogue/swagger-py/contents/{+path}","compare_url":"https://api.github.com/repos/analogue/swagger-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analogue/swagger-py/merges","archive_url":"https://api.github.com/repos/analogue/swagger-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analogue/swagger-py/downloads","issues_url":"https://api.github.com/repos/analogue/swagger-py/issues{/number}","pulls_url":"https://api.github.com/repos/analogue/swagger-py/pulls{/number}","milestones_url":"https://api.github.com/repos/analogue/swagger-py/milestones{/number}","notifications_url":"https://api.github.com/repos/analogue/swagger-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analogue/swagger-py/labels{/name}","releases_url":"https://api.github.com/repos/analogue/swagger-py/releases{/id}","created_at":"2014-10-20T21:50:53Z","updated_at":"2015-01-08T19:02:41Z","pushed_at":"2015-02-11T23:48:36Z","git_url":"git://github.com/analogue/swagger-py.git","ssh_url":"git@github.com:analogue/swagger-py.git","clone_url":"https://github.com/analogue/swagger-py.git","svn_url":"https://github.com/analogue/swagger-py","homepage":"","size":929,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:swagger2.0","ref":"swagger2.0","sha":"db27aff5e58badb15746b7fac161a455c4e40dc3","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":20313056,"name":"swagger-py","full_name":"Yelp/swagger-py","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/swagger-py","description":"Generic client library for Python2.6 - adopts SwaggerVersion 1.2","fork":false,"url":"https://api.github.com/repos/Yelp/swagger-py","forks_url":"https://api.github.com/repos/Yelp/swagger-py/forks","keys_url":"https://api.github.com/repos/Yelp/swagger-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/swagger-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/swagger-py/teams","hooks_url":"https://api.github.com/repos/Yelp/swagger-py/hooks","issue_events_url":"https://api.github.com/repos/Yelp/swagger-py/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/swagger-py/events","assignees_url":"https://api.github.com/repos/Yelp/swagger-py/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/swagger-py/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/swagger-py/tags","blobs_url":"https://api.github.com/repos/Yelp/swagger-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/swagger-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/swagger-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/swagger-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/swagger-py/languages","stargazers_url":"https://api.github.com/repos/Yelp/swagger-py/stargazers","contributors_url":"https://api.github.com/repos/Yelp/swagger-py/contributors","subscribers_url":"https://api.github.com/repos/Yelp/swagger-py/subscribers","subscription_url":"https://api.github.com/repos/Yelp/swagger-py/subscription","commits_url":"https://api.github.com/repos/Yelp/swagger-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/swagger-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/swagger-py/issues/comments/{number}","contents_url":"https://api.github.com/repos/Yelp/swagger-py/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/swagger-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/swagger-py/merges","archive_url":"https://api.github.com/repos/Yelp/swagger-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/swagger-py/downloads","issues_url":"https://api.github.com/repos/Yelp/swagger-py/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/swagger-py/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/swagger-py/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/swagger-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/swagger-py/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/swagger-py/releases{/id}","created_at":"2014-05-30T01:03:02Z","updated_at":"2015-02-02T17:40:33Z","pushed_at":"2015-02-04T22:54:09Z","git_url":"git://github.com/Yelp/swagger-py.git","ssh_url":"git@github.com:Yelp/swagger-py.git","clone_url":"https://github.com/Yelp/swagger-py.git","svn_url":"https://github.com/Yelp/swagger-py","homepage":"","size":1711,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":17,"forks":11,"open_issues":17,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/104"},"html":{"href":"https://github.com/Yelp/swagger-py/pull/104"},"issue":{"href":"https://api.github.com/repos/Yelp/swagger-py/issues/104"},"comments":{"href":"https://api.github.com/repos/Yelp/swagger-py/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/swagger-py/statuses/8ffee82cf6faf5e2c2f2a083d71c33bec49c22dd"}}}}