{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/26615687","id":26615687,"diff_hunk":"@@ -110,65 +110,65 @@ public void GetMetadataForProperties_IncludesMergedAttributes()\n             Assert.Equal(\"OnPropertyType\", Assert.IsType<ModelAttribute>(attributes[1]).Value);\n         }\n \n-        [Fact]\n-        public void GetMetadataForParameter_IncludesMergedAttributes()\n-        {\n-            // Arrange\n-            var provider = CreateProvider();\n-\n-            var methodInfo = GetType().GetMethod(\n-                \"GetMetadataForParameterTestMethod\", \n-                BindingFlags.Instance | BindingFlags.NonPublic);\n-            var parameterInfo = methodInfo.GetParameters().Where(p => p.Name == \"parameter\").Single();\n-\n-            var additionalAttributes = new object[]\n-            {\n-                new ModelAttribute(\"Extra\"),\n-            };\n-\n-            // Act\n-            var metadata = provider.GetMetadataForParameter(parameterInfo, additionalAttributes);\n-\n-            // Assert\n-            var defaultMetadata = Assert.IsType<DefaultModelMetadata>(metadata);\n-\n-            var attributes = defaultMetadata.Attributes.ToArray();\n-            Assert.Equal(\"Extra\", Assert.IsType<ModelAttribute>(attributes[0]).Value);\n-            Assert.Equal(\"OnParameter\", Assert.IsType<ModelAttribute>(attributes[1]).Value);\n-            Assert.Equal(\"OnType\", Assert.IsType<ModelAttribute>(attributes[2]).Value);\n-        }\n+        //[Fact]\n+        //public void GetMetadataForParameter_IncludesMergedAttributes()\n+        //{\n+        //    // Arrange\n+        //    var provider = CreateProvider();\n+\n+        //    var methodInfo = GetType().GetMethod(\n+        //        \"GetMetadataForParameterTestMethod\", \n+        //        BindingFlags.Instance | BindingFlags.NonPublic);\n+        //    var parameterInfo = methodInfo.GetParameters().Where(p => p.Name == \"parameter\").Single();\n+\n+        //    var additionalAttributes = new object[]\n+        //    {\n+        //        new ModelAttribute(\"Extra\"),\n+        //    };\n+\n+        //    // Act\n+        //    var metadata = provider.GetMetadataForParameter(parameterInfo, additionalAttributes);\n+\n+        //    // Assert\n+        //    var defaultMetadata = Assert.IsType<DefaultModelMetadata>(metadata);\n+\n+        //    var attributes = defaultMetadata.Attributes.ToArray();\n+        //    Assert.Equal(\"Extra\", Assert.IsType<ModelAttribute>(attributes[0]).Value);\n+        //    Assert.Equal(\"OnParameter\", Assert.IsType<ModelAttribute>(attributes[1]).Value);\n+        //    Assert.Equal(\"OnType\", Assert.IsType<ModelAttribute>(attributes[2]).Value);\n+        //}","path":"test/Microsoft.AspNet.Mvc.ModelBinding.Test/Metadata/DefaultModelMetadataProviderTest.cs","position":57,"original_position":57,"commit_id":"384c57b996d8cad89bcf0a3c4193ecc4df0a20b4","original_commit_id":"384c57b996d8cad89bcf0a3c4193ecc4df0a20b4","user":{"login":"harshgMSFT","id":6729943,"avatar_url":"https://avatars.githubusercontent.com/u/6729943?v=3","gravatar_id":"","url":"https://api.github.com/users/harshgMSFT","html_url":"https://github.com/harshgMSFT","followers_url":"https://api.github.com/users/harshgMSFT/followers","following_url":"https://api.github.com/users/harshgMSFT/following{/other_user}","gists_url":"https://api.github.com/users/harshgMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/harshgMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshgMSFT/subscriptions","organizations_url":"https://api.github.com/users/harshgMSFT/orgs","repos_url":"https://api.github.com/users/harshgMSFT/repos","events_url":"https://api.github.com/users/harshgMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/harshgMSFT/received_events","type":"User","site_admin":false},"body":"Missed it .. will do.","created_at":"2015-03-17T21:00:11Z","updated_at":"2015-03-17T21:00:11Z","html_url":"https://github.com/aspnet/Mvc/pull/2168#discussion_r26615687","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2168","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/26615687"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2168#discussion_r26615687"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2168"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2168","id":31098307,"html_url":"https://github.com/aspnet/Mvc/pull/2168","diff_url":"https://github.com/aspnet/Mvc/pull/2168.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2168.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2168","number":2168,"state":"open","locked":false,"title":"Removing ModelMetadataProvider.GetModelMetadataForParameters","user":{"login":"harshgMSFT","id":6729943,"avatar_url":"https://avatars.githubusercontent.com/u/6729943?v=3","gravatar_id":"","url":"https://api.github.com/users/harshgMSFT","html_url":"https://github.com/harshgMSFT","followers_url":"https://api.github.com/users/harshgMSFT/followers","following_url":"https://api.github.com/users/harshgMSFT/following{/other_user}","gists_url":"https://api.github.com/users/harshgMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/harshgMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshgMSFT/subscriptions","organizations_url":"https://api.github.com/users/harshgMSFT/orgs","repos_url":"https://api.github.com/users/harshgMSFT/repos","events_url":"https://api.github.com/users/harshgMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/harshgMSFT/received_events","type":"User","site_admin":false},"body":"- Pending: Few test fixes and some new test.\r\ncc: @rynowak ","created_at":"2015-03-13T03:48:23Z","updated_at":"2015-03-17T21:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"977c9bf58e5345cb5b70e4fb51b64d9f72d553ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2168/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2168/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2168/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/384c57b996d8cad89bcf0a3c4193ecc4df0a20b4","head":{"label":"aspnet:ParametersCleanup","ref":"ParametersCleanup","sha":"384c57b996d8cad89bcf0a3c4193ecc4df0a20b4","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-03-17T20:44:17Z","pushed_at":"2015-03-17T20:44:16Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":94004,"stargazers_count":1493,"watchers_count":1493,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":464,"mirror_url":null,"open_issues_count":212,"forks":464,"open_issues":212,"watchers":1493,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"489fc52df854ff98c8777cfaa0781ce8d38f18f9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-03-17T20:44:17Z","pushed_at":"2015-03-17T20:44:16Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":94004,"stargazers_count":1493,"watchers_count":1493,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":464,"mirror_url":null,"open_issues_count":212,"forks":464,"open_issues":212,"watchers":1493,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2168"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2168"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2168"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2168/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2168/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2168/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/384c57b996d8cad89bcf0a3c4193ecc4df0a20b4"}}}}