{"action":"created","comment":{"url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/comments/24061554","id":24061554,"diff_hunk":"@@ -157,7 +160,10 @@ public void execute(Tuple tuple) {\n \n         } catch (Throwable e) {\n             log.error(\"Exception while parsing {}\", url, e);\n-            collector.fail(tuple);\n+            metadata.put(\"errorMessage\", new String[] {\"Exception while parsing \" + url});","path":"jsoup-parser/src/main/java/com/shopstyle/crawler/jsoup/JSoupParserBolt.java","position":70,"original_position":70,"commit_id":"75529045ba366236817d6bc9ec5f97deee08c32f","original_commit_id":"75529045ba366236817d6bc9ec5f97deee08c32f","user":{"login":"GuiForget","id":2585258,"avatar_url":"https://avatars.githubusercontent.com/u/2585258?v=3","gravatar_id":"","url":"https://api.github.com/users/GuiForget","html_url":"https://github.com/GuiForget","followers_url":"https://api.github.com/users/GuiForget/followers","following_url":"https://api.github.com/users/GuiForget/following{/other_user}","gists_url":"https://api.github.com/users/GuiForget/gists{/gist_id}","starred_url":"https://api.github.com/users/GuiForget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuiForget/subscriptions","organizations_url":"https://api.github.com/users/GuiForget/orgs","repos_url":"https://api.github.com/users/GuiForget/repos","events_url":"https://api.github.com/users/GuiForget/events{/privacy}","received_events_url":"https://api.github.com/users/GuiForget/received_events","type":"User","site_admin":false},"body":"I would add  ` + \" : \" + e.getMessage()`","created_at":"2015-02-04T04:03:27Z","updated_at":"2015-02-04T04:03:27Z","html_url":"https://github.com/PopSugar/storm-crawler-extensions/pull/9#discussion_r24061554","pull_request_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/comments/24061554"},"html":{"href":"https://github.com/PopSugar/storm-crawler-extensions/pull/9#discussion_r24061554"},"pull_request":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9","id":28525211,"html_url":"https://github.com/PopSugar/storm-crawler-extensions/pull/9","diff_url":"https://github.com/PopSugar/storm-crawler-extensions/pull/9.diff","patch_url":"https://github.com/PopSugar/storm-crawler-extensions/pull/9.patch","issue_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues/9","number":9,"state":"open","locked":false,"title":"BE-472 #Done Put Errors in the status stream in JsoupParser Bolt","user":{"login":"nfalaki","id":5580722,"avatar_url":"https://avatars.githubusercontent.com/u/5580722?v=3","gravatar_id":"","url":"https://api.github.com/users/nfalaki","html_url":"https://github.com/nfalaki","followers_url":"https://api.github.com/users/nfalaki/followers","following_url":"https://api.github.com/users/nfalaki/following{/other_user}","gists_url":"https://api.github.com/users/nfalaki/gists{/gist_id}","starred_url":"https://api.github.com/users/nfalaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfalaki/subscriptions","organizations_url":"https://api.github.com/users/nfalaki/orgs","repos_url":"https://api.github.com/users/nfalaki/repos","events_url":"https://api.github.com/users/nfalaki/events{/privacy}","received_events_url":"https://api.github.com/users/nfalaki/received_events","type":"User","site_admin":false},"body":"Currently the error handling of the JSoupParserBolt is incorrect, It is currently doing a collector.fail,\r\nunfortunately this just resends the same tuple over and over again when we do this.\r\n\r\nA better solution would be to send the crawlStatus through the status stream to the CrawlItemUpdater.\r\nThe crawlItemUpdater will then save the status to dynamoDB with a status of error.","created_at":"2015-02-03T03:58:45Z","updated_at":"2015-02-04T04:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23e07d0acc306ac4682a84370cd8ceff7b5efe0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9/commits","review_comments_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9/comments","review_comment_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues/9/comments","statuses_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/statuses/75529045ba366236817d6bc9ec5f97deee08c32f","head":{"label":"nfalaki:addStatusStream","ref":"addStatusStream","sha":"75529045ba366236817d6bc9ec5f97deee08c32f","user":{"login":"nfalaki","id":5580722,"avatar_url":"https://avatars.githubusercontent.com/u/5580722?v=3","gravatar_id":"","url":"https://api.github.com/users/nfalaki","html_url":"https://github.com/nfalaki","followers_url":"https://api.github.com/users/nfalaki/followers","following_url":"https://api.github.com/users/nfalaki/following{/other_user}","gists_url":"https://api.github.com/users/nfalaki/gists{/gist_id}","starred_url":"https://api.github.com/users/nfalaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfalaki/subscriptions","organizations_url":"https://api.github.com/users/nfalaki/orgs","repos_url":"https://api.github.com/users/nfalaki/repos","events_url":"https://api.github.com/users/nfalaki/events{/privacy}","received_events_url":"https://api.github.com/users/nfalaki/received_events","type":"User","site_admin":false},"repo":{"id":30223726,"name":"storm-crawler-extensions","full_name":"nfalaki/storm-crawler-extensions","owner":{"login":"nfalaki","id":5580722,"avatar_url":"https://avatars.githubusercontent.com/u/5580722?v=3","gravatar_id":"","url":"https://api.github.com/users/nfalaki","html_url":"https://github.com/nfalaki","followers_url":"https://api.github.com/users/nfalaki/followers","following_url":"https://api.github.com/users/nfalaki/following{/other_user}","gists_url":"https://api.github.com/users/nfalaki/gists{/gist_id}","starred_url":"https://api.github.com/users/nfalaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfalaki/subscriptions","organizations_url":"https://api.github.com/users/nfalaki/orgs","repos_url":"https://api.github.com/users/nfalaki/repos","events_url":"https://api.github.com/users/nfalaki/events{/privacy}","received_events_url":"https://api.github.com/users/nfalaki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfalaki/storm-crawler-extensions","description":"Various extensions/plugins for the project https://github.com/DigitalPebble/storm-crawler","fork":true,"url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions","forks_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/forks","keys_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/teams","hooks_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/hooks","issue_events_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/events","assignees_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/tags","blobs_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/languages","stargazers_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/stargazers","contributors_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/contributors","subscribers_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/subscribers","subscription_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/subscription","commits_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/issues/comments/{number}","contents_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/merges","archive_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/downloads","issues_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/labels{/name}","releases_url":"https://api.github.com/repos/nfalaki/storm-crawler-extensions/releases{/id}","created_at":"2015-02-03T03:54:47Z","updated_at":"2015-02-03T03:54:47Z","pushed_at":"2015-02-03T19:43:13Z","git_url":"git://github.com/nfalaki/storm-crawler-extensions.git","ssh_url":"git@github.com:nfalaki/storm-crawler-extensions.git","clone_url":"https://github.com/nfalaki/storm-crawler-extensions.git","svn_url":"https://github.com/nfalaki/storm-crawler-extensions","homepage":null,"size":387,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PopSugar:master","ref":"master","sha":"d9932627c536312dedda72ccbeff00b1cc13cc9c","user":{"login":"PopSugar","id":1076661,"avatar_url":"https://avatars.githubusercontent.com/u/1076661?v=3","gravatar_id":"","url":"https://api.github.com/users/PopSugar","html_url":"https://github.com/PopSugar","followers_url":"https://api.github.com/users/PopSugar/followers","following_url":"https://api.github.com/users/PopSugar/following{/other_user}","gists_url":"https://api.github.com/users/PopSugar/gists{/gist_id}","starred_url":"https://api.github.com/users/PopSugar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopSugar/subscriptions","organizations_url":"https://api.github.com/users/PopSugar/orgs","repos_url":"https://api.github.com/users/PopSugar/repos","events_url":"https://api.github.com/users/PopSugar/events{/privacy}","received_events_url":"https://api.github.com/users/PopSugar/received_events","type":"Organization","site_admin":false},"repo":{"id":26197667,"name":"storm-crawler-extensions","full_name":"PopSugar/storm-crawler-extensions","owner":{"login":"PopSugar","id":1076661,"avatar_url":"https://avatars.githubusercontent.com/u/1076661?v=3","gravatar_id":"","url":"https://api.github.com/users/PopSugar","html_url":"https://github.com/PopSugar","followers_url":"https://api.github.com/users/PopSugar/followers","following_url":"https://api.github.com/users/PopSugar/following{/other_user}","gists_url":"https://api.github.com/users/PopSugar/gists{/gist_id}","starred_url":"https://api.github.com/users/PopSugar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopSugar/subscriptions","organizations_url":"https://api.github.com/users/PopSugar/orgs","repos_url":"https://api.github.com/users/PopSugar/repos","events_url":"https://api.github.com/users/PopSugar/events{/privacy}","received_events_url":"https://api.github.com/users/PopSugar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PopSugar/storm-crawler-extensions","description":"Various extensions/plugins for the project https://github.com/DigitalPebble/storm-crawler","fork":false,"url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions","forks_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/forks","keys_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/teams","hooks_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/hooks","issue_events_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/events","assignees_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/tags","blobs_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/languages","stargazers_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/stargazers","contributors_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/contributors","subscribers_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/subscribers","subscription_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/subscription","commits_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues/comments/{number}","contents_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/merges","archive_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/downloads","issues_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/labels{/name}","releases_url":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/releases{/id}","created_at":"2014-11-05T01:45:01Z","updated_at":"2015-01-29T14:38:57Z","pushed_at":"2015-01-29T14:38:57Z","git_url":"git://github.com/PopSugar/storm-crawler-extensions.git","ssh_url":"git@github.com:PopSugar/storm-crawler-extensions.git","clone_url":"https://github.com/PopSugar/storm-crawler-extensions.git","svn_url":"https://github.com/PopSugar/storm-crawler-extensions","homepage":null,"size":387,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9"},"html":{"href":"https://github.com/PopSugar/storm-crawler-extensions/pull/9"},"issue":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues/9"},"comments":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/PopSugar/storm-crawler-extensions/statuses/75529045ba366236817d6bc9ec5f97deee08c32f"}}}}