{"action":"closed","number":9956,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9956","id":42545875,"html_url":"https://github.com/laravel/framework/pull/9956","diff_url":"https://github.com/laravel/framework/pull/9956.diff","patch_url":"https://github.com/laravel/framework/pull/9956.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9956","number":9956,"state":"closed","locked":false,"title":"[5.2] Dependency injection in model factories","user":{"login":"dan-har","id":8581476,"avatar_url":"https://avatars.githubusercontent.com/u/8581476?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-har","html_url":"https://github.com/dan-har","followers_url":"https://api.github.com/users/dan-har/followers","following_url":"https://api.github.com/users/dan-har/following{/other_user}","gists_url":"https://api.github.com/users/dan-har/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-har/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-har/subscriptions","organizations_url":"https://api.github.com/users/dan-har/orgs","repos_url":"https://api.github.com/users/dan-har/repos","events_url":"https://api.github.com/users/dan-har/events{/privacy}","received_events_url":"https://api.github.com/users/dan-har/received_events","type":"User","site_admin":false},"body":"It can be useful to inject some other classes to the factories, like some custom generators for data that is not included in `Faker`\r\n\r\nexample of use : \r\n```\r\n$factory->define(App\\User::class, function (App\\CustomGenerator $customGenerator, $faker, $attributes) {\r\n    \r\n    return [\r\n        'name' => $faker->name,\r\n        'email' => $faker->email,\r\n        'password' => str_random(10),\r\n        'remember_token' => str_random(10),\r\n        'custom_attribute' => $customGenerator->someValue()\r\n    ];\r\n});\r\n```\r\n\r\nAlso, the function `Factory::raw()` was not compatible with the change in #9387, so it was fixed.\r\n","created_at":"2015-08-16T23:38:12Z","updated_at":"2015-08-17T16:10:55Z","closed_at":"2015-08-17T16:10:55Z","merged_at":null,"merge_commit_sha":"f851ec70a559eccb26876fbab4f650cb37070d44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9956/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9956/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9956/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/577d4b25cfbb2a15d24dbff519d88a887f63ca09","head":{"label":"dan-har:dependency-injection-model-factories","ref":"dependency-injection-model-factories","sha":"577d4b25cfbb2a15d24dbff519d88a887f63ca09","user":{"login":"dan-har","id":8581476,"avatar_url":"https://avatars.githubusercontent.com/u/8581476?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-har","html_url":"https://github.com/dan-har","followers_url":"https://api.github.com/users/dan-har/followers","following_url":"https://api.github.com/users/dan-har/following{/other_user}","gists_url":"https://api.github.com/users/dan-har/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-har/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-har/subscriptions","organizations_url":"https://api.github.com/users/dan-har/orgs","repos_url":"https://api.github.com/users/dan-har/repos","events_url":"https://api.github.com/users/dan-har/events{/privacy}","received_events_url":"https://api.github.com/users/dan-har/received_events","type":"User","site_admin":false},"repo":{"id":40841884,"name":"framework","full_name":"dan-har/framework","owner":{"login":"dan-har","id":8581476,"avatar_url":"https://avatars.githubusercontent.com/u/8581476?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-har","html_url":"https://github.com/dan-har","followers_url":"https://api.github.com/users/dan-har/followers","following_url":"https://api.github.com/users/dan-har/following{/other_user}","gists_url":"https://api.github.com/users/dan-har/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-har/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-har/subscriptions","organizations_url":"https://api.github.com/users/dan-har/orgs","repos_url":"https://api.github.com/users/dan-har/repos","events_url":"https://api.github.com/users/dan-har/events{/privacy}","received_events_url":"https://api.github.com/users/dan-har/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dan-har/framework","description":"","fork":true,"url":"https://api.github.com/repos/dan-har/framework","forks_url":"https://api.github.com/repos/dan-har/framework/forks","keys_url":"https://api.github.com/repos/dan-har/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dan-har/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dan-har/framework/teams","hooks_url":"https://api.github.com/repos/dan-har/framework/hooks","issue_events_url":"https://api.github.com/repos/dan-har/framework/issues/events{/number}","events_url":"https://api.github.com/repos/dan-har/framework/events","assignees_url":"https://api.github.com/repos/dan-har/framework/assignees{/user}","branches_url":"https://api.github.com/repos/dan-har/framework/branches{/branch}","tags_url":"https://api.github.com/repos/dan-har/framework/tags","blobs_url":"https://api.github.com/repos/dan-har/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dan-har/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dan-har/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dan-har/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dan-har/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/dan-har/framework/languages","stargazers_url":"https://api.github.com/repos/dan-har/framework/stargazers","contributors_url":"https://api.github.com/repos/dan-har/framework/contributors","subscribers_url":"https://api.github.com/repos/dan-har/framework/subscribers","subscription_url":"https://api.github.com/repos/dan-har/framework/subscription","commits_url":"https://api.github.com/repos/dan-har/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dan-har/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dan-har/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dan-har/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dan-har/framework/contents/{+path}","compare_url":"https://api.github.com/repos/dan-har/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dan-har/framework/merges","archive_url":"https://api.github.com/repos/dan-har/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dan-har/framework/downloads","issues_url":"https://api.github.com/repos/dan-har/framework/issues{/number}","pulls_url":"https://api.github.com/repos/dan-har/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/dan-har/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/dan-har/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dan-har/framework/labels{/name}","releases_url":"https://api.github.com/repos/dan-har/framework/releases{/id}","created_at":"2015-08-16T21:23:28Z","updated_at":"2015-08-16T21:23:31Z","pushed_at":"2015-08-17T11:10:04Z","git_url":"git://github.com/dan-har/framework.git","ssh_url":"git@github.com:dan-har/framework.git","clone_url":"https://github.com/dan-har/framework.git","svn_url":"https://github.com/dan-har/framework","homepage":"http://laravel.com","size":18078,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:master","ref":"master","sha":"7a23e3790eb4793cc8abcac644a49f43af12f77e","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-08-17T12:26:50Z","pushed_at":"2015-08-17T16:07:56Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":66025,"stargazers_count":3925,"watchers_count":3925,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2235,"mirror_url":null,"open_issues_count":76,"forks":2235,"open_issues":76,"watchers":3925,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9956"},"html":{"href":"https://github.com/laravel/framework/pull/9956"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9956"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9956/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9956/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9956/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/577d4b25cfbb2a15d24dbff519d88a887f63ca09"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":3,"commits":3,"additions":33,"deletions":12,"changed_files":3}}