{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18690","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18690/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18690/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18690/events","html_url":"https://github.com/kubernetes/kubernetes/pull/18690","id":122184397,"number":18690,"title":"Teach kubelet about CNI bridge plugins","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500"}],"state":"open","locked":false,"assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"comments":30,"created_at":"2015-12-15T03:19:19Z","updated_at":"2015-12-16T18:38:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18690","html_url":"https://github.com/kubernetes/kubernetes/pull/18690","diff_url":"https://github.com/kubernetes/kubernetes/pull/18690.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18690.patch"},"body":"This pr teaches the kubelet to write out a bridge plugin net.conf after the node controller has assigned it a podcidr. The goal is to teach the kubelet to pick a plugin based on \r\n--network-plugin=net.alph.kubernetes.io/plugin-type, by invoking a kubernetes meta-plugin and passing it plugin-type. \r\n\r\nDependencies: https://github.com/kubernetes/kubernetes/pull/18682, https://github.com/kubernetes/kubernetes/pull/18672, https://github.com/appc/cni/issues/88\r\nRef https://github.com/kubernetes/kubernetes/issues/17795"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/165206542","html_url":"https://github.com/kubernetes/kubernetes/pull/18690#issuecomment-165206542","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18690","id":165206542,"user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T18:38:47Z","updated_at":"2015-12-16T18:38:47Z","body":"I have a handful of relatively minor points, which could be done in a fixup.  My biggest concern is this:  Given the VERY MUCH in-development state of this, should we merge it?  Or should we track it in a devel branch (yeah, rebase hell) and merge it when a lot of the fixups are done?  I'm worried about the collateral damage this might cause but also about the attractive nuisance that it will be if people use it and it is still very rigid and full of holes.\r\n\r\nAlternatively, maybe we can find a better way to \"ifdef\" logic like this out?  I'm going to patch it into my tree and play with it."}}