{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/35652439","id":35652439,"diff_hunk":"@@ -11,18 +11,18 @@ def self.load_defaults\n \n     self.transaction do\n       [\n-        self.set('administrator', N_(\"The default administrator email address\"), administrator),\n-        self.set('foreman_url', N_(\"URL where your Foreman instance is reachable (see also Provisioning > unattended_url)\"), foreman_url),\n-        self.set('email_reply_address', N_(\"Email reply address for emails that Foreman is sending\"), email_reply_address),\n-        self.set('email_subject_prefix', N_(\"Prefix to add to all outgoing email\"), '[foreman]'),\n-        self.set('send_welcome_email', N_(\"Send a welcome email including username and URL to new users\"), false),\n-        self.set('entries_per_page', N_(\"Number of records shown per page in Foreman\"), 20),\n-        self.set('fix_db_cache', N_('Fix DB cache on next Foreman restart'), false),\n-        self.set('max_trend', N_(\"Max days for Trends graphs\"), 30),\n-        self.set('use_gravatar', N_(\"Foreman will use gravatar to display user icons\"), false),\n-        self.set('db_pending_migration', N_(\"Should the `foreman-rake db:migrate` be executed on the next run of the installer modules?\"), true),\n-        self.set('db_pending_seed', N_(\"Should the `foreman-rake db:seed` be executed on the next run of the installer modules?\"), true),\n-        self.set('proxy_request_timeout', N_(\"Max timeout for REST client requests to smart-proxy\"), 60)\n+        self.set('administrator', N_(\"The default administrator email address\"), administrator, N_('Administrator email')),","path":"app/models/setting/general.rb","position":16,"original_position":16,"commit_id":"48467e1bcb2c28ba57f93b9c41cddd06ca19482d","original_commit_id":"48467e1bcb2c28ba57f93b9c41cddd06ca19482d","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"add \"address\" to the end for consistency with the reply-to setting","created_at":"2015-07-28T14:20:25Z","updated_at":"2015-07-28T14:20:25Z","html_url":"https://github.com/theforeman/foreman/pull/2499#discussion_r35652439","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2499","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/35652439"},"html":{"href":"https://github.com/theforeman/foreman/pull/2499#discussion_r35652439"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2499"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2499","id":38847643,"html_url":"https://github.com/theforeman/foreman/pull/2499","diff_url":"https://github.com/theforeman/foreman/pull/2499.diff","patch_url":"https://github.com/theforeman/foreman/pull/2499.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2499","number":2499,"state":"open","locked":false,"title":"Fixes #7167 - names of settings marked for translation","user":{"login":"xprazak2","id":2664090,"avatar_url":"https://avatars.githubusercontent.com/u/2664090?v=3","gravatar_id":"","url":"https://api.github.com/users/xprazak2","html_url":"https://github.com/xprazak2","followers_url":"https://api.github.com/users/xprazak2/followers","following_url":"https://api.github.com/users/xprazak2/following{/other_user}","gists_url":"https://api.github.com/users/xprazak2/gists{/gist_id}","starred_url":"https://api.github.com/users/xprazak2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xprazak2/subscriptions","organizations_url":"https://api.github.com/users/xprazak2/orgs","repos_url":"https://api.github.com/users/xprazak2/repos","events_url":"https://api.github.com/users/xprazak2/events{/privacy}","received_events_url":"https://api.github.com/users/xprazak2/received_events","type":"User","site_admin":false},"body":"Names of settings are extracted form db into locale/setting_names.rb and may be replaced by short strings during translation. Marking underscored names in Setting:: classes is not enough since a couple of names were changed in migrations. ","created_at":"2015-06-30T06:56:57Z","updated_at":"2015-07-28T14:20:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc2bf554be7fa7db94080988e8a4931291e32278","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2499/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2499/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2499/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/48467e1bcb2c28ba57f93b9c41cddd06ca19482d","head":{"label":"xprazak2:settings-int","ref":"settings-int","sha":"48467e1bcb2c28ba57f93b9c41cddd06ca19482d","user":{"login":"xprazak2","id":2664090,"avatar_url":"https://avatars.githubusercontent.com/u/2664090?v=3","gravatar_id":"","url":"https://api.github.com/users/xprazak2","html_url":"https://github.com/xprazak2","followers_url":"https://api.github.com/users/xprazak2/followers","following_url":"https://api.github.com/users/xprazak2/following{/other_user}","gists_url":"https://api.github.com/users/xprazak2/gists{/gist_id}","starred_url":"https://api.github.com/users/xprazak2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xprazak2/subscriptions","organizations_url":"https://api.github.com/users/xprazak2/orgs","repos_url":"https://api.github.com/users/xprazak2/repos","events_url":"https://api.github.com/users/xprazak2/events{/privacy}","received_events_url":"https://api.github.com/users/xprazak2/received_events","type":"User","site_admin":false},"repo":{"id":33602529,"name":"foreman","full_name":"xprazak2/foreman","owner":{"login":"xprazak2","id":2664090,"avatar_url":"https://avatars.githubusercontent.com/u/2664090?v=3","gravatar_id":"","url":"https://api.github.com/users/xprazak2","html_url":"https://github.com/xprazak2","followers_url":"https://api.github.com/users/xprazak2/followers","following_url":"https://api.github.com/users/xprazak2/following{/other_user}","gists_url":"https://api.github.com/users/xprazak2/gists{/gist_id}","starred_url":"https://api.github.com/users/xprazak2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xprazak2/subscriptions","organizations_url":"https://api.github.com/users/xprazak2/orgs","repos_url":"https://api.github.com/users/xprazak2/repos","events_url":"https://api.github.com/users/xprazak2/events{/privacy}","received_events_url":"https://api.github.com/users/xprazak2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xprazak2/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/xprazak2/foreman","forks_url":"https://api.github.com/repos/xprazak2/foreman/forks","keys_url":"https://api.github.com/repos/xprazak2/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xprazak2/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xprazak2/foreman/teams","hooks_url":"https://api.github.com/repos/xprazak2/foreman/hooks","issue_events_url":"https://api.github.com/repos/xprazak2/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/xprazak2/foreman/events","assignees_url":"https://api.github.com/repos/xprazak2/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/xprazak2/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/xprazak2/foreman/tags","blobs_url":"https://api.github.com/repos/xprazak2/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xprazak2/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xprazak2/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/xprazak2/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xprazak2/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/xprazak2/foreman/languages","stargazers_url":"https://api.github.com/repos/xprazak2/foreman/stargazers","contributors_url":"https://api.github.com/repos/xprazak2/foreman/contributors","subscribers_url":"https://api.github.com/repos/xprazak2/foreman/subscribers","subscription_url":"https://api.github.com/repos/xprazak2/foreman/subscription","commits_url":"https://api.github.com/repos/xprazak2/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/xprazak2/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/xprazak2/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/xprazak2/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/xprazak2/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/xprazak2/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xprazak2/foreman/merges","archive_url":"https://api.github.com/repos/xprazak2/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xprazak2/foreman/downloads","issues_url":"https://api.github.com/repos/xprazak2/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/xprazak2/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/xprazak2/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/xprazak2/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xprazak2/foreman/labels{/name}","releases_url":"https://api.github.com/repos/xprazak2/foreman/releases{/id}","created_at":"2015-04-08T11:23:52Z","updated_at":"2015-04-08T11:23:58Z","pushed_at":"2015-07-28T11:27:27Z","git_url":"git://github.com/xprazak2/foreman.git","ssh_url":"git@github.com:xprazak2/foreman.git","clone_url":"https://github.com/xprazak2/foreman.git","svn_url":"https://github.com/xprazak2/foreman","homepage":"http://theforeman.org","size":34449,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"c1c9649b1370918e4c9c8d9aa2d9456742eac733","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-07-28T02:18:13Z","pushed_at":"2015-07-28T13:28:52Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":87691,"stargazers_count":810,"watchers_count":810,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":415,"mirror_url":null,"open_issues_count":88,"forks":415,"open_issues":88,"watchers":810,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2499"},"html":{"href":"https://github.com/theforeman/foreman/pull/2499"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2499"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2499/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2499/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2499/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/48467e1bcb2c28ba57f93b9c41cddd06ca19482d"}}}}