{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/workflow-plugin/issues/39","labels_url":"https://api.github.com/repos/jenkinsci/workflow-plugin/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-plugin/issues/39/comments","events_url":"https://api.github.com/repos/jenkinsci/workflow-plugin/issues/39/events","html_url":"https://github.com/jenkinsci/workflow-plugin/pull/39","id":54595047,"number":39,"title":"[FIXED JENKINS-26104] \"mail\" step","user":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?v=3","gravatar_id":"","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-16T16:31:47Z","updated_at":"2015-01-24T11:37:24Z","closed_at":"2015-01-23T21:55:22Z","pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-plugin/pulls/39","html_url":"https://github.com/jenkinsci/workflow-plugin/pull/39","diff_url":"https://github.com/jenkinsci/workflow-plugin/pull/39.diff","patch_url":"https://github.com/jenkinsci/workflow-plugin/pull/39.patch"},"body":"See [JENKINS-26104](https://issues.jenkins-ci.org/browse/JENKINS-26104).\r\n\r\nDrags in a dep on the mailer-plugin to get MimeMessageBuilder (currrently 1.13-SNAPSHOT but will obviously be 1.13 once we release the mailer-plugin changes for [JENKINS-23074](https://issues.jenkins-ci.org/browse/JENKINS-23074)).\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-plugin/issues/comments/71312645","html_url":"https://github.com/jenkinsci/workflow-plugin/pull/39#issuecomment-71312645","issue_url":"https://api.github.com/repos/jenkinsci/workflow-plugin/issues/39","id":71312645,"user":{"login":"reviewbybees","id":10512980,"avatar_url":"https://avatars.githubusercontent.com/u/10512980?v=3","gravatar_id":"","url":"https://api.github.com/users/reviewbybees","html_url":"https://github.com/reviewbybees","followers_url":"https://api.github.com/users/reviewbybees/followers","following_url":"https://api.github.com/users/reviewbybees/following{/other_user}","gists_url":"https://api.github.com/users/reviewbybees/gists{/gist_id}","starred_url":"https://api.github.com/users/reviewbybees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reviewbybees/subscriptions","organizations_url":"https://api.github.com/users/reviewbybees/orgs","repos_url":"https://api.github.com/users/reviewbybees/repos","events_url":"https://api.github.com/users/reviewbybees/events{/privacy}","received_events_url":"https://api.github.com/users/reviewbybees/received_events","type":"User","site_admin":false},"created_at":"2015-01-24T11:37:24Z","updated_at":"2015-01-24T11:37:24Z","body":"I prefer to rebase *and* then do an explicit merge commit... Unless it's a single commit that you are merging.\r\n\r\nFor medium to large changes I dislike squashing to a single commit as you don't see how it was developed and code review becomes big-bang rather than incremental\r\n\r\nSent from my iPhone\r\n\r\n> On 24 Jan 2015, at 10:27, Tom Fennelly <notifications@github.com> wrote:\r\n> \r\n> @jglick oops I didn't realise that was a sin, sorry.\r\n> \r\n> It's kinda funny. Last place I worked, you'd get your b**ls handed to you in a jar if you didn't git pull --rebase ... before pushing changes to a project. It was more or less universally considered bad to just merge due of the ugly history that was left after. Doctors differ and patients die :)\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> \r\n> -- \r\n> You received this message because you are subscribed to the Google Groups \"engineering-code-reviews\" group.\r\n> To unsubscribe from this group and stop receiving emails from it, send an email to engineering-code-reviews+unsubscribe@cloudbees.com.\r\n> To post to this group, send email to engineering-code-reviews@cloudbees.com.\r\n> To view this discussion on the web visit https://groups.google.com/a/cloudbees.com/d/msgid/engineering-code-reviews/jenkinsci/workflow-plugin/pull/39/c71309629%40github.com."}}