{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/39354774","id":39354774,"diff_hunk":"@@ -40,7 +40,7 @@ public void InheritanceTest03()\n         }\r\n \r\n         [Test]\r\n-        [Category(\"DSDefinedClass\")]\r\n+        [Category(\"DSDefinedClass_Ignored_DoNotTestInheritance\")]\r","path":"test/Engine/ProtoTest/Associative/Inheritance.cs","position":32,"original_position":32,"commit_id":"7dfc83f2e37bb951d849259264721f8d24e55543","original_commit_id":"7dfc83f2e37bb951d849259264721f8d24e55543","user":{"login":"lukechurch","id":2978182,"avatar_url":"https://avatars.githubusercontent.com/u/2978182?v=3","gravatar_id":"","url":"https://api.github.com/users/lukechurch","html_url":"https://github.com/lukechurch","followers_url":"https://api.github.com/users/lukechurch/followers","following_url":"https://api.github.com/users/lukechurch/following{/other_user}","gists_url":"https://api.github.com/users/lukechurch/gists{/gist_id}","starred_url":"https://api.github.com/users/lukechurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukechurch/subscriptions","organizations_url":"https://api.github.com/users/lukechurch/orgs","repos_url":"https://api.github.com/users/lukechurch/repos","events_url":"https://api.github.com/users/lukechurch/events{/privacy}","received_events_url":"https://api.github.com/users/lukechurch/received_events","type":"User","site_admin":false},"body":"I'm sorry, if you want me to review this, I'm going to need a more intelligable diff than this!","created_at":"2015-09-14T00:31:30Z","updated_at":"2015-09-14T00:31:30Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/5251#discussion_r39354774","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/39354774"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5251#discussion_r39354774"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251","id":44412957,"html_url":"https://github.com/DynamoDS/Dynamo/pull/5251","diff_url":"https://github.com/DynamoDS/Dynamo/pull/5251.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/5251.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5251","number":5251,"state":"open","locked":false,"title":"Port ds class test","user":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"body":"### Purpose\r\nPorting/Rewriting DS defined classes to remove the DS class and only focus on the specific test.\r\nThis is submission 1/14\r\n\r\nRefer to this top level task:\r\nhttp://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8343\r\n\r\nSee the guidlines:\r\nA test that uses a DS defined class should be re-written such that the DS defined class is removed.\r\nThis means doing one or a combination of the following:\r\n1 Write an FFI class to replace the DS defined class\r\n2 Remove the DS class if it is not necessary\r\n3 Remove verification that is unncecessary\r\n4 Rename the test appropriately if needed\r\n5 If a test is ported, modify the category from DSDefineClass to DSDefineClass_Ported\r\n6 If a test is NOT ported, modify the category from DSDefineClass to DSDefineClass_Ignored_SomeDecriptionHere\r\n7 At the end of the class porting task, the only categories left should be DSDefineClass_Ported and DSDefineClass_Ignored. \r\n8 There should be no regressions is these tasks. Tests that must be removed completely will be done at the end of the porting /rewriting task\r\n\r\n\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [X] The code base is in a better state after this PR\r\n- [x] The level of testing this PR includes is appropriate\r\n\r\n### Reviewers\r\n\r\n@lukechurch \r\n\r\n","created_at":"2015-09-08T09:57:15Z","updated_at":"2015-09-14T00:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50869f7d69b21747027c7fe248e98e8b7f326623","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5251/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/7dfc83f2e37bb951d849259264721f8d24e55543","head":{"label":"junmendoza:PortDSClassTest","ref":"PortDSClassTest","sha":"7dfc83f2e37bb951d849259264721f8d24e55543","user":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"repo":{"id":11733064,"name":"Dynamo","full_name":"junmendoza/Dynamo","owner":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junmendoza/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/junmendoza/Dynamo","forks_url":"https://api.github.com/repos/junmendoza/Dynamo/forks","keys_url":"https://api.github.com/repos/junmendoza/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junmendoza/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junmendoza/Dynamo/teams","hooks_url":"https://api.github.com/repos/junmendoza/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/junmendoza/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/junmendoza/Dynamo/events","assignees_url":"https://api.github.com/repos/junmendoza/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/junmendoza/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/junmendoza/Dynamo/tags","blobs_url":"https://api.github.com/repos/junmendoza/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junmendoza/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junmendoza/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/junmendoza/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junmendoza/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/junmendoza/Dynamo/languages","stargazers_url":"https://api.github.com/repos/junmendoza/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/junmendoza/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/junmendoza/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/junmendoza/Dynamo/subscription","commits_url":"https://api.github.com/repos/junmendoza/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/junmendoza/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/junmendoza/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/junmendoza/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/junmendoza/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/junmendoza/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junmendoza/Dynamo/merges","archive_url":"https://api.github.com/repos/junmendoza/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junmendoza/Dynamo/downloads","issues_url":"https://api.github.com/repos/junmendoza/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/junmendoza/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/junmendoza/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/junmendoza/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junmendoza/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/junmendoza/Dynamo/releases{/id}","created_at":"2013-07-29T06:47:14Z","updated_at":"2015-03-04T08:56:05Z","pushed_at":"2015-09-10T10:36:02Z","git_url":"git://github.com/junmendoza/Dynamo.git","ssh_url":"git@github.com:junmendoza/Dynamo.git","clone_url":"https://github.com/junmendoza/Dynamo.git","svn_url":"https://github.com/junmendoza/Dynamo","homepage":"http://dynamobim.org","size":862017,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"0d4c12f95c4458882eb54ec76aa32caf6bb62b25","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-09-07T10:28:42Z","pushed_at":"2015-09-13T10:07:31Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1033226,"stargazers_count":256,"watchers_count":256,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":199,"mirror_url":null,"open_issues_count":738,"forks":199,"open_issues":738,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5251"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5251"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5251/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5251/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/7dfc83f2e37bb951d849259264721f8d24e55543"}}}}