{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/comments/29066903","id":29066903,"diff_hunk":"@@ -185,6 +245,24 @@\n               });\n           }\n           \n+          var searchUsersLastName = function(searchTerm){          \n+            return $http.get('/portal/api/people.json?searchTerms%5B%5D=sn&sn=' + searchTerm).success(","path":"my-profile-webapp/src/main/webapp/my-app.js","position":128,"original_position":128,"commit_id":"49a404bb11fba7cf14334c8788ade75159adbdc0","original_commit_id":"49a404bb11fba7cf14334c8788ade75159adbdc0","user":{"login":"vertein","id":5521429,"avatar_url":"https://avatars.githubusercontent.com/u/5521429?v=3","gravatar_id":"","url":"https://api.github.com/users/vertein","html_url":"https://github.com/vertein","followers_url":"https://api.github.com/users/vertein/followers","following_url":"https://api.github.com/users/vertein/following{/other_user}","gists_url":"https://api.github.com/users/vertein/gists{/gist_id}","starred_url":"https://api.github.com/users/vertein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertein/subscriptions","organizations_url":"https://api.github.com/users/vertein/orgs","repos_url":"https://api.github.com/users/vertein/repos","events_url":"https://api.github.com/users/vertein/events{/privacy}","received_events_url":"https://api.github.com/users/vertein/received_events","type":"User","site_admin":false},"body":"Yep.  The webservice, portal in this case, handles it's own security logic about who should see which users (funky).  Since you need a portal session, this authenticates you as you and only you and then does the security around some uPortal rules.  I think this is fitting that the webservice is doing it's own security (kind of).  I tried calling the webservice as a non-admin in production and it sends back the correct responses, non-test tiers, portal seems to throw caution to the wind and allow anyone to lookup any user.  Weird, yes.  Funky security, yes.  I agree with your next comment about this not being the biggest deal.  When we get our real service, we'll have the opportunity to use spring security at that point.","created_at":"2015-04-24T17:15:48Z","updated_at":"2015-04-24T17:15:48Z","html_url":"https://github.com/UW-Madison-DoIT/my-profile/pull/4#discussion_r29066903","pull_request_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/comments/29066903"},"html":{"href":"https://github.com/UW-Madison-DoIT/my-profile/pull/4#discussion_r29066903"},"pull_request":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4","id":34055703,"html_url":"https://github.com/UW-Madison-DoIT/my-profile/pull/4","diff_url":"https://github.com/UW-Madison-DoIT/my-profile/pull/4.diff","patch_url":"https://github.com/UW-Madison-DoIT/my-profile/pull/4.patch","issue_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/4","number":4,"state":"open","locked":false,"title":"Search by last name","user":{"login":"vertein","id":5521429,"avatar_url":"https://avatars.githubusercontent.com/u/5521429?v=3","gravatar_id":"","url":"https://api.github.com/users/vertein","html_url":"https://github.com/vertein","followers_url":"https://api.github.com/users/vertein/followers","following_url":"https://api.github.com/users/vertein/following{/other_user}","gists_url":"https://api.github.com/users/vertein/gists{/gist_id}","starred_url":"https://api.github.com/users/vertein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertein/subscriptions","organizations_url":"https://api.github.com/users/vertein/orgs","repos_url":"https://api.github.com/users/vertein/repos","events_url":"https://api.github.com/users/vertein/events{/privacy}","received_events_url":"https://api.github.com/users/vertein/received_events","type":"User","site_admin":false},"body":"Searches for users based on last name or netid.  Then adds a click to the user row to fetch and display the user's local contact information.\r\n\r\nScreenshots from my-test environment (testable there for the duration of this pr).\r\n\r\nInitial Screen:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7320200/8d0ccfa6-ea60-11e4-8ed9-36c2a0db8b34.png)\r\n\r\nSearch Results:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7320220/ac8ab32a-ea60-11e4-86c3-d9d8e8e34c13.png)\r\n\r\nNo Search Results (taken from local host, because test users feed always returns some user):\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7320576/0c19a63c-ea63-11e4-9c00-ae4cfee225d3.png)\r\n\r\nMultiple Search Results:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7320608/408b7116-ea63-11e4-9369-38bf1caebf7d.png)\r\n\r\nMultiple Search Results after clicking load more and reaching end.  Load works in increments of ten:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7320641/7c14ae46-ea63-11e4-89ba-382cd102dada.png)\r\n\r\nAfter clicking the row (entire row is clickable) and there is a local contact info:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7320675/ae36e592-ea63-11e4-8202-e86f86ffe6ef.png)\r\n\r\nAfter clicking row and no local contact info available:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7321294/ee1d6516-ea66-11e4-8e44-af7d396b247f.png)\r\n\r\n","created_at":"2015-04-24T14:55:03Z","updated_at":"2015-04-24T17:15:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83ff7f3b869dff88cc17b7e36211e11e48f4373d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4/commits","review_comments_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4/comments","review_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/4/comments","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/statuses/49a404bb11fba7cf14334c8788ade75159adbdc0","head":{"label":"UW-Madison-DoIT:searchByLastName","ref":"searchByLastName","sha":"49a404bb11fba7cf14334c8788ade75159adbdc0","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":29696774,"name":"my-profile","full_name":"UW-Madison-DoIT/my-profile","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/my-profile","description":"","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/releases{/id}","created_at":"2015-01-22T19:46:17Z","updated_at":"2015-04-02T15:00:11Z","pushed_at":"2015-04-24T15:37:41Z","git_url":"git://github.com/UW-Madison-DoIT/my-profile.git","ssh_url":"git@github.com:UW-Madison-DoIT/my-profile.git","clone_url":"https://github.com/UW-Madison-DoIT/my-profile.git","svn_url":"https://github.com/UW-Madison-DoIT/my-profile","homepage":null,"size":564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"UW-Madison-DoIT:master","ref":"master","sha":"0ca964a0f0bd188cae9099f4f589918d0e3c9800","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":29696774,"name":"my-profile","full_name":"UW-Madison-DoIT/my-profile","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/my-profile","description":"","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/releases{/id}","created_at":"2015-01-22T19:46:17Z","updated_at":"2015-04-02T15:00:11Z","pushed_at":"2015-04-24T15:37:41Z","git_url":"git://github.com/UW-Madison-DoIT/my-profile.git","ssh_url":"git@github.com:UW-Madison-DoIT/my-profile.git","clone_url":"https://github.com/UW-Madison-DoIT/my-profile.git","svn_url":"https://github.com/UW-Madison-DoIT/my-profile","homepage":null,"size":564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4"},"html":{"href":"https://github.com/UW-Madison-DoIT/my-profile/pull/4"},"issue":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/4"},"comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Madison-DoIT/my-profile/statuses/49a404bb11fba7cf14334c8788ade75159adbdc0"}}}}