{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7709","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7709/labels{/name}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7709/comments","events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7709/events","html_url":"https://github.com/OpenRA/OpenRA/pull/7709","id":63551638,"number":7709,"title":"Added checks for missing sequence entries","user":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=3","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenRA/OpenRA/labels/PR:%20Needs%20+2","name":"PR: Needs +2","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-03-22T16:41:03Z","updated_at":"2015-06-20T15:13:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7709","html_url":"https://github.com/OpenRA/OpenRA/pull/7709","diff_url":"https://github.com/OpenRA/OpenRA/pull/7709.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/7709.patch"},"body":"Closes #2283.\r\n\r\nI experienced two crashes recently: \r\n* The sietch not having make animations while testing #4496.\r\n* Deployed Tiberian Sun units not having death animations, a regression from https://github.com/OpenRA/OpenRA/pull/7687.\r\n\r\nI extended the rule to also cover sequence definition on the actor from all traits (including overlays) and discovered some more inconsistencies in seldom used units. Also took some effort to clean things up."},"comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/113778908","html_url":"https://github.com/OpenRA/OpenRA/pull/7709#issuecomment-113778908","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7709","id":113778908,"user":{"login":"obrakmann","id":4331210,"avatar_url":"https://avatars.githubusercontent.com/u/4331210?v=3","gravatar_id":"","url":"https://api.github.com/users/obrakmann","html_url":"https://github.com/obrakmann","followers_url":"https://api.github.com/users/obrakmann/followers","following_url":"https://api.github.com/users/obrakmann/following{/other_user}","gists_url":"https://api.github.com/users/obrakmann/gists{/gist_id}","starred_url":"https://api.github.com/users/obrakmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrakmann/subscriptions","organizations_url":"https://api.github.com/users/obrakmann/orgs","repos_url":"https://api.github.com/users/obrakmann/repos","events_url":"https://api.github.com/users/obrakmann/events{/privacy}","received_events_url":"https://api.github.com/users/obrakmann/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T15:13:42Z","updated_at":"2015-06-20T15:13:42Z","body":"Got this when attacking with a zombie:\r\n\r\n```\r\nException of type `System.ArgumentNullException`: Argument cannot be null.\r\nParameter name: key\r\n  at System.ThrowHelper.ThrowArgumentNullException (ExceptionArgument argument) [0x00000] in <filename unknown>:0 \r\n  at System.Collections.Generic.Dictionary`2[System.String,OpenRA.Graphics.ISpriteSequence].FindEntry (System.String key) [0x00000] in <filename unknown>:0 \r\n  at System.Collections.Generic.Dictionary`2[System.String,OpenRA.Graphics.ISpriteSequence].ContainsKey (System.String key) [0x00000] in <filename unknown>:0 \r\n  at OpenRA.ReadOnlyDictionary`2[System.String,OpenRA.Graphics.ISpriteSequence].ContainsKey (System.String key) [0x00008] in /home/oliver/devel/openra/git/OpenRA.Game/Primitives/ReadOnlyDictionary.cs:67 \r\n  at OpenRA.Graphics.SequenceProvider.HasSequence (System.String unitName, System.String sequenceName) [0x0003a] in /home/oliver/devel/openra/git/OpenRA.Game/Graphics/SequenceProvider.cs:81 \r\n  at OpenRA.Graphics.Animation.HasSequence (System.String seq) [0x0000e] in /home/oliver/devel/openra/git/OpenRA.Game/Graphics/Animation.cs:169 \r\n  at OpenRA.Mods.Common.Traits.WithInfantryBody.Attacking (OpenRA.Actor self, Target target) [0x00020] in /home/oliver/devel/openra/git/OpenRA.Mods.Common/Traits/Render/WithInfantryBody.cs:98 \r\n  at OpenRA.Mods.Common.Traits.WithInfantryBody.Attacking (OpenRA.Actor self, Target target, OpenRA.Mods.Common.Traits.Armament a, OpenRA.Mods.Common.Traits.Barrel barrel) [0x00004] in /home/oliver/devel/openra/git/OpenRA.Mods.Common/Traits/Render/WithInfantryBody.cs:104 \r\n```\r\n\r\nBoth ants and zombies are missing the proper `AttackSequence` in `WithInfantryBody`."}}