{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/35481447","id":35481447,"diff_hunk":"@@ -246,4 +248,57 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {\n     }\n   }\n \n+  test(\"date_add\") {\n+    checkEvaluation(\n+      DateAdd(Literal(Date.valueOf(\"2016-02-28\")), Literal(1)),\n+      DateTimeUtils.fromJavaDate(Date.valueOf(\"2016-02-29\")))\n+    checkEvaluation(\n+      DateAdd(Literal(Date.valueOf(\"2016-02-28\")), Literal(-365)),\n+      DateTimeUtils.fromJavaDate(Date.valueOf(\"2015-02-28\")))\n+  }\n+\n+  test(\"date_sub\") {\n+    checkEvaluation(\n+      DateSub(Literal(Date.valueOf(\"2015-01-01\")), Literal(1)),\n+      DateTimeUtils.fromJavaDate(Date.valueOf(\"2014-12-31\")))\n+    checkEvaluation(\n+      DateSub(Literal(Date.valueOf(\"2015-01-01\")), Literal(-1)),\n+      DateTimeUtils.fromJavaDate(Date.valueOf(\"2015-01-02\")))\n+  }\n+\n+  test(\"time_add\") {\n+    checkEvaluation(\n+      TimeAdd(Literal(Date.valueOf(\"2016-01-29\")), Literal(new Interval(1, 0))),\n+      DateTimeUtils.fromJavaTimestamp(Timestamp.valueOf(\"2016-02-29 00:00:00\")))\n+    checkEvaluation(\n+      TimeAdd(Literal(Date.valueOf(\"2016-01-31\")), Literal(new Interval(1, 2000000.toLong))),\n+      DateTimeUtils.fromJavaTimestamp(Timestamp.valueOf(\"2016-02-29 00:00:02\")))\n+  }\n+\n+  test(\"time_sub\") {\n+    checkEvaluation(\n+      TimeSub(Literal(Timestamp.valueOf(\"2016-03-31 10:00:00\")), Literal(new Interval(1, 0))),\n+      DateTimeUtils.fromJavaTimestamp(Timestamp.valueOf(\"2016-02-29 10:00:00\")))\n+    checkEvaluation(\n+      TimeSub(\n+        Literal(Timestamp.valueOf(\"2016-03-30 00:00:01\")),\n+        Literal(new Interval(1, 2000000.toLong))),\n+      DateTimeUtils.fromJavaTimestamp(Timestamp.valueOf(\"2016-02-28 23:59:59\")))\n+  }\n+\n+  test(\"add_months\") {\n+    checkEvaluation(AddMonths(Literal(Date.valueOf(\n+      \"2015-01-30\")), Literal(1)), DateTimeUtils.fromJavaDate(Date.valueOf(\"2015-02-28\")))\n+    checkEvaluation(AddMonths(Literal(Date.valueOf(\n+      \"2016-03-30\")), Literal(-1)), DateTimeUtils.fromJavaDate(Date.valueOf(\"2016-02-29\")))\n+  }\n+\n+  test(\"months_between\") {\n+    checkEvaluation(MonthsBetween(Literal(Timestamp.valueOf(\n+      \"2015-01-30 11:52:00\")), Literal(Timestamp.valueOf(\"2015-01-30 11:50:00\"))), 0.0)\n+    checkEvaluation(MonthsBetween(Literal(Timestamp.valueOf(\n+      \"2015-01-31 00:00:00\")), Literal(Timestamp.valueOf(\"2015-03-31 22:00:00\"))), -2.0)\n+    checkEvaluation(MonthsBetween(Literal(Timestamp.valueOf(\n+      \"2015-03-31 22:00:00\")), Literal(Timestamp.valueOf(\"2015-02-28 00:00:00\"))), 1.0)","path":"sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala","position":65,"original_position":65,"commit_id":"e8a639aac79e945bdf2a52decc905360adfd625f","original_commit_id":"e8a639aac79e945bdf2a52decc905360adfd625f","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"body":"More test cast here to guarantee the behaviour of months_between. It's complicated and many conner cases exist I think","created_at":"2015-07-25T09:23:05Z","updated_at":"2015-07-25T09:23:05Z","html_url":"https://github.com/apache/spark/pull/7589#discussion_r35481447","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7589","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/35481447"},"html":{"href":"https://github.com/apache/spark/pull/7589#discussion_r35481447"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7589"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7589","id":40535858,"html_url":"https://github.com/apache/spark/pull/7589","diff_url":"https://github.com/apache/spark/pull/7589.diff","patch_url":"https://github.com/apache/spark/pull/7589.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7589","number":7589,"state":"open","locked":false,"title":"[SPARK-8186][SPARK-8187][SPARK-8194][SPARK-8198][SQL] functions: date_add, date_sub, add_months, months_between, time-interval calculation","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"body":"This subsumes #6782 ","created_at":"2015-07-22T07:04:35Z","updated_at":"2015-07-25T09:23:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ee3da9e3a3a2855dd22e0b0b9a8c35ebe740386","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7589/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7589/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7589/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e8a639aac79e945bdf2a52decc905360adfd625f","head":{"label":"adrian-wang:udfdatecal","ref":"udfdatecal","sha":"e8a639aac79e945bdf2a52decc905360adfd625f","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"repo":{"id":18545588,"name":"spark","full_name":"adrian-wang/spark","owner":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-wang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/adrian-wang/spark","forks_url":"https://api.github.com/repos/adrian-wang/spark/forks","keys_url":"https://api.github.com/repos/adrian-wang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-wang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-wang/spark/teams","hooks_url":"https://api.github.com/repos/adrian-wang/spark/hooks","issue_events_url":"https://api.github.com/repos/adrian-wang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-wang/spark/events","assignees_url":"https://api.github.com/repos/adrian-wang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-wang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-wang/spark/tags","blobs_url":"https://api.github.com/repos/adrian-wang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-wang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-wang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-wang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-wang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-wang/spark/languages","stargazers_url":"https://api.github.com/repos/adrian-wang/spark/stargazers","contributors_url":"https://api.github.com/repos/adrian-wang/spark/contributors","subscribers_url":"https://api.github.com/repos/adrian-wang/spark/subscribers","subscription_url":"https://api.github.com/repos/adrian-wang/spark/subscription","commits_url":"https://api.github.com/repos/adrian-wang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-wang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-wang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-wang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-wang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-wang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-wang/spark/merges","archive_url":"https://api.github.com/repos/adrian-wang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-wang/spark/downloads","issues_url":"https://api.github.com/repos/adrian-wang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-wang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-wang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-wang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-wang/spark/labels{/name}","releases_url":"https://api.github.com/repos/adrian-wang/spark/releases{/id}","created_at":"2014-04-08T04:42:25Z","updated_at":"2014-07-17T08:04:57Z","pushed_at":"2015-07-24T20:08:29Z","git_url":"git://github.com/adrian-wang/spark.git","ssh_url":"git@github.com:adrian-wang/spark.git","clone_url":"https://github.com/adrian-wang/spark.git","svn_url":"https://github.com/adrian-wang/spark","homepage":null,"size":110943,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c2b50d693e469558e3b3c9cbb9d76089d259b587","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-25T07:39:43Z","pushed_at":"2015-07-25T08:37:54Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1571849,"stargazers_count":4851,"watchers_count":4851,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4367,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":341,"forks":4367,"open_issues":341,"watchers":4851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7589"},"html":{"href":"https://github.com/apache/spark/pull/7589"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7589"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7589/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7589/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7589/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e8a639aac79e945bdf2a52decc905360adfd625f"}}}}