{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/37909047","id":37909047,"diff_hunk":"@@ -82,3 +82,28 @@ final case class GemsParameters(\n                      avgStrehl:           Double,\n                      strehlBand:          String)\n \n+\n+object InstrumentDetails {\n+\n+  // NOTE: This is similar to the code in ItcUniqueConfig which decides on imaging or spectroscopy setup\n+  // on Config elements. There should be a way to share this?","path":"bundle/edu.gemini.itc.shared/src/main/scala/edu/gemini/itc/shared/InstrumentDetails.scala","position":17,"original_position":17,"commit_id":"29a0729ba9e312d698483366bbc7c33795c273d7","original_commit_id":"29a0729ba9e312d698483366bbc7c33795c273d7","user":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"body":"Regarding this see also my comments in: http://jira.gemini.edu:8080/browse/OCSADV-267 . I agree that a next refactoring step with ITC could be to use the definition of a step from the SequenceModel NG as the input values.\r\n\r\nRegarding sealed: yeah, that surprised me, too. It compiles and works. The compiler produces a warning that the `case` statements with `MichelleParameters`/`TrecsParameters` can not be reached (because they are not defined in the `InstrumentDetails` code file, but everything works as expected. I will clean that up at some point, however Michelle and TReCS have no priority because they are not in use anymore.","created_at":"2015-08-25T19:36:29Z","updated_at":"2015-08-25T19:36:29Z","html_url":"https://github.com/gemini-hlsw/ocs/pull/528#discussion_r37909047","pull_request_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/37909047"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/528#discussion_r37909047"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528","id":43243522,"html_url":"https://github.com/gemini-hlsw/ocs/pull/528","diff_url":"https://github.com/gemini-hlsw/ocs/pull/528.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/528.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/528","number":528,"state":"open","locked":false,"title":"OCSADV-270: Detect instrument mode from configuration (imaging vs. spectroscopy)","user":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"body":"A small but really annoying usability nuisance that plagued users for a long time was, that users had to explicitly select a mode (imaging or spectroscopy) on the ITC web pages, although the mode is given by the instrument configuration, i.e. the absence or presence of a grating element.\r\n\r\nI promised Andy and others (including myself) to deal with this but never really got around to do it until now: the radio buttons for spectroscopy/imaging are gone on the HTML pages and the mode is deduced from the configuration.\r\n\r\nI also addressed some other minor issues:\r\n* One servlet to rule them all: the instrument specific servlets were not really useful, so I replaced them with a more generic calculation servlet that covers all instruments.\r\n* The servlet version numbers on the output pages (which were hardly ever updated and therefore not very useful) are gone; if a version number is needed, we should use the current ODB release version as the version number.\r\n* The spacer.gifs on the HTML pages showed on Chrome, a small change to the HTML makes sure they are always hidden.","created_at":"2015-08-25T02:26:24Z","updated_at":"2015-08-25T19:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8238fe859d2eae002f6077edcfe7aecbeb991086","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/528/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/29a0729ba9e312d698483366bbc7c33795c273d7","head":{"label":"fnussber:feature/OCSADV-270","ref":"feature/OCSADV-270","sha":"29a0729ba9e312d698483366bbc7c33795c273d7","user":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"repo":{"id":23975511,"name":"ocs","full_name":"fnussber/ocs","owner":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fnussber/ocs","description":"Gemini's Observatory Control System","fork":true,"url":"https://api.github.com/repos/fnussber/ocs","forks_url":"https://api.github.com/repos/fnussber/ocs/forks","keys_url":"https://api.github.com/repos/fnussber/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnussber/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnussber/ocs/teams","hooks_url":"https://api.github.com/repos/fnussber/ocs/hooks","issue_events_url":"https://api.github.com/repos/fnussber/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/fnussber/ocs/events","assignees_url":"https://api.github.com/repos/fnussber/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/fnussber/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/fnussber/ocs/tags","blobs_url":"https://api.github.com/repos/fnussber/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnussber/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnussber/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnussber/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnussber/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/fnussber/ocs/languages","stargazers_url":"https://api.github.com/repos/fnussber/ocs/stargazers","contributors_url":"https://api.github.com/repos/fnussber/ocs/contributors","subscribers_url":"https://api.github.com/repos/fnussber/ocs/subscribers","subscription_url":"https://api.github.com/repos/fnussber/ocs/subscription","commits_url":"https://api.github.com/repos/fnussber/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnussber/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnussber/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnussber/ocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnussber/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/fnussber/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnussber/ocs/merges","archive_url":"https://api.github.com/repos/fnussber/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnussber/ocs/downloads","issues_url":"https://api.github.com/repos/fnussber/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/fnussber/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/fnussber/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/fnussber/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnussber/ocs/labels{/name}","releases_url":"https://api.github.com/repos/fnussber/ocs/releases{/id}","created_at":"2014-09-12T20:20:20Z","updated_at":"2015-05-08T20:15:23Z","pushed_at":"2015-08-25T01:58:23Z","git_url":"git://github.com/fnussber/ocs.git","ssh_url":"git@github.com:fnussber/ocs.git","clone_url":"https://github.com/fnussber/ocs.git","svn_url":"https://github.com/fnussber/ocs","homepage":"","size":267559,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:develop","ref":"develop","sha":"43cbf2468540a30a779b0f02961c8cd104fe5ca6","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":23963494,"name":"ocs","full_name":"gemini-hlsw/ocs","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs","description":"Observatory Control Software","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs/releases{/id}","created_at":"2014-09-12T14:20:23Z","updated_at":"2015-07-13T13:36:36Z","pushed_at":"2015-08-25T14:24:05Z","git_url":"git://github.com/gemini-hlsw/ocs.git","ssh_url":"git@github.com:gemini-hlsw/ocs.git","clone_url":"https://github.com/gemini-hlsw/ocs.git","svn_url":"https://github.com/gemini-hlsw/ocs","homepage":"","size":274916,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/528"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/528"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/29a0729ba9e312d698483366bbc7c33795c273d7"}}}}