{"action":"opened","number":11030,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/11030","id":51188417,"html_url":"https://github.com/laravel/framework/pull/11030","diff_url":"https://github.com/laravel/framework/pull/11030.diff","patch_url":"https://github.com/laravel/framework/pull/11030.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/11030","number":11030,"state":"open","locked":false,"title":"Changes type casting to Swift's toString() method, enabling Exceptions","user":{"login":"xfxf","id":138684,"avatar_url":"https://avatars.githubusercontent.com/u/138684?v=3","gravatar_id":"","url":"https://api.github.com/users/xfxf","html_url":"https://github.com/xfxf","followers_url":"https://api.github.com/users/xfxf/followers","following_url":"https://api.github.com/users/xfxf/following{/other_user}","gists_url":"https://api.github.com/users/xfxf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxf/subscriptions","organizations_url":"https://api.github.com/users/xfxf/orgs","repos_url":"https://api.github.com/users/xfxf/repos","events_url":"https://api.github.com/users/xfxf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxf/received_events","type":"User","site_admin":false},"body":"Changes type casting used in raw_message to use Swift's built-in toString() method, allowing Exceptions to be properly thrown. This works around PHP's inability for __toString() to not throw an exception - see https://bugs.php.net/bug.php?id=53648\r\n\r\nI did this as I had an issue with some of my code, and I was only getting unhelpful errors such as exception 'Symfony\\Component\\Debug\\Exception\\FatalErrorException' with message 'Method Swift_Message::__toString() must not throw an exception' in /var/www/application/releases/release-last/vendor/laravel/framework/src/Illuminate/Mail/Transport/MandrillTransport.php:0 Stack trace: #0 [internal function]: Illuminate\\Exception\\Handler->handleShutdown() #1 {main} [] []\r\n\r\nWith this change, I'm now receiving useful exceptions detailing the actual problem.\r\n\r\nThis may be useful for later Laravel versions too as I see the same code in current master; I'm just stuck on 4.2 with this project so that's what this has been tested successfully with.","created_at":"2015-11-19T07:22:45Z","updated_at":"2015-11-19T07:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"490fa80fe9f7ff689164db89219d9fe98b52949e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/11030/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/11030/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/11030/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/846ed8e650ef0fe25bbf7042f0b1fe2824dcb1cc","head":{"label":"xfxf:4.2","ref":"4.2","sha":"846ed8e650ef0fe25bbf7042f0b1fe2824dcb1cc","user":{"login":"xfxf","id":138684,"avatar_url":"https://avatars.githubusercontent.com/u/138684?v=3","gravatar_id":"","url":"https://api.github.com/users/xfxf","html_url":"https://github.com/xfxf","followers_url":"https://api.github.com/users/xfxf/followers","following_url":"https://api.github.com/users/xfxf/following{/other_user}","gists_url":"https://api.github.com/users/xfxf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxf/subscriptions","organizations_url":"https://api.github.com/users/xfxf/orgs","repos_url":"https://api.github.com/users/xfxf/repos","events_url":"https://api.github.com/users/xfxf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxf/received_events","type":"User","site_admin":false},"repo":{"id":46474830,"name":"laravel-framework","full_name":"xfxf/laravel-framework","owner":{"login":"xfxf","id":138684,"avatar_url":"https://avatars.githubusercontent.com/u/138684?v=3","gravatar_id":"","url":"https://api.github.com/users/xfxf","html_url":"https://github.com/xfxf","followers_url":"https://api.github.com/users/xfxf/followers","following_url":"https://api.github.com/users/xfxf/following{/other_user}","gists_url":"https://api.github.com/users/xfxf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxf/subscriptions","organizations_url":"https://api.github.com/users/xfxf/orgs","repos_url":"https://api.github.com/users/xfxf/repos","events_url":"https://api.github.com/users/xfxf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xfxf/laravel-framework","description":"","fork":true,"url":"https://api.github.com/repos/xfxf/laravel-framework","forks_url":"https://api.github.com/repos/xfxf/laravel-framework/forks","keys_url":"https://api.github.com/repos/xfxf/laravel-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xfxf/laravel-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xfxf/laravel-framework/teams","hooks_url":"https://api.github.com/repos/xfxf/laravel-framework/hooks","issue_events_url":"https://api.github.com/repos/xfxf/laravel-framework/issues/events{/number}","events_url":"https://api.github.com/repos/xfxf/laravel-framework/events","assignees_url":"https://api.github.com/repos/xfxf/laravel-framework/assignees{/user}","branches_url":"https://api.github.com/repos/xfxf/laravel-framework/branches{/branch}","tags_url":"https://api.github.com/repos/xfxf/laravel-framework/tags","blobs_url":"https://api.github.com/repos/xfxf/laravel-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xfxf/laravel-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xfxf/laravel-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/xfxf/laravel-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xfxf/laravel-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/xfxf/laravel-framework/languages","stargazers_url":"https://api.github.com/repos/xfxf/laravel-framework/stargazers","contributors_url":"https://api.github.com/repos/xfxf/laravel-framework/contributors","subscribers_url":"https://api.github.com/repos/xfxf/laravel-framework/subscribers","subscription_url":"https://api.github.com/repos/xfxf/laravel-framework/subscription","commits_url":"https://api.github.com/repos/xfxf/laravel-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/xfxf/laravel-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/xfxf/laravel-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/xfxf/laravel-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/xfxf/laravel-framework/contents/{+path}","compare_url":"https://api.github.com/repos/xfxf/laravel-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xfxf/laravel-framework/merges","archive_url":"https://api.github.com/repos/xfxf/laravel-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xfxf/laravel-framework/downloads","issues_url":"https://api.github.com/repos/xfxf/laravel-framework/issues{/number}","pulls_url":"https://api.github.com/repos/xfxf/laravel-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/xfxf/laravel-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/xfxf/laravel-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xfxf/laravel-framework/labels{/name}","releases_url":"https://api.github.com/repos/xfxf/laravel-framework/releases{/id}","created_at":"2015-11-19T07:16:33Z","updated_at":"2015-11-19T07:17:01Z","pushed_at":"2015-11-19T07:21:46Z","git_url":"git://github.com/xfxf/laravel-framework.git","ssh_url":"git@github.com:xfxf/laravel-framework.git","clone_url":"https://github.com/xfxf/laravel-framework.git","svn_url":"https://github.com/xfxf/laravel-framework","homepage":"http://laravel.com","size":19466,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:4.2","ref":"4.2","sha":"deade43b4fe3db4e46e431cb3b1e092edb4073a0","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-11-19T00:14:51Z","pushed_at":"2015-11-19T07:22:46Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":32103,"stargazers_count":4353,"watchers_count":4353,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2516,"mirror_url":null,"open_issues_count":99,"forks":2516,"open_issues":99,"watchers":4353,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/11030"},"html":{"href":"https://github.com/laravel/framework/pull/11030"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/11030"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/11030/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/11030/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/11030/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/846ed8e650ef0fe25bbf7042f0b1fe2824dcb1cc"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}