{"action":"created","comment":{"url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/comments/44917824","id":44917824,"diff_hunk":"@@ -36,3 +36,13 @@ en:\n     currency:\n       format:\n         unit: £\n+\n+  activemodel:\n+    errors:\n+      models:\n+        take_whole_pot_calculator_form:\n+          blank: 'Using numbers, please enter the value of your %{attribute}'\n+          not_a_number: 'Using numbers, please enter the value of your %{attribute}'\n+          attributes:\n+            pension:\n+              above_limit: \"You've entered more than the maximum allowable state pension\"","path":"config/locales/en.yml","position":13,"original_position":13,"commit_id":"da2aa15f7d646cedd64cd5c1b8188278444f0a8b","original_commit_id":"da2aa15f7d646cedd64cd5c1b8188278444f0a8b","user":{"login":"stevenwilkin","id":45121,"avatar_url":"https://avatars.githubusercontent.com/u/45121?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenwilkin","html_url":"https://github.com/stevenwilkin","followers_url":"https://api.github.com/users/stevenwilkin/followers","following_url":"https://api.github.com/users/stevenwilkin/following{/other_user}","gists_url":"https://api.github.com/users/stevenwilkin/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenwilkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenwilkin/subscriptions","organizations_url":"https://api.github.com/users/stevenwilkin/orgs","repos_url":"https://api.github.com/users/stevenwilkin/repos","events_url":"https://api.github.com/users/stevenwilkin/events{/privacy}","received_events_url":"https://api.github.com/users/stevenwilkin/received_events","type":"User","site_admin":false},"body":"Those apostrophes will be the death of me","created_at":"2015-11-16T12:30:53Z","updated_at":"2015-11-16T12:30:53Z","html_url":"https://github.com/guidance-guarantee-programme/pension_guidance/pull/356#discussion_r44917824","pull_request_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356","_links":{"self":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/comments/44917824"},"html":{"href":"https://github.com/guidance-guarantee-programme/pension_guidance/pull/356#discussion_r44917824"},"pull_request":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356","id":50136087,"html_url":"https://github.com/guidance-guarantee-programme/pension_guidance/pull/356","diff_url":"https://github.com/guidance-guarantee-programme/pension_guidance/pull/356.diff","patch_url":"https://github.com/guidance-guarantee-programme/pension_guidance/pull/356.patch","issue_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/356","number":356,"state":"open","locked":false,"title":"[DO NOT MERGE] Take whole pot calculator - server-side validation","user":{"login":"stevenwilkin","id":45121,"avatar_url":"https://avatars.githubusercontent.com/u/45121?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenwilkin","html_url":"https://github.com/stevenwilkin","followers_url":"https://api.github.com/users/stevenwilkin/followers","following_url":"https://api.github.com/users/stevenwilkin/following{/other_user}","gists_url":"https://api.github.com/users/stevenwilkin/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenwilkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenwilkin/subscriptions","organizations_url":"https://api.github.com/users/stevenwilkin/orgs","repos_url":"https://api.github.com/users/stevenwilkin/repos","events_url":"https://api.github.com/users/stevenwilkin/events{/privacy}","received_events_url":"https://api.github.com/users/stevenwilkin/received_events","type":"User","site_admin":false},"body":"A clunky first pass at performing side-side validation of calculator input and displaying validation errs per the [GOV.UK guidlines](http://govuk-elements.herokuapp.com/errors):\r\n\r\n![image](https://cloud.githubusercontent.com/assets/45121/11037581/57e34f70-86f6-11e5-8723-4c0892a1a732.png)\r\n\r\nAt this stage this doesn't deal with commas in the supplied values and we still need to render values with the correct decimalisation. More helpful validation messages would also be an idea.","created_at":"2015-11-09T15:32:04Z","updated_at":"2015-11-16T12:30:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"603ef7378c04c1c2400d4790ea0fda58e4ea9b1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356/commits","review_comments_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356/comments","review_comment_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/356/comments","statuses_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/statuses/da2aa15f7d646cedd64cd5c1b8188278444f0a8b","head":{"label":"guidance-guarantee-programme:take-whole-pot-calculator-ruby-server-validation","ref":"take-whole-pot-calculator-ruby-server-validation","sha":"da2aa15f7d646cedd64cd5c1b8188278444f0a8b","user":{"login":"guidance-guarantee-programme","id":8751528,"avatar_url":"https://avatars.githubusercontent.com/u/8751528?v=3","gravatar_id":"","url":"https://api.github.com/users/guidance-guarantee-programme","html_url":"https://github.com/guidance-guarantee-programme","followers_url":"https://api.github.com/users/guidance-guarantee-programme/followers","following_url":"https://api.github.com/users/guidance-guarantee-programme/following{/other_user}","gists_url":"https://api.github.com/users/guidance-guarantee-programme/gists{/gist_id}","starred_url":"https://api.github.com/users/guidance-guarantee-programme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidance-guarantee-programme/subscriptions","organizations_url":"https://api.github.com/users/guidance-guarantee-programme/orgs","repos_url":"https://api.github.com/users/guidance-guarantee-programme/repos","events_url":"https://api.github.com/users/guidance-guarantee-programme/events{/privacy}","received_events_url":"https://api.github.com/users/guidance-guarantee-programme/received_events","type":"Organization","site_admin":false},"repo":{"id":26530409,"name":"pension_guidance","full_name":"guidance-guarantee-programme/pension_guidance","owner":{"login":"guidance-guarantee-programme","id":8751528,"avatar_url":"https://avatars.githubusercontent.com/u/8751528?v=3","gravatar_id":"","url":"https://api.github.com/users/guidance-guarantee-programme","html_url":"https://github.com/guidance-guarantee-programme","followers_url":"https://api.github.com/users/guidance-guarantee-programme/followers","following_url":"https://api.github.com/users/guidance-guarantee-programme/following{/other_user}","gists_url":"https://api.github.com/users/guidance-guarantee-programme/gists{/gist_id}","starred_url":"https://api.github.com/users/guidance-guarantee-programme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidance-guarantee-programme/subscriptions","organizations_url":"https://api.github.com/users/guidance-guarantee-programme/orgs","repos_url":"https://api.github.com/users/guidance-guarantee-programme/repos","events_url":"https://api.github.com/users/guidance-guarantee-programme/events{/privacy}","received_events_url":"https://api.github.com/users/guidance-guarantee-programme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guidance-guarantee-programme/pension_guidance","description":"Pension guidance from Pension Wise.","fork":false,"url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance","forks_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/forks","keys_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/teams","hooks_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/hooks","issue_events_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/events{/number}","events_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/events","assignees_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/assignees{/user}","branches_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/branches{/branch}","tags_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/tags","blobs_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/refs{/sha}","trees_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/statuses/{sha}","languages_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/languages","stargazers_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/stargazers","contributors_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/contributors","subscribers_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/subscribers","subscription_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/subscription","commits_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/commits{/sha}","git_commits_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/commits{/sha}","comments_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/comments{/number}","issue_comment_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/comments{/number}","contents_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/contents/{+path}","compare_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/merges","archive_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/downloads","issues_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues{/number}","pulls_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls{/number}","milestones_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/milestones{/number}","notifications_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/labels{/name}","releases_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/releases{/id}","created_at":"2014-11-12T10:16:42Z","updated_at":"2015-08-12T14:57:57Z","pushed_at":"2015-11-13T19:14:25Z","git_url":"git://github.com/guidance-guarantee-programme/pension_guidance.git","ssh_url":"git@github.com:guidance-guarantee-programme/pension_guidance.git","clone_url":"https://github.com/guidance-guarantee-programme/pension_guidance.git","svn_url":"https://github.com/guidance-guarantee-programme/pension_guidance","homepage":"https://www.pensionwise.gov.uk","size":16212,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"guidance-guarantee-programme:take-whole-pot-calculator-ruby","ref":"take-whole-pot-calculator-ruby","sha":"0fdb8e9d028c1948011d83041b8ee1bc88405ed0","user":{"login":"guidance-guarantee-programme","id":8751528,"avatar_url":"https://avatars.githubusercontent.com/u/8751528?v=3","gravatar_id":"","url":"https://api.github.com/users/guidance-guarantee-programme","html_url":"https://github.com/guidance-guarantee-programme","followers_url":"https://api.github.com/users/guidance-guarantee-programme/followers","following_url":"https://api.github.com/users/guidance-guarantee-programme/following{/other_user}","gists_url":"https://api.github.com/users/guidance-guarantee-programme/gists{/gist_id}","starred_url":"https://api.github.com/users/guidance-guarantee-programme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidance-guarantee-programme/subscriptions","organizations_url":"https://api.github.com/users/guidance-guarantee-programme/orgs","repos_url":"https://api.github.com/users/guidance-guarantee-programme/repos","events_url":"https://api.github.com/users/guidance-guarantee-programme/events{/privacy}","received_events_url":"https://api.github.com/users/guidance-guarantee-programme/received_events","type":"Organization","site_admin":false},"repo":{"id":26530409,"name":"pension_guidance","full_name":"guidance-guarantee-programme/pension_guidance","owner":{"login":"guidance-guarantee-programme","id":8751528,"avatar_url":"https://avatars.githubusercontent.com/u/8751528?v=3","gravatar_id":"","url":"https://api.github.com/users/guidance-guarantee-programme","html_url":"https://github.com/guidance-guarantee-programme","followers_url":"https://api.github.com/users/guidance-guarantee-programme/followers","following_url":"https://api.github.com/users/guidance-guarantee-programme/following{/other_user}","gists_url":"https://api.github.com/users/guidance-guarantee-programme/gists{/gist_id}","starred_url":"https://api.github.com/users/guidance-guarantee-programme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidance-guarantee-programme/subscriptions","organizations_url":"https://api.github.com/users/guidance-guarantee-programme/orgs","repos_url":"https://api.github.com/users/guidance-guarantee-programme/repos","events_url":"https://api.github.com/users/guidance-guarantee-programme/events{/privacy}","received_events_url":"https://api.github.com/users/guidance-guarantee-programme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guidance-guarantee-programme/pension_guidance","description":"Pension guidance from Pension Wise.","fork":false,"url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance","forks_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/forks","keys_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/teams","hooks_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/hooks","issue_events_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/events{/number}","events_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/events","assignees_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/assignees{/user}","branches_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/branches{/branch}","tags_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/tags","blobs_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/refs{/sha}","trees_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/statuses/{sha}","languages_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/languages","stargazers_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/stargazers","contributors_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/contributors","subscribers_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/subscribers","subscription_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/subscription","commits_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/commits{/sha}","git_commits_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/git/commits{/sha}","comments_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/comments{/number}","issue_comment_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/comments{/number}","contents_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/contents/{+path}","compare_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/merges","archive_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/downloads","issues_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues{/number}","pulls_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls{/number}","milestones_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/milestones{/number}","notifications_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/labels{/name}","releases_url":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/releases{/id}","created_at":"2014-11-12T10:16:42Z","updated_at":"2015-08-12T14:57:57Z","pushed_at":"2015-11-13T19:14:25Z","git_url":"git://github.com/guidance-guarantee-programme/pension_guidance.git","ssh_url":"git@github.com:guidance-guarantee-programme/pension_guidance.git","clone_url":"https://github.com/guidance-guarantee-programme/pension_guidance.git","svn_url":"https://github.com/guidance-guarantee-programme/pension_guidance","homepage":"https://www.pensionwise.gov.uk","size":16212,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356"},"html":{"href":"https://github.com/guidance-guarantee-programme/pension_guidance/pull/356"},"issue":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/356"},"comments":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/guidance-guarantee-programme/pension_guidance/statuses/da2aa15f7d646cedd64cd5c1b8188278444f0a8b"}}}}