{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/34851786","id":34851786,"diff_hunk":"@@ -80,7 +80,7 @@ class AsyncQpsServerTest : public Server {\n     server_ = builder.BuildAndStart();\n \n     using namespace std::placeholders;\n-    for (int i = 0; i < 10; i++) {\n+    for (int i = 0; i < 10000 / config.threads(); i++) {","path":"test/cpp/qps/server_async.cc","position":5,"original_position":5,"commit_id":"e0981dfa05e49acdd9fc5e8abb83a91d84d1a104","original_commit_id":"e0981dfa05e49acdd9fc5e8abb83a91d84d1a104","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"body":"Yeah, that probably should have been done in hindsight. Oops.","created_at":"2015-07-17T00:05:59Z","updated_at":"2015-07-17T00:05:59Z","html_url":"https://github.com/grpc/grpc/pull/2470#discussion_r34851786","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/2470","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/34851786"},"html":{"href":"https://github.com/grpc/grpc/pull/2470#discussion_r34851786"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2470"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/2470","id":40144414,"html_url":"https://github.com/grpc/grpc/pull/2470","diff_url":"https://github.com/grpc/grpc/pull/2470.diff","patch_url":"https://github.com/grpc/grpc/pull/2470.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/2470","number":2470,"state":"open","locked":false,"title":"Lock free requested call fulfillment path","user":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"body":"Utilize a lock free stack of requested calls to satisfy incoming new requests.\r\n\r\nThis change also includes some bonuses that were needed to prove out the performance:\r\n- a tweak to pollsets to remove epoll_ctl from the serialized path of add_fd\r\n- an atomic shutdown flag on the server\r\n- a tweak to our lockfree stack to provide an edge for the first inserted element, which is used to flush the pending call list","created_at":"2015-07-16T15:49:58Z","updated_at":"2015-07-17T00:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c018599ecf385339673360afe38cd8384f79f92","assignee":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/2470/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/2470/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/2470/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/e0981dfa05e49acdd9fc5e8abb83a91d84d1a104","head":{"label":"ctiller:i-want-to-wait-free","ref":"i-want-to-wait-free","sha":"e0981dfa05e49acdd9fc5e8abb83a91d84d1a104","user":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"repo":{"id":31379631,"name":"grpc","full_name":"ctiller/grpc","owner":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctiller/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/ctiller/grpc","forks_url":"https://api.github.com/repos/ctiller/grpc/forks","keys_url":"https://api.github.com/repos/ctiller/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctiller/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctiller/grpc/teams","hooks_url":"https://api.github.com/repos/ctiller/grpc/hooks","issue_events_url":"https://api.github.com/repos/ctiller/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/ctiller/grpc/events","assignees_url":"https://api.github.com/repos/ctiller/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/ctiller/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/ctiller/grpc/tags","blobs_url":"https://api.github.com/repos/ctiller/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctiller/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctiller/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctiller/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctiller/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ctiller/grpc/languages","stargazers_url":"https://api.github.com/repos/ctiller/grpc/stargazers","contributors_url":"https://api.github.com/repos/ctiller/grpc/contributors","subscribers_url":"https://api.github.com/repos/ctiller/grpc/subscribers","subscription_url":"https://api.github.com/repos/ctiller/grpc/subscription","commits_url":"https://api.github.com/repos/ctiller/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctiller/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctiller/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctiller/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctiller/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/ctiller/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctiller/grpc/merges","archive_url":"https://api.github.com/repos/ctiller/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctiller/grpc/downloads","issues_url":"https://api.github.com/repos/ctiller/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/ctiller/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ctiller/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ctiller/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctiller/grpc/labels{/name}","releases_url":"https://api.github.com/repos/ctiller/grpc/releases{/id}","created_at":"2015-02-26T17:36:22Z","updated_at":"2015-04-20T15:39:22Z","pushed_at":"2015-07-16T23:51:09Z","git_url":"git://github.com/ctiller/grpc.git","ssh_url":"git@github.com:ctiller/grpc.git","clone_url":"https://github.com/ctiller/grpc.git","svn_url":"https://github.com/ctiller/grpc","homepage":"","size":44014,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"f101af1ab4c553ff2a8cd8f72e8ca156ef188b86","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-07-16T17:04:58Z","pushed_at":"2015-07-17T00:01:29Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":61462,"stargazers_count":2871,"watchers_count":2871,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":377,"forks":416,"open_issues":377,"watchers":2871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2470"},"html":{"href":"https://github.com/grpc/grpc/pull/2470"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/2470"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/2470/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2470/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2470/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/e0981dfa05e49acdd9fc5e8abb83a91d84d1a104"}}}}