{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/comments/32485653","id":32485653,"diff_hunk":"@@ -211,15 +219,85 @@ is_uuid (GVariant *variant)\n }\n \n static void\n-uuid_from_variant (GVariant *variant,\n-                   uuid_t    uuid)\n+buffer_event (EmerDaemon *self,\n+              GVariant   *event)\n+{\n+  EmerDaemonPrivate *priv = emer_daemon_get_instance_private (self);\n+\n+  g_variant_ref_sink (event);\n+  gsize size_with_type = get_size_with_type (event);\n+  gsize new_bytes_buffered = priv->num_bytes_buffered + size_with_type;\n+  if (new_bytes_buffered > priv->max_bytes_buffered ||\n+      /* Don't get wedged by a large event. */\n+      new_bytes_buffered > MAX_REQUEST_PAYLOAD)\n+    {\n+      g_variant_unref (event);","path":"daemon/emer-daemon.c","position":134,"original_position":134,"commit_id":"624c5244f23945ba464b3fdd3220619cd9172473","original_commit_id":"624c5244f23945ba464b3fdd3220619cd9172473","user":{"login":"cosimoc","id":13906,"avatar_url":"https://avatars.githubusercontent.com/u/13906?v=3","gravatar_id":"","url":"https://api.github.com/users/cosimoc","html_url":"https://github.com/cosimoc","followers_url":"https://api.github.com/users/cosimoc/followers","following_url":"https://api.github.com/users/cosimoc/following{/other_user}","gists_url":"https://api.github.com/users/cosimoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cosimoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosimoc/subscriptions","organizations_url":"https://api.github.com/users/cosimoc/orgs","repos_url":"https://api.github.com/users/cosimoc/repos","events_url":"https://api.github.com/users/cosimoc/events{/privacy}","received_events_url":"https://api.github.com/users/cosimoc/received_events","type":"User","site_admin":false},"body":"Yeah, dropping events in the metrics public library sounds like a good idea. Not for this issue though.\r\nYou can use `g_test_expect_message()` to make tests robust to failure messages or test the messages themselves.","created_at":"2015-06-16T02:01:13Z","updated_at":"2015-06-16T02:01:13Z","html_url":"https://github.com/endlessm/eos-event-recorder-daemon/pull/188#discussion_r32485653","pull_request_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/comments/32485653"},"html":{"href":"https://github.com/endlessm/eos-event-recorder-daemon/pull/188#discussion_r32485653"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188","id":37742177,"html_url":"https://github.com/endlessm/eos-event-recorder-daemon/pull/188","diff_url":"https://github.com/endlessm/eos-event-recorder-daemon/pull/188.diff","patch_url":"https://github.com/endlessm/eos-event-recorder-daemon/pull/188.patch","issue_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/188","number":188,"state":"open","locked":false,"title":"WIP; do not merge.","user":{"login":"Kurt-von-Laven","id":974910,"avatar_url":"https://avatars.githubusercontent.com/u/974910?v=3","gravatar_id":"","url":"https://api.github.com/users/Kurt-von-Laven","html_url":"https://github.com/Kurt-von-Laven","followers_url":"https://api.github.com/users/Kurt-von-Laven/followers","following_url":"https://api.github.com/users/Kurt-von-Laven/following{/other_user}","gists_url":"https://api.github.com/users/Kurt-von-Laven/gists{/gist_id}","starred_url":"https://api.github.com/users/Kurt-von-Laven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kurt-von-Laven/subscriptions","organizations_url":"https://api.github.com/users/Kurt-von-Laven/orgs","repos_url":"https://api.github.com/users/Kurt-von-Laven/repos","events_url":"https://api.github.com/users/Kurt-von-Laven/events{/privacy}","received_events_url":"https://api.github.com/users/Kurt-von-Laven/received_events","type":"User","site_admin":false},"body":"[endlessm/eos-sdk#599]","created_at":"2015-06-15T22:25:14Z","updated_at":"2015-06-16T02:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8609e047bd75eeabfb973cdbfda1ee89de27e9e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/188/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/statuses/624c5244f23945ba464b3fdd3220619cd9172473","head":{"label":"endlessm:sdk/599","ref":"sdk/599","sha":"624c5244f23945ba464b3fdd3220619cd9172473","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":13224558,"name":"eos-event-recorder-daemon","full_name":"endlessm/eos-event-recorder-daemon","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-event-recorder-daemon","description":"Saves recorded user metrics and transmits them in small batches when there's an internet connection","fork":false,"url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon","forks_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/forks","keys_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/events","assignees_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/merges","archive_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/releases{/id}","created_at":"2013-09-30T19:14:11Z","updated_at":"2015-05-19T14:53:47Z","pushed_at":"2015-06-15T23:23:40Z","git_url":"git://github.com/endlessm/eos-event-recorder-daemon.git","ssh_url":"git@github.com:endlessm/eos-event-recorder-daemon.git","clone_url":"https://github.com/endlessm/eos-event-recorder-daemon.git","svn_url":"https://github.com/endlessm/eos-event-recorder-daemon","homepage":"","size":4215,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"d2993e62f537690a5f652e25dfeed4d791a571c4","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":13224558,"name":"eos-event-recorder-daemon","full_name":"endlessm/eos-event-recorder-daemon","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-event-recorder-daemon","description":"Saves recorded user metrics and transmits them in small batches when there's an internet connection","fork":false,"url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon","forks_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/forks","keys_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/events","assignees_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/merges","archive_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/releases{/id}","created_at":"2013-09-30T19:14:11Z","updated_at":"2015-05-19T14:53:47Z","pushed_at":"2015-06-15T23:23:40Z","git_url":"git://github.com/endlessm/eos-event-recorder-daemon.git","ssh_url":"git@github.com:endlessm/eos-event-recorder-daemon.git","clone_url":"https://github.com/endlessm/eos-event-recorder-daemon.git","svn_url":"https://github.com/endlessm/eos-event-recorder-daemon","homepage":"","size":4215,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188"},"html":{"href":"https://github.com/endlessm/eos-event-recorder-daemon/pull/188"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/188"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/statuses/624c5244f23945ba464b3fdd3220619cd9172473"}}}}