{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/39891349","id":39891349,"diff_hunk":"@@ -130,5 +130,36 @@\n         ManageIQ::Providers::Kubernetes::ContainerManager.last.authentication_token(\"bearer\").should == \"valid-token\"\n       end\n     end\n+\n+    context \"#button\" do\n+      before(:each) do\n+        set_user_privileges\n+        FactoryGirl.create(:vmdb_database)\n+        EvmSpecHelper.create_guid_miq_server_zone\n+      end\n+\n+      it \"when VM Migrate is pressed for unsupported type\" do\n+        controller.stub(:role_allows).and_return(true)\n+        controller.stub(:performed?).and_return(true)","path":"spec/controllers/ems_common_controller_spec.rb","position":14,"original_position":14,"commit_id":"909d2b7ee4f75b771c8023ec1f08a59df75e9a2d","original_commit_id":"909d2b7ee4f75b771c8023ec1f08a59df75e9a2d","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"body":"@martinpovolny when running spec test for some reason performed? was always returning false. Maybe i am doing something incorrectly, i will look again.","created_at":"2015-09-18T19:19:21Z","updated_at":"2015-09-18T19:19:21Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4368#discussion_r39891349","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/39891349"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4368#discussion_r39891349"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368","id":45105417,"html_url":"https://github.com/ManageIQ/manageiq/pull/4368","diff_url":"https://github.com/ManageIQ/manageiq/pull/4368.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4368.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4368","number":4368,"state":"open","locked":false,"title":"Fix to not try to render, to prevent double render error.","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"body":"- Fixed button methods to not try to render if method being called has already redirected or rendered. When trying to perform certain actions such as Migrate, Clone etc from list of VMs thru relationships was causing double render error when selected items were not supported for the task because flash_msg partial was already being rendered because task_supported? method in that case.\r\n- Added spec test to verify fix.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1263326\r\n\r\n@martinpovolny @dclarizio please review and suggest if there is another way this issue can be fixed. To recreate the issue Go to Infrastructure Providers, Go to SCVMM Provider summary screen, from there Click on VMs in the relationships box, Select one or more VMs from the list and click on Migrate selected Items button under Lifecycle button. You should see double render error in the log, you should be able to see this behavior for any of the CIs that have link to view VMs in the relationship box on their respective summary screens. Selected VM has to be the one that do not support Migrate task, which is why i used VMs under a SCVMM provider. Let me know if you have questions or need help recreating this issue.","created_at":"2015-09-15T21:33:36Z","updated_at":"2015-09-18T19:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d081f083c89c55973d451ae77a8671ace1aeeaf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4368/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/909d2b7ee4f75b771c8023ec1f08a59df75e9a2d","head":{"label":"h-kataria:fixed_prov_related_buttons_for_sub_list_views","ref":"fixed_prov_related_buttons_for_sub_list_views","sha":"909d2b7ee4f75b771c8023ec1f08a59df75e9a2d","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"repo":{"id":20811753,"name":"manageiq","full_name":"h-kataria/manageiq","owner":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-kataria/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/h-kataria/manageiq","forks_url":"https://api.github.com/repos/h-kataria/manageiq/forks","keys_url":"https://api.github.com/repos/h-kataria/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-kataria/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-kataria/manageiq/teams","hooks_url":"https://api.github.com/repos/h-kataria/manageiq/hooks","issue_events_url":"https://api.github.com/repos/h-kataria/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/h-kataria/manageiq/events","assignees_url":"https://api.github.com/repos/h-kataria/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/h-kataria/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/h-kataria/manageiq/tags","blobs_url":"https://api.github.com/repos/h-kataria/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-kataria/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-kataria/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-kataria/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-kataria/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/h-kataria/manageiq/languages","stargazers_url":"https://api.github.com/repos/h-kataria/manageiq/stargazers","contributors_url":"https://api.github.com/repos/h-kataria/manageiq/contributors","subscribers_url":"https://api.github.com/repos/h-kataria/manageiq/subscribers","subscription_url":"https://api.github.com/repos/h-kataria/manageiq/subscription","commits_url":"https://api.github.com/repos/h-kataria/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-kataria/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-kataria/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-kataria/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-kataria/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/h-kataria/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-kataria/manageiq/merges","archive_url":"https://api.github.com/repos/h-kataria/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-kataria/manageiq/downloads","issues_url":"https://api.github.com/repos/h-kataria/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/h-kataria/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/h-kataria/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/h-kataria/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-kataria/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/h-kataria/manageiq/releases{/id}","created_at":"2014-06-13T17:15:09Z","updated_at":"2014-06-24T23:08:03Z","pushed_at":"2015-09-18T18:31:41Z","git_url":"git://github.com/h-kataria/manageiq.git","ssh_url":"git@github.com:h-kataria/manageiq.git","clone_url":"https://github.com/h-kataria/manageiq.git","svn_url":"https://github.com/h-kataria/manageiq","homepage":null,"size":85204,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"9fb44950c1866f06183edc8affb503187cb0b41c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-09-18T14:07:23Z","pushed_at":"2015-09-18T19:03:23Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":160091,"stargazers_count":151,"watchers_count":151,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":420,"forks":157,"open_issues":420,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4368"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4368"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4368/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4368/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/909d2b7ee4f75b771c8023ec1f08a59df75e9a2d"}}}}