{"action":"closed","number":756,"pull_request":{"url":"https://api.github.com/repos/libMesh/libmesh/pulls/756","id":54055702,"html_url":"https://github.com/libMesh/libmesh/pull/756","diff_url":"https://github.com/libMesh/libmesh/pull/756.diff","patch_url":"https://github.com/libMesh/libmesh/pull/756.patch","issue_url":"https://api.github.com/repos/libMesh/libmesh/issues/756","number":756,"state":"closed","locked":false,"title":"Prevent user-supplied mesh dimension from being ignored","user":{"login":"bwspenc","id":6609012,"avatar_url":"https://avatars.githubusercontent.com/u/6609012?v=3","gravatar_id":"","url":"https://api.github.com/users/bwspenc","html_url":"https://github.com/bwspenc","followers_url":"https://api.github.com/users/bwspenc/followers","following_url":"https://api.github.com/users/bwspenc/following{/other_user}","gists_url":"https://api.github.com/users/bwspenc/gists{/gist_id}","starred_url":"https://api.github.com/users/bwspenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwspenc/subscriptions","organizations_url":"https://api.github.com/users/bwspenc/orgs","repos_url":"https://api.github.com/users/bwspenc/repos","events_url":"https://api.github.com/users/bwspenc/events{/privacy}","received_events_url":"https://api.github.com/users/bwspenc/received_events","type":"User","site_admin":false},"body":"The mesh dimension supplied in the constructors to MeshBase currently gets put into _elem_dims, but when prepare_for_use() gets called, that gets cleared, and it gets lost.  As a result, if the user asked for a mesh with dimension 3, but it only contains elements of dimension 1 or 2, the mesh dimension is reported as the lower number.  This fixes that issue.\r\n\r\nMy interest in doing this is that I'm trying to use a 3d or 2d truss mesh composed only of line elements.  The elements themselves are 1d, but the nodal coordinates are 2d or 3d.  With this fix, I can pass a 3 in to the constructor, and then the mesh dimension is reported as 3, and my MOOSE job runs happily.  I should note that this patch breaks many MOOSE tests because it currently passes 3 in to the MeshBase constructor, which then gets ignored. Passing in 1 instead by default from the MOOSE side fixes that.\r\n\r\nIdeally, I'd like to not have to tell it that it's a 3d mesh and have that be detected. I see that there is a spatial dimension and a mesh dimension.  I might have the terminology wrong, but I think what I have here is a mesh that is spatially 3D, but topologically 1D.  If that's correct, I think what I really need is a way to get the spatial dimension of my mesh. The spatial dimension is hardcoded to LIBMESH_DIM, so that isn't useful for the application to figure out what the actual dimension of the current mesh is.","created_at":"2015-12-18T01:40:59Z","updated_at":"2015-12-21T23:43:06Z","closed_at":"2015-12-21T23:43:06Z","merged_at":null,"merge_commit_sha":"584880c3dc6de6d574822e2fe5311e00f6ea790e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libMesh/libmesh/pulls/756/commits","review_comments_url":"https://api.github.com/repos/libMesh/libmesh/pulls/756/comments","review_comment_url":"https://api.github.com/repos/libMesh/libmesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libMesh/libmesh/issues/756/comments","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/377b932171f42a08c2bbb0fb7443b3b552389f41","head":{"label":"bwspenc:mesh_dim","ref":"mesh_dim","sha":"377b932171f42a08c2bbb0fb7443b3b552389f41","user":{"login":"bwspenc","id":6609012,"avatar_url":"https://avatars.githubusercontent.com/u/6609012?v=3","gravatar_id":"","url":"https://api.github.com/users/bwspenc","html_url":"https://github.com/bwspenc","followers_url":"https://api.github.com/users/bwspenc/followers","following_url":"https://api.github.com/users/bwspenc/following{/other_user}","gists_url":"https://api.github.com/users/bwspenc/gists{/gist_id}","starred_url":"https://api.github.com/users/bwspenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwspenc/subscriptions","organizations_url":"https://api.github.com/users/bwspenc/orgs","repos_url":"https://api.github.com/users/bwspenc/repos","events_url":"https://api.github.com/users/bwspenc/events{/privacy}","received_events_url":"https://api.github.com/users/bwspenc/received_events","type":"User","site_admin":false},"repo":{"id":17300645,"name":"libmesh","full_name":"bwspenc/libmesh","owner":{"login":"bwspenc","id":6609012,"avatar_url":"https://avatars.githubusercontent.com/u/6609012?v=3","gravatar_id":"","url":"https://api.github.com/users/bwspenc","html_url":"https://github.com/bwspenc","followers_url":"https://api.github.com/users/bwspenc/followers","following_url":"https://api.github.com/users/bwspenc/following{/other_user}","gists_url":"https://api.github.com/users/bwspenc/gists{/gist_id}","starred_url":"https://api.github.com/users/bwspenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwspenc/subscriptions","organizations_url":"https://api.github.com/users/bwspenc/orgs","repos_url":"https://api.github.com/users/bwspenc/repos","events_url":"https://api.github.com/users/bwspenc/events{/privacy}","received_events_url":"https://api.github.com/users/bwspenc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwspenc/libmesh","description":"libMesh github repository","fork":true,"url":"https://api.github.com/repos/bwspenc/libmesh","forks_url":"https://api.github.com/repos/bwspenc/libmesh/forks","keys_url":"https://api.github.com/repos/bwspenc/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwspenc/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwspenc/libmesh/teams","hooks_url":"https://api.github.com/repos/bwspenc/libmesh/hooks","issue_events_url":"https://api.github.com/repos/bwspenc/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/bwspenc/libmesh/events","assignees_url":"https://api.github.com/repos/bwspenc/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/bwspenc/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/bwspenc/libmesh/tags","blobs_url":"https://api.github.com/repos/bwspenc/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwspenc/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwspenc/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwspenc/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwspenc/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/bwspenc/libmesh/languages","stargazers_url":"https://api.github.com/repos/bwspenc/libmesh/stargazers","contributors_url":"https://api.github.com/repos/bwspenc/libmesh/contributors","subscribers_url":"https://api.github.com/repos/bwspenc/libmesh/subscribers","subscription_url":"https://api.github.com/repos/bwspenc/libmesh/subscription","commits_url":"https://api.github.com/repos/bwspenc/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwspenc/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwspenc/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwspenc/libmesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwspenc/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/bwspenc/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwspenc/libmesh/merges","archive_url":"https://api.github.com/repos/bwspenc/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwspenc/libmesh/downloads","issues_url":"https://api.github.com/repos/bwspenc/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/bwspenc/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/bwspenc/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/bwspenc/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwspenc/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/bwspenc/libmesh/releases{/id}","created_at":"2014-02-28T21:41:20Z","updated_at":"2014-06-05T15:39:30Z","pushed_at":"2015-12-18T01:25:30Z","git_url":"git://github.com/bwspenc/libmesh.git","ssh_url":"git@github.com:bwspenc/libmesh.git","clone_url":"https://github.com/bwspenc/libmesh.git","svn_url":"https://github.com/bwspenc/libmesh","homepage":"http://libmesh.sourceforge.net","size":0,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libMesh:master","ref":"master","sha":"eca97f6c8c1e1a758faba1564d901c67d53c47a3","user":{"login":"libMesh","id":2366757,"avatar_url":"https://avatars.githubusercontent.com/u/2366757?v=3","gravatar_id":"","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"repo":{"id":5850234,"name":"libmesh","full_name":"libMesh/libmesh","owner":{"login":"libMesh","id":2366757,"avatar_url":"https://avatars.githubusercontent.com/u/2366757?v=3","gravatar_id":"","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libMesh/libmesh","description":"libMesh github repository","fork":false,"url":"https://api.github.com/repos/libMesh/libmesh","forks_url":"https://api.github.com/repos/libMesh/libmesh/forks","keys_url":"https://api.github.com/repos/libMesh/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libMesh/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libMesh/libmesh/teams","hooks_url":"https://api.github.com/repos/libMesh/libmesh/hooks","issue_events_url":"https://api.github.com/repos/libMesh/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/libMesh/libmesh/events","assignees_url":"https://api.github.com/repos/libMesh/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/libMesh/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/libMesh/libmesh/tags","blobs_url":"https://api.github.com/repos/libMesh/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libMesh/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libMesh/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/libMesh/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/libMesh/libmesh/languages","stargazers_url":"https://api.github.com/repos/libMesh/libmesh/stargazers","contributors_url":"https://api.github.com/repos/libMesh/libmesh/contributors","subscribers_url":"https://api.github.com/repos/libMesh/libmesh/subscribers","subscription_url":"https://api.github.com/repos/libMesh/libmesh/subscription","commits_url":"https://api.github.com/repos/libMesh/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/libMesh/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/libMesh/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/libMesh/libmesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/libMesh/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/libMesh/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libMesh/libmesh/merges","archive_url":"https://api.github.com/repos/libMesh/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libMesh/libmesh/downloads","issues_url":"https://api.github.com/repos/libMesh/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/libMesh/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/libMesh/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/libMesh/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libMesh/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/libMesh/libmesh/releases{/id}","created_at":"2012-09-18T02:12:18Z","updated_at":"2015-12-15T16:09:06Z","pushed_at":"2015-12-21T23:42:27Z","git_url":"git://github.com/libMesh/libmesh.git","ssh_url":"git@github.com:libMesh/libmesh.git","clone_url":"https://github.com/libMesh/libmesh.git","svn_url":"https://github.com/libMesh/libmesh","homepage":"http://libmesh.github.io","size":98320,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":34,"forks":81,"open_issues":34,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/756"},"html":{"href":"https://github.com/libMesh/libmesh/pull/756"},"issue":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/756"},"comments":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/756/comments"},"review_comments":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/756/comments"},"review_comment":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/756/commits"},"statuses":{"href":"https://api.github.com/repos/libMesh/libmesh/statuses/377b932171f42a08c2bbb0fb7443b3b552389f41"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":26,"review_comments":0,"commits":1,"additions":15,"deletions":4,"changed_files":2}}