{"action":"created","comment":{"url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments/37956437","id":37956437,"diff_hunk":"@@ -592,6 +592,41 @@ set_changelog(app_identifier: \"com.krausefx.app\", version: \"1.0\", changelog: \"Al\n \n You can store the changelog in `./fastlane/changelog.txt` and it will automatically get loaded from there. This integration is useful if you support e.g. 10 languages and want to use the same \"What's new\"-text for all languages.\n \n+### upload_artifact\n+\n+This allows you to upload your ipa, or any other file you want, to artifactory. I recommend using a combination of the ENV variables along with passing some parameters into the command, as seen below.\n+\n+```ruby\n+# This example shows the minimum required configuration to upload an artifact \n+ENV['FL_UPLOAD_ARTIFACT_ENDPOINT'] = 'https://artifactory.example.com/artifactory/'","path":"docs/Actions.md","position":null,"original_position":10,"commit_id":"1ff8155134a97dd8044ec9b6517e398b62200bfe","original_commit_id":"4910b1e7235ee35962f9e336215d180148fdfb25","user":{"login":"koglinjg","id":1810619,"avatar_url":"https://avatars.githubusercontent.com/u/1810619?v=3","gravatar_id":"","url":"https://api.github.com/users/koglinjg","html_url":"https://github.com/koglinjg","followers_url":"https://api.github.com/users/koglinjg/followers","following_url":"https://api.github.com/users/koglinjg/following{/other_user}","gists_url":"https://api.github.com/users/koglinjg/gists{/gist_id}","starred_url":"https://api.github.com/users/koglinjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koglinjg/subscriptions","organizations_url":"https://api.github.com/users/koglinjg/orgs","repos_url":"https://api.github.com/users/koglinjg/repos","events_url":"https://api.github.com/users/koglinjg/events{/privacy}","received_events_url":"https://api.github.com/users/koglinjg/received_events","type":"User","site_admin":false},"body":"Should I document it like this instead?\r\n```ruby\r\nartifactory(\r\n  endpoint: 'https://artifactory.example.com/artifactory/' # uri for your artifactory instance\r\n  username: 'user'\r\n  password: 'password'\r\n  file: 'example.ipa',                                # File to upload\r\n  repo: 'mobile_artifacts',                           # Artifactory repo\r\n  repo_path: '/ios/appname/example-major.minor.ipa'   # Path to place the artifact including its filename\r\n)\r\n```\r\n\r\nOr just remove the ENV lines and leave the rest as is?","created_at":"2015-08-26T08:18:10Z","updated_at":"2015-08-26T08:18:10Z","html_url":"https://github.com/KrauseFx/fastlane/pull/542#discussion_r37956437","pull_request_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542","_links":{"self":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments/37956437"},"html":{"href":"https://github.com/KrauseFx/fastlane/pull/542#discussion_r37956437"},"pull_request":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542"}}},"pull_request":{"url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542","id":43372073,"html_url":"https://github.com/KrauseFx/fastlane/pull/542","diff_url":"https://github.com/KrauseFx/fastlane/pull/542.diff","patch_url":"https://github.com/KrauseFx/fastlane/pull/542.patch","issue_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/542","number":542,"state":"open","locked":false,"title":"Feature add artifactory support","user":{"login":"koglinjg","id":1810619,"avatar_url":"https://avatars.githubusercontent.com/u/1810619?v=3","gravatar_id":"","url":"https://api.github.com/users/koglinjg","html_url":"https://github.com/koglinjg","followers_url":"https://api.github.com/users/koglinjg/followers","following_url":"https://api.github.com/users/koglinjg/following{/other_user}","gists_url":"https://api.github.com/users/koglinjg/gists{/gist_id}","starred_url":"https://api.github.com/users/koglinjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koglinjg/subscriptions","organizations_url":"https://api.github.com/users/koglinjg/orgs","repos_url":"https://api.github.com/users/koglinjg/repos","events_url":"https://api.github.com/users/koglinjg/events{/privacy}","received_events_url":"https://api.github.com/users/koglinjg/received_events","type":"User","site_admin":false},"body":"I have created this action to add support for uploading files to artifactory. Let me know what you think. ","created_at":"2015-08-26T07:31:19Z","updated_at":"2015-08-26T08:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900c4f6368474690f787a20a7e0c519e7318cd4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542/commits","review_comments_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542/comments","review_comment_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/542/comments","statuses_url":"https://api.github.com/repos/KrauseFx/fastlane/statuses/1ff8155134a97dd8044ec9b6517e398b62200bfe","head":{"label":"koglinjg:feature_add_artifactory_support","ref":"feature_add_artifactory_support","sha":"1ff8155134a97dd8044ec9b6517e398b62200bfe","user":{"login":"koglinjg","id":1810619,"avatar_url":"https://avatars.githubusercontent.com/u/1810619?v=3","gravatar_id":"","url":"https://api.github.com/users/koglinjg","html_url":"https://github.com/koglinjg","followers_url":"https://api.github.com/users/koglinjg/followers","following_url":"https://api.github.com/users/koglinjg/following{/other_user}","gists_url":"https://api.github.com/users/koglinjg/gists{/gist_id}","starred_url":"https://api.github.com/users/koglinjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koglinjg/subscriptions","organizations_url":"https://api.github.com/users/koglinjg/orgs","repos_url":"https://api.github.com/users/koglinjg/repos","events_url":"https://api.github.com/users/koglinjg/events{/privacy}","received_events_url":"https://api.github.com/users/koglinjg/received_events","type":"User","site_admin":false},"repo":{"id":41321871,"name":"fastlane","full_name":"koglinjg/fastlane","owner":{"login":"koglinjg","id":1810619,"avatar_url":"https://avatars.githubusercontent.com/u/1810619?v=3","gravatar_id":"","url":"https://api.github.com/users/koglinjg","html_url":"https://github.com/koglinjg","followers_url":"https://api.github.com/users/koglinjg/followers","following_url":"https://api.github.com/users/koglinjg/following{/other_user}","gists_url":"https://api.github.com/users/koglinjg/gists{/gist_id}","starred_url":"https://api.github.com/users/koglinjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koglinjg/subscriptions","organizations_url":"https://api.github.com/users/koglinjg/orgs","repos_url":"https://api.github.com/users/koglinjg/repos","events_url":"https://api.github.com/users/koglinjg/events{/privacy}","received_events_url":"https://api.github.com/users/koglinjg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koglinjg/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/koglinjg/fastlane","forks_url":"https://api.github.com/repos/koglinjg/fastlane/forks","keys_url":"https://api.github.com/repos/koglinjg/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koglinjg/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koglinjg/fastlane/teams","hooks_url":"https://api.github.com/repos/koglinjg/fastlane/hooks","issue_events_url":"https://api.github.com/repos/koglinjg/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/koglinjg/fastlane/events","assignees_url":"https://api.github.com/repos/koglinjg/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/koglinjg/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/koglinjg/fastlane/tags","blobs_url":"https://api.github.com/repos/koglinjg/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koglinjg/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koglinjg/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/koglinjg/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koglinjg/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/koglinjg/fastlane/languages","stargazers_url":"https://api.github.com/repos/koglinjg/fastlane/stargazers","contributors_url":"https://api.github.com/repos/koglinjg/fastlane/contributors","subscribers_url":"https://api.github.com/repos/koglinjg/fastlane/subscribers","subscription_url":"https://api.github.com/repos/koglinjg/fastlane/subscription","commits_url":"https://api.github.com/repos/koglinjg/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/koglinjg/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/koglinjg/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/koglinjg/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/koglinjg/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/koglinjg/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koglinjg/fastlane/merges","archive_url":"https://api.github.com/repos/koglinjg/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koglinjg/fastlane/downloads","issues_url":"https://api.github.com/repos/koglinjg/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/koglinjg/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/koglinjg/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/koglinjg/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koglinjg/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/koglinjg/fastlane/releases{/id}","created_at":"2015-08-24T19:09:13Z","updated_at":"2015-08-24T19:09:14Z","pushed_at":"2015-08-26T08:13:20Z","git_url":"git://github.com/koglinjg/fastlane.git","ssh_url":"git@github.com:koglinjg/fastlane.git","clone_url":"https://github.com/koglinjg/fastlane.git","svn_url":"https://github.com/koglinjg/fastlane","homepage":"https://fastlane.tools","size":2785,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KrauseFx:master","ref":"master","sha":"6040b1718214aa314f359d7549b6fb7c16add83e","user":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"KrauseFx/fastlane","owner":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KrauseFx/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":false,"url":"https://api.github.com/repos/KrauseFx/fastlane","forks_url":"https://api.github.com/repos/KrauseFx/fastlane/forks","keys_url":"https://api.github.com/repos/KrauseFx/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KrauseFx/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KrauseFx/fastlane/teams","hooks_url":"https://api.github.com/repos/KrauseFx/fastlane/hooks","issue_events_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/KrauseFx/fastlane/events","assignees_url":"https://api.github.com/repos/KrauseFx/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/KrauseFx/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/KrauseFx/fastlane/tags","blobs_url":"https://api.github.com/repos/KrauseFx/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KrauseFx/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KrauseFx/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/KrauseFx/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KrauseFx/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/KrauseFx/fastlane/languages","stargazers_url":"https://api.github.com/repos/KrauseFx/fastlane/stargazers","contributors_url":"https://api.github.com/repos/KrauseFx/fastlane/contributors","subscribers_url":"https://api.github.com/repos/KrauseFx/fastlane/subscribers","subscription_url":"https://api.github.com/repos/KrauseFx/fastlane/subscription","commits_url":"https://api.github.com/repos/KrauseFx/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/KrauseFx/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/KrauseFx/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/KrauseFx/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/KrauseFx/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KrauseFx/fastlane/merges","archive_url":"https://api.github.com/repos/KrauseFx/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KrauseFx/fastlane/downloads","issues_url":"https://api.github.com/repos/KrauseFx/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/KrauseFx/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/KrauseFx/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KrauseFx/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/KrauseFx/fastlane/releases{/id}","created_at":"2014-12-02T17:00:38Z","updated_at":"2015-08-26T08:06:44Z","pushed_at":"2015-08-26T08:13:21Z","git_url":"git://github.com/KrauseFx/fastlane.git","ssh_url":"git@github.com:KrauseFx/fastlane.git","clone_url":"https://github.com/KrauseFx/fastlane.git","svn_url":"https://github.com/KrauseFx/fastlane","homepage":"https://fastlane.tools","size":6666,"stargazers_count":3164,"watchers_count":3164,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":87,"forks":259,"open_issues":87,"watchers":3164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542"},"html":{"href":"https://github.com/KrauseFx/fastlane/pull/542"},"issue":{"href":"https://api.github.com/repos/KrauseFx/fastlane/issues/542"},"comments":{"href":"https://api.github.com/repos/KrauseFx/fastlane/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/KrauseFx/fastlane/statuses/1ff8155134a97dd8044ec9b6517e398b62200bfe"}}}}