{"action":"created","comment":{"url":"https://api.github.com/repos/percolate/bfh/pulls/comments/40565947","id":40565947,"diff_hunk":"@@ -325,29 +356,106 @@ class Consistent(Mapping):\n \n     def test_empty_fields_serialize_as_none_valid_or_no(self):\n         \"\"\"We aren't making assumptions here. Call validate if you want it.\"\"\"\n-        class FirstSchema(Schema):\n-            wow = IntegerField(required=True)\n-            umm = IntegerField(required=False)\n+        first_schema, other_schema, my_map = set_up_schemas()\n+        source = first_schema(wow=1)","path":"tests/test_bfh.py","position":60,"original_position":60,"commit_id":"d603a8ad3657d48b16e25c4f6656ac8a4c9b43d6","original_commit_id":"d603a8ad3657d48b16e25c4f6656ac8a4c9b43d6","user":{"login":"benauthor","id":482743,"avatar_url":"https://avatars.githubusercontent.com/u/482743?v=3","gravatar_id":"","url":"https://api.github.com/users/benauthor","html_url":"https://github.com/benauthor","followers_url":"https://api.github.com/users/benauthor/followers","following_url":"https://api.github.com/users/benauthor/following{/other_user}","gists_url":"https://api.github.com/users/benauthor/gists{/gist_id}","starred_url":"https://api.github.com/users/benauthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benauthor/subscriptions","organizations_url":"https://api.github.com/users/benauthor/orgs","repos_url":"https://api.github.com/users/benauthor/repos","events_url":"https://api.github.com/users/benauthor/events{/privacy}","received_events_url":"https://api.github.com/users/benauthor/received_events","type":"User","site_admin":false},"body":"Since this is new functionality on the Field class, I think that putting all these new tests in the TestMappings class is kind of a misplacement. Unittest on as low a level as possible, and add higher level integration tests sparingly, as necessary. ","created_at":"2015-09-28T15:30:01Z","updated_at":"2015-09-28T15:30:01Z","html_url":"https://github.com/percolate/bfh/pull/4#discussion_r40565947","pull_request_url":"https://api.github.com/repos/percolate/bfh/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/percolate/bfh/pulls/comments/40565947"},"html":{"href":"https://github.com/percolate/bfh/pull/4#discussion_r40565947"},"pull_request":{"href":"https://api.github.com/repos/percolate/bfh/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/percolate/bfh/pulls/4","id":45728814,"html_url":"https://github.com/percolate/bfh/pull/4","diff_url":"https://github.com/percolate/bfh/pull/4.diff","patch_url":"https://github.com/percolate/bfh/pull/4.patch","issue_url":"https://api.github.com/repos/percolate/bfh/issues/4","number":4,"state":"open","locked":false,"title":"allow for defaults in fields","user":{"login":"ydawant","id":3058333,"avatar_url":"https://avatars.githubusercontent.com/u/3058333?v=3","gravatar_id":"","url":"https://api.github.com/users/ydawant","html_url":"https://github.com/ydawant","followers_url":"https://api.github.com/users/ydawant/followers","following_url":"https://api.github.com/users/ydawant/following{/other_user}","gists_url":"https://api.github.com/users/ydawant/gists{/gist_id}","starred_url":"https://api.github.com/users/ydawant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydawant/subscriptions","organizations_url":"https://api.github.com/users/ydawant/orgs","repos_url":"https://api.github.com/users/ydawant/repos","events_url":"https://api.github.com/users/ydawant/events{/privacy}","received_events_url":"https://api.github.com/users/ydawant/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-22T23:12:40Z","updated_at":"2015-09-28T15:30:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b03661ca36ef86196d6f080c5a0e43fb0ad799","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/percolate/bfh/pulls/4/commits","review_comments_url":"https://api.github.com/repos/percolate/bfh/pulls/4/comments","review_comment_url":"https://api.github.com/repos/percolate/bfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percolate/bfh/issues/4/comments","statuses_url":"https://api.github.com/repos/percolate/bfh/statuses/d603a8ad3657d48b16e25c4f6656ac8a4c9b43d6","head":{"label":"percolate:null_values","ref":"null_values","sha":"d603a8ad3657d48b16e25c4f6656ac8a4c9b43d6","user":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"repo":{"id":39850654,"name":"bfh","full_name":"percolate/bfh","owner":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percolate/bfh","description":"A Python DSL for schema transformations","fork":false,"url":"https://api.github.com/repos/percolate/bfh","forks_url":"https://api.github.com/repos/percolate/bfh/forks","keys_url":"https://api.github.com/repos/percolate/bfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percolate/bfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percolate/bfh/teams","hooks_url":"https://api.github.com/repos/percolate/bfh/hooks","issue_events_url":"https://api.github.com/repos/percolate/bfh/issues/events{/number}","events_url":"https://api.github.com/repos/percolate/bfh/events","assignees_url":"https://api.github.com/repos/percolate/bfh/assignees{/user}","branches_url":"https://api.github.com/repos/percolate/bfh/branches{/branch}","tags_url":"https://api.github.com/repos/percolate/bfh/tags","blobs_url":"https://api.github.com/repos/percolate/bfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percolate/bfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percolate/bfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/percolate/bfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percolate/bfh/statuses/{sha}","languages_url":"https://api.github.com/repos/percolate/bfh/languages","stargazers_url":"https://api.github.com/repos/percolate/bfh/stargazers","contributors_url":"https://api.github.com/repos/percolate/bfh/contributors","subscribers_url":"https://api.github.com/repos/percolate/bfh/subscribers","subscription_url":"https://api.github.com/repos/percolate/bfh/subscription","commits_url":"https://api.github.com/repos/percolate/bfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/percolate/bfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/percolate/bfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/percolate/bfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/percolate/bfh/contents/{+path}","compare_url":"https://api.github.com/repos/percolate/bfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percolate/bfh/merges","archive_url":"https://api.github.com/repos/percolate/bfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percolate/bfh/downloads","issues_url":"https://api.github.com/repos/percolate/bfh/issues{/number}","pulls_url":"https://api.github.com/repos/percolate/bfh/pulls{/number}","milestones_url":"https://api.github.com/repos/percolate/bfh/milestones{/number}","notifications_url":"https://api.github.com/repos/percolate/bfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percolate/bfh/labels{/name}","releases_url":"https://api.github.com/repos/percolate/bfh/releases{/id}","created_at":"2015-07-28T18:22:15Z","updated_at":"2015-09-22T20:08:35Z","pushed_at":"2015-09-25T18:36:15Z","git_url":"git://github.com/percolate/bfh.git","ssh_url":"git@github.com:percolate/bfh.git","clone_url":"https://github.com/percolate/bfh.git","svn_url":"https://github.com/percolate/bfh","homepage":null,"size":256,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"percolate:master","ref":"master","sha":"3d73a6b325aaf981b1dd9b8e66e946e33274652f","user":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"repo":{"id":39850654,"name":"bfh","full_name":"percolate/bfh","owner":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percolate/bfh","description":"A Python DSL for schema transformations","fork":false,"url":"https://api.github.com/repos/percolate/bfh","forks_url":"https://api.github.com/repos/percolate/bfh/forks","keys_url":"https://api.github.com/repos/percolate/bfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percolate/bfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percolate/bfh/teams","hooks_url":"https://api.github.com/repos/percolate/bfh/hooks","issue_events_url":"https://api.github.com/repos/percolate/bfh/issues/events{/number}","events_url":"https://api.github.com/repos/percolate/bfh/events","assignees_url":"https://api.github.com/repos/percolate/bfh/assignees{/user}","branches_url":"https://api.github.com/repos/percolate/bfh/branches{/branch}","tags_url":"https://api.github.com/repos/percolate/bfh/tags","blobs_url":"https://api.github.com/repos/percolate/bfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percolate/bfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percolate/bfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/percolate/bfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percolate/bfh/statuses/{sha}","languages_url":"https://api.github.com/repos/percolate/bfh/languages","stargazers_url":"https://api.github.com/repos/percolate/bfh/stargazers","contributors_url":"https://api.github.com/repos/percolate/bfh/contributors","subscribers_url":"https://api.github.com/repos/percolate/bfh/subscribers","subscription_url":"https://api.github.com/repos/percolate/bfh/subscription","commits_url":"https://api.github.com/repos/percolate/bfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/percolate/bfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/percolate/bfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/percolate/bfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/percolate/bfh/contents/{+path}","compare_url":"https://api.github.com/repos/percolate/bfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percolate/bfh/merges","archive_url":"https://api.github.com/repos/percolate/bfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percolate/bfh/downloads","issues_url":"https://api.github.com/repos/percolate/bfh/issues{/number}","pulls_url":"https://api.github.com/repos/percolate/bfh/pulls{/number}","milestones_url":"https://api.github.com/repos/percolate/bfh/milestones{/number}","notifications_url":"https://api.github.com/repos/percolate/bfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percolate/bfh/labels{/name}","releases_url":"https://api.github.com/repos/percolate/bfh/releases{/id}","created_at":"2015-07-28T18:22:15Z","updated_at":"2015-09-22T20:08:35Z","pushed_at":"2015-09-25T18:36:15Z","git_url":"git://github.com/percolate/bfh.git","ssh_url":"git@github.com:percolate/bfh.git","clone_url":"https://github.com/percolate/bfh.git","svn_url":"https://github.com/percolate/bfh","homepage":null,"size":256,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/percolate/bfh/pulls/4"},"html":{"href":"https://github.com/percolate/bfh/pull/4"},"issue":{"href":"https://api.github.com/repos/percolate/bfh/issues/4"},"comments":{"href":"https://api.github.com/repos/percolate/bfh/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/percolate/bfh/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/percolate/bfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percolate/bfh/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/percolate/bfh/statuses/d603a8ad3657d48b16e25c4f6656ac8a4c9b43d6"}}}}