{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/32117863","id":32117863,"diff_hunk":"@@ -104,3 +105,220 @@ message CreateTableResponse {\n // service SchemaService {\n //   rpc CreateTable (CreateTableRequest) returns (CreateTableResponse);\n // }\n+\n+// TableRequestHeader is supplied with every structured API request.\n+message TableRequestHeader {\n+  // Timestamp specifies time at which read or writes should be\n+  // performed. If the timestamp is set to zero value, its value\n+  // is initialized to the wall time of the receiving gateway node.\n+  optional Timestamp timestamp = 1 [(gogoproto.nullable) = false];\n+  // CmdID is optionally specified for request idempotence\n+  // (i.e. replay protection).\n+  optional ClientCmdID cmd_id = 2 [(gogoproto.nullable) = false, (gogoproto.customname) = \"CmdID\"];\n+  // User is the originating user. Used to lookup priority when\n+  // scheduling queued operations at target node.\n+  optional string user = 5 [(gogoproto.nullable) = false];\n+  // UserPriority specifies priority multiple for non-transactional\n+  // commands. This value should be a positive integer [1, 2^31-1).\n+  // It's properly viewed as a multiple for how likely this\n+  // transaction will be to prevail if a write conflict occurs.\n+  // Commands with UserPriority=100 will be 100x less likely to be\n+  // aborted as conflicting transactions or non-transactional commands\n+  // with UserPriority=1. This value is ignored if Txn is\n+  // specified. If neither this value nor Txn is specified, the value\n+  // defaults to 1.\n+  optional int32 user_priority = 8 [default = 1];\n+  // Txn is set non-nil if a transaction is underway. To start a txn,\n+  // the first request should set this field to non-nil with name and\n+  // isolation level set as desired. The response will contain the\n+  // fully-initialized transaction with txn ID, priority, initial\n+  // timestamp, and maximum timestamp. The transaction returned in a\n+  // response is feed to the next request.\n+  optional Transaction txn = 9;\n+  // ReadConsistency specifies the consistency for read\n+  // operations. The default is CONSISTENT. This value is ignored for\n+  // write operations.\n+  optional ReadConsistencyType read_consistency = 10 [(gogoproto.nullable) = false];\n+}\n+\n+// TableResponseHeader is returned with every structured API response.\n+message TableResponseHeader {\n+  // Error is non-nil if an error occurred.\n+  optional Error error = 1;\n+  // Timestamp specifies time at which read or write actually was\n+  // performed. In the case of both reads and writes, if the timestamp\n+  // supplied to the request was 0, the wall time of the node\n+  // servicing the request will be set here. Additionally, in the case\n+  // of writes, this value may be increased from the timestamp passed\n+  // with the RequestHeader if the key being written was either read\n+  // or written more recently.\n+  //\n+  // TODO(vivek): Is this only relevant in the non-transactional case?\n+  optional Timestamp timestamp = 2 [(gogoproto.nullable) = false];\n+  // Transaction is non-nil if the request specified a non-nil\n+  // transaction. The transaction timestamp and/or priority may have\n+  // been updated, depending on the outcome of the request.\n+  optional Transaction txn = 3;\n+}\n+\n+// A TableKey represents a key into a table index.\n+message TableKey {\n+  optional string table_name = 1;\n+  // A column key component. Multiple ColumnKeys together form a key.\n+  message ColumnKey {\n+    optional string column_name = 1;\n+    optional bytes key = 2; \n+  }\n+  // The different key components from each column.\n+  repeated ColumnKey columns = 2;\n+}\n+\n+// A TableRow represents a set of column values within a table row. \n+message TableRow {\n+  message Cell {\n+    optional bytes column_name = 1;\n+    optional Value value = 2;\n+  }\n+  repeated Cell cells = 1;\n+}\n+\n+// A GetTableRequest is used to read a table row.\n+message GetTableRequest {","path":"proto/structured.proto","position":null,"original_position":90,"commit_id":"9503cd43ee476314057ad5c1e87fc7ef18342e58","original_commit_id":"2d567d3aa91e7580b9accc9616d0483beba43449","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"body":"new name convention:  <operation>Table<scope>Request/Response","created_at":"2015-06-10T13:43:02Z","updated_at":"2015-06-10T13:43:02Z","html_url":"https://github.com/cockroachdb/cockroach/pull/1325#discussion_r32117863","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/32117863"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/1325#discussion_r32117863"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325","id":37302097,"html_url":"https://github.com/cockroachdb/cockroach/pull/1325","diff_url":"https://github.com/cockroachdb/cockroach/pull/1325.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/1325.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1325","number":1325,"state":"open","locked":false,"title":"All the table request/response protobufs for data operations","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-09T21:28:40Z","updated_at":"2015-06-10T13:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e4d1ac875447dfb1cc2ee9fe8acb3ae9af3bd39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1325/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9503cd43ee476314057ad5c1e87fc7ef18342e58","head":{"label":"cockroachdb:vivek/tables","ref":"vivek/tables","sha":"9503cd43ee476314057ad5c1e87fc7ef18342e58","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-06-10T13:27:52Z","pushed_at":"2015-06-10T13:38:27Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":35585,"stargazers_count":4524,"watchers_count":4524,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":89,"forks":328,"open_issues":89,"watchers":4524,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"a2b0a20d4fe9e05399f2f751000bd991432d7585","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-06-10T13:27:52Z","pushed_at":"2015-06-10T13:38:27Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":35585,"stargazers_count":4524,"watchers_count":4524,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":89,"forks":328,"open_issues":89,"watchers":4524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/1325"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/1325"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/1325/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1325/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9503cd43ee476314057ad5c1e87fc7ef18342e58"}}}}