{"action":"created","comment":{"url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/comments/43281626","id":43281626,"diff_hunk":"@@ -0,0 +1,105 @@\n+/**\n+ * Copyright (C) 2015 BonitaSoft S.A.\n+ * BonitaSoft, 32 rue Gustave Eiffel - 38000 Grenoble\n+ * This library is free software; you can redistribute it and/or modify it under the terms\n+ * of the GNU Lesser General Public License as published by the Free Software Foundation\n+ * version 2.1 of the License.\n+ * This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;\n+ * without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n+ * See the GNU Lesser General Public License for more details.\n+ * You should have received a copy of the GNU Lesser General Public License along with this\n+ * program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth\n+ * Floor, Boston, MA 02110-1301, USA.\n+ **/\n+package org.bonitasoft.engine.parameter;\n+\n+import java.util.Objects;\n+\n+/**\n+ * @author Matthieu Chaffotte\n+ */\n+public class SParameterImpl implements SParameter {\n+\n+    private String name;\n+    private String value;\n+    private long processDefinitionId;\n+    private long id;\n+    private long tenantId;\n+\n+    public SParameterImpl() {\n+    }\n+\n+    public SParameterImpl(String name, String value, long processDefinitionId) {\n+        this.name = name;\n+        this.value = value;\n+        this.processDefinitionId = processDefinitionId;\n+    }\n+\n+    @Override\n+    public long getId() {\n+        return id;\n+    }\n+\n+    public long getTenantId() {\n+        return tenantId;\n+    }\n+\n+    @Override\n+    public String getDiscriminator() {\n+        return null;","path":"bpm/bonita-core/bonita-parameter/bonita-parameter-impl/src/main/java/org/bonitasoft/engine/parameter/SParameterImpl.java","position":49,"original_position":49,"commit_id":"e64c089ba0b3fbab2dd08207166f4e5c5f07f506","original_commit_id":"e64c089ba0b3fbab2dd08207166f4e5c5f07f506","user":{"login":"educhastenier","id":4921958,"avatar_url":"https://avatars.githubusercontent.com/u/4921958?v=3","gravatar_id":"","url":"https://api.github.com/users/educhastenier","html_url":"https://github.com/educhastenier","followers_url":"https://api.github.com/users/educhastenier/followers","following_url":"https://api.github.com/users/educhastenier/following{/other_user}","gists_url":"https://api.github.com/users/educhastenier/gists{/gist_id}","starred_url":"https://api.github.com/users/educhastenier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/educhastenier/subscriptions","organizations_url":"https://api.github.com/users/educhastenier/orgs","repos_url":"https://api.github.com/users/educhastenier/repos","events_url":"https://api.github.com/users/educhastenier/events{/privacy}","received_events_url":"https://api.github.com/users/educhastenier/received_events","type":"User","site_admin":false},"body":"What are the consequences of returning null?","created_at":"2015-10-28T16:37:05Z","updated_at":"2015-10-28T16:37:05Z","html_url":"https://github.com/bonitasoft/bonita-engine/pull/190#discussion_r43281626","pull_request_url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/comments/43281626"},"html":{"href":"https://github.com/bonitasoft/bonita-engine/pull/190#discussion_r43281626"},"pull_request":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190","id":48044260,"html_url":"https://github.com/bonitasoft/bonita-engine/pull/190","diff_url":"https://github.com/bonitasoft/bonita-engine/pull/190.diff","patch_url":"https://github.com/bonitasoft/bonita-engine/pull/190.patch","issue_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/190","number":190,"state":"open","locked":false,"title":"Put parameters in database","user":{"login":"baptistemesta","id":2739234,"avatar_url":"https://avatars.githubusercontent.com/u/2739234?v=3","gravatar_id":"","url":"https://api.github.com/users/baptistemesta","html_url":"https://github.com/baptistemesta","followers_url":"https://api.github.com/users/baptistemesta/followers","following_url":"https://api.github.com/users/baptistemesta/following{/other_user}","gists_url":"https://api.github.com/users/baptistemesta/gists{/gist_id}","starred_url":"https://api.github.com/users/baptistemesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baptistemesta/subscriptions","organizations_url":"https://api.github.com/users/baptistemesta/orgs","repos_url":"https://api.github.com/users/baptistemesta/repos","events_url":"https://api.github.com/users/baptistemesta/events{/privacy}","received_events_url":"https://api.github.com/users/baptistemesta/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-19T08:42:52Z","updated_at":"2015-10-28T16:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0d7cc62a8e8325e5a4e6369945a72beb3648f78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190/commits","review_comments_url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190/comments","review_comment_url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/190/comments","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-engine/statuses/e64c089ba0b3fbab2dd08207166f4e5c5f07f506","head":{"label":"bonitasoft:parameters_in_db","ref":"parameters_in_db","sha":"e64c089ba0b3fbab2dd08207166f4e5c5f07f506","user":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"repo":{"id":11125081,"name":"bonita-engine","full_name":"bonitasoft/bonita-engine","owner":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonitasoft/bonita-engine","description":"","fork":false,"url":"https://api.github.com/repos/bonitasoft/bonita-engine","forks_url":"https://api.github.com/repos/bonitasoft/bonita-engine/forks","keys_url":"https://api.github.com/repos/bonitasoft/bonita-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonitasoft/bonita-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonitasoft/bonita-engine/teams","hooks_url":"https://api.github.com/repos/bonitasoft/bonita-engine/hooks","issue_events_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/events{/number}","events_url":"https://api.github.com/repos/bonitasoft/bonita-engine/events","assignees_url":"https://api.github.com/repos/bonitasoft/bonita-engine/assignees{/user}","branches_url":"https://api.github.com/repos/bonitasoft/bonita-engine/branches{/branch}","tags_url":"https://api.github.com/repos/bonitasoft/bonita-engine/tags","blobs_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/bonitasoft/bonita-engine/languages","stargazers_url":"https://api.github.com/repos/bonitasoft/bonita-engine/stargazers","contributors_url":"https://api.github.com/repos/bonitasoft/bonita-engine/contributors","subscribers_url":"https://api.github.com/repos/bonitasoft/bonita-engine/subscribers","subscription_url":"https://api.github.com/repos/bonitasoft/bonita-engine/subscription","commits_url":"https://api.github.com/repos/bonitasoft/bonita-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonitasoft/bonita-engine/contents/{+path}","compare_url":"https://api.github.com/repos/bonitasoft/bonita-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonitasoft/bonita-engine/merges","archive_url":"https://api.github.com/repos/bonitasoft/bonita-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonitasoft/bonita-engine/downloads","issues_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues{/number}","pulls_url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/bonitasoft/bonita-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/bonitasoft/bonita-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonitasoft/bonita-engine/labels{/name}","releases_url":"https://api.github.com/repos/bonitasoft/bonita-engine/releases{/id}","created_at":"2013-07-02T13:06:27Z","updated_at":"2015-09-28T11:51:41Z","pushed_at":"2015-10-28T15:20:26Z","git_url":"git://github.com/bonitasoft/bonita-engine.git","ssh_url":"git@github.com:bonitasoft/bonita-engine.git","clone_url":"https://github.com/bonitasoft/bonita-engine.git","svn_url":"https://github.com/bonitasoft/bonita-engine","homepage":"http://community.bonitasoft.com/","size":540378,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":8,"forks":39,"open_issues":8,"watchers":36,"default_branch":"master"}},"base":{"label":"bonitasoft:CoreProduct","ref":"CoreProduct","sha":"da804ed43def64d4559b5b588acdbf038d3c1436","user":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"repo":{"id":11125081,"name":"bonita-engine","full_name":"bonitasoft/bonita-engine","owner":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonitasoft/bonita-engine","description":"","fork":false,"url":"https://api.github.com/repos/bonitasoft/bonita-engine","forks_url":"https://api.github.com/repos/bonitasoft/bonita-engine/forks","keys_url":"https://api.github.com/repos/bonitasoft/bonita-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonitasoft/bonita-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonitasoft/bonita-engine/teams","hooks_url":"https://api.github.com/repos/bonitasoft/bonita-engine/hooks","issue_events_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/events{/number}","events_url":"https://api.github.com/repos/bonitasoft/bonita-engine/events","assignees_url":"https://api.github.com/repos/bonitasoft/bonita-engine/assignees{/user}","branches_url":"https://api.github.com/repos/bonitasoft/bonita-engine/branches{/branch}","tags_url":"https://api.github.com/repos/bonitasoft/bonita-engine/tags","blobs_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/bonitasoft/bonita-engine/languages","stargazers_url":"https://api.github.com/repos/bonitasoft/bonita-engine/stargazers","contributors_url":"https://api.github.com/repos/bonitasoft/bonita-engine/contributors","subscribers_url":"https://api.github.com/repos/bonitasoft/bonita-engine/subscribers","subscription_url":"https://api.github.com/repos/bonitasoft/bonita-engine/subscription","commits_url":"https://api.github.com/repos/bonitasoft/bonita-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonitasoft/bonita-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonitasoft/bonita-engine/contents/{+path}","compare_url":"https://api.github.com/repos/bonitasoft/bonita-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonitasoft/bonita-engine/merges","archive_url":"https://api.github.com/repos/bonitasoft/bonita-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonitasoft/bonita-engine/downloads","issues_url":"https://api.github.com/repos/bonitasoft/bonita-engine/issues{/number}","pulls_url":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/bonitasoft/bonita-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/bonitasoft/bonita-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonitasoft/bonita-engine/labels{/name}","releases_url":"https://api.github.com/repos/bonitasoft/bonita-engine/releases{/id}","created_at":"2013-07-02T13:06:27Z","updated_at":"2015-09-28T11:51:41Z","pushed_at":"2015-10-28T15:20:26Z","git_url":"git://github.com/bonitasoft/bonita-engine.git","ssh_url":"git@github.com:bonitasoft/bonita-engine.git","clone_url":"https://github.com/bonitasoft/bonita-engine.git","svn_url":"https://github.com/bonitasoft/bonita-engine","homepage":"http://community.bonitasoft.com/","size":540378,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":8,"forks":39,"open_issues":8,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190"},"html":{"href":"https://github.com/bonitasoft/bonita-engine/pull/190"},"issue":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/190"},"comments":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/bonitasoft/bonita-engine/statuses/e64c089ba0b3fbab2dd08207166f4e5c5f07f506"}}}}