{"action":"created","comment":{"url":"https://api.github.com/repos/mochajs/mocha/pulls/comments/31872707","id":31872707,"diff_hunk":"@@ -1,4 +1,5 @@\n \n+BROWSERIFY := node_modules/.bin/browserify","path":"Makefile","position":2,"original_position":2,"commit_id":"a795799155ff0a7f7d6968f6a7710051e7502913","original_commit_id":"eeba7eb573be6d6048bd88ad572fd7d257efedbb","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"body":"No clue, I can repro it in my other local repos, but not in my local Mocha repo. Weird.\r\n\r\nI also prefer the explicit path just because I keep global installations of some binaries (e.g. ESLint) installed for editor integrations, etc. and like to be sure there's nothing funky going on, like a missing local dependency triggering errors because it's falling back on a global installation, which is a heinous thing to debug. More verbose for fewer terrible things to debug, but maybe that's crossed over into paranoia territory.\r\n\r\nAnyway, it's working locally so I don't mind either way","created_at":"2015-06-07T00:37:31Z","updated_at":"2015-06-07T00:37:31Z","html_url":"https://github.com/mochajs/mocha/pull/1727#discussion_r31872707","pull_request_url":"https://api.github.com/repos/mochajs/mocha/pulls/1727","_links":{"self":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/comments/31872707"},"html":{"href":"https://github.com/mochajs/mocha/pull/1727#discussion_r31872707"},"pull_request":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1727"}}},"pull_request":{"url":"https://api.github.com/repos/mochajs/mocha/pulls/1727","id":37097591,"html_url":"https://github.com/mochajs/mocha/pull/1727","diff_url":"https://github.com/mochajs/mocha/pull/1727.diff","patch_url":"https://github.com/mochajs/mocha/pull/1727.patch","issue_url":"https://api.github.com/repos/mochajs/mocha/issues/1727","number":1727,"state":"open","locked":false,"title":"Build client-side Mocha using Browserify","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"body":"paging @boneskull, @travisjeffery \r\n\r\nStill needs some work before merging but wanted to put it out there early since it seems like a better build process is eating up time and making stuff like the [plugin API](https://github.com/mochajs/mocha/issues/1457) and [breaking reporters out into npm-land](https://github.com/mochajs/mocha/issues/509) difficult.\r\n\r\nOutstanding issues:\r\n\r\n- Still some cleanup to do, current transition is a little messy. And I bet we can remove a few more shims like `lib/browser/events`.\r\n- Did super cursory testing in the browser and even more cursory at the command line; would want to stress test this a bit more before merging.\r\n- The built Browserify file is still a lot larger than the current build process (~148k currently, 209k under Browserify). Haven't looked into this too deeply yet.\r\n- Browserified file includes all the reporters, which [@tj said](https://github.com/mochajs/mocha/issues/509#issuecomment-48804936) shouldn't happen anyway. I think, though, that removing them would break [mocha-phantomjs](https://github.com/metaskills/mocha-phantomjs); @metaskills, is that right? Is that something to be concerned about?\r\n\r\nWill follow up on these in the next day or so, when I get a bit more time.\r\n\r\n----------\r\n\r\nRelated issues:\r\n- https://github.com/mochajs/mocha/issues/1193\r\n- https://github.com/mochajs/mocha/pull/1260\r\n- https://github.com/mochajs/mocha/pull/1559\r\n- https://github.com/mochajs/mocha/issues/880 (this PR skips Jade in Browserify via `--ignore jade`, which I think was causing @jonathanong's issue back in #1260)\r\n\r\nTangentially related:\r\n- https://github.com/mochajs/mocha/issues/1457","created_at":"2015-06-06T22:11:33Z","updated_at":"2015-06-07T00:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"145837d64935eca201b9bfb8e9a77e234ad7dbf4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mochajs/mocha/pulls/1727/commits","review_comments_url":"https://api.github.com/repos/mochajs/mocha/pulls/1727/comments","review_comment_url":"https://api.github.com/repos/mochajs/mocha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mochajs/mocha/issues/1727/comments","statuses_url":"https://api.github.com/repos/mochajs/mocha/statuses/a795799155ff0a7f7d6968f6a7710051e7502913","head":{"label":"ndhoule:chore/browserify","ref":"chore/browserify","sha":"a795799155ff0a7f7d6968f6a7710051e7502913","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"repo":{"id":36967901,"name":"mocha","full_name":"ndhoule/mocha","owner":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndhoule/mocha","description":"mocha - simple, flexible, fun javascript test framework for node.js & the browser. (BDD, TDD, QUnit styles via interfaces)","fork":true,"url":"https://api.github.com/repos/ndhoule/mocha","forks_url":"https://api.github.com/repos/ndhoule/mocha/forks","keys_url":"https://api.github.com/repos/ndhoule/mocha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndhoule/mocha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndhoule/mocha/teams","hooks_url":"https://api.github.com/repos/ndhoule/mocha/hooks","issue_events_url":"https://api.github.com/repos/ndhoule/mocha/issues/events{/number}","events_url":"https://api.github.com/repos/ndhoule/mocha/events","assignees_url":"https://api.github.com/repos/ndhoule/mocha/assignees{/user}","branches_url":"https://api.github.com/repos/ndhoule/mocha/branches{/branch}","tags_url":"https://api.github.com/repos/ndhoule/mocha/tags","blobs_url":"https://api.github.com/repos/ndhoule/mocha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndhoule/mocha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndhoule/mocha/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndhoule/mocha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndhoule/mocha/statuses/{sha}","languages_url":"https://api.github.com/repos/ndhoule/mocha/languages","stargazers_url":"https://api.github.com/repos/ndhoule/mocha/stargazers","contributors_url":"https://api.github.com/repos/ndhoule/mocha/contributors","subscribers_url":"https://api.github.com/repos/ndhoule/mocha/subscribers","subscription_url":"https://api.github.com/repos/ndhoule/mocha/subscription","commits_url":"https://api.github.com/repos/ndhoule/mocha/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndhoule/mocha/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndhoule/mocha/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndhoule/mocha/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndhoule/mocha/contents/{+path}","compare_url":"https://api.github.com/repos/ndhoule/mocha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndhoule/mocha/merges","archive_url":"https://api.github.com/repos/ndhoule/mocha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndhoule/mocha/downloads","issues_url":"https://api.github.com/repos/ndhoule/mocha/issues{/number}","pulls_url":"https://api.github.com/repos/ndhoule/mocha/pulls{/number}","milestones_url":"https://api.github.com/repos/ndhoule/mocha/milestones{/number}","notifications_url":"https://api.github.com/repos/ndhoule/mocha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndhoule/mocha/labels{/name}","releases_url":"https://api.github.com/repos/ndhoule/mocha/releases{/id}","created_at":"2015-06-06T04:54:57Z","updated_at":"2015-06-06T04:54:59Z","pushed_at":"2015-06-07T00:12:56Z","git_url":"git://github.com/ndhoule/mocha.git","ssh_url":"git@github.com:ndhoule/mocha.git","clone_url":"https://github.com/ndhoule/mocha.git","svn_url":"https://github.com/ndhoule/mocha","homepage":"http://mochajs.org","size":5065,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mochajs:master","ref":"master","sha":"d71a5c6e0f17ab5b530388edf5b8cfb71ed75d33","user":{"login":"mochajs","id":8770005,"avatar_url":"https://avatars.githubusercontent.com/u/8770005?v=3","gravatar_id":"","url":"https://api.github.com/users/mochajs","html_url":"https://github.com/mochajs","followers_url":"https://api.github.com/users/mochajs/followers","following_url":"https://api.github.com/users/mochajs/following{/other_user}","gists_url":"https://api.github.com/users/mochajs/gists{/gist_id}","starred_url":"https://api.github.com/users/mochajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mochajs/subscriptions","organizations_url":"https://api.github.com/users/mochajs/orgs","repos_url":"https://api.github.com/users/mochajs/repos","events_url":"https://api.github.com/users/mochajs/events{/privacy}","received_events_url":"https://api.github.com/users/mochajs/received_events","type":"Organization","site_admin":false},"repo":{"id":1451352,"name":"mocha","full_name":"mochajs/mocha","owner":{"login":"mochajs","id":8770005,"avatar_url":"https://avatars.githubusercontent.com/u/8770005?v=3","gravatar_id":"","url":"https://api.github.com/users/mochajs","html_url":"https://github.com/mochajs","followers_url":"https://api.github.com/users/mochajs/followers","following_url":"https://api.github.com/users/mochajs/following{/other_user}","gists_url":"https://api.github.com/users/mochajs/gists{/gist_id}","starred_url":"https://api.github.com/users/mochajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mochajs/subscriptions","organizations_url":"https://api.github.com/users/mochajs/orgs","repos_url":"https://api.github.com/users/mochajs/repos","events_url":"https://api.github.com/users/mochajs/events{/privacy}","received_events_url":"https://api.github.com/users/mochajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mochajs/mocha","description":"mocha - simple, flexible, fun javascript test framework for node.js & the browser. (BDD, TDD, QUnit styles via interfaces)","fork":false,"url":"https://api.github.com/repos/mochajs/mocha","forks_url":"https://api.github.com/repos/mochajs/mocha/forks","keys_url":"https://api.github.com/repos/mochajs/mocha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mochajs/mocha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mochajs/mocha/teams","hooks_url":"https://api.github.com/repos/mochajs/mocha/hooks","issue_events_url":"https://api.github.com/repos/mochajs/mocha/issues/events{/number}","events_url":"https://api.github.com/repos/mochajs/mocha/events","assignees_url":"https://api.github.com/repos/mochajs/mocha/assignees{/user}","branches_url":"https://api.github.com/repos/mochajs/mocha/branches{/branch}","tags_url":"https://api.github.com/repos/mochajs/mocha/tags","blobs_url":"https://api.github.com/repos/mochajs/mocha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mochajs/mocha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mochajs/mocha/git/refs{/sha}","trees_url":"https://api.github.com/repos/mochajs/mocha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mochajs/mocha/statuses/{sha}","languages_url":"https://api.github.com/repos/mochajs/mocha/languages","stargazers_url":"https://api.github.com/repos/mochajs/mocha/stargazers","contributors_url":"https://api.github.com/repos/mochajs/mocha/contributors","subscribers_url":"https://api.github.com/repos/mochajs/mocha/subscribers","subscription_url":"https://api.github.com/repos/mochajs/mocha/subscription","commits_url":"https://api.github.com/repos/mochajs/mocha/commits{/sha}","git_commits_url":"https://api.github.com/repos/mochajs/mocha/git/commits{/sha}","comments_url":"https://api.github.com/repos/mochajs/mocha/comments{/number}","issue_comment_url":"https://api.github.com/repos/mochajs/mocha/issues/comments{/number}","contents_url":"https://api.github.com/repos/mochajs/mocha/contents/{+path}","compare_url":"https://api.github.com/repos/mochajs/mocha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mochajs/mocha/merges","archive_url":"https://api.github.com/repos/mochajs/mocha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mochajs/mocha/downloads","issues_url":"https://api.github.com/repos/mochajs/mocha/issues{/number}","pulls_url":"https://api.github.com/repos/mochajs/mocha/pulls{/number}","milestones_url":"https://api.github.com/repos/mochajs/mocha/milestones{/number}","notifications_url":"https://api.github.com/repos/mochajs/mocha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mochajs/mocha/labels{/name}","releases_url":"https://api.github.com/repos/mochajs/mocha/releases{/id}","created_at":"2011-03-07T18:44:25Z","updated_at":"2015-06-06T21:54:26Z","pushed_at":"2015-06-07T00:12:58Z","git_url":"git://github.com/mochajs/mocha.git","ssh_url":"git@github.com:mochajs/mocha.git","clone_url":"https://github.com/mochajs/mocha.git","svn_url":"https://github.com/mochajs/mocha","homepage":"http://mochajs.org","size":12561,"stargazers_count":6761,"watchers_count":6761,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1058,"mirror_url":null,"open_issues_count":152,"forks":1058,"open_issues":152,"watchers":6761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1727"},"html":{"href":"https://github.com/mochajs/mocha/pull/1727"},"issue":{"href":"https://api.github.com/repos/mochajs/mocha/issues/1727"},"comments":{"href":"https://api.github.com/repos/mochajs/mocha/issues/1727/comments"},"review_comments":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1727/comments"},"review_comment":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1727/commits"},"statuses":{"href":"https://api.github.com/repos/mochajs/mocha/statuses/a795799155ff0a7f7d6968f6a7710051e7502913"}}}}