{"action":"created","comment":{"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/comments/40064302","id":40064302,"diff_hunk":"@@ -24,13 +24,28 @@ class Contact < ActiveRecord::Base\n \n   belongs_to :party, inverse_of: :contacts\n \n-  has_many :contact_phone_numbers\n-\n-  has_many :phone_numbers,\n-           through: :contact_phone_numbers,\n-           inverse_of: :contacts\n+  has_many :phone_numbers","path":"app/models/contact.rb","position":9,"original_position":9,"commit_id":"09fc20ec52f788ac352ea436d1c64366c0e18dc0","original_commit_id":"09fc20ec52f788ac352ea436d1c64366c0e18dc0","user":{"login":"Cruikshanks","id":1789650,"avatar_url":"https://avatars.githubusercontent.com/u/1789650?v=3","gravatar_id":"","url":"https://api.github.com/users/Cruikshanks","html_url":"https://github.com/Cruikshanks","followers_url":"https://api.github.com/users/Cruikshanks/followers","following_url":"https://api.github.com/users/Cruikshanks/following{/other_user}","gists_url":"https://api.github.com/users/Cruikshanks/gists{/gist_id}","starred_url":"https://api.github.com/users/Cruikshanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cruikshanks/subscriptions","organizations_url":"https://api.github.com/users/Cruikshanks/orgs","repos_url":"https://api.github.com/users/Cruikshanks/repos","events_url":"https://api.github.com/users/Cruikshanks/events{/privacy}","received_events_url":"https://api.github.com/users/Cruikshanks/received_events","type":"User","site_admin":false},"body":"Was going to start writing a bunch of questions based on how I currently foresee this working, however this is one that would truly benefit from a 5 minute chat. Will arrange.","created_at":"2015-09-22T08:51:38Z","updated_at":"2015-09-22T08:51:38Z","html_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/34#discussion_r40064302","pull_request_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/comments/40064302"},"html":{"href":"https://github.com/EnvironmentAgency/waste-exemptions/pull/34#discussion_r40064302"},"pull_request":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34","id":45572368,"html_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/34","diff_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/34.diff","patch_url":"https://github.com/EnvironmentAgency/waste-exemptions/pull/34.patch","issue_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/34","number":34,"state":"open","locked":false,"title":"Feature/contact details","user":{"login":"autotelik","id":110434,"avatar_url":"https://avatars.githubusercontent.com/u/110434?v=3","gravatar_id":"","url":"https://api.github.com/users/autotelik","html_url":"https://github.com/autotelik","followers_url":"https://api.github.com/users/autotelik/followers","following_url":"https://api.github.com/users/autotelik/following{/other_user}","gists_url":"https://api.github.com/users/autotelik/gists{/gist_id}","starred_url":"https://api.github.com/users/autotelik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotelik/subscriptions","organizations_url":"https://api.github.com/users/autotelik/orgs","repos_url":"https://api.github.com/users/autotelik/repos","events_url":"https://api.github.com/users/autotelik/events{/privacy}","received_events_url":"https://api.github.com/users/autotelik/received_events","type":"User","site_admin":false},"body":"**This PR**\r\nCompletes WAS-326 - Contact details page: complete the full stack\r\n\r\nFactories for Contact/Phone Number, page object, rspec in place. \r\nView for applicant contact page\r\nImprovements to models Contact and PhoneNumber\r\nSpecs for Contact and Phone number\r\nUpdate gemspec so it ignores minor versions.\r\nValidations with locale messages\r\nValidation as per content doc. Ready for QA\r\n","created_at":"2015-09-21T16:51:51Z","updated_at":"2015-09-22T08:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beaca7c15e2d0291d2a2353da0625d6f4419534e","assignee":{"login":"Cruikshanks","id":1789650,"avatar_url":"https://avatars.githubusercontent.com/u/1789650?v=3","gravatar_id":"","url":"https://api.github.com/users/Cruikshanks","html_url":"https://github.com/Cruikshanks","followers_url":"https://api.github.com/users/Cruikshanks/followers","following_url":"https://api.github.com/users/Cruikshanks/following{/other_user}","gists_url":"https://api.github.com/users/Cruikshanks/gists{/gist_id}","starred_url":"https://api.github.com/users/Cruikshanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cruikshanks/subscriptions","organizations_url":"https://api.github.com/users/Cruikshanks/orgs","repos_url":"https://api.github.com/users/Cruikshanks/repos","events_url":"https://api.github.com/users/Cruikshanks/events{/privacy}","received_events_url":"https://api.github.com/users/Cruikshanks/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34/commits","review_comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34/comments","review_comment_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/34/comments","statuses_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/09fc20ec52f788ac352ea436d1c64366c0e18dc0","head":{"label":"EnvironmentAgency:feature/contact_details","ref":"feature/contact_details","sha":"09fc20ec52f788ac352ea436d1c64366c0e18dc0","user":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":36930252,"name":"waste-exemptions","full_name":"EnvironmentAgency/waste-exemptions","owner":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnvironmentAgency/waste-exemptions","description":"Waste Exemptions frontend code","fork":false,"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions","forks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/forks","keys_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/teams","hooks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/hooks","issue_events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/events{/number}","events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/events","assignees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/assignees{/user}","branches_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/branches{/branch}","tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/tags","blobs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/{sha}","languages_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/languages","stargazers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/stargazers","contributors_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contributors","subscribers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscribers","subscription_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscription","commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contents/{+path}","compare_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/merges","archive_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/downloads","issues_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues{/number}","pulls_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls{/number}","milestones_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/milestones{/number}","notifications_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/labels{/name}","releases_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/releases{/id}","created_at":"2015-06-05T11:55:29Z","updated_at":"2015-06-10T08:46:07Z","pushed_at":"2015-09-21T17:08:09Z","git_url":"git://github.com/EnvironmentAgency/waste-exemptions.git","ssh_url":"git@github.com:EnvironmentAgency/waste-exemptions.git","clone_url":"https://github.com/EnvironmentAgency/waste-exemptions.git","svn_url":"https://github.com/EnvironmentAgency/waste-exemptions","homepage":null,"size":1816,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"EnvironmentAgency:develop","ref":"develop","sha":"666269ad2f9ada36196c943b14bfd4ca6191a05b","user":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":36930252,"name":"waste-exemptions","full_name":"EnvironmentAgency/waste-exemptions","owner":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnvironmentAgency/waste-exemptions","description":"Waste Exemptions frontend code","fork":false,"url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions","forks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/forks","keys_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/teams","hooks_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/hooks","issue_events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/events{/number}","events_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/events","assignees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/assignees{/user}","branches_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/branches{/branch}","tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/tags","blobs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/{sha}","languages_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/languages","stargazers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/stargazers","contributors_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contributors","subscribers_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscribers","subscription_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/subscription","commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/contents/{+path}","compare_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/merges","archive_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/downloads","issues_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues{/number}","pulls_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls{/number}","milestones_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/milestones{/number}","notifications_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/labels{/name}","releases_url":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/releases{/id}","created_at":"2015-06-05T11:55:29Z","updated_at":"2015-06-10T08:46:07Z","pushed_at":"2015-09-21T17:08:09Z","git_url":"git://github.com/EnvironmentAgency/waste-exemptions.git","ssh_url":"git@github.com:EnvironmentAgency/waste-exemptions.git","clone_url":"https://github.com/EnvironmentAgency/waste-exemptions.git","svn_url":"https://github.com/EnvironmentAgency/waste-exemptions","homepage":null,"size":1816,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34"},"html":{"href":"https://github.com/EnvironmentAgency/waste-exemptions/pull/34"},"issue":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/34"},"comments":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/EnvironmentAgency/waste-exemptions/statuses/09fc20ec52f788ac352ea436d1c64366c0e18dc0"}}}}