{"action":"created","issue":{"url":"https://api.github.com/repos/pulp/pulp_puppet/issues/198","labels_url":"https://api.github.com/repos/pulp/pulp_puppet/issues/198/labels{/name}","comments_url":"https://api.github.com/repos/pulp/pulp_puppet/issues/198/comments","events_url":"https://api.github.com/repos/pulp/pulp_puppet/issues/198/events","html_url":"https://github.com/pulp/pulp_puppet/pull/198","id":113967197,"number":198,"title":"Install distributor now normalizes uid, gid, and filesystem permissions.","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars.githubusercontent.com/u/53091?v=3","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pulp/pulp_puppet/labels/LGTM","name":"LGTM","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars.githubusercontent.com/u/53091?v=3","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-29T02:49:09Z","updated_at":"2015-11-04T00:41:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pulp/pulp_puppet/pulls/198","html_url":"https://github.com/pulp/pulp_puppet/pull/198","diff_url":"https://github.com/pulp/pulp_puppet/pull/198.diff","patch_url":"https://github.com/pulp/pulp_puppet/pull/198.patch"},"body":"Also resurrected a bunch of unit tests for the install distributor that had\r\nbeen removed during the mongoengine conversion.\r\n\r\nfixes #1289\r\n\r\nhttps://pulp.plan.io/issues/1289"},"comment":{"url":"https://api.github.com/repos/pulp/pulp_puppet/issues/comments/153534876","html_url":"https://github.com/pulp/pulp_puppet/pull/198#issuecomment-153534876","issue_url":"https://api.github.com/repos/pulp/pulp_puppet/issues/198","id":153534876,"user":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars.githubusercontent.com/u/53091?v=3","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T00:41:20Z","updated_at":"2015-11-04T00:41:20Z","body":"The additional tests are actually very related. They are tests for the area whose behavior I was changing, albeit with a change to only one line. The area I was changing had very low test coverage, so I just resurrected and fixed the tests that got removed recently in the mongoengine conversion.\r\n\r\nI could submit a PR resurrecting those tests, then submit a second PR fixing the bug and changing those tests to reflect the changed behavior. But given that it's such a targeted area, I don't think that's worth the time and effort."}}