{"action":"created","issue":{"url":"https://api.github.com/repos/quickfix-j/quickfixj/issues/49","labels_url":"https://api.github.com/repos/quickfix-j/quickfixj/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/quickfix-j/quickfixj/issues/49/comments","events_url":"https://api.github.com/repos/quickfix-j/quickfixj/issues/49/events","html_url":"https://github.com/quickfix-j/quickfixj/pull/49","id":121342286,"number":49,"title":"QFJ-821 - acceptor/initiator certificate authentication","user":{"login":"the-thing","id":3160158,"avatar_url":"https://avatars.githubusercontent.com/u/3160158?v=3","gravatar_id":"","url":"https://api.github.com/users/the-thing","html_url":"https://github.com/the-thing","followers_url":"https://api.github.com/users/the-thing/followers","following_url":"https://api.github.com/users/the-thing/following{/other_user}","gists_url":"https://api.github.com/users/the-thing/gists{/gist_id}","starred_url":"https://api.github.com/users/the-thing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-thing/subscriptions","organizations_url":"https://api.github.com/users/the-thing/orgs","repos_url":"https://api.github.com/users/the-thing/repos","events_url":"https://api.github.com/users/the-thing/events{/privacy}","received_events_url":"https://api.github.com/users/the-thing/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-09T21:27:04Z","updated_at":"2015-12-22T00:10:16Z","closed_at":"2015-12-18T23:57:46Z","pull_request":{"url":"https://api.github.com/repos/quickfix-j/quickfixj/pulls/49","html_url":"https://github.com/quickfix-j/quickfixj/pull/49","diff_url":"https://github.com/quickfix-j/quickfixj/pull/49.diff","patch_url":"https://github.com/quickfix-j/quickfixj/pull/49.patch"},"body":"Implemented acceptor/initiator certificate authentication.\r\n\r\n- new SSL properties:\r\nKeyManagerFactoryAlgorithm (default X509)\r\nKeyStoreType (default JKS)\r\nSocketTrustStore\r\nSocketTrustStorePassword\r\nTrustManagerFactoryAlgorithm (default PKIX)\r\nTrustStoreType (default JKS)\r\nNeedClientAuth (default N)\r\nEnabledProtocols (default - Java supported protocols)\r\nCipherSuites (default - Java default cipher suites)\r\n\r\n- removed quickifx.mina.ssl.SimpleTrustManagerFactory class as there is no need for it, MINA provides org.apache.mina.filter.ssl.BogusTrustManagerFactory which\r\nserves the same purpose\r\n\r\n- added quickfix.mina.ssl.SSLFilter class which fixes issues with MINA overriding cipher suites to Java enabled cipher suites\r\n\r\n- comprehensive tests under quickfix.mina.ssl.SSLCertificateTest\r\n\r\n- QFJ-838 and QFJ-854 had to be fix along the way as I encountered the same problems"},"comment":{"url":"https://api.github.com/repos/quickfix-j/quickfixj/issues/comments/166463926","html_url":"https://github.com/quickfix-j/quickfixj/pull/49#issuecomment-166463926","issue_url":"https://api.github.com/repos/quickfix-j/quickfixj/issues/49","id":166463926,"user":{"login":"chrjohn","id":6644028,"avatar_url":"https://avatars.githubusercontent.com/u/6644028?v=3","gravatar_id":"","url":"https://api.github.com/users/chrjohn","html_url":"https://github.com/chrjohn","followers_url":"https://api.github.com/users/chrjohn/followers","following_url":"https://api.github.com/users/chrjohn/following{/other_user}","gists_url":"https://api.github.com/users/chrjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/chrjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrjohn/subscriptions","organizations_url":"https://api.github.com/users/chrjohn/orgs","repos_url":"https://api.github.com/users/chrjohn/repos","events_url":"https://api.github.com/users/chrjohn/events{/privacy}","received_events_url":"https://api.github.com/users/chrjohn/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T00:10:16Z","updated_at":"2015-12-22T00:10:16Z","body":"Hmm, cannot reproduce the errors on my local environment. Will try again on Bamboo."}}