{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments/47385925","id":47385925,"diff_hunk":"@@ -59,6 +59,26 @@ macro(defoption name doc default)\n     option(${name} ${doc} ${enabled})\n endmacro()\n \n+# Usage: leatherman_install(TARGETS)\n+#\n+# Installs targets using common cross-platform configuration.\n+# On Windows shared libraries go in bin, import and archive libraries\n+# go in lib. On Linux shared libraries go in lib. Binaries go in bin.\n+#\n+# Also always drop the prefix; give the target its expected name.\n+# We often have binaries and related dynamic libraries, and this\n+# simplifies giving them different but related names, such as\n+# `facter` and `libfacter`.\n+macro(leatherman_install)\n+    install(TARGETS ${ARGV}\n+        RUNTIME DESTINATION bin","path":"cmake/leatherman.cmake","position":16,"original_position":16,"commit_id":"41f5a8bc04cf7e25477138ac0198cdf1ef37eb3b","original_commit_id":"41f5a8bc04cf7e25477138ac0198cdf1ef37eb3b","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"It might be useful to update it to support https://github.com/puppetlabs/facter/pull/1228.","created_at":"2015-12-11T18:17:39Z","updated_at":"2015-12-11T18:17:39Z","html_url":"https://github.com/puppetlabs/leatherman/pull/109#discussion_r47385925","pull_request_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments/47385925"},"html":{"href":"https://github.com/puppetlabs/leatherman/pull/109#discussion_r47385925"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109","id":52899802,"html_url":"https://github.com/puppetlabs/leatherman/pull/109","diff_url":"https://github.com/puppetlabs/leatherman/pull/109.diff","patch_url":"https://github.com/puppetlabs/leatherman/pull/109.patch","issue_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/109","number":109,"state":"open","locked":false,"title":"(LTH-54) Formalize library installs","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Create a `leatherman_install` macro to replace CMake's `install` with\r\none supporting cross-platform defaults.","created_at":"2015-12-07T20:58:26Z","updated_at":"2015-12-11T18:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52e1b4083fbe0cfa0106fc66dbd150474fe1a53c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/109/comments","statuses_url":"https://api.github.com/repos/puppetlabs/leatherman/statuses/41f5a8bc04cf7e25477138ac0198cdf1ef37eb3b","head":{"label":"MikaelSmith:LTH-54","ref":"LTH-54","sha":"41f5a8bc04cf7e25477138ac0198cdf1ef37eb3b","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":31666230,"name":"leatherman","full_name":"MikaelSmith/leatherman","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/leatherman","description":"A collection of C++ and CMake utility libraries.","fork":true,"url":"https://api.github.com/repos/MikaelSmith/leatherman","forks_url":"https://api.github.com/repos/MikaelSmith/leatherman/forks","keys_url":"https://api.github.com/repos/MikaelSmith/leatherman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/leatherman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/leatherman/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/leatherman/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/leatherman/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/leatherman/events","assignees_url":"https://api.github.com/repos/MikaelSmith/leatherman/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/leatherman/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/leatherman/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/leatherman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/leatherman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/leatherman/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/leatherman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/leatherman/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/leatherman/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/leatherman/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/leatherman/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/leatherman/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/leatherman/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/leatherman/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/leatherman/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/leatherman/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/leatherman/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikaelSmith/leatherman/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/leatherman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/leatherman/merges","archive_url":"https://api.github.com/repos/MikaelSmith/leatherman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/leatherman/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/leatherman/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/leatherman/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/leatherman/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/leatherman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/leatherman/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/leatherman/releases{/id}","created_at":"2015-03-04T16:11:26Z","updated_at":"2015-06-12T23:05:11Z","pushed_at":"2015-12-10T19:46:59Z","git_url":"git://github.com/MikaelSmith/leatherman.git","ssh_url":"git@github.com:MikaelSmith/leatherman.git","clone_url":"https://github.com/MikaelSmith/leatherman.git","svn_url":"https://github.com/MikaelSmith/leatherman","homepage":"","size":749,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"65269b29ff76af5f6b8a6281853891e9718c0c77","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":31226286,"name":"leatherman","full_name":"puppetlabs/leatherman","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/leatherman","description":"A collection of C++ and CMake utility libraries.","fork":false,"url":"https://api.github.com/repos/puppetlabs/leatherman","forks_url":"https://api.github.com/repos/puppetlabs/leatherman/forks","keys_url":"https://api.github.com/repos/puppetlabs/leatherman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/leatherman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/leatherman/teams","hooks_url":"https://api.github.com/repos/puppetlabs/leatherman/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/leatherman/events","assignees_url":"https://api.github.com/repos/puppetlabs/leatherman/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/leatherman/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/leatherman/tags","blobs_url":"https://api.github.com/repos/puppetlabs/leatherman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/leatherman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/leatherman/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/leatherman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/leatherman/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/leatherman/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/leatherman/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/leatherman/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/leatherman/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/leatherman/subscription","commits_url":"https://api.github.com/repos/puppetlabs/leatherman/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/leatherman/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/leatherman/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/leatherman/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/leatherman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/leatherman/merges","archive_url":"https://api.github.com/repos/puppetlabs/leatherman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/leatherman/downloads","issues_url":"https://api.github.com/repos/puppetlabs/leatherman/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/leatherman/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/leatherman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/leatherman/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/leatherman/releases{/id}","created_at":"2015-02-23T19:50:46Z","updated_at":"2015-10-08T21:55:05Z","pushed_at":"2015-12-10T19:46:59Z","git_url":"git://github.com/puppetlabs/leatherman.git","ssh_url":"git@github.com:puppetlabs/leatherman.git","clone_url":"https://github.com/puppetlabs/leatherman.git","svn_url":"https://github.com/puppetlabs/leatherman","homepage":"","size":782,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109"},"html":{"href":"https://github.com/puppetlabs/leatherman/pull/109"},"issue":{"href":"https://api.github.com/repos/puppetlabs/leatherman/issues/109"},"comments":{"href":"https://api.github.com/repos/puppetlabs/leatherman/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/leatherman/statuses/41f5a8bc04cf7e25477138ac0198cdf1ef37eb3b"}}}}