{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/47972422","id":47972422,"diff_hunk":"@@ -8,6 +8,9 @@\n     <Project Include=\"System.Collections.csproj\" Condition=\"'$(TargetsWindows)' == 'true'\">\n       <AdditionalProperties>TargetGroup=net46</AdditionalProperties>\n     </Project>\n+    <Project Include=\"System.Collections.csproj\" Condition=\"'$(TargetsWindows)' == 'true'\">\n+      <AdditionalProperties>TargetGroup=netcore50aot</AdditionalProperties>","path":"src/System.Collections/src/System.Collections.builds","position":5,"original_position":5,"commit_id":"8a75e713c85cce04d9da8d0f819e123f5393716a","original_commit_id":"8a75e713c85cce04d9da8d0f819e123f5393716a","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"If this is building against contracts please use netcore50 as the target group because it will be the same for both netcore50 and netcore50aot. We should only ever use netcore50aot for things that need to reference things from the Private.NetNative targeting pack. ","created_at":"2015-12-17T22:45:22Z","updated_at":"2015-12-17T22:45:22Z","html_url":"https://github.com/dotnet/corefx/pull/5047#discussion_r47972422","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/5047","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/47972422"},"html":{"href":"https://github.com/dotnet/corefx/pull/5047#discussion_r47972422"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5047"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/5047","id":54031778,"html_url":"https://github.com/dotnet/corefx/pull/5047","diff_url":"https://github.com/dotnet/corefx/pull/5047.diff","patch_url":"https://github.com/dotnet/corefx/pull/5047.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/5047","number":5047,"state":"open","locked":false,"title":"Port .NET Native version of System.Collections","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"body":"This is a direct port of the .NET Native version of System.Collections from our internal source tree. It contains a few more types, like Dictionary, List, etc. that in CoreCLR are implemented in mscorlib. I've regenerated the solution file so that the new configurations can be accessed from Visual Studio.\r\n\r\nNOTE: I have not made any cleanup changes in this version. I started doing so but noticed that the existing code in System.Collections could use a lot of cleanup in the first place. I think we should do separate cleanup of the whole library.\r\n\r\n@weshaggard ","created_at":"2015-12-17T21:08:17Z","updated_at":"2015-12-17T22:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac156fa71d245dd0ada73f0f748860e5f47d1661","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/5047/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/5047/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/5047/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8a75e713c85cce04d9da8d0f819e123f5393716a","head":{"label":"mellinoe:collections-netnative","ref":"collections-netnative","sha":"8a75e713c85cce04d9da8d0f819e123f5393716a","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"repo":{"id":26655317,"name":"corefx","full_name":"mellinoe/corefx","owner":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellinoe/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/mellinoe/corefx","forks_url":"https://api.github.com/repos/mellinoe/corefx/forks","keys_url":"https://api.github.com/repos/mellinoe/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellinoe/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellinoe/corefx/teams","hooks_url":"https://api.github.com/repos/mellinoe/corefx/hooks","issue_events_url":"https://api.github.com/repos/mellinoe/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/mellinoe/corefx/events","assignees_url":"https://api.github.com/repos/mellinoe/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/mellinoe/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/mellinoe/corefx/tags","blobs_url":"https://api.github.com/repos/mellinoe/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellinoe/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellinoe/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellinoe/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellinoe/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/mellinoe/corefx/languages","stargazers_url":"https://api.github.com/repos/mellinoe/corefx/stargazers","contributors_url":"https://api.github.com/repos/mellinoe/corefx/contributors","subscribers_url":"https://api.github.com/repos/mellinoe/corefx/subscribers","subscription_url":"https://api.github.com/repos/mellinoe/corefx/subscription","commits_url":"https://api.github.com/repos/mellinoe/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellinoe/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellinoe/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellinoe/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellinoe/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/mellinoe/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellinoe/corefx/merges","archive_url":"https://api.github.com/repos/mellinoe/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellinoe/corefx/downloads","issues_url":"https://api.github.com/repos/mellinoe/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/mellinoe/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/mellinoe/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/mellinoe/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellinoe/corefx/labels{/name}","releases_url":"https://api.github.com/repos/mellinoe/corefx/releases{/id}","created_at":"2014-11-14T20:04:38Z","updated_at":"2014-11-14T20:07:32Z","pushed_at":"2015-12-17T22:22:25Z","git_url":"git://github.com/mellinoe/corefx.git","ssh_url":"git@github.com:mellinoe/corefx.git","clone_url":"https://github.com/mellinoe/corefx.git","svn_url":"https://github.com/mellinoe/corefx","homepage":"","size":42891,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"975c3ca9ebe52679a4de40700db1dc39ee35cee1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-12-17T21:33:25Z","pushed_at":"2015-12-17T22:28:28Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":52763,"stargazers_count":8793,"watchers_count":8793,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2000,"mirror_url":null,"open_issues_count":819,"forks":2000,"open_issues":819,"watchers":8793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5047"},"html":{"href":"https://github.com/dotnet/corefx/pull/5047"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5047"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5047/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5047/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5047/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8a75e713c85cce04d9da8d0f819e123f5393716a"}}}}