{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3510","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3510/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3510/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3510/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3510","id":58325191,"number":3510,"title":"FileExclusion: new extension for the ImportLibrary","user":{"login":"joshmoore","id":88113,"avatar_url":"https://avatars.githubusercontent.com/u/88113?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmoore","html_url":"https://github.com/joshmoore","followers_url":"https://api.github.com/users/joshmoore/followers","following_url":"https://api.github.com/users/joshmoore/following{/other_user}","gists_url":"https://api.github.com/users/joshmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmoore/subscriptions","organizations_url":"https://api.github.com/users/joshmoore/orgs","repos_url":"https://api.github.com/users/joshmoore/repos","events_url":"https://api.github.com/users/joshmoore/events{/privacy}","received_events_url":"https://api.github.com/users/joshmoore/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-02-20T09:04:30Z","updated_at":"2015-02-24T09:47:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3510","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3510","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3510.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3510.patch"},"body":"Similar to the FileTransfer interface, well-known or third\r\nparty FileExclusion instances can be passed to the ImportLibrary\r\nin order to influence the import process. Each exclusion is\r\ngiven the chance to veto the import of a given ImportContainer\r\nwhich has been chosen, e.g., by ImportCandidates. For example,\r\npassing `--exclude=filename` searches for a file with the same\r\nname on the server and then subsequently checks that the hash\r\nmatches. If it goes, the call to `importImage` exits early with\r\nthe log statement:\r\n\r\n```\r\nINFO   ....exclusions.FilenameExclusion - Checksum match for filename:\r\n```\r\n\r\nTesting:\r\n * `bin/omero import $SOMEFILE`\r\n * `bin/omero import $SOMEFILE # This should produce a duplicate`\r\n * `bin/omero import -- --exclude=filename $SOMEFILE # This should import nothing.`\r\n * `bin/omero import -- --exclude=filename $SOMEOTHERFILE # imports`\r\n * `bin/omero import -- --exclude=filename $SOMEOTHERFILE # does not import`\r\n\r\ncc: @jwgwarren @ximenesuk @jburel @mtbc \r\n\r\n*API comments welcome as are ideas for new implementations to test that API*"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/75726736","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3510#issuecomment-75726736","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3510","id":75726736,"user":{"login":"ximenesuk","id":1065145,"avatar_url":"https://avatars.githubusercontent.com/u/1065145?v=3","gravatar_id":"","url":"https://api.github.com/users/ximenesuk","html_url":"https://github.com/ximenesuk","followers_url":"https://api.github.com/users/ximenesuk/followers","following_url":"https://api.github.com/users/ximenesuk/following{/other_user}","gists_url":"https://api.github.com/users/ximenesuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ximenesuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximenesuk/subscriptions","organizations_url":"https://api.github.com/users/ximenesuk/orgs","repos_url":"https://api.github.com/users/ximenesuk/repos","events_url":"https://api.github.com/users/ximenesuk/events{/privacy}","received_events_url":"https://api.github.com/users/ximenesuk/received_events","type":"User","site_admin":false},"created_at":"2015-02-24T09:47:22Z","updated_at":"2015-02-24T09:47:22Z","body":"Probably fine as it is, just sanity checking. The cli output is clear enough and the event is available if other clients need it. I'd say this is good to merge as is."}}