{"action":"opened","number":287,"pull_request":{"url":"https://api.github.com/repos/mautic/mautic/pulls/287","id":33073755,"html_url":"https://github.com/mautic/mautic/pull/287","diff_url":"https://github.com/mautic/mautic/pull/287.diff","patch_url":"https://github.com/mautic/mautic/pull/287.patch","issue_url":"https://api.github.com/repos/mautic/mautic/issues/287","number":287,"state":"open","locked":false,"title":"Lead timeline fixes","user":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"body":"While working on campaigns, I came across a number of issues with the lead timeline so decided to fix them.\r\n\r\n1) When a form was submitted back to back with different IP addresses, the submission was getting associated with the wrong lead and thus displayed incorrectly in the lead's timeline.\r\n\r\n2) A lot of useless ip added and 0 point entries were displaying in the timeline so added catches to prevent logging already known IPs for the lead and 0 point log entries.\r\n\r\n3) Added ellipsis classes to some of the titles and details of the lead timeline boxes to keep long URLs, for example, from breaking the layout\r\n\r\n4) Forced an order of events that happened at the same time so that it looks to the user to be the order that was executed.  For example, form submission -> lead created -> lead identified, etc. Before it looked all out of order because they were sorted by just date.\r\n\r\n5) Fixed the engagement graph to only show unique engagements, not each event.  A single form submit could have resulted in 4-6 entries to the timeline (leads created, emails sent, etc) but they all took place during a single engagement.","created_at":"2015-04-10T18:58:29Z","updated_at":"2015-04-10T18:58:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mautic/mautic/pulls/287/commits","review_comments_url":"https://api.github.com/repos/mautic/mautic/pulls/287/comments","review_comment_url":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mautic/mautic/issues/287/comments","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/c37a489f7407130a5411a2736d38602f6068737b","head":{"label":"alanhartless:lead-timeline-fixes","ref":"lead-timeline-fixes","sha":"c37a489f7407130a5411a2736d38602f6068737b","user":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"repo":{"id":31477695,"name":"mautic","full_name":"alanhartless/mautic","owner":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanhartless/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":true,"url":"https://api.github.com/repos/alanhartless/mautic","forks_url":"https://api.github.com/repos/alanhartless/mautic/forks","keys_url":"https://api.github.com/repos/alanhartless/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanhartless/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanhartless/mautic/teams","hooks_url":"https://api.github.com/repos/alanhartless/mautic/hooks","issue_events_url":"https://api.github.com/repos/alanhartless/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/alanhartless/mautic/events","assignees_url":"https://api.github.com/repos/alanhartless/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/alanhartless/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/alanhartless/mautic/tags","blobs_url":"https://api.github.com/repos/alanhartless/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanhartless/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanhartless/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanhartless/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanhartless/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/alanhartless/mautic/languages","stargazers_url":"https://api.github.com/repos/alanhartless/mautic/stargazers","contributors_url":"https://api.github.com/repos/alanhartless/mautic/contributors","subscribers_url":"https://api.github.com/repos/alanhartless/mautic/subscribers","subscription_url":"https://api.github.com/repos/alanhartless/mautic/subscription","commits_url":"https://api.github.com/repos/alanhartless/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanhartless/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanhartless/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanhartless/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanhartless/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/alanhartless/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanhartless/mautic/merges","archive_url":"https://api.github.com/repos/alanhartless/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanhartless/mautic/downloads","issues_url":"https://api.github.com/repos/alanhartless/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/alanhartless/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/alanhartless/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/alanhartless/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanhartless/mautic/labels{/name}","releases_url":"https://api.github.com/repos/alanhartless/mautic/releases{/id}","created_at":"2015-02-28T21:38:41Z","updated_at":"2015-04-02T17:00:58Z","pushed_at":"2015-04-10T18:52:10Z","git_url":"git://github.com/alanhartless/mautic.git","ssh_url":"git@github.com:alanhartless/mautic.git","clone_url":"https://github.com/alanhartless/mautic.git","svn_url":"https://github.com/alanhartless/mautic","homepage":"http://mautic.org","size":19787,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mautic:staging","ref":"staging","sha":"ee6f73830f671e0db0278c173c0c198195e72ebd","user":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"repo":{"id":12204147,"name":"mautic","full_name":"mautic/mautic","owner":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mautic/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":false,"url":"https://api.github.com/repos/mautic/mautic","forks_url":"https://api.github.com/repos/mautic/mautic/forks","keys_url":"https://api.github.com/repos/mautic/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mautic/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mautic/mautic/teams","hooks_url":"https://api.github.com/repos/mautic/mautic/hooks","issue_events_url":"https://api.github.com/repos/mautic/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/mautic/mautic/events","assignees_url":"https://api.github.com/repos/mautic/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/mautic/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/mautic/mautic/tags","blobs_url":"https://api.github.com/repos/mautic/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mautic/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mautic/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mautic/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/mautic/mautic/languages","stargazers_url":"https://api.github.com/repos/mautic/mautic/stargazers","contributors_url":"https://api.github.com/repos/mautic/mautic/contributors","subscribers_url":"https://api.github.com/repos/mautic/mautic/subscribers","subscription_url":"https://api.github.com/repos/mautic/mautic/subscription","commits_url":"https://api.github.com/repos/mautic/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mautic/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mautic/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mautic/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mautic/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/mautic/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mautic/mautic/merges","archive_url":"https://api.github.com/repos/mautic/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mautic/mautic/downloads","issues_url":"https://api.github.com/repos/mautic/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/mautic/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/mautic/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/mautic/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mautic/mautic/labels{/name}","releases_url":"https://api.github.com/repos/mautic/mautic/releases{/id}","created_at":"2013-08-19T00:36:28Z","updated_at":"2015-04-10T17:37:22Z","pushed_at":"2015-04-10T18:58:29Z","git_url":"git://github.com/mautic/mautic.git","ssh_url":"git@github.com:mautic/mautic.git","clone_url":"https://github.com/mautic/mautic.git","svn_url":"https://github.com/mautic/mautic","homepage":"https://www.mautic.org","size":27406,"stargazers_count":120,"watchers_count":120,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":83,"forks":35,"open_issues":83,"watchers":120,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/mautic/mautic/pulls/287"},"html":{"href":"https://github.com/mautic/mautic/pull/287"},"issue":{"href":"https://api.github.com/repos/mautic/mautic/issues/287"},"comments":{"href":"https://api.github.com/repos/mautic/mautic/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/mautic/mautic/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mautic/mautic/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/mautic/mautic/statuses/c37a489f7407130a5411a2736d38602f6068737b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":89,"deletions":70,"changed_files":9}}