{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/cache/pulls/comments/27895083","id":27895083,"diff_hunk":"@@ -42,14 +42,12 @@ public function __construct($directory, $extension = self::EXTENSION)\n      */\n     protected function doFetch($id)\n     {\n-        $filename = $this->getFilename($id);\n+        $value = @include $this->getFilename($id);","path":"lib/Doctrine/Common/Cache/PhpFileCache.php","position":5,"original_position":5,"commit_id":"285228d89fa14f91832fe527569c4bd065079a06","original_commit_id":"285228d89fa14f91832fe527569c4bd065079a06","user":{"login":"zeroedin-bill","id":4266849,"avatar_url":"https://avatars.githubusercontent.com/u/4266849?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroedin-bill","html_url":"https://github.com/zeroedin-bill","followers_url":"https://api.github.com/users/zeroedin-bill/followers","following_url":"https://api.github.com/users/zeroedin-bill/following{/other_user}","gists_url":"https://api.github.com/users/zeroedin-bill/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroedin-bill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroedin-bill/subscriptions","organizations_url":"https://api.github.com/users/zeroedin-bill/orgs","repos_url":"https://api.github.com/users/zeroedin-bill/repos","events_url":"https://api.github.com/users/zeroedin-bill/events{/privacy}","received_events_url":"https://api.github.com/users/zeroedin-bill/received_events","type":"User","site_admin":false},"body":"*gasp*\r\n\r\nMakes sense, but you might want to add a comment to these methods to the effect of your comment here. It's not immediately obvious from looking at the code.","created_at":"2015-04-07T16:33:34Z","updated_at":"2015-04-07T16:33:34Z","html_url":"https://github.com/doctrine/cache/pull/69#discussion_r27895083","pull_request_url":"https://api.github.com/repos/doctrine/cache/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/doctrine/cache/pulls/comments/27895083"},"html":{"href":"https://github.com/doctrine/cache/pull/69#discussion_r27895083"},"pull_request":{"href":"https://api.github.com/repos/doctrine/cache/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/cache/pulls/69","id":32778611,"html_url":"https://github.com/doctrine/cache/pull/69","diff_url":"https://github.com/doctrine/cache/pull/69.diff","patch_url":"https://github.com/doctrine/cache/pull/69.patch","issue_url":"https://api.github.com/repos/doctrine/cache/issues/69","number":69,"state":"open","locked":false,"title":"Improved PhpFileCache performance by removing useless stat calls","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"Not sure if it's relevant, but this makes the `PhpFileCache` actually usable in a context where OpCache is enabled.","created_at":"2015-04-07T16:02:51Z","updated_at":"2015-04-07T16:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89f6d25625255ad07d12cf3982f51349790afed4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/cache/pulls/69/commits","review_comments_url":"https://api.github.com/repos/doctrine/cache/pulls/69/comments","review_comment_url":"https://api.github.com/repos/doctrine/cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/cache/issues/69/comments","statuses_url":"https://api.github.com/repos/doctrine/cache/statuses/285228d89fa14f91832fe527569c4bd065079a06","head":{"label":"Ocramius:feature/php-file-cache","ref":"feature/php-file-cache","sha":"285228d89fa14f91832fe527569c4bd065079a06","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"repo":{"id":33553429,"name":"cache","full_name":"Ocramius/cache","owner":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ocramius/cache","description":"Doctrine Cache component","fork":true,"url":"https://api.github.com/repos/Ocramius/cache","forks_url":"https://api.github.com/repos/Ocramius/cache/forks","keys_url":"https://api.github.com/repos/Ocramius/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ocramius/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ocramius/cache/teams","hooks_url":"https://api.github.com/repos/Ocramius/cache/hooks","issue_events_url":"https://api.github.com/repos/Ocramius/cache/issues/events{/number}","events_url":"https://api.github.com/repos/Ocramius/cache/events","assignees_url":"https://api.github.com/repos/Ocramius/cache/assignees{/user}","branches_url":"https://api.github.com/repos/Ocramius/cache/branches{/branch}","tags_url":"https://api.github.com/repos/Ocramius/cache/tags","blobs_url":"https://api.github.com/repos/Ocramius/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ocramius/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ocramius/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ocramius/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ocramius/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Ocramius/cache/languages","stargazers_url":"https://api.github.com/repos/Ocramius/cache/stargazers","contributors_url":"https://api.github.com/repos/Ocramius/cache/contributors","subscribers_url":"https://api.github.com/repos/Ocramius/cache/subscribers","subscription_url":"https://api.github.com/repos/Ocramius/cache/subscription","commits_url":"https://api.github.com/repos/Ocramius/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ocramius/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ocramius/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ocramius/cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ocramius/cache/contents/{+path}","compare_url":"https://api.github.com/repos/Ocramius/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ocramius/cache/merges","archive_url":"https://api.github.com/repos/Ocramius/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ocramius/cache/downloads","issues_url":"https://api.github.com/repos/Ocramius/cache/issues{/number}","pulls_url":"https://api.github.com/repos/Ocramius/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Ocramius/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Ocramius/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ocramius/cache/labels{/name}","releases_url":"https://api.github.com/repos/Ocramius/cache/releases{/id}","created_at":"2015-04-07T16:02:09Z","updated_at":"2015-04-07T16:02:10Z","pushed_at":"2015-04-07T16:02:20Z","git_url":"git://github.com/Ocramius/cache.git","ssh_url":"git@github.com:Ocramius/cache.git","clone_url":"https://github.com/Ocramius/cache.git","svn_url":"https://github.com/Ocramius/cache","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"6c5c32eb6c596993d04e13b95d0c1e8153783d7a","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":7550057,"name":"cache","full_name":"doctrine/cache","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/cache","description":"Doctrine Cache component","fork":false,"url":"https://api.github.com/repos/doctrine/cache","forks_url":"https://api.github.com/repos/doctrine/cache/forks","keys_url":"https://api.github.com/repos/doctrine/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/cache/teams","hooks_url":"https://api.github.com/repos/doctrine/cache/hooks","issue_events_url":"https://api.github.com/repos/doctrine/cache/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/cache/events","assignees_url":"https://api.github.com/repos/doctrine/cache/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/cache/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/cache/tags","blobs_url":"https://api.github.com/repos/doctrine/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/cache/languages","stargazers_url":"https://api.github.com/repos/doctrine/cache/stargazers","contributors_url":"https://api.github.com/repos/doctrine/cache/contributors","subscribers_url":"https://api.github.com/repos/doctrine/cache/subscribers","subscription_url":"https://api.github.com/repos/doctrine/cache/subscription","commits_url":"https://api.github.com/repos/doctrine/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/cache/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/cache/merges","archive_url":"https://api.github.com/repos/doctrine/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/cache/downloads","issues_url":"https://api.github.com/repos/doctrine/cache/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/cache/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/cache/releases{/id}","created_at":"2013-01-10T22:37:43Z","updated_at":"2015-03-30T01:02:16Z","pushed_at":"2015-04-07T16:02:53Z","git_url":"git://github.com/doctrine/cache.git","ssh_url":"git@github.com:doctrine/cache.git","clone_url":"https://github.com/doctrine/cache.git","svn_url":"https://github.com/doctrine/cache","homepage":null,"size":1201,"stargazers_count":132,"watchers_count":132,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":10,"forks":73,"open_issues":10,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/cache/pulls/69"},"html":{"href":"https://github.com/doctrine/cache/pull/69"},"issue":{"href":"https://api.github.com/repos/doctrine/cache/issues/69"},"comments":{"href":"https://api.github.com/repos/doctrine/cache/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/cache/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/cache/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/cache/statuses/285228d89fa14f91832fe527569c4bd065079a06"}}}}