{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/41161354","id":41161354,"diff_hunk":"@@ -5,17 +5,89 @@\n import 'dart:async';\n \n import 'package:newton/newton.dart';\n-import 'package:sky/src/animation/curves.dart';\n import 'package:sky/src/animation/animated_value.dart';\n-import 'package:sky/src/animation/animated_simulation.dart';\n+import 'package:sky/src/animation/curves.dart';\n+import 'package:sky/src/animation/scheduler.dart';\n+\n+typedef _TickerCallback(Duration elapsed);\n+\n+/// Calls its callback once per animation frame\n+class _Ticker {\n+  /// Constructs a ticker that will call onTick once per frame while running\n+  _Ticker(_TickerCallback onTick) : _onTick = onTick;\n+\n+  final _TickerCallback _onTick;\n+\n+  Completer _completer;\n+  int _animationId;\n+  Duration _startTime;\n+\n+  /// Start calling onTick once per animation frame\n+  ///\n+  /// The returned future resolves once the ticker stops ticking.\n+  Future start() {\n+    assert(!isTicking);\n+    assert(_startTime == null);\n+    _completer = new Completer();\n+    _scheduleTick();\n+    return _completer.future;\n+  }\n+\n+  /// Stop calling onTick\n+  ///\n+  /// Causes the future returned by [start] to resolve.\n+  void stop() {\n+    if (!isTicking)\n+      return;\n+\n+    _startTime = null;\n+\n+    if (_animationId != null) {\n+      scheduler.cancelAnimationFrame(_animationId);\n+      _animationId = null;\n+    }\n+\n+    // We take the _completer into a local variable so that !isTicking","path":"sky/packages/sky/lib/src/animation/timeline.dart","position":48,"original_position":48,"commit_id":"e19592b8e5e9dd27df6876aec29c1bc4d41c076e","original_commit_id":"e19592b8e5e9dd27df6876aec29c1bc4d41c076e","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"this comment's grammar is suspect.","created_at":"2015-10-05T15:57:14Z","updated_at":"2015-10-05T15:57:14Z","html_url":"https://github.com/flutter/engine/pull/1480#discussion_r41161354","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/1480","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/41161354"},"html":{"href":"https://github.com/flutter/engine/pull/1480#discussion_r41161354"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/1480"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/1480","id":46714356,"html_url":"https://github.com/flutter/engine/pull/1480","diff_url":"https://github.com/flutter/engine/pull/1480.diff","patch_url":"https://github.com/flutter/engine/pull/1480.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/1480","number":1480,"state":"open","locked":false,"title":"Remove AnimatedSimulation","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"This patch folds the functionality from AnimatedSimulation into Timeline.","created_at":"2015-10-03T22:00:29Z","updated_at":"2015-10-05T15:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ffdd3d94cd5d2746aad3efad1c219867d1d1a54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/1480/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/1480/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/1480/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/e19592b8e5e9dd27df6876aec29c1bc4d41c076e","head":{"label":"abarth:rm_animated_simulation","ref":"rm_animated_simulation","sha":"e19592b8e5e9dd27df6876aec29c1bc4d41c076e","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"repo":{"id":39215675,"name":"engine","full_name":"abarth/engine","owner":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abarth/engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/abarth/engine","forks_url":"https://api.github.com/repos/abarth/engine/forks","keys_url":"https://api.github.com/repos/abarth/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abarth/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abarth/engine/teams","hooks_url":"https://api.github.com/repos/abarth/engine/hooks","issue_events_url":"https://api.github.com/repos/abarth/engine/issues/events{/number}","events_url":"https://api.github.com/repos/abarth/engine/events","assignees_url":"https://api.github.com/repos/abarth/engine/assignees{/user}","branches_url":"https://api.github.com/repos/abarth/engine/branches{/branch}","tags_url":"https://api.github.com/repos/abarth/engine/tags","blobs_url":"https://api.github.com/repos/abarth/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abarth/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abarth/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/abarth/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abarth/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/abarth/engine/languages","stargazers_url":"https://api.github.com/repos/abarth/engine/stargazers","contributors_url":"https://api.github.com/repos/abarth/engine/contributors","subscribers_url":"https://api.github.com/repos/abarth/engine/subscribers","subscription_url":"https://api.github.com/repos/abarth/engine/subscription","commits_url":"https://api.github.com/repos/abarth/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/abarth/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/abarth/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/abarth/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/abarth/engine/contents/{+path}","compare_url":"https://api.github.com/repos/abarth/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abarth/engine/merges","archive_url":"https://api.github.com/repos/abarth/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abarth/engine/downloads","issues_url":"https://api.github.com/repos/abarth/engine/issues{/number}","pulls_url":"https://api.github.com/repos/abarth/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/abarth/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/abarth/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abarth/engine/labels{/name}","releases_url":"https://api.github.com/repos/abarth/engine/releases{/id}","created_at":"2015-07-16T19:18:24Z","updated_at":"2015-09-19T15:57:18Z","pushed_at":"2015-10-04T21:22:56Z","git_url":"git://github.com/abarth/engine.git","ssh_url":"git@github.com:abarth/engine.git","clone_url":"https://github.com/abarth/engine.git","svn_url":"https://github.com/abarth/engine","homepage":null,"size":76952,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"647aba8f4aa3c2207ff096ad5ec20c88c9293a38","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","created_at":"2015-07-16T17:39:56Z","updated_at":"2015-10-05T15:09:01Z","pushed_at":"2015-10-04T22:21:53Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":88656,"stargazers_count":262,"watchers_count":262,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":188,"forks":68,"open_issues":188,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/1480"},"html":{"href":"https://github.com/flutter/engine/pull/1480"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/1480"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/1480/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/1480/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/1480/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/e19592b8e5e9dd27df6876aec29c1bc4d41c076e"}}}}