{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/44345586","id":44345586,"diff_hunk":"@@ -96,7 +97,7 @@ describe('Trace Agent', function() {\n           '123456/667');\n         assert(result);\n         assert.equal(result.traceId, '123456');\n-        assert.equal(result.spanId, '667');\n+        assert.equal(result.spanId, 667);\n         assert(!result.options);\n       });\n ","path":"test/test-trace-agent.js","position":25,"original_position":25,"commit_id":"cc634477e484293de53bf91c0f6e90d849baf2e0","original_commit_id":"961b4f2cf261f0a07edb7d55198d57c59f5d73fe","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"I've added the tests to the invalid inputs section below. I think it should be a parse error if we get a non-numeric spanId.","created_at":"2015-11-09T22:53:29Z","updated_at":"2015-11-09T22:53:29Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/162#discussion_r44345586","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/44345586"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/162#discussion_r44345586"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162","id":50187177,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/162","diff_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/162.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/162.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/162","number":162,"state":"open","locked":false,"title":"Parsed spanids should have type number","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"Fixes #161","created_at":"2015-11-09T22:25:40Z","updated_at":"2015-11-09T22:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3a0be82035a7106b36d73ecbf6341004fa69021","assignee":null,"milestone":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/milestones/1","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/milestones/0.2.0","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/milestones/1/labels","id":1402811,"number":1,"title":"0.2.0","description":"","creator":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":3,"state":"open","created_at":"2015-11-09T18:54:15Z","updated_at":"2015-11-09T22:26:14Z","due_on":"2015-11-13T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/162/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/cc634477e484293de53bf91c0f6e90d849baf2e0","head":{"label":"matthewloring:spanid","ref":"spanid","sha":"cc634477e484293de53bf91c0f6e90d849baf2e0","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"repo":{"id":41391013,"name":"cloud-trace-nodejs","full_name":"matthewloring/cloud-trace-nodejs","owner":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewloring/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":true,"url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/releases{/id}","created_at":"2015-08-25T22:25:15Z","updated_at":"2015-08-25T22:25:15Z","pushed_at":"2015-11-09T22:52:32Z","git_url":"git://github.com/matthewloring/cloud-trace-nodejs.git","ssh_url":"git@github.com:matthewloring/cloud-trace-nodejs.git","clone_url":"https://github.com/matthewloring/cloud-trace-nodejs.git","svn_url":"https://github.com/matthewloring/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":962,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"eab9203ab78a3f1afa0d4f77258f1358976f684c","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":41170869,"name":"cloud-trace-nodejs","full_name":"GoogleCloudPlatform/cloud-trace-nodejs","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/releases{/id}","created_at":"2015-08-21T18:23:09Z","updated_at":"2015-11-06T09:43:17Z","pushed_at":"2015-11-09T22:52:33Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-trace-nodejs.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":1399,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":19,"forks":7,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/162"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/162"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/cc634477e484293de53bf91c0f6e90d849baf2e0"}}}}