{"action":"created","issue":{"url":"https://api.github.com/repos/fubralimited/php-oara/issues/27","labels_url":"https://api.github.com/repos/fubralimited/php-oara/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/fubralimited/php-oara/issues/27/comments","events_url":"https://api.github.com/repos/fubralimited/php-oara/issues/27/events","html_url":"https://github.com/fubralimited/php-oara/issues/27","id":83079546,"number":27,"title":"Extra status, get all transactions from all merchants, extra transaction information and clicks","user":{"login":"royduin","id":1703233,"avatar_url":"https://avatars.githubusercontent.com/u/1703233?v=3","gravatar_id":"","url":"https://api.github.com/users/royduin","html_url":"https://github.com/royduin","followers_url":"https://api.github.com/users/royduin/followers","following_url":"https://api.github.com/users/royduin/following{/other_user}","gists_url":"https://api.github.com/users/royduin/gists{/gist_id}","starred_url":"https://api.github.com/users/royduin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royduin/subscriptions","organizations_url":"https://api.github.com/users/royduin/orgs","repos_url":"https://api.github.com/users/royduin/repos","events_url":"https://api.github.com/users/royduin/events{/privacy}","received_events_url":"https://api.github.com/users/royduin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-31T12:29:49Z","updated_at":"2015-06-17T10:56:19Z","closed_at":null,"body":"Hi,\r\n\r\nBefore I'll create a pull request I'd like to discuss these 4 things:\r\n\r\n1. Currently there is `CONFIRMED`, `PENDING` and `DECLINED`. For example Zanox does have a `approved` status, this one is different from the `confirmed` status. Approved means; approved by the advertiser but not yet payed. When the bill is payed by the advertiser to the network it will get the status `confirmed`. I'd like to see this extra status, now a lot of transactions stay on `PENDING` and I'd like to see when it's approved by the advertiser. Do you guys agree with this implementation? Not every network does have this extra status...\r\n\r\n2. If I'd like to get all the transactions from a network from all the merchants I first have to call the `getMerchantList()` function, map this array with something like:\r\n\t```\r\n$merchants = $network->getMerchantList();\r\nforeach($merchants as $merchant){\r\n\t\t$merchantIds[] = $merchant['cid'];\r\n}\r\n```\r\nThen I can pass this array of ID's to the `getTransactionList()` function. This is only needed because of these if statements:\r\n\t- Zanox: https://github.com/fubralimited/php-oara/blob/master/Oara/Network/Publisher/Zanox.php#L149\r\n\t- Daisycon: https://github.com/fubralimited/php-oara/blob/master/Oara/Network/Publisher/Daisycon.php#L169\r\n\t- TradeTracker: https://github.com/fubralimited/php-oara/blob/master/Oara/Network/Publisher/TradeTracker.php#L101\r\n\r\n\tI think it's much easier to check in the `getTransactionList()` function for the `$merchantList` variable. If this one is `null` or an empty array the `getTransactionList()` function will skip the if statement. That way I don't have to get the merchant list first and I don't have to map that to an array of ID's to get the transactions of all merchants. I didn't checked all the networks, do all networks return all the transactions from all the merchants by default? Do you guys agree with this implementation?\r\n\r\n3. Currently the most networks return a `unique id`, `merchant id`, `date`, `status`, `amount` and `commission`. What about some extra fields? I think to most of the networks give more information but that isn't implemented. For example I'd like a `merchant name` (so I don't need the `getMerchantList()` function for this, see my point 2), `media name` (my website name) and the `products` (a description of what was bought). I think these are pretty general fields for all the networks, agree with this implementation?\r\n\r\n4. What about clicks? Currently this ins't implemented anywhere but I think it's pretty handy for creating graphs. A new function `getClicksList()`, like the `getTransactionList()` function which returns the amount of clicks per day. I can implement this for some networks..."},"comment":{"url":"https://api.github.com/repos/fubralimited/php-oara/issues/comments/112753202","html_url":"https://github.com/fubralimited/php-oara/issues/27#issuecomment-112753202","issue_url":"https://api.github.com/repos/fubralimited/php-oara/issues/27","id":112753202,"user":{"login":"royduin","id":1703233,"avatar_url":"https://avatars.githubusercontent.com/u/1703233?v=3","gravatar_id":"","url":"https://api.github.com/users/royduin","html_url":"https://github.com/royduin","followers_url":"https://api.github.com/users/royduin/followers","following_url":"https://api.github.com/users/royduin/following{/other_user}","gists_url":"https://api.github.com/users/royduin/gists{/gist_id}","starred_url":"https://api.github.com/users/royduin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royduin/subscriptions","organizations_url":"https://api.github.com/users/royduin/orgs","repos_url":"https://api.github.com/users/royduin/repos","events_url":"https://api.github.com/users/royduin/events{/privacy}","received_events_url":"https://api.github.com/users/royduin/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T10:56:19Z","updated_at":"2015-06-17T10:56:19Z","body":"@cmorillo, thanks for your reply! So if I implement my first and second point you won't accept the pull request? Because it's a little bit less generic than? What about my other questions?"}}