{"action":"created","comment":{"url":"https://api.github.com/repos/opencog/opencog/pulls/comments/30294656","id":30294656,"diff_hunk":"@@ -8,39 +8,33 @@\n ;    A\n ;----------------------------------------------------------------------\n \n-; Test NotLink rule. For now the TV formula assumes the concept is\n-; flat, or constant, in other words it's just fuzzy values, we ignore\n-; the confidence for now.\n-\n (define pln-rule-not\n   (BindLink\n     (VariableList\n-      (VariableNode \"$A\")\n-      (TypedVariableLink\n-       (VariableNode \"$A\")\n-       (TypeNode \"PredicateNode\")))\n+      (VariableNode \"$A\"))\n     (ImplicationLink\n       (VariableNode \"$A\")\n       (ExecutionOutputLink\n         (GroundedSchemaNode \"scm: pln-formula-not\")\n         (ListLink\n+\t\t  (NotLink\n+\t\t\t  (VariableNode \"$A\"))\n           (VariableNode \"$A\"))))))\n \n-(define (pln-formula-not A)\n-  (cog-set-tv!\n-   (NotLink A)\n-   (pln-formula-not-side-effect-free A))\n-)\n+(define (pln-formula-not nA A)\n+  (if (eq? (cog-type A) 'NotLink)\n+\t(cog-set-tv!\n+\t\t(gar A)\n+\t\t(pln-formula-not-side-effect-free A))","path":"opencog/reasoning/pln/rules/not.scm","position":34,"original_position":34,"commit_id":"96b7a57dc4267371b88a38d82078b5faf1bed82c","original_commit_id":"96b7a57dc4267371b88a38d82078b5faf1bed82c","user":{"login":"prateeksaxena2809","id":7004450,"avatar_url":"https://avatars.githubusercontent.com/u/7004450?v=3","gravatar_id":"","url":"https://api.github.com/users/prateeksaxena2809","html_url":"https://github.com/prateeksaxena2809","followers_url":"https://api.github.com/users/prateeksaxena2809/followers","following_url":"https://api.github.com/users/prateeksaxena2809/following{/other_user}","gists_url":"https://api.github.com/users/prateeksaxena2809/gists{/gist_id}","starred_url":"https://api.github.com/users/prateeksaxena2809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateeksaxena2809/subscriptions","organizations_url":"https://api.github.com/users/prateeksaxena2809/orgs","repos_url":"https://api.github.com/users/prateeksaxena2809/repos","events_url":"https://api.github.com/users/prateeksaxena2809/events{/privacy}","received_events_url":"https://api.github.com/users/prateeksaxena2809/received_events","type":"User","site_admin":false},"body":"if A is ```NotLink```, ```(gar A)``` removes the ```NotLink``` which is what we want by doing Not of Not A.","created_at":"2015-05-14T02:58:58Z","updated_at":"2015-05-14T02:58:58Z","html_url":"https://github.com/opencog/opencog/pull/1594#discussion_r30294656","pull_request_url":"https://api.github.com/repos/opencog/opencog/pulls/1594","_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments/30294656"},"html":{"href":"https://github.com/opencog/opencog/pull/1594#discussion_r30294656"},"pull_request":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1594"}}},"pull_request":{"url":"https://api.github.com/repos/opencog/opencog/pulls/1594","id":34766007,"html_url":"https://github.com/opencog/opencog/pull/1594","diff_url":"https://github.com/opencog/opencog/pull/1594.diff","patch_url":"https://github.com/opencog/opencog/pull/1594.patch","issue_url":"https://api.github.com/repos/opencog/opencog/issues/1594","number":1594,"state":"open","locked":false,"title":"Added johnny example and modified pln NotRule","user":{"login":"prateeksaxena2809","id":7004450,"avatar_url":"https://avatars.githubusercontent.com/u/7004450?v=3","gravatar_id":"","url":"https://api.github.com/users/prateeksaxena2809","html_url":"https://github.com/prateeksaxena2809","followers_url":"https://api.github.com/users/prateeksaxena2809/followers","following_url":"https://api.github.com/users/prateeksaxena2809/following{/other_user}","gists_url":"https://api.github.com/users/prateeksaxena2809/gists{/gist_id}","starred_url":"https://api.github.com/users/prateeksaxena2809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateeksaxena2809/subscriptions","organizations_url":"https://api.github.com/users/prateeksaxena2809/orgs","repos_url":"https://api.github.com/users/prateeksaxena2809/repos","events_url":"https://api.github.com/users/prateeksaxena2809/events{/privacy}","received_events_url":"https://api.github.com/users/prateeksaxena2809/received_events","type":"User","site_admin":false},"body":"Added example for first syllogism from List of Test Syllogisms mentioned [here] (http://wiki.opencog.org/w/List_of_Test_Syllogisms#Initial_test_list).\r\n\r\nAlso modified NotRule to be generic and handle nested NotLinks.","created_at":"2015-05-05T20:54:53Z","updated_at":"2015-05-14T02:58:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d99b618fd68e3cfdd1213845e926a2b4f34157a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencog/opencog/pulls/1594/commits","review_comments_url":"https://api.github.com/repos/opencog/opencog/pulls/1594/comments","review_comment_url":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/opencog/issues/1594/comments","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/96b7a57dc4267371b88a38d82078b5faf1bed82c","head":{"label":"prateeksaxena2809:add-johnny-example","ref":"add-johnny-example","sha":"96b7a57dc4267371b88a38d82078b5faf1bed82c","user":{"login":"prateeksaxena2809","id":7004450,"avatar_url":"https://avatars.githubusercontent.com/u/7004450?v=3","gravatar_id":"","url":"https://api.github.com/users/prateeksaxena2809","html_url":"https://github.com/prateeksaxena2809","followers_url":"https://api.github.com/users/prateeksaxena2809/followers","following_url":"https://api.github.com/users/prateeksaxena2809/following{/other_user}","gists_url":"https://api.github.com/users/prateeksaxena2809/gists{/gist_id}","starred_url":"https://api.github.com/users/prateeksaxena2809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateeksaxena2809/subscriptions","organizations_url":"https://api.github.com/users/prateeksaxena2809/orgs","repos_url":"https://api.github.com/users/prateeksaxena2809/repos","events_url":"https://api.github.com/users/prateeksaxena2809/events{/privacy}","received_events_url":"https://api.github.com/users/prateeksaxena2809/received_events","type":"User","site_admin":false},"repo":{"id":32343933,"name":"opencog","full_name":"prateeksaxena2809/opencog","owner":{"login":"prateeksaxena2809","id":7004450,"avatar_url":"https://avatars.githubusercontent.com/u/7004450?v=3","gravatar_id":"","url":"https://api.github.com/users/prateeksaxena2809","html_url":"https://github.com/prateeksaxena2809","followers_url":"https://api.github.com/users/prateeksaxena2809/followers","following_url":"https://api.github.com/users/prateeksaxena2809/following{/other_user}","gists_url":"https://api.github.com/users/prateeksaxena2809/gists{/gist_id}","starred_url":"https://api.github.com/users/prateeksaxena2809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateeksaxena2809/subscriptions","organizations_url":"https://api.github.com/users/prateeksaxena2809/orgs","repos_url":"https://api.github.com/users/prateeksaxena2809/repos","events_url":"https://api.github.com/users/prateeksaxena2809/events{/privacy}","received_events_url":"https://api.github.com/users/prateeksaxena2809/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prateeksaxena2809/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":true,"url":"https://api.github.com/repos/prateeksaxena2809/opencog","forks_url":"https://api.github.com/repos/prateeksaxena2809/opencog/forks","keys_url":"https://api.github.com/repos/prateeksaxena2809/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prateeksaxena2809/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prateeksaxena2809/opencog/teams","hooks_url":"https://api.github.com/repos/prateeksaxena2809/opencog/hooks","issue_events_url":"https://api.github.com/repos/prateeksaxena2809/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/prateeksaxena2809/opencog/events","assignees_url":"https://api.github.com/repos/prateeksaxena2809/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/prateeksaxena2809/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/prateeksaxena2809/opencog/tags","blobs_url":"https://api.github.com/repos/prateeksaxena2809/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prateeksaxena2809/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prateeksaxena2809/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/prateeksaxena2809/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prateeksaxena2809/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/prateeksaxena2809/opencog/languages","stargazers_url":"https://api.github.com/repos/prateeksaxena2809/opencog/stargazers","contributors_url":"https://api.github.com/repos/prateeksaxena2809/opencog/contributors","subscribers_url":"https://api.github.com/repos/prateeksaxena2809/opencog/subscribers","subscription_url":"https://api.github.com/repos/prateeksaxena2809/opencog/subscription","commits_url":"https://api.github.com/repos/prateeksaxena2809/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/prateeksaxena2809/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/prateeksaxena2809/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/prateeksaxena2809/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/prateeksaxena2809/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/prateeksaxena2809/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prateeksaxena2809/opencog/merges","archive_url":"https://api.github.com/repos/prateeksaxena2809/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prateeksaxena2809/opencog/downloads","issues_url":"https://api.github.com/repos/prateeksaxena2809/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/prateeksaxena2809/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/prateeksaxena2809/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/prateeksaxena2809/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prateeksaxena2809/opencog/labels{/name}","releases_url":"https://api.github.com/repos/prateeksaxena2809/opencog/releases{/id}","created_at":"2015-03-16T18:13:50Z","updated_at":"2015-05-06T08:51:22Z","pushed_at":"2015-05-08T18:08:31Z","git_url":"git://github.com/prateeksaxena2809/opencog.git","ssh_url":"git@github.com:prateeksaxena2809/opencog.git","clone_url":"https://github.com/prateeksaxena2809/opencog.git","svn_url":"https://github.com/prateeksaxena2809/opencog","homepage":"http://wiki.opencog.org/w/Development","size":138619,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"3579af301273b457f19df4a3db63fa0898b4fd7a","user":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":6365343,"name":"opencog","full_name":"opencog/opencog","owner":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":false,"url":"https://api.github.com/repos/opencog/opencog","forks_url":"https://api.github.com/repos/opencog/opencog/forks","keys_url":"https://api.github.com/repos/opencog/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/opencog/teams","hooks_url":"https://api.github.com/repos/opencog/opencog/hooks","issue_events_url":"https://api.github.com/repos/opencog/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/opencog/events","assignees_url":"https://api.github.com/repos/opencog/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/opencog/tags","blobs_url":"https://api.github.com/repos/opencog/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/opencog/languages","stargazers_url":"https://api.github.com/repos/opencog/opencog/stargazers","contributors_url":"https://api.github.com/repos/opencog/opencog/contributors","subscribers_url":"https://api.github.com/repos/opencog/opencog/subscribers","subscription_url":"https://api.github.com/repos/opencog/opencog/subscription","commits_url":"https://api.github.com/repos/opencog/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/opencog/merges","archive_url":"https://api.github.com/repos/opencog/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/opencog/downloads","issues_url":"https://api.github.com/repos/opencog/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/opencog/labels{/name}","releases_url":"https://api.github.com/repos/opencog/opencog/releases{/id}","created_at":"2012-10-24T06:10:15Z","updated_at":"2015-05-13T01:43:34Z","pushed_at":"2015-05-13T04:24:27Z","git_url":"git://github.com/opencog/opencog.git","ssh_url":"git@github.com:opencog/opencog.git","clone_url":"https://github.com/opencog/opencog.git","svn_url":"https://github.com/opencog/opencog","homepage":"http://wiki.opencog.org/w/Development","size":152289,"stargazers_count":577,"watchers_count":577,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":96,"forks":288,"open_issues":96,"watchers":577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1594"},"html":{"href":"https://github.com/opencog/opencog/pull/1594"},"issue":{"href":"https://api.github.com/repos/opencog/opencog/issues/1594"},"comments":{"href":"https://api.github.com/repos/opencog/opencog/issues/1594/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1594/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1594/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/opencog/statuses/96b7a57dc4267371b88a38d82078b5faf1bed82c"}}}}