{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/32628661","id":32628661,"diff_hunk":"@@ -175,12 +175,12 @@ DomainIntegralAction::~DomainIntegralAction()\n void\n DomainIntegralAction::act()\n {\n-  const std::string uo_name(\"crackFrontDefinition\");\n-  const std::string ak_base_name(\"q\");\n-  const std::string av_base_name(\"q\");\n+  const std::string uo_name = \"crackFrontDefinition\";","path":"modules/solid_mechanics/src/actions/DomainIntegralAction.C","position":24,"original_position":24,"commit_id":"8ec76cda6db1dbc3e3022a43792838bf7f588d9b","original_commit_id":"8ec76cda6db1dbc3e3022a43792838bf7f588d9b","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"I don't think we mind having constructor syntax for non-integral types. The old way is fine here.","created_at":"2015-06-17T13:58:13Z","updated_at":"2015-06-17T13:58:13Z","html_url":"https://github.com/idaholab/moose/pull/5255#discussion_r32628661","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/5255","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/32628661"},"html":{"href":"https://github.com/idaholab/moose/pull/5255#discussion_r32628661"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5255"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/5255","id":37861734,"html_url":"https://github.com/idaholab/moose/pull/5255","diff_url":"https://github.com/idaholab/moose/pull/5255.diff","patch_url":"https://github.com/idaholab/moose/pull/5255.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/5255","number":5255,"state":"open","locked":false,"title":"Change getMaterialProperty semantics to match getFunction/getPostprocessorValue","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"body":"This is a fairly large commit that closes #5218. It augments ```getMaterialProperty``` to allow a user to pass in an input parameter key for an input parameter of type ```MaterialPropertyName```. This avoids the common ```getMaterialProperty<>(getParam<std::string>(\"key\"))``` pattern and replaces it with ```getMaterialProperty<>(\"key\")```. The big benefit is that the input parameters of type ```MaterialPropertyName``` now accept Real numbers for Real material properties. This allows developers to set numerical default values for material properties which are taken if no material property name is provided. It also allows users to supply constant numbers in input files directly where material properties of type real are needed.\r\n\r\nThere might be some additional application patches necessary (a one line patch is already in Marmot, Grizzly didn't need anything, I'm working on hyrax). I'll work with @snschune tomorrow to get yak and rattlesnake in shape.\r\n\r\nI have a few commits in place to use the new semantics all over framework, modules and tests (btw. the default property stuff is covered in the tests now). I have also edited some input files to remove a few GenericConstantMaterial properties and use default material properties instead. I'm sure more can be done (especially on the applications side).\r\n\r\nI will add follow on PRs (for new issues) to update the derivative material property system accordingly, but this PR is big enough as it is.","created_at":"2015-06-17T03:00:29Z","updated_at":"2015-06-17T13:58:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2e2da5e0ba2b4ccef40f269b3c8fde2e1b78339","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/5255/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/5255/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/5255/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/8ec76cda6db1dbc3e3022a43792838bf7f588d9b","head":{"label":"dschwen:getmatprop_5218","ref":"getmatprop_5218","sha":"8ec76cda6db1dbc3e3022a43792838bf7f588d9b","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"repo":{"id":17870930,"name":"moose","full_name":"dschwen/moose","owner":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dschwen/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/dschwen/moose","forks_url":"https://api.github.com/repos/dschwen/moose/forks","keys_url":"https://api.github.com/repos/dschwen/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dschwen/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dschwen/moose/teams","hooks_url":"https://api.github.com/repos/dschwen/moose/hooks","issue_events_url":"https://api.github.com/repos/dschwen/moose/issues/events{/number}","events_url":"https://api.github.com/repos/dschwen/moose/events","assignees_url":"https://api.github.com/repos/dschwen/moose/assignees{/user}","branches_url":"https://api.github.com/repos/dschwen/moose/branches{/branch}","tags_url":"https://api.github.com/repos/dschwen/moose/tags","blobs_url":"https://api.github.com/repos/dschwen/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dschwen/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dschwen/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/dschwen/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dschwen/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/dschwen/moose/languages","stargazers_url":"https://api.github.com/repos/dschwen/moose/stargazers","contributors_url":"https://api.github.com/repos/dschwen/moose/contributors","subscribers_url":"https://api.github.com/repos/dschwen/moose/subscribers","subscription_url":"https://api.github.com/repos/dschwen/moose/subscription","commits_url":"https://api.github.com/repos/dschwen/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/dschwen/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/dschwen/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/dschwen/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/dschwen/moose/contents/{+path}","compare_url":"https://api.github.com/repos/dschwen/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dschwen/moose/merges","archive_url":"https://api.github.com/repos/dschwen/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dschwen/moose/downloads","issues_url":"https://api.github.com/repos/dschwen/moose/issues{/number}","pulls_url":"https://api.github.com/repos/dschwen/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/dschwen/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/dschwen/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dschwen/moose/labels{/name}","releases_url":"https://api.github.com/repos/dschwen/moose/releases{/id}","created_at":"2014-03-18T15:25:39Z","updated_at":"2015-04-23T01:28:39Z","pushed_at":"2015-06-17T04:36:26Z","git_url":"git://github.com/dschwen/moose.git","ssh_url":"git@github.com:dschwen/moose.git","clone_url":"https://github.com/dschwen/moose.git","svn_url":"https://github.com/dschwen/moose","homepage":null,"size":107168,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"b109b94a2b4198ae43262bb9488ea87d52027c54","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2015-06-09T05:07:23Z","pushed_at":"2015-06-17T13:44:32Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":126888,"stargazers_count":83,"watchers_count":83,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":136,"mirror_url":null,"open_issues_count":469,"forks":136,"open_issues":469,"watchers":83,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5255"},"html":{"href":"https://github.com/idaholab/moose/pull/5255"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/5255"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/5255/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5255/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5255/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/8ec76cda6db1dbc3e3022a43792838bf7f588d9b"}}}}