{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/36972462","id":36972462,"diff_hunk":"@@ -20,16 +20,15 @@\n #define JERRY_MEM_POOL_INTERNAL\n \n #include \"mem-allocator.h\"\n-#include \"mem-pool.h\"\n #include \"mem-poolman.h\"\n \n #include \"test-common.h\"\n \n // Iterations count\n-const uint32_t test_iters = 16384;\n+const uint32_t test_iters = 1024;\n \n // Subiterations count\n-const uint32_t test_max_sub_iters = 32;\n+const uint32_t test_max_sub_iters = 1024;","path":"tests/unit/test-poolman.cpp","position":15,"original_position":15,"commit_id":"881d227a5fcd5d82d23e607b032f711da36d8f66","original_commit_id":"881d227a5fcd5d82d23e607b032f711da36d8f66","user":{"login":"zherczeg","id":2270193,"avatar_url":"https://avatars.githubusercontent.com/u/2270193?v=3","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"1024*1024 is twice as big as 16384 * 32. Is this ok?","created_at":"2015-08-13T13:19:29Z","updated_at":"2015-08-13T13:19:29Z","html_url":"https://github.com/Samsung/jerryscript/pull/565#discussion_r36972462","pull_request_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/565","_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/36972462"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/565#discussion_r36972462"},"pull_request":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/565"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/565","id":42262221,"html_url":"https://github.com/Samsung/jerryscript/pull/565","diff_url":"https://github.com/Samsung/jerryscript/pull/565.diff","patch_url":"https://github.com/Samsung/jerryscript/pull/565.patch","issue_url":"https://api.github.com/repos/Samsung/jerryscript/issues/565","number":565,"state":"open","locked":false,"title":"Improvement of pool allocator","user":{"login":"ruben-ayrapetyan","id":11939769,"avatar_url":"https://avatars.githubusercontent.com/u/11939769?v=3","gravatar_id":"","url":"https://api.github.com/users/ruben-ayrapetyan","html_url":"https://github.com/ruben-ayrapetyan","followers_url":"https://api.github.com/users/ruben-ayrapetyan/followers","following_url":"https://api.github.com/users/ruben-ayrapetyan/following{/other_user}","gists_url":"https://api.github.com/users/ruben-ayrapetyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ruben-ayrapetyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruben-ayrapetyan/subscriptions","organizations_url":"https://api.github.com/users/ruben-ayrapetyan/orgs","repos_url":"https://api.github.com/users/ruben-ayrapetyan/repos","events_url":"https://api.github.com/users/ruben-ayrapetyan/events{/privacy}","received_events_url":"https://api.github.com/users/ruben-ayrapetyan/received_events","type":"User","site_admin":false},"body":"Arndale (Dual-core, 1 Ghz)\r\n\r\nBenchmark | Rss | Perf\r\n-------- | -------- | --------\r\n./sunspider-1.0.2.stable/3d-cube.js | 176 -> 172 <br> (2.273%) | 3.536 -> 3.03 <br> (14.310%) | \r\n./sunspider-1.0.2.stable/access-binary-trees.js | 100 -> 104 <br> (-4.000%) | 1.993 -> 2.124 <br> (-6.573%) | \r\n./sunspider-1.0.2.stable/access-fannkuch.js | 48 -> 48 <br> (0.000%) | 8.566 -> 7.237 <br> (15.515%) | \r\n./sunspider-1.0.2.stable/access-nbody.js | 72 -> 72 <br> (0.000%) | 3.908 -> 3.488 <br> (10.747%) | \r\n./sunspider-1.0.2.stable/bitops-3bit-bits-in-byte.js | 36 -> 36 <br> (0.000%) | 2.629 -> 2.328 <br> (11.449%) | \r\n./sunspider-1.0.2.stable/bitops-bits-in-byte.js | 36 -> 36 <br> (0.000%) | 3.722 -> 3.181 <br> (14.535%) | \r\n./sunspider-1.0.2.stable/bitops-bitwise-and.js | 28 -> 28 <br> (0.000%) | 2.269 -> 1.881 <br> (17.100%) | \r\n./sunspider-1.0.2.stable/controlflow-recursive.js | 216 -> 224 <br> (-3.704%) | 2.084 -> 1.882 <br> (9.693%) | \r\n./sunspider-1.0.2.stable/crypto-sha1.js | 148 -> 168 <br> (-13.514%) | 64.046 -> 56.812 <br> (11.295%) | \r\n./sunspider-1.0.2.stable/date-format-xparb.js | 112 -> 112 <br> (0.000%) | 2.321 -> 2.348 <br> (-1.163%) | \r\n./sunspider-1.0.2.stable/math-cordic.js | 52 -> 48 <br> (7.692%) | 4.637 -> 3.751 <br> (19.107%) | \r\n./sunspider-1.0.2.stable/math-partial-sums.js | 40 -> 40 <br> (0.000%) | 1.819 -> 1.647 <br> (9.456%) | \r\n./sunspider-1.0.2.stable/math-spectral-norm.js | 52 -> 52 <br> (0.000%) | 2.557 -> 2.068 <br> (19.124%) | \r\n./sunspider-1.0.2.stable/string-fasta.js | 60 -> 52 <br> (13.333%) | 19.614 -> 19.52 <br> (0.479%) | \r\nGeometric mean | 0.3122% | 10.659%\r\n\r\nBenchmark | Rss | Perf\r\n-------- | -------- | --------\r\n./sunspider-0.9.1/3d-cube.js | 9.302% | 14.608% | \r\n./sunspider-0.9.1/access-binary-trees.js | -4.348% | 10.991% | \r\n./sunspider-0.9.1/access-fannkuch.js | 15.385% | 9.101% | \r\n./sunspider-0.9.1/access-nbody.js | 5.556% | 10.877% | \r\n./sunspider-0.9.1/bitops-3bit-bits-in-byte.js | 11.111% | 12.732% | \r\n./sunspider-0.9.1/bitops-bits-in-byte.js | 0.000% | 14.623% | \r\n./sunspider-0.9.1/bitops-bitwise-and.js | 0.000% | 6.733% | \r\n./sunspider-0.9.1/controlflow-recursive.js | -5.660% | 9.434% | \r\n./sunspider-0.9.1/date-format-xparb.js | 0.000% | -1.037% | \r\n./sunspider-0.9.1/math-cordic.js | -9.091% | 17.247% | \r\n./sunspider-0.9.1/math-partial-sums.js | 0.000% | 12.784% | \r\n./sunspider-0.9.1/math-spectral-norm.js | 0.000% | 19.504% | \r\nGeometric mean | 2.1026% | 11.6084%\r\n","created_at":"2015-08-12T16:52:26Z","updated_at":"2015-08-13T13:19:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69a5d2022f8f3b6934ea4da4004a12b448368e3a","assignee":{"login":"egavrin","id":782710,"avatar_url":"https://avatars.githubusercontent.com/u/782710?v=3","gravatar_id":"","url":"https://api.github.com/users/egavrin","html_url":"https://github.com/egavrin","followers_url":"https://api.github.com/users/egavrin/followers","following_url":"https://api.github.com/users/egavrin/following{/other_user}","gists_url":"https://api.github.com/users/egavrin/gists{/gist_id}","starred_url":"https://api.github.com/users/egavrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egavrin/subscriptions","organizations_url":"https://api.github.com/users/egavrin/orgs","repos_url":"https://api.github.com/users/egavrin/repos","events_url":"https://api.github.com/users/egavrin/events{/privacy}","received_events_url":"https://api.github.com/users/egavrin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Samsung/jerryscript/milestones/4","html_url":"https://github.com/Samsung/jerryscript/milestones/Engine%20optimization%20&%20enhancement","labels_url":"https://api.github.com/repos/Samsung/jerryscript/milestones/4/labels","id":1188990,"number":4,"title":"Engine optimization & enhancement","description":"","creator":{"login":"egavrin","id":782710,"avatar_url":"https://avatars.githubusercontent.com/u/782710?v=3","gravatar_id":"","url":"https://api.github.com/users/egavrin","html_url":"https://github.com/egavrin","followers_url":"https://api.github.com/users/egavrin/followers","following_url":"https://api.github.com/users/egavrin/following{/other_user}","gists_url":"https://api.github.com/users/egavrin/gists{/gist_id}","starred_url":"https://api.github.com/users/egavrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egavrin/subscriptions","organizations_url":"https://api.github.com/users/egavrin/orgs","repos_url":"https://api.github.com/users/egavrin/repos","events_url":"https://api.github.com/users/egavrin/events{/privacy}","received_events_url":"https://api.github.com/users/egavrin/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":23,"state":"open","created_at":"2015-07-01T13:22:04Z","updated_at":"2015-08-12T16:52:26Z","due_on":"2015-08-27T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/565/commits","review_comments_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/565/comments","review_comment_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/issues/565/comments","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/881d227a5fcd5d82d23e607b032f711da36d8f66","head":{"label":"Samsung:Ruben-improve-pool-allocator","ref":"Ruben-improve-pool-allocator","sha":"881d227a5fcd5d82d23e607b032f711da36d8f66","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"Samsung/jerryscript","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/jerryscript","description":"","fork":false,"url":"https://api.github.com/repos/Samsung/jerryscript","forks_url":"https://api.github.com/repos/Samsung/jerryscript/forks","keys_url":"https://api.github.com/repos/Samsung/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/jerryscript/teams","hooks_url":"https://api.github.com/repos/Samsung/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/jerryscript/events","assignees_url":"https://api.github.com/repos/Samsung/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/jerryscript/tags","blobs_url":"https://api.github.com/repos/Samsung/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/jerryscript/languages","stargazers_url":"https://api.github.com/repos/Samsung/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/Samsung/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/Samsung/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/Samsung/jerryscript/subscription","commits_url":"https://api.github.com/repos/Samsung/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/jerryscript/merges","archive_url":"https://api.github.com/repos/Samsung/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/jerryscript/downloads","issues_url":"https://api.github.com/repos/Samsung/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/jerryscript/releases{/id}","created_at":"2015-04-03T01:10:31Z","updated_at":"2015-08-13T11:34:23Z","pushed_at":"2015-08-13T13:18:36Z","git_url":"git://github.com/Samsung/jerryscript.git","ssh_url":"git@github.com:Samsung/jerryscript.git","clone_url":"https://github.com/Samsung/jerryscript.git","svn_url":"https://github.com/Samsung/jerryscript","homepage":null,"size":12330,"stargazers_count":843,"watchers_count":843,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":91,"forks":55,"open_issues":91,"watchers":843,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"4ee30cba5d68586d4d248660df83dac316c7603a","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"Samsung/jerryscript","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/jerryscript","description":"","fork":false,"url":"https://api.github.com/repos/Samsung/jerryscript","forks_url":"https://api.github.com/repos/Samsung/jerryscript/forks","keys_url":"https://api.github.com/repos/Samsung/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/jerryscript/teams","hooks_url":"https://api.github.com/repos/Samsung/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/jerryscript/events","assignees_url":"https://api.github.com/repos/Samsung/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/jerryscript/tags","blobs_url":"https://api.github.com/repos/Samsung/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/jerryscript/languages","stargazers_url":"https://api.github.com/repos/Samsung/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/Samsung/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/Samsung/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/Samsung/jerryscript/subscription","commits_url":"https://api.github.com/repos/Samsung/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/jerryscript/merges","archive_url":"https://api.github.com/repos/Samsung/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/jerryscript/downloads","issues_url":"https://api.github.com/repos/Samsung/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/jerryscript/releases{/id}","created_at":"2015-04-03T01:10:31Z","updated_at":"2015-08-13T11:34:23Z","pushed_at":"2015-08-13T13:18:36Z","git_url":"git://github.com/Samsung/jerryscript.git","ssh_url":"git@github.com:Samsung/jerryscript.git","clone_url":"https://github.com/Samsung/jerryscript.git","svn_url":"https://github.com/Samsung/jerryscript","homepage":null,"size":12330,"stargazers_count":843,"watchers_count":843,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":91,"forks":55,"open_issues":91,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/565"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/565"},"issue":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/565"},"comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/565/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/565/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/565/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/jerryscript/statuses/881d227a5fcd5d82d23e607b032f711da36d8f66"}}}}