{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/19872","labels_url":"https://api.github.com/repos/owncloud/core/issues/19872/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/19872/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/19872/events","html_url":"https://github.com/owncloud/core/pull/19872","id":112161360,"number":19872,"title":"Share2.0 sharemanager","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/sharing","name":"sharing","color":"e102d8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/48","html_url":"https://github.com/owncloud/core/milestones/9.0-next","labels_url":"https://api.github.com/repos/owncloud/core/milestones/48/labels","id":1196845,"number":48,"title":"9.0-next","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":506,"closed_issues":75,"state":"open","created_at":"2015-07-07T14:21:23Z","updated_at":"2015-10-19T21:50:11Z","due_on":"2016-02-09T05:00:00Z","closed_at":null},"comments":3,"created_at":"2015-10-19T14:50:42Z","updated_at":"2015-10-20T05:44:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/19872","html_url":"https://github.com/owncloud/core/pull/19872","diff_url":"https://github.com/owncloud/core/pull/19872.diff","patch_url":"https://github.com/owncloud/core/pull/19872.patch"},"body":"@schiesbn @DeepDiver1975 first draft is here.\r\n\r\nfor now we have a sharemanager object and a ishareprovider and that is it. So no share object. Basically everything goes trough the share manager.\r\n\r\nThe manager itself acts like some kind of middleware between the shareprovider and the OCS Share API. Making sure that arguments are in the right format (date for example). And making sure that the user we want to share with exists etc.\r\n\r\nIShareProviders register themself at the sharemanager with a callback function. And then all the magic happens.\r\n\r\nMany things in the code do not work as expected yet or are even plain wrong now. But if we agree this is the way to go I can start cleaning up and already write some simple unit tests for this part. And do some squashing of commits :P\r\n\r\nSo feedback please :)"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/149439735","html_url":"https://github.com/owncloud/core/pull/19872#issuecomment-149439735","issue_url":"https://api.github.com/repos/owncloud/core/issues/19872","id":149439735,"user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T05:44:06Z","updated_at":"2015-10-20T05:44:06Z","body":"@DeepDiver1975 yeah I know it doesn't work. But I first wanted to agree if this was the way to go for the manager before I start to do all kinds of actual code and add unit tests etc."}}