{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/30972979","id":30972979,"diff_hunk":"@@ -161,18 +161,59 @@ private function renderItem( $type, array $data ) {\n \t\t\t->render( $this->templates[ $type ] );\n \t}\n \n-\tprotected function getThumbnailUrl( $url ) {\n+\t/**\n+\t * @desc returns the thumbnail url from\n+\t * Vignette or from old service\n+\t * @param string $url\n+\t * @return string thumbnail url\n+\t */\n+\tprotected function getThumbnailUrl( $data ) {\n+\t\t$url = $data['url'];\n+\t\t// TODO: remove 'if' condition when unified thumb method\n+\t\t// will be implemented: https://wikia­inc.atlassian.net/browse/PLATFORM­1237\n+\t\tif ( VignetteRequest::isVignetteUrl( $url ) ) {\n+\t\t\treturn $this->createVignetteThumbnail( $url );\n+\t\t} else {\n+\t\t\treturn $this->createOldThumbnail( $data['name'] );\n+\t\t}\n+\t}\n+\n+\t/**\n+\t * @param $url\n+\t * @return string\n+\t */\n+\tprivate function createVignetteThumbnail( $url ) {\n \t\treturn VignetteRequest::fromUrl( $url )\n \t\t\t->thumbnailDown()\n-\t\t\t->width( F::app()->checkSkin( 'wikiamobile' ) ?\n+\t\t\t->width(F::app()->checkSkin( 'wikiamobile' ) ?\n \t\t\t\tself::MOBILE_THUMBNAIL_WIDTH :\n \t\t\t\tself::DESKTOP_THUMBNAIL_WIDTH\n \t\t\t)\n-\t\t\t->height(self::THUMBNAIL_HEIGHT)\n+\t\t\t->height( self::THUMBNAIL_HEIGHT )\n \t\t\t->url();\n \t}\n \n \t/**\n+\t * @desc If the image is served from an old\n+\t * service we have to again obtain file to\n+\t * call the createThumb function\n+\t * @param $name\n+\t * @return mixed\n+\t */\n+\tprivate function createOldThumbnail( $name )\n+\t{\n+\t\t$file = wfFindFile( $name );","path":"extensions/wikia/PortableInfobox/services/PortableInfoboxRenderService.class.php","position":57,"original_position":57,"commit_id":"f32c1d948b6784b9369892c48f0f6501dea4bf1c","original_commit_id":"f32c1d948b6784b9369892c48f0f6501dea4bf1c","user":{"login":"RafLeszczynski","id":859645,"avatar_url":"https://avatars.githubusercontent.com/u/859645?v=3","gravatar_id":"","url":"https://api.github.com/users/RafLeszczynski","html_url":"https://github.com/RafLeszczynski","followers_url":"https://api.github.com/users/RafLeszczynski/followers","following_url":"https://api.github.com/users/RafLeszczynski/following{/other_user}","gists_url":"https://api.github.com/users/RafLeszczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/RafLeszczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RafLeszczynski/subscriptions","organizations_url":"https://api.github.com/users/RafLeszczynski/orgs","repos_url":"https://api.github.com/users/RafLeszczynski/repos","events_url":"https://api.github.com/users/RafLeszczynski/events{/privacy}","received_events_url":"https://api.github.com/users/RafLeszczynski/received_events","type":"User","site_admin":false},"body":"consider using one way to get File object across entire extension. Inside `NodeImage.php` you are creating file object using `\\WikiaFileHelper::getFileFromTitle($title);`","created_at":"2015-05-25T10:18:35Z","updated_at":"2015-05-25T10:18:35Z","html_url":"https://github.com/Wikia/app/pull/7308#discussion_r30972979","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/7308","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/30972979"},"html":{"href":"https://github.com/Wikia/app/pull/7308#discussion_r30972979"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/7308"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/7308","id":36044505,"html_url":"https://github.com/Wikia/app/pull/7308","diff_url":"https://github.com/Wikia/app/pull/7308.diff","patch_url":"https://github.com/Wikia/app/pull/7308.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/7308","number":7308,"state":"open","locked":false,"title":"DAT-2834 Support non-vignette images in infoboxes","user":{"login":"dianafa","id":3716441,"avatar_url":"https://avatars.githubusercontent.com/u/3716441?v=3","gravatar_id":"","url":"https://api.github.com/users/dianafa","html_url":"https://github.com/dianafa","followers_url":"https://api.github.com/users/dianafa/followers","following_url":"https://api.github.com/users/dianafa/following{/other_user}","gists_url":"https://api.github.com/users/dianafa/gists{/gist_id}","starred_url":"https://api.github.com/users/dianafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianafa/subscriptions","organizations_url":"https://api.github.com/users/dianafa/orgs","repos_url":"https://api.github.com/users/dianafa/repos","events_url":"https://api.github.com/users/dianafa/events{/privacy}","received_events_url":"https://api.github.com/users/dianafa/received_events","type":"User","site_admin":false},"body":"https://wikia-inc.atlassian.net/browse/DAT-2834\r\n\r\nFor now this solution uses an ugly 'if' here: https://github.com/Wikia/app/compare/DAT-2834#diff-38f4ac017c46ec2a05d85a08356fab19R174.\r\nWhen this ticket will be solved: \r\nhttps://wikia­inc.atlassian.net/browse/PLATFORM­1237\r\nplease remove this hack.","created_at":"2015-05-22T15:56:09Z","updated_at":"2015-05-25T10:18:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11d274ff220573e5795a96b297f4635a2251395b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/7308/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/7308/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/7308/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/f32c1d948b6784b9369892c48f0f6501dea4bf1c","head":{"label":"Wikia:DAT-2834","ref":"DAT-2834","sha":"f32c1d948b6784b9369892c48f0f6501dea4bf1c","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-05-08T19:30:43Z","pushed_at":"2015-05-25T09:52:22Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1409555,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":76,"forks":56,"open_issues":76,"watchers":77,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"e5b54f20d55b42cb5355b982074ee18f8bd3e7fb","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-05-08T19:30:43Z","pushed_at":"2015-05-25T09:52:22Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1409555,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":76,"forks":56,"open_issues":76,"watchers":77,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/7308"},"html":{"href":"https://github.com/Wikia/app/pull/7308"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/7308"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/7308/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/7308/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/7308/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/f32c1d948b6784b9369892c48f0f6501dea4bf1c"}}}}