{"action":"created","issue":{"url":"https://api.github.com/repos/igniterealtime/Openfire/issues/411","labels_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/411/labels{/name}","comments_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/411/comments","events_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/411/events","html_url":"https://github.com/igniterealtime/Openfire/pull/411","id":118732471,"number":411,"title":"Fix NPE when handling routing failures","user":{"login":"tevans","id":826423,"avatar_url":"https://avatars.githubusercontent.com/u/826423?v=3","gravatar_id":"","url":"https://api.github.com/users/tevans","html_url":"https://github.com/tevans","followers_url":"https://api.github.com/users/tevans/followers","following_url":"https://api.github.com/users/tevans/following{/other_user}","gists_url":"https://api.github.com/users/tevans/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans/subscriptions","organizations_url":"https://api.github.com/users/tevans/orgs","repos_url":"https://api.github.com/users/tevans/repos","events_url":"https://api.github.com/users/tevans/events{/privacy}","received_events_url":"https://api.github.com/users/tevans/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-25T00:24:42Z","updated_at":"2015-11-25T18:45:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/411","html_url":"https://github.com/igniterealtime/Openfire/pull/411","diff_url":"https://github.com/igniterealtime/Openfire/pull/411.diff","patch_url":"https://github.com/igniterealtime/Openfire/pull/411.patch"},"body":"Avoids NPE by dropping (and optionally logging) error response stanzas\r\nif the original packet has no sender JID."},"comment":{"url":"https://api.github.com/repos/igniterealtime/Openfire/issues/comments/159698378","html_url":"https://github.com/igniterealtime/Openfire/pull/411#issuecomment-159698378","issue_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/411","id":159698378,"user":{"login":"tevans","id":826423,"avatar_url":"https://avatars.githubusercontent.com/u/826423?v=3","gravatar_id":"","url":"https://api.github.com/users/tevans","html_url":"https://github.com/tevans","followers_url":"https://api.github.com/users/tevans/followers","following_url":"https://api.github.com/users/tevans/following{/other_user}","gists_url":"https://api.github.com/users/tevans/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans/subscriptions","organizations_url":"https://api.github.com/users/tevans/orgs","repos_url":"https://api.github.com/users/tevans/repos","events_url":"https://api.github.com/users/tevans/events{/privacy}","received_events_url":"https://api.github.com/users/tevans/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T18:45:14Z","updated_at":"2015-11-25T18:45:14Z","body":"Following up on this - the specific packets we are seeing are server-generated Roster broadcasts, e.g. https://github.com/igniterealtime/Openfire/blob/master/src/java/org/jivesoftware/openfire/roster/Roster.java#L712\r\nI suspect there are other type of packets sent from the server. Perhaps we should take a pass through to set the 'from' attribute to the domain, but this PR would act as an NPE guard in the meantime."}}