{"action":"created","issue":{"url":"https://api.github.com/repos/lsalzman/enet/issues/49","labels_url":"https://api.github.com/repos/lsalzman/enet/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/lsalzman/enet/issues/49/comments","events_url":"https://api.github.com/repos/lsalzman/enet/issues/49/events","html_url":"https://github.com/lsalzman/enet/issues/49","id":101912210,"number":49,"title":"Overzealous parenthesis","user":{"login":"gregoire-astruc","id":494291,"avatar_url":"https://avatars.githubusercontent.com/u/494291?v=3","gravatar_id":"","url":"https://api.github.com/users/gregoire-astruc","html_url":"https://github.com/gregoire-astruc","followers_url":"https://api.github.com/users/gregoire-astruc/followers","following_url":"https://api.github.com/users/gregoire-astruc/following{/other_user}","gists_url":"https://api.github.com/users/gregoire-astruc/gists{/gist_id}","starred_url":"https://api.github.com/users/gregoire-astruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregoire-astruc/subscriptions","organizations_url":"https://api.github.com/users/gregoire-astruc/orgs","repos_url":"https://api.github.com/users/gregoire-astruc/repos","events_url":"https://api.github.com/users/gregoire-astruc/events{/privacy}","received_events_url":"https://api.github.com/users/gregoire-astruc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-19T14:52:46Z","updated_at":"2015-08-19T19:41:27Z","closed_at":null,"body":"During my build with clang, a few innocuous warnings popped up:\r\n```\r\nenet/peer.c:227:59: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]\r\n\r\n   if ((((& peer -> dispatchedCommands) -> sentinel.next) == (& (& peer -> dispatchedCommands) -> sentinel)))\r\n\r\n\r\nenet/protocol.c:92:67: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]\r\n\r\n           if ((((& peer -> dispatchedCommands) -> sentinel.next) == (& (& peer -> dispatchedCommands) -> sentinel)))\r\n\r\nenet/protocol.c:264:62: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]\r\n\r\n    if ((((& peer -> sentReliableCommands) -> sentinel.next) == (& (& peer -> sentReliableCommands) -> sentinel)))\r\n\r\nenet/protocol.c:1546:65: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]\r\n\r\n       if ((((& peer -> sentReliableCommands) -> sentinel.next) == (& (& peer -> sentReliableCommands) -> sentinel)))\r\n```\r\nNothing critical, but I like keeping the warnings as low as possible (if any at all) :)"},"comment":{"url":"https://api.github.com/repos/lsalzman/enet/issues/comments/132754762","html_url":"https://github.com/lsalzman/enet/issues/49#issuecomment-132754762","issue_url":"https://api.github.com/repos/lsalzman/enet/issues/49","id":132754762,"user":{"login":"gregoire-astruc","id":494291,"avatar_url":"https://avatars.githubusercontent.com/u/494291?v=3","gravatar_id":"","url":"https://api.github.com/users/gregoire-astruc","html_url":"https://github.com/gregoire-astruc","followers_url":"https://api.github.com/users/gregoire-astruc/followers","following_url":"https://api.github.com/users/gregoire-astruc/following{/other_user}","gists_url":"https://api.github.com/users/gregoire-astruc/gists{/gist_id}","starred_url":"https://api.github.com/users/gregoire-astruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregoire-astruc/subscriptions","organizations_url":"https://api.github.com/users/gregoire-astruc/orgs","repos_url":"https://api.github.com/users/gregoire-astruc/repos","events_url":"https://api.github.com/users/gregoire-astruc/events{/privacy}","received_events_url":"https://api.github.com/users/gregoire-astruc/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T19:41:27Z","updated_at":"2015-08-19T19:41:27Z","body":"I beg to differ, extra parens here are not the ones you think :)\r\n```c\r\nif ((((& peer -> sentReliableCommands) -> sentinel.next) == (& (& peer -> sentReliableCommands) -> sentinel)))\r\n/* is equivalent to */\r\nif ( ((& peer -> sentReliableCommands) -> sentinel.next) == (& (& peer -> sentReliableCommands) -> sentinel) )\r\n\r\n// This is\r\nif ((expr)) /* vs */ if (expr)\r\n```\r\n\r\nSo there's no argument about readability here :)\r\nAnd I like my warnings turned on  :-$"}}