{"action":"created","issue":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/301","labels_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/301/comments","events_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/301/events","html_url":"https://github.com/DestinyItemManager/DIM/pull/301","id":110979261,"number":301,"title":"Proposal for UI&UX improvements in the move popup dialog","user":{"login":"vincchan","id":868272,"avatar_url":"https://avatars.githubusercontent.com/u/868272?v=3","gravatar_id":"","url":"https://api.github.com/users/vincchan","html_url":"https://github.com/vincchan","followers_url":"https://api.github.com/users/vincchan/followers","following_url":"https://api.github.com/users/vincchan/following{/other_user}","gists_url":"https://api.github.com/users/vincchan/gists{/gist_id}","starred_url":"https://api.github.com/users/vincchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincchan/subscriptions","organizations_url":"https://api.github.com/users/vincchan/orgs","repos_url":"https://api.github.com/users/vincchan/repos","events_url":"https://api.github.com/users/vincchan/events{/privacy}","received_events_url":"https://api.github.com/users/vincchan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-12T13:52:53Z","updated_at":"2015-10-12T15:24:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/301","html_url":"https://github.com/DestinyItemManager/DIM/pull/301","diff_url":"https://github.com/DestinyItemManager/DIM/pull/301.diff","patch_url":"https://github.com/DestinyItemManager/DIM/pull/301.patch"},"body":"Looking at the UI horizontally, DIM is structured as follows:\r\n\r\n<img width=\"1062\" alt=\"screen shot 2015-10-12 at 15 23 58\" src=\"https://cloud.githubusercontent.com/assets/868272/10429144/c9c52d86-70f6-11e5-91b9-a36364f8d2e2.png\">\r\n\r\nIf we look at the move popup dialog box that shows up after you click on an item. You'll see following structure of the move buttons which do not match the UI that was previously mentioned.\r\n\r\n<img width=\"336\" alt=\"screen shot 2015-10-12 at 15 22 59\" src=\"https://cloud.githubusercontent.com/assets/868272/10429177/08c4e8be-70f7-11e5-8745-3ca7378b015e.png\">\r\n\r\nWith this PR I propose to tweak the button layouts a bit.\r\n\r\n1. Changed the order of the buttons (Store / Equip) to better reflect the rest of the UI\r\n2. Wrap a border around the corresponding buttons which will help users better distinguish between the buttons of characters and vault. This is especially useful if they are using the same or similar looking Emblems.\r\n\r\nThis is the end result:\r\n<img width=\"346\" alt=\"screen shot 2015-10-12 at 15 22 49\" src=\"https://cloud.githubusercontent.com/assets/868272/10429298/c7bf7572-70f7-11e5-8dc9-37535ec657ba.png\">\r\n\r\nI'd appreciate some feedbacks for my take on this. I know it can be improved quite a bit. I was thinking maybe we could parse the prominent color of the emblem and use that as the border color...\r\n"},"comment":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/comments/147434871","html_url":"https://github.com/DestinyItemManager/DIM/pull/301#issuecomment-147434871","issue_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/301","id":147434871,"user":{"login":"SunburnedGoose","id":984608,"avatar_url":"https://avatars.githubusercontent.com/u/984608?v=3","gravatar_id":"","url":"https://api.github.com/users/SunburnedGoose","html_url":"https://github.com/SunburnedGoose","followers_url":"https://api.github.com/users/SunburnedGoose/followers","following_url":"https://api.github.com/users/SunburnedGoose/following{/other_user}","gists_url":"https://api.github.com/users/SunburnedGoose/gists{/gist_id}","starred_url":"https://api.github.com/users/SunburnedGoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunburnedGoose/subscriptions","organizations_url":"https://api.github.com/users/SunburnedGoose/orgs","repos_url":"https://api.github.com/users/SunburnedGoose/repos","events_url":"https://api.github.com/users/SunburnedGoose/events{/privacy}","received_events_url":"https://api.github.com/users/SunburnedGoose/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T15:24:04Z","updated_at":"2015-10-12T15:24:04Z","body":"Character order in the move popup needs to match the UI. Fixed or most\nrecent.\n\nI like emphasis given to the relationship but not the white borders. I'll\nthink about it\nOn Mon, Oct 12, 2015 at 7:28 AM Luca Simone <notifications@github.com>\nwrote:\n\n> Love it! [image: :+1:] great work\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/DestinyItemManager/DIM/pull/301#issuecomment-147413308>\n> .\n>\n"}}