{"action":"created","comment":{"url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/comments/46004398","id":46004398,"diff_hunk":"@@ -13,24 +15,30 @@ module Capybara::Poltergeist\n         expect(subject.inspector).to be_nil\n       end\n \n-      it 'adds --ssl-protocol=any to driver options' do\n-        expect(subject.phantomjs_options).to eq(%w{--ssl-protocol=any})\n+      it 'adds default phantomjs options to driver options' do\n+        expect(subject.phantomjs_options).to eq(default_phantomjs_options)\n       end\n     end\n \n     context 'with a phantomjs_options option' do\n       subject { Driver.new(nil, phantomjs_options: %w{--hello})}\n \n-      it \"is a combination of ssl-protocol and the provided options\" do\n-        expect(subject.phantomjs_options).to eq(%w{--hello --ssl-protocol=any})\n+      it \"is a combination of ssl settings and the provided options\" do\n+        expect(subject.phantomjs_options).to eq(%w{--hello --ignore-ssl-errors=yes --ssl-protocol=TLSv1})\n       end\n     end\n \n-    context 'with phantomjs_options containing ssl-protocol' do\n-      subject { Driver.new(nil, phantomjs_options: %w{--ssl-protocol=tlsv1})}\n+    context 'with phantomjs_options containing ssl-protocol settings' do\n+      subject { Driver.new(nil, phantomjs_options: %w{--ssl-protocol=any --ignore-ssl-errors=no})}\n \n       it \"uses the provided ssl-protocol\" do\n-        expect(subject.phantomjs_options).to eq(%w{--ssl-protocol=tlsv1})\n+        expect(subject.phantomjs_options).to include('--ssl-protocol=any')\n+        expect(subject.phantomjs_options).not_to include('--sll-protocol=TLSv1')","path":"spec/unit/driver_spec.rb","position":null,"original_position":38,"commit_id":"2ab17d7e6586b9661bdfc0983c46895f5ba2d3f1","original_commit_id":"262bf2fedecc179c9aa175a0acab00f6d3ce8d0d","user":{"login":"twalpole","id":16556,"avatar_url":"https://avatars.githubusercontent.com/u/16556?v=3","gravatar_id":"","url":"https://api.github.com/users/twalpole","html_url":"https://github.com/twalpole","followers_url":"https://api.github.com/users/twalpole/followers","following_url":"https://api.github.com/users/twalpole/following{/other_user}","gists_url":"https://api.github.com/users/twalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/twalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalpole/subscriptions","organizations_url":"https://api.github.com/users/twalpole/orgs","repos_url":"https://api.github.com/users/twalpole/repos","events_url":"https://api.github.com/users/twalpole/events{/privacy}","received_events_url":"https://api.github.com/users/twalpole/received_events","type":"User","site_admin":false},"body":"yes it was -- should be fixed and squashed now","created_at":"2015-11-26T19:53:41Z","updated_at":"2015-11-26T19:53:41Z","html_url":"https://github.com/teampoltergeist/poltergeist/pull/694#discussion_r46004398","pull_request_url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/comments/46004398"},"html":{"href":"https://github.com/teampoltergeist/poltergeist/pull/694#discussion_r46004398"},"pull_request":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694","id":50698475,"html_url":"https://github.com/teampoltergeist/poltergeist/pull/694","diff_url":"https://github.com/teampoltergeist/poltergeist/pull/694.diff","patch_url":"https://github.com/teampoltergeist/poltergeist/pull/694.patch","issue_url":"https://api.github.com/repos/teampoltergeist/poltergeist/issues/694","number":694,"state":"open","locked":false,"title":"set ssl phantomjs_options for default driver registration","user":{"login":"twalpole","id":16556,"avatar_url":"https://avatars.githubusercontent.com/u/16556?v=3","gravatar_id":"","url":"https://api.github.com/users/twalpole","html_url":"https://github.com/twalpole","followers_url":"https://api.github.com/users/twalpole/followers","following_url":"https://api.github.com/users/twalpole/following{/other_user}","gists_url":"https://api.github.com/users/twalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/twalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalpole/subscriptions","organizations_url":"https://api.github.com/users/twalpole/orgs","repos_url":"https://api.github.com/users/twalpole/repos","events_url":"https://api.github.com/users/twalpole/events{/privacy}","received_events_url":"https://api.github.com/users/twalpole/received_events","type":"User","site_admin":false},"body":"@route After reading a few of the currently open issues, and helping a couple of people on stackoverflow, it seems like setting phantomjs options --ignore-ssl-errors=yes --ssl-protocol=TLSv1  might make sense in the default registered poltergeist driver, thoughts?","created_at":"2015-11-13T22:09:18Z","updated_at":"2015-11-26T19:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a56a7f13b47596518879f02e7a3bca38f3ed3509","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694/commits","review_comments_url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694/comments","review_comment_url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teampoltergeist/poltergeist/issues/694/comments","statuses_url":"https://api.github.com/repos/teampoltergeist/poltergeist/statuses/2ab17d7e6586b9661bdfc0983c46895f5ba2d3f1","head":{"label":"twalpole:ssl","ref":"ssl","sha":"2ab17d7e6586b9661bdfc0983c46895f5ba2d3f1","user":{"login":"twalpole","id":16556,"avatar_url":"https://avatars.githubusercontent.com/u/16556?v=3","gravatar_id":"","url":"https://api.github.com/users/twalpole","html_url":"https://github.com/twalpole","followers_url":"https://api.github.com/users/twalpole/followers","following_url":"https://api.github.com/users/twalpole/following{/other_user}","gists_url":"https://api.github.com/users/twalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/twalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalpole/subscriptions","organizations_url":"https://api.github.com/users/twalpole/orgs","repos_url":"https://api.github.com/users/twalpole/repos","events_url":"https://api.github.com/users/twalpole/events{/privacy}","received_events_url":"https://api.github.com/users/twalpole/received_events","type":"User","site_admin":false},"repo":{"id":42402330,"name":"poltergeist","full_name":"twalpole/poltergeist","owner":{"login":"twalpole","id":16556,"avatar_url":"https://avatars.githubusercontent.com/u/16556?v=3","gravatar_id":"","url":"https://api.github.com/users/twalpole","html_url":"https://github.com/twalpole","followers_url":"https://api.github.com/users/twalpole/followers","following_url":"https://api.github.com/users/twalpole/following{/other_user}","gists_url":"https://api.github.com/users/twalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/twalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalpole/subscriptions","organizations_url":"https://api.github.com/users/twalpole/orgs","repos_url":"https://api.github.com/users/twalpole/repos","events_url":"https://api.github.com/users/twalpole/events{/privacy}","received_events_url":"https://api.github.com/users/twalpole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twalpole/poltergeist","description":"A PhantomJS driver for Capybara","fork":true,"url":"https://api.github.com/repos/twalpole/poltergeist","forks_url":"https://api.github.com/repos/twalpole/poltergeist/forks","keys_url":"https://api.github.com/repos/twalpole/poltergeist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twalpole/poltergeist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twalpole/poltergeist/teams","hooks_url":"https://api.github.com/repos/twalpole/poltergeist/hooks","issue_events_url":"https://api.github.com/repos/twalpole/poltergeist/issues/events{/number}","events_url":"https://api.github.com/repos/twalpole/poltergeist/events","assignees_url":"https://api.github.com/repos/twalpole/poltergeist/assignees{/user}","branches_url":"https://api.github.com/repos/twalpole/poltergeist/branches{/branch}","tags_url":"https://api.github.com/repos/twalpole/poltergeist/tags","blobs_url":"https://api.github.com/repos/twalpole/poltergeist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twalpole/poltergeist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twalpole/poltergeist/git/refs{/sha}","trees_url":"https://api.github.com/repos/twalpole/poltergeist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twalpole/poltergeist/statuses/{sha}","languages_url":"https://api.github.com/repos/twalpole/poltergeist/languages","stargazers_url":"https://api.github.com/repos/twalpole/poltergeist/stargazers","contributors_url":"https://api.github.com/repos/twalpole/poltergeist/contributors","subscribers_url":"https://api.github.com/repos/twalpole/poltergeist/subscribers","subscription_url":"https://api.github.com/repos/twalpole/poltergeist/subscription","commits_url":"https://api.github.com/repos/twalpole/poltergeist/commits{/sha}","git_commits_url":"https://api.github.com/repos/twalpole/poltergeist/git/commits{/sha}","comments_url":"https://api.github.com/repos/twalpole/poltergeist/comments{/number}","issue_comment_url":"https://api.github.com/repos/twalpole/poltergeist/issues/comments{/number}","contents_url":"https://api.github.com/repos/twalpole/poltergeist/contents/{+path}","compare_url":"https://api.github.com/repos/twalpole/poltergeist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twalpole/poltergeist/merges","archive_url":"https://api.github.com/repos/twalpole/poltergeist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twalpole/poltergeist/downloads","issues_url":"https://api.github.com/repos/twalpole/poltergeist/issues{/number}","pulls_url":"https://api.github.com/repos/twalpole/poltergeist/pulls{/number}","milestones_url":"https://api.github.com/repos/twalpole/poltergeist/milestones{/number}","notifications_url":"https://api.github.com/repos/twalpole/poltergeist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twalpole/poltergeist/labels{/name}","releases_url":"https://api.github.com/repos/twalpole/poltergeist/releases{/id}","created_at":"2015-09-13T16:00:13Z","updated_at":"2015-09-13T16:00:13Z","pushed_at":"2015-11-26T19:52:40Z","git_url":"git://github.com/twalpole/poltergeist.git","ssh_url":"git@github.com:twalpole/poltergeist.git","clone_url":"https://github.com/twalpole/poltergeist.git","svn_url":"https://github.com/twalpole/poltergeist","homepage":"","size":1741,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"teampoltergeist:master","ref":"master","sha":"0605547bb16544a787bcdcfc293b24b8e642c297","user":{"login":"teampoltergeist","id":7149329,"avatar_url":"https://avatars.githubusercontent.com/u/7149329?v=3","gravatar_id":"","url":"https://api.github.com/users/teampoltergeist","html_url":"https://github.com/teampoltergeist","followers_url":"https://api.github.com/users/teampoltergeist/followers","following_url":"https://api.github.com/users/teampoltergeist/following{/other_user}","gists_url":"https://api.github.com/users/teampoltergeist/gists{/gist_id}","starred_url":"https://api.github.com/users/teampoltergeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teampoltergeist/subscriptions","organizations_url":"https://api.github.com/users/teampoltergeist/orgs","repos_url":"https://api.github.com/users/teampoltergeist/repos","events_url":"https://api.github.com/users/teampoltergeist/events{/privacy}","received_events_url":"https://api.github.com/users/teampoltergeist/received_events","type":"Organization","site_admin":false},"repo":{"id":2661753,"name":"poltergeist","full_name":"teampoltergeist/poltergeist","owner":{"login":"teampoltergeist","id":7149329,"avatar_url":"https://avatars.githubusercontent.com/u/7149329?v=3","gravatar_id":"","url":"https://api.github.com/users/teampoltergeist","html_url":"https://github.com/teampoltergeist","followers_url":"https://api.github.com/users/teampoltergeist/followers","following_url":"https://api.github.com/users/teampoltergeist/following{/other_user}","gists_url":"https://api.github.com/users/teampoltergeist/gists{/gist_id}","starred_url":"https://api.github.com/users/teampoltergeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teampoltergeist/subscriptions","organizations_url":"https://api.github.com/users/teampoltergeist/orgs","repos_url":"https://api.github.com/users/teampoltergeist/repos","events_url":"https://api.github.com/users/teampoltergeist/events{/privacy}","received_events_url":"https://api.github.com/users/teampoltergeist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teampoltergeist/poltergeist","description":"A PhantomJS driver for Capybara","fork":false,"url":"https://api.github.com/repos/teampoltergeist/poltergeist","forks_url":"https://api.github.com/repos/teampoltergeist/poltergeist/forks","keys_url":"https://api.github.com/repos/teampoltergeist/poltergeist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teampoltergeist/poltergeist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teampoltergeist/poltergeist/teams","hooks_url":"https://api.github.com/repos/teampoltergeist/poltergeist/hooks","issue_events_url":"https://api.github.com/repos/teampoltergeist/poltergeist/issues/events{/number}","events_url":"https://api.github.com/repos/teampoltergeist/poltergeist/events","assignees_url":"https://api.github.com/repos/teampoltergeist/poltergeist/assignees{/user}","branches_url":"https://api.github.com/repos/teampoltergeist/poltergeist/branches{/branch}","tags_url":"https://api.github.com/repos/teampoltergeist/poltergeist/tags","blobs_url":"https://api.github.com/repos/teampoltergeist/poltergeist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teampoltergeist/poltergeist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teampoltergeist/poltergeist/git/refs{/sha}","trees_url":"https://api.github.com/repos/teampoltergeist/poltergeist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teampoltergeist/poltergeist/statuses/{sha}","languages_url":"https://api.github.com/repos/teampoltergeist/poltergeist/languages","stargazers_url":"https://api.github.com/repos/teampoltergeist/poltergeist/stargazers","contributors_url":"https://api.github.com/repos/teampoltergeist/poltergeist/contributors","subscribers_url":"https://api.github.com/repos/teampoltergeist/poltergeist/subscribers","subscription_url":"https://api.github.com/repos/teampoltergeist/poltergeist/subscription","commits_url":"https://api.github.com/repos/teampoltergeist/poltergeist/commits{/sha}","git_commits_url":"https://api.github.com/repos/teampoltergeist/poltergeist/git/commits{/sha}","comments_url":"https://api.github.com/repos/teampoltergeist/poltergeist/comments{/number}","issue_comment_url":"https://api.github.com/repos/teampoltergeist/poltergeist/issues/comments{/number}","contents_url":"https://api.github.com/repos/teampoltergeist/poltergeist/contents/{+path}","compare_url":"https://api.github.com/repos/teampoltergeist/poltergeist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teampoltergeist/poltergeist/merges","archive_url":"https://api.github.com/repos/teampoltergeist/poltergeist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teampoltergeist/poltergeist/downloads","issues_url":"https://api.github.com/repos/teampoltergeist/poltergeist/issues{/number}","pulls_url":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls{/number}","milestones_url":"https://api.github.com/repos/teampoltergeist/poltergeist/milestones{/number}","notifications_url":"https://api.github.com/repos/teampoltergeist/poltergeist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teampoltergeist/poltergeist/labels{/name}","releases_url":"https://api.github.com/repos/teampoltergeist/poltergeist/releases{/id}","created_at":"2011-10-27T22:36:00Z","updated_at":"2015-11-26T18:53:27Z","pushed_at":"2015-11-26T19:52:41Z","git_url":"git://github.com/teampoltergeist/poltergeist.git","ssh_url":"git@github.com:teampoltergeist/poltergeist.git","clone_url":"https://github.com/teampoltergeist/poltergeist.git","svn_url":"https://github.com/teampoltergeist/poltergeist","homepage":"","size":2583,"stargazers_count":1958,"watchers_count":1958,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":30,"forks":363,"open_issues":30,"watchers":1958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694"},"html":{"href":"https://github.com/teampoltergeist/poltergeist/pull/694"},"issue":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/issues/694"},"comments":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/teampoltergeist/poltergeist/statuses/2ab17d7e6586b9661bdfc0983c46895f5ba2d3f1"}}}}