{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/gabime/spdlog/pulls/33","id":27386111,"html_url":"https://github.com/gabime/spdlog/pull/33","diff_url":"https://github.com/gabime/spdlog/pull/33.diff","patch_url":"https://github.com/gabime/spdlog/pull/33.patch","issue_url":"https://api.github.com/repos/gabime/spdlog/issues/33","number":33,"state":"closed","locked":false,"title":"discard policies on queue overflow","user":{"login":"divaykin","id":331169,"avatar_url":"https://avatars.githubusercontent.com/u/331169?v=3","gravatar_id":"","url":"https://api.github.com/users/divaykin","html_url":"https://github.com/divaykin","followers_url":"https://api.github.com/users/divaykin/followers","following_url":"https://api.github.com/users/divaykin/following{/other_user}","gists_url":"https://api.github.com/users/divaykin/gists{/gist_id}","starred_url":"https://api.github.com/users/divaykin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divaykin/subscriptions","organizations_url":"https://api.github.com/users/divaykin/orgs","repos_url":"https://api.github.com/users/divaykin/repos","events_url":"https://api.github.com/users/divaykin/events{/privacy}","received_events_url":"https://api.github.com/users/divaykin/received_events","type":"User","site_admin":false},"body":"for me it's much better to lose few lines of log vs stopping the processing thread due to buffer overflow.\r\nmaybe set_async_mode is somewhat over complicated now, feel free to suggest better design.\r\n\r\nthx a lot","created_at":"2015-01-14T21:43:46Z","updated_at":"2015-01-15T08:01:17Z","closed_at":"2015-01-15T08:01:17Z","merged_at":"2015-01-15T08:01:17Z","merge_commit_sha":"b90f16fae16db8dc71bb3000bb9d781e3a52205f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gabime/spdlog/pulls/33/commits","review_comments_url":"https://api.github.com/repos/gabime/spdlog/pulls/33/comments","review_comment_url":"https://api.github.com/repos/gabime/spdlog/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gabime/spdlog/issues/33/comments","statuses_url":"https://api.github.com/repos/gabime/spdlog/statuses/295e189b7eec0ffd53486d1560a9e0dc788e9795","head":{"label":"divaykin:master","ref":"master","sha":"295e189b7eec0ffd53486d1560a9e0dc788e9795","user":{"login":"divaykin","id":331169,"avatar_url":"https://avatars.githubusercontent.com/u/331169?v=3","gravatar_id":"","url":"https://api.github.com/users/divaykin","html_url":"https://github.com/divaykin","followers_url":"https://api.github.com/users/divaykin/followers","following_url":"https://api.github.com/users/divaykin/following{/other_user}","gists_url":"https://api.github.com/users/divaykin/gists{/gist_id}","starred_url":"https://api.github.com/users/divaykin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divaykin/subscriptions","organizations_url":"https://api.github.com/users/divaykin/orgs","repos_url":"https://api.github.com/users/divaykin/repos","events_url":"https://api.github.com/users/divaykin/events{/privacy}","received_events_url":"https://api.github.com/users/divaykin/received_events","type":"User","site_admin":false},"repo":{"id":29241197,"name":"spdlog","full_name":"divaykin/spdlog","owner":{"login":"divaykin","id":331169,"avatar_url":"https://avatars.githubusercontent.com/u/331169?v=3","gravatar_id":"","url":"https://api.github.com/users/divaykin","html_url":"https://github.com/divaykin","followers_url":"https://api.github.com/users/divaykin/followers","following_url":"https://api.github.com/users/divaykin/following{/other_user}","gists_url":"https://api.github.com/users/divaykin/gists{/gist_id}","starred_url":"https://api.github.com/users/divaykin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divaykin/subscriptions","organizations_url":"https://api.github.com/users/divaykin/orgs","repos_url":"https://api.github.com/users/divaykin/repos","events_url":"https://api.github.com/users/divaykin/events{/privacy}","received_events_url":"https://api.github.com/users/divaykin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divaykin/spdlog","description":"Super fast C++ logging library.","fork":true,"url":"https://api.github.com/repos/divaykin/spdlog","forks_url":"https://api.github.com/repos/divaykin/spdlog/forks","keys_url":"https://api.github.com/repos/divaykin/spdlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divaykin/spdlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divaykin/spdlog/teams","hooks_url":"https://api.github.com/repos/divaykin/spdlog/hooks","issue_events_url":"https://api.github.com/repos/divaykin/spdlog/issues/events{/number}","events_url":"https://api.github.com/repos/divaykin/spdlog/events","assignees_url":"https://api.github.com/repos/divaykin/spdlog/assignees{/user}","branches_url":"https://api.github.com/repos/divaykin/spdlog/branches{/branch}","tags_url":"https://api.github.com/repos/divaykin/spdlog/tags","blobs_url":"https://api.github.com/repos/divaykin/spdlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divaykin/spdlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divaykin/spdlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/divaykin/spdlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divaykin/spdlog/statuses/{sha}","languages_url":"https://api.github.com/repos/divaykin/spdlog/languages","stargazers_url":"https://api.github.com/repos/divaykin/spdlog/stargazers","contributors_url":"https://api.github.com/repos/divaykin/spdlog/contributors","subscribers_url":"https://api.github.com/repos/divaykin/spdlog/subscribers","subscription_url":"https://api.github.com/repos/divaykin/spdlog/subscription","commits_url":"https://api.github.com/repos/divaykin/spdlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/divaykin/spdlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/divaykin/spdlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/divaykin/spdlog/issues/comments/{number}","contents_url":"https://api.github.com/repos/divaykin/spdlog/contents/{+path}","compare_url":"https://api.github.com/repos/divaykin/spdlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divaykin/spdlog/merges","archive_url":"https://api.github.com/repos/divaykin/spdlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divaykin/spdlog/downloads","issues_url":"https://api.github.com/repos/divaykin/spdlog/issues{/number}","pulls_url":"https://api.github.com/repos/divaykin/spdlog/pulls{/number}","milestones_url":"https://api.github.com/repos/divaykin/spdlog/milestones{/number}","notifications_url":"https://api.github.com/repos/divaykin/spdlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divaykin/spdlog/labels{/name}","releases_url":"https://api.github.com/repos/divaykin/spdlog/releases{/id}","created_at":"2015-01-14T11:29:19Z","updated_at":"2015-01-14T21:39:16Z","pushed_at":"2015-01-14T21:39:15Z","git_url":"git://github.com/divaykin/spdlog.git","ssh_url":"git@github.com:divaykin/spdlog.git","clone_url":"https://github.com/divaykin/spdlog.git","svn_url":"https://github.com/divaykin/spdlog","homepage":"","size":3046,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gabime:master","ref":"master","sha":"5b1115392e1d0f6647ef55fff63ddbe2322671ba","user":{"login":"gabime","id":6052198,"avatar_url":"https://avatars.githubusercontent.com/u/6052198?v=3","gravatar_id":"","url":"https://api.github.com/users/gabime","html_url":"https://github.com/gabime","followers_url":"https://api.github.com/users/gabime/followers","following_url":"https://api.github.com/users/gabime/following{/other_user}","gists_url":"https://api.github.com/users/gabime/gists{/gist_id}","starred_url":"https://api.github.com/users/gabime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabime/subscriptions","organizations_url":"https://api.github.com/users/gabime/orgs","repos_url":"https://api.github.com/users/gabime/repos","events_url":"https://api.github.com/users/gabime/events{/privacy}","received_events_url":"https://api.github.com/users/gabime/received_events","type":"User","site_admin":false},"repo":{"id":26038648,"name":"spdlog","full_name":"gabime/spdlog","owner":{"login":"gabime","id":6052198,"avatar_url":"https://avatars.githubusercontent.com/u/6052198?v=3","gravatar_id":"","url":"https://api.github.com/users/gabime","html_url":"https://github.com/gabime","followers_url":"https://api.github.com/users/gabime/followers","following_url":"https://api.github.com/users/gabime/following{/other_user}","gists_url":"https://api.github.com/users/gabime/gists{/gist_id}","starred_url":"https://api.github.com/users/gabime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabime/subscriptions","organizations_url":"https://api.github.com/users/gabime/orgs","repos_url":"https://api.github.com/users/gabime/repos","events_url":"https://api.github.com/users/gabime/events{/privacy}","received_events_url":"https://api.github.com/users/gabime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabime/spdlog","description":"Super fast C++ logging library.","fork":false,"url":"https://api.github.com/repos/gabime/spdlog","forks_url":"https://api.github.com/repos/gabime/spdlog/forks","keys_url":"https://api.github.com/repos/gabime/spdlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabime/spdlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabime/spdlog/teams","hooks_url":"https://api.github.com/repos/gabime/spdlog/hooks","issue_events_url":"https://api.github.com/repos/gabime/spdlog/issues/events{/number}","events_url":"https://api.github.com/repos/gabime/spdlog/events","assignees_url":"https://api.github.com/repos/gabime/spdlog/assignees{/user}","branches_url":"https://api.github.com/repos/gabime/spdlog/branches{/branch}","tags_url":"https://api.github.com/repos/gabime/spdlog/tags","blobs_url":"https://api.github.com/repos/gabime/spdlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabime/spdlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabime/spdlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabime/spdlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabime/spdlog/statuses/{sha}","languages_url":"https://api.github.com/repos/gabime/spdlog/languages","stargazers_url":"https://api.github.com/repos/gabime/spdlog/stargazers","contributors_url":"https://api.github.com/repos/gabime/spdlog/contributors","subscribers_url":"https://api.github.com/repos/gabime/spdlog/subscribers","subscription_url":"https://api.github.com/repos/gabime/spdlog/subscription","commits_url":"https://api.github.com/repos/gabime/spdlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabime/spdlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabime/spdlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabime/spdlog/issues/comments/{number}","contents_url":"https://api.github.com/repos/gabime/spdlog/contents/{+path}","compare_url":"https://api.github.com/repos/gabime/spdlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabime/spdlog/merges","archive_url":"https://api.github.com/repos/gabime/spdlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabime/spdlog/downloads","issues_url":"https://api.github.com/repos/gabime/spdlog/issues{/number}","pulls_url":"https://api.github.com/repos/gabime/spdlog/pulls{/number}","milestones_url":"https://api.github.com/repos/gabime/spdlog/milestones{/number}","notifications_url":"https://api.github.com/repos/gabime/spdlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabime/spdlog/labels{/name}","releases_url":"https://api.github.com/repos/gabime/spdlog/releases{/id}","created_at":"2014-11-01T01:28:53Z","updated_at":"2015-01-14T16:29:57Z","pushed_at":"2015-01-15T08:01:17Z","git_url":"git://github.com/gabime/spdlog.git","ssh_url":"git@github.com:gabime/spdlog.git","clone_url":"https://github.com/gabime/spdlog.git","svn_url":"https://github.com/gabime/spdlog","homepage":"","size":3046,"stargazers_count":258,"watchers_count":258,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":0,"forks":42,"open_issues":0,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gabime/spdlog/pulls/33"},"html":{"href":"https://github.com/gabime/spdlog/pull/33"},"issue":{"href":"https://api.github.com/repos/gabime/spdlog/issues/33"},"comments":{"href":"https://api.github.com/repos/gabime/spdlog/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/gabime/spdlog/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/gabime/spdlog/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gabime/spdlog/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/gabime/spdlog/statuses/295e189b7eec0ffd53486d1560a9e0dc788e9795"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gabime","id":6052198,"avatar_url":"https://avatars.githubusercontent.com/u/6052198?v=3","gravatar_id":"","url":"https://api.github.com/users/gabime","html_url":"https://github.com/gabime","followers_url":"https://api.github.com/users/gabime/followers","following_url":"https://api.github.com/users/gabime/following{/other_user}","gists_url":"https://api.github.com/users/gabime/gists{/gist_id}","starred_url":"https://api.github.com/users/gabime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabime/subscriptions","organizations_url":"https://api.github.com/users/gabime/orgs","repos_url":"https://api.github.com/users/gabime/repos","events_url":"https://api.github.com/users/gabime/events{/privacy}","received_events_url":"https://api.github.com/users/gabime/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":30,"deletions":17,"changed_files":6}}