{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/6274","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6274/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6274/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6274/events","html_url":"https://github.com/mozilla/pdf.js/pull/6274","id":97496123,"number":6274,"title":"Enabling find functionality on small devices","user":{"login":"Thunderforge","id":6200170,"avatar_url":"https://avatars.githubusercontent.com/u/6200170?v=3","gravatar_id":"","url":"https://api.github.com/users/Thunderforge","html_url":"https://github.com/Thunderforge","followers_url":"https://api.github.com/users/Thunderforge/followers","following_url":"https://api.github.com/users/Thunderforge/following{/other_user}","gists_url":"https://api.github.com/users/Thunderforge/gists{/gist_id}","starred_url":"https://api.github.com/users/Thunderforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thunderforge/subscriptions","organizations_url":"https://api.github.com/users/Thunderforge/orgs","repos_url":"https://api.github.com/users/Thunderforge/repos","events_url":"https://api.github.com/users/Thunderforge/events{/privacy}","received_events_url":"https://api.github.com/users/Thunderforge/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-viewer","name":"1-viewer","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"milestone":null,"comments":21,"created_at":"2015-07-27T15:58:39Z","updated_at":"2015-09-10T21:34:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6274","html_url":"https://github.com/mozilla/pdf.js/pull/6274","diff_url":"https://github.com/mozilla/pdf.js/pull/6274.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6274.patch"},"body":"This is a work in progress fix to allow for find functionality when PDF.js is used on small devices, addressing #6191. No attempt was made to address the issues regarding foreign languages in #3683; this will likely be something that is done after find functionality is included on small devices.\r\n\r\nAt about 600px, find functionality is visible with some of the toolbar icons on the right side being moved to the overflow bar:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6200170/8910763/341b2478-344e-11e5-8bfa-54a594f584c0.png)\r\n\r\nWhen the window shrinks to 570px, all elements with the `hiddenSmallView` CSS class are invisible. This no longer includes the Find functionality, but does include the next and previous buttons, per the discussion on the UX team where they pointed out that finger scrolling was far more likely to be used than a tiny button. Also, the find toolbar becomes extra tall. This will need more work, as there is a lot of empty space:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6200170/8910684/c302ad92-344d-11e5-9191-2beb6d62661b.png)\r\n\r\nAs the window gets smaller, the find toolbar checkboxes move to fill in the new space. Again, there is a lot of wasted space and improvements could be made:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6200170/8910713/e825370c-344d-11e5-8640-010e64b48192.png)\r\n\r\nWhen the window reaches 440px, the page label and the zoom dropdown menus are removed entirely:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6200170/8910736/08eb0412-344e-11e5-8ed6-fcf40feadca7.png)\r\n\r\nI would appreciate feedback on these changes, and any suggestions to solve the issue with extra space on the find toolbar when it gets to double height."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/139385794","html_url":"https://github.com/mozilla/pdf.js/pull/6274#issuecomment-139385794","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6274","id":139385794,"user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T21:34:20Z","updated_at":"2015-09-10T21:34:20Z","body":"Even if this is now looking much better overall, there still appears to be an issue with the `findbar` becoming way too wide, using all the available window width, in some cases (Firefox 42 on Windows):\r\n\r\n![findbar-full-width](https://cloud.githubusercontent.com/assets/2692120/9801579/4846d354-5814-11e5-9dcb-6792f410a7b3.png)\r\n"}}