{"action":"closed","number":314,"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/314","id":42001136,"html_url":"https://github.com/gammapy/gammapy/pull/314","diff_url":"https://github.com/gammapy/gammapy/pull/314.diff","patch_url":"https://github.com/gammapy/gammapy/pull/314.patch","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/314","number":314,"state":"closed","locked":false,"title":"Improve Makefile","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"body":"I want to improve the Gammapy [Makefile](https://github.com/gammapy/gammapy/blob/master/Makefile).\r\n\r\n- [x] Some things don't work on Mac:\r\n```\r\n$ make cython\r\nfind -name \"*.pyx\" -exec  {} \\;\r\nfind: illegal option -- n\r\nusage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]\r\n       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]\r\nmake: *** [cython] Error 1\r\n```\r\n- [x] Go through suggestions at https://github.com/gammapy/gammapy/pull/289#issuecomment-111856391\r\n- [x] Go through suggestions at https://github.com/gammapy/gammapy/pull/289#issuecomment-123653090\r\n\r\nI'll improve the developer docs to mention the Makefile in #312 .","created_at":"2015-08-10T09:23:26Z","updated_at":"2015-08-10T10:46:53Z","closed_at":"2015-08-10T10:46:52Z","merged_at":"2015-08-10T10:46:52Z","merge_commit_sha":"ed87f1c15d1f77794000ada52d7fe7bdd54da5ca","assignee":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/2","html_url":"https://github.com/gammapy/gammapy/milestones/0.3","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/2/labels","id":377787,"number":2,"title":"0.3","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":41,"state":"open","created_at":"2013-07-14T16:38:18Z","updated_at":"2015-08-10T10:46:53Z","due_on":"2015-08-10T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gammapy/gammapy/pulls/314/commits","review_comments_url":"https://api.github.com/repos/gammapy/gammapy/pulls/314/comments","review_comment_url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/314/comments","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/022e92a7fe8105a42c1212af979171dda89eb413","head":{"label":"cdeil:issue-314","ref":"issue-314","sha":"022e92a7fe8105a42c1212af979171dda89eb413","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"repo":{"id":12226099,"name":"gammapy","full_name":"cdeil/gammapy","owner":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdeil/gammapy","description":"Gamma-ray astronomy high-level data analysis Python package","fork":true,"url":"https://api.github.com/repos/cdeil/gammapy","forks_url":"https://api.github.com/repos/cdeil/gammapy/forks","keys_url":"https://api.github.com/repos/cdeil/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdeil/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdeil/gammapy/teams","hooks_url":"https://api.github.com/repos/cdeil/gammapy/hooks","issue_events_url":"https://api.github.com/repos/cdeil/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/cdeil/gammapy/events","assignees_url":"https://api.github.com/repos/cdeil/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/cdeil/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/cdeil/gammapy/tags","blobs_url":"https://api.github.com/repos/cdeil/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdeil/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdeil/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdeil/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdeil/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/cdeil/gammapy/languages","stargazers_url":"https://api.github.com/repos/cdeil/gammapy/stargazers","contributors_url":"https://api.github.com/repos/cdeil/gammapy/contributors","subscribers_url":"https://api.github.com/repos/cdeil/gammapy/subscribers","subscription_url":"https://api.github.com/repos/cdeil/gammapy/subscription","commits_url":"https://api.github.com/repos/cdeil/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdeil/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdeil/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdeil/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdeil/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/cdeil/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdeil/gammapy/merges","archive_url":"https://api.github.com/repos/cdeil/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdeil/gammapy/downloads","issues_url":"https://api.github.com/repos/cdeil/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/cdeil/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/cdeil/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/cdeil/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdeil/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/cdeil/gammapy/releases{/id}","created_at":"2013-08-19T19:51:36Z","updated_at":"2015-07-02T09:58:57Z","pushed_at":"2015-08-10T10:42:07Z","git_url":"git://github.com/cdeil/gammapy.git","ssh_url":"git@github.com:cdeil/gammapy.git","clone_url":"https://github.com/cdeil/gammapy.git","svn_url":"https://github.com/cdeil/gammapy","homepage":"https://gammapy.readthedocs.org/","size":4232,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gammapy:master","ref":"master","sha":"d2705635b3614816172b658898c9fcdfbdb0c56c","user":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"repo":{"id":10073640,"name":"gammapy","full_name":"gammapy/gammapy","owner":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gammapy/gammapy","description":"A Python package for gamma-ray astronomy","fork":false,"url":"https://api.github.com/repos/gammapy/gammapy","forks_url":"https://api.github.com/repos/gammapy/gammapy/forks","keys_url":"https://api.github.com/repos/gammapy/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gammapy/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gammapy/gammapy/teams","hooks_url":"https://api.github.com/repos/gammapy/gammapy/hooks","issue_events_url":"https://api.github.com/repos/gammapy/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/gammapy/gammapy/events","assignees_url":"https://api.github.com/repos/gammapy/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/gammapy/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/gammapy/gammapy/tags","blobs_url":"https://api.github.com/repos/gammapy/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gammapy/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gammapy/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gammapy/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gammapy/gammapy/languages","stargazers_url":"https://api.github.com/repos/gammapy/gammapy/stargazers","contributors_url":"https://api.github.com/repos/gammapy/gammapy/contributors","subscribers_url":"https://api.github.com/repos/gammapy/gammapy/subscribers","subscription_url":"https://api.github.com/repos/gammapy/gammapy/subscription","commits_url":"https://api.github.com/repos/gammapy/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gammapy/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gammapy/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gammapy/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gammapy/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/gammapy/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gammapy/gammapy/merges","archive_url":"https://api.github.com/repos/gammapy/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gammapy/gammapy/downloads","issues_url":"https://api.github.com/repos/gammapy/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/gammapy/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gammapy/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gammapy/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gammapy/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/gammapy/gammapy/releases{/id}","created_at":"2013-05-15T07:50:40Z","updated_at":"2015-06-06T13:39:51Z","pushed_at":"2015-08-10T10:46:52Z","git_url":"git://github.com/gammapy/gammapy.git","ssh_url":"git@github.com:gammapy/gammapy.git","clone_url":"https://github.com/gammapy/gammapy.git","svn_url":"https://github.com/gammapy/gammapy","homepage":"https://gammapy.readthedocs.org/","size":5976,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":106,"forks":21,"open_issues":106,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/314"},"html":{"href":"https://github.com/gammapy/gammapy/pull/314"},"issue":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/314"},"comments":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/gammapy/gammapy/statuses/022e92a7fe8105a42c1212af979171dda89eb413"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":151,"deletions":124,"changed_files":45}}