{"action":"created","issue":{"url":"https://api.github.com/repos/menpo/menpofit/issues/69","labels_url":"https://api.github.com/repos/menpo/menpofit/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/menpo/menpofit/issues/69/comments","events_url":"https://api.github.com/repos/menpo/menpofit/issues/69/events","html_url":"https://github.com/menpo/menpofit/issues/69","id":102397212,"number":69,"title":"noisy_shape_from_shape rotation parameter","user":{"login":"patricksnape","id":708474,"avatar_url":"https://avatars.githubusercontent.com/u/708474?v=3","gravatar_id":"","url":"https://api.github.com/users/patricksnape","html_url":"https://github.com/patricksnape","followers_url":"https://api.github.com/users/patricksnape/followers","following_url":"https://api.github.com/users/patricksnape/following{/other_user}","gists_url":"https://api.github.com/users/patricksnape/gists{/gist_id}","starred_url":"https://api.github.com/users/patricksnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricksnape/subscriptions","organizations_url":"https://api.github.com/users/patricksnape/orgs","repos_url":"https://api.github.com/users/patricksnape/repos","events_url":"https://api.github.com/users/patricksnape/events{/privacy}","received_events_url":"https://api.github.com/users/patricksnape/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-21T14:54:12Z","updated_at":"2015-08-21T15:34:21Z","closed_at":null,"body":"Is the `rotation` parameter of `noisy_shape_from_shape` correct? At the moment it controls if the initial `AlignmentSimilarity` accounts for rotation or not. Then, it will generate an initial shape that **does perturb the rotation**. I feel like the `rotation` parameter should control whether or not the noisy shape contains rotation or not. This seems to be what is commonly done in the face alignment literature - only generate perturbations that contain scale and translation variation.\r\n\r\n@jalabort thoughts?"},"comment":{"url":"https://api.github.com/repos/menpo/menpofit/issues/comments/133464462","html_url":"https://github.com/menpo/menpofit/issues/69#issuecomment-133464462","issue_url":"https://api.github.com/repos/menpo/menpofit/issues/69","id":133464462,"user":{"login":"jalabort","id":2472200,"avatar_url":"https://avatars.githubusercontent.com/u/2472200?v=3","gravatar_id":"","url":"https://api.github.com/users/jalabort","html_url":"https://github.com/jalabort","followers_url":"https://api.github.com/users/jalabort/followers","following_url":"https://api.github.com/users/jalabort/following{/other_user}","gists_url":"https://api.github.com/users/jalabort/gists{/gist_id}","starred_url":"https://api.github.com/users/jalabort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalabort/subscriptions","organizations_url":"https://api.github.com/users/jalabort/orgs","repos_url":"https://api.github.com/users/jalabort/repos","events_url":"https://api.github.com/users/jalabort/events{/privacy}","received_events_url":"https://api.github.com/users/jalabort/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T15:34:21Z","updated_at":"2015-08-21T15:34:21Z","body":"Renaming to `allow_alignment_rotation` sounds good to me. Regarding your question, in SDM training aligning without rotation and generating rotation perturbations makes sure you adapt to the kind of rotations present in your training dataset while allowing also to adapt to arbitrary rotations that are not naturally present. I'm on really fine grain here... but in theory this gives you more freedom regarding what exactly you want to learn..."}}