{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/36362026","id":36362026,"diff_hunk":"@@ -0,0 +1,133 @@\n+package jwt\n+\n+import (\n+\t\"fmt\"\n+\t\"time\"\n+\t\"encoding/json\"\n+\n+\t\"github.com/hashicorp/vault/helper/uuid\"\n+\t\"github.com/hashicorp/vault/logical\"\n+\t\"github.com/hashicorp/vault/logical/framework\"\n+)\n+\n+func pathIssue(b *backend) *framework.Path {\n+\treturn &framework.Path{\n+\t\tPattern: `issue/(?P<role>\\w[\\w-]+\\w)`,\n+\t\tFields: map[string]*framework.FieldSchema{\n+\t\t\t\"role\": &framework.FieldSchema{\n+\t\t\t\tType: framework.TypeString,\n+\t\t\t\tDescription: \"The desired role with configuration for this request\",\n+\t\t\t},\n+\t\t\t\"iss\": &framework.FieldSchema{","path":"builtin/logical/jwt/path_issue.go","position":21,"original_position":21,"commit_id":"f0ab3c1ff4dbf29462512c97e3548ed77d2336c0","original_commit_id":"f0ab3c1ff4dbf29462512c97e3548ed77d2336c0","user":{"login":"armon","id":592032,"avatar_url":"https://avatars.githubusercontent.com/u/592032?v=3","gravatar_id":"","url":"https://api.github.com/users/armon","html_url":"https://github.com/armon","followers_url":"https://api.github.com/users/armon/followers","following_url":"https://api.github.com/users/armon/following{/other_user}","gists_url":"https://api.github.com/users/armon/gists{/gist_id}","starred_url":"https://api.github.com/users/armon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armon/subscriptions","organizations_url":"https://api.github.com/users/armon/orgs","repos_url":"https://api.github.com/users/armon/repos","events_url":"https://api.github.com/users/armon/events{/privacy}","received_events_url":"https://api.github.com/users/armon/received_events","type":"User","site_admin":false},"body":"We should be explicit with these fields. \"iss\" should be \"issuer\", \"sub\" should be \"subject\" etc. I'd prefer clarity over saving a few bytes.","created_at":"2015-08-05T22:23:10Z","updated_at":"2015-08-05T22:23:10Z","html_url":"https://github.com/hashicorp/vault/pull/460#discussion_r36362026","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/36362026"},"html":{"href":"https://github.com/hashicorp/vault/pull/460#discussion_r36362026"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/460","id":41030362,"html_url":"https://github.com/hashicorp/vault/pull/460","diff_url":"https://github.com/hashicorp/vault/pull/460.diff","patch_url":"https://github.com/hashicorp/vault/pull/460.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/460","number":460,"state":"open","locked":false,"title":"Initial pass at JWT secret backend","user":{"login":"ekristen","id":48329,"avatar_url":"https://avatars.githubusercontent.com/u/48329?v=3","gravatar_id":"","url":"https://api.github.com/users/ekristen","html_url":"https://github.com/ekristen","followers_url":"https://api.github.com/users/ekristen/followers","following_url":"https://api.github.com/users/ekristen/following{/other_user}","gists_url":"https://api.github.com/users/ekristen/gists{/gist_id}","starred_url":"https://api.github.com/users/ekristen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekristen/subscriptions","organizations_url":"https://api.github.com/users/ekristen/orgs","repos_url":"https://api.github.com/users/ekristen/repos","events_url":"https://api.github.com/users/ekristen/events{/privacy}","received_events_url":"https://api.github.com/users/ekristen/received_events","type":"User","site_admin":false},"body":"This implements the following: \r\n* JWT Secret Backend - you can create roles that implement different algorithms and configure them with secret shared keys or private keys depending on the algorithm. You then can issue tokens against a role, by providing various claims to the write method. The tokens are stored and are retrievable if you have the JIT ID after the fact.\r\n\r\n* Docker Build capabilities - I'm a huge user of docker, and borrowed a few concepts from the `docker-machine` project, and introduced the ability to build this project using docker, can build cross platform too.\r\n\r\nIf you have docker setup, then it is simply just running `bash scripts/build-docker.sh` and it will be built cross platform. To build just for OSX `bash scripts/build-docker.sh -os=\"darwin\" -arch=\"amd64\"`","created_at":"2015-07-28T16:17:09Z","updated_at":"2015-08-05T22:23:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d9408031f09d82c55cfb1fe593579ad0a3fad9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/460/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/460/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/460/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/f0ab3c1ff4dbf29462512c97e3548ed77d2336c0","head":{"label":"ekristen:jwt","ref":"jwt","sha":"f0ab3c1ff4dbf29462512c97e3548ed77d2336c0","user":{"login":"ekristen","id":48329,"avatar_url":"https://avatars.githubusercontent.com/u/48329?v=3","gravatar_id":"","url":"https://api.github.com/users/ekristen","html_url":"https://github.com/ekristen","followers_url":"https://api.github.com/users/ekristen/followers","following_url":"https://api.github.com/users/ekristen/following{/other_user}","gists_url":"https://api.github.com/users/ekristen/gists{/gist_id}","starred_url":"https://api.github.com/users/ekristen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekristen/subscriptions","organizations_url":"https://api.github.com/users/ekristen/orgs","repos_url":"https://api.github.com/users/ekristen/repos","events_url":"https://api.github.com/users/ekristen/events{/privacy}","received_events_url":"https://api.github.com/users/ekristen/received_events","type":"User","site_admin":false},"repo":{"id":39793878,"name":"vault","full_name":"ekristen/vault","owner":{"login":"ekristen","id":48329,"avatar_url":"https://avatars.githubusercontent.com/u/48329?v=3","gravatar_id":"","url":"https://api.github.com/users/ekristen","html_url":"https://github.com/ekristen","followers_url":"https://api.github.com/users/ekristen/followers","following_url":"https://api.github.com/users/ekristen/following{/other_user}","gists_url":"https://api.github.com/users/ekristen/gists{/gist_id}","starred_url":"https://api.github.com/users/ekristen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekristen/subscriptions","organizations_url":"https://api.github.com/users/ekristen/orgs","repos_url":"https://api.github.com/users/ekristen/repos","events_url":"https://api.github.com/users/ekristen/events{/privacy}","received_events_url":"https://api.github.com/users/ekristen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekristen/vault","description":"A tool for managing secrets.","fork":true,"url":"https://api.github.com/repos/ekristen/vault","forks_url":"https://api.github.com/repos/ekristen/vault/forks","keys_url":"https://api.github.com/repos/ekristen/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekristen/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekristen/vault/teams","hooks_url":"https://api.github.com/repos/ekristen/vault/hooks","issue_events_url":"https://api.github.com/repos/ekristen/vault/issues/events{/number}","events_url":"https://api.github.com/repos/ekristen/vault/events","assignees_url":"https://api.github.com/repos/ekristen/vault/assignees{/user}","branches_url":"https://api.github.com/repos/ekristen/vault/branches{/branch}","tags_url":"https://api.github.com/repos/ekristen/vault/tags","blobs_url":"https://api.github.com/repos/ekristen/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekristen/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekristen/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekristen/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekristen/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/ekristen/vault/languages","stargazers_url":"https://api.github.com/repos/ekristen/vault/stargazers","contributors_url":"https://api.github.com/repos/ekristen/vault/contributors","subscribers_url":"https://api.github.com/repos/ekristen/vault/subscribers","subscription_url":"https://api.github.com/repos/ekristen/vault/subscription","commits_url":"https://api.github.com/repos/ekristen/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekristen/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekristen/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekristen/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekristen/vault/contents/{+path}","compare_url":"https://api.github.com/repos/ekristen/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekristen/vault/merges","archive_url":"https://api.github.com/repos/ekristen/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekristen/vault/downloads","issues_url":"https://api.github.com/repos/ekristen/vault/issues{/number}","pulls_url":"https://api.github.com/repos/ekristen/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/ekristen/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/ekristen/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekristen/vault/labels{/name}","releases_url":"https://api.github.com/repos/ekristen/vault/releases{/id}","created_at":"2015-07-27T19:35:33Z","updated_at":"2015-07-27T19:35:35Z","pushed_at":"2015-08-05T15:48:08Z","git_url":"git://github.com/ekristen/vault.git","ssh_url":"git@github.com:ekristen/vault.git","clone_url":"https://github.com/ekristen/vault.git","svn_url":"https://github.com/ekristen/vault","homepage":"http://vaultproject.io","size":4678,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"49cdf87ab92365ef4cd4e137ef0f2193c76d3d03","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for managing secrets.","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","created_at":"2015-02-25T00:15:59Z","updated_at":"2015-08-05T19:49:39Z","pushed_at":"2015-08-05T21:52:44Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"http://vaultproject.io","size":8089,"stargazers_count":3024,"watchers_count":3024,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":98,"forks":174,"open_issues":98,"watchers":3024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/460"},"html":{"href":"https://github.com/hashicorp/vault/pull/460"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/460"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/f0ab3c1ff4dbf29462512c97e3548ed77d2336c0"}}}}