{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/15","id":29670737,"html_url":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn/pull/15","diff_url":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn/pull/15.diff","patch_url":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn/pull/15.patch","issue_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues/15","number":15,"state":"closed","locked":false,"title":"Some argument format aligning between iOS and WinRT","user":{"login":"obsoleted","id":666628,"avatar_url":"https://avatars.githubusercontent.com/u/666628?v=3","gravatar_id":"","url":"https://api.github.com/users/obsoleted","html_url":"https://github.com/obsoleted","followers_url":"https://api.github.com/users/obsoleted/followers","following_url":"https://api.github.com/users/obsoleted/following{/other_user}","gists_url":"https://api.github.com/users/obsoleted/gists{/gist_id}","starred_url":"https://api.github.com/users/obsoleted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsoleted/subscriptions","organizations_url":"https://api.github.com/users/obsoleted/orgs","repos_url":"https://api.github.com/users/obsoleted/repos","events_url":"https://api.github.com/users/obsoleted/events{/privacy}","received_events_url":"https://api.github.com/users/obsoleted/received_events","type":"User","site_admin":false},"body":"These changes result in the following:\r\n- When a received message contains a variant argument iOS now returns the variant signature as part of the argument list returns. This is what WinRT was doing. \r\n\r\n    A simple example of this would be the callback for a property get of type 'n'. All Property gets have a variant return type. So now for both iOS and WinRT the callback should result in an argument value like so (if the property value was 1):\r\n\r\n    ```javascript\r\n    ['n', 1]\r\n    ```\r\n  \r\n- WinRT now returns arrays for nested collections. Previously it was returning the a WinRT projected Vector which has some API parity with JS arrays but not completely. Since it would be better to be exactly the same, and we don't want to expose WinRT types to the app this change now looks at all the arguments (recursively if encountering nested collections) and converts them to arrays. iOS was already returning standard arrays.\r\n\r\n  Here is an example of what the return looks like now:\r\n    ```javasript\r\n    [\"a(qss)\", // Signature of variant type (this was a variant property get)\r\n        [ // Container for the array of structure elements\r\n          [0, \"Tuner\", \"Tuner\"], // structure element represented as array of 3 values with types q, s and s\r\n          [1, \"AV1\", \"AV 1\"],\r\n          [2, \"Component1\", \"Component 1\"],\r\n          [3, \"HDMI1\", \"HDMI 1\"],\r\n          [4, \"HDMI2\", \"HDMI 2\"],\r\n          [5, \"HDMI3\", \"HDMI 3\"]\r\n        ]\r\n    ]\r\n    ```\r\n\r\n@phongcao and @vjrantal: I'd like your take on the proxy changes.\r\n\r\nI've tested this change out with the chat app between iOS and Windows and it seems to work fine (no variants or arrays so didn't really matter. I also tested it with an updated tv sample app and that worked much better (feature party in the app). @phongcao I will test out the lighting sample tomorrow on both WinRT and iOS with these changes. I haven't yet tried the lighting sample on iOS (sorry) so there may be some new issues/differences found when I try that also. But I think this is still progress towards a fully consistent API surface.","created_at":"2015-02-20T03:25:07Z","updated_at":"2015-02-20T05:16:57Z","closed_at":"2015-02-20T05:16:57Z","merged_at":"2015-02-20T05:16:57Z","merge_commit_sha":"350313b0cc9a027330d93e4202a4eb0efbf98eac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/15/commits","review_comments_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/15/comments","review_comment_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues/15/comments","statuses_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/statuses/a893bc583db3b194fdd9d0ebb84126ade3e9baa4","head":{"label":"obsoleted:argalign","ref":"argalign","sha":"a893bc583db3b194fdd9d0ebb84126ade3e9baa4","user":{"login":"obsoleted","id":666628,"avatar_url":"https://avatars.githubusercontent.com/u/666628?v=3","gravatar_id":"","url":"https://api.github.com/users/obsoleted","html_url":"https://github.com/obsoleted","followers_url":"https://api.github.com/users/obsoleted/followers","following_url":"https://api.github.com/users/obsoleted/following{/other_user}","gists_url":"https://api.github.com/users/obsoleted/gists{/gist_id}","starred_url":"https://api.github.com/users/obsoleted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsoleted/subscriptions","organizations_url":"https://api.github.com/users/obsoleted/orgs","repos_url":"https://api.github.com/users/obsoleted/repos","events_url":"https://api.github.com/users/obsoleted/events{/privacy}","received_events_url":"https://api.github.com/users/obsoleted/received_events","type":"User","site_admin":false},"repo":{"id":30717391,"name":"cordova-plugin-alljoyn-1","full_name":"obsoleted/cordova-plugin-alljoyn-1","owner":{"login":"obsoleted","id":666628,"avatar_url":"https://avatars.githubusercontent.com/u/666628?v=3","gravatar_id":"","url":"https://api.github.com/users/obsoleted","html_url":"https://github.com/obsoleted","followers_url":"https://api.github.com/users/obsoleted/followers","following_url":"https://api.github.com/users/obsoleted/following{/other_user}","gists_url":"https://api.github.com/users/obsoleted/gists{/gist_id}","starred_url":"https://api.github.com/users/obsoleted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsoleted/subscriptions","organizations_url":"https://api.github.com/users/obsoleted/orgs","repos_url":"https://api.github.com/users/obsoleted/repos","events_url":"https://api.github.com/users/obsoleted/events{/privacy}","received_events_url":"https://api.github.com/users/obsoleted/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obsoleted/cordova-plugin-alljoyn-1","description":"Native Cross-Platform AllJoyn Thin Client Plugin For Cordova","fork":true,"url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1","forks_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/forks","keys_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/teams","hooks_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/hooks","issue_events_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/issues/events{/number}","events_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/events","assignees_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/assignees{/user}","branches_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/branches{/branch}","tags_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/tags","blobs_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/statuses/{sha}","languages_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/languages","stargazers_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/stargazers","contributors_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/contributors","subscribers_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/subscribers","subscription_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/subscription","commits_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/contents/{+path}","compare_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/merges","archive_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/downloads","issues_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/issues{/number}","pulls_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/pulls{/number}","milestones_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/milestones{/number}","notifications_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/labels{/name}","releases_url":"https://api.github.com/repos/obsoleted/cordova-plugin-alljoyn-1/releases{/id}","created_at":"2015-02-12T18:37:12Z","updated_at":"2015-02-19T22:27:20Z","pushed_at":"2015-02-20T02:38:56Z","git_url":"git://github.com/obsoleted/cordova-plugin-alljoyn-1.git","ssh_url":"git@github.com:obsoleted/cordova-plugin-alljoyn-1.git","clone_url":"https://github.com/obsoleted/cordova-plugin-alljoyn-1.git","svn_url":"https://github.com/obsoleted/cordova-plugin-alljoyn-1","homepage":null,"size":500,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AllJoyn-Cordova:master","ref":"master","sha":"ad27e1c7059ec2bb916279c620674b3fc0b4e1b5","user":{"login":"AllJoyn-Cordova","id":10944601,"avatar_url":"https://avatars.githubusercontent.com/u/10944601?v=3","gravatar_id":"","url":"https://api.github.com/users/AllJoyn-Cordova","html_url":"https://github.com/AllJoyn-Cordova","followers_url":"https://api.github.com/users/AllJoyn-Cordova/followers","following_url":"https://api.github.com/users/AllJoyn-Cordova/following{/other_user}","gists_url":"https://api.github.com/users/AllJoyn-Cordova/gists{/gist_id}","starred_url":"https://api.github.com/users/AllJoyn-Cordova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllJoyn-Cordova/subscriptions","organizations_url":"https://api.github.com/users/AllJoyn-Cordova/orgs","repos_url":"https://api.github.com/users/AllJoyn-Cordova/repos","events_url":"https://api.github.com/users/AllJoyn-Cordova/events{/privacy}","received_events_url":"https://api.github.com/users/AllJoyn-Cordova/received_events","type":"Organization","site_admin":false},"repo":{"id":30602504,"name":"cordova-plugin-alljoyn","full_name":"AllJoyn-Cordova/cordova-plugin-alljoyn","owner":{"login":"AllJoyn-Cordova","id":10944601,"avatar_url":"https://avatars.githubusercontent.com/u/10944601?v=3","gravatar_id":"","url":"https://api.github.com/users/AllJoyn-Cordova","html_url":"https://github.com/AllJoyn-Cordova","followers_url":"https://api.github.com/users/AllJoyn-Cordova/followers","following_url":"https://api.github.com/users/AllJoyn-Cordova/following{/other_user}","gists_url":"https://api.github.com/users/AllJoyn-Cordova/gists{/gist_id}","starred_url":"https://api.github.com/users/AllJoyn-Cordova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllJoyn-Cordova/subscriptions","organizations_url":"https://api.github.com/users/AllJoyn-Cordova/orgs","repos_url":"https://api.github.com/users/AllJoyn-Cordova/repos","events_url":"https://api.github.com/users/AllJoyn-Cordova/events{/privacy}","received_events_url":"https://api.github.com/users/AllJoyn-Cordova/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn","description":"Native Cross-Platform AllJoyn Thin Client Plugin For Cordova","fork":false,"url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn","forks_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/forks","keys_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/teams","hooks_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/hooks","issue_events_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues/events{/number}","events_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/events","assignees_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/assignees{/user}","branches_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/branches{/branch}","tags_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/tags","blobs_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/statuses/{sha}","languages_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/languages","stargazers_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/stargazers","contributors_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/contributors","subscribers_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/subscribers","subscription_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/subscription","commits_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/contents/{+path}","compare_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/merges","archive_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/downloads","issues_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues{/number}","pulls_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls{/number}","milestones_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/milestones{/number}","notifications_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/labels{/name}","releases_url":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/releases{/id}","created_at":"2015-02-10T16:49:09Z","updated_at":"2015-02-19T19:37:49Z","pushed_at":"2015-02-20T05:16:57Z","git_url":"git://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn.git","ssh_url":"git@github.com:AllJoyn-Cordova/cordova-plugin-alljoyn.git","clone_url":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn.git","svn_url":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn","homepage":null,"size":81297,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/15"},"html":{"href":"https://github.com/AllJoyn-Cordova/cordova-plugin-alljoyn/pull/15"},"issue":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues/15"},"comments":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/AllJoyn-Cordova/cordova-plugin-alljoyn/statuses/a893bc583db3b194fdd9d0ebb84126ade3e9baa4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stefangordon","id":4087345,"avatar_url":"https://avatars.githubusercontent.com/u/4087345?v=3","gravatar_id":"","url":"https://api.github.com/users/stefangordon","html_url":"https://github.com/stefangordon","followers_url":"https://api.github.com/users/stefangordon/followers","following_url":"https://api.github.com/users/stefangordon/following{/other_user}","gists_url":"https://api.github.com/users/stefangordon/gists{/gist_id}","starred_url":"https://api.github.com/users/stefangordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefangordon/subscriptions","organizations_url":"https://api.github.com/users/stefangordon/orgs","repos_url":"https://api.github.com/users/stefangordon/repos","events_url":"https://api.github.com/users/stefangordon/events{/privacy}","received_events_url":"https://api.github.com/users/stefangordon/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":19,"deletions":5,"changed_files":2}}