{"action":"created","comment":{"url":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments/31550467","id":31550467,"diff_hunk":"@@ -34,47 +34,24 @@ public InternalNode(List<AbstractNode> children) {\n \t\t\tchild.translateXProperty().set(LEVELWIDTH);\n \t\t\trangeBegin = rangeBegin.add(child.marginProperty());\n \t\t\tEdge e = new Edge(child);\n-\t\t\tthis.getChildren().add(0, e);\n-\t\t\tchild.setIncomingEdge(e);\n+\t\t\tthis.outgoingEdges.add(e);\n \t\t}\n+\t\tthis.getChildren().addAll(0, outgoingEdges);\n \t\t// Add the nodes after the edges, so that they're on top.\n \t\tthis.getChildren().addAll(children);\n-\t\tbindInactiveProperties();\n \t}\n \n-\tprivate void bindInactiveProperties() {\n-\t\tinactiveProperty().bind(\n-\t\t\t\tBindings.createBooleanBinding(() -> children.stream()\n-\t\t\t\t\t\t.allMatch(AbstractNode::getInactive), children.stream()\n-\t\t\t\t\t\t.map(AbstractNode::inactiveProperty).toArray(BooleanProperty[]::new)));\n+\t/**\n+\t * Bind this margin property to the sum of the children margin properties.\n+\t */\n+\tpublic void bindMargins() {","path":"src/main/java/nl/tudelft/dnainator/ui/drawables/phylogeny/InternalNode.java","position":59,"original_position":59,"commit_id":"2852d083582f4de061b3754d4a4141ad3821b3a5","original_commit_id":"2852d083582f4de061b3754d4a4141ad3821b3a5","user":{"login":"Unia","id":1260727,"avatar_url":"https://avatars.githubusercontent.com/u/1260727?v=3","gravatar_id":"","url":"https://api.github.com/users/Unia","html_url":"https://github.com/Unia","followers_url":"https://api.github.com/users/Unia/followers","following_url":"https://api.github.com/users/Unia/following{/other_user}","gists_url":"https://api.github.com/users/Unia/gists{/gist_id}","starred_url":"https://api.github.com/users/Unia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unia/subscriptions","organizations_url":"https://api.github.com/users/Unia/orgs","repos_url":"https://api.github.com/users/Unia/repos","events_url":"https://api.github.com/users/Unia/events{/privacy}","received_events_url":"https://api.github.com/users/Unia/received_events","type":"User","site_admin":false},"body":"Does this have to be public?","created_at":"2015-06-02T17:50:40Z","updated_at":"2015-06-02T17:50:40Z","html_url":"https://github.com/DNAinator/dnainator/pull/101#discussion_r31550467","pull_request_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments/31550467"},"html":{"href":"https://github.com/DNAinator/dnainator/pull/101#discussion_r31550467"},"pull_request":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/DNAinator/dnainator/pulls/101","id":36581992,"html_url":"https://github.com/DNAinator/dnainator/pull/101","diff_url":"https://github.com/DNAinator/dnainator/pull/101.diff","patch_url":"https://github.com/DNAinator/dnainator/pull/101.patch","issue_url":"https://api.github.com/repos/DNAinator/dnainator/issues/101","number":101,"state":"open","locked":false,"title":"[RFC] Implement collapsing functionality on phylogenetic tree.","user":{"login":"Balletie","id":3884925,"avatar_url":"https://avatars.githubusercontent.com/u/3884925?v=3","gravatar_id":"","url":"https://api.github.com/users/Balletie","html_url":"https://github.com/Balletie","followers_url":"https://api.github.com/users/Balletie/followers","following_url":"https://api.github.com/users/Balletie/following{/other_user}","gists_url":"https://api.github.com/users/Balletie/gists{/gist_id}","starred_url":"https://api.github.com/users/Balletie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Balletie/subscriptions","organizations_url":"https://api.github.com/users/Balletie/orgs","repos_url":"https://api.github.com/users/Balletie/repos","events_url":"https://api.github.com/users/Balletie/events{/privacy}","received_events_url":"https://api.github.com/users/Balletie/received_events","type":"User","site_admin":false},"body":"Comes after #100.","created_at":"2015-05-31T13:13:24Z","updated_at":"2015-06-02T17:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd8633ca982d9b10c7173f61a20d21027709b3ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/101/commits","review_comments_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/101/comments","review_comment_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DNAinator/dnainator/issues/101/comments","statuses_url":"https://api.github.com/repos/DNAinator/dnainator/statuses/2852d083582f4de061b3754d4a4141ad3821b3a5","head":{"label":"Balletie:skip-collapse-phylo","ref":"skip-collapse-phylo","sha":"2852d083582f4de061b3754d4a4141ad3821b3a5","user":{"login":"Balletie","id":3884925,"avatar_url":"https://avatars.githubusercontent.com/u/3884925?v=3","gravatar_id":"","url":"https://api.github.com/users/Balletie","html_url":"https://github.com/Balletie","followers_url":"https://api.github.com/users/Balletie/followers","following_url":"https://api.github.com/users/Balletie/following{/other_user}","gists_url":"https://api.github.com/users/Balletie/gists{/gist_id}","starred_url":"https://api.github.com/users/Balletie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Balletie/subscriptions","organizations_url":"https://api.github.com/users/Balletie/orgs","repos_url":"https://api.github.com/users/Balletie/repos","events_url":"https://api.github.com/users/Balletie/events{/privacy}","received_events_url":"https://api.github.com/users/Balletie/received_events","type":"User","site_admin":false},"repo":{"id":34406161,"name":"dnainator","full_name":"Balletie/dnainator","owner":{"login":"Balletie","id":3884925,"avatar_url":"https://avatars.githubusercontent.com/u/3884925?v=3","gravatar_id":"","url":"https://api.github.com/users/Balletie","html_url":"https://github.com/Balletie","followers_url":"https://api.github.com/users/Balletie/followers","following_url":"https://api.github.com/users/Balletie/following{/other_user}","gists_url":"https://api.github.com/users/Balletie/gists{/gist_id}","starred_url":"https://api.github.com/users/Balletie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Balletie/subscriptions","organizations_url":"https://api.github.com/users/Balletie/orgs","repos_url":"https://api.github.com/users/Balletie/repos","events_url":"https://api.github.com/users/Balletie/events{/privacy}","received_events_url":"https://api.github.com/users/Balletie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Balletie/dnainator","description":"TI2806 Contextproject","fork":true,"url":"https://api.github.com/repos/Balletie/dnainator","forks_url":"https://api.github.com/repos/Balletie/dnainator/forks","keys_url":"https://api.github.com/repos/Balletie/dnainator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Balletie/dnainator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Balletie/dnainator/teams","hooks_url":"https://api.github.com/repos/Balletie/dnainator/hooks","issue_events_url":"https://api.github.com/repos/Balletie/dnainator/issues/events{/number}","events_url":"https://api.github.com/repos/Balletie/dnainator/events","assignees_url":"https://api.github.com/repos/Balletie/dnainator/assignees{/user}","branches_url":"https://api.github.com/repos/Balletie/dnainator/branches{/branch}","tags_url":"https://api.github.com/repos/Balletie/dnainator/tags","blobs_url":"https://api.github.com/repos/Balletie/dnainator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Balletie/dnainator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Balletie/dnainator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Balletie/dnainator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Balletie/dnainator/statuses/{sha}","languages_url":"https://api.github.com/repos/Balletie/dnainator/languages","stargazers_url":"https://api.github.com/repos/Balletie/dnainator/stargazers","contributors_url":"https://api.github.com/repos/Balletie/dnainator/contributors","subscribers_url":"https://api.github.com/repos/Balletie/dnainator/subscribers","subscription_url":"https://api.github.com/repos/Balletie/dnainator/subscription","commits_url":"https://api.github.com/repos/Balletie/dnainator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Balletie/dnainator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Balletie/dnainator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Balletie/dnainator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Balletie/dnainator/contents/{+path}","compare_url":"https://api.github.com/repos/Balletie/dnainator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Balletie/dnainator/merges","archive_url":"https://api.github.com/repos/Balletie/dnainator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Balletie/dnainator/downloads","issues_url":"https://api.github.com/repos/Balletie/dnainator/issues{/number}","pulls_url":"https://api.github.com/repos/Balletie/dnainator/pulls{/number}","milestones_url":"https://api.github.com/repos/Balletie/dnainator/milestones{/number}","notifications_url":"https://api.github.com/repos/Balletie/dnainator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Balletie/dnainator/labels{/name}","releases_url":"https://api.github.com/repos/Balletie/dnainator/releases{/id}","created_at":"2015-04-22T17:48:37Z","updated_at":"2015-05-08T11:54:15Z","pushed_at":"2015-06-02T17:48:18Z","git_url":"git://github.com/Balletie/dnainator.git","ssh_url":"git@github.com:Balletie/dnainator.git","clone_url":"https://github.com/Balletie/dnainator.git","svn_url":"https://github.com/Balletie/dnainator","homepage":null,"size":11763,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DNAinator:master","ref":"master","sha":"fd3d2ff17fb3cdd3ed6b1aa891d85595ec571ea3","user":{"login":"DNAinator","id":12066097,"avatar_url":"https://avatars.githubusercontent.com/u/12066097?v=3","gravatar_id":"","url":"https://api.github.com/users/DNAinator","html_url":"https://github.com/DNAinator","followers_url":"https://api.github.com/users/DNAinator/followers","following_url":"https://api.github.com/users/DNAinator/following{/other_user}","gists_url":"https://api.github.com/users/DNAinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DNAinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNAinator/subscriptions","organizations_url":"https://api.github.com/users/DNAinator/orgs","repos_url":"https://api.github.com/users/DNAinator/repos","events_url":"https://api.github.com/users/DNAinator/events{/privacy}","received_events_url":"https://api.github.com/users/DNAinator/received_events","type":"Organization","site_admin":false},"repo":{"id":34383905,"name":"dnainator","full_name":"DNAinator/dnainator","owner":{"login":"DNAinator","id":12066097,"avatar_url":"https://avatars.githubusercontent.com/u/12066097?v=3","gravatar_id":"","url":"https://api.github.com/users/DNAinator","html_url":"https://github.com/DNAinator","followers_url":"https://api.github.com/users/DNAinator/followers","following_url":"https://api.github.com/users/DNAinator/following{/other_user}","gists_url":"https://api.github.com/users/DNAinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DNAinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNAinator/subscriptions","organizations_url":"https://api.github.com/users/DNAinator/orgs","repos_url":"https://api.github.com/users/DNAinator/repos","events_url":"https://api.github.com/users/DNAinator/events{/privacy}","received_events_url":"https://api.github.com/users/DNAinator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DNAinator/dnainator","description":"TI2806 Contextproject","fork":false,"url":"https://api.github.com/repos/DNAinator/dnainator","forks_url":"https://api.github.com/repos/DNAinator/dnainator/forks","keys_url":"https://api.github.com/repos/DNAinator/dnainator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DNAinator/dnainator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DNAinator/dnainator/teams","hooks_url":"https://api.github.com/repos/DNAinator/dnainator/hooks","issue_events_url":"https://api.github.com/repos/DNAinator/dnainator/issues/events{/number}","events_url":"https://api.github.com/repos/DNAinator/dnainator/events","assignees_url":"https://api.github.com/repos/DNAinator/dnainator/assignees{/user}","branches_url":"https://api.github.com/repos/DNAinator/dnainator/branches{/branch}","tags_url":"https://api.github.com/repos/DNAinator/dnainator/tags","blobs_url":"https://api.github.com/repos/DNAinator/dnainator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DNAinator/dnainator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DNAinator/dnainator/git/refs{/sha}","trees_url":"https://api.github.com/repos/DNAinator/dnainator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DNAinator/dnainator/statuses/{sha}","languages_url":"https://api.github.com/repos/DNAinator/dnainator/languages","stargazers_url":"https://api.github.com/repos/DNAinator/dnainator/stargazers","contributors_url":"https://api.github.com/repos/DNAinator/dnainator/contributors","subscribers_url":"https://api.github.com/repos/DNAinator/dnainator/subscribers","subscription_url":"https://api.github.com/repos/DNAinator/dnainator/subscription","commits_url":"https://api.github.com/repos/DNAinator/dnainator/commits{/sha}","git_commits_url":"https://api.github.com/repos/DNAinator/dnainator/git/commits{/sha}","comments_url":"https://api.github.com/repos/DNAinator/dnainator/comments{/number}","issue_comment_url":"https://api.github.com/repos/DNAinator/dnainator/issues/comments{/number}","contents_url":"https://api.github.com/repos/DNAinator/dnainator/contents/{+path}","compare_url":"https://api.github.com/repos/DNAinator/dnainator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DNAinator/dnainator/merges","archive_url":"https://api.github.com/repos/DNAinator/dnainator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DNAinator/dnainator/downloads","issues_url":"https://api.github.com/repos/DNAinator/dnainator/issues{/number}","pulls_url":"https://api.github.com/repos/DNAinator/dnainator/pulls{/number}","milestones_url":"https://api.github.com/repos/DNAinator/dnainator/milestones{/number}","notifications_url":"https://api.github.com/repos/DNAinator/dnainator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DNAinator/dnainator/labels{/name}","releases_url":"https://api.github.com/repos/DNAinator/dnainator/releases{/id}","created_at":"2015-04-22T10:22:38Z","updated_at":"2015-05-19T08:52:43Z","pushed_at":"2015-06-02T17:48:19Z","git_url":"git://github.com/DNAinator/dnainator.git","ssh_url":"git@github.com:DNAinator/dnainator.git","clone_url":"https://github.com/DNAinator/dnainator.git","svn_url":"https://github.com/DNAinator/dnainator","homepage":null,"size":18048,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/101"},"html":{"href":"https://github.com/DNAinator/dnainator/pull/101"},"issue":{"href":"https://api.github.com/repos/DNAinator/dnainator/issues/101"},"comments":{"href":"https://api.github.com/repos/DNAinator/dnainator/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/DNAinator/dnainator/statuses/2852d083582f4de061b3754d4a4141ad3821b3a5"}}}}