{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2910","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2910/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2910/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2910/events","html_url":"https://github.com/cockroachdb/cockroach/pull/2910","id":113103899,"number":2910,"title":"protobuf: remove most getters","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-10-23T21:30:55Z","updated_at":"2015-10-23T23:16:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2910","html_url":"https://github.com/cockroachdb/cockroach/pull/2910","diff_url":"https://github.com/cockroachdb/cockroach/pull/2910.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/2910.patch"},"body":"Contains some cleanup missed by #2875, /cc @thschroeter.\r\n\r\nI'd review this commit by commit - the 2nd commit does the work for all but `roachpb.Value`, which is then done in the 3rd commit.\r\n\r\n@tschottdorf you're the lucky winner! Sorry. @bdarnell I'd appreciate your eyes on this as well."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/150713781","html_url":"https://github.com/cockroachdb/cockroach/pull/2910#issuecomment-150713781","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2910","id":150713781,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T23:16:03Z","updated_at":"2015-10-23T23:16:03Z","body":"> The only panics prevented by getters that I noticed while writing this PR were prevented by the getters' receiver-is-nil protection.\r\n\r\nThe receiver-is-nil protection is exactly the kind of data-dependent panic I was referring to. The getters can be used to chain accesses through a series of fields that may or may not be present."}}