{"action":"created","issue":{"url":"https://api.github.com/repos/slamdata/purescript-halogen/issues/43","labels_url":"https://api.github.com/repos/slamdata/purescript-halogen/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/slamdata/purescript-halogen/issues/43/comments","events_url":"https://api.github.com/repos/slamdata/purescript-halogen/issues/43/events","html_url":"https://github.com/slamdata/purescript-halogen/pull/43","id":63169403,"number":43,"title":"Final encoding of HTML","user":{"login":"paf31","id":630306,"avatar_url":"https://avatars.githubusercontent.com/u/630306?v=3","gravatar_id":"","url":"https://api.github.com/users/paf31","html_url":"https://github.com/paf31","followers_url":"https://api.github.com/users/paf31/followers","following_url":"https://api.github.com/users/paf31/following{/other_user}","gists_url":"https://api.github.com/users/paf31/gists{/gist_id}","starred_url":"https://api.github.com/users/paf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paf31/subscriptions","organizations_url":"https://api.github.com/users/paf31/orgs","repos_url":"https://api.github.com/users/paf31/repos","events_url":"https://api.github.com/users/paf31/events{/privacy}","received_events_url":"https://api.github.com/users/paf31/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-03-20T05:44:55Z","updated_at":"2015-03-26T05:11:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/slamdata/purescript-halogen/pulls/43","html_url":"https://github.com/slamdata/purescript-halogen/pull/43","diff_url":"https://github.com/slamdata/purescript-halogen/pull/43.diff","patch_url":"https://github.com/slamdata/purescript-halogen/pull/43.patch"},"body":"@jdegoes This is pretty much done, except that:\r\n\r\n- Traversals have been removed. I need to experiment with adding an initial encoding on which we can perform general-purpose traversals.\r\n- The `STProps` approach had to go. Maybe I can figure out a way to get it back in, but I don't think it's the end of the world.\r\n- I might need to tidy up the whole `Bifunctor`/`Plus` thing. I haven't made my mind up yet, but using `bifunctors` will require some upstream changes anyway.\r\n\r\nLet me know what you think. I'll let you decide if the complexity of the implementation is worth the flexibility. Now that this is working again, I'm leaning towards thinking that it is."},"comment":{"url":"https://api.github.com/repos/slamdata/purescript-halogen/issues/comments/86346008","html_url":"https://github.com/slamdata/purescript-halogen/pull/43#issuecomment-86346008","issue_url":"https://api.github.com/repos/slamdata/purescript-halogen/issues/43","id":86346008,"user":{"login":"paf31","id":630306,"avatar_url":"https://avatars.githubusercontent.com/u/630306?v=3","gravatar_id":"","url":"https://api.github.com/users/paf31","html_url":"https://github.com/paf31","followers_url":"https://api.github.com/users/paf31/followers","following_url":"https://api.github.com/users/paf31/following{/other_user}","gists_url":"https://api.github.com/users/paf31/gists{/gist_id}","starred_url":"https://api.github.com/users/paf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paf31/subscriptions","organizations_url":"https://api.github.com/users/paf31/orgs","repos_url":"https://api.github.com/users/paf31/repos","events_url":"https://api.github.com/users/paf31/events{/privacy}","received_events_url":"https://api.github.com/users/paf31/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T05:11:12Z","updated_at":"2015-03-26T05:11:12Z","body":"Ok, this is about as much as I can do to simplify the `HTML` data structure. I can separate some of the performance changes into another PR.\r\n\r\n@jdegoes Do you want to review one more time, before I merge?\r\n\r\nAfter this my main priorities in order (unless you have something else) are:\r\n\r\n- Try out some alternative `View` types for better composition\r\n- Try to speed up the generation of `VTree`s by avoiding passing various functions around\r\n\r\nwhich are the remaining blockers for a release. Then:\r\n\r\n- Integrate `purescript-markdown`\r\n- Extra Bootstrap components"}}