{"action":"closed","number":153,"pull_request":{"url":"https://api.github.com/repos/kriskowal/q-io/pulls/153","id":52277747,"html_url":"https://github.com/kriskowal/q-io/pull/153","diff_url":"https://github.com/kriskowal/q-io/pull/153.diff","patch_url":"https://github.com/kriskowal/q-io/pull/153.patch","issue_url":"https://api.github.com/repos/kriskowal/q-io/issues/153","number":153,"state":"closed","locked":false,"title":"Fix incorrect version check","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"body":"As it stands, the version check will ensure that the major version is non-negative *and* that the minor version is at least 10.  Current versions, with major version 4 or 5 but single-digit minor versions, are not matched by this.  Instead we can check whether the major version is at least 1 *or* the minor version is at least 10, assuming in the latter case that the major version cannot be less than 0 so we don't have to check for that.\r\n\r\nThis fixes #149 except on *very* old versions of node.","created_at":"2015-12-01T16:09:51Z","updated_at":"2015-12-01T18:55:36Z","closed_at":"2015-12-01T18:55:36Z","merged_at":"2015-12-01T18:55:36Z","merge_commit_sha":"a942045d34cfdf8fd300cb79baf07732fa6a68b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kriskowal/q-io/pulls/153/commits","review_comments_url":"https://api.github.com/repos/kriskowal/q-io/pulls/153/comments","review_comment_url":"https://api.github.com/repos/kriskowal/q-io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kriskowal/q-io/issues/153/comments","statuses_url":"https://api.github.com/repos/kriskowal/q-io/statuses/061284b473ec80dfe4c891d5de4b7b330da2a187","head":{"label":"gagern:nodeVersionCheck","ref":"nodeVersionCheck","sha":"061284b473ec80dfe4c891d5de4b7b330da2a187","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"repo":{"id":47200729,"name":"q-io","full_name":"gagern/q-io","owner":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gagern/q-io","description":"Interfaces for IO using Q promises in JavaScript on Node","fork":true,"url":"https://api.github.com/repos/gagern/q-io","forks_url":"https://api.github.com/repos/gagern/q-io/forks","keys_url":"https://api.github.com/repos/gagern/q-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gagern/q-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gagern/q-io/teams","hooks_url":"https://api.github.com/repos/gagern/q-io/hooks","issue_events_url":"https://api.github.com/repos/gagern/q-io/issues/events{/number}","events_url":"https://api.github.com/repos/gagern/q-io/events","assignees_url":"https://api.github.com/repos/gagern/q-io/assignees{/user}","branches_url":"https://api.github.com/repos/gagern/q-io/branches{/branch}","tags_url":"https://api.github.com/repos/gagern/q-io/tags","blobs_url":"https://api.github.com/repos/gagern/q-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gagern/q-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gagern/q-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/gagern/q-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gagern/q-io/statuses/{sha}","languages_url":"https://api.github.com/repos/gagern/q-io/languages","stargazers_url":"https://api.github.com/repos/gagern/q-io/stargazers","contributors_url":"https://api.github.com/repos/gagern/q-io/contributors","subscribers_url":"https://api.github.com/repos/gagern/q-io/subscribers","subscription_url":"https://api.github.com/repos/gagern/q-io/subscription","commits_url":"https://api.github.com/repos/gagern/q-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/gagern/q-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/gagern/q-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/gagern/q-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/gagern/q-io/contents/{+path}","compare_url":"https://api.github.com/repos/gagern/q-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gagern/q-io/merges","archive_url":"https://api.github.com/repos/gagern/q-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gagern/q-io/downloads","issues_url":"https://api.github.com/repos/gagern/q-io/issues{/number}","pulls_url":"https://api.github.com/repos/gagern/q-io/pulls{/number}","milestones_url":"https://api.github.com/repos/gagern/q-io/milestones{/number}","notifications_url":"https://api.github.com/repos/gagern/q-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gagern/q-io/labels{/name}","releases_url":"https://api.github.com/repos/gagern/q-io/releases{/id}","created_at":"2015-12-01T16:06:25Z","updated_at":"2015-12-01T16:06:26Z","pushed_at":"2015-12-01T16:08:44Z","git_url":"git://github.com/gagern/q-io.git","ssh_url":"git@github.com:gagern/q-io.git","clone_url":"https://github.com/gagern/q-io.git","svn_url":"https://github.com/gagern/q-io","homepage":"http://documentup.com/kriskowal/q-io","size":409,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1"}},"base":{"label":"kriskowal:v1","ref":"v1","sha":"fa3915be3e898738c50995f9ccaf828889e5cadc","user":{"login":"kriskowal","id":60294,"avatar_url":"https://avatars.githubusercontent.com/u/60294?v=3","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false},"repo":{"id":914623,"name":"q-io","full_name":"kriskowal/q-io","owner":{"login":"kriskowal","id":60294,"avatar_url":"https://avatars.githubusercontent.com/u/60294?v=3","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kriskowal/q-io","description":"Interfaces for IO using Q promises in JavaScript on Node","fork":false,"url":"https://api.github.com/repos/kriskowal/q-io","forks_url":"https://api.github.com/repos/kriskowal/q-io/forks","keys_url":"https://api.github.com/repos/kriskowal/q-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kriskowal/q-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kriskowal/q-io/teams","hooks_url":"https://api.github.com/repos/kriskowal/q-io/hooks","issue_events_url":"https://api.github.com/repos/kriskowal/q-io/issues/events{/number}","events_url":"https://api.github.com/repos/kriskowal/q-io/events","assignees_url":"https://api.github.com/repos/kriskowal/q-io/assignees{/user}","branches_url":"https://api.github.com/repos/kriskowal/q-io/branches{/branch}","tags_url":"https://api.github.com/repos/kriskowal/q-io/tags","blobs_url":"https://api.github.com/repos/kriskowal/q-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kriskowal/q-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kriskowal/q-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/kriskowal/q-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kriskowal/q-io/statuses/{sha}","languages_url":"https://api.github.com/repos/kriskowal/q-io/languages","stargazers_url":"https://api.github.com/repos/kriskowal/q-io/stargazers","contributors_url":"https://api.github.com/repos/kriskowal/q-io/contributors","subscribers_url":"https://api.github.com/repos/kriskowal/q-io/subscribers","subscription_url":"https://api.github.com/repos/kriskowal/q-io/subscription","commits_url":"https://api.github.com/repos/kriskowal/q-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/kriskowal/q-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/kriskowal/q-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/kriskowal/q-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/kriskowal/q-io/contents/{+path}","compare_url":"https://api.github.com/repos/kriskowal/q-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kriskowal/q-io/merges","archive_url":"https://api.github.com/repos/kriskowal/q-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kriskowal/q-io/downloads","issues_url":"https://api.github.com/repos/kriskowal/q-io/issues{/number}","pulls_url":"https://api.github.com/repos/kriskowal/q-io/pulls{/number}","milestones_url":"https://api.github.com/repos/kriskowal/q-io/milestones{/number}","notifications_url":"https://api.github.com/repos/kriskowal/q-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kriskowal/q-io/labels{/name}","releases_url":"https://api.github.com/repos/kriskowal/q-io/releases{/id}","created_at":"2010-09-16T06:07:02Z","updated_at":"2015-11-30T10:40:08Z","pushed_at":"2015-12-01T18:55:36Z","git_url":"git://github.com/kriskowal/q-io.git","ssh_url":"git@github.com:kriskowal/q-io.git","clone_url":"https://github.com/kriskowal/q-io.git","svn_url":"https://github.com/kriskowal/q-io","homepage":"http://documentup.com/kriskowal/q-io","size":1199,"stargazers_count":273,"watchers_count":273,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":27,"forks":65,"open_issues":27,"watchers":273,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/kriskowal/q-io/pulls/153"},"html":{"href":"https://github.com/kriskowal/q-io/pull/153"},"issue":{"href":"https://api.github.com/repos/kriskowal/q-io/issues/153"},"comments":{"href":"https://api.github.com/repos/kriskowal/q-io/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/kriskowal/q-io/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/kriskowal/q-io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kriskowal/q-io/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/kriskowal/q-io/statuses/061284b473ec80dfe4c891d5de4b7b330da2a187"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kriskowal","id":60294,"avatar_url":"https://avatars.githubusercontent.com/u/60294?v=3","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}