{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3946","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3946/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3946/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3946/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3946","id":101904756,"number":3946,"title":"[WIP]Style1 to patternfly conversion in Virtual Machines","user":{"login":"PanSpagetka","id":9535558,"avatar_url":"https://avatars.githubusercontent.com/u/9535558?v=3","gravatar_id":"","url":"https://api.github.com/users/PanSpagetka","html_url":"https://github.com/PanSpagetka","followers_url":"https://api.github.com/users/PanSpagetka/followers","following_url":"https://api.github.com/users/PanSpagetka/following{/other_user}","gists_url":"https://api.github.com/users/PanSpagetka/gists{/gist_id}","starred_url":"https://api.github.com/users/PanSpagetka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanSpagetka/subscriptions","organizations_url":"https://api.github.com/users/PanSpagetka/orgs","repos_url":"https://api.github.com/users/PanSpagetka/repos","events_url":"https://api.github.com/users/PanSpagetka/events{/privacy}","received_events_url":"https://api.github.com/users/PanSpagetka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-19T14:18:35Z","updated_at":"2015-09-01T14:47:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3946","html_url":"https://github.com/ManageIQ/manageiq/pull/3946","diff_url":"https://github.com/ManageIQ/manageiq/pull/3946.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3946.patch"},"body":"Parent issue: #3139\r\n\r\n1.\r\nBefore:\r\n![screenshot from 2015-08-26 14-13-51](https://cloud.githubusercontent.com/assets/9535558/9495390/9fa44b96-4c0b-11e5-8d71-a3ad7621e320.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-03-03](https://cloud.githubusercontent.com/assets/9535558/9495574/8b04b80a-4c0c-11e5-96d4-c68cde0da65e.png)\r\n\r\n2.\r\nBefore:\r\n![screenshot from 2015-08-26 14-14-09](https://cloud.githubusercontent.com/assets/9535558/9495393/a41808d4-4c0b-11e5-8788-d079006e9ac5.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-03-14](https://cloud.githubusercontent.com/assets/9535558/9495580/9204a8b8-4c0c-11e5-8b58-64447d48bb78.png)\r\n\r\n3.\r\nBefore:\r\n![screenshot from 2015-08-26 14-14-29](https://cloud.githubusercontent.com/assets/9535558/9495411/b8fa748a-4c0b-11e5-8cda-a40c27395d92.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-03-26](https://cloud.githubusercontent.com/assets/9535558/9495583/94347294-4c0c-11e5-8000-d2b4e6fc3d9c.png)\r\n\r\n4.\r\nBefore:\r\n![screenshot from 2015-08-26 14-16-16](https://cloud.githubusercontent.com/assets/9535558/9495414/bc4c8b82-4c0b-11e5-8c39-c6b93116bbf2.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-03-38](https://cloud.githubusercontent.com/assets/9535558/9495586/96235480-4c0c-11e5-94ea-5e23577d3a82.png)\r\n\r\n5.\r\nBefore:\r\n![screenshot from 2015-08-26 14-14-50](https://cloud.githubusercontent.com/assets/9535558/9495415/bfdabd3c-4c0b-11e5-9427-a9c16b2ef690.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-03-52](https://cloud.githubusercontent.com/assets/9535558/9495603/aa5cd87c-4c0c-11e5-81f1-732e6d2042ae.png)\r\n\r\n6.\r\nBefore:\r\n![screenshot from 2015-08-26 14-15-04](https://cloud.githubusercontent.com/assets/9535558/9495420/c2d5752c-4c0b-11e5-8982-01304c0a24be.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-04-03](https://cloud.githubusercontent.com/assets/9535558/9495629/cb8ae49e-4c0c-11e5-97bb-05ca6600e5ca.png)\r\n\r\n7.\r\nBefore:\r\n![screenshot from 2015-08-26 14-15-35](https://cloud.githubusercontent.com/assets/9535558/9495421/c4c452ae-4c0b-11e5-964a-c0c168f76402.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-14-33](https://cloud.githubusercontent.com/assets/9535558/9495797/95413cde-4c0d-11e5-96b3-530be6265b34.png)\r\n\r\n\r\n8.\r\nBefore:\r\n![screenshot from 2015-08-26 14-15-52](https://cloud.githubusercontent.com/assets/9535558/9495423/c7a31a32-4c0b-11e5-9bf2-9f376f78e931.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-26 16-04-24](https://cloud.githubusercontent.com/assets/9535558/9495632/cf436052-4c0c-11e5-9932-de526f905d81.png)\r\n\r\n9.\r\nBefore:\r\n![screenshot from 2015-09-01 11-17-16](https://cloud.githubusercontent.com/assets/9535558/9600447/671fd314-509b-11e5-9393-f7e0420419e7.png)\r\n\r\n\r\nAfter:\r\n![screenshot from 2015-09-01 11-18-56](https://cloud.githubusercontent.com/assets/9535558/9600450/6a793d8e-509b-11e5-84d6-36f74639925d.png)\r\n\r\n\r\n10.\r\nBefore:\r\n![screenshot from 2015-08-27 13-45-56](https://cloud.githubusercontent.com/assets/9535558/9520097/68243ab4-4cc4-11e5-844b-4dc333e726f3.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-27 13-58-48](https://cloud.githubusercontent.com/assets/9535558/9520098/6af82426-4cc4-11e5-9a73-d3969df25e70.png)\r\n\r\n10.\r\nBefore:\r\n![screenshot from 2015-08-27 14-08-22](https://cloud.githubusercontent.com/assets/9535558/9520250/db777c5a-4cc5-11e5-9c66-5694443eb76a.png)\r\n\r\nAfter:\r\n![screenshot from 2015-08-27 14-13-28](https://cloud.githubusercontent.com/assets/9535558/9520251/dc9a27f4-4cc5-11e5-9f73-9cf97f7d287b.png)\r\n\r\n\r\n@epwinchell Please review "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/136747930","html_url":"https://github.com/ManageIQ/manageiq/pull/3946#issuecomment-136747930","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3946","id":136747930,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T14:47:17Z","updated_at":"2015-09-01T14:47:17Z","body":"<rubocop />Checked commit https://github.com/PanSpagetka/manageiq/commit/d58b77b4122ca37f885c22575e767d1999cf535c with rubocop 0.33.0 and haml-lint 0.13.0\n6 files checked, 30 offenses detected\n\n**app/views/miq_request/_prov_field.html.haml**\n- [ ] :red_circle: **Warn** - [Line 35](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L35), Col  -  - Line is too long. [121/120]\n- [ ] :red_circle: **Warn** - [Line 148](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L148), Col  -  - Line is too long. [123/120]\n- [ ] :red_circle: **Warn** - [Line 212](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L212), Col  -  - Line is too long. [121/120]\n- [ ] :red_circle: **Warn** - [Line 256](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L256), Col  -  - Line is too long. [136/120]\n- [ ] :red_circle: **Warn** - [Line 351](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L351), Col  -  - Line is too long. [123/120]\n- [ ] :red_circle: **Warn** - [Line 393](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L393), Col  -  - Line is too long. [121/120]\n- [ ] :red_circle: **Warn** - [Line 430](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/miq_request/_prov_field.html.haml#L430), Col  -  - Line is too long. [123/120]\n\n**app/views/shared/views/_retire.html.haml**\n- [ ] :red_circle: **Warn** - [Line 4](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L4), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L13), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L13), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L13), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L13), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L13), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L13), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 20](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L20), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 20](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L20), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 20](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L20), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 28](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L28), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 28](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/shared/views/_retire.html.haml#L28), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n\n**app/views/vm_common/_reconfigure.html.haml**\n- [ ] :red_circle: **Warn** - [Line 21](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L21), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 27](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L27), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 53](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L53), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 53](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L53), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 54](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L54), Col  -  - Line is too long. [168/120]\n- [ ] :red_circle: **Warn** - [Line 79](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L79), Col  -  - Style/SpaceAfterComma: Space missing after comma.\n- [ ] :red_circle: **Warn** - [Line 79](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L79), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 79](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L79), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 80](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L80), Col  -  - Line is too long. [150/120]\n- [ ] :red_circle: **Warn** - [Line 95](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L95), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 96](https://github.com/PanSpagetka/manageiq/blob/d58b77b4122ca37f885c22575e767d1999cf535c/app/views/vm_common/_reconfigure.html.haml#L96), Col  -  - Line is too long. [155/120]\n"}}