{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/signonotron2/pulls/comments/43233126","id":43233126,"diff_hunk":"@@ -64,3 +64,7 @@\n     </div>\n   </div>\n </div>\n+\n+<div>\n+  <%= f.submit t(\"users.edit.change\"), :class => 'btn btn-primary add-top-margin' %>","path":"app/views/devise/passwords/_change_password_panel.html.erb","position":6,"original_position":6,"commit_id":"4b74127ce7a3031e0605c7b716252050a9a378df","original_commit_id":"4b74127ce7a3031e0605c7b716252050a9a378df","user":{"login":"benlovell","id":41963,"avatar_url":"https://avatars.githubusercontent.com/u/41963?v=3","gravatar_id":"","url":"https://api.github.com/users/benlovell","html_url":"https://github.com/benlovell","followers_url":"https://api.github.com/users/benlovell/followers","following_url":"https://api.github.com/users/benlovell/following{/other_user}","gists_url":"https://api.github.com/users/benlovell/gists{/gist_id}","starred_url":"https://api.github.com/users/benlovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlovell/subscriptions","organizations_url":"https://api.github.com/users/benlovell/orgs","repos_url":"https://api.github.com/users/benlovell/repos","events_url":"https://api.github.com/users/benlovell/events{/privacy}","received_events_url":"https://api.github.com/users/benlovell/received_events","type":"User","site_admin":false},"body":"Could we use the 1.9 style hash keys here, per the style guide?","created_at":"2015-10-28T09:35:09Z","updated_at":"2015-10-28T09:35:09Z","html_url":"https://github.com/alphagov/signonotron2/pull/426#discussion_r43233126","pull_request_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/426","_links":{"self":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/comments/43233126"},"html":{"href":"https://github.com/alphagov/signonotron2/pull/426#discussion_r43233126"},"pull_request":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/signonotron2/pulls/426","id":48727863,"html_url":"https://github.com/alphagov/signonotron2/pull/426","diff_url":"https://github.com/alphagov/signonotron2/pull/426.diff","patch_url":"https://github.com/alphagov/signonotron2/pull/426.patch","issue_url":"https://api.github.com/repos/alphagov/signonotron2/issues/426","number":426,"state":"open","locked":false,"title":"Improve error messaging and track user errors on forms to Google Analytics","user":{"login":"fofr","id":319055,"avatar_url":"https://avatars.githubusercontent.com/u/319055?v=3","gravatar_id":"","url":"https://api.github.com/users/fofr","html_url":"https://github.com/fofr","followers_url":"https://api.github.com/users/fofr/followers","following_url":"https://api.github.com/users/fofr/following{/other_user}","gists_url":"https://api.github.com/users/fofr/gists{/gist_id}","starred_url":"https://api.github.com/users/fofr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fofr/subscriptions","organizations_url":"https://api.github.com/users/fofr/orgs","repos_url":"https://api.github.com/users/fofr/repos","events_url":"https://api.github.com/users/fofr/events{/privacy}","received_events_url":"https://api.github.com/users/fofr/received_events","type":"User","site_admin":false},"body":"Collect anonymous metrics on the different types of user error when they’re changing their email or passphrase, or when setting up 2-step verification.\r\n\r\n* Add a helper for tracking messages in analytics\r\n* Start tracking the error messages in analytics\r\n\r\nThis also includes some improvements to the passphrase change forms:\r\n\r\n* Avoid using the default devise error message. The default includes a poor heading and old markup. The default can be found here: https://github.com/plataformatec/devise/blob/7df57d5081f9884849ca15e4fde179ef164a575f/app/helpers/devise_helper.rb\r\n* Consolidate errors into a new partial\r\n* DRY up form by moving submit button into partial\r\n\r\n## Before\r\n![pasted_image_at_2015_10_08_04_03_pm_720](https://cloud.githubusercontent.com/assets/319055/10727732/05b9064a-7bd4-11e5-8f7e-13820833675c.png)\r\n\r\n## After\r\n![screen shot 2015-10-23 at 13 20 58](https://cloud.githubusercontent.com/assets/319055/10727736/0ed30bb8-7bd4-11e5-9780-58157644ccbc.png)\r\n\r\ncc @boffbowsh @jamiecobbett","created_at":"2015-10-26T11:29:46Z","updated_at":"2015-10-28T09:35:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b869e750314e5a8d603f3fb1415ffbb9997dc8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/426/commits","review_comments_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/426/comments","review_comment_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/issues/426/comments","statuses_url":"https://api.github.com/repos/alphagov/signonotron2/statuses/4b74127ce7a3031e0605c7b716252050a9a378df","head":{"label":"alphagov:track-more-errors","ref":"track-more-errors","sha":"4b74127ce7a3031e0605c7b716252050a9a378df","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":3928902,"name":"signonotron2","full_name":"alphagov/signonotron2","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/signonotron2","description":"Single sign-on service for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/signonotron2","forks_url":"https://api.github.com/repos/alphagov/signonotron2/forks","keys_url":"https://api.github.com/repos/alphagov/signonotron2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/signonotron2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/signonotron2/teams","hooks_url":"https://api.github.com/repos/alphagov/signonotron2/hooks","issue_events_url":"https://api.github.com/repos/alphagov/signonotron2/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/signonotron2/events","assignees_url":"https://api.github.com/repos/alphagov/signonotron2/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/signonotron2/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/signonotron2/tags","blobs_url":"https://api.github.com/repos/alphagov/signonotron2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/signonotron2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/signonotron2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/signonotron2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/signonotron2/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/signonotron2/languages","stargazers_url":"https://api.github.com/repos/alphagov/signonotron2/stargazers","contributors_url":"https://api.github.com/repos/alphagov/signonotron2/contributors","subscribers_url":"https://api.github.com/repos/alphagov/signonotron2/subscribers","subscription_url":"https://api.github.com/repos/alphagov/signonotron2/subscription","commits_url":"https://api.github.com/repos/alphagov/signonotron2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/signonotron2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/signonotron2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/signonotron2/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/signonotron2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/signonotron2/merges","archive_url":"https://api.github.com/repos/alphagov/signonotron2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/signonotron2/downloads","issues_url":"https://api.github.com/repos/alphagov/signonotron2/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/signonotron2/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/signonotron2/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/signonotron2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/signonotron2/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/signonotron2/releases{/id}","created_at":"2012-04-04T13:23:55Z","updated_at":"2015-10-21T17:03:03Z","pushed_at":"2015-10-27T11:00:36Z","git_url":"git://github.com/alphagov/signonotron2.git","ssh_url":"git@github.com:alphagov/signonotron2.git","clone_url":"https://github.com/alphagov/signonotron2.git","svn_url":"https://github.com/alphagov/signonotron2","homepage":"","size":8787,"stargazers_count":38,"watchers_count":38,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":38,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"c581c8afc4cb09058a3c653c9aa49f604dec2fb6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":3928902,"name":"signonotron2","full_name":"alphagov/signonotron2","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/signonotron2","description":"Single sign-on service for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/signonotron2","forks_url":"https://api.github.com/repos/alphagov/signonotron2/forks","keys_url":"https://api.github.com/repos/alphagov/signonotron2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/signonotron2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/signonotron2/teams","hooks_url":"https://api.github.com/repos/alphagov/signonotron2/hooks","issue_events_url":"https://api.github.com/repos/alphagov/signonotron2/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/signonotron2/events","assignees_url":"https://api.github.com/repos/alphagov/signonotron2/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/signonotron2/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/signonotron2/tags","blobs_url":"https://api.github.com/repos/alphagov/signonotron2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/signonotron2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/signonotron2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/signonotron2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/signonotron2/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/signonotron2/languages","stargazers_url":"https://api.github.com/repos/alphagov/signonotron2/stargazers","contributors_url":"https://api.github.com/repos/alphagov/signonotron2/contributors","subscribers_url":"https://api.github.com/repos/alphagov/signonotron2/subscribers","subscription_url":"https://api.github.com/repos/alphagov/signonotron2/subscription","commits_url":"https://api.github.com/repos/alphagov/signonotron2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/signonotron2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/signonotron2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/signonotron2/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/signonotron2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/signonotron2/merges","archive_url":"https://api.github.com/repos/alphagov/signonotron2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/signonotron2/downloads","issues_url":"https://api.github.com/repos/alphagov/signonotron2/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/signonotron2/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/signonotron2/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/signonotron2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/signonotron2/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/signonotron2/releases{/id}","created_at":"2012-04-04T13:23:55Z","updated_at":"2015-10-21T17:03:03Z","pushed_at":"2015-10-27T11:00:36Z","git_url":"git://github.com/alphagov/signonotron2.git","ssh_url":"git@github.com:alphagov/signonotron2.git","clone_url":"https://github.com/alphagov/signonotron2.git","svn_url":"https://github.com/alphagov/signonotron2","homepage":"","size":8787,"stargazers_count":38,"watchers_count":38,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/426"},"html":{"href":"https://github.com/alphagov/signonotron2/pull/426"},"issue":{"href":"https://api.github.com/repos/alphagov/signonotron2/issues/426"},"comments":{"href":"https://api.github.com/repos/alphagov/signonotron2/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/signonotron2/statuses/4b74127ce7a3031e0605c7b716252050a9a378df"}}}}