{"action":"created","issue":{"url":"https://api.github.com/repos/mpdf/mpdf/issues/71","labels_url":"https://api.github.com/repos/mpdf/mpdf/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/mpdf/mpdf/issues/71/comments","events_url":"https://api.github.com/repos/mpdf/mpdf/issues/71/events","html_url":"https://github.com/mpdf/mpdf/pull/71","id":119955901,"number":71,"title":"WIP: add support for orphan and widow page breaking","user":{"login":"thnkloud9","id":1511745,"avatar_url":"https://avatars.githubusercontent.com/u/1511745?v=3","gravatar_id":"","url":"https://api.github.com/users/thnkloud9","html_url":"https://github.com/thnkloud9","followers_url":"https://api.github.com/users/thnkloud9/followers","following_url":"https://api.github.com/users/thnkloud9/following{/other_user}","gists_url":"https://api.github.com/users/thnkloud9/gists{/gist_id}","starred_url":"https://api.github.com/users/thnkloud9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thnkloud9/subscriptions","organizations_url":"https://api.github.com/users/thnkloud9/orgs","repos_url":"https://api.github.com/users/thnkloud9/repos","events_url":"https://api.github.com/users/thnkloud9/events{/privacy}","received_events_url":"https://api.github.com/users/thnkloud9/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-02T14:40:47Z","updated_at":"2015-12-02T21:23:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mpdf/mpdf/pulls/71","html_url":"https://github.com/mpdf/mpdf/pull/71","diff_url":"https://github.com/mpdf/mpdf/pull/71.diff","patch_url":"https://github.com/mpdf/mpdf/pull/71.patch"},"body":"To config min lines require before allowing a block orphan / widow update config.php:\r\n\r\n$this->minWidowLines = 3;\r\n$this->minOrphanLines = 3;\r\n\r\na value of 0 here should result in current behavior without auto breaks.\r\n\r\nI have only so far tested with examples/example02_CSS_styles.php, and this is a bit of a hasty patch, so any help with testing, examples, and feedback (be critical, I can take it ;-) would be very much appreciated.  I would be interested in the proper way to regression test and make sure I didn't break anything with these changes as well. "},"comment":{"url":"https://api.github.com/repos/mpdf/mpdf/issues/comments/161437915","html_url":"https://github.com/mpdf/mpdf/pull/71#issuecomment-161437915","issue_url":"https://api.github.com/repos/mpdf/mpdf/issues/71","id":161437915,"user":{"login":"blueliquiddesigns","id":2918419,"avatar_url":"https://avatars.githubusercontent.com/u/2918419?v=3","gravatar_id":"","url":"https://api.github.com/users/blueliquiddesigns","html_url":"https://github.com/blueliquiddesigns","followers_url":"https://api.github.com/users/blueliquiddesigns/followers","following_url":"https://api.github.com/users/blueliquiddesigns/following{/other_user}","gists_url":"https://api.github.com/users/blueliquiddesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/blueliquiddesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueliquiddesigns/subscriptions","organizations_url":"https://api.github.com/users/blueliquiddesigns/orgs","repos_url":"https://api.github.com/users/blueliquiddesigns/repos","events_url":"https://api.github.com/users/blueliquiddesigns/events{/privacy}","received_events_url":"https://api.github.com/users/blueliquiddesigns/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T21:23:53Z","updated_at":"2015-12-02T21:23:53Z","body":"Nice work! I especially liked the clone of the original object to check for overflow onto the next page.\r\n\r\nAdding appropriate unit tests will be the main way to ensure there is no regression. Adding tests for the new methods added should be relatively straightforward. But writing appropriate tests for `WriteFlowingBlock` looks like it will be more challenging – your added code may have to be moved to it's own method to make it easier to test as that method is huge."}}