{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/28664094","id":28664094,"diff_hunk":"@@ -309,12 +333,12 @@ public int[] FullMessage(List<PipelineMessage<int[]>> pipelineMessage)\n                 return data;\n             }\n \n-            public IConfiguration GetConfiguration()\n-            {\n-                return TangFactory.GetTang().NewConfigurationBuilder()\n-                .BindNamedParameter<GroupTestConfig.ChunkSize, int>(GenericType<GroupTestConfig.ChunkSize>.Class, _chunkSize.ToString(CultureInfo.InvariantCulture))\n-                .Build();\n-            }\n+            //public IConfiguration GetConfiguration()","path":"lang/cs/Org.Apache.REEF.Network.Examples/GroupCommunication/PipelineBroadcastReduceDriverAndTasks/PipelinedBroadcastReduceDriver.cs","position":87,"original_position":87,"commit_id":"5089d2d2c960806a632466c00a500027cd1c7738","original_commit_id":"5089d2d2c960806a632466c00a500027cd1c7738","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"please remove the commented out code.","created_at":"2015-04-20T04:54:07Z","updated_at":"2015-04-20T04:54:07Z","html_url":"https://github.com/apache/incubator-reef/pull/151#discussion_r28664094","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/28664094"},"html":{"href":"https://github.com/apache/incubator-reef/pull/151#discussion_r28664094"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/151","id":33588534,"html_url":"https://github.com/apache/incubator-reef/pull/151","diff_url":"https://github.com/apache/incubator-reef/pull/151.diff","patch_url":"https://github.com/apache/incubator-reef/pull/151.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/151","number":151,"state":"open","locked":false,"title":"[REEF-262]  Passing Configuration to Group Communication Driver","user":{"login":"jwang98052","id":5666504,"avatar_url":"https://avatars.githubusercontent.com/u/5666504?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang98052","html_url":"https://github.com/jwang98052","followers_url":"https://api.github.com/users/jwang98052/followers","following_url":"https://api.github.com/users/jwang98052/following{/other_user}","gists_url":"https://api.github.com/users/jwang98052/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang98052/subscriptions","organizations_url":"https://api.github.com/users/jwang98052/orgs","repos_url":"https://api.github.com/users/jwang98052/repos","events_url":"https://api.github.com/users/jwang98052/events{/privacy}","received_events_url":"https://api.github.com/users/jwang98052/received_events","type":"User","site_admin":false},"body":"Today clients pass Codec and ReduceFunction object to Group Communication driver and inside Group Communication driver, we create configurations for Codec, Reduce Functions and DataConverters. This doesn't provide flexibility for clients to set parameters in the reduce function also make the Group code complex. This PR is move all those settings to Tang Configuration. Allow clients to bind their own implementations and parameters, then passing the configuration to Group Communication Driver.\r\n\r\nThis PR includes:-\r\n-Added Configuration Module for Codec, ReduceFunction and DadtaConverter\r\n-Updated GroupCommunicationDriver APIs to accept Configuration\r\n-Simplified GroupCommunicationDriver to remove unnecessary overloading methods\r\n-Updated specification to wrap Configuration and removed Codec and DataConverter\r\n-Removed generic from specifications as it is not needed any more\r\n-Removed Codec type as generic from GroupCommunicationDriver API\r\n-Updated unit tests, functional tests and KMean tests\r\n\r\nJIRA: REEF-262. (https://issues.apache.org/jira/browse/REEF-262)","created_at":"2015-04-17T22:41:53Z","updated_at":"2015-04-20T04:54:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42af1edd9e830242a1481bf17f10b8ad6a95810d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/151/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/151/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/151/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/5089d2d2c960806a632466c00a500027cd1c7738","head":{"label":"Microsoft-CISL:REEF-262","ref":"REEF-262","sha":"5089d2d2c960806a632466c00a500027cd1c7738","user":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"repo":{"id":30330372,"name":"incubator-reef","full_name":"Microsoft-CISL/incubator-reef","owner":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft-CISL/incubator-reef","description":"Mirror of Apache REEF (Incubating) for Pull Request staging","fork":true,"url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef","forks_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/forks","keys_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/teams","hooks_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/events","assignees_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/tags","blobs_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/subscription","commits_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/merges","archive_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/downloads","issues_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/releases{/id}","created_at":"2015-02-05T01:06:12Z","updated_at":"2015-03-17T00:39:59Z","pushed_at":"2015-04-20T01:24:20Z","git_url":"git://github.com/Microsoft-CISL/incubator-reef.git","ssh_url":"git@github.com:Microsoft-CISL/incubator-reef.git","clone_url":"https://github.com/Microsoft-CISL/incubator-reef.git","svn_url":"https://github.com/Microsoft-CISL/incubator-reef","homepage":"","size":34547,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"774a5d75e60d091c28014f497a9b9c1789fa8c10","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2015-04-18T01:37:54Z","pushed_at":"2015-04-20T02:08:53Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":38421,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":5,"forks":19,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/151"},"html":{"href":"https://github.com/apache/incubator-reef/pull/151"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/151"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/5089d2d2c960806a632466c00a500027cd1c7738"}}}}