{"action":"created","issue":{"url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/issues/182","labels_url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/issues/182/comments","events_url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/issues/182/events","html_url":"https://github.com/OpenHFT/Chronicle-Queue/pull/182","id":97833799,"number":182,"title":"Tcp Pipeline","user":{"login":"ryanlea","id":728082,"avatar_url":"https://avatars.githubusercontent.com/u/728082?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanlea","html_url":"https://github.com/ryanlea","followers_url":"https://api.github.com/users/ryanlea/followers","following_url":"https://api.github.com/users/ryanlea/following{/other_user}","gists_url":"https://api.github.com/users/ryanlea/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlea/subscriptions","organizations_url":"https://api.github.com/users/ryanlea/orgs","repos_url":"https://api.github.com/users/ryanlea/repos","events_url":"https://api.github.com/users/ryanlea/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlea/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"lburgazzoli","id":1868933,"avatar_url":"https://avatars.githubusercontent.com/u/1868933?v=3","gravatar_id":"","url":"https://api.github.com/users/lburgazzoli","html_url":"https://github.com/lburgazzoli","followers_url":"https://api.github.com/users/lburgazzoli/followers","following_url":"https://api.github.com/users/lburgazzoli/following{/other_user}","gists_url":"https://api.github.com/users/lburgazzoli/gists{/gist_id}","starred_url":"https://api.github.com/users/lburgazzoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lburgazzoli/subscriptions","organizations_url":"https://api.github.com/users/lburgazzoli/orgs","repos_url":"https://api.github.com/users/lburgazzoli/repos","events_url":"https://api.github.com/users/lburgazzoli/events{/privacy}","received_events_url":"https://api.github.com/users/lburgazzoli/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-07-29T01:13:38Z","updated_at":"2015-08-11T22:07:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/pulls/182","html_url":"https://github.com/OpenHFT/Chronicle-Queue/pull/182","diff_url":"https://github.com/OpenHFT/Chronicle-Queue/pull/182.diff","patch_url":"https://github.com/OpenHFT/Chronicle-Queue/pull/182.patch"},"body":"This change introduces the concept of a TCP pipeline with the intent of allowing for TCP Handlers to modify data exchange sent during Chronicle Replication.  This allows for handlers to implement features such as throttling and security.  It has also led to the Chronicle replication code being implemented as handlers also.\r\n\r\nSome concepts have been brought forward from Chronicle-Network and included in Chronicle-Queue/chronicle for ease of future integration.  There is, however, additional work required to integrate with Chronicle-Threads.\r\n\r\nExisting test suites have executed successfully."},"comment":{"url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/issues/comments/130092055","html_url":"https://github.com/OpenHFT/Chronicle-Queue/pull/182#issuecomment-130092055","issue_url":"https://api.github.com/repos/OpenHFT/Chronicle-Queue/issues/182","id":130092055,"user":{"login":"peter-lawrey","id":1070321,"avatar_url":"https://avatars.githubusercontent.com/u/1070321?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-lawrey","html_url":"https://github.com/peter-lawrey","followers_url":"https://api.github.com/users/peter-lawrey/followers","following_url":"https://api.github.com/users/peter-lawrey/following{/other_user}","gists_url":"https://api.github.com/users/peter-lawrey/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-lawrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-lawrey/subscriptions","organizations_url":"https://api.github.com/users/peter-lawrey/orgs","repos_url":"https://api.github.com/users/peter-lawrey/repos","events_url":"https://api.github.com/users/peter-lawrey/events{/privacy}","received_events_url":"https://api.github.com/users/peter-lawrey/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T22:07:31Z","updated_at":"2015-08-11T22:07:31Z","body":"Ideally you should use a call back when a connection is lost/gained and you\ndecide how to log it.\n\nPeter.\nOn 11 Aug 2015 11:04 pm, \"Ryan Lea\" <notifications@github.com> wrote:\n\n> Hi Luca,\n>\n> I've just re-run and looked through the tests. That logging seems to align\n> with the tests where reconnection is used, and as a result is an expected\n> log message.\n>\n> It is pretty verbose in the tests though - I wonder whether warn is the\n> most appropriate setting? Although, having said that - I'd like to be\n> warned if my connection was lost.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/OpenHFT/Chronicle-Queue/pull/182#issuecomment-130091390>\n> .\n>\n"}}