{"action":"closed","number":13050,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/13050","id":47168200,"html_url":"https://github.com/angular/angular.js/pull/13050","diff_url":"https://github.com/angular/angular.js/pull/13050.diff","patch_url":"https://github.com/angular/angular.js/pull/13050.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/13050","number":13050,"state":"closed","locked":false,"title":"Do not suggest using a promise as timeout","user":{"login":"darabos","id":1268018,"avatar_url":"https://avatars.githubusercontent.com/u/1268018?v=3","gravatar_id":"","url":"https://api.github.com/users/darabos","html_url":"https://github.com/darabos","followers_url":"https://api.github.com/users/darabos/followers","following_url":"https://api.github.com/users/darabos/following{/other_user}","gists_url":"https://api.github.com/users/darabos/gists{/gist_id}","starred_url":"https://api.github.com/users/darabos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darabos/subscriptions","organizations_url":"https://api.github.com/users/darabos/orgs","repos_url":"https://api.github.com/users/darabos/repos","events_url":"https://api.github.com/users/darabos/events{/privacy}","received_events_url":"https://api.github.com/users/darabos/received_events","type":"User","site_admin":false},"body":"Promises don't work. (#9332) I wish they did, but if they don't at least do not explicitly document that they do.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/angular/angular.js/13050)\n<!-- Reviewable:end -->\n","created_at":"2015-10-08T15:31:07Z","updated_at":"2015-11-24T22:12:21Z","closed_at":"2015-11-24T22:12:21Z","merged_at":null,"merge_commit_sha":"a24fc9c0881a56daf1a24373df53b39f4b9e78b6","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/90","html_url":"https://github.com/angular/angular.js/milestones/1.5.x%20-%20migration-facilitation","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/90/labels","id":1025270,"number":90,"title":"1.5.x - migration-facilitation","description":"","creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":49,"state":"open","created_at":"2015-03-17T12:15:49Z","updated_at":"2015-11-24T22:12:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/13050/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/13050/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/13050/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/33bed80db068b49ac164f8d5fb0a6327374066fb","head":{"label":"darabos:patch-1","ref":"patch-1","sha":"33bed80db068b49ac164f8d5fb0a6327374066fb","user":{"login":"darabos","id":1268018,"avatar_url":"https://avatars.githubusercontent.com/u/1268018?v=3","gravatar_id":"","url":"https://api.github.com/users/darabos","html_url":"https://github.com/darabos","followers_url":"https://api.github.com/users/darabos/followers","following_url":"https://api.github.com/users/darabos/following{/other_user}","gists_url":"https://api.github.com/users/darabos/gists{/gist_id}","starred_url":"https://api.github.com/users/darabos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darabos/subscriptions","organizations_url":"https://api.github.com/users/darabos/orgs","repos_url":"https://api.github.com/users/darabos/repos","events_url":"https://api.github.com/users/darabos/events{/privacy}","received_events_url":"https://api.github.com/users/darabos/received_events","type":"User","site_admin":false},"repo":{"id":43898630,"name":"angular.js","full_name":"darabos/angular.js","owner":{"login":"darabos","id":1268018,"avatar_url":"https://avatars.githubusercontent.com/u/1268018?v=3","gravatar_id":"","url":"https://api.github.com/users/darabos","html_url":"https://github.com/darabos","followers_url":"https://api.github.com/users/darabos/followers","following_url":"https://api.github.com/users/darabos/following{/other_user}","gists_url":"https://api.github.com/users/darabos/gists{/gist_id}","starred_url":"https://api.github.com/users/darabos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darabos/subscriptions","organizations_url":"https://api.github.com/users/darabos/orgs","repos_url":"https://api.github.com/users/darabos/repos","events_url":"https://api.github.com/users/darabos/events{/privacy}","received_events_url":"https://api.github.com/users/darabos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darabos/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/darabos/angular.js","forks_url":"https://api.github.com/repos/darabos/angular.js/forks","keys_url":"https://api.github.com/repos/darabos/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darabos/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darabos/angular.js/teams","hooks_url":"https://api.github.com/repos/darabos/angular.js/hooks","issue_events_url":"https://api.github.com/repos/darabos/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/darabos/angular.js/events","assignees_url":"https://api.github.com/repos/darabos/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/darabos/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/darabos/angular.js/tags","blobs_url":"https://api.github.com/repos/darabos/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darabos/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darabos/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/darabos/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darabos/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/darabos/angular.js/languages","stargazers_url":"https://api.github.com/repos/darabos/angular.js/stargazers","contributors_url":"https://api.github.com/repos/darabos/angular.js/contributors","subscribers_url":"https://api.github.com/repos/darabos/angular.js/subscribers","subscription_url":"https://api.github.com/repos/darabos/angular.js/subscription","commits_url":"https://api.github.com/repos/darabos/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/darabos/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/darabos/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/darabos/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/darabos/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/darabos/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darabos/angular.js/merges","archive_url":"https://api.github.com/repos/darabos/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darabos/angular.js/downloads","issues_url":"https://api.github.com/repos/darabos/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/darabos/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/darabos/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/darabos/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darabos/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/darabos/angular.js/releases{/id}","created_at":"2015-10-08T15:29:23Z","updated_at":"2015-10-08T15:29:43Z","pushed_at":"2015-10-08T15:30:14Z","git_url":"git://github.com/darabos/angular.js.git","ssh_url":"git@github.com:darabos/angular.js.git","clone_url":"https://github.com/darabos/angular.js.git","svn_url":"https://github.com/darabos/angular.js","homepage":"http://angularjs.org","size":72171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"964a901bd827656cb5eee36d7a204f738d22647b","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2015-11-24T21:40:54Z","pushed_at":"2015-11-24T22:11:44Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":140273,"stargazers_count":44518,"watchers_count":44518,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20351,"mirror_url":null,"open_issues_count":1251,"forks":20351,"open_issues":1251,"watchers":44518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13050"},"html":{"href":"https://github.com/angular/angular.js/pull/13050"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/13050"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/13050/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13050/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13050/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/33bed80db068b49ac164f8d5fb0a6327374066fb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}