{"action":"created","comment":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments/36854226","id":36854226,"diff_hunk":"@@ -106,27 +106,31 @@ def make_class(self):\n         self.curves = [ {\"label\" : c['label'], \"equation_formatted\" : list_to_min_eqn(c['min_eqn']), \"url\": url_for_label(c['label'])} for c in curves_data ]\n         self.ncurves = curves_data.count()\n         self.bad_lfactors = [ [c[0], list_to_factored_poly_otherorder(c[1])] for c in self.bad_lfactors]\n-        for endalgtype in ['end_alg', 'rat_end_alg', 'real_end_alg', 'geom_end_alg', 'rat_geom_end_alg', 'real_geom_end_alg']:\n+        ## duplication of get_end_alg.  need to clean up!\n+        end_alg_title_dict = {'end_ring': '\\\\mathrm{End}(J)', \n+                              'rat_end_alg': '\\\\mathrm{End}(J) \\\\otimes \\\\Q',\n+                              'real_end_alg': '\\\\mathrm{End}(J) \\otimes \\R',","path":"lmfdb/genus2_curves/isog_class.py","position":null,"original_position":17,"commit_id":"0ff3ed98562637883b65fe6b61e2eea157ca9022","original_commit_id":"b56530cfb95daed7accc714f86d8d214c58042f9","user":{"login":"davidfarmer","id":211500,"avatar_url":"https://avatars.githubusercontent.com/u/211500?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfarmer","html_url":"https://github.com/davidfarmer","followers_url":"https://api.github.com/users/davidfarmer/followers","following_url":"https://api.github.com/users/davidfarmer/following{/other_user}","gists_url":"https://api.github.com/users/davidfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfarmer/subscriptions","organizations_url":"https://api.github.com/users/davidfarmer/orgs","repos_url":"https://api.github.com/users/davidfarmer/repos","events_url":"https://api.github.com/users/davidfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/davidfarmer/received_events","type":"User","site_admin":false},"body":"\nThis knowl lists the \"official\" LaTeX macros currently\nsupported for use anywhere in the LMFDB:\n\nhttp://beta.lmfdb.org/knowledge/show/doc.macros\n\nFor example, the operator \\End .\n\n","created_at":"2015-08-12T12:38:53Z","updated_at":"2015-08-12T12:38:53Z","html_url":"https://github.com/LMFDB/lmfdb/pull/325#discussion_r36854226","pull_request_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325","_links":{"self":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments/36854226"},"html":{"href":"https://github.com/LMFDB/lmfdb/pull/325#discussion_r36854226"},"pull_request":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325","id":42130261,"html_url":"https://github.com/LMFDB/lmfdb/pull/325","diff_url":"https://github.com/LMFDB/lmfdb/pull/325.diff","patch_url":"https://github.com/LMFDB/lmfdb/pull/325.patch","issue_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/325","number":325,"state":"open","locked":false,"title":"fixed bug.  made end_alg table in isogeny class look like curve page.","user":{"login":"danyasaki","id":7796860,"avatar_url":"https://avatars.githubusercontent.com/u/7796860?v=3","gravatar_id":"","url":"https://api.github.com/users/danyasaki","html_url":"https://github.com/danyasaki","followers_url":"https://api.github.com/users/danyasaki/followers","following_url":"https://api.github.com/users/danyasaki/following{/other_user}","gists_url":"https://api.github.com/users/danyasaki/gists{/gist_id}","starred_url":"https://api.github.com/users/danyasaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danyasaki/subscriptions","organizations_url":"https://api.github.com/users/danyasaki/orgs","repos_url":"https://api.github.com/users/danyasaki/repos","events_url":"https://api.github.com/users/danyasaki/events{/privacy}","received_events_url":"https://api.github.com/users/danyasaki/received_events","type":"User","site_admin":false},"body":"Fixed the bug John found.  Modified the code so that the behavior of the end_alg table on the isogeny class page mimics the curves page.  Code for curve and isogeny class is kept separate for now, but might be better to consolidate later.\r\nSee \r\nhttp://127.0.0.1:37777/Genus2Curve/Q/1152/a/147456/1\r\nhttp://127.0.0.1:37777/Genus2Curve/Q/1152/a/","created_at":"2015-08-11T13:46:24Z","updated_at":"2015-08-12T12:38:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4f3eba17d8cac6cac1dfc7843ba976338a5758a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325/commits","review_comments_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325/comments","review_comment_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/325/comments","statuses_url":"https://api.github.com/repos/LMFDB/lmfdb/statuses/0ff3ed98562637883b65fe6b61e2eea157ca9022","head":{"label":"danyasaki:genus2-bugfix","ref":"genus2-bugfix","sha":"0ff3ed98562637883b65fe6b61e2eea157ca9022","user":{"login":"danyasaki","id":7796860,"avatar_url":"https://avatars.githubusercontent.com/u/7796860?v=3","gravatar_id":"","url":"https://api.github.com/users/danyasaki","html_url":"https://github.com/danyasaki","followers_url":"https://api.github.com/users/danyasaki/followers","following_url":"https://api.github.com/users/danyasaki/following{/other_user}","gists_url":"https://api.github.com/users/danyasaki/gists{/gist_id}","starred_url":"https://api.github.com/users/danyasaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danyasaki/subscriptions","organizations_url":"https://api.github.com/users/danyasaki/orgs","repos_url":"https://api.github.com/users/danyasaki/repos","events_url":"https://api.github.com/users/danyasaki/events{/privacy}","received_events_url":"https://api.github.com/users/danyasaki/received_events","type":"User","site_admin":false},"repo":{"id":32023525,"name":"lmfdb","full_name":"danyasaki/lmfdb","owner":{"login":"danyasaki","id":7796860,"avatar_url":"https://avatars.githubusercontent.com/u/7796860?v=3","gravatar_id":"","url":"https://api.github.com/users/danyasaki","html_url":"https://github.com/danyasaki","followers_url":"https://api.github.com/users/danyasaki/followers","following_url":"https://api.github.com/users/danyasaki/following{/other_user}","gists_url":"https://api.github.com/users/danyasaki/gists{/gist_id}","starred_url":"https://api.github.com/users/danyasaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danyasaki/subscriptions","organizations_url":"https://api.github.com/users/danyasaki/orgs","repos_url":"https://api.github.com/users/danyasaki/repos","events_url":"https://api.github.com/users/danyasaki/events{/privacy}","received_events_url":"https://api.github.com/users/danyasaki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danyasaki/lmfdb","description":"L-Functions and Modular Forms Database","fork":true,"url":"https://api.github.com/repos/danyasaki/lmfdb","forks_url":"https://api.github.com/repos/danyasaki/lmfdb/forks","keys_url":"https://api.github.com/repos/danyasaki/lmfdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danyasaki/lmfdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danyasaki/lmfdb/teams","hooks_url":"https://api.github.com/repos/danyasaki/lmfdb/hooks","issue_events_url":"https://api.github.com/repos/danyasaki/lmfdb/issues/events{/number}","events_url":"https://api.github.com/repos/danyasaki/lmfdb/events","assignees_url":"https://api.github.com/repos/danyasaki/lmfdb/assignees{/user}","branches_url":"https://api.github.com/repos/danyasaki/lmfdb/branches{/branch}","tags_url":"https://api.github.com/repos/danyasaki/lmfdb/tags","blobs_url":"https://api.github.com/repos/danyasaki/lmfdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danyasaki/lmfdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danyasaki/lmfdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/danyasaki/lmfdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danyasaki/lmfdb/statuses/{sha}","languages_url":"https://api.github.com/repos/danyasaki/lmfdb/languages","stargazers_url":"https://api.github.com/repos/danyasaki/lmfdb/stargazers","contributors_url":"https://api.github.com/repos/danyasaki/lmfdb/contributors","subscribers_url":"https://api.github.com/repos/danyasaki/lmfdb/subscribers","subscription_url":"https://api.github.com/repos/danyasaki/lmfdb/subscription","commits_url":"https://api.github.com/repos/danyasaki/lmfdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/danyasaki/lmfdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/danyasaki/lmfdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/danyasaki/lmfdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/danyasaki/lmfdb/contents/{+path}","compare_url":"https://api.github.com/repos/danyasaki/lmfdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danyasaki/lmfdb/merges","archive_url":"https://api.github.com/repos/danyasaki/lmfdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danyasaki/lmfdb/downloads","issues_url":"https://api.github.com/repos/danyasaki/lmfdb/issues{/number}","pulls_url":"https://api.github.com/repos/danyasaki/lmfdb/pulls{/number}","milestones_url":"https://api.github.com/repos/danyasaki/lmfdb/milestones{/number}","notifications_url":"https://api.github.com/repos/danyasaki/lmfdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danyasaki/lmfdb/labels{/name}","releases_url":"https://api.github.com/repos/danyasaki/lmfdb/releases{/id}","created_at":"2015-03-11T14:55:56Z","updated_at":"2015-03-23T15:42:52Z","pushed_at":"2015-08-12T12:38:10Z","git_url":"git://github.com/danyasaki/lmfdb.git","ssh_url":"git@github.com:danyasaki/lmfdb.git","clone_url":"https://github.com/danyasaki/lmfdb.git","svn_url":"https://github.com/danyasaki/lmfdb","homepage":null,"size":14294,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LMFDB:master","ref":"master","sha":"c67ac086605520b6f24ce9442efa5d4c6f1a41ec","user":{"login":"LMFDB","id":3043016,"avatar_url":"https://avatars.githubusercontent.com/u/3043016?v=3","gravatar_id":"","url":"https://api.github.com/users/LMFDB","html_url":"https://github.com/LMFDB","followers_url":"https://api.github.com/users/LMFDB/followers","following_url":"https://api.github.com/users/LMFDB/following{/other_user}","gists_url":"https://api.github.com/users/LMFDB/gists{/gist_id}","starred_url":"https://api.github.com/users/LMFDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMFDB/subscriptions","organizations_url":"https://api.github.com/users/LMFDB/orgs","repos_url":"https://api.github.com/users/LMFDB/repos","events_url":"https://api.github.com/users/LMFDB/events{/privacy}","received_events_url":"https://api.github.com/users/LMFDB/received_events","type":"Organization","site_admin":false},"repo":{"id":7166369,"name":"lmfdb","full_name":"LMFDB/lmfdb","owner":{"login":"LMFDB","id":3043016,"avatar_url":"https://avatars.githubusercontent.com/u/3043016?v=3","gravatar_id":"","url":"https://api.github.com/users/LMFDB","html_url":"https://github.com/LMFDB","followers_url":"https://api.github.com/users/LMFDB/followers","following_url":"https://api.github.com/users/LMFDB/following{/other_user}","gists_url":"https://api.github.com/users/LMFDB/gists{/gist_id}","starred_url":"https://api.github.com/users/LMFDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMFDB/subscriptions","organizations_url":"https://api.github.com/users/LMFDB/orgs","repos_url":"https://api.github.com/users/LMFDB/repos","events_url":"https://api.github.com/users/LMFDB/events{/privacy}","received_events_url":"https://api.github.com/users/LMFDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMFDB/lmfdb","description":"L-Functions and Modular Forms Database","fork":false,"url":"https://api.github.com/repos/LMFDB/lmfdb","forks_url":"https://api.github.com/repos/LMFDB/lmfdb/forks","keys_url":"https://api.github.com/repos/LMFDB/lmfdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMFDB/lmfdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMFDB/lmfdb/teams","hooks_url":"https://api.github.com/repos/LMFDB/lmfdb/hooks","issue_events_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/events{/number}","events_url":"https://api.github.com/repos/LMFDB/lmfdb/events","assignees_url":"https://api.github.com/repos/LMFDB/lmfdb/assignees{/user}","branches_url":"https://api.github.com/repos/LMFDB/lmfdb/branches{/branch}","tags_url":"https://api.github.com/repos/LMFDB/lmfdb/tags","blobs_url":"https://api.github.com/repos/LMFDB/lmfdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMFDB/lmfdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMFDB/lmfdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMFDB/lmfdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMFDB/lmfdb/statuses/{sha}","languages_url":"https://api.github.com/repos/LMFDB/lmfdb/languages","stargazers_url":"https://api.github.com/repos/LMFDB/lmfdb/stargazers","contributors_url":"https://api.github.com/repos/LMFDB/lmfdb/contributors","subscribers_url":"https://api.github.com/repos/LMFDB/lmfdb/subscribers","subscription_url":"https://api.github.com/repos/LMFDB/lmfdb/subscription","commits_url":"https://api.github.com/repos/LMFDB/lmfdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMFDB/lmfdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMFDB/lmfdb/contents/{+path}","compare_url":"https://api.github.com/repos/LMFDB/lmfdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMFDB/lmfdb/merges","archive_url":"https://api.github.com/repos/LMFDB/lmfdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMFDB/lmfdb/downloads","issues_url":"https://api.github.com/repos/LMFDB/lmfdb/issues{/number}","pulls_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls{/number}","milestones_url":"https://api.github.com/repos/LMFDB/lmfdb/milestones{/number}","notifications_url":"https://api.github.com/repos/LMFDB/lmfdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMFDB/lmfdb/labels{/name}","releases_url":"https://api.github.com/repos/LMFDB/lmfdb/releases{/id}","created_at":"2012-12-14T14:09:00Z","updated_at":"2015-08-06T17:57:53Z","pushed_at":"2015-08-12T12:38:10Z","git_url":"git://github.com/LMFDB/lmfdb.git","ssh_url":"git@github.com:LMFDB/lmfdb.git","clone_url":"https://github.com/LMFDB/lmfdb.git","svn_url":"https://github.com/LMFDB/lmfdb","homepage":null,"size":16700,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":44,"forks":58,"open_issues":44,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325"},"html":{"href":"https://github.com/LMFDB/lmfdb/pull/325"},"issue":{"href":"https://api.github.com/repos/LMFDB/lmfdb/issues/325"},"comments":{"href":"https://api.github.com/repos/LMFDB/lmfdb/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/LMFDB/lmfdb/statuses/0ff3ed98562637883b65fe6b61e2eea157ca9022"}}}}