{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/45721132","id":45721132,"diff_hunk":"@@ -877,9 +877,9 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)\n \n     // -mempoollimit limits\n     int64_t nMempoolSizeLimit = GetArg(\"-maxmempool\", DEFAULT_MAX_MEMPOOL_SIZE) * 1000000;\n-    int64_t nMempoolDescendantSizeLimit = GetArg(\"-limitdescendantsize\", DEFAULT_DESCENDANT_SIZE_LIMIT) * 1000;\n-    if (nMempoolSizeLimit < 0 || nMempoolSizeLimit < nMempoolDescendantSizeLimit * 40)\n-        return InitError(strprintf(_(\"-maxmempool must be at least %d MB\"), GetArg(\"-limitdescendantsize\", DEFAULT_DESCENDANT_SIZE_LIMIT) / 25));\n+    int64_t nMempoolDescendantSizeLimit = GetArg(\"-limitdescendantsize\", DEFAULT_DESCENDANT_SIZE_LIMIT) * 1000 * 40;\n+    if (nMempoolSizeLimit < 0 || nMempoolSizeLimit < nMempoolDescendantSizeLimit)","path":"src/init.cpp","position":8,"original_position":8,"commit_id":"fa65c353b12ec2ff094747966a0a8ee7d16c2c7f","original_commit_id":"fa65c353b12ec2ff094747966a0a8ee7d16c2c7f","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"Can nMempoolDescendantSizeLimit be (usefully) negative? Otherwise it makes little sense to compare against both 0 and that value.","created_at":"2015-11-24T11:00:03Z","updated_at":"2015-11-24T11:00:03Z","html_url":"https://github.com/bitcoin/bitcoin/pull/7069#discussion_r45721132","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/45721132"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7069#discussion_r45721132"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069","id":51355963,"html_url":"https://github.com/bitcoin/bitcoin/pull/7069","diff_url":"https://github.com/bitcoin/bitcoin/pull/7069.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7069.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7069","number":7069,"state":"open","locked":false,"title":"[trivial] Fix -maxmempool InitError","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"`-maxmempool` is integer so we need to pass `std::ceil( $minimum )`","created_at":"2015-11-20T13:27:35Z","updated_at":"2015-11-24T11:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62b7e5c5a6833370ac5d48df68a4c07623980b4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7069/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa65c353b12ec2ff094747966a0a8ee7d16c2c7f","head":{"label":"MarcoFalke:MarcoFalke-2015-maxmempoolInitError","ref":"MarcoFalke-2015-maxmempoolInitError","sha":"fa65c353b12ec2ff094747966a0a8ee7d16c2c7f","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"repo":{"id":40046254,"name":"bitcoin","full_name":"MarcoFalke/bitcoin","owner":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcoFalke/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/MarcoFalke/bitcoin","forks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/forks","keys_url":"https://api.github.com/repos/MarcoFalke/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcoFalke/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcoFalke/bitcoin/teams","hooks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/events","assignees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/MarcoFalke/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/tags","blobs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcoFalke/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcoFalke/bitcoin/languages","stargazers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscription","commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/MarcoFalke/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcoFalke/bitcoin/merges","archive_url":"https://api.github.com/repos/MarcoFalke/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcoFalke/bitcoin/downloads","issues_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/MarcoFalke/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcoFalke/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcoFalke/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcoFalke/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/MarcoFalke/bitcoin/releases{/id}","created_at":"2015-08-01T12:42:47Z","updated_at":"2015-09-13T21:36:54Z","pushed_at":"2015-11-24T10:56:12Z","git_url":"git://github.com/MarcoFalke/bitcoin.git","ssh_url":"git@github.com:MarcoFalke/bitcoin.git","clone_url":"https://github.com/MarcoFalke/bitcoin.git","svn_url":"https://github.com/MarcoFalke/bitcoin","homepage":"https://bitcoin.org/en/download","size":60831,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"02a0f348c210af4054a3ae5a04d356b429349ebb","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-11-24T08:59:15Z","pushed_at":"2015-11-24T10:56:18Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":100554,"stargazers_count":7856,"watchers_count":7856,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5406,"mirror_url":null,"open_issues_count":431,"forks":5406,"open_issues":431,"watchers":7856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7069"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7069"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7069/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7069/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa65c353b12ec2ff094747966a0a8ee7d16c2c7f"}}}}