{"action":"created","issue":{"url":"https://api.github.com/repos/pieroxy/lz-string/issues/48","labels_url":"https://api.github.com/repos/pieroxy/lz-string/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/pieroxy/lz-string/issues/48/comments","events_url":"https://api.github.com/repos/pieroxy/lz-string/issues/48/events","html_url":"https://github.com/pieroxy/lz-string/pull/48","id":61788439,"number":48,"title":"Build leaking strings with push/join instead of string concatenation.","user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars.githubusercontent.com/u/291301?v=3","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-03-15T10:24:10Z","updated_at":"2015-03-15T20:27:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pieroxy/lz-string/pulls/48","html_url":"https://github.com/pieroxy/lz-string/pull/48","diff_url":"https://github.com/pieroxy/lz-string/pull/48.diff","patch_url":"https://github.com/pieroxy/lz-string/pull/48.patch"},"body":"This solves #46.\r\n\r\nI haven't updated lz-string.min.js, there is no build script."},"comment":{"url":"https://api.github.com/repos/pieroxy/lz-string/issues/comments/81226348","html_url":"https://github.com/pieroxy/lz-string/pull/48#issuecomment-81226348","issue_url":"https://api.github.com/repos/pieroxy/lz-string/issues/48","id":81226348,"user":{"login":"pieroxy","id":1426854,"avatar_url":"https://avatars.githubusercontent.com/u/1426854?v=3","gravatar_id":"","url":"https://api.github.com/users/pieroxy","html_url":"https://github.com/pieroxy","followers_url":"https://api.github.com/users/pieroxy/followers","following_url":"https://api.github.com/users/pieroxy/following{/other_user}","gists_url":"https://api.github.com/users/pieroxy/gists{/gist_id}","starred_url":"https://api.github.com/users/pieroxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieroxy/subscriptions","organizations_url":"https://api.github.com/users/pieroxy/orgs","repos_url":"https://api.github.com/users/pieroxy/repos","events_url":"https://api.github.com/users/pieroxy/events{/privacy}","received_events_url":"https://api.github.com/users/pieroxy/received_events","type":"User","site_admin":false},"created_at":"2015-03-15T20:27:29Z","updated_at":"2015-03-15T20:27:29Z","body":"First, about your use case. Of course, I generally advise people to turn on gzip compression when sending stuff from the server to the client. But even then, you were in the exact same use case as my initial jsperf: Compress a string, send it to the network and throw it away. I don't see the problem of having string bigger than what they represent here.\r\n\r\nAbout your jsperf. Well, strings are consistently faster with `+=` in your jsperf ;-) But don't worry I get the issue. I'm just think\r\n\r\nIn particular, this jsperf is making me doubt about the pertinence of this patch for in-browsers lz-string usages.\r\n\r\nBut now that I understand your issue, I'll try to think of something to mitigate"}}