{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/tsd/issues/218","labels_url":"https://api.github.com/repos/DefinitelyTyped/tsd/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/tsd/issues/218/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/tsd/issues/218/events","html_url":"https://github.com/DefinitelyTyped/tsd/pull/218","id":107622211,"number":218,"title":"Eliminate implicit property ordering for cache key","user":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-22T00:06:42Z","updated_at":"2015-09-22T00:54:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/tsd/pulls/218","html_url":"https://github.com/DefinitelyTyped/tsd/pull/218","diff_url":"https://github.com/DefinitelyTyped/tsd/pull/218.diff","patch_url":"https://github.com/DefinitelyTyped/tsd/pull/218.patch"},"body":"There is an implicit ordering of setting properties and the invocation\r\nof base class methods in order for GithubLoader to properly initialize\r\nitself with the appropriate cache key.  This change removes that\r\nimplicit ordering and passes, explicitly, the cache key string value to\r\nthe `GithubLoader::_initGithubLoader` method.\r\n\r\nNote that I am working towards taking care of #186, but in order to do so, I need to make some incremental changes along the way."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/tsd/issues/comments/142148983","html_url":"https://github.com/DefinitelyTyped/tsd/pull/218#issuecomment-142148983","issue_url":"https://api.github.com/repos/DefinitelyTyped/tsd/issues/218","id":142148983,"user":{"login":"Diullei","id":373936,"avatar_url":"https://avatars.githubusercontent.com/u/373936?v=3","gravatar_id":"","url":"https://api.github.com/users/Diullei","html_url":"https://github.com/Diullei","followers_url":"https://api.github.com/users/Diullei/followers","following_url":"https://api.github.com/users/Diullei/following{/other_user}","gists_url":"https://api.github.com/users/Diullei/gists{/gist_id}","starred_url":"https://api.github.com/users/Diullei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diullei/subscriptions","organizations_url":"https://api.github.com/users/Diullei/orgs","repos_url":"https://api.github.com/users/Diullei/repos","events_url":"https://api.github.com/users/Diullei/events{/privacy}","received_events_url":"https://api.github.com/users/Diullei/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T00:54:49Z","updated_at":"2015-09-22T00:54:49Z","body":"@ericvw I'm solving this test. This is not with your implementation."}}