{"action":"created","comment":{"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/comments/44425880","id":44425880,"diff_hunk":"@@ -71,6 +109,27 @@\n {% block javascript %}\n <script>\n     $(document).ready(function(){\n+\n+        // only show the more button if there are more than 3 rows\n+        var rowCount = $('#select-site-table tr').length;\n+        if(rowCount <= 3) {","path":"isites_migration/templates/isites_migration/index.html","position":114,"original_position":114,"commit_id":"d8a9a49f503adb6d69c811648d69eb2ebca0d31e","original_commit_id":"d8a9a49f503adb6d69c811648d69eb2ebca0d31e","user":{"login":"elliottyates","id":8975317,"avatar_url":"https://avatars.githubusercontent.com/u/8975317?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":"(might avoid flickering issues)","created_at":"2015-11-10T16:13:38Z","updated_at":"2015-11-10T16:13:38Z","html_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools/pull/10#discussion_r44425880","pull_request_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/comments/44425880"},"html":{"href":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools/pull/10#discussion_r44425880"},"pull_request":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10","id":50181476,"html_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools/pull/10","diff_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools/pull/10.diff","patch_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools/pull/10.patch","issue_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/10","number":10,"state":"open","locked":false,"title":"Task/eparker71/tlt 2098 display more info for isites content import","user":{"login":"eparker71","id":1084287,"avatar_url":"https://avatars.githubusercontent.com/u/1084287?v=3","gravatar_id":"","url":"https://api.github.com/users/eparker71","html_url":"https://github.com/eparker71","followers_url":"https://api.github.com/users/eparker71/followers","following_url":"https://api.github.com/users/eparker71/following{/other_user}","gists_url":"https://api.github.com/users/eparker71/gists{/gist_id}","starred_url":"https://api.github.com/users/eparker71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparker71/subscriptions","organizations_url":"https://api.github.com/users/eparker71/orgs","repos_url":"https://api.github.com/users/eparker71/repos","events_url":"https://api.github.com/users/eparker71/events{/privacy}","received_events_url":"https://api.github.com/users/eparker71/received_events","type":"User","site_admin":false},"body":"Jira ticket: https://jira.huit.harvard.edu/browse/TLT-2098\r\n\r\nPlaces to look harder:\r\nthe method get_previous_isites on line 160 of utils.py\r\nthe form \"form-inline\" on line 43 of index.html\r\n\r\nThis PR contains updates to the isites_migration tool. There are some text and UI edits along with some logic changes. The main logic change can be found in the file utils file in the method get_previous_isites.\r\nThis method used to be called \"get_previous_isites_keywords\", I changed to get_previous_isites as the nature of the data returned changed. The method now builds a dict for each isite found that contains the following:\r\n\r\n{\r\n    \"keyword\" : \"k12345\",\r\n    \"title\": \"this is some course\",\r\n    \"term\": \"Fall 2015\",\r\n    \"calendar_year\": 2005\r\n}\r\n\r\nThe last column calendar year, is only there for sorting purposes. The rest of the data is now being displayed in the UI. \r\n\r\nPer the ticket, the drop down select input field has been replaced with a table that contains the info above. The form inputs are now radio buttons.\r\n\r\nOn first display, the table will only show 3 rows. If the table has more than 3 rows a \"more\" button will be displayed below the table. If the \"more\" button is clicked, a \"less\" button will be displayed. \r\n\r\nTo pass the title and term values as hidden fields, I place the data on the radio button using the html data attribute. Then in javascript when a user clicks a radio button the hidden fields are updated with the correct values for the selected radio option. \r\n","created_at":"2015-11-09T21:39:29Z","updated_at":"2015-11-10T16:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"707bb9330242bf8a3a8e13df020a9382b0c3f96f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/10/comments","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/statuses/d8a9a49f503adb6d69c811648d69eb2ebca0d31e","head":{"label":"Harvard-University-iCommons:task/eparker71/TLT-2098-display-more-info-for-isites-content-import","ref":"task/eparker71/TLT-2098-display-more-info-for-isites-content-import","sha":"d8a9a49f503adb6d69c811648d69eb2ebca0d31e","user":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":42180115,"name":"canvas_course_admin_tools","full_name":"Harvard-University-iCommons/canvas_course_admin_tools","owner":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools","description":"","fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/releases{/id}","created_at":"2015-09-09T13:29:40Z","updated_at":"2015-09-29T13:23:36Z","pushed_at":"2015-11-10T15:44:12Z","git_url":"git://github.com/Harvard-University-iCommons/canvas_course_admin_tools.git","ssh_url":"git@github.com:Harvard-University-iCommons/canvas_course_admin_tools.git","clone_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools.git","svn_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools","homepage":null,"size":352,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Harvard-University-iCommons:develop","ref":"develop","sha":"e6521ee55df712c42d15193bc6c958d48cbc7939","user":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":42180115,"name":"canvas_course_admin_tools","full_name":"Harvard-University-iCommons/canvas_course_admin_tools","owner":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools","description":"","fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/releases{/id}","created_at":"2015-09-09T13:29:40Z","updated_at":"2015-09-29T13:23:36Z","pushed_at":"2015-11-10T15:44:12Z","git_url":"git://github.com/Harvard-University-iCommons/canvas_course_admin_tools.git","ssh_url":"git@github.com:Harvard-University-iCommons/canvas_course_admin_tools.git","clone_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools.git","svn_url":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools","homepage":null,"size":352,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10"},"html":{"href":"https://github.com/Harvard-University-iCommons/canvas_course_admin_tools/pull/10"},"issue":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/10"},"comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_course_admin_tools/statuses/d8a9a49f503adb6d69c811648d69eb2ebca0d31e"}}}}