{"push_id":546484807,"size":1000,"distinct_size":421,"ref":"refs/heads/master","head":"6a6d9c38050b5306afdccc6b3f242135603be930","before":"5e6c089b710681bbd7248f42c712c10c89f85be5","commits":[{"sha":"92c8dfb5e667df360e23b70dfcaba653bba6b8f4","author":{"email":"5dfbe9b445699acac9aa29de802dd6e20815f6e1@ibuildings.nl","name":"Reinier Kip"},"message":"[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/92c8dfb5e667df360e23b70dfcaba653bba6b8f4"},{"sha":"226b0ce66904f78d9c5af48250713fc5e181e626","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #12296 [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners (rjkip)\n\nThis PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12296).\n\nDiscussion\n----------\n\n[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | when relying on this configuration behaviour\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #12261\n| License       | MIT\n| Doc PR        | —\n\nSee symfony/symfony#12261.\n\nI configured a different firewall entry point for one firewall. However, when authentication had to be performed, it still called BasicAuthenticationEntryPoint::start() instead of my service's start(). My service was instantiated, yet never used.\n\nThe issue appears to be that the entry point is registered with the firewall's exception listener, but not with the BasicAuthenticationListener. This means that when the BasicAuthenticationListener determines the user has  provided wrong credentials, BasicAuthenticationEntryPoint is still used. Only in case of an exception would my  entry point service be used.\n\nIn my opinion, this is not correct behaviour. Can someone confirm this? Are there currently tests that pertain to the `entry_point` configuration on which I can base a test?\n\n---\n\nTest setup:\n\n```yaml\n# security.yml\nsecurity:\n    firewalls:\n        api:\n            pattern: ^/api/\n            http_basic: ~\n            entry_point: my.service\n        default:\n            anonymous: ~\n```\n\nCommits\n-------\n\n92c8dfb [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/226b0ce66904f78d9c5af48250713fc5e181e626"},{"sha":"30bde8961effb7cb5ff76d6ef83f130327f35931","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #12525 [Bundle][FrameworkBundle] be smarter when guessing the document root (xabbuh)\n\nThis PR was merged into the 2.3 branch.\n\nDiscussion\n----------\n\n[Bundle][FrameworkBundle] be smarter when guessing the document root\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #12524\n| License       | MIT\n| Doc PR        |\n\nCommits\n-------\n\ne28f5b8 be smarter when guessing the document root","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/30bde8961effb7cb5ff76d6ef83f130327f35931"},{"sha":"8871368ca3b41658103975039918ad42bda88559","author":{"email":"638e8f0171575864326f06d2a5f8e72287427b15@znerol.ch","name":"Lorenz Schori"},"message":"Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/8871368ca3b41658103975039918ad42bda88559"},{"sha":"10e208b9e7e17906905c0759a6007b42719d392b","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #12131 Extract an AbstractEventDispatcherTest from EventDispatcherTest (znerol)\n\nThis PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12131).\n\nDiscussion\n----------\n\nExtract an AbstractEventDispatcherTest from EventDispatcherTest\n\nAllow third party implementations of `EventDispatcherInterface` to reuse the `EventDispatcherTest` unit tests. Also instantly expand test coverage of `ContainerAwareEventDispatcher` by rebasing it onto the new `AbstractEventDispatcherTest`.\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | no\n| New feature?  | yes\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\n8871368 Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/10e208b9e7e17906905c0759a6007b42719d392b"},{"sha":"891ebe594ef895f54211956fd2f2304762ee800f","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"Merge branch '2.3' into 2.5\n\n* 2.3:\n  [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners\n  be smarter when guessing the document root\n  Azerbaijani locale\n  Fixed grammar error in docblock\n  Adjust upgrade file rendering\n  [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions\n  compare version using PHP_VERSION_ID\n  [Form] Add doc for FormEvents\n  don't override internal PHP constants\n\nConflicts:\n\tUPGRADE-3.0.md\n\tsrc/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php\n\tsrc/Symfony/Component/Debug/ErrorHandler.php\n\tsrc/Symfony/Component/HttpFoundation/Response.php","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/891ebe594ef895f54211956fd2f2304762ee800f"},{"sha":"f288a69ae5faccaccb798ca24b681e73657339d5","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"Merge branch '2.5' into 2.6\n\n* 2.5:\n  [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners\n  be smarter when guessing the document root\n  Azerbaijani locale\n  Fixed grammar error in docblock\n  Adjust upgrade file rendering\n  [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions\n  compare version using PHP_VERSION_ID\n  [Form] Add doc for FormEvents\n  don't override internal PHP constants\n  [Session] Fix parameter names in WriteCheckSessionHandler\n  Add consistency with request type checking\n  [FrameworkBundle] Fix server run in case the router script does not exist\n\nConflicts:\n\tcomposer.json\n\tsrc/Symfony/Component/Debug/ErrorHandler.php\n\tsrc/Symfony/Component/Debug/ExceptionHandler.php","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/f288a69ae5faccaccb798ca24b681e73657339d5"},{"sha":"6a63cc5fc75a41adc731263ff0de743165532a7b","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"Merge branch '2.6' into 2.7\n\n* 2.6:\n  Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest\n  [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners\n  be smarter when guessing the document root\n  Azerbaijani locale\n  Fixed grammar error in docblock\n  [HttpKernel] fix parse error in DumpDataCollector\n  [TwigBundle/DebugBundle] move dump extension & cleanups\n  Adjust upgrade file rendering\n  [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions\n  compare version using PHP_VERSION_ID\n  [Form] Add doc for FormEvents\n  *_timezone changes also affect the BirthdayType\n  don't override internal PHP constants\n  Drop support for model_timezone and view_timezone options in TimeType and DateType.\n  [DomCrawler] Added support for link tags in the Link class\n  [Session] Fix parameter names in WriteCheckSessionHandler\n  Add consistency with request type checking\n  [FrameworkBundle] Fix server run in case the router script does not exist","distinct":true,"url":"https://api.github.com/repos/csarrazi/symfony/commits/6a63cc5fc75a41adc731263ff0de743165532a7b"},{"sha":"1277c49612f147150e8399aa5ef2a3ddc3564361","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"Merge branch '2.7'\n\n* 2.7:\n  Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest\n  [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners\n  be smarter when guessing the document root\n  Azerbaijani locale\n  Fixed grammar error in docblock\n  [HttpKernel] fix parse error in DumpDataCollector\n  [TwigBundle/DebugBundle] move dump extension & cleanups\n  Adjust upgrade file rendering\n  [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions\n  compare version using PHP_VERSION_ID\n  [Form] Add doc for FormEvents\n  *_timezone changes also affect the BirthdayType\n  don't override internal PHP constants\n  Drop support for model_timezone and view_timezone options in TimeType and DateType.\n  [DomCrawler] Added support for link tags in the Link class\n  [Session] Fix parameter names in WriteCheckSessionHandler\n  Add consistency with request type checking\n  [FrameworkBundle] Fix server run in case the router script does not exist","distinct":true,"url":"https://api.github.com/repos/csarrazi/symfony/commits/1277c49612f147150e8399aa5ef2a3ddc3564361"},{"sha":"2c83825136407f8e76fb129d88e04b763e2df7f7","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated CHANGELOG for 2.3.22","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/2c83825136407f8e76fb129d88e04b763e2df7f7"},{"sha":"66f194ef85a14fb25762f1e8f36752a03a18f99d","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"update CONTRIBUTORS for 2.3.22","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/66f194ef85a14fb25762f1e8f36752a03a18f99d"},{"sha":"ace20d48857e640572e0310206e3173f2d829be1","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated VERSION for 2.3.22","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/ace20d48857e640572e0310206e3173f2d829be1"},{"sha":"2f59c8df55b2273565e8898373ebc38457c10c32","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"fixed typo","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/2f59c8df55b2273565e8898373ebc38457c10c32"},{"sha":"580de752494109d1cdb084b4e093c096a1cbcabc","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bumped Symfony version to 2.3.23","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/580de752494109d1cdb084b4e093c096a1cbcabc"},{"sha":"34b5f71d5850553ccd7e27c7d391be8bcb3f3a48","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated CHANGELOG for 2.5.7","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/34b5f71d5850553ccd7e27c7d391be8bcb3f3a48"},{"sha":"3e1f6a305779e51485533338783597c138fc3979","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"update CONTRIBUTORS for 2.5.7","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/3e1f6a305779e51485533338783597c138fc3979"},{"sha":"dd4254fc39a702af22cd886a6790769541469da1","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated VERSION for 2.5.7","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/dd4254fc39a702af22cd886a6790769541469da1"},{"sha":"9500411c9aa8d8c8b03a76a5d3bbf28719dfc542","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bumped Symfony version to 2.5.8","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/9500411c9aa8d8c8b03a76a5d3bbf28719dfc542"},{"sha":"76273bf4592ce4cc2bb48a46022801cffe7998cc","author":{"email":"5199305ec67cbc516698fe37247f0717af2ab4c9@yandex.ru","name":"Strate"},"message":"[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/76273bf4592ce4cc2bb48a46022801cffe7998cc"},{"sha":"ce3682190c287cf1efd7d9b412e684586515cba2","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #12137 [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data (Strate)\n\nThis PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #12137).\n\nDiscussion\n----------\n\n[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #12110\n| License       | MIT\n\nTest and fix of ticket #12110\n\nCommits\n-------\n\n76273bf [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data","distinct":false,"url":"https://api.github.com/repos/csarrazi/symfony/commits/ce3682190c287cf1efd7d9b412e684586515cba2"}]}