{"action":"created","comment":{"url":"https://api.github.com/repos/susynt/SusyNtuple/pulls/comments/38576278","id":38576278,"diff_hunk":"@@ -155,182 +46,164 @@ JetSelector& JetSelector::setSystematic(const NtSys::SusyNtSys &s)\n //----------------------------------------------------------\n bool JetSelector::isBaselineJet(const Jet* jet)\n {\n-    if(m_2lep || m_2lepWH || m_3lep) {\n-        return (jet->Pt() > JET_MIN_PT_BASELINE);\n-    } else {\n-        bool passEta = (fabs(jet->Eta()) < JET_MAX_ETA);\n-        bool passPt  = (jet->Pt() > JET_MIN_PT_BASELINE);\n-        return (passEta && passPt);\n-    }\n+    return (jet->Pt() > 20.0);\n }\n //----------------------------------------------------------\n bool JetSelector::isSignalJet(const Jet* jet)\n {\n-    JetSelector::check();\n-\n-    bool pass = false;\n-    if(jet) {\n-        if(m_2lep || m_2lepWH) {\n-            pass = (isCentralLightJet(jet) || isCentralBJet(jet) || isForwardJet(jet));\n-        }\n-        else if(m_3lep || m_SS3L) {\n-            pass = ((jet->Pt() > JET_MIN_PT_SIGNAL)\n-                     && (fabs(jet->Eta()) < JET_MAX_ETA)\n-                     && jetPassesJvtRequirement(jet));\n-        }\n-    } // if(jet)\n-\n-    return pass;\n+    return (isCentralLightJet(jet) ||\n+            isCentralBJet(jet) ||\n+            isForwardJet(jet));\n }\n //----------------------------------------------------------\n bool JetSelector::isBJet(const Jet* jet)\n {\n-    ///////////////////////////////\n-    // pT requirement\n-    ///////////////////////////////\n-    if(jet->Pt() < 20.0)    return false;\n-\n-    ///////////////////////////////\n-    // eta requirement\n-    ///////////////////////////////\n-    if(fabs(jet->Eta()) > 2.5) return false;\n-\n-    ///////////////////////////////\n-    // jvt requirement\n-    ///////////////////////////////\n-    if(!jetPassesJvtRequirement(jet)) return false;\n-\n-    ///////////////////////////////\n-    // mv2c20 cut\n-    ///////////////////////////////\n-    if(jet->mv2c20 < JET_MV2C20_77) return false;\n-\n-    return true;\n+    return ((jet->Pt()        > 20.0   ) &&\n+            (fabs(jet->Eta()) <  2.5   ) &&\n+            (jet->mv2c20      > -0.4434) && // 77% eff\n+            (passJvt(jet)));\n }\n //----------------------------------------------------------\n bool JetSelector::isCentralLightJet(const Jet* jet)\n {\n-    JetSelector::check();\n-\n-    //////////////////////////////\n-    // pt requirement\n-    //////////////////////////////\n-    if(jet->Pt() < JET_MIN_PT_L20)       return false;\n-\n-    //////////////////////////////\n-    // detector eta requirement\n-    //////////////////////////////\n-    if(fabs(jet->detEta) > JET_MAX_ETA)  return false;\n-\n-    //////////////////////////////\n-    // JVT requirement\n-    //////////////////////////////\n-    if(!jetPassesJvtRequirement(jet))    return false;\n-\n-    //////////////////////////////\n-    // MV2c20 requirement\n-    //   (a la SUSYTools)\n-    //////////////////////////////\n-    if(jet->bjet)                        return false;","path":"Root/JetSelector.cxx","position":245,"original_position":245,"commit_id":"faf5c1b4cb5dc7230ead4f6951e9936e0ace6f76","original_commit_id":"faf5c1b4cb5dc7230ead4f6951e9936e0ace6f76","user":{"login":"dantrim","id":7841565,"avatar_url":"https://avatars.githubusercontent.com/u/7841565?v=3","gravatar_id":"","url":"https://api.github.com/users/dantrim","html_url":"https://github.com/dantrim","followers_url":"https://api.github.com/users/dantrim/followers","following_url":"https://api.github.com/users/dantrim/following{/other_user}","gists_url":"https://api.github.com/users/dantrim/gists{/gist_id}","starred_url":"https://api.github.com/users/dantrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantrim/subscriptions","organizations_url":"https://api.github.com/users/dantrim/orgs","repos_url":"https://api.github.com/users/dantrim/repos","events_url":"https://api.github.com/users/dantrim/events{/privacy}","received_events_url":"https://api.github.com/users/dantrim/received_events","type":"User","site_admin":false},"body":"nope, the ```jet->bjet``` was just a carry over from before we were storing the mv2. The ```isBJet``` should be fine","created_at":"2015-09-02T19:54:30Z","updated_at":"2015-09-02T19:54:30Z","html_url":"https://github.com/susynt/SusyNtuple/pull/77#discussion_r38576278","pull_request_url":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/susynt/SusyNtuple/pulls/comments/38576278"},"html":{"href":"https://github.com/susynt/SusyNtuple/pull/77#discussion_r38576278"},"pull_request":{"href":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77","id":44019842,"html_url":"https://github.com/susynt/SusyNtuple/pull/77","diff_url":"https://github.com/susynt/SusyNtuple/pull/77.diff","patch_url":"https://github.com/susynt/SusyNtuple/pull/77.patch","issue_url":"https://api.github.com/repos/susynt/SusyNtuple/issues/77","number":77,"state":"open","locked":false,"title":"Refactor implementation of object selectors","user":{"login":"gerbaudo","id":616337,"avatar_url":"https://avatars.githubusercontent.com/u/616337?v=3","gravatar_id":"","url":"https://api.github.com/users/gerbaudo","html_url":"https://github.com/gerbaudo","followers_url":"https://api.github.com/users/gerbaudo/followers","following_url":"https://api.github.com/users/gerbaudo/following{/other_user}","gists_url":"https://api.github.com/users/gerbaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gerbaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerbaudo/subscriptions","organizations_url":"https://api.github.com/users/gerbaudo/orgs","repos_url":"https://api.github.com/users/gerbaudo/repos","events_url":"https://api.github.com/users/gerbaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gerbaudo/received_events","type":"User","site_admin":false},"body":"This is the initial version of what I suggested yesterday\r\nfor the Selector implementation.\r\nFor now I started with the `JetSelector`. If you think this looks\r\nreasonable, I'll modify in the same way `ElectronSelector`\r\nand `MuonSelector`.\r\n\r\nThe base class `JetSelector` holds the \"vanilla\" jet selection criteria.\r\nThe derived classes `JetSelector_ss3l`, `JetSelector_Stop2L` , etc.,\r\nhold the analysis-specific selection criteria.\r\n\r\nThe idea is to have the explicit definition of each selection criteria\r\nin the code, so that one can almost copy-and-paste from the analysis'\r\nwiki to the code. See for example `JetSelector_ss3l::isSignalJet()`.\r\nI believe that this is much easier to follow than having the thresholds\r\nset in one place and the `if(value<thresh)` elsewhere.\r\n\r\nNote to self: requires #76 ","created_at":"2015-09-02T17:31:55Z","updated_at":"2015-09-02T19:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794fb9ec391ccfdcbf3fde414fe8688458375523","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77/commits","review_comments_url":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77/comments","review_comment_url":"https://api.github.com/repos/susynt/SusyNtuple/pulls/comments{/number}","comments_url":"https://api.github.com/repos/susynt/SusyNtuple/issues/77/comments","statuses_url":"https://api.github.com/repos/susynt/SusyNtuple/statuses/faf5c1b4cb5dc7230ead4f6951e9936e0ace6f76","head":{"label":"susynt:refactor-selector","ref":"refactor-selector","sha":"faf5c1b4cb5dc7230ead4f6951e9936e0ace6f76","user":{"login":"susynt","id":12401848,"avatar_url":"https://avatars.githubusercontent.com/u/12401848?v=3","gravatar_id":"","url":"https://api.github.com/users/susynt","html_url":"https://github.com/susynt","followers_url":"https://api.github.com/users/susynt/followers","following_url":"https://api.github.com/users/susynt/following{/other_user}","gists_url":"https://api.github.com/users/susynt/gists{/gist_id}","starred_url":"https://api.github.com/users/susynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susynt/subscriptions","organizations_url":"https://api.github.com/users/susynt/orgs","repos_url":"https://api.github.com/users/susynt/repos","events_url":"https://api.github.com/users/susynt/events{/privacy}","received_events_url":"https://api.github.com/users/susynt/received_events","type":"Organization","site_admin":false},"repo":{"id":18421590,"name":"SusyNtuple","full_name":"susynt/SusyNtuple","owner":{"login":"susynt","id":12401848,"avatar_url":"https://avatars.githubusercontent.com/u/12401848?v=3","gravatar_id":"","url":"https://api.github.com/users/susynt","html_url":"https://github.com/susynt","followers_url":"https://api.github.com/users/susynt/followers","following_url":"https://api.github.com/users/susynt/following{/other_user}","gists_url":"https://api.github.com/users/susynt/gists{/gist_id}","starred_url":"https://api.github.com/users/susynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susynt/subscriptions","organizations_url":"https://api.github.com/users/susynt/orgs","repos_url":"https://api.github.com/users/susynt/repos","events_url":"https://api.github.com/users/susynt/events{/privacy}","received_events_url":"https://api.github.com/users/susynt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/susynt/SusyNtuple","description":"mirror of svn.cern.ch/reps/atlasinst/Institutes/UCIrvine/SUSYAnalysis/SusyNtuple","fork":false,"url":"https://api.github.com/repos/susynt/SusyNtuple","forks_url":"https://api.github.com/repos/susynt/SusyNtuple/forks","keys_url":"https://api.github.com/repos/susynt/SusyNtuple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susynt/SusyNtuple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susynt/SusyNtuple/teams","hooks_url":"https://api.github.com/repos/susynt/SusyNtuple/hooks","issue_events_url":"https://api.github.com/repos/susynt/SusyNtuple/issues/events{/number}","events_url":"https://api.github.com/repos/susynt/SusyNtuple/events","assignees_url":"https://api.github.com/repos/susynt/SusyNtuple/assignees{/user}","branches_url":"https://api.github.com/repos/susynt/SusyNtuple/branches{/branch}","tags_url":"https://api.github.com/repos/susynt/SusyNtuple/tags","blobs_url":"https://api.github.com/repos/susynt/SusyNtuple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susynt/SusyNtuple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susynt/SusyNtuple/git/refs{/sha}","trees_url":"https://api.github.com/repos/susynt/SusyNtuple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susynt/SusyNtuple/statuses/{sha}","languages_url":"https://api.github.com/repos/susynt/SusyNtuple/languages","stargazers_url":"https://api.github.com/repos/susynt/SusyNtuple/stargazers","contributors_url":"https://api.github.com/repos/susynt/SusyNtuple/contributors","subscribers_url":"https://api.github.com/repos/susynt/SusyNtuple/subscribers","subscription_url":"https://api.github.com/repos/susynt/SusyNtuple/subscription","commits_url":"https://api.github.com/repos/susynt/SusyNtuple/commits{/sha}","git_commits_url":"https://api.github.com/repos/susynt/SusyNtuple/git/commits{/sha}","comments_url":"https://api.github.com/repos/susynt/SusyNtuple/comments{/number}","issue_comment_url":"https://api.github.com/repos/susynt/SusyNtuple/issues/comments{/number}","contents_url":"https://api.github.com/repos/susynt/SusyNtuple/contents/{+path}","compare_url":"https://api.github.com/repos/susynt/SusyNtuple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susynt/SusyNtuple/merges","archive_url":"https://api.github.com/repos/susynt/SusyNtuple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susynt/SusyNtuple/downloads","issues_url":"https://api.github.com/repos/susynt/SusyNtuple/issues{/number}","pulls_url":"https://api.github.com/repos/susynt/SusyNtuple/pulls{/number}","milestones_url":"https://api.github.com/repos/susynt/SusyNtuple/milestones{/number}","notifications_url":"https://api.github.com/repos/susynt/SusyNtuple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susynt/SusyNtuple/labels{/name}","releases_url":"https://api.github.com/repos/susynt/SusyNtuple/releases{/id}","created_at":"2014-04-03T23:33:31Z","updated_at":"2015-05-12T06:12:06Z","pushed_at":"2015-09-02T19:41:09Z","git_url":"git://github.com/susynt/SusyNtuple.git","ssh_url":"git@github.com:susynt/SusyNtuple.git","clone_url":"https://github.com/susynt/SusyNtuple.git","svn_url":"https://github.com/susynt/SusyNtuple","homepage":null,"size":167589,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":2,"default_branch":"master"}},"base":{"label":"susynt:ss3l-selectors","ref":"ss3l-selectors","sha":"6416679e29a6ed1a415547849968882964f56e99","user":{"login":"susynt","id":12401848,"avatar_url":"https://avatars.githubusercontent.com/u/12401848?v=3","gravatar_id":"","url":"https://api.github.com/users/susynt","html_url":"https://github.com/susynt","followers_url":"https://api.github.com/users/susynt/followers","following_url":"https://api.github.com/users/susynt/following{/other_user}","gists_url":"https://api.github.com/users/susynt/gists{/gist_id}","starred_url":"https://api.github.com/users/susynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susynt/subscriptions","organizations_url":"https://api.github.com/users/susynt/orgs","repos_url":"https://api.github.com/users/susynt/repos","events_url":"https://api.github.com/users/susynt/events{/privacy}","received_events_url":"https://api.github.com/users/susynt/received_events","type":"Organization","site_admin":false},"repo":{"id":18421590,"name":"SusyNtuple","full_name":"susynt/SusyNtuple","owner":{"login":"susynt","id":12401848,"avatar_url":"https://avatars.githubusercontent.com/u/12401848?v=3","gravatar_id":"","url":"https://api.github.com/users/susynt","html_url":"https://github.com/susynt","followers_url":"https://api.github.com/users/susynt/followers","following_url":"https://api.github.com/users/susynt/following{/other_user}","gists_url":"https://api.github.com/users/susynt/gists{/gist_id}","starred_url":"https://api.github.com/users/susynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susynt/subscriptions","organizations_url":"https://api.github.com/users/susynt/orgs","repos_url":"https://api.github.com/users/susynt/repos","events_url":"https://api.github.com/users/susynt/events{/privacy}","received_events_url":"https://api.github.com/users/susynt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/susynt/SusyNtuple","description":"mirror of svn.cern.ch/reps/atlasinst/Institutes/UCIrvine/SUSYAnalysis/SusyNtuple","fork":false,"url":"https://api.github.com/repos/susynt/SusyNtuple","forks_url":"https://api.github.com/repos/susynt/SusyNtuple/forks","keys_url":"https://api.github.com/repos/susynt/SusyNtuple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susynt/SusyNtuple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susynt/SusyNtuple/teams","hooks_url":"https://api.github.com/repos/susynt/SusyNtuple/hooks","issue_events_url":"https://api.github.com/repos/susynt/SusyNtuple/issues/events{/number}","events_url":"https://api.github.com/repos/susynt/SusyNtuple/events","assignees_url":"https://api.github.com/repos/susynt/SusyNtuple/assignees{/user}","branches_url":"https://api.github.com/repos/susynt/SusyNtuple/branches{/branch}","tags_url":"https://api.github.com/repos/susynt/SusyNtuple/tags","blobs_url":"https://api.github.com/repos/susynt/SusyNtuple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susynt/SusyNtuple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susynt/SusyNtuple/git/refs{/sha}","trees_url":"https://api.github.com/repos/susynt/SusyNtuple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susynt/SusyNtuple/statuses/{sha}","languages_url":"https://api.github.com/repos/susynt/SusyNtuple/languages","stargazers_url":"https://api.github.com/repos/susynt/SusyNtuple/stargazers","contributors_url":"https://api.github.com/repos/susynt/SusyNtuple/contributors","subscribers_url":"https://api.github.com/repos/susynt/SusyNtuple/subscribers","subscription_url":"https://api.github.com/repos/susynt/SusyNtuple/subscription","commits_url":"https://api.github.com/repos/susynt/SusyNtuple/commits{/sha}","git_commits_url":"https://api.github.com/repos/susynt/SusyNtuple/git/commits{/sha}","comments_url":"https://api.github.com/repos/susynt/SusyNtuple/comments{/number}","issue_comment_url":"https://api.github.com/repos/susynt/SusyNtuple/issues/comments{/number}","contents_url":"https://api.github.com/repos/susynt/SusyNtuple/contents/{+path}","compare_url":"https://api.github.com/repos/susynt/SusyNtuple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susynt/SusyNtuple/merges","archive_url":"https://api.github.com/repos/susynt/SusyNtuple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susynt/SusyNtuple/downloads","issues_url":"https://api.github.com/repos/susynt/SusyNtuple/issues{/number}","pulls_url":"https://api.github.com/repos/susynt/SusyNtuple/pulls{/number}","milestones_url":"https://api.github.com/repos/susynt/SusyNtuple/milestones{/number}","notifications_url":"https://api.github.com/repos/susynt/SusyNtuple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susynt/SusyNtuple/labels{/name}","releases_url":"https://api.github.com/repos/susynt/SusyNtuple/releases{/id}","created_at":"2014-04-03T23:33:31Z","updated_at":"2015-05-12T06:12:06Z","pushed_at":"2015-09-02T19:41:09Z","git_url":"git://github.com/susynt/SusyNtuple.git","ssh_url":"git@github.com:susynt/SusyNtuple.git","clone_url":"https://github.com/susynt/SusyNtuple.git","svn_url":"https://github.com/susynt/SusyNtuple","homepage":null,"size":167589,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77"},"html":{"href":"https://github.com/susynt/SusyNtuple/pull/77"},"issue":{"href":"https://api.github.com/repos/susynt/SusyNtuple/issues/77"},"comments":{"href":"https://api.github.com/repos/susynt/SusyNtuple/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/susynt/SusyNtuple/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/susynt/SusyNtuple/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/susynt/SusyNtuple/statuses/faf5c1b4cb5dc7230ead4f6951e9936e0ace6f76"}}}}