{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/109","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/109/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/109/events","html_url":"https://github.com/puppetlabs/puppetlabs-java/pull/109","id":57741237,"number":109,"title":"Add support for OpenBSD, and also add some regression tests.","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-02-15T18:58:39Z","updated_at":"2015-04-21T09:07:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/109","html_url":"https://github.com/puppetlabs/puppetlabs-java/pull/109","diff_url":"https://github.com/puppetlabs/puppetlabs-java/pull/109.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-java/pull/109.patch"},"body":"Add info about OpenBSD support to README.md and metadata.json\r\n\r\nThanks to the lots of feedback from the other pull requests, here is a new try, following the suggestsions. \r\n\r\nI first came up with something like:\r\n\r\nFacter.add(:java_version) do\r\n...\r\nsomething for non-OpenBSD\r\n...\r\nend\r\nFacter.add(:java_version) do\r\nconfine :osfamily => 'OpenBSD'\r\n...\r\nend\r\n\r\nthat was easy, worked well on a machine that had Java installed, and also spec tests were easily written and all fine. However, on a OpenBSD machine without java installed I got warnings running facter like this:\r\n\r\nfacter -p java_version                                             \r\nCould not retrieve fact='java_version', resolution='<anonymous>': undefined method `lines' for nil:NilClass\r\n\r\nThose are not really an option. BTW, running Puppet 3.7.4, Facter 2.3.0. Facter only just got updated in the Ports tree to 2.4.1 Today, so haven't tested with that version yet.\r\n\r\nIf installing jdk or jre, doesn't matter, the java binary I point to, is there with both variants.\r\n\r\nSince there is no OpenBSD yet with java 1.8, I haven't bothered yet, to fiddle with confines and versions to distinguish. Since OpenBSD is not primary target for any java development, it also might still take some time for it to appear as a port.\r\n"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/comments/94713373","html_url":"https://github.com/puppetlabs/puppetlabs-java/pull/109#issuecomment-94713373","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/109","id":94713373,"user":{"login":"tphoney","id":10402706,"avatar_url":"https://avatars.githubusercontent.com/u/10402706?v=3","gravatar_id":"","url":"https://api.github.com/users/tphoney","html_url":"https://github.com/tphoney","followers_url":"https://api.github.com/users/tphoney/followers","following_url":"https://api.github.com/users/tphoney/following{/other_user}","gists_url":"https://api.github.com/users/tphoney/gists{/gist_id}","starred_url":"https://api.github.com/users/tphoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tphoney/subscriptions","organizations_url":"https://api.github.com/users/tphoney/orgs","repos_url":"https://api.github.com/users/tphoney/repos","events_url":"https://api.github.com/users/tphoney/events{/privacy}","received_events_url":"https://api.github.com/users/tphoney/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T09:07:34Z","updated_at":"2015-04-21T09:07:34Z","body":"This looks great, except for one detail i overlooked. Supported modules are only for the following OSes. (RHEL,Windows,Ubuntu,Debian,Solaris,SLES,Scientific Linux,CentOS,Oracle Linux,AIX). We can be compatible with BSD and that is ok. Can you remove the section for support in the metadata.json file as we do not officially support. It is fine to mention it in the readme, that we are compatible. "}}