{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/22307","labels_url":"https://api.github.com/repos/saltstack/salt/issues/22307/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/22307/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/22307/events","html_url":"https://github.com/saltstack/salt/pull/22307","id":66028323,"number":22307,"title":"Fix issue #22306","user":{"login":"EliRibble","id":2319207,"avatar_url":"https://avatars.githubusercontent.com/u/2319207?v=3","gravatar_id":"","url":"https://api.github.com/users/EliRibble","html_url":"https://github.com/EliRibble","followers_url":"https://api.github.com/users/EliRibble/followers","following_url":"https://api.github.com/users/EliRibble/following{/other_user}","gists_url":"https://api.github.com/users/EliRibble/gists{/gist_id}","starred_url":"https://api.github.com/users/EliRibble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EliRibble/subscriptions","organizations_url":"https://api.github.com/users/EliRibble/orgs","repos_url":"https://api.github.com/users/EliRibble/repos","events_url":"https://api.github.com/users/EliRibble/events{/privacy}","received_events_url":"https://api.github.com/users/EliRibble/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Minor%20Change","name":"Minor Change","color":"bfe5bf"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Tests%20Passed","name":"Tests Passed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-02T23:06:21Z","updated_at":"2015-04-03T19:07:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/22307","html_url":"https://github.com/saltstack/salt/pull/22307","diff_url":"https://github.com/saltstack/salt/pull/22307.diff","patch_url":"https://github.com/saltstack/salt/pull/22307.patch"},"body":"Be aware of when we download files from S3 that have an environment\r\nprefix. For example, if the S3 bucket contains /base/top.sls then the\r\nfile will be downloaded as {pillar_dir}/base/top.sls rather than\r\n{pillar_dir}/top.sls which will mean that we are building our pillar\r\nwith the wrong root and won't actually ingest any pillar data.\r\n\r\nNow we take into account whether or not we are in multiple_env mode and\r\ncorrect the pillar root accordingly.\r\n\r\nWe also need to avoid recursively recreating the pillar when we compile\r\nthe pillar. There may be a more canonical way to do this, I'm not\r\nfamiliar enough with salt internals to know, but by ripping out the s3\r\nconfig from the ext_pillar config we avoid the infinite recursion.\r\n\r\nMay be related to #18355"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/89393154","html_url":"https://github.com/saltstack/salt/pull/22307#issuecomment-89393154","issue_url":"https://api.github.com/repos/saltstack/salt/issues/22307","id":89393154,"user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"created_at":"2015-04-03T19:07:22Z","updated_at":"2015-04-03T19:07:22Z","body":"This is ok from a testing perspective. Thanks very much!"}}