{"action":"created","issue":{"url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/issues/183","labels_url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/issues/183/comments","events_url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/issues/183/events","html_url":"https://github.com/Vocaluxe/Vocaluxe/issues/183","id":123348120,"number":183,"title":"Unique Player-IDs","user":{"login":"lukeIam","id":5115160,"avatar_url":"https://avatars.githubusercontent.com/u/5115160?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeIam","html_url":"https://github.com/lukeIam","followers_url":"https://api.github.com/users/lukeIam/followers","following_url":"https://api.github.com/users/lukeIam/following{/other_user}","gists_url":"https://api.github.com/users/lukeIam/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeIam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeIam/subscriptions","organizations_url":"https://api.github.com/users/lukeIam/orgs","repos_url":"https://api.github.com/users/lukeIam/repos","events_url":"https://api.github.com/users/lukeIam/events{/privacy}","received_events_url":"https://api.github.com/users/lukeIam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/labels/feature%20request","name":"feature request","color":"207de5"},{"url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/labels/vocaluxe","name":"vocaluxe","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-12-21T20:05:04Z","updated_at":"2015-12-29T11:38:36Z","closed_at":null,"body":"At the moment players has a incrementing player id that depends on the profile loading order (alphabetic?). Just to clarify: there is no id stored.\r\n\r\nIt would be good to have an id which stays the same over time and even over systems (maybe useful in the future).\r\n\r\nProblem: there are so many places in the Vocaluxe code where the id is used for integer operations.\r\nI tried four times to change the player id to a guid - but I screwed up each time.\r\n\r\nSo here is my suggestion:\r\ngive each player an **additional** guid next to the integer id (update existing profiles on load).\r\n\r\n**Advantages**:   \r\n- we do not break any existing code\r\n- we create a doubtless possibility to identify a user if situation needs it\r\n- we are creating a basis for a potential central profile system in the future\r\n\r\n**Disadvantages**:   \r\n- not that nice because we have two ids"},"comment":{"url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/issues/comments/167770141","html_url":"https://github.com/Vocaluxe/Vocaluxe/issues/183#issuecomment-167770141","issue_url":"https://api.github.com/repos/Vocaluxe/Vocaluxe/issues/183","id":167770141,"user":{"login":"flokuep","id":1449832,"avatar_url":"https://avatars.githubusercontent.com/u/1449832?v=3","gravatar_id":"","url":"https://api.github.com/users/flokuep","html_url":"https://github.com/flokuep","followers_url":"https://api.github.com/users/flokuep/followers","following_url":"https://api.github.com/users/flokuep/following{/other_user}","gists_url":"https://api.github.com/users/flokuep/gists{/gist_id}","starred_url":"https://api.github.com/users/flokuep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flokuep/subscriptions","organizations_url":"https://api.github.com/users/flokuep/orgs","repos_url":"https://api.github.com/users/flokuep/repos","events_url":"https://api.github.com/users/flokuep/events{/privacy}","received_events_url":"https://api.github.com/users/flokuep/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T11:38:36Z","updated_at":"2015-12-29T11:38:36Z","body":"Hm. This didn't fixed the problem... Still don't know how to find the bug... Maybe @lukeIam could have a look at it?"}}