{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/41519709","id":41519709,"diff_hunk":"@@ -71,7 +81,10 @@ bool MCDataCreateWithBytes(const byte_t *p_bytes, uindex_t p_byte_count, MCDataR\n     \n \tif (t_success)\n \t{\n-        MCMemoryCopy(self -> bytes, p_bytes, p_byte_count);\n+\t\tif (nil != p_bytes)","path":"libfoundation/src/foundation-data.cpp","position":22,"original_position":22,"commit_id":"a1eb9d3e815a5687fbceef88113ea436d14b177f","original_commit_id":"a1eb9d3e815a5687fbceef88113ea436d14b177f","user":{"login":"livecodeali","id":3985854,"avatar_url":"https://avatars.githubusercontent.com/u/3985854?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"body":"As discussed offline, disregard","created_at":"2015-10-08T14:28:10Z","updated_at":"2015-10-08T14:28:10Z","html_url":"https://github.com/livecode/livecode/pull/3032#discussion_r41519709","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/3032","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/41519709"},"html":{"href":"https://github.com/livecode/livecode/pull/3032#discussion_r41519709"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3032"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/3032","id":47142926,"html_url":"https://github.com/livecode/livecode/pull/3032","diff_url":"https://github.com/livecode/livecode/pull/3032.diff","patch_url":"https://github.com/livecode/livecode/pull/3032.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/3032","number":3032,"state":"open","locked":false,"title":"libfoundation: Check for bad MCValueRef casts","user":{"login":"peter-b","id":47528,"avatar_url":"https://avatars.githubusercontent.com/u/47528?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-b","html_url":"https://github.com/peter-b","followers_url":"https://api.github.com/users/peter-b/followers","following_url":"https://api.github.com/users/peter-b/following{/other_user}","gists_url":"https://api.github.com/users/peter-b/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-b/subscriptions","organizations_url":"https://api.github.com/users/peter-b/orgs","repos_url":"https://api.github.com/users/peter-b/repos","events_url":"https://api.github.com/users/peter-b/events{/privacy}","received_events_url":"https://api.github.com/users/peter-b/received_events","type":"User","site_admin":false},"body":"Add assertions to every public libfoundation function that accepts arguments of `MCValueRef` type, ensuring that the values are of the expected type.  The new checks add about 2.5% overhead to the engine, as measured using `perf` on Linux.","created_at":"2015-10-08T11:52:24Z","updated_at":"2015-10-08T14:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc52d47f98330014bf82ae9c81f90b95356bcc99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/3032/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/3032/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/3032/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/a1eb9d3e815a5687fbceef88113ea436d14b177f","head":{"label":"peter-b:libfoundation/assert-type-7.0","ref":"libfoundation/assert-type-7.0","sha":"a1eb9d3e815a5687fbceef88113ea436d14b177f","user":{"login":"peter-b","id":47528,"avatar_url":"https://avatars.githubusercontent.com/u/47528?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-b","html_url":"https://github.com/peter-b","followers_url":"https://api.github.com/users/peter-b/followers","following_url":"https://api.github.com/users/peter-b/following{/other_user}","gists_url":"https://api.github.com/users/peter-b/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-b/subscriptions","organizations_url":"https://api.github.com/users/peter-b/orgs","repos_url":"https://api.github.com/users/peter-b/repos","events_url":"https://api.github.com/users/peter-b/events{/privacy}","received_events_url":"https://api.github.com/users/peter-b/received_events","type":"User","site_admin":false},"repo":{"id":24674939,"name":"livecode","full_name":"peter-b/livecode","owner":{"login":"peter-b","id":47528,"avatar_url":"https://avatars.githubusercontent.com/u/47528?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-b","html_url":"https://github.com/peter-b","followers_url":"https://api.github.com/users/peter-b/followers","following_url":"https://api.github.com/users/peter-b/following{/other_user}","gists_url":"https://api.github.com/users/peter-b/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-b/subscriptions","organizations_url":"https://api.github.com/users/peter-b/orgs","repos_url":"https://api.github.com/users/peter-b/repos","events_url":"https://api.github.com/users/peter-b/events{/privacy}","received_events_url":"https://api.github.com/users/peter-b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peter-b/livecode","description":"Peter Brett's LiveCode development repository","fork":true,"url":"https://api.github.com/repos/peter-b/livecode","forks_url":"https://api.github.com/repos/peter-b/livecode/forks","keys_url":"https://api.github.com/repos/peter-b/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peter-b/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peter-b/livecode/teams","hooks_url":"https://api.github.com/repos/peter-b/livecode/hooks","issue_events_url":"https://api.github.com/repos/peter-b/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/peter-b/livecode/events","assignees_url":"https://api.github.com/repos/peter-b/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/peter-b/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/peter-b/livecode/tags","blobs_url":"https://api.github.com/repos/peter-b/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peter-b/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peter-b/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/peter-b/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peter-b/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/peter-b/livecode/languages","stargazers_url":"https://api.github.com/repos/peter-b/livecode/stargazers","contributors_url":"https://api.github.com/repos/peter-b/livecode/contributors","subscribers_url":"https://api.github.com/repos/peter-b/livecode/subscribers","subscription_url":"https://api.github.com/repos/peter-b/livecode/subscription","commits_url":"https://api.github.com/repos/peter-b/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/peter-b/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/peter-b/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/peter-b/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/peter-b/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/peter-b/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peter-b/livecode/merges","archive_url":"https://api.github.com/repos/peter-b/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peter-b/livecode/downloads","issues_url":"https://api.github.com/repos/peter-b/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/peter-b/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/peter-b/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/peter-b/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peter-b/livecode/labels{/name}","releases_url":"https://api.github.com/repos/peter-b/livecode/releases{/id}","created_at":"2014-10-01T10:49:08Z","updated_at":"2015-03-05T08:56:34Z","pushed_at":"2015-10-08T12:45:49Z","git_url":"git://github.com/peter-b/livecode.git","ssh_url":"git@github.com:peter-b/livecode.git","clone_url":"https://github.com/peter-b/livecode.git","svn_url":"https://github.com/peter-b/livecode","homepage":"http://www.livecode.com/","size":95684,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"livecode:develop-7.0","ref":"develop-7.0","sha":"3f6512c6b6fe8af4d62de9c04808b6a58632d34f","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","created_at":"2013-04-10T00:15:57Z","updated_at":"2015-10-08T12:47:31Z","pushed_at":"2015-10-08T14:23:20Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":null,"size":298309,"stargazers_count":100,"watchers_count":100,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":49,"forks":83,"open_issues":49,"watchers":100,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3032"},"html":{"href":"https://github.com/livecode/livecode/pull/3032"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/3032"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/3032/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3032/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3032/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/a1eb9d3e815a5687fbceef88113ea436d14b177f"}}}}