{"action":"closed","number":1545,"pull_request":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/1545","id":48043051,"html_url":"https://github.com/slimphp/Slim/pull/1545","diff_url":"https://github.com/slimphp/Slim/pull/1545.diff","patch_url":"https://github.com/slimphp/Slim/pull/1545.patch","issue_url":"https://api.github.com/repos/slimphp/Slim/issues/1545","number":1545,"state":"closed","locked":false,"title":"router->pathfor fullpath param for subRequests. #1521","user":{"login":"ssotomayor","id":1304919,"avatar_url":"https://avatars.githubusercontent.com/u/1304919?v=3","gravatar_id":"","url":"https://api.github.com/users/ssotomayor","html_url":"https://github.com/ssotomayor","followers_url":"https://api.github.com/users/ssotomayor/followers","following_url":"https://api.github.com/users/ssotomayor/following{/other_user}","gists_url":"https://api.github.com/users/ssotomayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ssotomayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssotomayor/subscriptions","organizations_url":"https://api.github.com/users/ssotomayor/orgs","repos_url":"https://api.github.com/users/ssotomayor/repos","events_url":"https://api.github.com/users/ssotomayor/events{/privacy}","received_events_url":"https://api.github.com/users/ssotomayor/received_events","type":"User","site_admin":false},"body":"I assume with this you could do something like this:\r\n```\r\n$app->get('/', function ($request, $response, $args) use ($router) {\r\n    $sub = $this->subRequest('GET', $router->pathFor('hello', [], [], false));\r\n})->setName('home');\r\n\r\n$app->get('/hello', function ($request, $response, $args) use ($router) {\r\n    $response->write(\"hellorequest \");\r\n    return $response;\r\n})->setName('hello');\r\n```\r\n\r\nHowever i'm not sure $router-pathFor is expected to be used with app->subRequest, since it simply returns the path. Perhaps an owner can jump in and clarify, or maybe you can use this change.\r\n\r\nBest.","created_at":"2015-10-19T08:28:46Z","updated_at":"2015-10-22T20:29:03Z","closed_at":"2015-10-22T20:29:03Z","merged_at":null,"merge_commit_sha":"7866c1e7d1421b942f2ee47e78180968b7ac0d4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slimphp/Slim/pulls/1545/commits","review_comments_url":"https://api.github.com/repos/slimphp/Slim/pulls/1545/comments","review_comment_url":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimphp/Slim/issues/1545/comments","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/29d083276013751dddb02d340c1021ac8ac11be4","head":{"label":"ssotomayor:feature/1521-router-pathfor-fullpath","ref":"feature/1521-router-pathfor-fullpath","sha":"29d083276013751dddb02d340c1021ac8ac11be4","user":{"login":"ssotomayor","id":1304919,"avatar_url":"https://avatars.githubusercontent.com/u/1304919?v=3","gravatar_id":"","url":"https://api.github.com/users/ssotomayor","html_url":"https://github.com/ssotomayor","followers_url":"https://api.github.com/users/ssotomayor/followers","following_url":"https://api.github.com/users/ssotomayor/following{/other_user}","gists_url":"https://api.github.com/users/ssotomayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ssotomayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssotomayor/subscriptions","organizations_url":"https://api.github.com/users/ssotomayor/orgs","repos_url":"https://api.github.com/users/ssotomayor/repos","events_url":"https://api.github.com/users/ssotomayor/events{/privacy}","received_events_url":"https://api.github.com/users/ssotomayor/received_events","type":"User","site_admin":false},"repo":{"id":44501648,"name":"Slim","full_name":"ssotomayor/Slim","owner":{"login":"ssotomayor","id":1304919,"avatar_url":"https://avatars.githubusercontent.com/u/1304919?v=3","gravatar_id":"","url":"https://api.github.com/users/ssotomayor","html_url":"https://github.com/ssotomayor","followers_url":"https://api.github.com/users/ssotomayor/followers","following_url":"https://api.github.com/users/ssotomayor/following{/other_user}","gists_url":"https://api.github.com/users/ssotomayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ssotomayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssotomayor/subscriptions","organizations_url":"https://api.github.com/users/ssotomayor/orgs","repos_url":"https://api.github.com/users/ssotomayor/repos","events_url":"https://api.github.com/users/ssotomayor/events{/privacy}","received_events_url":"https://api.github.com/users/ssotomayor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssotomayor/Slim","description":"Slim Framework source code","fork":true,"url":"https://api.github.com/repos/ssotomayor/Slim","forks_url":"https://api.github.com/repos/ssotomayor/Slim/forks","keys_url":"https://api.github.com/repos/ssotomayor/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssotomayor/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssotomayor/Slim/teams","hooks_url":"https://api.github.com/repos/ssotomayor/Slim/hooks","issue_events_url":"https://api.github.com/repos/ssotomayor/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/ssotomayor/Slim/events","assignees_url":"https://api.github.com/repos/ssotomayor/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/ssotomayor/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/ssotomayor/Slim/tags","blobs_url":"https://api.github.com/repos/ssotomayor/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssotomayor/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssotomayor/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssotomayor/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssotomayor/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/ssotomayor/Slim/languages","stargazers_url":"https://api.github.com/repos/ssotomayor/Slim/stargazers","contributors_url":"https://api.github.com/repos/ssotomayor/Slim/contributors","subscribers_url":"https://api.github.com/repos/ssotomayor/Slim/subscribers","subscription_url":"https://api.github.com/repos/ssotomayor/Slim/subscription","commits_url":"https://api.github.com/repos/ssotomayor/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssotomayor/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssotomayor/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssotomayor/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssotomayor/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/ssotomayor/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssotomayor/Slim/merges","archive_url":"https://api.github.com/repos/ssotomayor/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssotomayor/Slim/downloads","issues_url":"https://api.github.com/repos/ssotomayor/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/ssotomayor/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/ssotomayor/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/ssotomayor/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssotomayor/Slim/labels{/name}","releases_url":"https://api.github.com/repos/ssotomayor/Slim/releases{/id}","created_at":"2015-10-18T23:55:03Z","updated_at":"2015-10-18T23:55:05Z","pushed_at":"2015-10-19T08:26:07Z","git_url":"git://github.com/ssotomayor/Slim.git","ssh_url":"git@github.com:ssotomayor/Slim.git","clone_url":"https://github.com/ssotomayor/Slim.git","svn_url":"https://github.com/ssotomayor/Slim","homepage":"http://slimframework.com","size":4715,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.x"}},"base":{"label":"slimphp:3.x","ref":"3.x","sha":"d5a3ef3427fe3138765d821a7500330f5e2b5d79","user":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"repo":{"id":926544,"name":"Slim","full_name":"slimphp/Slim","owner":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slimphp/Slim","description":"Slim Framework source code","fork":false,"url":"https://api.github.com/repos/slimphp/Slim","forks_url":"https://api.github.com/repos/slimphp/Slim/forks","keys_url":"https://api.github.com/repos/slimphp/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimphp/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimphp/Slim/teams","hooks_url":"https://api.github.com/repos/slimphp/Slim/hooks","issue_events_url":"https://api.github.com/repos/slimphp/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/slimphp/Slim/events","assignees_url":"https://api.github.com/repos/slimphp/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/slimphp/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/slimphp/Slim/tags","blobs_url":"https://api.github.com/repos/slimphp/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimphp/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimphp/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimphp/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/slimphp/Slim/languages","stargazers_url":"https://api.github.com/repos/slimphp/Slim/stargazers","contributors_url":"https://api.github.com/repos/slimphp/Slim/contributors","subscribers_url":"https://api.github.com/repos/slimphp/Slim/subscribers","subscription_url":"https://api.github.com/repos/slimphp/Slim/subscription","commits_url":"https://api.github.com/repos/slimphp/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimphp/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimphp/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimphp/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimphp/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/slimphp/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimphp/Slim/merges","archive_url":"https://api.github.com/repos/slimphp/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimphp/Slim/downloads","issues_url":"https://api.github.com/repos/slimphp/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/slimphp/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/slimphp/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/slimphp/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimphp/Slim/labels{/name}","releases_url":"https://api.github.com/repos/slimphp/Slim/releases{/id}","created_at":"2010-09-21T01:17:06Z","updated_at":"2015-10-22T15:46:13Z","pushed_at":"2015-10-22T20:27:48Z","git_url":"git://github.com/slimphp/Slim.git","ssh_url":"git@github.com:slimphp/Slim.git","clone_url":"https://github.com/slimphp/Slim.git","svn_url":"https://github.com/slimphp/Slim","homepage":"http://slimframework.com","size":9767,"stargazers_count":5918,"watchers_count":5918,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1105,"mirror_url":null,"open_issues_count":21,"forks":1105,"open_issues":21,"watchers":5918,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1545"},"html":{"href":"https://github.com/slimphp/Slim/pull/1545"},"issue":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1545"},"comments":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1545/comments"},"review_comments":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1545/comments"},"review_comment":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1545/commits"},"statuses":{"href":"https://api.github.com/repos/slimphp/Slim/statuses/29d083276013751dddb02d340c1021ac8ac11be4"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":23,"deletions":1,"changed_files":2}}