{"action":"closed","number":1725,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/1725","id":38133747,"html_url":"https://github.com/pfsense/pfsense/pull/1725","diff_url":"https://github.com/pfsense/pfsense/pull/1725.diff","patch_url":"https://github.com/pfsense/pfsense/pull/1725.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/1725","number":1725,"state":"closed","locked":false,"title":"Display monitor IP on Gateways widget","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"body":"This enhancement adds a setting for the Gateways dashboard widget so the user\r\ncan choose to display the Gateway IP, Monitor IP or both.\r\nIf \"both\" is chosen and the Gateway IP is the Monitor IP, then only the\r\nGateway IP is shown - i.e. the same IP address is not repeated on the\r\nwidget display.\r\nIf \"both\" is chosen and the Monitor IP is different to the Gateway IP\r\nthen the Monitor IP is shown in () brackets after the Gateway IP.\r\nIf \"Monitor IP\" is chosen and there is no special Monitor IP defined,\r\nthen the Gateway IP is displayed (which is also the Monitor IP).\r\nIf \"Gateway IP\" is chosen then the widget behaves as it does now.\r\n\"Gateway IP\" is the default.\r\nI find this handy because the Gateways widget reports RTT (latency) and\r\nloss figures that are actually for pings to the Monitor IP. So it seems\r\nuseful to be able to display the Monitor IP in the widget.","created_at":"2015-06-19T18:18:31Z","updated_at":"2015-06-25T12:43:41Z","closed_at":"2015-06-25T12:43:41Z","merged_at":"2015-06-25T12:43:41Z","merge_commit_sha":"e887ca46570e16777cf18675d68c00a63258e567","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1725/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1725/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/1725/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/6538d33af88902748964c35133b0436f8594023f","head":{"label":"phil-davis:gateways-widget","ref":"gateways-widget","sha":"6538d33af88902748964c35133b0436f8594023f","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"repo":{"id":33725284,"name":"pfsense","full_name":"phil-davis/pfsense","owner":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil-davis/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/phil-davis/pfsense","forks_url":"https://api.github.com/repos/phil-davis/pfsense/forks","keys_url":"https://api.github.com/repos/phil-davis/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil-davis/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil-davis/pfsense/teams","hooks_url":"https://api.github.com/repos/phil-davis/pfsense/hooks","issue_events_url":"https://api.github.com/repos/phil-davis/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/phil-davis/pfsense/events","assignees_url":"https://api.github.com/repos/phil-davis/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/phil-davis/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/phil-davis/pfsense/tags","blobs_url":"https://api.github.com/repos/phil-davis/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil-davis/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil-davis/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil-davis/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil-davis/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/phil-davis/pfsense/languages","stargazers_url":"https://api.github.com/repos/phil-davis/pfsense/stargazers","contributors_url":"https://api.github.com/repos/phil-davis/pfsense/contributors","subscribers_url":"https://api.github.com/repos/phil-davis/pfsense/subscribers","subscription_url":"https://api.github.com/repos/phil-davis/pfsense/subscription","commits_url":"https://api.github.com/repos/phil-davis/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil-davis/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil-davis/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil-davis/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/phil-davis/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/phil-davis/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil-davis/pfsense/merges","archive_url":"https://api.github.com/repos/phil-davis/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil-davis/pfsense/downloads","issues_url":"https://api.github.com/repos/phil-davis/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/phil-davis/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/phil-davis/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/phil-davis/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil-davis/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/phil-davis/pfsense/releases{/id}","created_at":"2015-04-10T11:33:35Z","updated_at":"2015-04-29T12:34:22Z","pushed_at":"2015-06-25T12:15:04Z","git_url":"git://github.com/phil-davis/pfsense.git","ssh_url":"git@github.com:phil-davis/pfsense.git","clone_url":"https://github.com/phil-davis/pfsense.git","svn_url":"https://github.com/phil-davis/pfsense","homepage":"http://www.pfsense.org","size":64511,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"3378289af3f39b231de2c26e298d85d3eca4c835","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","created_at":"2011-05-12T19:44:21Z","updated_at":"2015-06-23T07:50:01Z","pushed_at":"2015-06-25T12:43:39Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":96844,"stargazers_count":599,"watchers_count":599,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":30,"forks":380,"open_issues":30,"watchers":599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1725"},"html":{"href":"https://github.com/pfsense/pfsense/pull/1725"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1725"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1725/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1725/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1725/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/6538d33af88902748964c35133b0436f8594023f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pfSense-git-updates","id":7121082,"avatar_url":"https://avatars.githubusercontent.com/u/7121082?v=3","gravatar_id":"","url":"https://api.github.com/users/pfSense-git-updates","html_url":"https://github.com/pfSense-git-updates","followers_url":"https://api.github.com/users/pfSense-git-updates/followers","following_url":"https://api.github.com/users/pfSense-git-updates/following{/other_user}","gists_url":"https://api.github.com/users/pfSense-git-updates/gists{/gist_id}","starred_url":"https://api.github.com/users/pfSense-git-updates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfSense-git-updates/subscriptions","organizations_url":"https://api.github.com/users/pfSense-git-updates/orgs","repos_url":"https://api.github.com/users/pfSense-git-updates/repos","events_url":"https://api.github.com/users/pfSense-git-updates/events{/privacy}","received_events_url":"https://api.github.com/users/pfSense-git-updates/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":126,"deletions":12,"changed_files":2}}