{"action":"created","issue":{"url":"https://api.github.com/repos/resin-io/resin-supervisor/issues/14","labels_url":"https://api.github.com/repos/resin-io/resin-supervisor/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/resin-io/resin-supervisor/issues/14/comments","events_url":"https://api.github.com/repos/resin-io/resin-supervisor/issues/14/events","html_url":"https://github.com/resin-io/resin-supervisor/pull/14","id":117988067,"number":14,"title":"WIP: Rewrite in Go","user":{"login":"pcarranzav","id":2223590,"avatar_url":"https://avatars.githubusercontent.com/u/2223590?v=3","gravatar_id":"","url":"https://api.github.com/users/pcarranzav","html_url":"https://github.com/pcarranzav","followers_url":"https://api.github.com/users/pcarranzav/followers","following_url":"https://api.github.com/users/pcarranzav/following{/other_user}","gists_url":"https://api.github.com/users/pcarranzav/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarranzav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarranzav/subscriptions","organizations_url":"https://api.github.com/users/pcarranzav/orgs","repos_url":"https://api.github.com/users/pcarranzav/repos","events_url":"https://api.github.com/users/pcarranzav/events{/privacy}","received_events_url":"https://api.github.com/users/pcarranzav/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-20T08:20:31Z","updated_at":"2015-11-23T10:48:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resin-io/resin-supervisor/pulls/14","html_url":"https://github.com/resin-io/resin-supervisor/pull/14","diff_url":"https://github.com/resin-io/resin-supervisor/pull/14.diff","patch_url":"https://github.com/resin-io/resin-supervisor/pull/14.patch"},"body":"Still a long way to go, but here's so you have an idea of where we're headed with this\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/resin-io/resin-supervisor/14)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/resin-io/resin-supervisor/issues/comments/158902821","html_url":"https://github.com/resin-io/resin-supervisor/pull/14#issuecomment-158902821","issue_url":"https://api.github.com/repos/resin-io/resin-supervisor/issues/14","id":158902821,"user":{"login":"Page-","id":360115,"avatar_url":"https://avatars.githubusercontent.com/u/360115?v=3","gravatar_id":"","url":"https://api.github.com/users/Page-","html_url":"https://github.com/Page-","followers_url":"https://api.github.com/users/Page-/followers","following_url":"https://api.github.com/users/Page-/following{/other_user}","gists_url":"https://api.github.com/users/Page-/gists{/gist_id}","starred_url":"https://api.github.com/users/Page-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Page-/subscriptions","organizations_url":"https://api.github.com/users/Page-/orgs","repos_url":"https://api.github.com/users/Page-/repos","events_url":"https://api.github.com/users/Page-/events{/privacy}","received_events_url":"https://api.github.com/users/Page-/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T10:48:29Z","updated_at":"2015-11-23T10:48:29Z","body":"\n\n\n\nReviewed 6 of 6 files at r3.\nReview status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.\n\n---\n\n_[gosuper/application/application.go, line 58 \\[r3\\]](https://reviewable.io:443/reviews/resin-io/resin-supervisor/14#-K3nwI1RcdiEn_E2rulU:-K3nwI1RcdiEn_E2rulV:2024266423) ([raw file](https://github.com/resin-io/resin-supervisor/blob/2724063c5a959d3aa3d0c7f409e0dafca8ecc526/gosuper/application/application.go#L58)):_\nCan't this be `func (app supermodels.App) DataPath() string {` and be called as `app.DataPath()`?  It just feels like a better structuring to have the app generate its data (and other) paths rather than the manager\n\n---\n\n_[gosuper/device/device.go, line 92 \\[r3\\]](https://reviewable.io:443/reviews/resin-io/resin-supervisor/14#-K3nvkv-Q95gYhF3qvE9:-K3nvkv-Q95gYhF3qvEA:-520483256) ([raw file](https://github.com/resin-io/resin-supervisor/blob/2724063c5a959d3aa3d0c7f409e0dafca8ecc526/gosuper/device/device.go#L92)):_\nIf I understand https://golang.org/pkg/builtin/#append correctly this should be `dev.waitChannels = append(dev.waitChannels, make(chan bool))`?\n\n---\n\n_[gosuper/gosuper/main.go, line 19 \\[r3\\]](https://reviewable.io:443/reviews/resin-io/resin-supervisor/14#-K3nwwmcTFYfSEKaH06u:-K3nwwmcTFYfSEKaH06v:1596730785) ([raw file](https://github.com/resin-io/resin-supervisor/blob/2724063c5a959d3aa3d0c7f409e0dafca8ecc526/gosuper/gosuper/main.go#L19)):_\nI was a bit confused by this (briefly thought it was saying \"wait for ever\", who/what is ever?) - can this be `waitForever` please\n\n---\n\n\n_Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/resin-io/resin-supervisor/14)_\n<!-- Sent from Reviewable.io -->\n"}}