{"action":"created","comment":{"url":"https://api.github.com/repos/code-builders/far_mar/pulls/comments/43594770","id":43594770,"diff_hunk":"@@ -0,0 +1,18 @@\n+class FarMar::Base\n+\n+  def initialize (attrs)\n+\n+  end\n+\n+  def read_file\n+    \"class needs to be defined in order to read file\"","path":"lib/far_mar/base.rb","position":8,"original_position":8,"commit_id":"d7b31c313007fee55be44a58f2e96ccc311e4aa8","original_commit_id":"d7b31c313007fee55be44a58f2e96ccc311e4aa8","user":{"login":"bookis","id":134635,"avatar_url":"https://avatars.githubusercontent.com/u/134635?v=3","gravatar_id":"","url":"https://api.github.com/users/bookis","html_url":"https://github.com/bookis","followers_url":"https://api.github.com/users/bookis/followers","following_url":"https://api.github.com/users/bookis/following{/other_user}","gists_url":"https://api.github.com/users/bookis/gists{/gist_id}","starred_url":"https://api.github.com/users/bookis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bookis/subscriptions","organizations_url":"https://api.github.com/users/bookis/orgs","repos_url":"https://api.github.com/users/bookis/repos","events_url":"https://api.github.com/users/bookis/events{/privacy}","received_events_url":"https://api.github.com/users/bookis/received_events","type":"User","site_admin":false},"body":"We've never talked about this, but just a thought. Putting a default method here is a great idea, and if a class existed without the method this file would run, then most likely cause an error down the road because a string would be returned instead of an array. So the thought would be to instead of eventually having an error, just immidietely cause an error with a relevant error message. \r\n\r\n```rb\r\ndef read_file\r\n   raise StandardError, \"#{this.class} needs to define `.read_file`\"\r\nend\r\n```","created_at":"2015-11-02T03:19:45Z","updated_at":"2015-11-02T03:19:45Z","html_url":"https://github.com/code-builders/far_mar/pull/3#discussion_r43594770","pull_request_url":"https://api.github.com/repos/code-builders/far_mar/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/code-builders/far_mar/pulls/comments/43594770"},"html":{"href":"https://github.com/code-builders/far_mar/pull/3#discussion_r43594770"},"pull_request":{"href":"https://api.github.com/repos/code-builders/far_mar/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/code-builders/far_mar/pulls/3","id":48691406,"html_url":"https://github.com/code-builders/far_mar/pull/3","diff_url":"https://github.com/code-builders/far_mar/pull/3.diff","patch_url":"https://github.com/code-builders/far_mar/pull/3.patch","issue_url":"https://api.github.com/repos/code-builders/far_mar/issues/3","number":3,"state":"open","locked":false,"title":"Far_Mar final","user":{"login":"danieladler","id":13191112,"avatar_url":"https://avatars.githubusercontent.com/u/13191112?v=3","gravatar_id":"","url":"https://api.github.com/users/danieladler","html_url":"https://github.com/danieladler","followers_url":"https://api.github.com/users/danieladler/followers","following_url":"https://api.github.com/users/danieladler/following{/other_user}","gists_url":"https://api.github.com/users/danieladler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieladler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieladler/subscriptions","organizations_url":"https://api.github.com/users/danieladler/orgs","repos_url":"https://api.github.com/users/danieladler/repos","events_url":"https://api.github.com/users/danieladler/events{/privacy}","received_events_url":"https://api.github.com/users/danieladler/received_events","type":"User","site_admin":false},"body":"Excited for your thoughts and feedback on this iteration. A couple of notes are in comments in the class files, but otherwise it should all be self-explanatory. Thanks! ","created_at":"2015-10-25T23:40:38Z","updated_at":"2015-11-02T03:19:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3555782d58a8c4f83ddbdd5baaf701157f014bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/code-builders/far_mar/pulls/3/commits","review_comments_url":"https://api.github.com/repos/code-builders/far_mar/pulls/3/comments","review_comment_url":"https://api.github.com/repos/code-builders/far_mar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-builders/far_mar/issues/3/comments","statuses_url":"https://api.github.com/repos/code-builders/far_mar/statuses/d7b31c313007fee55be44a58f2e96ccc311e4aa8","head":{"label":"danieladler:master","ref":"master","sha":"d7b31c313007fee55be44a58f2e96ccc311e4aa8","user":{"login":"danieladler","id":13191112,"avatar_url":"https://avatars.githubusercontent.com/u/13191112?v=3","gravatar_id":"","url":"https://api.github.com/users/danieladler","html_url":"https://github.com/danieladler","followers_url":"https://api.github.com/users/danieladler/followers","following_url":"https://api.github.com/users/danieladler/following{/other_user}","gists_url":"https://api.github.com/users/danieladler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieladler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieladler/subscriptions","organizations_url":"https://api.github.com/users/danieladler/orgs","repos_url":"https://api.github.com/users/danieladler/repos","events_url":"https://api.github.com/users/danieladler/events{/privacy}","received_events_url":"https://api.github.com/users/danieladler/received_events","type":"User","site_admin":false},"repo":{"id":44562864,"name":"far_mar","full_name":"danieladler/far_mar","owner":{"login":"danieladler","id":13191112,"avatar_url":"https://avatars.githubusercontent.com/u/13191112?v=3","gravatar_id":"","url":"https://api.github.com/users/danieladler","html_url":"https://github.com/danieladler","followers_url":"https://api.github.com/users/danieladler/followers","following_url":"https://api.github.com/users/danieladler/following{/other_user}","gists_url":"https://api.github.com/users/danieladler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieladler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieladler/subscriptions","organizations_url":"https://api.github.com/users/danieladler/orgs","repos_url":"https://api.github.com/users/danieladler/repos","events_url":"https://api.github.com/users/danieladler/events{/privacy}","received_events_url":"https://api.github.com/users/danieladler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danieladler/far_mar","description":null,"fork":true,"url":"https://api.github.com/repos/danieladler/far_mar","forks_url":"https://api.github.com/repos/danieladler/far_mar/forks","keys_url":"https://api.github.com/repos/danieladler/far_mar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danieladler/far_mar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danieladler/far_mar/teams","hooks_url":"https://api.github.com/repos/danieladler/far_mar/hooks","issue_events_url":"https://api.github.com/repos/danieladler/far_mar/issues/events{/number}","events_url":"https://api.github.com/repos/danieladler/far_mar/events","assignees_url":"https://api.github.com/repos/danieladler/far_mar/assignees{/user}","branches_url":"https://api.github.com/repos/danieladler/far_mar/branches{/branch}","tags_url":"https://api.github.com/repos/danieladler/far_mar/tags","blobs_url":"https://api.github.com/repos/danieladler/far_mar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danieladler/far_mar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danieladler/far_mar/git/refs{/sha}","trees_url":"https://api.github.com/repos/danieladler/far_mar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danieladler/far_mar/statuses/{sha}","languages_url":"https://api.github.com/repos/danieladler/far_mar/languages","stargazers_url":"https://api.github.com/repos/danieladler/far_mar/stargazers","contributors_url":"https://api.github.com/repos/danieladler/far_mar/contributors","subscribers_url":"https://api.github.com/repos/danieladler/far_mar/subscribers","subscription_url":"https://api.github.com/repos/danieladler/far_mar/subscription","commits_url":"https://api.github.com/repos/danieladler/far_mar/commits{/sha}","git_commits_url":"https://api.github.com/repos/danieladler/far_mar/git/commits{/sha}","comments_url":"https://api.github.com/repos/danieladler/far_mar/comments{/number}","issue_comment_url":"https://api.github.com/repos/danieladler/far_mar/issues/comments{/number}","contents_url":"https://api.github.com/repos/danieladler/far_mar/contents/{+path}","compare_url":"https://api.github.com/repos/danieladler/far_mar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danieladler/far_mar/merges","archive_url":"https://api.github.com/repos/danieladler/far_mar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danieladler/far_mar/downloads","issues_url":"https://api.github.com/repos/danieladler/far_mar/issues{/number}","pulls_url":"https://api.github.com/repos/danieladler/far_mar/pulls{/number}","milestones_url":"https://api.github.com/repos/danieladler/far_mar/milestones{/number}","notifications_url":"https://api.github.com/repos/danieladler/far_mar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danieladler/far_mar/labels{/name}","releases_url":"https://api.github.com/repos/danieladler/far_mar/releases{/id}","created_at":"2015-10-19T20:43:46Z","updated_at":"2015-10-19T20:43:46Z","pushed_at":"2015-10-25T23:38:54Z","git_url":"git://github.com/danieladler/far_mar.git","ssh_url":"git@github.com:danieladler/far_mar.git","clone_url":"https://github.com/danieladler/far_mar.git","svn_url":"https://github.com/danieladler/far_mar","homepage":null,"size":383,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-builders:master","ref":"master","sha":"7c65f24da181bf404df8556002bc589891c0d1f6","user":{"login":"code-builders","id":13948000,"avatar_url":"https://avatars.githubusercontent.com/u/13948000?v=3","gravatar_id":"","url":"https://api.github.com/users/code-builders","html_url":"https://github.com/code-builders","followers_url":"https://api.github.com/users/code-builders/followers","following_url":"https://api.github.com/users/code-builders/following{/other_user}","gists_url":"https://api.github.com/users/code-builders/gists{/gist_id}","starred_url":"https://api.github.com/users/code-builders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-builders/subscriptions","organizations_url":"https://api.github.com/users/code-builders/orgs","repos_url":"https://api.github.com/users/code-builders/repos","events_url":"https://api.github.com/users/code-builders/events{/privacy}","received_events_url":"https://api.github.com/users/code-builders/received_events","type":"Organization","site_admin":false},"repo":{"id":44507886,"name":"far_mar","full_name":"code-builders/far_mar","owner":{"login":"code-builders","id":13948000,"avatar_url":"https://avatars.githubusercontent.com/u/13948000?v=3","gravatar_id":"","url":"https://api.github.com/users/code-builders","html_url":"https://github.com/code-builders","followers_url":"https://api.github.com/users/code-builders/followers","following_url":"https://api.github.com/users/code-builders/following{/other_user}","gists_url":"https://api.github.com/users/code-builders/gists{/gist_id}","starred_url":"https://api.github.com/users/code-builders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-builders/subscriptions","organizations_url":"https://api.github.com/users/code-builders/orgs","repos_url":"https://api.github.com/users/code-builders/repos","events_url":"https://api.github.com/users/code-builders/events{/privacy}","received_events_url":"https://api.github.com/users/code-builders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-builders/far_mar","description":null,"fork":false,"url":"https://api.github.com/repos/code-builders/far_mar","forks_url":"https://api.github.com/repos/code-builders/far_mar/forks","keys_url":"https://api.github.com/repos/code-builders/far_mar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-builders/far_mar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-builders/far_mar/teams","hooks_url":"https://api.github.com/repos/code-builders/far_mar/hooks","issue_events_url":"https://api.github.com/repos/code-builders/far_mar/issues/events{/number}","events_url":"https://api.github.com/repos/code-builders/far_mar/events","assignees_url":"https://api.github.com/repos/code-builders/far_mar/assignees{/user}","branches_url":"https://api.github.com/repos/code-builders/far_mar/branches{/branch}","tags_url":"https://api.github.com/repos/code-builders/far_mar/tags","blobs_url":"https://api.github.com/repos/code-builders/far_mar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-builders/far_mar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-builders/far_mar/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-builders/far_mar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-builders/far_mar/statuses/{sha}","languages_url":"https://api.github.com/repos/code-builders/far_mar/languages","stargazers_url":"https://api.github.com/repos/code-builders/far_mar/stargazers","contributors_url":"https://api.github.com/repos/code-builders/far_mar/contributors","subscribers_url":"https://api.github.com/repos/code-builders/far_mar/subscribers","subscription_url":"https://api.github.com/repos/code-builders/far_mar/subscription","commits_url":"https://api.github.com/repos/code-builders/far_mar/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-builders/far_mar/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-builders/far_mar/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-builders/far_mar/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-builders/far_mar/contents/{+path}","compare_url":"https://api.github.com/repos/code-builders/far_mar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-builders/far_mar/merges","archive_url":"https://api.github.com/repos/code-builders/far_mar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-builders/far_mar/downloads","issues_url":"https://api.github.com/repos/code-builders/far_mar/issues{/number}","pulls_url":"https://api.github.com/repos/code-builders/far_mar/pulls{/number}","milestones_url":"https://api.github.com/repos/code-builders/far_mar/milestones{/number}","notifications_url":"https://api.github.com/repos/code-builders/far_mar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-builders/far_mar/labels{/name}","releases_url":"https://api.github.com/repos/code-builders/far_mar/releases{/id}","created_at":"2015-10-19T02:55:39Z","updated_at":"2015-10-19T02:55:46Z","pushed_at":"2015-11-02T03:15:35Z","git_url":"git://github.com/code-builders/far_mar.git","ssh_url":"git@github.com:code-builders/far_mar.git","clone_url":"https://github.com/code-builders/far_mar.git","svn_url":"https://github.com/code-builders/far_mar","homepage":null,"size":494,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-builders/far_mar/pulls/3"},"html":{"href":"https://github.com/code-builders/far_mar/pull/3"},"issue":{"href":"https://api.github.com/repos/code-builders/far_mar/issues/3"},"comments":{"href":"https://api.github.com/repos/code-builders/far_mar/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/code-builders/far_mar/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/code-builders/far_mar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-builders/far_mar/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/code-builders/far_mar/statuses/d7b31c313007fee55be44a58f2e96ccc311e4aa8"}}}}