{"action":"created","issue":{"url":"https://api.github.com/repos/ypid/opening_hours.js/issues/115","labels_url":"https://api.github.com/repos/ypid/opening_hours.js/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/ypid/opening_hours.js/issues/115/comments","events_url":"https://api.github.com/repos/ypid/opening_hours.js/issues/115/events","html_url":"https://github.com/ypid/opening_hours.js/issues/115","id":111883979,"number":115,"title":"Public holidays Belgium","user":{"login":"sanderd17","id":562171,"avatar_url":"https://avatars.githubusercontent.com/u/562171?v=3","gravatar_id":"","url":"https://api.github.com/users/sanderd17","html_url":"https://github.com/sanderd17","followers_url":"https://api.github.com/users/sanderd17/followers","following_url":"https://api.github.com/users/sanderd17/following{/other_user}","gists_url":"https://api.github.com/users/sanderd17/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderd17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderd17/subscriptions","organizations_url":"https://api.github.com/users/sanderd17/orgs","repos_url":"https://api.github.com/users/sanderd17/repos","events_url":"https://api.github.com/users/sanderd17/events{/privacy}","received_events_url":"https://api.github.com/users/sanderd17/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ypid/opening_hours.js/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-16T18:21:17Z","updated_at":"2015-10-16T21:44:37Z","closed_at":null,"body":"In Belgium there are 10 public holidays. They are the same for all regions. However, as the regions use different languages, they are named differently.\r\n\r\nSee https://nl.wikipedia.org/wiki/Feestdagen_in_Belgi%C3%AB ,  https://fr.wikipedia.org/wiki/F%C3%AAtes_et_jours_f%C3%A9ri%C3%A9s_en_Belgique and https://de.wikipedia.org/wiki/Feiertage_in_Belgien\r\n\r\nI'm not sure how to put these different languages in JS data., so I'll just give a French, Dutch and German example\r\n\r\n```JS\r\n        'be': { // {{{\r\n            'PH': { // https://fr.wikipedia.org/wiki/F%C3%AAtes_et_jours_f%C3%A9ri%C3%A9s_en_Belgique\r\n                \"Jour de l'an\"                          : [  1,  1 ],\r\n                \"Lundi de Pâques\"                  : [  'easter', 1 ],\r\n                \"Fête du Travail\"                     : [  5,  1 ],\r\n                \"Jeudi de l'Ascension\"            : [  'easter', 39 ],\r\n                \"Lundi de Pentecôte\"              : [  'easter', 50 ],\r\n                \"Fête nationale\"                      : [  7, 21],\r\n                \"Assomption\"                          : [  8, 15 ],\r\n                \"Toussaint\"                             : [ 11,  1 ],\r\n                \"Armistice\"                              : [ 11, 11 ],\r\n                \"Noël\"                                     : [ 12, 25 ],\r\n            }\r\n        }, // }}}\r\n```\r\n\r\n```JS\r\n        'be': { // {{{\r\n            'PH': { // https://nl.wikipedia.org/wiki/Feestdagen_in_Belgi%C3%AB\r\n                \"Nieuwjaar\"                                  : [  1,  1 ],\r\n                \"Paasmaandag\"                           : [  'easter', 1 ],\r\n                \"Dag van de arbeid\"                     : [  5,  1 ],\r\n                \"Onze-Lieve-Heer-Hemelvaart\"    : [  'easter', 39 ],  // Often shorted to O.L.H. Hemelvaart\r\n                \"Pinkstermaandag\"                      : [  'easter', 50 ],\r\n                \"Nationale feestdag\"                    : [  7, 21],\r\n                \"Onze-Lieve-Vrouw-Hemelvaart\"  : [  8, 15 ], // Often shorted to O.L.V. Hemelvaart\r\n                \"Allerheiligen\"                               : [ 11,  1 ],\r\n                \"Wapenstilstand\"                          : [ 11, 11 ],\r\n                \"Kerstmis\"                                     : [ 12, 25 ],\r\n            }\r\n        }, // }}}\r\n```\r\n\r\n```JS\r\n        'be': { // {{{\r\n            'PH': { // https://nl.wikipedia.org/wiki/Feestdagen_in_Belgi%C3%AB\r\n                \"Neujahr\"                                     : [  1,  1 ],\r\n                \"Ostermontag\"                             : [  'easter', 1 ],\r\n                \"Tag der Arbeit\"                           : [  5,  1 ],\r\n                \"Christi Himmelfahrt\"                    : [  'easter', 39 ],\r\n                \"Pfingstmontag\"                           : [  'easter', 50 ],\r\n                \"Nationalfeirtag\"                           : [  7, 21],\r\n                \"Mariä Himmelfahrt\"                     : [  8, 15 ],\r\n                \"Allerheiligen\"                               : [ 11,  1 ],\r\n                \"Waffenstillstand\"                         : [ 11, 11 ],\r\n                \"Weihnachten\"                             : [ 12, 25 ],\r\n            }\r\n        }, // }}}\r\n```\r\n\r\nI don't know exactly what to do with Easter and Pentecost. As they always fall on a sunday, the monday after it is considered the PH. Our legislation doesn't differentiate between PHs and sundays AFAIK. so I guess it's fine to exclude these two days.\r\n\r\nThen we also have extra holidays for public servants, and oddly enough, that also counts for banks. These do differ between different regions, as the regional holiday is normally included in it. "},"comment":{"url":"https://api.github.com/repos/ypid/opening_hours.js/issues/comments/148843704","html_url":"https://github.com/ypid/opening_hours.js/issues/115#issuecomment-148843704","issue_url":"https://api.github.com/repos/ypid/opening_hours.js/issues/115","id":148843704,"user":{"login":"sanderd17","id":562171,"avatar_url":"https://avatars.githubusercontent.com/u/562171?v=3","gravatar_id":"","url":"https://api.github.com/users/sanderd17","html_url":"https://github.com/sanderd17","followers_url":"https://api.github.com/users/sanderd17/followers","following_url":"https://api.github.com/users/sanderd17/following{/other_user}","gists_url":"https://api.github.com/users/sanderd17/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderd17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderd17/subscriptions","organizations_url":"https://api.github.com/users/sanderd17/orgs","repos_url":"https://api.github.com/users/sanderd17/repos","events_url":"https://api.github.com/users/sanderd17/events{/privacy}","received_events_url":"https://api.github.com/users/sanderd17/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T21:44:37Z","updated_at":"2015-10-16T21:44:37Z","body":"The German page is the only one to list Easter and Pentecost as PH, while the German language only represents 1% of the population, so I'm more eager to follow the French and Dutch pages.\r\n\r\nBanking holidays would be ideal for those extra days. So it shouldn't be included in the PH section indeed.\r\n\r\nFor the linguistic communities, you can find those boundaries here: http://wiki.openstreetmap.org/wiki/WikiProject_Belgium/Boundaries#Linguistic_Communities_.28Gemeenschappen_.2F_Communaut.C3.A9s_.2F_Gemeinschaften.29\r\n\r\nHowever, the tagging mentioned on the wiki isn't right. It's not an administrative border, but a political one on OSM. This is because the linguistic communities don't blend in well with our other administrative boundaries (like provinces and arrondissements). So nominatim doesn't include the communities is their reverse lookup.\r\n\r\nOn top of that, Brussels is a bilingual city, and falls under the Flemish and French community. So perhaps Brussels could be a 4th, hard-coded bilingual list.\r\n\r\nIf you must rely on results from nominatim, the monolingual Dutch speaking area matches perfectly with the Flemish region (state Vlaanderen on nominatim), and the bilingual French-Dutch area matches perfectly with the Brussels Capital region (also listed as a state on nominatim). The German community on the other hand, can only be defined as a list of 9 municipalities. And the French community is the Walloon region (again a state on nominatim), but with the exclusion of those 9 German municipalities.\r\n\r\nI hope this brought some clarity, but quite likely it didn't."}}