{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/40884378","id":40884378,"diff_hunk":"@@ -1,183 +1,179 @@\n package builds\n \n-/*\n-This particular builds test suite is not part of the \"default\" group,  because its testing\n-centers around manipulation of images tags to confirm whether the `docker pull` invocation occurs\n-correctly based on `forcePull` setting in the BuildConfig, and rather than spend time creating / pulling down separate, test only,\n-images for each test scenario, we reuse existing images and ensure that the tests do not run in parallel, and step on each\n-others toes by tagging the same, existing images in ways which conflict.\n-*/\n-\n import (\n \t\"fmt\"\n \n \tg \"github.com/onsi/ginkgo\"\n \to \"github.com/onsi/gomega\"\n \n-\t\"time\"\n-\n+\tdockerClient \"github.com/fsouza/go-dockerclient\"\n \texutil \"github.com/openshift/origin/test/extended/util\"\n )\n \n-var (\n-\tresetData map[string]string\n+const (\n+\tbuildPrefixFS = \"ruby-sample-build-fs\"\n+\tbuildNameFS   = buildPrefixFS + \"-1\"\n+\tbuildPrefixTS = \"ruby-sample-build-ts\"\n+\tbuildNameTS   = buildPrefixTS + \"-1\"\n+\tbuildPrefixFD = \"ruby-sample-build-fd\"\n+\tbuildNameFD   = buildPrefixFD + \"-1\"\n+\tbuildPrefixTD = \"ruby-sample-build-td\"\n+\tbuildNameTD   = buildPrefixTD + \"-1\"\n+\tbuildPrefixFC = \"ruby-sample-build-fc\"\n+\tbuildNameFC   = buildPrefixFC + \"-1\"\n+\tbuildPrefixTC = \"ruby-sample-build-tc\"\n+\tbuildNameTC   = buildPrefixTC + \"-1\"\n+\n+\tcorruptor = \"docker.io/openshift/origin-custom-docker-builder\"","path":"test/extended/builds/forcepull.go","position":39,"original_position":39,"commit_id":"a5ce2733d977c7a84e7320a507217c32d364690f","original_commit_id":"e1c3c054eb0a8915e1411b85c9ff9acab9556510","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"how is this a corruptor for a custom buildconfig?  isn't this a valid custom builder image?\r\n\r\ni guess in the custom case (and arguably all cases) you don't care what the corruptor is as long as it's different from the image the buildconfig should be pulling, but it might be less confusing to pick something that's not a builder here.\r\n\r\ndocker.io/openshift/origin-base should be quick to pull since it should already exist.\r\n","created_at":"2015-10-01T07:05:19Z","updated_at":"2015-10-01T07:05:19Z","html_url":"https://github.com/openshift/origin/pull/4716#discussion_r40884378","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4716","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/40884378"},"html":{"href":"https://github.com/openshift/origin/pull/4716#discussion_r40884378"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4716"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4716","id":45344124,"html_url":"https://github.com/openshift/origin/pull/4716","diff_url":"https://github.com/openshift/origin/pull/4716.diff","patch_url":"https://github.com/openshift/origin/pull/4716.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4716","number":4716,"state":"open","locked":false,"title":"prevent force pull set up from running in other focuses; add some deb…","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"…ug clues in hack/util.sh\r\n\r\n@bparees @mfojtik @csrwng the PR for preventing some force pull initialization to happen in all the extended tests, irregardless of focus, etc.","created_at":"2015-09-17T21:27:07Z","updated_at":"2015-10-01T07:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d52078766c4f65009755cc26d87d600338bc0aff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4716/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4716/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4716/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/a5ce2733d977c7a84e7320a507217c32d364690f","head":{"label":"gabemontero:RemoveBeforeSuitesFromForcePull","ref":"RemoveBeforeSuitesFromForcePull","sha":"a5ce2733d977c7a84e7320a507217c32d364690f","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36941154,"name":"origin","full_name":"gabemontero/origin","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/gabemontero/origin","forks_url":"https://api.github.com/repos/gabemontero/origin/forks","keys_url":"https://api.github.com/repos/gabemontero/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/origin/teams","hooks_url":"https://api.github.com/repos/gabemontero/origin/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/origin/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/origin/events","assignees_url":"https://api.github.com/repos/gabemontero/origin/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/origin/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/origin/tags","blobs_url":"https://api.github.com/repos/gabemontero/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/origin/languages","stargazers_url":"https://api.github.com/repos/gabemontero/origin/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/origin/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/origin/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/origin/subscription","commits_url":"https://api.github.com/repos/gabemontero/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/origin/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/origin/merges","archive_url":"https://api.github.com/repos/gabemontero/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/origin/downloads","issues_url":"https://api.github.com/repos/gabemontero/origin/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/origin/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/origin/releases{/id}","created_at":"2015-06-05T15:48:08Z","updated_at":"2015-06-05T15:48:12Z","pushed_at":"2015-10-01T02:04:51Z","git_url":"git://github.com/gabemontero/origin.git","ssh_url":"git@github.com:gabemontero/origin.git","clone_url":"https://github.com/gabemontero/origin.git","svn_url":"https://github.com/gabemontero/origin","homepage":"http://www.openshift.org","size":142262,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a7e1132d5f27c330fcaf602675013ba5fffcd883","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-09-30T12:44:25Z","pushed_at":"2015-10-01T02:55:31Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":241412,"stargazers_count":709,"watchers_count":709,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":431,"mirror_url":null,"open_issues_count":559,"forks":431,"open_issues":559,"watchers":709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4716"},"html":{"href":"https://github.com/openshift/origin/pull/4716"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4716"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4716/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4716/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4716/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/a5ce2733d977c7a84e7320a507217c32d364690f"}}}}