{"action":"created","issue":{"url":"https://api.github.com/repos/collectd/collectd/issues/959","labels_url":"https://api.github.com/repos/collectd/collectd/issues/959/labels{/name}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/959/comments","events_url":"https://api.github.com/repos/collectd/collectd/issues/959/events","html_url":"https://github.com/collectd/collectd/pull/959","id":59806461,"number":959,"title":"Ceph: do not define _BSD_SOURCE","user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/collectd/collectd/milestones/8","html_url":"https://github.com/collectd/collectd/milestones/5.5","labels_url":"https://api.github.com/repos/collectd/collectd/milestones/8/labels","id":1009238,"number":8,"title":"5.5","description":"","creator":{"login":"mfournier","id":37533,"avatar_url":"https://avatars.githubusercontent.com/u/37533?v=3","gravatar_id":"","url":"https://api.github.com/users/mfournier","html_url":"https://github.com/mfournier","followers_url":"https://api.github.com/users/mfournier/followers","following_url":"https://api.github.com/users/mfournier/following{/other_user}","gists_url":"https://api.github.com/users/mfournier/gists{/gist_id}","starred_url":"https://api.github.com/users/mfournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfournier/subscriptions","organizations_url":"https://api.github.com/users/mfournier/orgs","repos_url":"https://api.github.com/users/mfournier/repos","events_url":"https://api.github.com/users/mfournier/events{/privacy}","received_events_url":"https://api.github.com/users/mfournier/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":1,"state":"open","created_at":"2015-03-06T13:49:49Z","updated_at":"2015-03-08T06:36:21Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-03-04T14:41:39Z","updated_at":"2015-03-08T07:20:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/959","html_url":"https://github.com/collectd/collectd/pull/959","diff_url":"https://github.com/collectd/collectd/pull/959.diff","patch_url":"https://github.com/collectd/collectd/pull/959.patch"},"body":"As far as I can see it doesn't need any definitions\r\nexposed by this define.\r\n\r\nFixes:\r\nmake[3]: Entering directory '/home/ruben/src/collectd/src'\r\n  CC       ceph_la-ceph.lo\r\nIn file included from /usr/include/stdio.h:27:0,\r\n                 from ./daemon/collectd.h:34,\r\n                 from ceph.c:26:\r\n/usr/include/features.h:148:3: error: #warning \"_BSD_SOURCE and\r\n_SVID_SOURCE are deprecated, use _DEFAULT_SOURCE\" [-Werror=cpp]\r\n # warning \"_BSD_SOURCE and _SVID_SOURCE are deprecated, use\r\n # _DEFAULT_SOURCE\"\r\n   ^\r\ncc1: all warnings being treated as errors\r\nMakefile:4120: recipe for target 'ceph_la-ceph.lo' failed\r\nmake[3]: *** [ceph_la-ceph.lo] Error 1\r\nmake[3]: Leaving directory '/home/ruben/src/collectd/src'\r\nMakefile:5096: recipe for target 'all-recursive' failed\r\nmake[2]: *** [all-recursive] Error 1\r\nmake[2]: Leaving directory '/home/ruben/src/collectd/src'\r\nMakefile:3142: recipe for target 'all' failed\r\nmake[1]: *** [all] Error 2\r\nmake[1]: Leaving directory '/home/ruben/src/collectd/src'\r\nMakefile:551: recipe for target 'all-recursive' failed\r\nmake: *** [all-recursive] Error 1"},"comment":{"url":"https://api.github.com/repos/collectd/collectd/issues/comments/77736854","html_url":"https://github.com/collectd/collectd/pull/959#issuecomment-77736854","issue_url":"https://api.github.com/repos/collectd/collectd/issues/959","id":77736854,"user":{"login":"mfournier","id":37533,"avatar_url":"https://avatars.githubusercontent.com/u/37533?v=3","gravatar_id":"","url":"https://api.github.com/users/mfournier","html_url":"https://github.com/mfournier","followers_url":"https://api.github.com/users/mfournier/followers","following_url":"https://api.github.com/users/mfournier/following{/other_user}","gists_url":"https://api.github.com/users/mfournier/gists{/gist_id}","starred_url":"https://api.github.com/users/mfournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfournier/subscriptions","organizations_url":"https://api.github.com/users/mfournier/orgs","repos_url":"https://api.github.com/users/mfournier/repos","events_url":"https://api.github.com/users/mfournier/events{/privacy}","received_events_url":"https://api.github.com/users/mfournier/received_events","type":"User","site_admin":false},"created_at":"2015-03-08T07:20:30Z","updated_at":"2015-03-08T07:20:30Z","body":"Despite having read some doc about these macros, I still don't understand exactly what the consequences of removing this statement would be.\r\n\r\nSo I'd stick with @pyr's advice, and follow what he did in 3bc1a46b. Would this be ok for you @rubenk ?"}}