{"action":"closed","number":674,"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/674","id":41395857,"html_url":"https://github.com/google/protobuf/pull/674","diff_url":"https://github.com/google/protobuf/pull/674.diff","patch_url":"https://github.com/google/protobuf/pull/674.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/674","number":674,"state":"closed","locked":false,"title":"Fix gcc C++11 build","user":{"login":"nsuke","id":3064114,"avatar_url":"https://avatars.githubusercontent.com/u/3064114?v=3","gravatar_id":"","url":"https://api.github.com/users/nsuke","html_url":"https://github.com/nsuke","followers_url":"https://api.github.com/users/nsuke/followers","following_url":"https://api.github.com/users/nsuke/following{/other_user}","gists_url":"https://api.github.com/users/nsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/nsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsuke/subscriptions","organizations_url":"https://api.github.com/users/nsuke/orgs","repos_url":"https://api.github.com/users/nsuke/repos","events_url":"https://api.github.com/users/nsuke/events{/privacy}","received_events_url":"https://api.github.com/users/nsuke/received_events","type":"User","site_admin":false},"body":"gcc with -std=c++11 failed because of conflicts between **google/protobuf/stubs/mathutil.h** and **cmath**.\r\n\r\n```\r\ncmake -GNinja -DCMAKE_CXX_FLAGS=\"-std=c++11 -DLANG_CXX11\" ../cmake && ninja\r\n\r\n[83/345] Building CXX object CMakeFiles/libprotobuf.dir/var/local/protobuf/src/google/protobuf/util/internal/utility.cc.o\r\nFAILED: /usr/bin/c++   -DGOOGLE_PROTOBUF_CMAKE_BUILD -DHAVE_PTHREAD -DLIBPROTOBUF_EXPORTS -std=c++11 -DLANG_CXX11 -I. -I/var/local/protobuf/src -I/var/local/protobuf/gmock -I/var/local/protobuf/gmock/gtest -I/var/local/protobuf/gmock/gtest/include -I/var/local/protobuf/gmock/include -MMD -MT CMakeFiles/libprotobuf.dir/var/local/protobuf/src/google/protobuf/util/internal/utility.cc.o -MF \"CMakeFiles/libprotobuf.dir/var/local/protobuf/src/google/protobuf/util/internal/utility.cc.o.d\" -o CMakeFiles/libprotobuf.dir/var/local/protobuf/src/google/protobuf/util/internal/utility.cc.o -c /var/local/protobuf/src/google/protobuf/util/internal/utility.cc\r\nIn file included from /var/local/protobuf/src/google/protobuf/util/internal/utility.cc:44:0:\r\n/var/local/protobuf/src/google/protobuf/stubs/mathlimits.h: In static member function 'static bool google::protobuf::MathLimits<double>::IsFinite(google::protobuf::MathLimits<double>::Type)':\r\n/var/local/protobuf/src/google/protobuf/stubs/mathlimits.h:233:55: error: call of overloaded 'isinf(const Type&)' is ambiguous\r\n   static bool IsFinite(const Type x) { return !isinf(x)  &&  !isnan(x); } \\\r\n...\r\n```\r\n(should be reproducible on plain ubuntu 14.04 with default gcc 4.8)\r\n\r\nThe incompatibility was already documented in the mathutil.h header comment and could be worked around by avoiding any direct or indirect **cmath** includes before **mathutil.h**.","created_at":"2015-08-01T03:56:31Z","updated_at":"2015-08-26T00:04:53Z","closed_at":"2015-08-26T00:04:53Z","merged_at":null,"merge_commit_sha":"170a6b2f5dd5389f2e7c83ccd2772dd910e75dbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/674/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/674/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/674/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/992531723cad417b4035d54dbca598d19868b69a","head":{"label":"nsuke:gcc-c++11-fix","ref":"gcc-c++11-fix","sha":"992531723cad417b4035d54dbca598d19868b69a","user":{"login":"nsuke","id":3064114,"avatar_url":"https://avatars.githubusercontent.com/u/3064114?v=3","gravatar_id":"","url":"https://api.github.com/users/nsuke","html_url":"https://github.com/nsuke","followers_url":"https://api.github.com/users/nsuke/followers","following_url":"https://api.github.com/users/nsuke/following{/other_user}","gists_url":"https://api.github.com/users/nsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/nsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsuke/subscriptions","organizations_url":"https://api.github.com/users/nsuke/orgs","repos_url":"https://api.github.com/users/nsuke/repos","events_url":"https://api.github.com/users/nsuke/events{/privacy}","received_events_url":"https://api.github.com/users/nsuke/received_events","type":"User","site_admin":false},"repo":{"id":27064711,"name":"protobuf","full_name":"nsuke/protobuf","owner":{"login":"nsuke","id":3064114,"avatar_url":"https://avatars.githubusercontent.com/u/3064114?v=3","gravatar_id":"","url":"https://api.github.com/users/nsuke","html_url":"https://github.com/nsuke","followers_url":"https://api.github.com/users/nsuke/followers","following_url":"https://api.github.com/users/nsuke/following{/other_user}","gists_url":"https://api.github.com/users/nsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/nsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsuke/subscriptions","organizations_url":"https://api.github.com/users/nsuke/orgs","repos_url":"https://api.github.com/users/nsuke/repos","events_url":"https://api.github.com/users/nsuke/events{/privacy}","received_events_url":"https://api.github.com/users/nsuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsuke/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/nsuke/protobuf","forks_url":"https://api.github.com/repos/nsuke/protobuf/forks","keys_url":"https://api.github.com/repos/nsuke/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsuke/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsuke/protobuf/teams","hooks_url":"https://api.github.com/repos/nsuke/protobuf/hooks","issue_events_url":"https://api.github.com/repos/nsuke/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/nsuke/protobuf/events","assignees_url":"https://api.github.com/repos/nsuke/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/nsuke/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/nsuke/protobuf/tags","blobs_url":"https://api.github.com/repos/nsuke/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsuke/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsuke/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsuke/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsuke/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/nsuke/protobuf/languages","stargazers_url":"https://api.github.com/repos/nsuke/protobuf/stargazers","contributors_url":"https://api.github.com/repos/nsuke/protobuf/contributors","subscribers_url":"https://api.github.com/repos/nsuke/protobuf/subscribers","subscription_url":"https://api.github.com/repos/nsuke/protobuf/subscription","commits_url":"https://api.github.com/repos/nsuke/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsuke/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsuke/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsuke/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsuke/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/nsuke/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsuke/protobuf/merges","archive_url":"https://api.github.com/repos/nsuke/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsuke/protobuf/downloads","issues_url":"https://api.github.com/repos/nsuke/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/nsuke/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/nsuke/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/nsuke/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsuke/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/nsuke/protobuf/releases{/id}","created_at":"2014-11-24T07:00:22Z","updated_at":"2014-11-24T07:00:25Z","pushed_at":"2015-08-01T03:52:16Z","git_url":"git://github.com/nsuke/protobuf.git","ssh_url":"git@github.com:nsuke/protobuf.git","clone_url":"https://github.com/nsuke/protobuf.git","svn_url":"https://github.com/nsuke/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":30746,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"bfbf35da9e3d97275ddf718f1e34e051d24f3be2","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","created_at":"2014-08-26T15:52:15Z","updated_at":"2015-08-25T15:58:38Z","pushed_at":"2015-08-26T00:04:06Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":49258,"stargazers_count":4704,"watchers_count":4704,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1295,"mirror_url":null,"open_issues_count":204,"forks":1295,"open_issues":204,"watchers":4704,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/674"},"html":{"href":"https://github.com/google/protobuf/pull/674"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/674"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/992531723cad417b4035d54dbca598d19868b69a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":9,"changed_files":2}}