{"action":"created","issue":{"url":"https://api.github.com/repos/jordansissel/fpm/issues/936","labels_url":"https://api.github.com/repos/jordansissel/fpm/issues/936/labels{/name}","comments_url":"https://api.github.com/repos/jordansissel/fpm/issues/936/comments","events_url":"https://api.github.com/repos/jordansissel/fpm/issues/936/events","html_url":"https://github.com/jordansissel/fpm/pull/936","id":87108185,"number":936,"title":"Removed the numeric-owner tar flag when deb_user=root","user":{"login":"jhooyberghs","id":4362619,"avatar_url":"https://avatars.githubusercontent.com/u/4362619?v=3","gravatar_id":"","url":"https://api.github.com/users/jhooyberghs","html_url":"https://github.com/jhooyberghs","followers_url":"https://api.github.com/users/jhooyberghs/followers","following_url":"https://api.github.com/users/jhooyberghs/following{/other_user}","gists_url":"https://api.github.com/users/jhooyberghs/gists{/gist_id}","starred_url":"https://api.github.com/users/jhooyberghs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhooyberghs/subscriptions","organizations_url":"https://api.github.com/users/jhooyberghs/orgs","repos_url":"https://api.github.com/users/jhooyberghs/repos","events_url":"https://api.github.com/users/jhooyberghs/events{/privacy}","received_events_url":"https://api.github.com/users/jhooyberghs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-10T21:09:08Z","updated_at":"2015-08-07T06:19:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jordansissel/fpm/pulls/936","html_url":"https://github.com/jordansissel/fpm/pull/936","diff_url":"https://github.com/jordansissel/fpm/pull/936.diff","patch_url":"https://github.com/jordansissel/fpm/pull/936.patch"},"body":"I removed a couple of lines of code that made it impossible to specify only a deb-user or deb-group without the other. I don't know why this was the way it was, so feel free to refuse this if this should be the way it is now.\r\n\r\nCurrent situation\r\nfpm --verbose -s dir -t deb -n testpackage --architecture all -C test --prefix /opt  --deb-user testuser --iteration 1 .\r\ndpkg-deb -c testpackage_1.0-1_all.deb \r\ndrwx------ 1000/0            0 2015-06-10 22:53 ./\r\ndrwxrwxr-x 1000/0            0 2015-06-10 22:53 ./usr/\r\ndrwxrwxr-x 1000/0            0 2015-06-10 22:53 ./usr/share/\r\ndrwxrwxr-x 1000/0            0 2015-06-10 22:53 ./usr/share/doc/\r\n......\r\nYou can see the deb-user being set to 1000, where I would expect to see 'testuser'.\r\n\r\nWith the change, there's no more numerical tar tag and therefor (the for me expected) folllowing result:\r\n/fpm --verbose -s dir -t deb -n testpackage --architecture all -C test --prefix /opt  --deb-user testuser --iteration 2 .\r\ndpkg -c testpackage_1.0-2_all.deb \r\ndrwx------ testuser/root     0 2015-06-10 22:55 ./\r\ndrwxrwxr-x testuser/root     0 2015-06-10 22:55 ./usr/\r\ndrwxrwxr-x testuser/root     0 2015-06-10 22:55 ./usr/share/\r\n......"},"comment":{"url":"https://api.github.com/repos/jordansissel/fpm/issues/comments/128609485","html_url":"https://github.com/jordansissel/fpm/pull/936#issuecomment-128609485","issue_url":"https://api.github.com/repos/jordansissel/fpm/issues/936","id":128609485,"user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"created_at":"2015-08-07T06:19:22Z","updated_at":"2015-08-07T06:19:22Z","body":"Here's my proposed patch that I _think_ may work towards solving this:\r\n\r\n```\r\ndiff --git a/lib/fpm/package/deb.rb b/lib/fpm/package/deb.rb\r\nindex 3592389..cfd2d9e 100644\r\n--- a/lib/fpm/package/deb.rb\r\n+++ b/lib/fpm/package/deb.rb\r\n@@ -796,7 +796,7 @@ class FPM::Package::Deb < FPM::Package\r\n \r\n       if !attributes[:deb_group].nil?\r\n         if attributes[:deb_group] == 'root'\r\n-          data_tar_flags += [ \"--numeric-owner\", \"--group\", \"0\" ]\r\n+          data_tar_flags += [ \"--group\", \"0\" ]\r\n         else\r\n           data_tar_flags += [ \"--group\", attributes[:deb_group] ]\r\n         end\r\n\r\n```"}}