{"action":"created","comment":{"url":"https://api.github.com/repos/OP2/PyOP2/pulls/comments/28726029","id":28726029,"diff_hunk":"@@ -2864,46 +2840,39 @@ def __len__(self):\n     def __getslice__(self, i, j):\n         raise NotImplementedError(\"Slicing maps is not currently implemented\")\n \n-    @property\n+    @cached_property\n     def _argtype(self):\n         \"\"\"Ctypes argtype for this :class:`Map`\"\"\"\n-        return np.ctypeslib.ndpointer(self._values.dtype, shape=self._values.shape)\n+        return ctypes.c_voidp\n \n-    @property\n+    @cached_property\n     def split(self):\n         return (self,)\n \n-    @property\n+    @cached_property\n     def iteration_region(self):\n         \"\"\"Return the iteration region for the current map. For a normal map it\n         will always be ALL. For a :class:`DecoratedMap` it will specify over which mesh\n         region the iteration will take place.\"\"\"\n         return frozenset([ALL])\n \n-    @property\n-    def implicit_bcs(self):\n-        \"\"\"Return any implicit (extruded \"top\" or \"bottom\") bcs to\n-        apply to this :class:`Map`.  Normally empty except in the case of\n-        some :class:`DecoratedMap`\\s.\"\"\"\n-        return frozenset([])","path":"pyop2/base.py","position":929,"original_position":929,"commit_id":"69fae950f857afdff59f371f5291f5bf16f9fc71","original_commit_id":"69fae950f857afdff59f371f5291f5bf16f9fc71","user":{"login":"dorugeber","id":5711063,"avatar_url":"https://avatars.githubusercontent.com/u/5711063?v=3","gravatar_id":"","url":"https://api.github.com/users/dorugeber","html_url":"https://github.com/dorugeber","followers_url":"https://api.github.com/users/dorugeber/followers","following_url":"https://api.github.com/users/dorugeber/following{/other_user}","gists_url":"https://api.github.com/users/dorugeber/gists{/gist_id}","starred_url":"https://api.github.com/users/dorugeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorugeber/subscriptions","organizations_url":"https://api.github.com/users/dorugeber/orgs","repos_url":"https://api.github.com/users/dorugeber/repos","events_url":"https://api.github.com/users/dorugeber/events{/privacy}","received_events_url":"https://api.github.com/users/dorugeber/received_events","type":"User","site_admin":false},"body":"Ditto not sure why this dies, but okay.","created_at":"2015-04-20T20:31:44Z","updated_at":"2015-04-20T20:31:44Z","html_url":"https://github.com/OP2/PyOP2/pull/435#discussion_r28726029","pull_request_url":"https://api.github.com/repos/OP2/PyOP2/pulls/435","_links":{"self":{"href":"https://api.github.com/repos/OP2/PyOP2/pulls/comments/28726029"},"html":{"href":"https://github.com/OP2/PyOP2/pull/435#discussion_r28726029"},"pull_request":{"href":"https://api.github.com/repos/OP2/PyOP2/pulls/435"}}},"pull_request":{"url":"https://api.github.com/repos/OP2/PyOP2/pulls/435","id":33675478,"html_url":"https://github.com/OP2/PyOP2/pull/435","diff_url":"https://github.com/OP2/PyOP2/pull/435.diff","patch_url":"https://github.com/OP2/PyOP2/pull/435.patch","issue_url":"https://api.github.com/repos/OP2/PyOP2/issues/435","number":435,"state":"open","locked":false,"title":"Rework overhead reduction","user":{"login":"wence-","id":1126981,"avatar_url":"https://avatars.githubusercontent.com/u/1126981?v=3","gravatar_id":"","url":"https://api.github.com/users/wence-","html_url":"https://github.com/wence-","followers_url":"https://api.github.com/users/wence-/followers","following_url":"https://api.github.com/users/wence-/following{/other_user}","gists_url":"https://api.github.com/users/wence-/gists{/gist_id}","starred_url":"https://api.github.com/users/wence-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wence-/subscriptions","organizations_url":"https://api.github.com/users/wence-/orgs","repos_url":"https://api.github.com/users/wence-/repos","events_url":"https://api.github.com/users/wence-/events{/privacy}","received_events_url":"https://api.github.com/users/wence-/received_events","type":"User","site_admin":false},"body":"Here's a reworked lot of reduction in the time we take to do nothing.  It works with lazy (loop fusion, yay!) and gives reasonable speedups for small problems.  I would like confirmation that this works properly for the loop fusion cases: there are no tests in pyop2 of this functionaliy.","created_at":"2015-04-20T15:16:53Z","updated_at":"2015-04-20T20:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40d6e9640e7e28f250c26d24fd36b6ca568de7df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP2/PyOP2/pulls/435/commits","review_comments_url":"https://api.github.com/repos/OP2/PyOP2/pulls/435/comments","review_comment_url":"https://api.github.com/repos/OP2/PyOP2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP2/PyOP2/issues/435/comments","statuses_url":"https://api.github.com/repos/OP2/PyOP2/statuses/69fae950f857afdff59f371f5291f5bf16f9fc71","head":{"label":"OP2:rework-overhead-reduction","ref":"rework-overhead-reduction","sha":"69fae950f857afdff59f371f5291f5bf16f9fc71","user":{"login":"OP2","id":1544411,"avatar_url":"https://avatars.githubusercontent.com/u/1544411?v=3","gravatar_id":"","url":"https://api.github.com/users/OP2","html_url":"https://github.com/OP2","followers_url":"https://api.github.com/users/OP2/followers","following_url":"https://api.github.com/users/OP2/following{/other_user}","gists_url":"https://api.github.com/users/OP2/gists{/gist_id}","starred_url":"https://api.github.com/users/OP2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP2/subscriptions","organizations_url":"https://api.github.com/users/OP2/orgs","repos_url":"https://api.github.com/users/OP2/repos","events_url":"https://api.github.com/users/OP2/events{/privacy}","received_events_url":"https://api.github.com/users/OP2/received_events","type":"Organization","site_admin":false},"repo":{"id":4648505,"name":"PyOP2","full_name":"OP2/PyOP2","owner":{"login":"OP2","id":1544411,"avatar_url":"https://avatars.githubusercontent.com/u/1544411?v=3","gravatar_id":"","url":"https://api.github.com/users/OP2","html_url":"https://github.com/OP2","followers_url":"https://api.github.com/users/OP2/followers","following_url":"https://api.github.com/users/OP2/following{/other_user}","gists_url":"https://api.github.com/users/OP2/gists{/gist_id}","starred_url":"https://api.github.com/users/OP2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP2/subscriptions","organizations_url":"https://api.github.com/users/OP2/orgs","repos_url":"https://api.github.com/users/OP2/repos","events_url":"https://api.github.com/users/OP2/events{/privacy}","received_events_url":"https://api.github.com/users/OP2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP2/PyOP2","description":"Framework for performance-portable parallel computations on unstructured meshes","fork":false,"url":"https://api.github.com/repos/OP2/PyOP2","forks_url":"https://api.github.com/repos/OP2/PyOP2/forks","keys_url":"https://api.github.com/repos/OP2/PyOP2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP2/PyOP2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP2/PyOP2/teams","hooks_url":"https://api.github.com/repos/OP2/PyOP2/hooks","issue_events_url":"https://api.github.com/repos/OP2/PyOP2/issues/events{/number}","events_url":"https://api.github.com/repos/OP2/PyOP2/events","assignees_url":"https://api.github.com/repos/OP2/PyOP2/assignees{/user}","branches_url":"https://api.github.com/repos/OP2/PyOP2/branches{/branch}","tags_url":"https://api.github.com/repos/OP2/PyOP2/tags","blobs_url":"https://api.github.com/repos/OP2/PyOP2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP2/PyOP2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP2/PyOP2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP2/PyOP2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP2/PyOP2/statuses/{sha}","languages_url":"https://api.github.com/repos/OP2/PyOP2/languages","stargazers_url":"https://api.github.com/repos/OP2/PyOP2/stargazers","contributors_url":"https://api.github.com/repos/OP2/PyOP2/contributors","subscribers_url":"https://api.github.com/repos/OP2/PyOP2/subscribers","subscription_url":"https://api.github.com/repos/OP2/PyOP2/subscription","commits_url":"https://api.github.com/repos/OP2/PyOP2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP2/PyOP2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP2/PyOP2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP2/PyOP2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP2/PyOP2/contents/{+path}","compare_url":"https://api.github.com/repos/OP2/PyOP2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP2/PyOP2/merges","archive_url":"https://api.github.com/repos/OP2/PyOP2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP2/PyOP2/downloads","issues_url":"https://api.github.com/repos/OP2/PyOP2/issues{/number}","pulls_url":"https://api.github.com/repos/OP2/PyOP2/pulls{/number}","milestones_url":"https://api.github.com/repos/OP2/PyOP2/milestones{/number}","notifications_url":"https://api.github.com/repos/OP2/PyOP2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP2/PyOP2/labels{/name}","releases_url":"https://api.github.com/repos/OP2/PyOP2/releases{/id}","created_at":"2012-06-13T08:28:09Z","updated_at":"2015-04-17T21:23:32Z","pushed_at":"2015-04-20T18:44:36Z","git_url":"git://github.com/OP2/PyOP2.git","ssh_url":"git@github.com:OP2/PyOP2.git","clone_url":"https://github.com/OP2/PyOP2.git","svn_url":"https://github.com/OP2/PyOP2","homepage":"op2.github.com/PyOP2","size":18741,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":31,"forks":12,"open_issues":31,"watchers":22,"default_branch":"master"}},"base":{"label":"OP2:master","ref":"master","sha":"af03a7e72e4419aef19708570d7bd33cc927751c","user":{"login":"OP2","id":1544411,"avatar_url":"https://avatars.githubusercontent.com/u/1544411?v=3","gravatar_id":"","url":"https://api.github.com/users/OP2","html_url":"https://github.com/OP2","followers_url":"https://api.github.com/users/OP2/followers","following_url":"https://api.github.com/users/OP2/following{/other_user}","gists_url":"https://api.github.com/users/OP2/gists{/gist_id}","starred_url":"https://api.github.com/users/OP2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP2/subscriptions","organizations_url":"https://api.github.com/users/OP2/orgs","repos_url":"https://api.github.com/users/OP2/repos","events_url":"https://api.github.com/users/OP2/events{/privacy}","received_events_url":"https://api.github.com/users/OP2/received_events","type":"Organization","site_admin":false},"repo":{"id":4648505,"name":"PyOP2","full_name":"OP2/PyOP2","owner":{"login":"OP2","id":1544411,"avatar_url":"https://avatars.githubusercontent.com/u/1544411?v=3","gravatar_id":"","url":"https://api.github.com/users/OP2","html_url":"https://github.com/OP2","followers_url":"https://api.github.com/users/OP2/followers","following_url":"https://api.github.com/users/OP2/following{/other_user}","gists_url":"https://api.github.com/users/OP2/gists{/gist_id}","starred_url":"https://api.github.com/users/OP2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP2/subscriptions","organizations_url":"https://api.github.com/users/OP2/orgs","repos_url":"https://api.github.com/users/OP2/repos","events_url":"https://api.github.com/users/OP2/events{/privacy}","received_events_url":"https://api.github.com/users/OP2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP2/PyOP2","description":"Framework for performance-portable parallel computations on unstructured meshes","fork":false,"url":"https://api.github.com/repos/OP2/PyOP2","forks_url":"https://api.github.com/repos/OP2/PyOP2/forks","keys_url":"https://api.github.com/repos/OP2/PyOP2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP2/PyOP2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP2/PyOP2/teams","hooks_url":"https://api.github.com/repos/OP2/PyOP2/hooks","issue_events_url":"https://api.github.com/repos/OP2/PyOP2/issues/events{/number}","events_url":"https://api.github.com/repos/OP2/PyOP2/events","assignees_url":"https://api.github.com/repos/OP2/PyOP2/assignees{/user}","branches_url":"https://api.github.com/repos/OP2/PyOP2/branches{/branch}","tags_url":"https://api.github.com/repos/OP2/PyOP2/tags","blobs_url":"https://api.github.com/repos/OP2/PyOP2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP2/PyOP2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP2/PyOP2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP2/PyOP2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP2/PyOP2/statuses/{sha}","languages_url":"https://api.github.com/repos/OP2/PyOP2/languages","stargazers_url":"https://api.github.com/repos/OP2/PyOP2/stargazers","contributors_url":"https://api.github.com/repos/OP2/PyOP2/contributors","subscribers_url":"https://api.github.com/repos/OP2/PyOP2/subscribers","subscription_url":"https://api.github.com/repos/OP2/PyOP2/subscription","commits_url":"https://api.github.com/repos/OP2/PyOP2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP2/PyOP2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP2/PyOP2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP2/PyOP2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP2/PyOP2/contents/{+path}","compare_url":"https://api.github.com/repos/OP2/PyOP2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP2/PyOP2/merges","archive_url":"https://api.github.com/repos/OP2/PyOP2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP2/PyOP2/downloads","issues_url":"https://api.github.com/repos/OP2/PyOP2/issues{/number}","pulls_url":"https://api.github.com/repos/OP2/PyOP2/pulls{/number}","milestones_url":"https://api.github.com/repos/OP2/PyOP2/milestones{/number}","notifications_url":"https://api.github.com/repos/OP2/PyOP2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP2/PyOP2/labels{/name}","releases_url":"https://api.github.com/repos/OP2/PyOP2/releases{/id}","created_at":"2012-06-13T08:28:09Z","updated_at":"2015-04-17T21:23:32Z","pushed_at":"2015-04-20T18:44:36Z","git_url":"git://github.com/OP2/PyOP2.git","ssh_url":"git@github.com:OP2/PyOP2.git","clone_url":"https://github.com/OP2/PyOP2.git","svn_url":"https://github.com/OP2/PyOP2","homepage":"op2.github.com/PyOP2","size":18741,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":31,"forks":12,"open_issues":31,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP2/PyOP2/pulls/435"},"html":{"href":"https://github.com/OP2/PyOP2/pull/435"},"issue":{"href":"https://api.github.com/repos/OP2/PyOP2/issues/435"},"comments":{"href":"https://api.github.com/repos/OP2/PyOP2/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/OP2/PyOP2/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/OP2/PyOP2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP2/PyOP2/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/OP2/PyOP2/statuses/69fae950f857afdff59f371f5291f5bf16f9fc71"}}}}