{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments/30550526","id":30550526,"diff_hunk":"@@ -0,0 +1,101 @@\n+//\n+//  CourseContentView.swift\n+//  edX\n+//\n+//  Created by Ehmad Zubair Chughtai on 18/05/2015.\n+//  Copyright (c) 2015 edX. All rights reserved.\n+//\n+\n+import UIKit\n+\n+class CourseContentView: UIView {\n+\n+    let fontStyle = OEXTextStyle(font: OEXTextFont.ThemeSans, size: 15.0)\n+    let smallerFontStyle = OEXTextStyle(font: OEXTextFont.ThemeSans, size: 13.0)\n+    var titleLabel = UILabel()\n+    var leftImageButton = UIButton.buttonWithType(UIButtonType.Custom) as! UIButton","path":"Source/CourseContentView.swift","position":16,"original_position":16,"commit_id":"76988ab88ec0e30eab0d6b2001bb71c1205c509a","original_commit_id":"76988ab88ec0e30eab0d6b2001bb71c1205c509a","user":{"login":"aleffert","id":114396,"avatar_url":"https://avatars.githubusercontent.com/u/114396?v=3","gravatar_id":"","url":"https://api.github.com/users/aleffert","html_url":"https://github.com/aleffert","followers_url":"https://api.github.com/users/aleffert/followers","following_url":"https://api.github.com/users/aleffert/following{/other_user}","gists_url":"https://api.github.com/users/aleffert/gists{/gist_id}","starred_url":"https://api.github.com/users/aleffert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleffert/subscriptions","organizations_url":"https://api.github.com/users/aleffert/orgs","repos_url":"https://api.github.com/users/aleffert/repos","events_url":"https://api.github.com/users/aleffert/events{/privacy}","received_events_url":"https://api.github.com/users/aleffert/received_events","type":"User","site_admin":false},"body":"Instead of ``left`` and ``right``, these should be ``leading`` and ``trailing`` or maybe ``primary`` and ``secondary``. This way it makes sense with RTL.","created_at":"2015-05-18T21:42:45Z","updated_at":"2015-05-18T21:42:45Z","html_url":"https://github.com/edx/edx-app-ios/pull/173#discussion_r30550526","pull_request_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments/30550526"},"html":{"href":"https://github.com/edx/edx-app-ios/pull/173#discussion_r30550526"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/173","id":35498191,"html_url":"https://github.com/edx/edx-app-ios/pull/173","diff_url":"https://github.com/edx/edx-app-ios/pull/173.diff","patch_url":"https://github.com/edx/edx-app-ios/pull/173.patch","issue_url":"https://api.github.com/repos/edx/edx-app-ios/issues/173","number":173,"state":"open","locked":false,"title":"Added custom cells to CourseOutline Screen","user":{"login":"ehmadzubair","id":10597112,"avatar_url":"https://avatars.githubusercontent.com/u/10597112?v=3","gravatar_id":"","url":"https://api.github.com/users/ehmadzubair","html_url":"https://github.com/ehmadzubair","followers_url":"https://api.github.com/users/ehmadzubair/followers","following_url":"https://api.github.com/users/ehmadzubair/following{/other_user}","gists_url":"https://api.github.com/users/ehmadzubair/gists{/gist_id}","starred_url":"https://api.github.com/users/ehmadzubair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehmadzubair/subscriptions","organizations_url":"https://api.github.com/users/ehmadzubair/orgs","repos_url":"https://api.github.com/users/ehmadzubair/repos","events_url":"https://api.github.com/users/ehmadzubair/events{/privacy}","received_events_url":"https://api.github.com/users/ehmadzubair/received_events","type":"User","site_admin":false},"body":"Four types of Course blocks now have custom cells.\r\n- HTML - `CourseHTMLTableViewCell`\r\n- Video - `CourseVideoTableViewCell`\r\n- Problem - `CourseProblemTableViewCell`\r\n- Unknown - `CourseUnknownTableViewCell`\r\n\r\nI was considering SubClassing UITableViewCell to have `setStyles()` , `addSubviews()` & `setConstraints()` methods in the superclass as much as possible. However, the guidelines conflict with that design. Hence, there's a lot of repeated code... Hope it's okay.\r\n\r\nThe Colours are set from `OEXStyles`. One color is used outside of edX Design Palette (http://ux.edx.org/#colors), The `CourseOutlineFooterView` background color. Should i add the color (neutral-xxlight) to the code?\r\n\r\nThe init(frame:) method is useless, but it has to be there because we're calling the designated initialiser.","created_at":"2015-05-15T09:38:34Z","updated_at":"2015-05-18T21:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a62ec2dd97572b435d8d67667c17689906ab26c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/173/commits","review_comments_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/173/comments","review_comment_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/issues/173/comments","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/76988ab88ec0e30eab0d6b2001bb71c1205c509a","head":{"label":"edx:ehmad-outlineViewStyles","ref":"ehmad-outlineViewStyles","sha":"76988ab88ec0e30eab0d6b2001bb71c1205c509a","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251733,"name":"edx-app-ios","full_name":"edx/edx-app-ios","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-ios","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-ios","forks_url":"https://api.github.com/repos/edx/edx-app-ios/forks","keys_url":"https://api.github.com/repos/edx/edx-app-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-ios/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-ios/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-ios/events","assignees_url":"https://api.github.com/repos/edx/edx-app-ios/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-ios/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-ios/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-ios/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-ios/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-ios/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-ios/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-ios/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-ios/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-ios/merges","archive_url":"https://api.github.com/repos/edx/edx-app-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-ios/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-ios/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-ios/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-ios/releases{/id}","created_at":"2015-01-14T15:49:29Z","updated_at":"2015-05-08T17:30:34Z","pushed_at":"2015-05-18T21:22:42Z","git_url":"git://github.com/edx/edx-app-ios.git","ssh_url":"git@github.com:edx/edx-app-ios.git","clone_url":"https://github.com/edx/edx-app-ios.git","svn_url":"https://github.com/edx/edx-app-ios","homepage":null,"size":297024,"stargazers_count":16,"watchers_count":16,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":4,"forks":17,"open_issues":4,"watchers":16,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"334cfc81ddf0db653c21b56f29ead9807e291fc5","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251733,"name":"edx-app-ios","full_name":"edx/edx-app-ios","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-ios","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-ios","forks_url":"https://api.github.com/repos/edx/edx-app-ios/forks","keys_url":"https://api.github.com/repos/edx/edx-app-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-ios/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-ios/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-ios/events","assignees_url":"https://api.github.com/repos/edx/edx-app-ios/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-ios/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-ios/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-ios/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-ios/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-ios/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-ios/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-ios/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-ios/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-ios/merges","archive_url":"https://api.github.com/repos/edx/edx-app-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-ios/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-ios/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-ios/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-ios/releases{/id}","created_at":"2015-01-14T15:49:29Z","updated_at":"2015-05-08T17:30:34Z","pushed_at":"2015-05-18T21:22:42Z","git_url":"git://github.com/edx/edx-app-ios.git","ssh_url":"git@github.com:edx/edx-app-ios.git","clone_url":"https://github.com/edx/edx-app-ios.git","svn_url":"https://github.com/edx/edx-app-ios","homepage":null,"size":297024,"stargazers_count":16,"watchers_count":16,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":4,"forks":17,"open_issues":4,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/173"},"html":{"href":"https://github.com/edx/edx-app-ios/pull/173"},"issue":{"href":"https://api.github.com/repos/edx/edx-app-ios/issues/173"},"comments":{"href":"https://api.github.com/repos/edx/edx-app-ios/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-app-ios/statuses/76988ab88ec0e30eab0d6b2001bb71c1205c509a"}}}}