{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/6088","labels_url":"https://api.github.com/repos/servo/servo/issues/6088/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/6088/comments","events_url":"https://api.github.com/repos/servo/servo/issues/6088/events","html_url":"https://github.com/servo/servo/issues/6088","id":77019172,"number":6088,"title":"Replace /usr/bin/find hacks in dependency makefiles with Cargo variables","user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/A-cargo","name":"A-cargo","color":"d7e102"},{"url":"https://api.github.com/repos/servo/servo/labels/E-easy","name":"E-easy","color":"02e10c"},{"url":"https://api.github.com/repos/servo/servo/labels/I-bustage","name":"I-bustage","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-16T11:40:09Z","updated_at":"2015-05-27T18:30:13Z","closed_at":null,"body":"Some of our dependencies makefiles have hacks like this:\r\n\r\nhttps://github.com/servo/rust-azure/blob/11d7292919a365c55ca6204c465c5eeefcabfe05/makefile.cargo#L62\r\n```Makefile\r\nSKIA_OUTDIR = $(shell find $(OUT_DIR)/../.. -name 'skia-*' -type d)/out\r\n```\r\n… which break when e.g. there is more then one directory matching `skia-*` (multiple versions have been built without `cargo clean`).\r\n\r\nInstead, we should be using Cargo’s metadata and `DEP_*` environment variables: http://doc.crates.io/build-script.html#the-links-manifest-key"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/106025606","html_url":"https://github.com/servo/servo/issues/6088#issuecomment-106025606","issue_url":"https://api.github.com/repos/servo/servo/issues/6088","id":106025606,"user":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"created_at":"2015-05-27T18:30:13Z","updated_at":"2015-05-27T18:30:13Z","body":"If anyone would like to help out with the remaining packages, see the various pull requests linked above for examples of how to fix this."}}