{"action":"created","issue":{"url":"https://api.github.com/repos/silas/node-consul/issues/16","labels_url":"https://api.github.com/repos/silas/node-consul/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/silas/node-consul/issues/16/comments","events_url":"https://api.github.com/repos/silas/node-consul/issues/16/events","html_url":"https://github.com/silas/node-consul/issues/16","id":105423625,"number":16,"title":"Lock Issues","user":{"login":"ekristen","id":48329,"avatar_url":"https://avatars.githubusercontent.com/u/48329?v=3","gravatar_id":"","url":"https://api.github.com/users/ekristen","html_url":"https://github.com/ekristen","followers_url":"https://api.github.com/users/ekristen/followers","following_url":"https://api.github.com/users/ekristen/following{/other_user}","gists_url":"https://api.github.com/users/ekristen/gists{/gist_id}","starred_url":"https://api.github.com/users/ekristen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekristen/subscriptions","organizations_url":"https://api.github.com/users/ekristen/orgs","repos_url":"https://api.github.com/users/ekristen/repos","events_url":"https://api.github.com/users/ekristen/events{/privacy}","received_events_url":"https://api.github.com/users/ekristen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-08T16:49:35Z","updated_at":"2015-10-03T21:35:00Z","closed_at":null,"body":"I had to comment out https://github.com/silas/node-consul/blob/master/lib/lock.js#L307-L315 and https://github.com/silas/node-consul/blob/master/lib/lock.js#L232-L235 to get the lock system to work reliably. \r\n\r\nI found that the monitor updates code is broken and the time is always going to fail, so basically after 15 seconds ( the default) it will always release the lock.\r\n\r\nI also found that the data.Flags would always fail on subsequent restarts of the application to check the lock. \r\n\r\nBy commenting out those two portions, the locking systems seems to work reliably for me now. "},"comment":{"url":"https://api.github.com/repos/silas/node-consul/issues/comments/145292389","html_url":"https://github.com/silas/node-consul/issues/16#issuecomment-145292389","issue_url":"https://api.github.com/repos/silas/node-consul/issues/16","id":145292389,"user":{"login":"silas","id":18528,"avatar_url":"https://avatars.githubusercontent.com/u/18528?v=3","gravatar_id":"","url":"https://api.github.com/users/silas","html_url":"https://github.com/silas","followers_url":"https://api.github.com/users/silas/followers","following_url":"https://api.github.com/users/silas/following{/other_user}","gists_url":"https://api.github.com/users/silas/gists{/gist_id}","starred_url":"https://api.github.com/users/silas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silas/subscriptions","organizations_url":"https://api.github.com/users/silas/orgs","repos_url":"https://api.github.com/users/silas/repos","events_url":"https://api.github.com/users/silas/events{/privacy}","received_events_url":"https://api.github.com/users/silas/received_events","type":"User","site_admin":false},"created_at":"2015-10-03T21:35:00Z","updated_at":"2015-10-03T21:35:00Z","body":"Want to try version `0.18.1` and let me know if that fixes (fbaf4dc) the monitor issue.\r\n\r\nI haven't been able to reproduce the `data.Flags` problem, can you give me some more info on your setup (consul version, server arch, etc...)."}}