{"action":"created","comment":{"url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/comments/27758632","id":27758632,"diff_hunk":"@@ -152,16 +152,6 @@ ms_ban(struct Client *client_p, struct Client *source_p, int parc, const char *p\n             return 0;\n         /* Deactivate, it will be reactivated later if appropriate. */\n         deactivate_conf(aconf, ptr);\n-        rb_free(aconf->user);\n-        aconf->user = NULL;\n-        rb_free(aconf->host);\n-        aconf->host = NULL;\n-        operhash_delete(aconf->info.oper);\n-        aconf->info.oper = NULL;\n-        rb_free(aconf->passwd);\n-        aconf->passwd = NULL;\n-        rb_free(aconf->spasswd);\n-        aconf->spasswd = NULL;","path":"modules/core/m_ban.c","position":13,"original_position":13,"commit_id":"badf3bb11e37e4bcfe2468bda970a4763f4ba332","original_commit_id":"2ee967366e6c2d34877990dc2a83c1590a19dd2a","user":{"login":"ariscop","id":1522423,"avatar_url":"https://avatars.githubusercontent.com/u/1522423?v=3","gravatar_id":"","url":"https://api.github.com/users/ariscop","html_url":"https://github.com/ariscop","followers_url":"https://api.github.com/users/ariscop/followers","following_url":"https://api.github.com/users/ariscop/following{/other_user}","gists_url":"https://api.github.com/users/ariscop/gists{/gist_id}","starred_url":"https://api.github.com/users/ariscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariscop/subscriptions","organizations_url":"https://api.github.com/users/ariscop/orgs","repos_url":"https://api.github.com/users/ariscop/repos","events_url":"https://api.github.com/users/ariscop/events{/privacy}","received_events_url":"https://api.github.com/users/ariscop/received_events","type":"User","site_admin":false},"body":"turns out free_conf frees aconf as well, so this is also a use after free","created_at":"2015-04-03T21:55:32Z","updated_at":"2015-04-03T21:55:32Z","html_url":"https://github.com/Elemental-IRCd/elemental-ircd/pull/66#discussion_r27758632","pull_request_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/comments/27758632"},"html":{"href":"https://github.com/Elemental-IRCd/elemental-ircd/pull/66#discussion_r27758632"},"pull_request":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66","id":32617509,"html_url":"https://github.com/Elemental-IRCd/elemental-ircd/pull/66","diff_url":"https://github.com/Elemental-IRCd/elemental-ircd/pull/66.diff","patch_url":"https://github.com/Elemental-IRCd/elemental-ircd/pull/66.patch","issue_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues/66","number":66,"state":"open","locked":false,"title":"Coverity fixes","user":{"login":"ariscop","id":1522423,"avatar_url":"https://avatars.githubusercontent.com/u/1522423?v=3","gravatar_id":"","url":"https://api.github.com/users/ariscop","html_url":"https://github.com/ariscop","followers_url":"https://api.github.com/users/ariscop/followers","following_url":"https://api.github.com/users/ariscop/following{/other_user}","gists_url":"https://api.github.com/users/ariscop/gists{/gist_id}","starred_url":"https://api.github.com/users/ariscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariscop/subscriptions","organizations_url":"https://api.github.com/users/ariscop/orgs","repos_url":"https://api.github.com/users/ariscop/repos","events_url":"https://api.github.com/users/ariscop/events{/privacy}","received_events_url":"https://api.github.com/users/ariscop/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-03T21:21:59Z","updated_at":"2015-04-03T21:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f3a945371eaa84849793e2174de9f4123147603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66/commits","review_comments_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66/comments","review_comment_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues/66/comments","statuses_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/statuses/badf3bb11e37e4bcfe2468bda970a4763f4ba332","head":{"label":"ariscop:coverity","ref":"coverity","sha":"badf3bb11e37e4bcfe2468bda970a4763f4ba332","user":{"login":"ariscop","id":1522423,"avatar_url":"https://avatars.githubusercontent.com/u/1522423?v=3","gravatar_id":"","url":"https://api.github.com/users/ariscop","html_url":"https://github.com/ariscop","followers_url":"https://api.github.com/users/ariscop/followers","following_url":"https://api.github.com/users/ariscop/following{/other_user}","gists_url":"https://api.github.com/users/ariscop/gists{/gist_id}","starred_url":"https://api.github.com/users/ariscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariscop/subscriptions","organizations_url":"https://api.github.com/users/ariscop/orgs","repos_url":"https://api.github.com/users/ariscop/repos","events_url":"https://api.github.com/users/ariscop/events{/privacy}","received_events_url":"https://api.github.com/users/ariscop/received_events","type":"User","site_admin":false},"repo":{"id":33338863,"name":"elemental-ircd","full_name":"ariscop/elemental-ircd","owner":{"login":"ariscop","id":1522423,"avatar_url":"https://avatars.githubusercontent.com/u/1522423?v=3","gravatar_id":"","url":"https://api.github.com/users/ariscop","html_url":"https://github.com/ariscop","followers_url":"https://api.github.com/users/ariscop/followers","following_url":"https://api.github.com/users/ariscop/following{/other_user}","gists_url":"https://api.github.com/users/ariscop/gists{/gist_id}","starred_url":"https://api.github.com/users/ariscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariscop/subscriptions","organizations_url":"https://api.github.com/users/ariscop/orgs","repos_url":"https://api.github.com/users/ariscop/repos","events_url":"https://api.github.com/users/ariscop/events{/privacy}","received_events_url":"https://api.github.com/users/ariscop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariscop/elemental-ircd","description":"Continuation of ShadowIRCD to meet people's needs","fork":true,"url":"https://api.github.com/repos/ariscop/elemental-ircd","forks_url":"https://api.github.com/repos/ariscop/elemental-ircd/forks","keys_url":"https://api.github.com/repos/ariscop/elemental-ircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariscop/elemental-ircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariscop/elemental-ircd/teams","hooks_url":"https://api.github.com/repos/ariscop/elemental-ircd/hooks","issue_events_url":"https://api.github.com/repos/ariscop/elemental-ircd/issues/events{/number}","events_url":"https://api.github.com/repos/ariscop/elemental-ircd/events","assignees_url":"https://api.github.com/repos/ariscop/elemental-ircd/assignees{/user}","branches_url":"https://api.github.com/repos/ariscop/elemental-ircd/branches{/branch}","tags_url":"https://api.github.com/repos/ariscop/elemental-ircd/tags","blobs_url":"https://api.github.com/repos/ariscop/elemental-ircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariscop/elemental-ircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariscop/elemental-ircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariscop/elemental-ircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariscop/elemental-ircd/statuses/{sha}","languages_url":"https://api.github.com/repos/ariscop/elemental-ircd/languages","stargazers_url":"https://api.github.com/repos/ariscop/elemental-ircd/stargazers","contributors_url":"https://api.github.com/repos/ariscop/elemental-ircd/contributors","subscribers_url":"https://api.github.com/repos/ariscop/elemental-ircd/subscribers","subscription_url":"https://api.github.com/repos/ariscop/elemental-ircd/subscription","commits_url":"https://api.github.com/repos/ariscop/elemental-ircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariscop/elemental-ircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariscop/elemental-ircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariscop/elemental-ircd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariscop/elemental-ircd/contents/{+path}","compare_url":"https://api.github.com/repos/ariscop/elemental-ircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariscop/elemental-ircd/merges","archive_url":"https://api.github.com/repos/ariscop/elemental-ircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariscop/elemental-ircd/downloads","issues_url":"https://api.github.com/repos/ariscop/elemental-ircd/issues{/number}","pulls_url":"https://api.github.com/repos/ariscop/elemental-ircd/pulls{/number}","milestones_url":"https://api.github.com/repos/ariscop/elemental-ircd/milestones{/number}","notifications_url":"https://api.github.com/repos/ariscop/elemental-ircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariscop/elemental-ircd/labels{/name}","releases_url":"https://api.github.com/repos/ariscop/elemental-ircd/releases{/id}","created_at":"2015-04-03T00:44:35Z","updated_at":"2015-04-03T00:44:37Z","pushed_at":"2015-04-03T21:42:40Z","git_url":"git://github.com/ariscop/elemental-ircd.git","ssh_url":"git@github.com:ariscop/elemental-ircd.git","clone_url":"https://github.com/ariscop/elemental-ircd.git","svn_url":"https://github.com/ariscop/elemental-ircd","homepage":"","size":8969,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Elemental-IRCd:master","ref":"master","sha":"83c3c3ae578304175376d60c2b3af302bbdca22b","user":{"login":"Elemental-IRCd","id":6687466,"avatar_url":"https://avatars.githubusercontent.com/u/6687466?v=3","gravatar_id":"","url":"https://api.github.com/users/Elemental-IRCd","html_url":"https://github.com/Elemental-IRCd","followers_url":"https://api.github.com/users/Elemental-IRCd/followers","following_url":"https://api.github.com/users/Elemental-IRCd/following{/other_user}","gists_url":"https://api.github.com/users/Elemental-IRCd/gists{/gist_id}","starred_url":"https://api.github.com/users/Elemental-IRCd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elemental-IRCd/subscriptions","organizations_url":"https://api.github.com/users/Elemental-IRCd/orgs","repos_url":"https://api.github.com/users/Elemental-IRCd/repos","events_url":"https://api.github.com/users/Elemental-IRCd/events{/privacy}","received_events_url":"https://api.github.com/users/Elemental-IRCd/received_events","type":"Organization","site_admin":false},"repo":{"id":13966675,"name":"elemental-ircd","full_name":"Elemental-IRCd/elemental-ircd","owner":{"login":"Elemental-IRCd","id":6687466,"avatar_url":"https://avatars.githubusercontent.com/u/6687466?v=3","gravatar_id":"","url":"https://api.github.com/users/Elemental-IRCd","html_url":"https://github.com/Elemental-IRCd","followers_url":"https://api.github.com/users/Elemental-IRCd/followers","following_url":"https://api.github.com/users/Elemental-IRCd/following{/other_user}","gists_url":"https://api.github.com/users/Elemental-IRCd/gists{/gist_id}","starred_url":"https://api.github.com/users/Elemental-IRCd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elemental-IRCd/subscriptions","organizations_url":"https://api.github.com/users/Elemental-IRCd/orgs","repos_url":"https://api.github.com/users/Elemental-IRCd/repos","events_url":"https://api.github.com/users/Elemental-IRCd/events{/privacy}","received_events_url":"https://api.github.com/users/Elemental-IRCd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elemental-IRCd/elemental-ircd","description":"Continuation of ShadowIRCD to meet people's needs","fork":false,"url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd","forks_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/forks","keys_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/teams","hooks_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/hooks","issue_events_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues/events{/number}","events_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/events","assignees_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/assignees{/user}","branches_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/branches{/branch}","tags_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/tags","blobs_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/statuses/{sha}","languages_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/languages","stargazers_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/stargazers","contributors_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/contributors","subscribers_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/subscribers","subscription_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/subscription","commits_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/contents/{+path}","compare_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/merges","archive_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/downloads","issues_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues{/number}","pulls_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls{/number}","milestones_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/milestones{/number}","notifications_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/labels{/name}","releases_url":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/releases{/id}","created_at":"2013-10-29T19:46:32Z","updated_at":"2015-04-03T05:38:34Z","pushed_at":"2015-04-03T21:42:40Z","git_url":"git://github.com/Elemental-IRCd/elemental-ircd.git","ssh_url":"git@github.com:Elemental-IRCd/elemental-ircd.git","clone_url":"https://github.com/Elemental-IRCd/elemental-ircd.git","svn_url":"https://github.com/Elemental-IRCd/elemental-ircd","homepage":"","size":8969,"stargazers_count":18,"watchers_count":18,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":22,"forks":14,"open_issues":22,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66"},"html":{"href":"https://github.com/Elemental-IRCd/elemental-ircd/pull/66"},"issue":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues/66"},"comments":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/Elemental-IRCd/elemental-ircd/statuses/badf3bb11e37e4bcfe2468bda970a4763f4ba332"}}}}