{"action":"created","comment":{"url":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments/43984528","id":43984528,"diff_hunk":"@@ -156,25 +154,14 @@ window.ContactsExporter = function ContactsExporter(theStrategy) {\n   };\n \n   //\n-  // Based on the strategy configure the progress display to show a\n-  // determinative or indeterminate ui depending on the strategy\n-  //\n-  var _configureProgress = function _configureProgress() {\n-    determinativeProgress =\n-      strategy.hasDeterminativeProgress !== undefined &&\n-      strategy.hasDeterminativeProgress();\n-  };\n-\n-  //\n   // Shows the progress dialog based on the\n   //\n   var _displayProgress = function _displayProgress() {\n-    var progressClass = determinativeProgress ? 'progressBar' : 'spinner';\n \n     Contacts.utility('Overlay', function _loaded() {\n       progress = utils.overlay.show(\n         strategy.getExportTitle(),\n-        progressClass,\n+        true,","path":"apps/communications/contacts/js/export/contacts_exporter.js","position":39,"original_position":39,"commit_id":"5eaf4d07f06ecc89d16c5e6418a80487dbb0e132","original_commit_id":"5eaf4d07f06ecc89d16c5e6418a80487dbb0e132","user":{"login":"egorlevichev","id":7557901,"avatar_url":"https://avatars.githubusercontent.com/u/7557901?v=3","gravatar_id":"","url":"https://api.github.com/users/egorlevichev","html_url":"https://github.com/egorlevichev","followers_url":"https://api.github.com/users/egorlevichev/followers","following_url":"https://api.github.com/users/egorlevichev/following{/other_user}","gists_url":"https://api.github.com/users/egorlevichev/gists{/gist_id}","starred_url":"https://api.github.com/users/egorlevichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egorlevichev/subscriptions","organizations_url":"https://api.github.com/users/egorlevichev/orgs","repos_url":"https://api.github.com/users/egorlevichev/repos","events_url":"https://api.github.com/users/egorlevichev/events{/privacy}","received_events_url":"https://api.github.com/users/egorlevichev/received_events","type":"User","site_admin":false},"body":"ok, but it's still wrong to use Boolean value instead of String. You calling function ``utils.overlay.show()`` here, it have following signature: ``function show(messageId, progressClass, textId)`` and according to source code expected values for ``progressClass`` parameter are: ``'spinner', 'activityBar', 'progressActivity', 'progressBar'``. So in case if you are not going to refactor shared component which implements this overlay, you shall pass ``'progressBar'`` value.","created_at":"2015-11-05T07:49:50Z","updated_at":"2015-11-05T07:49:50Z","html_url":"https://github.com/harman-red-square/gaia/pull/20#discussion_r43984528","pull_request_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments/43984528"},"html":{"href":"https://github.com/harman-red-square/gaia/pull/20#discussion_r43984528"},"pull_request":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/harman-red-square/gaia/pulls/20","id":49418697,"html_url":"https://github.com/harman-red-square/gaia/pull/20","diff_url":"https://github.com/harman-red-square/gaia/pull/20.diff","patch_url":"https://github.com/harman-red-square/gaia/pull/20.patch","issue_url":"https://api.github.com/repos/harman-red-square/gaia/issues/20","number":20,"state":"open","locked":false,"title":"Bug 1210314 - Settings: Initial Change on Visual Design","user":{"login":"Vinay18Mishra","id":14883929,"avatar_url":"https://avatars.githubusercontent.com/u/14883929?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinay18Mishra","html_url":"https://github.com/Vinay18Mishra","followers_url":"https://api.github.com/users/Vinay18Mishra/followers","following_url":"https://api.github.com/users/Vinay18Mishra/following{/other_user}","gists_url":"https://api.github.com/users/Vinay18Mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinay18Mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinay18Mishra/subscriptions","organizations_url":"https://api.github.com/users/Vinay18Mishra/orgs","repos_url":"https://api.github.com/users/Vinay18Mishra/repos","events_url":"https://api.github.com/users/Vinay18Mishra/events{/privacy}","received_events_url":"https://api.github.com/users/Vinay18Mishra/received_events","type":"User","site_admin":false},"body":"Initial Visual Design Changes:\r\n\t1.\tapps/settings/elements/about.html\r\n\t⁃\tChange <p> to <Span>, is same as VD. \r\n\t2.\tapps/settings/style/lists.css\r\n\t3.\tapps/settings/style/screen_lock.css\r\n\t4.\tapps/settings/style/settings.css\r\n\t5.\tapps/system/style/edges/edges.css\r\n\t6.\tshared/style/buttons.css\r\n\t7.\tshared/style/headers.css\r\n\t8.\tshared/style/value_selector.css\r\n\t⁃\tChange in Font Size, style, width and etc \r\n\t9.\tshared/style/switches.css\r\n\t⁃\tchange the on/ off to capital letter, font and style.\r\n\t10.\tshared/elements/gaia-header/dist/gaia-header.js \r\n\t11.\tshared/elements/gaia-header/gaia-header.js \r\n\t12.\tshared/elements/gaia-theme/gaia-theme.css \r\n\t⁃\tChange in gaia-header as  per VD, changes are like background color, back arrow style, Gaia-Header height and etc, \r\n\r\nBug 1210314- App Settings implementation Fixes:\r\n\t⁃\tapps/communications/contacts/js/export/bt.js\r\n\t⁃\tWe have removed this function and initialise this value, wherever we needed as per UX.\r\n@Ashish-Developer @pgmanutd ","created_at":"2015-11-02T11:03:31Z","updated_at":"2015-11-05T07:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77054a04d1297c8b10a0a27fd59b075252ed61bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/20/commits","review_comments_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/20/comments","review_comment_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harman-red-square/gaia/issues/20/comments","statuses_url":"https://api.github.com/repos/harman-red-square/gaia/statuses/5eaf4d07f06ecc89d16c5e6418a80487dbb0e132","head":{"label":"Vinay18Mishra:bug-1210314-settings","ref":"bug-1210314-settings","sha":"5eaf4d07f06ecc89d16c5e6418a80487dbb0e132","user":{"login":"Vinay18Mishra","id":14883929,"avatar_url":"https://avatars.githubusercontent.com/u/14883929?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinay18Mishra","html_url":"https://github.com/Vinay18Mishra","followers_url":"https://api.github.com/users/Vinay18Mishra/followers","following_url":"https://api.github.com/users/Vinay18Mishra/following{/other_user}","gists_url":"https://api.github.com/users/Vinay18Mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinay18Mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinay18Mishra/subscriptions","organizations_url":"https://api.github.com/users/Vinay18Mishra/orgs","repos_url":"https://api.github.com/users/Vinay18Mishra/repos","events_url":"https://api.github.com/users/Vinay18Mishra/events{/privacy}","received_events_url":"https://api.github.com/users/Vinay18Mishra/received_events","type":"User","site_admin":false},"repo":{"id":45379273,"name":"gaia","full_name":"Vinay18Mishra/gaia","owner":{"login":"Vinay18Mishra","id":14883929,"avatar_url":"https://avatars.githubusercontent.com/u/14883929?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinay18Mishra","html_url":"https://github.com/Vinay18Mishra","followers_url":"https://api.github.com/users/Vinay18Mishra/followers","following_url":"https://api.github.com/users/Vinay18Mishra/following{/other_user}","gists_url":"https://api.github.com/users/Vinay18Mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinay18Mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinay18Mishra/subscriptions","organizations_url":"https://api.github.com/users/Vinay18Mishra/orgs","repos_url":"https://api.github.com/users/Vinay18Mishra/repos","events_url":"https://api.github.com/users/Vinay18Mishra/events{/privacy}","received_events_url":"https://api.github.com/users/Vinay18Mishra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vinay18Mishra/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/Vinay18Mishra/gaia","forks_url":"https://api.github.com/repos/Vinay18Mishra/gaia/forks","keys_url":"https://api.github.com/repos/Vinay18Mishra/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vinay18Mishra/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vinay18Mishra/gaia/teams","hooks_url":"https://api.github.com/repos/Vinay18Mishra/gaia/hooks","issue_events_url":"https://api.github.com/repos/Vinay18Mishra/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/Vinay18Mishra/gaia/events","assignees_url":"https://api.github.com/repos/Vinay18Mishra/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/Vinay18Mishra/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/Vinay18Mishra/gaia/tags","blobs_url":"https://api.github.com/repos/Vinay18Mishra/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vinay18Mishra/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vinay18Mishra/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vinay18Mishra/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vinay18Mishra/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/Vinay18Mishra/gaia/languages","stargazers_url":"https://api.github.com/repos/Vinay18Mishra/gaia/stargazers","contributors_url":"https://api.github.com/repos/Vinay18Mishra/gaia/contributors","subscribers_url":"https://api.github.com/repos/Vinay18Mishra/gaia/subscribers","subscription_url":"https://api.github.com/repos/Vinay18Mishra/gaia/subscription","commits_url":"https://api.github.com/repos/Vinay18Mishra/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vinay18Mishra/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vinay18Mishra/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vinay18Mishra/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vinay18Mishra/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/Vinay18Mishra/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vinay18Mishra/gaia/merges","archive_url":"https://api.github.com/repos/Vinay18Mishra/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vinay18Mishra/gaia/downloads","issues_url":"https://api.github.com/repos/Vinay18Mishra/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/Vinay18Mishra/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/Vinay18Mishra/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/Vinay18Mishra/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vinay18Mishra/gaia/labels{/name}","releases_url":"https://api.github.com/repos/Vinay18Mishra/gaia/releases{/id}","created_at":"2015-11-02T07:40:09Z","updated_at":"2015-11-02T07:41:16Z","pushed_at":"2015-11-03T11:58:19Z","git_url":"git://github.com/Vinay18Mishra/gaia.git","ssh_url":"git@github.com:Vinay18Mishra/gaia.git","clone_url":"https://github.com/Vinay18Mishra/gaia.git","svn_url":"https://github.com/Vinay18Mishra/gaia","homepage":"https://wiki.mozilla.org/B2G","size":962842,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v2.2r"}},"base":{"label":"harman-red-square:bug-1210314-settings","ref":"bug-1210314-settings","sha":"f00a0491c7751609191650a5401ec38db874e333","user":{"login":"harman-red-square","id":14936980,"avatar_url":"https://avatars.githubusercontent.com/u/14936980?v=3","gravatar_id":"","url":"https://api.github.com/users/harman-red-square","html_url":"https://github.com/harman-red-square","followers_url":"https://api.github.com/users/harman-red-square/followers","following_url":"https://api.github.com/users/harman-red-square/following{/other_user}","gists_url":"https://api.github.com/users/harman-red-square/gists{/gist_id}","starred_url":"https://api.github.com/users/harman-red-square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harman-red-square/subscriptions","organizations_url":"https://api.github.com/users/harman-red-square/orgs","repos_url":"https://api.github.com/users/harman-red-square/repos","events_url":"https://api.github.com/users/harman-red-square/events{/privacy}","received_events_url":"https://api.github.com/users/harman-red-square/received_events","type":"Organization","site_admin":false},"repo":{"id":43541057,"name":"gaia","full_name":"harman-red-square/gaia","owner":{"login":"harman-red-square","id":14936980,"avatar_url":"https://avatars.githubusercontent.com/u/14936980?v=3","gravatar_id":"","url":"https://api.github.com/users/harman-red-square","html_url":"https://github.com/harman-red-square","followers_url":"https://api.github.com/users/harman-red-square/followers","following_url":"https://api.github.com/users/harman-red-square/following{/other_user}","gists_url":"https://api.github.com/users/harman-red-square/gists{/gist_id}","starred_url":"https://api.github.com/users/harman-red-square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harman-red-square/subscriptions","organizations_url":"https://api.github.com/users/harman-red-square/orgs","repos_url":"https://api.github.com/users/harman-red-square/repos","events_url":"https://api.github.com/users/harman-red-square/events{/privacy}","received_events_url":"https://api.github.com/users/harman-red-square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harman-red-square/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/harman-red-square/gaia","forks_url":"https://api.github.com/repos/harman-red-square/gaia/forks","keys_url":"https://api.github.com/repos/harman-red-square/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harman-red-square/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harman-red-square/gaia/teams","hooks_url":"https://api.github.com/repos/harman-red-square/gaia/hooks","issue_events_url":"https://api.github.com/repos/harman-red-square/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/harman-red-square/gaia/events","assignees_url":"https://api.github.com/repos/harman-red-square/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/harman-red-square/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/harman-red-square/gaia/tags","blobs_url":"https://api.github.com/repos/harman-red-square/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harman-red-square/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harman-red-square/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/harman-red-square/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harman-red-square/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/harman-red-square/gaia/languages","stargazers_url":"https://api.github.com/repos/harman-red-square/gaia/stargazers","contributors_url":"https://api.github.com/repos/harman-red-square/gaia/contributors","subscribers_url":"https://api.github.com/repos/harman-red-square/gaia/subscribers","subscription_url":"https://api.github.com/repos/harman-red-square/gaia/subscription","commits_url":"https://api.github.com/repos/harman-red-square/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/harman-red-square/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/harman-red-square/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/harman-red-square/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/harman-red-square/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/harman-red-square/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harman-red-square/gaia/merges","archive_url":"https://api.github.com/repos/harman-red-square/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harman-red-square/gaia/downloads","issues_url":"https://api.github.com/repos/harman-red-square/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/harman-red-square/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/harman-red-square/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/harman-red-square/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harman-red-square/gaia/labels{/name}","releases_url":"https://api.github.com/repos/harman-red-square/gaia/releases{/id}","created_at":"2015-10-02T07:40:12Z","updated_at":"2015-10-06T11:18:30Z","pushed_at":"2015-11-05T07:31:54Z","git_url":"git://github.com/harman-red-square/gaia.git","ssh_url":"git@github.com:harman-red-square/gaia.git","clone_url":"https://github.com/harman-red-square/gaia.git","svn_url":"https://github.com/harman-red-square/gaia","homepage":"https://wiki.mozilla.org/B2G","size":963746,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":7,"forks":33,"open_issues":7,"watchers":0,"default_branch":"v2.2r"}},"_links":{"self":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/20"},"html":{"href":"https://github.com/harman-red-square/gaia/pull/20"},"issue":{"href":"https://api.github.com/repos/harman-red-square/gaia/issues/20"},"comments":{"href":"https://api.github.com/repos/harman-red-square/gaia/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/harman-red-square/gaia/statuses/5eaf4d07f06ecc89d16c5e6418a80487dbb0e132"}}}}