{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/33714920","id":33714920,"diff_hunk":"@@ -78,7 +78,7 @@\n \t\t\t<arg value=\"-d\" />\n \t\t\t<arg path=\"${basedir}/libraries/cms/,${basedir}/libraries/joomla/,${basedir}/libraries/legacy/,${basedir}/libraries/vendor/joomla/\" />\n \t\t\t<arg value=\"-f\" />\n-\t\t\t<arg path=\"${basedir}/libraries/loader.php,${basedir}/libraries/platform.php,${basedir}/libraries/classloader.php\" />\n+\t\t\t<arg path=\"${basedir}/libraries/loader.php,${basedir}/libraries/platform.php,${basedir}/libraries/cms/class/loader.php\" />","path":"build.xml","position":5,"original_position":5,"commit_id":"4bc72d763df62beb01305dbdb3e513d2ffacc7f0","original_commit_id":"4bc72d763df62beb01305dbdb3e513d2ffacc7f0","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"body":"You can remove the file completely.  The `phpdoc` command here scans directories specified in the `-d` switch and includes files specified with the `-f` switch that aren't in those directories.  Since you've moved the file to a location that's already included with the directory switch it isn't needed in the file switch anymore.","created_at":"2015-07-01T19:25:21Z","updated_at":"2015-07-01T19:25:21Z","html_url":"https://github.com/joomla/joomla-cms/pull/7307#discussion_r33714920","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/33714920"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/7307#discussion_r33714920"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307","id":39016123,"html_url":"https://github.com/joomla/joomla-cms/pull/7307","diff_url":"https://github.com/joomla/joomla-cms/pull/7307.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7307.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7307","number":7307,"state":"open","locked":false,"title":"Moving JClassLoader and delete the old files","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"body":"This is a fix for #7296 \r\n\r\n### Issue\r\nThe renaming of the ClassLoader.php to classloader.php done in #6335 had some interesting effects on Linux and Centos systems which in some case even broke the CMS.\r\n\r\n### Solution\r\nSince we don't really know what happend with the files (some OS renamed the new file and leave the old alone, some overwrite it, some have both the new and old one) the most secure thing is to move the file to a new place and delete the old ones.\r\nThis also has the advantage that the new place is autoloadable.\r\n\r\n### Testing\r\nApply patch and make sure the CMS still works.\r\nRename (or delete) the following files if present and make sure the CMS still works.\r\n\r\n* libraries/ClassLoader.php\r\n* libraries/classloader.php\r\n\r\nI'm not sure how we can test the updater script which removes the files, but I don't expect an issue there.\r\nI'm also not sure what the change in the build.xml really does. I just adjusted the path there to match the new place.\r\n\r\n","created_at":"2015-07-01T19:23:31Z","updated_at":"2015-07-01T19:25:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9742735a3496a7a46a166debe522e4d66cd91318","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7307/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/4bc72d763df62beb01305dbdb3e513d2ffacc7f0","head":{"label":"Bakual:MoveClassLoader","ref":"MoveClassLoader","sha":"4bc72d763df62beb01305dbdb3e513d2ffacc7f0","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"repo":{"id":5132763,"name":"joomla-cms","full_name":"Bakual/joomla-cms","owner":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bakual/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Bakual/joomla-cms","forks_url":"https://api.github.com/repos/Bakual/joomla-cms/forks","keys_url":"https://api.github.com/repos/Bakual/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bakual/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bakual/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Bakual/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Bakual/joomla-cms/events","assignees_url":"https://api.github.com/repos/Bakual/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Bakual/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Bakual/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bakual/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bakual/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bakual/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Bakual/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Bakual/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Bakual/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Bakual/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Bakual/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Bakual/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bakual/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bakual/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bakual/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Bakual/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bakual/joomla-cms/merges","archive_url":"https://api.github.com/repos/Bakual/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bakual/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Bakual/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Bakual/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Bakual/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Bakual/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bakual/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Bakual/joomla-cms/releases{/id}","created_at":"2012-07-21T10:15:11Z","updated_at":"2015-04-24T10:32:58Z","pushed_at":"2015-07-01T19:20:39Z","git_url":"git://github.com/Bakual/joomla-cms.git","ssh_url":"git@github.com:Bakual/joomla-cms.git","clone_url":"https://github.com/Bakual/joomla-cms.git","svn_url":"https://github.com/Bakual/joomla-cms","homepage":"http://joomla.org","size":132088,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"b75ab38b9f9cada8a1c16d60adc4d938975a74b4","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-07-01T10:21:11Z","pushed_at":"2015-07-01T19:23:32Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":329081,"stargazers_count":1587,"watchers_count":1587,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1763,"mirror_url":null,"open_issues_count":569,"forks":1763,"open_issues":569,"watchers":1587,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/7307"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7307"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7307/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7307/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/4bc72d763df62beb01305dbdb3e513d2ffacc7f0"}}}}