{"action":"created","issue":{"url":"https://api.github.com/repos/handsoncode-apps/InvoiceDemo/issues/32","labels_url":"https://api.github.com/repos/handsoncode-apps/InvoiceDemo/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/handsoncode-apps/InvoiceDemo/issues/32/comments","events_url":"https://api.github.com/repos/handsoncode-apps/InvoiceDemo/issues/32/events","html_url":"https://github.com/handsoncode-apps/InvoiceDemo/issues/32","id":122959155,"number":32,"title":"Remove row button removes the last row, but should remove selected row","user":{"login":"miyconst","id":6435556,"avatar_url":"https://avatars.githubusercontent.com/u/6435556?v=3","gravatar_id":"","url":"https://api.github.com/users/miyconst","html_url":"https://github.com/miyconst","followers_url":"https://api.github.com/users/miyconst/followers","following_url":"https://api.github.com/users/miyconst/following{/other_user}","gists_url":"https://api.github.com/users/miyconst/gists{/gist_id}","starred_url":"https://api.github.com/users/miyconst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyconst/subscriptions","organizations_url":"https://api.github.com/users/miyconst/orgs","repos_url":"https://api.github.com/users/miyconst/repos","events_url":"https://api.github.com/users/miyconst/events{/privacy}","received_events_url":"https://api.github.com/users/miyconst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-18T14:36:52Z","updated_at":"2015-12-22T15:28:57Z","closed_at":null,"body":"Currently remove row button removes the last row.\r\n\r\nIf there is more than one page of rows, it is not visible, if something were made at all.\r\nThe last, not visible row got silently deleted, that is all.\r\n\r\nThe selected row should be removed instead of the last one."},"comment":{"url":"https://api.github.com/repos/handsoncode-apps/InvoiceDemo/issues/comments/166646700","html_url":"https://github.com/handsoncode-apps/InvoiceDemo/issues/32#issuecomment-166646700","issue_url":"https://api.github.com/repos/handsoncode-apps/InvoiceDemo/issues/32","id":166646700,"user":{"login":"miyconst","id":6435556,"avatar_url":"https://avatars.githubusercontent.com/u/6435556?v=3","gravatar_id":"","url":"https://api.github.com/users/miyconst","html_url":"https://github.com/miyconst","followers_url":"https://api.github.com/users/miyconst/followers","following_url":"https://api.github.com/users/miyconst/following{/other_user}","gists_url":"https://api.github.com/users/miyconst/gists{/gist_id}","starred_url":"https://api.github.com/users/miyconst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyconst/subscriptions","organizations_url":"https://api.github.com/users/miyconst/orgs","repos_url":"https://api.github.com/users/miyconst/repos","events_url":"https://api.github.com/users/miyconst/events{/privacy}","received_events_url":"https://api.github.com/users/miyconst/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T15:28:57Z","updated_at":"2015-12-22T15:28:57Z","body":"@krzysztofspilka, those are good ideas for a production application, but this is a demo sample. That is why I would like to keep the features.\r\n\r\nThe [Remove] button is a duplicate of the context menu, and might not be presented in the real applications, but many systems still use this UI pattern, especially for tablets, where context menu is not that intuitive.\r\n\r\nThe [Page limit] default value could be moved to settings, and would be nice to see it there. But the select-box should be on the page as well.\r\n\r\nThe [Min spare row] value is very application specific, many systems would prefer to be able to remove all rows. So, you can move this value to settings.\r\n\r\nI like the settings idea, but I would like to finish what we have now before adding some more features."}}