{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments/30723525","id":30723525,"diff_hunk":"@@ -27,7 +28,16 @@ axs.AuditRules.addRule({\n             !axs.utils.isElementOrAncestorHidden(element);\n     },\n     test: function(image) {\n-        return (!image.hasAttribute('alt') && image.getAttribute('role') != 'presentation');\n+        var imageIsPresentational = (image.hasAttribute('alt') && image.alt == \"\") || image.getAttribute('role') == 'presentation';\n+        if (imageIsPresentational)\n+            return false;\n+        var textAlternatives = axs.properties.getTextProperties(image);\n+        if (!textAlternatives)\n+            return true;\n+        // filename is only present if no other option found","path":"src/audits/ImageWithoutAltText.js","position":null,"original_position":25,"commit_id":"03a30222a67503269697cccf7e033209fc66a4d4","original_commit_id":"53b3457249ecb47aee29d1cd66ad90a2815a36ad","user":{"login":"alice","id":95208,"avatar_url":"https://avatars.githubusercontent.com/u/95208?v=3","gravatar_id":"","url":"https://api.github.com/users/alice","html_url":"https://github.com/alice","followers_url":"https://api.github.com/users/alice/followers","following_url":"https://api.github.com/users/alice/following{/other_user}","gists_url":"https://api.github.com/users/alice/gists{/gist_id}","starred_url":"https://api.github.com/users/alice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alice/subscriptions","organizations_url":"https://api.github.com/users/alice/orgs","repos_url":"https://api.github.com/users/alice/repos","events_url":"https://api.github.com/users/alice/events{/privacy}","received_events_url":"https://api.github.com/users/alice/received_events","type":"User","site_admin":false},"body":"It was explaining the \"why\" for the following line, but I've since cleaned up the logic so it's no longer necessary.","created_at":"2015-05-20T16:56:21Z","updated_at":"2015-05-20T16:56:21Z","html_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/155#discussion_r30723525","pull_request_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments/30723525"},"html":{"href":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/155#discussion_r30723525"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155","id":35795584,"html_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/155","diff_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/155.diff","patch_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/155.patch","issue_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/155","number":155,"state":"open","locked":false,"title":"Check for any text alternatives when assessing unlabeled images","user":{"login":"alice","id":95208,"avatar_url":"https://avatars.githubusercontent.com/u/95208?v=3","gravatar_id":"","url":"https://api.github.com/users/alice","html_url":"https://github.com/alice","followers_url":"https://api.github.com/users/alice/followers","following_url":"https://api.github.com/users/alice/following{/other_user}","gists_url":"https://api.github.com/users/alice/gists{/gist_id}","starred_url":"https://api.github.com/users/alice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alice/subscriptions","organizations_url":"https://api.github.com/users/alice/orgs","repos_url":"https://api.github.com/users/alice/repos","events_url":"https://api.github.com/users/alice/events{/privacy}","received_events_url":"https://api.github.com/users/alice/received_events","type":"User","site_admin":false},"body":"Fixes #154\r\n\r\n@ckundo or @RickSBrown PTAL","created_at":"2015-05-20T03:34:37Z","updated_at":"2015-05-20T16:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c96bfea641991afcffb66d450c42b7596d33726","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/155/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/statuses/03a30222a67503269697cccf7e033209fc66a4d4","head":{"label":"alice:images","ref":"images","sha":"03a30222a67503269697cccf7e033209fc66a4d4","user":{"login":"alice","id":95208,"avatar_url":"https://avatars.githubusercontent.com/u/95208?v=3","gravatar_id":"","url":"https://api.github.com/users/alice","html_url":"https://github.com/alice","followers_url":"https://api.github.com/users/alice/followers","following_url":"https://api.github.com/users/alice/following{/other_user}","gists_url":"https://api.github.com/users/alice/gists{/gist_id}","starred_url":"https://api.github.com/users/alice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alice/subscriptions","organizations_url":"https://api.github.com/users/alice/orgs","repos_url":"https://api.github.com/users/alice/repos","events_url":"https://api.github.com/users/alice/events{/privacy}","received_events_url":"https://api.github.com/users/alice/received_events","type":"User","site_admin":false},"repo":{"id":11849690,"name":"accessibility-developer-tools","full_name":"alice/accessibility-developer-tools","owner":{"login":"alice","id":95208,"avatar_url":"https://avatars.githubusercontent.com/u/95208?v=3","gravatar_id":"","url":"https://api.github.com/users/alice","html_url":"https://github.com/alice","followers_url":"https://api.github.com/users/alice/followers","following_url":"https://api.github.com/users/alice/following{/other_user}","gists_url":"https://api.github.com/users/alice/gists{/gist_id}","starred_url":"https://api.github.com/users/alice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alice/subscriptions","organizations_url":"https://api.github.com/users/alice/orgs","repos_url":"https://api.github.com/users/alice/repos","events_url":"https://api.github.com/users/alice/events{/privacy}","received_events_url":"https://api.github.com/users/alice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alice/accessibility-developer-tools","description":"","fork":true,"url":"https://api.github.com/repos/alice/accessibility-developer-tools","forks_url":"https://api.github.com/repos/alice/accessibility-developer-tools/forks","keys_url":"https://api.github.com/repos/alice/accessibility-developer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alice/accessibility-developer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alice/accessibility-developer-tools/teams","hooks_url":"https://api.github.com/repos/alice/accessibility-developer-tools/hooks","issue_events_url":"https://api.github.com/repos/alice/accessibility-developer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/alice/accessibility-developer-tools/events","assignees_url":"https://api.github.com/repos/alice/accessibility-developer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/alice/accessibility-developer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/alice/accessibility-developer-tools/tags","blobs_url":"https://api.github.com/repos/alice/accessibility-developer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alice/accessibility-developer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alice/accessibility-developer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/alice/accessibility-developer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alice/accessibility-developer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/alice/accessibility-developer-tools/languages","stargazers_url":"https://api.github.com/repos/alice/accessibility-developer-tools/stargazers","contributors_url":"https://api.github.com/repos/alice/accessibility-developer-tools/contributors","subscribers_url":"https://api.github.com/repos/alice/accessibility-developer-tools/subscribers","subscription_url":"https://api.github.com/repos/alice/accessibility-developer-tools/subscription","commits_url":"https://api.github.com/repos/alice/accessibility-developer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/alice/accessibility-developer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/alice/accessibility-developer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/alice/accessibility-developer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/alice/accessibility-developer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/alice/accessibility-developer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alice/accessibility-developer-tools/merges","archive_url":"https://api.github.com/repos/alice/accessibility-developer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alice/accessibility-developer-tools/downloads","issues_url":"https://api.github.com/repos/alice/accessibility-developer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/alice/accessibility-developer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/alice/accessibility-developer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/alice/accessibility-developer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alice/accessibility-developer-tools/labels{/name}","releases_url":"https://api.github.com/repos/alice/accessibility-developer-tools/releases{/id}","created_at":"2013-08-02T18:17:18Z","updated_at":"2015-04-23T14:33:50Z","pushed_at":"2015-05-20T16:54:50Z","git_url":"git://github.com/alice/accessibility-developer-tools.git","ssh_url":"git@github.com:alice/accessibility-developer-tools.git","clone_url":"https://github.com/alice/accessibility-developer-tools.git","svn_url":"https://github.com/alice/accessibility-developer-tools","homepage":null,"size":1263,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"01fa36e55d2284b218cfe16ee7ed607e38a267a2","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":11378642,"name":"accessibility-developer-tools","full_name":"GoogleChrome/accessibility-developer-tools","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/accessibility-developer-tools","description":"","fork":false,"url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools","forks_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/forks","keys_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/events","assignees_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/merges","archive_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/releases{/id}","created_at":"2013-07-12T21:40:22Z","updated_at":"2015-05-20T03:34:03Z","pushed_at":"2015-05-20T16:54:50Z","git_url":"git://github.com/GoogleChrome/accessibility-developer-tools.git","ssh_url":"git@github.com:GoogleChrome/accessibility-developer-tools.git","clone_url":"https://github.com/GoogleChrome/accessibility-developer-tools.git","svn_url":"https://github.com/GoogleChrome/accessibility-developer-tools","homepage":"","size":1899,"stargazers_count":351,"watchers_count":351,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":36,"forks":54,"open_issues":36,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155"},"html":{"href":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/155"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/155"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/statuses/03a30222a67503269697cccf7e033209fc66a4d4"}}}}