{"action":"created","issue":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5639","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5639/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5639/comments","events_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5639/events","html_url":"https://github.com/OrchardCMS/Orchard/issues/5639","id":100868779,"number":5639,"title":"Make failing migrations disable dependent features","user":{"login":"Piedone","id":1976647,"avatar_url":"https://avatars.githubusercontent.com/u/1976647?v=3","gravatar_id":"","url":"https://api.github.com/users/Piedone","html_url":"https://github.com/Piedone","followers_url":"https://api.github.com/users/Piedone/followers","following_url":"https://api.github.com/users/Piedone/following{/other_user}","gists_url":"https://api.github.com/users/Piedone/gists{/gist_id}","starred_url":"https://api.github.com/users/Piedone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piedone/subscriptions","organizations_url":"https://api.github.com/users/Piedone/orgs","repos_url":"https://api.github.com/users/Piedone/repos","events_url":"https://api.github.com/users/Piedone/events{/privacy}","received_events_url":"https://api.github.com/users/Piedone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-13T21:01:43Z","updated_at":"2015-08-13T22:15:03Z","closed_at":null,"body":"When a migration step fails it certainly means that the feature is in an uncertain (but erroneous) state. IMO it's safe to assume here that features depending on the feature with the failed migration won't work properly. Thus I suggest that when a migration step fails all features depending on the feature of the migration be disabled.\r\n\r\nI'd imagine a FeatureManager.Disable() added to DataMigrationManager.Update()'s catch, with a corresponding log entry. Also maybe a warning on the Features screen: if there are features to be updated (i.e. those that have failed their automatic migration) there  could be warning that all dependent features were automatically disabled."},"comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/comments/130863998","html_url":"https://github.com/OrchardCMS/Orchard/issues/5639#issuecomment-130863998","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5639","id":130863998,"user":{"login":"Piedone","id":1976647,"avatar_url":"https://avatars.githubusercontent.com/u/1976647?v=3","gravatar_id":"","url":"https://api.github.com/users/Piedone","html_url":"https://github.com/Piedone","followers_url":"https://api.github.com/users/Piedone/followers","following_url":"https://api.github.com/users/Piedone/following{/other_user}","gists_url":"https://api.github.com/users/Piedone/gists{/gist_id}","starred_url":"https://api.github.com/users/Piedone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piedone/subscriptions","organizations_url":"https://api.github.com/users/Piedone/orgs","repos_url":"https://api.github.com/users/Piedone/repos","events_url":"https://api.github.com/users/Piedone/events{/privacy}","received_events_url":"https://api.github.com/users/Piedone/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T22:15:03Z","updated_at":"2015-08-13T22:15:03Z","body":"Yes, it's not about the transaction: it only rolls back the migration step. This issue is about the higher level: turning off depending features (even if they were already turned on a long time ago)."}}